[GitHub] spark pull request: [SPARK-12913] [SQL] Improve performance of sta...

2016-02-01 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/10960#discussion_r51535285 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/CentralMomentAgg.scala --- @@ -57,173 +55,170 @@ abstract class Cen

[GitHub] spark pull request: [SPARK-13114][SQL] Add a test for tokens more ...

2016-02-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11020#issuecomment-178432874 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13114][SQL] Add a test for tokens more ...

2016-02-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11020#issuecomment-178432870 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13135][SQL] Don't print expressions rec...

2016-02-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11019#issuecomment-178431864 **[Test build #50554 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50554/consoleFull)** for PR 11019 at commit [`2c2b007`](https://gi

[GitHub] spark pull request: [SPARK-12850] [SQL] Support Bucket Pruning (Pr...

2016-02-01 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/10942#discussion_r51534666 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/sources/BucketedReadSuite.scala --- @@ -59,6 +61,162 @@ class BucketedReadSuite extends QueryTest w

[GitHub] spark pull request: [SPARK-12913] [SQL] Improve performance of sta...

2016-02-01 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/10960#discussion_r51534597 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/CentralMomentAgg.scala --- @@ -57,173 +55,170 @@ abstract class Cen

[GitHub] spark pull request: [SPARK-13135][SQL] Don't print expressions rec...

2016-02-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11019#issuecomment-178429585 **[Test build #2489 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2489/consoleFull)** for PR 11019 at commit [`2c2b007`](https://g

[GitHub] spark pull request: [SPARK-12913] [SQL] Improve performance of sta...

2016-02-01 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/10960#discussion_r51534413 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/CentralMomentAgg.scala --- @@ -57,173 +55,170 @@ abstract class Cen

[GitHub] spark pull request: [SPARK-13135][SQL] Don't print expressions rec...

2016-02-01 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/11019#issuecomment-178428368 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enable

[GitHub] spark pull request: [SPARK-13135][SQL] Don't print expressions rec...

2016-02-01 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/11019#issuecomment-178428206 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-12913] [SQL] Improve performance of sta...

2016-02-01 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/10960#discussion_r51534391 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala --- @@ -436,3 +436,21 @@ case class Murmur3Hash(children: Seq[Expres

[GitHub] spark pull request: [SPARK-13135][SQL] Don't print expressions rec...

2016-02-01 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/11019#discussion_r51534316 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -36,11 +36,11 @@ import org.apache.spar

[GitHub] spark pull request: [SPARK-13114][SQL] Add a test for tokens more ...

2016-02-01 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/11020#discussion_r51534298 --- Diff: sql/core/src/test/resources/cars-malformed.csv --- @@ -0,0 +1,5 @@ +year,make,model,comment,blank --- End diff -- Sure. --- I

[GitHub] spark pull request: [SPARK-12913] [SQL] Improve performance of sta...

2016-02-01 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/10960#discussion_r51534252 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegen.scala --- @@ -244,7 +244,7 @@ case class WholeStageCodegen(plan: CodegenSu

[GitHub] spark pull request: [SPARK-12913] [SQL] Improve performance of sta...

2016-02-01 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/10960#discussion_r51534225 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala --- @@ -436,3 +436,21 @@ case class Murmur3Hash(children: Seq[Expr

[GitHub] spark pull request: [SPARK-12850] [SQL] Support Bucket Pruning (Pr...

2016-02-01 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/10942#discussion_r51534192 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/sources/BucketedReadSuite.scala --- @@ -59,6 +61,162 @@ class BucketedReadSuite extends QueryTest w

[GitHub] spark pull request: [SPARK-12850] [SQL] Support Bucket Pruning (Pr...

2016-02-01 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/10942#discussion_r51534171 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/sources/BucketedReadSuite.scala --- @@ -59,6 +61,162 @@ class BucketedReadSuite extends QueryTest w

[GitHub] spark pull request: [SPARK-12850] [SQL] Support Bucket Pruning (Pr...

2016-02-01 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/10942#discussion_r51534160 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/sources/BucketedReadSuite.scala --- @@ -59,6 +61,162 @@ class BucketedReadSuite extends QueryTest w

[GitHub] spark pull request: [SPARK-13135][SQL] Don't print expressions rec...

2016-02-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11019#issuecomment-178426158 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13135][SQL] Don't print expressions rec...

2016-02-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11019#issuecomment-178426117 **[Test build #50551 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50551/consoleFull)** for PR 11019 at commit [`2c2b007`](https://g

[GitHub] spark pull request: [SPARK-13135][SQL] Don't print expressions rec...

2016-02-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11019#issuecomment-178426154 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12913] [SQL] Improve performance of sta...

2016-02-01 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/10960#issuecomment-178426025 @davies I made one pass. It would be nice to have a JIRA for checking query result with tolerance on numerical differences, because the result might change (though unlik

[GitHub] spark pull request: [SPARK-13109][Build] Fix SBT publishLocal issu...

2016-02-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11001#issuecomment-178425918 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12850] [SQL] Support Bucket Pruning (Pr...

2016-02-01 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/10942#discussion_r51534053 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/sources/BucketedReadSuite.scala --- @@ -59,6 +61,162 @@ class BucketedReadSuite extends QueryTest wi

[GitHub] spark pull request: [SPARK-13114][SQL] Add a test for tokens more ...

2016-02-01 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11020#discussion_r51534060 --- Diff: sql/core/src/test/resources/cars-malformed.csv --- @@ -0,0 +1,5 @@ +year,make,model,comment,blank --- End diff -- might be good if we

[GitHub] spark pull request: [SPARK-13109][Build] Fix SBT publishLocal issu...

2016-02-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11001#issuecomment-178425921 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12913] [SQL] Improve performance of sta...

2016-02-01 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/10960#discussion_r51534054 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/CentralMomentAgg.scala --- @@ -57,173 +55,170 @@ abstract class Cen

[GitHub] spark pull request: [SPARK-13109][Build] Fix SBT publishLocal issu...

2016-02-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11001#issuecomment-178425637 **[Test build #50539 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50539/consoleFull)** for PR 11001 at commit [`fbed906`](https://g

[GitHub] spark pull request: [SPARK-12710][SQL]Create local CoGroup operato...

2016-02-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10662 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-12709][SQL]Create local Except operator

2016-02-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10661 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-13114][SQL] Add a test for tokens more ...

2016-02-01 Thread HyukjinKwon
GitHub user HyukjinKwon opened a pull request: https://github.com/apache/spark/pull/11020 [SPARK-13114][SQL] Add a test for tokens more than the fields in schema https://issues.apache.org/jira/browse/SPARK-13114 This PR adds a test for tokens more than the fields in schema.

[GitHub] spark pull request: [SPARK-12850] [SQL] Support Bucket Pruning (Pr...

2016-02-01 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/10942#discussion_r51533917 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/sources/BucketedReadSuite.scala --- @@ -59,6 +61,162 @@ class BucketedReadSuite extends QueryTest wi

[GitHub] spark pull request: [SPARK-12913] [SQL] Improve performance of sta...

2016-02-01 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/10960#discussion_r51533886 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/CentralMomentAgg.scala --- @@ -57,173 +55,170 @@ abstract class Cen

[GitHub] spark pull request: [SPARK-12913] [SQL] Improve performance of sta...

2016-02-01 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/10960#discussion_r51533870 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/CentralMomentAgg.scala --- @@ -57,173 +55,170 @@ abstract class Cen

[GitHub] spark pull request: [SPARK-12710][SQL]Create local CoGroup operato...

2016-02-01 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/10662#issuecomment-178424564 note: i'm going to close this one as later too but we will revisit after Spark 2.0. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-12913] [SQL] Improve performance of sta...

2016-02-01 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/10960#discussion_r51533802 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/BenchmarkWholeStageCodegen.scala --- @@ -59,6 +59,55 @@ class BenchmarkWholeStageCodegen ext

[GitHub] spark pull request: [SPARK-12913] [SQL] Improve performance of sta...

2016-02-01 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/10960#discussion_r51533807 --- Diff: sql/hive/compatibility/src/test/scala/org/apache/spark/sql/hive/execution/HiveCompatibilitySuite.scala --- @@ -325,6 +325,10 @@ class HiveCompatibi

[GitHub] spark pull request: [SPARK-12913] [SQL] Improve performance of sta...

2016-02-01 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/10960#discussion_r51533812 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/WindowQuerySuite.scala --- @@ -133,44 +133,44 @@ class WindowQuerySuite extends QueryTe

[GitHub] spark pull request: [SPARK-12913] [SQL] Improve performance of sta...

2016-02-01 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/10960#discussion_r51533797 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/BenchmarkWholeStageCodegen.scala --- @@ -59,6 +59,55 @@ class BenchmarkWholeStageCodegen ext

[GitHub] spark pull request: [SPARK-12913] [SQL] Improve performance of sta...

2016-02-01 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/10960#discussion_r51533804 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/BenchmarkWholeStageCodegen.scala --- @@ -148,7 +197,8 @@ class BenchmarkWholeStageCodegen ex

[GitHub] spark pull request: [SPARK-12913] [SQL] Improve performance of sta...

2016-02-01 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/10960#discussion_r51533793 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/Window.scala --- @@ -198,7 +198,8 @@ case class Window( functions,

[GitHub] spark pull request: [SPARK-12913] [SQL] Improve performance of sta...

2016-02-01 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/10960#discussion_r51533775 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Corr.scala --- @@ -29,165 +28,95 @@ import org.apache.spark.sql.typ

[GitHub] spark pull request: [SPARK-12913] [SQL] Improve performance of sta...

2016-02-01 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/10960#discussion_r51533764 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/CentralMomentAgg.scala --- @@ -57,173 +55,170 @@ abstract class Cen

[GitHub] spark pull request: [SPARK-12913] [SQL] Improve performance of sta...

2016-02-01 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/10960#discussion_r51533758 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/CentralMomentAgg.scala --- @@ -57,173 +55,170 @@ abstract class Cen

[GitHub] spark pull request: [SPARK-12913] [SQL] Improve performance of sta...

2016-02-01 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/10960#discussion_r51533751 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/CentralMomentAgg.scala --- @@ -57,173 +55,170 @@ abstract class Cen

[GitHub] spark pull request: [SPARK-12913] [SQL] Improve performance of sta...

2016-02-01 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/10960#discussion_r51533788 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala --- @@ -436,3 +436,21 @@ case class Murmur3Hash(children: Seq[Expr

[GitHub] spark pull request: [SPARK-12709][SQL]Create local Except operator

2016-02-01 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/10661#issuecomment-178423933 @mwws thanks for submitting a patch on this. After thinking more about the ticket, I think we won't need it anymore as long as we implement anti-join, and rewrite except u

[GitHub] spark pull request: [SPARK-12913] [SQL] Improve performance of sta...

2016-02-01 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/10960#discussion_r51533782 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Covariance.scala --- @@ -28,171 +26,90 @@ import org.apache.spark.s

[GitHub] spark pull request: [SPARK-12913] [SQL] Improve performance of sta...

2016-02-01 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/10960#discussion_r51533777 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Corr.scala --- @@ -29,165 +28,95 @@ import org.apache.spark.sql.typ

[GitHub] spark pull request: [SPARK-12913] [SQL] Improve performance of sta...

2016-02-01 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/10960#discussion_r51533778 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Corr.scala --- @@ -29,165 +28,95 @@ import org.apache.spark.sql.typ

[GitHub] spark pull request: [SPARK-12913] [SQL] Improve performance of sta...

2016-02-01 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/10960#discussion_r51533789 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegen.scala --- @@ -244,7 +244,7 @@ case class WholeStageCodegen(plan: CodegenSu

[GitHub] spark pull request: [SPARK-12913] [SQL] Improve performance of sta...

2016-02-01 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/10960#discussion_r51533776 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Corr.scala --- @@ -29,165 +28,95 @@ import org.apache.spark.sql.typ

[GitHub] spark pull request: [SPARK-12913] [SQL] Improve performance of sta...

2016-02-01 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/10960#discussion_r51533740 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/CentralMomentAgg.scala --- @@ -57,173 +55,170 @@ abstract class Cen

[GitHub] spark pull request: [SPARK-12913] [SQL] Improve performance of sta...

2016-02-01 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/10960#discussion_r51533703 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/CentralMomentAgg.scala --- @@ -57,173 +55,170 @@ abstract class Cen

[GitHub] spark pull request: [SPARK-12913] [SQL] Improve performance of sta...

2016-02-01 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/10960#discussion_r51533735 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/CentralMomentAgg.scala --- @@ -57,173 +55,170 @@ abstract class Cen

[GitHub] spark pull request: [SPARK-12913] [SQL] Improve performance of sta...

2016-02-01 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/10960#discussion_r51533696 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/CentralMomentAgg.scala --- @@ -57,173 +55,170 @@ abstract class Cen

[GitHub] spark pull request: [SPARK-12913] [SQL] Improve performance of sta...

2016-02-01 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/10960#discussion_r51533700 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/CentralMomentAgg.scala --- @@ -57,173 +55,170 @@ abstract class Cen

[GitHub] spark pull request: [SPARK-12913] [SQL] Improve performance of sta...

2016-02-01 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/10960#discussion_r51533733 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/CentralMomentAgg.scala --- @@ -57,173 +55,170 @@ abstract class Cen

[GitHub] spark pull request: [SPARK-12913] [SQL] Improve performance of sta...

2016-02-01 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/10960#discussion_r51533698 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/CentralMomentAgg.scala --- @@ -57,173 +55,170 @@ abstract class Cen

[GitHub] spark pull request: [SPARK-12913] [SQL] Improve performance of sta...

2016-02-01 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/10960#discussion_r51533702 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/CentralMomentAgg.scala --- @@ -57,173 +55,170 @@ abstract class Cen

[GitHub] spark pull request: [SPARK-12850] [SQL] Support Bucket Pruning (Pr...

2016-02-01 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/10942#discussion_r51533620 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/sources/BucketedReadSuite.scala --- @@ -59,6 +61,162 @@ class BucketedReadSuite extends QueryTest wi

[GitHub] spark pull request: [SPARK-12850] [SQL] Support Bucket Pruning (Pr...

2016-02-01 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/10942#discussion_r51533379 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/sources/BucketedReadSuite.scala --- @@ -59,6 +61,162 @@ class BucketedReadSuite extends QueryTest wi

[GitHub] spark pull request: [SPARK-12994][CORE] It is not necessary to cre...

2016-02-01 Thread zjffdu
Github user zjffdu commented on a diff in the pull request: https://github.com/apache/spark/pull/10914#discussion_r51533266 --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala --- @@ -2212,9 +2212,9 @@ private[spark] object Utils extends Logging { * incompatible.

[GitHub] spark pull request: [SPARK-13121] [Streaming] java mapWithState mi...

2016-02-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11007#issuecomment-178420590 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13121] [Streaming] java mapWithState mi...

2016-02-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11007#issuecomment-178420557 **[Test build #50544 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50544/consoleFull)** for PR 11007 at commit [`78c0323`](https://g

[GitHub] spark pull request: [SPARK-12506][SPARK-12126][SQL]use CatalystSca...

2016-02-01 Thread HyukjinKwon
Github user HyukjinKwon commented on the pull request: https://github.com/apache/spark/pull/11005#issuecomment-178420517 As @maropu said, for me I also agree with him but some may think differently as mentioned [here](https://github.com/apache/spark/pull/10750#issuecomment-175400704).

[GitHub] spark pull request: [SPARK-13121] [Streaming] java mapWithState mi...

2016-02-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11007#issuecomment-178420592 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13131] [SQL] Use best time in benchmark

2016-02-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11018#issuecomment-178420156 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13131] [SQL] Use best time in benchmark

2016-02-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11018#issuecomment-178420163 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-10820][SQL] Support for the continuous ...

2016-02-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11006#issuecomment-178419567 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12850] [SQL] Support Bucket Pruning (Pr...

2016-02-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10942#issuecomment-178419462 **[Test build #50550 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50550/consoleFull)** for PR 10942 at commit [`3f09465`](https://gi

[GitHub] spark pull request: [SPARK-13131] [SQL] Use best time in benchmark

2016-02-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11018#issuecomment-178419574 **[Test build #50541 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50541/consoleFull)** for PR 11018 at commit [`a534e0e`](https://g

[GitHub] spark pull request: [SPARK-10820][SQL] Support for the continuous ...

2016-02-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11006#issuecomment-178419558 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-10820][SQL] Support for the continuous ...

2016-02-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11006#issuecomment-178418795 **[Test build #50540 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50540/consoleFull)** for PR 11006 at commit [`735e113`](https://g

[GitHub] spark pull request: [SPARK-10820][SQL] Support for the continuous ...

2016-02-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11006#issuecomment-178417496 **[Test build #2488 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2488/consoleFull)** for PR 11006 at commit [`735e113`](https://

[GitHub] spark pull request: [SPARK-13135][SQL] Don't print expressions rec...

2016-02-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11019#issuecomment-178417590 **[Test build #50551 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50551/consoleFull)** for PR 11019 at commit [`2c2b007`](https://gi

[GitHub] spark pull request: [SPARK-12506][SPARK-12126][SQL]use CatalystSca...

2016-02-01 Thread maropu
Github user maropu commented on the pull request: https://github.com/apache/spark/pull/11005#issuecomment-178416552 Great work though, I think that we should consider lots of things to refactor these kinds of datasource push-down codes because related tickets (SPARK-12449, 12686, ...)

[GitHub] spark pull request: [SPARK-13135][SQL] Don't print expressions rec...

2016-02-01 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11019#issuecomment-178416188 Let me know if you guys think this is more clear. Alternatively, we can also print the expression comment only for top level expressions. --- If your project is set up fo

[GitHub] spark pull request: [SPARK-13135][SQL] Don't print expressions rec...

2016-02-01 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11019#issuecomment-178416006 query: ```scala sqlContext.range(1, 1000).select('id + 1 + 1).show() ``` old generated code: ```java /* 068 */ while (!Range_overflow3 && Ra

[GitHub] spark pull request: [SPARK-5682][Core] Add encrypted shuffle in sp...

2016-02-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8880#issuecomment-178416074 **[Test build #50552 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50552/consoleFull)** for PR 8880 at commit [`4064ab1`](https://gith

[GitHub] spark pull request: [SPARK-13135][SQL] Don't print expressions rec...

2016-02-01 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11019#issuecomment-178415439 New generated code: ```java scala> sqlContext.range(1, 1000).agg(expr("count(1)"), expr("sum(id)")).show() /* 001 */ /* 002 */ public Object generate(Objec

[GitHub] spark pull request: [SPARK-13135][SQL] Don't print expressions rec...

2016-02-01 Thread rxin
GitHub user rxin opened a pull request: https://github.com/apache/spark/pull/11019 [SPARK-13135][SQL] Don't print expressions recursively in generated code Our code generation currently prints expressions recursively. For example, for expression "(1 + 1) + 1)", we would print the fo

[GitHub] spark pull request: [SPARK-13130][SQL] Make codegen variable names...

2016-02-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11017 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-13130][SQL] Make codegen variable names...

2016-02-01 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11017#issuecomment-178414618 Thanks - merging this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-12850] [SQL] Support Bucket Pruning (Pr...

2016-02-01 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/10942#discussion_r51531853 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/sources/BucketedReadSuite.scala --- @@ -59,6 +61,159 @@ class BucketedReadSuite extends QueryTest w

[GitHub] spark pull request: [SPARK-7729][UI]Executor which has been killed...

2016-02-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10058#issuecomment-178413213 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-7729][UI]Executor which has been killed...

2016-02-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10058#issuecomment-178413211 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13094][SQL] Add encoders for seq/array ...

2016-02-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11014#issuecomment-178413029 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13130][SQL] Make codegen variable names...

2016-02-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11017#issuecomment-178413182 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13130][SQL] Make codegen variable names...

2016-02-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11017#issuecomment-178413183 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13094][SQL] Add encoders for seq/array ...

2016-02-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11014#issuecomment-178413031 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-10521][SQL] Utilize Docker for test DB2...

2016-02-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9893#issuecomment-178412998 **[Test build #50549 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50549/consoleFull)** for PR 9893 at commit [`d034e37`](https://gith

[GitHub] spark pull request: [SPARK-13130][SQL] Make codegen variable names...

2016-02-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11017#issuecomment-178412987 **[Test build #50537 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50537/consoleFull)** for PR 11017 at commit [`0efceba`](https://g

[GitHub] spark pull request: [SPARK-13094][SQL] Add encoders for seq/array ...

2016-02-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11014#issuecomment-178412705 **[Test build #50538 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50538/consoleFull)** for PR 11014 at commit [`0b5f03c`](https://g

[GitHub] spark pull request: [SPARK-13057][SQL] Add benchmark codes and the...

2016-02-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10965#issuecomment-178412175 **[Test build #50546 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50546/consoleFull)** for PR 10965 at commit [`cc58f20`](https://gi

[GitHub] spark pull request: [SPARK-7729][UI]Executor which has been killed...

2016-02-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10058#issuecomment-178411858 **[Test build #50548 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50548/consoleFull)** for PR 10058 at commit [`f749a5f`](https://g

[GitHub] spark pull request: [SPARK-7729][UI]Executor which has been killed...

2016-02-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10058#issuecomment-178411873 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12506][SPARK-12126][SQL]use CatalystSca...

2016-02-01 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/11005#discussion_r51531271 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala --- @@ -20,14 +20,15 @@ package org.apache.spark.sql.executio

[GitHub] spark pull request: [SPARK-7729][UI]Executor which has been killed...

2016-02-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10058#issuecomment-178411869 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-7729][UI]Executor which has been killed...

2016-02-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10058#issuecomment-178411417 **[Test build #50548 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50548/consoleFull)** for PR 10058 at commit [`f749a5f`](https://gi

  1   2   3   4   5   6   7   >