Github user smurching commented on a diff in the pull request:
https://github.com/apache/spark/pull/19433#discussion_r143398990
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tree/impl/LocalDecisionTreeUtils.scala
---
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Sof
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19363
shall we fix RelationalGroupedDataset too?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional co
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19082
@gatorsmile If my words make you upset, I'm sorry. It's you right to raise
suspicion against any PRs. I do respect this right.
Maybe I'm wrong and there actually is a possible regression. App
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19424
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19424
**[Test build #82547 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82547/testReport)**
for PR 19424 at commit
[`24f1a75`](https://github.com/apache/spark/commit/24
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19438#discussion_r143406835
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/QuantileSummariesSuite.scala
---
@@ -58,7 +58,7 @@ class QuantileSummariesSuite ext
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19438#discussion_r143406940
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameStatSuite.scala ---
@@ -157,21 +157,21 @@ class DataFrameStatSuite extends QueryTest with
Sh
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19082
Yes no need for a back-and-forth. @gatorsmile I think it's reasonable to
ask for a little more detail on your comment.
---
-
To u
Github user ScrapCodes commented on a diff in the pull request:
https://github.com/apache/spark/pull/17357#discussion_r143407147
--- Diff:
core/src/main/scala/org/apache/spark/deploy/worker/DriverWrapper.scala ---
@@ -23,14 +23,15 @@ import org.apache.commons.lang3.StringUtils
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/18748
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user yaooqinn commented on the issue:
https://github.com/apache/spark/pull/19363
Okï¼i will add a jira tgt and fix RelationalGroupedDataset
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19363
**[Test build #82548 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82548/testReport)**
for PR 19363 at commit
[`7e7ed19`](https://github.com/apache/spark/commit/7e
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/19437#discussion_r143411366
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerBackendUtil.scala
---
@@ -170,9 +174,122 @@ private[
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/19437#discussion_r143413006
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/deploy/mesos/config.scala
---
@@ -21,6 +21,39 @@ import java.util.concurrent.TimeUnit
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/19437#discussion_r143415419
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerBackendUtil.scala
---
@@ -170,9 +174,122 @@ private[
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19266#discussion_r143421894
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/BufferHolder.java
---
@@ -35,6 +35,11 @@
* if the fields of row
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/19433
@smurching Does it still WIP ? If done remove "[WIP]", I will begin review,
thanks!
---
-
To unsubscribe, e-mail: reviews-u
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/15770#discussion_r143426157
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/clustering/PowerIterationClustering.scala
---
@@ -0,0 +1,216 @@
+/*
+ * Licensed to the Apa
Github user krishna-pandey commented on a diff in the pull request:
https://github.com/apache/spark/pull/19419#discussion_r143427428
--- Diff: core/src/main/scala/org/apache/spark/ui/JettyUtils.scala ---
@@ -89,6 +92,9 @@ private[spark] object JettyUtils extends Logging {
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/19106
@srowen Any other comments? Thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comman
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/19437
@susanxhuynh this a mesos 1.4 feature, shouldn't we document this for users?
https://issues.apache.org/jira/browse/MESOS-7418
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19424
**[Test build #82547 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82547/testReport)**
for PR 19424 at commit
[`24f1a75`](https://github.com/apache/spark/commit/2
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19424
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19424
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82547/
Test PASSed.
---
Github user 10110346 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19077#discussion_r143439369
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -116,9 +116,10 @@ private [sql] object Gen
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19363
**[Test build #82548 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82548/testReport)**
for PR 19363 at commit
[`7e7ed19`](https://github.com/apache/spark/commit/7
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19363
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82548/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19363
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
GitHub user pavel-sakun opened a pull request:
https://github.com/apache/spark/pull/19457
[SPARK] Misleading error message
Fix misleading error message when argument is expected.
## What changes were proposed in this pull request?
Change message to be accurate.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19457
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19106#discussion_r143445323
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/ProbabilisticClassifier.scala
---
@@ -230,21 +230,22 @@ private[ml] object ProbabilisticCl
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19106#discussion_r143445232
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/ProbabilisticClassifier.scala
---
@@ -230,21 +230,22 @@ private[ml] object ProbabilisticCl
Github user pavel-sakun commented on the issue:
https://github.com/apache/spark/pull/19457
Not aware ATM, this one handles missing value for args expecting one.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark
Github user sohum2002 commented on the issue:
https://github.com/apache/spark/pull/19454
Would appreciate some help in the Python implementation of the `flatten`
function as I have never used pyspark. Could someone help me out?
---
---
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19454
Let's fix up the PR title from `[SPARK-18855 ][SQL]` to
`[SPARK-18855][SQL]` BTW.
---
-
To unsubscribe, e-mail: reviews-unsu
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19457
**[Test build #3946 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3946/testReport)**
for PR 19457 at commit
[`bc6d92e`](https://github.com/apache/spark/commit/b
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19363
**[Test build #82549 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82549/testReport)**
for PR 19363 at commit
[`f051c10`](https://github.com/apache/spark/commit/f0
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19454
**[Test build #82550 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82550/testReport)**
for PR 19454 at commit
[`cc08623`](https://github.com/apache/spark/commit/cc
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19454
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82550/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19454
**[Test build #82550 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82550/testReport)**
for PR 19454 at commit
[`cc08623`](https://github.com/apache/spark/commit/c
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19454
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user DaimonPl commented on the issue:
https://github.com/apache/spark/pull/16578
@mallman @viirya from my understanding current workaround is for case when
reading columns which are not in file schema
> Parquet-mr will throw an exception if we try to read a superset of
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19454
I think @srowen requested to fix it in a more performant way as well, for
example, referring https://github.com/apache/spark/pull/16276, if I understood
correctly and otherwise closing it.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19454
BTW, for the answer to
https://github.com/apache/spark/pull/19454#issuecomment-335138642, I think you
should take a look at, for example, `flatMap` as a reference in `rdd.py` and
related tests,
Github user zivanfi commented on a diff in the pull request:
https://github.com/apache/spark/pull/19250#discussion_r143462649
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -266,6 +267,10 @@ final class DataFrameWriter[T] private[sql](ds:
Datas
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/19222
ping for review @hvanhovell @tejasapatil
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/17968#discussion_r143465176
--- Diff: python/pyspark/mllib/linalg/__init__.py ---
@@ -1131,14 +1131,21 @@ def __getitem__(self, indices):
return self.values[i + j
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/17968
ping @gglanzani This bug need fixed ASAP. Can you update code when you're
free ? Thanks.
---
-
To unsubscribe, e-mail: revi
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/17968
@gglanzani And you the `ml.linalg.DenseMatrix` looks have the same bug. Can
you also update it ?
---
-
To unsubscribe, e-ma
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/19438#discussion_r143480931
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/QuantileSummariesSuite.scala
---
@@ -58,7 +58,7 @@ class QuantileSummariesSuite exte
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/19438#discussion_r143481416
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/QuantileSummariesSuite.scala
---
@@ -58,7 +58,7 @@ class QuantileSummariesSuite exte
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/19438#discussion_r143481784
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameStatSuite.scala ---
@@ -157,21 +157,21 @@ class DataFrameStatSuite extends QueryTest with
Sha
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19106
**[Test build #82551 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82551/testReport)**
for PR 19106 at commit
[`1dfa4c1`](https://github.com/apache/spark/commit/1d
Github user bdrillard commented on the issue:
https://github.com/apache/spark/pull/16648
I'm blocking out time to prepare the part 2 PR for this issue starting
today over this week, regarding compaction of excess primitive state.
cc: @kiszk
---
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19374#discussion_r143361887
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
---
@@ -276,8 +276,8 @@ private[s
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19374#discussion_r143487275
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
---
@@ -276,8 +276,8 @@ private[s
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19374#discussion_r143484031
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
---
@@ -804,45 +814,52 @@ private
Github user susanxhuynh commented on a diff in the pull request:
https://github.com/apache/spark/pull/19374#discussion_r143344688
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
---
@@ -374,6 +375,15 @@ private[
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19438#discussion_r143492975
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/QuantileSummariesSuite.scala
---
@@ -58,7 +58,7 @@ class QuantileSummariesSui
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19363
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82549/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19363
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user sohum2002 commented on the issue:
https://github.com/apache/spark/pull/19454
@HyukjinKwon - Thank you for your comments and analysis of this PR. I will
also try to improve the `flatMap(identity)` as mentioned by @srowen. Also, will
add a python implementation.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19363
**[Test build #82549 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82549/testReport)**
for PR 19363 at commit
[`f051c10`](https://github.com/apache/spark/commit/f
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19439
**[Test build #82552 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82552/testReport)**
for PR 19439 at commit
[`b0c4ace`](https://github.com/apache/spark/commit/b0
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19457
**[Test build #3946 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3946/testReport)**
for PR 19457 at commit
[`bc6d92e`](https://github.com/apache/spark/commit/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19106
**[Test build #82551 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82551/testReport)**
for PR 19106 at commit
[`1dfa4c1`](https://github.com/apache/spark/commit/1
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19106
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19106
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82551/
Test PASSed.
---
Github user icexelloss commented on a diff in the pull request:
https://github.com/apache/spark/pull/18732#discussion_r143506845
--- Diff: python/pyspark/sql/group.py ---
@@ -192,7 +193,69 @@ def pivot(self, pivot_col, values=None):
jgd = self._jgd.pivot(pivot_col)
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18732
**[Test build #82553 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82553/testReport)**
for PR 18732 at commit
[`876b118`](https://github.com/apache/spark/commit/87
Github user icexelloss commented on a diff in the pull request:
https://github.com/apache/spark/pull/18732#discussion_r143507748
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/object.scala
---
@@ -519,3 +519,18 @@ case class CoGroup(
out
Github user susanxhuynh commented on the issue:
https://github.com/apache/spark/pull/19374
@skonto One more question: in your screen shot of the History Server, I
noticed the "Completed" time is 1969-12-31 for all the drivers (the original
one, retry-1, and retry-2). Is that to be exp
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18853
**[Test build #82554 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82554/testReport)**
for PR 18853 at commit
[`2ada11a`](https://github.com/apache/spark/commit/2a
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19269#discussion_r143514294
--- Diff:
sql/core/src/test/java/test/org/apache/spark/sql/sources/v2/JavaSimpleWritableDataSource.java
---
@@ -0,0 +1,297 @@
+/*
+ * Licensed to
Github user shubhamchopra commented on a diff in the pull request:
https://github.com/apache/spark/pull/17673#discussion_r143516384
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala
---
@@ -106,6 +106,45 @@ private[feature] trait Word2VecBase extends Params
Github user shubhamchopra commented on a diff in the pull request:
https://github.com/apache/spark/pull/17673#discussion_r143516496
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala
---
@@ -106,6 +106,45 @@ private[feature] trait Word2VecBase extends Params
Github user shubhamchopra commented on a diff in the pull request:
https://github.com/apache/spark/pull/17673#discussion_r143516595
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala
---
@@ -106,6 +106,45 @@ private[feature] trait Word2VecBase extends Params
Github user shubhamchopra commented on a diff in the pull request:
https://github.com/apache/spark/pull/17673#discussion_r143516772
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala
---
@@ -106,6 +106,45 @@ private[feature] trait Word2VecBase extends Params
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/spark/pull/19394#discussion_r143517490
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlan.scala ---
@@ -274,19 +274,26 @@ abstract class SparkPlan extends QueryPlan[SparkPl
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19394
**[Test build #82555 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82555/testReport)**
for PR 19394 at commit
[`a2976fe`](https://github.com/apache/spark/commit/a2
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/spark/pull/19394#discussion_r143517522
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlan.scala ---
@@ -274,19 +274,26 @@ abstract class SparkPlan extends QueryPlan[SparkPl
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19439
**[Test build #82552 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82552/testReport)**
for PR 19439 at commit
[`b0c4ace`](https://github.com/apache/spark/commit/b
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19439
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19439
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82552/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19394
**[Test build #82556 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82556/testReport)**
for PR 19394 at commit
[`1a813ac`](https://github.com/apache/spark/commit/1a
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/18460
Gentle ping~, @gatorsmile . :)
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19061
Hi, @vanzin and @jerryshao .
Could you review this `ConsoleProgressBar` issue when you have some time?
---
-
To unsubsc
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19266
@srowen Thanks!
@liufengdb Could you submit a separate PR to fix the issues and also please
include the test cases?
---
--
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19394
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.ap
Github user BryanCutler commented on the issue:
https://github.com/apache/spark/pull/18664
@HyukjinKwon and @ueshin so with Arrow, the Pandas DataFrame from
`toPandas()` timestamp columns will not have a timezone - are we going to do
the same thing for `pandas_udf` Series? I was plan
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/spark/pull/19269#discussion_r143524057
--- Diff:
sql/core/src/test/java/test/org/apache/spark/sql/sources/v2/JavaSimpleWritableDataSource.java
---
@@ -0,0 +1,297 @@
+/*
+ * Licensed to th
GitHub user superbobry opened a pull request:
https://github.com/apache/spark/pull/19458
[SPARK-7][CORE] DiskBlockManager.getAllBlocks now tolerates temp files
## What changes were proposed in this pull request?
Prior to this commit getAllBlocks implicitly assumed that t
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19458
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user smurching commented on the issue:
https://github.com/apache/spark/pull/19433
Thanks! I'll remove the WIP. To clear things up for the future, I'd thought
[WIP] was the appropriate tag for a PR that's ready for review but not ready to
be merged (based on https://spark.apache
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19458#discussion_r143527010
--- Diff:
core/src/main/scala/org/apache/spark/storage/DiskBlockManager.scala ---
@@ -100,7 +102,9 @@ private[spark] class DiskBlockManager(conf: SparkConf,
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19447#discussion_r143527821
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -279,11 +279,11 @@ class CodegenContext {
Github user shubhamchopra commented on a diff in the pull request:
https://github.com/apache/spark/pull/17673#discussion_r143528173
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala
---
@@ -171,20 +210,46 @@ final class Word2Vec @Since("1.4.0") (
@Sin
Github user shubhamchopra commented on a diff in the pull request:
https://github.com/apache/spark/pull/17673#discussion_r143528339
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala
---
@@ -171,20 +210,46 @@ final class Word2Vec @Since("1.4.0") (
@Sin
Github user shubhamchopra commented on a diff in the pull request:
https://github.com/apache/spark/pull/17673#discussion_r143529286
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/Word2VecSuite.scala ---
@@ -189,6 +305,136 @@ class Word2VecSuite extends SparkFunSuite wit
Github user shubhamchopra commented on a diff in the pull request:
https://github.com/apache/spark/pull/17673#discussion_r143529694
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/Word2VecSuite.scala ---
@@ -245,5 +508,28 @@ class Word2VecSuite extends SparkFunSuite with
1 - 100 of 333 matches
Mail list logo
