[chromium-dev] Re: HTML5 Web Socket design doc
2009/6/26 Michael Nordman micha...@google.com
2009/6/25 Fumitoshi Ukai (鵜飼文敏) u...@chromium.org
Thanks for review.
2009/6/25 Michael Nordman micha...@google.com
Only skimmed thusfar as well... but from what i've seen, looks reasonable
to me.
* A version of the diagram you have in the chrome doc would be nice in
the webkit doc too.
Sure. I've added a diagram in webkit part.
* Does WebSocketHandle really need to be refcounted. I know
ResourceHandle is a refcounted object and this design looks modeled off of
that (which may be why you've spec'd it this way). Unless your design
actually needs refcounting on this class, you may be able to simplify things
without it. From the looks of it, WebSocketChannel 'owns' the
WebSocketHandle.
Yes. I missed to add public RefCountedWebSocketHandle as base class of
WebSocketHandle.
Thanks.
I was suggesting that perhaps the WebSocketHandle does not need to be
refcounted.
Oh, sorry. I changed it to OwnPtr.
should we reuse WebCore/loader instead of adding new component?
The loader is somewhat notorious for its complexity. I think you've made
a good decision to keep this out of there and to design the websocket system
in a good clean modular fashion.
which component is responsible of web socket protocol framing? This
design assumes WebSocketChannel serializes/deserializes message in web
socket frame.
Since WebSocketHandle is inevitably going to be platform specific, any
code you want to be shared code shouldn't be slated for that class. To the
extent the 'web socket protocol framing' can be done indepedent of the
'platform' socket handle (which it looks like it can be), it would be a good
thing to put it in WebSocketChannel so its shared core common code goodness.
I see.
I've one question: Web socket handshaking is also platform independent.
Should we do the handshaking in WebSocketChannel and WebSocketHandle just
provides almost raw TCP socket?
Or Put handshaking in WebSocketHandle as resource loader puts HTTP in
platform code?
I haven't read the web sockets spec, so I don't know what the
'handshaking' entails?
It looks something similar like HTTP request/response.
see http://tools.ietf.org/html/draft-hixie-thewebsocketprotocol more
details.
OS level socket creation/destruction and tcp connection opening/closing
needs to be per-platform. Once you have a full-duplex connection and are
sending application 'protocol' data back and forth (message framing), that
probably wants to be common code. Which camp does the 'handshaking' fall
into?
Hmm, maybe we need to move construction of request in web socket handshake,
and verification of response in web socket handshake. Updated.
Thanks!
ukai
Regarding the WebKit API, note that no WebCore data types can be used
there. So you'll need to create wrapper classes.
I see you have speced WebKit:: wrapper classes with the same name as the
corresponding WebCore:: classes.
I wonder if that same naming could be confusingt? The naming convention
darin has been employing would be WebKit::WebWebSocketHandle, which
certainly looks odd.
Ok. I follow the naming convention to be WebKit::WebWebSocketHandle.
* virtual void didReceiveData(const String msg) {}
Maybe rename this to channel client api to didReceiveMessage() to help
distinguish between raw 'data' being surface by the 'handle', and complete
'messages' being surfaced by the 'channel'.
Sure. Fixed.
Thanks!
ukai
On Wed, Jun 24, 2009 at 2:32 AM, Fumitoshi Ukai (鵜飼文敏)
u...@chromium.org wrote:
Hi,
yuzo, tyoshino and I start working to implement HTML5 Web Socket and
write design docs
WebKit part: http://docs.google.com/View?id=dfm7gfvg_0fpjg22gh
Chromium part: http://docs.google.com/View?id=dfm7gfvg_1dm97qxgm
We'll send WebKit part to webkit-dev, if it looks ok.
We'd welcome if you could give us feedback on our design docs.
Thanks,
ukai
--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---
[chromium-dev] Re: How do I deploy an NPAPI plugin over the internet from HTML ?
OK. Thanks for the information. Before I proceed to build an independent installer, please can you advise whether or not there are any plans for Chrome to provide such a mechanism for automatic NPAPI Plugin downloads at some point in the future ? --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: question about helpwanted items (how it works)
http://codereview.chromium.org/147200 --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: question about helpwanted items (how it works)
http://codereview.chromium.org/147202 (i didn't know how to use gcl properly, so i re-submitted and deleted the prev issue, prev was only up for a very short while) --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: How do I deploy an NPAPI plugin over the internet from HTML ?
On Fri, Jun 26, 2009 at 11:24 AM, Non-Stickkevin.ra...@ntlworld.com wrote: OK. Thanks for the information. Before I proceed to build an independent installer, please can you advise whether or not there are any plans for Chrome to provide such a mechanism for automatic NPAPI Plugin downloads at some point in the future ? No, I don't think so. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: What's the real reason of giving up Windows 2000 support?
Feel free to make an eComstation port though, 2.0 is about to be released, plus its not that different from any other OS ;) - Itai On Jun 23, 12:48 pm, Elliot Glaysher (Chromium) e...@chromium.org wrote: On Tue, Jun 23, 2009 at 8:58 AM, Dan Kegeldaniel.r.ke...@gmail.com wrote: p.s. And OS/2 is right out. And no Amiga port, either. -- Elliot --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: How do I deploy an NPAPI plugin over the internet from HTML ?
On Fri, Jun 26, 2009 at 5:38 AM, Dean McNameede...@chromium.org wrote: On Fri, Jun 26, 2009 at 11:24 AM, Non-Stickkevin.ra...@ntlworld.com wrote: Before I proceed to build an independent installer, please can you advise whether or not there are any plans for Chrome to provide such a mechanism for automatic NPAPI Plugin downloads at some point in the future ? No, I don't think so. The problem is security. NPAPI plug-ins can run arbitrary code on your machine. If we made it easier to install NPAPI plug-ins than to run EXEs, all the malware authors would flock to NPAPI just like they've flocked to ActiveX in the past, which used to be (still is?) easier to install than EXEs. Adam --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: question about helpwanted items (how it works)
Thanks for writing this! I would personally use this feature frequently. The code looks good too. On Fri, Jun 26, 2009 at 4:35 AM, nakroyoav.zilberb...@gmail.com wrote: http://codereview.chromium.org/147202 (i didn't know how to use gcl properly, so i re-submitted and deleted the prev issue, prev was only up for a very short while) --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: What's the real reason of giving up Windows 2000 support?
Is eComstation the OS/2 that dare not speak its name? :-) On Fri, Jun 26, 2009 at 6:50 AM, Itaiida...@chromium.org wrote: Feel free to make an eComstation port though, 2.0 is about to be released, plus its not that different from any other OS ;) - Itai On Jun 23, 12:48 pm, Elliot Glaysher (Chromium) e...@chromium.org wrote: On Tue, Jun 23, 2009 at 8:58 AM, Dan Kegeldaniel.r.ke...@gmail.com wrote: p.s. And OS/2 is right out. And no Amiga port, either. -- Elliot --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: question about helpwanted items (how it works)
Yeah, this is great, thanks. On Fri, Jun 26, 2009 at 5:28 PM, Evan Martine...@chromium.org wrote: Thanks for writing this! I would personally use this feature frequently. The code looks good too. On Fri, Jun 26, 2009 at 4:35 AM, nakroyoav.zilberb...@gmail.com wrote: http://codereview.chromium.org/147202 (i didn't know how to use gcl properly, so i re-submitted and deleted the prev issue, prev was only up for a very short while) --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Memory usage in chrome
On Thu, Jun 25, 2009 at 4:11 PM, Mike Beltzner beltz...@mozilla.com wrote: On 25-Jun-09, at 7:02 PM, Mike Belshe wrote: This screen actually confuses me a little, as the Summary statistics don't match the summation of the process based statistics. Do you mean to say your summary statistics take into account the memory that's being shared across the various processes? Correct. The shared across all processes is a bit of a hack, because you can't know exactly which pages are shared across every single process. We do a heuristic. Cool! Good to know. I'll take a peek into that code you mentioned to see what the heuristic is that you're using. Interestingly, as I watched this value change while webpages were loading, it tracked the same pattern of growth/decline as Memory (Private Working Set) in the Task Manager, though the values were usually about 2x or so more. I suppose this is due to the heap sharing you were speaking of earlier? I'm not quite sure what you mean. I'm basically being lazy. I'd like to not have to make my own counter for Private Working Set, so I watched the values of Memory (Private Working Set) and Commit Size in the Task Manager as the test ran, and noticed that they increased/decreased at the same time, and the delta between them was a near constant 2x. Since my interest here is developing a metric that can help us understand when we're regressing/improving memory usage, the exact value isn't as important to me as the delta. If the deltas are simply off by a constant factor, I could live with that. As I said: lazy! understood. Just in case, here is the code for you to take: http://src.chromium.org/viewvc/chrome/trunk/src/base/process_util_win.cc?view=markuppathrev=14705 The Working Set - Private counter doesn't seem to have a structure according to the MSDN document; that's what maps to the Memory (Private Working Set) column in the TaskManager. Right, I think you have to use QueryWorkingSet, walk the pages and categorize them yourself. OK, I can look into trying that. Though I'm wondering if it's worth the bother, as the meta-pattern, to me, is more interesting than the precise megabyte count. For a single process browser, it's not worth the effort; I think it's the only way to know how to account for shared memory. The closest thing I can find is the Working Set counter, which uses the PROCESS_MEMORY_COUNTERS_EX.WorkingSetSize structure and shows up in the Vista Task Manager as Working Set (Memory) For multi-proc browsers like chrome, this will way overstate RAM; there is a good 5-6MB of shared working set in each process. So for 10 tabs, you'd could an extra 50MB for Chrome if you do it this way. Looking both in Task Manager and about:memory, when I have 30 tabs open I'm not seeing 30 processes. Are you sure you're right about this point? You don't always get a new process for every tab. If two tabs are connected via javascript, then they'll be in the same process (the about:memory shows which tabs are in the same process). So, clicking a link, for example, will open in the same tab, but typing the URL in the omnibox will create a new process. Others could tell you more about the exact policy for when you get a new process and when you don't. Someone just did in IRC, actually. Apparently in addition to what you said, as soon as a page is in cache, processes get pooled. I clear caches between test runs, but it sounds like since we're calling these with window.open() in our test, they all get placed in the same process. Overall, though, that should mean that we're *not* double counting memory. In fact, when I observed as the test ran, there were only three processes: one for the browser, one for the single content process from which all tabs were spawned, and one for Shockwave/Flash. Good news, I guess, in terms of reporting accurately! Good news and bad news :-) If you publish results saying how Chrome did, Chrome doesn't get to cleanup as cleanly in this case. It still *should*, but it's not what users do :-) OK - I think this might basically use one renderer process in chrome? Because of the new-process creation policy, it may not be representative of real world usage. Darin? Right, but AIUI, it's an erring on the side of reporting less, not more. If there's a better way to automate pageloads that represents real world usage, please let me know. I don't know of cross-browser code that will accomplish what you want. Maybe we should add that. The whole while, we measure the amount of memory taken using the PROCESS_MEMORY_COUNTERS structure, summating over processes when multiple exist (as they do in the case of Internet Explorer 8 and Chrome 2) Ok - that will double count shared memory. I'd estimate 3-5MB per process. So we're talking about over-reporting by 9-15MB across the test. Again, good to know. I'll try to take a closer look at your
[chromium-dev] Re: Memory usage in chrome
On 26-Jun-09, at 12:59 PM, Mike Belshe wrote: Overall, though, that should mean that we're *not* double counting memory. In fact, when I observed as the test ran, there were only three processes: one for the browser, one for the single content process from which all tabs were spawned, and one for Shockwave/ Flash. Good news, I guess, in terms of reporting accurately! Good news and bad news :-) If you publish results saying how Chrome did, Chrome doesn't get to cleanup as cleanly in this case. It still *should*, but it's not what users do :-) Hm, so the thinking is that since users will close tabs and open new ones and navigate from the Omnibox that will close and open processes, thus freeing memory? I don't think I'm going to publish results, per se, but if I do, I'll point this part out for sure. Right, but AIUI, it's an erring on the side of reporting less, not more. If there's a better way to automate pageloads that represents real world usage, please let me know. I don't know of cross-browser code that will accomplish what you want. Maybe we should add that. What about command line invocation? Does that spawn new processes? cheers, mike --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Memory usage in chrome
On Fri, Jun 26, 2009 at 10:11 AM, Mike Beltzner beltz...@mozilla.comwrote: On 26-Jun-09, at 12:59 PM, Mike Belshe wrote: Overall, though, that should mean that we're *not* double counting memory. In fact, when I observed as the test ran, there were only three processes: one for the browser, one for the single content process from which all tabs were spawned, and one for Shockwave/Flash. Good news, I guess, in terms of reporting accurately! Good news and bad news :-) If you publish results saying how Chrome did, Chrome doesn't get to cleanup as cleanly in this case. It still *should*, but it's not what users do :-) Hm, so the thinking is that since users will close tabs and open new ones and navigate from the Omnibox that will close and open processes, thus freeing memory? I don't think I'm going to publish results, per se, but if I do, I'll point this part out for sure. Right, but AIUI, it's an erring on the side of reporting less, not more. If there's a better way to automate pageloads that represents real world usage, please let me know. I don't know of cross-browser code that will accomplish what you want. Maybe we should add that. What about command line invocation? Does that spawn new processes? Oh - good call - yes - that should work. cheers, mike --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Reliability Fixit Week
Next week June 29 - July 2 is the Fixit week focusing on reliability. All crash bugs are Fixit work items. http://code.google.com/p/chromium/issues/list?can=2q=label:Crashsort=ownerhttp://code.google.com/p/chromium/issues/list?can=2q=label:Crashsort=ownercolspec=ID%20Stars%20Pri%20Area%20Type%20Status%20Summary%20Modified%20Owner%20Mstone In addition, there are purify, valgrind, and coverity issues labeled for this round of Fixit. http://code.google.com/p/chromium/issues/list?can=2q=coverity%20OR%20valgrind%20OR%20purify%20label:fixitsort=owner; We welcome *all* chromium contributors to participate. For committers (including provisional committers), please plan to set aside about 2 days for the next week to fix the above bugs. The process of this round of Fixit is same as what we did before and I list here for people recently joined the chromium development community. 1. If you have not done so, please look through the list and take the bugs you'd like to work on. 2. If you are overloaded with Fixit bugs, find new owners for some bugs or simply unassign yourself. 3. During the week, we will assign unclaimed bugs. For this reason, you may want to take the bug you'd like to work on yourself instead of being assigned with random bugs. 4. As our development culture, be prepared to work on bugs across all chromium code base. If you are assigned with bugs in an unfamiliar area, consider the following options: - Identify the best person to fix the bug and assign the bug to him/her if the person has cycles. - Do as much as you can to help out, for example, analyzing crash dumps, querying crash server to find common pattern across crash dumps, narrowing down the revision range that causes the bug, searching through reports from user group and bug database to get additional information, finding repro steps, constructing reduced test cases, etc. - Understand the code and fix it. Huan and Anthony. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Google History extension
Did you have any luck? Also this thread should probably be moved to the new extensions group if possible On Jun 9, 8:56 pm, Nick Baum nickb...@chromium.org wrote: Hi John, Web History doesn't have an official API, but I've emailed the teams. I'll let you know if they can share any more info. -Nick On Tue, Jun 9, 2009 at 10:41 AM, John Munro ghost...@gmail.com wrote: Can someone who works for Google perhaps put me in touch with someone from the Google Web History or Google Toolbar team? I can't find any information anywhere... On May 26, 3:20 pm, John Munro ghost...@gmail.com wrote: By sniffing Firefox I think what happens is that the toolbar does a HTTP GET to http://toolbarqueries.google.com/search?features=Rank:WHsourceid=nav... where the URL at the end (in this case filevision.net) is the URL to add to History. Unfortunately when I try just navigating to a URL like this I get a 403 Forbidden error. Maybe it's something to do with the googleip, iqrn and ch parameters, since I have no idea what they do. On May 26, 2:02 pm, Nick Baum nickb...@chromium.org wrote: I'd love to see an extension that does this! It might be relatively straight-forward to sniff network requests to google.com while browsing with the toolbar enabled. -Nick On Mon, May 25, 2009 at 4:26 PM, John Munro ghost...@gmail.com wrote: Ugh, it's minified - not sure I have the enthusiasm for that. Oh well :( On May 25, 6:32 pm, Evan Martin e...@chromium.org wrote: From a quick search it doesn't look like there's an API available. One thought is to examine the Google Toolbar for Firefox, as that can submit to web history and is written primarily in JavaScript. On Fri, May 22, 2009 at 6:07 PM, John Munro ghost...@gmail.com wrote: One of the things I miss when using Chrome is how Google Toolbar adds every page you visit to Google History. I would like to build a Chrome extension that just implements that one feature of Google Toolbar - adds every page you visit to Google History. I imagine this would be quite simple if it was just a matter of sending the current URL as a parameter to a Google History URL or something similar. Does anyone know how to submit a visited URL to Google History? Apologies if this is the wrong group to post this to. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] WebKit Sheriffing Documentation Update
Based on our experiences from the past few weeks of rolling, I updated the WebKit Integration documentation: http://sites.google.com/a/chromium.org/dev/developers/how-tos/webkit-merge-1 They key takeaways are: 1) roll often, in small increments 2) pay attention to actual changes you're rolling in and update test results. 3) don't hesitate to ask for help in case for breakage, but make sure to roll to the last green revision. :DG --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: how to judge layouttests' running result?
This is not a pass. Specifically Regressions: Unexpected failures lists the failures. Other times, you'll see Regressions: Unexpected * where * is crash, timeout, failures, etc. Also, it should have popped up a window with the results just for the failing tests. Ojan 2009/6/25 David Jones ds...@163.com I have ran layouttests on Windows XP, and got a result as: Expected to fail, but passed (5): LayoutTests/css2.1/t0805-c5519-brdr-r-01-e.html LayoutTests/css2.1/t0905-c5525-fltblck-00-d-ag.html LayoutTests/css2.1/t0905-c5525-flthw-00-c-g.html LayoutTests/css2.1/t0905-c5526-flthw-00-c-g.html LayoutTests/fast/encoding/invalid-UTF-8.html Expected to timeout, but passed (1): LayoutTests/http/tests/security/credentials-in-referer.html Regressions: Unexpected failures (8): LayoutTests/fast/css/css2-system-fonts.html = FAIL LayoutTests/fast/dom/anchor-toString.html = FAIL LayoutTests/fast/dom/java-applet-calls.html = FAIL LayoutTests/fast/dom/object-embed-plugin-scripting.html = FAIL LayoutTests/http/tests/security/ cross-frame-access-protocol-explicit-domain.ht ml = FAIL LayoutTests/http/tests/security/cross-frame-access-protocol.html = FAIL LayoutTests/platform/win/fast/text/uniscribe-missing-glyph.html = FAIL LayoutTests/plugins/embed-attributes-setting.html = FAIL Regressions: Unexpected timeouts (1): LayoutTests/http/tests/security/originHeader/origin-header-for-https.html = TI MEOUT -- = Tests to be fixed for the current release (786): 86 test cases (10.9%) Passed 364 test cases (46.3%) Skipped 289 test cases (36.8%) Text diff mismatch 191 test cases (24.3%) Simplified text diff mismatch 160 test cases (20.4%) Image mismatch 11 test cases (1.4%) Test timed out 6 test cases (0.8%) Test shell crashed 2 test cases (0.3%) No expected image found = Tests we want to pass for the current release (8984): 8271 test cases (92.1%) Passed 364 test cases (4.1%) Skipped 301 test cases (3.4%) Text diff mismatch 201 test cases (2.2%) Simplified text diff mismatch 164 test cases (1.8%) Image mismatch 12 test cases (0.1%) Test timed out 6 test cases (0.1%) Test shell crashed 2 test cases (0.0%) No expected image found = Tests to be fixed for a future release (0): = All tests (10884): 8753 test cases (80.4%) Passed 2130 test cases (19.6%) Skipped 411 test cases (3.8%) Text diff mismatch 302 test cases (2.8%) Simplified text diff mismatch 183 test cases (1.7%) Image mismatch 13 test cases (0.1%) Test timed out 6 test cases (0.1%) Test shell crashed 2 test cases (0.0%) No expected image found I don't know what it tells, am I passed the layouttests? There's also a layouttests in webkit, what's the relation between chrome's layouttest and webkit's layouttest? I think webkit's layouttest only run on Leopard. -- 200万种商品,最低价格,疯狂诱惑你http://count.mail.163.com/redirect/footer.htm?f=http://gouwu.youdao.com --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: WebKit Sheriffing Documentation Update
For the layout tests steps, why do you we need to build test_shell locally, rebaseline and then add the other platforms to tests_fixable? Can't we just use the rebaseline tool and point it at the integration bots? Currently, you can point the tool at a specific builder. Maybe we could add a --integration-builders or something that would look at the integration builders for all three platforms. Speaking of the integration bots, should we set one up for Linux as well? Ojan On Fri, Jun 26, 2009 at 10:59 AM, Dimitri Glazkov dglaz...@google.comwrote: Based on our experiences from the past few weeks of rolling, I updated the WebKit Integration documentation: http://sites.google.com/a/chromium.org/dev/developers/how-tos/webkit-merge-1 They key takeaways are: 1) roll often, in small increments 2) pay attention to actual changes you're rolling in and update test results. 3) don't hesitate to ask for help in case for breakage, but make sure to roll to the last green revision. :DG --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: WebKit Sheriffing Documentation Update
On Fri, Jun 26, 2009 at 12:10 PM, Amanda Walker ama...@chromium.org wrote: On Fri, Jun 26, 2009 at 2:42 PM, Ojan Vafaio...@chromium.org wrote: For the layout tests steps, why do you we need to build test_shell locally, rebaseline and then add the other platforms to tests_fixable? Can't we just use the rebaseline tool and point it at the integration bots? Agreed. Because of the way baselines are organized, the usual case is that of a new test arriving with a baseline for the Mac but not for Windows and Linux. Using the rebaseline tool (or even rework it a little so that it knows how to check for new tests) would be a lot more useful than having to generate new baselines locally. Speaking of the integration bots, should we set one up for Linux as well? At this point, it would be nice to have one for each platform. Mac already has one. I can add a linux webkit-latest bot too. (Might take a couple of days, since i'm not sure I have enough hardware.. will check) Nicolas --Amanda --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Should GYP files be UTF8 Encoded?
On Fri, Jun 26, 2009 at 1:50 PM, Daniel Cowxdaniel.c...@gmail.com wrote: Should GYP files be UTF8 Encoded? They certainly shouldn't be UTF16 or anything like that. However, if code-points 128 are slipping in I think the first question is why? If we have a need for such code-points, then UTF-8 is my preference. AGL --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Should GYP files be UTF8 Encoded?
On Fri, Jun 26, 2009 at 1:50 PM, Daniel Cowxdaniel.c...@gmail.com wrote: Should GYP files be UTF8 Encoded? We can probably get away with ascii for now... are there any filenames that really need to be in a wider character set? --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Should GYP files be UTF8 Encoded?
Not that I'm aware of. Just wanted to confirm that intention is ASCII for now unless need arises. On Jun 26, 2:18 pm, Dan Kegel daniel.r.ke...@gmail.com wrote: On Fri, Jun 26, 2009 at 1:50 PM, Daniel Cowxdaniel.c...@gmail.com wrote: Should GYP files be UTF8 Encoded? We can probably get away with ascii for now... are there any filenames that really need to be in a wider character set? --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] middle click on home
When you middle-click on the home button, it opens in a background tab. Is this intentional? I understand the idea of consistency with other middle clicks, but I struggle to think of a use case where I want to open an extra tab on my home page for later. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: middle click on home
On Fri, Jun 26, 2009 at 5:06 PM, Peter Kastingpkast...@google.com wrote: I don't understand; what's the alternative behavior you're proposing? Sorry, I failed to make that explicit: Open in foreground. (See original mail about false benefits of consistency.) (Yes, this behavior is intentional; all the toolbar buttons handle clicks/modifiers now, so e.g. middle-clicking the back button opens the previous page in a new background tab. This behavior was a popular niche request and matches Firefox.) PK On Jun 26, 2009 5:00 PM, Evan Martin e...@chromium.org wrote: When you middle-click on the home button, it opens in a background tab. Is this intentional? I understand the idea of consistency with other middle clicks, but I struggle to think of a use case where I want to open an extra tab on my home page for later. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: middle click on home
Given that there are a large number of ways to open the home page in a new foreground tab (e.g. ctrl-t + click, shift-middle click, etc.), there are a very large number of other places in the UI where middle-click opens a new background tab (including other toolbar buttons), there are no places I can think of offhand where middle-click opens a new foreground tab, and this behavior matches other browsers, I'm opposed to changing this. Besides, in at least my own use, background tabs would be more useful anyway. I never want the browser to change tabs for me and I queue up things as I think about them so I will do them in order. PK On Jun 26, 2009 5:09 PM, Evan Martin e...@chromium.org wrote: On Fri, Jun 26, 2009 at 5:06 PM, Peter Kastingpkast...@google.com wrote: I don't understand; wha... Sorry, I failed to make that explicit: Open in foreground. (See original mail about false benefits of consistency.) (Yes, this behavior is intentional; all the toolbar buttons handle clicks/modifiers now, so e... --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Windows 7 and the mailto protocol
This is only somewhat related to Chromium, but I'm asking here because the chromium developers might be the most likely to know the answer. I currently am running Windows 7 Ultimate x64, and I want to associate mailto: links that I click in Chromium (and anywhere, really) to be associated to a new window popping up in Chromium that opens a new email composition in GMail. I know the command for this (it involves -- app), but that doesn't do me any good if I can't put it anywhere. On windows xp, all I had to do was find the MAILTO file type and associate the appropriate command with it and everything worked. But in Windows 7 I do not have a MAILTO protocol. I go to Control Panel Default Programs Set Default Programs Chromium Choose defaults for this program. In this window, I have FTP, HTTP, and HTTPS protocols, but no MAILTO protocol. I'm assuming this is because I have no email client installed on my operating system, and Windows 7 acts dumb and doesn't even make MAILTO available since it does not detect an email client. That's just my speculation, though. Even if MAILTO was available, I don't think it would help because Windows 7 seems to have taken away the ability to associate a command with a protocol, like what was previously possible in Windows XP. Any ideas on this? --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Windows 7 and the mailto protocol
It's a good idea. We've talked in the past about allowing webapps to specify a manifest which (among other things) includes the list of protocols that they wish to support. When a webapp is installed via Create Application Shortcuts, we could add Chrome to the Windows list on behalf of the webapp. There's also the registerProtocolHandler component of one of the WHAT Web Apps specs. Definitely something we're considering, but no immediate implementation plans. -Ben On Fri, Jun 26, 2009 at 7:07 PM, Robert Daileyrcdai...@gmail.com wrote: This is only somewhat related to Chromium, but I'm asking here because the chromium developers might be the most likely to know the answer. I currently am running Windows 7 Ultimate x64, and I want to associate mailto: links that I click in Chromium (and anywhere, really) to be associated to a new window popping up in Chromium that opens a new email composition in GMail. I know the command for this (it involves -- app), but that doesn't do me any good if I can't put it anywhere. On windows xp, all I had to do was find the MAILTO file type and associate the appropriate command with it and everything worked. But in Windows 7 I do not have a MAILTO protocol. I go to Control Panel Default Programs Set Default Programs Chromium Choose defaults for this program. In this window, I have FTP, HTTP, and HTTPS protocols, but no MAILTO protocol. I'm assuming this is because I have no email client installed on my operating system, and Windows 7 acts dumb and doesn't even make MAILTO available since it does not detect an email client. That's just my speculation, though. Even if MAILTO was available, I don't think it would help because Windows 7 seems to have taken away the ability to associate a command with a protocol, like what was previously possible in Windows XP. Any ideas on this? --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Windows 7 and the mailto protocol
Thanks for getting back with me Ben. Good to know you guys are aware of the problem and looking at portable solutions. In the meantime, however, are you aware of any short-term solutions to this annoying problem? I have to say this is the one thing I hate about Windows 7 so far. I really don't understand how the new protocol system works in Windows 7 yet, nor why MAILTO isn't available. I'm hoping there are some registry keys I can edit somewhere. On Jun 26, 9:11 pm, Ben Goodger (Google) b...@chromium.org wrote: It's a good idea. We've talked in the past about allowing webapps to specify a manifest which (among other things) includes the list of protocols that they wish to support. When a webapp is installed via Create Application Shortcuts, we could add Chrome to the Windows list on behalf of the webapp. There's also the registerProtocolHandler component of one of the WHAT Web Apps specs. Definitely something we're considering, but no immediate implementation plans. -Ben On Fri, Jun 26, 2009 at 7:07 PM, Robert Daileyrcdai...@gmail.com wrote: This is only somewhat related to Chromium, but I'm asking here because the chromium developers might be the most likely to know the answer. I currently am running Windows 7 Ultimate x64, and I want to associate mailto: links that I click in Chromium (and anywhere, really) to be associated to a new window popping up in Chromium that opens a new email composition in GMail. I know the command for this (it involves -- app), but that doesn't do me any good if I can't put it anywhere. On windows xp, all I had to do was find the MAILTO file type and associate the appropriate command with it and everything worked. But in Windows 7 I do not have a MAILTO protocol. I go to Control Panel Default Programs Set Default Programs Chromium Choose defaults for this program. In this window, I have FTP, HTTP, and HTTPS protocols, but no MAILTO protocol. I'm assuming this is because I have no email client installed on my operating system, and Windows 7 acts dumb and doesn't even make MAILTO available since it does not detect an email client. That's just my speculation, though. Even if MAILTO was available, I don't think it would help because Windows 7 seems to have taken away the ability to associate a command with a protocol, like what was previously possible in Windows XP. Any ideas on this? --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Windows 7 and the mailto protocol
look at the 4th post in this thread, the one by nakro with the registry trick i have no win7 but i guess it should work as well http://www.google.com/support/forum/p/Chrome/thread?tid=3844726aab2447c8hl=en --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Windows 7 and the mailto protocol
I would recommend looking into how the underlying protocol system is implemented (what the format of the command is that Windows dispatches) then writing a script and setting that as the handler. In Chrome you can launch an app frame like so: path\to\chrome.exe --app URL Your script would synthesize the URL based on the data from windows and the URL format of the webmail provider. -Ben On Fri, Jun 26, 2009 at 7:16 PM, Robert Daileyrcdai...@gmail.com wrote: Thanks for getting back with me Ben. Good to know you guys are aware of the problem and looking at portable solutions. In the meantime, however, are you aware of any short-term solutions to this annoying problem? I have to say this is the one thing I hate about Windows 7 so far. I really don't understand how the new protocol system works in Windows 7 yet, nor why MAILTO isn't available. I'm hoping there are some registry keys I can edit somewhere. On Jun 26, 9:11 pm, Ben Goodger (Google) b...@chromium.org wrote: It's a good idea. We've talked in the past about allowing webapps to specify a manifest which (among other things) includes the list of protocols that they wish to support. When a webapp is installed via Create Application Shortcuts, we could add Chrome to the Windows list on behalf of the webapp. There's also the registerProtocolHandler component of one of the WHAT Web Apps specs. Definitely something we're considering, but no immediate implementation plans. -Ben On Fri, Jun 26, 2009 at 7:07 PM, Robert Daileyrcdai...@gmail.com wrote: This is only somewhat related to Chromium, but I'm asking here because the chromium developers might be the most likely to know the answer. I currently am running Windows 7 Ultimate x64, and I want to associate mailto: links that I click in Chromium (and anywhere, really) to be associated to a new window popping up in Chromium that opens a new email composition in GMail. I know the command for this (it involves -- app), but that doesn't do me any good if I can't put it anywhere. On windows xp, all I had to do was find the MAILTO file type and associate the appropriate command with it and everything worked. But in Windows 7 I do not have a MAILTO protocol. I go to Control Panel Default Programs Set Default Programs Chromium Choose defaults for this program. In this window, I have FTP, HTTP, and HTTPS protocols, but no MAILTO protocol. I'm assuming this is because I have no email client installed on my operating system, and Windows 7 acts dumb and doesn't even make MAILTO available since it does not detect an email client. That's just my speculation, though. Even if MAILTO was available, I don't think it would help because Windows 7 seems to have taken away the ability to associate a command with a protocol, like what was previously possible in Windows XP. Any ideas on this? --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Windows 7 and the mailto protocol
In regards to the script, I do not have the domain knowledge to do such a thing, unfortunately. On Jun 26, 9:48 pm, Ben Goodger (Google) b...@chromium.org wrote: I would recommend looking into how the underlying protocol system is implemented (what the format of the command is that Windows dispatches) then writing a script and setting that as the handler. In Chrome you can launch an app frame like so: path\to\chrome.exe --app URL Your script would synthesize the URL based on the data from windows and the URL format of the webmail provider. -Ben On Fri, Jun 26, 2009 at 7:16 PM, Robert Daileyrcdai...@gmail.com wrote: Thanks for getting back with me Ben. Good to know you guys are aware of the problem and looking at portable solutions. In the meantime, however, are you aware of any short-term solutions to this annoying problem? I have to say this is the one thing I hate about Windows 7 so far. I really don't understand how the new protocol system works in Windows 7 yet, nor why MAILTO isn't available. I'm hoping there are some registry keys I can edit somewhere. On Jun 26, 9:11 pm, Ben Goodger (Google) b...@chromium.org wrote: It's a good idea. We've talked in the past about allowing webapps to specify a manifest which (among other things) includes the list of protocols that they wish to support. When a webapp is installed via Create Application Shortcuts, we could add Chrome to the Windows list on behalf of the webapp. There's also the registerProtocolHandler component of one of the WHAT Web Apps specs. Definitely something we're considering, but no immediate implementation plans. -Ben On Fri, Jun 26, 2009 at 7:07 PM, Robert Daileyrcdai...@gmail.com wrote: This is only somewhat related to Chromium, but I'm asking here because the chromium developers might be the most likely to know the answer. I currently am running Windows 7 Ultimate x64, and I want to associate mailto: links that I click in Chromium (and anywhere, really) to be associated to a new window popping up in Chromium that opens a new email composition in GMail. I know the command for this (it involves -- app), but that doesn't do me any good if I can't put it anywhere. On windows xp, all I had to do was find the MAILTO file type and associate the appropriate command with it and everything worked. But in Windows 7 I do not have a MAILTO protocol. I go to Control Panel Default Programs Set Default Programs Chromium Choose defaults for this program. In this window, I have FTP, HTTP, and HTTPS protocols, but no MAILTO protocol. I'm assuming this is because I have no email client installed on my operating system, and Windows 7 acts dumb and doesn't even make MAILTO available since it does not detect an email client. That's just my speculation, though. Even if MAILTO was available, I don't think it would help because Windows 7 seems to have taken away the ability to associate a command with a protocol, like what was previously possible in Windows XP. Any ideas on this? --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Should GYP files be UTF8 Encoded?
The intention was ascii AFAIK. Unless someone has a use case? -BradN On Fri, Jun 26, 2009 at 3:05 PM, Daniel Cowx daniel.c...@gmail.com wrote: Not that I'm aware of. Just wanted to confirm that intention is ASCII for now unless need arises. On Jun 26, 2:18 pm, Dan Kegel daniel.r.ke...@gmail.com wrote: On Fri, Jun 26, 2009 at 1:50 PM, Daniel Cowxdaniel.c...@gmail.com wrote: Should GYP files be UTF8 Encoded? We can probably get away with ascii for now... are there any filenames that really need to be in a wider character set? --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
