[jira] [Comment Edited] (CASSANDRA-15907) Operational Improvements & Hardening for Replica Filtering Protection
[
https://issues.apache.org/jira/browse/CASSANDRA-15907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166770#comment-17166770
]
Caleb Rackliffe edited comment on CASSANDRA-15907 at 7/29/20, 5:46 AM:
---
[~adelapena] Here are the final PRs and test runs (with not ALL commits
squashed just yet, to make reviewing the small bits you might not have reviewed
yet easier):
3.0: [patch|https://github.com/apache/cassandra/pull/659/commits],
[CircleCI|https://app.circleci.com/pipelines/github/maedhroz/cassandra/89/workflows/b6192a9d-774a-4453-95c1-34d46acedcf4]
3.11: [patch|https://github.com/apache/cassandra/pull/665/commits],
[CircleCI|https://app.circleci.com/pipelines/github/maedhroz/cassandra/88/workflows/4af8d5a3-280d-449a-a650-d3ff2db5b0f4]
({{SASIIndexTest#testIndexMemtableSwitching}} is a known failure)
trunk: [patch|https://github.com/apache/cassandra/pull/666/commits], [CircleCI
J8|https://app.circleci.com/pipelines/github/maedhroz/cassandra/92/workflows/c59be4f8-329e-4d76-9c59-d49c38e58dd2],
[CircleCI
J11|https://app.circleci.com/pipelines/github/maedhroz/cassandra/92/workflows/56130350-62b0-48c3-b675-bdc45e3cebf2]
The [one
failure|https://app.circleci.com/pipelines/github/maedhroz/cassandra/92/workflows/c59be4f8-329e-4d76-9c59-d49c38e58dd2/jobs/448]
in {{TestBootstrap}} is an existing problem, but it doesn't appear to have a
flakey test Jira.
Let me know if you'd like me to do a final squash at some point. Thanks for all
your help on this one!
was (Author: maedhroz):
[~adelapena] Here are the final PRs and test runs (with not ALL commits
squashed just yet, to make reviewing the small bits you might not have reviewed
yet easier):
3.0: [patch|https://github.com/apache/cassandra/pull/659/commits],
[CircleCI|https://app.circleci.com/pipelines/github/maedhroz/cassandra/89/workflows/b6192a9d-774a-4453-95c1-34d46acedcf4]
3.11: [patch|https://github.com/apache/cassandra/pull/665/commits],
[CircleCI|https://app.circleci.com/pipelines/github/maedhroz/cassandra/88/workflows/4af8d5a3-280d-449a-a650-d3ff2db5b0f4]
({{SASIIndexTest#testIndexMemtableSwitching}} is a known failure)
trunk: [patch|https://github.com/apache/cassandra/pull/666/commits], [CircleCI
J8|https://app.circleci.com/pipelines/github/maedhroz/cassandra/92/workflows/c59be4f8-329e-4d76-9c59-d49c38e58dd2],
[CircleCI
J11|https://app.circleci.com/pipelines/github/maedhroz/cassandra/92/workflows/56130350-62b0-48c3-b675-bdc45e3cebf2]
Let me know if you'd like me to do a final squash at some point. Thanks for all
your help on this one!
> Operational Improvements & Hardening for Replica Filtering Protection
> -
>
> Key: CASSANDRA-15907
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15907
> Project: Cassandra
> Issue Type: Improvement
> Components: Consistency/Coordination, Feature/2i Index
>Reporter: Caleb Rackliffe
>Assignee: Caleb Rackliffe
>Priority: Normal
> Labels: 2i, memory
> Fix For: 3.0.x, 3.11.x, 4.0-beta
>
> Time Spent: 8h
> Remaining Estimate: 0h
>
> CASSANDRA-8272 uses additional space on the heap to ensure correctness for 2i
> and filtering queries at consistency levels above ONE/LOCAL_ONE. There are a
> few things we should follow up on, however, to make life a bit easier for
> operators and generally de-risk usage:
> (Note: Line numbers are based on {{trunk}} as of
> {{3cfe3c9f0dcf8ca8b25ad111800a21725bf152cb}}.)
> *Minor Optimizations*
> * {{ReplicaFilteringProtection:114}} - Given we size them up-front, we may be
> able to use simple arrays instead of lists for {{rowsToFetch}} and
> {{originalPartitions}}. Alternatively (or also), we may be able to null out
> references in these two collections more aggressively. (ex. Using
> {{ArrayList#set()}} instead of {{get()}} in {{queryProtectedPartitions()}},
> assuming we pass {{toFetch}} as an argument to {{querySourceOnKey()}}.)
> * {{ReplicaFilteringProtection:323}} - We may be able to use
> {{EncodingStats.merge()}} and remove the custom {{stats()}} method.
> * {{DataResolver:111 & 228}} - Cache an instance of
> {{UnaryOperator#identity()}} instead of creating one on the fly.
> * {{ReplicaFilteringProtection:217}} - We may be able to scatter/gather
> rather than serially querying every row that needs to be completed. This
> isn't a clear win perhaps, given it targets the latency of single queries and
> adds some complexity. (Certainly a decent candidate to kick even out of this
> issue.)
> *Documentation and Intelligibility*
> * There are a few places (CHANGES.txt, tracing output in
> {{ReplicaFilteringProtection}}, etc.) where we mention "replica-side
> filtering protection" (which makes it seem like the coordinator doesn't
> filter)
[jira] [Comment Edited] (CASSANDRA-15907) Operational Improvements & Hardening for Replica Filtering Protection
[
https://issues.apache.org/jira/browse/CASSANDRA-15907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166770#comment-17166770
]
Caleb Rackliffe edited comment on CASSANDRA-15907 at 7/29/20, 4:27 AM:
---
[~adelapena] Here are the final PRs and test runs (with not ALL commits
squashed just yet, to make reviewing the small bits you might not have reviewed
yet easier):
3.0: [patch|https://github.com/apache/cassandra/pull/659/commits],
[CircleCI|https://app.circleci.com/pipelines/github/maedhroz/cassandra/89/workflows/b6192a9d-774a-4453-95c1-34d46acedcf4]
3.11: [patch|https://github.com/apache/cassandra/pull/665/commits],
[CircleCI|https://app.circleci.com/pipelines/github/maedhroz/cassandra/88/workflows/4af8d5a3-280d-449a-a650-d3ff2db5b0f4]
({{SASIIndexTest#testIndexMemtableSwitching}} is a known failure)
trunk: [patch|https://github.com/apache/cassandra/pull/666/commits], [CircleCI
J8|https://app.circleci.com/pipelines/github/maedhroz/cassandra/92/workflows/c59be4f8-329e-4d76-9c59-d49c38e58dd2],
[CircleCI
J11|https://app.circleci.com/pipelines/github/maedhroz/cassandra/92/workflows/56130350-62b0-48c3-b675-bdc45e3cebf2]
Let me know if you'd like me to do a final squash at some point. Thanks for all
your help on this one!
was (Author: maedhroz):
[~adelapena] Here are the final PRs and test runs (with not ALL commits
squashed just yet, to make reviewing the small bits you might not have reviewed
yet easier):
3.0: [patch|https://github.com/apache/cassandra/pull/659/commits],
[CircleCI|https://app.circleci.com/pipelines/github/maedhroz/cassandra/89/workflows/b6192a9d-774a-4453-95c1-34d46acedcf4]
3.11: [patch|https://github.com/apache/cassandra/pull/665/commits],
[CircleCI|https://app.circleci.com/pipelines/github/maedhroz/cassandra/88/workflows/4af8d5a3-280d-449a-a650-d3ff2db5b0f4]
({{SASIIndexTest#testIndexMemtableSwitching}} is a known failure)
trunk: [patch|https://github.com/apache/cassandra/pull/666/commits], [CircleCI
J8|https://app.circleci.com/pipelines/github/maedhroz/cassandra/91/workflows/b1bd958d-2abf-48ff-a39c-4b43c3fc6008],
[CircleCI
J11|https://app.circleci.com/pipelines/github/maedhroz/cassandra/91/workflows/32a03dbd-2062-4a8a-914f-7dacf2ed1a59]
Let me know if you'd like me to do a final squash at some point. Thanks for all
your help on this one!
> Operational Improvements & Hardening for Replica Filtering Protection
> -
>
> Key: CASSANDRA-15907
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15907
> Project: Cassandra
> Issue Type: Improvement
> Components: Consistency/Coordination, Feature/2i Index
>Reporter: Caleb Rackliffe
>Assignee: Caleb Rackliffe
>Priority: Normal
> Labels: 2i, memory
> Fix For: 3.0.x, 3.11.x, 4.0-beta
>
> Time Spent: 8h
> Remaining Estimate: 0h
>
> CASSANDRA-8272 uses additional space on the heap to ensure correctness for 2i
> and filtering queries at consistency levels above ONE/LOCAL_ONE. There are a
> few things we should follow up on, however, to make life a bit easier for
> operators and generally de-risk usage:
> (Note: Line numbers are based on {{trunk}} as of
> {{3cfe3c9f0dcf8ca8b25ad111800a21725bf152cb}}.)
> *Minor Optimizations*
> * {{ReplicaFilteringProtection:114}} - Given we size them up-front, we may be
> able to use simple arrays instead of lists for {{rowsToFetch}} and
> {{originalPartitions}}. Alternatively (or also), we may be able to null out
> references in these two collections more aggressively. (ex. Using
> {{ArrayList#set()}} instead of {{get()}} in {{queryProtectedPartitions()}},
> assuming we pass {{toFetch}} as an argument to {{querySourceOnKey()}}.)
> * {{ReplicaFilteringProtection:323}} - We may be able to use
> {{EncodingStats.merge()}} and remove the custom {{stats()}} method.
> * {{DataResolver:111 & 228}} - Cache an instance of
> {{UnaryOperator#identity()}} instead of creating one on the fly.
> * {{ReplicaFilteringProtection:217}} - We may be able to scatter/gather
> rather than serially querying every row that needs to be completed. This
> isn't a clear win perhaps, given it targets the latency of single queries and
> adds some complexity. (Certainly a decent candidate to kick even out of this
> issue.)
> *Documentation and Intelligibility*
> * There are a few places (CHANGES.txt, tracing output in
> {{ReplicaFilteringProtection}}, etc.) where we mention "replica-side
> filtering protection" (which makes it seem like the coordinator doesn't
> filter) rather than "replica filtering protection" (which sounds more like
> what we actually do, which is protect ourselves against incorrect replica
> filtering results). It's a minor fix, but would avoid confusion.
> * The method call chain
[jira] [Comment Edited] (CASSANDRA-15907) Operational Improvements & Hardening for Replica Filtering Protection
[
https://issues.apache.org/jira/browse/CASSANDRA-15907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166770#comment-17166770
]
Caleb Rackliffe edited comment on CASSANDRA-15907 at 7/29/20, 4:18 AM:
---
[~adelapena] Here are the final PRs and test runs (with not ALL commits
squashed just yet, to make reviewing the small bits you might not have reviewed
yet easier):
3.0: [patch|https://github.com/apache/cassandra/pull/659/commits],
[CircleCI|https://app.circleci.com/pipelines/github/maedhroz/cassandra/89/workflows/b6192a9d-774a-4453-95c1-34d46acedcf4]
3.11: [patch|https://github.com/apache/cassandra/pull/665/commits],
[CircleCI|https://app.circleci.com/pipelines/github/maedhroz/cassandra/88/workflows/4af8d5a3-280d-449a-a650-d3ff2db5b0f4]
({{SASIIndexTest#testIndexMemtableSwitching}} is a known failure)
trunk: [patch|https://github.com/apache/cassandra/pull/666/commits], [CircleCI
J8|https://app.circleci.com/pipelines/github/maedhroz/cassandra/91/workflows/b1bd958d-2abf-48ff-a39c-4b43c3fc6008],
[CircleCI
J11|https://app.circleci.com/pipelines/github/maedhroz/cassandra/91/workflows/32a03dbd-2062-4a8a-914f-7dacf2ed1a59]
Let me know if you'd like me to do a final squash at some point. Thanks for all
your help on this one!
was (Author: maedhroz):
[~adelapena] Here are the final PRs and test runs (with not ALL commits
squashed just yet, to make reviewing the small bits you might not have reviewed
yet easier):
3.0: [patch|https://github.com/apache/cassandra/pull/659/commits],
[CircleCI|https://app.circleci.com/pipelines/github/maedhroz/cassandra/89/workflows/b6192a9d-774a-4453-95c1-34d46acedcf4]
3.11: [patch|https://github.com/apache/cassandra/pull/665/commits],
[CircleCI|https://app.circleci.com/pipelines/github/maedhroz/cassandra/88/workflows/6c0cd966-f55a-4c3c-b78a-81724134cce3]
({{SASIIndexTest#testIndexMemtableSwitching}} is a known failure)
{{TestCompression::test_compression_cql_options}} looks like it might be an
unreported failure.
trunk: [patch|https://github.com/apache/cassandra/pull/666/commits], [CircleCI
J8|https://app.circleci.com/pipelines/github/maedhroz/cassandra/91/workflows/b1bd958d-2abf-48ff-a39c-4b43c3fc6008],
[CircleCI
J11|https://app.circleci.com/pipelines/github/maedhroz/cassandra/91/workflows/32a03dbd-2062-4a8a-914f-7dacf2ed1a59]
Let me know if you'd like me to do a final squash at some point. Thanks for all
your help on this one!
> Operational Improvements & Hardening for Replica Filtering Protection
> -
>
> Key: CASSANDRA-15907
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15907
> Project: Cassandra
> Issue Type: Improvement
> Components: Consistency/Coordination, Feature/2i Index
>Reporter: Caleb Rackliffe
>Assignee: Caleb Rackliffe
>Priority: Normal
> Labels: 2i, memory
> Fix For: 3.0.x, 3.11.x, 4.0-beta
>
> Time Spent: 8h
> Remaining Estimate: 0h
>
> CASSANDRA-8272 uses additional space on the heap to ensure correctness for 2i
> and filtering queries at consistency levels above ONE/LOCAL_ONE. There are a
> few things we should follow up on, however, to make life a bit easier for
> operators and generally de-risk usage:
> (Note: Line numbers are based on {{trunk}} as of
> {{3cfe3c9f0dcf8ca8b25ad111800a21725bf152cb}}.)
> *Minor Optimizations*
> * {{ReplicaFilteringProtection:114}} - Given we size them up-front, we may be
> able to use simple arrays instead of lists for {{rowsToFetch}} and
> {{originalPartitions}}. Alternatively (or also), we may be able to null out
> references in these two collections more aggressively. (ex. Using
> {{ArrayList#set()}} instead of {{get()}} in {{queryProtectedPartitions()}},
> assuming we pass {{toFetch}} as an argument to {{querySourceOnKey()}}.)
> * {{ReplicaFilteringProtection:323}} - We may be able to use
> {{EncodingStats.merge()}} and remove the custom {{stats()}} method.
> * {{DataResolver:111 & 228}} - Cache an instance of
> {{UnaryOperator#identity()}} instead of creating one on the fly.
> * {{ReplicaFilteringProtection:217}} - We may be able to scatter/gather
> rather than serially querying every row that needs to be completed. This
> isn't a clear win perhaps, given it targets the latency of single queries and
> adds some complexity. (Certainly a decent candidate to kick even out of this
> issue.)
> *Documentation and Intelligibility*
> * There are a few places (CHANGES.txt, tracing output in
> {{ReplicaFilteringProtection}}, etc.) where we mention "replica-side
> filtering protection" (which makes it seem like the coordinator doesn't
> filter) rather than "replica filtering protection" (which sounds more like
> what we actually do, which is protect ourselves against incorrect
[jira] [Comment Edited] (CASSANDRA-15907) Operational Improvements & Hardening for Replica Filtering Protection
[
https://issues.apache.org/jira/browse/CASSANDRA-15907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166770#comment-17166770
]
Caleb Rackliffe edited comment on CASSANDRA-15907 at 7/29/20, 4:03 AM:
---
[~adelapena] Here are the final PRs and test runs (with not ALL commits
squashed just yet, to make reviewing the small bits you might not have reviewed
yet easier):
3.0: [patch|https://github.com/apache/cassandra/pull/659/commits],
[CircleCI|https://app.circleci.com/pipelines/github/maedhroz/cassandra/89/workflows/b6192a9d-774a-4453-95c1-34d46acedcf4]
3.11: [patch|https://github.com/apache/cassandra/pull/665/commits],
[CircleCI|https://app.circleci.com/pipelines/github/maedhroz/cassandra/88/workflows/6c0cd966-f55a-4c3c-b78a-81724134cce3]
({{SASIIndexTest#testIndexMemtableSwitching}} is a known failure)
{{TestCompression::test_compression_cql_options}} looks like it might be an
unreported failure.
trunk: [patch|https://github.com/apache/cassandra/pull/666/commits], [CircleCI
J8|https://app.circleci.com/pipelines/github/maedhroz/cassandra/91/workflows/b1bd958d-2abf-48ff-a39c-4b43c3fc6008],
[CircleCI
J11|https://app.circleci.com/pipelines/github/maedhroz/cassandra/91/workflows/32a03dbd-2062-4a8a-914f-7dacf2ed1a59]
Let me know if you'd like me to do a final squash at some point. Thanks for all
your help on this one!
was (Author: maedhroz):
[~adelapena] Here are the final PRs and test runs (with not ALL commits
squashed just yet, to make reviewing the small bits you might not have reviewed
yet easier):
3.0: [patch|https://github.com/apache/cassandra/pull/659/commits],
[CircleCI|https://app.circleci.com/pipelines/github/maedhroz/cassandra/89/workflows/b6192a9d-774a-4453-95c1-34d46acedcf4]
3.11: [patch|https://github.com/apache/cassandra/pull/665/commits],
[CircleCI|https://app.circleci.com/pipelines/github/maedhroz/cassandra/88/workflows/6c0cd966-f55a-4c3c-b78a-81724134cce3]
({{SASIIndexTest#testIndexMemtableSwitching}} is a known failure)
{{TestCompression::test_compression_cql_options}} looks like it might be an
unreported failure.
trunk: [patch|https://github.com/apache/cassandra/pull/666/commits], [CircleCI
J8|https://app.circleci.com/pipelines/github/maedhroz/cassandra/90/workflows/2804223b-0b3b-4da4-a180-733f67d179a5],
[CircleCI
J11|https://app.circleci.com/pipelines/github/maedhroz/cassandra/90/workflows/51c944a3-ac7e-4e15-acc2-a92844967d9e]
Let me know if you'd like me to do a final squash at some point. Thanks for all
your help on this one!
> Operational Improvements & Hardening for Replica Filtering Protection
> -
>
> Key: CASSANDRA-15907
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15907
> Project: Cassandra
> Issue Type: Improvement
> Components: Consistency/Coordination, Feature/2i Index
>Reporter: Caleb Rackliffe
>Assignee: Caleb Rackliffe
>Priority: Normal
> Labels: 2i, memory
> Fix For: 3.0.x, 3.11.x, 4.0-beta
>
> Time Spent: 8h
> Remaining Estimate: 0h
>
> CASSANDRA-8272 uses additional space on the heap to ensure correctness for 2i
> and filtering queries at consistency levels above ONE/LOCAL_ONE. There are a
> few things we should follow up on, however, to make life a bit easier for
> operators and generally de-risk usage:
> (Note: Line numbers are based on {{trunk}} as of
> {{3cfe3c9f0dcf8ca8b25ad111800a21725bf152cb}}.)
> *Minor Optimizations*
> * {{ReplicaFilteringProtection:114}} - Given we size them up-front, we may be
> able to use simple arrays instead of lists for {{rowsToFetch}} and
> {{originalPartitions}}. Alternatively (or also), we may be able to null out
> references in these two collections more aggressively. (ex. Using
> {{ArrayList#set()}} instead of {{get()}} in {{queryProtectedPartitions()}},
> assuming we pass {{toFetch}} as an argument to {{querySourceOnKey()}}.)
> * {{ReplicaFilteringProtection:323}} - We may be able to use
> {{EncodingStats.merge()}} and remove the custom {{stats()}} method.
> * {{DataResolver:111 & 228}} - Cache an instance of
> {{UnaryOperator#identity()}} instead of creating one on the fly.
> * {{ReplicaFilteringProtection:217}} - We may be able to scatter/gather
> rather than serially querying every row that needs to be completed. This
> isn't a clear win perhaps, given it targets the latency of single queries and
> adds some complexity. (Certainly a decent candidate to kick even out of this
> issue.)
> *Documentation and Intelligibility*
> * There are a few places (CHANGES.txt, tracing output in
> {{ReplicaFilteringProtection}}, etc.) where we mention "replica-side
> filtering protection" (which makes it seem like the coordinator doesn't
> filter) rather than "replica filtering protection"
[jira] [Comment Edited] (CASSANDRA-15907) Operational Improvements & Hardening for Replica Filtering Protection
[
https://issues.apache.org/jira/browse/CASSANDRA-15907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166770#comment-17166770
]
Caleb Rackliffe edited comment on CASSANDRA-15907 at 7/29/20, 3:51 AM:
---
[~adelapena] Here are the final PRs and test runs (with not ALL commits
squashed just yet, to make reviewing the small bits you might not have reviewed
yet easier):
3.0: [patch|https://github.com/apache/cassandra/pull/659/commits],
[CircleCI|https://app.circleci.com/pipelines/github/maedhroz/cassandra/89/workflows/b6192a9d-774a-4453-95c1-34d46acedcf4]
3.11: [patch|https://github.com/apache/cassandra/pull/665/commits],
[CircleCI|https://app.circleci.com/pipelines/github/maedhroz/cassandra/88/workflows/6c0cd966-f55a-4c3c-b78a-81724134cce3]
({{SASIIndexTest#testIndexMemtableSwitching}} is a known failure)
{{TestCompression::test_compression_cql_options}} looks like it might be an
unreported failure.
trunk: [patch|https://github.com/apache/cassandra/pull/666/commits], [CircleCI
J8|https://app.circleci.com/pipelines/github/maedhroz/cassandra/90/workflows/2804223b-0b3b-4da4-a180-733f67d179a5],
[CircleCI
J11|https://app.circleci.com/pipelines/github/maedhroz/cassandra/90/workflows/51c944a3-ac7e-4e15-acc2-a92844967d9e]
Let me know if you'd like me to do a final squash at some point. Thanks for all
your help on this one!
was (Author: maedhroz):
[~adelapena] Here are the final PRs and test runs (with not ALL commits
squashed just yet, to make reviewing the small bits you might not have reviewed
yet easier):
3.0: [patch|https://github.com/apache/cassandra/pull/659/commits],
[CircleCI|https://app.circleci.com/pipelines/github/maedhroz/cassandra/89/workflows/b6192a9d-774a-4453-95c1-34d46acedcf4]
3.11: [patch|https://github.com/apache/cassandra/pull/665/commits],
[CircleCI|https://app.circleci.com/pipelines/github/maedhroz/cassandra/88/workflows/6c0cd966-f55a-4c3c-b78a-81724134cce3]
({{SASIIndexTest#testIndexMemtableSwitching}} is a known failure)
trunk: [patch|https://github.com/apache/cassandra/pull/666/commits], [CircleCI
J8|https://app.circleci.com/pipelines/github/maedhroz/cassandra/90/workflows/2804223b-0b3b-4da4-a180-733f67d179a5],
[CircleCI
J11|https://app.circleci.com/pipelines/github/maedhroz/cassandra/90/workflows/51c944a3-ac7e-4e15-acc2-a92844967d9e]
Let me know if you'd like me to do a final squash at some point. Thanks for all
your help on this one!
> Operational Improvements & Hardening for Replica Filtering Protection
> -
>
> Key: CASSANDRA-15907
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15907
> Project: Cassandra
> Issue Type: Improvement
> Components: Consistency/Coordination, Feature/2i Index
>Reporter: Caleb Rackliffe
>Assignee: Caleb Rackliffe
>Priority: Normal
> Labels: 2i, memory
> Fix For: 3.0.x, 3.11.x, 4.0-beta
>
> Time Spent: 8h
> Remaining Estimate: 0h
>
> CASSANDRA-8272 uses additional space on the heap to ensure correctness for 2i
> and filtering queries at consistency levels above ONE/LOCAL_ONE. There are a
> few things we should follow up on, however, to make life a bit easier for
> operators and generally de-risk usage:
> (Note: Line numbers are based on {{trunk}} as of
> {{3cfe3c9f0dcf8ca8b25ad111800a21725bf152cb}}.)
> *Minor Optimizations*
> * {{ReplicaFilteringProtection:114}} - Given we size them up-front, we may be
> able to use simple arrays instead of lists for {{rowsToFetch}} and
> {{originalPartitions}}. Alternatively (or also), we may be able to null out
> references in these two collections more aggressively. (ex. Using
> {{ArrayList#set()}} instead of {{get()}} in {{queryProtectedPartitions()}},
> assuming we pass {{toFetch}} as an argument to {{querySourceOnKey()}}.)
> * {{ReplicaFilteringProtection:323}} - We may be able to use
> {{EncodingStats.merge()}} and remove the custom {{stats()}} method.
> * {{DataResolver:111 & 228}} - Cache an instance of
> {{UnaryOperator#identity()}} instead of creating one on the fly.
> * {{ReplicaFilteringProtection:217}} - We may be able to scatter/gather
> rather than serially querying every row that needs to be completed. This
> isn't a clear win perhaps, given it targets the latency of single queries and
> adds some complexity. (Certainly a decent candidate to kick even out of this
> issue.)
> *Documentation and Intelligibility*
> * There are a few places (CHANGES.txt, tracing output in
> {{ReplicaFilteringProtection}}, etc.) where we mention "replica-side
> filtering protection" (which makes it seem like the coordinator doesn't
> filter) rather than "replica filtering protection" (which sounds more like
> what we actually do, which is protect ourselves against incorrect
[jira] [Updated] (CASSANDRA-14608) Confirm correctness of windows scripts post-9608
[ https://issues.apache.org/jira/browse/CASSANDRA-14608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuki Morishita updated CASSANDRA-14608: --- Fix Version/s: 4.0-rc > Confirm correctness of windows scripts post-9608 > > > Key: CASSANDRA-14608 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14608 > Project: Cassandra > Issue Type: Task > Environment: Windows >Reporter: Jason Brown >Priority: Urgent > Fix For: 4.0-rc > > > In CASSANDRA-9608, we chose to defer making all the changes to Windows > scripts. This ticket is to ensure that we do that work. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14608) Confirm correctness of windows scripts post-9608
[ https://issues.apache.org/jira/browse/CASSANDRA-14608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuki Morishita updated CASSANDRA-14608: --- Authors: Yuki Morishita Test and Documentation Plan: The patch needs Windows environment with JDK8/JDK11 for review. There is no windows CI environments at the moment. Status: Patch Available (was: Open) [https://github.com/apache/cassandra/pull/701] Patch to read corresponding jvm-*.options based on java version. Also removed Sigar lib since it does not work for JDK11 and the recent JDK8. > Confirm correctness of windows scripts post-9608 > > > Key: CASSANDRA-14608 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14608 > Project: Cassandra > Issue Type: Task > Environment: Windows >Reporter: Jason Brown >Priority: Urgent > > In CASSANDRA-9608, we chose to defer making all the changes to Windows > scripts. This ticket is to ensure that we do that work. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-3.11' into trunk
This is an automated email from the ASF dual-hosted git repository. dcapwell pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 7f9b4f6a744a295befed281c9f570eeb47b99df4 Merge: a2c3d5a dd4ca8e Author: David Capwell AuthorDate: Tue Jul 28 18:02:50 2020 -0700 Merge branch 'cassandra-3.11' into trunk src/java/org/apache/cassandra/tools/NodeProbe.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15970) 3.x fails to start if commit log has range tombstones from a column which is also deleted
[
https://issues.apache.org/jira/browse/CASSANDRA-15970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Capwell updated CASSANDRA-15970:
--
Fix Version/s: (was: 3.11.x)
(was: 3.0.x)
3.11.8
3.0.22
Since Version: 3.0.0
Source Control Link:
https://github.com/apache/cassandra/commit/4b0c0817fa7b8e12a8e6cf96a9a2b67f36b449e8
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
not tagging 2.2 or trunk since the changes are utilities and keeping things
in-sync; the bug was in 3.x so fixed version is only 3.x
2.2 CI:
https://app.circleci.com/pipelines/github/dcapwell/cassandra/359/workflows/83812acb-5ae9-4cdd-9dc2-e054ab2169a9
Green
Disabled python dtest
3.0 CI:
https://app.circleci.com/pipelines/github/dcapwell/cassandra/360/workflows/8e93a655-b66e-4bf2-8866-5f9a46487763
Yellow
* https://issues.apache.org/jira/browse/CASSANDRA-15984
(thrift_hsha_test.TestThriftHSHA test_closing_connections is broken on 3.0 and
3.11)
* dropColumns -
org.apache.cassandra.distributed.upgrade.MigrateDropColumnsTest. This is
expected as the yaml used didn't replace the GitHub links, prior to the rebase
it was working in
https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=bug%2FCASSANDRA-15970-3.0
* https://issues.apache.org/jira/browse/CASSANDRA-15994
3.11 CI:
https://app.circleci.com/pipelines/github/dcapwell/cassandra/361/workflows/3a42fa45-1f60-4c95-86a4-15a6773e384e
Yellow
* https://issues.apache.org/jira/browse/CASSANDRA-15984
(thrift_hsha_test.TestThriftHSHA test_closing_connections is broken on 3.0 and
3.11)
* dropColumns -
org.apache.cassandra.distributed.upgrade.MigrateDropColumnsTest. This is
expected as the yaml used didn't replace the GitHub links, prior to the rebase
it was working in
https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=bug%2FCASSANDRA-15970-3.11
* https://issues.apache.org/jira/browse/CASSANDRA-15995
* https://issues.apache.org/jira/browse/CASSANDRA-15996
Trunk CI:
https://app.circleci.com/pipelines/github/dcapwell/cassandra/362/workflows/c04020b0-d13e-4e18-ae27-0277e636b73d
Yellow
* https://issues.apache.org/jira/browse/CASSANDRA-15958
> 3.x fails to start if commit log has range tombstones from a column which is
> also deleted
> -
>
> Key: CASSANDRA-15970
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15970
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Local Write-Read Paths, Local/Commit Log
>Reporter: David Capwell
>Assignee: David Capwell
>Priority: Normal
> Fix For: 3.0.22, 3.11.8
>
>
> Cassandra crashes with the following exception
> {code}
> ERROR [node1_isolatedExecutor:1] node1 2020-07-21 18:59:39,048
> JVMStabilityInspector.java:102 - Exiting due to error while processing commit
> log during initialization.
> org.apache.cassandra.db.commitlog.CommitLogReplayer$CommitLogReplayException:
> Unexpected error deserializing mutation; saved to
> /var/folders/cm/08cddl2s25j7fq3jdb76gh4rgn/T/mutation6239873170066752296dat.
> This may be caused by replaying a mutation against a table with the same
> name but incompatible schema.
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.handleReplayError(CommitLogReplayer.java:731)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.replayMutation(CommitLogReplayer.java:656)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.replaySyncSection(CommitLogReplayer.java:609)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.recover(CommitLogReplayer.java:493)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.recover(CommitLogReplayer.java:189)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLog.recover(CommitLog.java:170)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLog.recover(CommitLog.java:151)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.distributed.impl.Instance.lambda$startup$7(Instance.java:535)
> [dtest-3.0.21.jar:na]
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> ~[na:1.8.0_242]
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> ~[na:1.8.0_242]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> ~[na:1.8.0_242]
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> ~[na:1.8.0_242]
> at
>
[cassandra] branch cassandra-3.0 updated (dc725bc -> 4b0c081)
This is an automated email from the ASF dual-hosted git repository. dcapwell pushed a change to branch cassandra-3.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git. from dc725bc Forbid altering UDTs used in partition keys new b905397 3.x fails to start if commit log has range tombstones from a column which is also deleted new 4b0c081 Merge branch 'cassandra-2.2' into cassandra-3.0 The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGES.txt| 1 + src/java/org/apache/cassandra/db/LegacyLayout.java | 2 + .../org/apache/cassandra/utils/ByteBufferUtil.java | 2 + .../upgrade/MigrateDropColumnsTest.java| 106 + 4 files changed, 111 insertions(+) create mode 100644 test/distributed/org/apache/cassandra/distributed/upgrade/MigrateDropColumnsTest.java - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-2.2' into cassandra-3.0
This is an automated email from the ASF dual-hosted git repository.
dcapwell pushed a commit to branch cassandra-3.0
in repository https://gitbox.apache.org/repos/asf/cassandra.git
commit 4b0c0817fa7b8e12a8e6cf96a9a2b67f36b449e8
Merge: dc725bc b905397
Author: David Capwell
AuthorDate: Tue Jul 28 17:56:49 2020 -0700
Merge branch 'cassandra-2.2' into cassandra-3.0
CHANGES.txt| 1 +
src/java/org/apache/cassandra/db/LegacyLayout.java | 2 +
.../org/apache/cassandra/utils/ByteBufferUtil.java | 2 +
.../upgrade/MigrateDropColumnsTest.java| 106 +
4 files changed, 111 insertions(+)
diff --cc CHANGES.txt
index a42de51,439ef5d..d22ba43
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@@ -1,7 -1,4 +1,8 @@@
-2.2.18
+3.0.22:
++ * 3.x fails to start if commit log has range tombstones from a column which
is also deleted (CASSANDRA-15970)
+ * Forbid altering UDTs used in partition keys (CASSANDRA-15933)
+ * Fix empty/null json string representation (CASSANDRA-15896)
+Merged from 2.2:
* Fix CQL parsing of collections when the column type is reversed
(CASSANDRA-15814)
diff --cc src/java/org/apache/cassandra/db/LegacyLayout.java
index 8492de5,000..e58603a
mode 100644,00..100644
--- a/src/java/org/apache/cassandra/db/LegacyLayout.java
+++ b/src/java/org/apache/cassandra/db/LegacyLayout.java
@@@ -1,2793 -1,0 +1,2795 @@@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.cassandra.db;
+
+import java.io.DataInput;
+import java.io.IOException;
+import java.io.IOError;
+import java.nio.ByteBuffer;
+import java.security.MessageDigest;
+import java.util.*;
+import java.util.concurrent.TimeUnit;
+import java.util.stream.Collectors;
+
+import org.apache.cassandra.cql3.ColumnIdentifier;
+import org.apache.cassandra.cql3.SuperColumnCompatibility;
+import org.apache.cassandra.utils.AbstractIterator;
+
+import com.google.common.annotations.VisibleForTesting;
+import com.google.common.collect.Iterators;
+import com.google.common.collect.Lists;
+import com.google.common.collect.PeekingIterator;
+
+import org.apache.cassandra.config.CFMetaData;
+import org.apache.cassandra.config.ColumnDefinition;
+import org.apache.cassandra.db.filter.ColumnFilter;
+import org.apache.cassandra.db.filter.DataLimits;
+import org.apache.cassandra.db.rows.*;
+import org.apache.cassandra.db.partitions.*;
+import org.apache.cassandra.db.context.CounterContext;
+import org.apache.cassandra.db.marshal.*;
+import org.apache.cassandra.io.util.DataInputPlus;
+import org.apache.cassandra.io.util.DataOutputPlus;
+import org.apache.cassandra.net.MessagingService;
+import org.apache.cassandra.utils.*;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import static com.google.common.collect.Iterables.all;
+import static org.apache.cassandra.utils.ByteBufferUtil.bytes;
+
+/**
+ * Functions to deal with the old format.
+ */
+public abstract class LegacyLayout
+{
+private static final Logger logger =
LoggerFactory.getLogger(LegacyLayout.class);
+private static final NoSpamLogger noSpamLogger =
NoSpamLogger.getLogger(logger, 1L, TimeUnit.MINUTES);
+
+public final static int MAX_CELL_NAME_LENGTH =
FBUtilities.MAX_UNSIGNED_SHORT;
+
+public final static int STATIC_PREFIX = 0x;
+
+public final static int DELETION_MASK= 0x01;
+public final static int EXPIRATION_MASK = 0x02;
+public final static int COUNTER_MASK = 0x04;
+public final static int COUNTER_UPDATE_MASK = 0x08;
+private final static int RANGE_TOMBSTONE_MASK = 0x10;
+
+// Used in decodeBound if the number of components in the legacy bound is
greater than the clustering size,
+// indicating a complex column deletion (i.e. a collection tombstone),
but the referenced column is either
+// not present in the current table metadata, or is not currently a
complex column. In that case, we'll
+// check the dropped columns for the table which should contain the
previous column definition. If that
+// previous definition is also not complex (indicating that the column
may have
[cassandra] branch trunk updated (a2c3d5a -> 7f9b4f6)
This is an automated email from the ASF dual-hosted git repository. dcapwell pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git. from a2c3d5a how_to_commit.rst missing dash in git commands, added recommendation to compile before commit, and documented that a merge -s ours is needed for older branches even if they do not impact trunk new b905397 3.x fails to start if commit log has range tombstones from a column which is also deleted new 4b0c081 Merge branch 'cassandra-2.2' into cassandra-3.0 new dd4ca8e Merge branch 'cassandra-3.0' into cassandra-3.11 new 7f9b4f6 Merge branch 'cassandra-3.11' into trunk The 4 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: src/java/org/apache/cassandra/tools/NodeProbe.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-3.0' into cassandra-3.11
This is an automated email from the ASF dual-hosted git repository.
dcapwell pushed a commit to branch cassandra-3.11
in repository https://gitbox.apache.org/repos/asf/cassandra.git
commit dd4ca8e0ad809e99185704bb3ab13e746ba94dce
Merge: c61f390 4b0c081
Author: David Capwell
AuthorDate: Tue Jul 28 18:00:37 2020 -0700
Merge branch 'cassandra-3.0' into cassandra-3.11
CHANGES.txt| 1 +
src/java/org/apache/cassandra/db/LegacyLayout.java | 2 +
src/java/org/apache/cassandra/tools/NodeProbe.java | 2 +-
.../org/apache/cassandra/utils/ByteBufferUtil.java | 2 +
.../distributed/upgrade/MigrateDropColumns.java| 113 +
.../upgrade/MigrateDropColumns22To30To311Test.java | 11 ++
.../upgrade/MigrateDropColumns22To311Test.java | 11 ++
.../upgrade/MigrateDropColumns30To311Test.java | 11 ++
8 files changed, 152 insertions(+), 1 deletion(-)
diff --cc CHANGES.txt
index 812e020,d22ba43..d6ff2e1
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@@ -1,8 -1,7 +1,9 @@@
-3.0.22:
- * 3.x fails to start if commit log has range tombstones from a column which
is also deleted (CASSANDRA-15970)
+3.11.8
+ * Frozen RawTuple is not annotated with frozen in the toString method
(CASSANDRA-15857)
+Merged from 3.0:
* Forbid altering UDTs used in partition keys (CASSANDRA-15933)
* Fix empty/null json string representation (CASSANDRA-15896)
++ * 3.x fails to start if commit log has range tombstones from a column which
is also deleted (CASSANDRA-15970)
Merged from 2.2:
* Fix CQL parsing of collections when the column type is reversed
(CASSANDRA-15814)
diff --cc src/java/org/apache/cassandra/tools/NodeProbe.java
index 2c4e409,2425821..8e712db
--- a/src/java/org/apache/cassandra/tools/NodeProbe.java
+++ b/src/java/org/apache/cassandra/tools/NodeProbe.java
@@@ -277,17 -273,10 +277,17 @@@ public class NodeProbe implements AutoC
return ssProxy.upgradeSSTables(keyspaceName, excludeCurrentVersion,
jobs, tableNames);
}
+public int garbageCollect(String tombstoneOption, int jobs, String
keyspaceName, String... tableNames) throws IOException, ExecutionException,
InterruptedException
+{
+return ssProxy.garbageCollect(tombstoneOption, jobs, keyspaceName,
tableNames);
+}
+
private void checkJobs(PrintStream out, int jobs)
{
+// TODO this should get the configured number of
concurrent_compactors via JMX and not using DatabaseDescriptor
- DatabaseDescriptor.toolInitialization();
++DatabaseDescriptor.toolInitialization(false); // if running in dtest,
this would fail if true (default)
if (jobs > DatabaseDescriptor.getConcurrentCompactors())
-out.println(String.format("jobs (%d) is bigger than configured
concurrent_compactors (%d), using at most %d threads", jobs,
DatabaseDescriptor.getConcurrentCompactors(),
DatabaseDescriptor.getConcurrentCompactors()));
+out.println(String.format("jobs (%d) is bigger than configured
concurrent_compactors (%d) on this host, using at most %d threads", jobs,
DatabaseDescriptor.getConcurrentCompactors(),
DatabaseDescriptor.getConcurrentCompactors()));
}
public void forceKeyspaceCleanup(PrintStream out, int jobs, String
keyspaceName, String... tableNames) throws IOException, ExecutionException,
InterruptedException
diff --cc
test/distributed/org/apache/cassandra/distributed/upgrade/MigrateDropColumns.java
index 000,000..c8c04d1
new file mode 100644
--- /dev/null
+++
b/test/distributed/org/apache/cassandra/distributed/upgrade/MigrateDropColumns.java
@@@ -1,0 -1,0 +1,113 @@@
++package org.apache.cassandra.distributed.upgrade;
++
++import java.util.Arrays;
++import java.util.Collections;
++import java.util.Objects;
++
++import com.google.common.collect.ImmutableMap;
++import com.google.common.collect.ImmutableSet;
++import com.google.common.collect.Sets;
++import org.junit.Assert;
++import org.junit.Test;
++
++import org.apache.cassandra.db.marshal.CompositeType;
++import org.apache.cassandra.db.marshal.Int32Type;
++import org.apache.cassandra.db.marshal.MapType;
++import org.apache.cassandra.distributed.api.ConsistencyLevel;
++import org.apache.cassandra.distributed.api.Feature;
++import org.apache.cassandra.distributed.api.ICoordinator;
++import org.apache.cassandra.distributed.api.QueryResults;
++import org.apache.cassandra.distributed.api.SimpleQueryResult;
++import org.apache.cassandra.distributed.shared.AssertUtils;
++import org.apache.cassandra.distributed.shared.Versions;
++import org.apache.cassandra.distributed.test.ThriftClientUtils;
++import org.apache.cassandra.thrift.Deletion;
++import org.apache.cassandra.thrift.Mutation;
++import org.apache.cassandra.thrift.SlicePredicate;
++import org.apache.cassandra.thrift.SliceRange;
++import org.apache.cassandra.utils.ByteBufferUtil;
++
++public abstract class MigrateDropColumns extends UpgradeTestBase
++{
++private
[cassandra] branch cassandra-3.11 updated (c61f390 -> dd4ca8e)
This is an automated email from the ASF dual-hosted git repository. dcapwell pushed a change to branch cassandra-3.11 in repository https://gitbox.apache.org/repos/asf/cassandra.git. from c61f390 Merge branch 'cassandra-3.0' into cassandra-3.11 new b905397 3.x fails to start if commit log has range tombstones from a column which is also deleted new 4b0c081 Merge branch 'cassandra-2.2' into cassandra-3.0 new dd4ca8e Merge branch 'cassandra-3.0' into cassandra-3.11 The 3 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGES.txt| 1 + src/java/org/apache/cassandra/db/LegacyLayout.java | 2 + src/java/org/apache/cassandra/tools/NodeProbe.java | 2 +- .../org/apache/cassandra/utils/ByteBufferUtil.java | 2 + .../distributed/upgrade/MigrateDropColumns.java| 113 + .../upgrade/MigrateDropColumns22To30To311Test.java | 11 ++ .../upgrade/MigrateDropColumns22To311Test.java | 11 ++ .../upgrade/MigrateDropColumns30To311Test.java | 11 ++ 8 files changed, 152 insertions(+), 1 deletion(-) create mode 100644 test/distributed/org/apache/cassandra/distributed/upgrade/MigrateDropColumns.java create mode 100644 test/distributed/org/apache/cassandra/distributed/upgrade/MigrateDropColumns22To30To311Test.java create mode 100644 test/distributed/org/apache/cassandra/distributed/upgrade/MigrateDropColumns22To311Test.java create mode 100644 test/distributed/org/apache/cassandra/distributed/upgrade/MigrateDropColumns30To311Test.java - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-2.2 updated: 3.x fails to start if commit log has range tombstones from a column which is also deleted
This is an automated email from the ASF dual-hosted git repository.
dcapwell pushed a commit to branch cassandra-2.2
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/cassandra-2.2 by this push:
new b905397 3.x fails to start if commit log has range tombstones from a
column which is also deleted
b905397 is described below
commit b9053971ee9232b774c7175a6503f54947342266
Author: David Capwell
AuthorDate: Tue Jul 28 16:17:16 2020 -0700
3.x fails to start if commit log has range tombstones from a column which
is also deleted
patch by David Capwell; reviewed by Blake Eggleston,Brandon Williams for
CASSANDRA-15970
---
src/java/org/apache/cassandra/utils/ByteBufferUtil.java | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/java/org/apache/cassandra/utils/ByteBufferUtil.java
b/src/java/org/apache/cassandra/utils/ByteBufferUtil.java
index 1779e67..a9c037e 100644
--- a/src/java/org/apache/cassandra/utils/ByteBufferUtil.java
+++ b/src/java/org/apache/cassandra/utils/ByteBufferUtil.java
@@ -432,6 +432,8 @@ public class ByteBufferUtil
return ByteBufferUtil.bytes((InetAddress) obj);
else if (obj instanceof String)
return ByteBufferUtil.bytes((String) obj);
+else if (obj instanceof ByteBuffer)
+return (ByteBuffer) obj;
else
throw new IllegalArgumentException(String.format("Cannot convert
value %s of type %s",
obj,
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-15907) Operational Improvements & Hardening for Replica Filtering Protection
[
https://issues.apache.org/jira/browse/CASSANDRA-15907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166770#comment-17166770
]
Caleb Rackliffe edited comment on CASSANDRA-15907 at 7/29/20, 12:38 AM:
[~adelapena] Here are the final PRs and test runs (with not ALL commits
squashed just yet, to make reviewing the small bits you might not have reviewed
yet easier):
3.0: [patch|https://github.com/apache/cassandra/pull/659/commits],
[CircleCI|https://app.circleci.com/pipelines/github/maedhroz/cassandra/89/workflows/b6192a9d-774a-4453-95c1-34d46acedcf4]
3.11: [patch|https://github.com/apache/cassandra/pull/665/commits],
[CircleCI|https://app.circleci.com/pipelines/github/maedhroz/cassandra/88/workflows/6c0cd966-f55a-4c3c-b78a-81724134cce3]
({{SASIIndexTest#testIndexMemtableSwitching}} is a known failure)
trunk: [patch|https://github.com/apache/cassandra/pull/666/commits], [CircleCI
J8|https://app.circleci.com/pipelines/github/maedhroz/cassandra/90/workflows/2804223b-0b3b-4da4-a180-733f67d179a5],
[CircleCI
J11|https://app.circleci.com/pipelines/github/maedhroz/cassandra/90/workflows/51c944a3-ac7e-4e15-acc2-a92844967d9e]
Let me know if you'd like me to do a final squash at some point. Thanks for all
your help on this one!
was (Author: maedhroz):
[~adelapena] Here are the final PRs and test runs (with not ALL commits
squashed just yet, to make reviewing the small bits you might not have reviewed
yet easier):
3.0: [patch|https://github.com/apache/cassandra/pull/659/commits],
[CircleCI|https://app.circleci.com/pipelines/github/maedhroz/cassandra/89/workflows/b6192a9d-774a-4453-95c1-34d46acedcf4]
3.11: [patch|https://github.com/apache/cassandra/pull/665/commits],
[CircleCI|https://app.circleci.com/pipelines/github/maedhroz/cassandra/88/workflows/6c0cd966-f55a-4c3c-b78a-81724134cce3]
trunk: [patch|https://github.com/apache/cassandra/pull/666/commits], [CircleCI
J8|https://app.circleci.com/pipelines/github/maedhroz/cassandra/90/workflows/2804223b-0b3b-4da4-a180-733f67d179a5],
[CircleCI
J11|https://app.circleci.com/pipelines/github/maedhroz/cassandra/90/workflows/51c944a3-ac7e-4e15-acc2-a92844967d9e]
Let me know if you'd like me to do a final squash at some point. Thanks for all
your help on this one!
> Operational Improvements & Hardening for Replica Filtering Protection
> -
>
> Key: CASSANDRA-15907
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15907
> Project: Cassandra
> Issue Type: Improvement
> Components: Consistency/Coordination, Feature/2i Index
>Reporter: Caleb Rackliffe
>Assignee: Caleb Rackliffe
>Priority: Normal
> Labels: 2i, memory
> Fix For: 3.0.x, 3.11.x, 4.0-beta
>
> Time Spent: 8h
> Remaining Estimate: 0h
>
> CASSANDRA-8272 uses additional space on the heap to ensure correctness for 2i
> and filtering queries at consistency levels above ONE/LOCAL_ONE. There are a
> few things we should follow up on, however, to make life a bit easier for
> operators and generally de-risk usage:
> (Note: Line numbers are based on {{trunk}} as of
> {{3cfe3c9f0dcf8ca8b25ad111800a21725bf152cb}}.)
> *Minor Optimizations*
> * {{ReplicaFilteringProtection:114}} - Given we size them up-front, we may be
> able to use simple arrays instead of lists for {{rowsToFetch}} and
> {{originalPartitions}}. Alternatively (or also), we may be able to null out
> references in these two collections more aggressively. (ex. Using
> {{ArrayList#set()}} instead of {{get()}} in {{queryProtectedPartitions()}},
> assuming we pass {{toFetch}} as an argument to {{querySourceOnKey()}}.)
> * {{ReplicaFilteringProtection:323}} - We may be able to use
> {{EncodingStats.merge()}} and remove the custom {{stats()}} method.
> * {{DataResolver:111 & 228}} - Cache an instance of
> {{UnaryOperator#identity()}} instead of creating one on the fly.
> * {{ReplicaFilteringProtection:217}} - We may be able to scatter/gather
> rather than serially querying every row that needs to be completed. This
> isn't a clear win perhaps, given it targets the latency of single queries and
> adds some complexity. (Certainly a decent candidate to kick even out of this
> issue.)
> *Documentation and Intelligibility*
> * There are a few places (CHANGES.txt, tracing output in
> {{ReplicaFilteringProtection}}, etc.) where we mention "replica-side
> filtering protection" (which makes it seem like the coordinator doesn't
> filter) rather than "replica filtering protection" (which sounds more like
> what we actually do, which is protect ourselves against incorrect replica
> filtering results). It's a minor fix, but would avoid confusion.
> * The method call chain in {{DataResolver}} might be a bit simpler if we put
> the
[jira] [Created] (CASSANDRA-15996) Fix flaky python dtest test_expiration_overflow_policy_capnowarn - ttl_test.TestTTL
David Capwell created CASSANDRA-15996:
-
Summary: Fix flaky python dtest
test_expiration_overflow_policy_capnowarn - ttl_test.TestTTL
Key: CASSANDRA-15996
URL: https://issues.apache.org/jira/browse/CASSANDRA-15996
Project: Cassandra
Issue Type: Bug
Components: Test/dtest
Reporter: David Capwell
https://app.circleci.com/pipelines/github/dcapwell/cassandra/361/workflows/3a42fa45-1f60-4c95-86a4-15a6773e384e/jobs/1860
{code}
> assert warning, 'Log message should be print for CAP and CAP_NOWARN
> policy'
E AssertionError: Log message should be print for CAP and CAP_NOWARN
policy
E assert []
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15996) Fix flaky python dtest test_expiration_overflow_policy_capnowarn - ttl_test.TestTTL
[
https://issues.apache.org/jira/browse/CASSANDRA-15996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Capwell updated CASSANDRA-15996:
--
Bug Category: Parent values: Correctness(12982)Level 1 values: Test
Failure(12990)
Complexity: Normal
Discovered By: Unit Test
Fix Version/s: 4.0-beta
Severity: Normal
Status: Open (was: Triage Needed)
> Fix flaky python dtest test_expiration_overflow_policy_capnowarn -
> ttl_test.TestTTL
> ---
>
> Key: CASSANDRA-15996
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15996
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest
>Reporter: David Capwell
>Priority: Normal
> Fix For: 4.0-beta
>
>
> https://app.circleci.com/pipelines/github/dcapwell/cassandra/361/workflows/3a42fa45-1f60-4c95-86a4-15a6773e384e/jobs/1860
> {code}
> > assert warning, 'Log message should be print for CAP and
> > CAP_NOWARN policy'
> E AssertionError: Log message should be print for CAP and
> CAP_NOWARN policy
> E assert []
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15907) Operational Improvements & Hardening for Replica Filtering Protection
[
https://issues.apache.org/jira/browse/CASSANDRA-15907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166770#comment-17166770
]
Caleb Rackliffe commented on CASSANDRA-15907:
-
[~adelapena] Here are the final PRs and test runs (with not ALL commits
squashed just yet, to make reviewing the small bits you might not have reviewed
yet easier):
3.0: [patch|https://github.com/apache/cassandra/pull/659/commits],
[CircleCI|https://app.circleci.com/pipelines/github/maedhroz/cassandra/89/workflows/b6192a9d-774a-4453-95c1-34d46acedcf4]
3.11: [patch|https://github.com/apache/cassandra/pull/665/commits],
[CircleCI|https://app.circleci.com/pipelines/github/maedhroz/cassandra/88/workflows/6c0cd966-f55a-4c3c-b78a-81724134cce3]
trunk: [patch|https://github.com/apache/cassandra/pull/666/commits], [CircleCI
J8|https://app.circleci.com/pipelines/github/maedhroz/cassandra/90/workflows/2804223b-0b3b-4da4-a180-733f67d179a5],
[CircleCI
J11|https://app.circleci.com/pipelines/github/maedhroz/cassandra/90/workflows/51c944a3-ac7e-4e15-acc2-a92844967d9e]
Let me know if you'd like me to do a final squash at some point. Thanks for all
your help on this one!
> Operational Improvements & Hardening for Replica Filtering Protection
> -
>
> Key: CASSANDRA-15907
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15907
> Project: Cassandra
> Issue Type: Improvement
> Components: Consistency/Coordination, Feature/2i Index
>Reporter: Caleb Rackliffe
>Assignee: Caleb Rackliffe
>Priority: Normal
> Labels: 2i, memory
> Fix For: 3.0.x, 3.11.x, 4.0-beta
>
> Time Spent: 8h
> Remaining Estimate: 0h
>
> CASSANDRA-8272 uses additional space on the heap to ensure correctness for 2i
> and filtering queries at consistency levels above ONE/LOCAL_ONE. There are a
> few things we should follow up on, however, to make life a bit easier for
> operators and generally de-risk usage:
> (Note: Line numbers are based on {{trunk}} as of
> {{3cfe3c9f0dcf8ca8b25ad111800a21725bf152cb}}.)
> *Minor Optimizations*
> * {{ReplicaFilteringProtection:114}} - Given we size them up-front, we may be
> able to use simple arrays instead of lists for {{rowsToFetch}} and
> {{originalPartitions}}. Alternatively (or also), we may be able to null out
> references in these two collections more aggressively. (ex. Using
> {{ArrayList#set()}} instead of {{get()}} in {{queryProtectedPartitions()}},
> assuming we pass {{toFetch}} as an argument to {{querySourceOnKey()}}.)
> * {{ReplicaFilteringProtection:323}} - We may be able to use
> {{EncodingStats.merge()}} and remove the custom {{stats()}} method.
> * {{DataResolver:111 & 228}} - Cache an instance of
> {{UnaryOperator#identity()}} instead of creating one on the fly.
> * {{ReplicaFilteringProtection:217}} - We may be able to scatter/gather
> rather than serially querying every row that needs to be completed. This
> isn't a clear win perhaps, given it targets the latency of single queries and
> adds some complexity. (Certainly a decent candidate to kick even out of this
> issue.)
> *Documentation and Intelligibility*
> * There are a few places (CHANGES.txt, tracing output in
> {{ReplicaFilteringProtection}}, etc.) where we mention "replica-side
> filtering protection" (which makes it seem like the coordinator doesn't
> filter) rather than "replica filtering protection" (which sounds more like
> what we actually do, which is protect ourselves against incorrect replica
> filtering results). It's a minor fix, but would avoid confusion.
> * The method call chain in {{DataResolver}} might be a bit simpler if we put
> the {{repairedDataTracker}} in {{ResolveContext}}.
> *Testing*
> * I want to bite the bullet and get some basic tests for RFP (including any
> guardrails we might add here) onto the in-JVM dtest framework.
> *Guardrails*
> * As it stands, we don't have a way to enforce an upper bound on the memory
> usage of {{ReplicaFilteringProtection}} which caches row responses from the
> first round of requests. (Remember, these are later used to merged with the
> second round of results to complete the data for filtering.) Operators will
> likely need a way to protect themselves, i.e. simply fail queries if they hit
> a particular threshold rather than GC nodes into oblivion. (Having control
> over limits and page sizes doesn't quite get us there, because stale results
> _expand_ the number of incomplete results we must cache.) The fun question is
> how we do this, with the primary axes being scope (per-query, global, etc.)
> and granularity (per-partition, per-row, per-cell, actual heap usage, etc.).
> My starting disposition on the right trade-off between
> performance/complexity and accuracy is having something
[jira] [Commented] (CASSANDRA-15861) Mutating sstable component may race with entire-sstable-streaming(ZCS) causing checksum validation failure
[
https://issues.apache.org/jira/browse/CASSANDRA-15861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166767#comment-17166767
]
Caleb Rackliffe commented on CASSANDRA-15861:
-
[~jasonstack] I left a few more minor comments around the PR, but I'm +1
overall at this point. I don't think there's a good alternative to the current
approach unless we start trading away disk space to write the new index summary
to a temp file and atomic rename (which doesn't even work on all supported
operating systems).
> Mutating sstable component may race with entire-sstable-streaming(ZCS)
> causing checksum validation failure
> --
>
> Key: CASSANDRA-15861
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15861
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Repair, Consistency/Streaming,
> Local/Compaction
>Reporter: ZhaoYang
>Assignee: ZhaoYang
>Priority: Normal
> Fix For: 4.0-beta
>
>
> Flaky dtest: [test_dead_sync_initiator -
> repair_tests.repair_test.TestRepair|https://ci-cassandra.apache.org/view/all/job/Cassandra-devbranch-dtest/143/testReport/junit/dtest.repair_tests.repair_test/TestRepair/test_dead_sync_initiator/]
> {code:java|title=stacktrace}
> Unexpected error found in node logs (see stdout for full details). Errors:
> [ERROR [Stream-Deserializer-127.0.0.1:7000-570871f3] 2020-06-03 04:05:19,081
> CassandraEntireSSTableStreamReader.java:145 - [Stream
> 6f1c3360-a54f-11ea-a808-2f23710fdc90] Error while reading sstable from stream
> for table = keyspace1.standard1
> org.apache.cassandra.io.sstable.CorruptSSTableException: Corrupted:
> /home/cassandra/cassandra/cassandra-dtest/tmp/dtest-te4ty0r9/test/node3/data0/keyspace1/standard1-5f5ab140a54f11eaa8082f23710fdc90/na-2-big-Statistics.db
> at
> org.apache.cassandra.io.sstable.metadata.MetadataSerializer.maybeValidateChecksum(MetadataSerializer.java:219)
> at
> org.apache.cassandra.io.sstable.metadata.MetadataSerializer.deserialize(MetadataSerializer.java:198)
> at
> org.apache.cassandra.io.sstable.metadata.MetadataSerializer.deserialize(MetadataSerializer.java:129)
> at
> org.apache.cassandra.io.sstable.metadata.MetadataSerializer.mutate(MetadataSerializer.java:226)
> at
> org.apache.cassandra.db.streaming.CassandraEntireSSTableStreamReader.read(CassandraEntireSSTableStreamReader.java:140)
> at
> org.apache.cassandra.db.streaming.CassandraIncomingFile.read(CassandraIncomingFile.java:78)
> at
> org.apache.cassandra.streaming.messages.IncomingStreamMessage$1.deserialize(IncomingStreamMessage.java:49)
> at
> org.apache.cassandra.streaming.messages.IncomingStreamMessage$1.deserialize(IncomingStreamMessage.java:36)
> at
> org.apache.cassandra.streaming.messages.StreamMessage.deserialize(StreamMessage.java:49)
> at
> org.apache.cassandra.streaming.async.StreamingInboundHandler$StreamDeserializingTask.run(StreamingInboundHandler.java:181)
> at
> io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
> at java.lang.Thread.run(Thread.java:748)
> Caused by: java.io.IOException: Checksums do not match for
> /home/cassandra/cassandra/cassandra-dtest/tmp/dtest-te4ty0r9/test/node3/data0/keyspace1/standard1-5f5ab140a54f11eaa8082f23710fdc90/na-2-big-Statistics.db
> {code}
>
> In the above test, it executes "nodetool repair" on node1 and kills node2
> during repair. At the end, node3 reports checksum validation failure on
> sstable transferred from node1.
> {code:java|title=what happened}
> 1. When repair started on node1, it performs anti-compaction which modifies
> sstable's repairAt to 0 and pending repair id to session-id.
> 2. Then node1 creates {{ComponentManifest}} which contains file lengths to be
> transferred to node3.
> 3. Before node1 actually sends the files to node3, node2 is killed and node1
> starts to broadcast repair-failure-message to all participants in
> {{CoordinatorSession#fail}}
> 4. Node1 receives its own repair-failure-message and fails its local repair
> sessions at {{LocalSessions#failSession}} which triggers async background
> compaction.
> 5. Node1's background compaction will mutate sstable's repairAt to 0 and
> pending repair id to null via
> {{PendingRepairManager#getNextRepairFinishedTask}}, as there is no more
> in-progress repair.
> 6. Node1 actually sends the sstable to node3 where the sstable's STATS
> component size is different from the original size recorded in the manifest.
> 7. At the end, node3 reports checksum validation failure when it tries to
> mutate sstable level and "isTransient" attribute in
> {{CassandraEntireSSTableStreamReader#read}}.
> {code}
> Currently,
[jira] [Commented] (CASSANDRA-15338) Fix flakey testMessagePurging - org.apache.cassandra.net.ConnectionTest
[
https://issues.apache.org/jira/browse/CASSANDRA-15338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166765#comment-17166765
]
Yifan Cai commented on CASSANDRA-15338:
---
Thanks for reporting, [~dcapwell].
The test failure in the link is timeout (30 seconds) when closing the inbound
connection. I will take a closer look later.
> Fix flakey testMessagePurging - org.apache.cassandra.net.ConnectionTest
> ---
>
> Key: CASSANDRA-15338
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15338
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: David Capwell
>Assignee: Yifan Cai
>Priority: Normal
> Labels: pull-request-available
> Fix For: 4.0, 4.0-beta1
>
> Attachments: CASS-15338-Docker.zip
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Example failure:
> [https://circleci.com/gh/dcapwell/cassandra/11#artifacts/containers/1]
>
> {code:java}
> Testcase: testMessagePurging(org.apache.cassandra.net.ConnectionTest): FAILED
> expected:<0> but was:<1>
> junit.framework.AssertionFailedError: expected:<0> but was:<1>
> at
> org.apache.cassandra.net.ConnectionTest.lambda$testMessagePurging$38(ConnectionTest.java:625)
> at
> org.apache.cassandra.net.ConnectionTest.doTestManual(ConnectionTest.java:258)
> at
> org.apache.cassandra.net.ConnectionTest.testManual(ConnectionTest.java:231)
> at
> org.apache.cassandra.net.ConnectionTest.testMessagePurging(ConnectionTest.java:584){code}
>
> Looking closer at
> org.apache.cassandra.net.OutboundConnection.Delivery#stopAndRun it seems that
> the run method is called before
> org.apache.cassandra.net.OutboundConnection.Delivery#doRun which may lead to
> a test race condition where the CountDownLatch completes before executing
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-15995) Fix flaky test testIndexMemtableSwitching - org.apache.cassandra.index.sasi.SASIIndexTest
David Capwell created CASSANDRA-15995:
-
Summary: Fix flaky test testIndexMemtableSwitching -
org.apache.cassandra.index.sasi.SASIIndexTest
Key: CASSANDRA-15995
URL: https://issues.apache.org/jira/browse/CASSANDRA-15995
Project: Cassandra
Issue Type: Bug
Components: Test/unit
Reporter: David Capwell
https://app.circleci.com/pipelines/github/dcapwell/cassandra/361/workflows/3a42fa45-1f60-4c95-86a4-15a6773e384e/jobs/1855
{code}
junit.framework.AssertionFailedError: expected:<0> but was:<1>
at
org.apache.cassandra.index.sasi.SASIIndexTest.testIndexMemtableSwitching(SASIIndexTest.java:2379)
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15995) Fix flaky test testIndexMemtableSwitching - org.apache.cassandra.index.sasi.SASIIndexTest
[
https://issues.apache.org/jira/browse/CASSANDRA-15995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Capwell updated CASSANDRA-15995:
--
Bug Category: Parent values: Correctness(12982)Level 1 values: Test
Failure(12990)
Complexity: Normal
Discovered By: Unit Test
Fix Version/s: 4.0-beta
Severity: Normal
Status: Open (was: Triage Needed)
> Fix flaky test testIndexMemtableSwitching -
> org.apache.cassandra.index.sasi.SASIIndexTest
> -
>
> Key: CASSANDRA-15995
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15995
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: David Capwell
>Priority: Normal
> Fix For: 4.0-beta
>
>
> https://app.circleci.com/pipelines/github/dcapwell/cassandra/361/workflows/3a42fa45-1f60-4c95-86a4-15a6773e384e/jobs/1855
> {code}
> junit.framework.AssertionFailedError: expected:<0> but was:<1>
> at
> org.apache.cassandra.index.sasi.SASIIndexTest.testIndexMemtableSwitching(SASIIndexTest.java:2379)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15994) Fix flaky python dtest test_simple_rebuild - rebuild_test.TestRebuild
[
https://issues.apache.org/jira/browse/CASSANDRA-15994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Capwell updated CASSANDRA-15994:
--
Bug Category: Parent values: Correctness(12982)Level 1 values: Test
Failure(12990)
Complexity: Normal
Discovered By: Unit Test
Fix Version/s: 4.0-beta
Severity: Normal
Status: Open (was: Triage Needed)
> Fix flaky python dtest test_simple_rebuild - rebuild_test.TestRebuild
> -
>
> Key: CASSANDRA-15994
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15994
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest
>Reporter: David Capwell
>Priority: Normal
> Fix For: 4.0-beta
>
>
> https://app.circleci.com/pipelines/github/dcapwell/cassandra/360/workflows/8e93a655-b66e-4bf2-8866-5f9a46487763/jobs/1847
> {code}
> > assert self.rebuild_errors == 1, \
> 'rebuild errors should be 1, but found {}. Concurrent rebuild
> should not be allowed, but one rebuild command should have
> succeeded.'.format(self.rebuild_errors)
> E AssertionError: rebuild errors should be 1, but found 0. Concurrent
> rebuild should not be allowed, but one rebuild command should have succeeded.
> E assert 0 == 1
> E+ where 0 = 0x7f29fe243518>.rebuild_errors
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-15994) Fix flaky python dtest test_simple_rebuild - rebuild_test.TestRebuild
David Capwell created CASSANDRA-15994:
-
Summary: Fix flaky python dtest test_simple_rebuild -
rebuild_test.TestRebuild
Key: CASSANDRA-15994
URL: https://issues.apache.org/jira/browse/CASSANDRA-15994
Project: Cassandra
Issue Type: Bug
Components: Test/dtest
Reporter: David Capwell
https://app.circleci.com/pipelines/github/dcapwell/cassandra/360/workflows/8e93a655-b66e-4bf2-8866-5f9a46487763/jobs/1847
{code}
> assert self.rebuild_errors == 1, \
'rebuild errors should be 1, but found {}. Concurrent rebuild
should not be allowed, but one rebuild command should have
succeeded.'.format(self.rebuild_errors)
E AssertionError: rebuild errors should be 1, but found 0. Concurrent
rebuild should not be allowed, but one rebuild command should have succeeded.
E assert 0 == 1
E+ where 0 = .rebuild_errors
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15338) Fix flakey testMessagePurging - org.apache.cassandra.net.ConnectionTest
[
https://issues.apache.org/jira/browse/CASSANDRA-15338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166759#comment-17166759
]
David Capwell commented on CASSANDRA-15338:
---
[~yifanc] this test is still flakey, but now hitting TimeoutException:
https://app.circleci.com/pipelines/github/dcapwell/cassandra/362/workflows/c04020b0-d13e-4e18-ae27-0277e636b73d/jobs/1858
> Fix flakey testMessagePurging - org.apache.cassandra.net.ConnectionTest
> ---
>
> Key: CASSANDRA-15338
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15338
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: David Capwell
>Assignee: Yifan Cai
>Priority: Normal
> Labels: pull-request-available
> Fix For: 4.0, 4.0-beta1
>
> Attachments: CASS-15338-Docker.zip
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Example failure:
> [https://circleci.com/gh/dcapwell/cassandra/11#artifacts/containers/1]
>
> {code:java}
> Testcase: testMessagePurging(org.apache.cassandra.net.ConnectionTest): FAILED
> expected:<0> but was:<1>
> junit.framework.AssertionFailedError: expected:<0> but was:<1>
> at
> org.apache.cassandra.net.ConnectionTest.lambda$testMessagePurging$38(ConnectionTest.java:625)
> at
> org.apache.cassandra.net.ConnectionTest.doTestManual(ConnectionTest.java:258)
> at
> org.apache.cassandra.net.ConnectionTest.testManual(ConnectionTest.java:231)
> at
> org.apache.cassandra.net.ConnectionTest.testMessagePurging(ConnectionTest.java:584){code}
>
> Looking closer at
> org.apache.cassandra.net.OutboundConnection.Delivery#stopAndRun it seems that
> the run method is called before
> org.apache.cassandra.net.OutboundConnection.Delivery#doRun which may lead to
> a test race condition where the CountDownLatch completes before executing
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15899) Dropping a column can break queries until the schema is fully propagated
[
https://issues.apache.org/jira/browse/CASSANDRA-15899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Blake Eggleston updated CASSANDRA-15899:
Reviewers: Sam Tunnicliffe
> Dropping a column can break queries until the schema is fully propagated
>
>
> Key: CASSANDRA-15899
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15899
> Project: Cassandra
> Issue Type: Bug
> Components: Cluster/Schema
>Reporter: Marcus Eriksson
>Assignee: Blake Eggleston
>Priority: Normal
> Fix For: 3.0.x
>
>
> With a table like:
> {code}
> CREATE TABLE ks.tbl (id int primary key, v1 int, v2 int, v3 int)
> {code}
> and we drop {{v2}}, we get this exception on the replicas which haven't seen
> the schema change:
> {code}
> ERROR [SharedPool-Worker-1] node2 2020-06-24 09:49:08,107
> AbstractLocalAwareExecutorService.java:169 - Uncaught exception on thread
> Thread[SharedPool-Worker-1,5,node2]
> java.lang.IllegalStateException: [ColumnDefinition{name=v1,
> type=org.apache.cassandra.db.marshal.Int32Type, kind=REGULAR, position=-1},
> ColumnDefinition{name=v2, type=org.apache.cassandra.db.marshal.Int32Type,
> kind=REGULAR, position=-1}, ColumnDefinition{name=v3,
> type=org.apache.cassandra.db.marshal.Int32Type, kind=REGULAR, position=-1}]
> is not a subset of [v1 v3]
> at
> org.apache.cassandra.db.Columns$Serializer.encodeBitmap(Columns.java:546)
> ~[main/:na]
> at
> org.apache.cassandra.db.Columns$Serializer.serializeSubset(Columns.java:478)
> ~[main/:na]
> at
> org.apache.cassandra.db.rows.UnfilteredSerializer.serialize(UnfilteredSerializer.java:184)
> ~[main/:na]
> at
> org.apache.cassandra.db.rows.UnfilteredSerializer.serialize(UnfilteredSerializer.java:114)
> ~[main/:na]
> at
> org.apache.cassandra.db.rows.UnfilteredSerializer.serialize(UnfilteredSerializer.java:102)
> ~[main/:na]
> at
> org.apache.cassandra.db.rows.UnfilteredRowIteratorSerializer.serialize(UnfilteredRowIteratorSerializer.java:132)
> ~[main/:na]
> at
> org.apache.cassandra.db.rows.UnfilteredRowIteratorSerializer.serialize(UnfilteredRowIteratorSerializer.java:87)
> ~[main/:na]
> ...
> {code}
> Note that it doesn't matter if we {{SELECT *}} or {{SELECT id, v1}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15899) Dropping a column can break queries until the schema is fully propagated
[
https://issues.apache.org/jira/browse/CASSANDRA-15899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166754#comment-17166754
]
Blake Eggleston commented on CASSANDRA-15899:
-
I have a patch ready for review here:
https://github.com/bdeggleston/cassandra/tree/15899-trunk. This fixes the issue
for dropping columns as well as adding them, which would also throw validation
errors.
Dropped columns are handled by checking that the columns we're serializing and
the header columns are actually equal, not just the same length, and ignoring
situations where we have a column not specified by the read command.
Added columns are handled by returning placeholder columns when deserializing
columns instead of throwing an exception. We will throw an exception if we
attempt to deserialize any data with a placeholder column.
> Dropping a column can break queries until the schema is fully propagated
>
>
> Key: CASSANDRA-15899
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15899
> Project: Cassandra
> Issue Type: Bug
> Components: Cluster/Schema
>Reporter: Marcus Eriksson
>Assignee: Blake Eggleston
>Priority: Normal
> Fix For: 3.0.x
>
>
> With a table like:
> {code}
> CREATE TABLE ks.tbl (id int primary key, v1 int, v2 int, v3 int)
> {code}
> and we drop {{v2}}, we get this exception on the replicas which haven't seen
> the schema change:
> {code}
> ERROR [SharedPool-Worker-1] node2 2020-06-24 09:49:08,107
> AbstractLocalAwareExecutorService.java:169 - Uncaught exception on thread
> Thread[SharedPool-Worker-1,5,node2]
> java.lang.IllegalStateException: [ColumnDefinition{name=v1,
> type=org.apache.cassandra.db.marshal.Int32Type, kind=REGULAR, position=-1},
> ColumnDefinition{name=v2, type=org.apache.cassandra.db.marshal.Int32Type,
> kind=REGULAR, position=-1}, ColumnDefinition{name=v3,
> type=org.apache.cassandra.db.marshal.Int32Type, kind=REGULAR, position=-1}]
> is not a subset of [v1 v3]
> at
> org.apache.cassandra.db.Columns$Serializer.encodeBitmap(Columns.java:546)
> ~[main/:na]
> at
> org.apache.cassandra.db.Columns$Serializer.serializeSubset(Columns.java:478)
> ~[main/:na]
> at
> org.apache.cassandra.db.rows.UnfilteredSerializer.serialize(UnfilteredSerializer.java:184)
> ~[main/:na]
> at
> org.apache.cassandra.db.rows.UnfilteredSerializer.serialize(UnfilteredSerializer.java:114)
> ~[main/:na]
> at
> org.apache.cassandra.db.rows.UnfilteredSerializer.serialize(UnfilteredSerializer.java:102)
> ~[main/:na]
> at
> org.apache.cassandra.db.rows.UnfilteredRowIteratorSerializer.serialize(UnfilteredRowIteratorSerializer.java:132)
> ~[main/:na]
> at
> org.apache.cassandra.db.rows.UnfilteredRowIteratorSerializer.serialize(UnfilteredRowIteratorSerializer.java:87)
> ~[main/:na]
> ...
> {code}
> Note that it doesn't matter if we {{SELECT *}} or {{SELECT id, v1}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15899) Dropping a column can break queries until the schema is fully propagated
[
https://issues.apache.org/jira/browse/CASSANDRA-15899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Blake Eggleston updated CASSANDRA-15899:
Test and Documentation Plan: in-jvm dtests
Status: Patch Available (was: Open)
> Dropping a column can break queries until the schema is fully propagated
>
>
> Key: CASSANDRA-15899
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15899
> Project: Cassandra
> Issue Type: Bug
> Components: Cluster/Schema
>Reporter: Marcus Eriksson
>Assignee: Blake Eggleston
>Priority: Normal
> Fix For: 3.0.x
>
>
> With a table like:
> {code}
> CREATE TABLE ks.tbl (id int primary key, v1 int, v2 int, v3 int)
> {code}
> and we drop {{v2}}, we get this exception on the replicas which haven't seen
> the schema change:
> {code}
> ERROR [SharedPool-Worker-1] node2 2020-06-24 09:49:08,107
> AbstractLocalAwareExecutorService.java:169 - Uncaught exception on thread
> Thread[SharedPool-Worker-1,5,node2]
> java.lang.IllegalStateException: [ColumnDefinition{name=v1,
> type=org.apache.cassandra.db.marshal.Int32Type, kind=REGULAR, position=-1},
> ColumnDefinition{name=v2, type=org.apache.cassandra.db.marshal.Int32Type,
> kind=REGULAR, position=-1}, ColumnDefinition{name=v3,
> type=org.apache.cassandra.db.marshal.Int32Type, kind=REGULAR, position=-1}]
> is not a subset of [v1 v3]
> at
> org.apache.cassandra.db.Columns$Serializer.encodeBitmap(Columns.java:546)
> ~[main/:na]
> at
> org.apache.cassandra.db.Columns$Serializer.serializeSubset(Columns.java:478)
> ~[main/:na]
> at
> org.apache.cassandra.db.rows.UnfilteredSerializer.serialize(UnfilteredSerializer.java:184)
> ~[main/:na]
> at
> org.apache.cassandra.db.rows.UnfilteredSerializer.serialize(UnfilteredSerializer.java:114)
> ~[main/:na]
> at
> org.apache.cassandra.db.rows.UnfilteredSerializer.serialize(UnfilteredSerializer.java:102)
> ~[main/:na]
> at
> org.apache.cassandra.db.rows.UnfilteredRowIteratorSerializer.serialize(UnfilteredRowIteratorSerializer.java:132)
> ~[main/:na]
> at
> org.apache.cassandra.db.rows.UnfilteredRowIteratorSerializer.serialize(UnfilteredRowIteratorSerializer.java:87)
> ~[main/:na]
> ...
> {code}
> Note that it doesn't matter if we {{SELECT *}} or {{SELECT id, v1}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-13309) i couldnot able to run the cqlsh service.i am getting an syntax error in cqlsh.py file when i was trying to run cqlsh from bin folder
[ https://issues.apache.org/jira/browse/CASSANDRA-13309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-13309: - Resolution: Invalid Status: Resolved (was: Open) Python 3 isn't supported in 3.0: https://issues.apache.org/jira/browse/CASSANDRA-10190 > i couldnot able to run the cqlsh service.i am getting an syntax error in > cqlsh.py file when i was trying to run cqlsh from bin folder > - > > Key: CASSANDRA-13309 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13309 > Project: Cassandra > Issue Type: Bug > Components: Legacy/CQL > Environment: windows 10 64bit >Reporter: RANGU MANIKAR >Priority: Normal > Fix For: 3.0.x > > > C:\Program Files\apache-cassandra-3.0.11\bin>cqlsh > File "C:\Program Files\apache-cassandra-3.0.11\bin\\cqlsh.py", line 141 > except ImportError, e: > ^ > SyntaxError: invalid syntax > C:\Program Files\apache-cassandra-3.0.11\bin> -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-13309) i couldnot able to run the cqlsh service.i am getting an syntax error in cqlsh.py file when i was trying to run cqlsh from bin folder
[ https://issues.apache.org/jira/browse/CASSANDRA-13309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166742#comment-17166742 ] Aaj Kaal edited comment on CASSANDRA-13309 at 7/28/20, 10:59 PM: - I am on Windows 10 and using python 3.7.8 and have the same issue C:\Tools\apache-cassandra-3.11.7\bin>cqlsh File "C:\Tools\apache-cassandra-3.11.7\bin\\cqlsh.py", line 146 except ImportError, e: ^ SyntaxError: invalid syntax was (Author: aajkaal): I am on Windows 10 and using python 3.7.8 and have the same issue > i couldnot able to run the cqlsh service.i am getting an syntax error in > cqlsh.py file when i was trying to run cqlsh from bin folder > - > > Key: CASSANDRA-13309 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13309 > Project: Cassandra > Issue Type: Bug > Components: Legacy/CQL > Environment: windows 10 64bit >Reporter: RANGU MANIKAR >Priority: Normal > Fix For: 3.0.x > > > C:\Program Files\apache-cassandra-3.0.11\bin>cqlsh > File "C:\Program Files\apache-cassandra-3.0.11\bin\\cqlsh.py", line 141 > except ImportError, e: > ^ > SyntaxError: invalid syntax > C:\Program Files\apache-cassandra-3.0.11\bin> -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15970) 3.x fails to start if commit log has range tombstones from a column which is also deleted
[
https://issues.apache.org/jira/browse/CASSANDRA-15970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Capwell updated CASSANDRA-15970:
--
Reviewers: Blake Eggleston, Brandon Williams (was: Brandon Williams)
> 3.x fails to start if commit log has range tombstones from a column which is
> also deleted
> -
>
> Key: CASSANDRA-15970
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15970
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Local Write-Read Paths, Local/Commit Log
>Reporter: David Capwell
>Assignee: David Capwell
>Priority: Normal
> Fix For: 3.0.x, 3.11.x
>
>
> Cassandra crashes with the following exception
> {code}
> ERROR [node1_isolatedExecutor:1] node1 2020-07-21 18:59:39,048
> JVMStabilityInspector.java:102 - Exiting due to error while processing commit
> log during initialization.
> org.apache.cassandra.db.commitlog.CommitLogReplayer$CommitLogReplayException:
> Unexpected error deserializing mutation; saved to
> /var/folders/cm/08cddl2s25j7fq3jdb76gh4rgn/T/mutation6239873170066752296dat.
> This may be caused by replaying a mutation against a table with the same
> name but incompatible schema.
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.handleReplayError(CommitLogReplayer.java:731)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.replayMutation(CommitLogReplayer.java:656)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.replaySyncSection(CommitLogReplayer.java:609)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.recover(CommitLogReplayer.java:493)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.recover(CommitLogReplayer.java:189)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLog.recover(CommitLog.java:170)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLog.recover(CommitLog.java:151)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.distributed.impl.Instance.lambda$startup$7(Instance.java:535)
> [dtest-3.0.21.jar:na]
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> ~[na:1.8.0_242]
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> ~[na:1.8.0_242]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> ~[na:1.8.0_242]
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> ~[na:1.8.0_242]
> at
> org.apache.cassandra.concurrent.NamedThreadFactory.lambda$threadLocalDeallocator$0(NamedThreadFactory.java:83)
> ~[dtest-3.0.21.jar:na]
> at java.lang.Thread.run(Thread.java:748) ~[na:1.8.0_242]
> Caused by: java.lang.NullPointerException: null
> at
> org.apache.cassandra.db.ClusteringComparator.validate(ClusteringComparator.java:206)
> ~[dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.partitions.PartitionUpdate.validate(PartitionUpdate.java:494)
> ~[dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.replayMutation(CommitLogReplayer.java:629)
> [dtest-3.0.21.jar:na]
> ... 12 common frames omitted
> {code}
> If you drain in 2.2 before upgrade, you get the following
> {code}
> ERROR [SharedPool-Worker-1] node1 2020-07-21 22:17:25,661
> AbstractLocalAwareExecutorService.java:169 - Uncaught exception on thread
> Thread[SharedPool-Worker-1,5,node1]
> java.lang.RuntimeException: java.lang.NullPointerException
> at
> org.apache.cassandra.service.StorageProxy$DroppableRunnable.run(StorageProxy.java:2537)
> ~[dtest-3.0.21.jar:na]
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> ~[na:1.8.0_242]
> at
> org.apache.cassandra.concurrent.AbstractLocalAwareExecutorService$FutureTask.run(AbstractLocalAwareExecutorService.java:165)
> ~[dtest-3.0.21.jar:na]
> at org.apache.cassandra.concurrent.SEPWorker.run(SEPWorker.java:109)
> [dtest-3.0.21.jar:na]
> at java.lang.Thread.run(Thread.java:748) [na:1.8.0_242]
> Caused by: java.lang.NullPointerException: null
> at
> org.apache.cassandra.db.ClusteringComparator.compare(ClusteringComparator.java:131)
> ~[dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.UnfilteredDeserializer$OldFormatDeserializer.compareNextTo(UnfilteredDeserializer.java:391)
> ~[dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.columniterator.SSTableIterator$ForwardReader.handlePreSliceData(SSTableIterator.java:105)
> ~[dtest-3.0.21.jar:na]
> at
>
[jira] [Comment Edited] (CASSANDRA-13309) i couldnot able to run the cqlsh service.i am getting an syntax error in cqlsh.py file when i was trying to run cqlsh from bin folder
[ https://issues.apache.org/jira/browse/CASSANDRA-13309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166742#comment-17166742 ] Aaj Kaal edited comment on CASSANDRA-13309 at 7/28/20, 10:57 PM: - I am on Windows 10 and using python 3.7.8 and have the same issue was (Author: aajkaal): I am using python 3.7.8 and have the same issue > i couldnot able to run the cqlsh service.i am getting an syntax error in > cqlsh.py file when i was trying to run cqlsh from bin folder > - > > Key: CASSANDRA-13309 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13309 > Project: Cassandra > Issue Type: Bug > Components: Legacy/CQL > Environment: windows 10 64bit >Reporter: RANGU MANIKAR >Priority: Normal > Fix For: 3.0.x > > > C:\Program Files\apache-cassandra-3.0.11\bin>cqlsh > File "C:\Program Files\apache-cassandra-3.0.11\bin\\cqlsh.py", line 141 > except ImportError, e: > ^ > SyntaxError: invalid syntax > C:\Program Files\apache-cassandra-3.0.11\bin> -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13309) i couldnot able to run the cqlsh service.i am getting an syntax error in cqlsh.py file when i was trying to run cqlsh from bin folder
[ https://issues.apache.org/jira/browse/CASSANDRA-13309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166742#comment-17166742 ] Aaj Kaal commented on CASSANDRA-13309: -- I am using python 3.7.8 and have the same issue > i couldnot able to run the cqlsh service.i am getting an syntax error in > cqlsh.py file when i was trying to run cqlsh from bin folder > - > > Key: CASSANDRA-13309 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13309 > Project: Cassandra > Issue Type: Bug > Components: Legacy/CQL > Environment: windows 10 64bit >Reporter: RANGU MANIKAR >Priority: Normal > Fix For: 3.0.x > > > C:\Program Files\apache-cassandra-3.0.11\bin>cqlsh > File "C:\Program Files\apache-cassandra-3.0.11\bin\\cqlsh.py", line 141 > except ImportError, e: > ^ > SyntaxError: invalid syntax > C:\Program Files\apache-cassandra-3.0.11\bin> -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15191) stop_paranoid disk failure policy is ignored on CorruptSSTableException after node is up
[ https://issues.apache.org/jira/browse/CASSANDRA-15191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166731#comment-17166731 ] Brandon Williams commented on CASSANDRA-15191: -- 3.0 looks good, +1. > stop_paranoid disk failure policy is ignored on CorruptSSTableException after > node is up > > > Key: CASSANDRA-15191 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15191 > Project: Cassandra > Issue Type: Bug > Components: Local/Config >Reporter: Vincent White >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 3.0.x, 3.11.x, 4.0-beta > > Attachments: log.txt > > Time Spent: 3.5h > Remaining Estimate: 0h > > There is a bug when disk_failure_policy is set to stop_paranoid and > CorruptSSTableException is thrown after server is up. The problem is that > this setting is ignored. Normally, it should stop gossip and transport but it > just continues to serve requests and an exception is just logged. > > This patch unifies the exception handling in JVMStabilityInspector and code > is reworked in such way that this inspector acts as a central place where > such exceptions are inspected. > > The core reason for ignoring that exception is that thrown exception in > AbstractLocalAwareExecturorService is not CorruptSSTableException but it is > RuntimeException and that exception is as its cause. Hence it is better if we > handle this in JVMStabilityInspector which can recursively examine it, hence > act accordingly. > Behaviour before: > stop_paranoid of disk_failure_policy is ignored when CorruptSSTableException > is thrown, e.g. on a regular select statement > Behaviour after: > Gossip and transport (cql) is turned off, JVM is still up for further > investigation e.g. by jmx. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15975) SEP.shutdownAndWait does not wait for termination and SEPExecutor.awaitTermination may hang
[ https://issues.apache.org/jira/browse/CASSANDRA-15975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166723#comment-17166723 ] David Capwell commented on CASSANDRA-15975: --- LGTM +1 > SEP.shutdownAndWait does not wait for termination and > SEPExecutor.awaitTermination may hang > --- > > Key: CASSANDRA-15975 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15975 > Project: Cassandra > Issue Type: Bug > Components: Local/Other >Reporter: Jon Meredith >Assignee: Jon Meredith >Priority: Normal > > SharedExecutorPool.shutdownAndWait calls shutdownNow on the executors it > owns, which has the side effect of removing the executor from the list, then > uses the same emptied list to try and wait for them to complete shutting > down, which completes immediately. > > Once fixed by copying the list in SEP.shutdownAndWait, the SEPExecutorTest > suite fails with a timeout due to a startup race in SEPWorker. > > If a SEPExecutor is shutdown immediately after maybeSchedule creates a new > SEPWorker, > but before it is able to execute the first task then it exits immediately on > entering the work loop with a work and task permit reserved for it, which > invalidates the work/task permit accounting and prevents calling the shutdown > SimpleCondition.signalAll when the last SEPWorker exits. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15970) 3.x fails to start if commit log has range tombstones from a column which is also deleted
[
https://issues.apache.org/jira/browse/CASSANDRA-15970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Blake Eggleston updated CASSANDRA-15970:
Status: Ready to Commit (was: Review In Progress)
+1
> 3.x fails to start if commit log has range tombstones from a column which is
> also deleted
> -
>
> Key: CASSANDRA-15970
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15970
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Local Write-Read Paths, Local/Commit Log
>Reporter: David Capwell
>Assignee: David Capwell
>Priority: Normal
> Fix For: 3.0.x, 3.11.x
>
>
> Cassandra crashes with the following exception
> {code}
> ERROR [node1_isolatedExecutor:1] node1 2020-07-21 18:59:39,048
> JVMStabilityInspector.java:102 - Exiting due to error while processing commit
> log during initialization.
> org.apache.cassandra.db.commitlog.CommitLogReplayer$CommitLogReplayException:
> Unexpected error deserializing mutation; saved to
> /var/folders/cm/08cddl2s25j7fq3jdb76gh4rgn/T/mutation6239873170066752296dat.
> This may be caused by replaying a mutation against a table with the same
> name but incompatible schema.
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.handleReplayError(CommitLogReplayer.java:731)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.replayMutation(CommitLogReplayer.java:656)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.replaySyncSection(CommitLogReplayer.java:609)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.recover(CommitLogReplayer.java:493)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.recover(CommitLogReplayer.java:189)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLog.recover(CommitLog.java:170)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLog.recover(CommitLog.java:151)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.distributed.impl.Instance.lambda$startup$7(Instance.java:535)
> [dtest-3.0.21.jar:na]
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> ~[na:1.8.0_242]
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> ~[na:1.8.0_242]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> ~[na:1.8.0_242]
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> ~[na:1.8.0_242]
> at
> org.apache.cassandra.concurrent.NamedThreadFactory.lambda$threadLocalDeallocator$0(NamedThreadFactory.java:83)
> ~[dtest-3.0.21.jar:na]
> at java.lang.Thread.run(Thread.java:748) ~[na:1.8.0_242]
> Caused by: java.lang.NullPointerException: null
> at
> org.apache.cassandra.db.ClusteringComparator.validate(ClusteringComparator.java:206)
> ~[dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.partitions.PartitionUpdate.validate(PartitionUpdate.java:494)
> ~[dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.replayMutation(CommitLogReplayer.java:629)
> [dtest-3.0.21.jar:na]
> ... 12 common frames omitted
> {code}
> If you drain in 2.2 before upgrade, you get the following
> {code}
> ERROR [SharedPool-Worker-1] node1 2020-07-21 22:17:25,661
> AbstractLocalAwareExecutorService.java:169 - Uncaught exception on thread
> Thread[SharedPool-Worker-1,5,node1]
> java.lang.RuntimeException: java.lang.NullPointerException
> at
> org.apache.cassandra.service.StorageProxy$DroppableRunnable.run(StorageProxy.java:2537)
> ~[dtest-3.0.21.jar:na]
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> ~[na:1.8.0_242]
> at
> org.apache.cassandra.concurrent.AbstractLocalAwareExecutorService$FutureTask.run(AbstractLocalAwareExecutorService.java:165)
> ~[dtest-3.0.21.jar:na]
> at org.apache.cassandra.concurrent.SEPWorker.run(SEPWorker.java:109)
> [dtest-3.0.21.jar:na]
> at java.lang.Thread.run(Thread.java:748) [na:1.8.0_242]
> Caused by: java.lang.NullPointerException: null
> at
> org.apache.cassandra.db.ClusteringComparator.compare(ClusteringComparator.java:131)
> ~[dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.UnfilteredDeserializer$OldFormatDeserializer.compareNextTo(UnfilteredDeserializer.java:391)
> ~[dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.columniterator.SSTableIterator$ForwardReader.handlePreSliceData(SSTableIterator.java:105)
> ~[dtest-3.0.21.jar:na]
> at
>
[jira] [Commented] (CASSANDRA-15968) nodetool drain fails in jvm dtest
[
https://issues.apache.org/jira/browse/CASSANDRA-15968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166694#comment-17166694
]
Jon Meredith commented on CASSANDRA-15968:
--
I did a second round.
In the trunk version, after the MessagingService rewrite, can you reuse the
existing {{isShuttingDown}} instead of introducing a new one? I don't really
like resetting that in {{listen()}} unconditionally, especially if it's just to
handle some test code. What do you think about adding something like
{{unsafeResetListen}} if you *really* need to be able to do that?
> nodetool drain fails in jvm dtest
> -
>
> Key: CASSANDRA-15968
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15968
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest
>Reporter: David Capwell
>Assignee: David Capwell
>Priority: Normal
> Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0-beta
>
>
> Drain fails since MessagingService doesn’t expect to be shutdown twice.
> {code}
> Caused by: java.lang.AssertionError
> at
> org.apache.cassandra.net.MessagingService.shutdown(MessagingService.java:766)
> at
> org.apache.cassandra.distributed.impl.Instance.lambda$parallelRun$28(Instance.java:805)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> ... 3 more
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15959) org.apache.cassandra.cql3.validation.operations.TTLTest testCapWarnExpirationOverflowPolicy
[ https://issues.apache.org/jira/browse/CASSANDRA-15959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-15959: - Test and Documentation Plan: it is a test. Status: Patch Available (was: Open) There seems to be a timing race between computing the max TTL and fetching the TTL from the row. Patch to compute the max more closely to the fetch. > org.apache.cassandra.cql3.validation.operations.TTLTest > testCapWarnExpirationOverflowPolicy > --- > > Key: CASSANDRA-15959 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15959 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: David Capwell >Assignee: Brandon Williams >Priority: Normal > Fix For: 4.0-beta > > Attachments: 0001-computeMaxTTL-directly-before-fetching-TTL.patch > > > Build: > https://ci-cassandra.apache.org/job/Cassandra-trunk-test/194/testReport/junit/org.apache.cassandra.cql3.validation.operations/TTLTest/testCapWarnExpirationOverflowPolicy/ > junit.framework.AssertionFailedError > at > org.apache.cassandra.cql3.validation.operations.TTLTest.checkTTLIsCapped(TTLTest.java:321) > at > org.apache.cassandra.cql3.validation.operations.TTLTest.verifyData(TTLTest.java:303) > at > org.apache.cassandra.cql3.validation.operations.TTLTest.testCapExpirationDateOverflowPolicy(TTLTest.java:248) > at > org.apache.cassandra.cql3.validation.operations.TTLTest.testCapExpirationDateOverflowPolicy(TTLTest.java:199) > at > org.apache.cassandra.cql3.validation.operations.TTLTest.testCapWarnExpirationOverflowPolicy(TTLTest.java:140) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15959) org.apache.cassandra.cql3.validation.operations.TTLTest testCapWarnExpirationOverflowPolicy
[ https://issues.apache.org/jira/browse/CASSANDRA-15959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-15959: - Attachment: 0001-computeMaxTTL-directly-before-fetching-TTL.patch > org.apache.cassandra.cql3.validation.operations.TTLTest > testCapWarnExpirationOverflowPolicy > --- > > Key: CASSANDRA-15959 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15959 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: David Capwell >Assignee: Brandon Williams >Priority: Normal > Fix For: 4.0-beta > > Attachments: 0001-computeMaxTTL-directly-before-fetching-TTL.patch > > > Build: > https://ci-cassandra.apache.org/job/Cassandra-trunk-test/194/testReport/junit/org.apache.cassandra.cql3.validation.operations/TTLTest/testCapWarnExpirationOverflowPolicy/ > junit.framework.AssertionFailedError > at > org.apache.cassandra.cql3.validation.operations.TTLTest.checkTTLIsCapped(TTLTest.java:321) > at > org.apache.cassandra.cql3.validation.operations.TTLTest.verifyData(TTLTest.java:303) > at > org.apache.cassandra.cql3.validation.operations.TTLTest.testCapExpirationDateOverflowPolicy(TTLTest.java:248) > at > org.apache.cassandra.cql3.validation.operations.TTLTest.testCapExpirationDateOverflowPolicy(TTLTest.java:199) > at > org.apache.cassandra.cql3.validation.operations.TTLTest.testCapWarnExpirationOverflowPolicy(TTLTest.java:140) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15975) SEP.shutdownAndWait does not wait for termination and SEPExecutor.awaitTermination may hang
[ https://issues.apache.org/jira/browse/CASSANDRA-15975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-15975: -- Reviewers: Benedict Elliott Smith, David Capwell (was: Benedict Elliott Smith) > SEP.shutdownAndWait does not wait for termination and > SEPExecutor.awaitTermination may hang > --- > > Key: CASSANDRA-15975 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15975 > Project: Cassandra > Issue Type: Bug > Components: Local/Other >Reporter: Jon Meredith >Assignee: Jon Meredith >Priority: Normal > > SharedExecutorPool.shutdownAndWait calls shutdownNow on the executors it > owns, which has the side effect of removing the executor from the list, then > uses the same emptied list to try and wait for them to complete shutting > down, which completes immediately. > > Once fixed by copying the list in SEP.shutdownAndWait, the SEPExecutorTest > suite fails with a timeout due to a startup race in SEPWorker. > > If a SEPExecutor is shutdown immediately after maybeSchedule creates a new > SEPWorker, > but before it is able to execute the first task then it exits immediately on > entering the work loop with a work and task permit reserved for it, which > invalidates the work/task permit accounting and prevents calling the shutdown > SimpleCondition.signalAll when the last SEPWorker exits. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRASC-23) Set up structure for handling multiple Cassandra versions
[
https://issues.apache.org/jira/browse/CASSANDRASC-23?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jon Haddad updated CASSANDRASC-23:
--
Fix Version/s: 1.0
Source Control Link:
https://github.com/apache/cassandra-sidecar/commit/a4805a910904019698ae373ac33f88855cf67f3d
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
Thanks for the review Dinesh. Committed to master.
> Set up structure for handling multiple Cassandra versions
> -
>
> Key: CASSANDRASC-23
> URL: https://issues.apache.org/jira/browse/CASSANDRASC-23
> Project: Sidecar for Apache Cassandra
> Issue Type: Improvement
> Components: Configuration
>Reporter: Jon Haddad
>Assignee: Jon Haddad
>Priority: Normal
> Fix For: 1.0
>
>
> The first sidecar release will be for Cassandra 4.0, but one of the project
> goals is to be able to handle multiple versions. This will be especially
> important in mixed version clusters, or even mixed version 1:N sidecar to C*
> nodes (see CASSANDRASC-17).
> This JIRA is to lay the foundational work for supporting multiple Cassandra
> versions.
> Each Cassandra version (for example \{{cassandra40}}, \{{cassandra50}}, will
> be in a separate Gradle subproject, implementing a common interface defined
> in a \{{common}} subproject. A common cassandra integration testing
> framework will be able to test every version to ensure each version adheres
> to the expected interface.
> Each module will define the minimum compatibility it supports, so if someone
> (for example) wants to implement a Cassandra30 module for their own cluster,
> they will have the ability to do so.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRASC-23) Set up structure for handling multiple Cassandra versions
[
https://issues.apache.org/jira/browse/CASSANDRASC-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1710#comment-1710
]
ASF subversion and git services commented on CASSANDRASC-23:
Commit a4805a910904019698ae373ac33f88855cf67f3d in cassandra-sidecar's branch
refs/heads/master from Jon Haddad
[ https://gitbox.apache.org/repos/asf?p=cassandra-sidecar.git;h=a4805a9 ]
Support for multiple Cassandra versions
This patch lays the groundwork to support multiple Cassandra versions.
New submodules were created for common libraries as well as specific
Cassandra versions. Several dependencies are moved to the common
submodule due to their universal nature.
Most importantly, this patch introduces Junit Test Template for testing multiple
Cassandra versions. Test should be annotated with a
@CassandraIntegrationTest. These tests require Docker and Kubernetes be
available.
A single version is currently supported, 4.0. A dockerfile sets up the image
from the beta tarball and initializes the session.
Cassandra driver was upgraded to version 3.9, previous versions errored
with Java 11.
CircleCI tests are run using microk8s.
Patch by Jon Haddad; Reviewed by Dinesh Joshi for CASSANDRASC-23
> Set up structure for handling multiple Cassandra versions
> -
>
> Key: CASSANDRASC-23
> URL: https://issues.apache.org/jira/browse/CASSANDRASC-23
> Project: Sidecar for Apache Cassandra
> Issue Type: Improvement
> Components: Configuration
>Reporter: Jon Haddad
>Assignee: Jon Haddad
>Priority: Normal
>
> The first sidecar release will be for Cassandra 4.0, but one of the project
> goals is to be able to handle multiple versions. This will be especially
> important in mixed version clusters, or even mixed version 1:N sidecar to C*
> nodes (see CASSANDRASC-17).
> This JIRA is to lay the foundational work for supporting multiple Cassandra
> versions.
> Each Cassandra version (for example \{{cassandra40}}, \{{cassandra50}}, will
> be in a separate Gradle subproject, implementing a common interface defined
> in a \{{common}} subproject. A common cassandra integration testing
> framework will be able to test every version to ensure each version adheres
> to the expected interface.
> Each module will define the minimum compatibility it supports, so if someone
> (for example) wants to implement a Cassandra30 module for their own cluster,
> they will have the ability to do so.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-sidecar] branch master updated (c9da4b2 -> a4805a9)
This is an automated email from the ASF dual-hosted git repository. rustyrazorblade pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cassandra-sidecar.git. from c9da4b2 Ninja-Fix: CHANGES.txt for CASSANDRASC-22 add a4805a9 Support for multiple Cassandra versions No new revisions were added by this update. Summary of changes: .circleci/config.yml | 49 ++- .circleci/setup-microk8.sh | 23 ++ CHANGES.txt| 1 + README.md | 45 ++- build.gradle | 125 +-- cassandra-integration-tests/build.gradle | 44 +++ .../cassandra/sidecar/common/StatusTest.java | 51 +++ .../common/testing/CassandraIntegrationTest.java | 27 +- .../sidecar/common/testing/CassandraPod.java | 363 .../common/testing/CassandraPodException.java | 12 + .../common/testing/CassandraTestContext.java | 56 .../common/testing/CassandraTestTemplate.java | 176 ++ .../sidecar/common/testing/DelegateTest.java | 67 .../sidecar/common/testing/TestVersion.java| 31 +- .../common/testing/TestVersionSupplier.java| 44 +++ cassandra40/build.gradle | 18 + .../sidecar/cassandra40/Cassandra40Factory.java| 30 +- common/build.gradle| 38 +++ .../cassandra/sidecar/common}/CQLSession.java | 41 ++- .../sidecar/common/CassandraAdapterDelegate.java | 196 +++ .../sidecar/common/CassandraVersionProvider.java | 109 ++ .../sidecar/common/ICassandraAdapter.java | 22 +- .../sidecar/common/ICassandraFactory.java | 18 +- .../cassandra/sidecar/common/MinimumVersion.java | 23 +- .../sidecar/common/MockCassandraFactory.java | 18 +- .../cassandra/sidecar/common/NodeStatus.java | 17 +- .../sidecar/common/SimpleCassandraVersion.java | 159 + .../org/apache/cassandra/sidecar/mocks/V30.java| 27 +- .../org/apache/cassandra/sidecar/mocks/V40.java| 27 +- .../org/apache/cassandra/sidecar/mocks/V41.java| 27 +- .../common/SimpleCassandraVersionProviderTest.java | 85 + .../sidecar/common/SimpleCassandraVersionTest.java | 121 +++ containers/build.gradle| 76 + containers/src/Cassandra40/Dockerfile | 18 + containers/src/docker-entrypoint.sh| 15 + containers/src/optimize-memory.sh | 16 + docs/src/development.adoc | 95 ++ gradle.properties | 5 +- gradle/wrapper/gradle-wrapper.properties | 5 +- scripts/cleanup-pods.sh| 12 + scripts/setup-minikube.sh | 30 ++ settings.gradle| 5 + .../spotbugs-exclude.xml => spotbugs-exclude.xml | 0 .../sidecar/HealthServiceIntegrationTest.java | 366 - .../cassandra/sidecar/CassandraSidecarDaemon.java | 7 +- .../org/apache/cassandra/sidecar/MainModule.java | 30 ++ .../cassandra/sidecar/routes/HealthCheck.java | 89 - .../cassandra/sidecar/routes/HealthService.java| 101 +- .../sidecar/AbstractHealthServiceTest.java | 37 ++- .../org/apache/cassandra/sidecar/TestModule.java | 39 ++- .../apache/cassandra/sidecar/TestSslModule.java| 17 + 51 files changed, 2266 insertions(+), 787 deletions(-) create mode 100755 .circleci/setup-microk8.sh create mode 100644 cassandra-integration-tests/build.gradle create mode 100644 cassandra-integration-tests/src/test/java/org/apache/cassandra/sidecar/common/StatusTest.java copy src/test/java/org/apache/cassandra/sidecar/HealthServiceTest.java => cassandra-integration-tests/src/test/java/org/apache/cassandra/sidecar/common/testing/CassandraIntegrationTest.java (58%) create mode 100644 cassandra-integration-tests/src/test/java/org/apache/cassandra/sidecar/common/testing/CassandraPod.java create mode 100644 cassandra-integration-tests/src/test/java/org/apache/cassandra/sidecar/common/testing/CassandraPodException.java create mode 100644 cassandra-integration-tests/src/test/java/org/apache/cassandra/sidecar/common/testing/CassandraTestContext.java create mode 100644 cassandra-integration-tests/src/test/java/org/apache/cassandra/sidecar/common/testing/CassandraTestTemplate.java create mode 100644 cassandra-integration-tests/src/test/java/org/apache/cassandra/sidecar/common/testing/DelegateTest.java copy src/test/java/org/apache/cassandra/sidecar/mocks/MockHealthCheck.java => cassandra-integration-tests/src/test/java/org/apache/cassandra/sidecar/common/testing/TestVersion.java (56%) create mode 100644
[jira] [Comment Edited] (CASSANDRA-15970) 3.x fails to start if commit log has range tombstones from a column which is also deleted
[
https://issues.apache.org/jira/browse/CASSANDRA-15970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166585#comment-17166585
]
David Capwell edited comment on CASSANDRA-15970 at 7/28/20, 7:20 PM:
-
CI Links
2.2:
https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=bug%2FCASSANDRA-15970-2.2
3.0:
https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=bug%2FCASSANDRA-15970-3.0
3.11:
https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=bug%2FCASSANDRA-15970-3.11
trunk:
https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=bug%2FCASSANDRA-15970
Tests failed with the following:
2.2:
https://issues.apache.org/jira/browse/CASSANDRA-15985 (python dtest TestCqlsh
added enable_scripted_user_defined_functions which breaks on 2.2)
https://issues.apache.org/jira/browse/CASSANDRA-15984
(thrift_hsha_test.TestThriftHSHA test_closing_connections is broken on 3.0 and
3.11)
3.0:
https://issues.apache.org/jira/browse/CASSANDRA-15984
(thrift_hsha_test.TestThriftHSHA test_closing_connections is broken on 3.0 and
3.11)
3.11:
https://issues.apache.org/jira/browse/CASSANDRA-15881 (Flaky unit test:
SASIIndexTest.testInsertingIncorrectValuesIntoAgeIndex) - not actually, same
class but different test (testIndexMemtableSwitching); don't see a JIRA for
this test
https://issues.apache.org/jira/browse/CASSANDRA-15984
(thrift_hsha_test.TestThriftHSHA test_closing_connections is broken on 3.0 and
3.11)
Trunk:
https://issues.apache.org/jira/browse/CASSANDRA-15981 (jvm-dtests crash on java
11)
https://issues.apache.org/jira/browse/CASSANDRA-15992 (Fix flaky python dtest
test_13595 - consistency_test.TestConsistency)
https://issues.apache.org/jira/browse/CASSANDRA-15993 (Fix flaky python dtest
test_view_metadata_cleanup - materialized_views_test.TestMaterializedViews)
was (Author: dcapwell):
CI Links
2.2:
https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=bug%2FCASSANDRA-15970-2.2
3.0:
https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=bug%2FCASSANDRA-15970-3.0
3.11:
https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=bug%2FCASSANDRA-15970-3.11
trunk:
https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=bug%2FCASSANDRA-15970
Tests failed with the following:
2.2:
https://issues.apache.org/jira/browse/CASSANDRA-15985 (python dtest TestCqlsh
added enable_scripted_user_defined_functions which breaks on 2.2)
https://issues.apache.org/jira/browse/CASSANDRA-15984
(thrift_hsha_test.TestThriftHSHA test_closing_connections is broken on 3.0 and
3.11)
3.0:
3.11:
https://issues.apache.org/jira/browse/CASSANDRA-15881 (Flaky unit test:
SASIIndexTest.testInsertingIncorrectValuesIntoAgeIndex) - not actually, same
class but different test (testIndexMemtableSwitching); don't see a JIRA for
this test
https://issues.apache.org/jira/browse/CASSANDRA-15984
(thrift_hsha_test.TestThriftHSHA test_closing_connections is broken on 3.0 and
3.11)
Trunk:
https://issues.apache.org/jira/browse/CASSANDRA-15981 (jvm-dtests crash on java
11)
https://issues.apache.org/jira/browse/CASSANDRA-15992 (Fix flaky python dtest
test_13595 - consistency_test.TestConsistency)
https://issues.apache.org/jira/browse/CASSANDRA-15993 (Fix flaky python dtest
test_view_metadata_cleanup - materialized_views_test.TestMaterializedViews)
> 3.x fails to start if commit log has range tombstones from a column which is
> also deleted
> -
>
> Key: CASSANDRA-15970
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15970
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Local Write-Read Paths, Local/Commit Log
>Reporter: David Capwell
>Assignee: David Capwell
>Priority: Normal
> Fix For: 3.0.x, 3.11.x
>
>
> Cassandra crashes with the following exception
> {code}
> ERROR [node1_isolatedExecutor:1] node1 2020-07-21 18:59:39,048
> JVMStabilityInspector.java:102 - Exiting due to error while processing commit
> log during initialization.
> org.apache.cassandra.db.commitlog.CommitLogReplayer$CommitLogReplayException:
> Unexpected error deserializing mutation; saved to
> /var/folders/cm/08cddl2s25j7fq3jdb76gh4rgn/T/mutation6239873170066752296dat.
> This may be caused by replaying a mutation against a table with the same
> name but incompatible schema.
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.handleReplayError(CommitLogReplayer.java:731)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.replayMutation(CommitLogReplayer.java:656)
> [dtest-3.0.21.jar:na]
> at
>
[jira] [Comment Edited] (CASSANDRA-15970) 3.x fails to start if commit log has range tombstones from a column which is also deleted
[
https://issues.apache.org/jira/browse/CASSANDRA-15970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166585#comment-17166585
]
David Capwell edited comment on CASSANDRA-15970 at 7/28/20, 7:19 PM:
-
CI Links
2.2:
https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=bug%2FCASSANDRA-15970-2.2
3.0:
https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=bug%2FCASSANDRA-15970-3.0
3.11:
https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=bug%2FCASSANDRA-15970-3.11
trunk:
https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=bug%2FCASSANDRA-15970
Tests failed with the following:
2.2:
https://issues.apache.org/jira/browse/CASSANDRA-15985 (python dtest TestCqlsh
added enable_scripted_user_defined_functions which breaks on 2.2)
https://issues.apache.org/jira/browse/CASSANDRA-15984
(thrift_hsha_test.TestThriftHSHA test_closing_connections is broken on 3.0 and
3.11)
3.0:
3.11:
https://issues.apache.org/jira/browse/CASSANDRA-15881 (Flaky unit test:
SASIIndexTest.testInsertingIncorrectValuesIntoAgeIndex) - not actually, same
class but different test (testIndexMemtableSwitching); don't see a JIRA for
this test
https://issues.apache.org/jira/browse/CASSANDRA-15984
(thrift_hsha_test.TestThriftHSHA test_closing_connections is broken on 3.0 and
3.11)
Trunk:
https://issues.apache.org/jira/browse/CASSANDRA-15981 (jvm-dtests crash on java
11)
https://issues.apache.org/jira/browse/CASSANDRA-15992 (Fix flaky python dtest
test_13595 - consistency_test.TestConsistency)
https://issues.apache.org/jira/browse/CASSANDRA-15993 (Fix flaky python dtest
test_view_metadata_cleanup - materialized_views_test.TestMaterializedViews)
was (Author: dcapwell):
CI Links
2.2:
https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=bug%2FCASSANDRA-15970-2.2
3.0:
https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=bug%2FCASSANDRA-15970-3.0
3.11:
https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=bug%2FCASSANDRA-15970-3.11
trunk:
https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=bug%2FCASSANDRA-15970
Tests failed with the following:
2.2:
https://issues.apache.org/jira/browse/CASSANDRA-15985 (python dtest TestCqlsh
added enable_scripted_user_defined_functions which breaks on 2.2)
https://issues.apache.org/jira/browse/CASSANDRA-15984
(thrift_hsha_test.TestThriftHSHA test_closing_connections is broken on 3.0 and
3.11)
3.0:
3.11:
https://issues.apache.org/jira/browse/CASSANDRA-15881 (Flaky unit test:
SASIIndexTest.testInsertingIncorrectValuesIntoAgeIndex) - not actually, same
class but different test (testIndexMemtableSwitching); don't see a JIRA for
this test
https://issues.apache.org/jira/browse/CASSANDRA-15984
(thrift_hsha_test.TestThriftHSHA test_closing_connections is broken on 3.0 and
3.11)
Trunk:
https://issues.apache.org/jira/browse/CASSANDRA-15981 (jvm-dtests crash on java
11)
> 3.x fails to start if commit log has range tombstones from a column which is
> also deleted
> -
>
> Key: CASSANDRA-15970
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15970
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Local Write-Read Paths, Local/Commit Log
>Reporter: David Capwell
>Assignee: David Capwell
>Priority: Normal
> Fix For: 3.0.x, 3.11.x
>
>
> Cassandra crashes with the following exception
> {code}
> ERROR [node1_isolatedExecutor:1] node1 2020-07-21 18:59:39,048
> JVMStabilityInspector.java:102 - Exiting due to error while processing commit
> log during initialization.
> org.apache.cassandra.db.commitlog.CommitLogReplayer$CommitLogReplayException:
> Unexpected error deserializing mutation; saved to
> /var/folders/cm/08cddl2s25j7fq3jdb76gh4rgn/T/mutation6239873170066752296dat.
> This may be caused by replaying a mutation against a table with the same
> name but incompatible schema.
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.handleReplayError(CommitLogReplayer.java:731)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.replayMutation(CommitLogReplayer.java:656)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.replaySyncSection(CommitLogReplayer.java:609)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.recover(CommitLogReplayer.java:493)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.recover(CommitLogReplayer.java:189)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLog.recover(CommitLog.java:170)
> [dtest-3.0.21.jar:na]
> at
>
[jira] [Updated] (CASSANDRA-15993) Fix flaky python dtest test_view_metadata_cleanup - materialized_views_test.TestMaterializedViews
[
https://issues.apache.org/jira/browse/CASSANDRA-15993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Capwell updated CASSANDRA-15993:
--
Bug Category: Parent values: Correctness(12982)Level 1 values: Test
Failure(12990)
Complexity: Normal
Discovered By: Unit Test
Fix Version/s: 4.0-beta
Severity: Normal
Status: Open (was: Triage Needed)
> Fix flaky python dtest test_view_metadata_cleanup -
> materialized_views_test.TestMaterializedViews
> -
>
> Key: CASSANDRA-15993
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15993
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest
>Reporter: David Capwell
>Priority: Normal
> Fix For: 4.0-beta
>
>
> https://app.circleci.com/pipelines/github/dcapwell/cassandra/355/workflows/7b8df61d-706f-4094-a206-7cdc6b4e0451/jobs/1818
> {code}
> E cassandra.OperationTimedOut: errors={'127.0.0.2': 'Client request
> timeout. See Session.execute[_async](timeout)'}, last_host=127.0.0.2
> cassandra/cluster.py:4026: OperationTimedOut
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-15993) Fix flaky python dtest test_view_metadata_cleanup - materialized_views_test.TestMaterializedViews
David Capwell created CASSANDRA-15993:
-
Summary: Fix flaky python dtest test_view_metadata_cleanup -
materialized_views_test.TestMaterializedViews
Key: CASSANDRA-15993
URL: https://issues.apache.org/jira/browse/CASSANDRA-15993
Project: Cassandra
Issue Type: Bug
Components: Test/dtest
Reporter: David Capwell
https://app.circleci.com/pipelines/github/dcapwell/cassandra/355/workflows/7b8df61d-706f-4094-a206-7cdc6b4e0451/jobs/1818
{code}
E cassandra.OperationTimedOut: errors={'127.0.0.2': 'Client request timeout.
See Session.execute[_async](timeout)'}, last_host=127.0.0.2
cassandra/cluster.py:4026: OperationTimedOut
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15992) Fix flaky python dtest test_13595 - consistency_test.TestConsistency
[
https://issues.apache.org/jira/browse/CASSANDRA-15992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Capwell updated CASSANDRA-15992:
--
Bug Category: Parent values: Correctness(12982)Level 1 values: Test
Failure(12990)
Complexity: Normal
Discovered By: Unit Test
Fix Version/s: 4.0-beta
Severity: Normal
Status: Open (was: Triage Needed)
> Fix flaky python dtest test_13595 - consistency_test.TestConsistency
>
>
> Key: CASSANDRA-15992
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15992
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest
>Reporter: David Capwell
>Priority: Normal
> Fix For: 4.0-beta
>
>
> https://app.circleci.com/pipelines/github/dcapwell/cassandra/355/workflows/7b8df61d-706f-4094-a206-7cdc6b4e0451/jobs/1818
> {code}
> > assert 9 == jmx.read_attribute(srp, 'Count')
> E AssertionError: assert 9 == 5
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-15992) Fix flaky python dtest test_13595 - consistency_test.TestConsistency
David Capwell created CASSANDRA-15992:
-
Summary: Fix flaky python dtest test_13595 -
consistency_test.TestConsistency
Key: CASSANDRA-15992
URL: https://issues.apache.org/jira/browse/CASSANDRA-15992
Project: Cassandra
Issue Type: Bug
Components: Test/dtest
Reporter: David Capwell
https://app.circleci.com/pipelines/github/dcapwell/cassandra/355/workflows/7b8df61d-706f-4094-a206-7cdc6b4e0451/jobs/1818
{code}
> assert 9 == jmx.read_attribute(srp, 'Count')
E AssertionError: assert 9 == 5
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15970) 3.x fails to start if commit log has range tombstones from a column which is also deleted
[
https://issues.apache.org/jira/browse/CASSANDRA-15970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166628#comment-17166628
]
David Capwell commented on CASSANDRA-15970:
---
test on 3.11 is flaky due to timeouts, I will refactor it so each test case is
its own class =(
> 3.x fails to start if commit log has range tombstones from a column which is
> also deleted
> -
>
> Key: CASSANDRA-15970
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15970
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Local Write-Read Paths, Local/Commit Log
>Reporter: David Capwell
>Assignee: David Capwell
>Priority: Normal
> Fix For: 3.0.x, 3.11.x
>
>
> Cassandra crashes with the following exception
> {code}
> ERROR [node1_isolatedExecutor:1] node1 2020-07-21 18:59:39,048
> JVMStabilityInspector.java:102 - Exiting due to error while processing commit
> log during initialization.
> org.apache.cassandra.db.commitlog.CommitLogReplayer$CommitLogReplayException:
> Unexpected error deserializing mutation; saved to
> /var/folders/cm/08cddl2s25j7fq3jdb76gh4rgn/T/mutation6239873170066752296dat.
> This may be caused by replaying a mutation against a table with the same
> name but incompatible schema.
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.handleReplayError(CommitLogReplayer.java:731)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.replayMutation(CommitLogReplayer.java:656)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.replaySyncSection(CommitLogReplayer.java:609)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.recover(CommitLogReplayer.java:493)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.recover(CommitLogReplayer.java:189)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLog.recover(CommitLog.java:170)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLog.recover(CommitLog.java:151)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.distributed.impl.Instance.lambda$startup$7(Instance.java:535)
> [dtest-3.0.21.jar:na]
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> ~[na:1.8.0_242]
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> ~[na:1.8.0_242]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> ~[na:1.8.0_242]
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> ~[na:1.8.0_242]
> at
> org.apache.cassandra.concurrent.NamedThreadFactory.lambda$threadLocalDeallocator$0(NamedThreadFactory.java:83)
> ~[dtest-3.0.21.jar:na]
> at java.lang.Thread.run(Thread.java:748) ~[na:1.8.0_242]
> Caused by: java.lang.NullPointerException: null
> at
> org.apache.cassandra.db.ClusteringComparator.validate(ClusteringComparator.java:206)
> ~[dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.partitions.PartitionUpdate.validate(PartitionUpdate.java:494)
> ~[dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.replayMutation(CommitLogReplayer.java:629)
> [dtest-3.0.21.jar:na]
> ... 12 common frames omitted
> {code}
> If you drain in 2.2 before upgrade, you get the following
> {code}
> ERROR [SharedPool-Worker-1] node1 2020-07-21 22:17:25,661
> AbstractLocalAwareExecutorService.java:169 - Uncaught exception on thread
> Thread[SharedPool-Worker-1,5,node1]
> java.lang.RuntimeException: java.lang.NullPointerException
> at
> org.apache.cassandra.service.StorageProxy$DroppableRunnable.run(StorageProxy.java:2537)
> ~[dtest-3.0.21.jar:na]
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> ~[na:1.8.0_242]
> at
> org.apache.cassandra.concurrent.AbstractLocalAwareExecutorService$FutureTask.run(AbstractLocalAwareExecutorService.java:165)
> ~[dtest-3.0.21.jar:na]
> at org.apache.cassandra.concurrent.SEPWorker.run(SEPWorker.java:109)
> [dtest-3.0.21.jar:na]
> at java.lang.Thread.run(Thread.java:748) [na:1.8.0_242]
> Caused by: java.lang.NullPointerException: null
> at
> org.apache.cassandra.db.ClusteringComparator.compare(ClusteringComparator.java:131)
> ~[dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.UnfilteredDeserializer$OldFormatDeserializer.compareNextTo(UnfilteredDeserializer.java:391)
> ~[dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.columniterator.SSTableIterator$ForwardReader.handlePreSliceData(SSTableIterator.java:105)
> ~[dtest-3.0.21.jar:na]
> at
>
[jira] [Comment Edited] (CASSANDRA-15970) 3.x fails to start if commit log has range tombstones from a column which is also deleted
[
https://issues.apache.org/jira/browse/CASSANDRA-15970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166628#comment-17166628
]
David Capwell edited comment on CASSANDRA-15970 at 7/28/20, 6:48 PM:
-
upgrade test on 3.11 is flaky due to timeouts, I will refactor it so each test
case is its own class =(
was (Author: dcapwell):
test on 3.11 is flaky due to timeouts, I will refactor it so each test case is
its own class =(
> 3.x fails to start if commit log has range tombstones from a column which is
> also deleted
> -
>
> Key: CASSANDRA-15970
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15970
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Local Write-Read Paths, Local/Commit Log
>Reporter: David Capwell
>Assignee: David Capwell
>Priority: Normal
> Fix For: 3.0.x, 3.11.x
>
>
> Cassandra crashes with the following exception
> {code}
> ERROR [node1_isolatedExecutor:1] node1 2020-07-21 18:59:39,048
> JVMStabilityInspector.java:102 - Exiting due to error while processing commit
> log during initialization.
> org.apache.cassandra.db.commitlog.CommitLogReplayer$CommitLogReplayException:
> Unexpected error deserializing mutation; saved to
> /var/folders/cm/08cddl2s25j7fq3jdb76gh4rgn/T/mutation6239873170066752296dat.
> This may be caused by replaying a mutation against a table with the same
> name but incompatible schema.
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.handleReplayError(CommitLogReplayer.java:731)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.replayMutation(CommitLogReplayer.java:656)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.replaySyncSection(CommitLogReplayer.java:609)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.recover(CommitLogReplayer.java:493)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.recover(CommitLogReplayer.java:189)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLog.recover(CommitLog.java:170)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLog.recover(CommitLog.java:151)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.distributed.impl.Instance.lambda$startup$7(Instance.java:535)
> [dtest-3.0.21.jar:na]
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> ~[na:1.8.0_242]
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> ~[na:1.8.0_242]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> ~[na:1.8.0_242]
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> ~[na:1.8.0_242]
> at
> org.apache.cassandra.concurrent.NamedThreadFactory.lambda$threadLocalDeallocator$0(NamedThreadFactory.java:83)
> ~[dtest-3.0.21.jar:na]
> at java.lang.Thread.run(Thread.java:748) ~[na:1.8.0_242]
> Caused by: java.lang.NullPointerException: null
> at
> org.apache.cassandra.db.ClusteringComparator.validate(ClusteringComparator.java:206)
> ~[dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.partitions.PartitionUpdate.validate(PartitionUpdate.java:494)
> ~[dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.replayMutation(CommitLogReplayer.java:629)
> [dtest-3.0.21.jar:na]
> ... 12 common frames omitted
> {code}
> If you drain in 2.2 before upgrade, you get the following
> {code}
> ERROR [SharedPool-Worker-1] node1 2020-07-21 22:17:25,661
> AbstractLocalAwareExecutorService.java:169 - Uncaught exception on thread
> Thread[SharedPool-Worker-1,5,node1]
> java.lang.RuntimeException: java.lang.NullPointerException
> at
> org.apache.cassandra.service.StorageProxy$DroppableRunnable.run(StorageProxy.java:2537)
> ~[dtest-3.0.21.jar:na]
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> ~[na:1.8.0_242]
> at
> org.apache.cassandra.concurrent.AbstractLocalAwareExecutorService$FutureTask.run(AbstractLocalAwareExecutorService.java:165)
> ~[dtest-3.0.21.jar:na]
> at org.apache.cassandra.concurrent.SEPWorker.run(SEPWorker.java:109)
> [dtest-3.0.21.jar:na]
> at java.lang.Thread.run(Thread.java:748) [na:1.8.0_242]
> Caused by: java.lang.NullPointerException: null
> at
> org.apache.cassandra.db.ClusteringComparator.compare(ClusteringComparator.java:131)
> ~[dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.UnfilteredDeserializer$OldFormatDeserializer.compareNextTo(UnfilteredDeserializer.java:391)
> ~[dtest-3.0.21.jar:na]
>
[jira] [Updated] (CASSANDRA-15980) Improve log messages for socket connection/disconnection
[
https://issues.apache.org/jira/browse/CASSANDRA-15980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aleksey Yeschenko updated CASSANDRA-15980:
--
Reviewers: Aleksey Yeschenko
> Improve log messages for socket connection/disconnection
>
>
> Key: CASSANDRA-15980
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15980
> Project: Cassandra
> Issue Type: Bug
> Components: Observability/Logging
>Reporter: Jon Meredith
>Assignee: Jon Meredith
>Priority: Normal
> Fix For: 4.0-beta
>
>
> Logging for inbound SSL connections can take place before protocol
> negotiation has taken place and logs a misleading cipher that could cause
> problems for security auditing.
>
>
> {code:java}
> INFO 2020-07-03T13:57:58,380 [Messaging-EventLoop-3-1]
> org.apache.cassandra.net.InboundConnectionInitiator:242 - connection from
> peer /1.1.1.1:57899 to /2.2.2.2:7000, protocol = TLSv1.2, cipher suite =
> SSL_NULL_WITH_NULL_NULL
> {code}
>
> Instead Cassandra should log the connection & protocol, then once the cipher
> has been negotiated log the agreed upon cipher.
>
>
> If the inbound SSL connection does not present a client certificate,
> Cassandra logs this error, even if the client wasn't required to.
> {code:java}
> ERROR 2020-07-14T11:58:45,925 [Native-Transport-Requests-1]
> org.apache.cassandra.transport.ServerConnection:140 - Failed to get peer
> certificates for peer /4.3.2.1:59263
> {code}
>
> Logging the absense of verified certificates should be a concern of the
> SaslNegotiator if it requires it, and not something worth alerting the
> operator for generally. Downgrade to debug message to make investigation
> possible if needed.
>
>
> Finally, to help with logging issues related to disconnection, add a log
> statement when an instance decides it no longer needs to keep a gossip
> connection open when cleaning up connections in
> org.apache.cassandra.net.OutboundConnections.UnusedConnectionMonitor#closeUnusedSinceLastRun
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-15970) 3.x fails to start if commit log has range tombstones from a column which is also deleted
[
https://issues.apache.org/jira/browse/CASSANDRA-15970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166585#comment-17166585
]
David Capwell edited comment on CASSANDRA-15970 at 7/28/20, 6:35 PM:
-
CI Links
2.2:
https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=bug%2FCASSANDRA-15970-2.2
3.0:
https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=bug%2FCASSANDRA-15970-3.0
3.11:
https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=bug%2FCASSANDRA-15970-3.11
trunk:
https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=bug%2FCASSANDRA-15970
Tests failed with the following:
2.2:
https://issues.apache.org/jira/browse/CASSANDRA-15985 (python dtest TestCqlsh
added enable_scripted_user_defined_functions which breaks on 2.2)
https://issues.apache.org/jira/browse/CASSANDRA-15984
(thrift_hsha_test.TestThriftHSHA test_closing_connections is broken on 3.0 and
3.11)
3.0:
3.11:
https://issues.apache.org/jira/browse/CASSANDRA-15881 (Flaky unit test:
SASIIndexTest.testInsertingIncorrectValuesIntoAgeIndex) - not actually, same
class but different test (testIndexMemtableSwitching); don't see a JIRA for
this test
https://issues.apache.org/jira/browse/CASSANDRA-15984
(thrift_hsha_test.TestThriftHSHA test_closing_connections is broken on 3.0 and
3.11)
Trunk:
https://issues.apache.org/jira/browse/CASSANDRA-15981 (jvm-dtests crash on java
11)
was (Author: dcapwell):
CI Links
2.2:
https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=bug%2FCASSANDRA-15970-2.2
3.0:
https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=bug%2FCASSANDRA-15970-3.0
3.11:
https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=bug%2FCASSANDRA-15970-3.11
trunk:
https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=bug%2FCASSANDRA-15970
Tests failed with the following:
2.2:
https://issues.apache.org/jira/browse/CASSANDRA-15985 (python dtest TestCqlsh
added enable_scripted_user_defined_functions which breaks on 2.2)
https://issues.apache.org/jira/browse/CASSANDRA-15984
(thrift_hsha_test.TestThriftHSHA test_closing_connections is broken on 3.0 and
3.11)
3.0:
3.11:
https://issues.apache.org/jira/browse/CASSANDRA-15881 (Flaky unit test:
SASIIndexTest.testInsertingIncorrectValuesIntoAgeIndex) - not actually, same
class but different test (testIndexMemtableSwitching); don't see a JIRA for
this test
Trunk:
https://issues.apache.org/jira/browse/CASSANDRA-15981 (jvm-dtests crash on java
11)
> 3.x fails to start if commit log has range tombstones from a column which is
> also deleted
> -
>
> Key: CASSANDRA-15970
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15970
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Local Write-Read Paths, Local/Commit Log
>Reporter: David Capwell
>Assignee: David Capwell
>Priority: Normal
> Fix For: 3.0.x, 3.11.x
>
>
> Cassandra crashes with the following exception
> {code}
> ERROR [node1_isolatedExecutor:1] node1 2020-07-21 18:59:39,048
> JVMStabilityInspector.java:102 - Exiting due to error while processing commit
> log during initialization.
> org.apache.cassandra.db.commitlog.CommitLogReplayer$CommitLogReplayException:
> Unexpected error deserializing mutation; saved to
> /var/folders/cm/08cddl2s25j7fq3jdb76gh4rgn/T/mutation6239873170066752296dat.
> This may be caused by replaying a mutation against a table with the same
> name but incompatible schema.
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.handleReplayError(CommitLogReplayer.java:731)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.replayMutation(CommitLogReplayer.java:656)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.replaySyncSection(CommitLogReplayer.java:609)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.recover(CommitLogReplayer.java:493)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.recover(CommitLogReplayer.java:189)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLog.recover(CommitLog.java:170)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLog.recover(CommitLog.java:151)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.distributed.impl.Instance.lambda$startup$7(Instance.java:535)
> [dtest-3.0.21.jar:na]
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> ~[na:1.8.0_242]
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> ~[na:1.8.0_242]
> at
>
[jira] [Commented] (CASSANDRA-15970) 3.x fails to start if commit log has range tombstones from a column which is also deleted
[
https://issues.apache.org/jira/browse/CASSANDRA-15970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166617#comment-17166617
]
Brandon Williams commented on CASSANDRA-15970:
--
I see. +1
> 3.x fails to start if commit log has range tombstones from a column which is
> also deleted
> -
>
> Key: CASSANDRA-15970
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15970
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Local Write-Read Paths, Local/Commit Log
>Reporter: David Capwell
>Assignee: David Capwell
>Priority: Normal
> Fix For: 3.0.x, 3.11.x
>
>
> Cassandra crashes with the following exception
> {code}
> ERROR [node1_isolatedExecutor:1] node1 2020-07-21 18:59:39,048
> JVMStabilityInspector.java:102 - Exiting due to error while processing commit
> log during initialization.
> org.apache.cassandra.db.commitlog.CommitLogReplayer$CommitLogReplayException:
> Unexpected error deserializing mutation; saved to
> /var/folders/cm/08cddl2s25j7fq3jdb76gh4rgn/T/mutation6239873170066752296dat.
> This may be caused by replaying a mutation against a table with the same
> name but incompatible schema.
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.handleReplayError(CommitLogReplayer.java:731)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.replayMutation(CommitLogReplayer.java:656)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.replaySyncSection(CommitLogReplayer.java:609)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.recover(CommitLogReplayer.java:493)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.recover(CommitLogReplayer.java:189)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLog.recover(CommitLog.java:170)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLog.recover(CommitLog.java:151)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.distributed.impl.Instance.lambda$startup$7(Instance.java:535)
> [dtest-3.0.21.jar:na]
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> ~[na:1.8.0_242]
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> ~[na:1.8.0_242]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> ~[na:1.8.0_242]
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> ~[na:1.8.0_242]
> at
> org.apache.cassandra.concurrent.NamedThreadFactory.lambda$threadLocalDeallocator$0(NamedThreadFactory.java:83)
> ~[dtest-3.0.21.jar:na]
> at java.lang.Thread.run(Thread.java:748) ~[na:1.8.0_242]
> Caused by: java.lang.NullPointerException: null
> at
> org.apache.cassandra.db.ClusteringComparator.validate(ClusteringComparator.java:206)
> ~[dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.partitions.PartitionUpdate.validate(PartitionUpdate.java:494)
> ~[dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.replayMutation(CommitLogReplayer.java:629)
> [dtest-3.0.21.jar:na]
> ... 12 common frames omitted
> {code}
> If you drain in 2.2 before upgrade, you get the following
> {code}
> ERROR [SharedPool-Worker-1] node1 2020-07-21 22:17:25,661
> AbstractLocalAwareExecutorService.java:169 - Uncaught exception on thread
> Thread[SharedPool-Worker-1,5,node1]
> java.lang.RuntimeException: java.lang.NullPointerException
> at
> org.apache.cassandra.service.StorageProxy$DroppableRunnable.run(StorageProxy.java:2537)
> ~[dtest-3.0.21.jar:na]
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> ~[na:1.8.0_242]
> at
> org.apache.cassandra.concurrent.AbstractLocalAwareExecutorService$FutureTask.run(AbstractLocalAwareExecutorService.java:165)
> ~[dtest-3.0.21.jar:na]
> at org.apache.cassandra.concurrent.SEPWorker.run(SEPWorker.java:109)
> [dtest-3.0.21.jar:na]
> at java.lang.Thread.run(Thread.java:748) [na:1.8.0_242]
> Caused by: java.lang.NullPointerException: null
> at
> org.apache.cassandra.db.ClusteringComparator.compare(ClusteringComparator.java:131)
> ~[dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.UnfilteredDeserializer$OldFormatDeserializer.compareNextTo(UnfilteredDeserializer.java:391)
> ~[dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.columniterator.SSTableIterator$ForwardReader.handlePreSliceData(SSTableIterator.java:105)
> ~[dtest-3.0.21.jar:na]
> at
>
[jira] [Assigned] (CASSANDRA-15801) Tiny documentation fix in Architecture/Overview
[ https://issues.apache.org/jira/browse/CASSANDRA-15801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lorina Poland reassigned CASSANDRA-15801: - Assignee: Lorina Poland > Tiny documentation fix in Architecture/Overview > --- > > Key: CASSANDRA-15801 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15801 > Project: Cassandra > Issue Type: Bug > Components: Documentation/Website >Reporter: Philip White >Assignee: Lorina Poland >Priority: Normal > Attachments: > 0001-CASSANDRA-15801-Fix-typo-in-Architecture-Overview-do.patch > > > I noticed a small issue in the documentation, so I'd like to fix it. > This issue also exists to guide me to the proper way to make contributions to > Cassandra, hopefully larger ones in the future, so please forgive the > trivialness of this fix. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15964) Update Home index.html and remove all dead links
[ https://issues.apache.org/jira/browse/CASSANDRA-15964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lorina Poland updated CASSANDRA-15964: -- Resolution: Fixed Status: Resolved (was: Triage Needed) Merged. > Update Home index.html and remove all dead links > > > Key: CASSANDRA-15964 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15964 > Project: Cassandra > Issue Type: Improvement > Components: Documentation/Website >Reporter: Lorina Poland >Assignee: Lorina Poland >Priority: Normal > Labels: pull-request-available > > There are a number of tickets for home page improvement. Do all the work and > republish. > Linked to: > CASSANDRA-14128 > CASSANDRA-15237 > In addition, Mick Semb Wever suggested the following be added to the list of > companies using Cassandra: > Can we find links for the following? > - Key customers: Apple, Netflix, Uber, ING, Cern, Intuit, Fidelity, NY > Times, Outbrain, BazaarVoice, Best Buy, Comcast, eBay, Hulu, Sky, Pearson > Education, Walmart, Microsoft, Macy's™, McDonalds, Macquarie Bank, GitHub, > Spotify, Instagram. > - Market metrics: Cassandra is used by 40% of the Fortune 100. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15237) Professionally Support Link is Broken
[ https://issues.apache.org/jira/browse/CASSANDRA-15237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lorina Poland updated CASSANDRA-15237: -- Resolution: Fixed Status: Resolved (was: Triage Needed) Fixed as part of another merge. > Professionally Support Link is Broken > - > > Key: CASSANDRA-15237 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15237 > Project: Cassandra > Issue Type: Improvement > Components: Documentation/Website >Reporter: Rahul Singh >Assignee: Lorina Poland >Priority: Normal > Attachments: image-2019-07-18-11-05-30-440.png, > image-2019-07-18-11-06-03-030.png > > > Link is broken. Either it should go to the new confluence page we are working > on or the link be taken down. > > !image-2019-07-18-11-06-03-030.png! > > > !image-2019-07-18-11-05-30-440.png! -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-15237) Professionally Support Link is Broken
[ https://issues.apache.org/jira/browse/CASSANDRA-15237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lorina Poland reassigned CASSANDRA-15237: - Assignee: Lorina Poland (was: Rahul Singh) > Professionally Support Link is Broken > - > > Key: CASSANDRA-15237 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15237 > Project: Cassandra > Issue Type: Improvement > Components: Documentation/Website >Reporter: Rahul Singh >Assignee: Lorina Poland >Priority: Normal > Attachments: image-2019-07-18-11-05-30-440.png, > image-2019-07-18-11-06-03-030.png > > > Link is broken. Either it should go to the new confluence page we are working > on or the link be taken down. > > !image-2019-07-18-11-06-03-030.png! > > > !image-2019-07-18-11-05-30-440.png! -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-15970) 3.x fails to start if commit log has range tombstones from a column which is also deleted
[
https://issues.apache.org/jira/browse/CASSANDRA-15970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166585#comment-17166585
]
David Capwell edited comment on CASSANDRA-15970 at 7/28/20, 6:12 PM:
-
CI Links
2.2:
https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=bug%2FCASSANDRA-15970-2.2
3.0:
https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=bug%2FCASSANDRA-15970-3.0
3.11:
https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=bug%2FCASSANDRA-15970-3.11
trunk:
https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=bug%2FCASSANDRA-15970
Tests failed with the following:
2.2:
https://issues.apache.org/jira/browse/CASSANDRA-15985 (python dtest TestCqlsh
added enable_scripted_user_defined_functions which breaks on 2.2)
https://issues.apache.org/jira/browse/CASSANDRA-15984
(thrift_hsha_test.TestThriftHSHA test_closing_connections is broken on 3.0 and
3.11)
3.0:
3.11:
https://issues.apache.org/jira/browse/CASSANDRA-15881 (Flaky unit test:
SASIIndexTest.testInsertingIncorrectValuesIntoAgeIndex) - not actually, same
class but different test (testIndexMemtableSwitching); don't see a JIRA for
this test
Trunk:
https://issues.apache.org/jira/browse/CASSANDRA-15981 (jvm-dtests crash on java
11)
was (Author: dcapwell):
CI Links
2.2:
https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=bug%2FCASSANDRA-15970-2.2
3.0:
https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=bug%2FCASSANDRA-15970-3.0
3.11:
https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=bug%2FCASSANDRA-15970-3.11
trunk:
https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=bug%2FCASSANDRA-15970
Tests failed with the following:
2.2:
https://issues.apache.org/jira/browse/CASSANDRA-15985
https://issues.apache.org/jira/browse/CASSANDRA-15984
3.0:
3.11:
https://issues.apache.org/jira/browse/CASSANDRA-15881 - not actually, same
class but different test; don't see a JIRA for this test
Trunk:
https://issues.apache.org/jira/browse/CASSANDRA-15981
> 3.x fails to start if commit log has range tombstones from a column which is
> also deleted
> -
>
> Key: CASSANDRA-15970
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15970
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Local Write-Read Paths, Local/Commit Log
>Reporter: David Capwell
>Assignee: David Capwell
>Priority: Normal
> Fix For: 3.0.x, 3.11.x
>
>
> Cassandra crashes with the following exception
> {code}
> ERROR [node1_isolatedExecutor:1] node1 2020-07-21 18:59:39,048
> JVMStabilityInspector.java:102 - Exiting due to error while processing commit
> log during initialization.
> org.apache.cassandra.db.commitlog.CommitLogReplayer$CommitLogReplayException:
> Unexpected error deserializing mutation; saved to
> /var/folders/cm/08cddl2s25j7fq3jdb76gh4rgn/T/mutation6239873170066752296dat.
> This may be caused by replaying a mutation against a table with the same
> name but incompatible schema.
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.handleReplayError(CommitLogReplayer.java:731)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.replayMutation(CommitLogReplayer.java:656)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.replaySyncSection(CommitLogReplayer.java:609)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.recover(CommitLogReplayer.java:493)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.recover(CommitLogReplayer.java:189)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLog.recover(CommitLog.java:170)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLog.recover(CommitLog.java:151)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.distributed.impl.Instance.lambda$startup$7(Instance.java:535)
> [dtest-3.0.21.jar:na]
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> ~[na:1.8.0_242]
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> ~[na:1.8.0_242]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> ~[na:1.8.0_242]
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> ~[na:1.8.0_242]
> at
> org.apache.cassandra.concurrent.NamedThreadFactory.lambda$threadLocalDeallocator$0(NamedThreadFactory.java:83)
> ~[dtest-3.0.21.jar:na]
> at java.lang.Thread.run(Thread.java:748) ~[na:1.8.0_242]
> Caused by:
[jira] [Comment Edited] (CASSANDRA-15970) 3.x fails to start if commit log has range tombstones from a column which is also deleted
[
https://issues.apache.org/jira/browse/CASSANDRA-15970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166585#comment-17166585
]
David Capwell edited comment on CASSANDRA-15970 at 7/28/20, 6:11 PM:
-
CI Links
2.2:
https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=bug%2FCASSANDRA-15970-2.2
3.0:
https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=bug%2FCASSANDRA-15970-3.0
3.11:
https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=bug%2FCASSANDRA-15970-3.11
trunk:
https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=bug%2FCASSANDRA-15970
Tests failed with the following:
2.2:
https://issues.apache.org/jira/browse/CASSANDRA-15985
https://issues.apache.org/jira/browse/CASSANDRA-15984
3.0:
3.11:
https://issues.apache.org/jira/browse/CASSANDRA-15881 - not actually, same
class but different test; don't see a JIRA for this test
Trunk:
https://issues.apache.org/jira/browse/CASSANDRA-15981
was (Author: dcapwell):
CI Links
2.2:
https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=bug%2FCASSANDRA-15970-2.2
3.0:
https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=bug%2FCASSANDRA-15970-3.0
3.11:
https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=bug%2FCASSANDRA-15970-3.11
trunk:
https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=bug%2FCASSANDRA-15970
> 3.x fails to start if commit log has range tombstones from a column which is
> also deleted
> -
>
> Key: CASSANDRA-15970
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15970
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Local Write-Read Paths, Local/Commit Log
>Reporter: David Capwell
>Assignee: David Capwell
>Priority: Normal
> Fix For: 3.0.x, 3.11.x
>
>
> Cassandra crashes with the following exception
> {code}
> ERROR [node1_isolatedExecutor:1] node1 2020-07-21 18:59:39,048
> JVMStabilityInspector.java:102 - Exiting due to error while processing commit
> log during initialization.
> org.apache.cassandra.db.commitlog.CommitLogReplayer$CommitLogReplayException:
> Unexpected error deserializing mutation; saved to
> /var/folders/cm/08cddl2s25j7fq3jdb76gh4rgn/T/mutation6239873170066752296dat.
> This may be caused by replaying a mutation against a table with the same
> name but incompatible schema.
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.handleReplayError(CommitLogReplayer.java:731)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.replayMutation(CommitLogReplayer.java:656)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.replaySyncSection(CommitLogReplayer.java:609)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.recover(CommitLogReplayer.java:493)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.recover(CommitLogReplayer.java:189)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLog.recover(CommitLog.java:170)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLog.recover(CommitLog.java:151)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.distributed.impl.Instance.lambda$startup$7(Instance.java:535)
> [dtest-3.0.21.jar:na]
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> ~[na:1.8.0_242]
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> ~[na:1.8.0_242]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> ~[na:1.8.0_242]
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> ~[na:1.8.0_242]
> at
> org.apache.cassandra.concurrent.NamedThreadFactory.lambda$threadLocalDeallocator$0(NamedThreadFactory.java:83)
> ~[dtest-3.0.21.jar:na]
> at java.lang.Thread.run(Thread.java:748) ~[na:1.8.0_242]
> Caused by: java.lang.NullPointerException: null
> at
> org.apache.cassandra.db.ClusteringComparator.validate(ClusteringComparator.java:206)
> ~[dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.partitions.PartitionUpdate.validate(PartitionUpdate.java:494)
> ~[dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.replayMutation(CommitLogReplayer.java:629)
> [dtest-3.0.21.jar:na]
> ... 12 common frames omitted
> {code}
> If you drain in 2.2 before upgrade, you get the following
> {code}
> ERROR [SharedPool-Worker-1] node1 2020-07-21 22:17:25,661
> AbstractLocalAwareExecutorService.java:169 - Uncaught exception on thread
>
[jira] [Updated] (CASSANDRA-15970) 3.x fails to start if commit log has range tombstones from a column which is also deleted
[
https://issues.apache.org/jira/browse/CASSANDRA-15970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Capwell updated CASSANDRA-15970:
--
Reviewers: Brandon Williams (was: Brandon Williams, David Capwell)
> 3.x fails to start if commit log has range tombstones from a column which is
> also deleted
> -
>
> Key: CASSANDRA-15970
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15970
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Local Write-Read Paths, Local/Commit Log
>Reporter: David Capwell
>Assignee: David Capwell
>Priority: Normal
> Fix For: 3.0.x, 3.11.x
>
>
> Cassandra crashes with the following exception
> {code}
> ERROR [node1_isolatedExecutor:1] node1 2020-07-21 18:59:39,048
> JVMStabilityInspector.java:102 - Exiting due to error while processing commit
> log during initialization.
> org.apache.cassandra.db.commitlog.CommitLogReplayer$CommitLogReplayException:
> Unexpected error deserializing mutation; saved to
> /var/folders/cm/08cddl2s25j7fq3jdb76gh4rgn/T/mutation6239873170066752296dat.
> This may be caused by replaying a mutation against a table with the same
> name but incompatible schema.
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.handleReplayError(CommitLogReplayer.java:731)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.replayMutation(CommitLogReplayer.java:656)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.replaySyncSection(CommitLogReplayer.java:609)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.recover(CommitLogReplayer.java:493)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.recover(CommitLogReplayer.java:189)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLog.recover(CommitLog.java:170)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLog.recover(CommitLog.java:151)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.distributed.impl.Instance.lambda$startup$7(Instance.java:535)
> [dtest-3.0.21.jar:na]
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> ~[na:1.8.0_242]
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> ~[na:1.8.0_242]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> ~[na:1.8.0_242]
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> ~[na:1.8.0_242]
> at
> org.apache.cassandra.concurrent.NamedThreadFactory.lambda$threadLocalDeallocator$0(NamedThreadFactory.java:83)
> ~[dtest-3.0.21.jar:na]
> at java.lang.Thread.run(Thread.java:748) ~[na:1.8.0_242]
> Caused by: java.lang.NullPointerException: null
> at
> org.apache.cassandra.db.ClusteringComparator.validate(ClusteringComparator.java:206)
> ~[dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.partitions.PartitionUpdate.validate(PartitionUpdate.java:494)
> ~[dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.replayMutation(CommitLogReplayer.java:629)
> [dtest-3.0.21.jar:na]
> ... 12 common frames omitted
> {code}
> If you drain in 2.2 before upgrade, you get the following
> {code}
> ERROR [SharedPool-Worker-1] node1 2020-07-21 22:17:25,661
> AbstractLocalAwareExecutorService.java:169 - Uncaught exception on thread
> Thread[SharedPool-Worker-1,5,node1]
> java.lang.RuntimeException: java.lang.NullPointerException
> at
> org.apache.cassandra.service.StorageProxy$DroppableRunnable.run(StorageProxy.java:2537)
> ~[dtest-3.0.21.jar:na]
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> ~[na:1.8.0_242]
> at
> org.apache.cassandra.concurrent.AbstractLocalAwareExecutorService$FutureTask.run(AbstractLocalAwareExecutorService.java:165)
> ~[dtest-3.0.21.jar:na]
> at org.apache.cassandra.concurrent.SEPWorker.run(SEPWorker.java:109)
> [dtest-3.0.21.jar:na]
> at java.lang.Thread.run(Thread.java:748) [na:1.8.0_242]
> Caused by: java.lang.NullPointerException: null
> at
> org.apache.cassandra.db.ClusteringComparator.compare(ClusteringComparator.java:131)
> ~[dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.UnfilteredDeserializer$OldFormatDeserializer.compareNextTo(UnfilteredDeserializer.java:391)
> ~[dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.columniterator.SSTableIterator$ForwardReader.handlePreSliceData(SSTableIterator.java:105)
> ~[dtest-3.0.21.jar:na]
> at
>
[jira] [Updated] (CASSANDRA-15970) 3.x fails to start if commit log has range tombstones from a column which is also deleted
[
https://issues.apache.org/jira/browse/CASSANDRA-15970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Capwell updated CASSANDRA-15970:
--
Reviewers: Brandon Williams, David Capwell
Status: Review In Progress (was: Patch Available)
> 3.x fails to start if commit log has range tombstones from a column which is
> also deleted
> -
>
> Key: CASSANDRA-15970
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15970
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Local Write-Read Paths, Local/Commit Log
>Reporter: David Capwell
>Assignee: David Capwell
>Priority: Normal
> Fix For: 3.0.x, 3.11.x
>
>
> Cassandra crashes with the following exception
> {code}
> ERROR [node1_isolatedExecutor:1] node1 2020-07-21 18:59:39,048
> JVMStabilityInspector.java:102 - Exiting due to error while processing commit
> log during initialization.
> org.apache.cassandra.db.commitlog.CommitLogReplayer$CommitLogReplayException:
> Unexpected error deserializing mutation; saved to
> /var/folders/cm/08cddl2s25j7fq3jdb76gh4rgn/T/mutation6239873170066752296dat.
> This may be caused by replaying a mutation against a table with the same
> name but incompatible schema.
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.handleReplayError(CommitLogReplayer.java:731)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.replayMutation(CommitLogReplayer.java:656)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.replaySyncSection(CommitLogReplayer.java:609)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.recover(CommitLogReplayer.java:493)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.recover(CommitLogReplayer.java:189)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLog.recover(CommitLog.java:170)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLog.recover(CommitLog.java:151)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.distributed.impl.Instance.lambda$startup$7(Instance.java:535)
> [dtest-3.0.21.jar:na]
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> ~[na:1.8.0_242]
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> ~[na:1.8.0_242]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> ~[na:1.8.0_242]
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> ~[na:1.8.0_242]
> at
> org.apache.cassandra.concurrent.NamedThreadFactory.lambda$threadLocalDeallocator$0(NamedThreadFactory.java:83)
> ~[dtest-3.0.21.jar:na]
> at java.lang.Thread.run(Thread.java:748) ~[na:1.8.0_242]
> Caused by: java.lang.NullPointerException: null
> at
> org.apache.cassandra.db.ClusteringComparator.validate(ClusteringComparator.java:206)
> ~[dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.partitions.PartitionUpdate.validate(PartitionUpdate.java:494)
> ~[dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.replayMutation(CommitLogReplayer.java:629)
> [dtest-3.0.21.jar:na]
> ... 12 common frames omitted
> {code}
> If you drain in 2.2 before upgrade, you get the following
> {code}
> ERROR [SharedPool-Worker-1] node1 2020-07-21 22:17:25,661
> AbstractLocalAwareExecutorService.java:169 - Uncaught exception on thread
> Thread[SharedPool-Worker-1,5,node1]
> java.lang.RuntimeException: java.lang.NullPointerException
> at
> org.apache.cassandra.service.StorageProxy$DroppableRunnable.run(StorageProxy.java:2537)
> ~[dtest-3.0.21.jar:na]
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> ~[na:1.8.0_242]
> at
> org.apache.cassandra.concurrent.AbstractLocalAwareExecutorService$FutureTask.run(AbstractLocalAwareExecutorService.java:165)
> ~[dtest-3.0.21.jar:na]
> at org.apache.cassandra.concurrent.SEPWorker.run(SEPWorker.java:109)
> [dtest-3.0.21.jar:na]
> at java.lang.Thread.run(Thread.java:748) [na:1.8.0_242]
> Caused by: java.lang.NullPointerException: null
> at
> org.apache.cassandra.db.ClusteringComparator.compare(ClusteringComparator.java:131)
> ~[dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.UnfilteredDeserializer$OldFormatDeserializer.compareNextTo(UnfilteredDeserializer.java:391)
> ~[dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.columniterator.SSTableIterator$ForwardReader.handlePreSliceData(SSTableIterator.java:105)
> ~[dtest-3.0.21.jar:na]
> at
>
[jira] [Commented] (CASSANDRA-15970) 3.x fails to start if commit log has range tombstones from a column which is also deleted
[
https://issues.apache.org/jira/browse/CASSANDRA-15970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166605#comment-17166605
]
David Capwell commented on CASSANDRA-15970:
---
Thanks [~brandon.williams] for the review!
bq. I'm confused, why is there a 2.2 patch?
This line
https://github.com/dcapwell/cassandra/commit/52005e0061ea9ea8bf9c6ea782c75c39f23c0569#diff-31dfa99c0e891a6d048dd82581a3e6eeR69
{code}
// write table to pk=1
// NOTE: because jvm-dtest doesn't support collections in the execute interface
(see CASSANDRA-15969)
// need to encode to a ByteBuffer first
coordinator.execute(withKeyspace("INSERT INTO %s.tbl (pk, tables) VALUES (?,
?)"), ConsistencyLevel.ONE, 1, MAP_TYPE.decompose(ImmutableMap.of(1, 1)));
{code}
For the upgrade test, we run the inserts in 2.2. jvm-dtest doesn't support
collection types, so need to convert to a ByteBuffer. jvm-dtest uses
org.apache.cassandra.utils.ByteBufferUtil#objectToBytes to go from Object ->
ByteBuffer, and that method didn't support ByteBuffer -> ByteBuffer; this is
the reason to update 2.2
> 3.x fails to start if commit log has range tombstones from a column which is
> also deleted
> -
>
> Key: CASSANDRA-15970
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15970
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Local Write-Read Paths, Local/Commit Log
>Reporter: David Capwell
>Assignee: David Capwell
>Priority: Normal
> Fix For: 3.0.x, 3.11.x
>
>
> Cassandra crashes with the following exception
> {code}
> ERROR [node1_isolatedExecutor:1] node1 2020-07-21 18:59:39,048
> JVMStabilityInspector.java:102 - Exiting due to error while processing commit
> log during initialization.
> org.apache.cassandra.db.commitlog.CommitLogReplayer$CommitLogReplayException:
> Unexpected error deserializing mutation; saved to
> /var/folders/cm/08cddl2s25j7fq3jdb76gh4rgn/T/mutation6239873170066752296dat.
> This may be caused by replaying a mutation against a table with the same
> name but incompatible schema.
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.handleReplayError(CommitLogReplayer.java:731)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.replayMutation(CommitLogReplayer.java:656)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.replaySyncSection(CommitLogReplayer.java:609)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.recover(CommitLogReplayer.java:493)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.recover(CommitLogReplayer.java:189)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLog.recover(CommitLog.java:170)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLog.recover(CommitLog.java:151)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.distributed.impl.Instance.lambda$startup$7(Instance.java:535)
> [dtest-3.0.21.jar:na]
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> ~[na:1.8.0_242]
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> ~[na:1.8.0_242]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> ~[na:1.8.0_242]
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> ~[na:1.8.0_242]
> at
> org.apache.cassandra.concurrent.NamedThreadFactory.lambda$threadLocalDeallocator$0(NamedThreadFactory.java:83)
> ~[dtest-3.0.21.jar:na]
> at java.lang.Thread.run(Thread.java:748) ~[na:1.8.0_242]
> Caused by: java.lang.NullPointerException: null
> at
> org.apache.cassandra.db.ClusteringComparator.validate(ClusteringComparator.java:206)
> ~[dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.partitions.PartitionUpdate.validate(PartitionUpdate.java:494)
> ~[dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.replayMutation(CommitLogReplayer.java:629)
> [dtest-3.0.21.jar:na]
> ... 12 common frames omitted
> {code}
> If you drain in 2.2 before upgrade, you get the following
> {code}
> ERROR [SharedPool-Worker-1] node1 2020-07-21 22:17:25,661
> AbstractLocalAwareExecutorService.java:169 - Uncaught exception on thread
> Thread[SharedPool-Worker-1,5,node1]
> java.lang.RuntimeException: java.lang.NullPointerException
> at
> org.apache.cassandra.service.StorageProxy$DroppableRunnable.run(StorageProxy.java:2537)
> ~[dtest-3.0.21.jar:na]
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> ~[na:1.8.0_242]
> at
>
[jira] [Commented] (CASSANDRA-15970) 3.x fails to start if commit log has range tombstones from a column which is also deleted
[
https://issues.apache.org/jira/browse/CASSANDRA-15970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166588#comment-17166588
]
Brandon Williams commented on CASSANDRA-15970:
--
.bq Marked as 3.x only since this is upgrading from 2.x.
I'm confused, why is there a 2.2 patch? Otherwise, LGTM.
> 3.x fails to start if commit log has range tombstones from a column which is
> also deleted
> -
>
> Key: CASSANDRA-15970
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15970
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Local Write-Read Paths, Local/Commit Log
>Reporter: David Capwell
>Assignee: David Capwell
>Priority: Normal
> Fix For: 3.0.x, 3.11.x
>
>
> Cassandra crashes with the following exception
> {code}
> ERROR [node1_isolatedExecutor:1] node1 2020-07-21 18:59:39,048
> JVMStabilityInspector.java:102 - Exiting due to error while processing commit
> log during initialization.
> org.apache.cassandra.db.commitlog.CommitLogReplayer$CommitLogReplayException:
> Unexpected error deserializing mutation; saved to
> /var/folders/cm/08cddl2s25j7fq3jdb76gh4rgn/T/mutation6239873170066752296dat.
> This may be caused by replaying a mutation against a table with the same
> name but incompatible schema.
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.handleReplayError(CommitLogReplayer.java:731)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.replayMutation(CommitLogReplayer.java:656)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.replaySyncSection(CommitLogReplayer.java:609)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.recover(CommitLogReplayer.java:493)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.recover(CommitLogReplayer.java:189)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLog.recover(CommitLog.java:170)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLog.recover(CommitLog.java:151)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.distributed.impl.Instance.lambda$startup$7(Instance.java:535)
> [dtest-3.0.21.jar:na]
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> ~[na:1.8.0_242]
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> ~[na:1.8.0_242]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> ~[na:1.8.0_242]
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> ~[na:1.8.0_242]
> at
> org.apache.cassandra.concurrent.NamedThreadFactory.lambda$threadLocalDeallocator$0(NamedThreadFactory.java:83)
> ~[dtest-3.0.21.jar:na]
> at java.lang.Thread.run(Thread.java:748) ~[na:1.8.0_242]
> Caused by: java.lang.NullPointerException: null
> at
> org.apache.cassandra.db.ClusteringComparator.validate(ClusteringComparator.java:206)
> ~[dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.partitions.PartitionUpdate.validate(PartitionUpdate.java:494)
> ~[dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.replayMutation(CommitLogReplayer.java:629)
> [dtest-3.0.21.jar:na]
> ... 12 common frames omitted
> {code}
> If you drain in 2.2 before upgrade, you get the following
> {code}
> ERROR [SharedPool-Worker-1] node1 2020-07-21 22:17:25,661
> AbstractLocalAwareExecutorService.java:169 - Uncaught exception on thread
> Thread[SharedPool-Worker-1,5,node1]
> java.lang.RuntimeException: java.lang.NullPointerException
> at
> org.apache.cassandra.service.StorageProxy$DroppableRunnable.run(StorageProxy.java:2537)
> ~[dtest-3.0.21.jar:na]
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> ~[na:1.8.0_242]
> at
> org.apache.cassandra.concurrent.AbstractLocalAwareExecutorService$FutureTask.run(AbstractLocalAwareExecutorService.java:165)
> ~[dtest-3.0.21.jar:na]
> at org.apache.cassandra.concurrent.SEPWorker.run(SEPWorker.java:109)
> [dtest-3.0.21.jar:na]
> at java.lang.Thread.run(Thread.java:748) [na:1.8.0_242]
> Caused by: java.lang.NullPointerException: null
> at
> org.apache.cassandra.db.ClusteringComparator.compare(ClusteringComparator.java:131)
> ~[dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.UnfilteredDeserializer$OldFormatDeserializer.compareNextTo(UnfilteredDeserializer.java:391)
> ~[dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.columniterator.SSTableIterator$ForwardReader.handlePreSliceData(SSTableIterator.java:105)
> ~[dtest-3.0.21.jar:na]
>
[jira] [Comment Edited] (CASSANDRA-15970) 3.x fails to start if commit log has range tombstones from a column which is also deleted
[
https://issues.apache.org/jira/browse/CASSANDRA-15970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166588#comment-17166588
]
Brandon Williams edited comment on CASSANDRA-15970 at 7/28/20, 5:43 PM:
bq. Marked as 3.x only since this is upgrading from 2.x.
I'm confused, why is there a 2.2 patch? Otherwise, LGTM.
was (Author: brandon.williams):
.bq Marked as 3.x only since this is upgrading from 2.x.
I'm confused, why is there a 2.2 patch? Otherwise, LGTM.
> 3.x fails to start if commit log has range tombstones from a column which is
> also deleted
> -
>
> Key: CASSANDRA-15970
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15970
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Local Write-Read Paths, Local/Commit Log
>Reporter: David Capwell
>Assignee: David Capwell
>Priority: Normal
> Fix For: 3.0.x, 3.11.x
>
>
> Cassandra crashes with the following exception
> {code}
> ERROR [node1_isolatedExecutor:1] node1 2020-07-21 18:59:39,048
> JVMStabilityInspector.java:102 - Exiting due to error while processing commit
> log during initialization.
> org.apache.cassandra.db.commitlog.CommitLogReplayer$CommitLogReplayException:
> Unexpected error deserializing mutation; saved to
> /var/folders/cm/08cddl2s25j7fq3jdb76gh4rgn/T/mutation6239873170066752296dat.
> This may be caused by replaying a mutation against a table with the same
> name but incompatible schema.
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.handleReplayError(CommitLogReplayer.java:731)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.replayMutation(CommitLogReplayer.java:656)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.replaySyncSection(CommitLogReplayer.java:609)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.recover(CommitLogReplayer.java:493)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.recover(CommitLogReplayer.java:189)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLog.recover(CommitLog.java:170)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLog.recover(CommitLog.java:151)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.distributed.impl.Instance.lambda$startup$7(Instance.java:535)
> [dtest-3.0.21.jar:na]
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> ~[na:1.8.0_242]
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> ~[na:1.8.0_242]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> ~[na:1.8.0_242]
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> ~[na:1.8.0_242]
> at
> org.apache.cassandra.concurrent.NamedThreadFactory.lambda$threadLocalDeallocator$0(NamedThreadFactory.java:83)
> ~[dtest-3.0.21.jar:na]
> at java.lang.Thread.run(Thread.java:748) ~[na:1.8.0_242]
> Caused by: java.lang.NullPointerException: null
> at
> org.apache.cassandra.db.ClusteringComparator.validate(ClusteringComparator.java:206)
> ~[dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.partitions.PartitionUpdate.validate(PartitionUpdate.java:494)
> ~[dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.replayMutation(CommitLogReplayer.java:629)
> [dtest-3.0.21.jar:na]
> ... 12 common frames omitted
> {code}
> If you drain in 2.2 before upgrade, you get the following
> {code}
> ERROR [SharedPool-Worker-1] node1 2020-07-21 22:17:25,661
> AbstractLocalAwareExecutorService.java:169 - Uncaught exception on thread
> Thread[SharedPool-Worker-1,5,node1]
> java.lang.RuntimeException: java.lang.NullPointerException
> at
> org.apache.cassandra.service.StorageProxy$DroppableRunnable.run(StorageProxy.java:2537)
> ~[dtest-3.0.21.jar:na]
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> ~[na:1.8.0_242]
> at
> org.apache.cassandra.concurrent.AbstractLocalAwareExecutorService$FutureTask.run(AbstractLocalAwareExecutorService.java:165)
> ~[dtest-3.0.21.jar:na]
> at org.apache.cassandra.concurrent.SEPWorker.run(SEPWorker.java:109)
> [dtest-3.0.21.jar:na]
> at java.lang.Thread.run(Thread.java:748) [na:1.8.0_242]
> Caused by: java.lang.NullPointerException: null
> at
> org.apache.cassandra.db.ClusteringComparator.compare(ClusteringComparator.java:131)
> ~[dtest-3.0.21.jar:na]
> at
>
[jira] [Updated] (CASSANDRA-15970) 3.x fails to start if commit log has range tombstones from a column which is also deleted
[
https://issues.apache.org/jira/browse/CASSANDRA-15970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Capwell updated CASSANDRA-15970:
--
Description:
Cassandra crashes with the following exception
{code}
ERROR [node1_isolatedExecutor:1] node1 2020-07-21 18:59:39,048
JVMStabilityInspector.java:102 - Exiting due to error while processing commit
log during initialization.
org.apache.cassandra.db.commitlog.CommitLogReplayer$CommitLogReplayException:
Unexpected error deserializing mutation; saved to
/var/folders/cm/08cddl2s25j7fq3jdb76gh4rgn/T/mutation6239873170066752296dat.
This may be caused by replaying a mutation against a table with the same name
but incompatible schema.
at
org.apache.cassandra.db.commitlog.CommitLogReplayer.handleReplayError(CommitLogReplayer.java:731)
[dtest-3.0.21.jar:na]
at
org.apache.cassandra.db.commitlog.CommitLogReplayer.replayMutation(CommitLogReplayer.java:656)
[dtest-3.0.21.jar:na]
at
org.apache.cassandra.db.commitlog.CommitLogReplayer.replaySyncSection(CommitLogReplayer.java:609)
[dtest-3.0.21.jar:na]
at
org.apache.cassandra.db.commitlog.CommitLogReplayer.recover(CommitLogReplayer.java:493)
[dtest-3.0.21.jar:na]
at
org.apache.cassandra.db.commitlog.CommitLogReplayer.recover(CommitLogReplayer.java:189)
[dtest-3.0.21.jar:na]
at
org.apache.cassandra.db.commitlog.CommitLog.recover(CommitLog.java:170)
[dtest-3.0.21.jar:na]
at
org.apache.cassandra.db.commitlog.CommitLog.recover(CommitLog.java:151)
[dtest-3.0.21.jar:na]
at
org.apache.cassandra.distributed.impl.Instance.lambda$startup$7(Instance.java:535)
[dtest-3.0.21.jar:na]
at
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
~[na:1.8.0_242]
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
~[na:1.8.0_242]
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
~[na:1.8.0_242]
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
~[na:1.8.0_242]
at
org.apache.cassandra.concurrent.NamedThreadFactory.lambda$threadLocalDeallocator$0(NamedThreadFactory.java:83)
~[dtest-3.0.21.jar:na]
at java.lang.Thread.run(Thread.java:748) ~[na:1.8.0_242]
Caused by: java.lang.NullPointerException: null
at
org.apache.cassandra.db.ClusteringComparator.validate(ClusteringComparator.java:206)
~[dtest-3.0.21.jar:na]
at
org.apache.cassandra.db.partitions.PartitionUpdate.validate(PartitionUpdate.java:494)
~[dtest-3.0.21.jar:na]
at
org.apache.cassandra.db.commitlog.CommitLogReplayer.replayMutation(CommitLogReplayer.java:629)
[dtest-3.0.21.jar:na]
... 12 common frames omitted
{code}
If you drain in 2.2 before upgrade, you get the following
{code}
ERROR [SharedPool-Worker-1] node1 2020-07-21 22:17:25,661
AbstractLocalAwareExecutorService.java:169 - Uncaught exception on thread
Thread[SharedPool-Worker-1,5,node1]
java.lang.RuntimeException: java.lang.NullPointerException
at
org.apache.cassandra.service.StorageProxy$DroppableRunnable.run(StorageProxy.java:2537)
~[dtest-3.0.21.jar:na]
at
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
~[na:1.8.0_242]
at
org.apache.cassandra.concurrent.AbstractLocalAwareExecutorService$FutureTask.run(AbstractLocalAwareExecutorService.java:165)
~[dtest-3.0.21.jar:na]
at org.apache.cassandra.concurrent.SEPWorker.run(SEPWorker.java:109)
[dtest-3.0.21.jar:na]
at java.lang.Thread.run(Thread.java:748) [na:1.8.0_242]
Caused by: java.lang.NullPointerException: null
at
org.apache.cassandra.db.ClusteringComparator.compare(ClusteringComparator.java:131)
~[dtest-3.0.21.jar:na]
at
org.apache.cassandra.db.UnfilteredDeserializer$OldFormatDeserializer.compareNextTo(UnfilteredDeserializer.java:391)
~[dtest-3.0.21.jar:na]
at
org.apache.cassandra.db.columniterator.SSTableIterator$ForwardReader.handlePreSliceData(SSTableIterator.java:105)
~[dtest-3.0.21.jar:na]
at
org.apache.cassandra.db.columniterator.SSTableIterator$ForwardReader.hasNextInternal(SSTableIterator.java:164)
~[dtest-3.0.21.jar:na]
at
org.apache.cassandra.db.columniterator.AbstractSSTableIterator$Reader.hasNext(AbstractSSTableIterator.java:336)
~[dtest-3.0.21.jar:na]
at
org.apache.cassandra.db.filter.ClusteringIndexNamesFilter$1.hasNext(ClusteringIndexNamesFilter.java:157)
~[dtest-3.0.21.jar:na]
at
org.apache.cassandra.db.rows.UnfilteredRowIterator.isEmpty(UnfilteredRowIterator.java:70)
~[dtest-3.0.21.jar:na]
at
org.apache.cassandra.db.SinglePartitionReadCommand.queryMemtableAndSSTablesInTimestampOrder(SinglePartitionReadCommand.java:952)
~[dtest-3.0.21.jar:na]
at
org.apache.cassandra.db.SinglePartitionReadCommand.queryMemtableAndDiskInternal(SinglePartitionReadCommand.java:679)
[jira] [Commented] (CASSANDRA-15970) 3.x fails to start if commit log has range tombstones from a column which is also deleted
[
https://issues.apache.org/jira/browse/CASSANDRA-15970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166585#comment-17166585
]
David Capwell commented on CASSANDRA-15970:
---
CI Links
2.2:
https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=bug%2FCASSANDRA-15970-2.2
3.0:
https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=bug%2FCASSANDRA-15970-3.0
3.11:
https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=bug%2FCASSANDRA-15970-3.11
trunk:
https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=bug%2FCASSANDRA-15970
> 3.x fails to start if commit log has range tombstones from a column which is
> also deleted
> -
>
> Key: CASSANDRA-15970
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15970
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Local Write-Read Paths, Local/Commit Log
>Reporter: David Capwell
>Assignee: David Capwell
>Priority: Normal
> Fix For: 3.0.x, 3.11.x
>
>
> Cassandra crashes with the following exception
> {code}
> ERROR [node1_isolatedExecutor:1] node1 2020-07-21 18:59:39,048
> JVMStabilityInspector.java:102 - Exiting due to error while processing commit
> log during initialization.
> org.apache.cassandra.db.commitlog.CommitLogReplayer$CommitLogReplayException:
> Unexpected error deserializing mutation; saved to
> /var/folders/cm/08cddl2s25j7fq3jdb76gh4rgn/T/mutation6239873170066752296dat.
> This may be caused by replaying a mutation against a table with the same
> name but incompatible schema.
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.handleReplayError(CommitLogReplayer.java:731)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.replayMutation(CommitLogReplayer.java:656)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.replaySyncSection(CommitLogReplayer.java:609)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.recover(CommitLogReplayer.java:493)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.recover(CommitLogReplayer.java:189)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLog.recover(CommitLog.java:170)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLog.recover(CommitLog.java:151)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.distributed.impl.Instance.lambda$startup$7(Instance.java:535)
> [dtest-3.0.21.jar:na]
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> ~[na:1.8.0_242]
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> ~[na:1.8.0_242]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> ~[na:1.8.0_242]
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> ~[na:1.8.0_242]
> at
> org.apache.cassandra.concurrent.NamedThreadFactory.lambda$threadLocalDeallocator$0(NamedThreadFactory.java:83)
> ~[dtest-3.0.21.jar:na]
> at java.lang.Thread.run(Thread.java:748) ~[na:1.8.0_242]
> Caused by: java.lang.NullPointerException: null
> at
> org.apache.cassandra.db.ClusteringComparator.validate(ClusteringComparator.java:206)
> ~[dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.partitions.PartitionUpdate.validate(PartitionUpdate.java:494)
> ~[dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.replayMutation(CommitLogReplayer.java:629)
> [dtest-3.0.21.jar:na]
> ... 12 common frames omitted
> {code}
> If you drain in 2.2 before upgrade, you get the following
> {code}
> ERROR [SharedPool-Worker-1] node1 2020-07-21 22:17:25,661
> AbstractLocalAwareExecutorService.java:169 - Uncaught exception on thread
> Thread[SharedPool-Worker-1,5,node1]
> java.lang.RuntimeException: java.lang.NullPointerException
> at
> org.apache.cassandra.service.StorageProxy$DroppableRunnable.run(StorageProxy.java:2537)
> ~[dtest-3.0.21.jar:na]
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> ~[na:1.8.0_242]
> at
> org.apache.cassandra.concurrent.AbstractLocalAwareExecutorService$FutureTask.run(AbstractLocalAwareExecutorService.java:165)
> ~[dtest-3.0.21.jar:na]
> at org.apache.cassandra.concurrent.SEPWorker.run(SEPWorker.java:109)
> [dtest-3.0.21.jar:na]
> at java.lang.Thread.run(Thread.java:748) [na:1.8.0_242]
> Caused by: java.lang.NullPointerException: null
> at
> org.apache.cassandra.db.ClusteringComparator.compare(ClusteringComparator.java:131)
> ~[dtest-3.0.21.jar:na]
> at
>
[jira] [Updated] (CASSANDRA-15970) 3.x fails to start if commit log has range tombstones from a column which is also deleted
[
https://issues.apache.org/jira/browse/CASSANDRA-15970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Capwell updated CASSANDRA-15970:
--
Test and Documentation Plan: upgrade dtest
Status: Patch Available (was: Open)
> 3.x fails to start if commit log has range tombstones from a column which is
> also deleted
> -
>
> Key: CASSANDRA-15970
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15970
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Local Write-Read Paths, Local/Commit Log
>Reporter: David Capwell
>Assignee: David Capwell
>Priority: Normal
> Fix For: 3.0.x, 3.11.x
>
>
> Cassandra crashes with the following exception
> {code}
> ERROR [node1_isolatedExecutor:1] node1 2020-07-21 18:59:39,048
> JVMStabilityInspector.java:102 - Exiting due to error while processing commit
> log during initialization.
> org.apache.cassandra.db.commitlog.CommitLogReplayer$CommitLogReplayException:
> Unexpected error deserializing mutation; saved to
> /var/folders/cm/08cddl2s25j7fq3jdb76gh4rgn/T/mutation6239873170066752296dat.
> This may be caused by replaying a mutation against a table with the same
> name but incompatible schema.
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.handleReplayError(CommitLogReplayer.java:731)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.replayMutation(CommitLogReplayer.java:656)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.replaySyncSection(CommitLogReplayer.java:609)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.recover(CommitLogReplayer.java:493)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.recover(CommitLogReplayer.java:189)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLog.recover(CommitLog.java:170)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLog.recover(CommitLog.java:151)
> [dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.distributed.impl.Instance.lambda$startup$7(Instance.java:535)
> [dtest-3.0.21.jar:na]
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> ~[na:1.8.0_242]
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> ~[na:1.8.0_242]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> ~[na:1.8.0_242]
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> ~[na:1.8.0_242]
> at
> org.apache.cassandra.concurrent.NamedThreadFactory.lambda$threadLocalDeallocator$0(NamedThreadFactory.java:83)
> ~[dtest-3.0.21.jar:na]
> at java.lang.Thread.run(Thread.java:748) ~[na:1.8.0_242]
> Caused by: java.lang.NullPointerException: null
> at
> org.apache.cassandra.db.ClusteringComparator.validate(ClusteringComparator.java:206)
> ~[dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.partitions.PartitionUpdate.validate(PartitionUpdate.java:494)
> ~[dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.commitlog.CommitLogReplayer.replayMutation(CommitLogReplayer.java:629)
> [dtest-3.0.21.jar:na]
> ... 12 common frames omitted
> {code}
> If you drain in 2.2 before upgrade, you get the following
> {code}
> ERROR [SharedPool-Worker-1] node1 2020-07-21 22:17:25,661
> AbstractLocalAwareExecutorService.java:169 - Uncaught exception on thread
> Thread[SharedPool-Worker-1,5,node1]
> java.lang.RuntimeException: java.lang.NullPointerException
> at
> org.apache.cassandra.service.StorageProxy$DroppableRunnable.run(StorageProxy.java:2537)
> ~[dtest-3.0.21.jar:na]
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> ~[na:1.8.0_242]
> at
> org.apache.cassandra.concurrent.AbstractLocalAwareExecutorService$FutureTask.run(AbstractLocalAwareExecutorService.java:165)
> ~[dtest-3.0.21.jar:na]
> at org.apache.cassandra.concurrent.SEPWorker.run(SEPWorker.java:109)
> [dtest-3.0.21.jar:na]
> at java.lang.Thread.run(Thread.java:748) [na:1.8.0_242]
> Caused by: java.lang.NullPointerException: null
> at
> org.apache.cassandra.db.ClusteringComparator.compare(ClusteringComparator.java:131)
> ~[dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.UnfilteredDeserializer$OldFormatDeserializer.compareNextTo(UnfilteredDeserializer.java:391)
> ~[dtest-3.0.21.jar:na]
> at
> org.apache.cassandra.db.columniterator.SSTableIterator$ForwardReader.handlePreSliceData(SSTableIterator.java:105)
> ~[dtest-3.0.21.jar:na]
> at
>
[jira] [Comment Edited] (CASSANDRA-15937) JMX output inconsistencies from CASSANDRA-7544 storage-port-configurable-per-node
[
https://issues.apache.org/jira/browse/CASSANDRA-15937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164587#comment-17164587
]
Jon Meredith edited comment on CASSANDRA-15937 at 7/28/20, 5:04 PM:
Here's the before & after with the patch.
{code:java}
current trunk current w/port
patched patched w/port
AllEndpointStates/127.0.0.3\n... 127.0.0.1:7000\n
/127.0.0.1 /127.0.0.3:7000
SimpleStates /127.0.0.1=UP 127.0.0.1:7000=UP
/127.0.0.1=UP /127.0.0.2:7000=UP
LargeMessagePendingTasks /127.0.0.1=0 127.0.0.1:7000=0
/127.0.0.1=0/127.0.0.1:7000=0
TimeoutsPerHost /127.0.0.1=0 127.0.0.1:7000=0
/127.0.0.1=0/127.0.0.1:7000=0
SchemaVersions {...=[127.0.0.1,...]} {...=[127.0.0.1:7000,...]
{...=[127.0.0.1,...]} {...=[127.0.0.1:7000,...]}
TokenToEndpointMap -92...8=127.0.0.1 -92..8=127.0.0.1:7000
-92..08=127.0.0.1 -92..08=127.0.0.1:7000
EndpointToHostId127.0.0.1=e06...7e 127.0.0.1:7000=e0..7e
127.0.0.1=e04..5127.0.0.1:7000=e0..b5
HostIdToEndpointe06..7e=127.0.0.1 e06..7e=127.0.0.1:7000
e0..b5=127.0.0.1e0..b5=127.0.0.1:7000
LoadMap 127.0.0.1:7000=106.08 KiB 127.0.0.1=106.08 KiB
127.0.0.1=106.12 KiB127.0.0.1:7000=106.12 KiB
LiveNodes 127.0.0.1 127.0.0.1:7000
127.0.0.1 127.0.0.1:7000
Ownership /127.0.0.1=0.0 127.0.0.1:7000=0.0
/127.0.0.1=0.33 /127.0.0.1:7000=0.33
{code}
I checked the name resolution also works by adding some additional aliases to
/etc/hosts
{code:java}
127.0.0.1 localhost local0-i1
255.255.255.255 broadcasthost
::1 localhost
127.0.0.2 local0-i2
127.0.0.3 local0-i3
{code}
Which gives
{code:java}
"SimpleStates": "{local0-i3/127.0.0.3=UP, localhost/127.0.0.1=UP,
local0-i2/127.0.0.2=UP}",
"SimpleStatesWithPort": "{localhost/127.0.0.1:7000=UP,
local0-i2/127.0.0.2:7000=UP, local0-i3/127.0.0.3:7000=UP}",
{code}
If a reviewer is feeling adventurous and wants to test with IPv6, you can
create a cluster with
{code:java}
# macOS aliases, YMMV
sudo ifconfig lo0 inet6 alias 0:0:0:0:0:0:0:1
sudo ifconfig lo0 inet6 alias 0:0:0:0:0:0:0:2
sudo ifconfig lo0 inet6 alias 0:0:0:0:0:0:0:3
ccm create -n3 --install-dir=. --ip-format="::%d" c15937ipv6
{code}
was (Author: jmeredithco):
Here's the before & after with the patch.
{code}
current trunk current w/port
patched patched w/port
AllEndpointStates/127.0.0.3\n... 127.0.0.1:7000\n
/127.0.0.1 /127.0.0.3:7000
SimpleStates /127.0.0.1=UP 127.0.0.1:7000=UP
/127.0.0.1=UP /127.0.0.2:7000=UP
LargeMessagePendingTasks /127.0.0.1=0 127.0.0.1:7000=0
/127.0.0.1=0127.0.0.1:7000=0
TimeoutsPerHost /127.0.0.1=0 127.0.0.1:7000=0
/127.0.0.1=0/127.0.0.1:7000=0
SchemaVersions {...=[127.0.0.1,...]} {...=[127.0.0.1:7000,...]
{...=[127.0.0.1,...]} {...=[127.0.0.1:7000,...]}
TokenToEndpointMap -92...8=127.0.0.1 -92..8=127.0.0.1:7000
-92..08=127.0.0.1 -92..08=127.0.0.1:7000
EndpointToHostId127.0.0.1=e06...7e 127.0.0.1:7000=e0..7e
127.0.0.1=e04..5127.0.0.1:7000=e0..b5
HostIdToEndpointe06..7e=127.0.0.1 e06..7e=127.0.0.1:7000
e0..b5=127.0.0.1e0..b5=127.0.0.1:7000
LoadMap 127.0.0.1:7000=106.08 KiB 127.0.0.1=106.08 KiB
127.0.0.1=106.12 KiB127.0.0.1:7000=106.12 KiB
LiveNodes 127.0.0.1 127.0.0.1:7000
127.0.0.1 127.0.0.1:7000
Ownership /127.0.0.1=0.0 127.0.0.1:7000=0.0
/127.0.0.1=0.33 /127.0.0.1:7000=0.33
{code}
I checked the name resolution also works by adding some additional aliases to
/etc/hosts
{code}
127.0.0.1 localhost local0-i1
255.255.255.255 broadcasthost
::1 localhost
127.0.0.2 local0-i2
127.0.0.3 local0-i3
{code}
Which gives
{code}
"SimpleStates": "{local0-i3/127.0.0.3=UP, localhost/127.0.0.1=UP,
local0-i2/127.0.0.2=UP}",
"SimpleStatesWithPort": "{localhost/127.0.0.1:7000=UP,
local0-i2/127.0.0.2:7000=UP, local0-i3/127.0.0.3:7000=UP}",
{code}
If a reviewer is feeling adventurous and wants to test with IPv6, you can
create a
[jira] [Commented] (CASSANDRA-15968) nodetool drain fails in jvm dtest
[
https://issues.apache.org/jira/browse/CASSANDRA-15968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166528#comment-17166528
]
David Capwell commented on CASSANDRA-15968:
---
thanks for the review, ill work to address those comments.
bq. why did you put the registerDaemon call between the todo comment and the
has(GOSSIP) clause?
https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/service/CassandraDaemon.java#L370-L375
Mostly trying to keep the logic in the same order as CassandraDaemon.
bq. It seems cheap enough to register, not sure why it wasn't before.
One of the bad parts of the Instance setup, we need to replicate 100% of
cassandra daemon startup, but we don't use it directly... so some things like
this get missed.
> nodetool drain fails in jvm dtest
> -
>
> Key: CASSANDRA-15968
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15968
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest
>Reporter: David Capwell
>Assignee: David Capwell
>Priority: Normal
> Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0-beta
>
>
> Drain fails since MessagingService doesn’t expect to be shutdown twice.
> {code}
> Caused by: java.lang.AssertionError
> at
> org.apache.cassandra.net.MessagingService.shutdown(MessagingService.java:766)
> at
> org.apache.cassandra.distributed.impl.Instance.lambda$parallelRun$28(Instance.java:805)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> ... 3 more
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15975) SEP.shutdownAndWait does not wait for termination and SEPExecutor.awaitTermination may hang
[ https://issues.apache.org/jira/browse/CASSANDRA-15975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benedict Elliott Smith updated CASSANDRA-15975: --- Reviewers: Benedict Elliott Smith, Benedict Elliott Smith (was: Benedict Elliott Smith) Benedict Elliott Smith, Benedict Elliott Smith Status: Review In Progress (was: Patch Available) > SEP.shutdownAndWait does not wait for termination and > SEPExecutor.awaitTermination may hang > --- > > Key: CASSANDRA-15975 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15975 > Project: Cassandra > Issue Type: Bug > Components: Local/Other >Reporter: Jon Meredith >Assignee: Jon Meredith >Priority: Normal > > SharedExecutorPool.shutdownAndWait calls shutdownNow on the executors it > owns, which has the side effect of removing the executor from the list, then > uses the same emptied list to try and wait for them to complete shutting > down, which completes immediately. > > Once fixed by copying the list in SEP.shutdownAndWait, the SEPExecutorTest > suite fails with a timeout due to a startup race in SEPWorker. > > If a SEPExecutor is shutdown immediately after maybeSchedule creates a new > SEPWorker, > but before it is able to execute the first task then it exits immediately on > entering the work loop with a work and task permit reserved for it, which > invalidates the work/task permit accounting and prevents calling the shutdown > SimpleCondition.signalAll when the last SEPWorker exits. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15968) nodetool drain fails in jvm dtest
[
https://issues.apache.org/jira/browse/CASSANDRA-15968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166473#comment-17166473
]
Jon Meredith commented on CASSANDRA-15968:
--
Thanks for the patch. I did a quick first pass, not sure whether to leave
comments here or against the individual commits. Generally it looks good, just
a few nits and I'll do a second pass to look over the changes to shutdown.
HintsService:
Could you log on duplicate shutdown attempts (just an info) like
MessagingService - "Hints service already shutting down, ignoring."
Instance.java: Nit: In Instance.java, why did you put the registerDaemon call
between the todo comment and the has(GOSSIP) clause? It seems cheap enough to
register, not sure why it wasn't before.
Gossiper.java: Can you correct the log message on repeat shutdown to indicate
Gossiper.
Nit: If MessagingService can be restarted, wasShutdown could be renamed
isShutdown as that implies state rather than history.
> nodetool drain fails in jvm dtest
> -
>
> Key: CASSANDRA-15968
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15968
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest
>Reporter: David Capwell
>Assignee: David Capwell
>Priority: Normal
> Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0-beta
>
>
> Drain fails since MessagingService doesn’t expect to be shutdown twice.
> {code}
> Caused by: java.lang.AssertionError
> at
> org.apache.cassandra.net.MessagingService.shutdown(MessagingService.java:766)
> at
> org.apache.cassandra.distributed.impl.Instance.lambda$parallelRun$28(Instance.java:805)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> ... 3 more
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15968) nodetool drain fails in jvm dtest
[
https://issues.apache.org/jira/browse/CASSANDRA-15968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jon Meredith updated CASSANDRA-15968:
-
Reviewers: Jon Meredith, Jon Meredith (was: Jon Meredith)
Jon Meredith, Jon Meredith
Status: Review In Progress (was: Patch Available)
> nodetool drain fails in jvm dtest
> -
>
> Key: CASSANDRA-15968
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15968
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest
>Reporter: David Capwell
>Assignee: David Capwell
>Priority: Normal
> Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0-beta
>
>
> Drain fails since MessagingService doesn’t expect to be shutdown twice.
> {code}
> Caused by: java.lang.AssertionError
> at
> org.apache.cassandra.net.MessagingService.shutdown(MessagingService.java:766)
> at
> org.apache.cassandra.distributed.impl.Instance.lambda$parallelRun$28(Instance.java:805)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> ... 3 more
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15583) 4.0 quality testing: Tooling, Bundled and First Party
[ https://issues.apache.org/jira/browse/CASSANDRA-15583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Berenguer Blasi updated CASSANDRA-15583: Description: Reference [doc from NGCC|https://docs.google.com/document/d/1uhUOp7wpE9ZXNDgxoCZHejHt5SO4Qw1dArZqqsJccyQ/edit#] for context. *Shepherd: Sam Tunnicliffe* Test plans should cover bundled first-party tooling and CLIs such as nodetool, cqlsh, and new tools supporting full query and audit logging (CASSANDRA-13983, CASSANDRA-12151). ||Tool||UX test||UT coverage||dtest coverage||Comments|| |Nodetool|(x)|(x)|(!)|By no means all the sub commands are tested. Dtest also test nodetool as a side effect| |Cqlsh|(x)|(x)|(!)| | |Cassandra-stress|(x)|(x)|(x)| Some UT| |debug-cql|(x)|(x)|(x)| | |fqltool|(x)|(/)|(!)| | |auditlogviewer|(x)|(!)|(!)| | |*Sstable utilities*| | | | | |sstabledump|(x)|(x)|(!)| | |sstableexpiredblockers|(x)|(x)|(!)| | |sstablelevelreset|(x)|(x)|(!)| | |sstableloader|(x)|(x)|(!)| | |sstablemetadata|(x)|(x)|(x)|Ran in dtests, no dedicated test| |sstableofflinerelevel|(x)|(x)|(!)| | |sstablerepairedset|(x)|(x)|(x)|Ran in dtests, no dedicated test| |sstablescrub|(/)|(x)|(!)|UX fix: C-15991 but missing options in docs| |sstablesplit|(/)|(x)|(!)|UX fix: C-15991| |sstableupgrade|(/)|(x)|(!)|UX fix: C-15991| |sstableutil|(/)|(x)|(!)|UX fix: C-15991| |sstableverify|(/)|(x)|(!)|UX fix: C-15991 but missing options in docs + broken token_range option| was: Reference [doc from NGCC|https://docs.google.com/document/d/1uhUOp7wpE9ZXNDgxoCZHejHt5SO4Qw1dArZqqsJccyQ/edit#] for context. *Shepherd: Sam Tunnicliffe* Test plans should cover bundled first-party tooling and CLIs such as nodetool, cqlsh, and new tools supporting full query and audit logging (CASSANDRA-13983, CASSANDRA-12151). ||Tool||UX test||UT coverage||dtest coverage||Comments|| |Nodetool|(x)|(x)|(!)|By no means all the sub commands are tested. Dtest also test nodetool as a side effect| |Cqlsh|(x)|(x)|(!)| | |Cassandra-stress|(x)|(x)|(x)| Some UT| |debug-cql|(x)|(x)|(x)| | |fqltool|(x)|(/)|(!)| | |auditlogviewer|(x)|(!)|(!)| | |*Sstable utilities*| | | | | |sstabledump|(x)|(x)|(!)| | |sstableexpiredblockers|(x)|(x)|(!)| | |sstablelevelreset|(x)|(x)|(!)| | |sstableloader|(x)|(x)|(!)| | |sstablemetadata|(x)|(x)|(x)|Ran in dtests, no dedicated test| |sstableofflinerelevel|(x)|(x)|(!)| | |sstablerepairedset|(x)|(x)|(x)|Ran in dtests, no dedicated test| |sstablescrub|(x)|(x)|(!)| | |sstablesplit|(x)|(x)|(!)| | |sstableupgrade|(x)|(x)|(!)| | |sstableutil|(/)|(x)|(!)|UX fix: C-15991| |sstableverify|(/)|(x)|(!)|UX fix: C-15991 but missing options in docs + broken token_range option| > 4.0 quality testing: Tooling, Bundled and First Party > - > > Key: CASSANDRA-15583 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15583 > Project: Cassandra > Issue Type: Task > Components: Test/dtest, Test/unit >Reporter: Josh McKenzie >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 4.0-beta > > > Reference [doc from > NGCC|https://docs.google.com/document/d/1uhUOp7wpE9ZXNDgxoCZHejHt5SO4Qw1dArZqqsJccyQ/edit#] > for context. > *Shepherd: Sam Tunnicliffe* > Test plans should cover bundled first-party tooling and CLIs such as > nodetool, cqlsh, and new tools supporting full query and audit logging > (CASSANDRA-13983, CASSANDRA-12151). > ||Tool||UX test||UT coverage||dtest coverage||Comments|| > |Nodetool|(x)|(x)|(!)|By no means all the sub commands are tested. Dtest also > test nodetool as a side effect| > |Cqlsh|(x)|(x)|(!)| | > |Cassandra-stress|(x)|(x)|(x)| Some UT| > |debug-cql|(x)|(x)|(x)| | > |fqltool|(x)|(/)|(!)| | > |auditlogviewer|(x)|(!)|(!)| | > |*Sstable utilities*| | | | | > |sstabledump|(x)|(x)|(!)| | > |sstableexpiredblockers|(x)|(x)|(!)| | > |sstablelevelreset|(x)|(x)|(!)| | > |sstableloader|(x)|(x)|(!)| | > |sstablemetadata|(x)|(x)|(x)|Ran in dtests, no dedicated test| > |sstableofflinerelevel|(x)|(x)|(!)| | > |sstablerepairedset|(x)|(x)|(x)|Ran in dtests, no dedicated test| > |sstablescrub|(/)|(x)|(!)|UX fix: C-15991 but missing options in docs| > |sstablesplit|(/)|(x)|(!)|UX fix: C-15991| > |sstableupgrade|(/)|(x)|(!)|UX fix: C-15991| > |sstableutil|(/)|(x)|(!)|UX fix: C-15991| > |sstableverify|(/)|(x)|(!)|UX fix: C-15991 but missing options in docs + > broken token_range option| -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15583) 4.0 quality testing: Tooling, Bundled and First Party
[ https://issues.apache.org/jira/browse/CASSANDRA-15583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Berenguer Blasi updated CASSANDRA-15583: Description: Reference [doc from NGCC|https://docs.google.com/document/d/1uhUOp7wpE9ZXNDgxoCZHejHt5SO4Qw1dArZqqsJccyQ/edit#] for context. *Shepherd: Sam Tunnicliffe* Test plans should cover bundled first-party tooling and CLIs such as nodetool, cqlsh, and new tools supporting full query and audit logging (CASSANDRA-13983, CASSANDRA-12151). ||Tool||UX test||UT coverage||dtest coverage||Comments|| |Nodetool|(x)|(x)|(!)|By no means all the sub commands are tested. Dtest also test nodetool as a side effect| |Cqlsh|(x)|(x)|(!)| | |Cassandra-stress|(x)|(x)|(x)| Some UT| |debug-cql|(x)|(x)|(x)| | |fqltool|(x)|(/)|(!)| | |auditlogviewer|(x)|(!)|(!)| | |*Sstable utilities*| | | | | |sstabledump|(x)|(x)|(!)| | |sstableexpiredblockers|(x)|(x)|(!)| | |sstablelevelreset|(x)|(x)|(!)| | |sstableloader|(x)|(x)|(!)| | |sstablemetadata|(x)|(x)|(x)|Ran in dtests, no dedicated test| |sstableofflinerelevel|(x)|(x)|(!)| | |sstablerepairedset|(x)|(x)|(x)|Ran in dtests, no dedicated test| |sstablescrub|(x)|(x)|(!)| | |sstablesplit|(x)|(x)|(!)| | |sstableupgrade|(x)|(x)|(!)| | |sstableutil|(/)|(x)|(!)|UX fix: C-15991| |sstableverify|(/)|(x)|(!)|UX fix: C-15991 but missing options in docs + broken token_range option| was: Reference [doc from NGCC|https://docs.google.com/document/d/1uhUOp7wpE9ZXNDgxoCZHejHt5SO4Qw1dArZqqsJccyQ/edit#] for context. *Shepherd: Sam Tunnicliffe* Test plans should cover bundled first-party tooling and CLIs such as nodetool, cqlsh, and new tools supporting full query and audit logging (CASSANDRA-13983, CASSANDRA-12151). ||Tool||UX test||UT coverage||dtest coverage||Comments|| |Nodetool|(x)|(x)|(!)|By no means all the sub commands are tested. Dtest also test nodetool as a side effect| |Cqlsh|(x)|(x)|(!)| | |Cassandra-stress|(x)|(x)|(x)| Some UT| |debug-cql|(x)|(x)|(x)| | |fqltool|(x)|(/)|(!)| | |auditlogviewer|(x)|(!)|(!)| | |*Sstable utilities*| | | | | |sstabledump|(x)|(x)|(!)| | |sstableexpiredblockers|(x)|(x)|(!)| | |sstablelevelreset|(x)|(x)|(!)| | |sstableloader|(x)|(x)|(!)| | |sstablemetadata|(x)|(x)|(x)|Ran in dtests, no dedicated test| |sstableofflinerelevel|(x)|(x)|(!)| | |sstablerepairedset|(x)|(x)|(x)|Ran in dtests, no dedicated test| |sstablescrub|(x)|(x)|(!)| | |sstablesplit|(x)|(x)|(!)| | |sstableupgrade|(x)|(x)|(!)| | |sstableutil|(x)|(x)|(!)| | |sstableverify|(x)|(x)|(!)| | > 4.0 quality testing: Tooling, Bundled and First Party > - > > Key: CASSANDRA-15583 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15583 > Project: Cassandra > Issue Type: Task > Components: Test/dtest, Test/unit >Reporter: Josh McKenzie >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 4.0-beta > > > Reference [doc from > NGCC|https://docs.google.com/document/d/1uhUOp7wpE9ZXNDgxoCZHejHt5SO4Qw1dArZqqsJccyQ/edit#] > for context. > *Shepherd: Sam Tunnicliffe* > Test plans should cover bundled first-party tooling and CLIs such as > nodetool, cqlsh, and new tools supporting full query and audit logging > (CASSANDRA-13983, CASSANDRA-12151). > ||Tool||UX test||UT coverage||dtest coverage||Comments|| > |Nodetool|(x)|(x)|(!)|By no means all the sub commands are tested. Dtest also > test nodetool as a side effect| > |Cqlsh|(x)|(x)|(!)| | > |Cassandra-stress|(x)|(x)|(x)| Some UT| > |debug-cql|(x)|(x)|(x)| | > |fqltool|(x)|(/)|(!)| | > |auditlogviewer|(x)|(!)|(!)| | > |*Sstable utilities*| | | | | > |sstabledump|(x)|(x)|(!)| | > |sstableexpiredblockers|(x)|(x)|(!)| | > |sstablelevelreset|(x)|(x)|(!)| | > |sstableloader|(x)|(x)|(!)| | > |sstablemetadata|(x)|(x)|(x)|Ran in dtests, no dedicated test| > |sstableofflinerelevel|(x)|(x)|(!)| | > |sstablerepairedset|(x)|(x)|(x)|Ran in dtests, no dedicated test| > |sstablescrub|(x)|(x)|(!)| | > |sstablesplit|(x)|(x)|(!)| | > |sstableupgrade|(x)|(x)|(!)| | > |sstableutil|(/)|(x)|(!)|UX fix: C-15991| > |sstableverify|(/)|(x)|(!)|UX fix: C-15991 but missing options in docs + > broken token_range option| -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15991) 15583 - Add UX tests to intree LHF tooling
[ https://issues.apache.org/jira/browse/CASSANDRA-15991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Berenguer Blasi updated CASSANDRA-15991: Change Category: Quality Assurance Complexity: Normal Status: Open (was: Triage Needed) > 15583 - Add UX tests to intree LHF tooling > -- > > Key: CASSANDRA-15991 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15991 > Project: Cassandra > Issue Type: Improvement > Components: Test/unit >Reporter: Berenguer Blasi >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 4.0-beta > > > As per CASSANDRA-15583 many in tree tools lack proper UX tooling: mandatory > params are indeed mandatory, 'help' produces an actual help, return codes etc > This ticket is an attempt to add it to those tools that classify as LHF. > Other tools such as nodetool, with many sub-commands, deserve a separate > ticket of their own -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15991) 15583 - Add UX tests to intree LHF tooling
[ https://issues.apache.org/jira/browse/CASSANDRA-15991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Berenguer Blasi updated CASSANDRA-15991: Fix Version/s: 4.0-beta > 15583 - Add UX tests to intree LHF tooling > -- > > Key: CASSANDRA-15991 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15991 > Project: Cassandra > Issue Type: Improvement > Components: Test/unit >Reporter: Berenguer Blasi >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 4.0-beta > > > As per CASSANDRA-15583 many in tree tools lack proper UX tooling: mandatory > params are indeed mandatory, 'help' produces an actual help, return codes etc > This ticket is an attempt to add it to those tools that classify as LHF. > Other tools such as nodetool, with many sub-commands, deserve a separate > ticket of their own -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-14559) Check for endpoint collision with hibernating nodes
[ https://issues.apache.org/jira/browse/CASSANDRA-14559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166360#comment-17166360 ] Stefan Miklosovic edited comment on CASSANDRA-14559 at 7/28/20, 11:49 AM: -- PRs for trunk and 3.11 3.11: [https://github.com/apache/cassandra/pull/700/commits] trunk: [https://github.com/apache/cassandra/pull/699] dtest PR: [https://github.com/apache/cassandra-dtest/pull/87] [~dcapwell] [~Bereng] would any of you mind to go over this? thanks! was (Author: stefan.miklosovic): PRs for trunk and 3.11 3.11: [https://github.com/apache/cassandra/pull/700/commits] trunk: [https://github.com/apache/cassandra/pull/699] dtest PR: [https://github.com/apache/cassandra-dtest/pull/87] [~dcapwell] [~Bereng] would any of your mind to go over this? thanks! > Check for endpoint collision with hibernating nodes > > > Key: CASSANDRA-14559 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14559 > Project: Cassandra > Issue Type: Bug > Components: Consistency/Bootstrap and Decommission >Reporter: Vincent White >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 3.11.x, 4.0-beta2 > > > I ran across an edge case when replacing a node with the same address. This > issue results in the node(and its tokens) being unsafely removed from gossip. > Steps to replicate: > 1. Create 3 node cluster. > 2. Stop a node > 3. Replace the stopped node with a node using the same address using the > replace_address flag > 4. Stop the node before it finishes bootstrapping > 5. Remove the replace_address flag and restart the node to resume > bootstrapping (if the data dir is also cleared at this point the node will > also generate new tokens when it starts) > 6. Stop the node before it finishes bootstrapping again > 7. 30 Seconds later the node will be removed from gossip because it now > matches the check for a FatClient > I think this is only an issue when replacing a node with the same address > because other replacements now use STATUS_BOOTSTRAPPING_REPLACE and leave the > dead node unchanged. > I believe the simplest fix for this is to add a check that prevents a > non-bootstrapped node (without the replaces_address flag) starting if there > is a gossip entry for the same address in the hibernate state. > [3.11 PoC > |https://github.com/apache/cassandra/compare/trunk...vincewhite:check_for_hibernate_on_start] > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14559) Check for endpoint collision with hibernating nodes
[ https://issues.apache.org/jira/browse/CASSANDRA-14559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-14559: -- Complexity: Normal Component/s: (was: Legacy/Distributed Metadata) Consistency/Bootstrap and Decommission Discovered By: User Report Fix Version/s: 4.0-beta2 3.11.x Platform: All > Check for endpoint collision with hibernating nodes > > > Key: CASSANDRA-14559 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14559 > Project: Cassandra > Issue Type: Bug > Components: Consistency/Bootstrap and Decommission >Reporter: Vincent White >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 3.11.x, 4.0-beta2 > > > I ran across an edge case when replacing a node with the same address. This > issue results in the node(and its tokens) being unsafely removed from gossip. > Steps to replicate: > 1. Create 3 node cluster. > 2. Stop a node > 3. Replace the stopped node with a node using the same address using the > replace_address flag > 4. Stop the node before it finishes bootstrapping > 5. Remove the replace_address flag and restart the node to resume > bootstrapping (if the data dir is also cleared at this point the node will > also generate new tokens when it starts) > 6. Stop the node before it finishes bootstrapping again > 7. 30 Seconds later the node will be removed from gossip because it now > matches the check for a FatClient > I think this is only an issue when replacing a node with the same address > because other replacements now use STATUS_BOOTSTRAPPING_REPLACE and leave the > dead node unchanged. > I believe the simplest fix for this is to add a check that prevents a > non-bootstrapped node (without the replaces_address flag) starting if there > is a gossip entry for the same address in the hibernate state. > [3.11 PoC > |https://github.com/apache/cassandra/compare/trunk...vincewhite:check_for_hibernate_on_start] > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-14559) Check for endpoint collision with hibernating nodes
[ https://issues.apache.org/jira/browse/CASSANDRA-14559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166360#comment-17166360 ] Stefan Miklosovic edited comment on CASSANDRA-14559 at 7/28/20, 11:46 AM: -- PRs for trunk and 3.11 3.11: [https://github.com/apache/cassandra/pull/700/commits] trunk: [https://github.com/apache/cassandra/pull/699] dtest PR: [https://github.com/apache/cassandra-dtest/pull/87] [~dcapwell] [~Bereng] would any of your mind to go over this? thanks! was (Author: stefan.miklosovic): PRs for trunk and 3.11 3.11: [https://github.com/apache/cassandra/pull/700/commits] trunk: [https://github.com/apache/cassandra/pull/699] dtest PR: [https://github.com/apache/cassandra-dtest/pull/87] > Check for endpoint collision with hibernating nodes > > > Key: CASSANDRA-14559 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14559 > Project: Cassandra > Issue Type: Bug > Components: Legacy/Distributed Metadata >Reporter: Vincent White >Assignee: Stefan Miklosovic >Priority: Normal > > I ran across an edge case when replacing a node with the same address. This > issue results in the node(and its tokens) being unsafely removed from gossip. > Steps to replicate: > 1. Create 3 node cluster. > 2. Stop a node > 3. Replace the stopped node with a node using the same address using the > replace_address flag > 4. Stop the node before it finishes bootstrapping > 5. Remove the replace_address flag and restart the node to resume > bootstrapping (if the data dir is also cleared at this point the node will > also generate new tokens when it starts) > 6. Stop the node before it finishes bootstrapping again > 7. 30 Seconds later the node will be removed from gossip because it now > matches the check for a FatClient > I think this is only an issue when replacing a node with the same address > because other replacements now use STATUS_BOOTSTRAPPING_REPLACE and leave the > dead node unchanged. > I believe the simplest fix for this is to add a check that prevents a > non-bootstrapped node (without the replaces_address flag) starting if there > is a gossip entry for the same address in the hibernate state. > [3.11 PoC > |https://github.com/apache/cassandra/compare/trunk...vincewhite:check_for_hibernate_on_start] > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15833) Unresolvable false digest mismatch during upgrade due to CASSANDRA-10657
[ https://issues.apache.org/jira/browse/CASSANDRA-15833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166362#comment-17166362 ] Jacek Lewandowski commented on CASSANDRA-15833: --- Please also note this: https://issues.apache.org/jira/browse/CASSANDRA-15962 Here: [https://github.com/apache/cassandra/pull/676] is my test that reproduces the digest problems > Unresolvable false digest mismatch during upgrade due to CASSANDRA-10657 > > > Key: CASSANDRA-15833 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15833 > Project: Cassandra > Issue Type: Bug > Components: Consistency/Repair >Reporter: Jacek Lewandowski >Assignee: Jacek Lewandowski >Priority: Normal > Fix For: 3.11.x, 4.0-beta > > Attachments: CASSANDRA-15833-3.11.patch, CASSANDRA-15833-4.0.patch > > > CASSANDRA-10657 introduced changes in how the ColumnFilter is interpreted. > This results in digest mismatch when querying incomplete set of columns from > a table with consistency that requires reaching instances running pre > CASSANDRA-10657 from nodes that include CASSANDRA-10657 (it was introduced in > Cassandra 3.4). > The fix is to bring back the previous behaviour until there are no instances > running pre CASSANDRA-10657 version. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-14559) Check for endpoint collision with hibernating nodes
[ https://issues.apache.org/jira/browse/CASSANDRA-14559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic reassigned CASSANDRA-14559: - Assignee: Stefan Miklosovic (was: Vincent White) > Check for endpoint collision with hibernating nodes > > > Key: CASSANDRA-14559 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14559 > Project: Cassandra > Issue Type: Bug > Components: Legacy/Distributed Metadata >Reporter: Vincent White >Assignee: Stefan Miklosovic >Priority: Normal > > I ran across an edge case when replacing a node with the same address. This > issue results in the node(and its tokens) being unsafely removed from gossip. > Steps to replicate: > 1. Create 3 node cluster. > 2. Stop a node > 3. Replace the stopped node with a node using the same address using the > replace_address flag > 4. Stop the node before it finishes bootstrapping > 5. Remove the replace_address flag and restart the node to resume > bootstrapping (if the data dir is also cleared at this point the node will > also generate new tokens when it starts) > 6. Stop the node before it finishes bootstrapping again > 7. 30 Seconds later the node will be removed from gossip because it now > matches the check for a FatClient > I think this is only an issue when replacing a node with the same address > because other replacements now use STATUS_BOOTSTRAPPING_REPLACE and leave the > dead node unchanged. > I believe the simplest fix for this is to add a check that prevents a > non-bootstrapped node (without the replaces_address flag) starting if there > is a gossip entry for the same address in the hibernate state. > [3.11 PoC > |https://github.com/apache/cassandra/compare/trunk...vincewhite:check_for_hibernate_on_start] > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14559) Check for endpoint collision with hibernating nodes
[ https://issues.apache.org/jira/browse/CASSANDRA-14559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166360#comment-17166360 ] Stefan Miklosovic commented on CASSANDRA-14559: --- PRs for trunk and 3.11 3.11: [https://github.com/apache/cassandra/pull/700/commits] trunk: [https://github.com/apache/cassandra/pull/699] dtest PR: [https://github.com/apache/cassandra-dtest/pull/87] > Check for endpoint collision with hibernating nodes > > > Key: CASSANDRA-14559 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14559 > Project: Cassandra > Issue Type: Bug > Components: Legacy/Distributed Metadata >Reporter: Vincent White >Assignee: Vincent White >Priority: Normal > > I ran across an edge case when replacing a node with the same address. This > issue results in the node(and its tokens) being unsafely removed from gossip. > Steps to replicate: > 1. Create 3 node cluster. > 2. Stop a node > 3. Replace the stopped node with a node using the same address using the > replace_address flag > 4. Stop the node before it finishes bootstrapping > 5. Remove the replace_address flag and restart the node to resume > bootstrapping (if the data dir is also cleared at this point the node will > also generate new tokens when it starts) > 6. Stop the node before it finishes bootstrapping again > 7. 30 Seconds later the node will be removed from gossip because it now > matches the check for a FatClient > I think this is only an issue when replacing a node with the same address > because other replacements now use STATUS_BOOTSTRAPPING_REPLACE and leave the > dead node unchanged. > I believe the simplest fix for this is to add a check that prevents a > non-bootstrapped node (without the replaces_address flag) starting if there > is a gossip entry for the same address in the hibernate state. > [3.11 PoC > |https://github.com/apache/cassandra/compare/trunk...vincewhite:check_for_hibernate_on_start] > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15946) NPE when sending REQUEST_RSP from 3.0 to 4.0 in in-jvm dtests
[
https://issues.apache.org/jira/browse/CASSANDRA-15946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacek Lewandowski updated CASSANDRA-15946:
--
Test and Documentation Plan: Here
[https://github.com/apache/cassandra/pull/676] is the test which fails due to
the mentioned communication problems
Status: Patch Available (was: In Progress)
> NPE when sending REQUEST_RSP from 3.0 to 4.0 in in-jvm dtests
> -
>
> Key: CASSANDRA-15946
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15946
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest
>Reporter: Jacek Lewandowski
>Assignee: Jacek Lewandowski
>Priority: Normal
>
> There is a communication problem when testing upgrades using in-JVM dtest
> between Cassandra 3 and 4.
> In a method {{registerInboundFilter}} of {{Instance}}, we get a message which
> was just received and we prepare it for filtering as part of which, we
> serialize the payload again. This is fine when dealing with incoming
> Cassandra 4 message, because we can serialize it. However when we get the
> Cassandra 3 message, which uses a different protocol, and we get something
> like {{REQUEST_RSP}}, we can surely deserialize it through some special
> deserialization path, but we cannot serialize the payload for it as there is
> no serializer defined for {{REQUEST_RSP}} - no wonder, why would Cassandra
> 4.0 need to be able to serialize Cassandra 3.0 payloads?
> {code}
> java.lang.NullPointerException: null
> at
> org.apache.cassandra.net.Message$Serializer.serializePost40(Message.java:760)
> at
> org.apache.cassandra.net.Message$Serializer.serialize(Message.java:618)
> at
> org.apache.cassandra.distributed.impl.Instance.serializeMessage(Instance.java:267)
> at
> org.apache.cassandra.distributed.impl.Instance.lambda$registerInboundFilter$4(Instance.java:234)
> at
> org.apache.cassandra.net.InboundSink$Filtered.accept(InboundSink.java:62)
> at
> org.apache.cassandra.net.InboundSink$Filtered.accept(InboundSink.java:49)
> at org.apache.cassandra.net.InboundSink.accept(InboundSink.java:93)
> at
> org.apache.cassandra.distributed.impl.Instance.lambda$null$6(Instance.java:305)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at
> org.apache.cassandra.concurrent.AbstractLocalAwareExecutorService$FutureTask.run(AbstractLocalAwareExecutorService.java:165)
> at
> org.apache.cassandra.concurrent.AbstractLocalAwareExecutorService$LocalSessionFutureTask.run(AbstractLocalAwareExecutorService.java:137)
> at org.apache.cassandra.concurrent.SEPWorker.run(SEPWorker.java:119)
> at
> io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
> at java.lang.Thread.run(Thread.java:748)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15946) NPE when sending REQUEST_RSP from 3.0 to 4.0 in in-jvm dtests
[
https://issues.apache.org/jira/browse/CASSANDRA-15946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166355#comment-17166355
]
Jacek Lewandowski commented on CASSANDRA-15946:
---
I've updated my PR with your suggestions. It seems it works fine. You asked
about some reproduction example - it is here:
[https://github.com/apache/cassandra/pull/676] (CASSANDRA-15833) along with
this patch.
> NPE when sending REQUEST_RSP from 3.0 to 4.0 in in-jvm dtests
> -
>
> Key: CASSANDRA-15946
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15946
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest
>Reporter: Jacek Lewandowski
>Assignee: Jacek Lewandowski
>Priority: Normal
>
> There is a communication problem when testing upgrades using in-JVM dtest
> between Cassandra 3 and 4.
> In a method {{registerInboundFilter}} of {{Instance}}, we get a message which
> was just received and we prepare it for filtering as part of which, we
> serialize the payload again. This is fine when dealing with incoming
> Cassandra 4 message, because we can serialize it. However when we get the
> Cassandra 3 message, which uses a different protocol, and we get something
> like {{REQUEST_RSP}}, we can surely deserialize it through some special
> deserialization path, but we cannot serialize the payload for it as there is
> no serializer defined for {{REQUEST_RSP}} - no wonder, why would Cassandra
> 4.0 need to be able to serialize Cassandra 3.0 payloads?
> {code}
> java.lang.NullPointerException: null
> at
> org.apache.cassandra.net.Message$Serializer.serializePost40(Message.java:760)
> at
> org.apache.cassandra.net.Message$Serializer.serialize(Message.java:618)
> at
> org.apache.cassandra.distributed.impl.Instance.serializeMessage(Instance.java:267)
> at
> org.apache.cassandra.distributed.impl.Instance.lambda$registerInboundFilter$4(Instance.java:234)
> at
> org.apache.cassandra.net.InboundSink$Filtered.accept(InboundSink.java:62)
> at
> org.apache.cassandra.net.InboundSink$Filtered.accept(InboundSink.java:49)
> at org.apache.cassandra.net.InboundSink.accept(InboundSink.java:93)
> at
> org.apache.cassandra.distributed.impl.Instance.lambda$null$6(Instance.java:305)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at
> org.apache.cassandra.concurrent.AbstractLocalAwareExecutorService$FutureTask.run(AbstractLocalAwareExecutorService.java:165)
> at
> org.apache.cassandra.concurrent.AbstractLocalAwareExecutorService$LocalSessionFutureTask.run(AbstractLocalAwareExecutorService.java:137)
> at org.apache.cassandra.concurrent.SEPWorker.run(SEPWorker.java:119)
> at
> io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
> at java.lang.Thread.run(Thread.java:748)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15991) 15583 - Add UX tests to intree LHF tooling
[ https://issues.apache.org/jira/browse/CASSANDRA-15991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Berenguer Blasi updated CASSANDRA-15991: Summary: 15583 - Add UX tests to intree LHF tooling (was: 15583 - Add UX tests to intree tooling) > 15583 - Add UX tests to intree LHF tooling > -- > > Key: CASSANDRA-15991 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15991 > Project: Cassandra > Issue Type: Improvement > Components: Test/unit >Reporter: Berenguer Blasi >Assignee: Berenguer Blasi >Priority: Normal > > As per CASSANDRA-15583 many in tree tools lack proper UX tooling: mandatory > params are indeed mandatory, 'help' produces an actual help, return codes etc > This ticket is an attempt to add it to those tools that classify as LHF. > Other tools such as nodetool, with many sub-commands, deserve a separate > ticket of their own -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-15991) 15583 - Add UX tests to intree tooling
Berenguer Blasi created CASSANDRA-15991: --- Summary: 15583 - Add UX tests to intree tooling Key: CASSANDRA-15991 URL: https://issues.apache.org/jira/browse/CASSANDRA-15991 Project: Cassandra Issue Type: Improvement Components: Test/unit Reporter: Berenguer Blasi Assignee: Berenguer Blasi As per CASSANDRA-15583 many in tree tools lack proper UX tooling: mandatory params are indeed mandatory, 'help' produces an actual help, return codes etc This ticket is an attempt to add it to those tools that classify as LHF. Other tools such as nodetool, with many sub-commands, deserve a separate ticket of their own -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15946) NPE when sending REQUEST_RSP from 3.0 to 4.0 in in-jvm dtests
[
https://issues.apache.org/jira/browse/CASSANDRA-15946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166272#comment-17166272
]
Jacek Lewandowski commented on CASSANDRA-15946:
---
Sorry [~ifesdjeen], I was on short vacation. Indeed, this is what I was trying
to explain in the description of this ticket :)
Will try the approach you've suggested
> NPE when sending REQUEST_RSP from 3.0 to 4.0 in in-jvm dtests
> -
>
> Key: CASSANDRA-15946
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15946
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest
>Reporter: Jacek Lewandowski
>Assignee: Jacek Lewandowski
>Priority: Normal
>
> There is a communication problem when testing upgrades using in-JVM dtest
> between Cassandra 3 and 4.
> In a method {{registerInboundFilter}} of {{Instance}}, we get a message which
> was just received and we prepare it for filtering as part of which, we
> serialize the payload again. This is fine when dealing with incoming
> Cassandra 4 message, because we can serialize it. However when we get the
> Cassandra 3 message, which uses a different protocol, and we get something
> like {{REQUEST_RSP}}, we can surely deserialize it through some special
> deserialization path, but we cannot serialize the payload for it as there is
> no serializer defined for {{REQUEST_RSP}} - no wonder, why would Cassandra
> 4.0 need to be able to serialize Cassandra 3.0 payloads?
> {code}
> java.lang.NullPointerException: null
> at
> org.apache.cassandra.net.Message$Serializer.serializePost40(Message.java:760)
> at
> org.apache.cassandra.net.Message$Serializer.serialize(Message.java:618)
> at
> org.apache.cassandra.distributed.impl.Instance.serializeMessage(Instance.java:267)
> at
> org.apache.cassandra.distributed.impl.Instance.lambda$registerInboundFilter$4(Instance.java:234)
> at
> org.apache.cassandra.net.InboundSink$Filtered.accept(InboundSink.java:62)
> at
> org.apache.cassandra.net.InboundSink$Filtered.accept(InboundSink.java:49)
> at org.apache.cassandra.net.InboundSink.accept(InboundSink.java:93)
> at
> org.apache.cassandra.distributed.impl.Instance.lambda$null$6(Instance.java:305)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at
> org.apache.cassandra.concurrent.AbstractLocalAwareExecutorService$FutureTask.run(AbstractLocalAwareExecutorService.java:165)
> at
> org.apache.cassandra.concurrent.AbstractLocalAwareExecutorService$LocalSessionFutureTask.run(AbstractLocalAwareExecutorService.java:137)
> at org.apache.cassandra.concurrent.SEPWorker.run(SEPWorker.java:119)
> at
> io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
> at java.lang.Thread.run(Thread.java:748)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15583) 4.0 quality testing: Tooling, Bundled and First Party
[ https://issues.apache.org/jira/browse/CASSANDRA-15583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166268#comment-17166268 ] Berenguer Blasi commented on CASSANDRA-15583: - I'll get started with my plan (steps A, B & C) which seem pretty non-controversial at least as a starting point. I will assume CASSANDRA-15956 will get merged to trunk as that is just minor changes to the core one CASSANDRA-15942, already merged by Sam. #justfyi #collaborating > 4.0 quality testing: Tooling, Bundled and First Party > - > > Key: CASSANDRA-15583 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15583 > Project: Cassandra > Issue Type: Task > Components: Test/dtest, Test/unit >Reporter: Josh McKenzie >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 4.0-beta > > > Reference [doc from > NGCC|https://docs.google.com/document/d/1uhUOp7wpE9ZXNDgxoCZHejHt5SO4Qw1dArZqqsJccyQ/edit#] > for context. > *Shepherd: Sam Tunnicliffe* > Test plans should cover bundled first-party tooling and CLIs such as > nodetool, cqlsh, and new tools supporting full query and audit logging > (CASSANDRA-13983, CASSANDRA-12151). > ||Tool||UX test||UT coverage||dtest coverage||Comments|| > |Nodetool|(x)|(x)|(!)|By no means all the sub commands are tested. Dtest also > test nodetool as a side effect| > |Cqlsh|(x)|(x)|(!)| | > |Cassandra-stress|(x)|(x)|(x)| Some UT| > |debug-cql|(x)|(x)|(x)| | > |fqltool|(x)|(/)|(!)| | > |auditlogviewer|(x)|(!)|(!)| | > |*Sstable utilities*| | | | | > |sstabledump|(x)|(x)|(!)| | > |sstableexpiredblockers|(x)|(x)|(!)| | > |sstablelevelreset|(x)|(x)|(!)| | > |sstableloader|(x)|(x)|(!)| | > |sstablemetadata|(x)|(x)|(x)|Ran in dtests, no dedicated test| > |sstableofflinerelevel|(x)|(x)|(!)| | > |sstablerepairedset|(x)|(x)|(x)|Ran in dtests, no dedicated test| > |sstablescrub|(x)|(x)|(!)| | > |sstablesplit|(x)|(x)|(!)| | > |sstableupgrade|(x)|(x)|(!)| | > |sstableutil|(x)|(x)|(!)| | > |sstableverify|(x)|(x)|(!)| | -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14200) NullPointerException when dumping sstable with null value for timestamp column
[
https://issues.apache.org/jira/browse/CASSANDRA-14200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166262#comment-17166262
]
Berenguer Blasi commented on CASSANDRA-14200:
-
Had to assign myself to be able to close as dup. Feel free to correct me if
wrong :-)
> NullPointerException when dumping sstable with null value for timestamp column
> --
>
> Key: CASSANDRA-14200
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14200
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Core
>Reporter: Simon Zhou
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 3.0.x
>
>
> We have an sstable whose schema has a column of type timestamp and it's not
> part of primary key. When dumping the sstable using sstabledump there is NPE
> like this:
> {code:java}
> Exception in thread "main" java.lang.NullPointerException
> at java.util.Calendar.setTime(Calendar.java:1770)
> at java.text.SimpleDateFormat.format(SimpleDateFormat.java:943)
> at java.text.SimpleDateFormat.format(SimpleDateFormat.java:936)
> at java.text.DateFormat.format(DateFormat.java:345)
> at
> org.apache.cassandra.db.marshal.TimestampType.toJSONString(TimestampType.java:93)
> at
> org.apache.cassandra.tools.JsonTransformer.serializeCell(JsonTransformer.java:442)
> at
> org.apache.cassandra.tools.JsonTransformer.serializeColumnData(JsonTransformer.java:376)
> at
> org.apache.cassandra.tools.JsonTransformer.serializeRow(JsonTransformer.java:280)
> at
> org.apache.cassandra.tools.JsonTransformer.serializePartition(JsonTransformer.java:215)
> at java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184)
> at java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:175)
> at java.util.Iterator.forEachRemaining(Iterator.java:116)
> at
> java.util.Spliterators$IteratorSpliterator.forEachRemaining(Spliterators.java:1801)
> at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:481)
> at
> java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:471)
> at
> java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:151)
> at
> java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:174)
> at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
> at java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:418)
> at org.apache.cassandra.tools.JsonTransformer.toJson(JsonTransformer.java:104)
> at org.apache.cassandra.tools.SSTableExport.main(SSTableExport.java:242){code}
> The reason is that we use a null Date when there is no value for this column:
> {code}
> public Date deserialize(ByteBuffer bytes)
> {
> return bytes.remaining() == 0 ? null : new
> Date(ByteBufferUtil.toLong(bytes));
> }
> {code}
> It seems that we should not deserialize columns with null values.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-14200) NullPointerException when dumping sstable with null value for timestamp column
[
https://issues.apache.org/jira/browse/CASSANDRA-14200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Berenguer Blasi reassigned CASSANDRA-14200:
---
Assignee: Berenguer Blasi (was: Simon Zhou)
> NullPointerException when dumping sstable with null value for timestamp column
> --
>
> Key: CASSANDRA-14200
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14200
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Core
>Reporter: Simon Zhou
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 3.0.x
>
>
> We have an sstable whose schema has a column of type timestamp and it's not
> part of primary key. When dumping the sstable using sstabledump there is NPE
> like this:
> {code:java}
> Exception in thread "main" java.lang.NullPointerException
> at java.util.Calendar.setTime(Calendar.java:1770)
> at java.text.SimpleDateFormat.format(SimpleDateFormat.java:943)
> at java.text.SimpleDateFormat.format(SimpleDateFormat.java:936)
> at java.text.DateFormat.format(DateFormat.java:345)
> at
> org.apache.cassandra.db.marshal.TimestampType.toJSONString(TimestampType.java:93)
> at
> org.apache.cassandra.tools.JsonTransformer.serializeCell(JsonTransformer.java:442)
> at
> org.apache.cassandra.tools.JsonTransformer.serializeColumnData(JsonTransformer.java:376)
> at
> org.apache.cassandra.tools.JsonTransformer.serializeRow(JsonTransformer.java:280)
> at
> org.apache.cassandra.tools.JsonTransformer.serializePartition(JsonTransformer.java:215)
> at java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184)
> at java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:175)
> at java.util.Iterator.forEachRemaining(Iterator.java:116)
> at
> java.util.Spliterators$IteratorSpliterator.forEachRemaining(Spliterators.java:1801)
> at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:481)
> at
> java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:471)
> at
> java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:151)
> at
> java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:174)
> at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
> at java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:418)
> at org.apache.cassandra.tools.JsonTransformer.toJson(JsonTransformer.java:104)
> at org.apache.cassandra.tools.SSTableExport.main(SSTableExport.java:242){code}
> The reason is that we use a null Date when there is no value for this column:
> {code}
> public Date deserialize(ByteBuffer bytes)
> {
> return bytes.remaining() == 0 ? null : new
> Date(ByteBufferUtil.toLong(bytes));
> }
> {code}
> It seems that we should not deserialize columns with null values.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14200) NullPointerException when dumping sstable with null value for timestamp column
[
https://issues.apache.org/jira/browse/CASSANDRA-14200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Berenguer Blasi updated CASSANDRA-14200:
Resolution: Duplicate
Status: Resolved (was: Open)
> NullPointerException when dumping sstable with null value for timestamp column
> --
>
> Key: CASSANDRA-14200
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14200
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Core
>Reporter: Simon Zhou
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 3.0.x
>
>
> We have an sstable whose schema has a column of type timestamp and it's not
> part of primary key. When dumping the sstable using sstabledump there is NPE
> like this:
> {code:java}
> Exception in thread "main" java.lang.NullPointerException
> at java.util.Calendar.setTime(Calendar.java:1770)
> at java.text.SimpleDateFormat.format(SimpleDateFormat.java:943)
> at java.text.SimpleDateFormat.format(SimpleDateFormat.java:936)
> at java.text.DateFormat.format(DateFormat.java:345)
> at
> org.apache.cassandra.db.marshal.TimestampType.toJSONString(TimestampType.java:93)
> at
> org.apache.cassandra.tools.JsonTransformer.serializeCell(JsonTransformer.java:442)
> at
> org.apache.cassandra.tools.JsonTransformer.serializeColumnData(JsonTransformer.java:376)
> at
> org.apache.cassandra.tools.JsonTransformer.serializeRow(JsonTransformer.java:280)
> at
> org.apache.cassandra.tools.JsonTransformer.serializePartition(JsonTransformer.java:215)
> at java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184)
> at java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:175)
> at java.util.Iterator.forEachRemaining(Iterator.java:116)
> at
> java.util.Spliterators$IteratorSpliterator.forEachRemaining(Spliterators.java:1801)
> at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:481)
> at
> java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:471)
> at
> java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:151)
> at
> java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:174)
> at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
> at java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:418)
> at org.apache.cassandra.tools.JsonTransformer.toJson(JsonTransformer.java:104)
> at org.apache.cassandra.tools.SSTableExport.main(SSTableExport.java:242){code}
> The reason is that we use a null Date when there is no value for this column:
> {code}
> public Date deserialize(ByteBuffer bytes)
> {
> return bytes.remaining() == 0 ? null : new
> Date(ByteBufferUtil.toLong(bytes));
> }
> {code}
> It seems that we should not deserialize columns with null values.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15956) 15583 - Ensure tooling surface area coverage
[ https://issues.apache.org/jira/browse/CASSANDRA-15956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Berenguer Blasi updated CASSANDRA-15956: Source Control Link: (was: https://github.com/apache/cassandra/pull/683/commits/6c3962fba93682ff75708243d7efb92878984638) > 15583 - Ensure tooling surface area coverage > > > Key: CASSANDRA-15956 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15956 > Project: Cassandra > Issue Type: Improvement > Components: Test/unit >Reporter: Berenguer Blasi >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 4.0-beta > > > Given CASSANDRA-15942 POC seems ok so far. Now we'll extend that to other > tools and scenarios in a width first approach to make sure enough surface > area is covered. This should suffice to confirm our framework should enable > devs to test any tools when needed. > Tools: https://cassandra.apache.org/doc/latest/tools/index.html > ||Tool||Easy UT possible||UT Sample||Easy dtest possible||Has > dtest||Comments|| > |Nodetool|(/) Added/Enhanced|(/) Added/enhanced|(/)|(/)|Use UT if possible. > Otherwise dtests if you need a full multinode env| > |Cqlsh|(/) Added|(/) Added|(/)|(/)|Easy Cqlsh UT is now possible and an > example is included| > |Cassandra-stress|(/) Added and existing|(/) Added|(/)|(x)| > |debug-cql|(/)|(x)|(/)|(x)| > |fqltool|(/) Existing|(/) Existing|(/)|(/)| > |auditlogviewer|(/) Existing|(/) Existing|(/)|(/)| > |*Sstable utilities*|| > |sstabledump|(/) enhanced|(/) enhanced|(/)|(/)|| > |sstableexpiredblockers|(/) enhanced|(/) enhanced|(/)|(/)|| > |sstablelevelreset|(/) enhanced|(/) enhanced|(/)|(/)|| > |sstableloader|(/) enhanced|(/) enhanced|(/)|(/)|| > |sstablemetadata|(/) enhanced|(/) enhanced|(/)|(!)|Ran in dtests, no > dedicated test| > |sstableofflinerelevel|(/) enhanced|(/) enhanced|(/)|(/)|| > |sstablerepairedset|(/) enhanced|(/) enhanced|(/)|(!)|Ran in dtests, no > dedicated test| > |sstablescrub|(/) enhanced|(/) enhanced|(/)|(/)|| > |sstablesplit|(/) enhanced|(/) enhanced|(/)|(/)|| > |sstableupgrade|(/) enhanced|(/) enhanced|(/)|(/)|| > |sstableutil|(/) enhanced|(/) enhanced|(/)|(/)|| > |sstableverify|(/) enhanced|(/) enhanced|(/)|(/)|| -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15988) Add nodetool getfullquerylog
[ https://issues.apache.org/jira/browse/CASSANDRA-15988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166221#comment-17166221 ] Berenguer Blasi commented on CASSANDRA-15988: - CASSANDRA-15942 has been merged to trunk. That will allow you to add easy testing of the new command #collaborating > Add nodetool getfullquerylog > - > > Key: CASSANDRA-15988 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15988 > Project: Cassandra > Issue Type: Improvement > Components: Tool/fql >Reporter: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0-rc > > > This ticket is raised based on CASSANDRA-15791 and valuable feedback provided > by [~jshook]. > There are two outstanding questions: > * forming the exact shape of such a command and how it can benefit the > users; to be discussed in detail in this ticket > * Is this a thing we as a project can add to 4.0 beta or it should be > considered in 4.1 for example > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15990) Running CQL command with non-ASCII values raises UnicodeDecodeError
[
https://issues.apache.org/jira/browse/CASSANDRA-15990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Berenguer Blasi updated CASSANDRA-15990:
Fix Version/s: 4.0-beta
> Running CQL command with non-ASCII values raises UnicodeDecodeError
> ---
>
> Key: CASSANDRA-15990
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15990
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/cqlsh
>Reporter: Joseph Chu
>Priority: Normal
> Fix For: 4.0-beta
>
>
> There are INSERT statements that contains non-ASCII values that have run fine
> in Cassandra 3.11, but now raises a UnicodeDecodeError when I try executing
> them in 4.0-alpha4 and 4.0-beta1.
> Example input and output:
> {code:java}
> echo $LANG
> en_US.UTF-8
> $ cqlsh --debug
> Using CQL driver: '/usr/share/cassandra/bin/../lib/cassandra-driver-internal-only-3.23.0.post0-1a184b99.zip/cassandra-driver-3.23.0.post0-1a184b99/cassandra/__init__.py'>
> Using connect timeout: 5 seconds
> Using 'utf-8' encoding
> Using ssl: False
> Connected to Cassandra Cluster at 127.0.0.1:9042.
> [cqlsh 5.0.1 | Cassandra 4.0-beta1 | CQL spec 3.4.5 | Native protocol v4]
> Use HELP for help.
> cqlsh> CREATE KEYSPACE killr_video WITH replication = {'class':
> 'NetworkTopologyStrategy', 'DC-Houston': 1};
> cqlsh> USE killr_video;
> cqlsh:killr_video> CREATE TABLE movies_by_genre ( genre TEXT, title TEXT,
> year INT, duration INT, avg_rating FLOAT, country TEXT, PRIMARY KEY ((genre),
> title, year));
> cqlsh:killr_video> INSERT INTO movies_by_genre (genre, title, year, duration,
> avg_rating, country)
> ... VALUES ('Action', 'The Extraordinary Adventures of Adèle Blanc-Sec',
> 2010, 107, 6.30, 'France');
> Traceback (most recent call last):
> File "/usr/share/cassandra/bin/cqlsh.py", line 937, in onecmd
> self.handle_statement(st, statementtext)
> File "/usr/share/cassandra/bin/cqlsh.py", line 962, in handle_statement
> readline.add_history(new_hist)
> UnicodeEncodeError: 'ascii' codec can't encode character u'\xe8' in position
> 134: ordinal not in range(128){code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
