[jira] [Commented] (CASSANDRA-12681) Reject empty options and invalid DC names in replication configuration while creating or altering a keyspace.
[ https://issues.apache.org/jira/browse/CASSANDRA-12681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15535547#comment-15535547 ] Jeremiah Jordan commented on CASSANDRA-12681: - Thanks Jeff. +1 on the new NEWS.TXT entry as well. > Reject empty options and invalid DC names in replication configuration while > creating or altering a keyspace. > - > > Key: CASSANDRA-12681 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12681 > Project: Cassandra > Issue Type: Improvement > Components: Distributed Metadata >Reporter: Nachiket Patil >Assignee: Nachiket Patil >Priority: Minor > Fix For: 4.0 > > Attachments: trunkpatch.diff, v3.0patch.diff > > > Add some restrictions around create / alter keyspace with > NetworkTopologyStrategy: > 1. Do not accept empty replication configuration (no DC options after class). > Cassandra checks that SimpleStrategy must have replication_factor option but > does not check that at least one DC should be present in the options for > NetworkTopologyStrategy. > 2. Cassandra accepts any random string as DC name replication option for > NetworkTopologyStrategy while creating or altering keyspaces. Add a > restriction that the options specified is valid datacenter name. Using > incorrect value or simple mistake in typing the DC name can cause outage in > production environment. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12681) Reject empty options and invalid DC names in replication configuration while creating or altering a keyspace.
[
https://issues.apache.org/jira/browse/CASSANDRA-12681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15534866#comment-15534866
]
Jeff Jirsa commented on CASSANDRA-12681:
Reverted in 3.0 ( {{cd8a98a2dd2d7e4993cd1aa3c282602b48be73c8}} ) and 3.X (
{{02404115e0db1762473556f985c8e5388db92da6}} ), updated NEWS.txt to be more
descriptive in trunk/4.0:
{code}
- Cassandra will no longer allow invalid keyspace replication options, such
as invalid datacenter names for
NetworkTopologyStrategy. Operators MUST add new nodes to a datacenter
before they can set set ALTER or
CREATE keyspace replication policies using that datacenter. Existing
keyspaces will continue to operate,
but CREATE and ALTER will validate that all datacenters specified exist
in the cluster.
{code}
Apologies to you DSE folks for the inconvenience. Having been on the wrong side
of API changes in minor versions, I should have been more sensitive to this.
> Reject empty options and invalid DC names in replication configuration while
> creating or altering a keyspace.
> -
>
> Key: CASSANDRA-12681
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12681
> Project: Cassandra
> Issue Type: Improvement
> Components: Distributed Metadata
>Reporter: Nachiket Patil
>Assignee: Nachiket Patil
>Priority: Minor
> Fix For: 3.0.10, 3.10
>
> Attachments: trunkpatch.diff, v3.0patch.diff
>
>
> Add some restrictions around create / alter keyspace with
> NetworkTopologyStrategy:
> 1. Do not accept empty replication configuration (no DC options after class).
> Cassandra checks that SimpleStrategy must have replication_factor option but
> does not check that at least one DC should be present in the options for
> NetworkTopologyStrategy.
> 2. Cassandra accepts any random string as DC name replication option for
> NetworkTopologyStrategy while creating or altering keyspaces. Add a
> restriction that the options specified is valid datacenter name. Using
> incorrect value or simple mistake in typing the DC name can cause outage in
> production environment.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12681) Reject empty options and invalid DC names in replication configuration while creating or altering a keyspace.
[ https://issues.apache.org/jira/browse/CASSANDRA-12681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15534243#comment-15534243 ] Jeff Jirsa commented on CASSANDRA-12681: Will revert it when I get home. Will re-land in 4.0 only. Feel free to revert on my behalf if you're in a hurry. > Reject empty options and invalid DC names in replication configuration while > creating or altering a keyspace. > - > > Key: CASSANDRA-12681 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12681 > Project: Cassandra > Issue Type: Improvement > Components: Distributed Metadata >Reporter: Nachiket Patil >Assignee: Nachiket Patil >Priority: Minor > Fix For: 3.0.10, 3.10 > > Attachments: trunkpatch.diff, v3.0patch.diff > > > Add some restrictions around create / alter keyspace with > NetworkTopologyStrategy: > 1. Do not accept empty replication configuration (no DC options after class). > Cassandra checks that SimpleStrategy must have replication_factor option but > does not check that at least one DC should be present in the options for > NetworkTopologyStrategy. > 2. Cassandra accepts any random string as DC name replication option for > NetworkTopologyStrategy while creating or altering keyspaces. Add a > restriction that the options specified is valid datacenter name. Using > incorrect value or simple mistake in typing the DC name can cause outage in > production environment. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12681) Reject empty options and invalid DC names in replication configuration while creating or altering a keyspace.
[ https://issues.apache.org/jira/browse/CASSANDRA-12681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15534174#comment-15534174 ] Aleksey Yeschenko commented on CASSANDRA-12681: --- It's breaking the existing contract by not accepting previously accepted values. It's broken a couple strategy implementations that inherit from NTS in DSE, for one. But, really, we have rules, and one of them is that only bug fixes go to 3.0.x - and this isn't a bug fix. > Reject empty options and invalid DC names in replication configuration while > creating or altering a keyspace. > - > > Key: CASSANDRA-12681 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12681 > Project: Cassandra > Issue Type: Improvement > Components: Distributed Metadata >Reporter: Nachiket Patil >Assignee: Nachiket Patil >Priority: Minor > Fix For: 3.0.10, 3.10 > > Attachments: trunkpatch.diff, v3.0patch.diff > > > Add some restrictions around create / alter keyspace with > NetworkTopologyStrategy: > 1. Do not accept empty replication configuration (no DC options after class). > Cassandra checks that SimpleStrategy must have replication_factor option but > does not check that at least one DC should be present in the options for > NetworkTopologyStrategy. > 2. Cassandra accepts any random string as DC name replication option for > NetworkTopologyStrategy while creating or altering keyspaces. Add a > restriction that the options specified is valid datacenter name. Using > incorrect value or simple mistake in typing the DC name can cause outage in > production environment. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12681) Reject empty options and invalid DC names in replication configuration while creating or altering a keyspace.
[ https://issues.apache.org/jira/browse/CASSANDRA-12681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15534157#comment-15534157 ] Aleksey Yeschenko commented on CASSANDRA-12681: --- +1, this is not acceptable for 3.0, not at this stage (almost a year in). Borderline acceptable for 3.X, but safest to commit to 4.0 only. > Reject empty options and invalid DC names in replication configuration while > creating or altering a keyspace. > - > > Key: CASSANDRA-12681 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12681 > Project: Cassandra > Issue Type: Improvement > Components: Distributed Metadata >Reporter: Nachiket Patil >Assignee: Nachiket Patil >Priority: Minor > Fix For: 3.0.10, 3.10 > > Attachments: trunkpatch.diff, v3.0patch.diff > > > Add some restrictions around create / alter keyspace with > NetworkTopologyStrategy: > 1. Do not accept empty replication configuration (no DC options after class). > Cassandra checks that SimpleStrategy must have replication_factor option but > does not check that at least one DC should be present in the options for > NetworkTopologyStrategy. > 2. Cassandra accepts any random string as DC name replication option for > NetworkTopologyStrategy while creating or altering keyspaces. Add a > restriction that the options specified is valid datacenter name. Using > incorrect value or simple mistake in typing the DC name can cause outage in > production environment. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12681) Reject empty options and invalid DC names in replication configuration while creating or altering a keyspace.
[ https://issues.apache.org/jira/browse/CASSANDRA-12681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15534159#comment-15534159 ] sankalp kohli commented on CASSANDRA-12681: --- What API is it breaking? It stops users from accidental outages right. > Reject empty options and invalid DC names in replication configuration while > creating or altering a keyspace. > - > > Key: CASSANDRA-12681 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12681 > Project: Cassandra > Issue Type: Improvement > Components: Distributed Metadata >Reporter: Nachiket Patil >Assignee: Nachiket Patil >Priority: Minor > Fix For: 3.0.10, 3.10 > > Attachments: trunkpatch.diff, v3.0patch.diff > > > Add some restrictions around create / alter keyspace with > NetworkTopologyStrategy: > 1. Do not accept empty replication configuration (no DC options after class). > Cassandra checks that SimpleStrategy must have replication_factor option but > does not check that at least one DC should be present in the options for > NetworkTopologyStrategy. > 2. Cassandra accepts any random string as DC name replication option for > NetworkTopologyStrategy while creating or altering keyspaces. Add a > restriction that the options specified is valid datacenter name. Using > incorrect value or simple mistake in typing the DC name can cause outage in > production environment. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12681) Reject empty options and invalid DC names in replication configuration while creating or altering a keyspace.
[ https://issues.apache.org/jira/browse/CASSANDRA-12681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15534124#comment-15534124 ] Jeremiah Jordan commented on CASSANDRA-12681: - [~jjirsa] since this is not a bug fix, and it breaks anything doing stuff like mentioned in CASSANDRA-4795 I really think we should revert this from 3.0.10 and possibly only commit it to 4.0. This is a breaking "API" change/behavior. > Reject empty options and invalid DC names in replication configuration while > creating or altering a keyspace. > - > > Key: CASSANDRA-12681 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12681 > Project: Cassandra > Issue Type: Improvement > Components: Distributed Metadata >Reporter: Nachiket Patil >Assignee: Nachiket Patil >Priority: Minor > Fix For: 3.0.10, 3.10 > > Attachments: trunkpatch.diff, v3.0patch.diff > > > Add some restrictions around create / alter keyspace with > NetworkTopologyStrategy: > 1. Do not accept empty replication configuration (no DC options after class). > Cassandra checks that SimpleStrategy must have replication_factor option but > does not check that at least one DC should be present in the options for > NetworkTopologyStrategy. > 2. Cassandra accepts any random string as DC name replication option for > NetworkTopologyStrategy while creating or altering keyspaces. Add a > restriction that the options specified is valid datacenter name. Using > incorrect value or simple mistake in typing the DC name can cause outage in > production environment. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12681) Reject empty options and invalid DC names in replication configuration while creating or altering a keyspace.
[ https://issues.apache.org/jira/browse/CASSANDRA-12681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15528066#comment-15528066 ] Nachiket Patil commented on CASSANDRA-12681: Thanks for all the help [~jjirsa] > Reject empty options and invalid DC names in replication configuration while > creating or altering a keyspace. > - > > Key: CASSANDRA-12681 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12681 > Project: Cassandra > Issue Type: Improvement > Components: Distributed Metadata >Reporter: Nachiket Patil >Assignee: Nachiket Patil >Priority: Minor > Fix For: 3.10, 3.0.10 > > Attachments: trunkpatch.diff, v3.0patch.diff > > > Add some restrictions around create / alter keyspace with > NetworkTopologyStrategy: > 1. Do not accept empty replication configuration (no DC options after class). > Cassandra checks that SimpleStrategy must have replication_factor option but > does not check that at least one DC should be present in the options for > NetworkTopologyStrategy. > 2. Cassandra accepts any random string as DC name replication option for > NetworkTopologyStrategy while creating or altering keyspaces. Add a > restriction that the options specified is valid datacenter name. Using > incorrect value or simple mistake in typing the DC name can cause outage in > production environment. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12681) Reject empty options and invalid DC names in replication configuration while creating or altering a keyspace.
[ https://issues.apache.org/jira/browse/CASSANDRA-12681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15524924#comment-15524924 ] Jeff Jirsa commented on CASSANDRA-12681: [~nachiket_patil] - it looks like your patch breaks dtest for both 3.0 and trunk: http://cassci.datastax.com/job/jeffjirsa-cassandra-12681-3.0-dtest/3/testReport/junit/junit/cql_tests/StorageProxyCQLTester/keyspace_test/ http://cassci.datastax.com/job/jeffjirsa-cassandra-12681-dtest/lastUnstableBuild/testReport/junit/cql_tests/StorageProxyCQLTester/keyspace_test/ The test is here: https://github.com/riptano/cassandra-dtest/blob/master/cql_tests.py#L73-L104 The dtest uses a datacenter named 'dc1', though ccm uses 'datacenter1'. I've opened a pull request to the dtests repo: https://github.com/riptano/cassandra-dtest/pull/1348 . I don't have write access to that repo, so we'll have to wait for someone who does to commit that, and then we'll kick off another dtest. > Reject empty options and invalid DC names in replication configuration while > creating or altering a keyspace. > - > > Key: CASSANDRA-12681 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12681 > Project: Cassandra > Issue Type: Improvement > Components: Distributed Metadata >Reporter: Nachiket Patil >Assignee: Nachiket Patil >Priority: Minor > Fix For: 3.0.x, 3.x > > Attachments: trunkpatch.diff, v3.0patch.diff > > > Add some restrictions around create / alter keyspace with > NetworkTopologyStrategy: > 1. Do not accept empty replication configuration (no DC options after class). > Cassandra checks that SimpleStrategy must have replication_factor option but > does not check that at least one DC should be present in the options for > NetworkTopologyStrategy. > 2. Cassandra accepts any random string as DC name replication option for > NetworkTopologyStrategy while creating or altering keyspaces. Add a > restriction that the options specified is valid datacenter name. Using > incorrect value or simple mistake in typing the DC name can cause outage in > production environment. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12681) Reject empty options and invalid DC names in replication configuration while creating or altering a keyspace.
[ https://issues.apache.org/jira/browse/CASSANDRA-12681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15524179#comment-15524179 ] Jeff Jirsa commented on CASSANDRA-12681: Thanks! I'll push up to cassci for one last test run > Reject empty options and invalid DC names in replication configuration while > creating or altering a keyspace. > - > > Key: CASSANDRA-12681 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12681 > Project: Cassandra > Issue Type: Improvement > Components: Distributed Metadata >Reporter: Nachiket Patil >Assignee: Nachiket Patil >Priority: Minor > Attachments: trunkpatch.diff, v3.0patch.diff > > > Add some restrictions around create / alter keyspace with > NetworkTopologyStrategy: > 1. Do not accept empty replication configuration (no DC options after class). > Cassandra checks that SimpleStrategy must have replication_factor option but > does not check that at least one DC should be present in the options for > NetworkTopologyStrategy. > 2. Cassandra accepts any random string as DC name replication option for > NetworkTopologyStrategy while creating or altering keyspaces. Add a > restriction that the options specified is valid datacenter name. Using > incorrect value or simple mistake in typing the DC name can cause outage in > production environment. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12681) Reject empty options and invalid DC names in replication configuration while creating or altering a keyspace.
[ https://issues.apache.org/jira/browse/CASSANDRA-12681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15524115#comment-15524115 ] Nachiket Patil commented on CASSANDRA-12681: [~jjirsa] Thanks for the review and changes. I have added your changes and some comments I had here and updated the diff. > Reject empty options and invalid DC names in replication configuration while > creating or altering a keyspace. > - > > Key: CASSANDRA-12681 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12681 > Project: Cassandra > Issue Type: Improvement > Components: Distributed Metadata >Reporter: Nachiket Patil >Assignee: Nachiket Patil >Priority: Minor > Attachments: trunkpatch.diff, v3.0patch.diff > > > Add some restrictions around create / alter keyspace with > NetworkTopologyStrategy: > 1. Do not accept empty replication configuration (no DC options after class). > Cassandra checks that SimpleStrategy must have replication_factor option but > does not check that at least one DC should be present in the options for > NetworkTopologyStrategy. > 2. Cassandra accepts any random string as DC name replication option for > NetworkTopologyStrategy while creating or altering keyspaces. Add a > restriction that the options specified is valid datacenter name. Using > incorrect value or simple mistake in typing the DC name can cause outage in > production environment. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12681) Reject empty options and invalid DC names in replication configuration while creating or altering a keyspace.
[ https://issues.apache.org/jira/browse/CASSANDRA-12681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15524100#comment-15524100 ] Nachiket Patil commented on CASSANDRA-12681: 3. Add execute drop keyspace for new keyspace created for the CASSANDRA-4278 test in create tests. > Reject empty options and invalid DC names in replication configuration while > creating or altering a keyspace. > - > > Key: CASSANDRA-12681 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12681 > Project: Cassandra > Issue Type: Improvement > Components: Distributed Metadata >Reporter: Nachiket Patil >Assignee: Nachiket Patil >Priority: Minor > Attachments: trunkpatch.diff, v3.0patch.diff > > > Add some restrictions around create / alter keyspace with > NetworkTopologyStrategy: > 1. Do not accept empty replication configuration (no DC options after class). > Cassandra checks that SimpleStrategy must have replication_factor option but > does not check that at least one DC should be present in the options for > NetworkTopologyStrategy. > 2. Cassandra accepts any random string as DC name replication option for > NetworkTopologyStrategy while creating or altering keyspaces. Add a > restriction that the options specified is valid datacenter name. Using > incorrect value or simple mistake in typing the DC name can cause outage in > production environment. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12681) Reject empty options and invalid DC names in replication configuration while creating or altering a keyspace.
[
https://issues.apache.org/jira/browse/CASSANDRA-12681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15523833#comment-15523833
]
Nachiket Patil commented on CASSANDRA-12681:
Thanks for the review and changes Jeff. Your changes look good, minor comment:
1. I would like to add a CREATE statement instead of ALTER statement in create
tests for valid + invalid DC. We are testing same alter statement in alter
tests.
CreateTest.java
#361
- assertInvalidThrow(ConfigurationException.class, "ALTER KEYSPACE
testABC WITH replication={ 'class' : 'NetworkTopologyStrategy', '" +
DATA_CENTER + "' : 2 , 'INVALID_DC': 1}");
+ assertInvalidThrow(ConfigurationException.class, "CREATE KEYSPACE
testXYZ WITH replication={ 'class' : 'NetworkTopologyStrategy', '" +
DATA_CENTER + "' : 2 , 'INVALID_DC': 1}");
// clean-up
execute("DROP KEYSPACE testABC");
+ execute("DROP KEYSPACE testXYZ");
2. Just thought of quick enhancement: all drop keyspace statements in tests,
add "IF EXISTS" so if something goes wrong, the tests will fail with assertion
failed error instead of "cannot drop keyspace" ConfigurationException.
> Reject empty options and invalid DC names in replication configuration while
> creating or altering a keyspace.
> -
>
> Key: CASSANDRA-12681
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12681
> Project: Cassandra
> Issue Type: Improvement
> Components: Distributed Metadata
>Reporter: Nachiket Patil
>Assignee: Nachiket Patil
>Priority: Minor
> Attachments: trunkpatch.diff, v3.0patch.diff
>
>
> Add some restrictions around create / alter keyspace with
> NetworkTopologyStrategy:
> 1. Do not accept empty replication configuration (no DC options after class).
> Cassandra checks that SimpleStrategy must have replication_factor option but
> does not check that at least one DC should be present in the options for
> NetworkTopologyStrategy.
> 2. Cassandra accepts any random string as DC name replication option for
> NetworkTopologyStrategy while creating or altering keyspaces. Add a
> restriction that the options specified is valid datacenter name. Using
> incorrect value or simple mistake in typing the DC name can cause outage in
> production environment.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12681) Reject empty options and invalid DC names in replication configuration while creating or altering a keyspace.
[ https://issues.apache.org/jira/browse/CASSANDRA-12681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15523739#comment-15523739 ] Jeff Jirsa commented on CASSANDRA-12681: 3.0 tests look good. Trunk tests look awful. Tracked the problem to a commit last week that broke the tests - I'd like to hold of on committing until tests are cleaned up [~nachiket_patil] - are you happy with my proposed changes to your patch? > Reject empty options and invalid DC names in replication configuration while > creating or altering a keyspace. > - > > Key: CASSANDRA-12681 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12681 > Project: Cassandra > Issue Type: Improvement > Components: Distributed Metadata >Reporter: Nachiket Patil >Assignee: Nachiket Patil >Priority: Minor > Attachments: trunkpatch.diff, v3.0patch.diff > > > Add some restrictions around create / alter keyspace with > NetworkTopologyStrategy: > 1. Do not accept empty replication configuration (no DC options after class). > Cassandra checks that SimpleStrategy must have replication_factor option but > does not check that at least one DC should be present in the options for > NetworkTopologyStrategy. > 2. Cassandra accepts any random string as DC name replication option for > NetworkTopologyStrategy while creating or altering keyspaces. Add a > restriction that the options specified is valid datacenter name. Using > incorrect value or simple mistake in typing the DC name can cause outage in > production environment. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12681) Reject empty options and invalid DC names in replication configuration while creating or altering a keyspace.
[ https://issues.apache.org/jira/browse/CASSANDRA-12681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15518275#comment-15518275 ] Jeff Jirsa commented on CASSANDRA-12681: As far as I can tell, modern versions of titan are no longer abusing schema metadata: [by default they're using SimpleStrategy with no options|https://github.com/thinkaurelius/titan/blob/titan10/titan-cassandra/src/main/java/com/thinkaurelius/titan/diskstorage/cassandra/AbstractCassandraStoreManager.java#L83-L93], and probably relying on users to set anything beyond SimpleStrategy, and I see no custom strategy options being passed. > Reject empty options and invalid DC names in replication configuration while > creating or altering a keyspace. > - > > Key: CASSANDRA-12681 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12681 > Project: Cassandra > Issue Type: Improvement > Components: Distributed Metadata >Reporter: Nachiket Patil >Assignee: Nachiket Patil >Priority: Minor > Attachments: trunkpatch.diff, v3.0patch.diff > > > Add some restrictions around create / alter keyspace with > NetworkTopologyStrategy: > 1. Do not accept empty replication configuration (no DC options after class). > Cassandra checks that SimpleStrategy must have replication_factor option but > does not check that at least one DC should be present in the options for > NetworkTopologyStrategy. > 2. Cassandra accepts any random string as DC name replication option for > NetworkTopologyStrategy while creating or altering keyspaces. Add a > restriction that the options specified is valid datacenter name. Using > incorrect value or simple mistake in typing the DC name can cause outage in > production environment. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12681) Reject empty options and invalid DC names in replication configuration while creating or altering a keyspace.
[
https://issues.apache.org/jira/browse/CASSANDRA-12681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15518218#comment-15518218
]
Jeff Jirsa commented on CASSANDRA-12681:
Overall looks good.
Pushed to my github so I could kickoff tests. Also have 1 important and 3 minor
suggestions (which I've pushed here for your convenience:
[3.0|https://github.com/apache/cassandra/commit/49138d380048d2b891e2cf07dd788f01355c2ebe]
and
[trunk|https://github.com/apache/cassandra/commit/e43894aa0ec5f9a91aa8b8ceb6ea98509ff2d14a]):
- Recreate test for CASSANDRA-4278 in CreateTest where it should have been in
the first place (it was a early CQL bug, but we shouldn't reduce test coverage)
- Spelling correction on
testAlterKeyspaceWithNoOptionThrowsConfigurationExcepotion
- Add mixed valid/invalid DC statement to create and alter tests
- Remove double semi-colon
|[3.0
branch|https://github.com/apache/cassandra/compare/cassandra-3.0...jeffjirsa:cassandra-12681-3.0]|[testall|http://cassci.datastax.com/job/jeffjirsa-cassandra-12681-3.0-testall/]|[dtests|http://cassci.datastax.com/job/jeffjirsa-cassandra-12681-3.0-dtest/]|
|[trunk|https://github.com/apache/cassandra/compare/trunk...jeffjirsa:cassandra-12681]|[testall|http://cassci.datastax.com/job/jeffjirsa-cassandra-12681-testall/]|[dtests|http://cassci.datastax.com/job/jeffjirsa-cassandra-12681-dtest/]|
This still un-does CASSANDRA-4795, and [~xedin] noted:
{quote}
Ok, so changing this in 1.2.1 probably was a bit unfair to people, because e.g.
Titan relies on providing custom strategy option 'titan-version' and it can't
do custom strategy because there is no control of what version people install,
can we please start warning people about unrecognized options in the strategy
again instead of restricting them, because those options are sometimes very
convenient to safe meta-information.
{quote}
I'll look to see if modern versions of titan still do this - if so, we may need
to think about whether or not it's worth breaking other applications.
> Reject empty options and invalid DC names in replication configuration while
> creating or altering a keyspace.
> -
>
> Key: CASSANDRA-12681
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12681
> Project: Cassandra
> Issue Type: Improvement
> Components: Distributed Metadata
>Reporter: Nachiket Patil
>Assignee: Nachiket Patil
>Priority: Minor
> Attachments: trunkpatch.diff, v3.0patch.diff
>
>
> Add some restrictions around create / alter keyspace with
> NetworkTopologyStrategy:
> 1. Do not accept empty replication configuration (no DC options after class).
> Cassandra checks that SimpleStrategy must have replication_factor option but
> does not check that at least one DC should be present in the options for
> NetworkTopologyStrategy.
> 2. Cassandra accepts any random string as DC name replication option for
> NetworkTopologyStrategy while creating or altering keyspaces. Add a
> restriction that the options specified is valid datacenter name. Using
> incorrect value or simple mistake in typing the DC name can cause outage in
> production environment.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12681) Reject empty options and invalid DC names in replication configuration while creating or altering a keyspace.
[ https://issues.apache.org/jira/browse/CASSANDRA-12681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15517938#comment-15517938 ] sankalp kohli commented on CASSANDRA-12681: --- [~jjirsa] Can you please review this ? > Reject empty options and invalid DC names in replication configuration while > creating or altering a keyspace. > - > > Key: CASSANDRA-12681 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12681 > Project: Cassandra > Issue Type: Improvement > Components: Distributed Metadata >Reporter: Nachiket Patil >Assignee: Nachiket Patil >Priority: Minor > Attachments: trunkpatch.diff, v3.0patch.diff > > > Add some restrictions around create / alter keyspace with > NetworkTopologyStrategy: > 1. Do not accept empty replication configuration (no DC options after class). > Cassandra checks that SimpleStrategy must have replication_factor option but > does not check that at least one DC should be present in the options for > NetworkTopologyStrategy. > 2. Cassandra accepts any random string as DC name replication option for > NetworkTopologyStrategy while creating or altering keyspaces. Add a > restriction that the options specified is valid datacenter name. Using > incorrect value or simple mistake in typing the DC name can cause outage in > production environment. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12681) Reject empty options and invalid DC names in replication configuration while creating or altering a keyspace.
[ https://issues.apache.org/jira/browse/CASSANDRA-12681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15515468#comment-15515468 ] Nachiket Patil commented on CASSANDRA-12681: Agree. I think it is time to revisit some restrictions around keyspace creation. For backward compatibility's sake, I haven't removed the code in `AbstractReplicationStrategy` where `ConfigurationException` is ignored in method `createReplicationStrategy()`. And `ConfigurationException` is thrown in `validateReplicationStrategy()`. This way, Cassandra will start even if there are any keyspaces already present with incorrect replication setting but will not allow creation of new ones or altering existing ones to wrong setting. > Reject empty options and invalid DC names in replication configuration while > creating or altering a keyspace. > - > > Key: CASSANDRA-12681 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12681 > Project: Cassandra > Issue Type: Improvement > Components: Distributed Metadata >Reporter: Nachiket Patil >Assignee: Nachiket Patil >Priority: Minor > Attachments: trunkpatch.diff, v3.0patch.diff > > > Add some restrictions around create / alter keyspace with > NetworkTopologyStrategy: > 1. Do not accept empty replication configuration (no DC options after class). > Cassandra checks that SimpleStrategy must have replication_factor option but > does not check that at least one DC should be present in the options for > NetworkTopologyStrategy. > 2. Cassandra accepts any random string as DC name replication option for > NetworkTopologyStrategy while creating or altering keyspaces. Add a > restriction that the options specified is valid datacenter name. Using > incorrect value or simple mistake in typing the DC name can cause outage in > production environment. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12681) Reject empty options and invalid DC names in replication configuration while creating or altering a keyspace.
[ https://issues.apache.org/jira/browse/CASSANDRA-12681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15515172#comment-15515172 ] Jeff Jirsa commented on CASSANDRA-12681: This has been mentioned in the past (typos in KS replication settings can cause queries to fail, in particular), so it's clearly a pain point for multiple people, but we should note that this un-does the backwards-compatibility changes of CASSANDRA-4795 from 2013. At the time, it was noted that unknown options were a horrible thing to do, but also recognized that people were using it for various reasons. Maybe it IS time to reconsider CASSANDRA-4795 - it's been 3 years, hopefully people have stopped abusing the schema. > Reject empty options and invalid DC names in replication configuration while > creating or altering a keyspace. > - > > Key: CASSANDRA-12681 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12681 > Project: Cassandra > Issue Type: Improvement > Components: Distributed Metadata >Reporter: Nachiket Patil >Assignee: Nachiket Patil >Priority: Minor > Attachments: trunkpatch.diff, v3.0patch.diff > > > Add some restrictions around create / alter keyspace with > NetworkTopologyStrategy: > 1. Do not accept empty replication configuration (no DC options after class). > Cassandra checks that SimpleStrategy must have replication_factor option but > does not check that at least one DC should be present in the options for > NetworkTopologyStrategy. > 2. Cassandra accepts any random string as DC name replication option for > NetworkTopologyStrategy while creating or altering keyspaces. Add a > restriction that the options specified is valid datacenter name. Using > incorrect value or simple mistake in typing the DC name can cause outage in > production environment. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
