[jira] [Commented] (CASSANDRA-17132) Fix startup issue with internode_application_timeout_in_ms
[ https://issues.apache.org/jira/browse/CASSANDRA-17132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491213#comment-17491213 ] Ekaterina Dimitrova commented on CASSANDRA-17132: - CASSANDRA-17377 opened to fix this > Fix startup issue with internode_application_timeout_in_ms > -- > > Key: CASSANDRA-17132 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17132 > Project: Cassandra > Issue Type: Bug > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0.2, 4.1 > > > While testing my patch for CASSANDRA-17131 I found that there is a problem > with _internode_application_timeout_in_ms_ in 4.0 and trunk. > Seems to me that we can just safely remove it for now? -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17132) Fix startup issue with internode_application_timeout_in_ms
[
https://issues.apache.org/jira/browse/CASSANDRA-17132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491195#comment-17491195
]
Jeff Jirsa commented on CASSANDRA-17132:
This commit broke users upgrading from 4.0.1 to 4.0.2.
We should NOT be making breaking changes in minor versions.
We also missed the {{NEWS.txt}} entry that notifies customers of breaking
changes.
> Fix startup issue with internode_application_timeout_in_ms
> --
>
> Key: CASSANDRA-17132
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17132
> Project: Cassandra
> Issue Type: Bug
> Components: Build
>Reporter: Ekaterina Dimitrova
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 4.0.2, 4.1
>
>
> While testing my patch for CASSANDRA-17131 I found that there is a problem
> with _internode_application_timeout_in_ms_ in 4.0 and trunk.
> Seems to me that we can just safely remove it for now?
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17132) Fix startup issue with internode_application_timeout_in_ms
[ https://issues.apache.org/jira/browse/CASSANDRA-17132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17444614#comment-17444614 ] Ekaterina Dimitrova commented on CASSANDRA-17132: - Commit done: 03e83f2070..b6f61e850c cassandra-4.0 -> cassandra-4.0 ad4d2b3a26..f61d817cb5 trunk -> trunk The renaming of the two commented parameters was reverted and deferred to CASSANDRA-17141. Thank you! > Fix startup issue with internode_application_timeout_in_ms > -- > > Key: CASSANDRA-17132 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17132 > Project: Cassandra > Issue Type: Bug > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0.x, 4.x > > > While testing my patch for CASSANDRA-17131 I found that there is a problem > with _internode_application_timeout_in_ms_ in 4.0 and trunk. > Seems to me that we can just safely remove it for now? -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17132) Fix startup issue with internode_application_timeout_in_ms
[ https://issues.apache.org/jira/browse/CASSANDRA-17132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1797#comment-1797 ] Berenguer Blasi commented on CASSANDRA-17132: - Spoke on Slack that pending change will be done on commit. +1. > Fix startup issue with internode_application_timeout_in_ms > -- > > Key: CASSANDRA-17132 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17132 > Project: Cassandra > Issue Type: Bug > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0.x, 4.x > > > While testing my patch for CASSANDRA-17131 I found that there is a problem > with _internode_application_timeout_in_ms_ in 4.0 and trunk. > Seems to me that we can just safely remove it for now? -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17132) Fix startup issue with internode_application_timeout_in_ms
[ https://issues.apache.org/jira/browse/CASSANDRA-17132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17443873#comment-17443873 ] Ekaterina Dimitrova commented on CASSANDRA-17132: - CASSANDRA-17141 linked. True, I will remove those two renames from the current patch and handle the properties in the other ticket. > Fix startup issue with internode_application_timeout_in_ms > -- > > Key: CASSANDRA-17132 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17132 > Project: Cassandra > Issue Type: Bug > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0.x, 4.x > > > While testing my patch for CASSANDRA-17131 I found that there is a problem > with _internode_application_timeout_in_ms_ in 4.0 and trunk. > Seems to me that we can just safely remove it for now? -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17132) Fix startup issue with internode_application_timeout_in_ms
[ https://issues.apache.org/jira/browse/CASSANDRA-17132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17443858#comment-17443858 ] Berenguer Blasi commented on CASSANDRA-17132: - You can have a link with the right compare base as in [here|https://github.com/apache/cassandra/compare/cassandra-4.0...ekaterinadimitrova2:17132-4.0?expand=1] #justyi Ok so iiuc that name change is seen as a bug, you've opened a ticket to address that (can you link it please?) and you'll remove that from the commits in here. Is that correct? > Fix startup issue with internode_application_timeout_in_ms > -- > > Key: CASSANDRA-17132 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17132 > Project: Cassandra > Issue Type: Bug > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0.x, 4.x > > > While testing my patch for CASSANDRA-17131 I found that there is a problem > with _internode_application_timeout_in_ms_ in 4.0 and trunk. > Seems to me that we can just safely remove it for now? -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17132) Fix startup issue with internode_application_timeout_in_ms
[
https://issues.apache.org/jira/browse/CASSANDRA-17132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17443845#comment-17443845
]
Ekaterina Dimitrova commented on CASSANDRA-17132:
-
{quote}[~e.dimitrova] your '4.0 patch' link point to a compare between _trunk_
and your 4.0 PR instead of 4.0 and your 4.0 PR #justfyi
{quote}
I grabbed the link on commit but I didn't open a PR, it is just the comparison
so it requires to get the 4.0 from the drop-down menu. Works perfect with
trunk, but I had to open a PR for 4.0.
{quote} - Which rename is a breaking change in 4.0?
{{internode_socket_send_buffer_size_in_bytes}} was changed in the code long ago
and here we're only fixing the yml. it's like we're fixing a bug rather than
introducing a rename right?{quote}
The thing is that we have on one side a bug(the name not changed in
cassandra.yaml), on the other one a breaking change so it is good to have the
backward compatibility with the old name for people who upgrade, similar to
what we did with metrics. I already pulled a ticket and agreed on the details
with Benedict, Alex and Aleksey.
Thank you for the review [~bereng]
> Fix startup issue with internode_application_timeout_in_ms
> --
>
> Key: CASSANDRA-17132
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17132
> Project: Cassandra
> Issue Type: Bug
> Components: Build
>Reporter: Ekaterina Dimitrova
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 4.0.x, 4.x
>
>
> While testing my patch for CASSANDRA-17131 I found that there is a problem
> with _internode_application_timeout_in_ms_ in 4.0 and trunk.
> Seems to me that we can just safely remove it for now?
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17132) Fix startup issue with internode_application_timeout_in_ms
[
https://issues.apache.org/jira/browse/CASSANDRA-17132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17443669#comment-17443669
]
Berenguer Blasi commented on CASSANDRA-17132:
-
[~e.dimitrova] your '4.0 patch' link point to a compare between _trunk_ and
your 4.0 PR instead of 4.0 and your 4.0 PR #justfyi
Just a couple comments:
- I _think_ [~dcapwell] was on top of the bootstrap failures and there is some
umbrella ticket somewhere already?
- The dtest failures on an address already being used I concur they are
probably infra problems. I have seen than before and it sounds like a bad ccm
env cleanup imo.
- Which rename is a breaking change in 4.0?
{{internode_socket_send_buffer_size_in_bytes}} was changed in the code long ago
and here we're only fixing the yml. it's like we're fixing a bug rather than
introducing a rename right?
Otherwise lgtm.
> Fix startup issue with internode_application_timeout_in_ms
> --
>
> Key: CASSANDRA-17132
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17132
> Project: Cassandra
> Issue Type: Bug
> Components: Build
>Reporter: Ekaterina Dimitrova
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 4.0.x, 4.x
>
>
> While testing my patch for CASSANDRA-17131 I found that there is a problem
> with _internode_application_timeout_in_ms_ in 4.0 and trunk.
> Seems to me that we can just safely remove it for now?
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17132) Fix startup issue with internode_application_timeout_in_ms
[ https://issues.apache.org/jira/browse/CASSANDRA-17132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17442511#comment-17442511 ] Ekaterina Dimitrova commented on CASSANDRA-17132: - [~dcapwell] made a valid comment that the rename was breaking change in 4.0. I am pulling the rename in a separate ticket to decide on backward compatibilities, etc as I don't see a reason to delay the rest of the cleaning pending on those. CI stands, I can revert the rename on commit if the rest is fine. > Fix startup issue with internode_application_timeout_in_ms > -- > > Key: CASSANDRA-17132 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17132 > Project: Cassandra > Issue Type: Bug > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0.x, 4.x > > > While testing my patch for CASSANDRA-17131 I found that there is a problem > with _internode_application_timeout_in_ms_ in 4.0 and trunk. > Seems to me that we can just safely remove it for now? -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17132) Fix startup issue with internode_application_timeout_in_ms
[
https://issues.apache.org/jira/browse/CASSANDRA-17132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17442447#comment-17442447
]
Ekaterina Dimitrova commented on CASSANDRA-17132:
-
I reran the java 11 python no-vnodes DTests as they were failing with
"UnavailableSocketError", typical when lacking CircleCI resources but just in
case!
[This|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1188/workflows/8b8d24bc-b24e-439a-92e3-d6f4541ef9fb/jobs/7143/tests]
is the new run which confirms my theory and doesn't show any new issues except
the one failure which fix is about to be merged later today.
There are already tickets opened for - {_}test_speculative_data_request -
read_repair_test.TestSpeculativeReadRepair{_}, I opened CASSANDRA-17139 for
{_}org.apache.cassandra.distributed.test.ring.BootstrapTest{_}. There are
already tickets for the python _upgrade dtests,
testNoTreesRetainedAfterDifference, replaceAliveHost -
org.apache.cassandra.distributed.test.hostreplacement.HostReplacementTest,
utests_system_keyspace_directory_ tests
Different bootstrap tests are failing, it seems to me bootstrapping is unstable
lately. I am wondering whether not to open an umbrella ticket. What do you
think?
CompactStorage tests OOM from time to time. That seems more like CircleCI
config needs to be polished? [~benedict], [~dcapwell], anyone of you up for a
review?
> Fix startup issue with internode_application_timeout_in_ms
> --
>
> Key: CASSANDRA-17132
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17132
> Project: Cassandra
> Issue Type: Bug
> Components: Build
>Reporter: Ekaterina Dimitrova
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 4.0.x, 4.x
>
>
> While testing my patch for CASSANDRA-17131 I found that there is a problem
> with _internode_application_timeout_in_ms_ in 4.0 and trunk.
> Seems to me that we can just safely remove it for now?
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17132) Fix startup issue with internode_application_timeout_in_ms
[ https://issues.apache.org/jira/browse/CASSANDRA-17132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17442005#comment-17442005 ] Ekaterina Dimitrova commented on CASSANDRA-17132: - Follow up ticket for the docs opened - CASSANDRA-17135 > Fix startup issue with internode_application_timeout_in_ms > -- > > Key: CASSANDRA-17132 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17132 > Project: Cassandra > Issue Type: Bug > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0.x, 4.x > > > While testing my patch for CASSANDRA-17131 I found that there is a problem > with _internode_application_timeout_in_ms_ in 4.0 and trunk. > Seems to me that we can just safely remove it for now? -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17132) Fix startup issue with internode_application_timeout_in_ms
[ https://issues.apache.org/jira/browse/CASSANDRA-17132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17442001#comment-17442001 ] Ekaterina Dimitrova commented on CASSANDRA-17132: - I just realized we also don't need _otc_coalescing_enough_coalesced_messages._ It is only used to check whether it is between 0 and 128 in the _DatabaseDescriptor_ and nothing else. I removed that check and the parameter too. [4.0 patch |https://github.com/ekaterinadimitrova2/cassandra/pull/new/17132-4.0] | [J8 CI |https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1188/workflows/06afaf5b-6951-4b3d-8fbf-6ef2aef04e52] | [J11 CI |https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1188/workflows/8b8d24bc-b24e-439a-92e3-d6f4541ef9fb] [trunk patch |https://github.com/ekaterinadimitrova2/cassandra/pull/new/17132-trunk] | [J8 CI |https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1189/workflows/416dcd5e-720e-4eca-b3d5-61767906457b] | [J11 CI|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1189/workflows/40cb1de6-299d-4c6a-a162-d878d79beb67] The docs are still in transition so I will open a followup ticket to update them in ascidoc. > Fix startup issue with internode_application_timeout_in_ms > -- > > Key: CASSANDRA-17132 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17132 > Project: Cassandra > Issue Type: Bug > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0.x, 4.x > > > While testing my patch for CASSANDRA-17131 I found that there is a problem > with _internode_application_timeout_in_ms_ in 4.0 and trunk. > Seems to me that we can just safely remove it for now? -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17132) Fix startup issue with internode_application_timeout_in_ms
[ https://issues.apache.org/jira/browse/CASSANDRA-17132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17441677#comment-17441677 ] Benedict Elliott Smith commented on CASSANDRA-17132: Thanks [~e.dimitrova], agreed with all of the above. > Fix startup issue with internode_application_timeout_in_ms > -- > > Key: CASSANDRA-17132 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17132 > Project: Cassandra > Issue Type: Bug > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0.x, 4.x > > > While testing my patch for CASSANDRA-17131 I found that there is a problem > with _internode_application_timeout_in_ms_ in 4.0 and trunk. > Seems to me that we can just safely remove it for now? -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17132) Fix startup issue with internode_application_timeout_in_ms
[
https://issues.apache.org/jira/browse/CASSANDRA-17132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17441487#comment-17441487
]
Ekaterina Dimitrova commented on CASSANDRA-17132:
-
I believe we also don't need {_}otc_backlog_expiration_interval_ms,
otc_coalescing_strategy, otc_coalescing_window_us_default{_},
{_}otc_coalescing_window_us{_}. The last three are also not removed from
_Config.java_ but they are not used. Sorry [~benedict], can you confirm also
those, please? I believe those were the last ones with issues.
> Fix startup issue with internode_application_timeout_in_ms
> --
>
> Key: CASSANDRA-17132
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17132
> Project: Cassandra
> Issue Type: Bug
> Components: Build
>Reporter: Ekaterina Dimitrova
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 4.0.x, 4.x
>
>
> While testing my patch for CASSANDRA-17131 I found that there is a problem
> with _internode_application_timeout_in_ms_ in 4.0 and trunk.
> Seems to me that we can just safely remove it for now?
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17132) Fix startup issue with internode_application_timeout_in_ms
[
https://issues.apache.org/jira/browse/CASSANDRA-17132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17441482#comment-17441482
]
Ekaterina Dimitrova commented on CASSANDRA-17132:
-
I believe we also need to rename _internode_send_buff_size_in_bytes_ and
_internode_recv_buff_size_in_bytes_ to
_internode_socket_send_buffer_size_in_bytes_ and
\{_}internode_socket_recv_buffer_size_in_bytes{_}.
They were refactored again as per the messaging subsystem rewrite. CC
[~benedict] for confirmation
> Fix startup issue with internode_application_timeout_in_ms
> --
>
> Key: CASSANDRA-17132
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17132
> Project: Cassandra
> Issue Type: Bug
> Components: Build
>Reporter: Ekaterina Dimitrova
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 4.0.x, 4.x
>
>
> While testing my patch for CASSANDRA-17131 I found that there is a problem
> with _internode_application_timeout_in_ms_ in 4.0 and trunk.
> Seems to me that we can just safely remove it for now?
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17132) Fix startup issue with internode_application_timeout_in_ms
[ https://issues.apache.org/jira/browse/CASSANDRA-17132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17441363#comment-17441363 ] Ekaterina Dimitrova commented on CASSANDRA-17132: - I suspect this one was added with the idea to add some internals later but this never happened so we can probably just remove it for now from cassandra.yaml and the docs. [~benedict] , can you, please, confirm? I can submit a patch > Fix startup issue with internode_application_timeout_in_ms > -- > > Key: CASSANDRA-17132 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17132 > Project: Cassandra > Issue Type: Bug > Components: Build >Reporter: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0.x, 4.x > > > While testing my patch for CASSANDRA-17131 I found that there is a problem > with _internode_application_timeout_in_ms_ in 4.0 and trunk. > Seems to me that we can just safely remove it for now? -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
