[GitHub] blueorangutan commented on issue #2616: 4.11.1.0: Stabilization and blocker/issues fixes

[GitBox]

blueorangutan commented on issue #2616: 4.11.1.0: Stabilization and 
blocker/issues fixes
URL: https://github.com/apache/cloudstack/pull/2616#issuecomment-386180421
 
 
   Trillian test result (tid-2579)
   Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 47627 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2616-t2579-xenserver-65sp1.zip
   Smoke tests completed. 67 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on a change in pull request #2595: CLOUDSTACK-10199: Support requesting a specific IPv4 address

[GitBox]

rafaelweingartner commented on a change in pull request #2595: 
CLOUDSTACK-10199: Support requesting a specific IPv4 address
URL: https://github.com/apache/cloudstack/pull/2595#discussion_r185680530
 
 

 ##
 File path: 
engine/orchestration/src/test/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestratorTest.java
 ##
 @@ -159,4 +174,255 @@ public void testDontRemoveDhcpServiceWhenNotProvided() {
 verify(testOrchastrator._ntwkSrvcDao, 
never()).getProviderForServiceInNetwork(network.getId(), Service.Dhcp);
 verify(testOrchastrator._networksDao, 
times(1)).findById(nic.getNetworkId());
 }
+
+@Test
+public void testConfigureNicProfileBasedOnRequestedIpTestMacNull() {
+Network network = mock(Network.class);
+NicProfile requestedNicProfile = new NicProfile();
+NicProfile nicProfile = Mockito.spy(new NicProfile());
+
+configureTestConfigureNicProfileBasedOnRequestedIpTests(nicProfile, 
0l, false, IPAddressVO.State.Free, "192.168.100.1", "255.255.255.0", 
"00-88-14-4D-4C-FB",
+requestedNicProfile, null, "192.168.100.150");
+
+
testOrchastrator.configureNicProfileBasedOnRequestedIp(requestedNicProfile, 
nicProfile, network);
+
+verifyAndAssert("192.168.100.150", "192.168.100.1", "255.255.255.0", 
nicProfile, 1, 1);
+}
+
+@Test
+public void 
testConfigureNicProfileBasedOnRequestedIpTestNicProfileMacNotNull() {
+Network network = mock(Network.class);
+NicProfile requestedNicProfile = new NicProfile();
+NicProfile nicProfile = Mockito.spy(new NicProfile());
+
+configureTestConfigureNicProfileBasedOnRequestedIpTests(nicProfile, 
0l, false, IPAddressVO.State.Free, "192.168.100.1", "255.255.255.0", 
"00-88-14-4D-4C-FB",
+requestedNicProfile, "00-88-14-4D-4C-FB", "192.168.100.150");
+
+
testOrchastrator.configureNicProfileBasedOnRequestedIp(requestedNicProfile, 
nicProfile, network);
+
+verifyAndAssert("192.168.100.150", "192.168.100.1", "255.255.255.0", 
nicProfile, 1, 0);
+}
+
+@Test
+public void testConfigureNicProfileBasedOnRequestedIpTestRequestedIpNull() 
{
+testConfigureNicProfileBasedOnRequestedIpTestRequestedIp(null, "", 
false);
+}
+
+@Test
+public void 
testConfigureNicProfileBasedOnRequestedIpTestRequestedIpIsBlank() {
+testConfigureNicProfileBasedOnRequestedIpTestRequestedIp("", "The 
requested [IPv4 address=''] is not a valid IP address", true);
+}
+
+@Test
+public void 
testConfigureNicProfileBasedOnRequestedIpTestRequestedIpIsNotValid() {
+testConfigureNicProfileBasedOnRequestedIpTestRequestedIp("123", "The 
requested [IPv4 address='123'] is not a valid IP address", true);
+}
+
+private void 
testConfigureNicProfileBasedOnRequestedIpTestRequestedIp(String 
requestedIpv4Address, String exceptionAssert, boolean expectException) {
+Network network = mock(Network.class);
+NicProfile requestedNicProfile = new NicProfile();
+NicProfile nicProfile = Mockito.spy(new NicProfile());
+
+configureTestConfigureNicProfileBasedOnRequestedIpTests(nicProfile, 
0l, false, IPAddressVO.State.Free, "192.168.100.1", "255.255.255.0", 
"00-88-14-4D-4C-FB",
+requestedNicProfile, null, requestedIpv4Address);
+try {
+
testOrchastrator.configureNicProfileBasedOnRequestedIp(requestedNicProfile, 
nicProfile, network);
+} catch (InvalidParameterValueException e) {
+assertEquals(exceptionAssert, e.getMessage());
 
 Review comment:
   why not use the `@Test` with the `expected` parameter?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on a change in pull request #2595: CLOUDSTACK-10199: Support requesting a specific IPv4 address

[GitBox]

rafaelweingartner commented on a change in pull request #2595: 
CLOUDSTACK-10199: Support requesting a specific IPv4 address
URL: https://github.com/apache/cloudstack/pull/2595#discussion_r185681019
 
 

 ##
 File path: engine/schema/src/main/java/com/cloud/dc/dao/VlanDaoImpl.java
 ##
 @@ -82,6 +83,24 @@ public VlanVO findByZoneAndVlanId(long zoneId, String 
vlanId) {
 return findOneBy(sc);
 }
 
+/**
+ * Returns a vlan by the network id and if the given IPv4 is in the 
network IP range.
+ */
+@Override
+public VlanVO findByNetworkIdAndIpv4Range(long networkId, String 
ipv4Address) {
+List vlanVoList = listVlansByNetworkId(networkId);
+for (VlanVO vlan : vlanVoList) {
+String ipRange = vlan.getIpRange();
+String[] ipRangeParts = ipRange.split("-");
+String startIP = ipRangeParts[0];
+String endIP = ipRangeParts[1];
+if (NetUtils.isIpInRange(ipv4Address, startIP, endIP)) {
 
 Review comment:
   What about using something similar to `isIp6InNetwork`?
   I also get a feeling that this method you implemented is doing the same as 
`isIpWithInCidrRange`


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on a change in pull request #2595: CLOUDSTACK-10199: Support requesting a specific IPv4 address

[GitBox]

rafaelweingartner commented on a change in pull request #2595: 
CLOUDSTACK-10199: Support requesting a specific IPv4 address
URL: https://github.com/apache/cloudstack/pull/2595#discussion_r185680460
 
 

 ##
 File path: 
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
 ##
 @@ -883,6 +885,78 @@ public void saveExtraDhcpOptions(final String 
networkUuid, final Long nicId, fin
 return new Pair(vmNic, Integer.valueOf(deviceId));
 }
 
+/**
+ * If the requested IPv4 address from the NicProfile was configured then 
it configures the IPv4 address, Netmask and Gateway to deploy the VM with the 
requested IP.
+ */
+protected void configureNicProfileBasedOnRequestedIp(NicProfile 
requestedNicProfile, NicProfile nicProfile, Network network) {
+if (requestedNicProfile == null) {
+return;
+}
+String requestedIpv4Address = requestedNicProfile.getRequestedIPv4();
+if (requestedIpv4Address == null) {
+return;
+}
+if (!NetUtils.isValidIp4(requestedIpv4Address)) {
+throw new InvalidParameterValueException(String.format("The 
requested [IPv4 address='%s'] is not a valid IP address", 
requestedIpv4Address));
+}
+
+VlanVO vlanVo = _vlanDao.findByNetworkIdAndIpv4Range(network.getId(), 
requestedIpv4Address);
+if (vlanVo == null) {
+throw new CloudRuntimeException(String.format("Trying to configure 
a Nic with the requested [IPv4='%s'] but cannot find a Vlan for the [network 
id='%s']",
+requestedIpv4Address, network.getId()));
+}
+
+String ipv4Gateway = vlanVo.getVlanGateway();
+String ipv4Netmask = vlanVo.getVlanNetmask();
+
+if (!NetUtils.isValidIp4(ipv4Gateway)) {
+throw new CloudRuntimeException(String.format("The 
[IPv4Gateway='%s'] from [VlanId='%s'] is not valid", ipv4Gateway, 
vlanVo.getId()));
+}
+if (!NetUtils.isValidIp4Netmask(ipv4Netmask)) {
+throw new CloudRuntimeException(String.format("The 
[IPv4Netmask='%s'] from [VlanId='%s'] is not valid", ipv4Netmask, 
vlanVo.getId()));
+}
+
+acquireLockAndCheckIfIpv4IsFree(network, requestedIpv4Address);
+
+nicProfile.setIPv4Address(requestedIpv4Address);
+nicProfile.setIPv4Gateway(ipv4Gateway);
+nicProfile.setIPv4Netmask(ipv4Netmask);
+
+if (nicProfile.getMacAddress() == null) {
+try {
+String macAddress = 
_networkModel.getNextAvailableMacAddressInNetwork(network.getId());
+nicProfile.setMacAddress(macAddress);
+} catch (InsufficientAddressCapacityException e) {
+throw new CloudRuntimeException(String.format("Cannot get next 
available mac address in [network id='%s']", network.getId()), e);
+}
+}
+}
+
+/**
+ *  Acquires lock of in table "user_ip_address" and checks if the 
requested IPv4 address is Free.
+ */
+protected void acquireLockAndCheckIfIpv4IsFree(Network network, String 
requestedIpv4Address) {
 
 Review comment:
   These exceptions that you throw here, I think it might be better to throw an 
`InvalidParameterValueException` instead. These exception will happen when the 
user enters an "invalid/already used" IP, right?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on a change in pull request #2595: CLOUDSTACK-10199: Support requesting a specific IPv4 address

[GitBox]

rafaelweingartner commented on a change in pull request #2595: 
CLOUDSTACK-10199: Support requesting a specific IPv4 address
URL: https://github.com/apache/cloudstack/pull/2595#discussion_r185680248
 
 

 ##
 File path: 
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
 ##
 @@ -883,6 +885,78 @@ public void saveExtraDhcpOptions(final String 
networkUuid, final Long nicId, fin
 return new Pair(vmNic, Integer.valueOf(deviceId));
 }
 
+/**
+ * If the requested IPv4 address from the NicProfile was configured then 
it configures the IPv4 address, Netmask and Gateway to deploy the VM with the 
requested IP.
+ */
+protected void configureNicProfileBasedOnRequestedIp(NicProfile 
requestedNicProfile, NicProfile nicProfile, Network network) {
+if (requestedNicProfile == null) {
+return;
+}
+String requestedIpv4Address = requestedNicProfile.getRequestedIPv4();
+if (requestedIpv4Address == null) {
+return;
+}
+if (!NetUtils.isValidIp4(requestedIpv4Address)) {
+throw new InvalidParameterValueException(String.format("The 
requested [IPv4 address='%s'] is not a valid IP address", 
requestedIpv4Address));
+}
+
+VlanVO vlanVo = _vlanDao.findByNetworkIdAndIpv4Range(network.getId(), 
requestedIpv4Address);
+if (vlanVo == null) {
+throw new CloudRuntimeException(String.format("Trying to configure 
a Nic with the requested [IPv4='%s'] but cannot find a Vlan for the [network 
id='%s']",
+requestedIpv4Address, network.getId()));
+}
+
+String ipv4Gateway = vlanVo.getVlanGateway();
+String ipv4Netmask = vlanVo.getVlanNetmask();
+
+if (!NetUtils.isValidIp4(ipv4Gateway)) {
+throw new CloudRuntimeException(String.format("The 
[IPv4Gateway='%s'] from [VlanId='%s'] is not valid", ipv4Gateway, 
vlanVo.getId()));
+}
+if (!NetUtils.isValidIp4Netmask(ipv4Netmask)) {
+throw new CloudRuntimeException(String.format("The 
[IPv4Netmask='%s'] from [VlanId='%s'] is not valid", ipv4Netmask, 
vlanVo.getId()));
+}
+
+acquireLockAndCheckIfIpv4IsFree(network, requestedIpv4Address);
+
+nicProfile.setIPv4Address(requestedIpv4Address);
+nicProfile.setIPv4Gateway(ipv4Gateway);
+nicProfile.setIPv4Netmask(ipv4Netmask);
+
+if (nicProfile.getMacAddress() == null) {
+try {
+String macAddress = 
_networkModel.getNextAvailableMacAddressInNetwork(network.getId());
+nicProfile.setMacAddress(macAddress);
+} catch (InsufficientAddressCapacityException e) {
+throw new CloudRuntimeException(String.format("Cannot get next 
available mac address in [network id='%s']", network.getId()), e);
+}
+}
+}
+
+/**
+ *  Acquires lock of in table "user_ip_address" and checks if the 
requested IPv4 address is Free.
+ */
+protected void acquireLockAndCheckIfIpv4IsFree(Network network, String 
requestedIpv4Address) {
+IPAddressVO ipVO = 
_ipAddressDao.findByIpAndSourceNetworkId(network.getId(), requestedIpv4Address);
+if (ipVO == null) {
+throw new CloudRuntimeException(String.format("Cannot find 
IPAddressVO for guest [IPv4 address='%s'] and [network id='%s']", 
requestedIpv4Address, network.getId()));
+}
+try {
+IPAddressVO lockedIpVO = 
_ipAddressDao.acquireInLockTable(ipVO.getId());
+if (lockedIpVO == null) {
+_ipAddressDao.releaseFromLockTable(ipVO.getId());
+}
+if (lockedIpVO.getState() != IPAddressVO.State.Free) {
+String ipState = lockedIpVO.getState().toString();
+_ipAddressDao.releaseFromLockTable(lockedIpVO.getId());
+throw new CloudRuntimeException(String.format("Cannot acquire 
guest [IPv4 address='%s']; The Ip address is in [state='%s']", 
requestedIpv4Address, ipState));
+}
+lockedIpVO.setState(IPAddressVO.State.Allocated);
+_ipAddressDao.update(lockedIpVO.getId(), lockedIpVO);
+} catch (Exception e) {
+_ipAddressDao.releaseFromLockTable(ipVO.getId());
 
 Review comment:
   Danger zone  here! Please do not hide exceptions.
   
   BTW, do you need to catch pokemons here?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on a change in pull request #2595: CLOUDSTACK-10199: Support requesting a specific IPv4 address

[GitBox]

rafaelweingartner commented on a change in pull request #2595: 
CLOUDSTACK-10199: Support requesting a specific IPv4 address
URL: https://github.com/apache/cloudstack/pull/2595#discussion_r185680088
 
 

 ##
 File path: 
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
 ##
 @@ -883,6 +885,78 @@ public void saveExtraDhcpOptions(final String 
networkUuid, final Long nicId, fin
 return new Pair(vmNic, Integer.valueOf(deviceId));
 }
 
+/**
+ * If the requested IPv4 address from the NicProfile was configured then 
it configures the IPv4 address, Netmask and Gateway to deploy the VM with the 
requested IP.
+ */
+protected void configureNicProfileBasedOnRequestedIp(NicProfile 
requestedNicProfile, NicProfile nicProfile, Network network) {
+if (requestedNicProfile == null) {
+return;
+}
+String requestedIpv4Address = requestedNicProfile.getRequestedIPv4();
+if (requestedIpv4Address == null) {
+return;
+}
+if (!NetUtils.isValidIp4(requestedIpv4Address)) {
+throw new InvalidParameterValueException(String.format("The 
requested [IPv4 address='%s'] is not a valid IP address", 
requestedIpv4Address));
+}
+
+VlanVO vlanVo = _vlanDao.findByNetworkIdAndIpv4Range(network.getId(), 
requestedIpv4Address);
 
 Review comment:
   This name `findByNetworkIdAndIpv4Range` does not seem to be adequate. It 
seems that you are going to look for a `VlanVo` by ipv4 range, which is not the 
case. You are looking for a `VlanVo` of a network that "supports" the specified 
IPv4. Therefore, something like `findVlanByNetworkIdAndIpv4` seems better.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] khos2ow opened a new issue #2620: Why do we package final artifacts with developer profile?

[GitBox]

khos2ow opened a new issue #2620: Why do we package final artifacts with 
developer profile?
URL: https://github.com/apache/cloudstack/issues/2620
 
 
   This technically is not an issue, but I was just got curios why we package 
our final artifacts (both rpm and deb) with `developer` maven profile. in:
   
   - `debian/rules#L16`
   - `packaging/centos63/cloud.spec#L209-223`
   - `packaging/centos7/cloud.spec#L192`
   
   It doesn't make sense since these are going to be installed in `prod` or 
alike, and most probably won't be any `deploydb` and `db.properties.override`.
   
   I believe we should remove these.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] GabrielBrascher commented on issue #2595: CLOUDSTACK-10199: Support requesting a specific IPv4 address

[GitBox]

GabrielBrascher commented on issue #2595: CLOUDSTACK-10199: Support requesting 
a specific IPv4 address
URL: https://github.com/apache/cloudstack/pull/2595#issuecomment-385842603
 
 
   @rhtyd I am using basic network and KVM. It might be a problem only on the 
basic network then.
   I tested with cloudmonkey, using the following command:
   `deploy virtualmachine zoneid= serviceofferingid= templateid= 
startvm=true ipaddress= name= displayname=<“name”>`


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] khos2ow commented on issue #2581: Latest Docker container is broken

[GitBox]

khos2ow commented on issue #2581: Latest Docker container is broken
URL: https://github.com/apache/cloudstack/issues/2581#issuecomment-386095362
 
 
   I'll take a look.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2382: CLOUDSTACK-4045 IP address acquired with associateIpAddress is marked as source NAT

[GitBox]

blueorangutan commented on issue #2382: CLOUDSTACK-4045 IP address acquired 
with associateIpAddress is marked as source NAT
URL: https://github.com/apache/cloudstack/pull/2382#issuecomment-386094830
 
 
   Trillian test result (tid-2575)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 26440 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2382-t2575-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_certauthority_root.py
   Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 63 look OK, 4 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_secured_vm_migration | `Error` | 37.52 | test_vm_life_cycle.py
   test_02_not_secured_vm_migration | `Error` | 38.54 | test_vm_life_cycle.py
   test_03_secured_to_nonsecured_vm_migration | `Error` | 38.55 | 
test_vm_life_cycle.py
   test_04_nonsecured_to_secured_vm_migration | `Error` | 38.53 | 
test_vm_life_cycle.py
   test_11_migrate_volume_and_change_offering | `Error` | 129.43 | 
test_volumes.py
   test_01_redundant_vpc_site2site_vpn | `Failure` | 375.30 | test_vpc_vpn.py
   test_01_vpc_site2site_vpn | `Failure` | 155.24 | test_vpc_vpn.py
   test_hostha_enable_ha_when_host_in_maintenance | `Error` | 4.69 | 
test_hostha_kvm.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2616: 4.11.1.0: Stabilization and blocker/issues fixes

[GitBox]

blueorangutan commented on issue #2616: 4.11.1.0: Stabilization and 
blocker/issues fixes
URL: https://github.com/apache/cloudstack/pull/2616#issuecomment-386087674
 
 
   Trillian test result (tid-2578)
   Environment: xcpng74 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 24113 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2616-t2578-xcpng74.zip
   Intermitten failure detected: /marvin/tests/smoke/test_deploy_vm_iso.py
   Intermitten failure detected: /marvin/tests/smoke/test_primary_storage.py
   Smoke tests completed. 66 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_primary_storage_iscsi | `Error` | 3.10 | test_primary_storage.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2616: 4.11.1.0: Stabilization and blocker/issues fixes

[GitBox]

blueorangutan commented on issue #2616: 4.11.1.0: Stabilization and 
blocker/issues fixes
URL: https://github.com/apache/cloudstack/pull/2616#issuecomment-386075457
 
 
   Trillian test result (tid-2577)
   Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 21450 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2616-t2577-xenserver-71.zip
   Intermitten failure detected: /marvin/tests/smoke/test_scale_vm.py
   Smoke tests completed. 66 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_scale_vm | `Error` | 14.39 | test_scale_vm.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2473: CLOUDSTACK-10309 Add option on if to VM HA power-on a OOB-shut-off-VM

[GitBox]

blueorangutan commented on issue #2473: CLOUDSTACK-10309 Add option on if to VM 
HA power-on a OOB-shut-off-VM
URL: https://github.com/apache/cloudstack/pull/2473#issuecomment-386040632
 
 
   Trillian test result (tid-2574)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 21986 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2473-t2574-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_public_ip_range.py
   Intermitten failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
   Intermitten failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
   Intermitten failure detected: /marvin/tests/smoke/test_router_dns.py
   Intermitten failure detected: /marvin/tests/smoke/test_router_dnsservice.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_routers_iptables_default_policy.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers.py
   Intermitten failure detected: /marvin/tests/smoke/test_secondary_storage.py
   Intermitten failure detected: /marvin/tests/smoke/test_service_offerings.py
   Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
   Intermitten failure detected: /marvin/tests/smoke/test_ssvm.py
   Intermitten failure detected: /marvin/tests/smoke/test_templates.py
   Intermitten failure detected: /marvin/tests/smoke/test_usage.py
   Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermitten failure detected: /marvin/tests/smoke/test_vm_snapshots.py
   Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 45 look OK, 22 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_04_rvpc_privategw_static_routes | `Error` | 474.81 | 
test_privategw_acl.py
   ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | 
test_reset_vm_on_reboot.py
   ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | 
test_router_dhcphosts.py
   ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | 
test_router_dhcphosts.py
   ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | 
test_router_dns.py
   ContextSuite context=TestVmSnapshot>:setup | `Error` | 0.05 | 
test_vm_snapshots.py
   ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | 
test_router_dnsservice.py
   ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | 
test_routers_iptables_default_policy.py
   ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | 
test_routers_iptables_default_policy.py
   test_01_isolate_network_FW_PF_default_routes_egress_true | `Error` | 0.12 | 
test_routers_network_ops.py
   test_02_isolate_network_FW_PF_default_routes_egress_false | `Error` | 0.12 | 
test_routers_network_ops.py
   ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 1.26 | 
test_routers_network_ops.py
   ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | 
test_routers.py
   test_01_sys_vm_start | `Failure` | 0.08 | test_secondary_storage.py
   test_02_sys_template_ready | `Failure` | 0.06 | test_secondary_storage.py
   ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | 
test_service_offerings.py
   ContextSuite context=TestServiceOfferings>:setup | `Error` | 0.13 | 
test_service_offerings.py
   ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | 
test_snapshots.py
   test_01_list_sec_storage_vm | `Failure` | 0.03 | test_ssvm.py
   test_02_list_cpvm_vm | `Failure` | 0.03 | test_ssvm.py
   test_03_ssvm_internals | `Failure` | 0.03 | test_ssvm.py
   test_04_cpvm_internals | `Failure` | 0.03 | test_ssvm.py
   test_05_stop_ssvm | `Failure` | 0.02 | test_ssvm.py
   test_06_stop_cpvm | `Failure` | 0.02 | test_ssvm.py
   test_07_reboot_ssvm | `Failure` | 0.02 | test_ssvm.py
   test_08_reboot_cpvm | `Failure` | 0.03 | test_ssvm.py
   test_09_destroy_ssvm | `Failure` | 0.03 | test_ssvm.py
   test_10_destroy_cpvm | `Failure` | 0.02 | test_ssvm.py
   test_02_create_template_with_checksum_sha1 | `Error` | 65.32 | 
test_templates.py
   test_03_create_template_with_checksum_sha256 | `Error` | 65.34 | 
test_templates.py
   test_04_create_template_with_checksum_md5 | `Error` | 65.34 | 
test_templates.py
   test_05_create_template_with_no_checksum | `Error` | 65.34 | 
test_templates.py
   

[GitHub] khos2ow commented on issue #2561: cloud-early-config detects unknown hypervisor type "xen-domU"

[GitBox]

khos2ow commented on issue #2561: cloud-early-config detects unknown hypervisor 
type "xen-domU"
URL: https://github.com/apache/cloudstack/issues/2561#issuecomment-386016513
 
 
   Thanks @rhtyd about the fix, but I believe it's not complete as I mentioned 
in [#2616 
(comment)](https://github.com/apache/cloudstack/pull/2616#discussion_r185517562).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] khos2ow commented on a change in pull request #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer

[GitBox]

khos2ow commented on a change in pull request #2465: CLOUDSTACK-10232: 
SystemVMs and VR to run as HVM on XenServer
URL: https://github.com/apache/cloudstack/pull/2465#discussion_r185519409
 
 

 ##
 File path: systemvm/debian/opt/cloud/bin/setup/cloud-early-config
 ##
 @@ -64,10 +71,17 @@ config_guest() {
 
 get_boot_params() {
   case $HYPERVISOR in
- xen-domU|xen-hvm)
+ xen-pv)
   cat /proc/cmdline > $CMDLINE
   sed -i "s/%/ /g" $CMDLINE
   ;;
+ xen-hvm)
+  if [ ! -f /usr/sbin/xenstore-read ]; then
+log_it "ERROR: xentools not installed, cannot found xenstore-read" 
&& exit 5
+  fi
+  /usr/sbin/xenstore-read vm-data/cloudstack/init > 
/var/cache/cloud/cmdline
 
 Review comment:
   That's strange, I really don't know what's going on. I just checked dozens 
of random VMs, on various Xenserver version (7.x.x+ though) and all of them had 
`xenstore-read` in both places! I guess using `/usr/bin` would be safer. or 
even check both places then log an error?
   BTW I wrote a comment on your PR as well.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] khos2ow commented on a change in pull request #2616: 4.11.1.0: Stabilization and blocker/issues fixes

[GitBox]

khos2ow commented on a change in pull request #2616: 4.11.1.0: Stabilization 
and blocker/issues fixes
URL: https://github.com/apache/cloudstack/pull/2616#discussion_r185515379
 
 

 ##
 File path: systemvm/debian/opt/cloud/bin/setup/cloud-early-config
 ##
 @@ -71,16 +71,16 @@ config_guest() {
 
 get_boot_params() {
   case $HYPERVISOR in
- xen-pv)
+ xen-pv|xen-domU)
 
 Review comment:
   @rhtyd you should not add `xen-domU` to this case, because in fully patched 
Xenserver one HVM instance might be reported as `xen-domU` which in reality is 
should be `xen-hvm`. Basically this is the output of `virt-what`.
   I'll put another comment to describe further.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] khos2ow commented on a change in pull request #2616: 4.11.1.0: Stabilization and blocker/issues fixes

[GitBox]

khos2ow commented on a change in pull request #2616: 4.11.1.0: Stabilization 
and blocker/issues fixes
URL: https://github.com/apache/cloudstack/pull/2616#discussion_r185517562
 
 

 ##
 File path: systemvm/debian/opt/cloud/bin/setup/cloud-early-config
 ##
 @@ -71,16 +71,16 @@ config_guest() {
 
 get_boot_params() {
   case $HYPERVISOR in
- xen-pv)
+ xen-pv|xen-domU)
 
 Review comment:
   in `hypervisor()` function above, line 44-52 should be moved to the very 
beginning of the function as the very first step to detect type of Xen, then 
let `virt-what` does its job. The reason is some HVM instances on Xen still 
being reported as `xen-domU` (which most probably they are pvhvm or something). 
But detecting if an instance is on PV or HVM through `dmesg` is accurate.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2616: 4.11.1.0: Stabilization and blocker/issues fixes

[GitBox]

blueorangutan commented on issue #2616: 4.11.1.0: Stabilization and 
blocker/issues fixes
URL: https://github.com/apache/cloudstack/pull/2616#issuecomment-385990102
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1996


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on a change in pull request #2616: 4.11.1.0: Stabilization and blocker/issues fixes

[GitBox]

rafaelweingartner commented on a change in pull request #2616: 4.11.1.0: 
Stabilization and blocker/issues fixes
URL: https://github.com/apache/cloudstack/pull/2616#discussion_r185504916
 
 

 ##
 File path: systemvm/debian/opt/cloud/bin/setup/patchsystemvm.sh
 ##
 @@ -37,6 +37,8 @@ patch_systemvm() {
   echo "Restored keystore file and certs using backup" >> $logfile
fi
rm -fr $backupfolder
+   # Import global cacerts into 'cloud' service's keystore
+   keytool -importkeystore -srckeystore /etc/ssl/certs/java/cacerts 
-destkeystore /usr/local/cloud/systemvm/certs/realhostip.keystore -srcstorepass 
changeit -deststorepass vmops.com -noprompt || true
 
 Review comment:
   Why importing the Java default cacerts? I mean, why not using it directly?
   I see that you are already modifying it to add the Let's encrypt public key.
   
   Also, why do you need the `|| true` at the end?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on a change in pull request #2616: 4.11.1.0: Stabilization and blocker/issues fixes

[GitBox]

rafaelweingartner commented on a change in pull request #2616: 4.11.1.0: 
Stabilization and blocker/issues fixes
URL: https://github.com/apache/cloudstack/pull/2616#discussion_r185503526
 
 

 ##
 File path: 
tools/appliance/systemvmtemplate/scripts/configure_systemvm_services.sh
 ##
 @@ -31,6 +31,16 @@ function configure_apache2() {
sed -i 's/SSLProtocol .*$/SSLProtocol TLSv1.2/g' 
/etc/apache2/mods-available/ssl.conf
 }
 
+function configure_cacerts() {
+  CDIR=$(pwd)
+  cd /tmp
+  # Add LetsEncrypt ca-cert
+  wget https://letsencrypt.org/certs/lets-encrypt-x3-cross-signed.der
+  keytool -trustcacerts -keystore /etc/ssl/certs/java/cacerts -storepass 
changeit -noprompt -importcert -alias letsencryptauthorityx3cross -file 
lets-encrypt-x3-cross-signed.der || true
 
 Review comment:
   do you need the `|| true` at the end of this command ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack-docs-rn] branch master updated (4bef109 -> 4378e5c)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-docs-rn.git.


from 4bef109  Add upgrade remark for 4.10.0.0 users.
 add b96d833  update rn-docs for 4.11.1.0 systemvmtemplate configuration 
and url
 new 4378e5c  conf: bump master version to 4.12.0.0

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 source/about.rst |  9 +
 source/conf.py   |  4 ++--
 source/global.rst| 10 +-
 source/index.rst |  1 +
 source/upgrade/_sysvm_templates.rst  | 20 +---
 .../upgrade/{upgrade-4.10.rst => upgrade-4.11.rst}   | 11 +++
 6 files changed, 25 insertions(+), 30 deletions(-)
 copy source/upgrade/{upgrade-4.10.rst => upgrade-4.11.rst} (97%)

-- 
To stop receiving notification emails like this one, please contact
ro...@apache.org.

[cloudstack-docs-rn] 01/01: conf: bump master version to 4.12.0.0

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-docs-rn.git

commit 4378e5c6bc6c829df02cba154546cfb4e431d449
Author: Rohit Yadav 
AuthorDate: Wed May 2 19:31:06 2018 +0530

conf: bump master version to 4.12.0.0

Signed-off-by: Rohit Yadav 
---
 source/conf.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/source/conf.py b/source/conf.py
index b09a0d9..bd2b8eb 100644
--- a/source/conf.py
+++ b/source/conf.py
@@ -74,9 +74,9 @@ copyright = u'2018, Apache CloudStack'
 # built documents.
 #
 # The short X.Y version.
-version = '4.11'
+version = '4.12'
 # The full version, including alpha/beta/rc tags.
-release = '4.11.1.0'
+release = '4.12.0.0'
 
 # The language for content autogenerated by Sphinx. Refer to documentation
 # for a list of supported languages.

-- 
To stop receiving notification emails like this one, please contact
ro...@apache.org.

[cloudstack-docs-rn] branch 4.11 updated: update rn-docs for 4.11.1.0 systemvmtemplate configuration and url

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch 4.11
in repository https://gitbox.apache.org/repos/asf/cloudstack-docs-rn.git


The following commit(s) were added to refs/heads/4.11 by this push:
 new b96d833  update rn-docs for 4.11.1.0 systemvmtemplate configuration 
and url
b96d833 is described below

commit b96d833c5790b4fb457b91b7908eaeaea3ef2627
Author: Rohit Yadav 
AuthorDate: Wed May 2 19:30:06 2018 +0530

update rn-docs for 4.11.1.0 systemvmtemplate configuration and url

Signed-off-by: Rohit Yadav 
---
 source/about.rst|   9 +-
 source/conf.py  |   2 +-
 source/global.rst   |  10 +-
 source/index.rst|   1 +
 source/upgrade/_sysvm_templates.rst |  20 +-
 source/upgrade/upgrade-4.11.rst | 419 
 6 files changed, 440 insertions(+), 21 deletions(-)

diff --git a/source/about.rst b/source/about.rst
index 0b59de7..e496b89 100644
--- a/source/about.rst
+++ b/source/about.rst
@@ -12,7 +12,7 @@
KIND, either express or implied.  See the License for the
specific language governing permissions and limitations
under the License.
-   
+
 
 What's New in |version|
 ===
@@ -24,7 +24,8 @@ releases that was worked on for 8 months.
 A LOT changed in this release, so this is not a complete list, but here is a
 quick summary of some of the changes:
 
-* Support for XenServer 7.1 and 7.2, and improved support for VMware 6.5.
+* Support for XenServer 7.1, 7.2, 7.3 and 7.4, and support for XCP-ng 7.4.
+* Improved support for VMware 6.5.
 * Host-HA framework and HA-provider for KVM hosts with and NFS as primary 
storage, and a new background polling task manager.
 * Secure agents communication: new certificate authority framework and a 
default built-in root CA provider.
 * New network type - L2.
@@ -62,8 +63,8 @@ quick summary of some of the changes:
 * Improved support for Java 8 for building artifacts/modules, packaging, and in
   the systemvm template.
 * A faster console proxy startup and service availability.
-* A new Debian 9 based systemvm template that patches systemvm without 
requiring
-  reboot.
+* A new Debian 9 based smaller systemvm template that patches systemvm without
+  requiring reboot.
 * Several optimizations and improvements to the virtual router including better
   support for redundant virtual routers and strongswan provided s2s and remote
   access vpn.
diff --git a/source/conf.py b/source/conf.py
index 1065f60..b09a0d9 100644
--- a/source/conf.py
+++ b/source/conf.py
@@ -76,7 +76,7 @@ copyright = u'2018, Apache CloudStack'
 # The short X.Y version.
 version = '4.11'
 # The full version, including alpha/beta/rc tags.
-release = '4.11.0.0'
+release = '4.11.1.0'
 
 # The language for content autogenerated by Sphinx. Refer to documentation
 # for a list of supported languages.
diff --git a/source/global.rst b/source/global.rst
index 55a36ad..c37e617 100644
--- a/source/global.rst
+++ b/source/global.rst
@@ -21,11 +21,11 @@
 .. _CloudStack Apidocs: http://cloudstack.apache.org/docs/api/
 
 .. Latest version systemvm template URL
-.. |sysvm64-url-xen|replace:: 
http://download.cloudstack.org/systemvm/4.11/systemvmtemplate-4.11.0-xen.vhd.bz2
-.. |sysvm64-url-kvm|replace:: 
http://download.cloudstack.org/systemvm/4.11/systemvmtemplate-4.11.0-kvm.qcow2.bz2
-.. |sysvm64-url-vmware| replace:: 
http://download.cloudstack.org/systemvm/4.11/systemvmtemplate-4.11.0-vmware.ova
-.. |sysvm64-url-hyperv| replace:: 
http://download.cloudstack.org/systemvm/4.11/systemvmtemplate-4.11.0-hyperv.vhd.zip
-.. |sysvm64-url-ovm|replace:: 
http://download.cloudstack.org/systemvm/4.11/systemvmtemplate-4.11.0-ovm.raw.bz2
+.. |sysvm64-url-xen|replace:: 
http://download.cloudstack.org/systemvm/4.11/systemvmtemplate-4.11.1-xen.vhd.bz2
+.. |sysvm64-url-kvm|replace:: 
http://download.cloudstack.org/systemvm/4.11/systemvmtemplate-4.11.1-kvm.qcow2.bz2
+.. |sysvm64-url-vmware| replace:: 
http://download.cloudstack.org/systemvm/4.11/systemvmtemplate-4.11.1-vmware.ova
+.. |sysvm64-url-hyperv| replace:: 
http://download.cloudstack.org/systemvm/4.11/systemvmtemplate-4.11.1-hyperv.vhd.zip
+.. |sysvm64-url-ovm|replace:: 
http://download.cloudstack.org/systemvm/4.11/systemvmtemplate-4.11.1-ovm.raw.bz2
 
 .. Version specific: 4.5 systemvm template URL
 .. |acs45-sysvm64-url-xen|replace:: 
http://cloudstack.apt-get.eu/systemvm/4.5/systemvm64template-4.5-xen.vhd.bz2
diff --git a/source/index.rst b/source/index.rst
index ef487a9..0da55a2 100644
--- a/source/index.rst
+++ b/source/index.rst
@@ -67,6 +67,7 @@ Contents:
 .. toctree::
:maxdepth: 1
 
+   upgrade/upgrade-4.11
upgrade/upgrade-4.10
upgrade/upgrade-4.9
upgrade/upgrade-4.8
diff --git a/source/upgrade/_sysvm_templates.rst 
b/source/upgrade/_sysvm_templates.rst
index f279165..45bee8c 100644
--- 

[GitHub] blueorangutan commented on issue #2508: CLOUDSTACK-9114: Reduce VR downtime during network restart

[GitBox]

blueorangutan commented on issue #2508: CLOUDSTACK-9114: Reduce VR downtime 
during network restart
URL: https://github.com/apache/cloudstack/pull/2508#issuecomment-385799975
 
 
   Trillian test result (tid-2561)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 41070 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2508-t2561-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 63 look OK, 4 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_03_vpc_privategw_restart_vpc_cleanup | `Error` | 238.99 | 
test_privategw_acl.py
   test_02_not_secured_vm_migration | `Error` | 0.12 | test_vm_life_cycle.py
   test_03_secured_to_nonsecured_vm_migration | `Error` | 0.09 | 
test_vm_life_cycle.py
   test_04_nonsecured_to_secured_vm_migration | `Error` | 0.10 | 
test_vm_life_cycle.py
   test_04_rvpc_network_garbage_collector_nics | `Failure` | 289.87 | 
test_vpc_redundant.py
   test_hostha_enable_ha_when_host_in_maintenance | `Error` | 1.43 | 
test_hostha_kvm.py
   test_hostha_kvm_host_degraded | `Error` | 785.29 | test_hostha_kvm.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2508: CLOUDSTACK-9114: Reduce VR downtime during network restart

[GitBox]

blueorangutan commented on issue #2508: CLOUDSTACK-9114: Reduce VR downtime 
during network restart
URL: https://github.com/apache/cloudstack/pull/2508#issuecomment-385628954
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2508: CLOUDSTACK-9114: Reduce VR downtime during network restart

[GitBox]

blueorangutan commented on issue #2508: CLOUDSTACK-9114: Reduce VR downtime 
during network restart
URL: https://github.com/apache/cloudstack/pull/2508#issuecomment-385577308
 
 
   Trillian test result (tid-2553)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 53363 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2508-t2553-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_network.py
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 63 look OK, 4 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_reboot_router | `Failure` | 478.10 | test_network.py
   test_02_vpc_privategw_static_routes | `Failure` | 202.70 | 
test_privategw_acl.py
   test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 207.98 | 
test_privategw_acl.py
   test_04_rvpc_privategw_static_routes | `Failure` | 597.12 | 
test_privategw_acl.py
   test_02_isolate_network_FW_PF_default_routes_egress_false | `Failure` | 
402.71 | test_routers_network_ops.py
   test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Failure` | 
749.84 | test_routers_network_ops.py
   test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Failure` | 
760.36 | test_routers_network_ops.py
   test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 2.26 | 
test_host_maintenance.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2508: CLOUDSTACK-9114: Reduce VR downtime during network restart

[GitBox]

rhtyd commented on issue #2508: CLOUDSTACK-9114: Reduce VR downtime during 
network restart
URL: https://github.com/apache/cloudstack/pull/2508#issuecomment-385358311
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2508: CLOUDSTACK-9114: Reduce VR downtime during network restart

[GitBox]

rhtyd commented on issue #2508: CLOUDSTACK-9114: Reduce VR downtime during 
network restart
URL: https://github.com/apache/cloudstack/pull/2508#issuecomment-385628843
 
 
   @blueorangutan test
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2508: CLOUDSTACK-9114: Reduce VR downtime during network restart

[GitBox]

blueorangutan commented on issue #2508: CLOUDSTACK-9114: Reduce VR downtime 
during network restart
URL: https://github.com/apache/cloudstack/pull/2508#issuecomment-385358428
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2616: 4.11.1.0: Stabilization and blocker/issues fixes

[GitBox]

blueorangutan commented on issue #2616: 4.11.1.0: Stabilization and 
blocker/issues fixes
URL: https://github.com/apache/cloudstack/pull/2616#issuecomment-385954773
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1994


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2616: 4.11.1.0: Stabilization and blocker/issues fixes

[GitBox]

rhtyd commented on issue #2616: 4.11.1.0: Stabilization and blocker/issues fixes
URL: https://github.com/apache/cloudstack/pull/2616#issuecomment-385981744
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2616: 4.11.1.0: Stabilization and blocker/issues fixes

[GitBox]

blueorangutan commented on issue #2616: 4.11.1.0: Stabilization and 
blocker/issues fixes
URL: https://github.com/apache/cloudstack/pull/2616#issuecomment-385948081
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2616: 4.11.1.0: Stabilization and blocker/issues fixes

[GitBox]

rhtyd commented on issue #2616: 4.11.1.0: Stabilization and blocker/issues fixes
URL: https://github.com/apache/cloudstack/pull/2616#issuecomment-385947990
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2616: 4.11.1.0: Stabilization and blocker/issues fixes

[GitBox]

blueorangutan commented on issue #2616: 4.11.1.0: Stabilization and 
blocker/issues fixes
URL: https://github.com/apache/cloudstack/pull/2616#issuecomment-385981805
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd closed issue #2548: Upgrade to 4.11 and pre-existent saml2 authentication settings

[GitBox]

rhtyd closed issue #2548: Upgrade to 4.11 and pre-existent saml2 authentication 
settings
URL: https://github.com/apache/cloudstack/issues/2548
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2548: Upgrade to 4.11 and pre-existent saml2 authentication settings

[GitBox]

rhtyd commented on issue #2548: Upgrade to 4.11 and pre-existent saml2 
authentication settings
URL: https://github.com/apache/cloudstack/issues/2548#issuecomment-385968484
 
 
   @eligorio I could reproduce and I've fixed the issue. You may test 
upgrade+saml2 login using this PR: 
https://github.com/apache/cloudstack/pull/2616
   If you're looking for a rpm repo to test against, I'll share that next week 
on dev ML. I'll close the PR, thanks.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2574: [CLOUDSTACK-5235] ask users current password when they are executing a password update

[GitBox]

blueorangutan commented on issue #2574: [CLOUDSTACK-5235] ask users current 
password when they are executing a password update
URL: https://github.com/apache/cloudstack/pull/2574#issuecomment-385966300
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1995


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2574: [CLOUDSTACK-5235] ask users current password when they are executing a password update

[GitBox]

blueorangutan commented on issue #2574: [CLOUDSTACK-5235] ask users current 
password when they are executing a password update
URL: https://github.com/apache/cloudstack/pull/2574#issuecomment-385958828
 
 
   @rafaelweingartner a Jenkins job has been kicked to build packages. I'll 
keep you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch master updated: [CLOUDSTACK-5235] ask users current password when they are executing a password update (#2574)

[rafael]

This is an automated email from the ASF dual-hosted git repository.

rafael pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/master by this push:
 new 3adc2b8  [CLOUDSTACK-5235] ask users current password when they are 
executing a password update (#2574)
3adc2b8 is described below

commit 3adc2b8485d8a56634a3d4c54074321431bf2fda
Author: Rafael Weingärtner 
AuthorDate: Wed May 2 09:19:06 2018 -0300

[CLOUDSTACK-5235] ask users current password when they are executing a 
password update (#2574)

* [CLOUDSTACK-5235] Force users to enter old password when updating password

* Formatting for checkstyle

* Remove an unused import in AccountManagerImpl

* Apply Nitin's suggestions

* Change 'oldPassword' to 'currentPassword'

* Second review of Resmo

* Fix typos found by Nitin
---
 .../main/java/com/cloud/user/AccountService.java   |  45 +-
 .../org/apache/cloudstack/api/ApiConstants.java|   4 +-
 .../api/command/admin/user/UpdateUserCmd.java  |  30 +-
 .../contrail/management/MockAccountManager.java|   7 -
 .../cloudstack/api/command/LdapImportUsersCmd.java |  52 +-
 .../main/java/com/cloud/user/AccountManager.java   |  90 +--
 .../java/com/cloud/user/AccountManagerImpl.java| 444 --
 .../com/cloud/user/AccountManagerImplTest.java | 676 ++---
 .../AccountManagerImplVolumeDeleteEventTest.java   |  56 +-
 .../com/cloud/user/AccountManagetImplTestBase.java |  48 +-
 .../com/cloud/user/MockAccountManagerImpl.java |   7 -
 .../java/com/cloud/user/MockDomainManagerImpl.java | 164 -
 ui/l10n/ar.js  |   1 +
 ui/l10n/ca.js  |   1 +
 ui/l10n/de_DE.js   |   1 +
 ui/l10n/en.js  |   1 +
 ui/l10n/es.js  |   1 +
 ui/l10n/fr_FR.js   |   1 +
 ui/l10n/hu.js  |   1 +
 ui/l10n/it_IT.js   |   1 +
 ui/l10n/ja_JP.js   |   1 +
 ui/l10n/ko_KR.js   |   1 +
 ui/l10n/nb_NO.js   |   1 +
 ui/l10n/nl_NL.js   |   1 +
 ui/l10n/pl.js  |   1 +
 ui/l10n/pt_BR.js   |   1 +
 ui/l10n/ru_RU.js   |   1 +
 ui/l10n/zh_CN.js   |   1 +
 ui/scripts/accounts.js |  15 +-
 29 files changed, 998 insertions(+), 656 deletions(-)

diff --git a/api/src/main/java/com/cloud/user/AccountService.java 
b/api/src/main/java/com/cloud/user/AccountService.java
index 9683d9f..060861d 100644
--- a/api/src/main/java/com/cloud/user/AccountService.java
+++ b/api/src/main/java/com/cloud/user/AccountService.java
@@ -23,53 +23,28 @@ import org.apache.cloudstack.acl.RoleType;
 import org.apache.cloudstack.acl.SecurityChecker.AccessType;
 import org.apache.cloudstack.api.command.admin.user.GetUserKeysCmd;
 import org.apache.cloudstack.api.command.admin.user.RegisterCmd;
+import org.apache.cloudstack.api.command.admin.user.UpdateUserCmd;
 
 import com.cloud.domain.Domain;
 import com.cloud.exception.PermissionDeniedException;
 import com.cloud.offering.DiskOffering;
 import com.cloud.offering.ServiceOffering;
 
-
 public interface AccountService {
 
 /**
  * Creates a new user and account, stores the password as is so encrypted 
passwords are recommended.
- *
- * @param userName
- *TODO
- * @param password
- *TODO
- * @param firstName
- *TODO
- * @param lastName
- *TODO
- * @param email
- *TODO
- * @param timezone
- *TODO
- * @param accountName
- *TODO
- * @param accountType
- *TODO
- * @param domainId
- *TODO
- * @param networkDomain
- *TODO
- *
  * @return the user if created successfully, null otherwise
  */
-UserAccount createUserAccount(String userName, String password, String 
firstName, String lastName, String email, String timezone, String accountName,
-short accountType, Long roleId, Long domainId, String networkDomain, 
Map details, String accountUUID, String userUUID);
+UserAccount createUserAccount(String userName, String password, String 
firstName, String lastName, String email, String timezone, String accountName, 
short accountType, Long roleId, Long domainId,
+String networkDomain, Map details, String 
accountUUID, String userUUID);
 
-UserAccount createUserAccount(String userName, 

[GitHub] rafaelweingartner closed pull request #2574: [CLOUDSTACK-5235] ask users current password when they are executing a password update

[GitBox]

rafaelweingartner closed pull request #2574: [CLOUDSTACK-5235] ask users 
current password when they are executing a password update
URL: https://github.com/apache/cloudstack/pull/2574
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/api/src/main/java/com/cloud/user/AccountService.java 
b/api/src/main/java/com/cloud/user/AccountService.java
index 9683d9fa330..060861d1809 100644
--- a/api/src/main/java/com/cloud/user/AccountService.java
+++ b/api/src/main/java/com/cloud/user/AccountService.java
@@ -23,53 +23,28 @@
 import org.apache.cloudstack.acl.SecurityChecker.AccessType;
 import org.apache.cloudstack.api.command.admin.user.GetUserKeysCmd;
 import org.apache.cloudstack.api.command.admin.user.RegisterCmd;
+import org.apache.cloudstack.api.command.admin.user.UpdateUserCmd;
 
 import com.cloud.domain.Domain;
 import com.cloud.exception.PermissionDeniedException;
 import com.cloud.offering.DiskOffering;
 import com.cloud.offering.ServiceOffering;
 
-
 public interface AccountService {
 
 /**
  * Creates a new user and account, stores the password as is so encrypted 
passwords are recommended.
- *
- * @param userName
- *TODO
- * @param password
- *TODO
- * @param firstName
- *TODO
- * @param lastName
- *TODO
- * @param email
- *TODO
- * @param timezone
- *TODO
- * @param accountName
- *TODO
- * @param accountType
- *TODO
- * @param domainId
- *TODO
- * @param networkDomain
- *TODO
- *
  * @return the user if created successfully, null otherwise
  */
-UserAccount createUserAccount(String userName, String password, String 
firstName, String lastName, String email, String timezone, String accountName,
-short accountType, Long roleId, Long domainId, String networkDomain, 
Map details, String accountUUID, String userUUID);
+UserAccount createUserAccount(String userName, String password, String 
firstName, String lastName, String email, String timezone, String accountName, 
short accountType, Long roleId, Long domainId,
+String networkDomain, Map details, String 
accountUUID, String userUUID);
 
-UserAccount createUserAccount(String userName, String password, String 
firstName, String lastName, String email, String timezone, String accountName, 
short accountType, Long roleId, Long domainId, String networkDomain,
-  Map details, String 
accountUUID, String userUUID, User.Source source);
+UserAccount createUserAccount(String userName, String password, String 
firstName, String lastName, String email, String timezone, String accountName, 
short accountType, Long roleId, Long domainId,
+String networkDomain, Map details, String 
accountUUID, String userUUID, User.Source source);
 
 /**
  * Locks a user by userId. A locked user cannot access the API, but will 
still have running VMs/IP addresses
  * allocated/etc.
- *
- * @param userId
- * @return UserAccount object
  */
 UserAccount lockUser(long userId);
 
@@ -79,8 +54,7 @@ UserAccount createUserAccount(String userName, String 
password, String firstName
 
 User createUser(String userName, String password, String firstName, String 
lastName, String email, String timeZone, String accountName, Long domainId, 
String userUUID);
 
-User createUser(String userName, String password, String firstName, String 
lastName, String email, String timeZone, String accountName, Long domainId, 
String userUUID,
-User.Source source);
+User createUser(String userName, String password, String firstName, String 
lastName, String email, String timeZone, String accountName, Long domainId, 
String userUUID, User.Source source);
 
 boolean isAdmin(Long accountId);
 
@@ -90,7 +64,7 @@ User createUser(String userName, String password, String 
firstName, String lastN
 
 UserAccount getActiveUserAccount(String username, Long domainId);
 
-UserAccount updateUser(Long userId, String firstName, String lastName, 
String email, String userName, String password, String apiKey, String 
secretKey, String timeZone);
+UserAccount updateUser(UpdateUserCmd updateUserCmd);
 
 Account getActiveAccountById(long accountId);
 
@@ -128,15 +102,14 @@ User createUser(String userName, String password, String 
firstName, String lastN
 
 void checkAccess(User user, ControlledEntity entity);
 
-void checkAccess(Account account, AccessType accessType, boolean 
sameOwner, String apiName,
-ControlledEntity... entities) 

[GitHub] rafaelweingartner opened a new pull request #2619: Remote "self-injection" of AccountManagerImpl

[GitBox]

rafaelweingartner opened a new pull request #2619: Remote "self-injection" of 
AccountManagerImpl
URL: https://github.com/apache/cloudstack/pull/2619
 
 
   ## Description
   
   While working on other PRs I noticed that the singleton AccountManagerImpl 
had a reference for itself. That is not needed. Therefore, I removed it.
   
   
   
   
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [X] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   
   
   
   
   
   
   ## How Has This Been Tested?
   Smoke tests
   
   
   
   
   
   ## Checklist:
   
   
   - [X] I have read the 
[CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md)
 document.
   - [X] My code follows the code style of this project.
   - [ ] My change requires a change to the documentation.
   - [ ] I have updated the documentation accordingly.
   Testing
   - [ ] I have added tests to cover my changes.
   - [X] All relevant new and existing integration tests have passed.
   - [ ] A full integration testsuite with all test that can run on my 
environment has passed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2616: 4.11.1.0: Stabilization and blocker/issues fixes

[GitBox]

blueorangutan commented on issue #2616: 4.11.1.0: Stabilization and 
blocker/issues fixes
URL: https://github.com/apache/cloudstack/pull/2616#issuecomment-385954773
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1994


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] marcaurele commented on issue #1709: CLOUDSTACK-7982: KVM live migration with local storage

[GitBox]

marcaurele commented on issue #1709: CLOUDSTACK-7982: KVM live migration with 
local storage
URL: https://github.com/apache/cloudstack/pull/1709#issuecomment-385953605
 
 
   rebase done


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wido commented on issue #2611: Ceph RBD primary storage fails connection and renders node unusable

[GitBox]

wido commented on issue #2611: Ceph RBD primary storage fails connection and 
renders node unusable
URL: https://github.com/apache/cloudstack/issues/2611#issuecomment-385952598
 
 
   Ok, I see. The operation not supported is odd, but it seems to be missing 
the cephx part indeed.
   
   At the moment I do not have a 4.11 environment to test this with, but I'll 
look at the code later.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] giorgiomassar8 commented on issue #2611: Ceph RBD primary storage fails connection and renders node unusable

[GitBox]

giorgiomassar8 commented on issue #2611: Ceph RBD primary storage fails 
connection and renders node unusable
URL: https://github.com/apache/cloudstack/issues/2611#issuecomment-385951279
 
 
   I have set debugging on one of the agents and this is what I get:
   
   ```
   2018-05-02 13:41:44,401 INFO  [kvm.storage.LibvirtStorageAdaptor] 
(agentRequest-Handler-4:null) (logid:d06ebad5) Attempting to create storage 
pool be80af6a-7201-3410-8da4-9b3b58c4954f (RBD) in libvirt
   2018-05-02 13:41:44,401 DEBUG [kvm.resource.LibvirtConnection] 
(agentRequest-Handler-4:null) (logid:d06ebad5) Looking for libvirtd connection 
at: qemu:///system
   2018-05-02 13:41:44,403 WARN  [kvm.storage.LibvirtStorageAdaptor] 
(agentRequest-Handler-4:null) (logid:d06ebad5) Storage pool 
be80af6a-7201-3410-8da4-9b3b58c4954f was not found running in libvirt. Need to 
create it.
   2018-05-02 13:41:44,403 INFO  [kvm.storage.LibvirtStorageAdaptor] 
(agentRequest-Handler-4:null) (logid:d06ebad5) Didn't find an existing storage 
pool be80af6a-7201-3410-8da4-9b3b58c4954f by UUID, checking for pools with 
duplicate paths
   2018-05-02 13:41:44,404 DEBUG [kvm.storage.LibvirtStorageAdaptor] 
(agentRequest-Handler-4:null) (logid:d06ebad5) Checking path of existing pool 
9fb695bd-a47f-45d3-9fe7-f029dff431d8 against pool we want to create
   2018-05-02 13:41:44,408 DEBUG [kvm.storage.LibvirtStorageAdaptor] 
(agentRequest-Handler-4:null) (logid:d06ebad5) Attempting to create storage 
pool be80af6a-7201-3410-8da4-9b3b58c4954f
   2018-05-02 13:41:44,408 DEBUG [kvm.storage.LibvirtStorageAdaptor] 
(agentRequest-Handler-4:null) (logid:d06ebad5) 
   be80af6a-7201-3410-8da4-9b3b58c4954f
   be80af6a-7201-3410-8da4-9b3b58c4954f
   
   
   cephstor1
   
   
   
   2018-05-02 13:41:44,415 ERROR [kvm.storage.LibvirtStorageAdaptor] 
(agentRequest-Handler-4:null) (logid:d06ebad5) Failed to create RBD storage 
pool: org.libvirt.LibvirtException: failed to connect to the RADOS monitor on: 
storagepool1:6789,: Operation not supported
   2018-05-02 13:41:44,415 DEBUG [cloud.agent.Agent] 
(agentRequest-Handler-4:null) (logid:d06ebad5) Seq 1-6775102689425489922:  { 
Ans: , MgmtId: 29010072043598, via: 1, Ver: v1, Flags: 10, 
[{"com.cloud.agent.api.UnsupportedAnswer":{"result":false,"details":"Unsupported
 command issued: com.cloud.agent.api.ModifyStoragePoolCommand.  Are you sure 
you got the right type of server?","wait":0}}] }
   2018-05-02 13:41:44,451 DEBUG [kvm.resource.LibvirtComputingResource] 
(Agent-Handler-4:null) (logid:d06ebad5) Execution is successful.
   2018-05-02 13:41:44,453 DEBUG [cloud.agent.Agent] (Agent-Handler-4:null) 
(logid:d06ebad5) Watch Sent: Seq 1-6775102689425489921:  { Ans: , MgmtId: 
29010072043598, via: 1, Ver: v1, Flags: 10, 
[{"com.cloud.agent.api.Answer":{"result":true,"details":"","wait":0}}] }
   2018-05-02 13:41:44,464 DEBUG [utils.nio.NioConnection] 
(Agent-NioConnectionHandler-1:null) (logid:) Location 1: Socket 
Socket[addr=/10.20.0.21,port=8250,localport=45374] closed on read.  Probably -1 
returned: Connection closed with -1 on reading size.
   2018-05-02 13:41:44,464 DEBUG [utils.nio.NioConnection] 
(Agent-NioConnectionHandler-1:null) (logid:) Closing socket 
Socket[addr=/10.20.0.21,port=8250,localport=45374]
   2018-05-02 13:41:44,464 DEBUG [cloud.agent.Agent] (Agent-Handler-1:null) 
(logid:) Clearing watch list: 2
   2018-05-02 13:41:46,728 INFO  [cloud.agent.Agent] (Agent-Handler-1:null) 
(logid:) Connected to the server
   2018-05-02 13:41:49,465 INFO  [cloud.agent.Agent] (Agent-Handler-1:null) 
(logid:) Lost connection to the server. Dealing with the remaining commands...
   
   ```
   In the generated XML there isn't the secret part, perhaps the agent is 
trying to use another authentication mechanism which this version of libvirt 
does not support?
   
   This is what I have been using as a workaround, and it works:
   
   ```
   
 be80af6a-7201-3410-8da4-9b3b58c4954f
 be80af6a-7201-3410-8da4-9b3b58c4954f
 
   cephstor1
   
   
 
   
 
   
   
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2382: CLOUDSTACK-4045 IP address acquired with associateIpAddress is marked as source NAT

[GitBox]

blueorangutan commented on issue #2382: CLOUDSTACK-4045 IP address acquired 
with associateIpAddress is marked as source NAT
URL: https://github.com/apache/cloudstack/pull/2382#issuecomment-385950452
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2382: CLOUDSTACK-4045 IP address acquired with associateIpAddress is marked as source NAT

[GitBox]

rhtyd commented on issue #2382: CLOUDSTACK-4045 IP address acquired with 
associateIpAddress is marked as source NAT
URL: https://github.com/apache/cloudstack/pull/2382#issuecomment-385950273
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2376: [4.11] Smoketest Health Check

[GitBox]

blueorangutan commented on issue #2376: [4.11] Smoketest Health Check
URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-385547575
 
 
   Trillian test result (tid-2550)
   Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 6
   Total time taken: 48598 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2376-t2550-xenserver-71.zip
   Intermitten failure detected: /marvin/tests/smoke/test_certauthority_root.py
   Intermitten failure detected: /marvin/tests/smoke/test_dynamicroles.py
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_simulator.py
   Intermitten failure detected: /marvin/tests/smoke/test_login.py
   Intermitten failure detected: /marvin/tests/smoke/test_network.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_outofbandmanagement_nestedplugin.py
   Intermitten failure detected: /marvin/tests/smoke/test_outofbandmanagement.py
   Intermitten failure detected: /marvin/tests/smoke/test_primary_storage.py
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_projects.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers.py
   Intermitten failure detected: /marvin/tests/smoke/test_scale_vm.py
   Intermitten failure detected: /marvin/tests/smoke/test_service_offerings.py
   Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
   Intermitten failure detected: /marvin/tests/smoke/test_ssvm.py
   Intermitten failure detected: /marvin/tests/smoke/test_templates.py
   Intermitten failure detected: /marvin/tests/smoke/test_usage.py
   Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 48 look OK, 19 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   login_test_saml_user | `Error` | 0.63 | test_login.py
   test_revoke_certificate | `Error` | 0.01 | test_certauthority_root.py
   test_reboot_router | `Error` | 1529.76 | test_network.py
   test_role_account_acls_multiple_mgmt_servers | `Error` | 0.75 | 
test_dynamicroles.py
   test_configure_ha_provider_invalid | `Error` | 0.01 | 
test_hostha_simulator.py
   test_configure_ha_provider_valid | `Error` | 0.01 | test_hostha_simulator.py
   test_ha_configure_enabledisable_across_clusterzones | `Error` | 0.01 | 
test_hostha_simulator.py
   test_ha_disable_feature_invalid | `Error` | 0.01 | test_hostha_simulator.py
   test_ha_enable_feature_invalid | `Error` | 0.01 | test_hostha_simulator.py
   test_ha_list_providers | `Error` | 0.01 | test_hostha_simulator.py
   test_ha_multiple_mgmt_server_ownership | `Error` | 0.01 | 
test_hostha_simulator.py
   test_ha_verify_fsm_available | `Error` | 0.01 | test_hostha_simulator.py
   test_ha_verify_fsm_degraded | `Error` | 0.01 | test_hostha_simulator.py
   test_ha_verify_fsm_fenced | `Error` | 0.01 | test_hostha_simulator.py
   test_ha_verify_fsm_recovering | `Error` | 0.01 | test_hostha_simulator.py
   test_hostha_configure_default_driver | `Error` | 0.01 | 
test_hostha_simulator.py
   test_hostha_configure_invalid_provider | `Error` | 0.01 | 
test_hostha_simulator.py
   test_hostha_disable_feature_valid | `Error` | 0.01 | test_hostha_simulator.py
   test_hostha_enable_feature_valid | `Error` | 0.01 | test_hostha_simulator.py
   test_hostha_enable_feature_without_setting_provider | `Error` | 0.01 | 
test_hostha_simulator.py
   test_list_ha_for_host | `Error` | 0.01 | test_hostha_simulator.py
   test_list_ha_for_host_invalid | `Error` | 0.01 | test_hostha_simulator.py
   test_list_ha_for_host_valid | `Error` | 0.01 | test_hostha_simulator.py
   test_02_edit_primary_storage_tags | `Error` | 0.01 | test_primary_storage.py
   test_oobm_issue_power_cycle | `Error` | 3.38 | 
test_outofbandmanagement_nestedplugin.py
   test_oobm_issue_power_off | `Error` | 3.37 | 
test_outofbandmanagement_nestedplugin.py
   test_oobm_issue_power_on | `Error` | 3.37 | 
test_outofbandmanagement_nestedplugin.py
   test_oobm_issue_power_reset | `Error` | 3.42 | 
test_outofbandmanagement_nestedplugin.py
   test_oobm_issue_power_soft | `Error` | 3.33 | 
test_outofbandmanagement_nestedplugin.py
   test_oobm_issue_power_status | `Error` | 2.35 | 
test_outofbandmanagement_nestedplugin.py
   test_oobm_background_powerstate_sync | `Failure` | 21.60 | 
test_outofbandmanagement.py
   test_oobm_background_powerstate_sync | `Error` | 21.60 | 
test_outofbandmanagement.py
   test_oobm_configure_default_driver | `Error` | 0.05 | 
test_outofbandmanagement.py
   test_oobm_configure_invalid_driver | `Error` | 0.05 | 
test_outofbandmanagement.py
   test_oobm_disable_feature_invalid | `Error` | 0.07 | 
test_outofbandmanagement.py
   test_oobm_disable_feature_valid | `Error` | 1.15 | 
test_outofbandmanagement.py
   test_oobm_enable_feature_invalid | `Error` | 0.08 

[GitHub] blueorangutan commented on issue #2376: [4.11] Smoketest Health Check

[GitBox]

blueorangutan commented on issue #2376: [4.11] Smoketest Health Check
URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-383362221
 
 
   Trillian test result (tid-2529)
   Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 6
   Total time taken: 159866 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2376-t2529-xenserver-71.zip
   Intermitten failure detected: /marvin/tests/smoke/test_certauthority_root.py
   Intermitten failure detected: /marvin/tests/smoke/test_deploy_vm_iso.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_vm_root_resize.py
   Intermitten failure detected: /marvin/tests/smoke/test_dynamicroles.py
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_simulator.py
   Intermitten failure detected: /marvin/tests/smoke/test_login.py
   Intermitten failure detected: /marvin/tests/smoke/test_network.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_outofbandmanagement_nestedplugin.py
   Intermitten failure detected: /marvin/tests/smoke/test_outofbandmanagement.py
   Intermitten failure detected: /marvin/tests/smoke/test_primary_storage.py
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_projects.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers.py
   Intermitten failure detected: /marvin/tests/smoke/test_scale_vm.py
   Intermitten failure detected: /marvin/tests/smoke/test_service_offerings.py
   Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
   Intermitten failure detected: /marvin/tests/smoke/test_ssvm.py
   Intermitten failure detected: /marvin/tests/smoke/test_templates.py
   Intermitten failure detected: /marvin/tests/smoke/test_usage.py
   Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 48 look OK, 19 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   login_test_saml_user | `Error` | 0.63 | test_login.py
   test_revoke_certificate | `Error` | 0.01 | test_certauthority_root.py
   test_reboot_router | `Error` | 2509.01 | test_network.py
   test_role_account_acls_multiple_mgmt_servers | `Error` | 0.72 | 
test_dynamicroles.py
   test_configure_ha_provider_invalid | `Error` | 0.01 | 
test_hostha_simulator.py
   test_configure_ha_provider_valid | `Error` | 0.01 | test_hostha_simulator.py
   test_ha_configure_enabledisable_across_clusterzones | `Error` | 0.01 | 
test_hostha_simulator.py
   test_ha_disable_feature_invalid | `Error` | 0.01 | test_hostha_simulator.py
   test_ha_enable_feature_invalid | `Error` | 0.01 | test_hostha_simulator.py
   test_ha_list_providers | `Error` | 0.01 | test_hostha_simulator.py
   test_ha_multiple_mgmt_server_ownership | `Error` | 0.01 | 
test_hostha_simulator.py
   test_ha_verify_fsm_available | `Error` | 0.01 | test_hostha_simulator.py
   test_ha_verify_fsm_degraded | `Error` | 0.01 | test_hostha_simulator.py
   test_ha_verify_fsm_fenced | `Error` | 0.01 | test_hostha_simulator.py
   test_ha_verify_fsm_recovering | `Error` | 0.01 | test_hostha_simulator.py
   test_hostha_configure_default_driver | `Error` | 0.01 | 
test_hostha_simulator.py
   test_hostha_configure_invalid_provider | `Error` | 0.01 | 
test_hostha_simulator.py
   test_hostha_disable_feature_valid | `Error` | 0.01 | test_hostha_simulator.py
   test_hostha_enable_feature_valid | `Error` | 0.01 | test_hostha_simulator.py
   test_hostha_enable_feature_without_setting_provider | `Error` | 0.01 | 
test_hostha_simulator.py
   test_list_ha_for_host | `Error` | 0.01 | test_hostha_simulator.py
   test_list_ha_for_host_invalid | `Error` | 0.01 | test_hostha_simulator.py
   test_list_ha_for_host_valid | `Error` | 0.01 | test_hostha_simulator.py
   test_02_edit_primary_storage_tags | `Error` | 0.01 | test_primary_storage.py
   test_oobm_issue_power_cycle | `Error` | 3.52 | 
test_outofbandmanagement_nestedplugin.py
   test_oobm_issue_power_off | `Error` | 3.36 | 
test_outofbandmanagement_nestedplugin.py
   test_oobm_issue_power_on | `Error` | 3.45 | 
test_outofbandmanagement_nestedplugin.py
   test_oobm_issue_power_reset | `Error` | 3.34 | 
test_outofbandmanagement_nestedplugin.py
   test_oobm_issue_power_soft | `Error` | 3.42 | 
test_outofbandmanagement_nestedplugin.py
   test_oobm_issue_power_status | `Error` | 2.26 | 
test_outofbandmanagement_nestedplugin.py
   test_oobm_background_powerstate_sync | `Failure` | 21.58 | 
test_outofbandmanagement.py
   test_oobm_background_powerstate_sync | `Error` | 21.58 | 
test_outofbandmanagement.py
   test_oobm_configure_default_driver | `Error` | 0.05 | 
test_outofbandmanagement.py
   test_oobm_configure_invalid_driver | `Error` | 0.06 | 
test_outofbandmanagement.py
   test_oobm_disable_feature_invalid | `Error` | 0.07 | 

[GitHub] blueorangutan commented on issue #2376: [4.11] Smoketest Health Check

[GitBox]

blueorangutan commented on issue #2376: [4.11] Smoketest Health Check
URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-385570724
 
 
   Trillian test result (tid-2552)
   Environment: vmware-65 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 57211 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2376-t2552-vmware-65.zip
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_service_offerings.py
   Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Smoke tests completed. 65 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   ContextSuite context=TestCpuCapServiceOfferings>:teardown | `Error` | 0.00 | 
test_service_offerings.py
   test_01_secured_vm_migration | `Error` | 1.12 | test_vm_life_cycle.py
   test_02_not_secured_vm_migration | `Error` | 1.11 | test_vm_life_cycle.py
   test_03_secured_to_nonsecured_vm_migration | `Error` | 1.16 | 
test_vm_life_cycle.py
   test_04_nonsecured_to_secured_vm_migration | `Error` | 1.11 | 
test_vm_life_cycle.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2376: [4.11] Smoketest Health Check

[GitBox]

blueorangutan commented on issue #2376: [4.11] Smoketest Health Check
URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-385415566
 
 
   Trillian test result (tid-2551)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 20363 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2376-t2551-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 66 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_hostha_enable_ha_when_host_in_maintenance | `Error` | 1.44 | 
test_hostha_kvm.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2376: [4.11] Smoketest Health Check

[GitBox]

rhtyd commented on issue #2376: [4.11] Smoketest Health Check
URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-385337014
 
 
   @blueorangutan test matrix


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2376: [4.11] Smoketest Health Check

[GitBox]

blueorangutan commented on issue #2376: [4.11] Smoketest Health Check
URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-382499980
 
 
   Trillian test result (tid-2510)
   Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 6
   Total time taken: 123842 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2376-t2510-xenserver-71.zip
   Intermitten failure detected: /marvin/tests/smoke/test_network.py
   Intermitten failure detected: /marvin/tests/smoke/test_projects.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers.py
   Intermitten failure detected: /marvin/tests/smoke/test_scale_vm.py
   Intermitten failure detected: /marvin/tests/smoke/test_service_offerings.py
   Intermitten failure detected: /marvin/tests/smoke/test_ssvm.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 61 look OK, 6 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_reboot_router | `Error` | 2520.97 | test_network.py
   test_10_project_activation | `Error` | 2754.61 | test_projects.py
   test_04_restart_network_wo_cleanup | `Failure` | 5.77 | test_routers.py
   test_08_start_router | `Error` | 1378.62 | test_routers.py
   test_09_reboot_router | `Error` | 1.12 | test_routers.py
   test_01_scale_vm | `Error` | 28.89 | test_scale_vm.py
   ContextSuite context=TestCpuCapServiceOfferings>:teardown | `Error` | 0.00 | 
test_service_offerings.py
   test_05_stop_ssvm | `Failure` | 923.06 | test_ssvm.py
   test_06_stop_cpvm | `Failure` | 927.73 | test_ssvm.py
   test_08_reboot_cpvm | `Failure` | 0.03 | test_ssvm.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2616: 4.11.1.0: Stabilization and blocker/issues fixes

[GitBox]

blueorangutan commented on issue #2616: 4.11.1.0: Stabilization and 
blocker/issues fixes
URL: https://github.com/apache/cloudstack/pull/2616#issuecomment-385948081
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2616: 4.11.1.0: Stabilization and blocker/issues fixes

[GitBox]

rhtyd commented on issue #2616: 4.11.1.0: Stabilization and blocker/issues fixes
URL: https://github.com/apache/cloudstack/pull/2616#issuecomment-385947990
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2382: CLOUDSTACK-4045 IP address acquired with associateIpAddress is marked as source NAT

[GitBox]

blueorangutan commented on issue #2382: CLOUDSTACK-4045 IP address acquired 
with associateIpAddress is marked as source NAT
URL: https://github.com/apache/cloudstack/pull/2382#issuecomment-385947928
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1993


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2382: CLOUDSTACK-4045 IP address acquired with associateIpAddress is marked as source NAT

[GitBox]

blueorangutan commented on issue #2382: CLOUDSTACK-4045 IP address acquired 
with associateIpAddress is marked as source NAT
URL: https://github.com/apache/cloudstack/pull/2382#issuecomment-385942661
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2382: CLOUDSTACK-4045 IP address acquired with associateIpAddress is marked as source NAT

[GitBox]

rhtyd commented on issue #2382: CLOUDSTACK-4045 IP address acquired with 
associateIpAddress is marked as source NAT
URL: https://github.com/apache/cloudstack/pull/2382#issuecomment-385942642
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #1940: CLOUDSTACK-9781:ACS records ID in events tables instead of UUID.

[GitBox]

rhtyd commented on issue #1940: CLOUDSTACK-9781:ACS records ID in events tables 
instead of UUID.
URL: https://github.com/apache/cloudstack/pull/1940#issuecomment-385942506
 
 
   Okay @rafaelweingartner. Let me diagnose that and get back to you soon.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2473: CLOUDSTACK-10309 Add option on if to VM HA power-on a OOB-shut-off-VM

[GitBox]

rhtyd commented on issue #2473: CLOUDSTACK-10309 Add option on if to VM HA 
power-on a OOB-shut-off-VM
URL: https://github.com/apache/cloudstack/pull/2473#issuecomment-385942294
 
 
   Okay @rafaelweingartner I'll merge after smoketests are back.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd closed issue #2541: Add "Lets Encrypt CA" Certpath to SSVM Keystore (for cdimage.debian.org)

[GitBox]

rhtyd closed issue #2541: Add "Lets Encrypt CA" Certpath to SSVM Keystore (for 
cdimage.debian.org)
URL: https://github.com/apache/cloudstack/issues/2541
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2541: Add "Lets Encrypt CA" Certpath to SSVM Keystore (for cdimage.debian.org)

[GitBox]

rhtyd commented on issue #2541: Add "Lets Encrypt CA" Certpath to SSVM Keystore 
(for cdimage.debian.org)
URL: https://github.com/apache/cloudstack/issues/2541#issuecomment-385941284
 
 
   Closing this as this is addressed in new 4.11.1 systemvmtemple from this pr 
https://github.com/apache/cloudstack/pull/2616


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov opened a new issue #2618: Infra->Pods does not show which pod from which zone is, admin needs to name them with the zone name to have this info

[GitBox]

borisstoyanov opened a new issue #2618: Infra->Pods does not show which pod 
from which zone is, admin needs to name them with the zone name to have this 
info
URL: https://github.com/apache/cloudstack/issues/2618
 
 
   
   # ISSUE TYPE
   
* Improvement Request
* Enhancement Request
* Feature Idea
   
   # COMPONENT NAME
   
   ~~~
   UI
   ~~~
   
   # CLOUDSTACK VERSION
   
   ~~~
   Reported in 4.11, but also seen in previous 
   ~~~
   
   # CONFIGURATION
   
   Have more than one zone with multiple pods 
   
   
   # OS / ENVIRONMENT
   
   NA
   
   # SUMMARY
   
   When opening the Pods in the UI, Cloudstack admin is not able to see which 
zone a pod is part of, if it's using same naming it could be confusing. It'll 
be good if we have a fields here to display the zone.
   
   # STEPS TO REPRODUCE
   
   
   
   ~~~
   Just open Infra->Pods
   ~~~
   
   
   
   # EXPECTED RESULTS
   
   ~~~
   Pods to have zone displayed 
   ~~~
   
   # ACTUAL RESULTS
   
   
   
   ~~~
   They dont
   ~~~
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2616: 4.11.1.0: Stabilization and blocker/issues fixes

[GitBox]

rhtyd commented on issue #2616: 4.11.1.0: Stabilization and blocker/issues fixes
URL: https://github.com/apache/cloudstack/pull/2616#issuecomment-385933833
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2616: 4.11.1.0: Stabilization and blocker/issues fixes

[GitBox]

blueorangutan commented on issue #2616: 4.11.1.0: Stabilization and 
blocker/issues fixes
URL: https://github.com/apache/cloudstack/pull/2616#issuecomment-385933876
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2616: 4.11.1.0: Stabilization and blocker/issues fixes

[GitBox]

blueorangutan commented on issue #2616: 4.11.1.0: Stabilization and 
blocker/issues fixes
URL: https://github.com/apache/cloudstack/pull/2616#issuecomment-385939819
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1992


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2616: 4.11.1.0: Stabilization and blocker/issues fixes

[GitBox]

blueorangutan commented on issue #2616: 4.11.1.0: Stabilization and 
blocker/issues fixes
URL: https://github.com/apache/cloudstack/pull/2616#issuecomment-385758598
 
 
   Trillian test result (tid-2563)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 23255 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2616-t2563-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 67 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2616: 4.11.1.0: Stabilization and blocker/issues fixes

[GitBox]

blueorangutan commented on issue #2616: 4.11.1.0: Stabilization and 
blocker/issues fixes
URL: https://github.com/apache/cloudstack/pull/2616#issuecomment-385655022
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1986


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2616: 4.11.1.0: Stabilization and blocker/issues fixes

[GitBox]

blueorangutan commented on issue #2616: 4.11.1.0: Stabilization and 
blocker/issues fixes
URL: https://github.com/apache/cloudstack/pull/2616#issuecomment-385650778
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2616: 4.11.1.0: Stabilization and blocker/issues fixes

[GitBox]

rhtyd commented on issue #2616: 4.11.1.0: Stabilization and blocker/issues fixes
URL: https://github.com/apache/cloudstack/pull/2616#issuecomment-385650745
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2561: cloud-early-config detects unknown hypervisor type "xen-domU"

[GitBox]

rhtyd commented on issue #2561: cloud-early-config detects unknown hypervisor 
type "xen-domU"
URL: https://github.com/apache/cloudstack/issues/2561#issuecomment-385939710
 
 
   Tested and validated the fix. @MartinEmrich you may help with testing the 
issue using #2616, I'll publish newer 4.11.1 systemvmtemplate later this week. 
/cc @khos2ow 
   I'll mark this issue as closed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2616: 4.11.1.0: Stabilization and blocker/issues fixes

[GitBox]

blueorangutan commented on issue #2616: 4.11.1.0: Stabilization and 
blocker/issues fixes
URL: https://github.com/apache/cloudstack/pull/2616#issuecomment-385939819
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1992


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd closed issue #2561: cloud-early-config detects unknown hypervisor type "xen-domU"

[GitBox]

rhtyd closed issue #2561: cloud-early-config detects unknown hypervisor type 
"xen-domU"
URL: https://github.com/apache/cloudstack/issues/2561
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2561: cloud-early-config detects unknown hypervisor type "xen-domU"

[GitBox]

rhtyd commented on issue #2561: cloud-early-config detects unknown hypervisor 
type "xen-domU"
URL: https://github.com/apache/cloudstack/issues/2561#issuecomment-385937342
 
 
   I've found the issue and testing the fix as part of 
https://github.com/apache/cloudstack/pull/2616 /cc @MartinEmrich @khos2ow 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] houthuis commented on issue #2382: CLOUDSTACK-4045 IP address acquired with associateIpAddress is marked as source NAT

[GitBox]

houthuis commented on issue #2382: CLOUDSTACK-4045 IP address acquired with 
associateIpAddress is marked as source NAT
URL: https://github.com/apache/cloudstack/pull/2382#issuecomment-385935862
 
 
   @DaanHoogland thanks for running the tests, I am happy.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2473: CLOUDSTACK-10309 Add option on if to VM HA power-on a OOB-shut-off-VM

[GitBox]

rafaelweingartner commented on issue #2473: CLOUDSTACK-10309 Add option on if 
to VM HA power-on a OOB-shut-off-VM
URL: https://github.com/apache/cloudstack/pull/2473#issuecomment-385934377
 
 
   I do believe it needs code extraction and unit tests, but you want to merge 
it. Let's proceed and merge.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2530: KVM hosts fail to connect if there is more than one IP address on the host

[GitBox]

rhtyd commented on issue #2530: KVM hosts fail to connect if there is more than 
one IP address on the host
URL: https://github.com/apache/cloudstack/issues/2530#issuecomment-385934254
 
 
   Marking this closed as addressed in PR. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd closed issue #2530: KVM hosts fail to connect if there is more than one IP address on the host

[GitBox]

rhtyd closed issue #2530: KVM hosts fail to connect if there is more than one 
IP address on the host
URL: https://github.com/apache/cloudstack/issues/2530
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2616: 4.11.1.0: Stabilization and blocker/issues fixes

[GitBox]

blueorangutan commented on issue #2616: 4.11.1.0: Stabilization and 
blocker/issues fixes
URL: https://github.com/apache/cloudstack/pull/2616#issuecomment-385773457
 
 
   Trillian test result (tid-2564)
   Environment: vmware-65 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 26950 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2616-t2564-vmware-65.zip
   Intermitten failure detected: /marvin/tests/smoke/test_service_offerings.py
   Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Smoke tests completed. 65 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   ContextSuite context=TestCpuCapServiceOfferings>:teardown | `Error` | 0.00 | 
test_service_offerings.py
   test_01_secured_vm_migration | `Error` | 1.10 | test_vm_life_cycle.py
   test_02_not_secured_vm_migration | `Error` | 1.09 | test_vm_life_cycle.py
   test_03_secured_to_nonsecured_vm_migration | `Error` | 1.09 | 
test_vm_life_cycle.py
   test_04_nonsecured_to_secured_vm_migration | `Error` | 1.09 | 
test_vm_life_cycle.py
   test_10_attachAndDetach_iso | `Failure` | 11.67 | test_vm_life_cycle.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2616: 4.11.1.0: Stabilization and blocker/issues fixes

[GitBox]

rhtyd commented on issue #2616: 4.11.1.0: Stabilization and blocker/issues fixes
URL: https://github.com/apache/cloudstack/pull/2616#issuecomment-385933833
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2616: 4.11.1.0: Stabilization and blocker/issues fixes

[GitBox]

blueorangutan commented on issue #2616: 4.11.1.0: Stabilization and 
blocker/issues fixes
URL: https://github.com/apache/cloudstack/pull/2616#issuecomment-385933876
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #1940: CLOUDSTACK-9781:ACS records ID in events tables instead of UUID.

[GitBox]

rafaelweingartner commented on issue #1940: CLOUDSTACK-9781:ACS records ID in 
events tables instead of UUID.
URL: https://github.com/apache/cloudstack/pull/1940#issuecomment-385933561
 
 
   I have replied you guys at #2607. This error might happen if there are some 
other testes that change the tags of the primary storage I use.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #1940: CLOUDSTACK-9781:ACS records ID in events tables instead of UUID.

[GitBox]

rafaelweingartner commented on issue #1940: CLOUDSTACK-9781:ACS records ID in 
events tables instead of UUID.
URL: https://github.com/apache/cloudstack/pull/1940#issuecomment-385933561
 
 
   I have replied you guys at #2607. This error happens if there are some other 
testes that change the tags of the primary storage I use.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2607: Allow changing disk offering of VMs' root volume during volume migration

[GitBox]

rafaelweingartner commented on issue #2607: Allow changing disk offering of 
VMs' root volume during volume migration
URL: https://github.com/apache/cloudstack/pull/2607#issuecomment-385932685
 
 
   None of the errors are related. Let me detail the causes for failures there.
   * `test_04_extract_template`: Extract Template Failed with invalid URL 
http://192.168.100.170/userdata/aeb36612-0a31-4a66-8579-844f47556729.qcow2
   * `ContextSuite context=TestISOUsage>:setup`: Looks like a download failure 
as well.
   * `test_vm_life_cycle.py` (all tests from this file): Host communication is 
not as expected: true. Instead it's: false
   * `test_06_download_detached_volume`: Failed with invalid URL 
http://192.168.100.170/userdata/3b5a751b-e8d2-4b21-818f-e2fec696310c.qcow2
   * `test_11_migrate_volume_and_change_offering` (this is the only one that 
could be related): Target Storage [id=50dc6d8a-5959-3778-ad39-7e86e71ff764] 
tags [storage.overprovisioning.factor] does not match new disk offering 
[id=1aa758ec-1f9e-4997-b944-8ead5e387fb5] tags [null].
   
   You can look at the code I changed; it does not cause these errors. The 
error seen in `test_11_migrate_volume_and_change` seems to be a concurrency 
problem. Are you running multiple tests at the same time? If you open the file 
“test_volumes.py”, you will see at line 928 that I set the storage tags to 
empty. Therefore, that error should not have happened. Can you try executing 
the tests again?
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wido commented on issue #2611: Ceph RBD primary storage fails connection and renders node unusable

[GitBox]

wido commented on issue #2611: Ceph RBD primary storage fails connection and 
renders node unusable
URL: https://github.com/apache/cloudstack/issues/2611#issuecomment-385930647
 
 
   Can you increase the logging to DEBUG on the Agent and show the XML which 
the Agent generates to define the storage pool?
   
   The error you are seeing comes from libvirt+librados underneath so I'd need 
to see the XML it generates.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2473: CLOUDSTACK-10309 Add option on if to VM HA power-on a OOB-shut-off-VM

[GitBox]

blueorangutan commented on issue #2473: CLOUDSTACK-10309 Add option on if to VM 
HA power-on a OOB-shut-off-VM
URL: https://github.com/apache/cloudstack/pull/2473#issuecomment-385926883
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2473: CLOUDSTACK-10309 Add option on if to VM HA power-on a OOB-shut-off-VM

[GitBox]

rhtyd commented on issue #2473: CLOUDSTACK-10309 Add option on if to VM HA 
power-on a OOB-shut-off-VM
URL: https://github.com/apache/cloudstack/pull/2473#issuecomment-385926721
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer

[GitBox]

rhtyd commented on a change in pull request #2465: CLOUDSTACK-10232: SystemVMs 
and VR to run as HVM on XenServer
URL: https://github.com/apache/cloudstack/pull/2465#discussion_r185440771
 
 

 ##
 File path: systemvm/debian/opt/cloud/bin/setup/cloud-early-config
 ##
 @@ -64,10 +71,17 @@ config_guest() {
 
 get_boot_params() {
   case $HYPERVISOR in
- xen-domU|xen-hvm)
+ xen-pv)
   cat /proc/cmdline > $CMDLINE
   sed -i "s/%/ /g" $CMDLINE
   ;;
+ xen-hvm)
+  if [ ! -f /usr/sbin/xenstore-read ]; then
+log_it "ERROR: xentools not installed, cannot found xenstore-read" 
&& exit 5
+  fi
+  /usr/sbin/xenstore-read vm-data/cloudstack/init > 
/var/cache/cloud/cmdline
 
 Review comment:
   @khos2ow in 4.11 systemvmtemplate, the xenstore-read is at /usr/bin, can you 
check/comment why /usr/sbin was used? I've however, fixed this blocker in the 
stabilization PR: 
https://github.com/shapeblue/cloudstack/commit/3dbb2e6b4b98cba9d59b241bd0a8c2a051131cbc


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2473: CLOUDSTACK-10309 Add option on if to VM HA power-on a OOB-shut-off-VM

[GitBox]

blueorangutan commented on issue #2473: CLOUDSTACK-10309 Add option on if to VM 
HA power-on a OOB-shut-off-VM
URL: https://github.com/apache/cloudstack/pull/2473#issuecomment-385918272
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1991


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2473: CLOUDSTACK-10309 Add option on if to VM HA power-on a OOB-shut-off-VM

[GitBox]

blueorangutan commented on issue #2473: CLOUDSTACK-10309 Add option on if to VM 
HA power-on a OOB-shut-off-VM
URL: https://github.com/apache/cloudstack/pull/2473#issuecomment-385910924
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2473: CLOUDSTACK-10309 Add option on if to VM HA power-on a OOB-shut-off-VM

[GitBox]

rhtyd commented on issue #2473: CLOUDSTACK-10309 Add option on if to VM HA 
power-on a OOB-shut-off-VM
URL: https://github.com/apache/cloudstack/pull/2473#issuecomment-385910875
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2116: CLOUDSTACK-8959: Option to attach the config drive

[GitBox]

rhtyd commented on issue #2116: CLOUDSTACK-8959: Option to attach the config 
drive
URL: https://github.com/apache/cloudstack/pull/2116#issuecomment-385908508
 
 
   @DaanHoogland @fmaximus @jayapalu ping, can you comment if this PR was 
already included in any other PR, or we still need this PR towards the config 
drive feature?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2473: CLOUDSTACK-10309 Add option on if to VM HA power-on a OOB-shut-off-VM

[GitBox]

blueorangutan commented on issue #2473: CLOUDSTACK-10309 Add option on if to VM 
HA power-on a OOB-shut-off-VM
URL: https://github.com/apache/cloudstack/pull/2473#issuecomment-385901746
 
 
   Packaging result: ✔centos6 ✖centos7 ✖debian. JID-1990


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2600: CLOUDSTACK-10362: Change the "getXXX" method names to "isXXX".

[GitBox]

blueorangutan commented on issue #2600: CLOUDSTACK-10362: Change the "getXXX" 
method names to "isXXX".
URL: https://github.com/apache/cloudstack/pull/2600#issuecomment-385901557
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1989


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #1940: CLOUDSTACK-9781:ACS records ID in events tables instead of UUID.

[GitBox]

rhtyd commented on issue #1940: CLOUDSTACK-9781:ACS records ID in events tables 
instead of UUID.
URL: https://github.com/apache/cloudstack/pull/1940#issuecomment-385895269
 
 
   The only new issue/failure I see is 
`test_11_migrate_volume_and_change_offering`. @jayantpatil1234 can you check if 
this error is caused by your PR /cc @rafaelweingartner @DaanHoogland 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2399: CLOUDSTACK-10223 delete snapshots when deleting domain

[GitBox]

blueorangutan commented on issue #2399: CLOUDSTACK-10223 delete snapshots when 
deleting domain
URL: https://github.com/apache/cloudstack/pull/2399#issuecomment-385894554
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on issue #2473: CLOUDSTACK-10309 Add option on if to VM HA power-on a OOB-shut-off-VM

[GitBox]

DaanHoogland commented on issue #2473: CLOUDSTACK-10309 Add option on if to VM 
HA power-on a OOB-shut-off-VM
URL: https://github.com/apache/cloudstack/pull/2473#issuecomment-385894396
 
 
   @rhtyd @rafaelweingartner , i just revisited the code and stand by my the 
lgtm.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2399: CLOUDSTACK-10223 delete snapshots when deleting domain

[GitBox]

rhtyd commented on issue #2399: CLOUDSTACK-10223 delete snapshots when deleting 
domain
URL: https://github.com/apache/cloudstack/pull/2399#issuecomment-385894307
 
 
   LGTM, let me re-run again.
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on issue #2607: Allow changing disk offering of VMs' root volume during volume migration

[GitBox]

DaanHoogland commented on issue #2607: Allow changing disk offering of VMs' 
root volume during volume migration
URL: https://github.com/apache/cloudstack/pull/2607#issuecomment-385893385
 
 
   @rafaelweingartner some of the errors above seem related to your changes, do 
you have time to check them?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] 01/01: Merge branch '4.11'

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit 5df580ef64a0dca92012dd7d1f68ab413e5f66ac
Merge: c6b4467 314caff
Author: Rohit Yadav 
AuthorDate: Wed May 2 13:18:29 2018 +0530

Merge branch '4.11'


-- 
To stop receiving notification emails like this one, please contact
ro...@apache.org.