(cloudstack) branch dummy updated (d7c90f21d03 -> b224003a520)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch dummy in repository https://gitbox.apache.org/repos/asf/cloudstack.git discard d7c90f21d03 do not merge add 969e094419d server: improve stats collector logs to state what the collector does (#8387) add 6d916cad348 Merge remote-tracking branch 'origin/4.18' add b224003a520 do not merge This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (d7c90f21d03) \ N -- N -- N refs/heads/dummy (b224003a520) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes: server/src/main/java/com/cloud/server/StatsCollector.java | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-)
Re: [PR] CleanUp Async Jobs after mgmt server maintenance [cloudstack]
blueorangutan commented on PR #8394: URL: https://github.com/apache/cloudstack/pull/8394#issuecomment-1865809820 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8111 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Cloudstack virtual machines can't communicate with virtual routers when they are on different hosts [cloudstack]
weizhouapache closed issue #8360: Cloudstack virtual machines can't communicate with virtual routers when they are on different hosts URL: https://github.com/apache/cloudstack/issues/8360 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Cloudstack virtual machines can't communicate with virtual routers when they are on different hosts [cloudstack]
weizhouapache commented on issue #8360: URL: https://github.com/apache/cloudstack/issues/8360#issuecomment-1865809774 thanks for the update @herdiansah571 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Normalize loggers and upgrade log4j 1.2 to log4j 2.19 [cloudstack]
github-actions[bot] commented on PR #7131: URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1865809457 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch 4.18-dummy updated (a361982334e -> fa1c05ca49c)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch 4.18-dummy in repository https://gitbox.apache.org/repos/asf/cloudstack.git discard a361982334e don't merge add 969e094419d server: improve stats collector logs to state what the collector does (#8387) add fa1c05ca49c don't merge This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (a361982334e) \ N -- N -- N refs/heads/4.18-dummy (fa1c05ca49c) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes: server/src/main/java/com/cloud/server/StatsCollector.java | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-)
(cloudstack) branch main updated (1411da1a22b -> 6d916cad348)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 1411da1a22b Add e2e tests for listing resources (#8281) add 969e094419d server: improve stats collector logs to state what the collector does (#8387) new 6d916cad348 Merge remote-tracking branch 'origin/4.18' The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: server/src/main/java/com/cloud/server/StatsCollector.java | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-)
(cloudstack) 01/01: Merge remote-tracking branch 'origin/4.18'
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit 6d916cad348f5833a567c17f5c9dbccaf2135448 Merge: 1411da1a22b 969e094419d Author: Rohit Yadav AuthorDate: Thu Dec 21 13:18:51 2023 +0530 Merge remote-tracking branch 'origin/4.18' server/src/main/java/com/cloud/server/StatsCollector.java | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-)
Re: [PR] Fixup test_list_volumes.py failure [cloudstack]
blueorangutan commented on PR #8392: URL: https://github.com/apache/cloudstack/pull/8392#issuecomment-1865804979 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8110 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch 4.18 updated: server: improve stats collector logs to state what the collector does (#8387)
This is an automated email from the ASF dual-hosted git repository.
shwstppr pushed a commit to branch 4.18
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/4.18 by this push:
new 969e094419d server: improve stats collector logs to state what the
collector does (#8387)
969e094419d is described below
commit 969e094419d66fab925d1185c3c2551bf22ad407
Author: Rohit Yadav
AuthorDate: Thu Dec 21 13:06:32 2023 +0530
server: improve stats collector logs to state what the collector does
(#8387)
This simply improves the log statement that prints debug statements
during beginning of a stats collector run for hosts or VMs.
Signed-off-by: Rohit Yadav
---
server/src/main/java/com/cloud/server/StatsCollector.java | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/server/src/main/java/com/cloud/server/StatsCollector.java
b/server/src/main/java/com/cloud/server/StatsCollector.java
index 91410198e2f..19820093f3a 100644
--- a/server/src/main/java/com/cloud/server/StatsCollector.java
+++ b/server/src/main/java/com/cloud/server/StatsCollector.java
@@ -644,13 +644,12 @@ public class StatsCollector extends ManagerBase
implements ComponentMethodInterc
@Override
protected void runInContext() {
try {
-LOGGER.debug("HostStatsCollector is running...");
-
SearchCriteria sc =
createSearchCriteriaForHostTypeRoutingStateUpAndNotInMaintenance();
-
-Map metrics = new HashMap<>();
List hosts = _hostDao.search(sc, null);
+LOGGER.debug(String.format("HostStatsCollector is running to
process %d UP hosts", hosts.size()));
+
+Map metrics = new HashMap<>();
for (HostVO host : hosts) {
HostStatsEntry hostStatsEntry = (HostStatsEntry)
_resourceMgr.getHostStatistics(host.getId());
if (hostStatsEntry != null) {
@@ -1192,13 +1191,12 @@ public class StatsCollector extends ManagerBase
implements ComponentMethodInterc
@Override
protected void runInContext() {
try {
-LOGGER.trace("VmStatsCollector is running...");
-
SearchCriteria sc =
createSearchCriteriaForHostTypeRoutingStateUpAndNotInMaintenance();
List hosts = _hostDao.search(sc, null);
-Map metrics = new HashMap<>();
+LOGGER.debug(String.format("VmStatsCollector is running to
process VMs across %d UP hosts", hosts.size()));
+Map metrics = new HashMap<>();
for (HostVO host : hosts) {
Date timestamp = new Date();
Map vmMap =
getVmMapForStatsForHost(host);
Re: [PR] server: improve stats collector logs to state what the collector does [cloudstack]
shwstppr merged PR #8387: URL: https://github.com/apache/cloudstack/pull/8387 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] vpc: optimize createMonitorServiceCommand() execution [cloudstack]
blueorangutan commented on PR #8385: URL: https://github.com/apache/cloudstack/pull/8385#issuecomment-1865771509 @harikrishna-patnala a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] vpc: optimize createMonitorServiceCommand() execution [cloudstack]
harikrishna-patnala commented on PR #8385: URL: https://github.com/apache/cloudstack/pull/8385#issuecomment-1865769600 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fixup test_list_volumes.py failure [cloudstack]
blueorangutan commented on PR #8392: URL: https://github.com/apache/cloudstack/pull/8392#issuecomment-1865745815 @vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fixup test_list_volumes.py failure [cloudstack]
vishesh92 commented on PR #8392: URL: https://github.com/apache/cloudstack/pull/8392#issuecomment-1865744848 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CleanUp Async Jobs after mgmt server maintenance [cloudstack]
harikrishna-patnala commented on code in PR #8394: URL: https://github.com/apache/cloudstack/pull/8394#discussion_r1433619783 ## framework/jobs/src/main/java/org/apache/cloudstack/framework/jobs/impl/AsyncJobManagerImpl.java: ## @@ -35,12 +35,22 @@ import javax.inject.Inject; import javax.naming.ConfigurationException; +import com.cloud.network.Network; Review Comment: can you reorder this please ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CleanUp Async Jobs after mgmt server maintenance [cloudstack]
blueorangutan commented on PR #8394: URL: https://github.com/apache/cloudstack/pull/8394#issuecomment-1865650945 @harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CleanUp Async Jobs after mgmt server maintenance [cloudstack]
harikrishna-patnala commented on PR #8394: URL: https://github.com/apache/cloudstack/pull/8394#issuecomment-1865646801 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fixup test_list_volumes.py failure [cloudstack]
blueorangutan commented on PR #8392: URL: https://github.com/apache/cloudstack/pull/8392#issuecomment-1865641034 @shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fixup test_list_volumes.py failure [cloudstack]
shwstppr commented on PR #8392: URL: https://github.com/apache/cloudstack/pull/8392#issuecomment-1865639667 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CleanUp Async Jobs after mgmt server maintenance [cloudstack]
codecov[bot] commented on PR #8394: URL: https://github.com/apache/cloudstack/pull/8394#issuecomment-1865616137 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8394?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Comparison is base [(`1411da1`)](https://app.codecov.io/gh/apache/cloudstack/commit/1411da1a22bc6aa26634f3038475e3d5fbbcd6bb?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) 30.88% compared to head [(`c4cb6be`)](https://app.codecov.io/gh/apache/cloudstack/pull/8394?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) 4.39%. Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #8394 +/- ## - Coverage 30.88% 4.39% -26.49% Files 5341 361 -4980 Lines374861 28622 -346239 Branches 545184992-49526 - Hits 1157691258 -114511 + Misses 243825 27225 -216600 + Partials 15267 139-15128 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/8394/flags?src=pr=flags_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Coverage Δ | | |---|---|---| | [simulator-marvin-tests](https://app.codecov.io/gh/apache/cloudstack/pull/8394/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `?` | | | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/8394/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `4.39% <ø> (ø)` | | | [unit-tests](https://app.codecov.io/gh/apache/cloudstack/pull/8394/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/8394?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fixup test_list_volumes.py failure [cloudstack]
blueorangutan commented on PR #8392: URL: https://github.com/apache/cloudstack/pull/8392#issuecomment-1865610141 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8109 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] server: improve stats collector logs to state what the collector does [cloudstack]
blueorangutan commented on PR #8387: URL: https://github.com/apache/cloudstack/pull/8387#issuecomment-1865602079 [SF] Trillian test result (tid-8649) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 39924 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8387-t8649-kvm-centos7.zip Smoke tests completed. 109 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] CleanUp Async Jobs after mgmt server maintenance [cloudstack]
kishankavala opened a new pull request, #8394:
URL: https://github.com/apache/cloudstack/pull/8394
### Description
This PR fixes moves resources stuck in transition state during async job
cleanup
Problem:
During maintenance of the management server, other servers in the cluster or
the same server after a restart initiate async job cleanup. However, this
process leaves resources in a transitional state. The only recovery option
currently available is to make direct database changes.
Solution:
This PR introduces a resolution by changing Volume, Virtual Machine, and
Network resources from their transitional states. This adjustment enables the
reattempt of failed operations without the need for manual database
modifications.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [X] Minor
Bug Severity
- [ ] BLOCKER
- [X] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
Tested manually and with unit tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Fixup test_list_volumes.py failure [cloudstack]
sureshanaparti commented on PR #8392: URL: https://github.com/apache/cloudstack/pull/8392#issuecomment-1865528461 @vishesh92 can you update the description (about the issue, fix) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fixup test_list_volumes.py failure [cloudstack]
sureshanaparti commented on code in PR #8392: URL: https://github.com/apache/cloudstack/pull/8392#discussion_r1433548007 ## test/integration/smoke/test_list_volumes.py: ## @@ -140,6 +140,26 @@ def setUpClass(cls): def tearDownClass(cls): super(TestListVolumes, cls).tearDownClass() +@classmethod +def wait_for_volume_cleanup(cls): +"""Clean up volumes that were left by previous tests Review Comment: ```suggestion """Wait for volumes to clean up that were left by previous tests ``` this doesn't cleanup, waiting for earlier volumes to tear down. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] test: additional check to ensure hosts are left in up state [cloudstack]
blueorangutan commented on PR #8383: URL: https://github.com/apache/cloudstack/pull/8383#issuecomment-1865516551 [SF] Trillian test result (tid-8648) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 40634 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8383-t8648-kvm-centos7.zip Smoke tests completed. 109 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fixup test_list_volumes.py failure [cloudstack]
codecov[bot] commented on PR #8392: URL: https://github.com/apache/cloudstack/pull/8392#issuecomment-1865505110 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8392?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Comparison is base [(`1411da1`)](https://app.codecov.io/gh/apache/cloudstack/commit/1411da1a22bc6aa26634f3038475e3d5fbbcd6bb?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) 30.88% compared to head [(`8ce45a3`)](https://app.codecov.io/gh/apache/cloudstack/pull/8392?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) 4.39%. Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #8392 +/- ## - Coverage 30.88% 4.39% -26.49% Files 5341 361 -4980 Lines374861 28622 -346239 Branches 545184992-49526 - Hits 1157691258 -114511 + Misses 243825 27225 -216600 + Partials 15267 139-15128 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/8392/flags?src=pr=flags_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Coverage Δ | | |---|---|---| | [simulator-marvin-tests](https://app.codecov.io/gh/apache/cloudstack/pull/8392/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `?` | | | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/8392/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `4.39% <ø> (ø)` | | | [unit-tests](https://app.codecov.io/gh/apache/cloudstack/pull/8392/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/8392?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] Linstor primary storages are not created for disabled hosts [cloudstack]
rajujith opened a new issue, #8393: URL: https://github.com/apache/cloudstack/issues/8393 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ primary storage Linstor ~~~ # CLOUDSTACK VERSION ~~~ 4.18.1 ~~~ # CONFIGURATION Linstor # OS / ENVIRONMENT # SUMMARY When adding a linstor primary storage it not added for disabled host i.e missing the entries in the table 'storage_pool_host_ref'. Once the host is enabled later the host can't be used to deploy to this primary storage. The issue appears likewise when a host is added when a linstor primary storage is disabled. # STEPS TO REPRODUCE ~~~ 1. Disable a host in a cluster 2. Add a linstor primary storage 3. Check the table storage_pool_host_ref or enable the host and try a new instance deployment ( check the logs to confirm) or use tags to force it. ~~~ # EXPECTED RESULTS ~~~ Disabled host/primary storage needs to be considered while adding host/primary storage. ~~~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fixup test_list_volumes.py failure [cloudstack]
blueorangutan commented on PR #8392: URL: https://github.com/apache/cloudstack/pull/8392#issuecomment-1865499296 @vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fixup test_list_volumes.py failure [cloudstack]
vishesh92 commented on PR #8392: URL: https://github.com/apache/cloudstack/pull/8392#issuecomment-1865498408 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Fixup test_list_volumes.py failure [cloudstack]
vishesh92 opened a new pull request, #8392:
URL: https://github.com/apache/cloudstack/pull/8392
### Description
This PR...
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
How did you try to break this feature and the system with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [I] Management server metrics only shows on 1 GUI at a time [cloudstack]
rajujith commented on issue #8235: URL: https://github.com/apache/cloudstack/issues/8235#issuecomment-1865489136 @Tbaugus44 like @DaanHoogland mentioned there could be some stale records for the same management server, try this: `select id,msid,name,state,last_update from mshost where removed is null;` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.18 LTS Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #7345: URL: https://github.com/apache/cloudstack/pull/7345#issuecomment-1865480123 [SF] Trillian test result (tid-8645) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8 Total time taken: 58108 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7345-t8645-vmware-67u3.zip Smoke tests completed. 107 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_03_vpc_internallb_haproxy_stats_on_all_interfaces | `Failure` | 237.23 | test_internal_lb.py test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Error` | 939.54 | test_vpc_redundant.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Option to create StorPool primary storage with a valid URL [cloudstack]
sureshanaparti commented on code in PR #8356:
URL: https://github.com/apache/cloudstack/pull/8356#discussion_r1433486324
##
plugins/storage/volume/storpool/src/main/java/org/apache/cloudstack/storage/datastore/util/StorPoolUtil.java:
##
@@ -240,6 +246,13 @@ public SpConnectionDesc(String url) {
}
}
+private void extractUriParams(String url) throws URISyntaxException {
+URI uri = new URI(url);
Review Comment:
@slavkap new format
(_storpool://{SP_AUTH_TOKEN}@{SP_API_HTTP}:{SP_API_HTTP_PORT}/{SP_TEMPLATE}_)
has the scheme, so assuming it would be mentioned while creating StorPool
primary storage. So, any scheme is accepted now, eg. _nfs://, powerflex://,
xyz://_ as it is ignored.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Change password.policy.regex default to empty [cloudstack]
sureshanaparti commented on code in PR #8370:
URL: https://github.com/apache/cloudstack/pull/8370#discussion_r1433479556
##
server/src/main/java/com/cloud/user/PasswordPolicyImpl.java:
##
@@ -188,12 +188,12 @@ protected void validateIfPasswordMatchesRegex(String
password, String username,
logger.trace(String.format("Validating if the new password for user
[%s] matches regex [%s] defined in the configuration [%s].",
username, passwordPolicyRegex, PasswordPolicyRegex.key()));
-if (passwordPolicyRegex == null){
+if (StringUtils.isBlank(passwordPolicyRegex)) {
logger.trace(String.format("Regex is null; therefore, we will not
validate if the new password matches with regex for user [%s].", username));
return;
}
-if (!password.matches(passwordPolicyRegex)){
+if (!password.matches(passwordPolicyRegex)) {
Review Comment:
> @sureshanaparti All the password policies are applied only on user/account
creation or password change. They are not validated on log in.
ok, thanks for the update @JoaoJandre
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] remove StorPool tags from detached volumes [cloudstack]
sureshanaparti commented on code in PR #8377:
URL: https://github.com/apache/cloudstack/pull/8377#discussion_r1433478710
##
plugins/storage/volume/storpool/src/main/java/org/apache/cloudstack/storage/datastore/util/StorPoolUtil.java:
##
@@ -517,7 +517,13 @@ public static SpApiResponse volumeUpdate(final String
name, final Long newSize,
return POST("MultiCluster/VolumeUpdate/" + name, json, conn);
}
-public static SpApiResponse volumeUpdateTags(final String name, final
String uuid, Long iops,
+public static SpApiResponse volumeRemoveTags(String name, Map tags, SpConnectionDesc conn) {
+Map json = new HashMap<>();
Review Comment:
@slavkap Better to create empty tags map here, instead of passing it to
indicate removal of tags in the method, otherwise it's like an update tags.
_Map tags = StorPoolHelper.addStorPoolTags(null, "", null,
"");_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [I] Cloudstack virtual machines can't communicate with virtual routers when they are on different hosts [cloudstack]
herdiansah571 commented on issue #8360: URL: https://github.com/apache/cloudstack/issues/8360#issuecomment-1865454056 Hello @weizhouapache Currently Cloudstack virtual machines can communicate with virtual routers when they are on different hosts after configure VLAN Trunks on physical switch port. thank you for provide me an explanation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Option to create StorPool primary storage with a valid URL [cloudstack]
blueorangutan commented on PR #8356: URL: https://github.com/apache/cloudstack/pull/8356#issuecomment-1865422925 [SF] Trillian test result (tid-8647) Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9 Total time taken: 52392 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8356-t8647-kvm-alma9.zip Smoke tests completed. 125 look OK, 3 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_11_destroy_ssvm | `Failure` | 918.66 | test_ssvm.py test_05_list_volumes_isrecursive | `Failure` | 0.04 | test_list_volumes.py test_07_list_volumes_listall | `Failure` | 0.04 | test_list_volumes.py test_01_migrate_VM_and_root_volume | `Error` | 91.61 | test_vm_life_cycle.py test_02_migrate_VM_with_two_data_disks | `Error` | 51.02 | test_vm_life_cycle.py test_08_migrate_vm | `Error` | 46.12 | test_vm_life_cycle.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.19/main Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #7344: URL: https://github.com/apache/cloudstack/pull/7344#issuecomment-1865417199 [SF] Trillian test result (tid-8642) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8 Total time taken: 55967 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7344-t8642-vmware-67u3.zip Smoke tests completed. 127 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_08_upgrade_kubernetes_ha_cluster | `Failure` | 646.73 | test_kubernetes_clusters.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.19/main Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #7344: URL: https://github.com/apache/cloudstack/pull/7344#issuecomment-1865318631 [SF] Trillian test result (tid-8641) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 46694 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7344-t8641-xenserver-71.zip Smoke tests completed. 127 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_05_list_volumes_isrecursive | `Failure` | 0.03 | test_list_volumes.py test_07_list_volumes_listall | `Failure` | 0.03 | test_list_volumes.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.18 LTS Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #7345: URL: https://github.com/apache/cloudstack/pull/7345#issuecomment-1865306450 [SF] Trillian test result (tid-8644) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 41648 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7345-t8644-xenserver-71.zip Smoke tests completed. 109 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.19/main Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #7344: URL: https://github.com/apache/cloudstack/pull/7344#issuecomment-1865300504 [SF] Trillian test result (tid-8643) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 44910 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7344-t8643-kvm-centos7.zip Smoke tests completed. 127 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_05_list_volumes_isrecursive | `Failure` | 0.03 | test_list_volumes.py test_07_list_volumes_listall | `Failure` | 0.02 | test_list_volumes.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Veeam: Support Veeam 11 and 12 [cloudstack]
blueorangutan commented on PR #8241: URL: https://github.com/apache/cloudstack/pull/8241#issuecomment-1865280063 @weizhouapache a [LL] Trillian-Jenkins test job (rocky8 mgmt + vmware-70u3) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Veeam: Support Veeam 11 and 12 [cloudstack]
weizhouapache commented on PR #8241: URL: https://github.com/apache/cloudstack/pull/8241#issuecomment-1865278641 @blueorangutan LLtest rocky8 vmware-70u3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Veeam: Support Veeam 11 and 12 [cloudstack]
blueorangutan commented on PR #8241: URL: https://github.com/apache/cloudstack/pull/8241#issuecomment-1865273902 [LL]Trillian test result (tid-6902) Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server r8 Total time taken: 48743 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8241-t6902-vmware-70u3.zip Smoke tests completed. 107 look OK, 3 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_add_primary_storage_disabled_host | `Error` | 35.23 | test_primary_storage.py test_01_invalid_upgrade_kubernetes_cluster | `Failure` | 0.01 | test_kubernetes_clusters.py test_02_upgrade_kubernetes_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py test_04_autoscale_kubernetes_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py test_05_basic_lifecycle_kubernetes_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py test_06_delete_kubernetes_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py test_07_deploy_kubernetes_ha_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py test_08_upgrade_kubernetes_ha_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py test_09_delete_kubernetes_ha_cluster | `Failure` | 0.01 | test_kubernetes_clusters.py test_10_vpc_tier_kubernetes_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py test_list_system_vms_metrics_history | `Failure` | 0.18 | test_metrics_api.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] Improvement on collecting/updating Secondary Storage total size/capacity [cloudstack]
andrijapanicsb opened a new issue, #8391: URL: https://github.com/apache/cloudstack/issues/8391 Improvement request: - the capacity of the Secondary Storage seem updated/obtained from time to time, by SSVMs and the value (capacity) is held in the memory of the mgmt server. In certain cases, this becomes a very... useless... design, where the values can not be altered in case of edge cases where the Secondary Storage capacity needs to be expanded, but SSVMs are not running/existing, for whatever reason. Proposal: - store the capacity of the SS in the DB (perhaps op_host_capacity table, like for the Primary data, and other resource values) - Enable a global setting that will control the interval of the capacity collection from the NFS Secondary Storage - Consider offloading the work to the mgmt server, as per architecture design, all mgmt servers MUST be able to mount the secondary storage NFS shares (for various other tasks) - Consider implementing an explicit API call that will trigger updating the SS NFS capacities (in cases where the backend capacity has been expanded) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] VMware: VMs can't be started when no secondary storage with enough capacity + wrong messages around secondary storage [cloudstack]
andrijapanicsb opened a new issue, #8390: URL: https://github.com/apache/cloudstack/issues/8390 An environment with 2 Secondary Storages - both over 90% full (global setting set's the treshold to 0.9) While ACS tries to start a VM (SSVM in this case) - it fails to start it with the following log messages - note that it also says that Secondary Storage is not of NFS type, then it looks for staging (assumes Object based Secondary Storage, obviously), which is not true. Note the Secondary Storages are NOT deleted, ACS reports something like that, due to what seems to be yet another bug in the code, or an awful logging message at least. 1. There should be ZERO dependency during staring a VM on the space available on Secondary Storage(s) - zero data is written to it, this is design bug. Even worst, if SSVMs are destroyed, ACS can't start them due to no SS with enough space, so even if you have increased the Secondary Storage space on the backedn storage, it's can't be read/updated inside ACS while SSVMs are down/not existing. 2. Image store message needs to be corrected (there are no object-based SS in this env) - "Secondary storage is not NFS, we need to use staging storage" and related messages 3. "failed to get message for exception: secondary storage for dc 5 is not ready yet?" should be properly rewriten to send a clear message that there are no NFS-based secondary storage with enough capacity, under 90% full by default, etc ``` 2023-12-20 18:39:01,303 INFO [c.c.h.v.m.VirtualMachineMO] (DirectAgent-134:ctx-16031b08 vdc-lon8-esx02.esx.lon8.my.domain, cmd: GetVolumeStatsCommand) (logid:5e70aef9) Look for disk device info from volume : ROOT-511897_2.vmdk with base name: ROOT-511897_2 2023-12-20 18:39:01,303 INFO [c.c.h.v.m.VirtualMachineMO] (DirectAgent-134:ctx-16031b08 vdc-lon8-esx02.esx.lon8.my.domain, cmd: GetVolumeStatsCommand) (logid:5e70aef9) Test against disk device, controller key: 1000, unit number: 0 2023-12-20 18:39:01,303 INFO [c.c.h.v.m.VirtualMachineMO] (DirectAgent-134:ctx-16031b08 vdc-lon8-esx02.esx.lon8.my.domain, cmd: GetVolumeStatsCommand) (logid:5e70aef9) Test against disk backing : [lon8_EBS_PRM01] r-511897-VM/ROOT-511897_2.vmdk 2023-12-20 18:39:01,303 INFO [c.c.h.v.m.VirtualMachineMO] (DirectAgent-134:ctx-16031b08 vdc-lon8-esx02.esx.lon8.my.domain, cmd: GetVolumeStatsCommand) (logid:5e70aef9) Disk backing : [lon8_EBS_PRM01] r-511897-VM/ROOT-511897_2.vmdk matches ==> scsi0:0 2023-12-20 18:39:01,310 DEBUG [c.c.h.v.m.DatastoreMO] (DirectAgent-134:ctx-16031b08 vdc-lon8-esx02.esx.lon8.my.domain, cmd: GetVolumeStatsCommand) (logid:5e70aef9) Search file ROOT-511897_2.vmdk on [lon8_EBS_PRM01] r-511897-VM 2023-12-20 18:39:01,338 DEBUG [c.c.h.v.m.DatastoreMO] (DirectAgent-134:ctx-16031b08 vdc-lon8-esx02.esx.lon8.my.domain, cmd: GetVolumeStatsCommand) (logid:5e70aef9) File found = ROOT-511897_2.vmdk, size=(1.76 GB) 1891631104 2023-12-20 18:39:01,343 WARN [c.c.h.v.r.VmwareResource] (DirectAgent-448:ctx-a4188b3c vdc-ams24-esx08.esx.ams24.my.domain, job-13161936/job-13236627, cmd: StartCommand) (logid:3b93f48e) hotadd of memory is not supported, dynamic scaling feature can not be applied to vm: s-512269-VM 2023-12-20 18:39:01,418 WARN [c.c.h.v.r.VmwareResource] (DirectAgent-448:ctx-a4188b3c vdc-ams24-esx08.esx.ams24.my.domain, job-13161936/job-13236627, cmd: StartCommand) (logid:3b93f48e) hotadd of cpu is not supported, dynamic scaling feature can not be applied to vm: s-512269-VM 2023-12-20 18:39:01,430 DEBUG [c.c.s.StatsCollector] (DirectAgent-448:ctx-a4188b3c vdc-ams24-esx08.esx.ams24.my.domain, job-13161936/job-13236627, cmd: StartCommand) (logid:3b93f48e) Verifying image storage [38]. Capacity: total=[50 TB], used=[46 TB], threshold=[89.9761581421%]. 2023-12-20 18:39:01,430 WARN [c.c.s.StatsCollector] (DirectAgent-448:ctx-a4188b3c vdc-ams24-esx08.esx.ams24.my.domain, job-13161936/job-13236627, cmd: StartCommand) (logid:3b93f48e) Image storage [38] has not enough capacity. Capacity: total=[50 TB], used=[46 TB], threshold=[89.9761581421%]. 2023-12-20 18:39:01,431 DEBUG [c.c.s.StatsCollector] (DirectAgent-448:ctx-a4188b3c vdc-ams24-esx08.esx.ams24.my.domain, job-13161936/job-13236627, cmd: StartCommand) (logid:3b93f48e) Verifying image storage [28]. Capacity: total=[90 TB], used=[82 TB], threshold=[89.9761581421%]. 2023-12-20 18:39:01,431 WARN [c.c.s.StatsCollector] (DirectAgent-448:ctx-a4188b3c vdc-ams24-esx08.esx.ams24.my.domain, job-13161936/job-13236627, cmd: StartCommand) (logid:3b93f48e) Image storage [28] has not enough capacity. Capacity: total=[90 TB], used=[82 TB], threshold=[89.9761581421%]. 2023-12-20 18:39:01,431 INFO [c.c.h.v.m.VmwareManagerImpl] (DirectAgent-448:ctx-a4188b3c vdc-ams24-esx08.esx.ams24.my.domain, job-13161936/job-13236627, cmd: StartCommand) (logid:3b93f48e) Secondary storage is not NFS, we need to use
Re: [PR] server: fix debug message when expunge a vm [cloudstack]
blueorangutan commented on PR #8374: URL: https://github.com/apache/cloudstack/pull/8374#issuecomment-1865028605 [SF] Trillian test result (tid-8639) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 47391 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8374-t8639-kvm-centos7.zip Smoke tests completed. 107 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_08_upgrade_kubernetes_ha_cluster | `Failure` | 576.75 | test_kubernetes_clusters.py test_08_migrate_vm | `Error` | 0.06 | test_vm_life_cycle.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] server: improve stats collector logs to state what the collector does [cloudstack]
blueorangutan commented on PR #8387: URL: https://github.com/apache/cloudstack/pull/8387#issuecomment-1864983753 @DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] server: improve stats collector logs to state what the collector does [cloudstack]
DaanHoogland commented on PR #8387: URL: https://github.com/apache/cloudstack/pull/8387#issuecomment-1864978125 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] prevent nic removal on out of bounds router stop [cloudstack]
DaanHoogland commented on code in PR #8371:
URL: https://github.com/apache/cloudstack/pull/8371#discussion_r1433064693
##
server/src/main/java/com/cloud/network/guru/ControlNetworkGuru.java:
##
@@ -166,18 +167,25 @@ public boolean release(NicProfile nic,
VirtualMachineProfile vm, String reservat
assert nic.getTrafficType() == TrafficType.Control;
HypervisorType hType = vm.getHypervisorType();
if ( ( (hType == HypervisorType.VMware) || (hType ==
HypervisorType.Hyperv) )&& isRouterVm(vm)) {
+// for now place this in the vmware specific part, but it miught
be more generic and move up two or three lines
+if
(!VirtualNetworkApplianceManager.RemoveNicsOnStop.valueIn(vm.getVirtualMachine().getDataCenterId()))
{
+if (s_logger.isDebugEnabled()) {
+s_logger.debug(String.format("not releasing %s\n\t from
%s\n\t with reservationId %s.", nic, vm, reservationId));
Review Comment:
debugging aid, easier to comare objects in the logs this way. Can remove
when finished.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] prevent nic removal on out of bounds router stop [cloudstack]
weizhouapache commented on code in PR #8371:
URL: https://github.com/apache/cloudstack/pull/8371#discussion_r1433034778
##
server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManager.java:
##
@@ -36,82 +36,83 @@
*/
public interface VirtualNetworkApplianceManager extends Manager,
VirtualNetworkApplianceService {
-static final String RouterTemplateXenCK = "router.template.xenserver";
-static final String RouterTemplateKvmCK = "router.template.kvm";
-static final String RouterTemplateVmwareCK = "router.template.vmware";
-static final String RouterTemplateHyperVCK = "router.template.hyperv";
-static final String RouterTemplateLxcCK = "router.template.lxc";
-static final String RouterTemplateOvm3CK = "router.template.ovm3";
-static final String SetServiceMonitorCK =
"network.router.EnableServiceMonitoring";
-static final String RouterAlertsCheckIntervalCK =
"router.alerts.check.interval";
-static final String VirtualRouterServiceOfferingCK =
"router.service.offering";
-
-static final String RouterHealthChecksConfigRefreshIntervalCK =
"router.health.checks.config.refresh.interval";
-static final String RouterHealthChecksResultFetchIntervalCK =
"router.health.checks.results.fetch.interval";
-static final String RouterHealthChecksFailuresToRecreateVrCK =
"router.health.checks.failures.to.recreate.vr";
-
-static final ConfigKey RouterTemplateXen = new
ConfigKey(String.class, RouterTemplateXenCK, "Advanced", "SystemVM
Template (XenServer)",
+String RouterTemplateXenCK = "router.template.xenserver";
+String RouterTemplateKvmCK = "router.template.kvm";
+String RouterTemplateVmwareCK = "router.template.vmware";
+String RouterTemplateHyperVCK = "router.template.hyperv";
+String RouterTemplateLxcCK = "router.template.lxc";
+String RouterTemplateOvm3CK = "router.template.ovm3";
+String SetServiceMonitorCK = "network.router.EnableServiceMonitoring";
+String RouterAlertsCheckIntervalCK = "router.alerts.check.interval";
+String VirtualRouterServiceOfferingCK = "router.service.offering";
+
+String RouterHealthChecksConfigRefreshIntervalCK =
"router.health.checks.config.refresh.interval";
+String RouterHealthChecksResultFetchIntervalCK =
"router.health.checks.results.fetch.interval";
+String RouterHealthChecksFailuresToRecreateVrCK =
"router.health.checks.failures.to.recreate.vr";
+String RemoveNicsOnStopCK = "ssvm.release.control.ip.on.stop";
Review Comment:
SystemVmReleaseControlIpOnStop
looks more accurate
##
server/src/main/java/com/cloud/network/guru/ControlNetworkGuru.java:
##
@@ -166,18 +167,25 @@ public boolean release(NicProfile nic,
VirtualMachineProfile vm, String reservat
assert nic.getTrafficType() == TrafficType.Control;
HypervisorType hType = vm.getHypervisorType();
if ( ( (hType == HypervisorType.VMware) || (hType ==
HypervisorType.Hyperv) )&& isRouterVm(vm)) {
+// for now place this in the vmware specific part, but it miught
be more generic and move up two or three lines
+if
(!VirtualNetworkApplianceManager.RemoveNicsOnStop.valueIn(vm.getVirtualMachine().getDataCenterId()))
{
+if (s_logger.isDebugEnabled()) {
+s_logger.debug(String.format("not releasing %s\n\t from
%s\n\t with reservationId %s.", nic, vm, reservationId));
Review Comment:
why \n\t is used here (and other lines)?
##
server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManager.java:
##
@@ -36,82 +36,83 @@
*/
public interface VirtualNetworkApplianceManager extends Manager,
VirtualNetworkApplianceService {
-static final String RouterTemplateXenCK = "router.template.xenserver";
-static final String RouterTemplateKvmCK = "router.template.kvm";
-static final String RouterTemplateVmwareCK = "router.template.vmware";
-static final String RouterTemplateHyperVCK = "router.template.hyperv";
-static final String RouterTemplateLxcCK = "router.template.lxc";
-static final String RouterTemplateOvm3CK = "router.template.ovm3";
-static final String SetServiceMonitorCK =
"network.router.EnableServiceMonitoring";
-static final String RouterAlertsCheckIntervalCK =
"router.alerts.check.interval";
-static final String VirtualRouterServiceOfferingCK =
"router.service.offering";
-
-static final String RouterHealthChecksConfigRefreshIntervalCK =
"router.health.checks.config.refresh.interval";
-static final String RouterHealthChecksResultFetchIntervalCK =
"router.health.checks.results.fetch.interval";
-static final String RouterHealthChecksFailuresToRecreateVrCK =
"router.health.checks.failures.to.recreate.vr";
-
-static final ConfigKey RouterTemplateXen = new
ConfigKey(String.class, RouterTemplateXenCK, "Advanced", "SystemVM
Template (XenServer)",
+String RouterTemplateXenCK =
Re: [PR] test: additional check to ensure hosts are left in up state [cloudstack]
blueorangutan commented on PR #8383: URL: https://github.com/apache/cloudstack/pull/8383#issuecomment-1864911698 @weizhouapache a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] test: additional check to ensure hosts are left in up state [cloudstack]
weizhouapache commented on PR #8383: URL: https://github.com/apache/cloudstack/pull/8383#issuecomment-1864909880 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] test: additional check to ensure hosts are left in up state [cloudstack]
blueorangutan commented on PR #8383: URL: https://github.com/apache/cloudstack/pull/8383#issuecomment-1864901686 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8106 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Template reported as Ready/Installed only based on the template_stor_ref, ignoring template_zone_ref [cloudstack]
andrijapanicsb commented on issue #8388: URL: https://github.com/apache/cloudstack/issues/8388#issuecomment-1864856382 I faced the issue when triggering template auto-install for ADDITIONAL zone, while (by mistake) the template was not marked as cross_zone=1 (it was =0) Not sure if this might be an isolated case and how this could be visible for other templates. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] test: additional check to ensure hosts are left in up state [cloudstack]
blueorangutan commented on PR #8383: URL: https://github.com/apache/cloudstack/pull/8383#issuecomment-1864819972 @shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] test: additional check to ensure hosts are left in up state [cloudstack]
shwstppr commented on PR #8383: URL: https://github.com/apache/cloudstack/pull/8383#issuecomment-1864813808 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] server: improve stats collector logs to state what the collector does [cloudstack]
blueorangutan commented on PR #8387: URL: https://github.com/apache/cloudstack/pull/8387#issuecomment-1864794955 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8105 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] server: improve stats collector logs to state what the collector does [cloudstack]
codecov[bot] commented on PR #8387: URL: https://github.com/apache/cloudstack/pull/8387#issuecomment-1864785118 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8387?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report Attention: `4 lines` in your changes are missing coverage. Please review. > Comparison is base [(`64ecd00`)](https://app.codecov.io/gh/apache/cloudstack/commit/64ecd00eb70531d177031b50e5c15f73668df6e8?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) 13.12% compared to head [(`57d8a38`)](https://app.codecov.io/gh/apache/cloudstack/pull/8387?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) 13.12%. | [Files](https://app.codecov.io/gh/apache/cloudstack/pull/8387?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Patch % | Lines | |---|---|---| | [...src/main/java/com/cloud/server/StatsCollector.java](https://app.codecov.io/gh/apache/cloudstack/pull/8387?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL3NlcnZlci9TdGF0c0NvbGxlY3Rvci5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/cloudstack/pull/8387?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Additional details and impacted files ```diff @@Coverage Diff@@ ## 4.18#8387 +/- ## = Coverage 13.12% 13.12% Complexity 9141 9141 = Files 2720 2720 Lines257723 257723 Branches 4017740177 = Hits 3383833838 Misses 219595 219595 Partials 4290 4290 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/8387?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [DRAFT] Add support for Ceph RGW Object Store [cloudstack]
codecov[bot] commented on PR #8389: URL: https://github.com/apache/cloudstack/pull/8389#issuecomment-1864784680 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8389?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Comparison is base [(`127fd9d`)](https://app.codecov.io/gh/apache/cloudstack/commit/127fd9d2f06ebb2938b482e95914a32ef788e57e?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) 30.78% compared to head [(`209332f`)](https://app.codecov.io/gh/apache/cloudstack/pull/8389?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) 4.39%. > Report is 9 commits behind head on main. Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #8389 +/- ## - Coverage 30.78% 4.39% -26.40% Files 5341 361 -4980 Lines374840 28622 -346218 Branches 545164992-49524 - Hits 1154121258 -114154 + Misses 244170 27225 -216945 + Partials 15258 139-15119 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/8389/flags?src=pr=flags_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Coverage Δ | | |---|---|---| | [simulator-marvin-tests](https://app.codecov.io/gh/apache/cloudstack/pull/8389/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `?` | | | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/8389/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `4.39% <ø> (ø)` | | | [unit-tests](https://app.codecov.io/gh/apache/cloudstack/pull/8389/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/8389?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] prevent nic removal on out of bounds router stop [cloudstack]
blueorangutan commented on PR #8371: URL: https://github.com/apache/cloudstack/pull/8371#issuecomment-1864777843 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8104 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [DRAFT] Add support for Ceph RGW Object Store [cloudstack]
wido opened a new pull request, #8389:
URL: https://github.com/apache/cloudstack/pull/8389
### Description
This PR adds support for the Ceph RGW as an Object Store Driver in CloudStack
### Types of changes
- [ x ] New feature (non-breaking change which adds functionality)
### Screenshots (if appropriate):
### How Has This Been Tested?
I have a local Ceph environment (IPv6 only) running with the RADOS Gateway
(S3 server) running against which I tested this PR.
It also has SSL enabled so it could verify that this works as expected.
How did you try to break this feature and the system with this change?
I manually tried to create and remove buckets and that worked as expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] vpc: optimize createMonitorServiceCommand() execution [cloudstack]
blueorangutan commented on PR #8385: URL: https://github.com/apache/cloudstack/pull/8385#issuecomment-1864754818 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8103 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Template reported as Ready/Installed only based on the template_stor_ref, ignoring template_zone_ref [cloudstack]
weizhouapache commented on issue #8388: URL: https://github.com/apache/cloudstack/issues/8388#issuecomment-1864691977 @andrijapanicsb did you face the issue in other scenario ? for example, add new zone ? I wonder if there is a way to reproduce the issue without manual db changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] server: improve stats collector logs to state what the collector does [cloudstack]
blueorangutan commented on PR #8387: URL: https://github.com/apache/cloudstack/pull/8387#issuecomment-1864677413 @rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] server: improve stats collector logs to state what the collector does [cloudstack]
rohityadavcloud commented on PR #8387: URL: https://github.com/apache/cloudstack/pull/8387#issuecomment-1864672568 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] Template reported as Ready/Installed only based on the template_stor_ref, ignoring template_zone_ref [cloudstack]
andrijapanicsb opened a new issue, #8388:
URL: https://github.com/apache/cloudstack/issues/8388
ACS 4.18.1
As the title says:
The template_zone_ref for the given template is missing/not present
The template_store_ref for the given template is present/populated.
ACS shows the template as Ready/Installed, while in reality, ACS consider it
absent in that Zone (when you try to use it) - due to missing zone ref records.
Reproduce the issue (with systemVM template specifically):
- Disable the zone, delete SSVM/CPVM
- in the DB, remove record for the systemVM template from the
template_zone_ref
- Enable the Zone, observer SSVM/CPVM created in DB but not started
- Observer the mgmt logs having error:
com.cloud.utils.exception.CloudRuntimeException: Unable to orchestrate start VM
instance
{"id":4,"instanceName":"v-4-VM","type":"ConsoleProxy","uuid":"c4bc6e96-d0ff-49ef-84c0-2e3f9d209092"}
due to [T**emplate for the VM instance can not be found in the zone ID: %s,**
VM instance configuration needs to be updated].
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] server: improve stats collector logs to state what the collector does [cloudstack]
rohityadavcloud opened a new pull request, #8387:
URL: https://github.com/apache/cloudstack/pull/8387
This simply improves the log statement that prints debug statements during
beginning of a stats collector run for hosts or VMs.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [x] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] remove StorPool tags from detached volumes [cloudstack]
DaanHoogland commented on code in PR #8377:
URL: https://github.com/apache/cloudstack/pull/8377#discussion_r1432836221
##
plugins/storage/volume/storpool/src/main/java/org/apache/cloudstack/storage/datastore/util/StorPoolUtil.java:
##
@@ -517,6 +517,12 @@ public static SpApiResponse volumeUpdate(final String
name, final Long newSize,
return POST("MultiCluster/VolumeUpdate/" + name, json, conn);
}
+public static SpApiResponse volumeUpadateTags(String name, Map tags, SpConnectionDesc conn) {
Review Comment:
:shrug:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[I] Port forwarding rules gets the same public port when creating port forwarding rules with CloudStack's API [cloudstack]
saffronjam opened a new issue, #8386: URL: https://github.com/apache/cloudstack/issues/8386 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ API for Virtual Router Port forwarding rules ~~~ # CLOUDSTACK VERSION ~~~ 4.18.1 ~~~ # CONFIGURATION Isolated network Source NAT with redundant router  # OS / ENVIRONMENT Ubuntu 22.04 My client is the Go client for CloudStack's API # SUMMARY Using the API I was able to create, what I think, is a race-condition for port forwarding rules that is not handled by the API. Two port forwarding rules ended up with the same public port, even though I should have received an error such as: "The range specified, 2502-2502, conflicts with ... ".  # STEPS TO REPRODUCE ~~~ Using the API create 2 port forwarding rules with same public port (for 2 different VMs in my case). ~~~ # EXPECTED RESULTS ~~~ Conflict error, that I can handle in my client using the CloudStack API. ~~~ # ACTUAL RESULTS ~~~ Two port forwarding rules created, with the same public port, for different VMs. Only one of them works of course. ~~~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] vpc: optimize createMonitorServiceCommand() execution [cloudstack]
blueorangutan commented on PR #8385: URL: https://github.com/apache/cloudstack/pull/8385#issuecomment-1864621821 @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] vpc: optimize createMonitorServiceCommand() execution [cloudstack]
weizhouapache commented on PR #8385: URL: https://github.com/apache/cloudstack/pull/8385#issuecomment-1864619273 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] remove StorPool tags from detached volumes [cloudstack]
slavkap commented on code in PR #8377:
URL: https://github.com/apache/cloudstack/pull/8377#discussion_r1432822793
##
plugins/storage/volume/storpool/src/main/java/org/apache/cloudstack/storage/datastore/util/StorPoolUtil.java:
##
@@ -517,6 +517,12 @@ public static SpApiResponse volumeUpdate(final String
name, final Long newSize,
return POST("MultiCluster/VolumeUpdate/" + name, json, conn);
}
+public static SpApiResponse volumeUpadateTags(String name, Map tags, SpConnectionDesc conn) {
Review Comment:
I renamed the method with the latest commit as Suresh suggested to
volumeRemoveTags
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] remove StorPool tags from detached volumes [cloudstack]
DaanHoogland commented on code in PR #8377:
URL: https://github.com/apache/cloudstack/pull/8377#discussion_r1432812725
##
plugins/storage/volume/storpool/src/main/java/org/apache/cloudstack/storage/datastore/util/StorPoolUtil.java:
##
@@ -517,6 +517,12 @@ public static SpApiResponse volumeUpdate(final String
name, final Long newSize,
return POST("MultiCluster/VolumeUpdate/" + name, json, conn);
}
+public static SpApiResponse volumeUpadateTags(String name, Map tags, SpConnectionDesc conn) {
Review Comment:
that seems ok, but the spello is still strange: volumeUpadateTags instead of
volumeUpdateTags?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] remove StorPool tags from detached volumes [cloudstack]
slavkap commented on code in PR #8377:
URL: https://github.com/apache/cloudstack/pull/8377#discussion_r1432774853
##
plugins/storage/volume/storpool/src/main/java/org/apache/cloudstack/storage/datastore/util/StorPoolUtil.java:
##
@@ -517,6 +517,12 @@ public static SpApiResponse volumeUpdate(final String
name, final Long newSize,
return POST("MultiCluster/VolumeUpdate/" + name, json, conn);
}
+public static SpApiResponse volumeUpadateTags(String name, Map tags, SpConnectionDesc conn) {
Review Comment:
@DaanHoogland, I will rename it as you both suggested. Still, I prefer to
leave it with a common name like the used StorPool API call even though now it
is used only to remove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] vpc: optimize createMonitorServiceCommand() execution [cloudstack]
codecov[bot] commented on PR #8385: URL: https://github.com/apache/cloudstack/pull/8385#issuecomment-1864514086 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8385?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Comparison is base [(`1411da1`)](https://app.codecov.io/gh/apache/cloudstack/commit/1411da1a22bc6aa26634f3038475e3d5fbbcd6bb?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) 30.88% compared to head [(`e34959f`)](https://app.codecov.io/gh/apache/cloudstack/pull/8385?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) 4.39%. Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #8385 +/- ## - Coverage 30.88% 4.39% -26.49% Files 5341 361 -4980 Lines374861 28622 -346239 Branches 545184992-49526 - Hits 1157691258 -114511 + Misses 243825 27225 -216600 + Partials 15267 139-15128 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/8385/flags?src=pr=flags_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Coverage Δ | | |---|---|---| | [simulator-marvin-tests](https://app.codecov.io/gh/apache/cloudstack/pull/8385/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `?` | | | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/8385/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `4.39% <ø> (ø)` | | | [unit-tests](https://app.codecov.io/gh/apache/cloudstack/pull/8385/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/8385?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] prevent nic removal on out of bounds router stop [cloudstack]
DaanHoogland commented on code in PR #8371:
URL: https://github.com/apache/cloudstack/pull/8371#discussion_r1432735875
##
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java:
##
@@ -2310,12 +2311,12 @@ public void releaseNic(final VirtualMachineProfile
vmProfile, final Nic nic) thr
@DB
protected void releaseNic(final VirtualMachineProfile vmProfile, final
long nicId) throws ConcurrentOperationException, ResourceUnavailableException {
-final Pair networkToRelease =
Transaction.execute(new TransactionCallback>() {
+final Pair networkToRelease =
Transaction.execute(new TransactionCallback<>() {
@Override
public Pair doInTransaction(final
TransactionStatus status) {
final NicVO nic = _nicDao.lockRow(nicId, true);
if (nic == null) {
-throw new ConcurrentOperationException("Unable to acquire
lock on nic " + nic);
+throw new
ConcurrentOperationException(String.format("Unable to acquire lock on nic
id==%d", nicId));
Review Comment:
yeah, almost looks like code ;)
```suggestion
throw new
ConcurrentOperationException(String.format("Unable to acquire lock on nic
id=%d", nicId));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] vpc: optimize createMonitorServiceCommand() execution [cloudstack]
DaanHoogland commented on PR #8385: URL: https://github.com/apache/cloudstack/pull/8385#issuecomment-1864502841 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Usage] Create network billing [cloudstack]
DaanHoogland commented on PR #7236: URL: https://github.com/apache/cloudstack/pull/7236#issuecomment-1864494295 tested list usage types and list usagerecords for the new type. the output is good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] test: additional check to ensure hosts are left in up state [cloudstack]
blueorangutan commented on PR #8383: URL: https://github.com/apache/cloudstack/pull/8383#issuecomment-1864488693 @shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] test: additional check to ensure hosts are left in up state [cloudstack]
shwstppr commented on PR #8383: URL: https://github.com/apache/cloudstack/pull/8383#issuecomment-1864486594 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] test: additional check to ensure hosts are left in up state [cloudstack]
shwstppr commented on code in PR #8383:
URL: https://github.com/apache/cloudstack/pull/8383#discussion_r1432723691
##
test/integration/smoke/test_vm_life_cycle.py:
##
@@ -1011,8 +1011,36 @@ def setUpClass(cls):
@classmethod
def tearDownClass(cls):
+cls.ensure_all_hosts_are_up()
super(TestSecuredVmMigration, cls).tearDownClass()
+@classmethod
+def ensure_all_hosts_are_up(cls):
+hosts = Host.list(
+cls.apiclient,
+zoneid=cls.zone.id,
+type='Routing',
+hypervisor='KVM'
+)
+for host in hosts:
+if host.state != "Up":
+SshClient(host.ipaddress, port=22,
user=cls.hostConfig["username"], passwd=cls.hostConfig["password"]) \
+.execute("service cloudstack-agent stop ; \
+ sleep 10 ; \
+ service cloudstack-agent start")
+interval = 5
+retries = 10
+while retries > -1:
+time.sleep(interval)
+restarted_host = Host.list(
+cls.apiclient,
+hostid=host.id,
+type='Routing'
+)[0]
+if restarted_host.state == 'Up':
Review Comment:
```suggestion
if restarted_host.state == "Up":
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] test: additional check to ensure hosts are left in up state [cloudstack]
shwstppr commented on code in PR #8383:
URL: https://github.com/apache/cloudstack/pull/8383#discussion_r1432721985
##
test/integration/smoke/test_vm_life_cycle.py:
##
@@ -1011,8 +1011,36 @@ def setUpClass(cls):
@classmethod
def tearDownClass(cls):
+cls.ensure_all_hosts_are_up()
super(TestSecuredVmMigration, cls).tearDownClass()
+@classmethod
+def ensure_all_hosts_are_up(cls):
+hosts = Host.list(
+cls.apiclient,
+zoneid=cls.zone.id,
+type='Routing',
+hypervisor='KVM'
+)
+for host in hosts:
+if host.state != "Up":
+SshClient(host.ipaddress, port=22,
user=cls.hostConfig["username"], passwd=cls.hostConfig["password"]) \
+.execute("service cloudstack-agent stop ; \
+ sleep 10 ; \
+ service cloudstack-agent start")
+interval = 5
+retries = 10
+while retries > -1:
+time.sleep(interval)
+restarted_host = Host.list(
+cls.apiclient,
+hostid=host.id,
+type='Routing'
+)[0]
+if restarted_host.state == state:
Review Comment:
```suggestion
if restarted_host.state == 'Up':
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] test: additional check to ensure hosts are left in up state [cloudstack]
shwstppr commented on code in PR #8383:
URL: https://github.com/apache/cloudstack/pull/8383#discussion_r1432721308
##
test/integration/smoke/test_vm_life_cycle.py:
##
@@ -1011,8 +1011,36 @@ def setUpClass(cls):
@classmethod
def tearDownClass(cls):
+cls.ensure_all_hosts_are_up()
super(TestSecuredVmMigration, cls).tearDownClass()
+@classmethod
+def ensure_all_hosts_are_up(cls):
+hosts = Host.list(
+cls.apiclient,
+zoneid=cls.zone.id,
+type='Routing',
+hypervisor='KVM'
+)
+for host in hosts:
+if host.state != "Up":
+SshClient(host.ipaddress, port=22,
user=cls.hostConfig["username"], passwd=cls.hostConfig["password"]) \
+.execute("service cloudstack-agent stop ; \
+ sleep 10 ; \
+ service cloudstack-agent start")
+interval = 5
+retries = 10
+while retries > -1:
+time.sleep(interval)
+restarted_host = Host.list(
+cls.apiclient,
+hostid=host.id,
+type='Routing'
+)[0]
+if restarted_host.state == state:
Review Comment:
@weizhouapache yes
But I'm not able to reproduce the issue with hosts remaining in `Connecting`
state so not sure if this will solve the problem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] test: additional check to ensure hosts are left in up state [cloudstack]
weizhouapache commented on code in PR #8383:
URL: https://github.com/apache/cloudstack/pull/8383#discussion_r1432713732
##
test/integration/smoke/test_vm_life_cycle.py:
##
@@ -1011,8 +1011,36 @@ def setUpClass(cls):
@classmethod
def tearDownClass(cls):
+cls.ensure_all_hosts_are_up()
super(TestSecuredVmMigration, cls).tearDownClass()
+@classmethod
+def ensure_all_hosts_are_up(cls):
+hosts = Host.list(
+cls.apiclient,
+zoneid=cls.zone.id,
+type='Routing',
+hypervisor='KVM'
+)
+for host in hosts:
+if host.state != "Up":
+SshClient(host.ipaddress, port=22,
user=cls.hostConfig["username"], passwd=cls.hostConfig["password"]) \
+.execute("service cloudstack-agent stop ; \
+ sleep 10 ; \
+ service cloudstack-agent start")
+interval = 5
+retries = 10
+while retries > -1:
+time.sleep(interval)
+restarted_host = Host.list(
+cls.apiclient,
+hostid=host.id,
+type='Routing'
+)[0]
+if restarted_host.state == state:
Review Comment:
should `== state` be `== "Up"` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] prevent nic removal on out of bounds router stop [cloudstack]
weizhouapache commented on code in PR #8371:
URL: https://github.com/apache/cloudstack/pull/8371#discussion_r1432662763
##
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java:
##
@@ -2310,12 +2311,12 @@ public void releaseNic(final VirtualMachineProfile
vmProfile, final Nic nic) thr
@DB
protected void releaseNic(final VirtualMachineProfile vmProfile, final
long nicId) throws ConcurrentOperationException, ResourceUnavailableException {
-final Pair networkToRelease =
Transaction.execute(new TransactionCallback>() {
+final Pair networkToRelease =
Transaction.execute(new TransactionCallback<>() {
@Override
public Pair doInTransaction(final
TransactionStatus status) {
final NicVO nic = _nicDao.lockRow(nicId, true);
if (nic == null) {
-throw new ConcurrentOperationException("Unable to acquire
lock on nic " + nic);
+throw new
ConcurrentOperationException(String.format("Unable to acquire lock on nic
id==%d", nicId));
Review Comment:
double "="
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] vpc: optimize createMonitorServiceCommand() execution [cloudstack]
boring-cyborg[bot] commented on PR #8385: URL: https://github.com/apache/cloudstack/pull/8385#issuecomment-1864451339 Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) Here are some useful points: - In case of a new feature add useful documentation (raise doc PR at https://github.com/apache/cloudstack-documentation) - Be patient and persistent. It might take some time to get a review or get the final approval from the committers. - Pay attention to the quality of your code, ensure tests are passing and your PR doesn't have conflicts. - Please follow [ASF Code of Conduct](https://github.com/apache/.github/blob/main/.github/CODE_OF_CONDUCT.md) for all communication including (but not limited to) comments on Pull Requests, Issues, Mailing list and Slack. - Be sure to read the [CloudStack Coding Conventions](https://cwiki.apache.org/confluence/display/CLOUDSTACK/Coding+conventions). Apache CloudStack is a community-driven project and together we are making it better . In case of doubts contact the developers at: Mailing List: d...@cloudstack.apache.org (https://cloudstack.apache.org/mailing-lists.html) Slack: https://apachecloudstack.slack.com/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] vpc: optimize createMonitorServiceCommand() execution [cloudstack]
phsm opened a new pull request, #8385:
URL: https://github.com/apache/cloudstack/pull/8385
### Description
This PR moves an expensive getRouterHealthChecksConfig() upper the execution
stack during VPC restart. So this way it is only executed once instead of tens
or hundreds times (depending on VPC tiers amount).
This is done by introducing a `Map routerHealthCheckConfig`
argument to createMonitorServiceCommand() method that accepts pre-computed
health check config.
Fixes #8055
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [x] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
1. Prepared a test VPC:
- 10 tiers
- redundant offering (2 VRs)
- each tier has 1 running VM in it.
2. Performed VPC restart with clean up. Took 61 minutes to fully restart in
my case
3. Applied these changes
4. Performed VPC restart with clean up. Took 9 minutes to fully restart.
How did you try to break this feature and the system with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [I] Backup virtual router of a redundant VPC stays in starting state after restart with clean up. [cloudstack]
weizhouapache commented on issue #8055:
URL: https://github.com/apache/cloudstack/issues/8055#issuecomment-1864401554
> @weizhouapache Hi Wei,
>
> I've actually managed to implement the patch myself.
>
> The test looks promising: Without this patch applied, the 10-tier VPC took
61 minutes to fully restart With this patch applied, the same VPC took 9
minutes to fully restart
>
> Can you take a look at it? If it looks good to you, I can make a PR with
it.
>
> * I changed getRouterHealthChecksConfig() to be protected as
VpcVirtualNetworkApplianceManagerImpl is going to call it.
> * Moved the getRouterHealthChecksConfig() upper to
finalizeCommandsOnStart() in the execution stack. The health check config is
now passed down the stack as a function argument.
> * Adjusted other methods that use getRouterHealthChecksConfig().
>
> ```diff
> diff --git
a/server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
b/server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
> index f7bfb1c4af..3d236c0a13 100644
> ---
a/server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
> +++
b/server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
> @@ -1623,7 +1623,7 @@ Configurable, StateListener }
>
> private SetMonitorServiceCommand
createMonitorServiceCommand(DomainRouterVO router, List
services,
> - boolean
reconfigure, boolean deleteFromProcessedCache) {
> + boolean
reconfigure, boolean deleteFromProcessedCache, Map
routerHealthCheckConfig) {
> final SetMonitorServiceCommand command = new
SetMonitorServiceCommand(services);
> command.setAccessDetail(NetworkElementCommand.ROUTER_IP,
_routerControlHelper.getRouterControlIp(router.getId()));
> command.setAccessDetail(NetworkElementCommand.ROUTER_NAME,
router.getInstanceName());
> @@ -1641,7 +1641,7 @@ Configurable, StateListener }
>
>
command.setAccessDetail(SetMonitorServiceCommand.ROUTER_HEALTH_CHECKS_EXCLUDED,
excludedTests);
> -
command.setHealthChecksConfig(getRouterHealthChecksConfig(router));
> +command.setHealthChecksConfig(routerHealthCheckConfig);
> command.setReconfigureAfterUpdate(reconfigure);
> command.setDeleteFromProcessedCache(deleteFromProcessedCache); //
As part of updating
> return command;
> @@ -1666,7 +1666,7 @@ Configurable, StateListener s_logger.info("Updating data for router health checks for router
" + router.getUuid());
> Answer origAnswer = null;
> try {
> -SetMonitorServiceCommand command =
createMonitorServiceCommand(router, null, true, true);
> +SetMonitorServiceCommand command =
createMonitorServiceCommand(router, null, true, true,
getRouterHealthChecksConfig(router));
> origAnswer = _agentMgr.easySend(router.getHostId(), command);
> } catch (final Exception e) {
> s_logger.error("Error while sending update data for health
check to router: " + router.getInstanceName(), e);
> @@ -1891,7 +1891,7 @@ Configurable, StateListener
.append(generateKeyValuePairOrEmptyString("server.maxqueue", serverMaxqueue));
> }
>
> -private Map getRouterHealthChecksConfig(final
DomainRouterVO router) {
> +protected Map getRouterHealthChecksConfig(final
DomainRouterVO router) {
> Map data = new HashMap<>();
> List routerJoinVOs =
domainRouterJoinDao.searchByIds(router.getId());
> StringBuilder vmsData = new StringBuilder();
> @@ -2464,7 +2464,7 @@ Configurable, StateListener if (reprogramGuestNtwks) {
> finalizeIpAssocForNetwork(cmds, router, provider,
guestNetworkId, null);
> finalizeNetworkRulesForNetwork(cmds, router, provider,
guestNetworkId);
> -finalizeMonitorService(cmds, profile, router, provider,
guestNetworkId, true);
> +finalizeMonitorService(cmds, profile, router, provider,
guestNetworkId, true, getRouterHealthChecksConfig(router));
> }
>
> finalizeUserDataAndDhcpOnStart(cmds, router, provider,
guestNetworkId);
> @@ -2478,7 +2478,7 @@ Configurable, StateListener }
>
> protected void finalizeMonitorService(final Commands cmds, final
VirtualMachineProfile profile, final DomainRouterVO router, final Provider
provider,
> - final long networkId, boolean
onStart) {
> + final long networkId, boolean
onStart, Map routerHealthCheckConfig) {
> final
Re: [PR] remove StorPool tags from detached volumes [cloudstack]
DaanHoogland commented on code in PR #8377:
URL: https://github.com/apache/cloudstack/pull/8377#discussion_r1432652852
##
plugins/storage/volume/storpool/src/main/java/org/apache/cloudstack/storage/datastore/util/StorPoolUtil.java:
##
@@ -517,6 +517,12 @@ public static SpApiResponse volumeUpdate(final String
name, final Long newSize,
return POST("MultiCluster/VolumeUpdate/" + name, json, conn);
}
+public static SpApiResponse volumeUpadateTags(String name, Map tags, SpConnectionDesc conn) {
Review Comment:
@slavkap `volumeUpadateTags` has a spello.
also
When we need a thing in the future we can implement it then, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [I] Backup virtual router of a redundant VPC stays in starting state after restart with clean up. [cloudstack]
phsm commented on issue #8055:
URL: https://github.com/apache/cloudstack/issues/8055#issuecomment-1864388934
@weizhouapache
Hi Wei,
I've actually managed to implement the patch myself.
The test looks promising:
Without this patch applied, the 10-tier VPC took 61 minutes to fully restart
With this patch applied, the same VPC took 9 minutes to fully restart
Can you take a look at it? If it looks good to you, I can make a PR with it.
- I changed getRouterHealthChecksConfig() to be protected as
VpcVirtualNetworkApplianceManagerImpl is going to call it.
- Moved the getRouterHealthChecksConfig() upper to finalizeCommandsOnStart()
in the execution stack. The health check config is now passed down the stack as
a function argument.
- Adjusted other methods that use getRouterHealthChecksConfig().
```patch
diff --git
a/server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
b/server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
index f7bfb1c4af..3d236c0a13 100644
---
a/server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
+++
b/server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
@@ -1623,7 +1623,7 @@ Configurable, StateListener
services,
- boolean
reconfigure, boolean deleteFromProcessedCache) {
+ boolean
reconfigure, boolean deleteFromProcessedCache, Map
routerHealthCheckConfig) {
final SetMonitorServiceCommand command = new
SetMonitorServiceCommand(services);
command.setAccessDetail(NetworkElementCommand.ROUTER_IP,
_routerControlHelper.getRouterControlIp(router.getId()));
command.setAccessDetail(NetworkElementCommand.ROUTER_NAME,
router.getInstanceName());
@@ -1641,7 +1641,7 @@ Configurable, StateListener getRouterHealthChecksConfig(final
DomainRouterVO router) {
+protected Map getRouterHealthChecksConfig(final
DomainRouterVO router) {
Map data = new HashMap<>();
List routerJoinVOs =
domainRouterJoinDao.searchByIds(router.getId());
StringBuilder vmsData = new StringBuilder();
@@ -2464,7 +2464,7 @@ Configurable, StateListener routerHealthCheckConfig) {
final NetworkOffering offering =
_networkOfferingDao.findById(_networkDao.findById(networkId).getNetworkOfferingId());
if (offering.isRedundantRouter()) {
// service monitoring is currently not added in RVR
@@ -2528,7 +2528,7 @@ Configurable, StateListener routerHealthCheckConfig =
getRouterHealthChecksConfig(domainRouterVO);
if (reprogramGuestNtwks && publicNics.size() > 0) {
-finalizeMonitorService(cmds, profile, domainRouterVO,
provider, publicNics.get(0).second().getId(), true);
+finalizeMonitorService(cmds, profile, domainRouterVO,
provider, publicNics.get(0).second().getId(), true, routerHealthCheckConfig);
}
for (final Pair nicNtwk : guestNics) {
@@ -495,7 +496,7 @@ public class VpcVirtualNetworkApplianceManagerImpl
extends VirtualNetworkApplian
if (reprogramGuestNtwks) {
finalizeIpAssocForNetwork(cmds, domainRouterVO,
provider, guestNetworkId, vlanMacAddress);
finalizeNetworkRulesForNetwork(cmds, domainRouterVO,
provider, guestNetworkId);
-finalizeMonitorService(cmds, profile, domainRouterVO,
provider, guestNetworkId, true);
+finalizeMonitorService(cmds, profile, domainRouterVO,
provider, guestNetworkId, true, routerHealthCheckConfig);
}
finalizeUserDataAndDhcpOnStart(cmds, domainRouterVO,
provider, guestNetworkId);
@@ -554,7 +555,7 @@ public class VpcVirtualNetworkApplianceManagerImpl
extends VirtualNetworkApplian
finalizeNetworkRulesForNetwork(cmds, router, provider,
networkId);
}
-finalizeMonitorService(cmds, getVirtualMachineProfile(router),
router, provider, networkId, false);
+finalizeMonitorService(cmds, getVirtualMachineProfile(router),
router, provider, networkId, false, getRouterHealthChecksConfig(router));
return _nwHelper.sendCommandsToRouter(router, cmds);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] test: additional check to ensure hosts are left in up state [cloudstack]
codecov[bot] commented on PR #8383: URL: https://github.com/apache/cloudstack/pull/8383#issuecomment-1864386737 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8383?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Comparison is base [(`64ecd00`)](https://app.codecov.io/gh/apache/cloudstack/commit/64ecd00eb70531d177031b50e5c15f73668df6e8?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) 13.12% compared to head [(`1951b0c`)](https://app.codecov.io/gh/apache/cloudstack/pull/8383?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) 13.12%. Additional details and impacted files ```diff @@Coverage Diff@@ ## 4.18#8383 +/- ## = Coverage 13.12% 13.12% Complexity 9141 9141 = Files 2720 2720 Lines257723 257723 Branches 4017740177 = Hits 3383833838 Misses 219595 219595 Partials 4290 4290 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/8383?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] remove StorPool tags from detached volumes [cloudstack]
DaanHoogland commented on code in PR #8377:
URL: https://github.com/apache/cloudstack/pull/8377#discussion_r1432649252
##
plugins/storage/volume/storpool/src/main/java/org/apache/cloudstack/storage/datastore/util/StorPoolUtil.java:
##
@@ -517,6 +517,12 @@ public static SpApiResponse volumeUpdate(final String
name, final Long newSize,
return POST("MultiCluster/VolumeUpdate/" + name, json, conn);
}
+public static SpApiResponse volumeUpadateTags(String name, Map tags, SpConnectionDesc conn) {
Review Comment:
in the future `this method could be used to set tags also` but the name is
`volumeRemoveTags`, @slavkap ? Remove and set seem in contradiction to me. Can
we add/rename whatever we need in the future later?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] remove StorPool tags from detached volumes [cloudstack]
DaanHoogland commented on code in PR #8377:
URL: https://github.com/apache/cloudstack/pull/8377#discussion_r1432649252
##
plugins/storage/volume/storpool/src/main/java/org/apache/cloudstack/storage/datastore/util/StorPoolUtil.java:
##
@@ -517,6 +517,12 @@ public static SpApiResponse volumeUpdate(final String
name, final Long newSize,
return POST("MultiCluster/VolumeUpdate/" + name, json, conn);
}
+public static SpApiResponse volumeUpadateTags(String name, Map tags, SpConnectionDesc conn) {
Review Comment:
in the future `this method could be used to set tags also` but the name is
`volumeRemoveTags`, @slavkap ? Remove and set seem in contradiction to me. Can
we add/rename whatever we need in the future later?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Option to create StorPool primary storage with a valid URL [cloudstack]
blueorangutan commented on PR #8356: URL: https://github.com/apache/cloudstack/pull/8356#issuecomment-1864384554 @DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Option to create StorPool primary storage with a valid URL [cloudstack]
DaanHoogland commented on PR #8356: URL: https://github.com/apache/cloudstack/pull/8356#issuecomment-1864382564 @blueorangutan test alma9 kvm-alma9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.18 LTS Health Check, please don't merge this! [cloudstack]
DaanHoogland commented on PR #7345: URL: https://github.com/apache/cloudstack/pull/7345#issuecomment-1864381200 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.18 LTS Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #7345: URL: https://github.com/apache/cloudstack/pull/7345#issuecomment-1864380389 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8101 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
