(cloudstack-terraform-provider) branch dependabot/go_modules/golang.org/x/net-0.23.0 deleted (was 6bd572d)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/go_modules/golang.org/x/net-0.23.0 in repository https://gitbox.apache.org/repos/asf/cloudstack-terraform-provider.git was 6bd572d Bump golang.org/x/net from 0.0.0-20210805182204-aaa1db679c0d to 0.23.0 The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
(cloudstack-terraform-provider) branch DaanHoogland-patch-1-1 deleted (was 669b71a)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch DaanHoogland-patch-1-1 in repository https://gitbox.apache.org/repos/asf/cloudstack-terraform-provider.git was 669b71a Update hash generation The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
(cloudstack-terraform-provider) branch main updated: Update hash generation (#108)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack-terraform-provider.git The following commit(s) were added to refs/heads/main by this push: new 368cb0a Update hash generation (#108) 368cb0a is described below commit 368cb0a3044bc616601058d42d037b661b6551c0 Author: dahn AuthorDate: Sat Apr 20 07:14:33 2024 +0200 Update hash generation (#108) md5 deprecated sha512 use specific tool for easy validation --- performrelease.sh | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/performrelease.sh b/performrelease.sh index f21a679..e733da9 100755 --- a/performrelease.sh +++ b/performrelease.sh @@ -102,11 +102,8 @@ else gpg -v --default-key $certid --armor --output apache-cloudstack-terraform-provider-$version-src.tar.bz2.asc --detach-sig apache-cloudstack-terraform-provider-$version-src.tar.bz2 fi -echo 'md5' -gpg -v --print-md MD5 apache-cloudstack-terraform-provider-$version-src.tar.bz2 > apache-cloudstack-terraform-provider-$version-src.tar.bz2.md5 - echo 'sha512' -gpg -v --print-md SHA512 apache-cloudstack-terraform-provider-$version-src.tar.bz2 > apache-cloudstack-terraform-provider-$version-src.tar.bz2.sha512 +sha512sum apache-cloudstack-terraform-provider-$version-src.tar.bz2 > apache-cloudstack-terraform-provider-$version-src.tar.bz2.sha512 echo 'verify' gpg -v --verify apache-cloudstack-terraform-provider-$version-src.tar.bz2.asc apache-cloudstack-terraform-provider-$version-src.tar.bz2
Re: [PR] test: fix unknown parameter hostid in test_vm_life_cycle.py [cloudstack]
blueorangutan commented on PR #8948: URL: https://github.com/apache/cloudstack/pull/8948#issuecomment-2067523452 [SF] Trillian test result (tid-9920) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8 Total time taken: 55634 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8948-t9920-vmware-67u3.zip Smoke tests completed. 126 look OK, 3 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_events_resource | `Error` | 212.31 | test_events_resource.py test_01_events_resource | `Error` | 212.32 | test_events_resource.py test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Error` | 507.50 | test_internal_lb.py test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Error` | 1029.71 | test_internal_lb.py test_04_deploy_vm_for_other_user_and_test_vm_operations | `Failure` | 109.85 | test_network_permissions.py ContextSuite context=TestNetworkPermissions>:teardown | `Error` | 1.53 | test_network_permissions.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] test: fix unknown parameter hostid in test_vm_life_cycle.py [cloudstack]
blueorangutan commented on PR #8948: URL: https://github.com/apache/cloudstack/pull/8948#issuecomment-2067517709 [SF] Trillian test result (tid-9921) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 53996 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8948-t9921-kvm-centos7.zip Smoke tests completed. 126 look OK, 3 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_events_resource | `Error` | 295.40 | test_events_resource.py test_01_events_resource | `Error` | 295.42 | test_events_resource.py test_04_deploy_vm_for_other_user_and_test_vm_operations | `Failure` | 88.11 | test_network_permissions.py ContextSuite context=TestNetworkPermissions>:teardown | `Error` | 1.49 | test_network_permissions.py test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 767.61 | test_vpc_redundant.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.18 LTS Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #7345: URL: https://github.com/apache/cloudstack/pull/7345#issuecomment-2067513344 [SF] Trillian test result (tid-9926) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8 Total time taken: 52854 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7345-t9926-vmware-67u3.zip Smoke tests completed. 109 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Failure` | 711.04 | test_internal_lb.py test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Error` | 711.09 | test_internal_lb.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] add logs to ipallocation attempt [cloudstack]
blueorangutan commented on PR #8239: URL: https://github.com/apache/cloudstack/pull/8239#issuecomment-2067507536 [SF] Trillian test result (tid-9928) Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9 Total time taken: 49336 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8239-t9928-kvm-alma9.zip Smoke tests completed. 109 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_migrate_VM_and_root_volume | `Error` | 102.32 | test_vm_life_cycle.py test_02_migrate_VM_with_two_data_disks | `Error` | 51.17 | test_vm_life_cycle.py test_08_migrate_vm | `Error` | 49.46 | test_vm_life_cycle.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] log sanitation on output of jobs [cloudstack]
blueorangutan commented on PR #8890: URL: https://github.com/apache/cloudstack/pull/8890#issuecomment-2067501113 [SF] Trillian test result (tid-9918) Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9 Total time taken: 59060 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8890-t9918-kvm-alma9.zip Smoke tests completed. 126 look OK, 3 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_events_resource | `Error` | 324.55 | test_events_resource.py test_01_events_resource | `Error` | 324.57 | test_events_resource.py test_04_deploy_vm_for_other_user_and_test_vm_operations | `Failure` | 109.22 | test_network_permissions.py ContextSuite context=TestNetworkPermissions>:teardown | `Error` | 1.55 | test_network_permissions.py test_01_vpc_site2site_vpn | `Failure` | 361.85 | test_vpc_vpn.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] cleanup some smoke tests [cloudstack]
blueorangutan commented on PR #8196: URL: https://github.com/apache/cloudstack/pull/8196#issuecomment-2067398566 [SF] Trillian test result (tid-9924) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 44507 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8196-t9924-kvm-centos7.zip Smoke tests completed. 108 look OK, 7 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_add_primary_storage_disabled_host | `Error` | 0.19 | test_primary_storage.py test_03_migration_options_storage_tags | `Error` | 0.02 | test_primary_storage.py test_01_secure_vm_migration | `Error` | 69.28 | test_secured_vm_migration.py test_02_unsecure_vm_migration | `Error` | 218.99 | test_secured_vm_migration.py test_04_nonsecured_to_secured_vm_migration | `Error` | 112.69 | test_secured_vm_migration.py test_04_nonsecured_to_secured_vm_migration | `Error` | 112.69 | test_secured_vm_migration.py ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py ContextSuite context=TestServiceOfferings>:setup | `Error` | 3.66 | test_service_offerings.py ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py ContextSuite context=TestSnapshotStandaloneBackup>:setup | `Error` | 0.00 | test_snapshots.py test_01_list_sec_storage_vm | `Failure` | 0.05 | test_ssvm.py test_02_list_cpvm_vm | `Failure` | 0.04 | test_ssvm.py test_03_ssvm_internals | `Failure` | 0.04 | test_ssvm.py test_04_cpvm_internals | `Failure` | 0.04 | test_ssvm.py test_05_stop_ssvm | `Failure` | 0.04 | test_ssvm.py test_06_stop_cpvm | `Failure` | 0.04 | test_ssvm.py test_07_reboot_ssvm | `Failure` | 0.04 | test_ssvm.py test_08_reboot_cpvm | `Failure` | 0.04 | test_ssvm.py test_09_reboot_ssvm_forced | `Failure` | 0.04 | test_ssvm.py test_10_reboot_cpvm_forced | `Failure` | 0.04 | test_ssvm.py test_11_destroy_ssvm | `Failure` | 0.04 | test_ssvm.py test_12_destroy_cpvm | `Failure` | 0.04 | test_ssvm.py test_01_deploy_vm_on_specific_host | `Error` | 0.08 | test_vm_deployment_planner.py test_04_deploy_vm_on_host_override_pod_and_cluster | `Error` | 0.11 | test_vm_deployment_planner.py test_08_migrate_vm | `Error` | 0.06 | test_vm_life_cycle.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.18 LTS Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #7345: URL: https://github.com/apache/cloudstack/pull/7345#issuecomment-2067393602 [SF] Trillian test result (tid-9927) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 43068 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7345-t9927-kvm-centos7.zip Smoke tests completed. 110 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.18 LTS Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #7345: URL: https://github.com/apache/cloudstack/pull/7345#issuecomment-2067388633 [SF] Trillian test result (tid-9925) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 43328 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7345-t9925-xenserver-71.zip Smoke tests completed. 110 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GUI whitelabel runtime system [cloudstack]
blueorangutan commented on PR #8942: URL: https://github.com/apache/cloudstack/pull/8942#issuecomment-2067381549 [SF] Trillian test result (tid-9917) Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9 Total time taken: 51841 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8942-t9917-kvm-alma9.zip Smoke tests completed. 127 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_events_resource | `Error` | 318.04 | test_events_resource.py test_01_events_resource | `Error` | 318.05 | test_events_resource.py test_04_deploy_vm_for_other_user_and_test_vm_operations | `Failure` | 96.36 | test_network_permissions.py ContextSuite context=TestNetworkPermissions>:teardown | `Error` | 1.62 | test_network_permissions.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] linstor: Only set allow-two-primaries if resource is already in use [cloudstack]
blueorangutan commented on PR #8802: URL: https://github.com/apache/cloudstack/pull/8802#issuecomment-2067311219 [SF] Trillian test result (tid-9916) Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9 Total time taken: 46646 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8802-t9916-kvm-alma9.zip Smoke tests completed. 109 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_migrate_VM_and_root_volume | `Error` | 102.90 | test_vm_life_cycle.py test_02_migrate_VM_with_two_data_disks | `Error` | 53.62 | test_vm_life_cycle.py test_08_migrate_vm | `Error` | 48.56 | test_vm_life_cycle.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KVM: enable no-mac-spoofing on virtual nics [cloudstack]
BryanMLima commented on PR #8951: URL: https://github.com/apache/cloudstack/pull/8951#issuecomment-2067292978 Hey @weizhouapache, can you provide more context to the issue fixed by this PR? Should we add a no arp spoofing as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] cleanup some smoke tests [cloudstack]
blueorangutan commented on PR #8196: URL: https://github.com/apache/cloudstack/pull/8196#issuecomment-2067276073 [SF] Trillian Build Failed (tid-9934) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix KVM live migration with NFS volumes [cloudstack]
blueorangutan commented on PR #8952: URL: https://github.com/apache/cloudstack/pull/8952#issuecomment-2067264556 @weizhouapache a [SL] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix KVM live migration with NFS volumes [cloudstack]
weizhouapache commented on PR #8952: URL: https://github.com/apache/cloudstack/pull/8952#issuecomment-2067262917 @blueorangutan test rocky8 kvm-rocky8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] packaging: move juniper-contrail network plugin to noredist build [cloudstack]
blueorangutan commented on PR #8932: URL: https://github.com/apache/cloudstack/pull/8932#issuecomment-2067252951 [SF] Trillian test result (tid-9914) Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8 Total time taken: 45681 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8932-t9914-kvm-rocky8.zip Smoke tests completed. 109 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_migrate_VM_and_root_volume | `Error` | 92.82 | test_vm_life_cycle.py test_02_migrate_VM_with_two_data_disks | `Error` | 59.23 | test_vm_life_cycle.py test_08_migrate_vm | `Error` | 0.07 | test_vm_life_cycle.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Extra parameter for UpdateImageStore [cloudstack]
blueorangutan commented on PR #8941: URL: https://github.com/apache/cloudstack/pull/8941#issuecomment-2067238666 [SF] Trillian test result (tid-9911) Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9 Total time taken: 47485 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8941-t9911-kvm-alma9.zip Smoke tests completed. 109 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_migrate_VM_and_root_volume | `Error` | 95.03 | test_vm_life_cycle.py test_02_migrate_VM_with_two_data_disks | `Error` | 55.09 | test_vm_life_cycle.py test_08_migrate_vm | `Error` | 49.29 | test_vm_life_cycle.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] prevent an NPE on an uninitialised TemplateObject [cloudstack]
blueorangutan commented on PR #8898: URL: https://github.com/apache/cloudstack/pull/8898#issuecomment-2067228666 [SF] Trillian test result (tid-9915) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8 Total time taken: 44656 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8898-t9915-vmware-67u3.zip Smoke tests completed. 71 look OK, 39 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- ContextSuite context=TestAddVmToSubDomain>:setup | `Error` | 82.33 | test_accounts.py test_DeleteDomain | `Error` | 157.88 | test_accounts.py test_forceDeleteDomain | `Failure` | 160.89 | test_accounts.py test_01_user_remove_VM_running | `Error` | 71.64 | test_accounts.py test_DeployVmAntiAffinityGroup_in_project | `Error` | 81.44 | test_affinity_groups_projects.py ContextSuite context=TestAnnotations>:setup | `Error` | 0.00 | test_annotations.py test_query_async_job_result | `Error` | 103.61 | test_async_job.py test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Error` | 75.67 | test_internal_lb.py test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Error` | 75.68 | test_internal_lb.py test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Error` | 139.63 | test_internal_lb.py test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Error` | 139.64 | test_internal_lb.py test_03_vpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 74.34 | test_internal_lb.py test_03_vpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 74.35 | test_internal_lb.py test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 151.46 | test_internal_lb.py test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 151.47 | test_internal_lb.py test_deploy_more_vms_than_limit_allows | `Error` | 63.59 | test_deploy_vms_in_parallel.py ContextSuite context=TestLoadBalance>:setup | `Error` | 0.00 | test_loadbalance.py test_deployvm_firstfit | `Error` | 64.53 | test_deploy_vms_with_varied_deploymentplanners.py test_deployvm_userconcentrated | `Error` | 16.03 | test_deploy_vms_with_varied_deploymentplanners.py test_deployvm_userdispersing | `Error` | 16.99 | test_deploy_vms_with_varied_deploymentplanners.py test_deployvm_userdata | `Error` | 61.38 | test_deploy_vm_with_userdata.py test_deployvm_userdata_post | `Error` | 15.85 | test_deploy_vm_with_userdata.py test_delete_account | `Error` | 79.69 | test_network.py test_delete_network_while_vm_on_it | `Error` | 9.95 | test_network.py test_delete_network_while_vm_on_it | `Error` | 9.95 | test_network.py test_deploy_vm_l2network | `Error` | 8.84 | test_network.py test_deploy_vm_l2network | `Error` | 8.84 | test_network.py test_l2network_restart | `Error` | 9.40 | test_network.py test_l2network_restart | `Error` | 9.40 | test_network.py ContextSuite context=TestL2Networks>:teardown | `Error` | 10.59 | test_network.py ContextSuite context=TestPortForwarding>:setup | `Error` | 83.65 | test_network.py ContextSuite context=TestPublicIP>:setup | `Error` | 71.13 | test_network.py test_reboot_router | `Error` | 68.73 | test_network.py test_releaseIP | `Error` | 67.53 | test_network.py ContextSuite context=TestRouterRules>:setup | `Error` | 138.87 | test_network.py ContextSuite context=TestRemoteDiagnostics>:setup | `Error` | 0.00 | test_diagnostics.py test_list_vms_metrics_admin | `Error` | 23.97 | test_metrics_api.py test_list_vms_metrics_history | `Error` | 23.12 | test_metrics_api.py test_list_vms_metrics_user | `Error` | 69.71 | test_metrics_api.py test_list_volumes_metrics_history | `Error` | 16.60 | test_metrics_api.py test_03_deploy_vm_domain_service_offering | `Error` | 94.82 | test_domain_service_offerings.py ContextSuite context=TestListIdsParams>:setup | `Error` | 0.00 | test_list_ids_parameter.py test_nic_secondaryip_add_remove | `Error` | 77.04 | test_multipleips_per_nic.py test_nested_virtualization_vmware | `Error` | 94.31 | test_nested_virtualization.py test_network_acl | `Error` | 97.41 | test_network_acl.py test_01_verify_ipv6_network | `Error` | 72.79 | test_network_ipv6.py test_01_verify_ipv6_network | `Error` | 72.80 | test_network_ipv6.py ContextSuite context=TestIsolatedNetworksPasswdServer>:setup | `Error` | 0.00 | test_password_server.py test_01_create_delete_portforwarding_fornonvpc | `Error` | 70.40 | test_portforwardingrules.py test_02_vpc_privategw_static_routes | `Failure` | 142.09 | test_privategw_acl.py test_02_vpc_privategw_static_routes | `Error` | 142.10 | test_privategw_acl.py test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 138.18 | test_privategw_acl.py test_03_vpc_privategw_restart_vpc_cleanup | `Error` | 138.19 | test_privategw_acl.py
Re: [PR] [HEALTH] 4.20/main Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #8602: URL: https://github.com/apache/cloudstack/pull/8602#issuecomment-2067221011 [SF] Trillian Build Failed (tid-9931) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Veeam] disable jobs but keep backups [cloudstack]
blueorangutan commented on PR #6589: URL: https://github.com/apache/cloudstack/pull/6589#issuecomment-2067216141 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9342 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix KVM live migration with NFS volumes [cloudstack]
blueorangutan commented on PR #8952: URL: https://github.com/apache/cloudstack/pull/8952#issuecomment-2067195350 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9341 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KVM: enable no-mac-spoofing on virtual nics [cloudstack]
blueorangutan commented on PR #8951: URL: https://github.com/apache/cloudstack/pull/8951#issuecomment-2067167694 @weizhouapache a [SL] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KVM: enable no-mac-spoofing on virtual nics [cloudstack]
weizhouapache commented on PR #8951: URL: https://github.com/apache/cloudstack/pull/8951#issuecomment-2067167093 @blueorangutan test rocky8 kvm-rocky8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KVM: enable no-mac-spoofing on virtual nics [cloudstack]
blueorangutan commented on PR #8951: URL: https://github.com/apache/cloudstack/pull/8951#issuecomment-2067163760 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9339 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix KVM live migration with NFS volumes [cloudstack]
blueorangutan commented on PR #8952: URL: https://github.com/apache/cloudstack/pull/8952#issuecomment-2067163761 Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 9340 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch 4.18 updated: kvm: export sysinfo for arm64 domains for cloud-init to work (#8940)
This is an automated email from the ASF dual-hosted git repository.
weizhou pushed a commit to branch 4.18
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/4.18 by this push:
new 5a52ca78ae5 kvm: export sysinfo for arm64 domains for cloud-init to
work (#8940)
5a52ca78ae5 is described below
commit 5a52ca78ae5e165211c618525613c3d62cfd1b28
Author: Rohit Yadav
AuthorDate: Sat Apr 20 00:53:49 2024 +0530
kvm: export sysinfo for arm64 domains for cloud-init to work (#8940)
This fixes a limitation for arm64/aarch64 KVM hosts to correctly export
the product name via sysconfig attribute. Without this `cloud-init`
doesn't function correctly on arm64 platforms.
Signed-off-by: Rohit Yadav
---
.../src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git
a/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java
b/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java
index db179f98642..6d69b2f9664 100644
---
a/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java
+++
b/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java
@@ -222,9 +222,7 @@ public class LibvirtVMDef {
guestDef.append("\n");
}
}
-if (_arch == null || !_arch.equals("aarch64")) {
-guestDef.append("\n");
-}
+guestDef.append("\n");
guestDef.append("\n");
if (iothreads) {
guestDef.append(String.format("%s",
NUMBER_OF_IOTHREADS));
Re: [PR] kvm: export sysinfo for arm64 domains for cloud-init to work [cloudstack]
weizhouapache merged PR #8940: URL: https://github.com/apache/cloudstack/pull/8940 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Usage] Create VPC billing [cloudstack]
stephankruggg commented on PR #7235: URL: https://github.com/apache/cloudstack/pull/7235#issuecomment-2067156241 > @stephankruggg did you test this? Yes, prior to approving this PR I ran the same tests as @SadiJr, as far as I can remember. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Quota] Add API to list preset variables [cloudstack]
blueorangutan commented on PR #8372: URL: https://github.com/apache/cloudstack/pull/8372#issuecomment-2067146592 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9338 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] kvm: export sysinfo for arm64 domains for cloud-init to work [cloudstack]
blueorangutan commented on PR #8940: URL: https://github.com/apache/cloudstack/pull/8940#issuecomment-2067146899 [SF] Trillian test result (tid-9912) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 42928 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8940-t9912-kvm-centos7.zip Smoke tests completed. 110 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Usage] Create network billing [cloudstack]
blueorangutan commented on PR #7236: URL: https://github.com/apache/cloudstack/pull/7236#issuecomment-2067118892 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9337 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Veeam] disable jobs but keep backups [cloudstack]
blueorangutan commented on PR #6589: URL: https://github.com/apache/cloudstack/pull/6589#issuecomment-2067111572 @BryanMLima a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Veeam] disable jobs but keep backups [cloudstack]
BryanMLima commented on code in PR #6589:
URL: https://github.com/apache/cloudstack/pull/6589#discussion_r1572775460
##
engine/schema/src/main/java/org/apache/cloudstack/backup/dao/BackupDaoImpl.java:
##
@@ -141,32 +141,37 @@ public List syncBackups(Long zoneId, Long vmId,
List externalBac
@Override
public BackupResponse newBackupResponse(Backup backup) {
-VMInstanceVO vm =
vmInstanceDao.findByIdIncludingRemoved(backup.getVmId());
-AccountVO account =
accountDao.findByIdIncludingRemoved(vm.getAccountId());
-DomainVO domain = domainDao.findByIdIncludingRemoved(vm.getDomainId());
-DataCenterVO zone =
dataCenterDao.findByIdIncludingRemoved(vm.getDataCenterId());
-BackupOffering offering =
backupOfferingDao.findByIdIncludingRemoved(vm.getBackupOfferingId());
-
-BackupResponse response = new BackupResponse();
-response.setId(backup.getUuid());
-response.setVmId(vm.getUuid());
-response.setVmName(vm.getHostName());
-response.setExternalId(backup.getExternalId());
-response.setType(backup.getType());
-response.setDate(backup.getDate());
-response.setSize(backup.getSize());
-response.setProtectedSize(backup.getProtectedSize());
-response.setStatus(backup.getStatus());
-response.setVolumes(new
Gson().toJson(vm.getBackupVolumeList().toArray(), Backup.VolumeInfo[].class));
-response.setBackupOfferingId(offering.getUuid());
-response.setBackupOffering(offering.getName());
-response.setAccountId(account.getUuid());
-response.setAccount(account.getAccountName());
-response.setDomainId(domain.getUuid());
-response.setDomain(domain.getName());
-response.setZoneId(zone.getUuid());
-response.setZone(zone.getName());
-response.setObjectName("backup");
-return response;
+try {
+VMInstanceVO vm =
vmInstanceDao.findByIdIncludingRemoved(backup.getVmId());
+AccountVO account =
accountDao.findByIdIncludingRemoved(vm.getAccountId());
+DomainVO domain =
domainDao.findByIdIncludingRemoved(vm.getDomainId());
+DataCenterVO zone =
dataCenterDao.findByIdIncludingRemoved(vm.getDataCenterId());
+BackupOffering offering =
backupOfferingDao.findByIdIncludingRemoved(backup.getBackupOfferingId());
+
+BackupResponse response = new BackupResponse();
+response.setId(backup.getUuid());
+response.setVmId(vm.getUuid());
+response.setVmName(vm.getHostName());
+response.setExternalId(backup.getExternalId());
+response.setType(backup.getType());
+response.setDate(backup.getDate());
+response.setSize(backup.getSize());
+response.setProtectedSize(backup.getProtectedSize());
+response.setStatus(backup.getStatus());
+
response.setVolumes(GSON.toJson(backup.getBackupVolumeList().toArray(),
Backup.VolumeInfo[].class));
+response.setBackupOfferingId(offering.getUuid());
+response.setBackupOffering(offering.getName());
+response.setAccountId(account.getUuid());
+response.setAccount(account.getAccountName());
+response.setDomainId(domain.getUuid());
+response.setDomain(domain.getName());
+response.setZoneId(zone.getUuid());
+response.setZone(zone.getName());
+response.setObjectName("backup");
+return response;
+} catch (Exception e) {
Review Comment:
Same here.
##
engine/schema/src/main/resources/META-INF/db/schema-41720to41800.sql:
##
@@ -1562,6 +1562,21 @@ DELETE FROM `cloud`.`snapshot_store_ref`
WHERE store_role = "Primary" AND store_id IN (SELECT id FROM storage_pool
WHERE removed IS NOT NULL);
+ALTER TABLE `cloud`.`backups` ADD backup_volumes TEXT NULL COMMENT 'details of
backedup volumes';
+
+-- Populate column backup_volumes in table backups with a GSON
+-- formed by concatenating the UUID, type, size, path and deviceId
+-- of the volumes of VMs that have some backup offering.
+-- Required for the restore process of a backup using Veeam
+-- The Gson result can be in one of this formats:
+-- When VM has only ROOT disk:
[{"uuid":"","type":"","size":,"path":"","deviceId":}]
+-- When VM has more tha one disk:
[{"uuid":"","type":"","size":,"path":"","deviceId":},
{"uuid":"","type":"","size":,"path":"","deviceId":},
<>]
+UPDATE `cloud`.`backups` b INNER JOIN `cloud`.`vm_instance` vm ON b.vm_id =
vm.id SET b.backup_volumes = (SELECT CONCAT("[", GROUP_CONCAT(
CONCAT("{\"uuid\":\"", v.uuid, "\",\"type\":\"", v.volume_type, "\",\"size\":",
v.`size`, ",\"path\":\"", v.path, "\",\"deviceId\":", v.device_id, "}")
SEPARATOR ","), "]") FROM `cloud`.`volumes` v WHERE v.instance_id = vm.id);
Review Comment:
The volumes are already removed, I think it is
Re: [PR] [Veeam] disable jobs but keep backups [cloudstack]
BryanMLima commented on PR #6589: URL: https://github.com/apache/cloudstack/pull/6589#issuecomment-2067110351 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Veeam] disable jobs but keep backups [cloudstack]
codecov-commenter commented on PR #6589: URL: https://github.com/apache/cloudstack/pull/6589#issuecomment-2067106675 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/6589?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report Attention: Patch coverage is `40.55944%` with `85 lines` in your changes are missing coverage. Please review. > Project coverage is 23.23%. Comparing base [(`e44c17e`)](https://app.codecov.io/gh/apache/cloudstack/commit/e44c17e07703ac0ceda7326585f433fe33b37ca4?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`8de0ba0`)](https://app.codecov.io/gh/apache/cloudstack/pull/6589?dropdown=coverage=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). > Report is 64 commits behind head on main. > :exclamation: Current head 8de0ba0 differs from pull request most recent head 3a129f0. Consider uploading reports for the commit 3a129f0 to get more accurate results | [Files](https://app.codecov.io/gh/apache/cloudstack/pull/6589?dropdown=coverage=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Patch % | Lines | |---|---|---| | [.../src/main/java/com/cloud/vm/UserVmManagerImpl.java](https://app.codecov.io/gh/apache/cloudstack/pull/6589?src=pr=tree=server%2Fsrc%2Fmain%2Fjava%2Fcom%2Fcloud%2Fvm%2FUserVmManagerImpl.java_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL3ZtL1VzZXJWbU1hbmFnZXJJbXBsLmphdmE=) | 17.24% | [22 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/cloudstack/pull/6589?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [.../storage/datastore/db/PrimaryDataStoreDaoImpl.java](https://app.codecov.io/gh/apache/cloudstack/pull/6589?src=pr=tree=engine%2Fschema%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fcloudstack%2Fstorage%2Fdatastore%2Fdb%2FPrimaryDataStoreDaoImpl.java_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvY2xvdWRzdGFjay9zdG9yYWdlL2RhdGFzdG9yZS9kYi9QcmltYXJ5RGF0YVN0b3JlRGFvSW1wbC5qYXZh) | 51.51% | [16 Missing :warning: ](https://app.codecov.io/gh/apache/cloudstack/pull/6589?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [...main/java/org/apache/cloudstack/backup/Backup.java](https://app.codecov.io/gh/apache/cloudstack/pull/6589?src=pr=tree=api%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fcloudstack%2Fbackup%2FBackup.java_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-YXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL2JhY2t1cC9CYWNrdXAuamF2YQ==) | 13.33% | [13 Missing :warning: ](https://app.codecov.io/gh/apache/cloudstack/pull/6589?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [...rg/apache/cloudstack/backup/BackupManagerImpl.java](https://app.codecov.io/gh/apache/cloudstack/pull/6589?src=pr=tree=server%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fcloudstack%2Fbackup%2FBackupManagerImpl.java_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-c2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL2JhY2t1cC9CYWNrdXBNYW5hZ2VySW1wbC5qYXZh) | 30.00% | [5 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/cloudstack/pull/6589?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [...stack/api/command/user/volume/DetachVolumeCmd.java](https://app.codecov.io/gh/apache/cloudstack/pull/6589?src=pr=tree=api%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fcloudstack%2Fapi%2Fcommand%2Fuser%2Fvolume%2FDetachVolumeCmd.java_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-YXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL2FwaS9jb21tYW5kL3VzZXIvdm9sdW1lL0RldGFjaFZvbHVtZUNtZC5qYXZh) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/cloudstack/pull/6589?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [...in/java/org/apache/cloudstack/backup/BackupVO.java](https://app.codecov.io/gh/apache/cloudstack/pull/6589?src=pr=tree=engine%2Fschema%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fcloudstack%2Fbackup%2FBackupVO.java_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvY2xvdWRzdGFjay9iYWNrdXAvQmFja3VwVk8uamF2YQ==) | 33.33% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/cloudstack/pull/6589?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | |
Re: [PR] [VMware] apply IOPS in resize/migrate [cloudstack]
blueorangutan commented on PR #7226: URL: https://github.com/apache/cloudstack/pull/7226#issuecomment-2067104765 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9336 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix KVM live migration with NFS volumes [cloudstack]
blueorangutan commented on PR #8952: URL: https://github.com/apache/cloudstack/pull/8952#issuecomment-2067080195 @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix KVM live migration with NFS volumes [cloudstack]
weizhouapache commented on PR #8952: URL: https://github.com/apache/cloudstack/pull/8952#issuecomment-2067078554 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix KVM live migration with NFS volumes [cloudstack]
blueorangutan commented on PR #8952: URL: https://github.com/apache/cloudstack/pull/8952#issuecomment-2067070195 @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix KVM live migration with NFS volumes [cloudstack]
weizhouapache commented on PR #8952: URL: https://github.com/apache/cloudstack/pull/8952#issuecomment-2067068872 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] test: fix unknown parameter hostid in test_vm_life_cycle.py [cloudstack]
codecov-commenter commented on PR #8948: URL: https://github.com/apache/cloudstack/pull/8948#issuecomment-2067067128 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8948?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 15.13%. Comparing base [(`cadbb56`)](https://app.codecov.io/gh/apache/cloudstack/commit/cadbb563afaa907a45e8931cb8a95e8ca5b8f034?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`12369f8`)](https://app.codecov.io/gh/apache/cloudstack/pull/8948?dropdown=coverage=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). > Report is 4 commits behind head on 4.19. Additional details and impacted files ```diff @@ Coverage Diff @@ ## 4.19#8948 +/- ## - Coverage 15.13% 15.13% -0.01% + Complexity1346913468 -1 Files 4863 4863 Lines326031 326031 Branches 4583845838 - Hits 4934949343 -6 - Misses 270066 270073 +7 + Partials 6616 6615 -1 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/8948/flags?src=pr=flags_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Coverage Δ | | |---|---|---| | [simulator-marvin-tests](https://app.codecov.io/gh/apache/cloudstack/pull/8948/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `15.13% <ø> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/8948?dropdown=coverage=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KVM: enable no-mac-spoofing on virtual nics [cloudstack]
blueorangutan commented on PR #8951: URL: https://github.com/apache/cloudstack/pull/8951#issuecomment-2067066946 @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KVM: enable no-mac-spoofing on virtual nics [cloudstack]
weizhouapache commented on PR #8951: URL: https://github.com/apache/cloudstack/pull/8951#issuecomment-2067064795 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KVM: enable no-mac-spoofing on virtual nics [cloudstack]
weizhouapache commented on PR #8951: URL: https://github.com/apache/cloudstack/pull/8951#issuecomment-2067060156 @NuxRo this is probably you want to have. I am not sure if there are downside . @DaanHoogland and me have tested it. mac anti-spoofing works, but ip anti-spoofing does not work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Fix KVM live migration with NFS volumes [cloudstack]
JoaoJandre opened a new pull request, #8952:
URL: https://github.com/apache/cloudstack/pull/8952
### Description
Using KVM as the hypervisor, when migrating a VM that has volumes on NFS
storage, if any volume of it is migrated, all volumes that are on NFS must be
migrated, otherwise, the migration will fail with the error `unable to execute
QEMU command 'block- export-add': Block node is read-only`.
This situation occurs because, during the migration of VMs with volumes, the
ACS does not inform which volumes should be migrated, causing Libvirt to assume
that they will all be migrated, even if their path does not change, leading the
hypervisor to try to overwrite the volumes of the VM during migration,
resulting in the aforementioned error.
The use of the Libvirt migration API has been refactored so that ACS reports
which volumes should be migrated.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [X] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
How did you try to break this feature and the system with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] KVM: enable no-mac-spoofing on virtual nics [cloudstack]
weizhouapache opened a new pull request, #8951:
URL: https://github.com/apache/cloudstack/pull/8951
Refer to
https://libvirt.org/firewall.html#the-network-filter-driver
https://libvirt.org/formatnwfilter.html#concepts
### Description
This PR...
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
How did you try to break this feature and the system with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [Quota] Add API to list preset variables [cloudstack]
blueorangutan commented on PR #8372: URL: https://github.com/apache/cloudstack/pull/8372#issuecomment-2067028881 @BryanMLima a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Quota] Add API to list preset variables [cloudstack]
BryanMLima commented on PR #8372: URL: https://github.com/apache/cloudstack/pull/8372#issuecomment-2067027893 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Usage] Create network billing [cloudstack]
blueorangutan commented on PR #7236: URL: https://github.com/apache/cloudstack/pull/7236#issuecomment-2067025602 @BryanMLima a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Usage] Create network billing [cloudstack]
BryanMLima commented on PR #7236: URL: https://github.com/apache/cloudstack/pull/7236#issuecomment-2067022709 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Usage] Create network billing [cloudstack]
codecov-commenter commented on PR #7236: URL: https://github.com/apache/cloudstack/pull/7236#issuecomment-2067020937 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/7236?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report Attention: Patch coverage is `13.06533%` with `173 lines` in your changes are missing coverage. Please review. > Project coverage is 29.90%. Comparing base [(`ffd5972`)](https://app.codecov.io/gh/apache/cloudstack/commit/ffd59720dd8ce8d2d8081179d7089d55f0f337fd?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`2d9f0c4`)](https://app.codecov.io/gh/apache/cloudstack/pull/7236?dropdown=coverage=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). > Report is 48 commits behind head on 4.19. > :exclamation: Current head 2d9f0c4 differs from pull request most recent head 5054528. Consider uploading reports for the commit 5054528 to get more accurate results | [Files](https://app.codecov.io/gh/apache/cloudstack/pull/7236?dropdown=coverage=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Patch % | Lines | |---|---|---| | [...java/com/cloud/usage/dao/UsageNetworksDaoImpl.java](https://app.codecov.io/gh/apache/cloudstack/pull/7236?src=pr=tree=engine%2Fschema%2Fsrc%2Fmain%2Fjava%2Fcom%2Fcloud%2Fusage%2Fdao%2FUsageNetworksDaoImpl.java_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC91c2FnZS9kYW8vVXNhZ2VOZXR3b3Jrc0Rhb0ltcGwuamF2YQ==) | 3.03% | [64 Missing :warning: ](https://app.codecov.io/gh/apache/cloudstack/pull/7236?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [...src/main/java/com/cloud/usage/UsageNetworksVO.java](https://app.codecov.io/gh/apache/cloudstack/pull/7236?src=pr=tree=engine%2Fschema%2Fsrc%2Fmain%2Fjava%2Fcom%2Fcloud%2Fusage%2FUsageNetworksVO.java_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC91c2FnZS9Vc2FnZU5ldHdvcmtzVk8uamF2YQ==) | 7.31% | [38 Missing :warning: ](https://app.codecov.io/gh/apache/cloudstack/pull/7236?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [...va/com/cloud/usage/parser/NetworksUsageParser.java](https://app.codecov.io/gh/apache/cloudstack/pull/7236?src=pr=tree=usage%2Fsrc%2Fmain%2Fjava%2Fcom%2Fcloud%2Fusage%2Fparser%2FNetworksUsageParser.java_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-dXNhZ2Uvc3JjL21haW4vamF2YS9jb20vY2xvdWQvdXNhZ2UvcGFyc2VyL05ldHdvcmtzVXNhZ2VQYXJzZXIuamF2YQ==) | 0.00% | [37 Missing :warning: ](https://app.codecov.io/gh/apache/cloudstack/pull/7236?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [...rc/main/java/com/cloud/usage/UsageManagerImpl.java](https://app.codecov.io/gh/apache/cloudstack/pull/7236?src=pr=tree=usage%2Fsrc%2Fmain%2Fjava%2Fcom%2Fcloud%2Fusage%2FUsageManagerImpl.java_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-dXNhZ2Uvc3JjL21haW4vamF2YS9jb20vY2xvdWQvdXNhZ2UvVXNhZ2VNYW5hZ2VySW1wbC5qYXZh) | 0.00% | [16 Missing :warning: ](https://app.codecov.io/gh/apache/cloudstack/pull/7236?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [...tionrule/presetvariables/PresetVariableHelper.java](https://app.codecov.io/gh/apache/cloudstack/pull/7236?src=pr=tree=framework%2Fquota%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fcloudstack%2Fquota%2Factivationrule%2Fpresetvariables%2FPresetVariableHelper.java_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-ZnJhbWV3b3JrL3F1b3RhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL3F1b3RhL2FjdGl2YXRpb25ydWxlL3ByZXNldHZhcmlhYmxlcy9QcmVzZXRWYXJpYWJsZUhlbHBlci5qYXZh) | 8.33% | [11 Missing :warning: ](https://app.codecov.io/gh/apache/cloudstack/pull/7236?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [.../schema/src/main/java/com/cloud/usage/UsageVO.java](https://app.codecov.io/gh/apache/cloudstack/pull/7236?src=pr=tree=engine%2Fschema%2Fsrc%2Fmain%2Fjava%2Fcom%2Fcloud%2Fusage%2FUsageVO.java_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC91c2FnZS9Vc2FnZVZPLmphdmE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/cloudstack/pull/7236?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | |
Re: [PR] [VMware] apply IOPS in resize/migrate [cloudstack]
blueorangutan commented on PR #7226: URL: https://github.com/apache/cloudstack/pull/7226#issuecomment-2067002350 @BryanMLima a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [VMware] apply IOPS in resize/migrate [cloudstack]
BryanMLima commented on PR #7226: URL: https://github.com/apache/cloudstack/pull/7226#issuecomment-2067001800 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Ability to specify NFS mount options while adding a primary storage and modify them on a pre-existing primary storage [cloudstack]
JoaoJandre commented on code in PR #8947:
URL: https://github.com/apache/cloudstack/pull/8947#discussion_r1572658067
##
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtStoragePoolDef.java:
##
@@ -187,6 +208,13 @@ public String toString() {
storagePoolBuilder.append("" + _targetPath + "\n");
storagePoolBuilder.append("\n");
}
+if (_poolType == PoolType.NETFS && _nfsopts != null) {
+storagePoolBuilder.append("\n");
+for (Map.Entry options : _nfsopts.entrySet()) {
+storagePoolBuilder.append("\n");
+}
+storagePoolBuilder.append("\n");
Review Comment:
why not put this inside the if block at line 148?
##
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java:
##
@@ -654,20 +654,54 @@ public KVMStoragePool createStoragePool(String name,
String host, int port, Stri
} catch (LibvirtException e) {
s_logger.error("Failure in attempting to see if an existing
storage pool might be using the path of the pool to be created:" + e);
}
+}
+
+List nfsopts = null;
+if (type == StoragePoolType.NetworkFilesystem) {
+if (details != null && details.containsKey("nfsopts")) {
+nfsopts =
Arrays.asList(details.get("nfsopts").replaceAll("\\s", "").split(","));
+}
+
+if (sp != null && nfsopts != null) {
+try {
+LibvirtStoragePoolDef poolDef = getStoragePoolDef(conn,
sp);
+Map poolNfsOptsMap = poolDef.getNfsOpts();
+boolean optionsDiffer = false;
+if (poolNfsOptsMap.size() != nfsopts.size()) {
+optionsDiffer = true;
+} else {
+for (String nfsopt : nfsopts) {
+if (!poolNfsOptsMap.containsKey(nfsopt)) {
+optionsDiffer = true;
+break;
+}
+}
+}
+if (optionsDiffer == true) {
Review Comment:
```suggestion
if (optionsDiffer) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] New feature: Implicit host tags [cloudstack]
weizhouapache commented on PR #8929: URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2066959313 > > > @JoaoJandre thanks for your review > > > the methods are moved from [HostTagDaoImpl.java](https://github.com/apache/cloudstack/blob/4.19/server/src/main/java/com/cloud/api/query/dao/HostTagDaoImpl.java) without any code changes. Since it has the very similar class name as [HostTagsDaoImpl](https://github.com/apache/cloudstack/blob/4.19/engine/schema/src/main/java/com/cloud/host/dao/HostTagsDaoImpl.java), I merged them into 1 file. > > > > suggestion committed @JoaoJandre > > > > actually the test could be simple, as the all host tags are considered during vm deployment and vm migration, etc, including the implicit and current (explicit) host tags. > > @weizhouapache What happens if you define an implicit tag on a host and a flexible tag on it as well? > Currently you either have normal or flexible tags, not both. here is a question: why not both? the normal tag could be regarded as a special type of flexible tag. This PR will not break the flexible tags anyway, as the implicit tags are empty by default. It can be regarded as a limitation. I will update the doc PR. Anyone who is interested in supporting both implicit tags and flexible tags can work on the improvement to support both. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] New feature: Implicit host tags [cloudstack]
JoaoJandre commented on PR #8929: URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2066932539 > > @JoaoJandre thanks for your review > > the methods are moved from [HostTagDaoImpl.java](https://github.com/apache/cloudstack/blob/4.19/server/src/main/java/com/cloud/api/query/dao/HostTagDaoImpl.java) without any code changes. Since it has the very similar class name as [HostTagsDaoImpl](https://github.com/apache/cloudstack/blob/4.19/engine/schema/src/main/java/com/cloud/host/dao/HostTagsDaoImpl.java), I merged them into 1 file. > > suggestion committed @JoaoJandre > > actually the test could be simple, as the all host tags are considered during vm deployment and vm migration, etc, including the implicit and current (explicit) host tags. @weizhouapache What happens if you define an implicit tag on a host and a flexible tag on it as well? Currently you either have normal or flexible tags, not both. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Log4j2 refactor cloud engine orchestration module [cloudstack]
JoaoJandre commented on code in PR #8742:
URL: https://github.com/apache/cloudstack/pull/8742#discussion_r1572644711
##
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java:
##
@@ -3064,33 +3060,31 @@ protected void
checkL2OfferingServices(NetworkOfferingVO ntwkOff) {
public boolean shutdownNetwork(final long networkId, final
ReservationContext context, final boolean cleanupElements) {
NetworkVO network = _networksDao.findById(networkId);
if (network.getState() == Network.State.Allocated) {
-logger.debug("Network is already shutdown: " + network);
+logger.debug("Network is already shutdown: {}", network);
return true;
}
if (network.getState() != Network.State.Implemented &&
network.getState() != Network.State.Shutdown) {
-logger.debug("Network is not implemented: " + network);
+logger.debug("Network is not implemented: {}", network);
return false;
}
try {
//do global lock for the network
network = _networksDao.acquireInLockTable(networkId,
NetworkLockTimeout.value());
if (network == null) {
-logger.warn("Unable to acquire lock for the network " +
network + " as a part of network shutdown");
+logger.warn("Unable to acquire lock for the network {} as a
part of network shutdown", network);
return false;
}
-if (logger.isDebugEnabled()) {
-logger.debug("Lock is acquired for network " + network + " as
a part of network shutdown");
-}
+logger.debug("Lock is acquired for network " + network + " as a
part of network shutdown");
Review Comment:
String concatenation
##
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java:
##
@@ -3880,51 +3874,51 @@ private boolean cleanupNetworkResources(final long
networkId, final Account call
//remove all PF/Static Nat rules for the network
try {
if (_rulesMgr.revokeAllPFStaticNatRulesForNetwork(networkId,
callerUserId, caller)) {
-logger.debug("Successfully cleaned up portForwarding/staticNat
rules for network id=" + networkId);
+logger.debug("Successfully cleaned up portForwarding/staticNat
rules for network id={}", networkId);
} else {
success = false;
-logger.warn("Failed to release portForwarding/StaticNat rules
as a part of network id=" + networkId + " cleanup");
+logger.warn("Failed to release portForwarding/StaticNat rules
as a part of network id={} cleanup", networkId);
}
} catch (final ResourceUnavailableException ex) {
success = false;
// shouldn't even come here as network is being cleaned up after
all network elements are shutdown
-logger.warn("Failed to release portForwarding/StaticNat rules as a
part of network id=" + networkId + " cleanup due to resourceUnavailable ", ex);
+logger.warn("Failed to release portForwarding/StaticNat rules as a
part of network id={} cleanup due to resourceUnavailable" + networkId, ex);
Review Comment:
Wrong syntax
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] New feature: Implicit host tags [cloudstack]
weizhouapache commented on PR #8929: URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2066918607 > @JoaoJandre thanks for your review > > the methods are moved from [HostTagDaoImpl.java](https://github.com/apache/cloudstack/blob/4.19/server/src/main/java/com/cloud/api/query/dao/HostTagDaoImpl.java) without any code changes. Since it has the very similar class name as [HostTagsDaoImpl](https://github.com/apache/cloudstack/blob/4.19/engine/schema/src/main/java/com/cloud/host/dao/HostTagsDaoImpl.java), I merged them into 1 file. suggestion committed @JoaoJandre actually the test could be simple, as the all host tags are considered during vm deployment and vm migration, etc, including the implicit and current (explicit) host tags. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] Dashboard doesn't update for SAML user upon login [cloudstack]
rohityadavcloud opened a new issue, #8950: URL: https://github.com/apache/cloudstack/issues/8950 Log-in as a SAML user such as on https://qa.cloudstack.cloud/client/ (use rick user), the dashboard looks like the following and doesn't show the values correctly. https://github.com/apache/cloudstack/assets/95203/fb43d352-5745-44dc-b7ef-056217acc957;> However, upon changing the project and back to default view the dashboard is fixed. # ISSUE TYPE * Bug Report * # COMPONENT NAME ~~~ SAML ~~~ # CLOUDSTACK VERSION ~~~ 4.19 ~~~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Update netty version for compatibility/staying current [cloudstack]
codecov-commenter commented on PR #8945: URL: https://github.com/apache/cloudstack/pull/8945#issuecomment-2066884744 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8945?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 15.13%. Comparing base [(`cadbb56`)](https://app.codecov.io/gh/apache/cloudstack/commit/cadbb563afaa907a45e8931cb8a95e8ca5b8f034?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`b112960`)](https://app.codecov.io/gh/apache/cloudstack/pull/8945?dropdown=coverage=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). > Report is 4 commits behind head on 4.19. Additional details and impacted files ```diff @@ Coverage Diff @@ ## 4.19#8945 +/- ## - Coverage 15.13% 15.13% -0.01% - Complexity1346913472 +3 Files 4863 4863 Lines326031 326031 Branches 4583845838 - Hits 4934949347 -2 Misses 270066 270066 - Partials 6616 6618 +2 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/8945/flags?src=pr=flags_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Coverage Δ | | |---|---|---| | [simulator-marvin-tests](https://app.codecov.io/gh/apache/cloudstack/pull/8945/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `15.13% <ø> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/8945?dropdown=coverage=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] prevent duplicate ip table rules in SSVM [cloudstack]
blueorangutan commented on PR #8530: URL: https://github.com/apache/cloudstack/pull/8530#issuecomment-2066830399 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9335 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.19 Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #8601: URL: https://github.com/apache/cloudstack/pull/8601#issuecomment-2066772875 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9334 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fixup resource limit checks [cloudstack]
blueorangutan commented on PR #8935: URL: https://github.com/apache/cloudstack/pull/8935#issuecomment-2066758668 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9333 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] New feature: Implicit host tags [cloudstack]
weizhouapache commented on PR #8929: URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2066749768 @JoaoJandre thanks for your review the methods are moved from [HostTagDaoImpl.java](https://github.com/apache/cloudstack/blob/4.19/server/src/main/java/com/cloud/api/query/dao/HostTagDaoImpl.java) without any code changes. Since it has the very similar class name as [HostTagsDaoImpl](https://github.com/apache/cloudstack/blob/4.19/engine/schema/src/main/java/com/cloud/host/dao/HostTagsDaoImpl.java), I merged them into 1 file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Domain name does not show when listing Shared Networks as admin user [cloudstack]
DaanHoogland commented on issue #8895: URL: https://github.com/apache/cloudstack/issues/8895#issuecomment-2066744379 @marco, tried this with 4.19.0.1 and with 4.18.1.1 but both show the domain. Can you elaborate on the issue a bit? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] New feature: Implicit host tags [cloudstack]
JoaoJandre commented on code in PR #8929:
URL: https://github.com/apache/cloudstack/pull/8929#discussion_r1572398700
##
engine/schema/src/main/java/com/cloud/host/dao/HostTagsDaoImpl.java:
##
@@ -110,4 +167,72 @@ public ConfigKey[] getConfigKeys() {
public String getConfigComponentName() {
return HostTagsDaoImpl.class.getSimpleName();
}
+
+@Override
+public HostTagResponse newHostTagResponse(HostTagVO tag) {
+HostTagResponse tagResponse = new HostTagResponse();
+
+tagResponse.setName(tag.getTag());
+tagResponse.setHostId(tag.getHostId());
+tagResponse.setImplicit(tag.getIsImplicit());
+
+tagResponse.setObjectName("hosttag");
+
+return tagResponse;
+}
+
+@Override
+public List searchByIds(Long... stIds) {
+String batchCfg = _configDao.getValue("detail.batch.query.size");
+
+final int detailsBatchSize = batchCfg != null ?
Integer.parseInt(batchCfg) : 2000;
+
+// query details by batches
+List uvList = new ArrayList();
+int curr_index = 0;
+
+if (stIds.length > detailsBatchSize) {
+while ((curr_index + detailsBatchSize) <= stIds.length) {
+Long[] ids = new Long[detailsBatchSize];
+
+for (int k = 0, j = curr_index; j < curr_index +
detailsBatchSize; j++, k++) {
+ids[k] = stIds[j];
+}
+
+SearchCriteria sc = stSearch.create();
+
+sc.setParameters("idIN", (Object[])ids);
+
+List vms = searchIncludingRemoved(sc, null, null,
false);
Review Comment:
```suggestion
List hostTags = searchIncludingRemoved(sc, null,
null, false);
```
##
engine/schema/src/main/java/com/cloud/host/dao/HostTagsDaoImpl.java:
##
@@ -110,4 +167,72 @@ public ConfigKey[] getConfigKeys() {
public String getConfigComponentName() {
return HostTagsDaoImpl.class.getSimpleName();
}
+
+@Override
+public HostTagResponse newHostTagResponse(HostTagVO tag) {
+HostTagResponse tagResponse = new HostTagResponse();
+
+tagResponse.setName(tag.getTag());
+tagResponse.setHostId(tag.getHostId());
+tagResponse.setImplicit(tag.getIsImplicit());
+
+tagResponse.setObjectName("hosttag");
+
+return tagResponse;
+}
+
+@Override
+public List searchByIds(Long... stIds) {
Review Comment:
what does the "st" in "stIds" mean?
##
engine/schema/src/main/java/com/cloud/host/dao/HostTagsDaoImpl.java:
##
@@ -110,4 +167,72 @@ public ConfigKey[] getConfigKeys() {
public String getConfigComponentName() {
return HostTagsDaoImpl.class.getSimpleName();
}
+
+@Override
+public HostTagResponse newHostTagResponse(HostTagVO tag) {
+HostTagResponse tagResponse = new HostTagResponse();
+
+tagResponse.setName(tag.getTag());
+tagResponse.setHostId(tag.getHostId());
+tagResponse.setImplicit(tag.getIsImplicit());
+
+tagResponse.setObjectName("hosttag");
+
+return tagResponse;
+}
+
+@Override
+public List searchByIds(Long... stIds) {
+String batchCfg = _configDao.getValue("detail.batch.query.size");
+
+final int detailsBatchSize = batchCfg != null ?
Integer.parseInt(batchCfg) : 2000;
+
+// query details by batches
+List uvList = new ArrayList();
Review Comment:
hostTagList?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [I] Usage leaves a job record after stopping [cloudstack]
DaanHoogland commented on issue #8590: URL: https://github.com/apache/cloudstack/issues/8590#issuecomment-2066721631 fixed in #8896 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Usage leaves a job record after stopping [cloudstack]
DaanHoogland closed issue #8590: Usage leaves a job record after stopping URL: https://github.com/apache/cloudstack/issues/8590 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] prevent duplicate ip table rules in SSVM [cloudstack]
blueorangutan commented on PR #8530: URL: https://github.com/apache/cloudstack/pull/8530#issuecomment-2066715059 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] prevent duplicate ip table rules in SSVM [cloudstack]
DaanHoogland commented on PR #8530: URL: https://github.com/apache/cloudstack/pull/8530#issuecomment-2066711635 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] UI: ignore error when list public ips for CKS clusters on Shared network [cloudstack]
blueorangutan commented on PR #8489: URL: https://github.com/apache/cloudstack/pull/8489#issuecomment-2066711425 @DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] UI: ignore error when list public ips for CKS clusters on Shared network [cloudstack]
DaanHoogland commented on PR #8489: URL: https://github.com/apache/cloudstack/pull/8489#issuecomment-2066709115 @blueorangutan test alma9 kvm-alma9 keepEnv securityGroups -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Usage] Create VPC billing [cloudstack]
DaanHoogland commented on PR #7235: URL: https://github.com/apache/cloudstack/pull/7235#issuecomment-2066696578 @stephankruggg did you test this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [UI] Add option to specify account/project while deploying VMs [cloudstack]
BryanMLima commented on PR #8919: URL: https://github.com/apache/cloudstack/pull/8919#issuecomment-2066685214 > tested ok, Note that during VM deployment the target user must already have a network to deploy the VM in or there will be no option to the admin to deploy @DaanHoogland, thanks for testing. In the view of VM deploy, you can create a new network and specify the domain and account, therefore, there is no need to pre-create the network for the account.  > @BryanMLima , have you also logged in as the other user to manipulate/delete the resources created? (nice feature btw) Yes, I was able to manage the resources (VM and network) as expected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.20/main Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #8602: URL: https://github.com/apache/cloudstack/pull/8602#issuecomment-2066655201 @DaanHoogland a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.20/main Health Check, please don't merge this! [cloudstack]
DaanHoogland commented on PR #8602: URL: https://github.com/apache/cloudstack/pull/8602#issuecomment-2066652787 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.19 Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #8601: URL: https://github.com/apache/cloudstack/pull/8601#issuecomment-2066644097 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.19 Health Check, please don't merge this! [cloudstack]
sureshanaparti commented on PR #8601: URL: https://github.com/apache/cloudstack/pull/8601#issuecomment-2066641648 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.20/main Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #8602: URL: https://github.com/apache/cloudstack/pull/8602#issuecomment-2066623804 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9332 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fixup resource limit checks [cloudstack]
blueorangutan commented on PR #8935: URL: https://github.com/apache/cloudstack/pull/8935#issuecomment-2066608957 @vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fixup resource limit checks [cloudstack]
vishesh92 commented on PR #8935: URL: https://github.com/apache/cloudstack/pull/8935#issuecomment-2066607097 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Update netty version for compatibility/staying current [cloudstack]
sureshanaparti commented on PR #8945: URL: https://github.com/apache/cloudstack/pull/8945#issuecomment-2066558558 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Update netty version for compatibility/staying current [cloudstack]
blueorangutan commented on PR #8945: URL: https://github.com/apache/cloudstack/pull/8945#issuecomment-2066561929 @sureshanaparti a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch main updated: test: fix test failures in ActionEventInterceptorTest (#8938)
This is an automated email from the ASF dual-hosted git repository.
weizhou pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/main by this push:
new 8ff2c018cc5 test: fix test failures in ActionEventInterceptorTest
(#8938)
8ff2c018cc5 is described below
commit 8ff2c018cc5b3fc69bcd8756695d04b384e46ab8
Author: Wei Zhou
AuthorDate: Fri Apr 19 15:10:38 2024 +0200
test: fix test failures in ActionEventInterceptorTest (#8938)
* test: fix test failures in ActionEventInterceptorTest
```
Error: Failures:
Error:ActionEventInterceptorTest.testInterceptComplete:247
Error:ActionEventInterceptorTest.testInterceptException:261
Error:ActionEventInterceptorTest.testInterceptStartAsync:234
expected: but was:
```
* Update 8938: move CallContext.unregister as well
---
server/src/test/java/com/cloud/event/ActionEventInterceptorTest.java | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git
a/server/src/test/java/com/cloud/event/ActionEventInterceptorTest.java
b/server/src/test/java/com/cloud/event/ActionEventInterceptorTest.java
index 9211ce16759..109cb585d8e 100644
--- a/server/src/test/java/com/cloud/event/ActionEventInterceptorTest.java
+++ b/server/src/test/java/com/cloud/event/ActionEventInterceptorTest.java
@@ -172,6 +172,7 @@ public class ActionEventInterceptorTest {
account.setId(ACCOUNT_ID);
user = new UserVO(1, "testuser", "password", "firstname", "lastName",
"email", "timezone",
UUID.randomUUID().toString(), User.Source.UNKNOWN);
+CallContext.register(user, account);
Mockito.when(accountDao.findById(ACCOUNT_ID)).thenReturn(account);
}
@@ -197,6 +198,8 @@ public class ActionEventInterceptorTest {
utils.init();
+CallContext.unregister();
+
componentContextMocked.close();
}
@@ -265,7 +268,6 @@ public class ActionEventInterceptorTest {
@Test
public void testInterceptExceptionResource() throws NoSuchMethodException {
-CallContext.register(user, account);
Long resourceId = 1L;
ApiCommandResourceType resourceType =
ApiCommandResourceType.VirtualMachine;
CallContext.current().setEventResourceId(resourceId);
@@ -282,7 +284,6 @@ public class ActionEventInterceptorTest {
Assert.assertEquals(eventVO.getState(),
com.cloud.event.Event.State.Completed);
Assert.assertEquals(eventVO.getResourceId(), resourceId);
Assert.assertEquals(eventVO.getResourceType(),
resourceType.toString());
-CallContext.unregister();
}
@Test
Re: [PR] test: fix test failures in ActionEventInterceptorTest [cloudstack]
weizhouapache merged PR #8938: URL: https://github.com/apache/cloudstack/pull/8938 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Refactor configuration SystemVMDefaultHypervisor [cloudstack]
blueorangutan commented on PR #8934: URL: https://github.com/apache/cloudstack/pull/8934#issuecomment-2066499758 @DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Refactor configuration SystemVMDefaultHypervisor [cloudstack]
DaanHoogland commented on PR #8934: URL: https://github.com/apache/cloudstack/pull/8934#issuecomment-2066497076 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Failed Volume Snapshot shows State as BackedUp [cloudstack]
DaanHoogland commented on issue #8946: URL: https://github.com/apache/cloudstack/issues/8946#issuecomment-2066495367 And was there a file on primary storage? also , in your stacktrace it says `TemplateManagerImpl.createPrivateTemplate` so if a template is to be created from a snapshot or a volume it would always have to be copied to secondary to do so. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack-go) branch dependabot/go_modules/golang.org/x/net-0.23.0 created (now 1af5124)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/go_modules/golang.org/x/net-0.23.0 in repository https://gitbox.apache.org/repos/asf/cloudstack-go.git at 1af5124 Bump golang.org/x/net from 0.17.0 to 0.23.0 No new revisions were added by this update.
Re: [PR] Refactor configuration SystemVMDefaultHypervisor [cloudstack]
GaOrtiga commented on code in PR #8934:
URL: https://github.com/apache/cloudstack/pull/8934#discussion_r1572296935
##
engine/components-api/src/main/java/com/cloud/resource/ResourceManager.java:
##
@@ -61,6 +61,11 @@ public interface ResourceManager extends ResourceService,
Configurable {
+ "To force-stop VMs, choose 'ForceStop' strategy",
true, ConfigKey.Scope.Global, null, null, null, null, null,
ConfigKey.Kind.Select, "Error,Migration,ForceStop");
+ConfigKey SystemVMDefaultHypervisor = new
ConfigKey(String.class,
+"system.vm.default.hypervisor", "Advanced", "Any", "Hypervisor
type used to create System VMs. Valid values are: XenServer, KVM, VMware,
Hyperv, VirtualBox, " +
+"Parralels, BareMetal, Ovm, LXC, Any", true,
ConfigKey.Scope.Global, null, null, null, null, null, ConfigKey.Kind.Select,
"XenServer, KVM, VMware, Hyperv, " +
+"VirtualBox, Parralels, BareMetal, Ovm, LXC, Any");
Review Comment:
@sureshanaparti I agree with changing the scope to zone, however, can you
further explain what you mean by handling "defaultSystemVMHypervisorType" in
upgrade?
Wouldn't changing the scope to zone and fetching the value of the config for
the specific zone be sufficient to guarantee the expected behaviour?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] test: fix test failures in ActionEventInterceptorTest [cloudstack]
weizhouapache commented on PR #8938: URL: https://github.com/apache/cloudstack/pull/8938#issuecomment-2066467433 marked as "ready for review" as it fixes the failure with build CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] test: fix test failures in ActionEventInterceptorTest [cloudstack]
weizhouapache commented on code in PR #8938:
URL: https://github.com/apache/cloudstack/pull/8938#discussion_r1572292590
##
server/src/test/java/com/cloud/event/ActionEventInterceptorTest.java:
##
@@ -172,6 +172,7 @@ public EventVO answer(InvocationOnMock invocation) throws
Throwable {
account.setId(ACCOUNT_ID);
user = new UserVO(1, "testuser", "password", "firstname", "lastName",
"email", "timezone",
UUID.randomUUID().toString(), User.Source.UNKNOWN);
+CallContext.register(user, account);
Review Comment:
updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [I] Failed Volume Snapshot shows State as BackedUp [cloudstack]
nischalnischal2020 commented on issue #8946:
URL: https://github.com/apache/cloudstack/issues/8946#issuecomment-2066462748
HI @DaanHoogland
There was no file in the secondary storage, besides this we use the Global
parameter = "snapshot.backup.to.secondary = False" So snapshot files would
remain in Primary Storage.
The logs show the error as
2024-03-22 15:47:49,643 DEBUG c.c.a.t.Request (logid:) Seq
19-8222165544694979585: Processing: { Ans: , MgmtId: 195808829246451, via: 19,
Ver: v1, Flags: 10,
[{"org.apache.cloudstack.storage.command.CopyCmdAnswer":{"result":"false","details":"org.apache.cloudstack.utils.qemu.QemuImgException:
qemu-img: Could not open
'rbd:arch-int-vpc-prim/fe23b82c-e8c4-4a14-a4dc-6ea3d54a6c55@db6e00a4-882d-4ad5-b827-b1db5f1bb9e6:mon_host=172.20.202.10:auth_supported=cephx:id=stackusr:key=AQBGk7Fi8IrUDBAA2qvfs+QVVYJ0Ri8jAk7Hiw==:rbd_default_format=2:client_mount_timeout=30':
error reading header from fe23b82c-e8c4-4a14-a4dc-6ea3d54a6c55: No such file
or directory","wait":"0","bypassHostMaintenance":"false"}}] }
2024-03-22 15:47:49,643 DEBUG [c.c.a.t.Request]
(API-Job-Executor-73:ctx-b37e560d job-63965 ctx-7185241a) (logid:606af370) Seq
19-8222165544694979585: Received: { Ans: , MgmtId: 195808829246451, via:
19(SBARCLD-INT-VPC5), Ver: v1, Flags: 10, { CopyCmdAnswer } }
2024-03-22 15:47:49,644 DEBUG [o.a.c.s.s.SnapshotServiceImpl]
(API-Job-Executor-73:ctx-b37e560d job-63965 ctx-7185241a) (logid:606af370)
Failed to copy snapshot
java.lang.RuntimeException: InvocationTargetException when invoking RPC
callback for command: copySnapshotAsyncCallback
at
org.apache.cloudstack.framework.async.AsyncCallbackDispatcher.dispatch(AsyncCallbackDispatcher.java:154)
at
org.apache.cloudstack.framework.async.InplaceAsyncCallbackDriver.performCompletionCallback(InplaceAsyncCallbackDriver.java:25)
at
org.apache.cloudstack.framework.async.AsyncCallbackDispatcher.complete(AsyncCallbackDispatcher.java:126)
at
org.apache.cloudstack.storage.motion.AncientDataMotionStrategy.copyAsync(AncientDataMotionStrategy.java:534)
at
org.apache.cloudstack.storage.motion.DataMotionServiceImpl.copyAsync(DataMotionServiceImpl.java:84)
at
org.apache.cloudstack.storage.motion.DataMotionServiceImpl.copyAsync(DataMotionServiceImpl.java:106)
at
org.apache.cloudstack.storage.snapshot.SnapshotServiceImpl.backupSnapshot(SnapshotServiceImpl.java:283)
at
org.apache.cloudstack.storage.snapshot.DefaultSnapshotStrategy.backupSnapshot(DefaultSnapshotStrategy.java:177)
at
org.apache.cloudstack.snapshot.SnapshotHelper.backupSnapshotToSecondaryStorageIfNotExists(SnapshotHelper.java:134)
at
com.cloud.template.TemplateManagerImpl.createPrivateTemplate(TemplateManagerImpl.java:1644)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
Method)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] test: fix test failures in ActionEventInterceptorTest [cloudstack]
weizhouapache commented on code in PR #8938:
URL: https://github.com/apache/cloudstack/pull/8938#discussion_r1572290467
##
server/src/test/java/com/cloud/event/ActionEventInterceptorTest.java:
##
@@ -172,6 +172,7 @@ public EventVO answer(InvocationOnMock invocation) throws
Throwable {
account.setId(ACCOUNT_ID);
user = new UserVO(1, "testuser", "password", "firstname", "lastName",
"email", "timezone",
UUID.randomUUID().toString(), User.Source.UNKNOWN);
+CallContext.register(user, account);
Review Comment:
good point @vishesh92
thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] merge forward error in logger name [cloudstack]
DaanHoogland commented on PR #8949: URL: https://github.com/apache/cloudstack/pull/8949#issuecomment-2066462166 I agree, but with the number of times we merge forward something is bound to slip through. mea culpa in this case. I'll be more vigilant. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.20/main Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #8602: URL: https://github.com/apache/cloudstack/pull/8602#issuecomment-2066459717 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] merge forward error in logger name [cloudstack]
weizhouapache commented on PR #8949: URL: https://github.com/apache/cloudstack/pull/8949#issuecomment-2066459425 This happened many many times ( I broke main branch last friday as well) we'd better build the whole project before pushing to main branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.20/main Health Check, please don't merge this! [cloudstack]
DaanHoogland commented on PR #8602: URL: https://github.com/apache/cloudstack/pull/8602#issuecomment-2066457918 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
