[GitHub] [incubator-mxnet] sl1pkn07 commented on a change in pull request #17815: [WIP] Add SOVERSION when build shared libmxnet.so library

2020-03-18 Thread GitBox 
sl1pkn07 commented on a change in pull request #17815: [WIP] Add SOVERSION when 
build shared libmxnet.so library
URL: https://github.com/apache/incubator-mxnet/pull/17815#discussion_r394398634
 
 

 ##
 File path: CMakeLists.txt
 ##
 @@ -704,6 +712,8 @@ if(UNIX)
   target_link_libraries(mxnet PRIVATE mxnet_static)
   target_link_libraries(mxnet_static PUBLIC ${CMAKE_DL_LIBS})
   set_target_properties(mxnet_static PROPERTIES OUTPUT_NAME mxnet)
+  set_target_properties(mxnet PROPERTIES VERSION 
"${ver_major}.${ver_minor}.${ver_patch}")
 
 Review comment:
   i think is finally done
   
   tested on local and works as spected


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] sl1pkn07 commented on a change in pull request #17815: [WIP] Add SOVERSION when build shared libmxnet.so library

2020-03-18 Thread GitBox 
sl1pkn07 commented on a change in pull request #17815: [WIP] Add SOVERSION when 
build shared libmxnet.so library
URL: https://github.com/apache/incubator-mxnet/pull/17815#discussion_r394383299
 
 

 ##
 File path: CMakeLists.txt
 ##
 @@ -704,6 +712,8 @@ if(UNIX)
   target_link_libraries(mxnet PRIVATE mxnet_static)
   target_link_libraries(mxnet_static PUBLIC ${CMAKE_DL_LIBS})
   set_target_properties(mxnet_static PROPERTIES OUTPUT_NAME mxnet)
+  set_target_properties(mxnet PROPERTIES VERSION 
"${ver_major}.${ver_minor}.${ver_patch}")
 
 Review comment:
   ook, i found the problem
   
   `project()` is call twice in the main CMakeFile
   
   https://github.com/apache/incubator-mxnet/blob/master/CMakeLists.txt#L9
   https://github.com/apache/incubator-mxnet/blob/master/CMakeLists.txt#L89
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] sl1pkn07 commented on a change in pull request #17815: [WIP] Add SOVERSION when build shared libmxnet.so library

2020-03-18 Thread GitBox 
sl1pkn07 commented on a change in pull request #17815: [WIP] Add SOVERSION when 
build shared libmxnet.so library
URL: https://github.com/apache/incubator-mxnet/pull/17815#discussion_r394383299
 
 

 ##
 File path: CMakeLists.txt
 ##
 @@ -704,6 +712,8 @@ if(UNIX)
   target_link_libraries(mxnet PRIVATE mxnet_static)
   target_link_libraries(mxnet_static PUBLIC ${CMAKE_DL_LIBS})
   set_target_properties(mxnet_static PROPERTIES OUTPUT_NAME mxnet)
+  set_target_properties(mxnet PROPERTIES VERSION 
"${ver_major}.${ver_minor}.${ver_patch}")
 
 Review comment:
   ook, i found the problem
   
   `project()` is call twice in the main CMakeFile
   
   https://github.com/apache/incubator-mxnet/blob/master/CMakeLists.txt#L9
   https://github.com/apache/incubator-mxnet/blob/master/CMakeLists.txt#L89
   
   why this?
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] sl1pkn07 commented on a change in pull request #17815: [WIP] Add SOVERSION when build shared libmxnet.so library

2020-03-18 Thread GitBox 
sl1pkn07 commented on a change in pull request #17815: [WIP] Add SOVERSION when 
build shared libmxnet.so library
URL: https://github.com/apache/incubator-mxnet/pull/17815#discussion_r394377382
 
 

 ##
 File path: CMakeLists.txt
 ##
 @@ -704,6 +712,8 @@ if(UNIX)
   target_link_libraries(mxnet PRIVATE mxnet_static)
   target_link_libraries(mxnet_static PUBLIC ${CMAKE_DL_LIBS})
   set_target_properties(mxnet_static PROPERTIES OUTPUT_NAME mxnet)
+  set_target_properties(mxnet PROPERTIES VERSION 
"${ver_major}.${ver_minor}.${ver_patch}")
 
 Review comment:
   other test, and this surprise me, i just add
   ~~~cmake
   message(STATUS "Project version: ${PROJECT_VERSION}")
   ~~~
   just after `project()` function, and works
   
   
![Screenshot_20200318_151002](https://user-images.githubusercontent.com/462213/76969342-8d657180-692a-11ea-95bc-bb7401e81fae.png)
   
   but is vanished if put that in the bottom/middle of the CMakeLists
   
   
![Screenshot_20200318_151423](https://user-images.githubusercontent.com/462213/76969787-2ac0a580-692b-11ea-8eb2-e1fed938adbc.png)
   
![Screenshot_20200318_151156](https://user-images.githubusercontent.com/462213/76969551-d1587680-692a-11ea-810b-b8d1fba0947a.png)
   
   
   cmake is a bit complex for me, IDK where is the problem, so, i think is 
better keep untounch with `${ver_major}.${ver_minor}.${ver_patch}` and in near 
future (when i found the problem), fix it
   
   greetings
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] sl1pkn07 commented on a change in pull request #17815: [WIP] Add SOVERSION when build shared libmxnet.so library

2020-03-18 Thread GitBox 
sl1pkn07 commented on a change in pull request #17815: [WIP] Add SOVERSION when 
build shared libmxnet.so library
URL: https://github.com/apache/incubator-mxnet/pull/17815#discussion_r394377382
 
 

 ##
 File path: CMakeLists.txt
 ##
 @@ -704,6 +712,8 @@ if(UNIX)
   target_link_libraries(mxnet PRIVATE mxnet_static)
   target_link_libraries(mxnet_static PUBLIC ${CMAKE_DL_LIBS})
   set_target_properties(mxnet_static PROPERTIES OUTPUT_NAME mxnet)
+  set_target_properties(mxnet PROPERTIES VERSION 
"${ver_major}.${ver_minor}.${ver_patch}")
 
 Review comment:
   other test, and this surprise me, i just add
   ~~~cmake
   message(STATUS "Project version: ${PROJECT_VERSION}")
   ~~~
   just before `project()` function, and works
   
   
![Screenshot_20200318_151002](https://user-images.githubusercontent.com/462213/76969342-8d657180-692a-11ea-95bc-bb7401e81fae.png)
   
   but is vanished if put that in the bottom/middle of the CMakeLists
   
   
![Screenshot_20200318_151423](https://user-images.githubusercontent.com/462213/76969787-2ac0a580-692b-11ea-8eb2-e1fed938adbc.png)
   
![Screenshot_20200318_151156](https://user-images.githubusercontent.com/462213/76969551-d1587680-692a-11ea-810b-b8d1fba0947a.png)
   
   
   cmake is a bit complex for me, IDK where is the problem, so, i think is 
better keep untounch with `${ver_major}.${ver_minor}.${ver_patch}` and in near 
future (when i found the problem), fix it
   
   greetings
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] sl1pkn07 commented on a change in pull request #17815: [WIP] Add SOVERSION when build shared libmxnet.so library

2020-03-18 Thread GitBox 
sl1pkn07 commented on a change in pull request #17815: [WIP] Add SOVERSION when 
build shared libmxnet.so library
URL: https://github.com/apache/incubator-mxnet/pull/17815#discussion_r394377382
 
 

 ##
 File path: CMakeLists.txt
 ##
 @@ -704,6 +712,8 @@ if(UNIX)
   target_link_libraries(mxnet PRIVATE mxnet_static)
   target_link_libraries(mxnet_static PUBLIC ${CMAKE_DL_LIBS})
   set_target_properties(mxnet_static PROPERTIES OUTPUT_NAME mxnet)
+  set_target_properties(mxnet PROPERTIES VERSION 
"${ver_major}.${ver_minor}.${ver_patch}")
 
 Review comment:
   other test, ans this surprise me, i just add
   ~~~cmake
   message(STATUS "Project version: ${PROJECT_VERSION}")
   ~~~
   just before `project()` function, and works
   
   
![Screenshot_20200318_151002](https://user-images.githubusercontent.com/462213/76969342-8d657180-692a-11ea-95bc-bb7401e81fae.png)
   
   but is vanished if put that in the bottom/middle of the CMakeLists
   
   
![Screenshot_20200318_151423](https://user-images.githubusercontent.com/462213/76969787-2ac0a580-692b-11ea-8eb2-e1fed938adbc.png)
   
![Screenshot_20200318_151156](https://user-images.githubusercontent.com/462213/76969551-d1587680-692a-11ea-810b-b8d1fba0947a.png)
   
   
   cmake is a bit complex for me, IDK where is the problem, so, i think is 
better keep untounch with `${ver_major}.${ver_minor}.${ver_patch}` and in near 
future (when i found the problem), fix it
   
   greetings
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] sl1pkn07 commented on a change in pull request #17815: [WIP] Add SOVERSION when build shared libmxnet.so library

2020-03-18 Thread GitBox 
sl1pkn07 commented on a change in pull request #17815: [WIP] Add SOVERSION when 
build shared libmxnet.so library
URL: https://github.com/apache/incubator-mxnet/pull/17815#discussion_r394377382
 
 

 ##
 File path: CMakeLists.txt
 ##
 @@ -704,6 +712,8 @@ if(UNIX)
   target_link_libraries(mxnet PRIVATE mxnet_static)
   target_link_libraries(mxnet_static PUBLIC ${CMAKE_DL_LIBS})
   set_target_properties(mxnet_static PROPERTIES OUTPUT_NAME mxnet)
+  set_target_properties(mxnet PROPERTIES VERSION 
"${ver_major}.${ver_minor}.${ver_patch}")
 
 Review comment:
   other test, ans this surprise me, i just add
   ~~~cmake
   message(STATUS "Project version: ${PROJECT_VERSION}")
   ~~~
   just before `project()` function, and works
   
   
![Screenshot_20200318_151002](https://user-images.githubusercontent.com/462213/76969342-8d657180-692a-11ea-95bc-bb7401e81fae.png)
   
   bus is vanished if put that in the bottom/middle of the CMakeLists
   
   
![Screenshot_20200318_151423](https://user-images.githubusercontent.com/462213/76969787-2ac0a580-692b-11ea-8eb2-e1fed938adbc.png)
   
![Screenshot_20200318_151156](https://user-images.githubusercontent.com/462213/76969551-d1587680-692a-11ea-810b-b8d1fba0947a.png)
   
   
   cmake is a bit complex for me, IDK where is the problem, so, i think is 
better keep untounch with `${ver_major}.${ver_minor}.${ver_patch}` and in near 
future (i i found the problem), fix it
   
   greetings
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] sl1pkn07 commented on a change in pull request #17815: [WIP] Add SOVERSION when build shared libmxnet.so library

2020-03-18 Thread GitBox 
sl1pkn07 commented on a change in pull request #17815: [WIP] Add SOVERSION when 
build shared libmxnet.so library
URL: https://github.com/apache/incubator-mxnet/pull/17815#discussion_r394362027
 
 

 ##
 File path: CMakeLists.txt
 ##
 @@ -704,6 +712,8 @@ if(UNIX)
   target_link_libraries(mxnet PRIVATE mxnet_static)
   target_link_libraries(mxnet_static PUBLIC ${CMAKE_DL_LIBS})
   set_target_properties(mxnet_static PROPERTIES OUTPUT_NAME mxnet)
+  set_target_properties(mxnet PROPERTIES VERSION 
"${ver_major}.${ver_minor}.${ver_patch}")
 
 Review comment:
   without quotes
   
   
   
![Screenshot_20200318_145003](https://user-images.githubusercontent.com/462213/76967483-d1a34280-6927-11ea-906c-f0dc921da0d5.png)
   
   
   
   with quotes
   
   
   
![Screenshot_20200318_145123](https://user-images.githubusercontent.com/462213/76967664-01524a80-6928-11ea-8a4c-d3855e2a4f15.png)
   
   
   
   if you see some examples you postes, `PROJECT_VERSION` is ser as sis before
   
   
https://github.com/fps/ladspa.m.plugins/blob/3d595382b72674e926fb52a426fa7689ce1aa999/CMakeLists.txt#L8
   
https://github.com/devcrmbmp812/QTwork/blob/56129534067aa2bc0875e538ce91f8e32ae84e72/CMakeLists.txt#L6
   
   
   the only case i test and works is 
https://github.com/eyjohn/scratch-binary-compat/blob/master/CMakeLists.txt
   but this, as you see in the captures, not works on mxnet


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] sl1pkn07 commented on a change in pull request #17815: [WIP] Add SOVERSION when build shared libmxnet.so library

2020-03-18 Thread GitBox 
sl1pkn07 commented on a change in pull request #17815: [WIP] Add SOVERSION when 
build shared libmxnet.so library
URL: https://github.com/apache/incubator-mxnet/pull/17815#discussion_r394362027
 
 

 ##
 File path: CMakeLists.txt
 ##
 @@ -704,6 +712,8 @@ if(UNIX)
   target_link_libraries(mxnet PRIVATE mxnet_static)
   target_link_libraries(mxnet_static PUBLIC ${CMAKE_DL_LIBS})
   set_target_properties(mxnet_static PROPERTIES OUTPUT_NAME mxnet)
+  set_target_properties(mxnet PROPERTIES VERSION 
"${ver_major}.${ver_minor}.${ver_patch}")
 
 Review comment:
   without quotes
   
   
   
![Screenshot_20200318_145003](https://user-images.githubusercontent.com/462213/76967483-d1a34280-6927-11ea-906c-f0dc921da0d5.png)
   
   
   
   with quotes
   
   
   
![Screenshot_20200318_145123](https://user-images.githubusercontent.com/462213/76967664-01524a80-6928-11ea-8a4c-d3855e2a4f15.png)
   
   
   
   if you see some examples you paste, `PROJECT_VERSION` is ser as sis before
   
   
https://github.com/fps/ladspa.m.plugins/blob/3d595382b72674e926fb52a426fa7689ce1aa999/CMakeLists.txt#L8
   
https://github.com/devcrmbmp812/QTwork/blob/56129534067aa2bc0875e538ce91f8e32ae84e72/CMakeLists.txt#L6
   
   
   the only case i test and works is 
https://github.com/eyjohn/scratch-binary-compat/blob/master/CMakeLists.txt
   but this, as you see in the captures, not works on mxnet


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] sl1pkn07 commented on a change in pull request #17815: [WIP] Add SOVERSION when build shared libmxnet.so library

2020-03-18 Thread GitBox 
sl1pkn07 commented on a change in pull request #17815: [WIP] Add SOVERSION when 
build shared libmxnet.so library
URL: https://github.com/apache/incubator-mxnet/pull/17815#discussion_r394362027
 
 

 ##
 File path: CMakeLists.txt
 ##
 @@ -704,6 +712,8 @@ if(UNIX)
   target_link_libraries(mxnet PRIVATE mxnet_static)
   target_link_libraries(mxnet_static PUBLIC ${CMAKE_DL_LIBS})
   set_target_properties(mxnet_static PROPERTIES OUTPUT_NAME mxnet)
+  set_target_properties(mxnet PROPERTIES VERSION 
"${ver_major}.${ver_minor}.${ver_patch}")
 
 Review comment:
   without quotes
   
   
   
![Screenshot_20200318_145003](https://user-images.githubusercontent.com/462213/76967483-d1a34280-6927-11ea-906c-f0dc921da0d5.png)
   
   
   
   with quotes
   
   
   
![Screenshot_20200318_145123](https://user-images.githubusercontent.com/462213/76967664-01524a80-6928-11ea-8a4c-d3855e2a4f15.png)
   
   
   
   if you see some examples you paste, `PROJECT_VERSION` is set as-sis before
   
   
https://github.com/fps/ladspa.m.plugins/blob/3d595382b72674e926fb52a426fa7689ce1aa999/CMakeLists.txt#L8
   
https://github.com/devcrmbmp812/QTwork/blob/56129534067aa2bc0875e538ce91f8e32ae84e72/CMakeLists.txt#L6
   
   
   the only case i test and works is 
https://github.com/eyjohn/scratch-binary-compat/blob/master/CMakeLists.txt
   but this, as you see in the captures, not works on mxnet


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] sl1pkn07 commented on a change in pull request #17815: [WIP] Add SOVERSION when build shared libmxnet.so library

2020-03-18 Thread GitBox 
sl1pkn07 commented on a change in pull request #17815: [WIP] Add SOVERSION when 
build shared libmxnet.so library
URL: https://github.com/apache/incubator-mxnet/pull/17815#discussion_r394362027
 
 

 ##
 File path: CMakeLists.txt
 ##
 @@ -704,6 +712,8 @@ if(UNIX)
   target_link_libraries(mxnet PRIVATE mxnet_static)
   target_link_libraries(mxnet_static PUBLIC ${CMAKE_DL_LIBS})
   set_target_properties(mxnet_static PROPERTIES OUTPUT_NAME mxnet)
+  set_target_properties(mxnet PROPERTIES VERSION 
"${ver_major}.${ver_minor}.${ver_patch}")
 
 Review comment:
   without quotes
   
   
   
![Screenshot_20200318_145003](https://user-images.githubusercontent.com/462213/76967483-d1a34280-6927-11ea-906c-f0dc921da0d5.png)
   
   
   
   with quotes
   
   
   
![Screenshot_20200318_145123](https://user-images.githubusercontent.com/462213/76967664-01524a80-6928-11ea-8a4c-d3855e2a4f15.png)
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] sl1pkn07 commented on a change in pull request #17815: [WIP] Add SOVERSION when build shared libmxnet.so library

2020-03-17 Thread GitBox 
sl1pkn07 commented on a change in pull request #17815: [WIP] Add SOVERSION when 
build shared libmxnet.so library
URL: https://github.com/apache/incubator-mxnet/pull/17815#discussion_r394081119
 
 

 ##
 File path: CMakeLists.txt
 ##
 @@ -704,6 +712,8 @@ if(UNIX)
   target_link_libraries(mxnet PRIVATE mxnet_static)
   target_link_libraries(mxnet_static PUBLIC ${CMAKE_DL_LIBS})
   set_target_properties(mxnet_static PROPERTIES OUTPUT_NAME mxnet)
+  set_target_properties(mxnet PROPERTIES VERSION 
"${ver_major}.${ver_minor}.${ver_patch}")
 
 Review comment:
   like this?
   
   ~~~cmake
 set_target_properties(mxnet PROPERTIES VERSION "${PROJECT_VERSION}")
 set_target_properties(mxnet PROPERTIES SOVERSION 
"${PROJECT_VERSION_MAJOR}")
   ~~~


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] sl1pkn07 commented on a change in pull request #17815: [WIP] Add SOVERSION when build shared libmxnet.so library

2020-03-17 Thread GitBox 
sl1pkn07 commented on a change in pull request #17815: [WIP] Add SOVERSION when 
build shared libmxnet.so library
URL: https://github.com/apache/incubator-mxnet/pull/17815#discussion_r394047949
 
 

 ##
 File path: CMakeLists.txt
 ##
 @@ -704,6 +712,8 @@ if(UNIX)
   target_link_libraries(mxnet PRIVATE mxnet_static)
   target_link_libraries(mxnet_static PUBLIC ${CMAKE_DL_LIBS})
   set_target_properties(mxnet_static PROPERTIES OUTPUT_NAME mxnet)
+  set_target_properties(mxnet PROPERTIES VERSION 
"${ver_major}.${ver_minor}.${ver_patch}")
 
 Review comment:
   needs this with the last change?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] sl1pkn07 commented on a change in pull request #17815: [WIP] Add SOVERSION when build shared libmxnet.so library

2020-03-17 Thread GitBox 
sl1pkn07 commented on a change in pull request #17815: [WIP] Add SOVERSION when 
build shared libmxnet.so library
URL: https://github.com/apache/incubator-mxnet/pull/17815#discussion_r394047744
 
 

 ##
 File path: CMakeLists.txt
 ##
 @@ -1,5 +1,14 @@
 cmake_minimum_required(VERSION 3.13)
 
+file(READ "include/mxnet/base.h" ver)
+string(REGEX MATCH "MXNET_MAJOR ([0-9]*)" _ ${ver})
+set(ver_major ${CMAKE_MATCH_1})
+string(REGEX MATCH "MXNET_MINOR ([0-9]*)" _ ${ver})
+set(ver_minor ${CMAKE_MATCH_1})
+string(REGEX MATCH "MXNET_PATCH ([0-9]*)" _ ${ver})
+set(ver_patch ${CMAKE_MATCH_1})
+set(_PROJECT_VERSION "${ver_major}.${ver_minor}.${ver_patch}")
 
 Review comment:
   missing "language"
   
   https://cmake.org/cmake/help/latest/command/project.html
   
   noy im not sure if need other changes


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-mxnet] sl1pkn07 commented on a change in pull request #17815: [WIP] Add SOVERSION when build shared libmxnet.so library

2020-03-17 Thread GitBox 
sl1pkn07 commented on a change in pull request #17815: [WIP] Add SOVERSION when 
build shared libmxnet.so library
URL: https://github.com/apache/incubator-mxnet/pull/17815#discussion_r394043698
 
 

 ##
 File path: CMakeLists.txt
 ##
 @@ -1,5 +1,14 @@
 cmake_minimum_required(VERSION 3.13)
 
+file(READ "include/mxnet/base.h" ver)
+string(REGEX MATCH "MXNET_MAJOR ([0-9]*)" _ ${ver})
+set(ver_major ${CMAKE_MATCH_1})
+string(REGEX MATCH "MXNET_MINOR ([0-9]*)" _ ${ver})
+set(ver_minor ${CMAKE_MATCH_1})
+string(REGEX MATCH "MXNET_PATCH ([0-9]*)" _ ${ver})
+set(ver_patch ${CMAKE_MATCH_1})
+set(_PROJECT_VERSION "${ver_major}.${ver_minor}.${ver_patch}")
 
 Review comment:
   because ikd can merge it, is is valid, then I merge it


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services