[GitHub] [incubator-nuttx-apps] xiaoxiang781216 edited a comment on issue #118: Fix parallel buid errors in examples/elf
xiaoxiang781216 edited a comment on issue #118: Fix parallel buid errors in examples/elf URL: https://github.com/apache/incubator-nuttx-apps/pull/118#issuecomment-598017857 @masayuki2009 it seems that this build break relate to this change: ``` Configuration/Tool: spresense/elf,CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL Cleaning... Configuring... Copy files Select CONFIG_HOST_LINUX=y Refreshing... Disabling CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL Enabling CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL Refreshing... Building NuttX... arm-none-eabi-ld: hello++2.o: file not recognized: file truncated make[4]: *** [hello++2] Error 1 make[4]: Target 'all' not remade because of errors. make[3]: *** [helloxx_build] Error 2 make[3]: Target 'all' not remade because of errors. make[2]: *** [tests/symtab.c] Error 2 make[2]: Target 'all' not remade because of errors. make[1]: *** [/home/jenkins/jenkins-slave/workspace/NuttX-Nightly-Build/apps/examples/elf_all] Error 2 make[1]: Target 'all' not remade because of errors. make: *** [../apps/libapps.a] Error 2 make: Target 'all' not remade because of errors. ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on issue #118: Fix parallel buid errors in examples/elf
xiaoxiang781216 commented on issue #118: Fix parallel buid errors in examples/elf URL: https://github.com/apache/incubator-nuttx-apps/pull/118#issuecomment-598017857 @masayuki2009 it seems that this build break relate to this change. Configuration/Tool: spresense/elf,CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL Cleaning... Configuring... Copy files Select CONFIG_HOST_LINUX=y Refreshing... Disabling CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL Enabling CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL Refreshing... Building NuttX... arm-none-eabi-ld: hello++2.o: file not recognized: file truncated make[4]: *** [hello++2] Error 1 make[4]: Target 'all' not remade because of errors. make[3]: *** [helloxx_build] Error 2 make[3]: Target 'all' not remade because of errors. make[2]: *** [tests/symtab.c] Error 2 make[2]: Target 'all' not remade because of errors. make[1]: *** [/home/jenkins/jenkins-slave/workspace/NuttX-Nightly-Build/apps/examples/elf_all] Error 2 make[1]: Target 'all' not remade because of errors. make: *** [../apps/libapps.a] Error 2 make: Target 'all' not remade because of errors. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx-website] btashton commented on issue #18: Initial checkin nuttx website github action workflow
btashton commented on issue #18: Initial checkin nuttx website github action workflow URL: https://github.com/apache/incubator-nuttx-website/pull/18#issuecomment-597992567 I'll take another look. I run publish without sudo locally and everything ends up in the working directory. I'll fork it and take a look at what's up. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #549: boards/xtensa/esp32/esp32-core/include/board.h: nxstyle fixes
xiaoxiang781216 commented on issue #549: boards/xtensa/esp32/esp32-core/include/board.h: nxstyle fixes URL: https://github.com/apache/incubator-nuttx/pull/549#issuecomment-597989437 > > @yamt and @patacongo since the tool need time to improve what we face during the daliy development, how about we don't make the build test depends on style check? So we can ensure the change pass the build, but waive the style problem case by base. > > I think that is a great idea. I like giving the final decision to the committer. There are too many special cases like this where dividing a long line is worse the keeping the line too long. > > And we have to have some way to continue and make progress. It is important to fix style errors, but not as important as making progress and trying not to annoy our contributors too much. @liuguo09 please help change the workflow a litlte bit. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on issue #548: arch/xtensa/src/common/xtensa_abi.h: nxstyle fixes
yamt commented on issue #548: arch/xtensa/src/common/xtensa_abi.h: nxstyle fixes URL: https://github.com/apache/incubator-nuttx/pull/548#issuecomment-597988609 ok. then we need either * reviewers inspect errors manually * or, find an automatic way to detect assembly and skip them This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #549: boards/xtensa/esp32/esp32-core/include/board.h: nxstyle fixes
patacongo commented on issue #549: boards/xtensa/esp32/esp32-core/include/board.h: nxstyle fixes URL: https://github.com/apache/incubator-nuttx/pull/549#issuecomment-597983352 > @yamt and @patacongo since the tool need time to improve what we face during the daliy development, how about we don't make the build test depends on style check? So we can ensure the change pass the build, but waive the style problem case by base. I think that is a great idea. I like giving the final decision to the committer. There are too many special cases like this where dividing a long line is worse the keeping the line too long. And we have to have some way to continue and make progress. It is important to fix style errors, but not as important as making progress and trying not to annoy our contributors too much. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx-website] liuguo09 commented on issue #18: Initial checkin nuttx website github action workflow
liuguo09 commented on issue #18: Initial checkin nuttx website github action workflow URL: https://github.com/apache/incubator-nuttx-website/pull/18#issuecomment-597982320 @btashton please help review again. Seems comments gone after I force pushed to update PR : ( To summarize: 1. I remove the additional sudo apt install bundle line you commented 2. Keep sudo ./publish.sh, or it would fail as below: ERROR: While executing gem ... (Gem::FilePermissionError) You don't have write permissions for the /var/lib/gems/2.5.0 directory. ##[error]Process completed with exit code 1. More details in https://github.com/liuguo09/incubator-nuttx-website/pull/5/checks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-nuttx] branch master updated (45b8e3c -> 7f6bf93)
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 45b8e3c sched/wqueue: Update to Apache 2.0 headers. add 7f6bf93 boards/xtensa/esp32/esp32-core/include/board.h: nxstyle fixes No new revisions were added by this update. Summary of changes: boards/xtensa/esp32/esp32-core/include/board.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #549: boards/xtensa/esp32/esp32-core/include/board.h: nxstyle fixes
xiaoxiang781216 merged pull request #549: boards/xtensa/esp32/esp32-core/include/board.h: nxstyle fixes URL: https://github.com/apache/incubator-nuttx/pull/549 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #549: boards/xtensa/esp32/esp32-core/include/board.h: nxstyle fixes
xiaoxiang781216 commented on issue #549: boards/xtensa/esp32/esp32-core/include/board.h: nxstyle fixes URL: https://github.com/apache/incubator-nuttx/pull/549#issuecomment-597981338 > my suggestion is to make nxstyle skip the check if the line includes a URL-like string. > because: > > * usually URLs are not under our control > * there's no good way to wrap URLs @yamt and @patacongo since the tool need time to improve what we face during the daliy development, how about we don't make the build test depends on style check? So we can ensure the change pass the build, but waive the style problem case by base. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #548: arch/xtensa/src/common/xtensa_abi.h: nxstyle fixes
patacongo commented on issue #548: arch/xtensa/src/common/xtensa_abi.h: nxstyle fixes URL: https://github.com/apache/incubator-nuttx/pull/548#issuecomment-597976013 > > > my suggestion is to stop using *.h for assemby. eg. use *.inc instead. > note: this might be a trivial change because some files are included by both of C and asm. This is not a NuttX convention. .inc is not used by any files in NuttX. It is a converntion of certain vendors of support libraries for MCUs. We cannot change it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #549: boards/xtensa/esp32/esp32-core/include/board.h: nxstyle fixes
patacongo commented on issue #549: boards/xtensa/esp32/esp32-core/include/board.h: nxstyle fixes URL: https://github.com/apache/incubator-nuttx/pull/549#issuecomment-597975277 To me, I don't mind waiving some style warnings. The job is very big right now but will bet better in the future, I hope. I think we should think about community first and make sure that we are supportive of people who make a good effort. We will catch the error again another day. So, if you are satisified, I have no problem waiving the single remaining issue. I think you do not need my concurrence, I will always trust your judgement on things like this. This all only works because people have good intentions and we trust each other. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on issue #548: arch/xtensa/src/common/xtensa_abi.h: nxstyle fixes
yamt commented on issue #548: arch/xtensa/src/common/xtensa_abi.h: nxstyle fixes URL: https://github.com/apache/incubator-nuttx/pull/548#issuecomment-597972832 my suggestion is to stop using *.h for assemby. eg. use *.inc instead. note: this might be a trivial change because some files are included by both of C and asm. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on issue #550: arch/xtensa/src/esp32/esp32_cpustart.c: nxstyle fixes
yamt commented on issue #550: arch/xtensa/src/esp32/esp32_cpustart.c: nxstyle fixes URL: https://github.com/apache/incubator-nuttx/pull/550#issuecomment-597972420 my suggestion is to hardcode whitelists in nxstyle. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on issue #549: boards/xtensa/esp32/esp32-core/include/board.h: nxstyle fixes
yamt commented on issue #549: boards/xtensa/esp32/esp32-core/include/board.h: nxstyle fixes URL: https://github.com/apache/incubator-nuttx/pull/549#issuecomment-597972221 my suggestion is to make nxstyle skip the check if the line includes a URL-like string. because: * usually URLs are not under our control * there's no good way to wrap URLs This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #549: boards/xtensa/esp32/esp32-core/include/board.h: nxstyle fixes
xiaoxiang781216 commented on issue #549: boards/xtensa/esp32/esp32-core/include/board.h: nxstyle fixes URL: https://github.com/apache/incubator-nuttx/pull/549#issuecomment-597971598 @patacongo should we waive this warning? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] yamt opened a new pull request #550: arch/xtensa/src/esp32/esp32_cpustart.c: nxstyle fixes
yamt opened a new pull request #550: arch/xtensa/src/esp32/esp32_cpustart.c: nxstyle fixes URL: https://github.com/apache/incubator-nuttx/pull/550 The remaining errors: Mixed case identifier found I didn't fix them because they were on ROM symbols, which are not supposed to obey NuttX's coding style. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] yamt opened a new pull request #549: boards/xtensa/esp32/esp32-core/include/board.h: nxstyle fixes
yamt opened a new pull request #549: boards/xtensa/esp32/esp32-core/include/board.h: nxstyle fixes URL: https://github.com/apache/incubator-nuttx/pull/549 The remaining errors: Long line found I didn't fix it because it's on a URL. There's no good way to wrap a URL as far as I know. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] yamt opened a new pull request #548: arch/xtensa/src/common/xtensa_abi.h: nxstyle fixes
yamt opened a new pull request #548: arch/xtensa/src/common/xtensa_abi.h: nxstyle fixes URL: https://github.com/apache/incubator-nuttx/pull/548 The remaining errors: Operator/assignment must be preceded with whitespace I didn't fix them because they are in assembly code, which nxstyle doesn't understand. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-nuttx-apps] branch master updated (0cb3712 -> 176fd27)
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git. from 0cb3712 examples/sotest/lib: Fix dependency new b1fd3ec examples: elf: Fix parallel build errors new 176fd27 examples: elf: Fix parallel build errors at link time The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: examples/elf/Makefile | 11 ++- examples/elf/tests/Makefile | 3 ++- 2 files changed, 4 insertions(+), 10 deletions(-)
[incubator-nuttx-apps] 01/02: examples: elf: Fix parallel build errors
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git commit b1fd3ec8d8b9c593f870c953447a98e6565579f7 Author: Masayuki Ishikawa AuthorDate: Wed Mar 11 13:07:21 2020 +0900 examples: elf: Fix parallel build errors NOTE: Apply the same logic as in examples/posix_spawn/Makefile Signed-off-by: Masayuki Ishikawa --- examples/elf/Makefile | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/examples/elf/Makefile b/examples/elf/Makefile index e8279cc..b867753 100644 --- a/examples/elf/Makefile +++ b/examples/elf/Makefile @@ -51,18 +51,11 @@ ROOTDEPPATH := --dep-path tests VPATH += :tests -ifeq ($(CONFIG_EXAMPLES_ELF_ROMFS),y) - FSIMG_HDR = $(TESTS_DIR)/romfs.h -else - FSIMG_HDR = $(TESTS_DIR)/cromfs.h -endif - -elf_main.c: tests/symtab.c - -tests/symtab.c tests/dirlist.h $(FSIMG_HDR): +context:: @$(MAKE) -C tests TOPDIR="$(TOPDIR)" APPDIR="$(APPDIR)" CROSSDEV=$(CROSSDEV) clean:: @$(MAKE) -C tests TOPDIR="$(TOPDIR)" APPDIR="$(APPDIR)" CROSSDEV=$(CROSSDEV) clean + $(call CLEAN) include $(APPDIR)/Application.mk
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #118: Fix parallel buid errors in examples/elf
xiaoxiang781216 merged pull request #118: Fix parallel buid errors in examples/elf URL: https://github.com/apache/incubator-nuttx-apps/pull/118 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-nuttx-apps] 02/02: examples: elf: Fix parallel build errors at link time
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git commit 176fd27c8ab9e9eb7d72b5501a8acca94cc38734 Author: Masayuki Ishikawa AuthorDate: Wed Mar 11 13:13:26 2020 +0900 examples: elf: Fix parallel build errors at link time During generating symtab.c, compile seqeuence would start with incomplete symtab.c. This change will fix such a situation. Signed-off-by: Masayuki Ishikawa --- examples/elf/tests/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/examples/elf/tests/Makefile b/examples/elf/tests/Makefile index fd97821..03c1ca3 100644 --- a/examples/elf/tests/Makefile +++ b/examples/elf/tests/Makefile @@ -141,7 +141,8 @@ $(DIRLIST_HDR) : populate # Create the exported symbol table $(SYMTAB_SRC): populate - $(Q) $(TESTS_DIR)/mksymtab.sh $(FSIMG_DIR) >$@ + $(Q) $(TESTS_DIR)/mksymtab.sh $(FSIMG_DIR) >$@_tmp + $(Q) mv $@_tmp $@ # Clean each subdirectory
[GitHub] [incubator-nuttx] btashton commented on issue #546: sched/timer: Update most files to Apache 2.0
btashton commented on issue #546: sched/timer: Update most files to Apache 2.0 URL: https://github.com/apache/incubator-nuttx/pull/546#issuecomment-597892402 Why was this just merged when we said there are issues doing this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] btashton commented on issue #545: sched/wdog: Update to Apache 2.0 Headers
btashton commented on issue #545: sched/wdog: Update to Apache 2.0 Headers URL: https://github.com/apache/incubator-nuttx/pull/545#issuecomment-597891931 Please stop! We will have to undo this and make it so much harder to do than analysis This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-nuttx] branch master updated: sched/wqueue: Update to Apache 2.0 headers.
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 45b8e3c sched/wqueue: Update to Apache 2.0 headers. 45b8e3c is described below commit 45b8e3ce7fa26a87b9cfb4c76698544d9aee7be9 Author: Gregory Nutt AuthorDate: Wed Mar 11 14:23:38 2020 -0600 sched/wqueue: Update to Apache 2.0 headers. Also run files through nxstyle to assurand coding standard compliance. --- sched/wqueue/Make.defs| 39 +-- sched/wqueue/kwork_cancel.c | 43 ++--- sched/wqueue/kwork_hpthread.c | 63 +-- sched/wqueue/kwork_inherit.c | 51 +-- sched/wqueue/kwork_lpthread.c | 59 +++- sched/wqueue/kwork_notifier.c | 43 +++-- sched/wqueue/kwork_process.c | 39 +-- sched/wqueue/kwork_queue.c| 54 +++-- sched/wqueue/kwork_signal.c | 39 +-- sched/wqueue/wqueue.h | 44 ++ 10 files changed, 165 insertions(+), 309 deletions(-) diff --git a/sched/wqueue/Make.defs b/sched/wqueue/Make.defs index 8b065ec..5e8bd86 100644 --- a/sched/wqueue/Make.defs +++ b/sched/wqueue/Make.defs @@ -1,35 +1,20 @@ # sched/wqueue/Make.defs # -# Copyright (C) 2014 Gregory Nutt. All rights reserved. -# Author: Gregory Nutt +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. The +# ASF licenses this file to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance with the +# License. You may obtain a copy of the License at # -# Redistribution and use in source and binary forms, with or without -# modification, are permitted provided that the following conditions -# are met: +# http://www.apache.org/licenses/LICENSE-2.0 # -# 1. Redistributions of source code must retain the above copyright -#notice, this list of conditions and the following disclaimer. -# 2. Redistributions in binary form must reproduce the above copyright -#notice, this list of conditions and the following disclaimer in -#the documentation and/or other materials provided with the -#distribution. -# 3. Neither the name NuttX nor the names of its contributors may be -#used to endorse or promote products derived from this software -#without specific prior written permission. -# -# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS -# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT -# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS -# FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE -# COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, -# INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, -# BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS -# OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED -# AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT -# LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN -# ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE -# POSSIBILITY OF SUCH DAMAGE. +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +# License for the specific language governing permissions and limitations +# under the License. # diff --git a/sched/wqueue/kwork_cancel.c b/sched/wqueue/kwork_cancel.c index 526a3d9..7e52e09 100644 --- a/sched/wqueue/kwork_cancel.c +++ b/sched/wqueue/kwork_cancel.c @@ -1,35 +1,20 @@ / * sched/wqueue/kwork_cancel.c * - * Copyright (C) 2014, 2016 Gregory Nutt. All rights reserved. - * Author: Gregory Nutt + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at * - * Redistribution and use in source and binary forms, with or without - * modification, are
[GitHub] [incubator-nuttx] acassis merged pull request #546: sched/timer: Update most files to Apache 2.0
acassis merged pull request #546: sched/timer: Update most files to Apache 2.0 URL: https://github.com/apache/incubator-nuttx/pull/546 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-nuttx] branch master updated: sched/timer: Update most files to Apache 2.0
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new f824989 sched/timer: Update most files to Apache 2.0 f824989 is described below commit f824989acc39b7d783b0a18897eb7c02467bc6d4 Author: Gregory Nutt AuthorDate: Wed Mar 11 14:09:41 2020 -0600 sched/timer: Update most files to Apache 2.0 Update all files possible under sched/timer to Apache 2.0. These excludes two files that have a Xiaomi copyright. Also, run all modified files through nxstyle to assure that the conform to the coding standard. --- sched/timer/Make.defs | 39 ++-- sched/timer/timer.h| 45 + sched/timer/timer_create.c | 43 sched/timer/timer_delete.c | 39 ++-- sched/timer/timer_getoverrun.c | 39 ++-- sched/timer/timer_gettime.c| 39 ++-- sched/timer/timer_initialize.c | 39 ++-- sched/timer/timer_release.c| 39 ++-- sched/timer/timer_settime.c| 50 ++ 9 files changed, 118 insertions(+), 254 deletions(-) diff --git a/sched/timer/Make.defs b/sched/timer/Make.defs index 3da70d8..b7241c8 100644 --- a/sched/timer/Make.defs +++ b/sched/timer/Make.defs @@ -1,35 +1,20 @@ # sched/timer/Make.defs # -# Copyright (C) 2014 Gregory Nutt. All rights reserved. -# Author: Gregory Nutt +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. The +# ASF licenses this file to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance with the +# License. You may obtain a copy of the License at # -# Redistribution and use in source and binary forms, with or without -# modification, are permitted provided that the following conditions -# are met: +# http://www.apache.org/licenses/LICENSE-2.0 # -# 1. Redistributions of source code must retain the above copyright -#notice, this list of conditions and the following disclaimer. -# 2. Redistributions in binary form must reproduce the above copyright -#notice, this list of conditions and the following disclaimer in -#the documentation and/or other materials provided with the -#distribution. -# 3. Neither the name NuttX nor the names of its contributors may be -#used to endorse or promote products derived from this software -#without specific prior written permission. -# -# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS -# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT -# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS -# FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE -# COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, -# INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, -# BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS -# OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED -# AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT -# LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN -# ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE -# POSSIBILITY OF SUCH DAMAGE. +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +# License for the specific language governing permissions and limitations +# under the License. # diff --git a/sched/timer/timer.h b/sched/timer/timer.h index 5a8aaf0..83948bc 100644 --- a/sched/timer/timer.h +++ b/sched/timer/timer.h @@ -1,35 +1,20 @@ / * sched/timer/timer.h * - * Copyright (C) 2007-2009, 2014-2015 Gregory Nutt. All rights reserved. - * Author: Gregory Nutt + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at * - * Redistribution and use in
[GitHub] [incubator-nuttx] acassis merged pull request #547: sched/wqueue: Update to Apache 2.0 headers.
acassis merged pull request #547: sched/wqueue: Update to Apache 2.0 headers. URL: https://github.com/apache/incubator-nuttx/pull/547 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-nuttx] branch pr546 created (now c21d198)
This is an automated email from the ASF dual-hosted git repository. acassis pushed a change to branch pr546 in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. at c21d198 sched/wdog: Update to Apache 2.0 Headers No new revisions were added by this update.
[GitHub] [incubator-nuttx] acassis commented on issue #545: sched/wdog: Update to Apache 2.0 Headers
acassis commented on issue #545: sched/wdog: Update to Apache 2.0 Headers URL: https://github.com/apache/incubator-nuttx/pull/545#issuecomment-597890842 I will follow with this merge since hundreds of other patches like this were committed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-nuttx] branch master updated (bfc15a6 -> c21d198)
This is an automated email from the ASF dual-hosted git repository. acassis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from bfc15a6 z20x: Fixes related to W25 boot configurations. add c21d198 sched/wdog: Update to Apache 2.0 Headers No new revisions were added by this update. Summary of changes: sched/wdog/Make.defs | 39 - sched/wdog/wd_cancel.c | 40 -- sched/wdog/wd_create.c | 39 - sched/wdog/wd_delete.c | 40 -- sched/wdog/wd_gettime.c| 39 - sched/wdog/wd_initialize.c | 39 - sched/wdog/wd_recover.c| 39 - sched/wdog/wd_start.c | 48 -- sched/wdog/wdog.h | 43 ++--- 9 files changed, 114 insertions(+), 252 deletions(-)
[incubator-nuttx] branch pr545 updated: sched/wdog: Update to Apache 2.0 Headers
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch pr545 in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/pr545 by this push: new c21d198 sched/wdog: Update to Apache 2.0 Headers c21d198 is described below commit c21d198ac5692a62c193f346332e178f9fcb06d6 Author: Gregory Nutt AuthorDate: Wed Mar 11 13:51:28 2020 -0600 sched/wdog: Update to Apache 2.0 Headers And run each .c and .h file through nxstyle to assure compliance. --- sched/wdog/Make.defs | 39 - sched/wdog/wd_cancel.c | 40 -- sched/wdog/wd_create.c | 39 - sched/wdog/wd_delete.c | 40 -- sched/wdog/wd_gettime.c| 39 - sched/wdog/wd_initialize.c | 39 - sched/wdog/wd_recover.c| 39 - sched/wdog/wd_start.c | 48 -- sched/wdog/wdog.h | 43 ++--- 9 files changed, 114 insertions(+), 252 deletions(-) diff --git a/sched/wdog/Make.defs b/sched/wdog/Make.defs index c5107bd..43be20c 100644 --- a/sched/wdog/Make.defs +++ b/sched/wdog/Make.defs @@ -1,35 +1,20 @@ # sched/wdog/Make.defs # -# Copyright (C) 2014 Gregory Nutt. All rights reserved. -# Author: Gregory Nutt +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. The +# ASF licenses this file to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance with the +# License. You may obtain a copy of the License at # -# Redistribution and use in source and binary forms, with or without -# modification, are permitted provided that the following conditions -# are met: +# http://www.apache.org/licenses/LICENSE-2.0 # -# 1. Redistributions of source code must retain the above copyright -#notice, this list of conditions and the following disclaimer. -# 2. Redistributions in binary form must reproduce the above copyright -#notice, this list of conditions and the following disclaimer in -#the documentation and/or other materials provided with the -#distribution. -# 3. Neither the name NuttX nor the names of its contributors may be -#used to endorse or promote products derived from this software -#without specific prior written permission. -# -# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS -# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT -# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS -# FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE -# COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, -# INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, -# BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS -# OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED -# AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT -# LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN -# ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE -# POSSIBILITY OF SUCH DAMAGE. +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +# License for the specific language governing permissions and limitations +# under the License. # diff --git a/sched/wdog/wd_cancel.c b/sched/wdog/wd_cancel.c index 01ea2ef..b387386 100644 --- a/sched/wdog/wd_cancel.c +++ b/sched/wdog/wd_cancel.c @@ -1,36 +1,20 @@ / * sched/wdog/wd_cancel.c * - * Copyright (C) 2007-2009, 2014, 2016-2017 Gregory Nutt. All rights - * reserved. - * Author: Gregory Nutt + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at * - * Redistribution and use in source and binary forms, with or without - * modification, are permitted provided that the following conditions - * are met: + *
[GitHub] [incubator-nuttx] acassis merged pull request #545: sched/wdog: Update to Apache 2.0 Headers
acassis merged pull request #545: sched/wdog: Update to Apache 2.0 Headers URL: https://github.com/apache/incubator-nuttx/pull/545 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-nuttx] branch pr545 created (now bfc15a6)
This is an automated email from the ASF dual-hosted git repository. acassis pushed a change to branch pr545 in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. at bfc15a6 z20x: Fixes related to W25 boot configurations. No new revisions were added by this update.
[incubator-nuttx] branch master updated (e9a9485 -> bfc15a6)
This is an automated email from the ASF dual-hosted git repository. acassis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from e9a9485 sched/sched: Appease nxstyle errors (#539) add bfc15a6 z20x: Fixes related to W25 boot configurations. No new revisions were added by this update. Summary of changes: arch/z80/src/ez80/ez80_timerisr.c | 78 + arch/z80/src/ez80/ez80f92.h | 6 +-- boards/z80/ez80/z20x/README.txt | 30 ++ boards/z80/ez80/z20x/src/w25_main.c | 9 - 4 files changed, 102 insertions(+), 21 deletions(-)
[incubator-nuttx] branch pr544 updated: z20x: Fixes related to W25 boot configurations.
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch pr544 in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/pr544 by this push: new bfc15a6 z20x: Fixes related to W25 boot configurations. bfc15a6 is described below commit bfc15a6295de95f77fbadcc11cd324fed27ed6e6 Author: Gregory Nutt AuthorDate: Wed Mar 11 13:28:33 2020 -0600 z20x: Fixes related to W25 boot configurations. arch/z80/src/ez80/ez80_timerisr.c: Correct a mismatch between the programmed reload value and the timer input clock frequency. arch/z80/src/ez80/ez80f92.h: Correct error in timer input clock divider: Bits 2-3, not bits 3-4. boards/z80/ez80/z20x/src/w25_main.c: Correct an uninitialized return value; private function was not declard static. --- arch/z80/src/ez80/ez80_timerisr.c | 78 + arch/z80/src/ez80/ez80f92.h | 6 +-- boards/z80/ez80/z20x/README.txt | 30 ++ boards/z80/ez80/z20x/src/w25_main.c | 9 - 4 files changed, 102 insertions(+), 21 deletions(-) diff --git a/arch/z80/src/ez80/ez80_timerisr.c b/arch/z80/src/ez80/ez80_timerisr.c index 12be388..830fc7a 100644 --- a/arch/z80/src/ez80/ez80_timerisr.c +++ b/arch/z80/src/ez80/ez80_timerisr.c @@ -29,12 +29,57 @@ #include #include +#include #include "chip.h" #include "clock/clock.h" #include "z80_internal.h" / + * Pre-processor Definitions + / + +/* Select a clock divider. Choices are 4, 16, 64, or 256 */ + +#define CLOCK_DIVIDER 16 + +/* Given that: + * + * reload_value = (timer_period * system_clock_frequency) / clock_divider + *= system_clock_frequency / DENOMINATOR + * + * Where: + * + * DENOMINATOR = clock_divider / timer_period + * + * The system timer period is given by CONFIG_USEC_PER_TICK which is usually + * 10,000 corresponding to 100Hz. + * + * + * DENOMINATOR = clock_divider / CONFIG_USEC_PER_TICK / USEC_PER_SEC + *= (USEC_PER_SEC * clock_divider) / CONFIG_USEC_PER_TICK + * + * So for the usual value of CONFIG_USEC_PER_TICK (10,000) and a divider of + * 16, the DENOMINATOR would be 1,600 + */ + +#define DENOMINATOR ((USEC_PER_SEC * CLOCK_DIVIDER) / CONFIG_USEC_PER_TICK) + +/* Pick clock divider register setting */ + +#if CLOCK_DIVIDER == 4 +# define EZ80_TMRCLKDIV EZ80_TMRCLKDIV_4 +#elif CLOCK_DIVIDER == 16 +# define EZ80_TMRCLKDIV EZ80_TMRCLKDIV_16 +#elif CLOCK_DIVIDER == 64 +# define EZ80_TMRCLKDIV EZ80_TMRCLKDIV_64 +#elif CLOCK_DIVIDER == 256 +# define EZ80_TMRCLKDIV EZ80_TMRCLKDIV_256 +#else +# error Invalid clock divider +#endif + +/ * Private Functions / @@ -108,29 +153,30 @@ void up_timer_initialize(void) * In continuous mode: * * timer_period = reload_value x clock_divider / system_clock_frequency + * * or + * * reload_value = (timer_period * system_clock_frequency) / clock_divider + *= system_clock_frequency / DENOMINATOR * - * eZ80F91: - * For timer_period=10mS, and clock_divider=16, that would yield: + * Where: * - * reload_value = system_clock_frequency / 1600 + * DENOMINATOR = clock_divider / timer_period * - * For a system timer of 50,000,000, that would result in a reload value - * of 31,250. + * eZ80F91: + * For timer_period=10mS, and clock_divider=16, that would yield a + * DENOMINATOR of 1600. For a system timer of 50,000,000, that would + * result in a reload value of 31,250. * * eZ80F92: - * For timer_period=10mS, and clock_divider=4, that would yield: - * - * reload_value = system_clock_frequency / 400 - * - * For a system timer of 20,000,000, * divider of 4, that would result - * in a reload value of 50,000. + * For timer_period=10mS, and clock_divider=4, that would yield a + * DENOMINATOR of 1600. For a system timer of 20,000,000, that would + * result in a reload value of 50,000. * * NOTE: The system clock frequency value is defined in the board.h file */ - reload = (uint16_t)(ez80_systemclock / 1600); + reload = (uint16_t)(ez80_systemclock / DENOMINATOR); outp(EZ80_TMR0_RRH, (uint8_t)(reload >> 8)); outp(EZ80_TMR0_RRL, (uint8_t)(reload)); @@ -157,11 +203,11 @@ void up_timer_initialize(void) /* EZ80_TMRCTL_TIMEN: Bit 0: The programmable reload timer is enabled * EZ80_TMRCTL_RLD: Bit 1: Force reload * EZ80_TMRCTL_TIMCONT: Bit 2: The timer operates in CONTINUOUS mode. - * EZ80_TMRCLKDIV_16: Bits 3-4: System clock divider = 16 + * EZ80_TMRCLKDIV: Bits 2-3: Timer
[incubator-nuttx] branch pr544 created (now e9a9485)
This is an automated email from the ASF dual-hosted git repository. acassis pushed a change to branch pr544 in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. at e9a9485 sched/sched: Appease nxstyle errors (#539) No new revisions were added by this update.
[GitHub] [incubator-nuttx] acassis merged pull request #544: z20x: Fixes related to W25 boot configurations.
acassis merged pull request #544: z20x: Fixes related to W25 boot configurations. URL: https://github.com/apache/incubator-nuttx/pull/544 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #546: sched/timer: Update most files to Apache 2.0
patacongo commented on issue #546: sched/timer: Update most files to Apache 2.0 URL: https://github.com/apache/incubator-nuttx/pull/546#issuecomment-597865166 I have been doing this for several weeks in my free time. What you are saying is in complete conflict with the information that was given to me earlier. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] btashton commented on issue #546: sched/timer: Update most files to Apache 2.0
btashton commented on issue #546: sched/timer: Update most files to Apache 2.0 URL: https://github.com/apache/incubator-nuttx/pull/546#issuecomment-597859365 I don't think we should be doing this until we go through the process of establishing and documenting the code history. Just because the copyright on the file is yours it is not enough to convert if others have made non trivial changes. This is what Adam is working on determining. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo opened a new pull request #547: sched/wqueue: Update to Apache 2.0 headers.
patacongo opened a new pull request #547: sched/wqueue: Update to Apache 2.0 headers. URL: https://github.com/apache/incubator-nuttx/pull/547 Also run files through nxstyle to assurand coding standard compliance. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo opened a new pull request #546: sched/timer: Update most files to Apache 2.0
patacongo opened a new pull request #546: sched/timer: Update most files to Apache 2.0 URL: https://github.com/apache/incubator-nuttx/pull/546 Update all files possible under sched/timer to Apache 2.0. These excludes two files that have a Xiaomi copyright. Also, run all modified files through nxstyle to assure that the conform to the coding standard. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo opened a new pull request #545: sched/wdog: Update to Apache 2.0 Headers
patacongo opened a new pull request #545: sched/wdog: Update to Apache 2.0 Headers URL: https://github.com/apache/incubator-nuttx/pull/545 And run each .c and .h file through nxstyle to assure compliance. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo opened a new pull request #544: z20x: Fixes related to W25 boot configurations.
patacongo opened a new pull request #544: z20x: Fixes related to W25 boot configurations. URL: https://github.com/apache/incubator-nuttx/pull/544 arch/z80/src/ez80/ez80_timerisr.c: Correct a mismatch between the programmed reload value and the timer input clock frequency. arch/z80/src/ez80/ez80f92.h: Correct error in timer input clock divider: Bits 2-3, not bits 3-4. boards/z80/ez80/z20x/src/w25_main.c: Correct an uninitialized return value; private function was not declared static. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #536: unclear NuttXCCodingStandard examples
patacongo commented on issue #536: unclear NuttXCCodingStandard examples URL: https://github.com/apache/incubator-nuttx/issues/536#issuecomment-597815127 > Should we add this note to the repo so that that never happens? It is true of all of the documents under the documents tabs. These are only copies. The really should just be read-only This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] davids5 commented on issue #536: unclear NuttXCCodingStandard examples
davids5 commented on issue #536: unclear NuttXCCodingStandard examples URL: https://github.com/apache/incubator-nuttx/issues/536#issuecomment-597812352 @patacongo good to know - Should we add this note to the repo so that that never happens? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #459: stm32h7: support SDRAM via FMC peripherial
patacongo commented on issue #459: stm32h7: support SDRAM via FMC peripherial URL: https://github.com/apache/incubator-nuttx/pull/459#issuecomment-597761012 > As already stated this should have been fixed in #489 or do I miss something? No, it is just that the word "should" is ambiguous. "should" can imply that something done in the past, like "That should do it!" Or it can imply a failure to do something in the past as in "I should have done that". I resolved the ambiguity by assuming the latter. My mistake. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #536: unclear NuttXCCodingStandard examples
patacongo commented on issue #536: unclear NuttXCCodingStandard examples URL: https://github.com/apache/incubator-nuttx/issues/536#issuecomment-597758167 We should carefully entertain any PR to modify the coding standard. Remember that the version in Confluence is NOT the master. The master is in the nuttx repository at Documents/NuttXCCCodingStandard.html and can be updated via PR as with any other file. The verion on Confluence is then a copy of that. Any changes made in Confluence will be lost the next time that the Documents are updated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-nuttx] branch master updated: sched/sched: Appease nxstyle errors (#539)
This is an automated email from the ASF dual-hosted git repository.
gnutt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new e9a9485 sched/sched: Appease nxstyle errors (#539)
e9a9485 is described below
commit e9a94859bc355e706f50946a51232655d1f78671
Author: YAMAMOTO Takashi
AuthorDate: Thu Mar 12 02:10:08 2020 +0900
sched/sched: Appease nxstyle errors (#539)
The remaining errors ("Missing space before closing C comment")
don't make sense. Maybe a bug in nxstyle.
---
sched/sched/sched_addreadytorun.c| 7 ++--
sched/sched/sched_cpuload.c | 3 +-
sched/sched/sched_cpuselect.c| 3 +-
sched/sched/sched_lock.c | 20 +-
sched/sched/sched_note.c | 17 +---
sched/sched/sched_removereadytorun.c | 9 +++--
sched/sched/sched_rrgetinterval.c| 3 +-
sched/sched/sched_setaffinity.c | 11 +++---
sched/sched/sched_setpriority.c | 5 ++-
sched/sched/sched_sporadic.c | 3 +-
sched/sched/sched_thistask.c | 6 +--
sched/sched/sched_unlock.c | 16
sched/sched/sched_wait.c | 3 +-
sched/sched/sched_waitid.c | 18 +
sched/sched/sched_waitpid.c | 77 +++-
15 files changed, 111 insertions(+), 90 deletions(-)
diff --git a/sched/sched/sched_addreadytorun.c
b/sched/sched/sched_addreadytorun.c
index af29b96..c5e7c9a 100644
--- a/sched/sched/sched_addreadytorun.c
+++ b/sched/sched/sched_addreadytorun.c
@@ -201,7 +201,8 @@ bool sched_addreadytorun(FAR struct tcb_s *btcb)
/* Determine the desired new task state. First, if the new task priority
* is higher then the priority of the lowest priority, running task, then
- * the new task will be running and a context switch switch will be required.
+ * the new task will be running and a context switch switch will be
+ * required.
*/
if (rtcb->sched_priority < btcb->sched_priority)
@@ -413,8 +414,8 @@ bool sched_addreadytorun(FAR struct tcb_s *btcb)
* REVISIT: I have seen this assertion fire. Apparently another
* CPU may add another, higher priority task to the same
* g_assignedtasks[] list sometime after sched_cpu_select() was
- * called above, leaving this TCB in the wrong task list if
task_state
- * is TSTATE_TASK_ASSIGNED).
+ * called above, leaving this TCB in the wrong task list if
+ * task_state is TSTATE_TASK_ASSIGNED).
*/
DEBUGASSERT(task_state == TSTATE_TASK_ASSIGNED);
diff --git a/sched/sched/sched_cpuload.c b/sched/sched/sched_cpuload.c
index dfc356b..c82944c 100644
--- a/sched/sched/sched_cpuload.c
+++ b/sched/sched/sched_cpuload.c
@@ -229,7 +229,8 @@ void weak_function nxsched_process_cpuload(void)
* Return load measurement data for the select PID.
*
* Input Parameters:
- * pid - The task ID of the thread of interest. pid == 0 is the IDLE thread.
+ * pid - The task ID of the thread of interest. pid == 0 is the IDLE
+ * thread.
* cpuload - The location to return the CPU load
*
* Returned Value:
diff --git a/sched/sched/sched_cpuselect.c b/sched/sched/sched_cpuselect.c
index e0d28f8..09d457c 100644
--- a/sched/sched/sched_cpuselect.c
+++ b/sched/sched/sched_cpuselect.c
@@ -95,7 +95,8 @@ int sched_cpu_select(cpu_set_t affinity)
if ((affinity & (1 << i)) != 0)
{
- FAR struct tcb_s *rtcb = (FAR struct tcb_s *)g_assignedtasks[i].head;
+ FAR struct tcb_s *rtcb = (FAR struct tcb_s *)
+ g_assignedtasks[i].head;
/* If this thread is executing its IDLE task, the use it. The
* IDLE task is always the last task in the assigned task list.
diff --git a/sched/sched/sched_lock.c b/sched/sched/sched_lock.c
index 1f7f031..d77d6d3 100644
--- a/sched/sched/sched_lock.c
+++ b/sched/sched/sched_lock.c
@@ -86,9 +86,9 @@
*locked.
* 2. Scheduling logic would set the bit associated with the cpu in
*'g_cpu_lockset' when the TCB at the head of the g_assignedtasks[cpu]
- *list transitions has 'lockcount' > 0. This might happen when sched_lock()
- *is called, or after a context switch that changes the TCB at the
- *head of the g_assignedtasks[cpu] list.
+ *list transitions has 'lockcount' > 0. This might happen when
+ *sched_lock() is called, or after a context switch that changes the
+ *TCB at the head of the g_assignedtasks[cpu] list.
* 3. Similarly, the cpu bit in the global 'g_cpu_lockset' would be cleared
*when the TCB at the head of the g_assignedtasks[cpu] list has
*'lockcount' == 0. This might happen when sched_unlock() is called, or
@@ -160,14 +160,14 @@ int sched_lock(void)
#endif
int cpu;
- /* The following operation is non-atomic unless
[GitHub] [incubator-nuttx] patacongo merged pull request #539: sched/sched: Appease nxstyle errors
patacongo merged pull request #539: sched/sched: Appease nxstyle errors URL: https://github.com/apache/incubator-nuttx/pull/539 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-nuttx] branch master updated (295fa01 -> 45196ca)
This is an automated email from the ASF dual-hosted git repository. gnutt pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 295fa01 sched/sched/sched_mergepending.c: Fix nxstyle complaints. add 45196ca tools/nxstyle.c: Check for missing space before closing comment faulty (#543) No new revisions were added by this update. Summary of changes: tools/nxstyle.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
[GitHub] [incubator-nuttx] patacongo merged pull request #543: Addresses Issue #540, check for missing space before closing comment …
patacongo merged pull request #543: Addresses Issue #540, check for missing space before closing comment … URL: https://github.com/apache/incubator-nuttx/pull/543 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo removed a comment on issue #459: stm32h7: support SDRAM via FMC peripherial
patacongo removed a comment on issue #459: stm32h7: support SDRAM via FMC peripherial URL: https://github.com/apache/incubator-nuttx/pull/459#issuecomment-596148082 > @patacongo recognizing your are not failure with github. > > There is a `suggested change` that was requested. > > I have asked you to use that feature and not waste time on adding comments that are not actionable when they can be. The contributor can then merge the suggestion and all our efforts add value not just criticism. Once the review is done the contributor can squash and force push to remove all the bable commits. @davids5 Go to hell. You have no authority here. You are very offensive. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo edited a comment on issue #539: sched/sched: Appease nxstyle errors
patacongo edited a comment on issue #539: sched/sched: Appease nxstyle errors URL: https://github.com/apache/incubator-nuttx/pull/539#issuecomment-597677566 Now I see that some long line fixes that I did in sched/sched/sched_mergepending.c are conflicting with something else. The version from #542 with the shorter lines is the one that is correct. Ah.. I see that I have permission to resolve the conflict. Let's see what fails next. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] johannes-nivus edited a comment on issue #543: Addresses Issue #540, check for missing space before closing comment …
johannes-nivus edited a comment on issue #543: Addresses Issue #540, check for missing space before closing comment … URL: https://github.com/apache/incubator-nuttx/pull/543#issuecomment-597741255 Haha this is funny... Now nxstyle again fails at nxstyle. That's why you shouldn't do something in a hurry. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] johannes-nivus edited a comment on issue #543: Addresses Issue #540, check for missing space before closing comment …
johannes-nivus edited a comment on issue #543: Addresses Issue #540, check for missing space before closing comment … URL: https://github.com/apache/incubator-nuttx/pull/543#issuecomment-597741255 Haha this is funny... nxstyle again fails at nxstyle. That's why you shouldn't do something in a hurry. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] johannes-nivus commented on issue #543: Addresses Issue #540, check for missing space before closing comment …
johannes-nivus commented on issue #543: Addresses Issue #540, check for missing space before closing comment … URL: https://github.com/apache/incubator-nuttx/pull/543#issuecomment-597741255 Haha this i funny... nxstyle again fails at nxstyle. That's why you shouldn't do somethin in a hurry. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] johannes-nivus edited a comment on issue #543: Addresses Issue #540, check for missing space before closing comment …
johannes-nivus edited a comment on issue #543: Addresses Issue #540, check for missing space before closing comment … URL: https://github.com/apache/incubator-nuttx/pull/543#issuecomment-597741255 Haha this i funny... nxstyle again fails at nxstyle. That's why you shouldn't do something in a hurry. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] johannes-nivus opened a new pull request #543: Addresses Issue #540, check for missing space before closing comment …
johannes-nivus opened a new pull request #543: Addresses Issue #540, check for missing space before closing comment … URL: https://github.com/apache/incubator-nuttx/pull/543 …was faulty This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] adamfeuer commented on issue #528: sched/mqueue: Correct/update license headers.
adamfeuer commented on issue #528: sched/mqueue: Correct/update license headers. URL: https://github.com/apache/incubator-nuttx/pull/528#issuecomment-597732333 @xiaoxiang781216 @btashton @patacongo @justinmclean I created a wiki page that tried to summarize what we've discussed in this thread: [License Clearing](https://cwiki.apache.org/confluence/display/NUTTX/License+Clearing) I tried to write a process that was clear and possible to follow to make progress. If it's not right, let me know or just update the wiki page. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] johannes-nivus commented on issue #540: possible nxstyle false alarm: "Missing space before closing C comment"
johannes-nivus commented on issue #540: possible nxstyle false alarm: "Missing space before closing C comment" URL: https://github.com/apache/incubator-nuttx/issues/540#issuecomment-597728208 > > > This is the error: > > At line 1474: line[n-1] == '*' and line[n] == '/' and n >= 2 > > This test at line 1474 is line[n+1] != ' ' and line[n-2] != '*' > > That should be line[n-1] != ' ', right? (actually !isspace(line[n-1])). It is trying to verify that */ is preceded by a space like " */" or by another asterisk as in a block comment "**/" This is just a dumb coding error. > > Do you want to fix it? Or should I? Let's not collide. I will fix it, give me one or two hours. Concerning the comment stuff, I get the idea, and currently your examples shouldn't produce problems... but I will test. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] johannes-nivus commented on issue #459: stm32h7: support SDRAM via FMC peripherial
johannes-nivus commented on issue #459: stm32h7: support SDRAM via FMC peripherial URL: https://github.com/apache/incubator-nuttx/pull/459#issuecomment-597723928 > > > > Also found a small bug in nxstyle.c: > > @johannes-nivus Are you going to fix that one? As already stated this should have been fixed in #489 or do I miss something? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] adamfeuer commented on issue #528: sched/mqueue: Correct/update license headers.
adamfeuer commented on issue #528: sched/mqueue: Correct/update license headers. URL: https://github.com/apache/incubator-nuttx/pull/528#issuecomment-597705639 @justinmclean Thank you, that's the info I needed. I'll work on it getting the list together. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on issue #538: ESP32: Use __asm__ __volatile__ for inline assembly
yamt commented on issue #538: ESP32: Use __asm__ __volatile__ for inline assembly URL: https://github.com/apache/incubator-nuttx/pull/538#issuecomment-597697575 @patacongo here's my attempt. https://github.com/apache/incubator-nuttx/pull/533 please read the commit message. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #459: stm32h7: support SDRAM via FMC peripherial
patacongo commented on issue #459: stm32h7: support SDRAM via FMC peripherial URL: https://github.com/apache/incubator-nuttx/pull/459#issuecomment-597687373 > Also found a small bug in nxstyle.c: @johannes-nivus Are you going to fix that one? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #459: stm32h7: support SDRAM via FMC peripherial
patacongo commented on issue #459: stm32h7: support SDRAM via FMC peripherial URL: https://github.com/apache/incubator-nuttx/pull/459#issuecomment-597682980 Wow... 180 seems excessive. We need to get you out of the critical path on this one so that you can move forward and have a good life. But I can't help be believe that there are not just a few lines that are forcing that huge "ruler", just breaking up a few lines probably all that is necessary. But let's not burden you with that. Many people have a habit of trying to say too much in register definition files. I am guilty of that at times too. It is easier to copy-paste a long bit description from a specificiation than it is to re-write a concise short description. The intention of the register definitions files is simply to provide a proper definition. The comment should not explain the detailed properties of the bit; the user should look in the reference manual for that. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo edited a comment on issue #539: sched/sched: Appease nxstyle errors
patacongo edited a comment on issue #539: sched/sched: Appease nxstyle errors URL: https://github.com/apache/incubator-nuttx/pull/539#issuecomment-597677566 Now I see that some lone line fixes that I did in sched/sched/sched_mergepending.c are conflicting with something else. The version from #542 with the shorter lines is the one that is correct. Ah.. I see that I have permission to resolve the conflict. Let's see what fails next. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #539: sched/sched: Appease nxstyle errors
patacongo commented on issue #539: sched/sched: Appease nxstyle errors URL: https://github.com/apache/incubator-nuttx/pull/539#issuecomment-597677566 Now I see that some lone line fixes that I did in sched/sched/sched_mergepending.c are conflicting with something else. The version from #542 with the shorter lines is the one that is correct. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] davids5 commented on issue #448: Add a sample of git pre-commit hook
davids5 commented on issue #448: Add a sample of git pre-commit hook URL: https://github.com/apache/incubator-nuttx/pull/448#issuecomment-597674843 >I have more experience with Makefile than you imagination: Makefile is a good tool but the shell script is better in some case. There is method to pass the runtime argument(e..g. commit id or directory) to Makefile, but the syntax is very urgly. I am sure you do and are very skilled at it. I think this is why it is so hard for you to gasp that a NOOB needs helper. This I all I am asking you to consider. Solve the simple cases for them, and they learn and grow. >Please tell me how can I check a specific commit id or all source files in a directory? make check_format? but it check all source files: You can not - that is not what it is for. This is not a replacement for the script it is a tool for the first time contributor (We want to to grow the project) The script does the git commands on the branch to get the names of the change files and checks those files. A precommit hook would be different. > That's fine if you want check_contrib, I just require to call checkpatch.sh. Agreed! > My patch mean PR here, I am just asking you to think about the newcomers to the project. You and I understand your usage in context. But calling a PR a patch will get you patches emailed to you and confuse people. > Do you think it's clear than this: Yes it tells you what to type to make the command work and has tab-completion. > How do you know my internal workflow? Xiaomi never use github internally at all, could you tell me how can I send PR inside the company if we have internal tooling? So please don't make any assumption that my workflow is bad than yours. I do not: All I know is you told me I have to do: cherry-pick (or rebase) to master run the tools, fix the problems and submit. But If I cherry-pick to master, those commits came from somewhere and that STABLE branch is now out of syncing with ONLY the changes I am upstreaming. This mean you have to bring those commits back to STABLE. Compare that to: run the tools from master on your branch fix the CS issue. Cherry-pick and submit. It is better because there is no back and forth cherry-picking. >Why do you ignore my same question? I ask more than Greg. I have to list here to remember you again: Sorry the link is bad. If you use markup it will not get mangled. > The code is there, why you need reverse engineer? Sorry that was bad wording on my part. The elegant bash script that was submitted was to difficult for me to quickly decipher to find what the arguments should have been. I did not know we could pass HEAD to it. Aging this fall into the category of the too skilled assuming their knowledge is common knowledge and , not understanding the needs of the newcomer. > Please contribute your out of tree solution. It comes with cmake and nija - So this is not going to happen any time soon. @xiaoxiang781216 What I am telling you is you are a very brilliant and skilled engineer, and need to consider making the project more inviting to those less skilled than you. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #540: possible nxstyle false alarm: "Missing space before closing C comment"
patacongo commented on issue #540: possible nxstyle false alarm: "Missing space before closing C comment" URL: https://github.com/apache/incubator-nuttx/issues/540#issuecomment-597674609 A slightly more credible example: draw_rectangle(y2 - y1 + 1, /* Height */ x2 - x1 + 1, /* Width */ (y2 -y1 + 1) * /* Area */ (x2 - x1 + 1)); In mathematical logic, sometimes the arguments can be relatively complex expressions mat not be intuitive and should be commented. In the above case, I would probably use local variables to hold at least the height and width, but others do things differently. You get the general idea. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo edited a comment on issue #540: possible nxstyle false alarm: "Missing space before closing C comment"
patacongo edited a comment on issue #540: possible nxstyle false alarm: "Missing space before closing C comment" URL: https://github.com/apache/incubator-nuttx/issues/540#issuecomment-597669642 The issue here is just a nxstyle bug at line 1474. But thinking more about the larger question, "Should comments be allowed in parameter lists?" Ithink that the answer has to be YES. After reconsideration I realize that that is actually done quite often. The example case at hand is perverse, but parameter commenting like the following is very common and should be permitted (in both actual and formal parameters): int foobar(int a,/* This is parameter a */ int b,/* This is parameter b */ int c); /* This is parameter c */ I have done that a few times myself when the values passed as actual parameters are not clear. It is probably not a good thing to do for formal parameters since these should be documented in the "Input Parameters" section of the function header, not in the parameter list. However, many people do put comments on formal parameters. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo edited a comment on issue #540: possible nxstyle false alarm: "Missing space before closing C comment"
patacongo edited a comment on issue #540: possible nxstyle false alarm: "Missing space before closing C comment" URL: https://github.com/apache/incubator-nuttx/issues/540#issuecomment-597669642 The issue here is just a nxstyle bug at line 1474. But thinking more about the larger question, "Should comments be allowed in parameter lists?" Ithink that the answer has to be YES. After reconsideration I realize that that is actually done quite often. The example case at hand is perverse, but parameter commenting like the following is very common and should be permitted (in both actual and formal parameters): int foobar(int a,/* This is parameter a */ int b,/* This is parameter b */ int c); /* This is parameter c */ I have done that a few times myself when the values passed as actual parameters are not clear. It is probably not a good thing to do for formal parameters since these should be document in the "Input Parameters" section of the function header, not in the parameter list. However, many people do that. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] johannes-nivus commented on issue #459: stm32h7: support SDRAM via FMC peripherial
johannes-nivus commented on issue #459: stm32h7: support SDRAM via FMC
peripherial
URL: https://github.com/apache/incubator-nuttx/pull/459#issuecomment-597670246
> The text width has grown to 180 chars :)
> Other than that, nxstyle is happy.
>
> Also found a small bug in nxstyle.c:
>
> ```
> if (len < min)
> {
> min = len;
> lineno_min = lineno_min;
> }
> ```
>
> should have same fix as was done earlier for lineno_max:
>
> lineno_min = lineno;
Should have been fixed in #489
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #540: possible nxstyle false alarm: "Missing space before closing C comment"
patacongo commented on issue #540: possible nxstyle false alarm: "Missing space before closing C comment" URL: https://github.com/apache/incubator-nuttx/issues/540#issuecomment-597669642 The issue here is just a nxstyle bug at line 1474. But thinking more about the larger question, "Should comments be allowed in parameter lists?" this think that the answer has to be YES. After reconsideration I realize that that is actually done quite often. The example case at hand is perverse, but parameter commenting like the following is very common and should be permitted (in both actual and formal parameters): int foobar(int a,/* This is parameter a */ int b,/* This is parameter b */ int c); /* This is parameter c */ I have done that a few times myself when the values passed as actual parameters are not clear. It is probably not a good thing to do for formal parameters since these should be document in the "Input Parameters" section of the function header, not in the parameter list. However, many people do that. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #539: sched/sched: Appease nxstyle errors
xiaoxiang781216 commented on issue #539: sched/sched: Appease nxstyle errors URL: https://github.com/apache/incubator-nuttx/pull/539#issuecomment-597668330 > Let's wait for #542 to be merged and let the checks run again. @yamt you can rebase this PR now. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-nuttx] branch master updated (4e65d54 -> 295fa01)
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 4e65d54 Add OUTTOGGLE mode to STM32H7 timer driver (#541) add 295fa01 sched/sched/sched_mergepending.c: Fix nxstyle complaints. No new revisions were added by this update. Summary of changes: sched/sched/sched_mergepending.c | 49 +++- 1 file changed, 18 insertions(+), 31 deletions(-)
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #542: sched/sched/sched_mergepending.c: Fix nxstyle complaints.
xiaoxiang781216 merged pull request #542: sched/sched/sched_mergepending.c: Fix nxstyle complaints. URL: https://github.com/apache/incubator-nuttx/pull/542 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #538: ESP32: Use __asm__ __volatile__ for inline assembly
patacongo commented on issue #538: ESP32: Use __asm__ __volatile__ for inline assembly URL: https://github.com/apache/incubator-nuttx/pull/538#issuecomment-597656268 @yamt Do you want me to help out with the coding standard problems? I can fix them in a different PR. I ask because I do not want to collide with anything you are doing. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo edited a comment on issue #540: possible nxstyle false alarm: "Missing space before closing C comment"
patacongo edited a comment on issue #540: possible nxstyle false alarm: "Missing space before closing C comment" URL: https://github.com/apache/incubator-nuttx/issues/540#issuecomment-597638797 This is the error: At line 1474: line[n-1] == '*' and line[n] == '/' and n >= 2 This test at line 1474 is line[n+1] != ' ' and line[n-2] != '*' That should be line[n-1] != ' ', right? (actually !isspace(line[n-1])). It is trying to verify that */ is preceded by a space like " */" or by another asterisk as in a block comment "**/" This is just a dumb coding error. Do you want to fix it? Or should I? Let's not collide. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #540: possible nxstyle false alarm: "Missing space before closing C comment"
patacongo commented on issue #540: possible nxstyle false alarm: "Missing space before closing C comment" URL: https://github.com/apache/incubator-nuttx/issues/540#issuecomment-597645658 > I see, but can you please share your opinion concerning comments inside statements that is not commented out code but perhaps an explanation? > > `call(int a /* This is an integer */ );` If it is not prohibited, then it is permitted. Providing it does not conflict with common sense, acceptable practice. And if it conflicts with common sense, acceptable practice then it should be prohibited. I don't have a strong opinion in this case. I would not comment in that way[1]. And would raise my eybrows to see such commenting. Ultimately coding standards come down to aesthetics. But the coding standard must be commonly applied for good software quality. So those aesthetics need to be formalized and made standard .. cast in concrete. If they are not so formalized, then it is left as a matter of personal preference UNLESS you do want to formalilze it. If you want to forbid comments in the argument lists, I will support that but then you should also submit a PR against Documentation/NuttXCCodingStandard.html. That is the master coding standard, the version on the website is a copy. Greg [1] CAVEAT: I don't normally comment this way, but I am the culprit in the example we were discussing. In this case, I just left some commented out stuff left over from debug. I still think that the commented out code is correct but it is commented out because it didn't work and I forgot to remove the comments. In #542 I kept the question but moved it out of the argument list and marked it clearly with REVISIT: This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] johannes-nivus commented on issue #540: possible nxstyle false alarm: "Missing space before closing C comment"
johannes-nivus commented on issue #540: possible nxstyle false alarm: "Missing space before closing C comment" URL: https://github.com/apache/incubator-nuttx/issues/540#issuecomment-597639824 I see, but can you please share your opinion concerning comments inside statements that is not commented out code but perhaps an explanation? `call(int a /* This is an integer */ );` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo edited a comment on issue #540: possible nxstyle false alarm: "Missing space before closing C comment"
patacongo edited a comment on issue #540: possible nxstyle false alarm: "Missing space before closing C comment" URL: https://github.com/apache/incubator-nuttx/issues/540#issuecomment-597638797 This is the error: At line 1474: line[n-1] == '*' and line[n] == '/' and n >= 2 This test at line 1474 is line[n+1] != ' ' and line[n-2] != '*' That should be line[n-1 != ' '], right? (actually !isspace(line[n-1])). It is trying to verify that */ is preceded by a space like " */" or by another asterisk as in a block comment "**/" This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #540: possible nxstyle false alarm: "Missing space before closing C comment"
patacongo commented on issue #540: possible nxstyle false alarm: "Missing space before closing C comment" URL: https://github.com/apache/incubator-nuttx/issues/540#issuecomment-597638797 This is the error: At line 1474: line[n-1] == '*' and line[n] == '/' and n >= 2 This test at line 1474 is line[n+1] != ' ' and line[n-2] != '*' That should be line[n-1], right? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] anpaza commented on issue #459: stm32h7: support SDRAM via FMC peripherial
anpaza commented on issue #459: stm32h7: support SDRAM via FMC peripherial
URL: https://github.com/apache/incubator-nuttx/pull/459#issuecomment-597636050
The text width has grown to 180 chars :)
Other than that, nxstyle is happy.
Also found a small bug in nxstyle.c:
if (len < min)
{
min = len;
lineno_min = lineno_min;
}
should have same fix as was done earlier for lineno_max:
lineno_min = lineno;
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #540: possible nxstyle false alarm: "Missing space before closing C comment"
patacongo commented on issue #540: possible nxstyle false alarm: "Missing space before closing C comment" URL: https://github.com/apache/incubator-nuttx/issues/540#issuecomment-597635517 > The discussion isn't about commented out code, but about comments inside code, perhaps parameter lists Yes, but this case is violating the coding standard for other reasons and is fixed with #542 Please merge, someone. That is gating other PRs. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #539: sched/sched: Appease nxstyle errors
patacongo commented on issue #539: sched/sched: Appease nxstyle errors URL: https://github.com/apache/incubator-nuttx/pull/539#issuecomment-597634093 Let's wait for #542 to be merged and let the checks run again. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo opened a new pull request #542: sched/sched/sched_mergepending.c: Fix nxstyle complaints.
patacongo opened a new pull request #542: sched/sched/sched_mergepending.c: Fix nxstyle complaints. URL: https://github.com/apache/incubator-nuttx/pull/542 And change to Apache 2.0 license. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] johannes-nivus commented on issue #540: possible nxstyle false alarm: "Missing space before closing C comment"
johannes-nivus commented on issue #540: possible nxstyle false alarm: "Missing space before closing C comment" URL: https://github.com/apache/incubator-nuttx/issues/540#issuecomment-597621279 The discussion isn't about commented out code, but about comments inside code, perhaps parameter lists: > ``` > cpu = sched_cpu_select(ALL_CPUS /* ptcb->affinity */); > ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] davids5 edited a comment on issue #459: stm32h7: support SDRAM via FMC peripherial
davids5 edited a comment on issue #459: stm32h7: support SDRAM via FMC peripherial URL: https://github.com/apache/incubator-nuttx/pull/459#issuecomment-597614597 @anpaza > Do you mean: > a) The rulers in file stm32h7x3xx_rcc.h should be extended to cover the longest right-side comment > b) All the comments should be right-side of the respective #define > I can give one more try. Bravo! Yes. The way the file is on master, it only needed the blocks extended. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] davids5 commented on issue #459: stm32h7: support SDRAM via FMC peripherial
davids5 commented on issue #459: stm32h7: support SDRAM via FMC peripherial URL: https://github.com/apache/incubator-nuttx/pull/459#issuecomment-597614597 @a > Do you mean: > a) The rulers in file stm32h7x3xx_rcc.h should be extended to cover the longest right-side comment > b) All the comments should be right-side of the respective #define > I can give one more try. Bravo! Yes. The way the file is on master, it only needed the blocks extended. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] davids5 commented on issue #536: unclear NuttXCCodingStandard examples
davids5 commented on issue #536: unclear NuttXCCodingStandard examples URL: https://github.com/apache/incubator-nuttx/issues/536#issuecomment-597613353 I think the problem is bigger then just this one. Why do we have N ways? Acceptable, Discouraged, Correct, Preferred, In the past if you choose to do it the any way other then Preferred, your contribution would be modified to be the Preferred way. This sort of thing is what makes having or creating a formatting tool a complex mess for NO ADDED value. Why not remove all the ambiguity from the fix the CS document and fix the tool? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] anpaza commented on issue #459: stm32h7: support SDRAM via FMC peripherial
anpaza commented on issue #459: stm32h7: support SDRAM via FMC peripherial URL: https://github.com/apache/incubator-nuttx/pull/459#issuecomment-597612315 Do you mean: a) The rulers in file stm32h7x3xx_rcc.h should be extended to cover the longest right-side comment b) All the comments should be right-side of the respective #define I can give one more try. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx-website] liuguo09 commented on issue #18: Initial checkin nuttx website github action workflow
liuguo09 commented on issue #18: Initial checkin nuttx website github action workflow URL: https://github.com/apache/incubator-nuttx-website/pull/18#issuecomment-597610928 One of the github action CI in my own fork as below: https://github.com/liuguo09/incubator-nuttx-website/pull/8/checks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] davids5 commented on issue #459: stm32h7: support SDRAM via FMC peripherial
davids5 commented on issue #459: stm32h7: support SDRAM via FMC peripherial URL: https://github.com/apache/incubator-nuttx/pull/459#issuecomment-597608242 @anpaza - Again I must apologizes to you for our poor tooling, and my inability to communicate the steps to fix it. If it is OK with you , I will push a commit to this PR that will pass CI on the rcc file by changing the ruler. The issue I have is is that I have several deadlines I have to meet and will not be abel to get to it right away. The approach I will take is revert the rcc file and just add your code changes to it. Then lengthen the block comments. This why of fixing the file is 100% OK in a arch .h file. The way I will push it is documented here: https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/committing-changes-to-a-pull-request-branch-created-from-a-fork This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx-website] liuguo09 opened a new pull request #18: Initial checkin nuttx website github action workflow
liuguo09 opened a new pull request #18: Initial checkin nuttx website github action workflow URL: https://github.com/apache/incubator-nuttx-website/pull/18 Nuttx website github action workflow: 1. Checkout nuttx website 2. Install essential tools 3. Run publish.sh and push asf-site branch Signed-off-by: liuhaitao This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] davids5 merged pull request #541: Add OUTTOGGLE mode to STM32H7 timer driver
davids5 merged pull request #541: Add OUTTOGGLE mode to STM32H7 timer driver URL: https://github.com/apache/incubator-nuttx/pull/541 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-nuttx] branch master updated: Add OUTTOGGLE mode to STM32H7 timer driver (#541)
This is an automated email from the ASF dual-hosted git repository. davids5 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 4e65d54 Add OUTTOGGLE mode to STM32H7 timer driver (#541) 4e65d54 is described below commit 4e65d543d869b9236dc86d20f1b21bd8c6a91458 Author: Andrey Zabolotnyi AuthorDate: Wed Mar 11 15:18:43 2020 +0300 Add OUTTOGGLE mode to STM32H7 timer driver (#541) * stm32h7: New timer output mode STM32_TIM_CH_OUTTOGGLE. In this mode timer generates a square waveform on given timer channel. The maximal waveform freq is timer clock divided by 4 (prescaler 1, period 1 results in 2 clocks '0' and 2 clocks '1'). * stm32_tim.h styling fixes. --- arch/arm/src/stm32h7/stm32_tim.c | 5 + arch/arm/src/stm32h7/stm32_tim.h | 5 +++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/arch/arm/src/stm32h7/stm32_tim.c b/arch/arm/src/stm32h7/stm32_tim.c index 6761cfd..464d1f6 100644 --- a/arch/arm/src/stm32h7/stm32_tim.c +++ b/arch/arm/src/stm32h7/stm32_tim.c @@ -904,6 +904,11 @@ static int stm32_tim_setchannel(FAR struct stm32_tim_dev_s *dev, case STM32_TIM_CH_DISABLED: break; + case STM32_TIM_CH_OUTTOGGLE: +ccmr_val = (ATIM_CCMR_MODE_OCREFTOG << ATIM_CCMR1_OC1M_SHIFT); +ccer_val |= ATIM_CCER_CC1E << (channel << 2); +break; + case STM32_TIM_CH_OUTPWM: ccmr_val = (ATIM_CCMR_MODE_PWM1 << ATIM_CCMR1_OC1M_SHIFT) + ATIM_CCMR1_OC1PE; diff --git a/arch/arm/src/stm32h7/stm32_tim.h b/arch/arm/src/stm32h7/stm32_tim.h index ab935cd..f1b3a99 100644 --- a/arch/arm/src/stm32h7/stm32_tim.h +++ b/arch/arm/src/stm32h7/stm32_tim.h @@ -137,11 +137,12 @@ typedef enum /* MODES: */ - STM32_TIM_CH_MODE_MASK = 0x06, + STM32_TIM_CH_MODE_MASK = 0x0e, /* Output Compare Modes */ STM32_TIM_CH_OUTPWM = 0x04,/* Enable standard PWM mode, active high when counter < compare */ + STM32_TIM_CH_OUTTOGGLE = 0x08,/* Toggle TIM_CHx output on UEV */ #if 0 STM32_TIM_CH_OUTCOMPARE = 0x06, @@ -181,7 +182,7 @@ struct stm32_tim_ops_s }; / - * Public Functions + * Public Function Prototypes / /* Power-up timer and get its structure */
[GitHub] [incubator-nuttx] patacongo commented on issue #540: possible nxstyle false alarm: "Missing space before closing C comment"
patacongo commented on issue #540: possible nxstyle false alarm: "Missing space before closing C comment" URL: https://github.com/apache/incubator-nuttx/issues/540#issuecomment-597598260 > I don't think comments inside code statements should be encouraged The coding standard is clear about any form of commented out code. It should be avoided unless there is explanation, then the may be disabled only with #if 0, never commented out. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] anpaza opened a new pull request #541: Add OUTTOGGLE mode to STM32H7 timer driver
anpaza opened a new pull request #541: Add OUTTOGGLE mode to STM32H7 timer driver URL: https://github.com/apache/incubator-nuttx/pull/541 This patch adds a mode to toggle timer output pin on every counter overflow. The implementation was just borrowed from STM32F7 port. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
