[GitHub] [incubator-nuttx] anchao opened a new pull request, #7409: boards/arm/gcc: disable coverage analysis temporarily
anchao opened a new pull request, #7409:
URL: https://github.com/apache/incubator-nuttx/pull/7409
## Summary
boards/arm/gcc: disable coverage analysis temporarily
**Please revert this change if arm resolved this issue in the next release**
ARM GNU toolchain 11.3.Rel1 missing gcov_* symbols:
https://community.arm.com/support-forums/f/compilers-and-libraries-forum/53354/arm-gnu-toolchain-11-3-rel1-missing-gcov_-symbols
$ arm-none-eabi-gcc -v
```
...
gcc version 11.3.1 20220712 (Arm GNU Toolchain 11.3.Rel1)
```
$ cat main.c
```
int __start(void)
{
return 0;
}
```
Compiler with arm GCC-11.3:
```
$ arm-none-eabi-gcc -c -Wstrict-prototypes -Os -fno-strict-aliasing
-fomit-frame-pointer -fprofile-generate \ -ftest-coverage -mthumb --coverage
-fno-common -Wall -Wshadow -Wundef -ffunction-sections -fdata-sections -g \
-mlittle-endian -mcpu=cortex-m0 -mthumb -mfloat-abi=soft main.c -o main.o
```
```
$ arm-none-eabi-ld --entry=__start -nostdlib --gc-sections
-Tpimoroni-tiny2040-flash.ld -o test_gcov --start-group main.o \
~/gcc/linux/arm/bin/../lib/gcc/arm-none-eabi/11.3.1/thumb/v6-m/nofp/libgcov.a
--end-group arm-none-eabi-ld: main.o: in function `__start':
/home/archer/code/nuttx/n4/incubator-nuttx/main.c:2: undefined reference to
`__gcov_indirect_call_profiler_v4' arm-none-eabi-ld:
/home/archer/code/nuttx/n4/incubator-nuttx/main.c:4: undefined reference to
`__gcov_indirect_call' arm-none-eabi-ld:
/home/archer/code/nuttx/n4/incubator-nuttx/main.c:4: undefined reference to
`__gcov_time_profiler_counter'
```
link success with arm GCC-10.3:
```
$ arm-none-eabi-ld --entry=__start -nostdlib --gc-sections
-Tpimoroni-tiny2040-flash.ld -o test_gcov --start-group main.o \
~/lib/gcc/arm-none-eabi/10.3.1/thumb/v6-m/nofp/libgcov.a --end-group
$ ls -l test_gcov
-rwxrwxr-x 1 archer archer 68744 10月 24 12:51 test_gcov
```
Signed-off-by: chao an
## Impact
$ arm-none-eabi-gcc -v
...
gcc version 11.3.1 20220712 (Arm GNU Toolchain 11.3.Rel1)
## Testing
CI- check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-nuttx] SPRESENSE commented on a diff in pull request #7402: drivers/modem/alt1250: Fix poll function
SPRESENSE commented on code in PR #7402:
URL: https://github.com/apache/incubator-nuttx/pull/7402#discussion_r1002896707
##
drivers/modem/alt1250/alt1250.c:
##
@@ -279,6 +279,25 @@ static void write_evtbitmapwithlist(FAR struct
alt1250_dev_s *dev,
nxmutex_unlock(>evtmaplock);
}
+/
+ * Name: is_evtbitmap_avail
+ /
+
+static int is_evtbitmap_avail(FAR struct alt1250_dev_s *dev)
Review Comment:
Fix with https://github.com/apache/incubator-nuttx/pull/7408
##
drivers/modem/alt1250/alt1250.c:
##
@@ -279,6 +279,25 @@ static void write_evtbitmapwithlist(FAR struct
alt1250_dev_s *dev,
nxmutex_unlock(>evtmaplock);
}
+/
+ * Name: is_evtbitmap_avail
+ /
+
+static int is_evtbitmap_avail(FAR struct alt1250_dev_s *dev)
+{
+ int ret;
Review Comment:
Fix with https://github.com/apache/incubator-nuttx/pull/7408
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-nuttx] SPRESENSE opened a new pull request, #7408: drivers/modem/alt1250: Change return type of bool function
SPRESENSE opened a new pull request, #7408: URL: https://github.com/apache/incubator-nuttx/pull/7408 ## Summary Changed the return type to bool pointed out in the review comments for https://github.com/apache/incubator-nuttx/pull/7402. ## Impact None ## Testing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx] branch master updated (2fd7e18a16 -> 306029e6e4)
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from 2fd7e18a16 include/sys: fix style issues in queue.h add 306029e6e4 lte: Include nuttx/fs/ioctl.h instead of wireless.h No new revisions were added by this update. Summary of changes: include/nuttx/wireless/lte/lte_ioctl.h | 9 + 1 file changed, 5 insertions(+), 4 deletions(-)
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7403: lte: Include nuttx/fs/ioctl.h instead of wireless.h
xiaoxiang781216 merged PR #7403: URL: https://github.com/apache/incubator-nuttx/pull/7403 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7402: drivers/modem/alt1250: Fix poll function
pkarashchenko commented on code in PR #7402:
URL: https://github.com/apache/incubator-nuttx/pull/7402#discussion_r1002886204
##
drivers/modem/alt1250/alt1250.c:
##
@@ -279,6 +279,25 @@ static void write_evtbitmapwithlist(FAR struct
alt1250_dev_s *dev,
nxmutex_unlock(>evtmaplock);
}
+/
+ * Name: is_evtbitmap_avail
+ /
+
+static int is_evtbitmap_avail(FAR struct alt1250_dev_s *dev)
Review Comment:
```suggestion
static bool is_evtbitmap_avail(FAR struct alt1250_dev_s *dev)
```
##
drivers/modem/alt1250/alt1250.c:
##
@@ -279,6 +279,25 @@ static void write_evtbitmapwithlist(FAR struct
alt1250_dev_s *dev,
nxmutex_unlock(>evtmaplock);
}
+/
+ * Name: is_evtbitmap_avail
+ /
+
+static int is_evtbitmap_avail(FAR struct alt1250_dev_s *dev)
+{
+ int ret;
Review Comment:
```suggestion
bool ret;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[incubator-nuttx] branch master updated (33f903178e -> 2fd7e18a16)
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from 33f903178e drivers/modem/alt1250: Fix poll function add a742ff arch/risc-v/src/mpfs/hardware: fix alignment in comment add e43db5fe28 sched/semaphore: fix typo in comment add 2fd7e18a16 include/sys: fix style issues in queue.h No new revisions were added by this update. Summary of changes: arch/risc-v/src/mpfs/hardware/mpfs_usb.h |4 +- include/sys/queue.h | 1230 +++--- sched/semaphore/sem_holder.c | 12 +- 3 files changed, 624 insertions(+), 622 deletions(-)
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7396: Style fixes
xiaoxiang781216 merged PR #7396: URL: https://github.com/apache/incubator-nuttx/pull/7396 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx] branch master updated (8c1036b7a1 -> 33f903178e)
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from 8c1036b7a1 tools/ci/docker/linux/Dockerfile: Keep the installation in alphabetical order add 33f903178e drivers/modem/alt1250: Fix poll function No new revisions were added by this update. Summary of changes: drivers/modem/alt1250/alt1250.c | 52 +++-- 1 file changed, 50 insertions(+), 2 deletions(-)
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7402: drivers/modem/alt1250: Fix poll function
xiaoxiang781216 merged PR #7402: URL: https://github.com/apache/incubator-nuttx/pull/7402 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] W-Mai commented on a diff in pull request #7407: ci/docker: copy `clang-extdef-mapping` to clang-arm
W-Mai commented on code in PR #7407: URL: https://github.com/apache/incubator-nuttx/pull/7407#discussion_r1002869309 ## tools/ci/docker/linux/Dockerfile: ## @@ -308,6 +308,7 @@ ENV PATH="/tools/rust/cargo/bin:$PATH" # ARM toolchain COPY --from=nuttx-toolchain-arm /tools/clang-arm-none-eabi/ clang-arm-none-eabi/ +CMD cp /usr/bin/clang-extdef-mapping-10 clang-arm-none-eabi/bin/clang-extdef-mapping Review Comment: that's ok -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7407: ci/docker: copy `clang-extdef-mapping` to clang-arm
xiaoxiang781216 commented on code in PR #7407: URL: https://github.com/apache/incubator-nuttx/pull/7407#discussion_r1002869097 ## tools/ci/docker/linux/Dockerfile: ## @@ -308,6 +308,7 @@ ENV PATH="/tools/rust/cargo/bin:$PATH" # ARM toolchain COPY --from=nuttx-toolchain-arm /tools/clang-arm-none-eabi/ clang-arm-none-eabi/ +CMD cp /usr/bin/clang-extdef-mapping-10 clang-arm-none-eabi/bin/clang-extdef-mapping Review Comment: let's modify cibuild.sh too -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] W-Mai opened a new pull request, #7407: ci/docker: copy `clang-extdef-mapping` to clang-arm
W-Mai opened a new pull request, #7407: URL: https://github.com/apache/incubator-nuttx/pull/7407 ## Summary Clang relies on clang-extdef-mapping for ctu checking. But clang-arm doesn't provide this file A tweaking way to support this feature is copy a `clang-extdef-mapping` from other clang version. ## Impact ## Testing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #1382: Fixed compiler warnings.
xiaoxiang781216 merged PR #1382: URL: https://github.com/apache/incubator-nuttx-apps/pull/1382 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx-apps] branch master updated: Fixed compiler warnings.
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git
The following commit(s) were added to refs/heads/master by this push:
new d251d12f6 Fixed compiler warnings.
d251d12f6 is described below
commit d251d12f6fa20833245e41db5a886657049f089c
Author: Fotis Panagiotopoulos
AuthorDate: Sun Oct 23 19:10:56 2022 +0300
Fixed compiler warnings.
---
netutils/netlib/netlib_parseurl.c | 2 +-
netutils/webclient/webclient.c| 11 +--
2 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/netutils/netlib/netlib_parseurl.c
b/netutils/netlib/netlib_parseurl.c
index 775f2f189..a80612966 100644
--- a/netutils/netlib/netlib_parseurl.c
+++ b/netutils/netlib/netlib_parseurl.c
@@ -59,7 +59,7 @@ int netlib_parseurl(FAR const char *str, FAR struct url_s
*url)
{
FAR const char *src = str;
FAR char *dest;
- int bytesleft;
+ size_t bytesleft;
int ret = OK;
size_t pathlen;
diff --git a/netutils/webclient/webclient.c b/netutils/webclient/webclient.c
index a24c877cd..41cfe94d9 100644
--- a/netutils/webclient/webclient.c
+++ b/netutils/webclient/webclient.c
@@ -285,6 +285,7 @@ static int webclient_static_body_func(FAR void *buffer,
size_t reqsize,
FAR void *ctx)
{
+ UNUSED(buffer);
*datap = ctx;
*sizep = reqsize;
return 0;
@@ -798,6 +799,8 @@ static inline int wget_parsechunkheader(struct
webclient_context *ctx,
int ndx;
int ret = OK;
+ UNUSED(ctx);
+
offset = ws->offset;
ndx= ws->ndx;
@@ -908,6 +911,8 @@ static inline int wget_parsechunkenddata(struct
webclient_context *ctx,
int ndx;
int ret = OK;
+ UNUSED(ctx);
+
offset = ws->offset;
ndx= ws->ndx;
@@ -966,6 +971,8 @@ static inline int wget_parsechunktrailer(struct
webclient_context *ctx,
int ndx;
int ret = OK;
+ UNUSED(ctx);
+
offset = ws->offset;
ndx= ws->ndx;
@@ -1871,7 +1878,7 @@ int webclient_perform(FAR struct webclient_context *ctx)
DEBUGASSERT(bytes_to_send <= ws->state_len);
ssize_t ssz = webclient_conn_send(conn,
-ws->data_buffer +
+(char *)ws->data_buffer +
ws->state_offset,
bytes_to_send);
if (ssz < 0)
@@ -1891,7 +1898,7 @@ int webclient_perform(FAR struct webclient_context *ctx)
ws->state_len -= ssz;
ws->state_offset += ssz;
DEBUGASSERT(ws->state_offset <= ws->data_len);
- if (ws->state_offset == ws->data_len)
+ if ((size_t)ws->state_offset == ws->data_len)
{
ws->data_buffer = NULL;
}
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #1382: Fixed compiler warnings.
xiaoxiang781216 commented on PR #1382: URL: https://github.com/apache/incubator-nuttx-apps/pull/1382#issuecomment-1288384476 Let's ignore the know ci broken issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7398: Fix error: mmcsd/mmcsd_sdio.c:2669:35: error: 'buffer' may be used uninitialized [-Werror=maybe-uninitialized]
xiaoxiang781216 commented on PR #7398: URL: https://github.com/apache/incubator-nuttx/pull/7398#issuecomment-1288380466 @anchao is looking this problem, look like the toolchain compile libgcov with the wrong config. Anyway, if we can't fix the problem soon, we can temp disable gcov option from defconfig. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx-apps] SPRESENSE opened a new pull request, #1383: wireless: gs2200m: Change usrsock xid from uint64_t to uint32_t
SPRESENSE opened a new pull request, #1383: URL: https://github.com/apache/incubator-nuttx-apps/pull/1383 ## Summary Fix the type to match usrsock.h has been changed by https://github.com/apache/incubator-nuttx/pull/6893 ## Impact ## Testing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] SPRESENSE opened a new pull request, #7406: arch: cxd56xx: Fix stall bulk xfer when sending 512 byte data
SPRESENSE opened a new pull request, #7406: URL: https://github.com/apache/incubator-nuttx/pull/7406 ## Summary Remove hardware zero length packet enhancement because of driver logic already processed the ZLP correctly. It is unnecessary and cause of IN interrupt lost. ## Impact only spresense ## Testing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] SPRESENSE opened a new pull request, #7405: arch: cxd56xx: Fix deadlock by using GNSS CEP file on SPI-Flash
SPRESENSE opened a new pull request, #7405: URL: https://github.com/apache/incubator-nuttx/pull/7405 ## Summary If you specify a file path on SPI-Flash in CONFIG_CXD56_GNSS_CEP_FILENAME, it causes a deadlock issue in the inter-CPU communication. To resolve it, introduce a new CONFIG_CXD56_GNSS_CEP_ON_SPIFLASH and then use pre-read buffers during checking CEP file. So this needs the large of free memory. ## Impact only spresense gnss ## Testing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] Donny9 opened a new pull request, #7404: romfs: expand file cache by CONFIG_FS_ROMFS_FCACHE_NSECTORS
Donny9 opened a new pull request, #7404: URL: https://github.com/apache/incubator-nuttx/pull/7404 ## Summary The default size of file cache is size of a sector, it may not be good size for optimizing read speed in physical device. So we can set the config according to speed test profile to optimize access IO speed. Signed-off-by: dongjiuzhu1 ## Impact improve read speed for romfs ## Testing Vela CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7401: arch/arm/stm32h7: multiple fixes for stm32h7 flash interface
xiaoxiang781216 commented on PR #7401: URL: https://github.com/apache/incubator-nuttx/pull/7401#issuecomment-1288336647 please rebase the change to fix the ci error. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7397: arch: stm32h7: Flush D-Cache on flash erase operation
xiaoxiang781216 commented on PR #7397: URL: https://github.com/apache/incubator-nuttx/pull/7397#issuecomment-1288336313 @tito97sp please rebase the change to the last mainline to fix the ci error. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] SPRESENSE opened a new pull request, #7403: lte: Include nuttx/fs/ioctl.h instead of wireless.h
SPRESENSE opened a new pull request, #7403: URL: https://github.com/apache/incubator-nuttx/pull/7403 ## Summary lte command definitions are separated from wireless ioctl. ## Impact No ## Testing spresense lte works well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] SPRESENSE opened a new pull request, #7402: drivers/modem/alt1250: Fix poll function
SPRESENSE opened a new pull request, #7402: URL: https://github.com/apache/incubator-nuttx/pull/7402 ## Summary Notify only when there are available events. ## Impact modem/alt1250 only ## Testing spresense lte works well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] ttnie commented on a diff in pull request #7383: CI: add example to sim
ttnie commented on code in PR #7383:
URL: https://github.com/apache/incubator-nuttx/pull/7383#discussion_r1002815874
##
tools/ci/testrun/script/test_example/test_example.py:
##
@@ -0,0 +1,44 @@
+#!/usr/bin/python3
+# encoding: utf-8
+import pytest
+
+pytestmark = [pytest.mark.common, pytest.mark.qemu]
+do_not_support = ["sabre-6quad", "rv-virt", "rv-virt64", "esp32c3-devkit",
"bl602evb"]
+
+
+def test_hello(p):
+ret = p.sendCommand("hello", "Hello, World!!")
+assert ret == 0
+
+
+def test_helloxx(p):
+if p.board in do_not_support:
+pytest.skip("unsupported at {}".format(p.board))
+if p.board == "best1600_ep":
+if p.core == "tee":
+pytest.skip("unsupported at {}-{}".format(p.board, p.core))
+ret = p.sendCommand("helloxx", "Hello, World!!")
Review Comment:
I got the result like below, looks like different with yours. Image build by
citest deconfig. @acassis
nsh> helloxx
helloxx_main: Saying hello from the dynamically constructed instance
CHelloWorld::HelloWorld: Hello, World!!
helloxx_main: Saying hello from the instance constructed on the stack
CHelloWorld::HelloWorld: Hello, World!!
helloxx_main: Saying hello from the statically constructed instance
CHelloWorld::HelloWorld: Hello, World!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[incubator-nuttx-website] branch asf-site updated: Publishing web: d696c67810809c3f81a4dd87b09d9e940db854b4 docs: 8c1036b7a1a7971fead89f070974fc8c60a6ad18
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new a03f468 Publishing web: d696c67810809c3f81a4dd87b09d9e940db854b4 docs: 8c1036b7a1a7971fead89f070974fc8c60a6ad18 a03f468 is described below commit a03f46896757f50f86f4bee49fc820dfd327583b Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> AuthorDate: Mon Oct 24 00:20:24 2022 + Publishing web: d696c67810809c3f81a4dd87b09d9e940db854b4 docs: 8c1036b7a1a7971fead89f070974fc8c60a6ad18 --- content/docs/10.0.0/index.html | 2 +- content/docs/10.0.1/index.html | 2 +- content/docs/10.1.0/index.html | 2 +- content/docs/10.2.0/index.html | 2 +- content/docs/10.3.0/index.html | 2 +- content/docs/11.0.0/index.html | 2 +- content/docs/latest/index.html | 2 +- content/docs/latest/searchindex.js | 2 +- content/feed.xml | 4 ++-- 9 files changed, 10 insertions(+), 10 deletions(-) diff --git a/content/docs/10.0.0/index.html b/content/docs/10.0.0/index.html index 5dd8716..148e97b 100644 --- a/content/docs/10.0.0/index.html +++ b/content/docs/10.0.0/index.html @@ -207,7 +207,7 @@ by following these NuttX Documentation¶ NuttX is a real-time operating system (RTOS) with an emphasis on standards compliance and small footprint. Scalable from 8-bit to 32-bit microcontroller environments, the primary governing standards in NuttX are Posix and ANSI standards. Additional standard APIs from Unix and other common RTOS’s (such as VxWorks) are adopted for functionality not available under these standards, or for functionality that is not appropriate for deeply-embedded environments (such as fork()). -Last Updated: 23 October 22 at 00:17 +Last Updated: 24 October 22 at 00:17 Table of Contents diff --git a/content/docs/10.0.1/index.html b/content/docs/10.0.1/index.html index 4c4d673..2f521f2 100644 --- a/content/docs/10.0.1/index.html +++ b/content/docs/10.0.1/index.html @@ -219,7 +219,7 @@ by following these NuttX Documentation¶ NuttX is a real-time operating system (RTOS) with an emphasis on standards compliance and small footprint. Scalable from 8-bit to 32-bit microcontroller environments, the primary governing standards in NuttX are Posix and ANSI standards. Additional standard APIs from Unix and other common RTOS’s (such as VxWorks) are adopted for functionality not available under these standards, or for functionality that is not appropriate for deeply-embedded environments (such as fork()). -Last Updated: 23 October 22 at 00:17 +Last Updated: 24 October 22 at 00:17 Table of Contents diff --git a/content/docs/10.1.0/index.html b/content/docs/10.1.0/index.html index b8eaf2f..d6049da 100644 --- a/content/docs/10.1.0/index.html +++ b/content/docs/10.1.0/index.html @@ -219,7 +219,7 @@ by following these NuttX Documentation¶ NuttX is a real-time operating system (RTOS) with an emphasis on standards compliance and small footprint. Scalable from 8-bit to 64-bit microcontroller environments, the primary governing standards in NuttX are POSIX and ANSI standards. Additional standard APIs from Unix and other common RTOS’s (such as VxWorks) are adopted for functionality not available under these standards, or for functionality that is not appropriate for deeply-embedded environments (such as fork()). -Last Updated: 23 October 22 at 00:17 +Last Updated: 24 October 22 at 00:17 Table of Contents diff --git a/content/docs/10.2.0/index.html b/content/docs/10.2.0/index.html index 4bd75de..2df4763 100644 --- a/content/docs/10.2.0/index.html +++ b/content/docs/10.2.0/index.html @@ -220,7 +220,7 @@ by following these NuttX Documentation¶ NuttX is a real-time operating system (RTOS) with an emphasis on standards compliance and small footprint. Scalable from 8-bit to 64-bit microcontroller environments, the primary governing standards in NuttX are POSIX and ANSI standards. Additional standard APIs from Unix and other common RTOS’s (such as VxWorks) are adopted for functionality not available under these standards, or for functionality that is not appropriate for deeply-embedded environments (such as fork()). -Last Updated: 23 October 22 at 00:18 +Last Updated: 24 October 22 at 00:17 Table of Contents diff --git a/content/docs/10.3.0/index.html b/content/docs/10.3.0/index.html index 4bd75de..95efe9a 100644 --- a/content/docs/10.3.0/index.html +++ b/content/docs/10.3.0/index.html @@ -220,7 +220,7 @@ by following these NuttX Documentation¶ NuttX is a real-time operating system (RTOS) with an emphasis on standards compliance and small footprint. Scalable from 8-bit to 64-bit microcontroller environments, the primary governing standards in NuttX are POSIX and ANSI standards. Additional standard APIs from Unix and other common RTOS’s (such
[incubator-nuttx] 02/02: tools/ci/docker/linux/Dockerfile: Keep the installation in alphabetical order
This is an automated email from the ASF dual-hosted git repository. btashton pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 8c1036b7a1a7971fead89f070974fc8c60a6ad18 Author: Xiang Xiao AuthorDate: Mon Oct 24 01:05:13 2022 +0800 tools/ci/docker/linux/Dockerfile: Keep the installation in alphabetical order Signed-off-by: Xiang Xiao --- tools/ci/docker/linux/Dockerfile | 193 +++ 1 file changed, 96 insertions(+), 97 deletions(-) diff --git a/tools/ci/docker/linux/Dockerfile b/tools/ci/docker/linux/Dockerfile index a3424ce284..be20984c7e 100644 --- a/tools/ci/docker/linux/Dockerfile +++ b/tools/ci/docker/linux/Dockerfile @@ -27,15 +27,15 @@ RUN apt-get update -qq && apt-get install -y -qq \ FROM builder-base AS nuttx-tools RUN apt-get update -qq && DEBIAN_FRONTEND="noninteractive" apt-get install -y -qq \ - flex \ bison \ - gperf \ - libncurses5-dev \ - make \ cmake \ + flex \ g++ \ gawk \ - git + git \ + gperf \ + libncurses5-dev \ + make RUN mkdir /tools WORKDIR /tools @@ -44,8 +44,10 @@ RUN mkdir -p /tools/nuttx-tools RUN curl -s -L https://bitbucket.org/nuttx/tools/get/9ad3e1ee75c7.tar.gz \ | tar -C nuttx-tools --strip-components=1 -xz -RUN cd nuttx-tools/kconfig-frontends \ - && ./configure --enable-mconf --disable-gconf --disable-qconf --enable-static --prefix=/tools/kconfig-frontends \ +RUN mkdir bloaty -p \ + && git clone --depth 1 --branch v1.1 https://github.com/google/bloaty bloaty \ + && cd bloaty \ + && cmake -DCMAKE_SYSTEM_PREFIX_PATH=/tools/bloaty \ && make install RUN cd nuttx-tools \ @@ -54,10 +56,8 @@ RUN cd nuttx-tools \ && cd genromfs \ && make install PREFIX=/tools/genromfs -RUN mkdir bloaty -p \ - && git clone --depth 1 --branch v1.1 https://github.com/google/bloaty bloaty \ - && cd bloaty \ - && cmake -DCMAKE_SYSTEM_PREFIX_PATH=/tools/bloaty \ +RUN cd nuttx-tools/kconfig-frontends \ + && ./configure --enable-mconf --disable-gconf --disable-qconf --enable-static --prefix=/tools/kconfig-frontends \ && make install # Install Rust and targets supported from NuttX @@ -83,6 +83,11 @@ WORKDIR /tools # Build image for tool required by ARM builds ### FROM nuttx-toolchain-base AS nuttx-toolchain-arm +# Download the latest ARM clang toolchain prebuilt by ARM +RUN mkdir clang-arm-none-eabi && \ + curl -s -L "https://github.com/ARM-software/LLVM-embedded-toolchain-for-Arm/releases/download/release-14.0.0/LLVMEmbeddedToolchainForArm-14.0.0-linux.tar.gz; \ + | tar -C clang-arm-none-eabi --strip-components 1 -xz + # Download the latest ARM GCC toolchain prebuilt by ARM RUN mkdir gcc-arm-none-eabi && \ curl -s -L "https://developer.arm.com/-/media/Files/downloads/gnu/11.3.rel1/binrel/arm-gnu-toolchain-11.3.rel1-x86_64-arm-none-eabi.tar.xz; \ @@ -90,11 +95,6 @@ RUN mkdir gcc-arm-none-eabi && \ && curl -s -L -O "https://raw.githubusercontent.com/apache/incubator-nuttx/master/tools/ci/patch/arm-none-eabi-workaround-for-newlib-version-break.patch; \ && patch -p0 < arm-none-eabi-workaround-for-newlib-version-break.patch -# Download the latest ARM clang toolchain prebuilt by ARM -RUN mkdir clang-arm-none-eabi && \ - curl -s -L "https://github.com/ARM-software/LLVM-embedded-toolchain-for-Arm/releases/download/release-14.0.0/LLVMEmbeddedToolchainForArm-14.0.0-linux.tar.gz; \ - | tar -C clang-arm-none-eabi --strip-components 1 -xz - ### # Build image for tool required by ARM64 builds ### @@ -114,66 +114,20 @@ RUN mkdir pinguino-compilers && \ curl -s -L "https://github.com/PinguinoIDE/pinguino-compilers/archive/62db5158d7f6d41c6fadb05de81cc31dd81a1958.tar.gz; \ | tar -C pinguino-compilers --strip-components=2 --wildcards -xz */linux64 -### -# Build image for tool required by RISCV builds -### -FROM nuttx-toolchain-base AS nuttx-toolchain-riscv -# Download the latest RISCV GCC toolchain prebuilt by SiFive -RUN mkdir riscv64-unknown-elf-gcc && \ - curl -s -L "https://static.dev.sifive.com/dev-tools/riscv64-unknown-elf-gcc-8.3.0-2019.08.0-x86_64-linux-ubuntu14.tar.gz; \ - | tar -C riscv64-unknown-elf-gcc --strip-components 1 -xz - -### -# Build image for tool required by SPARC builds -### -FROM nuttx-toolchain-base AS nuttx-toolchain-sparc -# Download the SPARC GCC toolchain prebuilt by Gaisler -RUN mkdir sparc-gaisler-elf-gcc && \ - curl -s -L
[incubator-nuttx] branch master updated (4aad964d48 -> 8c1036b7a1)
This is an automated email from the ASF dual-hosted git repository. btashton pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from 4aad964d48 Fix sam4s_nand.c:152:3: error: this 'while' clause does not guard... [-Werror=misleading-indentation] new d922119f0a tools/ci/docker/linux/Dockerfile: Intall libtinfo5 in final image new 8c1036b7a1 tools/ci/docker/linux/Dockerfile: Keep the installation in alphabetical order The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: tools/ci/docker/linux/Dockerfile | 194 +++ 1 file changed, 97 insertions(+), 97 deletions(-)
[incubator-nuttx] 01/02: tools/ci/docker/linux/Dockerfile: Intall libtinfo5 in final image
This is an automated email from the ASF dual-hosted git repository. btashton pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit d922119f0acc69debd775379ee2a73d97032b8dc Author: Xiang Xiao AuthorDate: Mon Oct 24 00:44:20 2022 +0800 tools/ci/docker/linux/Dockerfile: Intall libtinfo5 in final image fix the following error: /tools/clang-arm-none-eabi/bin/clang: error while loading shared libraries: libtinfo.so.5: cannot open shared object file: No such file or directory Signed-off-by: Xiang Xiao --- tools/ci/docker/linux/Dockerfile | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/ci/docker/linux/Dockerfile b/tools/ci/docker/linux/Dockerfile index 8bceff7013..a3424ce284 100644 --- a/tools/ci/docker/linux/Dockerfile +++ b/tools/ci/docker/linux/Dockerfile @@ -248,6 +248,7 @@ RUN apt-get update -qq && DEBIAN_FRONTEND="noninteractive" apt-get install -y -q libpulse-dev libpulse-dev:i386 \ libpython2.7 \ libncurses5-dev \ + libtinfo5 \ libx11-dev libx11-dev:i386 \ libxext-dev libxext-dev:i386 \ linux-libc-dev:i386 \
[GitHub] [incubator-nuttx] btashton merged pull request #7399: tools/ci/docker/linux/Dockerfile: Intall libtinfo5 in final image
btashton merged PR #7399: URL: https://github.com/apache/incubator-nuttx/pull/7399 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] tito97sp commented on a diff in pull request #7400: board/stm32h7: Fix CONFIG_LIB_BOARDCTL build cap in stm32_boot.c
tito97sp commented on code in PR #7400:
URL: https://github.com/apache/incubator-nuttx/pull/7400#discussion_r1002779246
##
boards/arm/stm32h7/nucleo-h743zi/src/stm32_boot.c:
##
@@ -86,7 +86,7 @@ void stm32_boardinitialize(void)
#ifdef CONFIG_BOARD_LATE_INITIALIZE
void board_late_initialize(void)
{
-#if defined(CONFIG_NSH_LIBRARY) && !defined(CONFIG_BOARDCTL)
+#if defined(CONFIG_NSH_LIBRARY) && !defined(CONFIG_LIB_BOARDCTL)
Review Comment:
Sorry an error was made by me and the PR is gonna be closed.
The `stm32_bringup()` function is better to be called from app so this PR
approach is erroneous.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-nuttx] tito97sp closed pull request #7400: board/stm32h7: Fix CONFIG_LIB_BOARDCTL build cap in stm32_boot.c
tito97sp closed pull request #7400: board/stm32h7: Fix CONFIG_LIB_BOARDCTL build cap in stm32_boot.c URL: https://github.com/apache/incubator-nuttx/pull/7400 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] tito97sp commented on a diff in pull request #7400: board/stm32h7: Fix CONFIG_LIB_BOARDCTL build cap in stm32_boot.c
tito97sp commented on code in PR #7400:
URL: https://github.com/apache/incubator-nuttx/pull/7400#discussion_r1002779246
##
boards/arm/stm32h7/nucleo-h743zi/src/stm32_boot.c:
##
@@ -86,7 +86,7 @@ void stm32_boardinitialize(void)
#ifdef CONFIG_BOARD_LATE_INITIALIZE
void board_late_initialize(void)
{
-#if defined(CONFIG_NSH_LIBRARY) && !defined(CONFIG_BOARDCTL)
+#if defined(CONFIG_NSH_LIBRARY) && !defined(CONFIG_LIB_BOARDCTL)
Review Comment:
Sorry an error was made by me and the PR is gonna be closed.
The `stm32_bringup()` function is better to be call from app so this PR
approach is erroneous.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7400: board/stm32h7: Fix CONFIG_LIB_BOARDCTL build cap in stm32_boot.c
pkarashchenko commented on code in PR #7400:
URL: https://github.com/apache/incubator-nuttx/pull/7400#discussion_r1002773918
##
boards/arm/stm32h7/nucleo-h743zi/src/stm32_boot.c:
##
@@ -86,7 +86,7 @@ void stm32_boardinitialize(void)
#ifdef CONFIG_BOARD_LATE_INITIALIZE
void board_late_initialize(void)
{
-#if defined(CONFIG_NSH_LIBRARY) && !defined(CONFIG_BOARDCTL)
+#if defined(CONFIG_NSH_LIBRARY) && !defined(CONFIG_LIB_BOARDCTL)
Review Comment:
What configuration are you using? Maybe you can post a defconfig file, so it
will be more easy to track down the root cause
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-nuttx] tito97sp commented on a diff in pull request #7400: board/stm32h7: Fix CONFIG_LIB_BOARDCTL build cap in stm32_boot.c
tito97sp commented on code in PR #7400:
URL: https://github.com/apache/incubator-nuttx/pull/7400#discussion_r1002773648
##
boards/arm/stm32h7/nucleo-h743zi/src/stm32_boot.c:
##
@@ -86,7 +86,7 @@ void stm32_boardinitialize(void)
#ifdef CONFIG_BOARD_LATE_INITIALIZE
void board_late_initialize(void)
{
-#if defined(CONFIG_NSH_LIBRARY) && !defined(CONFIG_BOARDCTL)
+#if defined(CONFIG_NSH_LIBRARY) && !defined(CONFIG_LIB_BOARDCTL)
Review Comment:
Regarding the implementation of the `board_late_initialize()` I have found
that there exist several implementations of the same function as resumed in the
next diagram:
Where the different color paths are taken depending on the build caps used
of the same color. (Black color indicates that no build caps check are done in
some implementations)
Maybe an effort should be done here in homogenizing this as it is really
difficult to understand the proper way to initialize the board.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7400: board/stm32h7: Fix CONFIG_LIB_BOARDCTL build cap in stm32_boot.c
pkarashchenko commented on code in PR #7400:
URL: https://github.com/apache/incubator-nuttx/pull/7400#discussion_r1002773744
##
boards/arm/stm32h7/nucleo-h743zi/src/stm32_boot.c:
##
@@ -86,7 +86,7 @@ void stm32_boardinitialize(void)
#ifdef CONFIG_BOARD_LATE_INITIALIZE
void board_late_initialize(void)
{
-#if defined(CONFIG_NSH_LIBRARY) && !defined(CONFIG_BOARDCTL)
+#if defined(CONFIG_NSH_LIBRARY) && !defined(CONFIG_LIB_BOARDCTL)
Review Comment:
I will try to take a look here this week
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-nuttx] tito97sp commented on a diff in pull request #7400: board/stm32h7: Fix CONFIG_LIB_BOARDCTL build cap in stm32_boot.c
tito97sp commented on code in PR #7400:
URL: https://github.com/apache/incubator-nuttx/pull/7400#discussion_r1002773648
##
boards/arm/stm32h7/nucleo-h743zi/src/stm32_boot.c:
##
@@ -86,7 +86,7 @@ void stm32_boardinitialize(void)
#ifdef CONFIG_BOARD_LATE_INITIALIZE
void board_late_initialize(void)
{
-#if defined(CONFIG_NSH_LIBRARY) && !defined(CONFIG_BOARDCTL)
+#if defined(CONFIG_NSH_LIBRARY) && !defined(CONFIG_LIB_BOARDCTL)
Review Comment:
Regarding the implementation of the `board_late_initialize()` I have found
that there exist several implementations of the same function as resumed in the
next diagram:
Where the different color paths are taken depending on the build caps used.
Maybe an effort should be done here in homogenizing this as it is really
difficult to understand the proper way to initialize the board.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-nuttx] tito97sp commented on a diff in pull request #7400: board/stm32h7: Fix CONFIG_LIB_BOARDCTL build cap in stm32_boot.c
tito97sp commented on code in PR #7400:
URL: https://github.com/apache/incubator-nuttx/pull/7400#discussion_r1002773648
##
boards/arm/stm32h7/nucleo-h743zi/src/stm32_boot.c:
##
@@ -86,7 +86,7 @@ void stm32_boardinitialize(void)
#ifdef CONFIG_BOARD_LATE_INITIALIZE
void board_late_initialize(void)
{
-#if defined(CONFIG_NSH_LIBRARY) && !defined(CONFIG_BOARDCTL)
+#if defined(CONFIG_NSH_LIBRARY) && !defined(CONFIG_LIB_BOARDCTL)
Review Comment:
Regarding the implementation of the board_late_initialize I have find that
there exist several implementations of the same as resumed in the next diagram:
Where the different color paths are taken depending on the build caps used.
Maybe an effort should be done here in homogenizing this as it is really
difficult to understand the proper way to initialize the board.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-nuttx-apps] fjpanag commented on a diff in pull request #1382: Fixed compiler warnings.
fjpanag commented on code in PR #1382: URL: https://github.com/apache/incubator-nuttx-apps/pull/1382#discussion_r1002769220 ## netutils/webclient/webclient.c: ## @@ -797,6 +798,7 @@ static inline int wget_parsechunkheader(struct webclient_context *ctx, int offset; int ndx; int ret = OK; + UNUSED(ctx); Review Comment: done ## netutils/webclient/webclient.c: ## @@ -907,6 +909,7 @@ static inline int wget_parsechunkenddata(struct webclient_context *ctx, int offset; int ndx; int ret = OK; + UNUSED(ctx); Review Comment: done ## netutils/webclient/webclient.c: ## @@ -965,6 +968,7 @@ static inline int wget_parsechunktrailer(struct webclient_context *ctx, int offset; int ndx; int ret = OK; + UNUSED(ctx); Review Comment: done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #7398: Fix error: mmcsd/mmcsd_sdio.c:2669:35: error: 'buffer' may be used uninitialized [-Werror=maybe-uninitialized]
pkarashchenko commented on PR #7398: URL: https://github.com/apache/incubator-nuttx/pull/7398#issuecomment-1288197425 @xiaoxiang781216 seems like the new toolchain has an issue with `gcov`: ``` rm-none-eabi-ld: /github/workspace/sources/nuttx/staging/libarch.a(rp2040_start.o): in function `__start': /github/workspace/sources/nuttx/arch/arm/src/chip/rp2040_start.c:83: undefined reference to `__gcov_indirect_call_profiler_v4' arm-none-eabi-ld: /github/workspace/sources/nuttx/arch/arm/src/chip/rp2040_start.c:139: undefined reference to `__gcov_indirect_call' arm-none-eabi-ld: /github/workspace/sources/nuttx/arch/arm/src/chip/rp2040_start.c:139: undefined reference to `__gcov_time_profiler_counter' arm-none-eabi-ld: /github/workspace/sources/nuttx/staging/libarch.a(rp2040_clock.o): in function `rp2040_clock_configure': /github/workspace/sources/nuttx/arch/arm/src/chip/rp2040_clock.c:87: undefined reference to `__gcov_indirect_call_profiler_v4' arm-none-eabi-ld: /github/workspace/sources/nuttx/arch/arm/src/chip/rp2040_clock.c:101: undefined reference to `__gcov_topn_values_profiler' arm-none-eabi-ld: /github/workspace/sources/nuttx/arch/arm/src/chip/rp2040_clock.c:144: undefined reference to `__gcov_topn_values_profiler' arm-none-eabi-ld: /github/workspace/sources/nuttx/arch/arm/src/chip/rp2040_clock.c:147: undefined reference to `__gcov_indirect_call' arm-none-eabi-ld: /github/workspace/sources/nuttx/arch/arm/src/chip/rp2040_clock.c:147: undefined reference to `__gcov_time_profiler_counter' ... ``` Please investigate. Most probably `EXTRA_LIBS += $(wildcard $(shell $(CC) $(ARCHCPUFLAGS) --print-file-name=libgcov.a))` is not evaluated properly. Anyway I'm merging this RP because `gcov` issue seems to be the last step to restore CI on mainline -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx] branch master updated (ee82f7b5ca -> 4aad964d48)
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from ee82f7b5ca Fix error: proxies/PROXY_socketpair.c:9:55: error: argument 4 of type 'int *' declared as a pointer [-Werror=array-parameter=] add 57b6447e0a Fix error: mmcsd/mmcsd_sdio.c:2669:35: error: 'buffer' may be used uninitialized [-Werror=maybe-uninitialized] add 00d78a51e4 Fix usbhost/usbhost_hub.c:1339:3: error: 'free' called on pointer 'alloc' with nonzero offset 12 [-Werror=free-nonheap-object] add 4aad964d48 Fix sam4s_nand.c:152:3: error: this 'while' clause does not guard... [-Werror=misleading-indentation] No new revisions were added by this update. Summary of changes: arch/arm/src/sam34/sam4s_nand.c | 5 - drivers/mmcsd/mmcsd_sdio.c | 2 ++ drivers/usbhost/usbhost_hub.c | 2 +- 3 files changed, 7 insertions(+), 2 deletions(-)
[GitHub] [incubator-nuttx] pkarashchenko merged pull request #7398: Fix error: mmcsd/mmcsd_sdio.c:2669:35: error: 'buffer' may be used uninitialized [-Werror=maybe-uninitialized]
pkarashchenko merged PR #7398: URL: https://github.com/apache/incubator-nuttx/pull/7398 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7397: arch: stm32h7: Flush D-Cache on flash erase operation
pkarashchenko commented on code in PR #7397: URL: https://github.com/apache/incubator-nuttx/pull/7397#discussion_r1002768208 ## arch/arm/src/stm32h7/stm32h743xx_flash.c: ## @@ -769,6 +769,12 @@ ssize_t up_progmem_eraseblock(size_t block) return (ssize_t)ret; } + /* Flush and invalidate D-Cache for this block */ + +#ifdef CONFIG_ARMV7M_DCACHE + up_flush_dcache(block_address, block_address + FLASH_SECTOR_SIZE); Review Comment: Please try https://github.com/apache/incubator-nuttx/pull/7401 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko opened a new pull request, #7401: arch/arm/stm32h7: multiple fixes for stm32h7 flash interface
pkarashchenko opened a new pull request, #7401: URL: https://github.com/apache/incubator-nuttx/pull/7401 ## Summary This PR contain few fixes for stm32h7 flash interface: - Fix cache invalidation before reading flash data after flash erase operation - Fix `stm32h7_israngeerased` operation to use the correct address - Fix error checking in `stm32h7_israngeerased` - Replace exclusive semaphore with mutex - Fix few style issues ## Impact Bug fix ## Testing Pass CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] tito97sp commented on a diff in pull request #7400: board/stm32h7: Fix CONFIG_LIB_BOARDCTL build cap in stm32_boot.c
tito97sp commented on code in PR #7400:
URL: https://github.com/apache/incubator-nuttx/pull/7400#discussion_r1002766985
##
boards/arm/stm32h7/nucleo-h743zi/src/stm32_boot.c:
##
@@ -86,7 +86,7 @@ void stm32_boardinitialize(void)
#ifdef CONFIG_BOARD_LATE_INITIALIZE
void board_late_initialize(void)
{
-#if defined(CONFIG_NSH_LIBRARY) && !defined(CONFIG_BOARDCTL)
+#if defined(CONFIG_NSH_LIBRARY) && !defined(CONFIG_LIB_BOARDCTL)
Review Comment:
Hi @pkarashchenko, what do you propose in this case?
I see that there exists other boards does not check neither
`CONFIG_NSH_LIBRARY` nor `CONFIG_BOARDCTL` for intializing the board and other
that checks both.
* nuttx/boards/arm/samv7/samv71-xult/src/sam_boot.c
* nuttx/boards/arm/stm32/nucleo-f303ze/src/stm32_boot.c
In my case I have defined `CONFIG_NSH_LIBRARY` and also `CONFIG_BOARDCTL` so
the `stm32_bringup()` function is never reachable.
Why `CONFIG_BOARDCTL` must not be defined in order to perform a
board_late_initialization?
I am confused about the difference between `CONFIG_BOARDCTL` and
`CONFIG_LIB_BOARDCTL`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a diff in pull request #1382: Fixed compiler warnings.
pkarashchenko commented on code in PR #1382: URL: https://github.com/apache/incubator-nuttx-apps/pull/1382#discussion_r1002764169 ## netutils/webclient/webclient.c: ## @@ -965,6 +968,7 @@ static inline int wget_parsechunktrailer(struct webclient_context *ctx, int offset; int ndx; int ret = OK; + UNUSED(ctx); Review Comment: ```suggestion UNUSED(ctx); ``` ## netutils/webclient/webclient.c: ## @@ -907,6 +909,7 @@ static inline int wget_parsechunkenddata(struct webclient_context *ctx, int offset; int ndx; int ret = OK; + UNUSED(ctx); Review Comment: ```suggestion UNUSED(ctx); ``` ## netutils/webclient/webclient.c: ## @@ -797,6 +798,7 @@ static inline int wget_parsechunkheader(struct webclient_context *ctx, int offset; int ndx; int ret = OK; + UNUSED(ctx); Review Comment: ```suggestion UNUSED(ctx); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7400: board/stm32h7: Fix CONFIG_LIB_BOARDCTL build cap in stm32_boot.c
pkarashchenko commented on code in PR #7400:
URL: https://github.com/apache/incubator-nuttx/pull/7400#discussion_r1002763737
##
boards/arm/stm32h7/nucleo-h743zi/src/stm32_boot.c:
##
@@ -86,7 +86,7 @@ void stm32_boardinitialize(void)
#ifdef CONFIG_BOARD_LATE_INITIALIZE
void board_late_initialize(void)
{
-#if defined(CONFIG_NSH_LIBRARY) && !defined(CONFIG_BOARDCTL)
+#if defined(CONFIG_NSH_LIBRARY) && !defined(CONFIG_LIB_BOARDCTL)
Review Comment:
seems like `LIB_BOARDCTL` is leftover from renaming. Probably we need to
clean-up all the places and do not introduce new dependencies
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-nuttx] tito97sp commented on a diff in pull request #7397: arch: stm32h7: Flush D-Cache on flash erase operation
tito97sp commented on code in PR #7397: URL: https://github.com/apache/incubator-nuttx/pull/7397#discussion_r1002762069 ## arch/arm/src/stm32h7/stm32h743xx_flash.c: ## @@ -769,6 +769,12 @@ ssize_t up_progmem_eraseblock(size_t block) return (ssize_t)ret; } + /* Flush and invalidate D-Cache for this block */ + +#ifdef CONFIG_ARMV7M_DCACHE + up_flush_dcache(block_address, block_address + FLASH_SECTOR_SIZE); Review Comment: Yes please. Submit the changes and I test them in my setup. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7397: arch: stm32h7: Flush D-Cache on flash erase operation
pkarashchenko commented on code in PR #7397: URL: https://github.com/apache/incubator-nuttx/pull/7397#discussion_r1002761824 ## arch/arm/src/stm32h7/stm32h743xx_flash.c: ## @@ -769,6 +769,12 @@ ssize_t up_progmem_eraseblock(size_t block) return (ssize_t)ret; } + /* Flush and invalidate D-Cache for this block */ + +#ifdef CONFIG_ARMV7M_DCACHE + up_flush_dcache(block_address, block_address + FLASH_SECTOR_SIZE); Review Comment: The https://github.com/apache/incubator-nuttx/blob/ee82f7b5ca56a7f392843398e45f25773f8435d9/arch/arm/src/stm32h7/stm32h7b3xx_flash.c#L768 already contain similar fix, but there is an error in that line :) I've looked in stm32h743753 reference manual (the "Embedded Flash memory" section) and see that flash read access is done via AXI interface over 256 bit read data buffers, so flash memory interface is "peripheral" in this case and erase command makes it to change the state on the flash. The CPU read of 256 bit read data buffers goes via cache (in other words data accessed from CPU on those flash addresses can be cached), so we need to invalidate the CPU data cache before next read access to those addresses after flash erase is done. In case of `stm32h7b3xx_flash.c` even if `up_invalidate_dcache()` is called before flash erase due to flash read access is protected by a semaphore the next flash read access is done in `stm32h7_israngeerased()`. I think that the best place for `up_invalidate_dcache()` is after `ret = 0;` line in both `stm32h743xx` and `stm32h7b3xx`. If you want I can submit the change for both cases and you can verify it with your setup -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] tito97sp opened a new pull request, #7400: board/stm32h7: Fix CONFIG_LIB_BOARDCTL build cap in stm32_boot.c
tito97sp opened a new pull request, #7400: URL: https://github.com/apache/incubator-nuttx/pull/7400 Signed-off-by: Andrés Sánchez Pascual ## Summary `stm32_bringup()` not reachable. Fix CONFIG_LIB_BOARDCTL build cap in `board_late_initialize()` function ## Impact Board STM32H743ZI ## Testing Tested on target. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7398: Fix error: mmcsd/mmcsd_sdio.c:2669:35: error: 'buffer' may be used uninitialized [-Werror=maybe-uninitialized]
xiaoxiang781216 commented on code in PR #7398:
URL: https://github.com/apache/incubator-nuttx/pull/7398#discussion_r1002751126
##
arch/arm/src/sam34/sam4s_nand.c:
##
@@ -149,7 +149,11 @@ static int nand_wait_ready(struct sam_nandcs_s *priv)
/* The ready/busy (R/nB) signal of the NAND Flash */
- while (!sam_gpioread(priv->rb));
+ while (!sam_gpioread(priv->rb))
+{
+ ;
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7398: Fix error: mmcsd/mmcsd_sdio.c:2669:35: error: 'buffer' may be used uninitialized [-Werror=maybe-uninitialized]
pkarashchenko commented on code in PR #7398:
URL: https://github.com/apache/incubator-nuttx/pull/7398#discussion_r1002749169
##
arch/arm/src/sam34/sam4s_nand.c:
##
@@ -149,7 +149,11 @@ static int nand_wait_ready(struct sam_nandcs_s *priv)
/* The ready/busy (R/nB) signal of the NAND Flash */
- while (!sam_gpioread(priv->rb));
+ while (!sam_gpioread(priv->rb))
+{
+ ;
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-nuttx] tito97sp commented on a diff in pull request #7397: arch: stm32h7: Flush D-Cache on flash erase operation
tito97sp commented on code in PR #7397: URL: https://github.com/apache/incubator-nuttx/pull/7397#discussion_r1002748381 ## arch/arm/src/stm32h7/stm32h743xx_flash.c: ## @@ -769,6 +769,12 @@ ssize_t up_progmem_eraseblock(size_t block) return (ssize_t)ret; } + /* Flush and invalidate D-Cache for this block */ + +#ifdef CONFIG_ARMV7M_DCACHE + up_flush_dcache(block_address, block_address + FLASH_SECTOR_SIZE); Review Comment: Thanks for the comment @pkarashchenko . I agree completely. I am a confused about who is the component (CPU or Flash Peripheral) that uses the Cache. My original idea about the workflow was the following: 1. The CPU performs a write operation into flash. 2. Cache memory gets the new data and "retains" it. 3. CPU performs a sector erase directly through the Flash Memory peripheral registers (Flash peripheral). 4. Flash sector is erased. 5. Cache data is flushed with delay (Synchronization failure). 6. CPU reads Flash memory to check that is correctly erased. -> It finds non erased data. -> reports a failure. But I agree that the process could be the following: 1. CPU performs a sector erase directly through the Flash Memory peripheral registers (Flash peripheral). 2. Flash sector erased operation is managed though the Cache that "retains" the new data (erased data). 3. CPU reads Flash memory to check that is correctly erased. -> It finds non erased data. -> reports a failure. 4. Cache data is flushed with delay (Synchronization failure). I discard the second one as I do not see that the erase operation in flash memory could involve directly the cache. I think the second one is the approach you were talking about in your previous comment, am I right?? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] tito97sp commented on a diff in pull request #7397: arch: stm32h7: Flush D-Cache on flash erase operation
tito97sp commented on code in PR #7397: URL: https://github.com/apache/incubator-nuttx/pull/7397#discussion_r1002748381 ## arch/arm/src/stm32h7/stm32h743xx_flash.c: ## @@ -769,6 +769,12 @@ ssize_t up_progmem_eraseblock(size_t block) return (ssize_t)ret; } + /* Flush and invalidate D-Cache for this block */ + +#ifdef CONFIG_ARMV7M_DCACHE + up_flush_dcache(block_address, block_address + FLASH_SECTOR_SIZE); Review Comment: Thanks for the comment @pkarashchenko . I agree completely. I am a confused about who is the component (CPU or Flash Peripheral) that uses the Cache. In my first idea was something like this: 1. The CPU performs a write operation into flash. 2. Cache memory gets the new data and "retains" it. 3. CPU performs a sector erase directly through the Flash Memory peripheral registers (Flash peripheral). 4. Flash sector is erased. 5. Cache data is flushed with delay (Synchronization failure). 6. CPU reads Flash memory to check that is correctly erased. -> It finds non erased data. -> reports a failure. But I agree that the process could be the following: 1. CPU performs a sector erase directly through the Flash Memory peripheral registers (Flash peripheral). 2. Flash sector erased operation is managed though the Cache that "retains" the new data (erased data). 3. CPU reads Flash memory to check that is correctly erased. -> It finds non erased data. -> reports a failure. 4. Cache data is flushed with delay (Synchronization failure). I discard the second one as I do not see that the erase operation in flash memory could involve directly the cache. I think the second one is the approach you were talking about in your previous comment, am I right?? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] tito97sp commented on pull request #7397: arch: stm32h7: Flush D-Cache on flash erase operation
tito97sp commented on PR #7397: URL: https://github.com/apache/incubator-nuttx/pull/7397#issuecomment-1288164142 PR blocked by https://github.com/apache/incubator-nuttx/pull/7398 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7391: tools/ci/testlist: Switch half build to clang
xiaoxiang781216 commented on PR #7391: URL: https://github.com/apache/incubator-nuttx/pull/7391#issuecomment-1288157867 depend on https://github.com/apache/incubator-nuttx/pull/7399 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx-apps] branch master updated: industry/foc/foc_ident: make the Ki resistance measurement parameter configurable
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git
The following commit(s) were added to refs/heads/master by this push:
new 8d61a10a7 industry/foc/foc_ident: make the Ki resistance measurement
parameter configurable
8d61a10a7 is described below
commit 8d61a10a74574952d3fced8594423724313c80e7
Author: raiden00pl
AuthorDate: Thu Aug 18 11:38:32 2022 +0200
industry/foc/foc_ident: make the Ki resistance measurement parameter
configurable
The hardcoded parameter may not be suitable for various types of motors
---
examples/foc/Kconfig | 4
examples/foc/foc_cfg.h | 3 +++
examples/foc/foc_motor_b16.c | 2 ++
examples/foc/foc_motor_f32.c | 1 +
include/industry/foc/fixed16/foc_ident.h | 1 +
include/industry/foc/float/foc_ident.h | 1 +
industry/foc/fixed16/foc_ident.c | 10 --
industry/foc/float/foc_ident.c | 10 --
8 files changed, 28 insertions(+), 4 deletions(-)
diff --git a/examples/foc/Kconfig b/examples/foc/Kconfig
index c3a1066c1..ade011557 100644
--- a/examples/foc/Kconfig
+++ b/examples/foc/Kconfig
@@ -386,6 +386,10 @@ config EXAMPLES_FOC_IDENT_RES_CURRENT
int "FOC motor ident resistance current (x1000)"
default 0
+config EXAMPLES_FOC_IDENT_RES_KI
+ int "FOC motor ident resistance Ki (x1000)"
+ default 50
+
config EXAMPLES_FOC_IDENT_IND_VOLTAGE
int "FOC motor ident inductance voltage (x1000)"
default 0
diff --git a/examples/foc/foc_cfg.h b/examples/foc/foc_cfg.h
index 155b44379..4874aed58 100644
--- a/examples/foc/foc_cfg.h
+++ b/examples/foc/foc_cfg.h
@@ -88,6 +88,9 @@
# if (CONFIG_EXAMPLES_FOC_IDENT_RES_CURRENT == 0)
#error
# endif
+# if (CONFIG_EXAMPLES_FOC_IDENT_RES_KI == 0)
+#error
+# endif
# if (CONFIG_EXAMPLES_FOC_IDENT_IND_VOLTAGE == 0)
#error
# endif
diff --git a/examples/foc/foc_motor_b16.c b/examples/foc/foc_motor_b16.c
index a3996f6d1..8a4083a0f 100644
--- a/examples/foc/foc_motor_b16.c
+++ b/examples/foc/foc_motor_b16.c
@@ -989,6 +989,8 @@ int foc_motor_init(FAR struct foc_motor_b16_s *motor,
ident_cfg.per = motor->per;
ident_cfg.res_current = ftob16(CONFIG_EXAMPLES_FOC_IDENT_RES_CURRENT /
1000.0f);
+ ident_cfg.res_ki = ftob16(CONFIG_EXAMPLES_FOC_IDENT_RES_KI /
+ 1000.0f);
ident_cfg.ind_volt= ftob16(CONFIG_EXAMPLES_FOC_IDENT_IND_VOLTAGE /
1000.0f);
ident_cfg.res_steps = (CONFIG_EXAMPLES_FOC_NOTIFIER_FREQ *
diff --git a/examples/foc/foc_motor_f32.c b/examples/foc/foc_motor_f32.c
index 6c9b54374..c123881cf 100644
--- a/examples/foc/foc_motor_f32.c
+++ b/examples/foc/foc_motor_f32.c
@@ -972,6 +972,7 @@ int foc_motor_init(FAR struct foc_motor_f32_s *motor,
ident_cfg.per = motor->per;
ident_cfg.res_current = (CONFIG_EXAMPLES_FOC_IDENT_RES_CURRENT / 1000.0f);
+ ident_cfg.res_ki = (CONFIG_EXAMPLES_FOC_IDENT_RES_KI / 1000.0f);
ident_cfg.ind_volt= (CONFIG_EXAMPLES_FOC_IDENT_IND_VOLTAGE / 1000.0f);
ident_cfg.res_steps = (CONFIG_EXAMPLES_FOC_NOTIFIER_FREQ * \
CONFIG_EXAMPLES_FOC_IDENT_RES_SEC / 1000);
diff --git a/include/industry/foc/fixed16/foc_ident.h
b/include/industry/foc/fixed16/foc_ident.h
index 276fa631e..d7360e19b 100644
--- a/include/industry/foc/fixed16/foc_ident.h
+++ b/include/industry/foc/fixed16/foc_ident.h
@@ -41,6 +41,7 @@ struct foc_routine_ident_cfg_b16_s
{
b16_t per;/* Routine period in sec */
b16_t res_current;/* Resistance measurement current */
+ b16_t res_ki; /* Resistance measurement Ki */
b16_t ind_volt; /* Inductance measurement current */
int res_steps; /* Resistance measurement steps */
int ind_steps; /* Inductance measurement steps */
diff --git a/include/industry/foc/float/foc_ident.h
b/include/industry/foc/float/foc_ident.h
index a2d392ba9..66da973a4 100644
--- a/include/industry/foc/float/foc_ident.h
+++ b/include/industry/foc/float/foc_ident.h
@@ -83,6 +83,7 @@ struct foc_routine_ident_cfg_f32_s
#endif
float per;/* Routine period in sec */
float res_current;/* Resistance measurement current */
+ float res_ki; /* Resistance measurement Ki */
float ind_volt; /* Inductance measurement voltage */
int res_steps; /* Resistance measurement steps */
int ind_steps; /* Inductance measurement steps */
diff --git a/industry/foc/fixed16/foc_ident.c b/industry/foc/fixed16/foc_ident.c
index 65dab3535..be9d4eaef 100644
--- a/industry/foc/fixed16/foc_ident.c
+++ b/industry/foc/fixed16/foc_ident.c
@@ -39,7 +39,6 @@
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #1375: foc_ident: make the Ki resistance measurement parameter configurable
xiaoxiang781216 merged PR #1375: URL: https://github.com/apache/incubator-nuttx-apps/pull/1375 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #1375: foc_ident: make the Ki resistance measurement parameter configurable
xiaoxiang781216 commented on PR #1375: URL: https://github.com/apache/incubator-nuttx-apps/pull/1375#issuecomment-1288157528 let's ignore the ci broken and merge this simple change directly -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx-apps] 06/07: Revert "Revert "examples/foc: fix description in Kconfig""
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git commit 0fe45a4c7320207da0d578197ae139518e367149 Author: Petro Karashchenko AuthorDate: Sun Oct 23 12:08:16 2022 +0200 Revert "Revert "examples/foc: fix description in Kconfig"" This reverts commit 1a18703a42784b38c9b8de170399536713eb9daa. --- examples/foc/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/foc/Kconfig b/examples/foc/Kconfig index 2b193df9b..c3a1066c1 100644 --- a/examples/foc/Kconfig +++ b/examples/foc/Kconfig @@ -128,7 +128,7 @@ config EXAMPLES_FOC_QENCO_DEVPATH default "/dev/qe" ---help--- The default path to the qenco device without the device minor number. - Default: /dev/qenco + Default: /dev/qe endif # EXAMPLES_FOC_HAVE_QENCO
[incubator-nuttx-apps] 04/07: Revert "Revert "nshlib: fix possible out of bounds array access""
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git commit ec1c5f92739e8ec15751cfb04be11c057a96e594 Author: Petro Karashchenko AuthorDate: Sun Oct 23 12:07:54 2022 +0200 Revert "Revert "nshlib: fix possible out of bounds array access"" This reverts commit fe4b44e3ff27220b4f1abf5d46cdc29dc1afa64d. --- nshlib/nsh_fsutils.c | 1 - 1 file changed, 1 deletion(-) diff --git a/nshlib/nsh_fsutils.c b/nshlib/nsh_fsutils.c index 2f88549c5..c9b50710c 100644 --- a/nshlib/nsh_fsutils.c +++ b/nshlib/nsh_fsutils.c @@ -513,7 +513,6 @@ FAR char *nsh_getdirpath(FAR struct nsh_vtbl_s *vtbl, snprintf(vtbl->iobuffer, IOBUFFERSIZE, "%s/%s", dirpath, path); } - vtbl->iobuffer[PATH_MAX] = '\0'; return strdup(vtbl->iobuffer); } #endif
[incubator-nuttx-apps] 05/07: Revert "Revert "examples/timer_gpio: fix initialization of timer notification""
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git commit 9368b659a763faa4e45b657ea71922b651751aa5 Author: Petro Karashchenko AuthorDate: Sun Oct 23 12:08:03 2022 +0200 Revert "Revert "examples/timer_gpio: fix initialization of timer notification"" This reverts commit 539b7363d08efcd37c0677ec62832d4e604e5050. --- examples/timer_gpio/timer_gpio_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/examples/timer_gpio/timer_gpio_main.c b/examples/timer_gpio/timer_gpio_main.c index a38e5acb1..315963aa2 100644 --- a/examples/timer_gpio/timer_gpio_main.c +++ b/examples/timer_gpio/timer_gpio_main.c @@ -182,6 +182,7 @@ static int timer_gpio_daemon(int argc, char *argv[]) notify.event.sigev_notify = SIGEV_SIGNAL; notify.event.sigev_signo = CONFIG_EXAMPLES_TIMER_GPIO_SIGNO; notify.event.sigev_value.sival_ptr = NULL; + notify.oneshot = false; ret = ioctl(fd_timer, TCIOC_NOTIFICATION, (unsigned long)((uintptr_t)));
[incubator-nuttx-apps] 07/07: netutils/thttpd: remove MIN and MAX definitions from libhttpd.c
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git commit 5862b9d15cbaf570a2e8166b440bb0044f45c443 Author: Petro Karashchenko AuthorDate: Sun Oct 23 12:09:04 2022 +0200 netutils/thttpd: remove MIN and MAX definitions from libhttpd.c This reverts commit e12d48f0d240edbd6934aac373242fe6b9b9aad2. --- examples/ajoystick/ajoy_main.c | 1 + examples/djoystick/djoy_main.c | 1 + examples/nunchuck/nunchuck_main.c | 1 + examples/zerocross/zerocross_main.c | 1 + netutils/thttpd/libhttpd.c | 8 netutils/thttpd/libhttpd.h | 2 ++ 6 files changed, 6 insertions(+), 8 deletions(-) diff --git a/examples/ajoystick/ajoy_main.c b/examples/ajoystick/ajoy_main.c index 398a787a9..c421328a4 100644 --- a/examples/ajoystick/ajoy_main.c +++ b/examples/ajoystick/ajoy_main.c @@ -59,6 +59,7 @@ #ifndef MIN # define MIN(a,b) ((a) < (b) ? (a) : (b)) #endif + #ifndef MAX # define MAX(a,b) ((a) > (b) ? (a) : (b)) #endif diff --git a/examples/djoystick/djoy_main.c b/examples/djoystick/djoy_main.c index 39f809782..54d72d9e1 100644 --- a/examples/djoystick/djoy_main.c +++ b/examples/djoystick/djoy_main.c @@ -56,6 +56,7 @@ #ifndef MIN # define MIN(a,b) ((a) < (b) ? (a) : (b)) #endif + #ifndef MAX # define MAX(a,b) ((a) > (b) ? (a) : (b)) #endif diff --git a/examples/nunchuck/nunchuck_main.c b/examples/nunchuck/nunchuck_main.c index 2e28ebbc7..c0e1a2059 100644 --- a/examples/nunchuck/nunchuck_main.c +++ b/examples/nunchuck/nunchuck_main.c @@ -55,6 +55,7 @@ #ifndef MIN # define MIN(a,b) ((a) < (b) ? (a) : (b)) #endif + #ifndef MAX # define MAX(a,b) ((a) > (b) ? (a) : (b)) #endif diff --git a/examples/zerocross/zerocross_main.c b/examples/zerocross/zerocross_main.c index a7dc72b56..c96f8b24b 100644 --- a/examples/zerocross/zerocross_main.c +++ b/examples/zerocross/zerocross_main.c @@ -56,6 +56,7 @@ #ifndef MIN # define MIN(a,b) ((a) < (b) ? (a) : (b)) #endif + #ifndef MAX # define MAX(a,b) ((a) > (b) ? (a) : (b)) #endif diff --git a/netutils/thttpd/libhttpd.c b/netutils/thttpd/libhttpd.c index 30ea11411..7e31d2cbf 100644 --- a/netutils/thttpd/libhttpd.c +++ b/netutils/thttpd/libhttpd.c @@ -92,14 +92,6 @@ extern CODE char *crypt(const char *key, const char *setting); -#ifndef MAX -# define MAX(a,b) ((a) > (b) ? (a) : (b)) -#endif - -#ifndef MIN -# define MIN(a,b) ((a) < (b) ? (a) : (b)) -#endif - /* Conditional macro to allow two alternate forms for use in the built-in * error pages. If EXPLICIT_ERROR_PAGES is defined, the second and more * explicit error form is used; otherwise, the first and more generic diff --git a/netutils/thttpd/libhttpd.h b/netutils/thttpd/libhttpd.h index fd0e657e8..a4e7f38b6 100644 --- a/netutils/thttpd/libhttpd.h +++ b/netutils/thttpd/libhttpd.h @@ -55,6 +55,7 @@ #include #include "config.h" + #ifdef CONFIG_THTTPD / @@ -66,6 +67,7 @@ #ifndef MAX # define MAX(a,b) ((a) > (b) ? (a) : (b)) #endif + #ifndef MIN # define MIN(a,b) ((a) < (b) ? (a) : (b)) #endif
[incubator-nuttx-apps] branch master updated (9ba5c86bc -> 5862b9d15)
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git from 9ba5c86bc README.md: remove inaccessible links new 7c8f0e41f Revert "Revert "include/canutils/lely: fix file path in comment header"" new 513662732 Revert "Revert "system/libuv: minor style fixes in Makefile"" new 7bf9025f2 Revert "Revert "system/spi: improve alignment in array initialization"" new ec1c5f927 Revert "Revert "nshlib: fix possible out of bounds array access"" new 9368b659a Revert "Revert "examples/timer_gpio: fix initialization of timer notification"" new 0fe45a4c7 Revert "Revert "examples/foc: fix description in Kconfig"" new 5862b9d15 netutils/thttpd: remove MIN and MAX definitions from libhttpd.c The 7 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: examples/ajoystick/ajoy_main.c| 1 + examples/djoystick/djoy_main.c| 1 + examples/foc/Kconfig | 2 +- examples/nunchuck/nunchuck_main.c | 1 + examples/timer_gpio/timer_gpio_main.c | 1 + examples/zerocross/zerocross_main.c | 1 + include/canutils/lely/config.h| 8 netutils/thttpd/libhttpd.c| 8 netutils/thttpd/libhttpd.h| 2 ++ nshlib/nsh_fsutils.c | 1 - system/libuv/Makefile | 5 ++--- system/spi/spi_main.c | 2 +- 12 files changed, 15 insertions(+), 18 deletions(-)
[incubator-nuttx-apps] 03/07: Revert "Revert "system/spi: improve alignment in array initialization""
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git
commit 7bf9025f28c68d0cdab67a0429c24f718ef5ff59
Author: Petro Karashchenko
AuthorDate: Sun Oct 23 12:07:18 2022 +0200
Revert "Revert "system/spi: improve alignment in array initialization""
This reverts commit a7567ce7b63b3d3dc3c3c3cb30e7387e38d65266.
---
system/spi/spi_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/system/spi/spi_main.c b/system/spi/spi_main.c
index 63aa45d62..b9a698142 100644
--- a/system/spi/spi_main.c
+++ b/system/spi/spi_main.c
@@ -55,7 +55,7 @@ static const struct cmdmap_s g_spicmds[] =
{
{ "?",spicmd_help, "Show help ", NULL },
{ "bus", spicmd_bus, "List buses", NULL },
- { "exch", spicmd_exch, "SPI Exchange ", "[OPTIONS] []" },
+ { "exch", spicmd_exch, "SPI Exchange ", "[OPTIONS] []" },
{ "help", spicmd_help, "Show help ", NULL },
{ NULL, NULL, NULL, NULL }
};
[incubator-nuttx-apps] 01/07: Revert "Revert "include/canutils/lely: fix file path in comment header""
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git commit 7c8f0e41fc2ade4a57ef3e0788e9002d0c3e4f62 Author: Petro Karashchenko AuthorDate: Sun Oct 23 12:06:52 2022 +0200 Revert "Revert "include/canutils/lely: fix file path in comment header"" This reverts commit 8e1ee24f9e345874702229e39f1b0aae657dba9a. --- include/canutils/lely/config.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/include/canutils/lely/config.h b/include/canutils/lely/config.h index b6cfee4cc..339a953ee 100644 --- a/include/canutils/lely/config.h +++ b/include/canutils/lely/config.h @@ -1,5 +1,5 @@ / - * apps/canutils/lely/config.h + * apps/include/canutils/lely/config.h * * Licensed to the Apache Software Foundation (ASF) under one or more * contributor license agreements. See the NOTICE file distributed with @@ -18,8 +18,8 @@ * / -#ifndef __CANUTILS_LELY_CONFIG_H -#define __CANUTILS_LELY_CONFIG_H +#ifndef __APPS_INCLUDE_CANUTILS_LELY_CONFIG_H +#define __APPS_INCLUDE_CANUTILS_LELY_CONFIG_H / * Included Files @@ -275,4 +275,4 @@ # define LELY_NO_CO_COAPP_SLAVE 1 #endif -#endif /* __CANUTILS_LELY_CONFIG_H */ +#endif /* __APPS_INCLUDE_CANUTILS_LELY_CONFIG_H */
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #1381: Minor fixes
xiaoxiang781216 merged PR #1381: URL: https://github.com/apache/incubator-nuttx-apps/pull/1381 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx-apps] 02/07: Revert "Revert "system/libuv: minor style fixes in Makefile""
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git commit 513662732d060b2094e67edb4190a5edcd7853e6 Author: Petro Karashchenko AuthorDate: Sun Oct 23 12:07:06 2022 +0200 Revert "Revert "system/libuv: minor style fixes in Makefile"" This reverts commit f613d0549690156f0fa386ba32382218adae9afc. --- system/libuv/Makefile | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/system/libuv/Makefile b/system/libuv/Makefile index 515632f72..e20fb6c24 100644 --- a/system/libuv/Makefile +++ b/system/libuv/Makefile @@ -25,7 +25,7 @@ LIBUV_PATCHS ?= $(sort $(wildcard 000*.patch)) LIBUV_VERSION = 1.42.0 LIBUV_UNPACK = libuv LIBUV_TARBALL = v$(LIBUV_VERSION).zip -LIBUV_URL_BASE = https://github.com/libuv/libuv/archive/refs/tags/ +LIBUV_URL_BASE = https://github.com/libuv/libuv/archive/refs/tags LIBUV_URL = $(LIBUV_URL_BASE)/$(LIBUV_TARBALL) @@ -38,8 +38,7 @@ $(LIBUV_UNPACK): $(LIBUV_TARBALL) $(call DELDIR, $(LIBUV_UNPACK)) $(Q) unzip $(LIBUV_TARBALL) $(Q) mv libuv-$(LIBUV_VERSION) $(LIBUV_UNPACK) - $(Q) cat $(LIBUV_PATCHS) | \ - patch -s -N -d $(LIBUV_UNPACK) -p1 + $(Q) cat $(LIBUV_PATCHS) | patch -s -N -d $(LIBUV_UNPACK) -p1 $(LIBUV_UNPACK)/.patch: $(LIBUV_UNPACK) $(Q) touch $(LIBUV_UNPACK)/.patch
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request, #7399: tools/ci/docker/linux/Dockerfile: Intall libtinfo5 in final image
xiaoxiang781216 opened a new pull request, #7399: URL: https://github.com/apache/incubator-nuttx/pull/7399 ## Summary and keep the installation in alphabetical order ## Impact Required by arm clang toolchain, reported here: https://github.com/apache/incubator-nuttx/actions/runs/3303662256/jobs/5453251147 ## Testing Pass CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx-apps] fjpanag commented on a diff in pull request #1382: Fixed compiler warnings.
fjpanag commented on code in PR #1382: URL: https://github.com/apache/incubator-nuttx-apps/pull/1382#discussion_r1002740169 ## netutils/webclient/webclient.c: ## @@ -1873,7 +1877,7 @@ int webclient_perform(FAR struct webclient_context *ctx) DEBUGASSERT(bytes_to_send <= ws->state_len); ssize_t ssz = webclient_conn_send(conn, -ws->data_buffer + +(char*)ws->data_buffer + Review Comment: Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx-apps] fjpanag commented on a diff in pull request #1382: Fixed compiler warnings.
fjpanag commented on code in PR #1382:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1382#discussion_r1002740068
##
netutils/webclient/webclient.c:
##
@@ -904,6 +906,7 @@ static inline int wget_parsechunkheader(struct
webclient_context *ctx,
static inline int wget_parsechunkenddata(struct webclient_context *ctx,
struct wget_s *ws)
{
+ UNUSED(ctx);
Review Comment:
Done.
##
netutils/webclient/webclient.c:
##
@@ -794,6 +795,7 @@ static inline int wget_parseheaders(struct
webclient_context *ctx,
static inline int wget_parsechunkheader(struct webclient_context *ctx,
struct wget_s *ws)
{
+ UNUSED(ctx);
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a diff in pull request #1382: Fixed compiler warnings.
pkarashchenko commented on code in PR #1382:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1382#discussion_r1002735010
##
netutils/webclient/webclient.c:
##
@@ -904,6 +906,7 @@ static inline int wget_parsechunkheader(struct
webclient_context *ctx,
static inline int wget_parsechunkenddata(struct webclient_context *ctx,
struct wget_s *ws)
{
+ UNUSED(ctx);
Review Comment:
Let's move it after `ret = OK;`
##
netutils/webclient/webclient.c:
##
@@ -794,6 +795,7 @@ static inline int wget_parseheaders(struct
webclient_context *ctx,
static inline int wget_parsechunkheader(struct webclient_context *ctx,
struct wget_s *ws)
{
+ UNUSED(ctx);
Review Comment:
Let's move it after `ret = OK:`
##
netutils/webclient/webclient.c:
##
@@ -1873,7 +1877,7 @@ int webclient_perform(FAR struct webclient_context *ctx)
DEBUGASSERT(bytes_to_send <= ws->state_len);
ssize_t ssz = webclient_conn_send(conn,
-ws->data_buffer +
+(char*)ws->data_buffer +
Review Comment:
```suggestion
(char *)ws->data_buffer +
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #7398: Fix error: mmcsd/mmcsd_sdio.c:2669:35: error: 'buffer' may be used uninitialized [-Werror=maybe-uninitialized]
btashton commented on PR #7398: URL: https://github.com/apache/incubator-nuttx/pull/7398#issuecomment-1288148091 > It's hard to compile all config in the local machine. It's more simple that ci use the new docker image(instead the old) run all config if the patch change Dockerfile. @btashton is it possible? Unfortunately you cannot push from a PR to the container registry (which makes sense for security), but what you can do it push to a registry including one off your GitHub fork, and then reference that in the PR until things are working. I have done that a few times. I can also put some more thought into other workflow setups but this is probably the easiest path for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7398: Fix error: mmcsd/mmcsd_sdio.c:2669:35: error: 'buffer' may be used uninitialized [-Werror=maybe-uninitialized]
xiaoxiang781216 commented on PR #7398: URL: https://github.com/apache/incubator-nuttx/pull/7398#issuecomment-1288146490 It's hard to compile all config in the local machine -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx-apps] fjpanag opened a new pull request, #1382: Fixed compiler warnings.
fjpanag opened a new pull request, #1382: URL: https://github.com/apache/incubator-nuttx-apps/pull/1382 ## Summary Fixes a couple of compiler warnings. ## Impact N/A ## Testing Build test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #7398: Fix error: mmcsd/mmcsd_sdio.c:2669:35: error: 'buffer' may be used uninitialized [-Werror=maybe-uninitialized]
pkarashchenko commented on PR #7398: URL: https://github.com/apache/incubator-nuttx/pull/7398#issuecomment-1288141729 > > Still some other errors remain > > Fix here: https://github.com/apache/incubator-nuttx/pull/7398/commits/8b78bcc9649d26b27a82394e7f6a19c68a386553 > The new gcc version do a great job to catch so many error in compile time. Yes. But I was expecting builds to be run locally and those fixes to be merged prior to toolchain upgrade :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7398: Fix error: mmcsd/mmcsd_sdio.c:2669:35: error: 'buffer' may be used uninitialized [-Werror=maybe-uninitialized]
xiaoxiang781216 commented on PR #7398: URL: https://github.com/apache/incubator-nuttx/pull/7398#issuecomment-1288138643 > Still some other errors remain Fix here: https://github.com/apache/incubator-nuttx/pull/7398/commits/8b78bcc9649d26b27a82394e7f6a19c68a386553 The new gcc version do the great job to catch so many error in compile time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #7398: Fix error: mmcsd/mmcsd_sdio.c:2669:35: error: 'buffer' may be used uninitialized [-Werror=maybe-uninitialized]
pkarashchenko commented on PR #7398: URL: https://github.com/apache/incubator-nuttx/pull/7398#issuecomment-1288130247 Still some other errors remain -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7397: arch: stm32h7: Flush D-Cache on flash erase operation
pkarashchenko commented on code in PR #7397: URL: https://github.com/apache/incubator-nuttx/pull/7397#discussion_r1002714821 ## arch/arm/src/stm32h7/stm32h743xx_flash.c: ## @@ -769,6 +769,12 @@ ssize_t up_progmem_eraseblock(size_t block) return (ssize_t)ret; } + /* Flush and invalidate D-Cache for this block */ + +#ifdef CONFIG_ARMV7M_DCACHE + up_flush_dcache(block_address, block_address + FLASH_SECTOR_SIZE); Review Comment: Let me take a closer look later today. In general the logic that I use is next: 1. If memory is modified by CPU and then modified area is read by peripheral (or DMA or any other memory user) then the memory area cache should be cleaned after the memory update is finished by the CPU. 2. If the memory is updated by the peripheral (or DMA or any other memory user) and the CPU needs to get the result of such an update then the memory area cache should be invalidated prior to reading that area by the CPU. 3. As you already mentioned the most conservative way is to use a cache flush that is clean+invalidate. There is no harm in using cache flush, but from what I read it is that we want to erase the flash (actual memory update done by peripheral) and then read back the content to verify that page is actually erased. That is why I posted a comment. Anyway let me browse the code and take a closer look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] tito97sp commented on a diff in pull request #7397: arch: stm32h7: Flush D-Cache on flash erase operation
tito97sp commented on code in PR #7397: URL: https://github.com/apache/incubator-nuttx/pull/7397#discussion_r1002712991 ## arch/arm/src/stm32h7/stm32h743xx_flash.c: ## @@ -769,6 +769,12 @@ ssize_t up_progmem_eraseblock(size_t block) return (ssize_t)ret; } + /* Flush and invalidate D-Cache for this block */ + +#ifdef CONFIG_ARMV7M_DCACHE + up_flush_dcache(block_address, block_address + FLASH_SECTOR_SIZE); Review Comment: HI @pkarashchenko. The problem I face is a lack in synchronization between the sector erase inside `up_progmem_eraseblock()` function and the following erase check performed through `stm32h7_israngeerased()`. I realized that after the sector is erased the cache flushes the previous contents and when I check the memory status it appears as not clean (not fully erased). So my opinion here is that the cache flush must be done before the sector erase operation. Regarding the use of `up_flush_cache()` in place of `up_invalidate_dcache()`, I have used the the most conservative cache operation since `up_invalidate_dcache()` marks the contents as invalid (basically, a delete operation). Info form: [level-1-cache-on-stm32f7-series-and-stm32h7-series-stmicroelectronics.pdf](https://www.google.com/url?sa=t=j==s=web==rja=8=2ahUKEwik8O-7vfb6AhWIhv0HHcrTCt4QFnoECBcQAQ=https%3A%2F%2Fwww.st.com%2Fresource%2Fen%2Fapplication_note%2Fdm00272913-level-1-cache-on-stm32f7-series-and-stm32h7-series-stmicroelectronics.pdf=AOvVaw22vWOqlHEuqOoGdM3hJ8sd) What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] tito97sp commented on a diff in pull request #7397: arch: stm32h7: Flush D-Cache on flash erase operation
tito97sp commented on code in PR #7397: URL: https://github.com/apache/incubator-nuttx/pull/7397#discussion_r1002712991 ## arch/arm/src/stm32h7/stm32h743xx_flash.c: ## @@ -769,6 +769,12 @@ ssize_t up_progmem_eraseblock(size_t block) return (ssize_t)ret; } + /* Flush and invalidate D-Cache for this block */ + +#ifdef CONFIG_ARMV7M_DCACHE + up_flush_dcache(block_address, block_address + FLASH_SECTOR_SIZE); Review Comment: HI @pkarashchenko. The problem I face is a lack in synchronization between the sector erase inside `up_progmem_eraseblock()` and the following erase check in `stm32h7_israngeerased()`. I see that once the sector is erased the cache flush the precious contents and once I check the memory status it appears as not clean, so in my opinion the flush of cache from previous operations must be done before the sector erase. Regarding the use of `up_flush_cache()` in place of `up_invalidate_dcache()` is for using the most conservative Cache operation. `up_invalidate_dcache()` marks the contents as invalid (basically, a delete operation). Info form: [level-1-cache-on-stm32f7-series-and-stm32h7-series-stmicroelectronics.pdf](https://www.google.com/url?sa=t=j==s=web==rja=8=2ahUKEwik8O-7vfb6AhWIhv0HHcrTCt4QFnoECBcQAQ=https%3A%2F%2Fwww.st.com%2Fresource%2Fen%2Fapplication_note%2Fdm00272913-level-1-cache-on-stm32f7-series-and-stm32h7-series-stmicroelectronics.pdf=AOvVaw22vWOqlHEuqOoGdM3hJ8sd) What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7398: Fix error: mmcsd/mmcsd_sdio.c:2669:35: error: 'buffer' may be used uninitialized [-Werror=maybe-uninitialized]
xiaoxiang781216 commented on code in PR #7398: URL: https://github.com/apache/incubator-nuttx/pull/7398#discussion_r1002710219 ## drivers/mmcsd/mmcsd_sdio.c: ## @@ -2659,6 +2659,8 @@ static int mmcsd_read_csd(FAR struct mmcsd_state_s *priv) return -EPERM; } + memset(buffer, sizeof(buffer)); Review Comment: Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7398: Fix error: mmcsd/mmcsd_sdio.c:2669:35: error: 'buffer' may be used uninitialized [-Werror=maybe-uninitialized]
pkarashchenko commented on code in PR #7398: URL: https://github.com/apache/incubator-nuttx/pull/7398#discussion_r1002708020 ## drivers/mmcsd/mmcsd_sdio.c: ## @@ -2659,6 +2659,8 @@ static int mmcsd_read_csd(FAR struct mmcsd_state_s *priv) return -EPERM; } + memset(buffer, sizeof(buffer)); Review Comment: ```suggestion memset(buffer, 0, sizeof(buffer)); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx-apps] hartmannathan commented on pull request #1380: README.md: remove inaccessible links
hartmannathan commented on PR #1380: URL: https://github.com/apache/incubator-nuttx-apps/pull/1380#issuecomment-1288098689 Note that the NuttX Porting Guide is currently in the CWIKI: https://cwiki.apache.org/confluence/display/NUTTX/Porting+Guide It would perhaps be better to update the links rather than remove them: e.g., ``` This is documented in `NuttX/boards/README.txt` and `nuttx/Documentation/NuttXPortingGuide.html` (Online at https://cwiki.apache.org/confluence/display/NUTTX/Porting+Guide under _Build options_) and in the `apps/README.txt` file. ``` Better yet, the NuttX Porting Guide should be migrated into the nuttx repository Documentation directory. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx-apps] branch master updated (2962af6fe -> 9ba5c86bc)
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git from 2962af6fe Fix fatal error: array: No such file or directory add 9ba5c86bc README.md: remove inaccessible links No new revisions were added by this update. Summary of changes: README.md | 5 + 1 file changed, 1 insertion(+), 4 deletions(-)
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #1380: README.md: remove inaccessible links
xiaoxiang781216 merged PR #1380: URL: https://github.com/apache/incubator-nuttx-apps/pull/1380 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #1380: README.md: remove inaccessible links
xiaoxiang781216 commented on PR #1380: URL: https://github.com/apache/incubator-nuttx-apps/pull/1380#issuecomment-1288094660 Let's ignore the build error introduced by new version of toolchain for this simple change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #1381: Minor fixes
xiaoxiang781216 commented on PR #1381: URL: https://github.com/apache/incubator-nuttx-apps/pull/1381#issuecomment-1288094503 The build error is fixed here: https://github.com/apache/incubator-nuttx/pull/7398 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request, #7398: Fix error: mmcsd/mmcsd_sdio.c:2669:35: error: 'buffer' may be used uninitialized [-Werror=maybe-uninitialized]
xiaoxiang781216 opened a new pull request, #7398: URL: https://github.com/apache/incubator-nuttx/pull/7398 ## Summary since new version gcc toolchain make more check. ## Impact Minor ## Testing Pass CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7397: arch: stm32h7: Flush D-Cache on flash erase operation
pkarashchenko commented on code in PR #7397: URL: https://github.com/apache/incubator-nuttx/pull/7397#discussion_r1002684613 ## arch/arm/src/stm32h7/stm32h743xx_flash.c: ## @@ -769,6 +769,12 @@ ssize_t up_progmem_eraseblock(size_t block) return (ssize_t)ret; } + /* Flush and invalidate D-Cache for this block */ + +#ifdef CONFIG_ARMV7M_DCACHE + up_flush_dcache(block_address, block_address + FLASH_SECTOR_SIZE); Review Comment: shouldn't this be a `up_invalidate_dcache()` call and called before `stm32h7_israngeerased()`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #7396: Style fixes
pkarashchenko commented on PR #7396: URL: https://github.com/apache/incubator-nuttx/pull/7396#issuecomment-1288079113 > @pkarashchenko please fix the style warning: https://github.com/apache/incubator-nuttx/actions/runs/3304682303/jobs/5454270761 done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko commented on pull request #1381: Minor fixes
pkarashchenko commented on PR #1381: URL: https://github.com/apache/incubator-nuttx-apps/pull/1381#issuecomment-1288077505 @xiaoxiang781216 here is the correct PR. In previously I accidentally removed `MIN` and `MAX` from `libhttpd.h` instead of `libhttpd.c`. Let's wait CI to pass -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko opened a new pull request, #1381: Minor fixes
pkarashchenko opened a new pull request, #1381: URL: https://github.com/apache/incubator-nuttx-apps/pull/1381 ## Summary Multiple minor fixes ## Impact Fix possible memory overflow ## Testing Pass CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7397: arch: stm32h7: Flush D-Cache on flash erase operation
xiaoxiang781216 commented on PR #7397: URL: https://github.com/apache/incubator-nuttx/pull/7397#issuecomment-1288059705 @tito97sp please remove the empty patch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7397: arch: stm32h7: Flush D-Cache on flash erase operation
xiaoxiang781216 commented on PR #7397: URL: https://github.com/apache/incubator-nuttx/pull/7397#issuecomment-1288059592 Do the following: ``` git remote add apache g...@github.com:apache/incubator-nuttx.git git fetch apache git rebase apahce/master git push -f origin ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] tito97sp commented on pull request #7397: arch: stm32h7: Flush D-Cache on flash erase operation
tito97sp commented on PR #7397: URL: https://github.com/apache/incubator-nuttx/pull/7397#issuecomment-1288057639 > > > > @tito97sp could you rebase your patch which may fix the download problem. > > > > > > Hi @xiaoxiang781216 I have deleted the patch branch that was causing problems. Could you trigger the builders again? > > Done, you can restore the patch by: git branch --track issue/ORDISO-5-add-compatibility-with-d-caches origin/issue/ORDISO-5-add-compatibility-with-d-caches Command executed on local. Any further actions are needed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7397: arch: stm32h7: Flush D-Cache on flash erase operation
xiaoxiang781216 commented on PR #7397: URL: https://github.com/apache/incubator-nuttx/pull/7397#issuecomment-1288055788 > > @tito97sp could you rebase your patch which may fix the download problem. > > Hi @xiaoxiang781216 I have deleted the patch branch that was causing problems. Could you trigger the builders again? Done, you can restore the patch by: git branch --track issue/ORDISO-5-add-compatibility-with-d-caches origin/issue/ORDISO-5-add-compatibility-with-d-caches -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx-apps] branch master updated: Fix fatal error: array: No such file or directory
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git
The following commit(s) were added to refs/heads/master by this push:
new 2962af6fe Fix fatal error: array: No such file or directory
2962af6fe is described below
commit 2962af6fe6688eebfc30b4cd4e4d0da37e0d4097
Author: Xiang Xiao
AuthorDate: Sun Oct 23 14:00:00 2022 +0800
Fix fatal error: array: No such file or directory
enable test_stl2 only when CONFIG_LIBCXX is enabled
since uClibc++/minic++ doesn't have array header file
Signed-off-by: Xiang Xiao
---
testing/cxxtest/cxxtest_main.cxx | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/testing/cxxtest/cxxtest_main.cxx b/testing/cxxtest/cxxtest_main.cxx
index 4be644178..65b485d81 100644
--- a/testing/cxxtest/cxxtest_main.cxx
+++ b/testing/cxxtest/cxxtest_main.cxx
@@ -36,7 +36,7 @@
#ifdef CONFIG_CXX_EXCEPTION
#include
#endif
-#if __cplusplus >= 201703L
+#if defined(CONFIG_LIBCXX) && __cplusplus >= 201703L
#include
#include
#endif
@@ -61,7 +61,7 @@ public:
}
};
-#if __cplusplus >= 201703L
+#if defined(CONFIG_LIBCXX) && __cplusplus >= 201703L
class File
{
public:
@@ -193,7 +193,7 @@ static void test_stl()
// Name: test_stl2
//***/
-#if __cplusplus >= 201703L
+#if defined(CONFIG_LIBCXX) && __cplusplus >= 201703L
auto test_stl2() -> void
{
std::cout << "Test C++17 features ==" << std::endl;
@@ -274,7 +274,7 @@ extern "C" int main(int argc, char *argv[])
test_ofstream();
test_iostream();
test_stl();
-#if __cplusplus >= 201703L
+#if defined(CONFIG_LIBCXX) && __cplusplus >= 201703L
test_stl2();
#endif
#ifdef CONFIG_CXX_RTTI
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #1379: Fix fatal error: array: No such file or directory
xiaoxiang781216 merged PR #1379: URL: https://github.com/apache/incubator-nuttx-apps/pull/1379 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
