[GitHub] [pulsar] wolfstudy merged pull request #5627: [Issue 5626][pulsar-function-go] Fix a memory leak of pulsar-function-go library regarding time.NewTimer()
wolfstudy merged pull request #5627: [Issue 5626][pulsar-function-go] Fix a memory leak of pulsar-function-go library regarding time.NewTimer() URL: https://github.com/apache/pulsar/pull/5627 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] wolfstudy closed issue #5626: Memory leak of pulsar-function-go library regarding time.NewTimer()
wolfstudy closed issue #5626: Memory leak of pulsar-function-go library regarding time.NewTimer() URL: https://github.com/apache/pulsar/issues/5626 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] wolfstudy commented on issue #5592: [Issue 5589][pulsar-function-go] Fix a memory leak of pulsar-function-go library
wolfstudy commented on issue #5592: [Issue 5589][pulsar-function-go] Fix a memory leak of pulsar-function-go library URL: https://github.com/apache/pulsar/pull/5592#issuecomment-560263099 run cpp tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[pulsar] branch master updated (86a6be7 -> f310ab0)
This is an automated email from the ASF dual-hosted git repository. rxl pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 86a6be7 Add Murmur3_32Hash private constructor (#5765) add f310ab0 Fixes #5626 (#5627) No new revisions were added by this update. Summary of changes: pulsar-function-go/pf/instance.go | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-)
[GitHub] [pulsar] jiazhai commented on issue #3218: Pulsar client should be able to connect to brokers without DNS
jiazhai commented on issue #3218: Pulsar client should be able to connect to brokers without DNS URL: https://github.com/apache/pulsar/issues/3218#issuecomment-560262700 add a sub task issue for cpp client This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #4955: [PIP-39] Introduce system topic and topic policies service
codelipenghui commented on issue #4955: [PIP-39] Introduce system topic and topic policies service URL: https://github.com/apache/pulsar/pull/4955#issuecomment-560258079 run java8 tests run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #5755: UnAckedMessages admin information not correct
codelipenghui commented on issue #5755: UnAckedMessages admin information not
correct
URL: https://github.com/apache/pulsar/issues/5755#issuecomment-560257624
Is the the negative number of `unackedMessages` can reproduce every time, i
have test it by using your POC code, but the stats of the topic is always:
```json
{
"msgRateIn": 0,
"msgRateOut": 0,
"msgThroughputIn": 0,
"msgThroughputOut": 0,
"averageMsgSize": 0,
"storageSize": 4772378,
"publishers": [],
"subscriptions": {
"one-subscription": {
"blockedSubscriptionOnUnackedMsgs": false,
"isReplicated": false,
"msgRateOut": 0,
"msgThroughputOut": 0,
"msgRateRedeliver": 0,
"msgRateExpired": 0,
"msgBacklog": 99950,
"msgDelayed": 0,
"unackedMessages": 50010,
"type": "Shared",
"activeConsumerName": "",
"consumers": [
{
"blockedConsumerOnUnackedMsgs": true,
"availablePermits": 940,
"unackedMessages": 50010,
"msgRateOut": 0,
"msgThroughputOut": 0,
"msgRateRedeliver": 0,
"consumerName": "f2273",
"metadata": {}
}
]
}
},
"replication": {},
"deduplicationStatus": "Disabled"
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #5680: [transaction-coordinator] Implementation of transaction coordinator client.
codelipenghui commented on issue #5680: [transaction-coordinator] Implementation of transaction coordinator client. URL: https://github.com/apache/pulsar/pull/5680#issuecomment-560257826 run cpp tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] jiazhai commented on issue #5333: Do not use timed receive in BrokerClientIntegrationTest.testUnsupportedBatchMessageConsumer
jiazhai commented on issue #5333: Do not use timed receive in BrokerClientIntegrationTest.testUnsupportedBatchMessageConsumer URL: https://github.com/apache/pulsar/pull/5333#issuecomment-560250099 run cpp tests run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] congbobo184 commented on issue #5762: Add the filesystem offload doc
congbobo184 commented on issue #5762: Add the filesystem offload doc URL: https://github.com/apache/pulsar/pull/5762#issuecomment-560244559 run Integration Tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] massakam commented on issue #5758: Bump jackson libraries to 2.10.1
massakam commented on issue #5758: Bump jackson libraries to 2.10.1 URL: https://github.com/apache/pulsar/pull/5758#issuecomment-560244154 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] tuteng commented on issue #5778: Python API Docs are not updated
tuteng commented on issue #5778: Python API Docs are not updated URL: https://github.com/apache/pulsar/issues/5778#issuecomment-560234358 We have an e-mail to discuss this matter https://lists.apache.org/thread.html/a6a91990907cf8d2458ff8b7e1e916a9bfb17ec0cd216d57c66ab96c@%3Cdev.pulsar.apache.org%3E. We are doing this, this is a pr https://github.com/apache/pulsar/pull/5660. After adding the old version of API documents, we will consider replacing the jump links in the documents. @acedrew This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Fomal-haut commented on issue #5755: UnAckedMessages admin information not correct
Fomal-haut commented on issue #5755: UnAckedMessages admin information not
correct
URL: https://github.com/apache/pulsar/issues/5755#issuecomment-560232144
**Sure. Here is my POC code.**
_**Pulsar admin(create topic and subscription):**_
```
import org.apache.pulsar.client.admin.PulsarAdmin;
import org.apache.pulsar.client.admin.PulsarAdminException;`
import org.apache.pulsar.client.api.MessageId;
import org.apache.pulsar.client.api.PulsarClientException;
public class PulsarAdminTest {
public static void main(String[] args) throws PulsarClientException,
PulsarAdminException {
String url = "http://localhost:8080;;
boolean tlsAllowInsecureConnection = false;
String tlsTrustCertsFilePath = null;
PulsarAdmin admin = PulsarAdmin.builder()
.serviceHttpUrl(url)
.tlsTrustCertsFilePath(tlsTrustCertsFilePath)
.allowTlsInsecureConnection(tlsAllowInsecureConnection)
.build();
admin.topics().createNonPartitionedTopic("public/default/one");
admin.topics().createSubscription("public/default/one",
"one-subscription", MessageId.earliest);
admin.close();
}
}
```
_**Pulsar producer(publish messages):**_
```
import org.apache.pulsar.client.api.Producer;
import org.apache.pulsar.client.api.PulsarClient;
import org.apache.pulsar.client.api.PulsarClientException;
public class PulsarSingleProducer {
public static void main(String[] args) throws PulsarClientException,
InterruptedException {
PulsarClient client = null;
client = PulsarClient.builder()
.serviceUrl("pulsar://localhost:6650")
.build();
Producer producer = client.newProducer()
.enableBatching(false)
.topic("public/default/one")
.create();
int counter = 0;
for (int i = 0; i < 100_000; i++) {
counter ++;
producer.send((i + "").getBytes());
if (counter % 5000 == 0) {
System.out.println(counter);
}
}
System.out.println("start to close");
producer.close();
client.close();
}
}
```
_**Pulsar consumer(receive messages):**_
```
import org.apache.pulsar.client.api.*;
import java.util.concurrent.TimeUnit;
public class PulsarConsumerMaxUnAckTest {
public static void main(String[] args) throws PulsarClientException {
PulsarClient client = PulsarClient.builder()
.serviceUrl("pulsar://localhost:6650")
.build();
Consumer consumer = client.newConsumer()
.topic("public/default/one")
.ackTimeout(10, TimeUnit.HOURS)
.subscriptionName("one-subscription")
.subscriptionType(SubscriptionType.Shared)
.subscribe();
int counter = 0;
while (true) {
// Wait for a message
Message msg = consumer.receive();
counter ++;
try {
// Do something with the message
if (counter % 1000 == 0) {
consumer.acknowledge(msg);
System.out.println(counter);
System.out.println(String.format("Message received: %s",
new String(msg.getData(;
}
} catch (Exception e) {
// Message failed to process, redeliver later
consumer.negativeAcknowledge(msg);
}
}
}
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] acedrew commented on issue #5778: Python API Docs are not updated
acedrew commented on issue #5778: Python API Docs are not updated URL: https://github.com/apache/pulsar/issues/5778#issuecomment-560224377 @tuteng Thanks, yes I was able to find the docs and just look at the source to answer my question, but it was confusing to follow the link from the 2.4.1 docs to find a completely different version of the API  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie commented on issue #5370: sql worker on Ubuntu 18: libprocname.so failing, and failing JVM vendor check
sijie commented on issue #5370: sql worker on Ubuntu 18: libprocname.so failing, and failing JVM vendor check URL: https://github.com/apache/pulsar/issues/5370#issuecomment-560223980 didn't realize #5386 was closed. we will pick it up again. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] jiazhai opened a new issue #5780: CPP client: support multiple hosts for C++
jiazhai opened a new issue #5780: CPP client: support multiple hosts for C++ URL: https://github.com/apache/pulsar/issues/5780 This is a sub issue for #3218 In #3249 java support is provided, this is for support of CPP and other client This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie commented on issue #5761: [pulsar-client] Switch partition when a batch is full (in RoundRobinMessageRouter)
sijie commented on issue #5761: [pulsar-client] Switch partition when a batch is full (in RoundRobinMessageRouter) URL: https://github.com/apache/pulsar/pull/5761#issuecomment-560223191 > Is a new message router can works well here? the time based message router, the router will switch to the next partition for every time period The current message router is a time based message router. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] wolfstudy commented on issue #5734: [Reopen][Issue 5597]retry when getPartitionedTopicMetadata failed
wolfstudy commented on issue #5734: [Reopen][Issue 5597]retry when getPartitionedTopicMetadata failed URL: https://github.com/apache/pulsar/pull/5734#issuecomment-560222712 > The tests seems to be failed due to the change. Can you please take a look at those tests? Sure, will fix them. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] tuteng commented on issue #5635: [Issue 5612] Use Reactivestreams client for Mongo Sink
tuteng commented on issue #5635: [Issue 5612] Use Reactivestreams client for Mongo Sink URL: https://github.com/apache/pulsar/pull/5635#issuecomment-560222478 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie commented on issue #5635: [Issue 5612] Use Reactivestreams client for Mongo Sink
sijie commented on issue #5635: [Issue 5612] Use Reactivestreams client for Mongo Sink URL: https://github.com/apache/pulsar/pull/5635#issuecomment-560219204 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie commented on issue #5147: Deprecate getstatus subcommand for source command
sijie commented on issue #5147: Deprecate getstatus subcommand for source command URL: https://github.com/apache/pulsar/pull/5147#issuecomment-560219327 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie commented on issue #5734: [Reopen][Issue 5597]retry when getPartitionedTopicMetadata failed
sijie commented on issue #5734: [Reopen][Issue 5597]retry when getPartitionedTopicMetadata failed URL: https://github.com/apache/pulsar/pull/5734#issuecomment-560219006 @wolfstudy ``` Test Result (7 failures / +7) org.apache.pulsar.broker.service.BrokerServiceTest.testLookupThrottlingForClientByClient org.apache.pulsar.broker.service.BrokerServiceThrottlingTest.testLookupThrottlingForClientByBroker org.apache.pulsar.broker.service.PeerReplicatorTest.testPeerClusterTopicLookup org.apache.pulsar.broker.service.PeerReplicatorTest.testPeerClusterTopicLookup org.apache.pulsar.broker.service.PeerReplicatorTest.testPeerClusterTopicLookup org.apache.pulsar.client.api.TlsProducerConsumerTest.testTlsClientAuthOverBinaryProtocol org.apache.pulsar.client.api.TlsProducerConsumerTest.testTlsClientAuthOverHTTPProtocol ``` The tests seems to be failed due to the change. Can you please take a look at those tests? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] wolfstudy commented on issue #5734: [Reopen][Issue 5597]retry when getPartitionedTopicMetadata failed
wolfstudy commented on issue #5734: [Reopen][Issue 5597]retry when getPartitionedTopicMetadata failed URL: https://github.com/apache/pulsar/pull/5734#issuecomment-560218820 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] wolfstudy commented on issue #5592: [Issue 5589][pulsar-function-go] Fix a memory leak of pulsar-function-go library
wolfstudy commented on issue #5592: [Issue 5589][pulsar-function-go] Fix a memory leak of pulsar-function-go library URL: https://github.com/apache/pulsar/pull/5592#issuecomment-560218744 run java8 tests run cpp tests run integration tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] wolfstudy removed a comment on issue #5592: [Issue 5589][pulsar-function-go] Fix a memory leak of pulsar-function-go library
wolfstudy removed a comment on issue #5592: [Issue 5589][pulsar-function-go] Fix a memory leak of pulsar-function-go library URL: https://github.com/apache/pulsar/pull/5592#issuecomment-560218679 reset this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] wolfstudy commented on issue #5592: [Issue 5589][pulsar-function-go] Fix a memory leak of pulsar-function-go library
wolfstudy commented on issue #5592: [Issue 5589][pulsar-function-go] Fix a memory leak of pulsar-function-go library URL: https://github.com/apache/pulsar/pull/5592#issuecomment-560218679 reset this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] wolfstudy commented on issue #5627: [Issue 5626][pulsar-function-go] Fix a memory leak of pulsar-function-go library regarding time.NewTimer()
wolfstudy commented on issue #5627: [Issue 5626][pulsar-function-go] Fix a memory leak of pulsar-function-go library regarding time.NewTimer() URL: https://github.com/apache/pulsar/pull/5627#issuecomment-560218607 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie commented on issue #5762: Add the filesystem offload doc
sijie commented on issue #5762: Add the filesystem offload doc URL: https://github.com/apache/pulsar/pull/5762#issuecomment-560218256 run cpp tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] jiazhai commented on issue #5770: Pulsar Broker Sometimes does not return CommandSendReceipt/CommandSendError to prducer send CommandSend
jiazhai commented on issue #5770: Pulsar Broker Sometimes does not return CommandSendReceipt/CommandSendError to prducer send CommandSend URL: https://github.com/apache/pulsar/issues/5770#issuecomment-560217876 @alphashaw I think in your example, **res1 < res2** is not guaranteed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] aahmed-se commented on issue #5642: Add Github workflow for gated checkin
aahmed-se commented on issue #5642: Add Github workflow for gated checkin URL: https://github.com/apache/pulsar/pull/5642#issuecomment-560215498 Added a description. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] jiazhai commented on issue #4675: Document for delayed message delivery.
jiazhai commented on issue #4675: Document for delayed message delivery. URL: https://github.com/apache/pulsar/issues/4675#issuecomment-560205411 Seems this already fixed in https://github.com/apache/pulsar/pull/5293 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] jiazhai closed issue #4675: Document for delayed message delivery.
jiazhai closed issue #4675: Document for delayed message delivery. URL: https://github.com/apache/pulsar/issues/4675 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] jiazhai commented on issue #5642: Add Github workflow for gated checkin
jiazhai commented on issue #5642: Add Github workflow for gated checkin URL: https://github.com/apache/pulsar/pull/5642#issuecomment-560203653 @aahmed-se Would you please provide a description for this PR?  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[pulsar] branch master updated (f0df253 -> 9b415ce)
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from f0df253 [docs] Fix link issue for "Authentication and authorization in Pulsar" (#5771) add 9b415ce Fix bug that beforeConsume() of interceptor is not called when receiver queue size is 0 (#5777) No new revisions were added by this update. Summary of changes: .../apache/pulsar/client/api/InterceptorsTest.java | 71 +++--- .../pulsar/client/impl/ZeroQueueConsumerImpl.java | 4 +- 2 files changed, 64 insertions(+), 11 deletions(-)
[GitHub] [pulsar] codelipenghui merged pull request #5777: [pulsar-client] Fix bug that beforeConsume() of interceptor is not called when receiver queue size is 0
codelipenghui merged pull request #5777: [pulsar-client] Fix bug that beforeConsume() of interceptor is not called when receiver queue size is 0 URL: https://github.com/apache/pulsar/pull/5777 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui merged pull request #5765: add Murmur3_32Hash private constructor
codelipenghui merged pull request #5765: add Murmur3_32Hash private constructor URL: https://github.com/apache/pulsar/pull/5765 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[pulsar] branch master updated (9b415ce -> 86a6be7)
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 9b415ce Fix bug that beforeConsume() of interceptor is not called when receiver queue size is 0 (#5777) add 86a6be7 Add Murmur3_32Hash private constructor (#5765) No new revisions were added by this update. Summary of changes: .../src/main/java/org/apache/pulsar/client/impl/Murmur3_32Hash.java | 2 ++ 1 file changed, 2 insertions(+)
[GitHub] [pulsar] codelipenghui commented on issue #5680: [transaction-coordinator] Implementation of transaction coordinator client.
codelipenghui commented on issue #5680: [transaction-coordinator] Implementation of transaction coordinator client. URL: https://github.com/apache/pulsar/pull/5680#issuecomment-560203025 run cpp tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #5776: fix potential NPE and repeated conditional test
codelipenghui commented on issue #5776: fix potential NPE and repeated conditional test URL: https://github.com/apache/pulsar/pull/5776#issuecomment-560202948 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #5755: UnAckedMessages admin information not correct
codelipenghui commented on issue #5755: UnAckedMessages admin information not correct URL: https://github.com/apache/pulsar/issues/5755#issuecomment-560202067 @Fomal-haut I can't reproduce the negative number of `unackedMessages`, can you provide a reproduce demo? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Anonymitaet commented on a change in pull request #5762: Add the filesystem offload doc
Anonymitaet commented on a change in pull request #5762: Add the filesystem offload doc URL: https://github.com/apache/pulsar/pull/5762#discussion_r352397993 ## File path: site2/docs/cookbooks-tiered-storage.md ## @@ -186,6 +190,62 @@ Pulsar also provides some knobs to configure the size of requests sent to GCS. In both cases, these should not be touched unless you know what you are doing. +### "filesystem" Driver configuration + + + Configure connection address + +You can configure the connection address in the `broker.conf` file. + +```conf +fileSystemURI="hdfs://127.0.0.1:9000" +``` + Configure Hadoop profile path + +The configuration file is stored in the Hadoop profile path. It contains various settings, such as base path, authentication, and so on. + +```conf +fileSystemProfilePath="../conf/filesystem_offload_core_site.xml" +``` + +The model for storing topic data uses `org.apache.hadoop.io.MapFile`. You can use all of the configurations in `org.apache.hadoop.io.MapFile` for Hadoop. +**Example** Review comment: ```suggestion **Example** ``` Add a blank line to correct this issue.  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Jennifer88huang opened a new issue #5779: [docs] Reorganize "Tiered storage" content
Jennifer88huang opened a new issue #5779: [docs] Reorganize "Tiered storage" content URL: https://github.com/apache/pulsar/issues/5779 **Describe the bug** There are two sections about "tiered storage" under "Concepts and Architecture" and "Cookbooks", the information splits. It's better to reorganize the the content for "tierage storage" after merging https://github.com/apache/pulsar/pull/5762 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #5755: UnAckedMessages admin information not correct
codelipenghui commented on issue #5755: UnAckedMessages admin information not correct URL: https://github.com/apache/pulsar/issues/5755#issuecomment-560193656 @Fomal-haut Thanks, i will try to reproduce the negative number of `unackedMessages`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Fomal-haut commented on issue #5755: UnAckedMessages admin information not correct
Fomal-haut commented on issue #5755: UnAckedMessages admin information not correct URL: https://github.com/apache/pulsar/issues/5755#issuecomment-560191528 @codelipenghui Thanks for the elaboration. Yes, the client version is also 2.4.1. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] massakam commented on issue #5758: Bump jackson libraries to 2.10.1
massakam commented on issue #5758: Bump jackson libraries to 2.10.1 URL: https://github.com/apache/pulsar/pull/5758#issuecomment-560185408 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] Jennifer88huang commented on issue #5764: [docs] Fix link issue for "Authentication and authorization in Pulsar"
Jennifer88huang commented on issue #5764: [docs] Fix link issue for "Authentication and authorization in Pulsar" URL: https://github.com/apache/pulsar/pull/5764#issuecomment-560183847 run cpp tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #5761: [pulsar-client] Switch partition when a batch is full (in RoundRobinMessageRouter)
codelipenghui commented on issue #5761: [pulsar-client] Switch partition when a batch is full (in RoundRobinMessageRouter) URL: https://github.com/apache/pulsar/pull/5761#issuecomment-560183750 Is a new message router can works well here? the time based message router, the router will switch to the next partition for every time period i think we can’t change the robin behavior, because users is face to the messages, so it’s better to keep robin for each message not robin for batch. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] tuteng commented on issue #5778: Python API Docs are not updated
tuteng commented on issue #5778: Python API Docs are not updated URL: https://github.com/apache/pulsar/issues/5778#issuecomment-560183081 Please try http://pulsar.apache.org/api/python/2.5.0-SNAPSHOT/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #5755: UnAckedMessages admin information not correct
codelipenghui commented on issue #5755: UnAckedMessages admin information not correct URL: https://github.com/apache/pulsar/issues/5755#issuecomment-560181164 @Fomal-haut the the unackMessages represent the messages already dispatched to the consumer but the consumer have not acked, the backlog is the total remaining messages of the subscription. So the messages which not deliver to consumers will not be contains by unAckMessages. The negative number of unAckedMessages looks weird, is your client version also 2.4.1? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] acedrew opened a new issue #5778: Python API Docs are not updated
acedrew opened a new issue #5778: Python API Docs are not updated URL: https://github.com/apache/pulsar/issues/5778 **Describe the bug** Python API docs do not represent the 2.4.1 code that the rest of the site is based on. Specifically, the Client.subscribe method now takes an initial_position argument that is missing from the documentation. It appears that the doc generation pipeline is still broken from #5368 **To Reproduce** https://pulsar.apache.org/api/python/ **Expected behavior** The Python API documentation would show code and examples congruent with the rest of the documentation This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #5765: add Murmur3_32Hash private constructor
codelipenghui commented on issue #5765: add Murmur3_32Hash private constructor URL: https://github.com/apache/pulsar/pull/5765#issuecomment-560175141 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] codelipenghui commented on issue #5776: fix potential NPE and repeated conditional test
codelipenghui commented on issue #5776: fix potential NPE and repeated conditional test URL: https://github.com/apache/pulsar/pull/5776#issuecomment-560175090 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie commented on a change in pull request #5714: Add more info in the error messages
sijie commented on a change in pull request #5714: Add more info in the error
messages
URL: https://github.com/apache/pulsar/pull/5714#discussion_r352358248
##
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java
##
@@ -301,11 +301,17 @@ public UnAckedMessageTracker getUnAckedMessageTracker() {
}).exceptionally(e -> {
log.error("[{}][{}] Failed to unsubscribe: {}", topic,
subscription, e.getCause().getMessage());
setState(State.Ready);
-unsubscribeFuture.completeExceptionally(e.getCause());
+unsubscribeFuture.completeExceptionally(
+new PulsarClientException.WrapperException(
+String.format("[%s][%s] Failed to unsubscribe",
topicName.toString(), subscription),
+
+e.getCause()));
return null;
});
} else {
-unsubscribeFuture.completeExceptionally(new
PulsarClientException("Not connected to broker"));
+unsubscribeFuture.completeExceptionally(
+new PulsarClientException(
Review comment:
"Client is not connected to broker when unsubscribing subscription %s of
topic %s"
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] sijie commented on a change in pull request #5714: Add more info in the error messages
sijie commented on a change in pull request #5714: Add more info in the error
messages
URL: https://github.com/apache/pulsar/pull/5714#discussion_r352359003
##
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java
##
@@ -1466,7 +1480,10 @@ public void seek(long timestamp) throws
PulsarClientException {
seekFuture.complete(null);
}).exceptionally(e -> {
log.error("[{}][{}] Failed to reset subscription: {}", topic,
subscription, e.getCause().getMessage());
-seekFuture.completeExceptionally(e.getCause());
+seekFuture.completeExceptionally(
+new PulsarClientException.WrapperException(
Review comment:
I am not sure WrapperException is the right fix here. because it will change
the client behavior. for example, if a client used to handle exeception A, now
we are throwing a WrapperException of A.
We should reconstruct a A with an updated error message and its stack trace.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] sijie commented on a change in pull request #5714: Add more info in the error messages
sijie commented on a change in pull request #5714: Add more info in the error
messages
URL: https://github.com/apache/pulsar/pull/5714#discussion_r352358161
##
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/BinaryProtoLookupService.java
##
@@ -251,8 +252,10 @@ private void getTopicsUnderNamespace(InetSocketAddress
socketAddress,
}).exceptionally((e) -> {
long nextDelay = Math.min(backoff.next(), remainingTime.get());
if (nextDelay <= 0) {
-topicsFuture.completeExceptionally(new PulsarClientException
-.TimeoutException("Could not getTopicsUnderNamespace
within configured timeout."));
+topicsFuture.completeExceptionally(
+new PulsarClientException.TimeoutException(
+format("[%s] Could not getTopicsUnderNamespace within
configured timeout",
Review comment:
It is much clear to write the error message as a sentence rather than
putting the namespace at the beginning. Thinking from end-users' perspective,
which one is easier to understand?
"Could not get topics of namespace %s within configured timeout"
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] sijie commented on a change in pull request #5714: Add more info in the error messages
sijie commented on a change in pull request #5714: Add more info in the error
messages
URL: https://github.com/apache/pulsar/pull/5714#discussion_r352358827
##
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java
##
@@ -1442,11 +1454,13 @@ public void seek(long timestamp) throws
PulsarClientException {
public CompletableFuture seekAsync(long timestamp) {
if (getState() == State.Closing || getState() == State.Closed) {
return FutureUtil
-.failedFuture(new
PulsarClientException.AlreadyClosedException("Consumer was already closed"));
+.failedFuture(new PulsarClientException.AlreadyClosedException(
+String.format("[%s][%s] Consumer was already closed",
topicName.toString(), subscription)));
}
if (!isConnected()) {
-return FutureUtil.failedFuture(new PulsarClientException("Not
connected to broker"));
+return FutureUtil.failedFuture(new PulsarClientException(
+String.format("[%s][%s] Not connected to broker",
topicName.toString(), subscription)));
Review comment:
Please fix all occurrences that have similar issues.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] sijie commented on a change in pull request #5714: Add more info in the error messages
sijie commented on a change in pull request #5714: Add more info in the error
messages
URL: https://github.com/apache/pulsar/pull/5714#discussion_r352358178
##
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java
##
@@ -301,11 +301,17 @@ public UnAckedMessageTracker getUnAckedMessageTracker() {
}).exceptionally(e -> {
log.error("[{}][{}] Failed to unsubscribe: {}", topic,
subscription, e.getCause().getMessage());
setState(State.Ready);
-unsubscribeFuture.completeExceptionally(e.getCause());
+unsubscribeFuture.completeExceptionally(
+new PulsarClientException.WrapperException(
+String.format("[%s][%s] Failed to unsubscribe",
topicName.toString(), subscription),
Review comment:
"Failed to unsubscribe subscription %s of topic %s"
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] sijie commented on a change in pull request #5714: Add more info in the error messages
sijie commented on a change in pull request #5714: Add more info in the error
messages
URL: https://github.com/apache/pulsar/pull/5714#discussion_r352358429
##
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java
##
@@ -1442,11 +1454,13 @@ public void seek(long timestamp) throws
PulsarClientException {
public CompletableFuture seekAsync(long timestamp) {
if (getState() == State.Closing || getState() == State.Closed) {
return FutureUtil
-.failedFuture(new
PulsarClientException.AlreadyClosedException("Consumer was already closed"));
+.failedFuture(new PulsarClientException.AlreadyClosedException(
+String.format("[%s][%s] Consumer was already closed",
topicName.toString(), subscription)));
}
if (!isConnected()) {
-return FutureUtil.failedFuture(new PulsarClientException("Not
connected to broker"));
+return FutureUtil.failedFuture(new PulsarClientException(
+String.format("[%s][%s] Not connected to broker",
topicName.toString(), subscription)));
Review comment:
This error message doesn't tell what action that this exception is about. It
only tells "client is not connected to a broker". It is not useful at all. You
should include the action in the error message.
"Client is not connected to broker when seeking subscription %s of topic %s
to timestamp %d".
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] sijie commented on a change in pull request #5714: Add more info in the error messages
sijie commented on a change in pull request #5714: Add more info in the error
messages
URL: https://github.com/apache/pulsar/pull/5714#discussion_r352358664
##
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java
##
@@ -1442,11 +1454,13 @@ public void seek(long timestamp) throws
PulsarClientException {
public CompletableFuture seekAsync(long timestamp) {
if (getState() == State.Closing || getState() == State.Closed) {
return FutureUtil
-.failedFuture(new
PulsarClientException.AlreadyClosedException("Consumer was already closed"));
+.failedFuture(new PulsarClientException.AlreadyClosedException(
+String.format("[%s][%s] Consumer was already closed",
topicName.toString(), subscription)));
Review comment:
Same comments as below.
"Consumer %s was already closed when seeking subscription %s of topic %s to
timestamp %d", consumerName, subscription, topicName, timestamp
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] sijie commented on issue #5758: Bump jackson libraries to 2.10.1
sijie commented on issue #5758: Bump jackson libraries to 2.10.1 URL: https://github.com/apache/pulsar/pull/5758#issuecomment-560130418 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie commented on issue #5762: Add the filesystem offload doc
sijie commented on issue #5762: Add the filesystem offload doc URL: https://github.com/apache/pulsar/pull/5762#issuecomment-560130265 @congbobo184 can you check @Anonymitaet 's comments? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie commented on issue #5635: [Issue 5612] Use Reactivestreams client for Mongo Sink
sijie commented on issue #5635: [Issue 5612] Use Reactivestreams client for Mongo Sink URL: https://github.com/apache/pulsar/pull/5635#issuecomment-560130173 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[pulsar] branch master updated: [docs] Fix link issue for "Authentication and authorization in Pulsar" (#5771)
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new f0df253 [docs] Fix link issue for "Authentication and authorization in Pulsar" (#5771) f0df253 is described below commit f0df25308d274cd9358a4bf9195aa4f0244f4d9c Author: belinda-wong <30765197+belinda-w...@users.noreply.github.com> AuthorDate: Mon Dec 2 00:47:20 2019 +0800 [docs] Fix link issue for "Authentication and authorization in Pulsar" (#5771) * Fixes the dead link changed to: see ["Enabling TLS Authentication on Proxies"](security-tls-authentication.md#enable-tls-authentication-on-proxies) --- site2/docs/security-authorization.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/site2/docs/security-authorization.md b/site2/docs/security-authorization.md index 6a1f015..60d4f1a 100644 --- a/site2/docs/security-authorization.md +++ b/site2/docs/security-authorization.md @@ -30,7 +30,7 @@ You can also enable the authorization for the proxy in the proxy configuration f ### Proxy Roles -By default, the broker treats the connection between a proxy and the broker as a normal user connection. The broker authenticates the user as the role configured in `proxy.conf`(see ["Enabling TLS Authentication on Proxies"](security-tls-authentication#on-proxies)). However, when the user connects to the cluster through a proxy, the user rarely requires the authentication. The user expects to be able to interact with the cluster as the role for which they have authenticated with the proxy. +By default, the broker treats the connection between a proxy and the broker as a normal user connection. The broker authenticates the user as the role configured in `proxy.conf`(see ["Enable TLS Authentication on Proxies"](security-tls-authentication.md#enable-tls-authentication-on-proxies)). However, when the user connects to the cluster through a proxy, the user rarely requires the authentication. The user expects to be able to interact with the cluster as the role for which they have [...] Pulsar uses *Proxy roles* to enable the authentication. Proxy roles are specified in the broker configuration file, [`conf/broker.conf`](reference-configuration.md#broker). If a client that is authenticated with a broker is one of its ```proxyRoles```, all requests from that client must also carry information about the role of the client that is authenticated with the proxy. This information is called the *original principle*. If the *original principle* misses, the client is not able to [...]
[GitHub] [pulsar] sijie merged pull request #5771: [docs] Fix link issue for "Authentication and authorization in Pulsar"
sijie merged pull request #5771: [docs] Fix link issue for "Authentication and authorization in Pulsar" URL: https://github.com/apache/pulsar/pull/5771 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] sijie closed issue #5753: [Doc] link for TLS Authentication on Proxies is dead
sijie closed issue #5753: [Doc] link for TLS Authentication on Proxies is dead URL: https://github.com/apache/pulsar/issues/5753 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [pulsar] zhaohaidao commented on a change in pull request #5767: Support batch authorization of partitioned topic
zhaohaidao commented on a change in pull request #5767: Support batch
authorization of partitioned topic
URL: https://github.com/apache/pulsar/pull/5767#discussion_r352337822
##
File path:
pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/PersistentTopicsTest.java
##
@@ -312,4 +316,82 @@ public void testGetPartitionedTopicsList() throws
KeeperException, InterruptedEx
Assert.assertEquals(nonPersistentPartitionedTopics.size(), 1);
Assert.assertEquals(TopicName.get(nonPersistentPartitionedTopics.get(0)).getDomain().value(),
TopicDomain.non_persistent.value());
}
+
+@Test
+public void testGrantNonPartitionedTopic() {
+final String topicName = "non-partitioned-topic";
+persistentTopics.createNonPartitionedTopic(testTenant, testNamespace,
topicName, true);
+String role = "role";
+Set expectActions = new HashSet<>();
+expectActions.add(AuthAction.produce);
+persistentTopics.grantPermissionsOnTopic(testTenant, testNamespace,
topicName, role, expectActions);
+Map> permissions =
persistentTopics.getPermissionsOnTopic(testTenant, testNamespace, topicName);
+Assert.assertEquals(permissions.get(role), expectActions);
+}
+
+@Test
+public void testGrantPartitionedTopic() {
+final String partitionedTopicName = "partitioned-topic";
+final int numPartitions = 5;
+LocalZooKeeperCacheService mockLocalZooKeeperCacheService =
mock(LocalZooKeeperCacheService.class);
+ZooKeeperChildrenCache mockZooKeeperChildrenCache =
mock(ZooKeeperChildrenCache.class);
+
doReturn(mockLocalZooKeeperCacheService).when(pulsar).getLocalZkCacheService();
+
doReturn(mockZooKeeperChildrenCache).when(mockLocalZooKeeperCacheService).managedLedgerListCache();
Review comment:
> you can provide this support in the internalGetPermissionsOnTopic function.
Is it better to create a new api called getPermissionsOnPartitionedTopic?
I understand if I support searching partitioned topic in
internalGetPermissionsOnTopic. The output structure of getPermissionsOnTopic
will be changed to
Map> which will break API compatibility?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] zhaohaidao commented on a change in pull request #5767: Support batch authorization of partitioned topic
zhaohaidao commented on a change in pull request #5767: Support batch
authorization of partitioned topic
URL: https://github.com/apache/pulsar/pull/5767#discussion_r352337822
##
File path:
pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/PersistentTopicsTest.java
##
@@ -312,4 +316,82 @@ public void testGetPartitionedTopicsList() throws
KeeperException, InterruptedEx
Assert.assertEquals(nonPersistentPartitionedTopics.size(), 1);
Assert.assertEquals(TopicName.get(nonPersistentPartitionedTopics.get(0)).getDomain().value(),
TopicDomain.non_persistent.value());
}
+
+@Test
+public void testGrantNonPartitionedTopic() {
+final String topicName = "non-partitioned-topic";
+persistentTopics.createNonPartitionedTopic(testTenant, testNamespace,
topicName, true);
+String role = "role";
+Set expectActions = new HashSet<>();
+expectActions.add(AuthAction.produce);
+persistentTopics.grantPermissionsOnTopic(testTenant, testNamespace,
topicName, role, expectActions);
+Map> permissions =
persistentTopics.getPermissionsOnTopic(testTenant, testNamespace, topicName);
+Assert.assertEquals(permissions.get(role), expectActions);
+}
+
+@Test
+public void testGrantPartitionedTopic() {
+final String partitionedTopicName = "partitioned-topic";
+final int numPartitions = 5;
+LocalZooKeeperCacheService mockLocalZooKeeperCacheService =
mock(LocalZooKeeperCacheService.class);
+ZooKeeperChildrenCache mockZooKeeperChildrenCache =
mock(ZooKeeperChildrenCache.class);
+
doReturn(mockLocalZooKeeperCacheService).when(pulsar).getLocalZkCacheService();
+
doReturn(mockZooKeeperChildrenCache).when(mockLocalZooKeeperCacheService).managedLedgerListCache();
Review comment:
you can provide this support in the internalGetPermissionsOnTopic function.
===
Is it better to create a new api called getPermissionsOnPartitionedTopic?
I understand if I support searching partitioned topic in
internalGetPermissionsOnTopic. The output structure of getPermissionsOnTopic
will be changed to
Map> which will break API compatibility?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] zhaohaidao commented on a change in pull request #5767: Support batch authorization of partitioned topic
zhaohaidao commented on a change in pull request #5767: Support batch
authorization of partitioned topic
URL: https://github.com/apache/pulsar/pull/5767#discussion_r352337039
##
File path:
pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/PersistentTopicsTest.java
##
@@ -312,4 +316,74 @@ public void testGetPartitionedTopicsList() throws
KeeperException, InterruptedEx
Assert.assertEquals(nonPersistentPartitionedTopics.size(), 1);
Assert.assertEquals(TopicName.get(nonPersistentPartitionedTopics.get(0)).getDomain().value(),
TopicDomain.non_persistent.value());
}
+
+@Test
+public void testGrantNonPartitionedTopic() {
+final String topicName = "non-partitioned-topic";
+persistentTopics.createNonPartitionedTopic(testTenant, testNamespace,
topicName, true);
+String role = "role";
+Set expectActions = new HashSet<>();
+expectActions.add(AuthAction.produce);
+persistentTopics.grantPermissionsOnTopic(testTenant, testNamespace,
topicName, role, expectActions);
+Map> permissions =
persistentTopics.getPermissionsOnTopic(testTenant, testNamespace, topicName);
+Assert.assertEquals(permissions.get(role), expectActions);
+}
+
+@Test
+public void testGrantPartitionedTopic() {
+final String partitionedTopicName = "partitioned-topic";
+final int numPartitions = 5;
+persistentTopics.createPartitionedTopic(testTenant, testNamespace,
partitionedTopicName, numPartitions);
+
+String role = "role";
+Set expectActions = new HashSet<>();
+expectActions.add(AuthAction.produce);
+persistentTopics.grantPermissionsOnTopic(testTenant, testNamespace,
partitionedTopicName, role, expectActions);
+Map> permissions =
persistentTopics.getPermissionsOnTopic(testTenant, testNamespace,
+partitionedTopicName);
+Assert.assertEquals(permissions.get(role), expectActions);
+TopicName topicName = TopicName.get(partitionedTopicName);
+for (int i = 0; i < numPartitions; i++) {
+TopicName partition = topicName.getPartition(i);
+Map> partitionPermissions =
persistentTopics.getPermissionsOnTopic(testTenant,
Review comment:
Thanks for reminding. I have fixed failed cases
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] zhaohaidao commented on a change in pull request #5767: Support batch authorization of partitioned topic
zhaohaidao commented on a change in pull request #5767: Support batch
authorization of partitioned topic
URL: https://github.com/apache/pulsar/pull/5767#discussion_r352336995
##
File path:
pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/PersistentTopicsTest.java
##
@@ -312,4 +316,82 @@ public void testGetPartitionedTopicsList() throws
KeeperException, InterruptedEx
Assert.assertEquals(nonPersistentPartitionedTopics.size(), 1);
Assert.assertEquals(TopicName.get(nonPersistentPartitionedTopics.get(0)).getDomain().value(),
TopicDomain.non_persistent.value());
}
+
+@Test
+public void testGrantNonPartitionedTopic() {
+final String topicName = "non-partitioned-topic";
+persistentTopics.createNonPartitionedTopic(testTenant, testNamespace,
topicName, true);
+String role = "role";
+Set expectActions = new HashSet<>();
+expectActions.add(AuthAction.produce);
+persistentTopics.grantPermissionsOnTopic(testTenant, testNamespace,
topicName, role, expectActions);
+Map> permissions =
persistentTopics.getPermissionsOnTopic(testTenant, testNamespace, topicName);
+Assert.assertEquals(permissions.get(role), expectActions);
+}
+
+@Test
+public void testGrantPartitionedTopic() {
+final String partitionedTopicName = "partitioned-topic";
+final int numPartitions = 5;
+LocalZooKeeperCacheService mockLocalZooKeeperCacheService =
mock(LocalZooKeeperCacheService.class);
+ZooKeeperChildrenCache mockZooKeeperChildrenCache =
mock(ZooKeeperChildrenCache.class);
+
doReturn(mockLocalZooKeeperCacheService).when(pulsar).getLocalZkCacheService();
+
doReturn(mockZooKeeperChildrenCache).when(mockLocalZooKeeperCacheService).managedLedgerListCache();
Review comment:
Thanks for the explanation, I understand.
I will open a new pr to support searching partitioned in
**getPermissionsOnTopic**
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] Jennifer88huang commented on issue #5771: [docs] Fix link issue for "Authentication and authorization in Pulsar"
Jennifer88huang commented on issue #5771: [docs] Fix link issue for "Authentication and authorization in Pulsar" URL: https://github.com/apache/pulsar/pull/5771#issuecomment-560076070 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
