[lintian] branch master updated (e11c4ba -> 51761a6)

[Niels Thykier]

This is an automated email from the git hooks/post-receive script.

nthykier pushed a change to branch master
in repository lintian.

  from  e11c4ba   c/r-html-reports: Record processing-errors in the stats 
file
   new  51761a6   c/reporting: Improve handling of packages with errors

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 commands/reporting-lintian-harness.pm | 11 ++-
 commands/reporting-sync-state.pm  |  7 +++
 2 files changed, 17 insertions(+), 1 deletion(-)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] branch master updated (293c897 -> e11c4ba)

[Niels Thykier]

This is an automated email from the git hooks/post-receive script.

nthykier pushed a change to branch master
in repository lintian.

  from  293c897   Remove 
override_dh_auto_test-does-not-check-DEB_BUILD_PROFILES (for now) as there are 
just too many false-positive cases to check. (Closes: #889592)
   new  e11c4ba   c/r-html-reports: Record processing-errors in the stats 
file

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 commands/reporting-html-reports.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] 01/01: c/reporting: Improve handling of packages with errors

[Niels Thykier]

This is an automated email from the git hooks/post-receive script.

nthykier pushed a commit to branch master
in repository lintian.

commit 51761a6f020cc117e8f060ac33b91f615fe2f646
Author: Niels Thykier 
Date:   Mon Feb 5 07:36:39 2018 +

c/reporting: Improve handling of packages with errors

Signed-off-by: Niels Thykier 
---
 commands/reporting-lintian-harness.pm | 11 ++-
 commands/reporting-sync-state.pm  |  7 +++
 2 files changed, 17 insertions(+), 1 deletion(-)

diff --git a/commands/reporting-lintian-harness.pm 
b/commands/reporting-lintian-harness.pm
index 41931e5..b7aa42a 100644
--- a/commands/reporting-lintian-harness.pm
+++ b/commands/reporting-lintian-harness.pm
@@ -414,12 +414,21 @@ sub process_worklist {
 next if not exists($state->{'groups'}{$group_id});
 $group_data = $state->{'groups'}{$group_id};
 $group_data->{'last-processed-by'} = $LINTIAN_VERSION;
+delete($group_data->{'out-of-date'});
+}
+for my $group_id (sort(keys(%errors))) {
+my $group_data;
+# In theory, they can disappear - in practise, that requires
+# an external call to (e.g.) dplint reporting-sync-state.
+next if not exists($state->{'groups'}{$group_id});
 if ($errors{$group_id}) {
 ++$group_data->{'processing-errors'};
+# Set the "last-processed-by" flag so we can clear the
+# error if there is a new version of lintian.
+$group_data->{'last-processed-by'} = $LINTIAN_VERSION;
 } else {
 delete($group_data->{'processing-errors'});
 }
-delete($group_data->{'out-of-date'});
 }
 save_state_cache($OPT{'state-dir'}, $state);
 last if $exit_code;
diff --git a/commands/reporting-sync-state.pm b/commands/reporting-sync-state.pm
index 20f0c82..3e50f05 100644
--- a/commands/reporting-sync-state.pm
+++ b/commands/reporting-sync-state.pm
@@ -300,6 +300,13 @@ sub cleanup_group_state {
 log_debug("Marking ${group_id} as out of date: In backlog")
   if $backlog->{$group_id};
 }
+if (exists($group_data->{'processing-errors'})
+and exists($group_data->{'last-processed-by'})
+and $group_data->{'last-processed-by'} ne $OPT{'desired-version'}){
+log_debug(
+"Clearing error flag for ${group_id}: New version of lintian");
+delete($group_data->{'processing-errors'});
+}
 }
 
 if (not %{$members}) {

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] 01/01: c/r-html-reports: Record processing-errors in the stats file

[Niels Thykier]

This is an automated email from the git hooks/post-receive script.

nthykier pushed a commit to branch master
in repository lintian.

commit e11c4ba68e099d6dd714b9b148e5817d3e59d119
Author: Niels Thykier 
Date:   Mon Feb 5 07:22:03 2018 +

c/r-html-reports: Record processing-errors in the stats file

Signed-off-by: Niels Thykier 
---
 commands/reporting-html-reports.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/commands/reporting-html-reports.pm 
b/commands/reporting-html-reports.pm
index 4f5f959..4259538 100644
--- a/commands/reporting-html-reports.pm
+++ b/commands/reporting-html-reports.pm
@@ -120,7 +120,7 @@ my (%statistics, %tag_statistics);
 my (%by_maint, %by_uploader, %by_tag, %maintainer_table, %delta);
 my @attrs = qw(maintainers source-packages binary-packages udeb-packages
   errors warnings info experimental pedantic overridden groups-known
-  groups-backlog classifications);
+  groups-backlog classifications processing-errors);
 
 sub required_cfg_value {
 my (@keys) = @_;

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

Bug#889628: lintian: False-positive bad-jar-name

[Niels Thykier]

Package: lintian
Version: 2.5.72
Severity: normal

Hi,

Spotted a false-positive for bad-jar-name.

Thunderbird (among other) appears to be using jar files named
"bn-BD.jar" for language packs installed into packages such as
"lightning-l10n-bn-bd".

(Admittedly, the experimental version of thunderbird does not have
this issue).

I suspect we should limit this check to "common directories used for
public java libraries".

Thanks,
~Niels

Bug#889592: lintian: false positive for override_dh_auto_test-does-not-check-DEB_BUILD_PROFILES

[gregor herrmann]

On Mon, 05 Feb 2018 00:10:21 +0100, Mattia Rizzolo wrote:

> > Very quick visual check: All I've seen use dh_auto_test, either with
> > some variables or with some actions before or after.
> If there are actions before or after dh_auto_test then it may still be
> "unsafe":  

Yes, they may, or they may not.

Second cursory visual check:

Mostly `mkdir -p $(BUILDHOME)'.
Some `mv file file.bak' before and the opposite afterwards. A `chmod'
or two of an existing file.

Ok, +/- 2 hardcoded `make test'.
2 hits for over 300 false positives sound like there's room for
improvement.

> I've seen package running `make -C test` before dh_auto_test,
> that one should be skipped if DEB_BUILD_OPTIONS=nocheck.

Ack.

> Or that try to move some test artifact after dh_auto_test: that would
> actually cause a ftbfs if dh_auto_test did nothing.

Yup, I've seen this in other packages.

> The only "safe" cases of command that are fine to run in an
> override_dh_auto_test are : and echo (if not redirected to a file).

Here I disagree. 


Cheers,
gregor

-- 
 .''`.  https://info.comodo.priv.at -- Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
   `-   NP: Tom Waits: Georgia Lee


signature.asc
Description: Digital Signature

Bug#889592: lintian: false positive for override_dh_auto_test-does-not-check-DEB_BUILD_PROFILES

[Chris Lamb]

tags 889592 + pending
thanks

"Fixed" in Git, pending upload:

  
https://anonscm.debian.org/git/lintian/lintian.git/commit/?id=293c897ef968e0f50ac4f48986034aeda57e179d

Ah well, just too many false-positive cases.. I mean, we'd have to start
ignoring ": " comments, as well as detecting the differences between, say:

override_dh_auto_test:
  echo "input" | ./testsuite.sh

and

override_dh_auto_test:
  echo "Not running"

etc. etc. :)


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

Bug#889592: lintian: false positive for override_dh_auto_test-does-not-check-DEB_BUILD_PROFILES

[Mattia Rizzolo]

On Mon, Feb 05, 2018 at 12:03:56AM +0100, gregor herrmann wrote:
> % grep override_dh_auto_test */debian/rules | wc -l
> 321
> 
> Very quick visual check: All I've seen use dh_auto_test, either with
> some variables or with some actions before or after.

If there are actions before or after dh_auto_test then it may still be
"unsafe":  I've seen package running `make -C test` before dh_auto_test,
that one should be skipped if DEB_BUILD_OPTIONS=nocheck.
Or that try to move some test artifact after dh_auto_test: that would
actually cause a ftbfs if dh_auto_test did nothing.
The only "safe" cases of command that are fine to run in an
override_dh_auto_test are : and echo (if not redirected to a file).

-- 
regards,
Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540  .''`.
more about me:  https://mapreri.org : :'  :
Launchpad user: https://launchpad.net/~mapreri  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-


signature.asc
Description: PGP signature

Processed: Re: lintian: false positive for override_dh_auto_test-does-not-check-DEB_BUILD_PROFILES

[Debian Bug Tracking System]

Processing commands for cont...@bugs.debian.org:

> tags 889592 + pending
Bug #889592 [lintian] lintian: false positive for 
override_dh_auto_test-does-not-check-DEB_BUILD_PROFILES
Added tag(s) pending.
> thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
889592: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=889592
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

[lintian] 01/01: Remove override_dh_auto_test-does-not-check-DEB_BUILD_PROFILES (for now) as there are just too many false-positive cases to check. (Closes: #889592)

[Chris Lamb]

This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit 293c897ef968e0f50ac4f48986034aeda57e179d
Author: Chris Lamb 
Date:   Sun Feb 4 23:04:54 2018 +

Remove override_dh_auto_test-does-not-check-DEB_BUILD_PROFILES (for now) as 
there are just too many false-positive cases to check. (Closes: #889592)
---
 checks/rules.desc | 19 ---
 checks/rules.pm   |  9 -
 debian/changelog  |  4 
 .../debian/debian/rules   |  8 
 .../desc  |  5 -
 .../tags  |  0
 .../debian/debian/rules   |  9 -
 .../desc  |  5 -
 .../tags  |  0
 .../debian/debian/rules   |  7 ---
 .../desc  |  5 -
 .../tags  |  1 -
 12 files changed, 4 insertions(+), 68 deletions(-)

diff --git a/checks/rules.desc b/checks/rules.desc
index 9d28c33..4e89148 100644
--- a/checks/rules.desc
+++ b/checks/rules.desc
@@ -337,22 +337,3 @@ Info: The debian/rules file for this package has 
a call to
  .
  Please remove the call and let dpkg-deb(1) select suitable defaults.
 Ref: #829100, dpkg-deb(1)
-
-Tag: override_dh_auto_test-does-not-check-DEB_BUILD_PROFILES
-Severity: wishlist
-Certainty: possible
-Info: The debian/rules file for this package has an
- override_dh_auto_test target that does not appear to
- check DEB_BUILD_PROFILES against nocheck.
- .
- As this check is not automatically performed by debhelper(1), the
- specified testsuite is run regardless of using the nocheck
- build profile.
- .
- Please add a check such as:
- .
-  override_dh_auto_test:
-  ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS)))
-  ./run-upstream-testsuite
-  endif
-Ref: https://wiki.debian.org/BuildProfileSpec#Registered_profile_names
diff --git a/checks/rules.pm b/checks/rules.pm
index b31200a..8f70f7e 100644
--- a/checks/rules.pm
+++ b/checks/rules.pm
@@ -439,15 +439,6 @@ sub run {
 @{$rules_per_target{"override_$cmd"}};
 }
 
-if (my $line = $overridden{'dh_auto_test'}) {
-tag 'override_dh_auto_test-does-not-check-DEB_BUILD_PROFILES',
-  "(line $line)"
-  if $rules_per_target{'override_dh_auto_test'}
-  and none { m/(DEB_BUILD_OPTIONS|nocheck)/ } @conditionals
-  and none { m/\bdh_auto_test\b/ }
-$rules_per_target{'override_dh_auto_test'};
-}
-
 # Make sure that all the required build dependencies are there.  Don't
 # issue missing-build-dependency errors for debhelper, since there's
 # another test that does that and it would just be a duplicate.
diff --git a/debian/changelog b/debian/changelog
index 9d67431..93686e2 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -19,6 +19,10 @@ lintian (2.5.74) UNRELEASED; urgency=medium
 + [CL] Avoid emitting "Can't use an undefined value as an ARRAY
   reference" warnings when debian/patches is a file, not a directory.
   (Closes: #889535)
+  * checks/rules.{desc,pm}:
++ [CL] Remove override_dh_auto_test-does-not-check-DEB_BUILD_PROFILES
+  (for now) as there are just too many false-positive cases to check.
+  (Closes: #889592)
   * checks/scripts.desc:
 + [CL] Improve, elaborate and tidy the long description of the
   maintainer-script-should-not-use-recursive-chown-or-chmod tag.
diff --git 
a/t/tests/rules-dh-auto-test-does-not-check-deb-build-options-empty/debian/debian/rules
 
b/t/tests/rules-dh-auto-test-does-not-check-deb-build-options-empty/debian/debian/rules
deleted file mode 100755
index a205d48..000
--- 
a/t/tests/rules-dh-auto-test-does-not-check-deb-build-options-empty/debian/debian/rules
+++ /dev/null
@@ -1,8 +0,0 @@
-#!/usr/bin/make -f
-
-%:
-   dh $@
-
-# Empty target follows
-override_dh_auto_test:
-   # comment
diff --git 
a/t/tests/rules-dh-auto-test-does-not-check-deb-build-options-empty/desc 
b/t/tests/rules-dh-auto-test-does-not-check-deb-build-options-empty/desc
deleted file mode 100644
index 09f3706..000
--- a/t/tests/rules-dh-auto-test-does-not-check-deb-build-options-empty/desc
+++ /dev/null
@@ -1,5 +0,0 @@
-Testname: rules-dh-auto-test-does-not-check-deb-build-options-empty
-Version: 1.0
-Description: Test for missing checks for DEB_BUILD_PROFILES (empty 
false-positive)
-Test-Against:
- override_dh_auto_test-does-not-check-DEB_BUILD_PROFILES
diff --git 
a/t/tests/rules-dh-auto-test-does-not-check-deb-build-options-empty/tags 
b/t/tests/rules-dh-auto-test-does-not-check-deb-build-options-empty/tags
deleted file mode 100644
index e69de29..000
diff --git 

Bug#889592: lintian: false positive for override_dh_auto_test-does-not-check-DEB_BUILD_PROFILES

[gregor herrmann]

On Sun, 04 Feb 2018 21:29:23 +0100, Mattia Rizzolo wrote:

> https://tracker.debian.org/media/packages/a/autoconf-dickey/rules-2.52%2B20170501-2
> https://tracker.debian.org/media/packages/a/avro-c/rules-1.8.2-1
> Not sure why this is matched, I thought it wouldn't have been:
> |override_dh_auto_test:
> | dh_auto_test --no-parallel
> 
> https://tracker.debian.org/media/packages/libx/libxcb/rules-1.12-1
> Similar to the previous:
> |override_dh_auto_test:
> | dh_auto_test -- VERBOSE=1

This will affect dozens or hundreds of perl packages. [0]

First encounter right now:

I: librole-rest-client-perl source: 
override_dh_auto_test-does-not-check-DEB_BUILD_PROFILES (line 6)

and

% cat debian/rules 
#!/usr/bin/make -f

%:
dh $@

override_dh_auto_test:
http_proxy= dh_auto_test


Emitting this tag when dh_auto_test is contained within override_dh_auto_test
seems not ideal.



Cheers,
gregor

[0] First approximation:

% grep override_dh_auto_test */debian/rules | wc -l
321

Very quick visual check: All I've seen use dh_auto_test, either with
some variables or with some actions before or after.

-- 
 .''`.  https://info.comodo.priv.at -- Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
   `-   NP: Rolling Stones: Lastime


signature.asc
Description: Digital Signature

[lintian] branch master updated (b2f5a40 -> 293c897)

[Chris Lamb]

This is an automated email from the git hooks/post-receive script.

lamby pushed a change to branch master
in repository lintian.

  from  b2f5a40   Do not emit package-does-not-install-examples if we don't 
have any binary packages in our laboratory. (Closes: #889591)
   new  293c897   Remove 
override_dh_auto_test-does-not-check-DEB_BUILD_PROFILES (for now) as there are 
just too many false-positive cases to check. (Closes: #889592)

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 checks/rules.desc | 19 ---
 checks/rules.pm   |  9 -
 debian/changelog  |  4 
 .../debian/debian/rules   |  8 
 .../desc  |  5 -
 .../tags  |  0
 .../debian/debian/rules   |  9 -
 .../desc  |  5 -
 .../tags  |  0
 .../debian/debian/rules   |  7 ---
 .../desc  |  5 -
 .../tags  |  1 -
 12 files changed, 4 insertions(+), 68 deletions(-)
 delete mode 100755 
t/tests/rules-dh-auto-test-does-not-check-deb-build-options-empty/debian/debian/rules
 delete mode 100644 
t/tests/rules-dh-auto-test-does-not-check-deb-build-options-empty/desc
 delete mode 100644 
t/tests/rules-dh-auto-test-does-not-check-deb-build-options-empty/tags
 delete mode 100755 
t/tests/rules-dh-auto-test-does-not-check-deb-build-options-unrel/debian/debian/rules
 delete mode 100644 
t/tests/rules-dh-auto-test-does-not-check-deb-build-options-unrel/desc
 delete mode 100644 
t/tests/rules-dh-auto-test-does-not-check-deb-build-options-unrel/tags
 delete mode 100755 
t/tests/rules-dh-auto-test-does-not-check-deb-build-options/debian/debian/rules
 delete mode 100644 
t/tests/rules-dh-auto-test-does-not-check-deb-build-options/desc
 delete mode 100644 
t/tests/rules-dh-auto-test-does-not-check-deb-build-options/tags

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

Bug#889591: lintian: emits package-does-not-install-examples although all examples are installed

[Chris Lamb]

tags 889591 + pending
thanks

Fixed in Git, pending upload:

  
https://anonscm.debian.org/git/lintian/lintian.git/commit/?id=b2f5a40f1b8a548409a1597ecc61b5f8eab5d27f


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

[lintian] branch master updated (b059a3b -> b2f5a40)

[Chris Lamb]

This is an automated email from the git hooks/post-receive script.

lamby pushed a change to branch master
in repository lintian.

  from  b059a3b   Tidy changelog entry.
   new  dcef40c   Factor out call to _ships_examples to avoid excessive 
looping over $sorted_index.
   new  b2f5a40   Do not emit package-does-not-install-examples if we don't 
have any binary packages in our laboratory. (Closes: #889591)

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 checks/cruft.pm  | 5 +++--
 debian/changelog | 4 
 2 files changed, 7 insertions(+), 2 deletions(-)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] 01/02: Factor out call to _ships_examples to avoid excessive looping over $sorted_index.

[Chris Lamb]

This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit dcef40cc19184fee46db85f1378bff679e2bad25
Author: Chris Lamb 
Date:   Sun Feb 4 22:45:37 2018 +

Factor out call to _ships_examples to avoid excessive looping over 
$sorted_index.
---
 checks/cruft.pm  | 3 ++-
 debian/changelog | 2 ++
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/checks/cruft.pm b/checks/cruft.pm
index 7ebf4bf..2a12c8f 100644
--- a/checks/cruft.pm
+++ b/checks/cruft.pm
@@ -571,6 +571,7 @@ sub find_cruft {
 my ($source_pkg, $info, $warned, $ltinbd, $group) = @_;
 my $prefix = ($info->native ? 'diff-contains' : 'source-contains');
 my @worklist;
+my $ships_examples = _ships_examples($group);
 
 # start with the top-level dirs
 push(@worklist, $info->index('')->children);
@@ -609,7 +610,7 @@ sub find_cruft {
 }
 }
 tag 'package-does-not-install-examples', $entry
-  if $basename eq 'examples' and not _ships_examples($group);
+  if $basename eq 'examples' and not $ships_examples;
 }
 
 push(@worklist, $entry->children);
diff --git a/debian/changelog b/debian/changelog
index 472f81f..dde7387 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -4,6 +4,8 @@ lintian (2.5.74) UNRELEASED; urgency=medium
 
   * checks/cruft.desc:
 + [BR] Check for wasm files.  (Closes: #889102)
++ [CL] Factor out call to _ships_examples to avoid excessive looping
+  over $sorted_index.
   * checks/fields.pm:
 + [CL] Avoid false positives when checking binary packages depending on
   toolchain packages by ignoring packages starting with "dh-" or ending

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] 01/01: Tidy changelog entry.

[Chris Lamb]

This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit b059a3b4eaf2beb0463703b91d777b3f28166d03
Author: Chris Lamb 
Date:   Sun Feb 4 22:31:55 2018 +

Tidy changelog entry.
---
 debian/changelog | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/debian/changelog b/debian/changelog
index 16c6f6d..472f81f 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -21,12 +21,12 @@ lintian (2.5.74) UNRELEASED; urgency=medium
   Heavily based on a patch by Daniel Kahn Gillmor - thanks!
   (Closes: #889489)

-  * data/files/privacy-breaker-fragments:
-+ [BR] Detects new fragments for google cse
-
   * commands/reporting-{html-reports,lintian-harness}.pm:
 + [NT] Register packages that fail during archive wide processing.
 
+  * data/files/privacy-breaker-fragments:
++ [BR] Detect new fragments for Google CSE.
+
   * lib/Lintian/Util.pm:
 + [NT] Give lower processing priority to packages that repeatedly
   trigger errors during archive-wide processing.

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] branch master updated (918e926 -> b059a3b)

[Chris Lamb]

This is an automated email from the git hooks/post-receive script.

lamby pushed a change to branch master
in repository lintian.

  from  918e926   Improve debugging for tag/url
   new  b059a3b   Tidy changelog entry.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 debian/changelog | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] branch master updated (470de0e -> 918e926)

[Bastien Roucariès]

This is an automated email from the git hooks/post-receive script.

rouca pushed a change to branch master
in repository lintian.

  from  470de0e   d/control: Add comment related to the 
libfile-basedir-perl dependency
   new  aaf6a73   Detect new fragment for google cse
   new  34a907c   Add debug for javascript fragment
   new  918e926   Improve debugging for tag/url

The 3 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 checks/files.pm|   7 +-
 data/files/privacy-breaker-fragments   |   7 +-
 debian/changelog   |   5 +
 .../debian/src/privacy-breach-google-cse/search.js |  14 +++
 t/tests/files-privacybreach/tags   | 111 +++--
 5 files changed, 83 insertions(+), 61 deletions(-)
 create mode 100644 
t/tests/files-privacybreach/debian/src/privacy-breach-google-cse/search.js

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] 03/03: Improve debugging for tag/url

[Bastien Roucariès]

This is an automated email from the git hooks/post-receive script.

rouca pushed a commit to branch master
in repository lintian.

commit 918e9265add984f6bb1668590e8a91e9eb0b37e5
Author: Bastien ROUCARIÈS 
Date:   Sun Feb 4 22:46:02 2018 +0100

Improve debugging for tag/url
---
 checks/files.pm  |  2 +-
 t/tests/files-privacybreach/tags | 50 
 2 files changed, 26 insertions(+), 26 deletions(-)

diff --git a/checks/files.pm b/checks/files.pm
index 51ef64d..a6e8edd 100644
--- a/checks/files.pm
+++ b/checks/files.pm
@@ -2104,7 +2104,7 @@ sub _check_tag_url_privacy_breach {
 
 # generic case
 unless (exists $privacybreachhash->{'tag-generic-'.$website}){
-tag 'privacy-breach-generic', $file, "($url)";
+tag 'privacy-breach-generic', $file, "[$fulltag] ($url)";
 $privacybreachhash->{'tag-generic-'.$website} = 1;
 }
 return;
diff --git a/t/tests/files-privacybreach/tags b/t/tests/files-privacybreach/tags
index 817bbd1..cfcf319 100644
--- a/t/tests/files-privacybreach/tags
+++ b/t/tests/files-privacybreach/tags
@@ -54,28 +54,28 @@ E: files-privacybreach: privacy-breach-uses-embedded-file 
usr/share/files-privac
 E: files-privacybreach: privacy-breach-uses-embedded-file 
usr/share/files-privacy-breach/privacy-breach-may-use-debian-package/libjs-openlayers.html
 You may use the libjs-openlayers package. 
(http://openlayers.org/api/openlayers.js)
 E: files-privacybreach: privacy-breach-uses-embedded-file 
usr/share/files-privacy-breach/privacy-breach-may-use-debian-package/libjs-prototype.html
 You may use the libjs-prototype package. 
(https://ajax.googleapis.com/ajax/libs/prototype/1.7.0.0/prototype.js)
 E: files-privacybreach: privacy-breach-w3c-valid-html 
usr/share/files-privacy-breach/privacy-breach-w3c-valid-html/htmlvalid.html 
(http://www.w3.org/icons/valid-xhtml10)
-W: files-privacybreach: privacy-breach-generic 
usr/share/files-privacy-breach/privacy-breach-generic/applet.html 
(//1984.os/trackme2)
-W: files-privacybreach: privacy-breach-generic 
usr/share/files-privacy-breach/privacy-breach-generic/applet.html 
(http://1984.os/trackme)
-W: files-privacybreach: privacy-breach-generic 
usr/share/files-privacy-breach/privacy-breach-generic/audio.html 
(ftp://1984.os/tuxistrackingme.ogg)
-W: files-privacybreach: privacy-breach-generic 
usr/share/files-privacy-breach/privacy-breach-generic/audiotrack.html 
(http://1984.os/notracking.vtt)
-W: files-privacybreach: privacy-breach-generic 
usr/share/files-privacy-breach/privacy-breach-generic/div.html 
(//trackme.1984/index-3.html)
-W: files-privacybreach: privacy-breach-generic 
usr/share/files-privacy-breach/privacy-breach-generic/div.html 
(http://trackme.1984/index-2.html)
-W: files-privacybreach: privacy-breach-generic 
usr/share/files-privacy-breach/privacy-breach-generic/embed.html 
(//1984.os/givemydata2.swf)
-W: files-privacybreach: privacy-breach-generic 
usr/share/files-privacy-breach/privacy-breach-generic/embed.html 
(http://1984.os/givemydata.swf)
-W: files-privacybreach: privacy-breach-generic 
usr/share/files-privacy-breach/privacy-breach-generic/externalimg.xml 
(http://1984.ow/bigbrotheriswatchingyou.png)
-W: files-privacybreach: privacy-breach-generic 
usr/share/files-privacy-breach/privacy-breach-generic/frame.html 
(http://1984.os/trackme_frame_c.htm)
-W: files-privacybreach: privacy-breach-generic 
usr/share/files-privacy-breach/privacy-breach-generic/genericwebsite.html 
(http://www.example.com/trackme.js)
-W: files-privacybreach: privacy-breach-generic 
usr/share/files-privacy-breach/privacy-breach-generic/googlefontapi.html 
(http://fonts.googleapis.com/css?family=open+sans)
-W: files-privacybreach: privacy-breach-generic 
usr/share/files-privacy-breach/privacy-breach-generic/iframe.html 
(http://1984.ow/bigbrotheriswatchingyou.html)
-W: files-privacybreach: privacy-breach-generic 
usr/share/files-privacy-breach/privacy-breach-generic/import.css 
(http://1984.wo/importtracking.css)
-W: files-privacybreach: privacy-breach-generic 
usr/share/files-privacy-breach/privacy-breach-generic/importcss.html 
(http://trackme.css/track.css)
-W: files-privacybreach: privacy-breach-generic 
usr/share/files-privacy-breach/privacy-breach-generic/input.html 
(http://1984.os/hiddentrackme.png)
-W: files-privacybreach: privacy-breach-generic 
usr/share/files-privacy-breach/privacy-breach-generic/link.xml 
(http://1984.org/style.css)
-W: files-privacybreach: privacy-breach-generic 
usr/share/files-privacy-breach/privacy-breach-generic/object.html 
(https://1984.os/hellotrackme.swf)
-W: files-privacybreach: privacy-breach-generic 
usr/share/files-privacy-breach/privacy-breach-generic/source.html 
(https://1984.os/tracking.mp3)
-W: files-privacybreach: privacy-breach-generic 
usr/share/files-privacy-breach/privacy-breach-generic/track.html 
(http://1984.os/notracking.vtt)
-W: files-privacybreach: privacy-breach-generic 

[lintian] 01/03: Detect new fragment for google cse

[Bastien Roucariès]

This is an automated email from the git hooks/post-receive script.

rouca pushed a commit to branch master
in repository lintian.

commit aaf6a73f04718e61f56fbc79b4ec6613ec4c2078
Author: Bastien ROUCARIÈS 
Date:   Sun Feb 4 22:36:55 2018 +0100

Detect new fragment for google cse

Signed-off-by: Bastien ROUCARIÈS 
---
 data/files/privacy-breaker-fragments   |  7 ---
 debian/changelog   |  3 +++
 .../debian/src/privacy-breach-google-cse/search.js | 14 ++
 t/tests/files-privacybreach/tags   |  1 +
 4 files changed, 22 insertions(+), 3 deletions(-)

diff --git a/data/files/privacy-breaker-fragments 
b/data/files/privacy-breaker-fragments
index 6412c19..2a329d0 100644
--- a/data/files/privacy-breaker-fragments
+++ b/data/files/privacy-breaker-fragments
@@ -19,11 +19,12 @@ customsearchcontrol~~ 
google\.search\.customsearchcontrol\s*\(\s*'
 google.load~~ google\.load\s*\(\s*'search' 
~~ 
privacy-breach-google-cse
 customsearchengine ~~  
~~ 
privacy-breach-google-cse
 partner-pub~~ value\s*=\s*"partner-pub-\d+:?\d+"   
~~ 
privacy-breach-google-cse
+cse.js ~~ //www[.]google[.]com/cse/cse[.]js\?cx[=] 
~~ 
privacy-breach-google-cse
 plusone~~ 
(?:
  ~~ privacy-breach-facebook
 piwik  ~~ 
(?:piwik_url\s*=|[\'"]piwik\.js[\'\"]|end\s+piwik\h+(?:tag|code)|[\'\"]settrackerurl[\'\"])
  ~~ privacy-breach-piwik
 pkbaseurl  ~~ pkbaseurl\s*=
~~ 
privacy-breach-piwik
diff --git a/debian/changelog b/debian/changelog
index 1a2a138..7856ee0 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -18,6 +18,9 @@ lintian (2.5.74) UNRELEASED; urgency=medium
   maintainer-script-should-not-use-recursive-chown-or-chmod tag.
   Heavily based on a patch by Daniel Kahn Gillmor - thanks!
   (Closes: #889489)
+   
+  * data/files/privacy-breaker-fragments:
++ [BR] Detects new fragments for google cse
 
   * commands/reporting-{html-reports,lintian-harness}.pm:
 + [NT] Register packages that fail during archive wide processing.
diff --git 
a/t/tests/files-privacybreach/debian/src/privacy-breach-google-cse/search.js 
b/t/tests/files-privacybreach/debian/src/privacy-breach-google-cse/search.js
new file mode 100644
index 000..001a08b
--- /dev/null
+++ b/t/tests/files-privacybreach/debian/src/privacy-breach-google-cse/search.js
@@ -0,0 +1,14 @@
+
+
+
+  (function() {
+var cx = '006134137889097767902:turn9fku95u';
+var gcse = document.createElement('offline-script');
+gcse.type = 'text/javascript';
+gcse.async = true;
+gcse.src = (document.location.protocol == 'https:' ? 'https:' : 'http:') +
+'//www.google.com/cse/cse.js?cx=' + cx;
+var s = 

Bug#889592: lintian: false positive for override_dh_auto_test-does-not-check-DEB_BUILD_PROFILES

[Mattia Rizzolo]

Package: lintian
Version: 2.5.73

On Sun, Feb 04, 2018 at 03:36:45PM +0530, Chris Lamb wrote:
> Some results coming in:
> 
>   
> https://lintian.debian.org/tags/override_dh_auto_test-does-not-check-DEB_BUILD_PROFILES.html
> 
> Thoughts?

Randomly checked few packages and they were mostly all fpos:

https://tracker.debian.org/media/packages/a/aff4/rules-0.24.post1-3
Ok, this is crazy, he deserves what he got for being too clever with
make :D

https://tracker.debian.org/media/packages/a/autoconf-dickey/rules-2.52%2B20170501-2
https://tracker.debian.org/media/packages/a/avro-c/rules-1.8.2-1
Not sure why this is matched, I thought it wouldn't have been:
|override_dh_auto_test:
|   dh_auto_test --no-parallel

https://tracker.debian.org/media/packages/libx/libxcb/rules-1.12-1
Similar to the previous:
|override_dh_auto_test:
|   dh_auto_test -- VERBOSE=1

https://tracker.debian.org/media/packages/o/osm2pgsql/rules-0.94.0%2Bds-1
Also similar:
|override_dh_auto_test:
|   dh_auto_test || echo "Ignoring test failures"

https://tracker.debian.org/media/packages/a/akonadi-calendar-tools/rules-417.08.3-2
https://tracker.debian.org/media/packages/b/biosig4c%2B%2B/rules-1.4.1-1.1
This seems to be a recurring pattern:
|override_dh_auto_test:
|   # Disable dh_auto_test at build time
|   :

https://tracker.debian.org/media/packages/b/bibletime/rules-2.11.1-1
I believe this is going the be another recurring pattern:
|override_dh_auto_test:
|   echo "Skip dh_auto_test because the tests rely on a display which is 
not there"


Whilst true that the last two technically should deal with
DEB_BUILD_OPTIONS=nocheck, I believe running a single `:` or a single
`echo` should be considered fine.


In my random pick, I saw this real positive:
https://tracker.debian.org/media/packages/l/lua-lgi/rules-0.9.2-1
|override_dh_auto_test:
|   make -C tests all
|   GI_TYPELIB_PATH=tests LD_LIBRARY_PATH=tests xvfb-run dh_auto_test
I recommend to add a similar thing to the testsuite, as this one is
*also* calling dh_auto_test, but it should still handle
DEB_BUILD_OPTIONS=nocheck by hand.

-- 
regards,
Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540  .''`.
more about me:  https://mapreri.org : :'  :
Launchpad user: https://launchpad.net/~mapreri  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-


signature.asc
Description: PGP signature

Bug#889591: lintian: emits package-does-not-install-examples although all examples are installed

[Sebastian Ramacher]

Package: lintian
Version: 2.5.73
Severity: normal

lintian reports

P: libbluray source: package-does-not-install-examples src/examples/

on libbluray. However, all files from src/examples are installed in
libbluray-doc:

$ ls src/examples
bd_info.c  bdsplice.c  index_dump.c  libbluray_test.c  list_titles.c  
sound_dump.c

$ cat debian/libbluray-doc.examples
src/examples/*.c

Cheers


-- System Information:
Debian Release: buster/sid
  APT prefers unstable-debug
  APT policy: (650, 'unstable-debug'), (650, 'unstable'), (601, 'testing'), 
(600, 'experimental-debug'), (600, 'experimental'), (500, 'testing-debug')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.14.0-3-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8), LANGUAGE=en_US:en 
(charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages lintian depends on:
ii  binutils  2.30-1
ii  bzip2 1.0.6-8.1
ii  diffstat  1.61-1+b1
ii  dpkg  1.19.0.5
ii  file  1:5.32-1
ii  gettext   0.19.8.1-4
ii  intltool-debian   0.35.0+20060710.4
ii  libapt-pkg-perl   0.1.33
ii  libarchive-zip-perl   1.60-1
ii  libclass-accessor-perl0.51-1
ii  libclone-perl 0.39-1
ii  libdpkg-perl  1.19.0.5
ii  libemail-valid-perl   1.202-1
ii  libfile-basedir-perl  0.07-1
ii  libipc-run-perl   0.96-1
ii  liblist-moreutils-perl0.416-1+b3
ii  libparse-debianchangelog-perl 1.2.0-12
ii  libperl5.26 [libdigest-sha-perl]  5.26.1-4+b1
ii  libtext-levenshtein-perl  0.13-1
ii  libtimedate-perl  2.3000-2
ii  liburi-perl   1.73-1
ii  libxml-simple-perl2.24-1
ii  libyaml-libyaml-perl  0.69+repack-1
ii  man-db2.7.6.1-4+b1
ii  patchutils0.3.4-2
ii  perl  5.26.1-4+b1
ii  t1utils   1.41-2
ii  xz-utils  5.2.2-1.3

Versions of packages lintian recommends:
pn  libperlio-gzip-perl  

Versions of packages lintian suggests:
pn  binutils-multiarch 
ii  dpkg-dev   1.19.0.5
ii  libhtml-parser-perl3.72-3+b2
ii  libtext-template-perl  1.47-1

-- no debconf information

-- 
Sebastian Ramacher


signature.asc
Description: PGP signature

Bug#889486: Please check for packages named "dh-*" in binary-package-depends-on-toolchain-package

[Josh Triplett]

On Sun, Feb 04, 2018 at 02:28:35PM +0530, Chris Lamb wrote:
> Thanks. :)  Fixed in Git, pending upload:
> 
>   
> https://anonscm.debian.org/git/lintian/lintian.git/commit/?id=f8d52f6db1309feb076c938923518e7e323e46d8

Thanks!

- Josh Triplett

[lintian] branch master updated (20e91e8 -> 470de0e)

[Niels Thykier]

This is an automated email from the git hooks/post-receive script.

nthykier pushed a change to branch master
in repository lintian.

  from  20e91e8   d/changelog: Document the latest changes
   new  0a9f1cc   c/r-lintian-harness: Add missing assignment
   new  470de0e   d/control: Add comment related to the 
libfile-basedir-perl dependency

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 commands/reporting-lintian-harness.pm | 2 +-
 debian/control| 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] 02/02: d/control: Add comment related to the libfile-basedir-perl dependency

[Niels Thykier]

This is an automated email from the git hooks/post-receive script.

nthykier pushed a commit to branch master
in repository lintian.

commit 470de0eb3579fa35fbd3a1f3364de90bdf3a7390
Author: Niels Thykier 
Date:   Sun Feb 4 12:43:06 2018 +

d/control: Add comment related to the libfile-basedir-perl dependency

Signed-off-by: Niels Thykier 
---
 debian/control | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/debian/control b/debian/control
index f65ec8b..8bdf463 100644
--- a/debian/control
+++ b/debian/control
@@ -93,6 +93,8 @@ Depends: binutils,
  libdigest-sha-perl,
  libdpkg-perl,
  libemail-valid-perl,
+# libfile-basedir-perl is deliberately *not* installed on our archive-wide
+# processing host
  libfile-basedir-perl,
  libipc-run-perl,
  liblist-moreutils-perl,

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] 01/02: c/r-lintian-harness: Add missing assignment

[Niels Thykier]

This is an automated email from the git hooks/post-receive script.

nthykier pushed a commit to branch master
in repository lintian.

commit 0a9f1cc70c078bac97001e6ecd4b7b0e7eba0423
Author: Niels Thykier 
Date:   Sun Feb 4 12:42:49 2018 +

c/r-lintian-harness: Add missing assignment

Signed-off-by: Niels Thykier 
---
 commands/reporting-lintian-harness.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/commands/reporting-lintian-harness.pm 
b/commands/reporting-lintian-harness.pm
index d107687..41931e5 100644
--- a/commands/reporting-lintian-harness.pm
+++ b/commands/reporting-lintian-harness.pm
@@ -349,7 +349,7 @@ sub process_worklist {
 $processed{$group_id} = 1;
 # We ignore errors if we sent lintian a signal to avoid
 # *some* false-positives.
-$errors{$group_id} if not $signalled_lintian;
+$errors{$group_id} = 1 if not $signalled_lintian;
 } elsif ($line =~ m/^ack-signal (SIG\S+)$/) {
 my $signal = $1;
 log_msg(

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[Debian RT] Please update the set of installed packages for lintian.d.o

[Niels Thykier]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512

Hi,

Please apply attached patches that updates the lintian.d.o metapackage.

The first patch is a bit noisy but I hope it will make it easier for
us to keep the dependency list in sync.  Indeed, it helped me to
identify 4 redundant packages and 1 missing packages.

The second patch adds scour, which I intend to use to optimize the SVG
files on lintian.d.o.  With that tool, we can expect to save about 40%
on the disk usage of the SVGs (~11MB in total out of 31MB) and it will
hopefully also reduce the bandwidth used as well.

Thanks,
~Niels
-BEGIN PGP SIGNATURE-

iQIzBAEBCgAdFiEEsxMaRR2/33ygW0GXBUu7n32AZEIFAlp2/0QACgkQBUu7n32A
ZELdnA/+NWnRIAzM22md6fU9RuXiWpypWKvIwBTSDBpwecLFisGYksgdM1Mta5dg
tHg0e9YiPmFfhz9JkuGxWtBaNXfpZVZuEdQtL4EQJs6DNclfSgs4xBqS7v77u0A1
dA+4hNNl9GZZbTK7bQtNC3X+TkEYN7RM69VM0DSWSdqnyMuTMrh/Y08g85SEl+iK
GLpHjKUNX+zFrHKLf/lrRYwC+9A65cIJAVtytblEUTEt3yp00F+OqzulmkWmCWAy
9xc0eIx4JwONf3RRwva+dsjXKfFwNkl1r0lz8oeTiAN/VgfGY5BVRUCT2AzyRML4
IRS2Nj12x5JoufTo1YJPEejAdcjQTDkdSj4gZOevgyFkMMdA/hGkcsvqq/OE9/nP
uCBhz13bsjik1RZMyoTEGqYNnXeSQkbWIemvjhbpcvoP21T9fd/Dg7iOH603YIXD
9j3B32GOQfa+HGItrb43ZVDZT6KR6nqHOBudOjRSykkgR5FvRzDZ9HP1rAJ4QYzE
yRqlioYiUxx+sK8SeYmPRvyZmvNgCkicqc5KhONEaXBQq+50j4YVdmT5hrF4OwBC
o7gmYiqfHaB1jTnICrj047gM4vjk2q+sCaPZu1DN8t3ERX2VSSq654g12mG76AFt
e3PbOJ3M2PbCWMYU5sJ+xNIzYfq0V02Zq6PO301UfGs8tU3yGlA=
=pWSf
-END PGP SIGNATURE-
From 21f96310a7c62b4924632a21a22a5a8c9ef035ba Mon Sep 17 00:00:00 2001
From: Niels Thykier 
Date: Sun, 4 Feb 2018 12:26:50 +
Subject: [PATCH 1/2] lintian.d.o: Reorder and sync dependencies

Group the dependencies so it is easier to tell *why* lintian.d.o needs
a particular package.  Going through this list also found that four of
the dependencies should now be obsolete and we were missing xz-utils.

Signed-off-by: Niels Thykier 
---
 debian/changelog |  6 ++
 debian/control   | 23 +++
 2 files changed, 17 insertions(+), 12 deletions(-)

diff --git a/debian/changelog b/debian/changelog
index 4ecffa1..f66bff0 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -22,6 +22,12 @@ debian.org (65) UNRELEASED; urgency=medium
 
   [ Niels Thykier ]
   * release.debian.org: Add python3-sphinx
+  * lintian.debian.org: Reorder and sync dependency list:
+- fakeroot
+- locales
+- perl (>= 5.14~) | libautodie-perl (>= 2.10~)
+- unzip
++ xz-utils
 
   [ Julien Cristau ]
   * ftp-master.d.o:
diff --git a/debian/control b/debian/control
index 168d2d5..477a4e3 100644
--- a/debian/control
+++ b/debian/control
@@ -729,16 +729,15 @@ Description: metapackages for women.debian.org dependencies
 
 Package: debian.org-lintian.debian.org
 Architecture: all
-Depends:   binutils,
+Depends:
+# lintian's runtime dependencies
+	binutils,
 	binutils-multiarch,
 	bzip2,
 	diffstat,
 	dpkg-dev,
-	debhelper,
-	fakeroot,
 	file,
 	gettext,
-	gnuplot-nox | gnuplot,
 	intltool-debian,
 	libapt-pkg-perl,
 	libarchive-zip-perl,
@@ -753,22 +752,22 @@ Depends:   binutils,
 	liblist-moreutils-perl,
 	libparse-debianchangelog-perl,
 	libperlio-gzip-perl,
-	libtimedate-perl,
 	libtext-levenshtein-perl,
-	libtext-template-perl,
+	libtimedate-perl,
 	liburi-perl,
 	libyaml-libyaml-perl,
 	libxml-simple-perl,
-	locales,
 	man-db,
 	perl,
-	perl (>= 5.14~) | libautodie-perl (>= 2.10~),
 	t1utils,
-	unzip
-	,
+	xz-utils,
+# Needed for the "clean" + "rebuild-lintian.debian.org" targets (beyond the above)
+	debhelper,
 	docbook-utils,
-	docbook-xml
-	,
+	docbook-xml,
+# Needed for the reporting framework (beyond the above)
+	gnuplot-nox | gnuplot,
+	libtext-template-perl,
 Description: metapackages for lintian.debian.org dependencies
  This package depends on everything that is needed for lintian.debian.org.
 
-- 
2.15.1

From f8b9ec65072e5297d34a4be4222ae105705c1258 Mon Sep 17 00:00:00 2001
From: Niels Thykier 
Date: Sun, 4 Feb 2018 12:29:59 +
Subject: [PATCH 2/2] lintian.d.o: Add scour dependencies to optimize generated
 svg files

Add scour dependency to optimize the generated svg files on
lintian.d.o.  Quick tests suggests that the files can be easily be
reduced by about 40% with scour.

The "scour | python-scour (<< 0.36-2~)" dependency is to be forward
compatible with buster, where the scour binary moves to its own
"scour" package (from python-scour).

Signed-off-by: Niels Thykier 
---
 debian/changelog | 3 ++-
 debian/control   | 1 +
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/debian/changelog b/debian/changelog
index f66bff0..b078476 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -22,11 +22,12 @@ debian.org (65) UNRELEASED; urgency=medium
 
   [ Niels Thykier ]
   * release.debian.org: Add python3-sphinx
-  * lintian.debian.org: Reorder and sync dependency list:
+  * lintian.debian.org: Reorder and update dependency list:
 - fakeroot
 - locales
 - perl (>= 5.14~) | libautodie-perl 

[lintian] branch master updated (b2aae60 -> 20e91e8)

[Niels Thykier]

This is an automated email from the git hooks/post-receive script.

nthykier pushed a change to branch master
in repository lintian.

  from  b2aae60   Ignore packages ending with "-source" too.
   new  ca764b1   c/r-lintian-harness: Record processing errors
   new  cd1fbfe   c/r-html-reports: Show number of groups with processing 
errors
   new  8fd2653   r/t/maintainer.tmpl: Add a distinct status for incomplete 
reports
   new  83455a6   L::Util: Make find_backlog penalitize packages with 
repeated errors
   new  20e91e8   d/changelog: Document the latest changes

The 5 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 commands/reporting-html-reports.pm|  7 +++
 commands/reporting-lintian-harness.pm | 12 +++-
 debian/changelog  | 14 ++
 lib/Lintian/Util.pm   | 11 ++-
 reporting/templates/index.tmpl|  1 +
 reporting/templates/lintian.css.tmpl  |  4 
 reporting/templates/maintainer.tmpl   |  2 ++
 7 files changed, 49 insertions(+), 2 deletions(-)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] 05/05: d/changelog: Document the latest changes

[Niels Thykier]

This is an automated email from the git hooks/post-receive script.

nthykier pushed a commit to branch master
in repository lintian.

commit 20e91e84903388ae186f83e1d2c56f91614a8f2f
Author: Niels Thykier 
Date:   Sun Feb 4 11:26:01 2018 +

d/changelog: Document the latest changes

Signed-off-by: Niels Thykier 
---
 debian/changelog | 14 ++
 1 file changed, 14 insertions(+)

diff --git a/debian/changelog b/debian/changelog
index 6f3d160..1a2a138 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -19,6 +19,20 @@ lintian (2.5.74) UNRELEASED; urgency=medium
   Heavily based on a patch by Daniel Kahn Gillmor - thanks!
   (Closes: #889489)
 
+  * commands/reporting-{html-reports,lintian-harness}.pm:
++ [NT] Register packages that fail during archive wide processing.
+
+  * lib/Lintian/Util.pm:
++ [NT] Give lower processing priority to packages that repeatedly
+  trigger errors during archive-wide processing.
+
+  * reporting/templates/index.tmpl:
++ [NT] Display summary of how many groups had errors during their
+  last processing.
+  * reporting/templates/{lintian.css,maintainer}.tmpl:
++ [NT] Use a distinct error status instead of "Outdated" for
+  packages with errors during their last processing.
+
  -- Chris Lamb   Sat, 03 Feb 2018 10:51:52 +
 
 lintian (2.5.73) unstable; urgency=medium

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] 04/05: L::Util: Make find_backlog penalitize packages with repeated errors

[Niels Thykier]

This is an automated email from the git hooks/post-receive script.

nthykier pushed a commit to branch master
in repository lintian.

commit 83455a675cb86cd99da43cb24c217c2ffd91557f
Author: Niels Thykier 
Date:   Sun Feb 4 10:17:29 2018 +

L::Util: Make find_backlog penalitize packages with repeated errors

Signed-off-by: Niels Thykier 
---
 lib/Lintian/Util.pm | 11 ++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/lib/Lintian/Util.pm b/lib/Lintian/Util.pm
index b89396c..f2eafd0 100644
--- a/lib/Lintian/Util.pm
+++ b/lib/Lintian/Util.pm
@@ -1720,11 +1720,19 @@ gcc-5 + gcc-5-cross + gcc-6 + gcc-6-cross).
 
 sub find_backlog {
 my ($lintian_version, $state) = @_;
-my (@backlog, %by_version);
+my (@backlog, %by_version, @low_priority);
 for my $group_id (keys(%{$state->{'groups'}})) {
 my $last_version = '0';
 my $group_data = $state->{'groups'}{$group_id};
 my $is_out_of_date;
+if (exists($group_data->{'processing-errors'})
+and $group_data->{'processing-errors'} > 2) {
+# To avoid possible "starvation", we will give lower priority
+# to packages that repeatedly fail.  They will be retried as
+# the backlog is cleared.
+push(@low_priority, $group_id);
+next;
+}
 if (exists($group_data->{'out-of-date'})) {
 $is_out_of_date = $group_data->{'out-of-date'};
 }
@@ -1738,6 +1746,7 @@ sub find_backlog {
 for my $v (sort(versions_comparator keys(%by_version))) {
 push(@backlog, shuffle(@{$by_version{$v}}));
 }
+push(@backlog, shuffle(@low_priority)) if @low_priority;
 return @backlog;
 }
 

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] 03/05: r/t/maintainer.tmpl: Add a distinct status for incomplete reports

[Niels Thykier]

This is an automated email from the git hooks/post-receive script.

nthykier pushed a commit to branch master
in repository lintian.

commit 8fd2653d2f631171718798e595b90262dfd156c0
Author: Niels Thykier 
Date:   Sun Feb 4 09:47:49 2018 +

r/t/maintainer.tmpl: Add a distinct status for incomplete reports

Signed-off-by: Niels Thykier 
---
 reporting/templates/lintian.css.tmpl | 4 
 reporting/templates/maintainer.tmpl  | 2 ++
 2 files changed, 6 insertions(+)

diff --git a/reporting/templates/lintian.css.tmpl 
b/reporting/templates/lintian.css.tmpl
index 7660e34..cc3e8a3 100644
--- a/reporting/templates/lintian.css.tmpl
+++ b/reporting/templates/lintian.css.tmpl
@@ -378,6 +378,10 @@ li.type-O {
 color: #444;
 }
 
+b.processing-error {
+color: #FF6700;
+}
+
 blockquote {
 padding: 6px 16px;
 background-color: #EEE;
diff --git a/reporting/templates/maintainer.tmpl 
b/reporting/templates/maintainer.tmpl
index 9fdd6c4..3e58c5b 100644
--- a/reporting/templates/maintainer.tmpl
+++ b/reporting/templates/maintainer.tmpl
@@ -108,6 +108,8 @@
 my $status = 'up-to-date';
 my $last_processed_by = $state->{'last-processed-by'} // 
'N/A';
 $status = 'outdated' if 
(exists($state->{'out-of-date'}));
+$status = 'incomplete report; 
an error occurred during the last check'
+  if exists($state->{'processing-errors'}) and 
$state->{'processing-errors'};
 $OUT .= qq(  \n);
 $OUT .= qq(   );
 $OUT .= "$source ($version$component)";

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] 01/05: c/r-lintian-harness: Record processing errors

[Niels Thykier]

This is an automated email from the git hooks/post-receive script.

nthykier pushed a commit to branch master
in repository lintian.

commit ca764b17da939c5b1b80aebf486ca3bcf23482a0
Author: Niels Thykier 
Date:   Sun Feb 4 09:23:01 2018 +

c/r-lintian-harness: Record processing errors

Signed-off-by: Niels Thykier 
---
 commands/reporting-lintian-harness.pm | 12 +++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/commands/reporting-lintian-harness.pm 
b/commands/reporting-lintian-harness.pm
index fc76850..d107687 100644
--- a/commands/reporting-lintian-harness.pm
+++ b/commands/reporting-lintian-harness.pm
@@ -213,7 +213,7 @@ sub process_worklist {
 log_msg('Command line used: ' . join(q{ }, @LINTIAN_CMD));
 while (@worklist) {
 my $len = scalar @worklist;
-my (@work_splice, @completed, %processed);
+my (@work_splice, @completed, %processed, %errors);
 my ($lintpipe, $lint_stdin, $status_fd, $lint_status_out);
 my $got_alarm = 0;
 
@@ -299,8 +299,10 @@ sub process_worklist {
 my $time_limit
   = $start_time + BACKLOG_PROCESSING_TIME_LIMIT - time();
 my $count = 0;
+my $signalled_lintian = 0;
 my $sig_handler = sub {
 my ($signal_name) = @_;
+$signalled_lintian = 1;
 $count++;
 if ($signal_name eq 'ALRM') {
 $got_alarm = 1 if $got_alarm >= 0;
@@ -345,6 +347,9 @@ sub process_worklist {
 log_msg("  [lintian] error processing $group_id "
   . "(time: $runtime)");
 $processed{$group_id} = 1;
+# We ignore errors if we sent lintian a signal to avoid
+# *some* false-positives.
+$errors{$group_id} if not $signalled_lintian;
 } elsif ($line =~ m/^ack-signal (SIG\S+)$/) {
 my $signal = $1;
 log_msg(
@@ -409,6 +414,11 @@ sub process_worklist {
 next if not exists($state->{'groups'}{$group_id});
 $group_data = $state->{'groups'}{$group_id};
 $group_data->{'last-processed-by'} = $LINTIAN_VERSION;
+if ($errors{$group_id}) {
+++$group_data->{'processing-errors'};
+} else {
+delete($group_data->{'processing-errors'});
+}
 delete($group_data->{'out-of-date'});
 }
 save_state_cache($OPT{'state-dir'}, $state);

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] 02/05: c/r-html-reports: Show number of groups with processing errors

[Niels Thykier]

This is an automated email from the git hooks/post-receive script.

nthykier pushed a commit to branch master
in repository lintian.

commit cd1fbfebdc246e8d3680ed853deb607087c8d4c4
Author: Niels Thykier 
Date:   Sun Feb 4 09:32:25 2018 +

c/r-html-reports: Show number of groups with processing errors

Signed-off-by: Niels Thykier 
---
 commands/reporting-html-reports.pm | 7 +++
 reporting/templates/index.tmpl | 1 +
 2 files changed, 8 insertions(+)

diff --git a/commands/reporting-html-reports.pm 
b/commands/reporting-html-reports.pm
index 49080e2..4f5f959 100644
--- a/commands/reporting-html-reports.pm
+++ b/commands/reporting-html-reports.pm
@@ -616,6 +616,13 @@ sub collect_statistics {
 $statistics{'groups-known'} = scalar(keys(%{$state_cache->{'groups'}}));
 $statistics{'groups-backlog'}
   = scalar(find_backlog($LINTIAN_VERSION,$state_cache));
+my $pkgs_w_errors = 0;
+for my $group_data (values(%{$state_cache->{'groups'}})) {
+$pkgs_w_errors++
+  if exists($group_data->{'processing-errors'})
+  and $group_data->{'processing-errors'};
+}
+$statistics{'groups-with-errors'} = $pkgs_w_errors;
 
 for my $attr (@attrs) {
 my $old = $old_statistics->{$attr} || 0;
diff --git a/reporting/templates/index.tmpl b/reporting/templates/index.tmpl
index add58ae..e253ab8 100644
--- a/reporting/templates/index.tmpl
+++ b/reporting/templates/index.tmpl
@@ -76,6 +76,7 @@
   Maintainers:  {$delta{maintainers}}
   Package groups: {$delta{'groups-known'}}
   Rescheduled groups: {$delta{'groups-backlog'}}
+  Groups with processing errors: 
{$delta{'groups-with-errors'}}
   Source packages:  {$delta{'source-packages'}}
   Binary packages:  {$delta{'binary-packages'}}
   deb packages: {$delta{'udeb-packages'}}

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

Jenkins build is back to normal : lintian-tests_buster #565

[jenkins]

See 

Bug#712394: lintian: Warn if override_dh_auto_test target doesn't check for DEB_BUILD_OPTIONS=nocheck

[Chris Lamb]

Chris Lamb wrote:

> We might just end up reverting the whole thing, naturally, but let's see
> how we go for now...

Some results coming in:

  
https://lintian.debian.org/tags/override_dh_auto_test-does-not-check-DEB_BUILD_PROFILES.html

Thoughts?


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

Jenkins build is back to normal : lintian-tests_sid #2531

[jenkins]

See 

[lintian] branch master updated (5f9248e -> b2aae60)

[Chris Lamb]

This is an automated email from the git hooks/post-receive script.

lamby pushed a change to branch master
in repository lintian.

  from  5f9248e   Don't fail if dpdir is undefined.
   new  b2aae60   Ignore packages ending with "-source" too.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 checks/fields.pm|  1 +
 debian/changelog|  5 +++--
 t/tests/fields-depends-general/debian/debian/control.in | 12 
 3 files changed, 16 insertions(+), 2 deletions(-)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] 01/01: Ignore packages ending with "-source" too.

[Chris Lamb]

This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit b2aae6091ee9b0a5971dc927a732c2b692233ee2
Author: Chris Lamb 
Date:   Sun Feb 4 09:57:42 2018 +

Ignore packages ending with "-source" too.
---
 checks/fields.pm|  1 +
 debian/changelog|  5 +++--
 t/tests/fields-depends-general/debian/debian/control.in | 12 
 3 files changed, 16 insertions(+), 2 deletions(-)

diff --git a/checks/fields.pm b/checks/fields.pm
index 2ced6ff..ce545a2 100644
--- a/checks/fields.pm
+++ b/checks/fields.pm
@@ -907,6 +907,7 @@ sub run {
   "$field: $part_d_orig"
   if $KNOWN_TOOLCHAIN->known($d_pkg)
   and not $pkg =~ m/^dh-/
+  and not $pkg =~ m/-(source|src)$/
   and not $DH_ADDONS_VALUES{$pkg};
 
 # default-jdk-doc must depend on openjdk-X-doc (or
diff --git a/debian/changelog b/debian/changelog
index e18bb23..6f3d160 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -6,8 +6,9 @@ lintian (2.5.74) UNRELEASED; urgency=medium
 + [BR] Check for wasm files.  (Closes: #889102)
   * checks/fields.pm:
 + [CL] Avoid false positives when checking binary packages depending on
-  toolchain packages by ignoring packages starting with "dh-". Thanks
-  to Josh Triplett for the report.  (Closes: #889486)
+  toolchain packages by ignoring packages starting with "dh-" or ending
+  with "-source". Thanks to Josh Triplett for the report.
+  (Closes: #889486)
   * checks/patch-systems.pm:
 + [CL] Avoid emitting "Can't use an undefined value as an ARRAY
   reference" warnings when debian/patches is a file, not a directory.
diff --git a/t/tests/fields-depends-general/debian/debian/control.in 
b/t/tests/fields-depends-general/debian/debian/control.in
index 5b610cc..7f3ef33 100644
--- a/t/tests/fields-depends-general/debian/debian/control.in
+++ b/t/tests/fields-depends-general/debian/debian/control.in
@@ -67,3 +67,15 @@ Description: {$description} - Fake Debhelper package
  .
  The fake Debhelper package to test false-positives in
  binary-package-depends-on-toolchain-package.
+
+Package: {$source}-source
+Architecture: {$architecture}
+Depends: $\{shlibs:Depends\}, $\{misc:Depends\}, debhelper
+Description: {$description} - Fake DKMS-like package
+ This is a test package designed to exercise some feature or tag of
+ Lintian.  It is part of the Lintian test suite and may do very odd
+ things.  It should not be installed like a regular package.  It may
+ be an empty package.
+ .
+ The fake DKMS-like package to test false-positives in
+ binary-package-depends-on-toolchain-package.

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

Build failed in Jenkins: lintian-tests_sid #2530

[jenkins]

See 


Changes:

[lamby] Improve, elaborate and tidy the long description of the

--
[...truncated 244.56 KB...]
Adding debian:DigiCert_Global_Root_CA.pem
Adding debian:DigiCert_Assured_ID_Root_G3.pem
Adding debian:DigiCert_Assured_ID_Root_G2.pem
Adding debian:DigiCert_Assured_ID_Root_CA.pem
Adding debian:Deutsche_Telekom_Root_CA_2.pem
Adding debian:DST_Root_CA_X3.pem
Adding debian:DST_ACES_CA_X6.pem
Adding debian:D-TRUST_Root_Class_3_CA_2_EV_2009.pem
Adding debian:D-TRUST_Root_Class_3_CA_2_2009.pem
Adding debian:Cybertrust_Global_Root.pem
Adding debian:Comodo_Trusted_Services_root.pem
Adding debian:Comodo_Secure_Services_root.pem
Adding debian:Comodo_AAA_Services_root.pem
Adding debian:China_Internet_Network_Information_Center_EV_Certificates_Root.pem
Adding debian:Chambers_of_Commerce_Root_-_2008.pem
Adding debian:Certum_Trusted_Network_CA_2.pem
Adding debian:Certum_Trusted_Network_CA.pem
Adding debian:Certum_Root_CA.pem
Adding debian:Certplus_Root_CA_G2.pem
Adding debian:Certplus_Root_CA_G1.pem
Adding debian:Certplus_Class_2_Primary_CA.pem
Adding debian:Certinomis_-_Root_CA.pem
Warning: there was a problem reading the certificate file 
/etc/ssl/certs/Certinomis_-_Autorit?_Racine.pem. Message:
  /etc/ssl/certs/Certinomis_-_Autorit?_Racine.pem (No such file or directory)
Adding debian:Certigna.pem
Adding debian:Camerfirma_Global_Chambersign_Root.pem
Adding debian:Camerfirma_Chambers_of_Commerce_Root.pem
Adding debian:COMODO_RSA_Certification_Authority.pem
Adding debian:COMODO_ECC_Certification_Authority.pem
Adding debian:COMODO_Certification_Authority.pem
Adding debian:CNNIC_ROOT.pem
Adding debian:CFCA_EV_ROOT.pem
Adding debian:CA_Disig_Root_R2.pem
Adding debian:CA_Disig_Root_R1.pem
Adding debian:Buypass_Class_3_Root_CA.pem
Adding debian:Buypass_Class_2_Root_CA.pem
Adding debian:Baltimore_CyberTrust_Root.pem
Adding debian:Autoridad_de_Certificacion_Firmaprofesional_CIF_A62634068.pem
Adding debian:Atos_TrustedRoot_2011.pem
Adding debian:Amazon_Root_CA_4.pem
Adding debian:Amazon_Root_CA_3.pem
Adding debian:Amazon_Root_CA_2.pem
Adding debian:Amazon_Root_CA_1.pem
Adding debian:AffirmTrust_Premium_ECC.pem
Adding debian:AffirmTrust_Premium.pem
Adding debian:AffirmTrust_Networking.pem
Adding debian:AffirmTrust_Commercial.pem
Adding debian:AddTrust_Qualified_Certificates_Root.pem
Adding debian:AddTrust_Public_Services_Root.pem
Adding debian:AddTrust_Low-Value_Services_Root.pem
Adding debian:AddTrust_External_Root.pem
Adding debian:Actalis_Authentication_Root_CA.pem
Adding debian:AC_RAIZ_FNMT-RCM.pem
Adding debian:ACEDICOM_Root.pem
Adding debian:ACCVRAIZ1.pem
done.
Setting up openjdk-8-jdk-headless:amd64 (8u151-b12-1) ...
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/idlj to 
provide /usr/bin/idlj (idlj) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jdeps to 
provide /usr/bin/jdeps (jdeps) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/wsimport to 
provide /usr/bin/wsimport (wsimport) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/rmic to 
provide /usr/bin/rmic (rmic) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jinfo to 
provide /usr/bin/jinfo (jinfo) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jsadebugd to 
provide /usr/bin/jsadebugd (jsadebugd) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/native2ascii 
to provide /usr/bin/native2ascii (native2ascii) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jstat to 
provide /usr/bin/jstat (jstat) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/javac to 
provide /usr/bin/javac (javac) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/javah to 
provide /usr/bin/javah (javah) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jstack to 
provide /usr/bin/jstack (jstack) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jrunscript to 
provide /usr/bin/jrunscript (jrunscript) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/javadoc to 
provide /usr/bin/javadoc (javadoc) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jhat to 
provide /usr/bin/jhat (jhat) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/javap to 
provide /usr/bin/javap (javap) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jar to provide 
/usr/bin/jar (jar) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/xjc to provide 
/usr/bin/xjc (xjc) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/schemagen to 
provide /usr/bin/schemagen (schemagen) in auto mode

[lintian] 01/01: Don't fail if dpdir is undefined.

[Chris Lamb]

This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit 5f9248eabbfcf7f3527c0195f6b6a621d1243339
Author: Chris Lamb 
Date:   Sun Feb 4 09:55:08 2018 +

Don't fail if dpdir is undefined.
---
 checks/patch-systems.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/checks/patch-systems.pm b/checks/patch-systems.pm
index 11f9185..2c49714 100644
--- a/checks/patch-systems.pm
+++ b/checks/patch-systems.pm
@@ -227,7 +227,7 @@ sub run {
 }
 
 #- look for unreferenced files in debian/patches
-if ($dpdir->is_dir and $format ne '2.0') {
+if ($dpdir and $dpdir->is_dir and $format ne '2.0') {
 # Check all series files, including $vendor.series
 foreach my $file ($dpdir->children) {
 next unless $file =~ /\/(.+\.)?series$/;

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] branch master updated (530c587 -> 5f9248e)

[Chris Lamb]

This is an automated email from the git hooks/post-receive script.

lamby pushed a change to branch master
in repository lintian.

  from  530c587   Don't warn if debian/patches is a symlink to a file 
either. Thanks Niels!
   new  5f9248e   Don't fail if dpdir is undefined.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 checks/patch-systems.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

Re: [lintian] 02/02: Avoid emitting "Can't use an undefined value as an ARRAY reference" warnings when debian/patches is a file, not a directory. (Closes: #889535)

[Chris Lamb]

Hi Niels,

> This looks like it would still cause issues if d/patches is a symlink to
> a file.

Great spot. Should be addressed in:

  
https://anonscm.debian.org/git/lintian/lintian.git/commit/?id=530c5878a1c2198d79d35e8eafebbc9c8e6d91ec

:)


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

[lintian] branch master updated (76a12dd -> 530c587)

[Chris Lamb]

This is an automated email from the git hooks/post-receive script.

lamby pushed a change to branch master
in repository lintian.

  from  76a12dd   Avoid emitting "Can't use an undefined value as an ARRAY 
reference" warnings when debian/patches is a file, not a directory. (Closes: 
#889535)
   new  530c587   Don't warn if debian/patches is a symlink to a file 
either. Thanks Niels!

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 checks/patch-systems.pm | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] 01/01: Don't warn if debian/patches is a symlink to a file either. Thanks Niels!

[Chris Lamb]

This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit 530c5878a1c2198d79d35e8eafebbc9c8e6d91ec
Author: Chris Lamb 
Date:   Sun Feb 4 09:45:08 2018 +

Don't warn if debian/patches is a symlink to a file either. Thanks Niels!
---
 checks/patch-systems.pm | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/checks/patch-systems.pm b/checks/patch-systems.pm
index d73a653..11f9185 100644
--- a/checks/patch-systems.pm
+++ b/checks/patch-systems.pm
@@ -47,14 +47,13 @@ sub run {
 my $droot = $info->index_resolved_path('debian/');
 return if not $droot;
 my $dpdir = $droot->resolve_path('patches');
-my $resolved;
 my $patch_series;
 my %known_files;
 
 # Find debian/patches/series, assuming debian/patches is a (symlink to a)
 # dir.  There are cases, where it is a file (ctwm: #778556)
 if ($dpdir and ($dpdir->is_dir or $dpdir->is_symlink)) {
-$resolved = $dpdir->resolve_path;
+my $resolved = $dpdir->resolve_path;
 $patch_series = $resolved->resolve_path('series') if $resolved->is_dir;
 }
 
@@ -228,7 +227,7 @@ sub run {
 }
 
 #- look for unreferenced files in debian/patches
-if ($resolved and $format ne '2.0') {
+if ($dpdir->is_dir and $format ne '2.0') {
 # Check all series files, including $vendor.series
 foreach my $file ($dpdir->children) {
 next unless $file =~ /\/(.+\.)?series$/;

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

Bug#889535: lintian: Can't use an undefined value as an ARRAY reference at /srv/lintian.debian.org/lintian/lib/Lintian/Path.pm line 326.

[Chris Lamb]

tags 889535 + pending
thanks

Thanks! Fixed in Git, pending upload:

  
https://anonscm.debian.org/git/lintian/lintian.git/commit/?id=76a12dd8be5bd2308918d4019a880d84ced00877


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

Re: [lintian] 02/02: Avoid emitting "Can't use an undefined value as an ARRAY reference" warnings when debian/patches is a file, not a directory. (Closes: #889535)

[Niels Thykier]

Chris Lamb:
> This is an automated email from the git hooks/post-receive script.
> 
> lamby pushed a commit to branch master
> in repository lintian.
> 
> commit 76a12dd8be5bd2308918d4019a880d84ced00877
> Author: Chris Lamb 
> Date:   Sun Feb 4 09:36:00 2018 +
> 
> Avoid emitting "Can't use an undefined value as an ARRAY reference" 
> warnings when debian/patches is a file, not a directory. (Closes: #889535)
> ---
>  checks/patch-systems.pm | 5 +++--
>  debian/changelog| 4 
>  2 files changed, 7 insertions(+), 2 deletions(-)
> 

Hi,

Thanks for fixing this bug; just one comment.

> diff --git a/checks/patch-systems.pm b/checks/patch-systems.pm
> index cac174e..d73a653 100644
> --- a/checks/patch-systems.pm
> +++ b/checks/patch-systems.pm
> @@ -47,13 +47,14 @@ sub run {
>  my $droot = $info->index_resolved_path('debian/');
>  return if not $droot;
>  my $dpdir = $droot->resolve_path('patches');
> +my $resolved;
>  my $patch_series;
>  my %known_files;
>  
>  # Find debian/patches/series, assuming debian/patches is a (symlink to a)
>  # dir.  There are cases, where it is a file (ctwm: #778556)
>  if ($dpdir and ($dpdir->is_dir or $dpdir->is_symlink)) {
> -my $resolved = $dpdir->resolve_path;
> +$resolved = $dpdir->resolve_path;
>  $patch_series = $resolved->resolve_path('series') if 
> $resolved->is_dir;
>  }
>  
> @@ -227,7 +228,7 @@ sub run {
>  }
>  
>  #- look for unreferenced files in debian/patches
> -if ($dpdir and $format ne '2.0') {
> +if ($resolved and $format ne '2.0') {
>  # Check all series files, including $vendor.series
>  foreach my $file ($dpdir->children) {
>  next unless $file =~ /\/(.+\.)?series$/;
> [...]


This looks like it would still cause issues if d/patches is a symlink to
a file.  In that case, $resolved would still be valid path (to the
file).  Adding a "and $resolved->is_dir" should solve that.

Thanks,
~Niels

Build failed in Jenkins: lintian-tests_sid #2529

[jenkins]

See 


Changes:

[niels] c/r-html-reports: Handle "release-often" pattern better in the version

[lamby] Tidy changelog entry

[lamby] Avoid false positives when checking binary packages depending on

--
[...truncated 244.55 KB...]
Adding debian:DigiCert_Global_Root_CA.pem
Adding debian:DigiCert_Assured_ID_Root_G3.pem
Adding debian:DigiCert_Assured_ID_Root_G2.pem
Adding debian:DigiCert_Assured_ID_Root_CA.pem
Adding debian:Deutsche_Telekom_Root_CA_2.pem
Adding debian:DST_Root_CA_X3.pem
Adding debian:DST_ACES_CA_X6.pem
Adding debian:D-TRUST_Root_Class_3_CA_2_EV_2009.pem
Adding debian:D-TRUST_Root_Class_3_CA_2_2009.pem
Adding debian:Cybertrust_Global_Root.pem
Adding debian:Comodo_Trusted_Services_root.pem
Adding debian:Comodo_Secure_Services_root.pem
Adding debian:Comodo_AAA_Services_root.pem
Adding debian:China_Internet_Network_Information_Center_EV_Certificates_Root.pem
Adding debian:Chambers_of_Commerce_Root_-_2008.pem
Adding debian:Certum_Trusted_Network_CA_2.pem
Adding debian:Certum_Trusted_Network_CA.pem
Adding debian:Certum_Root_CA.pem
Adding debian:Certplus_Root_CA_G2.pem
Adding debian:Certplus_Root_CA_G1.pem
Adding debian:Certplus_Class_2_Primary_CA.pem
Adding debian:Certinomis_-_Root_CA.pem
Warning: there was a problem reading the certificate file 
/etc/ssl/certs/Certinomis_-_Autorit?_Racine.pem. Message:
  /etc/ssl/certs/Certinomis_-_Autorit?_Racine.pem (No such file or directory)
Adding debian:Certigna.pem
Adding debian:Camerfirma_Global_Chambersign_Root.pem
Adding debian:Camerfirma_Chambers_of_Commerce_Root.pem
Adding debian:COMODO_RSA_Certification_Authority.pem
Adding debian:COMODO_ECC_Certification_Authority.pem
Adding debian:COMODO_Certification_Authority.pem
Adding debian:CNNIC_ROOT.pem
Adding debian:CFCA_EV_ROOT.pem
Adding debian:CA_Disig_Root_R2.pem
Adding debian:CA_Disig_Root_R1.pem
Adding debian:Buypass_Class_3_Root_CA.pem
Adding debian:Buypass_Class_2_Root_CA.pem
Adding debian:Baltimore_CyberTrust_Root.pem
Adding debian:Autoridad_de_Certificacion_Firmaprofesional_CIF_A62634068.pem
Adding debian:Atos_TrustedRoot_2011.pem
Adding debian:Amazon_Root_CA_4.pem
Adding debian:Amazon_Root_CA_3.pem
Adding debian:Amazon_Root_CA_2.pem
Adding debian:Amazon_Root_CA_1.pem
Adding debian:AffirmTrust_Premium_ECC.pem
Adding debian:AffirmTrust_Premium.pem
Adding debian:AffirmTrust_Networking.pem
Adding debian:AffirmTrust_Commercial.pem
Adding debian:AddTrust_Qualified_Certificates_Root.pem
Adding debian:AddTrust_Public_Services_Root.pem
Adding debian:AddTrust_Low-Value_Services_Root.pem
Adding debian:AddTrust_External_Root.pem
Adding debian:Actalis_Authentication_Root_CA.pem
Adding debian:AC_RAIZ_FNMT-RCM.pem
Adding debian:ACEDICOM_Root.pem
Adding debian:ACCVRAIZ1.pem
done.
Setting up openjdk-8-jdk-headless:amd64 (8u151-b12-1) ...
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/idlj to 
provide /usr/bin/idlj (idlj) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jdeps to 
provide /usr/bin/jdeps (jdeps) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/wsimport to 
provide /usr/bin/wsimport (wsimport) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/rmic to 
provide /usr/bin/rmic (rmic) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jinfo to 
provide /usr/bin/jinfo (jinfo) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jsadebugd to 
provide /usr/bin/jsadebugd (jsadebugd) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/native2ascii 
to provide /usr/bin/native2ascii (native2ascii) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jstat to 
provide /usr/bin/jstat (jstat) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/javac to 
provide /usr/bin/javac (javac) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/javah to 
provide /usr/bin/javah (javah) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jstack to 
provide /usr/bin/jstack (jstack) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jrunscript to 
provide /usr/bin/jrunscript (jrunscript) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/javadoc to 
provide /usr/bin/javadoc (javadoc) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jhat to 
provide /usr/bin/jhat (jhat) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/javap to 
provide /usr/bin/javap (javap) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/jar to provide 
/usr/bin/jar (jar) in auto mode
update-alternatives: using /usr/lib/jvm/java-8-openjdk-amd64/bin/xjc to provide 
/usr/bin/xjc (xjc) in auto mode
update-alternatives: 

Processed: Re: lintian: Can't use an undefined value as an ARRAY reference at /srv/lintian.debian.org/lintian/lib/Lintian/Path.pm line 326.

[Debian Bug Tracking System]

Processing commands for cont...@bugs.debian.org:

> tags 889535 + pending
Bug #889535 [lintian] lintian: Can't use an undefined value as an ARRAY 
reference at /srv/lintian.debian.org/lintian/lib/Lintian/Path.pm line 326.
Added tag(s) pending.
> thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
889535: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=889535
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

[lintian] 02/02: Avoid emitting "Can't use an undefined value as an ARRAY reference" warnings when debian/patches is a file, not a directory. (Closes: #889535)

[Chris Lamb]

This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit 76a12dd8be5bd2308918d4019a880d84ced00877
Author: Chris Lamb 
Date:   Sun Feb 4 09:36:00 2018 +

Avoid emitting "Can't use an undefined value as an ARRAY reference" 
warnings when debian/patches is a file, not a directory. (Closes: #889535)
---
 checks/patch-systems.pm | 5 +++--
 debian/changelog| 4 
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/checks/patch-systems.pm b/checks/patch-systems.pm
index cac174e..d73a653 100644
--- a/checks/patch-systems.pm
+++ b/checks/patch-systems.pm
@@ -47,13 +47,14 @@ sub run {
 my $droot = $info->index_resolved_path('debian/');
 return if not $droot;
 my $dpdir = $droot->resolve_path('patches');
+my $resolved;
 my $patch_series;
 my %known_files;
 
 # Find debian/patches/series, assuming debian/patches is a (symlink to a)
 # dir.  There are cases, where it is a file (ctwm: #778556)
 if ($dpdir and ($dpdir->is_dir or $dpdir->is_symlink)) {
-my $resolved = $dpdir->resolve_path;
+$resolved = $dpdir->resolve_path;
 $patch_series = $resolved->resolve_path('series') if $resolved->is_dir;
 }
 
@@ -227,7 +228,7 @@ sub run {
 }
 
 #- look for unreferenced files in debian/patches
-if ($dpdir and $format ne '2.0') {
+if ($resolved and $format ne '2.0') {
 # Check all series files, including $vendor.series
 foreach my $file ($dpdir->children) {
 next unless $file =~ /\/(.+\.)?series$/;
diff --git a/debian/changelog b/debian/changelog
index f2e887d..e18bb23 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -8,6 +8,10 @@ lintian (2.5.74) UNRELEASED; urgency=medium
 + [CL] Avoid false positives when checking binary packages depending on
   toolchain packages by ignoring packages starting with "dh-". Thanks
   to Josh Triplett for the report.  (Closes: #889486)
+  * checks/patch-systems.pm:
++ [CL] Avoid emitting "Can't use an undefined value as an ARRAY
+  reference" warnings when debian/patches is a file, not a directory.
+  (Closes: #889535)
   * checks/scripts.desc:
 + [CL] Improve, elaborate and tidy the long description of the
   maintainer-script-should-not-use-recursive-chown-or-chmod tag.

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] 01/02: checks/patch-systens.pm: Fix typo in comment.

[Chris Lamb]

This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit 7ea6e4cc0260ee7a1bb1289c1922215a3393c04f
Author: Chris Lamb 
Date:   Sun Feb 4 09:35:48 2018 +

checks/patch-systens.pm: Fix typo in comment.
---
 checks/patch-systems.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/checks/patch-systems.pm b/checks/patch-systems.pm
index 134a650..cac174e 100644
--- a/checks/patch-systems.pm
+++ b/checks/patch-systems.pm
@@ -228,7 +228,7 @@ sub run {
 
 #- look for unreferenced files in debian/patches
 if ($dpdir and $format ne '2.0') {
-# Check all series filesf, including $vendor.series
+# Check all series files, including $vendor.series
 foreach my $file ($dpdir->children) {
 next unless $file =~ /\/(.+\.)?series$/;
 next unless $file->is_open_ok;

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] branch master updated (94acd66 -> 76a12dd)

[Chris Lamb]

This is an automated email from the git hooks/post-receive script.

lamby pushed a change to branch master
in repository lintian.

  from  94acd66   debian/changelog: Wrap long line.
   new  7ea6e4c   checks/patch-systens.pm: Fix typo in comment.
   new  76a12dd   Avoid emitting "Can't use an undefined value as an ARRAY 
reference" warnings when debian/patches is a file, not a directory. (Closes: 
#889535)

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 checks/patch-systems.pm | 7 ---
 debian/changelog| 4 
 2 files changed, 8 insertions(+), 3 deletions(-)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

Bug#889489: lintian: improve description of maintainer-script-should-not-use-recursive-chown-or-chmod

[Chris Lamb]

tags 889489 + pending
thanks

Applied in Git with a few changes. Many many thanks :)

  
https://anonscm.debian.org/git/lintian/lintian.git/commit/?id=d0c97d122f74564d489467dd0a201fa3cdc31ba3


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

Processed: Re: lintian: improve description of maintainer-script-should-not-use-recursive-chown-or-chmod

[Debian Bug Tracking System]

Processing commands for cont...@bugs.debian.org:

> tags 889489 + pending
Bug #889489 [lintian] lintian: improve description of 
maintainer-script-should-not-use-recursive-chown-or-chmod
Added tag(s) pending.
> thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
889489: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=889489
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

[lintian] branch master updated (d0c97d1 -> 94acd66)

[Chris Lamb]

This is an automated email from the git hooks/post-receive script.

lamby pushed a change to branch master
in repository lintian.

  from  d0c97d1   Improve, elaborate and tidy the long description of the 
maintainer-script-should-not-use-recursive-chown-or-chmod tag. Heavily based on 
a patch by Daniel Kahn Gillmor - thanks! (Closes: #889489)
   new  94acd66   debian/changelog: Wrap long line.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 debian/changelog | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] 01/01: debian/changelog: Wrap long line.

[Chris Lamb]

This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit 94acd6642998a519db25ba07283e10c5cacc71cc
Author: Chris Lamb 
Date:   Sun Feb 4 09:23:54 2018 +

debian/changelog: Wrap long line.
---
 debian/changelog | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/debian/changelog b/debian/changelog
index e1f3057..f2e887d 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -6,8 +6,8 @@ lintian (2.5.74) UNRELEASED; urgency=medium
 + [BR] Check for wasm files.  (Closes: #889102)
   * checks/fields.pm:
 + [CL] Avoid false positives when checking binary packages depending on
-  toolchain packages by ignoring packages starting with "dh-". Thanks to
-  Josh Triplett for the report.  (Closes: #889486)
+  toolchain packages by ignoring packages starting with "dh-". Thanks
+  to Josh Triplett for the report.  (Closes: #889486)
   * checks/scripts.desc:
 + [CL] Improve, elaborate and tidy the long description of the
   maintainer-script-should-not-use-recursive-chown-or-chmod tag.

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] branch master updated (f8d52f6 -> d0c97d1)

[Chris Lamb]

This is an automated email from the git hooks/post-receive script.

lamby pushed a change to branch master
in repository lintian.

  from  f8d52f6   Avoid false positives when checking binary packages 
depending on toolchain packages by ignoring packages starting with "dh-". 
Thanks to Josh Triplett for the report. (Closes: #889486)
   new  d0c97d1   Improve, elaborate and tidy the long description of the 
maintainer-script-should-not-use-recursive-chown-or-chmod tag. Heavily based on 
a patch by Daniel Kahn Gillmor - thanks! (Closes: #889489)

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 checks/scripts.desc | 26 ++
 debian/changelog|  5 +
 2 files changed, 27 insertions(+), 4 deletions(-)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] 01/01: Improve, elaborate and tidy the long description of the maintainer-script-should-not-use-recursive-chown-or-chmod tag. Heavily based on a patch by Daniel Kahn Gillmor - thanks! (Close

[Chris Lamb]

This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit d0c97d122f74564d489467dd0a201fa3cdc31ba3
Author: Chris Lamb 
Date:   Sun Feb 4 09:22:48 2018 +

Improve, elaborate and tidy the long description of the 
maintainer-script-should-not-use-recursive-chown-or-chmod tag. Heavily based on 
a patch by Daniel Kahn Gillmor - thanks! (Closes: #889489)
---
 checks/scripts.desc | 26 ++
 debian/changelog|  5 +
 2 files changed, 27 insertions(+), 4 deletions(-)

diff --git a/checks/scripts.desc b/checks/scripts.desc
index 176b8a1..b244bbb 100644
--- a/checks/scripts.desc
+++ b/checks/scripts.desc
@@ -816,7 +816,25 @@ Ref: #614907, #862051
 Tag: maintainer-script-should-not-use-recursive-chown-or-chmod
 Severity: normal
 Certainty: certain
-Info: The maintainer script appears to call chmod or chown
- with the recursive -R argument. This is vulnerable to hardlink
- attacks on kernels that do not have fs.protected_hardlinks=1
-Ref: #889060
+Info: The maintainer script appears to call chmod or
+ chown with an --recursive or -R argument.
+ .
+ This is vulnerable to hardlink attacks on mainline, non-Debian kernels
+ that do not have fs.protected_hardlinks=1,
+ .
+ This arises through altering permissions or ownership within a directory
+ that may be owned by a non-privileged user - such a user can link to
+ files that they do not own such as /etc/shadow or files
+ within /var/lib/dpkg/. The promiscuous chown or
+ chmod would convert the ownership or permissions of these
+ files so that they are manipulable by the non-privileged user.
+ .
+ Ways to avoid this problem include:
+ .
+  - If your package uses a static uid, please perform the chown at
+package build time instead of installation time.
+  - Use a non-recursive call instead, ensuring that you do not change
+ownership of files that are in user-controlled directories.
+  - Use runuser(1) to perform any initialization work as the
+user you were previously chowning to.
+Ref: #889060, #889488, runuser(1)
diff --git a/debian/changelog b/debian/changelog
index 432d8a5..e1f3057 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -8,6 +8,11 @@ lintian (2.5.74) UNRELEASED; urgency=medium
 + [CL] Avoid false positives when checking binary packages depending on
   toolchain packages by ignoring packages starting with "dh-". Thanks to
   Josh Triplett for the report.  (Closes: #889486)
+  * checks/scripts.desc:
++ [CL] Improve, elaborate and tidy the long description of the
+  maintainer-script-should-not-use-recursive-chown-or-chmod tag.
+  Heavily based on a patch by Daniel Kahn Gillmor - thanks!
+  (Closes: #889489)
 
  -- Chris Lamb   Sat, 03 Feb 2018 10:51:52 +
 

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

Bug#889535: lintian: Can't use an undefined value as an ARRAY reference at /srv/lintian.debian.org/lintian/lib/Lintian/Path.pm line 326.

[Niels Thykier]

Package: lintian
Version: 2.5.72
Severity: normal

Hi,

Seen on lindsay.d.o for vtwm/5.4.7-5 and xtrs/4.9c-4.  Below is the
log for vtwm (it looks similar for xtrs):


"""
N: 
N: Processing source package vtwm (version 5.4.7-5, arch source) ...
C: vtwm source (5.4.7-5) [source]: rules-requires-root-implicitly
C: vtwm source (5.4.7-5) [source]: debian-build-system debhelper
W: vtwm source (5.4.7-5) [source]: 
package-uses-deprecated-debhelper-compat-version 5
W: vtwm source (5.4.7-5) [source]: dh-clean-k-is-deprecated
W: vtwm source (5.4.7-5) [source]: missing-debian-source-format
C: vtwm source (5.4.7-5) [source]: source-format 1.0 [implicit non-native]
Can't use an undefined value as an ARRAY reference at 
/srv/lintian.debian.org/lintian/lib/Lintian/Path.pm line 326.
internal error: cannot run patch-systems check on package source:vtwm/5.4.7-5
warning: skipping check of source:vtwm/5.4.7-5
N: 
"""

Thanks,
~Niels

[lintian] branch master updated (fe8148a -> a17f3e3)

[Niels Thykier]

This is an automated email from the git hooks/post-receive script.

nthykier pushed a change to branch master
in repository lintian.

  from  fe8148a   r/t/head.tmpl: Drop CSP http-equiv; we use proper HTTP 
headers now
   new  a17f3e3   c/r-html-reports: Handle "release-often" pattern better 
in the version graph

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 commands/reporting-html-reports.pm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

Processed: Re: Please check for packages named "dh-*" in binary-package-depends-on-toolchain-package

[Debian Bug Tracking System]

Processing commands for cont...@bugs.debian.org:

> tags 889486 + pending
Bug #889486 [lintian] Please check for packages named "dh-*" in 
binary-package-depends-on-toolchain-package
Added tag(s) pending.
> thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
889486: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=889486
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Bug#889486: Please check for packages named "dh-*" in binary-package-depends-on-toolchain-package

[Chris Lamb]

tags 889486 + pending
thanks

Thanks. :)  Fixed in Git, pending upload:

  
https://anonscm.debian.org/git/lintian/lintian.git/commit/?id=f8d52f6db1309feb076c938923518e7e323e46d8


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

[lintian] branch master updated (740e673 -> fe8148a)

[Niels Thykier]

This is an automated email from the git hooks/post-receive script.

nthykier pushed a change to branch master
in repository lintian.

  from  740e673   Detect wasm prebuilt file
   new  fe8148a   r/t/head.tmpl: Drop CSP http-equiv; we use proper HTTP 
headers now

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 reporting/templates/head.tmpl | 1 -
 1 file changed, 1 deletion(-)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] branch master updated (a17f3e3 -> f8d52f6)

[Chris Lamb]

This is an automated email from the git hooks/post-receive script.

lamby pushed a change to branch master
in repository lintian.

  from  a17f3e3   c/r-html-reports: Handle "release-often" pattern better 
in the version graph
   new  4c18827   Tidy changelog entry
   new  f8d52f6   Avoid false positives when checking binary packages 
depending on toolchain packages by ignoring packages starting with "dh-". 
Thanks to Josh Triplett for the report. (Closes: #889486)

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 checks/fields.pm|  1 +
 debian/changelog|  8 ++--
 t/tests/fields-depends-general/debian/debian/control.in | 12 
 3 files changed, 19 insertions(+), 2 deletions(-)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] 01/02: Tidy changelog entry

[Chris Lamb]

This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit 4c188271e351fd168ccbfcf8efa553c1c6828948
Author: Chris Lamb 
Date:   Sun Feb 4 08:56:13 2018 +

Tidy changelog entry
---
 debian/changelog | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/debian/changelog b/debian/changelog
index 2ed559f..232872a 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -2,8 +2,8 @@ lintian (2.5.74) UNRELEASED; urgency=medium
 
   XXX: generate tag summary
 
-  * checks/cruft.{desc}:
-+ [BR] Check for wasm file. (Closes: #889102)
+  * checks/cruft.desc:
++ [BR] Check for wasm files.  (Closes: #889102)
 
  -- Chris Lamb   Sat, 03 Feb 2018 10:51:52 +
 

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] 02/02: Avoid false positives when checking binary packages depending on toolchain packages by ignoring packages starting with "dh-". Thanks to Josh Triplett for the report. (Closes: #889486)

[Chris Lamb]

This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit f8d52f6db1309feb076c938923518e7e323e46d8
Author: Chris Lamb 
Date:   Sun Feb 4 08:57:50 2018 +

Avoid false positives when checking binary packages depending on toolchain 
packages by ignoring packages starting with "dh-". Thanks to Josh Triplett for 
the report. (Closes: #889486)
---
 checks/fields.pm|  1 +
 debian/changelog|  4 
 t/tests/fields-depends-general/debian/debian/control.in | 12 
 3 files changed, 17 insertions(+)

diff --git a/checks/fields.pm b/checks/fields.pm
index d04acab..2ced6ff 100644
--- a/checks/fields.pm
+++ b/checks/fields.pm
@@ -906,6 +906,7 @@ sub run {
 tag 'binary-package-depends-on-toolchain-package',
   "$field: $part_d_orig"
   if $KNOWN_TOOLCHAIN->known($d_pkg)
+  and not $pkg =~ m/^dh-/
   and not $DH_ADDONS_VALUES{$pkg};
 
 # default-jdk-doc must depend on openjdk-X-doc (or
diff --git a/debian/changelog b/debian/changelog
index 232872a..432d8a5 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -4,6 +4,10 @@ lintian (2.5.74) UNRELEASED; urgency=medium
 
   * checks/cruft.desc:
 + [BR] Check for wasm files.  (Closes: #889102)
+  * checks/fields.pm:
++ [CL] Avoid false positives when checking binary packages depending on
+  toolchain packages by ignoring packages starting with "dh-". Thanks to
+  Josh Triplett for the report.  (Closes: #889486)
 
  -- Chris Lamb   Sat, 03 Feb 2018 10:51:52 +
 
diff --git a/t/tests/fields-depends-general/debian/debian/control.in 
b/t/tests/fields-depends-general/debian/debian/control.in
index 2844548..5b610cc 100644
--- a/t/tests/fields-depends-general/debian/debian/control.in
+++ b/t/tests/fields-depends-general/debian/debian/control.in
@@ -55,3 +55,15 @@ Description: {$description} - Fake Doc package
  be an empty package.
  .
  The fake doc package.
+
+Package: dh-{$source}
+Architecture: {$architecture}
+Depends: $\{shlibs:Depends\}, $\{misc:Depends\}, debhelper
+Description: {$description} - Fake Debhelper package
+ This is a test package designed to exercise some feature or tag of
+ Lintian.  It is part of the Lintian test suite and may do very odd
+ things.  It should not be installed like a regular package.  It may
+ be an empty package.
+ .
+ The fake Debhelper package to test false-positives in
+ binary-package-depends-on-toolchain-package.

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] 01/01: c/r-html-reports: Handle "release-often" pattern better in the version graph

[Niels Thykier]

This is an automated email from the git hooks/post-receive script.

nthykier pushed a commit to branch master
in repository lintian.

commit a17f3e3492ab8191649b549d03b8d02210e4f5b1
Author: Niels Thykier 
Date:   Sun Feb 4 08:47:42 2018 +

c/r-html-reports: Handle "release-often" pattern better in the version graph

Signed-off-by: Niels Thykier 
---
 commands/reporting-html-reports.pm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/commands/reporting-html-reports.pm 
b/commands/reporting-html-reports.pm
index 749f153..49080e2 100644
--- a/commands/reporting-html-reports.pm
+++ b/commands/reporting-html-reports.pm
@@ -726,9 +726,9 @@ sub update_history_and_make_graphs {
 (my $label = $v) =~ s/\-[\w\d]+$//;
 print {$common} "set label '$label' at '$versions{$v}',graph ",
   "1.04 rotate by 90 font ',8'\n";
-}
 
-$last_version = $versions{$v};
+$last_version = $versions{$v};
+}
 }
 close($common);
 

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

[lintian] 01/01: r/t/head.tmpl: Drop CSP http-equiv; we use proper HTTP headers now

[Niels Thykier]

This is an automated email from the git hooks/post-receive script.

nthykier pushed a commit to branch master
in repository lintian.

commit fe8148af114bff4ce2e3de0b59f3463159496417
Author: Niels Thykier 
Date:   Sun Feb 4 08:42:17 2018 +

r/t/head.tmpl: Drop CSP http-equiv; we use proper HTTP headers now

Signed-off-by: Niels Thykier 
---
 reporting/templates/head.tmpl | 1 -
 1 file changed, 1 deletion(-)

diff --git a/reporting/templates/head.tmpl b/reporting/templates/head.tmpl
index 5a44b0e..4001950 100644
--- a/reporting/templates/head.tmpl
+++ b/reporting/templates/head.tmpl
@@ -1,7 +1,6 @@
 
 
 
-  
   {$page_title}
   
   

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

Re: Intend to remove lintian.log from lintian.d.o (please migrate to the .gz variant)

[Niels Thykier]

Paul Wise:
> On Sat, Feb 3, 2018 at 6:17 PM, Niels Thykier wrote:
> 
>> Please migrate any usage of "https://lintian.debian.org/lintian.log; to
>> "https://lintian.debian.org/lintian.log.gz; (and update the code to
>> decompress as necessary).
> 
> Done in git for the repos I have checked out:
> 
> https://salsa.debian.org/qa/qa/commit/0cb18cede223158598f9a48281d66686b5867bc3
> https://salsa.debian.org/qa/pts/commit/b4240196376f954c4d6cbf7271787d8a9d20dcc3
> https://anonscm.debian.org/git/collab-qa/udd.git/commit/?id=e8907c20c4a7eaee01cb94eda618561935145aa8
> 

Excellent! :)

~Niels