Bug#869692: RFS: cyclograph/1.9.0-1

[Federico Brega]

> Please update Standards-Version to he current version.
Done.
This triggers a warning in lintian, which only knows about 4.0.0
This warning is displayed also by other packages already in Debian and
nobody put in place an override for this warning so I though I should do
the same.
Debian policy 4.1.0 §4.15 is about reproducibility, which I was
already targeting,
but it is not 100% clear how can I be sure that my package is reproducible.
I built the package twice and the binary packages are identical, but I don't
know if this is enough.
Priority from extra to optional is now part of the policy so this is
reflected in
the changelog.

> Shipping files like /usr/share/pixmaps/new.svg seems very wrong, they
> should be in a package-specific dir (and not under /usr/share/pixmaps).
All icons are now moved in /usr/share/cyclograph/icons with the exception
of the application icon, which is now also in 48x48 as required by freedesktop
specifications. A couple more sizes have been provided in png format.

> Qt frontend doesn't work: ImportError: cannot import name 'QtWebEngineWidgets'
Added the missing dependency to qtwebengine

> You shouldn't use the full icon paths in .desktop Icon, definitely not
> ones for 32x32.
I ran desktop-file-validate and it mislead me to add the full path,
The file extension should have been removed, and now they are.

Regards
--
Federico

Bug#869692: RFS: cyclograph/1.9.0-1

[Andrey Rahmatullin]

Please update Standards-Version to he current version.
Shipping files like /usr/share/pixmaps/new.svg seems very wrong, they
should be in a package-specific dir (and not under /usr/share/pixmaps).
Qt frontend doesn't work: ImportError: cannot import name 'QtWebEngineWidgets'
You shouldn't use the full icon paths in .desktop Icon, definitely not
ones for 32x32.

On Wed, Aug 23, 2017 at 09:31:30PM +0200, Federico Brega wrote:
> First of all: this bug refers to 1.9.0 but we are talking about 1.9.1
> from now on, is a
> separate bug needed?
You should retitle the current one.

-- 
WBR, wRAR


signature.asc
Description: PGP signature

Bug#869692: RFS: cyclograph/1.9.0-1

[Federico Brega]

We've finally manage to get a new upstream release, which is 1.9.1~rc1
We went for an rc1 because we want to have binary packages only once the source
are acceptable. So rc2 is planned to include only changes needed for
debian packaging.
Once the source is Ok for debian, the final release will be made
upstream with the
same sources of the last rc.

First of all: this bug refers to 1.9.0 but we are talking about 1.9.1
from now on, is a
separate bug needed?

> > > Patch headers should be in the DEP-3 format (lintian tells that).
Done

> > > doc/manual.html says it's autogenerated from a LyX source
They are now generated from the lyx file, with the obvious addition of
elyxer to the b-d.

> > > The same for cyclograph/qt/cyclograph_rc.py which is pyrcc5-generated.
The file is now generated by pyuicc, with the addition of
pyqt4-dev-tools to the b-d.

Also the gui files are edited by qt designer so the code generation
has been included in
the setup script, too.

The same goes for gettext

> > > The GUIs still have a "Check online" checkbox which is even on by default
> > > even if it has no effect, it should be hidden.
> > Ok, thanks for the care you are giving to this package.
> > To fix this a patch or a new upstream release is required. Are both options
> > acceptable?
> Which both options?
I was asking I a debian patch is acceptable to hide the checkbox. The
other option is
a new upstream implementing the change. Anyways we went for the second option to
keep the debian patch short.
--
Federico

Bug#869692: RFS: cyclograph/1.9.0-1

[Andrey Rahmatullin]

On Mon, Aug 07, 2017 at 06:10:05PM +0200, Federico Brega wrote:
> > Patch headers should be in the DEP-3 format (lintian tells that).
> 
> Now I have to ask for the option needed for lintian to tell that.
It only tells that in the description of tag which is emitted when there
is no header at all.

> > doc/manual.html says it's autogenerated from a LyX source yet the source
> > and a way to regenerate it from that source are not included. This is a
> > DFSG violation.
> It's not auto-generated, but generated. I use LyX as my editor, it saves
> the file in an internal format, and I export it to html.
> I don't see any violation to DFSG §2, which is the closes to the subject.
Are you editing .html directly?

> > The same for cyclograph/qt/cyclograph_rc.py which is pyrcc5-generated.
> I agree more on this, because the resource file is a kind of binary /
> obfuscated code. It contains only artworks and the same html files used
> by cyclograph-gtk3. If the generation process has to be done in debian
> I don't think a new upstream release can be avoided, because the file
> needed to build the resource file is not distributed in the tar.
Sure, that's what I've said.

> We'll try to have the package working with no resource file installed at all,
I don't think it's possible or a good idea, but whatever.
> but would it be acceptable to have it in the source package or a repack
> would be needed?
Sourceless files shouldn't be in the source package even if they are not
used.

> > The GUIs still have a "Check online" checkbox which is even on by default
> > even if it has no effect, it should be hidden.
> Ok, thanks for the care you are giving to this package.
> To fix this a patch or a new upstream release is required. Are both options
> acceptable?
Which both options?

-- 
WBR, wRAR


signature.asc
Description: PGP signature

Bug#869692: RFS: cyclograph/1.9.0-1

[Federico Brega]

> Patch headers should be in the DEP-3 format (lintian tells that).

Now I have to ask for the option needed for lintian to tell that.
I run lintian --display-info and it is not reporting anything about the patches.
The lintian report at https://mentors.debian.net/package/cyclograph
isn't showing anything suspicious either.
How can I get that kind of level out of lintian?

> Instead of "Removed pycompat file because lintinan says it is obsolete"
> you should write "Removed obsolete debian/pycompat".
Ok

> doc/manual.html says it's autogenerated from a LyX source yet the source
> and a way to regenerate it from that source are not included. This is a
> DFSG violation.
It's not auto-generated, but generated. I use LyX as my editor, it saves
the file in an internal format, and I export it to html.
I don't see any violation to DFSG §2, which is the closes to the subject.
I'm sure may other packages have some kind of xml in their sources but
the editor is not listed in the B-D.

> The same for cyclograph/qt/cyclograph_rc.py which is pyrcc5-generated.
I agree more on this, because the resource file is a kind of binary /
obfuscated code. It contains only artworks and the same html files used
by cyclograph-gtk3. If the generation process has to be done in debian
I don't think a new upstream release can be avoided, because the file
needed to build the resource file is not distributed in the tar.
We'll try to have the package working with no resource file installed at all,
but would it be acceptable to have it in the source package or a repack
would be needed?

> The GUIs still have a "Check online" checkbox which is even on by default
> even if it has no effect, it should be hidden.
Ok, thanks for the care you are giving to this package.
To fix this a patch or a new upstream release is required. Are both options
acceptable?

--
Federico

Bug#869692: RFS: cyclograph/1.9.0-1

[Andrey Rahmatullin]

Control: tags -1 + moreinfo

New typos in the changelog entry: "linitian", "descroption". Patch headers
have typos too.
debian/format is garbage.
debian/stamp-patched too.
Patch headers should be in the DEP-3 format (lintian tells that).
Instead of "Removed pycompat file because lintinan says it is obsolete"
you should write "Removed obsolete debian/pycompat".
doc/manual.html says it's autogenerated from a LyX source yet the source
and a way to regenerate it from that source are not included. This is a
DFSG violation.
The same for cyclograph/qt/cyclograph_rc.py which is pyrcc5-generated.
The GUIs still have a "Check online" checkbox which is even on by default
even if it has no effect, it should be hidden.

-- 
WBR, wRAR


signature.asc
Description: PGP signature

Bug#869692: RFS: cyclograph/1.9.0-1

[Federico Brega]

>> Please take a look at the new changelog and see if this is now clear.
> It's better, but I would write it in this way:
>
> - Switch to pybuild
> - Add dh-python, python3-all, python3-setuptools to Build-Depends
> - Switch the cyclograph package to Python 3
Ok, this looks very clear.

>> > * The package now uses dh-python in combination with python3-setuptools
>> > "in combination"?
>> My understanding is that pybuild, provided by the dh-python package,
>> needs the setuptools for python3
> Why do you think pybuild needs setuptools? The package seems to build fine
> without that B-D.

I think you are right. I didn't understand how pybuild works.
Setuptools is not needed.

> It seems you haven't run lintian:
...
> At least vcs-field-uses-insecure-uri, vcs-field-not-canonical and
> spelling-error-in-changelog are caused by the changes in this upload, but
> you should fix other problems too.

gbp buildpackage runs lintian with the standard level, so I missed the
info, and I did not run it again aftr changing the chagelog at last. I
tried getting rid of all the warnings and most of the infos.


> Why there is no separate section for debian/ in debian/copyright? Are the
> copyright authors the same for it and the software itself?

Yes the copyright authors are the same of the package authors. Is a
separate section needed also in this case?

> You should fix the .desktop files. Currently having "python
> /usr/bin/cyclograph" there is not just unneeded, it's wrong, as
> /usr/bin/cyclograph is now using Python 3.

I added desktopFilesFix.diff in debian/patches

> Priority should be optional, not extra.
Ok

Thank you for your help
--
Federico

Bug#869692: RFS: cyclograph/1.9.0-1

[Andrey Rahmatullin]

On Sat, Jul 29, 2017 at 09:46:49PM +0200, Federico Brega wrote:
> 2017-07-29 19:34 GMT+02:00 Andrey Rahmatullin :
> > * The package now depends on python3
> > Which package?
> It's both a build dependency and a runtime dependency of "cyclograph"
> the main binary package. The cyclograph-qt5 and cyclograph-gtk3 binary
> packages depend on cyclograph, so they all depend on python3.
> Please take a look at the new changelog and see if this is now clear.
It's better, but I would write it in this way:

- Switch to pybuild
- Add dh-python, python3-all, python3-setuptools to Build-Depends
- Switch the cyclograph package to Python 3

> > * The package now uses dh-python in combination with python3-setuptools
> > "in combination"?
> My understanding is that pybuild, provided by the dh-python package,
> needs the setuptools for python3
Why do you think pybuild needs setuptools? The package seems to build fine
without that B-D.


It seems you haven't run lintian:

I: cyclograph source: debian-pycompat-is-obsolete
I: cyclograph source: vcs-field-uses-insecure-uri vcs-git 
git://git.debian.org/pkg-running/cyclograph.git
I: cyclograph source: vcs-field-not-canonical 
git://git.debian.org/pkg-running/cyclograph.git 
https://anonscm.debian.org/git/pkg-running/cyclograph.git
I: cyclograph source: vcs-field-uses-insecure-uri vcs-browser 
http://git.debian.org/?p=pkg-running/cyclograph.git;a=summary
I: cyclograph source: vcs-field-not-canonical 
http://git.debian.org/?p=pkg-running/cyclograph.git;a=summary 
https://anonscm.debian.org/git/pkg-running/cyclograph.git;a=summary
I: cyclograph source: quilt-patch-missing-description removeUpdatesCheck.diff
I: cyclograph source: quilt-patch-missing-description useOpenLayersPackage.diff
I: cyclograph source: testsuite-autopkgtest-missing
I: cyclograph source: debian-watch-file-is-missing
W: cyclograph-qt5: spelling-error-in-changelog upsteam upstream
I: cyclograph-qt5: unknown-field-in-control tag
I: cyclograph-qt5: desktop-entry-contains-encoding-key 
usr/share/applications/cyclograph-qt.desktop:3 Encoding
I: cyclograph-qt5: desktop-entry-lacks-keywords-entry 
usr/share/applications/cyclograph-qt.desktop
W: cyclograph: spelling-error-in-changelog upsteam upstream
I: cyclograph: unknown-field-in-control tag
X: cyclograph: privacy-breach-generic usr/share/cyclograph/openlayers.html 
(http://maps.google.com/maps/api/js?v=3.3sensor=false)
X: cyclograph: privacy-breach-generic usr/share/doc/cyclograph/manual.html 
(http://elyxer.nongnu.org/lyx.css)
W: cyclograph-gtk3: spelling-error-in-changelog upsteam upstream
I: cyclograph-gtk3: unknown-field-in-control tag
I: cyclograph-gtk3: desktop-entry-contains-encoding-key 
usr/share/applications/cyclograph-gtk3.desktop:3 Encoding
I: cyclograph-gtk3: desktop-entry-lacks-keywords-entry 
usr/share/applications/cyclograph-gtk3.desktop
N: 2 tags overridden (2 warnings)

At least vcs-field-uses-insecure-uri, vcs-field-not-canonical and
spelling-error-in-changelog are caused by the changes in this upload, but
you should fix other problems too.

Why there is no separate section for debian/ in debian/copyright? Are the
copyright authors the same for it and the software itself?

You should fix the .desktop files. Currently having "python
/usr/bin/cyclograph" there is not just unneeded, it's wrong, as
/usr/bin/cyclograph is now using Python 3.

Priority should be optional, not extra.

-- 
WBR, wRAR


signature.asc
Description: PGP signature

Bug#869692: RFS: cyclograph/1.9.0-1

[Federico Brega]

On the git server you can find a new commit with all the changes requested.

2017-07-29 19:34 GMT+02:00 Andrey Rahmatullin :
> * The package now depends on python3
> Which package?
It's both a build dependency and a runtime dependency of "cyclograph"
the main binary package. The cyclograph-qt5 and cyclograph-gtk3 binary
packages depend on cyclograph, so they all depend on python3.
Please take a look at the new changelog and see if this is now clear.
> * The package now uses dh-python in combination with python3-setuptools
> "in combination"?
My understanding is that pybuild, provided by the dh-python package,
needs the setuptools for python3, but, since it cannot know if python2
or python3 is used, the correct B-D has to be manually added.
Please take a look at the new changelog and see if this is now clear.
> * Added cyclograph-qt5 ui
> Not clear that cyclograph-qt5 is a new subpackage.
Ok, last entry in the changelog was about the removal of
cyclograph-qt4, but I can understand that a longer description in the
changelog is more useful.
> * Debhelper compat version updated to 10
> It's "compat level", see debhelper(7).
Sorry for that. I confused the Debhelper version, with the compatibility level.
> * Updated Standards to 4.0.0
> It's "Standards-Version", and it's customary to add "(no change needed)"
> if an upgrade to the new version didn't require anything (I assume you've
> read the upgrade checklist?).
I read the checklist[1] and I didn't find anything to be done.
"(no change needed)" added.
> * Updated gtk to webkit2 version 4.0
> Not clear what is "gtk" here.
This is the "cyclograph-gtk3".
> * Added vcs field to debian/control
> It's not a "vcs" field but Vcs-Git and Vcs-Browser.
Modified
> You also didn't mention the switch to pybuild.
Added

 [1] https://www.debian.org/doc/packaging-manuals/upgrading-checklist.txt
--
Federico

Bug#869692: RFS: cyclograph/1.9.0-1

[Andrey Rahmatullin]

On Fri, Jul 28, 2017 at 08:08:52PM +0200, Federico Brega wrote:
> > And there are other changes (about python for example) that are not listed
> > in the changelog.
> I listed all the changes done to files in the "debian" folder. The
> other changes are
> all made by upstream and, in my understanding, are out of scope from the 
> debian
> changelog.

* The package now depends on python3
Which package?
* The package now uses dh-python in combination with python3-setuptools
"in combination"? 
* Added cyclograph-qt5 ui
Not clear that cyclograph-qt5 is a new subpackage.
* Debhelper compat version updated to 10
It's "compat level", see debhelper(7).
* Updated Standards to 4.0.0
It's "Standards-Version", and it's customary to add "(no change needed)"
if an upgrade to the new version didn't require anything (I assume you've
read the upgrade checklist?).
* Updated gtk to webkit2 version 4.0
Not clear what is "gtk" here.
* Added vcs field to debian/control
It's not a "vcs" field but Vcs-Git and Vcs-Browser.

You also didn't mention the switch to pybuild.

-- 
WBR, wRAR


signature.asc
Description: PGP signature

Bug#869692: RFS: cyclograph/1.9.0-1

[Federico Brega]

Thank you Andrey for your help.
My changes to your suggestions are commented below and can be found in the
git repository.

> You don't need to add your name in brackets if there are no other names.
Removed

>>   * Debhelper compat version updated to 9
> The current recommended level is 10.
Switched to 10, both in debian/compat and in Build-Depends: debhelper (>= 10~)

> And there are other changes (about python for example) that are not listed
> in the changelog.
I listed all the changes done to files in the "debian" folder. The
other changes are
all made by upstream and, in my understanding, are out of scope from the debian
changelog.

Please tell me if I misunderstood something.
Regards
--
Federico

Bug#869692: RFS: cyclograph/1.9.0-1

[Andrey Rahmatullin]

On Tue, Jul 25, 2017 at 07:41:12PM +0200, Federico Brega wrote:
> cyclograph (1.9.0-1) UNRELEASED; urgency=medium
> 
>   [ Federico Brega ]
You don't need to add your name in brackets if there are no other names.

>   * Debhelper compat version updated to 9
The current recommended level is 10.

And there are other changes (about python for example) that are not listed
in the changelog.

-- 
WBR, wRAR


signature.asc
Description: PGP signature

Bug#869692: RFS: cyclograph/1.9.0-1

[Federico Brega]

Package: sponsorship-requests
Severity: important

Dear mentors,

I am looking for a sponsor for my package "cyclograph":

git://git.debian.org/pkg-running/cyclograph.git

It can be built with gbp.

Changes since the last upload:
This is important because it is currently affected by and RC bug, which
is closed by this upload.

cyclograph (1.9.0-1) UNRELEASED; urgency=medium

  [ Federico Brega ]
  * New upstream release
  * Added cyclograph-qt5 ui
  * Debhelper compat version updated to 9
  * Updated Standards to 4.0.0
  * Updated gtk to webkit2 version 4.0 (closes: bug#866635)
  * Added vcs field to debian/control

  -- Federico Brega   Sat, 15 Jul 2017 16:16:41 +0200

Regards,
Federico Brega