[GitHub] activemq-artemis issue #2025: ARTEMIS-1815 adding exclusive-queue example

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/2025
  
I amended your commits before merging... 

examples are now checked for checkstyle also now :)


---

[GitHub] activemq-artemis pull request #2025: ARTEMIS-1815 adding exclusive-queue exa...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/2025


---

[GitHub] activemq-artemis issue #2025: ARTEMIS-1815 adding exclusive-queue example

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/2025
  
this would also fail checkstyle


---

[GitHub] activemq-artemis pull request #2024: ARTEMIS-1814 Try original connection wh...

[clebertsuconic]

GitHub user clebertsuconic reopened a pull request:

https://github.com/apache/activemq-artemis/pull/2024

ARTEMIS-1814 Try original connection when every other node failed

@michaelandrepearce @mtaylor this one will interest you I think

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/clebertsuconic/activemq-artemis ARTEMIS-1814

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/2024.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2024


commit 415fb3ead284464824b0bbe51a6fc1cebdb27950
Author: Clebert Suconic 
Date:   2018-04-16T21:44:21Z

ARTEMIS-1814 Try original connection when every other node failed




---

ApacheCon current-event banner

[Piergiorgio Lucidi]

Hi,

I'm contributing in the Apache ComDev project and we would like to spread
out informations about Apache-related events such as ApacheCon.

Rich Bowen started a thread about this topic and we are actually searching
to use a dynamic banner that will be updated automatically without the need
to update the website everytime for every new event. On the
dev@community.a.o list Rich Bowen asked to get this included in as many
project websites as possible [2].

It would be great to have also ActiveMQ website updated to include the
current-event banner described in the first step of this README [1].

To track the progress of all projects updating their website, a link to
this thread will be put in a shared google spreadsheet [3].

Thank you so much for your cooperation.

Cheers,
PJ

[1] - http://apache.org/events/README.txt
[2] -
https://lists.apache.org/thread.html/d672b1849f6668c0f67ff4c71b20bbb4f56a49a1777607b12643d1dc@%3Cdev.community.apache.org%3E
[3] -
https://docs.google.com/spreadsheets/d/101O3EVBYv_QhHW74bFLoO89ydaXoUJW4AC97YhnR530/edit#gid=0

[GitHub] activemq-artemis pull request #2026: NO-JIRA Adding examples verification in...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/2026


---

[GitHub] activemq-artemis issue #2025: ARTEMIS-1815 adding exclusive-queue example

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/2025
  
@pgfox  please rebase, also add the new example under run-examples under 
artemis-distribution/src/test/script


---

[GitHub] activemq-artemis issue #2025: ARTEMIS-1815 adding exclusive-queue example

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/2025
  
@pgfox please, update run-examples.sh under 
artemis-distribution/src/tests/script


---

[GitHub] activemq-artemis issue #2025: ARTEMIS-1815 adding exclusive-queue example

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/2025
  
please, wait #2026 to be merged...

@pgfox I will need you to rebase once I merge #2026... I will let you know.


---

[GitHub] activemq-artemis pull request #2026: NO-JIRA Adding examples verification in...

[clebertsuconic]

GitHub user clebertsuconic opened a pull request:

https://github.com/apache/activemq-artemis/pull/2026

NO-JIRA Adding examples verification into travis



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/clebertsuconic/activemq-artemis travis

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/2026.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2026


commit bc0cf57d21bca92e9846d49893cd695911436db2
Author: Clebert Suconic 
Date:   2018-04-17T17:47:21Z

NO-JIRA Adding examples verification into travis




---

Re: [HEADS-UP] 2.5.1 in one week

[Clebert Suconic]

There's some house keeping to be done.. a few Pull Requests open
now... i will cut a release as soon as it's ready.


So.. if anyone needs time.. please let me know here. We can still do
another release in 2 or 3 weeks after this one.. (There's no need to
wait months before releases).

On Sun, Apr 15, 2018 at 9:40 PM, pwjenkins
 wrote:
> That would be great timing for us if you can do that without messing up your
> other plans. Thank you!
>
>
>
> --
> Sent from: http://activemq.2283324.n4.nabble.com/ActiveMQ-Dev-f2368404.html



-- 
Clebert Suconic

Re: [DISCUSS] Reopening Pull Requests..

[Clebert Suconic]

a... I think I know what it is...


if you change your commit ID, but the ID of master still the same..
perhaps there are no issues...


I would stick to this procedure though.. as it would always work.

On Tue, Apr 17, 2018 at 11:59 AM, Clebert Suconic
 wrote:
> for some reason that hasn't been the case on ActiveMQ Artemis. Perhaps
> because there's some mirroring happening?
>
> On Tue, Apr 17, 2018 at 10:32 AM, Jiri Danek  wrote:
>> And I also can force push into the branch and get rid of the previous
>> commits, so the PR seems to be completely restored.
>>
>> --
>> Jiri Daněk
>> Messaging QA
>
>
>
> --
> Clebert Suconic



-- 
Clebert Suconic

[GitHub] activemq-artemis issue #1982: JUnit rules to be usable against external secu...

[jbertram]

Github user jbertram commented on the issue:

https://github.com/apache/activemq-artemis/pull/1982
  
Here's the related Stack Overflow discussion: 
https://stackoverflow.com/questions/49564252/jms-test-util-for-junit-or-spock.


---

[GitHub] activemq-artemis issue #1982: JUnit rules to be usable against external secu...

[jbertram]

Github user jbertram commented on the issue:

https://github.com/apache/activemq-artemis/pull/1982
  
@mohamnag, any update on this?


---

[GitHub] activemq-artemis pull request #:

[clebertsuconic]

Github user clebertsuconic commented on the pull request:


https://github.com/apache/activemq-artemis/commit/2f0149c7598ed8c3adc2c0e5b0315fa07756dd4b#commitcomment-28619396
  
this commit broke the tests.. checkstyle


---

Re: [DISCUSS] Reopening Pull Requests..

[Clebert Suconic]

for some reason that hasn't been the case on ActiveMQ Artemis. Perhaps
because there's some mirroring happening?

On Tue, Apr 17, 2018 at 10:32 AM, Jiri Danek  wrote:
> And I also can force push into the branch and get rid of the previous
> commits, so the PR seems to be completely restored.
>
> --
> Jiri Daněk
> Messaging QA



-- 
Clebert Suconic

[GitHub] activemq-artemis pull request #2022: ARTEMIS-1813 DB2 should avoid Blob to a...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/2022


---

[GitHub] activemq-artemis pull request #1987: ARTEMIS-1781 Connector parameters not b...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1987


---

[GitHub] activemq-artemis pull request #2025: ARTEMIS-1815 adding exclusive-queue exa...

[pgfox]

GitHub user pgfox opened a pull request:

https://github.com/apache/activemq-artemis/pull/2025

ARTEMIS-1815 adding exclusive-queue example


To highlight the new exclusive queue functionality, add "exclusive-queue" 
example. see contained examples/features/standard/exclusive-queue/readme.md for 
more details. 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pgfox/activemq-artemis exclusive_queue_example

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/2025.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2025


commit 24442f8a63588f78b4a617a2d4a0c1cbfcc0bcb4
Author: Pat Fox 
Date:   2018-04-17T14:22:10Z

ARTEMIS-1815 adding exclusive-queue example




---

[GitHub] activemq-artemis issue #1987: ARTEMIS-1781 Connector parameters not backward...

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1987
  
the only reason I splitted into two commits is because it would be simpler 
to verify the fix.

Again.. thanks a lot for this.


---

[GitHub] activemq-artemis issue #1987: ARTEMIS-1781 Connector parameters not backward...

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1987
  
@TomasHofman  Kudos.. really nice...

i have done some tweaking though.. I'm removing TransportConstantsV2 and 
adding those properties directly on the Utility.. the TransportConstantsV2 name 
would be confusing and people would think that's the newest version to be 
used...

I have also split your commit into 2.. one for the tests and one for the 
fix... but I kept you the authorship.


I'm merging these myself as I don't see a point on going back and forth 
asking you to make these chagnes as I have them already...

I will apologize in advance as I'm pushing I change I made into your commit 
(removing the V2 class) but the github would be simpler if I amended my change 
into yours.. consider it like I have asked you to make the change and it's been 
done..


I'm merging it now.. but please check if you see anything wrong after I 
merged it.


---

Can I hide message details from web console?

[nitinghuge]

Hi,

 Can I hide message contents from active mq console? My message body
contains some sensitive information which should not be visible on console.
How can I do this? I am fine even if I can somehow disabled Atom link from
web console becuase if link is disabled then user will not be able to click
on message for view purpose and so message contents will not be available to
user.

Regards,
Nitin



--
Sent from: http://activemq.2283324.n4.nabble.com/ActiveMQ-Dev-f2368404.html

[GitHub] activemq-artemis pull request #2016: ARTEMIS-1808 LargeServerMessageImpl lea...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/2016


---

[GitHub] activemq-artemis pull request #2021: NO-JIRA: Fix test regression

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/2021


---

[GitHub] activemq-artemis pull request #2018: [ARTEMIS-1776] - Implement asynchronous...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/2018


---

Spinning loop in TcpTransportServer

[tpavelka]

Hello,
I am investigating a problem on z/OS where the socket accept loop in
TcpTransportServer can indefinitelly spin the CPU at 100% and churn out
large amounts of messages. I have opened the issue AMQ-6937 for this. While
working on this issue, I have discovered that the problem can happen on
Linux as well, when you run out of file descriptors you will get the same
tight loop.
I have put together a patch (attached to AMQ-6937) that slows down exception
handling so that these situations do not consume as much CPU.
Can somebody help me understand what do I need to do to make this patch
added to an ActiveMQ release? 

Thanks,
Tomas



--
Sent from: http://activemq.2283324.n4.nabble.com/ActiveMQ-Dev-f2368404.html

[GitHub] activemq-artemis pull request #2019: ARTEMIS-1810 JDBCSequentialFileFactoryD...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/2019


---

[GitHub] activemq-artemis pull request #1997: ARTEMIS-1653 Allow database tables to b...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1997


---

[GitHub] activemq-artemis pull request #2003: ARTEMIS-1788 JDBC HA should use JDBC Ne...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/2003


---

[GitHub] activemq-artemis pull request #2014: ARTEMIS-1806 JDBC Connection leaks

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/2014


---

Re: [DISCUSS] Reopening Pull Requests..

[Jiri Danek]

And I also can force push into the branch and get rid of the previous
commits, so the PR seems to be completely restored.

-- 
Jiri Daněk
Messaging QA

Re: [DISCUSS] Reopening Pull Requests..

[Jiri Danek]

On Tue, Apr 17, 2018 at 4:12 PM, Clebert Suconic 
wrote:

> If you close your pull request, you may reopen it if you keep the same
> git hash before you reopen it.
>

Worked for me even if I changed the hash of the last commit before
reopening.

my test PR is https://github.com/rh-messaging/cli-java/pull/48

1) I committed "Revert "Exclude" and "qpidjms 357",
2) pushed it to "jdanekrh:some_pr" branch
3) created the PR,
4) wrote comment,
5) closed pr,
6) committed one more thing to the branch
7) pushed it
8) reopened pr

and I have all the commits in the PR.

-- 
Jiri Daněk
Messaging QA

[GitHub] activemq-artemis pull request #2022: ARTEMIS-1813 DB2 should avoid Blob to a...

[franz1981]

GitHub user franz1981 reopened a pull request:

https://github.com/apache/activemq-artemis/pull/2022

ARTEMIS-1813 DB2 should avoid Blob to append data

DB2 10.5 doesn't allow to append Blob data to an existing Blob,
producing unexpected errors: a custom DB2 sequential file 
can perfom the append by using a customized UPDATE statement.
max-blob-size.db2 and create-file-table.db2 are changed to match the
2 GB max blob size limit allowed by DB2.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/franz1981/activemq-artemis ARTEMIS-1813

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/2022.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2022


commit 815debed0e571b8ddf247d8f48ac20081ddfbc25
Author: Francesco Nigro 
Date:   2018-04-16T14:52:08Z

ARTEMIS-1813 DB2 should avoid Blob to append data

DB2 10.5 doesn't allow to append Blob data to an existing Blob,
producing unexpected errors: a custom DB2 sequential file
can perfom the append by using a customized UPDATE statement.
max-blob-size.db2 and create-file-table.db2 are changed to match the
2 GB max blob size limit allowed by DB2.




---

Re: [DISCUSS] Reopening Pull Requests..

[Francesco Nigro]

Great, Clebert!

That's very useful: I have found sometimes my closed PRs unable to be
reopened...that's why.

Thanks!!

Il giorno mar 17 apr 2018 alle ore 16:13 Clebert Suconic <
clebert.suco...@gmail.com> ha scritto:

> If you close your pull request, you may reopen it if you keep the same
> git hash before you reopen it.
>
>
> So, on a real example, I opened
> https://github.com/apache/activemq-artemis/pull/2024
>
>
> Now I closed it as there's a minor test I need to fix... The current
> hash while closed is: 415fb3ead284464824b0bbe51a6fc1cebdb27950
>
>
> So, if I reopen it.. i have to reopen it still at
> 415fb3ead284464824b0bbe51a6fc1cebdb27950
>
> And then push the new commit with a -f into my branch.
>
>
>
>
> I never read any documentations about it.. but I can only assume it's
> how github will handle opening new PRs on top of your existing branch.
>
>
>
> --
> Clebert Suconic
>

[DISCUSS] Reopening Pull Requests..

[Clebert Suconic]

If you close your pull request, you may reopen it if you keep the same
git hash before you reopen it.


So, on a real example, I opened
https://github.com/apache/activemq-artemis/pull/2024


Now I closed it as there's a minor test I need to fix... The current
hash while closed is: 415fb3ead284464824b0bbe51a6fc1cebdb27950


So, if I reopen it.. i have to reopen it still at
415fb3ead284464824b0bbe51a6fc1cebdb27950

And then push the new commit with a -f into my branch.




I never read any documentations about it.. but I can only assume it's
how github will handle opening new PRs on top of your existing branch.



-- 
Clebert Suconic

[GitHub] activemq-artemis pull request #2020: ARTEMIS-1812 fix for missing (core) mes...

[clebertsuconic]

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/2020#discussion_r182086148
  
--- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java
 ---
@@ -829,7 +829,13 @@ public RoutingStatus route(final Message message,
 
   // TODO auto-create queues here?
   // first check for the auto-queue creation thing
-  if (bindings == null) {
+  if (bindings == null && 
!address.toString().equals("activemq.notifications")) {
--- End diff --

This seems a symptom of another issue instead of a proper fix.

it seems you are fixing a symptom of another issue. Accepting this fix will 
probably hide a real issue somewhere else.


Can you replicate this on a test.. so we can validate the real issue?


---

[GitHub] activemq-artemis issue #2022: ARTEMIS-1813 DB2 should avoid Blob to append d...

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/2022
  
@franz1981  to reopen this PR successfully on github.

Reopen it with the same git you have now... then push -f...

If you reopen it with a different git-ID it will fail and you would need to 
open a new one.


---

[GitHub] activemq-artemis issue #2022: ARTEMIS-1813 DB2 should avoid Blob to append d...

[franz1981]

Github user franz1981 commented on the issue:

https://github.com/apache/activemq-artemis/pull/2022
  
I'm closing it until the tests on it will pass :+1: 


---

[GitHub] activemq-artemis pull request #2022: ARTEMIS-1813 DB2 should avoid Blob to a...

[franz1981]

Github user franz1981 closed the pull request at:

https://github.com/apache/activemq-artemis/pull/2022


---

[GitHub] activemq-artemis pull request #2023: ARTEMIS-857 Add JMX endpoints to view a...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/2023


---

[GitHub] activemq-artemis issue #2015: ARTEMIS-1807 File-based Large Message encoding...

[franz1981]

Github user franz1981 commented on the issue:

https://github.com/apache/activemq-artemis/pull/2015
  
@michaelandrepearce I'm thinking with @orpiske which kind of test should 
make sense in order to emulate the correct use case to be stressed...
Please, can you share your throughts on that? 
I'm concerned about how much is OS configuration sensitive running those 
tests as well


---

[GitHub] activemq-artemis issue #1997: ARTEMIS-1653 Allow database tables to be creat...

[mtaylor]

Github user mtaylor commented on the issue:

https://github.com/apache/activemq-artemis/pull/1997
  
+1 Franz.

On Tue, 17 Apr 2018, 07:27 nlippke,  wrote:

> @franz1981  I totally agree. Broker should
> not run any DDL-Statements if tables are managed by a DBA.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> 
,
> or mute the thread
> 

> .
>



---

[GitHub] activemq-artemis issue #2023: ARTEMIS-857 Add JMX endpoints to view and rese...

[michaelandrepearce]

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/2023
  
Test case added to QueueControlTest


---

[GitHub] activemq-web pull request #4: Replace broken affiliate link with direct link

[vanbockryck]

GitHub user vanbockryck opened a pull request:

https://github.com/apache/activemq-web/pull/4

Replace broken affiliate link with direct link

The links (three identical ones on books.html) for the ActiveMQ-in-Action 
book are redirecting to a postaffiliatepro.com page. I have replaced them with 
a direct link to the manning page, i.e. 
https://www.manning.com/books/activemq-in-action.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/anova-be/activemq-web master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-web/pull/4.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4


commit 9b240c1d2d9574ff3da519027289cab631969ad6
Author: kevin.vanbockryck 
Date:   2018-04-17T07:18:36Z

Replace broken affiliate link with direct link




---

[GitHub] activemq-artemis issue #2013: ARTEMIS-1805 fix for broker operations in hawt...

[gaohoward]

Github user gaohoward commented on the issue:

https://github.com/apache/activemq-artemis/pull/2013
  
@stanlyDoge you got to remove @Override annotations from 
ActiveMQServerControlImpl also.


---

[GitHub] activemq-artemis issue #2013: ARTEMIS-1805 fix for broker operations in hawt...

[stanlyDoge]

Github user stanlyDoge commented on the issue:

https://github.com/apache/activemq-artemis/pull/2013
  
@gaohoward Done.


---

[GitHub] activemq-artemis issue #1997: ARTEMIS-1653 Allow database tables to be creat...

[franz1981]

Github user franz1981 commented on the issue:

https://github.com/apache/activemq-artemis/pull/1997
  
@nlippke @mtaylor I have updated this PR to avoid issues with concurrent 
creations of tables/indexes for the JDBC Journal with Oracle (there is a test 
attached): when a table seems to exists both CREATE TABLE and CREATE INDEX 
statements are no longer used to initialize it.
That is useful to allow a shared store to concurrently start 2 journals on 
the same database and while rebooting the broker with an empty journal (table 
already existent, but empty ie no need to create index twice).
That means that a DBA should take care to create table and indexes (if 
any), but if it will just create tables, the broker won't create any index on 
them, wdyt?


---