Re: HEADS-UP ActiveMQ Artemis 2.6.3 to be cut Friday the 10th
Hi Clebert Theres an NPE introduced in https://github.com/apache/activemq-artemis/commit/bf282e5e7d133e898f0dc4d08f4df87722fc5a91 I have commented on the PR that was merged that introduced it. So needs to be fixed before release. Sent from my Samsung Galaxy smartphone. Original message From: Clebert Suconic Date: 14/08/2018 02:37 (GMT+00:00) To: dev@activemq.apache.org Subject: Re: HEADS-UP ActiveMQ Artemis 2.6.3 to be cut Friday the 10th I fixed the compatibility issue, and a few other PRs merged. Does anyone see anything else blocking it.. or can we cut activemq artemis 2.6.3 tomorrow? On Fri, Aug 10, 2018 at 10:06 AM Clebert Suconic wrote: > > I will have to postpone to Monday... > > I have started working on a compatibility issue between 1.5 and 2.x > that I want to make sure before we release. > > > Meanwhile: I have cut a master git report, where I added a XREF of > commits on 2.6.x > > this is a current list I just cut of master versus 2.6.x, starting at > the mergebase between 2.6.x and master: > > https://clebertsuconic.github.io/2.6.x-gap.html > > > ^^ This will be helpful to show any missing commits between the two > branches. if anyone sees anything missing on 2.6.x let me know please. > On Wed, Aug 8, 2018 at 10:45 AM Clebert Suconic > wrote: > > > > I have been cherry-picking everything that makes sense from master into > > 2.6.x... > > > > I want to have a release cut on Friday/10th. I will start cutting it > > on Thurstday the 9th afternoon so the vote is sent Friday Morning (US > > EST time) > > > > If you are aware of any blockers for the 2.6.x.. please let me know. > > > > -- > > Clebert Suconic > > > > -- > Clebert Suconic -- Clebert Suconic
[GitHub] activemq-artemis pull request #2248: ARTEMIS-2030 only use interrupt during ...
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2248 ---
[GitHub] activemq-artemis issue #2199: ARTEMIS-1996 MappedSequentialFileFactory may c...
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2199 @franz1981 are you providing an alternative fix? If not why not lets merge this and later you can provide an alternative to replace this solution? ---
[GitHub] activemq-artemis pull request #2238: ARTEMIS-2023 Support 1x prefixes for JM...
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2238#discussion_r209819327
--- Diff:
artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/server/config/impl/ConnectionFactoryConfigurationImpl.java
---
@@ -623,6 +636,8 @@ public void decode(final ActiveMQBuffer buffer) {
deserializationBlackList =
BufferHelper.readNullableSimpleStringAsString(buffer);
deserializationWhiteList =
BufferHelper.readNullableSimpleStringAsString(buffer);
+
+ enable1xPrefixes = buffer.readableBytes() > 0 ? buffer.readBoolean()
: null;
--- End diff --
@clebertsuconic @jbertram Should default to 0, null would throw npe here,
as field being set is a promiti5
---
Re: HEADS-UP ActiveMQ Artemis 2.6.3 to be cut Friday the 10th
I fixed the compatibility issue, and a few other PRs merged. Does anyone see anything else blocking it.. or can we cut activemq artemis 2.6.3 tomorrow? On Fri, Aug 10, 2018 at 10:06 AM Clebert Suconic wrote: > > I will have to postpone to Monday... > > I have started working on a compatibility issue between 1.5 and 2.x > that I want to make sure before we release. > > > Meanwhile: I have cut a master git report, where I added a XREF of > commits on 2.6.x > > this is a current list I just cut of master versus 2.6.x, starting at > the mergebase between 2.6.x and master: > > https://clebertsuconic.github.io/2.6.x-gap.html > > > ^^ This will be helpful to show any missing commits between the two > branches. if anyone sees anything missing on 2.6.x let me know please. > On Wed, Aug 8, 2018 at 10:45 AM Clebert Suconic > wrote: > > > > I have been cherry-picking everything that makes sense from master into > > 2.6.x... > > > > I want to have a release cut on Friday/10th. I will start cutting it > > on Thurstday the 9th afternoon so the vote is sent Friday Morning (US > > EST time) > > > > If you are aware of any blockers for the 2.6.x.. please let me know. > > > > -- > > Clebert Suconic > > > > -- > Clebert Suconic -- Clebert Suconic
[GitHub] activemq-artemis issue #2241: Added a Spring Boot Sample integration
Github user ricardozanini commented on the issue: https://github.com/apache/activemq-artemis/pull/2241 Hi @jbertram! Done! ---
[GitHub] activemq-artemis pull request #2248: ARTEMIS-2030 only use interrupt during ...
GitHub user clebertsuconic opened a pull request: https://github.com/apache/activemq-artemis/pull/2248 ARTEMIS-2030 only use interrupt during shutdown on RA You can merge this pull request into a Git repository by running: $ git pull https://github.com/clebertsuconic/activemq-artemis ARTEMIS-2030 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/2248.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2248 commit 99d091a0eaa07f042ce5d689bff9a3bd5880f1b3 Author: Clebert Suconic Date: 2018-08-14T00:30:54Z ARTEMIS-2030 only use interrupt during shutdown on RA ---
[GitHub] activemq-artemis pull request #2247: ARTEMIS-2029 Fixing wire checks after r...
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2247 ---
[GitHub] activemq-artemis pull request #2246: ARTEMIS-2024 Enable SharedClientID on C...
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2246 ---
[GitHub] activemq-artemis issue #2243: Artemis-2022 create count messages with group ...
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2243 @michaelandrepearce for future PRs, the Adjust checkstyle commit could have been squashed to the previous commit. There's no need to keep checkstyle commits separately, unless you want to keep authorship of commits. The issue is that if any point I need to git bisect we may have broken commits. No big deal now.. but we should avoid it. ---
[GitHub] activemq-artemis issue #2247: ARTEMIS-2029 Fixing wire checks after reconnec...
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2247 @jbertram it's not.. there's a different packet on reconnect sessions. So that's not called. ---
[GitHub] activemq-artemis issue #2241: Added a Spring Boot Sample integration
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/2241 @ricardozanini, you should squash all of your commits so there's just one. ---
[GitHub] activemq-artemis issue #2247: ARTEMIS-2029 Fixing wire checks after reconnec...
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/2247 Seems OK. I would have thought that the channelVersion would get set when the session was re-created on the backup (e.g. in `org.apache.activemq.artemis.core.protocol.core.impl.ActiveMQPacketHandler#handleCreateSession`), but I guess that's not being called? ---
[GitHub] activemq-artemis issue #2247: ARTEMIS-2029 Fixing wire checks after reconnec...
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2247 Itâs a simple fix. I will have to adjust counts. As for everything else. Do u think this is ok ? ---
[GitHub] activemq-artemis issue #2241: Added a Spring Boot Sample integration
Github user ricardozanini commented on the issue: https://github.com/apache/activemq-artemis/pull/2241 @jbertram , @michaelandrepearce I've removed PooledJMS completely. Now users would rely only on amqp-starter for this sample. I couldn't found out what is the Travis issue. If someone point me out to the right direction, I could solve that as well. :) ---
[GitHub] activemq-artemis issue #2247: ARTEMIS-2029 Fixing wire checks after reconnec...
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2247 Yeah. I will fix it later today. ---
[GitHub] activemq-artemis issue #2247: ARTEMIS-2029 Fixing wire checks after reconnec...
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/2247 Looks like compatibility tests are failing. ---
Re: C# NMS Submission
I don't expect username and password to affect inactivity timeouts. Inactivity timeouts should only occur when the TCP connection between the client and broker is somehow excessively slow or stuck (e.g. if packets are not crossing the network properly). Versions of the client and server should not be an issue, although there _have_ been cases where different versions have caused problems. Note that version 5.5.2 of the broker is very, very old. Many bugs have been fixed since then. One thing to look at here is packet flow between the client and server. WireShark or tcpdump could be very helpful here. Hope this helps. Art On Tue, Aug 7, 2018 at 7:18 PM, raynera wrote: > I might be being stupid. Not creating my connection with a username & > password. Will try again when I'm back in the office! > > > > -- > Sent from: http://activemq.2283324.n4.nabble.com/ActiveMQ-Dev- > f2368404.html >
[GitHub] activemq-artemis issue #2241: Added a Spring Boot Sample integration
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/2241 @ricardozanini, I'd remove it completely from everything. ---
[GitHub] activemq-artemis issue #2241: Added a Spring Boot Sample integration
Github user ricardozanini commented on the issue: https://github.com/apache/activemq-artemis/pull/2241 @jbertram I will remove the dependency from PooledJMS. But I can mention it in the docs? Or I remove it at all? ---
[GitHub] activemq-artemis issue #2241: Added a Spring Boot Sample integration
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/2241 @ricardozanini, probably best to just close this PR based on @michaelandrepearce's feedback. If you want, you could remove the dependencies and make it a pure Spring Boot example and send another PR (or modify this one without closing it). ---
[GitHub] activemq-artemis issue #2241: Added a Spring Boot Sample integration
Github user ricardozanini commented on the issue: https://github.com/apache/activemq-artemis/pull/2241 I'm not in position to decide, but I could remove it and them add to the docs that one could use it for it's own use case. ---
[GitHub] activemq-artemis issue #2241: Added a Spring Boot Sample integration
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2241 The point with the example is essentially backing by adding the depenency that this is acceptable. To me its not. ---
[GitHub] activemq-artemis issue #2241: Added a Spring Boot Sample integration
Github user ricardozanini commented on the issue: https://github.com/apache/activemq-artemis/pull/2241 Justification behind use of JMS Pool: > The JMS pool provides configuration capabilities not available in the CachingConnectionFactory and prevent certain not ideal uses like caching consumer which one should really never do. The code does not preclude you from using the CachingConnectionFactory at all and you can use standard Spring bean trickery to control what is created in you app if you want so if you really need to use CachingConnectionFactory. The PooledJMS library also provides JMS 2.0 functionality which is useful for those want that. I'm going to add it to the README to make it clear to users. I'll correct the Travis issues and stash the commit to be consider to be merged. Thanks @michaelandrepearce and @jbertram! ---
[GitHub] activemq-artemis issue #2241: Added a Spring Boot Sample integration
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/2241 I can't speak the contributor rights and licensing issues as I've not looked into the fine print on that, but I would say that the comparison to CMS and NMS isn't a good one since those are both tied directly to the 5.x broker whereas the pool isn't. The pool is generic and could be used with any JMS client. I'm not involved at all with the pool so I can't identify the exact, original motivations for breaking it into it's own project, but from an outsider's perspective it makes sense to me. Clearly you disagree, but I'm not convinced that should stop this example from being merged. ---
[GitHub] activemq-artemis issue #2241: Added a Spring Boot Sample integration
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2241 @jbertram my issues are as follows: The code broken out doesn't attribute the original contributors over time, people who contribute have a right to keep their attribution. Peoples contributions were to the ASF, e.g. i contribute to activemq, on the basis my contribution remains in ASF, and i license my contribution to the foundation. I get that it has JMS 2.0 support, but thats should be something that in ActiveMQ i think should be supported and i think really its a shame people didnt contribute back to Apache Software Foundation. If this is really needed we should look to have in Artemis (which is the JMS 2.0 broker) or we can have a submodule like we have CMS and NMS. ---
[GitHub] activemq-artemis pull request #2246: ARTEMIS-2024 Enable SharedClientID on C...
Github user mtaylor commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2246#discussion_r209671702
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/client/ConnectionTest.java
---
@@ -131,6 +131,27 @@ public void testTwoConnectionsSameIDThroughCF() throws
Exception {
session2.close();
}
+ @Test
+ public void testTwoConnectionsSameIDThroughCFWithShareClientIDEnabeld()
throws Exception {
+ ActiveMQConnectionFactory connectionFactory = new
ActiveMQConnectionFactory("tcp://localhost:61616?clientID=myid;enableSharedClientID=true");
+
+ conn = connectionFactory.createConnection();
+ try {
+ conn2 = connectionFactory.createConnection();
+ } catch (InvalidClientIDException expected) {
+ Assert.fail("Should allow sharing of client IDs among the same
CF");
+ }
+
+ Session session1 = conn.createSession();
+ Session session2 = conn.createSession();
--- End diff --
Yes. Copy and paste error ;). Will fix.
---
[GitHub] activemq-artemis pull request #2246: ARTEMIS-2024 Enable SharedClientID on C...
Github user mtaylor commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2246#discussion_r209671517
--- Diff:
artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQConnection.java
---
@@ -673,12 +673,16 @@ protected final void checkClosed() throws
JMSException {
}
}
- public void authorize() throws JMSException {
+ public void authorize(boolean validateClientId) throws JMSException {
--- End diff --
The method was public I will add it back.
---
[GitHub] activemq-artemis issue #2241: Added a Spring Boot Sample integration
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/2241 IMO, the JMS pool from 5.x should not be migrated to Artemis. It belongs in it's own project with it's own release cycle. Also, it makes sense for it to *not* be in the ActiveMQ project to make clear that the pool is generic and isn't tied to any ActiveMQ broker. The pool on messaginghub has JMS 2.0 support. ---
[GitHub] activemq-artemis issue #2247: ARTEMIS-2029 Fixing wire checks after reconnec...
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2247 It's good now.. I found a change I added by mistake ---
[GitHub] activemq-artemis pull request #2247: ARTEMIS-2029 Fixing wire checks after r...
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2247#discussion_r209666896
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/CoreMessage.java
---
@@ -638,13 +638,9 @@ public synchronized CoreMessage encode() {
checkProperties();
- if (writableBuffer != null) {
--- End diff --
ouch.. don't merge this.. didn't mean this change
---
[GitHub] activemq-artemis pull request #2238: ARTEMIS-2023 Support 1x prefixes for JM...
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2238 ---
[GitHub] activemq-artemis issue #2246: ARTEMIS-2024 Enable SharedClientID on Connecti...
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2246 failed test: Failed tests: ConnectionFactoryPropertiesTest.testCompareConnectionFactoryAndResourceAdapterProperties:86->compare:97->Assert.fail:88 in ActiveMQ Connection Factory only: [enableSharedClientID] in ActiveMQ Resource Adapter only: [] ---
[GitHub] activemq-artemis pull request #2244: fix tyop
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2244 ---
[GitHub] activemq-artemis pull request #2247: ARTEMIS-2029 Fixing wire checks after r...
GitHub user clebertsuconic opened a pull request: https://github.com/apache/activemq-artemis/pull/2247 ARTEMIS-2029 Fixing wire checks after reconnects You can merge this pull request into a Git repository by running: $ git pull https://github.com/clebertsuconic/activemq-artemis compat Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/2247.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2247 commit 77d399e294239335b1c1960b690c8807b2e3713e Author: Clebert Suconic Date: 2018-08-13T15:49:19Z ARTEMIS-2029 Fixing wire checks after reconnects ---
[GitHub] activemq-artemis pull request #2246: ARTEMIS-2024 Enable SharedClientID on C...
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2246#discussion_r209658818
--- Diff:
artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQConnection.java
---
@@ -673,12 +673,16 @@ protected final void checkClosed() throws
JMSException {
}
}
- public void authorize() throws JMSException {
+ public void authorize(boolean validateClientId) throws JMSException {
--- End diff --
@michaelandrepearce that's internal API though
---
[GitHub] activemq-artemis pull request #2246: ARTEMIS-2024 Enable SharedClientID on C...
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2246#discussion_r209658786
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/client/ConnectionTest.java
---
@@ -131,6 +131,27 @@ public void testTwoConnectionsSameIDThroughCF() throws
Exception {
session2.close();
}
+ @Test
+ public void testTwoConnectionsSameIDThroughCFWithShareClientIDEnabeld()
throws Exception {
+ ActiveMQConnectionFactory connectionFactory = new
ActiveMQConnectionFactory("tcp://localhost:61616?clientID=myid;enableSharedClientID=true");
+
+ conn = connectionFactory.createConnection();
+ try {
+ conn2 = connectionFactory.createConnection();
+ } catch (InvalidClientIDException expected) {
+ Assert.fail("Should allow sharing of client IDs among the same
CF");
+ }
+
+ Session session1 = conn.createSession();
+ Session session2 = conn.createSession();
--- End diff --
Probably should test conn2 as well here?
---
[GitHub] activemq-artemis pull request #2246: ARTEMIS-2024 Enable SharedClientID on C...
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2246#discussion_r209658044
--- Diff:
artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQConnection.java
---
@@ -673,12 +673,16 @@ protected final void checkClosed() throws
JMSException {
}
}
- public void authorize() throws JMSException {
+ public void authorize(boolean validateClientId) throws JMSException {
--- End diff --
public interface change in client code, should probably keep the existing
method for people who may have coded against it.
---
[GitHub] activemq-artemis issue #2241: Added a Spring Boot Sample integration
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2241 @ricardozanini my point more here is if you need Pooled Connection Factory and it has valid use, then we should look to migrate and support it from ActiveMQ 5.x to ActiveMQ Artemis adding the JMS 2.0 support. ---
[GitHub] activemq-artemis issue #2245: ARTEMIS-2027: handle aborted AMQP deliveries
Github user gemmellr commented on the issue: https://github.com/apache/activemq-artemis/pull/2245 Merged to 2.6.x in commit c1c2d01bc525411d46cef1c7589e4a1e71e42b02 ---
[GitHub] activemq-artemis issue #2241: Added a Spring Boot Sample integration
Github user ricardozanini commented on the issue: https://github.com/apache/activemq-artemis/pull/2241 HI @michaelandrepearce! Thanks for your review. Regarding the sample and the differences between JMS Pool and Spring Caching feature, I'm going to edit the README file to enhance it with this details. I added the JMS Pool here because the [amqp-10-jms-spring-boot](https://github.com/amqphub/amqp-10-jms-spring-boot) itself is relying on it ([or if a reference to their classes are found in the classpath](https://github.com/amqphub/amqp-10-jms-spring-boot/blob/master/amqp-10-jms-spring-boot-autoconfigure/src/main/java/org/amqphub/spring/boot/jms/autoconfigure/AMQP10JMSAutoConfiguration.java#L58)). I may ask to the author why he's using JMS Pool instead of Spring's own feature. > I mostly have an issue here that Pooled CF you're bringing in from your side project (messaginghub) is originally Apache ActiveMQ 5 code, that rather than you contributing any fixes or enhancements to this and porting either to a subproject in ActiveMQ or to Artemis as a submodule, youve decided to host outside Apache, and lose all the attribution that others have made over time, https://github.com/apache/activemq/commits/master/activemq-jms-pool I'm sorry, but I'm not the author of this project. If the code is came from ActiveMQ, I understand that you're right and the code should be in here. I think we might need to contact the author. ---
[GitHub] activemq-artemis pull request #2245: ARTEMIS-2027: handle aborted AMQP deliv...
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2245 ---
[GitHub] activemq-artemis issue #2237: [ARTEMIS-2022] Create count messages 'group by...
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2237 Not atm afaik, as efforts are for bug fix release atm. ---
[GitHub] activemq-artemis pull request #2238: ARTEMIS-2023 Support 1x prefixes for JM...
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2238#discussion_r209626842
--- Diff:
artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/server/config/impl/ConnectionFactoryConfigurationImpl.java
---
@@ -623,6 +636,8 @@ public void decode(final ActiveMQBuffer buffer) {
deserializationBlackList =
BufferHelper.readNullableSimpleStringAsString(buffer);
deserializationWhiteList =
BufferHelper.readNullableSimpleStringAsString(buffer);
+
+ enable1xPrefixes = buffer.readBoolean();
--- End diff --
That's correct. I pushed a change to deal with the compatibility issue.
---
[GitHub] activemq-artemis pull request #2246: ARTEMIS-2024 Enable SharedClientID on C...
GitHub user mtaylor opened a pull request: https://github.com/apache/activemq-artemis/pull/2246 ARTEMIS-2024 Enable SharedClientID on ConnectionFactory You can merge this pull request into a Git repository by running: $ git pull https://github.com/mtaylor/activemq-artemis ARTEMIS-2024 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/2246.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2246 commit 3d7e60a6b9408bc2985e84a2370429dd024b4560 Author: Martyn Taylor Date: 2018-08-10T11:25:14Z ARTEMIS-2024 Enable SharedClientID on ConnectionFactory ---
[GitHub] activemq-artemis pull request #2238: ARTEMIS-2023 Support 1x prefixes for JM...
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2238#discussion_r209621351
--- Diff:
artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/server/config/impl/ConnectionFactoryConfigurationImpl.java
---
@@ -623,6 +636,8 @@ public void decode(final ActiveMQBuffer buffer) {
deserializationBlackList =
BufferHelper.readNullableSimpleStringAsString(buffer);
deserializationWhiteList =
BufferHelper.readNullableSimpleStringAsString(buffer);
+
+ enable1xPrefixes = buffer.readBoolean();
--- End diff --
yes.. but didn't you add a boolean? that would from my quick glance break
serialization with older versions.. wouldn't it?
---
[GitHub] activemq-artemis pull request #2238: ARTEMIS-2023 Support 1x prefixes for JM...
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2238#discussion_r209618198
--- Diff:
artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/server/config/impl/ConnectionFactoryConfigurationImpl.java
---
@@ -623,6 +636,8 @@ public void decode(final ActiveMQBuffer buffer) {
deserializationBlackList =
BufferHelper.readNullableSimpleStringAsString(buffer);
deserializationWhiteList =
BufferHelper.readNullableSimpleStringAsString(buffer);
+
+ enable1xPrefixes = buffer.readBoolean();
--- End diff --
This is a pretty rare use-case involving JMS connection factories
configured and stored on the broker-side. It's something that Wildfly does for
their client/server JNDI implementation. It's never used by the broker
standalone.
---
[GitHub] activemq-artemis pull request #2245: ARTEMIS-2027: handle aborted AMQP deliv...
GitHub user gemmellr opened a pull request: https://github.com/apache/activemq-artemis/pull/2245 ARTEMIS-2027: handle aborted AMQP deliveries Fixes handling of aborted deliveries to ensure the receiver processes the delivery (and any subsequent ones) appropriately. Unit tested only since Proton-J cant send aborted deliveries, though I have also verified it with modified client (slowed down) sending from client-> Dispatch -> Artemis and back and killing the client connection mid-send. I'd like this backported to 2.6.x also. You can merge this pull request into a Git repository by running: $ git pull https://github.com/gemmellr/activemq-artemis delivery-aborted Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/2245.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2245 commit e1ba608d64883f071442340ed091441187f48a01 Author: Robbie Gemmell Date: 2018-08-13T13:01:01Z ARTEMIS-2027: handle aborted AMQP deliveries ---
[GitHub] activemq-artemis issue #2244: fix tyop
Github user mberndt123 commented on the issue: https://github.com/apache/activemq-artemis/pull/2244 Done ---
[GitHub] activemq-artemis issue #2237: [ARTEMIS-2022] Create count messages 'group by...
Github user ArthurFritz commented on the issue: https://github.com/apache/activemq-artemis/pull/2237 Cool, is there an expected date for 2.7.0? ---
[GitHub] activemq-artemis issue #2237: [ARTEMIS-2022] Create count messages 'group by...
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2237 This is a feature not a bug fix, 2.6.3 is a bug fix release only. This would be in next feature release 2.7.0 ---
[GitHub] activemq-artemis issue #2244: fix tyop
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2244 Nice spot, could you just change the commit message to prefix it with NO-JIRA thanks. ---
[GitHub] activemq-artemis pull request #2244: fix tyop
GitHub user mberndt123 opened a pull request: https://github.com/apache/activemq-artemis/pull/2244 fix tyop You can merge this pull request into a Git repository by running: $ git pull https://github.com/mberndt123/activemq-artemis patch-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/2244.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2244 commit c34bfe0cbddc14ce6d486e551c05d0c596a27365 Author: Matthias Berndt Date: 2018-08-13T10:50:37Z fix tyop ---
[GitHub] activemq-artemis issue #2237: [ARTEMIS-2022] Create count messages 'group by...
Github user ArthurFritz commented on the issue: https://github.com/apache/activemq-artemis/pull/2237 @michaelandrepearce You're welcome. Would you know the expected date of version 2.6.3 ? ---
[GitHub] activemq-artemis issue #2237: [ARTEMIS-2022] Create count messages 'group by...
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2237 @ArthurFritz thanks for the contribution :) ---
[GitHub] activemq-artemis issue #2237: [ARTEMIS-2022] Create count messages 'group by...
Github user ArthurFritz commented on the issue: https://github.com/apache/activemq-artemis/pull/2237 Ok, thanks. ---
[GitHub] activemq-artemis pull request #2237: [ARTEMIS-2022] Create count messages 'g...
Github user ArthurFritz closed the pull request at: https://github.com/apache/activemq-artemis/pull/2237 ---
[GitHub] activemq-artemis issue #2237: [ARTEMIS-2022] Create count messages 'group by...
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2237 @ArthurFritz as your branch just had the changes i suggested, but also an additonal but un-needed extra merge commit, i merged from the branch i had of yours, https://github.com/apache/activemq-artemis/pull/2243. Could you close this? ---
[GitHub] activemq-artemis pull request #2243: Artemis-2022 create count messages with...
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2243 ---
[GitHub] activemq-artemis pull request #2241: Added a Spring Boot Sample integration
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2241#discussion_r209509591
--- Diff: examples/features/standard/spring-boot-integration/pom.xml ---
@@ -0,0 +1,94 @@
+http://maven.apache.org/POM/4.0.0;
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+ 4.0.0
+
+ org.apache.activemq.examples.broker
+ jms-examples
+ 2.7.0-SNAPSHOT
+
+ spring-boot-integration
+ ActiveMQ Artemis JMS Spring Boot Integration Example
+
+
+
${project.basedir}/../../../..
+
+
+ 2.0.1
+
+ 1.0.2
+
+
+
+
+ org.apache.activemq
+ artemis-amqp-protocol
+ ${project.version}
+
+
+ org.amqphub.spring
+ amqp-10-jms-spring-boot-starter
+ ${amqp-10-jms-spring.version}
+
+
+ org.messaginghub
--- End diff --
This does seem like If this is a spring boot example, and example using
Spring JMS CachingConnection Factory would be more suitable. As spring users
use this.
---
[GitHub] activemq-artemis pull request #2243: Artemis-2022 create count messages with...
GitHub user michaelandrepearce opened a pull request: https://github.com/apache/activemq-artemis/pull/2243 Artemis-2022 create count messages with group by filter You can merge this pull request into a Git repository by running: $ git pull https://github.com/michaelandrepearce/activemq-artemis ARTEMIS-2022 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/2243.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2243 commit 259f3f8be9014b79503e1ed0ead8c9598f340ff6 Author: Arthur Fritz Santiago Date: 2018-08-10T14:49:16Z [ARTEMIS-2022] Create count messages 'group by' this property filter commit d7d7f7499cf7ca675f901090e3199ad71bc0f922 Author: Arthur Fritz Santiago Date: 2018-08-10T15:09:32Z [ARTEMIS-2022] Ajust checkstyle commit fdf3fadac52b94f060e8baff3e475c9f806b4baa Author: Michael André Pearce Date: 2018-08-10T21:37:26Z ARTEMIS-2022 - Enhancements Fix checkstyle Avoid duplicated logic Ability to filter and group Instantiate SimpleString property key once Get property value via getObjectProprty to ensure all special mapped properties such as in AMQPMessage would return Avoid a custom string to represent null, instead rely on Java's representation "null" by using Objects.toString to get the string value of the property value used to group by. ---
[GitHub] activemq-artemis pull request #2242: 2022
Github user michaelandrepearce closed the pull request at: https://github.com/apache/activemq-artemis/pull/2242 ---
[GitHub] activemq-artemis pull request #2242: 2022
GitHub user michaelandrepearce opened a pull request: https://github.com/apache/activemq-artemis/pull/2242 2022 You can merge this pull request into a Git repository by running: $ git pull https://github.com/michaelandrepearce/activemq-artemis 2022 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/2242.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2242 commit 259f3f8be9014b79503e1ed0ead8c9598f340ff6 Author: Arthur Fritz Santiago Date: 2018-08-10T14:49:16Z [ARTEMIS-2022] Create count messages 'group by' this property filter commit d7d7f7499cf7ca675f901090e3199ad71bc0f922 Author: Arthur Fritz Santiago Date: 2018-08-10T15:09:32Z [ARTEMIS-2022] Ajust checkstyle commit fdf3fadac52b94f060e8baff3e475c9f806b4baa Author: Michael André Pearce Date: 2018-08-10T21:37:26Z ARTEMIS-2022 - Enhancements Fix checkstyle Avoid duplicated logic Ability to filter and group Instantiate SimpleString property key once Get property value via getObjectProprty to ensure all special mapped properties such as in AMQPMessage would return Avoid a custom string to represent null, instead rely on Java's representation "null" by using Objects.toString to get the string value of the property value used to group by. commit 803e7021e987601ab62b9f5b09359adec76391a8 Author: Arthur Fritz Santiago Date: 2018-08-11T18:39:42Z Merge pull request #1 from michaelandrepearce/ARTEMIS-2022 ARTEMIS-2022 - Enhancements ---
[GitHub] activemq-artemis issue #2240: ARTEMIS-2025 Ensure correct calculation of mes...
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/2240 @clebertsuconic @mtaylor seems also MessageBodyTest.testBytesMessage is broker due to this change, and any PR build is failing now. ---
