[GitHub] webbery opened a new issue #14: How to keep selection range when DOM change for unchangeable article?

[GitBox]

webbery opened a new issue #14: How to keep selection range when DOM change for 
unchangeable article?
URL: https://github.com/apache/incubator-annotator/issues/14
 
 
   Hi, this may be an enchancement. Because I have no idea how to impliment it. 
   I have selected a range while other annotated part of my selection. If I 
used websocket to show these DOM changes, can I keep my selection?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] tilgovi commented on issue #14: How to keep selection range when DOM change for unchangeable article?

[GitBox]

tilgovi commented on issue #14: How to keep selection range when DOM change for 
unchangeable article?
URL: 
https://github.com/apache/incubator-annotator/issues/14#issuecomment-339200333
 
 
   Thanks for raising this issue.
   
   Right now there is very little in this repository other than some sample / 
demo code and a package for parsing and serializing selector fragments.
   
   Are you looking for help with Annotator.js, perhaps?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] webbery commented on issue #14: How to keep selection range when DOM change for unchangeable article?

[GitBox]

webbery commented on issue #14: How to keep selection range when DOM change for 
unchangeable article?
URL: 
https://github.com/apache/incubator-annotator/issues/14#issuecomment-339517953
 
 
   I use annotator.js of open annotator. But I do not update annotation 
simultaneously. If selection save as a node before update, it may be separated 
to two parts which can only select one of them in chrome.
   
   Because of that, it is still an idea I'm not implimented.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] tilgovi commented on issue #14: How to keep selection range when DOM change for unchangeable article?

[GitBox]

tilgovi commented on issue #14: How to keep selection range when DOM change for 
unchangeable article?
URL: 
https://github.com/apache/incubator-annotator/issues/14#issuecomment-339520195
 
 
   You are looking for a different repository: 
https://github.com/openannotation/annotator


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] webbery commented on issue #14: How to keep selection range when DOM change for unchangeable article?

[GitBox]

webbery commented on issue #14: How to keep selection range when DOM change for 
unchangeable article?
URL: 
https://github.com/apache/incubator-annotator/issues/14#issuecomment-339524307
 
 
   Yes, I have used that repository in my nodejs project. And I'm not sure that 
my new idea can be implemented or not. Because this repository doesn't update 
for a long time. W3C create a new annotation standard. 
   
   This incubator will be better than openannotation. So I think it may have 
some way to keeping selection? :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Treora opened a new pull request #15: Hackathon produce

[GitBox]

Treora opened a new pull request #15: Hackathon produce
URL: https://github.com/apache/incubator-annotator/pull/15
 
 
   Some unfinished code, but possibly a usable basis to start building things 
with. Implements TextQuoteSelector (anchoring as well as describing), a 
tentatively named 'AnySelector' for detecting the selector type, and arbitrary 
nesting through a RangeSelector or the refinedBy property. Everything is based 
on async generators, and designed to allow for optimisations (e.g. memoisation) 
at any level (hence the required `createSelector` step everywhere before being 
able to use a selector).
   
   Design and code by @tilgovi, @jakehartnell and myself.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] BigBlueHat commented on issue #15: Hackathon produce

[GitBox]

BigBlueHat commented on issue #15: Hackathon produce
URL: 
https://github.com/apache/incubator-annotator/pull/15#issuecomment-340585136
 
 
   This is great work, all! I'm ? to merge this code if @tilgovi and others 
are--and I'll do so tomorrow (or so) if I've not heard any reason not to.
   
   @Treora and @JakeHartnell thank you both for all the great work! @Treora 
we've talked briefly about you joining as a committer, and this commit proves 
you know what you're up against and have an interest in contributing. ? I'll 
get you up for a vote shortly based on this work.
   
   Much thanks all!
   
   @apache/annotator-committers (and folks seeing this on the list!) please 
review this code and add your thoughts.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] tilgovi commented on issue #15: Hackathon produce

[GitBox]

tilgovi commented on issue #15: Hackathon produce
URL: 
https://github.com/apache/incubator-annotator/pull/15#issuecomment-340588195
 
 
   There's lots to do for this to be ready for others to consume, but it's 
moving in a good direction. ? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] BigBlueHat commented on issue #15: Hackathon produce

[GitBox]

BigBlueHat commented on issue #15: Hackathon produce
URL: 
https://github.com/apache/incubator-annotator/pull/15#issuecomment-340759042
 
 
   Thanks @tilgovi. Let's make this our next level up, and we can begin to help 
folks understand this approach (documentation, add the demo to the site, etc), 
and hopefully get more folks contributing.
   
   Merging shortly.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] BigBlueHat closed pull request #15: Hackathon produce

[GitBox]

BigBlueHat closed pull request #15: Hackathon produce
URL: https://github.com/apache/incubator-annotator/pull/15
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/.eslintrc.yml b/.eslintrc.yml
index eabba44..19c4790 100644
--- a/.eslintrc.yml
+++ b/.eslintrc.yml
@@ -7,7 +7,6 @@ env:
 extends:
   - eslint:recommended
   - plugin:import/recommended
-  - google
   - prettier
 
 globals:
diff --git a/demo/index.html b/demo/index.html
index 202572f..fd67f41 100644
--- a/demo/index.html
+++ b/demo/index.html
@@ -3,12 +3,80 @@
   
 
 Apache Annotator (incubating) demo
+
+  * {
+box-sizing: border-box;
+  }
+  body {
+max-width: 50em;
+margin: 0 auto;
+padding: 1em;
+  }
+  .highlighted {
+background-color: rgba(255, 255, 120, 0.5);;
+border: 0.1px solid rgba(255, 100, 0, 0.8);;
+  }
+  #debugField {
+width: 20rem;
+float: right;
+color: #666;
+background: #f8f8f8;
+padding: 2em;
+height: 20em;
+overflow-y: scroll;
+resize: vertical;
+  }
+  #debugField.error {
+color: red;
+  }
+  #selectableText, #corpus {
+display: inline-block;
+max-width: 15em;
+padding: 1em;
+line-height: 1.4em;
+font-size: 18px;
+font-family: sans;
+border: 1px solid lightgrey;
+  }
+
   
   
-Search:
-
-
-  Hello, annotated world!
+
+  Hi! Let's play with some annotator tools! This page demonstrates https://www.w3.org/TR/2017/REC-annotation-model-20170223/";>selectors.
+
+
+  Try select some text in the first paragraph below:
+
+
+  Hello, annotated world! To annotate, or not to annotate, that is the 
question.
+
+
+  Hello, annotated world! To annotate, or not to annotate, that is the 
question.
+
+
+
+  Upon a change of selection, a
+  https://www.w3.org/TR/2017/REC-annotation-model-20170223/#text-quote-selector";>TextQuoteSelector
+  will be created, that describes what was selected.
+  The selector is serialised and shown the window location,
+  https://www.w3.org/TR/2017/NOTE-selectors-states-20170223/#frags";>as the 
fragment identifier.
+  Here on the right is the selector in its usual JSON format.
+  In the second paragraph, the selector is 'anchored', i.e. text it refers 
to is found and highlighted.
+
+
+  Notice how, when the text of your selection appears multiple times, just
+  enough characters around it are stored in the selector to find the right
+  occurrence again.
+
+
+  Also reasonably functional:
+  
+RangeSelector
 (https://www.w3.org/TR/2017/REC-annotation-model-20170223/#range-selector";>spec)
+Refining
 a selector using another selector (https://www.w3.org/TR/2017/REC-annotation-model-20170223/#refinement-of-selection";>spec)
+Multiple 
matches (but overlapping matches currently mess up the highlighter)
+Any deeper nesting 
of the above
+  
+
 
 
 
diff --git a/demo/index.js b/demo/index.js
index 0a4b0ac..2dff404 100644
--- a/demo/index.js
+++ b/demo/index.js
@@ -13,46 +13,112 @@
  * the License.
  */
 
-/* global corpus, query, module */
+/* global corpus, module */
 
 import * as fragment from '@annotator/fragment-identifier';
+import { describeTextQuoteByRange as describeRange } from '@annotator/text';
+// import { createAnySelector } from '@annotator/any';
 import mark from './mark.js';
 import search from './search.js';
 
-const input = () => {
-  const type = 'TextQuoteSelector';
-  const exact = query.value;
-  if (exact) {
-window.location.hash = fragment.stringify({ type, exact });
-  } else {
-window.history.replaceState(null, '', window.location.pathname);
-refresh();
-  }
-};
-
-const refresh = () => {
+const refresh = async () => {
   corpus.innerHTML = corpus.innerText;
   const identifier = window.location.hash.slice(1);
-  if (!identifier) return;
+  if (!identifier) {
+debugInfo();
+return;
+  }
   try {
 const { selector } = fragment.parse(identifier);
-const range = search(corpus, selector);
-if (range) mark(range);
+debugInfo(selector);
+const results = search(corpus, selector);
+const ranges = [];
+for await (let range of results) {
+  ranges.push(range);
+}
+for (let range of ranges) {
+  try {
+mark(range);
+  } catch (err) {
+console.log(`Failed to highlight text: 
${range.cloneContents().textContent}`)
+  }
+}
   } catch (e) {
+debugError(e);
 if (e instanceof fragment.SyntaxError) return;
 else throw e;
   }
 };
 
+const debugInfo =

[GitHub] BigBlueHat opened a new issue #16: Firefox selection weirdness in the demo

[GitBox]

BigBlueHat opened a new issue #16: Firefox selection weirdness in the demo
URL: https://github.com/apache/incubator-annotator/issues/16
 
 
   When I select content in the left-hand box in the demo, the selection jumps 
outside of the box and sometimes leaves earlier selections in place. Double 
clicking a word works fine, however.
   
   Also, if I double click near the `,` or `.` in the sentence the highlighting 
happens within the scope of the whole page--not just within the right-hand side 
box.
   
   Chrome does seem to have these issues.
   
   This trouble is in Firefox Dev Edition 57.0b12 (64-bit).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] tilgovi commented on issue #14: How to keep selection range when DOM change for unchangeable article?

[GitBox]

tilgovi commented on issue #14: How to keep selection range when DOM change for 
unchangeable article?
URL: 
https://github.com/apache/incubator-annotator/issues/14#issuecomment-343777264
 
 
   @webbery thank you again for bringing up your needs here. I'm going to close 
this issue because there is not a concrete action to take. This repository is 
very new but it's being designed with this kind of use case in mind.
   
   When we get close to our first release I'll go back through these issues and 
make sure to comment so that you and anyone else who is waiting to test the new 
packages can check that it addresses your needs.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] tilgovi closed issue #14: How to keep selection range when DOM change for unchangeable article?

[GitBox]

tilgovi closed issue #14: How to keep selection range when DOM change for 
unchangeable article?
URL: https://github.com/apache/incubator-annotator/issues/14
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] tilgovi commented on issue #13: fragment.js should have a license header

[GitBox]

tilgovi commented on issue #13: fragment.js should have a license header
URL: 
https://github.com/apache/incubator-annotator/issues/13#issuecomment-343777441
 
 
   pegjs/pegjs#491


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] tilgovi commented on issue #16: Firefox selection weirdness in the demo

[GitBox]

tilgovi commented on issue #16: Firefox selection weirdness in the demo
URL: 
https://github.com/apache/incubator-annotator/issues/16#issuecomment-343777537
 
 
   I can't reproduce this in the same environment.
   
   I'll close this for now, but am happy to work this out with you if it 
continues to be a problem.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] tilgovi closed issue #16: Firefox selection weirdness in the demo

[GitBox]

tilgovi closed issue #16: Firefox selection weirdness in the demo
URL: https://github.com/apache/incubator-annotator/issues/16
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] BigBlueHat opened a new pull request #17: Demo tweaks

[GitBox]

BigBlueHat opened a new pull request #17: Demo tweaks
URL: https://github.com/apache/incubator-annotator/pull/17
 
 
   Fixed the "big" demo link and tweaked a few other things to make the demo a 
wee bit nicer.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] BigBlueHat opened a new issue #16: Firefox selection weirdness in the demo

[GitBox]

BigBlueHat opened a new issue #16: Firefox selection weirdness in the demo
URL: https://github.com/apache/incubator-annotator/issues/16
 
 
   When I select content in the left-hand box in the demo, the selection jumps 
outside of the box and sometimes leaves earlier selections in place. Double 
clicking a word works fine, however.
   
   Also, if I double click near the `,` or `.` in the sentence the highlighting 
happens within the scope of the whole page--not just within the right-hand side 
box.
   
   Chrome does seem to have these issues.
   
   This trouble is in Firefox Dev Edition 57.0b12 (64-bit).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] BigBlueHat commented on issue #16: Firefox selection weirdness in the demo

[GitBox]

BigBlueHat commented on issue #16: Firefox selection weirdness in the demo
URL: 
https://github.com/apache/incubator-annotator/issues/16#issuecomment-344268089
 
 
   Here's what it looks like for me after double-clicking the first `,` in the 
selection area. You'll note in this case it *does* properly highlight the 
matching `, ` (the space gets added by the browser's handling of 
double-clicking text) in the display box, but then it also selects the `, ` in 
the content below (see the gray highlight after "In the second paragraph").
   
   ![screenshot-2017-11-14 apache annotator incubating 
demo](https://user-images.githubusercontent.com/43209/32783664-88fa74b8-c91a-11e7-87c4-7ee71e2a5dcd.png)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] BigBlueHat commented on issue #16: Firefox selection weirdness in the demo

[GitBox]

BigBlueHat commented on issue #16: Firefox selection weirdness in the demo
URL: 
https://github.com/apache/incubator-annotator/issues/16#issuecomment-344268822
 
 
   Double clicking the `.` at the end of the sentence shows the same 
situation--the highlight appearing in the content below the demo boxes. 
However, it does not display in the `#corpus` (right hand side display box) 
because on the left the text contains a `\n` but on the right that `\n` gets 
stripped (afaict) by the use of `innerText` when rendering the display.
   
   ![screenshot-2017-11-14 apache annotator incubating demo 
1](https://user-images.githubusercontent.com/43209/32783754-d8b85b46-c91a-11e7-8e0c-5e9ec2bd5c2c.png)
   
   The whitespace thing should be relatively trivial to fix, but the selecting 
outside of the intended area is probably a bug.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] BigBlueHat opened a new issue #18: Adding the demo to the site

[GitBox]

BigBlueHat opened a new issue #18: Adding the demo to the site
URL: https://github.com/apache/incubator-annotator/issues/18
 
 
   Right now the demo in this repo is as much a dev environment as it is a 
demo--which is great! ? 
   
   However, I'd also like to package up the demo code (occasionally) and add it 
to the 
[apache/incubator-annotator-website](https://github.com/apache/incubator-annotator-website)
 repo.
   
   I'm new to webpack, so untangling the dev/build environment bits is what I 
need guidance in.
   
   Thanks!
   ? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Treora commented on issue #16: Firefox selection weirdness in the demo

[GitBox]

Treora commented on issue #16: Firefox selection weirdness in the demo
URL: 
https://github.com/apache/incubator-annotator/issues/16#issuecomment-344278340
 
 
   @BigBlueHat: just to check, might you have the [Precise 
links](https://addons.mozilla.org/en-US/firefox/addon/precise-links/) extension 
enabled? That could surely cause the out-of-box selection (it reacts to the 
fragment identifier, and applies it to the page as a whole).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] BigBlueHat closed issue #16: Firefox selection weirdness in the demo

[GitBox]

BigBlueHat closed issue #16: Firefox selection weirdness in the demo
URL: https://github.com/apache/incubator-annotator/issues/16
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] BigBlueHat commented on issue #16: Firefox selection weirdness in the demo

[GitBox]

BigBlueHat commented on issue #16: Firefox selection weirdness in the demo
URL: 
https://github.com/apache/incubator-annotator/issues/16#issuecomment-344359101
 
 
   @Treora I did indeed (at least in Firefox). Thank you!
   
   That was indeed the cause, as disabling it removed the "bug."
   
   Thanks, Gerben!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] tilgovi commented on issue #17: Demo tweaks

[GitBox]

tilgovi commented on issue #17: Demo tweaks
URL: 
https://github.com/apache/incubator-annotator/pull/17#issuecomment-346895581
 
 
   I'm gonna merge this. We should discuss the workflow we want going forward, 
but I think it's okay to push pretty quickly ahead right now.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] tilgovi closed pull request #17: Demo tweaks

[GitBox]

tilgovi closed pull request #17: Demo tweaks
URL: https://github.com/apache/incubator-annotator/pull/17
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] uskudarli opened a new issue #19: [incubator-annotator] capitalization error in imported module name asyncGenerator

[GitBox]

uskudarli opened a new issue #19: [incubator-annotator] capitalization error in 
imported module name asyncGenerator 
URL: https://github.com/apache/incubator-annotator/issues/19
 
 
   
   After installation of 
[incubator-annotator](https://github.com/apache/incubator-annotator)
   
   when the demo is started
   > yarn start
   the error:
   ERROR in 
./node_modules/@babel/runtime/helpers/builtin/es6/wrapAsyncGenerator.js
   Module not found: Error: Can't resolve './AsyncGenerator' 
   is encountered.
   
   Fixing the capitalization (from A to a) resolves the issue (import 
AsyncGenerator from "./asyncGenerator")
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] bjonnh opened a new issue #20: Upstream bug in babel?

[GitBox]

bjonnh opened a new issue #20: Upstream bug in babel?
URL: https://github.com/apache/incubator-annotator/issues/20
 
 
   I had to edit 
node_modules/\@babel/runtime/helpers/builtin/es6/wrapAsyncGenerator.js
   and change the AsyncGenerator.js include to asyncGenerator.js
   
   I?couldn't find that in the original babel code, they seem to use a 
generator.
   
   Filed a bug upstream: https://github.com/babel/babel/issues/6938
   
   I 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] bjonnh opened a new issue #21: Ability to use multiple layers of annotation.

[GitBox]

bjonnh opened a new issue #21: Ability to use multiple layers of annotation.
URL: https://github.com/apache/incubator-annotator/issues/21
 
 
   This kind of thing cannot be represented in a DOM easily, unless we have a 
tree and a way for each tree to just represent the index of the annotations in 
it.
   
   Working in a DOM:
   The cat is on the roof 
   
   Not working in a DOM:
...   
   
   I was envisionning something similar to (not following any W3C 
recommendation here, just an idea)
   
   Something is here
   
   is
   Something is here
   Something is
   is 
here
   
   
   
   But copying the text over and over is probably not a good idea?
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] BigBlueHat commented on issue #21: Ability to use multiple layers of annotation.

[GitBox]

BigBlueHat commented on issue #21: Ability to use multiple layers of annotation.
URL: 
https://github.com/apache/incubator-annotator/issues/21#issuecomment-348224795
 
 
   The way this has been done in the past (afaik) is to keep references to the 
groups of DOM nodes that represent a single annotation--and juggle all the 
interleaved DOM nodes if/when anything changes. It's beyond inefficient, but 
it's what happens when you cram to trees together...
   
   So, from your example, you'd end up with something like this (pseudo code 
here also):
   ```html
   Something is 
here
   
   And there's more text down here
   ```
   
   Lovely, right? ? The text in each selection would be:
   1. "is"
   2. "is here"
   3. "Something is here And there's more text"
   
   Presented as a tree this looks like:
   ```html
   
 Something 
 
   
 is
   
here
 
   
   
   
 And there's more text
 down here
   
   ```
   
   The DOM will think of (and treat) several of these `` tags as parents 
or children of other `` tags. The annotation software, however, would 
treat them as unrelated and remove/add/change their occurrences wherever 
they're found. Finding them is one thing 
(`document.querySelectorAll('[data-anno-id=3]`) creating them interleaved 
inside other stuff is entirely another...


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] BigBlueHat opened a new issue #2: Make `asf-site` the new `master`?

[GitBox]

BigBlueHat opened a new issue #2: Make `asf-site` the new `master`?
URL: https://github.com/apache/incubator-annotator-website/issues/2
 
 
   Right now the default git branch is `master`. The site, however, is 
published out of `asf-site`.
   
   Do we want to:
   a) use `asf-site` as our "prod" style branch (merge `master` into `asf-site` 
when it's "ready")
   b) drop `master` and make `asf-site` the new default branch (everything else 
branches out of it)
   
   I personally like option b. best, but a. can work too--as long as we make 
that clear and work it that way.
   
   Thoughts? @apache/annotator-committers ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] tilgovi commented on issue #20: Upstream bug in babel?

[GitBox]

tilgovi commented on issue #20: Upstream bug in babel?
URL: 
https://github.com/apache/incubator-annotator/issues/20#issuecomment-348292387
 
 
   Thank you! That does look like an upstream bug.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] tilgovi commented on issue #20: Upstream bug in babel?

[GitBox]

tilgovi commented on issue #20: Upstream bug in babel?
URL: 
https://github.com/apache/incubator-annotator/issues/20#issuecomment-348292626
 
 
   I think I might disable the runtime transformation for now. I'm having some 
other issues with it, too.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] tilgovi closed issue #19: [incubator-annotator] capitalization error in imported module name asyncGenerator

[GitBox]

tilgovi closed issue #19: [incubator-annotator] capitalization error in 
imported module name asyncGenerator 
URL: https://github.com/apache/incubator-annotator/issues/19
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] tilgovi commented on issue #19: [incubator-annotator] capitalization error in imported module name asyncGenerator

[GitBox]

tilgovi commented on issue #19: [incubator-annotator] capitalization error in 
imported module name asyncGenerator 
URL: 
https://github.com/apache/incubator-annotator/issues/19#issuecomment-348292908
 
 
   Look like @bjonnh diagnosed this is #20. I'm going to close this so we can 
track it in one place. Thanks so much!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] tilgovi commented on issue #21: Ability to use multiple layers of annotation.

[GitBox]

tilgovi commented on issue #21: Ability to use multiple layers of annotation.
URL: 
https://github.com/apache/incubator-annotator/issues/21#issuecomment-348294295
 
 
   This is helpful context for whomever wants to implement a highlighter, but 
we haven't got one yet. The demo adds `mark` do documents as an example of what 
could be done with the result of selection, but there's no exposed highlighter 
API yet.
   
   Where does that leave us with this issue? Is there more to discuss here 
right now? Would it be helpful for me to leave it open?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] tilgovi commented on issue #2: Make `asf-site` the new `master`?

[GitBox]

tilgovi commented on issue #2: Make `asf-site` the new `master`?
URL: 
https://github.com/apache/incubator-annotator-website/issues/2#issuecomment-348294655
 
 
   I might prefer option (a). Opening a PR from master is pretty lightweight 
and maybe a good signal for "publish the website (y/n)?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] tilgovi commented on issue #2: Make `asf-site` the new `master`?

[GitBox]

tilgovi commented on issue #2: Make `asf-site` the new `master`?
URL: 
https://github.com/apache/incubator-annotator-website/issues/2#issuecomment-348294864
 
 
   Oh, asf-site is the default branch as far as GitHub is concerned and I've no 
way to change that. Maybe let's just delete master then.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] BigBlueHat commented on issue #2: Make `asf-site` the new `master`?

[GitBox]

BigBlueHat commented on issue #2: Make `asf-site` the new `master`?
URL: 
https://github.com/apache/incubator-annotator-website/issues/2#issuecomment-348302736
 
 
   Ah. Seems you're right. ? to deleting `master`...which I think Infra needs 
to do. Correct @Humbedooh?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] tilgovi commented on issue #2: Make `asf-site` the new `master`?

[GitBox]

tilgovi commented on issue #2: Make `asf-site` the new `master`?
URL: 
https://github.com/apache/incubator-annotator-website/issues/2#issuecomment-348305222
 
 
   Nope. I just did it. ? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] tilgovi closed issue #2: Make `asf-site` the new `master`?

[GitBox]

tilgovi closed issue #2: Make `asf-site` the new `master`?
URL: https://github.com/apache/incubator-annotator-website/issues/2
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] BigBlueHat commented on issue #21: Ability to use multiple layers of annotation.

[GitBox]

BigBlueHat commented on issue #21: Ability to use multiple layers of annotation.
URL: 
https://github.com/apache/incubator-annotator/issues/21#issuecomment-348328566
 
 
   I think let's leave it open and begin planning/coding a highlighter. It's a 
super hard piece of this puzzle, and having that done will mean more annotation 
tools (built on Apache Annotator ta boot!). ? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] BigBlueHat closed issue #20: Upstream bug in babel?

[GitBox]

BigBlueHat closed issue #20: Upstream bug in babel?
URL: https://github.com/apache/incubator-annotator/issues/20
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] BigBlueHat commented on issue #20: Upstream bug in babel?

[GitBox]

BigBlueHat commented on issue #20: Upstream bug in babel?
URL: 
https://github.com/apache/incubator-annotator/issues/20#issuecomment-348328835
 
 
   Cool. I'll close this as needing to be upstreamed. @bjonnh you up for doing 
that? ? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] BigBlueHat opened a new issue #22: Build a highlighter

[GitBox]

BigBlueHat opened a new issue #22: Build a highlighter
URL: https://github.com/apache/incubator-annotator/issues/22
 
 
   This does eek into the realm of UX, so I want to proceed cautiously here. 
However, juggling the "mixed tree" environment discussed in #21 is likely to be 
a near everyday occurrence for folks building annotation tools.
   
   If we can collectively solve that issue well, we'll all win. ? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] BigBlueHat commented on issue #22: Build a highlighter

[GitBox]

BigBlueHat commented on issue #22: Build a highlighter
URL: 
https://github.com/apache/incubator-annotator/issues/22#issuecomment-348329370
 
 
   Additionally, this might help inform things the browsers need to 
change/tweak/add about how the DOM itself works and interacts.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Laurian commented on issue #22: Build a highlighter

[GitBox]

Laurian commented on issue #22: Build a highlighter
URL: 
https://github.com/apache/incubator-annotator/issues/22#issuecomment-348344479
 
 
   Many years ago, there was a xpointerlib.mozdev.org a Firefox add-on used for 
Annotea, that would insert into DOM elements to highlight annotations, while 
marking those nodes to be ignored in further operations, such that multiple 
annotations would still more or less anchor. 
   
   See `function isMarkedIgnore(element)` in 
https://www.mozdev.org/source/browse/xpointerlib/src/components/nsXPointerService.js?rev=1.21;content-type=text%2Fplain
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Laurian commented on issue #22: Build a highlighter

[GitBox]

Laurian commented on issue #22: Build a highlighter
URL: 
https://github.com/apache/incubator-annotator/issues/22#issuecomment-348344479
 
 
   Many years ago, there was http://xpointerlib.mozdev.org a Firefox add-on 
used for Annotea, that would insert into DOM elements to highlight annotations, 
while marking those nodes to be ignored in further operations, such that 
multiple annotations would still more or less anchor. 
   
   See `function isMarkedIgnore(element)` in 
https://www.mozdev.org/source/browse/xpointerlib/src/components/nsXPointerService.js?rev=1.21;content-type=text%2Fplain
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] tilgovi commented on issue #22: Build a highlighter

[GitBox]

tilgovi commented on issue #22: Build a highlighter
URL: 
https://github.com/apache/incubator-annotator/issues/22#issuecomment-348372006
 
 
   Worth taking inspiration from https://github.com/nickstenning/marks too


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] tilgovi commented on issue #22: Build a highlighter

[GitBox]

tilgovi commented on issue #22: Build a highlighter
URL: 
https://github.com/apache/incubator-annotator/issues/22#issuecomment-348372088
 
 
   Nice part about inserting `mark` tags is that it's super boring and the 
browser styles it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] tilgovi commented on issue #22: Build a highlighter

[GitBox]

tilgovi commented on issue #22: Build a highlighter
URL: 
https://github.com/apache/incubator-annotator/issues/22#issuecomment-348373026
 
 
   I take that back. I would rather not commit to any tag choice at all right 
now and just spend some time mulling over what problem(s) really need solving.
   
   Here are some more formed thoughts that have come up for me in the past:
   
   Q: How to denote things added by the annotation layer
   A: TDB, but also maybe just doesn't matter to some selectors
   
   Q: How to visualize style / modify the DOM
   A: TDB, but generally requires iterating over the text nodes for text use 
cases
   
   Q: How do we iterate over all the text nodes?
   A: `NodeIterator`, which I even built a polyfill for: 
https://github.com/tilgovi/dom-node-iterator
   
   I think we need to sketch a couple highlighter implementations and play with 
them.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] tilgovi commented on issue #20: Upstream bug in babel?

[GitBox]

tilgovi commented on issue #20: Upstream bug in babel?
URL: 
https://github.com/apache/incubator-annotator/issues/20#issuecomment-348724191
 
 
   This should be fixed now!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] tilgovi commented on issue #19: [incubator-annotator] capitalization error in imported module name asyncGenerator

[GitBox]

tilgovi commented on issue #19: [incubator-annotator] capitalization error in 
imported module name asyncGenerator 
URL: 
https://github.com/apache/incubator-annotator/issues/19#issuecomment-348724205
 
 
   This should be fixed now!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] tilgovi opened a new issue #23: Build infrastructure

[GitBox]

tilgovi opened a new issue #23: Build infrastructure
URL: https://github.com/apache/incubator-annotator/issues/23
 
 
   Set up build infrastructure for outputting ESM and CJS builds for the 
supported node/browser platforms.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] tilgovi commented on issue #13: fragment.js should have a license header

[GitBox]

tilgovi commented on issue #13: fragment.js should have a license header
URL: 
https://github.com/apache/incubator-annotator/issues/13#issuecomment-356065694
 
 
   Also, need to fix the license header in the fragment.pegjs file. I 
inappropriately added a comment at the top. I think, instead, that the full 
text of the W3C license needs to appear in LICENSE and a small notice in 
NOTICE, but nothing should be added to third-party code.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] tilgovi opened a new issue #24: LICENSE and NOTICE in packages

[GitBox]

tilgovi opened a new issue #24: LICENSE and NOTICE in packages
URL: https://github.com/apache/incubator-annotator/issues/24
 
 
   If packages are to be published to NPM, I think they should each have their 
own copy of LICENSE and NOTICE. It's possible we should concatenate all the 
NOTICE files into the root NOTICE file when preparing the "official" Apache 
release, or maintain such an aggregation by hand, but I think we want both.
   
   - When we publish to NPM, I want individual packages to have licenses and 
notices for their constituent code.
   
   - When we publish a source release of the whole repo, I want a LICENSE and 
NOTICE file that conforms to ASF expectations.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] tilgovi commented on issue #23: Build infrastructure

[GitBox]

tilgovi commented on issue #23: Build infrastructure
URL: 
https://github.com/apache/incubator-annotator/issues/23#issuecomment-356066429
 
 
   I have WIP on this. Working locally. I'm just working out the last kinks.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] tilgovi closed issue #23: Build infrastructure

[GitBox]

tilgovi closed issue #23: Build infrastructure
URL: https://github.com/apache/incubator-annotator/issues/23
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] tilgovi commented on issue #23: Build infrastructure

[GitBox]

tilgovi commented on issue #23: Build infrastructure
URL: 
https://github.com/apache/incubator-annotator/issues/23#issuecomment-356690706
 
 
   Closed by 4f7d0ec6b3e9567f6d38f573cf3e5ade98c3965b


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blahah opened a new issue #25: error: context not equal to range's container

[GitBox]

blahah opened a new issue #25: error: context not equal to range's container
URL: https://github.com/apache/incubator-annotator/issues/25
 
 
   Hi, I'm trying to use annotator to allow generating an annotation from any 
arbitrary selection in a web page.
   
   I'm having an issue with `describeTextQuoteByRange` from `@annotator/dom`.
   
   If I modify the demo so that the `context` passed to 
`describeTextQuoteByRange` is anything other than the original value 
(`selectable`), it fails with the error:
   
   ```
   Uncaught (in promise) Error: Context not equal to range's container; not 
implemented.
   at quote.js:48
   at Generator.next ()
   at step (asyncToGenerator.js:10)
   at _next (asyncToGenerator.js:25)
   at asyncToGenerator.js:32
   at new Promise ()
   at asyncToGenerator.js:5
   at describeTextQuoteByRange (quote.js:21)
   at HTMLDocument.onSelectionChange (mount.js:26)
   ```
   
   I copied the approach used in the demo - I create a range using `var 
selectableRange = document.createRange()`, then add a node using 
`selectableRange.selectNodeContents(el)`.
   
   I tried using `document.body` as `el`, and various other elements larger 
than `selectable`, but they all give the same error. I also tried leaving out 
the `context` key from the options object, same result.
   
   Can you provide any insight into how this should be done?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Treora commented on issue #25: error: context not equal to range's container

[GitBox]

Treora commented on issue #25: error: context not equal to range's container
URL: 
https://github.com/apache/incubator-annotator/issues/25#issuecomment-358286276
 
 
   As you may be aware, annotator's code is still very immature, and the most 
relevant part of the error message is the 'not implemented'. So in any case the 
solution should be to develop this function further, not to change the way you 
invoke it. I see I put a bit more info in the [source 
code](https://github.com/apache/incubator-annotator/blob/f7e7daab30949dccbf990105c08bfe887b1b6db9/packages/dom/src/text/quote.mjs#L38-L40):
   ```
 // FIXME We should get range index relative to context. Look at
 // dom-anchor-text-position? For now, we implement the easy case where the
 // ranges are within the same container.
   ```
   
   Would be good to sit down some time and develop this to a more usable state.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] BigBlueHat commented on issue #25: error: context not equal to range's container

[GitBox]

BigBlueHat commented on issue #25: error: context not equal to range's container
URL: 
https://github.com/apache/incubator-annotator/issues/25#issuecomment-358332423
 
 
   I did some digging and it seems like the demo code limits which nodes can be 
used in a way the underlying library code does not:
   
https://github.com/apache/incubator-annotator/blob/master/demo/index.js#L57-L59
   
   I'm not sure if this `isWithinNode()` method is solely for the demo's 
selection box, or if something like that is always needed when using the 
underlying library.
   
   This sounds like a job for @tilgovi! ? I'm happy to hack into it more, but 
some basic guidance would help me not make a mess. ? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Treora commented on issue #25: error: context not equal to range's container

[GitBox]

Treora commented on issue #25: error: context not equal to range's container
URL: 
https://github.com/apache/incubator-annotator/issues/25#issuecomment-358412575
 
 
   > I'm not sure if this isWithinNode() method is solely for the demo's 
selection box, or if something like that is always needed when using the 
underlying library.
   
   It is needed in the demo, because the (content of) the `#selectable` text 
box is regarded as the 'document' we are annotating (and the `#corpus` box next 
to it is the document the annotation is reapplied to). Passing a range that 
falls outside the document you are working in seems generally invalid. So the 
`isWithinNode` check is done because we pass the contents of `#selectable` as 
the `context` to `describeRange`.
   
   The actual issue here is more or less the other way around: if the 
context/'document' is larger than a single text node, e.g. the whole 
`document.body`, things should of course work fine, but that (most usual) 
situation not yet implemented.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] tilgovi commented on issue #25: error: context not equal to range's container

[GitBox]

tilgovi commented on issue #25: error: context not equal to range's container
URL: 
https://github.com/apache/incubator-annotator/issues/25#issuecomment-358420732
 
 
   Now that the build is in place, I'm comfortable importing dom-anchor-* 
libraries. I'll do that ASAP and then ping back this issue.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] tilgovi closed issue #13: Fragment identifier license chore

[GitBox]

tilgovi closed issue #13: Fragment identifier license chore
URL: https://github.com/apache/incubator-annotator/issues/13
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] tilgovi commented on issue #24: LICENSE and NOTICE in packages

[GitBox]

tilgovi commented on issue #24: LICENSE and NOTICE in packages
URL: 
https://github.com/apache/incubator-annotator/issues/24#issuecomment-372542013
 
 
   @BigBlueHat how do you think we should handle this? Do we want to treat the 
packages as sub-projects and put LICENSE + NOTICE in each one? Or treat it all 
as one big project with a single LICENSE + NOTICE at the root, but then what do 
we do about npm packages (nothing, maybe, and assume the license and URL in the 
package.json is enough to find the source)?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] BigBlueHat commented on issue #24: LICENSE and NOTICE in packages

[GitBox]

BigBlueHat commented on issue #24: LICENSE and NOTICE in packages
URL: 
https://github.com/apache/incubator-annotator/issues/24#issuecomment-372695059
 
 
   Given that npm distribution is still source code distribution, the LICENSE + 
NOTICE in each sub-project is likely the most correct.
   
   Another advantage that has is that NOTICE file contents are subsequently 
more correct.
   
   However, if we go that route, we'll also want a script (probably) that 
aggregates all the NOTICE files into one big one for the main project.
   
   Does that sound sensible?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] BigBlueHat commented on issue #24: LICENSE and NOTICE in packages

[GitBox]

BigBlueHat commented on issue #24: LICENSE and NOTICE in packages
URL: 
https://github.com/apache/incubator-annotator/issues/24#issuecomment-372695106
 
 
   @Humbedooh @jimjag is there someone we should reach out to within the ASF 
who could better answer this question?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] tilgovi commented on issue #24: LICENSE and NOTICE in packages

[GitBox]

tilgovi commented on issue #24: LICENSE and NOTICE in packages
URL: 
https://github.com/apache/incubator-annotator/issues/24#issuecomment-372765120
 
 
   That sounds right to me. Even the Babel-transipled source is source to me 
and I got help from a Babel maintainer yesterday to preserve license headers in 
transpiled files, even though I don't expect those will be in an Apache release 
and only distributed through npm.
   
   I think we should proceed that way and I'll figure out something reasonable 
for aggregating them, although maybe in the short term it's easy enough to do 
by hand. Probably not where we should spend coding time right now.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] djKooks opened a new issue #26: Documentation link error

[GitBox]

djKooks opened a new issue #26: Documentation link error
URL: https://github.com/apache/incubator-annotator/issues/26
 
 
   Hello,
   The link `development documentation` README file seems not connected. Could 
you look on?
   
   Also, is there any document which describes this project more clearly?
   
   Thanks


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] BigBlueHat opened a new issue #27: yarn install errors on a clean checkout

[GitBox]

BigBlueHat opened a new issue #27: yarn install errors on a clean checkout
URL: https://github.com/apache/incubator-annotator/issues/27
 
 
   I just did a clean checkout, and when I run `yarn` (or `yarn install`), I 
get this:
   ```
   yarn install v1.2.1
   error An unexpected error occurred: "patterns.map is not a function".
   info If you think this is a bug, please open a bug report with the 
information provided in 
"C:\\Users\\user-name\\dev\\annotator\\incubator-annotator\\yarn-error.log".
   info Visit https://yarnpkg.com/en/docs/cli/install for documentation about 
this command.
   ```
   
   Yarn version:  1.2.1
   Node version:  8.8.1
   Platform:  win32 x64
   ```
   Trace:
 TypeError: patterns.map is not a function
 at C:\Program Files (x86)\Yarn\lib\cli.js:53963:78
 at Generator.next ()
 at step (C:\Program Files (x86)\Yarn\lib\cli.js:92:30)
 at C:\Program Files (x86)\Yarn\lib\cli.js:110:14
 at new Promise ()
 at new F (C:\Program Files (x86)\Yarn\lib\cli.js:29382:28)
 at C:\Program Files (x86)\Yarn\lib\cli.js:89:12
 at Config.resolveWorkspaces (C:\Program Files 
(x86)\Yarn\lib\cli.js:53999:7)
 at C:\Program Files (x86)\Yarn\lib\cli.js:22025:49
 at Generator.next ()
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] BigBlueHat closed issue #27: yarn install errors on a clean checkout

[GitBox]

BigBlueHat closed issue #27: yarn install errors on a clean checkout
URL: https://github.com/apache/incubator-annotator/issues/27
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] BigBlueHat commented on issue #27: yarn install errors on a clean checkout

[GitBox]

BigBlueHat commented on issue #27: yarn install errors on a clean checkout
URL: 
https://github.com/apache/incubator-annotator/issues/27#issuecomment-374220124
 
 
   **/me** reads the README and upgrades to yarn 1.5.1
   
   ...which, of course, fixes the problem...


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] BigBlueHat commented on issue #24: LICENSE and NOTICE in packages

[GitBox]

BigBlueHat commented on issue #24: LICENSE and NOTICE in packages
URL: 
https://github.com/apache/incubator-annotator/issues/24#issuecomment-374380205
 
 
   Here's the official ASF stuff:
   https://apache.org/dev/licensing-howto.html#assembling-license-and-notice
   
   Pretty easy to copy/paste. 😁 I'll try and tackle this one soon.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] BigBlueHat closed issue #26: Documentation link error

[GitBox]

BigBlueHat closed issue #26: Documentation link error
URL: https://github.com/apache/incubator-annotator/issues/26
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] BigBlueHat commented on issue #26: Documentation link error

[GitBox]

BigBlueHat commented on issue #26: Documentation link error
URL: 
https://github.com/apache/incubator-annotator/issues/26#issuecomment-376955642
 
 
   @djKooks I updated the README to clarify that the "development 
documentation" is a `localhost` only resource atm. Hopefully that makes things 
clearer!
   
   Thanks for posting the issue!
   🎩 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] BigBlueHat commented on issue #24: LICENSE and NOTICE in packages

[GitBox]

BigBlueHat commented on issue #24: LICENSE and NOTICE in packages
URL: 
https://github.com/apache/incubator-annotator/issues/24#issuecomment-376959263
 
 
   @tilgovi @apache/annotator-committers I've added LICENSE to all packages and 
NOTICE to just (for now) `packages/fragment-identifier` based on my 
understanding of what's needed.
   
   Do we need NOTICE in all of the packages even if there's no additional code 
used (directly in our code; aka not merely a `dependency` in packages) from 
other projects? or is that file only present if we have used/modified code 
which we've also added to our project's repo?
   
   Once we know those answers, this issue MAY be close-able.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] tilgovi commented on issue #24: LICENSE and NOTICE in packages

[GitBox]

tilgovi commented on issue #24: LICENSE and NOTICE in packages
URL: 
https://github.com/apache/incubator-annotator/issues/24#issuecomment-376985238
 
 
   My read is that we should have a NOTICE file even if it contains nothing but 
our header. Per the ASL, the content of that NOTICE file would then be 
reproduced downstream if other consumers embed Annotator, and serves as a 
notice that the software includes Apache Annotator components.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] BigBlueHat closed issue #24: LICENSE and NOTICE in packages

[GitBox]

BigBlueHat closed issue #24: LICENSE and NOTICE in packages
URL: https://github.com/apache/incubator-annotator/issues/24
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] BigBlueHat opened a new issue #28: Failing during `yarn start`

[GitBox]

BigBlueHat opened a new issue #28: Failing during `yarn start`
URL: https://github.com/apache/incubator-annotator/issues/28
 
 
   The tests reference a `../lib` directory which is absent (perhaps 
auto-generated at runtime or something?) and it causes the following errors:
   ```
   ERROR in ./packages/selector/test/index.mjs
   Module not found: Error: Can't resolve '../lib' in 
'C:\Users\byoung2\dev\annotator\annotator\p
   ackages\selector\test'
@ ./packages/selector/test/index.mjs 1:0-35 4:21-29
@ ./node_modules/multi-entry-loader?include=./packages/*/test/**/*.mjs
@ 
./node_modules/mocha-loader!./node_modules/multi-entry-loader?include=./packages/*/test/**/
   *.mjs
@ multi chai/register-assert 
mocha-loader!multi-entry-loader?include=./packages/*/test/**/*.m
   js
   
   ERROR in ./packages/range/test/cartesian.mjs
   Module not found: Error: Can't resolve '../lib/cartesian.mjs' in 
'C:\Users\byoung2\dev\annotat
   or\annotator\packages\range\test'
@ ./packages/range/test/cartesian.mjs 5:0-47 48:19-26
@ ./node_modules/multi-entry-loader?include=./packages/*/test/**/*.mjs
@ 
./node_modules/mocha-loader!./node_modules/multi-entry-loader?include=./packages/*/test/**/
   *.mjs
@ multi chai/register-assert 
mocha-loader!multi-entry-loader?include=./packages/*/test/**/*.m
   js
   i ｢wdm｣: Failed to compile.
   ```
   
   Full log (containing the above) is below:
   ```bash
   $ yarn start
   yarn run v1.5.1
   $ webpack-serve
   i ｢hot｣: webpack: Compiling...
   i ｢hot｣: WebSocket Server Listening at localhost:8081
   i ｢serve｣: Project is running at http://localhost:8080
   i ｢serve｣: Server URI copied to clipboard
   i ｢hot｣: webpack: Compiling Done
   × ｢wdm｣: Hash: 48894b03e48351b3f485
   Version: webpack 4.1.1
   Time: 13734ms
   Built at: 2018-3-28 14:25:09
 Asset  Size  ChunksChunk Names
   demo.js   949 KiBdemo  [emitted]  [big]  demo
   test.js  2.48 MiBtest  [emitted]  [big]  test
   Entrypoint demo [big] = demo.js
   Entrypoint test [big] = test.js
   [./demo/index.js] 5.17 KiB {demo} [built]
   [./demo/mark.js] 804 bytes {demo} [built]
   [./node_modules/@babel/runtime/helpers/builtin/es6/asyncToGenerator.js] 709 
bytes {test} {demo
   } [built]
   [./node_modules/chai/index.js] 40 bytes {test} [built]
   [./node_modules/chai/register-assert.js] 38 bytes {test} [built]
   
[./node_modules/mocha-loader/index.js!./node_modules/multi-entry-loader/index.js?include=./pac
   kages/*/test/**/*.mjs!./] 
./node_modules/mocha-loader!./node_modules/multi-entry-loader?includ
   e=./packages/*/test/**/*.mjs 776 bytes {test} [built]
   
[./node_modules/webpack-hot-client/client/index.js?69a6d200-876a-4461-8380-b5c66ef55c63]
 (webp
   ack)-hot-client/client?69a6d200-876a-4461-8380-b5c66ef55c63 1.78 KiB {test} 
{demo} [built]
   [./node_modules/webpack-hot-client/client/socket.js] 
(webpack)-hot-client/client/socket.js 1.3
   7 KiB {test} {demo} [built]
   [./node_modules/webpack/buildin/global.js] (webpack)/buildin/global.js 509 
bytes {test} {demo}
[built]
   [./packages/dom/src/index.mjs] 1.74 KiB {demo} [built]
   [./packages/fragment-identifier/src/index.mjs] 1.31 KiB {demo} [built]
  [0] multi ./demo/index.js 28 bytes {demo} [built]
  [1] multi chai/register-assert 
mocha-loader!multi-entry-loader?include=./packages/*/test/**
   /*.mjs 40 bytes {test} [built]
  [2] multi webpack-hot-client/client?69a6d200-876a-4461-8380-b5c66ef55c63 
./demo/index.js 40
bytes {demo} [built]
  [3] multi webpack-hot-client/client?69a6d200-876a-4461-8380-b5c66ef55c63 
chai/register-asse
   rt mocha-loader!multi-entry-loader?include=./packages/*/test/**/*.mjs 52 
bytes {test} [built]
   + 209 hidden modules
   
   ERROR in ./packages/selector/test/index.mjs
   Module not found: Error: Can't resolve '../lib' in 
'C:\Users\byoung2\dev\annotator\annotator\p
   ackages\selector\test'
@ ./packages/selector/test/index.mjs 1:0-35 4:21-29
@ ./node_modules/multi-entry-loader?include=./packages/*/test/**/*.mjs
@ 
./node_modules/mocha-loader!./node_modules/multi-entry-loader?include=./packages/*/test/**/
   *.mjs
@ multi chai/register-assert 
mocha-loader!multi-entry-loader?include=./packages/*/test/**/*.m
   js
   
   ERROR in ./packages/range/test/cartesian.mjs
   Module not found: Error: Can't resolve '../lib/cartesian.mjs' in 
'C:\Users\byoung2\dev\annotat
   or\annotator\packages\range\test'
@ ./packages/range/test/cartesian.mjs 5:0-47 48:19-26
@ ./node_modules/multi-entry-loader?include=./packages/*/test/**/*.mjs
@ 
./node_modules/mocha-loader!./node_modules/multi-entry-loader?include=./packages/*/test/**/
   *.mjs
@ multi chai/register-assert 
mocha-loader!multi-entry-loader?include=./packages/*/test/**/*.m
   js
   i ｢wdm｣: Failed to compile.
   ```
   
   I changed the `../lib` references to `../src` in that case...but it happened 
again in another test. I'm not sure (yet) if this was a path change t

[GitHub] tilgovi commented on issue #28: Failing during `yarn start`

[GitBox]

tilgovi commented on issue #28: Failing during `yarn start`
URL: 
https://github.com/apache/incubator-annotator/issues/28#issuecomment-376990184
 
 
   I just noticed this, too. I've got some WIP to address it. I'll assign 
myself.
   
   For the moment, you can always run build and then test and they should pass.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] tilgovi commented on issue #28: Failing during `yarn start`

[GitBox]

tilgovi commented on issue #28: Failing during `yarn start`
URL: 
https://github.com/apache/incubator-annotator/issues/28#issuecomment-376990241
 
 
   Although, that won't work in the webpack tests, I think.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] BigBlueHat opened a new issue #29: Extract NOTICE related content from LICENSE file in fragment-identifier

[GitBox]

BigBlueHat opened a new issue #29: Extract NOTICE related content from LICENSE 
file in fragment-identifier
URL: https://github.com/apache/incubator-annotator/issues/29
 
 
   Because 
https://github.com/apache/incubator-annotator/commit/4766340e970815c3cb39d2b5a2e05bd56783e4c9#commitcomment-28336927


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] tilgovi closed issue #28: Failing during `yarn start`

[GitBox]

tilgovi closed issue #28: Failing during `yarn start`
URL: https://github.com/apache/incubator-annotator/issues/28
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] tilgovi commented on issue #28: Failing during `yarn start`

[GitBox]

tilgovi commented on issue #28: Failing during `yarn start`
URL: 
https://github.com/apache/incubator-annotator/issues/28#issuecomment-395918540
 
 
   Closed in c1f7fa1dfd84c27537cc20d244cfd48eb65462cd


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Treora opened a new pull request #30: Remove reselect/memoisation.

[GitBox]

Treora opened a new pull request #30: Remove reselect/memoisation.
URL: https://github.com/apache/incubator-annotator/pull/30
 
 
   Simplifies the code a lot, to help speed up development. similar 
optimisations could be reintroduced again later.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] tilgovi closed pull request #30: Remove reselect/memoisation.

[GitBox]

tilgovi closed pull request #30: Remove reselect/memoisation.
URL: https://github.com/apache/incubator-annotator/pull/30
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/packages/any/src/index.mjs b/packages/any/src/index.mjs
index 81e7cc3..6772eeb 100644
--- a/packages/any/src/index.mjs
+++ b/packages/any/src/index.mjs
@@ -13,13 +13,10 @@
  * the License.
  */
 
-import * as reselect from 'reselect';
 import { createTextQuoteSelector } from '@annotator/text';
 import { createRangeSelector } from '@annotator/range';
 import { makeRefinable } from '@annotator/refinedBy';
 
-const { createSelector } = reselect;
-
 export function createAnySelectorCreator(selectorCreatorsByType) {
   function selectSelector(type) {
 const selectorCreator = selectorCreatorsByType[type];
@@ -32,18 +29,11 @@ export function 
createAnySelectorCreator(selectorCreatorsByType) {
   }
 
   function createAnySelector() {
-const memoizedSelectSelector = createSelector(
-  descriptor => descriptor.type,
-  type => selectSelector(type)
-);
-
 async function* anySelector({ descriptors, context }) {
   const descriptor = descriptors[0]; // TODO handle multiple descriptors
-  const selectorFunc = memoizedSelectSelector(descriptor);
+  const selectorFunc = selectSelector(descriptor.type);
   yield* selectorFunc({ descriptors: [descriptor], context });
 }
-
-// Not wrapped with Tee; we expect the selector implementations to do that.
 return anySelector;
   }
 
diff --git a/packages/dom/package.json b/packages/dom/package.json
index ea510f4..29243e5 100644
--- a/packages/dom/package.json
+++ b/packages/dom/package.json
@@ -11,7 +11,6 @@
 "url": "https://gitbox.apache.org/repos/asf/incubator-annotator.git";
   },
   "dependencies": {
-"@annotator/selector": "0.0.0",
 "range-normalize": "^1.1.1"
   },
   "peerDependencies": {
diff --git a/packages/dom/src/index.mjs b/packages/dom/src/index.mjs
index 115a8cc..70a36bb 100644
--- a/packages/dom/src/index.mjs
+++ b/packages/dom/src/index.mjs
@@ -14,21 +14,6 @@
  */
 
 export * from './text';
-import { createSelectorCreator, defaultMemoize } from '@annotator/selector';
-
-function domEqualityCheck(a, b) {
-  if (a !== b) return false;
-  // TODO:
-  // - weakref the node
-  // - attach mutation listener
-  // - invalidate on mutations
-  return true;
-}
-
-const createDomSelector = createSelectorCreator(
-  defaultMemoize,
-  domEqualityCheck
-);
 
 export function createCssSelector(selectors) {
   const cssSelector = selectors.map(({ value }) => value).join(',');
@@ -37,5 +22,5 @@ export function createCssSelector(selectors) {
 yield* context.querySelectorAll(cssSelector);
   }
 
-  return createDomSelector(exec);
+  return exec;
 }
diff --git a/packages/range/src/index.mjs b/packages/range/src/index.mjs
index 6a78af6..ffe2906 100644
--- a/packages/range/src/index.mjs
+++ b/packages/range/src/index.mjs
@@ -1,4 +1,3 @@
-import { createSelector as createAnnotatorSelector } from 
'@annotator/selector';
 import { product } from './cartesian';
 
 export function createRangeSelector({ createAnySelector }) {
@@ -29,7 +28,7 @@ export function createRangeSelector({ createAnySelector }) {
 }
   }
 
-  return createAnnotatorSelector(rangeSelector);
+  return rangeSelector;
 }
 
 function rangeBetween({ start, end, context }) {
diff --git a/packages/refinedBy/src/index.mjs b/packages/refinedBy/src/index.mjs
index 10ca9f1..f4f8b9a 100644
--- a/packages/refinedBy/src/index.mjs
+++ b/packages/refinedBy/src/index.mjs
@@ -1,16 +1,10 @@
-import * as reselect from 'reselect';
-
-const { createSelector } = reselect;
-
 export function makeRefinable(selector, { createAnySelector }) {
-  const memoizedCreateAnySelector = createSelector(() => createAnySelector());
-
   async function* refinableSelector({ descriptors, context }) {
 const matches = selector({ descriptors, context });
 for await (let match of matches) {
   const refiningDescriptor = match.descriptor.refinedBy;
   if (refiningDescriptor) {
-const anySelector = memoizedCreateAnySelector();
+const anySelector = createAnySelector();
 const refiningMatches = anySelector({
   descriptors: [refiningDescriptor],
   context: matchAsContext(match),
diff --git a/packages/selector/.npmignore b/packages/selector/.npmignore
deleted file mode 100644
index 281df39..000
--- a/packages/selector/.npmignore
+++ /dev/null
@@ -1,2 +0,0 @@
-src
-test
diff --git a/packages/selector/LICENSE b/packages/selector/LICENSE
deleted file mode 100644
index d14c5bb..000
--- a/packages/selector/LICENSE
+++ /dev/null
@@ -1,259 +0,0 @@
-
- Apache License
-   Version 2.0

[GitHub] BigBlueHat opened a new issue #31: Incorporate Web Annotation testing tools

[GitBox]

BigBlueHat opened a new issue #31: Incorporate Web Annotation testing tools
URL: https://github.com/apache/incubator-annotator/issues/31
 
 
   This will ease testing (by us or others) of the Web Annotation JSON 
documents that we (and others) pass to the client libraries we're currently 
building.
   
   There are several repos which contain code we can use:
   
    Web Annotation Data Model
   * https://github.com/w3c/web-annotation-tests - The JSON Schema's built by 
the Web Annotation WG
   * https://github.com/web-platform-tests/wpt/tree/master/annotation-model - 
The JSON Schema's also exist in the Web Platform Tests tooling (identical to 
the above, but surrounding tools have changed a bit)
   
    Web Annotation Protocol
   * https://github.com/web-platform-tests/wpt/tree/master/annotation-protocol 
- contains...
 * 
https://github.com/web-platform-tests/wpt/blob/master/annotation-protocol/server/server-manual.html
 - client-side tests run against a configurable protocol server endpoint
 * 
https://github.com/web-platform-tests/wpt/blob/master/annotation-protocol/tools/protocol-server.py
 - Python 2 / wptserve-based reference implementation
 * 
https://github.com/web-platform-tests/wpt/tree/master/annotation-protocol/files 
- files served by the reference implementation
   * https://github.com/BigBlueHat/web-annotation-protocol-server - the 
original source for the reference implementation
   * https://github.com/BigBlueHat/web-annotation-protocol-tester - command 
line protocol (and contained format) testing tool--*incomplete*
   
    Web Annotation Vocab
   * https://github.com/web-platform-tests/wpt/tree/master/annotation-vocab - 
vocabulary (non-serialization-specific) testing of the output graphs and term 
usage
   
   All of these are licensed such that we can incorporate them into this code. 
The command line protocol tester (which uses mocha.js) is probably the thing of 
most interest for us--especially if we expand it to use the JSON Schema's which 
are used for W3C validation.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] BigBlueHat closed issue #29: Extract NOTICE related content from LICENSE file in fragment-identifier

[GitBox]

BigBlueHat closed issue #29: Extract NOTICE related content from LICENSE file 
in fragment-identifier
URL: https://github.com/apache/incubator-annotator/issues/29
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] JakeHartnell commented on issue #18: Adding the demo to the site

[GitBox]

JakeHartnell commented on issue #18: Adding the demo to the site
URL: 
https://github.com/apache/incubator-annotator/issues/18#issuecomment-395992344
 
 
   Working on it!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] BigBlueHat commented on issue #31: Incorporate Web Annotation testing tools

[GitBox]

BigBlueHat commented on issue #31: Incorporate Web Annotation testing tools
URL: 
https://github.com/apache/incubator-annotator/issues/31#issuecomment-395993696
 
 
   Plan confirmed with @tilgovi to create a validation tool in `scripts/` as a 
command line tool (using mocha.js) built from 
https://github.com/BigBlueHat/web-annotation-protocol-tester + the JSON 
Schema's from https://github.com/w3c/web-annotation-tests
   
   End game will be a script that validates local JSON or JSON from a URL 
against the Web Annotation Data Model JSON Schemas.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] JCCR commented on issue #31: Incorporate Web Annotation testing tools

[GitBox]

JCCR commented on issue #31: Incorporate Web Annotation testing tools
URL: 
https://github.com/apache/incubator-annotator/issues/31#issuecomment-395997106
 
 
   I can work on this.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] BigBlueHat commented on issue #31: Incorporate Web Annotation testing tools

[GitBox]

BigBlueHat commented on issue #31: Incorporate Web Annotation testing tools
URL: 
https://github.com/apache/incubator-annotator/issues/31#issuecomment-395997800
 
 
   @JCCR awesome! Would love your help. I'm getting the basics in today, I 
hope, but let's chat! Find me in `#annotator` on Freednode if you're available 
today. Otherwise, let's work here async. 😸 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] JakeHartnell opened a new pull request #3: Include demo

[GitBox]

JakeHartnell opened a new pull request #3: Include demo
URL: https://github.com/apache/incubator-annotator-website/pull/3
 
 
   Closes #18 in the incubator-annotator repo.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] JCCR commented on issue #31: Incorporate Web Annotation testing tools

[GitBox]

JCCR commented on issue #31: Incorporate Web Annotation testing tools
URL: 
https://github.com/apache/incubator-annotator/issues/31#issuecomment-396013903
 
 
   @BigBlueHat
   Can do asynchronously!
   Would have liked to jump in and chat but I'm AFK today.
   
   On Sat, Jun 9, 2018, 1:49 PM BigBlueHat,  wrote:
   
   > @JCCR  awesome! Would love your help. I'm
   > getting the basics in today, I hope, but let's chat! Find me in #annotator
   > on Freednode if you're available today. Otherwise, let's work here async.
   > 😸
   >
   > —
   > You are receiving this because you were mentioned.
   >
   >
   > Reply to this email directly, view it on GitHub
   > 
,
   > or mute the thread
   > 

   > .
   >
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] JakeHartnell commented on issue #18: Adding the demo to the site

[GitBox]

JakeHartnell commented on issue #18: Adding the demo to the site
URL: 
https://github.com/apache/incubator-annotator/issues/18#issuecomment-396014071
 
 
   I added a webpack build to the incubator-annotator-website. It includes the 
demo from here, but styles it with Semantic UI. Going to be working on adding 
code examples to the demo page as that would be the most helpful for people 
getting started.
   
   PR here: https://github.com/apache/incubator-annotator-website/pull/3


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] BigBlueHat opened a new pull request #32: Initial incorporation of Annotation Schema MUSTs

[GitBox]

BigBlueHat opened a new pull request #32: Initial incorporation of Annotation 
Schema MUSTs
URL: https://github.com/apache/incubator-annotator/pull/32
 
 
   Fixes #31.
   
   Plenty more schemas where these came from. Hopefully this sets the stage for
   similar testings of the SHOULDs, Collections, etc.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] BigBlueHat commented on issue #31: Incorporate Web Annotation testing tools

[GitBox]

BigBlueHat commented on issue #31: Incorporate Web Annotation testing tools
URL: 
https://github.com/apache/incubator-annotator/issues/31#issuecomment-396015369
 
 
   @JCCR PR #32 will *technically* close this issue, however, there's much more 
room here for improving this code.
   
   It currently only works on files (despite the `--url` name of the 
parameter), it needs more of the available schemas incorporated, it might be 
nice to have it work on a folder (or Collection!) of annotations. Etc. 😃 
   
   Feel free to bring your inspiration and ideas to any of this work!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] JakeHartnell opened a new pull request #4: Include demo

[GitBox]

JakeHartnell opened a new pull request #4: Include demo
URL: https://github.com/apache/incubator-annotator-website/pull/4
 
 
   Adds webpack build, closed #3  in favour of this thanks to feedback from 
@BigBlueHat.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] tilgovi commented on a change in pull request #32: Initial incorporation of Annotation Schema MUSTs

[GitBox]

tilgovi commented on a change in pull request #32: Initial incorporation of 
Annotation Schema MUSTs
URL: https://github.com/apache/incubator-annotator/pull/32#discussion_r194245895
 
 

 ##
 File path: test/mocha.opts
 ##
 @@ -4,3 +4,4 @@
 --recursive
 --watch-extensions mjs
 packages/*/test/**/*.mjs
+test/data-model.mjs
 
 Review comment:
   maybe `test/**/*.mjs` for future tests to be included!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services