[jira] [Resolved] (ATLAS-4106) Adding Debug metrics to atlas.

[Sarath Subramanian (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sarath Subramanian resolved ATLAS-4106.
---
Resolution: Fixed

> Adding Debug metrics to atlas.
> --
>
> Key: ATLAS-4106
> URL: https://issues.apache.org/jira/browse/ATLAS-4106
> Project: Atlas
>  Issue Type: New Feature
>  Components:  atlas-core
>Affects Versions: 2.1.0
>Reporter: Mayank Jain
>Assignee: Mayank Jain
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
>
> This is a new feature added to atlas to create a ease for keeping track of 
> certain highly  used api's  in atlas , so at the time of evaluating the 
> performance of certain API we could have our data ready.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4106) Adding Debug metrics to atlas.

[Sarath Subramanian (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sarath Subramanian updated ATLAS-4106:
--
Component/s:  atlas-core

> Adding Debug metrics to atlas.
> --
>
> Key: ATLAS-4106
> URL: https://issues.apache.org/jira/browse/ATLAS-4106
> Project: Atlas
>  Issue Type: New Feature
>  Components:  atlas-core
>Affects Versions: 2.1.0
>Reporter: Mayank Jain
>Assignee: Mayank Jain
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
>
> This is a new feature added to atlas to create a ease for keeping track of 
> certain highly  used api's  in atlas , so at the time of evaluating the 
> performance of certain API we could have our data ready.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4106) Adding Debug metrics to atlas.

[Sarath Subramanian (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sarath Subramanian updated ATLAS-4106:
--
Affects Version/s: 2.1.0

> Adding Debug metrics to atlas.
> --
>
> Key: ATLAS-4106
> URL: https://issues.apache.org/jira/browse/ATLAS-4106
> Project: Atlas
>  Issue Type: New Feature
>Affects Versions: 2.1.0
>Reporter: Mayank Jain
>Assignee: Mayank Jain
>Priority: Major
>
> This is a new feature added to atlas to create a ease for keeping track of 
> certain highly  used api's  in atlas , so at the time of evaluating the 
> performance of certain API we could have our data ready.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4106) Adding Debug metrics to atlas.

[Sarath Subramanian (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sarath Subramanian updated ATLAS-4106:
--
Fix Version/s: 2.2.0
   3.0.0

> Adding Debug metrics to atlas.
> --
>
> Key: ATLAS-4106
> URL: https://issues.apache.org/jira/browse/ATLAS-4106
> Project: Atlas
>  Issue Type: New Feature
>Affects Versions: 2.1.0
>Reporter: Mayank Jain
>Assignee: Mayank Jain
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
>
> This is a new feature added to atlas to create a ease for keeping track of 
> certain highly  used api's  in atlas , so at the time of evaluating the 
> performance of certain API we could have our data ready.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-4106) Adding Debug metrics to atlas.

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-4106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17337104#comment-17337104
 ] 

ASF subversion and git services commented on ATLAS-4106:


Commit 8077863b2f5a9c7ee4bd140eb954e24fef684785 in atlas's branch 
refs/heads/master from mayanknj
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=8077863 ]

ATLAS-4106: Add REST API debug metrics to Atlas

Co-authored-by: Jayendra Parab 

Signed-off-by: Sarath Subramanian 


> Adding Debug metrics to atlas.
> --
>
> Key: ATLAS-4106
> URL: https://issues.apache.org/jira/browse/ATLAS-4106
> Project: Atlas
>  Issue Type: New Feature
>Reporter: Mayank Jain
>Assignee: Mayank Jain
>Priority: Major
>
> This is a new feature added to atlas to create a ease for keeping track of 
> certain highly  used api's  in atlas , so at the time of evaluating the 
> performance of certain API we could have our data ready.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-4106) Adding Debug metrics to atlas.

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-4106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17337105#comment-17337105
 ] 

ASF subversion and git services commented on ATLAS-4106:


Commit 266d26a055515874836975b82a6a11f317888a26 in atlas's branch 
refs/heads/branch-2.0 from mayanknj
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=266d26a ]

ATLAS-4106: Add REST API debug metrics to Atlas

Co-authored-by: Jayendra Parab 

Signed-off-by: Sarath Subramanian 
(cherry picked from commit 8077863b2f5a9c7ee4bd140eb954e24fef684785)


> Adding Debug metrics to atlas.
> --
>
> Key: ATLAS-4106
> URL: https://issues.apache.org/jira/browse/ATLAS-4106
> Project: Atlas
>  Issue Type: New Feature
>Reporter: Mayank Jain
>Assignee: Mayank Jain
>Priority: Major
>
> This is a new feature added to atlas to create a ease for keeping track of 
> certain highly  used api's  in atlas , so at the time of evaluating the 
> performance of certain API we could have our data ready.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-4269) Deferred Actions : When a tag is propagated from an entity via 2 processes , blocking 1 process removes tag propagated from another process

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-4269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17337072#comment-17337072
 ] 

ASF subversion and git services commented on ATLAS-4269:


Commit 06dbe0f0feda648bae41ab170984bf7c4fb94da5 in atlas's branch 
refs/heads/branch-2.0 from Sarath Subramanian
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=06dbe0f ]

ATLAS-4269: Deferred Actions : When a tag is propagated from an entity via 2 
processes , blocking 1 process removes tag propagated from another process

(cherry picked from commit 85e3c5cf64747432bd434bbf1573224988c37bf6)


> Deferred Actions : When a tag is propagated from an entity via 2 processes , 
> blocking 1 process removes tag propagated from another process
> ---
>
> Key: ATLAS-4269
> URL: https://issues.apache.org/jira/browse/ATLAS-4269
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 2.1.0
>Reporter: Sarath Subramanian
>Assignee: Sarath Subramanian
>Priority: Major
>  Labels: tagpropagation
> Fix For: 3.0.0, 2.2.0
>
> Attachments: default...@cm.png
>
>
> 1.Create a lineage as attached in the screenshot (i.e) tag propagated from a 
> source using 2 processes to a target 
> 2. Add a tag to t3 , now the tag is propagated to t4 via both process1 and 
> process2.
> 3. Now block the propagation from t3 to process1.
> 4. Expectation is that , tag will be propagated via process2 to t4. But the  
> propagated tag is removed from t4
> !default...@cm.png!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-4269) Deferred Actions : When a tag is propagated from an entity via 2 processes , blocking 1 process removes tag propagated from another process

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-4269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17337071#comment-17337071
 ] 

ASF subversion and git services commented on ATLAS-4269:


Commit 85e3c5cf64747432bd434bbf1573224988c37bf6 in atlas's branch 
refs/heads/master from Sarath Subramanian
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=85e3c5c ]

ATLAS-4269: Deferred Actions : When a tag is propagated from an entity via 2 
processes , blocking 1 process removes tag propagated from another process


> Deferred Actions : When a tag is propagated from an entity via 2 processes , 
> blocking 1 process removes tag propagated from another process
> ---
>
> Key: ATLAS-4269
> URL: https://issues.apache.org/jira/browse/ATLAS-4269
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 2.1.0
>Reporter: Sarath Subramanian
>Assignee: Sarath Subramanian
>Priority: Major
>  Labels: tagpropagation
> Fix For: 3.0.0, 2.2.0
>
> Attachments: default...@cm.png
>
>
> 1.Create a lineage as attached in the screenshot (i.e) tag propagated from a 
> source using 2 processes to a target 
> 2. Add a tag to t3 , now the tag is propagated to t4 via both process1 and 
> process2.
> 3. Now block the propagation from t3 to process1.
> 4. Expectation is that , tag will be propagated via process2 to t4. But the  
> propagated tag is removed from t4
> !default...@cm.png!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-4267) Quick Search : AggregationMetrics is incorrect with some special characters

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-4267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17337066#comment-17337066
 ] 

ASF subversion and git services commented on ATLAS-4267:


Commit cb5df196172f0de424397e6a5e8863559a14f8e9 in atlas's branch 
refs/heads/branch-2.0 from Pinal
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=cb5df19 ]

ATLAS-4267 : Quick Search : AggregationMetrics is incorrect with some special 
characters

Signed-off-by: Pinal 


> Quick Search : AggregationMetrics is incorrect with some special characters
> ---
>
> Key: ATLAS-4267
> URL: https://issues.apache.org/jira/browse/ATLAS-4267
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 3.0.0
>Reporter: Pinal Shah
>Assignee: Pinal
>Priority: Major
>  Labels: quicksearch
>
> Quick search with attribute filter :
> qualifiedName - beginsWith - "default.datagen_table_sensitive_725_1."  has 
> empty AggregationMetrics
> whereas with "default.datagen_table_sensitive_725_1" has right 
> AggregationMetrics. __ 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-4267) Quick Search : AggregationMetrics is incorrect with some special characters

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-4267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17337063#comment-17337063
 ] 

ASF subversion and git services commented on ATLAS-4267:


Commit 1366a648d08a23d9ff3b3eb3c1e85d069800522f in atlas's branch 
refs/heads/master from Pinal
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=1366a64 ]

ATLAS-4267 : Quick Search : AggregationMetrics is incorrect with some special 
characters

Signed-off-by: Pinal 


> Quick Search : AggregationMetrics is incorrect with some special characters
> ---
>
> Key: ATLAS-4267
> URL: https://issues.apache.org/jira/browse/ATLAS-4267
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 3.0.0
>Reporter: Pinal Shah
>Assignee: Pinal
>Priority: Major
>  Labels: quicksearch
>
> Quick search with attribute filter :
> qualifiedName - beginsWith - "default.datagen_table_sensitive_725_1."  has 
> empty AggregationMetrics
> whereas with "default.datagen_table_sensitive_725_1" has right 
> AggregationMetrics. __ 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 73316: ATLAS-4269: Deferred Actions : When a tag is propagated from an entity via 2 processes , blocking 1 process removes tag propagated from another process

[Ashutosh Mestry via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73316/#review222919
---


Ship it!




Ship It!

- Ashutosh Mestry


On April 30, 2021, 4:01 a.m., Sarath Subramanian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73316/
> ---
> 
> (Updated April 30, 2021, 4:01 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Deep Singh, Madhan Neethiraj, 
> Radhika Kundam, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-4269
> https://issues.apache.org/jira/browse/ATLAS-4269
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Issue
> =
> 1.Create a lineage as attached in the screenshot (see JIRA) tag propagated 
> from a source using 2 processes to a target 
> 
> 2. Add a tag to t3 , now the tag is propagated to t4 via both process1 and 
> process2.
> 
> 3. Now block the propagation from t3 to process1.
> 
> 4. Expectation is that , tag will be propagated via process2 to t4. But the  
> propagated tag is removed from t4
> 
> 
> Solution:
> =
> 
> Recently tag propagation logic was updated to use queue implementation. When 
> adding impacted vertices to the result added a check to see if vertex already 
> present. So no duplicates present.
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
>  9abcf646c 
> 
> 
> Diff: https://reviews.apache.org/r/73316/diff/2/
> 
> 
> Testing
> ---
> 
> Precommit: 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/532/console
> 
> Manually validated in circular lineage
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>

Re: Review Request 73316: ATLAS-4269: Deferred Actions : When a tag is propagated from an entity via 2 processes , blocking 1 process removes tag propagated from another process

[Sarath Subramanian]

> On April 29, 2021, 6:16 p.m., Ashutosh Mestry wrote:
> > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
> > Lines 602 (patched)
> > 
> >
> > listContainsVertex -> findByVertexId, pass vertexId as parameter, that 
> > will address earlier comment.

updated to use map


- Sarath


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73316/#review222917
---


On April 29, 2021, 9:01 p.m., Sarath Subramanian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73316/
> ---
> 
> (Updated April 29, 2021, 9:01 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Deep Singh, Madhan Neethiraj, 
> Radhika Kundam, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-4269
> https://issues.apache.org/jira/browse/ATLAS-4269
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Issue
> =
> 1.Create a lineage as attached in the screenshot (see JIRA) tag propagated 
> from a source using 2 processes to a target 
> 
> 2. Add a tag to t3 , now the tag is propagated to t4 via both process1 and 
> process2.
> 
> 3. Now block the propagation from t3 to process1.
> 
> 4. Expectation is that , tag will be propagated via process2 to t4. But the  
> propagated tag is removed from t4
> 
> 
> Solution:
> =
> 
> Recently tag propagation logic was updated to use queue implementation. When 
> adding impacted vertices to the result added a check to see if vertex already 
> present. So no duplicates present.
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
>  9abcf646c 
> 
> 
> Diff: https://reviews.apache.org/r/73316/diff/2/
> 
> 
> Testing
> ---
> 
> Precommit: 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/532/console
> 
> Manually validated in circular lineage
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>

Re: Review Request 73316: ATLAS-4269: Deferred Actions : When a tag is propagated from an entity via 2 processes , blocking 1 process removes tag propagated from another process

[Sarath Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73316/
---

(Updated April 29, 2021, 9:01 p.m.)


Review request for atlas, Ashutosh Mestry, Deep Singh, Madhan Neethiraj, 
Radhika Kundam, and Sidharth Mishra.


Changes
---

updated implementation to use map to avoid search on collection on every result 
addition.


Bugs: ATLAS-4269
https://issues.apache.org/jira/browse/ATLAS-4269


Repository: atlas


Description
---

Issue
=
1.Create a lineage as attached in the screenshot (see JIRA) tag propagated from 
a source using 2 processes to a target 

2. Add a tag to t3 , now the tag is propagated to t4 via both process1 and 
process2.

3. Now block the propagation from t3 to process1.

4. Expectation is that , tag will be propagated via process2 to t4. But the  
propagated tag is removed from t4


Solution:
=

Recently tag propagation logic was updated to use queue implementation. When 
adding impacted vertices to the result added a check to see if vertex already 
present. So no duplicates present.


Diffs (updated)
-

  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
 9abcf646c 


Diff: https://reviews.apache.org/r/73316/diff/2/

Changes: https://reviews.apache.org/r/73316/diff/1-2/


Testing
---

Precommit: 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/532/console

Manually validated in circular lineage


Thanks,

Sarath Subramanian

[jira] [Updated] (ATLAS-4269) Deferred Actions : When a tag is propagated from an entity via 2 processes , blocking 1 process removes tag propagated from another process

[Sarath Subramanian (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sarath Subramanian updated ATLAS-4269:
--
Attachment: default...@cm.png

> Deferred Actions : When a tag is propagated from an entity via 2 processes , 
> blocking 1 process removes tag propagated from another process
> ---
>
> Key: ATLAS-4269
> URL: https://issues.apache.org/jira/browse/ATLAS-4269
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 2.1.0
>Reporter: Sarath Subramanian
>Assignee: Sarath Subramanian
>Priority: Major
> Attachments: default...@cm.png
>
>
> 1.Create a lineage as attached in the screenshot (i.e) tag propagated from a 
> source using 2 processes to a target 
> 2. Add a tag to t3 , now the tag is propagated to t4 via both process1 and 
> process2.
> 3. Now block the propagation from t3 to process1.
> 4. Expectation is that , tag will be propagated via process2 to t4. But the  
> propagated tag is removed from t4
> !default...@cm.png!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4269) Deferred Actions : When a tag is propagated from an entity via 2 processes , blocking 1 process removes tag propagated from another process

[Sarath Subramanian (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sarath Subramanian updated ATLAS-4269:
--
Labels: tagpropagation  (was: )

> Deferred Actions : When a tag is propagated from an entity via 2 processes , 
> blocking 1 process removes tag propagated from another process
> ---
>
> Key: ATLAS-4269
> URL: https://issues.apache.org/jira/browse/ATLAS-4269
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 2.1.0
>Reporter: Sarath Subramanian
>Assignee: Sarath Subramanian
>Priority: Major
>  Labels: tagpropagation
> Fix For: 3.0.0, 2.2.0
>
> Attachments: default...@cm.png
>
>
> 1.Create a lineage as attached in the screenshot (i.e) tag propagated from a 
> source using 2 processes to a target 
> 2. Add a tag to t3 , now the tag is propagated to t4 via both process1 and 
> process2.
> 3. Now block the propagation from t3 to process1.
> 4. Expectation is that , tag will be propagated via process2 to t4. But the  
> propagated tag is removed from t4
> !default...@cm.png!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 73316: ATLAS-4269: Deferred Actions : When a tag is propagated from an entity via 2 processes , blocking 1 process removes tag propagated from another process

[Ashutosh Mestry via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73316/#review222917
---




repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
Lines 602 (patched)


listContainsVertex -> findByVertexId, pass vertexId as parameter, that will 
address earlier comment.



repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
Lines 607 (patched)


vertex.getIdForDisplay is evaluated in each iteration. Consider 
initializing it in a variable outside the loop.


- Ashutosh Mestry


On April 29, 2021, 11:37 p.m., Sarath Subramanian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73316/
> ---
> 
> (Updated April 29, 2021, 11:37 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Deep Singh, Madhan Neethiraj, 
> Radhika Kundam, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-4269
> https://issues.apache.org/jira/browse/ATLAS-4269
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Issue
> =
> 1.Create a lineage as attached in the screenshot (see JIRA) tag propagated 
> from a source using 2 processes to a target 
> 
> 2. Add a tag to t3 , now the tag is propagated to t4 via both process1 and 
> process2.
> 
> 3. Now block the propagation from t3 to process1.
> 
> 4. Expectation is that , tag will be propagated via process2 to t4. But the  
> propagated tag is removed from t4
> 
> 
> Solution:
> =
> 
> Recently tag propagation logic was updated to use queue implementation. When 
> adding impacted vertices to the result added a check to see if vertex already 
> present. So no duplicates present.
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
>  9abcf646c 
> 
> 
> Diff: https://reviews.apache.org/r/73316/diff/1/
> 
> 
> Testing
> ---
> 
> Precommit: 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/532/console
> 
> Manually validated in circular lineage
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>

[jira] [Created] (ATLAS-4269) Deferred Actions : When a tag is propagated from an entity via 2 processes , blocking 1 process removes tag propagated from another process

[Sarath Subramanian (Jira)]

Sarath Subramanian created ATLAS-4269:
-

 Summary: Deferred Actions : When a tag is propagated from an 
entity via 2 processes , blocking 1 process removes tag propagated from another 
process
 Key: ATLAS-4269
 URL: https://issues.apache.org/jira/browse/ATLAS-4269
 Project: Atlas
  Issue Type: Bug
  Components:  atlas-core
Affects Versions: 2.1.0
Reporter: Sarath Subramanian
Assignee: Sarath Subramanian
 Attachments: default...@cm.png

1.Create a lineage as attached in the screenshot (i.e) tag propagated from a 
source using 2 processes to a target 

2. Add a tag to t3 , now the tag is propagated to t4 via both process1 and 
process2.

3. Now block the propagation from t3 to process1.

4. Expectation is that , tag will be propagated via process2 to t4. But the  
propagated tag is removed from t4

!default...@cm.png!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4269) Deferred Actions : When a tag is propagated from an entity via 2 processes , blocking 1 process removes tag propagated from another process

[Sarath Subramanian (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sarath Subramanian updated ATLAS-4269:
--
Fix Version/s: 2.2.0
   3.0.0

> Deferred Actions : When a tag is propagated from an entity via 2 processes , 
> blocking 1 process removes tag propagated from another process
> ---
>
> Key: ATLAS-4269
> URL: https://issues.apache.org/jira/browse/ATLAS-4269
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 2.1.0
>Reporter: Sarath Subramanian
>Assignee: Sarath Subramanian
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: default...@cm.png
>
>
> 1.Create a lineage as attached in the screenshot (i.e) tag propagated from a 
> source using 2 processes to a target 
> 2. Add a tag to t3 , now the tag is propagated to t4 via both process1 and 
> process2.
> 3. Now block the propagation from t3 to process1.
> 4. Expectation is that , tag will be propagated via process2 to t4. But the  
> propagated tag is removed from t4
> !default...@cm.png!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Review Request 73316: ATLAS-4269: Deferred Actions : When a tag is propagated from an entity via 2 processes , blocking 1 process removes tag propagated from another process

[Sarath Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73316/
---

Review request for atlas, Ashutosh Mestry, Deep Singh, Madhan Neethiraj, 
Radhika Kundam, and Sidharth Mishra.


Bugs: ATLAS-4269
https://issues.apache.org/jira/browse/ATLAS-4269


Repository: atlas


Description
---

Issue
=
1.Create a lineage as attached in the screenshot (see JIRA) tag propagated from 
a source using 2 processes to a target 

2. Add a tag to t3 , now the tag is propagated to t4 via both process1 and 
process2.

3. Now block the propagation from t3 to process1.

4. Expectation is that , tag will be propagated via process2 to t4. But the  
propagated tag is removed from t4


Solution:
=

Recently tag propagation logic was updated to use queue implementation. When 
adding impacted vertices to the result added a check to see if vertex already 
present. So no duplicates present.


Diffs
-

  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
 9abcf646c 


Diff: https://reviews.apache.org/r/73316/diff/1/


Testing
---

Precommit: 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/532/console

Manually validated in circular lineage


Thanks,

Sarath Subramanian

[jira] [Commented] (ATLAS-4268) Deferred Actions : When a tag is already associated to a term and when the term is assigned to the entity , tag propagation doesn't happen

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-4268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17335800#comment-17335800
 ] 

ASF subversion and git services commented on ATLAS-4268:


Commit 2bb3199f528952cbea3bbde9f25b57f98217550c in atlas's branch 
refs/heads/branch-2.0 from Sarath Subramanian
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=2bb3199 ]

ATLAS-4268: Deferred Actions : When a tag is already associated to a term and 
when the term is assigned to the entity, tag propagation doesn't happen

(cherry picked from commit 7e73fc2591f8177630f1ffd82e774b490832650a)


> Deferred Actions : When a tag is already associated to a term and when the 
> term is assigned to the entity , tag propagation doesn't happen
> --
>
> Key: ATLAS-4268
> URL: https://issues.apache.org/jira/browse/ATLAS-4268
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 2.1.0
>Reporter: Sarath Subramanian
>Assignee: Sarath Subramanian
>Priority: Major
>
> Enabled deferred actions
> Create term term1.
> Add tag tag1 to term1.
> Associate term1 to entity1
> Expected that tag1 will be propagated to entity1 from term1 , but didn't 
> happen.
> Associated a new tag tag2 to term1 , now that tag2 is associated to entity1
>  
> Issue is seen only when deferred actions is enabled.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-4268) Deferred Actions : When a tag is already associated to a term and when the term is assigned to the entity , tag propagation doesn't happen

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-4268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17335799#comment-17335799
 ] 

ASF subversion and git services commented on ATLAS-4268:


Commit 7e73fc2591f8177630f1ffd82e774b490832650a in atlas's branch 
refs/heads/master from Sarath Subramanian
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=7e73fc2 ]

ATLAS-4268: Deferred Actions : When a tag is already associated to a term and 
when the term is assigned to the entity, tag propagation doesn't happen


> Deferred Actions : When a tag is already associated to a term and when the 
> term is assigned to the entity , tag propagation doesn't happen
> --
>
> Key: ATLAS-4268
> URL: https://issues.apache.org/jira/browse/ATLAS-4268
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 2.1.0
>Reporter: Sarath Subramanian
>Assignee: Sarath Subramanian
>Priority: Major
>
> Enabled deferred actions
> Create term term1.
> Add tag tag1 to term1.
> Associate term1 to entity1
> Expected that tag1 will be propagated to entity1 from term1 , but didn't 
> happen.
> Associated a new tag tag2 to term1 , now that tag2 is associated to entity1
>  
> Issue is seen only when deferred actions is enabled.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 73314: ATLAS-4268: Deferred Actions : When a tag is already associated to a term and when the term is assigned to the entity , tag propagation doesn't happen

[Ashutosh Mestry via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73314/#review222915
---


Ship it!




Ship It!

- Ashutosh Mestry


On April 29, 2021, 7:39 p.m., Sarath Subramanian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73314/
> ---
> 
> (Updated April 29, 2021, 7:39 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Deep Singh, Madhan Neethiraj, 
> Radhika Kundam, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-4268
> https://issues.apache.org/jira/browse/ATLAS-4268
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Issue:
> Enabled deferred actions
> 
> Create term term1.
> 
> Add tag tag1 to term1.
> 
> Associate term1 to entity1
> 
> Expected that tag1 will be propagated to entity1 from term1 , but didn't 
> happen.
> 
> Associated a new tag tag2 to term1 , now that tag2 is associated to entity1
> 
> 
> Solution:
> 
> Previously during deferred action only impacted vertices were computed, this 
> should be updated to comput included impacted vertices to handle source 
> entity as well.
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
>  2a71e345b 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
>  2e0f39a73 
> 
> 
> Diff: https://reviews.apache.org/r/73314/diff/1/
> 
> 
> Testing
> ---
> 
> Precommit: 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/531/console
> 
> Manually verified:
> 
> 1. Created new term 'myterm' under glossary 'MyGlossary' and assigned 
> classification PII (propagation=true)
> 2. assigned term myterm to an entity with lineage
> 3. verified classification is propagated to source entity to which term is 
> assigned and also to all downstream entities.
> 
> 
> Also validated use case to create a new table from existing table (having 
> term with classification assigned), verified that classification propagated.
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>

Review Request 73314: ATLAS-4268: Deferred Actions : When a tag is already associated to a term and when the term is assigned to the entity , tag propagation doesn't happen

[Sarath Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73314/
---

Review request for atlas, Ashutosh Mestry, Deep Singh, Madhan Neethiraj, 
Radhika Kundam, and Sidharth Mishra.


Bugs: ATLAS-4268
https://issues.apache.org/jira/browse/ATLAS-4268


Repository: atlas


Description
---

Issue:
Enabled deferred actions

Create term term1.

Add tag tag1 to term1.

Associate term1 to entity1

Expected that tag1 will be propagated to entity1 from term1 , but didn't happen.

Associated a new tag tag2 to term1 , now that tag2 is associated to entity1


Solution:

Previously during deferred action only impacted vertices were computed, this 
should be updated to comput included impacted vertices to handle source entity 
as well.


Diffs
-

  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
 2a71e345b 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
 2e0f39a73 


Diff: https://reviews.apache.org/r/73314/diff/1/


Testing
---

Precommit: 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/531/console

Manually verified:

1. Created new term 'myterm' under glossary 'MyGlossary' and assigned 
classification PII (propagation=true)
2. assigned term myterm to an entity with lineage
3. verified classification is propagated to source entity to which term is 
assigned and also to all downstream entities.


Also validated use case to create a new table from existing table (having term 
with classification assigned), verified that classification propagated.


Thanks,

Sarath Subramanian

[jira] [Created] (ATLAS-4268) Deferred Actions : When a tag is already associated to a term and when the term is assigned to the entity , tag propagation doesn't happen

[Sarath Subramanian (Jira)]

Sarath Subramanian created ATLAS-4268:
-

 Summary: Deferred Actions : When a tag is already associated to a 
term and when the term is assigned to the entity , tag propagation doesn't 
happen
 Key: ATLAS-4268
 URL: https://issues.apache.org/jira/browse/ATLAS-4268
 Project: Atlas
  Issue Type: Bug
  Components:  atlas-core
Affects Versions: 2.1.0
Reporter: Sarath Subramanian
Assignee: Sarath Subramanian


Enabled deferred actions

Create term term1.

Add tag tag1 to term1.

Associate term1 to entity1

Expected that tag1 will be propagated to entity1 from term1 , but didn't happen.

Associated a new tag tag2 to term1 , now that tag2 is associated to entity1

 

Issue is seen only when deferred actions is enabled.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-4261) Bulk Glossary Import Response and Failed Error Message Improvements

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-4261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17335723#comment-17335723
 ] 

ASF subversion and git services commented on ATLAS-4261:


Commit 00f30545d75a7456bf4119b44effe26f384eae03 in atlas's branch 
refs/heads/branch-2.0 from sidmishra
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=00f3054 ]

ATLAS-4261: Changed the AtlasGlossaryTermHeader glossaryGUID to termGUID

Signed-off-by: Sarath Subramanian 
(cherry picked from commit 5673d72287d59aaf2685030a727998f040abdd72)


> Bulk Glossary Import Response and Failed Error Message Improvements 
> 
>
> Key: ATLAS-4261
> URL: https://issues.apache.org/jira/browse/ATLAS-4261
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 2.1.0
>Reporter: Sidharth Kumar Mishra
>Assignee: Sidharth Kumar Mishra
>Priority: Major
>  Labels: glossary
> Fix For: 3.0.0, 2.2.0
>
> Attachments: ATLAS-4261.patch
>
>
> 1. For bulk glossary import, if we have relations and there is some error 
> present then the failed error message contains duplicate messages. 
> 2. The success response doesn't contains information about the relations
> 3. The failed messages at response contains extra '\n' 
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-4261) Bulk Glossary Import Response and Failed Error Message Improvements

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-4261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17335722#comment-17335722
 ] 

ASF subversion and git services commented on ATLAS-4261:


Commit 5673d72287d59aaf2685030a727998f040abdd72 in atlas's branch 
refs/heads/master from sidmishra
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=5673d72 ]

ATLAS-4261: Changed the AtlasGlossaryTermHeader glossaryGUID to termGUID

Signed-off-by: Sarath Subramanian 


> Bulk Glossary Import Response and Failed Error Message Improvements 
> 
>
> Key: ATLAS-4261
> URL: https://issues.apache.org/jira/browse/ATLAS-4261
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 2.1.0
>Reporter: Sidharth Kumar Mishra
>Assignee: Sidharth Kumar Mishra
>Priority: Major
>  Labels: glossary
> Fix For: 3.0.0, 2.2.0
>
> Attachments: ATLAS-4261.patch
>
>
> 1. For bulk glossary import, if we have relations and there is some error 
> present then the failed error message contains duplicate messages. 
> 2. The success response doesn't contains information about the relations
> 3. The failed messages at response contains extra '\n' 
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 73313: ATLAS-4261: Bulk Glossary Import Response and Failed Error Message Improvements

[Sarath Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73313/#review222913
---


Ship it!




Ship It!

- Sarath Subramanian


On April 29, 2021, 10:40 a.m., Sidharth Mishra wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73313/
> ---
> 
> (Updated April 29, 2021, 10:40 a.m.)
> 
> 
> Review request for atlas and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4261
> https://issues.apache.org/jira/browse/ATLAS-4261
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-4261: Bulk Glossary Import Response and Failed Error Message 
> Improvements
> 
> 
> Diffs
> -
> 
>   
> intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTermHeader.java
>  65a5ce041 
> 
> 
> Diff: https://reviews.apache.org/r/73313/diff/1/
> 
> 
> Testing
> ---
> 
> In case of glossary import, new response:
> 
> {
> "failedImportInfoList": [
> {
> "parentObjectName": "Banking9",
> "childObjectName": "Payable",
> "importStatus": "FAILED",
> "remarks": "Glossary term with qualifiedName Payable@Banking9 
> already exists"
> },
> {
> "parentObjectName": "Auto9",
> "childObjectName": "Steering",
> "importStatus": "FAILED",
> "remarks": "Glossary term with qualifiedName Steering@Auto9 
> already exists"
> }
> ],
> "successImportInfoList": [
> {
> "parentObjectName": "Banking16",
> "childObjectName": "Receivable",
> "importStatus": "SUCCESS",
> "remarks": 
> "{\"termGuid\":\"f4f4c97a-7937-4639-8c3d-bdd46f0a6ed8\",\"qualifiedName\":\"Receivable@Banking16\"}"
> }
> ]
> }
> 
> 
> Thanks,
> 
> Sidharth Mishra
> 
>

Review Request 73313: ATLAS-4261: Bulk Glossary Import Response and Failed Error Message Improvements

[Sidharth Mishra]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73313/
---

Review request for atlas and Sarath Subramanian.


Bugs: ATLAS-4261
https://issues.apache.org/jira/browse/ATLAS-4261


Repository: atlas


Description
---

ATLAS-4261: Bulk Glossary Import Response and Failed Error Message Improvements


Diffs
-

  
intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTermHeader.java 
65a5ce041 


Diff: https://reviews.apache.org/r/73313/diff/1/


Testing
---

In case of glossary import, new response:

{
"failedImportInfoList": [
{
"parentObjectName": "Banking9",
"childObjectName": "Payable",
"importStatus": "FAILED",
"remarks": "Glossary term with qualifiedName Payable@Banking9 
already exists"
},
{
"parentObjectName": "Auto9",
"childObjectName": "Steering",
"importStatus": "FAILED",
"remarks": "Glossary term with qualifiedName Steering@Auto9 already 
exists"
}
],
"successImportInfoList": [
{
"parentObjectName": "Banking16",
"childObjectName": "Receivable",
"importStatus": "SUCCESS",
"remarks": 
"{\"termGuid\":\"f4f4c97a-7937-4639-8c3d-bdd46f0a6ed8\",\"qualifiedName\":\"Receivable@Banking16\"}"
}
]
}


Thanks,

Sidharth Mishra

Re: Review Request 73310: ATLAS-4267 : Quick Search : AggregationMetrics is incorrect with some special characters

[Sarath Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73310/#review222912
---


Ship it!




Ship It!

- Sarath Subramanian


On April 29, 2021, 10:09 a.m., Pinal Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73310/
> ---
> 
> (Updated April 29, 2021, 10:09 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-4267
> https://issues.apache.org/jira/browse/ATLAS-4267
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Quick search with attribute filter :
> 
> qualifiedName - beginsWith - "default.datagen_table_sensitive_725_1."  has 
> empty AggregationMetrics
> 
> whereas with "default.datagen_table_sensitive_725_1" has right 
> AggregationMetrics. __
> 
> 
> Diffs
> -
> 
>   
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasSolrQueryBuilder.java
>  1dd8be7e9 
>   
> graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/AtlasSolrQueryBuilderTest.java
>  c2acc5b34 
>   repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 
> 3750799f7 
>   
> repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java
>  f55577c8c 
> 
> 
> Diff: https://reviews.apache.org/r/73310/diff/3/
> 
> 
> Testing
> ---
> 
> Unit test case added
> Precommit : 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/529/console
> 
> 
> Thanks,
> 
> Pinal Shah
> 
>

Re: Review Request 73310: ATLAS-4267 : Quick Search : AggregationMetrics is incorrect with some special characters

[Pinal Shah]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73310/
---

(Updated April 29, 2021, 5:09 p.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, and Sarath 
Subramanian.


Changes
---

addressed review comments


Bugs: ATLAS-4267
https://issues.apache.org/jira/browse/ATLAS-4267


Repository: atlas


Description
---

Quick search with attribute filter :

qualifiedName - beginsWith - "default.datagen_table_sensitive_725_1."  has 
empty AggregationMetrics

whereas with "default.datagen_table_sensitive_725_1" has right 
AggregationMetrics. __


Diffs (updated)
-

  
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasSolrQueryBuilder.java
 1dd8be7e9 
  
graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/AtlasSolrQueryBuilderTest.java
 c2acc5b34 
  repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 
3750799f7 
  
repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java
 f55577c8c 


Diff: https://reviews.apache.org/r/73310/diff/3/

Changes: https://reviews.apache.org/r/73310/diff/2-3/


Testing
---

Unit test case added
Precommit : 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/529/console


Thanks,

Pinal Shah

[jira] [Commented] (ATLAS-3047) Ability to parse and persist avro schema in Atlas

[Oshin Sharel Britto (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-3047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17335575#comment-17335575
 ] 

Oshin Sharel Britto commented on ATLAS-3047:


[~ayushmnnit] Are there any plans of adding the AVRO parser?

> Ability to parse and persist avro schema in Atlas
> -
>
> Key: ATLAS-3047
> URL: https://issues.apache.org/jira/browse/ATLAS-3047
> Project: Atlas
>  Issue Type: New Feature
>Reporter: Ayush Nigam
>Assignee: Ayush Nigam
>Priority: Major
>  Labels: AVRO
>
> As part of our use case we have developed Avro Parser that can parse fully 
> nested avro schemas and persist them to atlas.
> Also we have added capability to add field classifications and have done 
> enhancements on already existing avro modle to accomodate new types such as 
> avro_map,avro_union,logical types etc



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 73310: ATLAS-4267 : Quick Search : AggregationMetrics is incorrect with some special characters

[Sarath Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73310/#review222907
---




graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasSolrQueryBuilder.java
Line 351 (original), 392 (patched)


duuplicate lines 392/394 and 400/402:

consider replacing:

```
String attrValuePrefix = replaceWildCard ? ":*" : ":";


queryBuilder.append("+").append(indexFieldName).append(attrValuePrefix).append(attributeValue).append("
 ");
```


- Sarath Subramanian


On April 29, 2021, 3:46 a.m., Pinal Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73310/
> ---
> 
> (Updated April 29, 2021, 3:46 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-4267
> https://issues.apache.org/jira/browse/ATLAS-4267
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Quick search with attribute filter :
> 
> qualifiedName - beginsWith - "default.datagen_table_sensitive_725_1."  has 
> empty AggregationMetrics
> 
> whereas with "default.datagen_table_sensitive_725_1" has right 
> AggregationMetrics. __
> 
> 
> Diffs
> -
> 
>   
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasSolrQueryBuilder.java
>  1dd8be7e9 
>   
> graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/AtlasSolrQueryBuilderTest.java
>  c2acc5b34 
>   repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 
> 3750799f7 
>   
> repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java
>  f55577c8c 
> 
> 
> Diff: https://reviews.apache.org/r/73310/diff/2/
> 
> 
> Testing
> ---
> 
> Unit test case added
> Precommit : 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/529/console
> 
> 
> Thanks,
> 
> Pinal Shah
> 
>

Re: Review Request 73310: ATLAS-4267 : Quick Search : AggregationMetrics is incorrect with some special characters

[Pinal Shah]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73310/
---

(Updated April 29, 2021, 10:46 a.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, and Sarath 
Subramanian.


Bugs: ATLAS-4267
https://issues.apache.org/jira/browse/ATLAS-4267


Repository: atlas


Description
---

Quick search with attribute filter :

qualifiedName - beginsWith - "default.datagen_table_sensitive_725_1."  has 
empty AggregationMetrics

whereas with "default.datagen_table_sensitive_725_1" has right 
AggregationMetrics. __


Diffs (updated)
-

  
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasSolrQueryBuilder.java
 1dd8be7e9 
  
graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/AtlasSolrQueryBuilderTest.java
 c2acc5b34 
  repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 
3750799f7 
  
repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java
 f55577c8c 


Diff: https://reviews.apache.org/r/73310/diff/2/

Changes: https://reviews.apache.org/r/73310/diff/1-2/


Testing (updated)
---

Unit test case added
Precommit : 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/529/console


Thanks,

Pinal Shah

[jira] [Updated] (ATLAS-4267) Quick Search : AggregationMetrics is incorrect with some special characters

[Pinal (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pinal updated ATLAS-4267:
-
Labels: quicksearch  (was: )

> Quick Search : AggregationMetrics is incorrect with some special characters
> ---
>
> Key: ATLAS-4267
> URL: https://issues.apache.org/jira/browse/ATLAS-4267
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 3.0.0
>Reporter: Pinal Shah
>Assignee: Pinal
>Priority: Major
>  Labels: quicksearch
>
> Quick search with attribute filter :
> qualifiedName - beginsWith - "default.datagen_table_sensitive_725_1."  has 
> empty AggregationMetrics
> whereas with "default.datagen_table_sensitive_725_1" has right 
> AggregationMetrics. __ 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Review Request 73310: ATLAS-4267 : Quick Search : AggregationMetrics is incorrect with some special characters

[Pinal Shah]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73310/
---

Review request for atlas, Jayendra Parab, Madhan Neethiraj, and Sarath 
Subramanian.


Bugs: ATLAS-4267
https://issues.apache.org/jira/browse/ATLAS-4267


Repository: atlas


Description
---

Quick search with attribute filter :

qualifiedName - beginsWith - "default.datagen_table_sensitive_725_1."  has 
empty AggregationMetrics

whereas with "default.datagen_table_sensitive_725_1" has right 
AggregationMetrics. __


Diffs
-

  
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasSolrQueryBuilder.java
 1dd8be7e9 
  repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 
3750799f7 
  
repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java
 f55577c8c 


Diff: https://reviews.apache.org/r/73310/diff/1/


Testing
---

Unit test case added


Thanks,

Pinal Shah

[jira] [Updated] (ATLAS-4261) Bulk Glossary Import Response and Failed Error Message Improvements

[Sarath Subramanian (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sarath Subramanian updated ATLAS-4261:
--
Fix Version/s: 2.2.0
   3.0.0

> Bulk Glossary Import Response and Failed Error Message Improvements 
> 
>
> Key: ATLAS-4261
> URL: https://issues.apache.org/jira/browse/ATLAS-4261
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 2.1.0
>Reporter: Sidharth Kumar Mishra
>Assignee: Sidharth Kumar Mishra
>Priority: Major
>  Labels: glossary
> Fix For: 3.0.0, 2.2.0
>
> Attachments: ATLAS-4261.patch
>
>
> 1. For bulk glossary import, if we have relations and there is some error 
> present then the failed error message contains duplicate messages. 
> 2. The success response doesn't contains information about the relations
> 3. The failed messages at response contains extra '\n' 
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-4261) Bulk Glossary Import Response and Failed Error Message Improvements

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-4261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17335165#comment-17335165
 ] 

ASF subversion and git services commented on ATLAS-4261:


Commit 6a025043d2aac4d8e44bf0b3f5598bb3c766a38b in atlas's branch 
refs/heads/branch-2.0 from sidmishra
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=6a02504 ]

ATLAS-4261: Bulk Glossary Import Response and Failed Error Message Improvements

Signed-off-by: Sarath Subramanian 
(cherry picked from commit 7d7d1f3e1b1be9ea585398eb337208250730bda3)


> Bulk Glossary Import Response and Failed Error Message Improvements 
> 
>
> Key: ATLAS-4261
> URL: https://issues.apache.org/jira/browse/ATLAS-4261
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 2.1.0
>Reporter: Sidharth Kumar Mishra
>Assignee: Sidharth Kumar Mishra
>Priority: Major
>  Labels: glossary
> Attachments: ATLAS-4261.patch
>
>
> 1. For bulk glossary import, if we have relations and there is some error 
> present then the failed error message contains duplicate messages. 
> 2. The success response doesn't contains information about the relations
> 3. The failed messages at response contains extra '\n' 
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-4261) Bulk Glossary Import Response and Failed Error Message Improvements

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-4261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17335164#comment-17335164
 ] 

ASF subversion and git services commented on ATLAS-4261:


Commit 7d7d1f3e1b1be9ea585398eb337208250730bda3 in atlas's branch 
refs/heads/master from sidmishra
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=7d7d1f3 ]

ATLAS-4261: Bulk Glossary Import Response and Failed Error Message Improvements

Signed-off-by: Sarath Subramanian 


> Bulk Glossary Import Response and Failed Error Message Improvements 
> 
>
> Key: ATLAS-4261
> URL: https://issues.apache.org/jira/browse/ATLAS-4261
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 2.1.0
>Reporter: Sidharth Kumar Mishra
>Assignee: Sidharth Kumar Mishra
>Priority: Major
>  Labels: glossary
> Attachments: ATLAS-4261.patch
>
>
> 1. For bulk glossary import, if we have relations and there is some error 
> present then the failed error message contains duplicate messages. 
> 2. The success response doesn't contains information about the relations
> 3. The failed messages at response contains extra '\n' 
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)