[jira] [Commented] (ATLAS-4240) UI: Some Categories are not shown in the tree that matches the search string of search bar.

2021-04-14 Thread Rahul Kurup (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-4240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17320867#comment-17320867
 ] 

Rahul Kurup commented on ATLAS-4240:


+1

> UI: Some Categories are not shown in the tree that matches the search string 
> of search bar.
> ---
>
> Key: ATLAS-4240
> URL: https://issues.apache.org/jira/browse/ATLAS-4240
> Project: Atlas
>  Issue Type: Sub-task
>  Components: atlas-webui
>Reporter: Prasad P. Pawar
>Assignee: Prasad P. Pawar
>Priority: Major
>  Labels: categories
> Attachments: 
> 0001-ATLAS-3903-UI-Glossary-category-not-reflected-in-the.patch, 
> CategoryList.png, Old-ui_Category_Bug.png, Old-ui_Category_bug_2.png
>
>
> Consider "G6" glossary having "G6_C1" category, and "G6_C1" category having 
> "G6_SubCategory" category (refer image CategoryList.png)
> Old-UI:
> Glossary tab-> switch to category and refresh the page
> Search for a category "G6"
> It doesn't show "G6_SubCategory" in the search (refer to image 
> Old-ui_Category_Bug.png).
> Expand the "G6_C1" category, Api is hit and "G6_SubCategory" is not 
> highlighted (refer to image Old-ui_Category_bug_2.png)
> New-UI (left side search bar):
> Glossary panel-> switch to category
> Search for a category "G6" (left side search bar)
> It doesn't show "G6_SubCategory" in the search
> Expand "G6_C1" category, Api is hit and "G6_SubCategory" is not highlighted



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ATLAS-3903) New UI: Glossary category not reflected in the tree after creation.

2021-04-14 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-3903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17320873#comment-17320873
 ] 

ASF subversion and git services commented on ATLAS-3903:


Commit af2cc7496ef4c856545a730b2e0859066b8dd4b5 in atlas's branch 
refs/heads/master from prasad pawar
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=af2cc74 ]

ATLAS-3903: UI - Glossary category not reflected in the tree after creation.

Signed-off-by: nixonrodrigues 


> New UI: Glossary category not reflected in the tree after creation.
> ---
>
> Key: ATLAS-3903
> URL: https://issues.apache.org/jira/browse/ATLAS-3903
> Project: Atlas
>  Issue Type: Bug
>  Components: atlas-webui
>Reporter: Keval Bhatt
>Assignee: Prasad P. Pawar
>Priority: Major
>  Labels: categories
> Fix For: 3.0.0, 2.2.0
>
> Attachments: 
> 0001-ATLAS-3903-UI-Glossary-category-not-reflected-in-the.patch, 
> 0001-ATLAS-3903-UI-v1-Glossary-category-not-reflected-in-.patch, 
> Category_does_not_reflect_in_dropdown.mkv
>
>
> Steps reproduce the issue:
>  * Create the glossary
>  * Click on "..." to create the category
>  * After adding category details click on save
> Due to regression newly created category is not rendered in the tree view. if 
> a user clicks on the refresh button then it is visible.
> Please check the attached video for a better understanding.
> [^Category_does_not_reflect_in_dropdown.mkv]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ATLAS-3903) New UI: Glossary category not reflected in the tree after creation.

2021-04-14 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-3903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17320874#comment-17320874
 ] 

ASF subversion and git services commented on ATLAS-3903:


Commit 6c259a61875e9110208b993824d45493a0e44468 in atlas's branch 
refs/heads/branch-2.0 from prasad pawar
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=6c259a6 ]

ATLAS-3903: UI - Glossary category not reflected in the tree after creation.

Signed-off-by: nixonrodrigues 
(cherry picked from commit af2cc7496ef4c856545a730b2e0859066b8dd4b5)


> New UI: Glossary category not reflected in the tree after creation.
> ---
>
> Key: ATLAS-3903
> URL: https://issues.apache.org/jira/browse/ATLAS-3903
> Project: Atlas
>  Issue Type: Bug
>  Components: atlas-webui
>Reporter: Keval Bhatt
>Assignee: Prasad P. Pawar
>Priority: Major
>  Labels: categories
> Fix For: 3.0.0, 2.2.0
>
> Attachments: 
> 0001-ATLAS-3903-UI-Glossary-category-not-reflected-in-the.patch, 
> 0001-ATLAS-3903-UI-v1-Glossary-category-not-reflected-in-.patch, 
> Category_does_not_reflect_in_dropdown.mkv
>
>
> Steps reproduce the issue:
>  * Create the glossary
>  * Click on "..." to create the category
>  * After adding category details click on save
> Due to regression newly created category is not rendered in the tree view. if 
> a user clicks on the refresh button then it is visible.
> Please check the attached video for a better understanding.
> [^Category_does_not_reflect_in_dropdown.mkv]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ATLAS-3903) New UI: Glossary category not reflected in the tree after creation.

2021-04-14 Thread Rahul Kurup (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-3903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17320866#comment-17320866
 ] 

Rahul Kurup commented on ATLAS-3903:


+1

> New UI: Glossary category not reflected in the tree after creation.
> ---
>
> Key: ATLAS-3903
> URL: https://issues.apache.org/jira/browse/ATLAS-3903
> Project: Atlas
>  Issue Type: Bug
>  Components: atlas-webui
>Reporter: Keval Bhatt
>Assignee: Prasad P. Pawar
>Priority: Major
>  Labels: categories
> Fix For: 3.0.0, 2.2.0
>
> Attachments: 
> 0001-ATLAS-3903-UI-Glossary-category-not-reflected-in-the.patch, 
> 0001-ATLAS-3903-UI-v1-Glossary-category-not-reflected-in-.patch, 
> Category_does_not_reflect_in_dropdown.mkv
>
>
> Steps reproduce the issue:
>  * Create the glossary
>  * Click on "..." to create the category
>  * After adding category details click on save
> Due to regression newly created category is not rendered in the tree view. if 
> a user clicks on the refresh button then it is visible.
> Please check the attached video for a better understanding.
> [^Category_does_not_reflect_in_dropdown.mkv]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ATLAS-3903) New UI: Glossary category not reflected in the tree after creation.

2021-04-14 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-3903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17320892#comment-17320892
 ] 

ASF subversion and git services commented on ATLAS-3903:


Commit 0527a3cfafbaa17e848a14489f2934b8b2f16552 in atlas's branch 
refs/heads/branch-2.0 from prasad pawar
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=0527a3c ]

ATLAS-3903:UI Glossary category not reflected in the tree after creation.


> New UI: Glossary category not reflected in the tree after creation.
> ---
>
> Key: ATLAS-3903
> URL: https://issues.apache.org/jira/browse/ATLAS-3903
> Project: Atlas
>  Issue Type: Bug
>  Components: atlas-webui
>Reporter: Keval Bhatt
>Assignee: Prasad P. Pawar
>Priority: Major
>  Labels: categories
> Fix For: 3.0.0, 2.2.0
>
> Attachments: 
> 0001-ATLAS-3903-UI-Glossary-category-not-reflected-in-the.patch, 
> 0001-ATLAS-3903-UI-v1-Glossary-category-not-reflected-in-.patch, 
> Category_does_not_reflect_in_dropdown.mkv
>
>
> Steps reproduce the issue:
>  * Create the glossary
>  * Click on "..." to create the category
>  * After adding category details click on save
> Due to regression newly created category is not rendered in the tree view. if 
> a user clicks on the refresh button then it is visible.
> Please check the attached video for a better understanding.
> [^Category_does_not_reflect_in_dropdown.mkv]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ATLAS-3903) New UI: Glossary category not reflected in the tree after creation.

2021-04-14 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-3903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17320891#comment-17320891
 ] 

ASF subversion and git services commented on ATLAS-3903:


Commit ae0f66d015e9a0d79a6997e044e61e645890f14b in atlas's branch 
refs/heads/branch-2.0 from Nixon Rodrigues
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=ae0f66d ]

Revert "ATLAS-3903: UI - Glossary category not reflected in the tree after 
creation."

This reverts commit 6c259a61875e9110208b993824d45493a0e44468.


> New UI: Glossary category not reflected in the tree after creation.
> ---
>
> Key: ATLAS-3903
> URL: https://issues.apache.org/jira/browse/ATLAS-3903
> Project: Atlas
>  Issue Type: Bug
>  Components: atlas-webui
>Reporter: Keval Bhatt
>Assignee: Prasad P. Pawar
>Priority: Major
>  Labels: categories
> Fix For: 3.0.0, 2.2.0
>
> Attachments: 
> 0001-ATLAS-3903-UI-Glossary-category-not-reflected-in-the.patch, 
> 0001-ATLAS-3903-UI-v1-Glossary-category-not-reflected-in-.patch, 
> Category_does_not_reflect_in_dropdown.mkv
>
>
> Steps reproduce the issue:
>  * Create the glossary
>  * Click on "..." to create the category
>  * After adding category details click on save
> Due to regression newly created category is not rendered in the tree view. if 
> a user clicks on the refresh button then it is visible.
> Please check the attached video for a better understanding.
> [^Category_does_not_reflect_in_dropdown.mkv]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ATLAS-4242) (New UI) Single click of glossary doesn't work after clicking on Atlas logo.

2021-04-14 Thread Prasad P. Pawar (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-4242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17320842#comment-17320842
 ] 

Prasad P. Pawar commented on ATLAS-4242:


The fix for this is provided in 
[ATLAS-3887|https://issues.apache.org/jira/browse/ATLAS-3887] patch.

> (New UI) Single click of glossary doesn't work after clicking on Atlas logo.
> 
>
> Key: ATLAS-4242
> URL: https://issues.apache.org/jira/browse/ATLAS-4242
> Project: Atlas
>  Issue Type: Bug
>Reporter: Rahul Kurup
>Assignee: Prasad P. Pawar
>Priority: Minor
>
> Steps:
>  # Select any one existing glossary and single click it.
>  # Then click on Atlas logo
>  # Then once again single click the same glossary
> You will see that the glossary does not get selected as expected.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ATLAS-3903) New UI: Glossary category not reflected in the tree after creation.

2021-04-14 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-3903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17320890#comment-17320890
 ] 

ASF subversion and git services commented on ATLAS-3903:


Commit e6f2a8afe3877db2f63e50137926ffe73ae6a991 in atlas's branch 
refs/heads/master from prasad pawar
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=e6f2a8a ]

ATLAS-3903:UI v1 Glossary category not reflected in the tree after creation.


> New UI: Glossary category not reflected in the tree after creation.
> ---
>
> Key: ATLAS-3903
> URL: https://issues.apache.org/jira/browse/ATLAS-3903
> Project: Atlas
>  Issue Type: Bug
>  Components: atlas-webui
>Reporter: Keval Bhatt
>Assignee: Prasad P. Pawar
>Priority: Major
>  Labels: categories
> Fix For: 3.0.0, 2.2.0
>
> Attachments: 
> 0001-ATLAS-3903-UI-Glossary-category-not-reflected-in-the.patch, 
> 0001-ATLAS-3903-UI-v1-Glossary-category-not-reflected-in-.patch, 
> Category_does_not_reflect_in_dropdown.mkv
>
>
> Steps reproduce the issue:
>  * Create the glossary
>  * Click on "..." to create the category
>  * After adding category details click on save
> Due to regression newly created category is not rendered in the tree view. if 
> a user clicks on the refresh button then it is visible.
> Please check the attached video for a better understanding.
> [^Category_does_not_reflect_in_dropdown.mkv]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ATLAS-3903) New UI: Glossary category not reflected in the tree after creation.

2021-04-14 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-3903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17320889#comment-17320889
 ] 

ASF subversion and git services commented on ATLAS-3903:


Commit 7b0ecd1dcb92dad5b9a0659f7b5f2a7fa1d95f93 in atlas's branch 
refs/heads/master from Nixon Rodrigues
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=7b0ecd1 ]

Revert "ATLAS-3903: UI - Glossary category not reflected in the tree after 
creation."

This reverts commit af2cc7496ef4c856545a730b2e0859066b8dd4b5.


> New UI: Glossary category not reflected in the tree after creation.
> ---
>
> Key: ATLAS-3903
> URL: https://issues.apache.org/jira/browse/ATLAS-3903
> Project: Atlas
>  Issue Type: Bug
>  Components: atlas-webui
>Reporter: Keval Bhatt
>Assignee: Prasad P. Pawar
>Priority: Major
>  Labels: categories
> Fix For: 3.0.0, 2.2.0
>
> Attachments: 
> 0001-ATLAS-3903-UI-Glossary-category-not-reflected-in-the.patch, 
> 0001-ATLAS-3903-UI-v1-Glossary-category-not-reflected-in-.patch, 
> Category_does_not_reflect_in_dropdown.mkv
>
>
> Steps reproduce the issue:
>  * Create the glossary
>  * Click on "..." to create the category
>  * After adding category details click on save
> Due to regression newly created category is not rendered in the tree view. if 
> a user clicks on the refresh button then it is visible.
> Please check the attached video for a better understanding.
> [^Category_does_not_reflect_in_dropdown.mkv]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: Review Request 72644: ATLAS-3872 Restrict typedef creation when a child type attribute conflicts with parent type attribute of same name

2021-04-14 Thread Pinal Shah

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72644/#review222823
---


Ship it!




Ship It!

- Pinal Shah


On April 8, 2021, 1:01 p.m., Mandar Ambawane wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72644/
> ---
> 
> (Updated April 8, 2021, 1:01 p.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3872
> https://issues.apache.org/jira/browse/ATLAS-3872
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Cause of the problem:
> Type-def Column is created by quick-start script.
> 
> Here in this case, Type-def Column has the attribute "name". And it has 
> property isOptional = true
> 
> Type-def Column is a child of Type-def Asset which also has the attribute 
> "name". And it has property isOptional = false
> 
> Now while creating Entity of Type-def Column from UI, it does not show 
> attribute "name" in the mandatory fields because for Type-def Column its 
> property isOptional = true
> 
> But while validating the attributes from server side we iterate through all 
> the attributes of Entity type (Including Parent's attributes)
> In this case, while validating Type-def Asset's attribute "name" (which has 
> property isOptional = false) we get an error because its value is sent as 
> "null" from UI side.
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 773fae2 
>   intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 
> 22259bc 
>   intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 27c7f73 
>   intg/src/main/java/org/apache/atlas/type/AtlasStructType.java d89aca2 
>   intg/src/test/java/org/apache/atlas/TestUtilsV2.java 80ab6b4 
>   intg/src/test/java/org/apache/atlas/model/ModelTestUtil.java 5df9525 
>   repository/src/test/resources/logging-v1-full.zip 
> 69c54eec000964a1f6f3fef96b26cca188a28ba1 
>   repository/src/test/resources/sales-v1-full.zip 
> 07afbf6ecae312a840b54cae5ab01335c513d180 
>   repository/src/test/resources/salesNewTypeAttrs-next.zip 
> e4c8505be1587fb7cc8b6354bdda701e9557da99 
>   repository/src/test/resources/salesNewTypeAttrs.zip 
> a4467e641fffb10189288fb2f26dc4fbc06bbd42 
>   webapp/src/main/java/org/apache/atlas/examples/QuickStart.java 82a9f5c 
>   webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java d5cf9b7 
>   webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java 
> 6db6b58 
>   
> webapp/src/test/java/org/apache/atlas/web/integration/TypedefsJerseyResourceIT.java
>  0cd707f 
>   
> webapp/src/test/java/org/apache/atlas/web/integration/TypesJerseyResourceIT.java
>  7c820e7 
> 
> 
> Diff: https://reviews.apache.org/r/72644/diff/7/
> 
> 
> Testing
> ---
> 
> PreCommit: 
> https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2007/console
> 
> PreCommit: 
> https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2014/console
> 
> PreCommit: 
> https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2083/console
> 
> PreCommit: 
> https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2088/console
> 
> 
> Thanks,
> 
> Mandar Ambawane
> 
>



Re: Review Request 72644: ATLAS-3872 Restrict typedef creation when a child type attribute conflicts with parent type attribute of same name

2021-04-14 Thread Pinal Shah


> On April 14, 2021, 11:28 a.m., Pinal Shah wrote:
> > Ship It!

Need to trigger Precommit


- Pinal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72644/#review222823
---


On April 8, 2021, 1:01 p.m., Mandar Ambawane wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72644/
> ---
> 
> (Updated April 8, 2021, 1:01 p.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3872
> https://issues.apache.org/jira/browse/ATLAS-3872
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Cause of the problem:
> Type-def Column is created by quick-start script.
> 
> Here in this case, Type-def Column has the attribute "name". And it has 
> property isOptional = true
> 
> Type-def Column is a child of Type-def Asset which also has the attribute 
> "name". And it has property isOptional = false
> 
> Now while creating Entity of Type-def Column from UI, it does not show 
> attribute "name" in the mandatory fields because for Type-def Column its 
> property isOptional = true
> 
> But while validating the attributes from server side we iterate through all 
> the attributes of Entity type (Including Parent's attributes)
> In this case, while validating Type-def Asset's attribute "name" (which has 
> property isOptional = false) we get an error because its value is sent as 
> "null" from UI side.
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 773fae2 
>   intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 
> 22259bc 
>   intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 27c7f73 
>   intg/src/main/java/org/apache/atlas/type/AtlasStructType.java d89aca2 
>   intg/src/test/java/org/apache/atlas/TestUtilsV2.java 80ab6b4 
>   intg/src/test/java/org/apache/atlas/model/ModelTestUtil.java 5df9525 
>   repository/src/test/resources/logging-v1-full.zip 
> 69c54eec000964a1f6f3fef96b26cca188a28ba1 
>   repository/src/test/resources/sales-v1-full.zip 
> 07afbf6ecae312a840b54cae5ab01335c513d180 
>   repository/src/test/resources/salesNewTypeAttrs-next.zip 
> e4c8505be1587fb7cc8b6354bdda701e9557da99 
>   repository/src/test/resources/salesNewTypeAttrs.zip 
> a4467e641fffb10189288fb2f26dc4fbc06bbd42 
>   webapp/src/main/java/org/apache/atlas/examples/QuickStart.java 82a9f5c 
>   webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java d5cf9b7 
>   webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java 
> 6db6b58 
>   
> webapp/src/test/java/org/apache/atlas/web/integration/TypedefsJerseyResourceIT.java
>  0cd707f 
>   
> webapp/src/test/java/org/apache/atlas/web/integration/TypesJerseyResourceIT.java
>  7c820e7 
> 
> 
> Diff: https://reviews.apache.org/r/72644/diff/7/
> 
> 
> Testing
> ---
> 
> PreCommit: 
> https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2007/console
> 
> PreCommit: 
> https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2014/console
> 
> PreCommit: 
> https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2083/console
> 
> PreCommit: 
> https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2088/console
> 
> 
> Thanks,
> 
> Mandar Ambawane
> 
>



Re: Review Request 73258: ATLAS-4195: [Atlas: Audits] 2 entries are created in audits when "replace columns" command is executed in hive

2021-04-14 Thread Nikhil Bonte

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73258/#review222825
---



Started a pre-commit - 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/497/

- Nikhil Bonte


On March 29, 2021, 11:29 p.m., Deep Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73258/
> ---
> 
> (Updated March 29, 2021, 11:29 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-4195
> https://issues.apache.org/jira/browse/ATLAS-4195
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> When columns for certain table are deleted or replaced, in graph we mark the 
> table relationship with columns(replaced or deleted) as inactive. When shuch 
> a table's definition is sent by Hivehook in some event(may be as refered 
> entity), an update audit is created for the table (irrespective of 
> differential audit feature being enableld or disabled). 
> 
> This is because in entity comparator, where we compare relationships of 
> stored entity with the relationships of incoming refered table entity, we do 
> not ignore the inactive relationships of stored entity. This was because 
> mapVertexToArray method of EntityGraphRetriever did not have the capability 
> to ignore AtlasEdges having inactive status.
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityComparator.java
>  d962385c2 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
>  8208d11c2 
> 
> 
> Diff: https://reviews.apache.org/r/73258/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing was done.
> 
> 
> Thanks,
> 
> Deep Singh
> 
>



[jira] [Updated] (ATLAS-3919) Handling classification propagation as deferred-action

2021-04-14 Thread Sarath Subramanian (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sarath Subramanian updated ATLAS-3919:
--
Fix Version/s: 2.2.0
   3.0.0

> Handling classification propagation as deferred-action
> --
>
> Key: ATLAS-3919
> URL: https://issues.apache.org/jira/browse/ATLAS-3919
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Affects Versions: 2.0.0, 2.1.0
>Reporter: Jayendra Parab
>Assignee: Jayendra Parab
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
>
> Currently, whenever a user assigns a tag or updates a tag on an entity, it 
> gets propagated to all the entities derived from the tagged entity. This 
> operation takes quite a lot of time to complete (sometimes into minutes) and 
> causes usability issues on the UI and other clients invoking the REST API
> To resolve this issue, tag-propagation needs to be handled as 
> deferred-action, so that time consuming like propagation, audits & 
> notifications can be processed in background threads



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (ATLAS-3919) Handling classification propagation as deferred-action

2021-04-14 Thread Sarath Subramanian (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sarath Subramanian resolved ATLAS-3919.
---
Resolution: Fixed

> Handling classification propagation as deferred-action
> --
>
> Key: ATLAS-3919
> URL: https://issues.apache.org/jira/browse/ATLAS-3919
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Affects Versions: 2.0.0, 2.1.0
>Reporter: Jayendra Parab
>Assignee: Jayendra Parab
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
>
> Currently, whenever a user assigns a tag or updates a tag on an entity, it 
> gets propagated to all the entities derived from the tagged entity. This 
> operation takes quite a lot of time to complete (sometimes into minutes) and 
> causes usability issues on the UI and other clients invoking the REST API
> To resolve this issue, tag-propagation needs to be handled as 
> deferred-action, so that time consuming like propagation, audits & 
> notifications can be processed in background threads



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ATLAS-3919) Handling classification propagation as deferred-action

2021-04-14 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-3919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17321811#comment-17321811
 ] 

ASF subversion and git services commented on ATLAS-3919:


Commit 0751f16250220271ce63ab7523de37e1f85defda in atlas's branch 
refs/heads/master from Ashutosh Mestry
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=0751f16 ]

ATLAS-3919: Handling classification propagation as deferred-action

Co-authored-by: Jayendra Parab 

Signed-off-by: Sarath Subramanian 


> Handling classification propagation as deferred-action
> --
>
> Key: ATLAS-3919
> URL: https://issues.apache.org/jira/browse/ATLAS-3919
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Affects Versions: 2.0.0, 2.1.0
>Reporter: Jayendra Parab
>Assignee: Jayendra Parab
>Priority: Major
>
> Currently, whenever a user assigns a tag or updates a tag on an entity, it 
> gets propagated to all the entities derived from the tagged entity. This 
> operation takes quite a lot of time to complete (sometimes into minutes) and 
> causes usability issues on the UI and other clients invoking the REST API
> To resolve this issue, tag-propagation needs to be handled as 
> deferred-action, so that time consuming like propagation, audits & 
> notifications can be processed in background threads



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ATLAS-3919) Handling classification propagation as deferred-action

2021-04-14 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-3919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17321813#comment-17321813
 ] 

ASF subversion and git services commented on ATLAS-3919:


Commit 6eb970ce23d4ce290687512d3871db8f086a9e4f in atlas's branch 
refs/heads/branch-2.0 from Ashutosh Mestry
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=6eb970c ]

ATLAS-3919: Handling classification propagation as deferred-action

Co-authored-by: Jayendra Parab 

Signed-off-by: Sarath Subramanian 
(cherry picked from commit 0751f16250220271ce63ab7523de37e1f85defda)


> Handling classification propagation as deferred-action
> --
>
> Key: ATLAS-3919
> URL: https://issues.apache.org/jira/browse/ATLAS-3919
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Affects Versions: 2.0.0, 2.1.0
>Reporter: Jayendra Parab
>Assignee: Jayendra Parab
>Priority: Major
>
> Currently, whenever a user assigns a tag or updates a tag on an entity, it 
> gets propagated to all the entities derived from the tagged entity. This 
> operation takes quite a lot of time to complete (sometimes into minutes) and 
> causes usability issues on the UI and other clients invoking the REST API
> To resolve this issue, tag-propagation needs to be handled as 
> deferred-action, so that time consuming like propagation, audits & 
> notifications can be processed in background threads



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: Review Request 73271: ATLAS-4238 : Quick Search: handle special characters to get correct results

2021-04-14 Thread Pinal Shah


> On April 14, 2021, 5:18 a.m., Sidharth Mishra wrote:
> > The precommit has failed. Please chck before merge.

it failed at Hive-bridge module, which is not related to this patch


- Pinal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73271/#review222818
---


On April 14, 2021, 6:40 a.m., Pinal Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73271/
> ---
> 
> (Updated April 14, 2021, 6:40 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4238
> https://issues.apache.org/jira/browse/ATLAS-4238
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Current working:** During freetext/quick search, wildcard '*' is appended 
> after the search string from UI.
> Whenever attribute search value has "**+-&|!(){}[]^"~?:**"  special 
> characters, then '*' will not be appended to get the correct result.
> 
> ('*' is removed because for TEXT type attribute, it tokenize the value on 
> special characters)
> 
> **Issue:** '@' or 'digit+.' etc there are many other special characters which 
> gets tokenize for 'TEXT' type attribute. hence if the search value has these 
> special characters which are not added in above list, it doesn't give results.
> 
> **Solution:** We need to handle all the special characters which tokenize the 
> string
> 
> **Note:** This patch doesn't handle escaping special characters when search 
> as part of freetext search
>  
>  - Whenever user tends to search for **'STRING'** type attribute example: 
> 'name'
>i.  **Client has to escape 'space'**
>ii.**For the partial search, client has to append '*' **
> 
>Example: to search string with name = sales department@hdfc, user has 
> to search like sales\ department*
>
>  - Whenever user tends to search for **'TEXT'** type attribute example: 
> 'qualifiedName'
>i.  **No Need of escape 'space'**. If it is escaped partial search will 
> not work
>ii.**For partial search, no need of appending '*' **
> 
>Example: to search string with qualifiedName = sales department@hdfc, 
> user has to search like sales department or sales\ department@hdfc
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java
>  4ae2d1279 
>   
> repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java
>  9846d4310 
> 
> 
> Diff: https://reviews.apache.org/r/73271/diff/3/
> 
> 
> Testing
> ---
> 
> added test cases
> Precommit: 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/487/console
> 
> 
> Thanks,
> 
> Pinal Shah
> 
>



[jira] [Created] (ATLAS-4244) Atlas: UI Lineage tab gives Uncaught TypeError

2021-04-14 Thread Prasad P. Pawar (Jira)
Prasad P. Pawar created ATLAS-4244:
--

 Summary: Atlas: UI Lineage tab gives Uncaught TypeError
 Key: ATLAS-4244
 URL: https://issues.apache.org/jira/browse/ATLAS-4244
 Project: Atlas
  Issue Type: Bug
  Components: atlas-webui
Reporter: Prasad P. Pawar
Assignee: Prasad P. Pawar


1) The lineage tab gives Uncaught TypeError in the console panel.

LineageLayoutView.js?bust=1576185031805:208 Uncaught TypeError: Cannot read 
property 'trunc' of undefined
at N.d. (LineageLayoutView.js?bust=1576185031805:208)
at LineageLayoutView.js?bust=1576185031805:222
at Function.s.each.s.forEach (underscore-min.js?bust=1576185031805:1)
at N.d.crateLineageRelationshipHashMap 
(LineageLayoutView.js?bust=1576185031805:221)
at Object.success (LineageLayoutView.js?bust=1576185031805:147)
at k (jquery.min.js?bust=1576185031805:2)
at Object.fireWith [as resolveWith] (jquery.min.js?bust=1576185031805:2)
at d (jquery.min.js?bust=1576185031805:3)
at XMLHttpRequest. (jquery.min.js?bust=1576185031805:3)

2) createTime & modifiedTime show incorrect date value of entity detail page, 
when default values are "0" (ENGESC-3036-manulife branch).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-4244) Atlas: UI Lineage tab gives Uncaught TypeError

2021-04-14 Thread Prasad P. Pawar (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Prasad P. Pawar updated ATLAS-4244:
---
Attachment: 0001-ENGESC-3036-manulife-ATLAS-UI-Lineage-without-displa.patch

> Atlas: UI Lineage tab gives Uncaught TypeError
> --
>
> Key: ATLAS-4244
> URL: https://issues.apache.org/jira/browse/ATLAS-4244
> Project: Atlas
>  Issue Type: Bug
>  Components: atlas-webui
>Reporter: Prasad P. Pawar
>Assignee: Prasad P. Pawar
>Priority: Major
> Attachments: 
> 0001-ENGESC-3036-manulife-ATLAS-UI-Lineage-without-displa.patch, 
> 0001-HDP-3.1-maint-ATLAS-UI-Lineage-without-displayText-k.patch
>
>
> 1) The lineage tab gives Uncaught TypeError in the console panel. 
> (ENGESC-3036-manulife branch, HDP-3.1-maint branch, cdpd master branch & 
> CDH-7.1-maint branch)
> LineageLayoutView.js?bust=1576185031805:208 Uncaught TypeError: Cannot read 
> property 'trunc' of undefined
> at N.d. (LineageLayoutView.js?bust=1576185031805:208)
> at LineageLayoutView.js?bust=1576185031805:222
> at Function.s.each.s.forEach (underscore-min.js?bust=1576185031805:1)
> at N.d.crateLineageRelationshipHashMap 
> (LineageLayoutView.js?bust=1576185031805:221)
> at Object.success (LineageLayoutView.js?bust=1576185031805:147)
> at k (jquery.min.js?bust=1576185031805:2)
> at Object.fireWith [as resolveWith] (jquery.min.js?bust=1576185031805:2)
> at d (jquery.min.js?bust=1576185031805:3)
> at XMLHttpRequest. (jquery.min.js?bust=1576185031805:3)
> 2) createTime & modifiedTime show incorrect date value of entity detail page, 
> when default values are "0" (ENGESC-3036-manulife branch).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-4244) Atlas: UI Lineage tab gives Uncaught TypeError

2021-04-14 Thread Prasad P. Pawar (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Prasad P. Pawar updated ATLAS-4244:
---
Description: 
1) The lineage tab gives Uncaught TypeError in the console panel. 
(ENGESC-3036-manulife branch, HDP-3.1-maint branch, cdpd master branch & 
CDH-7.1-maint branch)

LineageLayoutView.js?bust=1576185031805:208 Uncaught TypeError: Cannot read 
property 'trunc' of undefined
at N.d. (LineageLayoutView.js?bust=1576185031805:208)
at LineageLayoutView.js?bust=1576185031805:222
at Function.s.each.s.forEach (underscore-min.js?bust=1576185031805:1)
at N.d.crateLineageRelationshipHashMap 
(LineageLayoutView.js?bust=1576185031805:221)
at Object.success (LineageLayoutView.js?bust=1576185031805:147)
at k (jquery.min.js?bust=1576185031805:2)
at Object.fireWith [as resolveWith] (jquery.min.js?bust=1576185031805:2)
at d (jquery.min.js?bust=1576185031805:3)
at XMLHttpRequest. (jquery.min.js?bust=1576185031805:3)

2) createTime & modifiedTime show incorrect date value of entity detail page, 
when default values are "0" (ENGESC-3036-manulife branch).

  was:
1) The lineage tab gives Uncaught TypeError in the console panel.

LineageLayoutView.js?bust=1576185031805:208 Uncaught TypeError: Cannot read 
property 'trunc' of undefined
at N.d. (LineageLayoutView.js?bust=1576185031805:208)
at LineageLayoutView.js?bust=1576185031805:222
at Function.s.each.s.forEach (underscore-min.js?bust=1576185031805:1)
at N.d.crateLineageRelationshipHashMap 
(LineageLayoutView.js?bust=1576185031805:221)
at Object.success (LineageLayoutView.js?bust=1576185031805:147)
at k (jquery.min.js?bust=1576185031805:2)
at Object.fireWith [as resolveWith] (jquery.min.js?bust=1576185031805:2)
at d (jquery.min.js?bust=1576185031805:3)
at XMLHttpRequest. (jquery.min.js?bust=1576185031805:3)

2) createTime & modifiedTime show incorrect date value of entity detail page, 
when default values are "0" (ENGESC-3036-manulife branch).


> Atlas: UI Lineage tab gives Uncaught TypeError
> --
>
> Key: ATLAS-4244
> URL: https://issues.apache.org/jira/browse/ATLAS-4244
> Project: Atlas
>  Issue Type: Bug
>  Components: atlas-webui
>Reporter: Prasad P. Pawar
>Assignee: Prasad P. Pawar
>Priority: Major
> Attachments: 
> 0001-ENGESC-3036-manulife-ATLAS-UI-Lineage-without-displa.patch, 
> 0001-HDP-3.1-maint-ATLAS-UI-Lineage-without-displayText-k.patch
>
>
> 1) The lineage tab gives Uncaught TypeError in the console panel. 
> (ENGESC-3036-manulife branch, HDP-3.1-maint branch, cdpd master branch & 
> CDH-7.1-maint branch)
> LineageLayoutView.js?bust=1576185031805:208 Uncaught TypeError: Cannot read 
> property 'trunc' of undefined
> at N.d. (LineageLayoutView.js?bust=1576185031805:208)
> at LineageLayoutView.js?bust=1576185031805:222
> at Function.s.each.s.forEach (underscore-min.js?bust=1576185031805:1)
> at N.d.crateLineageRelationshipHashMap 
> (LineageLayoutView.js?bust=1576185031805:221)
> at Object.success (LineageLayoutView.js?bust=1576185031805:147)
> at k (jquery.min.js?bust=1576185031805:2)
> at Object.fireWith [as resolveWith] (jquery.min.js?bust=1576185031805:2)
> at d (jquery.min.js?bust=1576185031805:3)
> at XMLHttpRequest. (jquery.min.js?bust=1576185031805:3)
> 2) createTime & modifiedTime show incorrect date value of entity detail page, 
> when default values are "0" (ENGESC-3036-manulife branch).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-4244) Atlas: UI Lineage tab gives Uncaught TypeError

2021-04-14 Thread Prasad P. Pawar (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Prasad P. Pawar updated ATLAS-4244:
---
Attachment: 0001-HDP-3.1-maint-ATLAS-UI-Lineage-without-displayText-k.patch

> Atlas: UI Lineage tab gives Uncaught TypeError
> --
>
> Key: ATLAS-4244
> URL: https://issues.apache.org/jira/browse/ATLAS-4244
> Project: Atlas
>  Issue Type: Bug
>  Components: atlas-webui
>Reporter: Prasad P. Pawar
>Assignee: Prasad P. Pawar
>Priority: Major
> Attachments: 
> 0001-ENGESC-3036-manulife-ATLAS-UI-Lineage-without-displa.patch, 
> 0001-HDP-3.1-maint-ATLAS-UI-Lineage-without-displayText-k.patch
>
>
> 1) The lineage tab gives Uncaught TypeError in the console panel. 
> (ENGESC-3036-manulife branch, HDP-3.1-maint branch, cdpd master branch & 
> CDH-7.1-maint branch)
> LineageLayoutView.js?bust=1576185031805:208 Uncaught TypeError: Cannot read 
> property 'trunc' of undefined
> at N.d. (LineageLayoutView.js?bust=1576185031805:208)
> at LineageLayoutView.js?bust=1576185031805:222
> at Function.s.each.s.forEach (underscore-min.js?bust=1576185031805:1)
> at N.d.crateLineageRelationshipHashMap 
> (LineageLayoutView.js?bust=1576185031805:221)
> at Object.success (LineageLayoutView.js?bust=1576185031805:147)
> at k (jquery.min.js?bust=1576185031805:2)
> at Object.fireWith [as resolveWith] (jquery.min.js?bust=1576185031805:2)
> at d (jquery.min.js?bust=1576185031805:3)
> at XMLHttpRequest. (jquery.min.js?bust=1576185031805:3)
> 2) createTime & modifiedTime show incorrect date value of entity detail page, 
> when default values are "0" (ENGESC-3036-manulife branch).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-4244) Atlas: UI Lineage tab gives Uncaught TypeError

2021-04-14 Thread Prasad P. Pawar (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Prasad P. Pawar updated ATLAS-4244:
---
Attachment: 0001-ATLAS-UI-Lineage-without-displayText-key-fixed.patch

> Atlas: UI Lineage tab gives Uncaught TypeError
> --
>
> Key: ATLAS-4244
> URL: https://issues.apache.org/jira/browse/ATLAS-4244
> Project: Atlas
>  Issue Type: Bug
>  Components: atlas-webui
>Reporter: Prasad P. Pawar
>Assignee: Prasad P. Pawar
>Priority: Major
> Attachments: 
> 0001-ATLAS-UI-Lineage-without-displayText-key-fixed.patch, 
> 0001-ENGESC-3036-manulife-ATLAS-UI-Lineage-without-displa.patch, 
> 0001-HDP-3.1-maint-ATLAS-UI-Lineage-without-displayText-k.patch
>
>
> 1) The lineage tab gives Uncaught TypeError in the console panel. 
> (ENGESC-3036-manulife branch, HDP-3.1-maint branch, cdpd master branch & 
> CDH-7.1-maint branch)
> LineageLayoutView.js?bust=1576185031805:208 Uncaught TypeError: Cannot read 
> property 'trunc' of undefined
> at N.d. (LineageLayoutView.js?bust=1576185031805:208)
> at LineageLayoutView.js?bust=1576185031805:222
> at Function.s.each.s.forEach (underscore-min.js?bust=1576185031805:1)
> at N.d.crateLineageRelationshipHashMap 
> (LineageLayoutView.js?bust=1576185031805:221)
> at Object.success (LineageLayoutView.js?bust=1576185031805:147)
> at k (jquery.min.js?bust=1576185031805:2)
> at Object.fireWith [as resolveWith] (jquery.min.js?bust=1576185031805:2)
> at d (jquery.min.js?bust=1576185031805:3)
> at XMLHttpRequest. (jquery.min.js?bust=1576185031805:3)
> 2) createTime & modifiedTime show incorrect date value of entity detail page, 
> when default values are "0" (ENGESC-3036-manulife branch).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-4244) Atlas: UI Lineage tab gives Uncaught TypeError

2021-04-14 Thread Prasad P. Pawar (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Prasad P. Pawar updated ATLAS-4244:
---
Attachment: (was: 
0001-HDP-3.1-maint-ATLAS-UI-Lineage-without-displayText-k.patch)

> Atlas: UI Lineage tab gives Uncaught TypeError
> --
>
> Key: ATLAS-4244
> URL: https://issues.apache.org/jira/browse/ATLAS-4244
> Project: Atlas
>  Issue Type: Bug
>  Components: atlas-webui
>Reporter: Prasad P. Pawar
>Assignee: Prasad P. Pawar
>Priority: Major
> Attachments: 0001-ATLAS-UI-Lineage-without-displayText-key-fixed.patch
>
>
> 1) The lineage tab gives Uncaught TypeError in the console panel. 
> (ENGESC-3036-manulife branch, HDP-3.1-maint branch, cdpd master branch & 
> CDH-7.1-maint branch)
> LineageLayoutView.js?bust=1576185031805:208 Uncaught TypeError: Cannot read 
> property 'trunc' of undefined
> at N.d. (LineageLayoutView.js?bust=1576185031805:208)
> at LineageLayoutView.js?bust=1576185031805:222
> at Function.s.each.s.forEach (underscore-min.js?bust=1576185031805:1)
> at N.d.crateLineageRelationshipHashMap 
> (LineageLayoutView.js?bust=1576185031805:221)
> at Object.success (LineageLayoutView.js?bust=1576185031805:147)
> at k (jquery.min.js?bust=1576185031805:2)
> at Object.fireWith [as resolveWith] (jquery.min.js?bust=1576185031805:2)
> at d (jquery.min.js?bust=1576185031805:3)
> at XMLHttpRequest. (jquery.min.js?bust=1576185031805:3)
> 2) createTime & modifiedTime show incorrect date value of entity detail page, 
> when default values are "0" (ENGESC-3036-manulife branch).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-4244) Atlas: UI Lineage tab gives Uncaught TypeError

2021-04-14 Thread Prasad P. Pawar (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Prasad P. Pawar updated ATLAS-4244:
---
Description: 
1) The lineage tab gives Uncaught TypeError in the console panel.

LineageLayoutView.js?bust=1576185031805:208 Uncaught TypeError: Cannot read 
property 'trunc' of undefined
at N.d. (LineageLayoutView.js?bust=1576185031805:208)
at LineageLayoutView.js?bust=1576185031805:222
at Function.s.each.s.forEach (underscore-min.js?bust=1576185031805:1)
at N.d.crateLineageRelationshipHashMap 
(LineageLayoutView.js?bust=1576185031805:221)
at Object.success (LineageLayoutView.js?bust=1576185031805:147)
at k (jquery.min.js?bust=1576185031805:2)
at Object.fireWith [as resolveWith] (jquery.min.js?bust=1576185031805:2)
at d (jquery.min.js?bust=1576185031805:3)
at XMLHttpRequest. (jquery.min.js?bust=1576185031805:3)


  was:
1) The lineage tab gives Uncaught TypeError in the console panel. 
(ENGESC-3036-manulife branch, HDP-3.1-maint branch, cdpd master branch & 
CDH-7.1-maint branch)

LineageLayoutView.js?bust=1576185031805:208 Uncaught TypeError: Cannot read 
property 'trunc' of undefined
at N.d. (LineageLayoutView.js?bust=1576185031805:208)
at LineageLayoutView.js?bust=1576185031805:222
at Function.s.each.s.forEach (underscore-min.js?bust=1576185031805:1)
at N.d.crateLineageRelationshipHashMap 
(LineageLayoutView.js?bust=1576185031805:221)
at Object.success (LineageLayoutView.js?bust=1576185031805:147)
at k (jquery.min.js?bust=1576185031805:2)
at Object.fireWith [as resolveWith] (jquery.min.js?bust=1576185031805:2)
at d (jquery.min.js?bust=1576185031805:3)
at XMLHttpRequest. (jquery.min.js?bust=1576185031805:3)

2) createTime & modifiedTime show incorrect date value of entity detail page, 
when default values are "0" (ENGESC-3036-manulife branch).


> Atlas: UI Lineage tab gives Uncaught TypeError
> --
>
> Key: ATLAS-4244
> URL: https://issues.apache.org/jira/browse/ATLAS-4244
> Project: Atlas
>  Issue Type: Bug
>  Components: atlas-webui
>Reporter: Prasad P. Pawar
>Assignee: Prasad P. Pawar
>Priority: Major
> Attachments: 0001-ATLAS-UI-Lineage-without-displayText-key-fixed.patch
>
>
> 1) The lineage tab gives Uncaught TypeError in the console panel.
> LineageLayoutView.js?bust=1576185031805:208 Uncaught TypeError: Cannot read 
> property 'trunc' of undefined
> at N.d. (LineageLayoutView.js?bust=1576185031805:208)
> at LineageLayoutView.js?bust=1576185031805:222
> at Function.s.each.s.forEach (underscore-min.js?bust=1576185031805:1)
> at N.d.crateLineageRelationshipHashMap 
> (LineageLayoutView.js?bust=1576185031805:221)
> at Object.success (LineageLayoutView.js?bust=1576185031805:147)
> at k (jquery.min.js?bust=1576185031805:2)
> at Object.fireWith [as resolveWith] (jquery.min.js?bust=1576185031805:2)
> at d (jquery.min.js?bust=1576185031805:3)
> at XMLHttpRequest. (jquery.min.js?bust=1576185031805:3)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-4244) Atlas: UI Lineage tab gives Uncaught TypeError

2021-04-14 Thread Prasad P. Pawar (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Prasad P. Pawar updated ATLAS-4244:
---
Attachment: (was: 
0001-ENGESC-3036-manulife-ATLAS-UI-Lineage-without-displa.patch)

> Atlas: UI Lineage tab gives Uncaught TypeError
> --
>
> Key: ATLAS-4244
> URL: https://issues.apache.org/jira/browse/ATLAS-4244
> Project: Atlas
>  Issue Type: Bug
>  Components: atlas-webui
>Reporter: Prasad P. Pawar
>Assignee: Prasad P. Pawar
>Priority: Major
> Attachments: 0001-ATLAS-UI-Lineage-without-displayText-key-fixed.patch
>
>
> 1) The lineage tab gives Uncaught TypeError in the console panel. 
> (ENGESC-3036-manulife branch, HDP-3.1-maint branch, cdpd master branch & 
> CDH-7.1-maint branch)
> LineageLayoutView.js?bust=1576185031805:208 Uncaught TypeError: Cannot read 
> property 'trunc' of undefined
> at N.d. (LineageLayoutView.js?bust=1576185031805:208)
> at LineageLayoutView.js?bust=1576185031805:222
> at Function.s.each.s.forEach (underscore-min.js?bust=1576185031805:1)
> at N.d.crateLineageRelationshipHashMap 
> (LineageLayoutView.js?bust=1576185031805:221)
> at Object.success (LineageLayoutView.js?bust=1576185031805:147)
> at k (jquery.min.js?bust=1576185031805:2)
> at Object.fireWith [as resolveWith] (jquery.min.js?bust=1576185031805:2)
> at d (jquery.min.js?bust=1576185031805:3)
> at XMLHttpRequest. (jquery.min.js?bust=1576185031805:3)
> 2) createTime & modifiedTime show incorrect date value of entity detail page, 
> when default values are "0" (ENGESC-3036-manulife branch).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ATLAS-4244) Atlas: UI Lineage tab gives Uncaught TypeError

2021-04-14 Thread Prasad P. Pawar (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-4244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17320771#comment-17320771
 ] 

Prasad P. Pawar commented on ATLAS-4244:


Hi,
The uploaded patch has this Lineage fix 

> Atlas: UI Lineage tab gives Uncaught TypeError
> --
>
> Key: ATLAS-4244
> URL: https://issues.apache.org/jira/browse/ATLAS-4244
> Project: Atlas
>  Issue Type: Bug
>  Components: atlas-webui
>Reporter: Prasad P. Pawar
>Assignee: Prasad P. Pawar
>Priority: Major
> Attachments: 0001-ATLAS-UI-Lineage-without-displayText-key-fixed.patch
>
>
> 1) The lineage tab gives Uncaught TypeError in the console panel.
> LineageLayoutView.js?bust=1576185031805:208 Uncaught TypeError: Cannot read 
> property 'trunc' of undefined
> at N.d. (LineageLayoutView.js?bust=1576185031805:208)
> at LineageLayoutView.js?bust=1576185031805:222
> at Function.s.each.s.forEach (underscore-min.js?bust=1576185031805:1)
> at N.d.crateLineageRelationshipHashMap 
> (LineageLayoutView.js?bust=1576185031805:221)
> at Object.success (LineageLayoutView.js?bust=1576185031805:147)
> at k (jquery.min.js?bust=1576185031805:2)
> at Object.fireWith [as resolveWith] (jquery.min.js?bust=1576185031805:2)
> at d (jquery.min.js?bust=1576185031805:3)
> at XMLHttpRequest. (jquery.min.js?bust=1576185031805:3)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-4244) Atlas: UI Lineage tab gives Uncaught TypeError

2021-04-14 Thread Prasad P. Pawar (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Prasad P. Pawar updated ATLAS-4244:
---
Attachment: 4244_bug.png

> Atlas: UI Lineage tab gives Uncaught TypeError
> --
>
> Key: ATLAS-4244
> URL: https://issues.apache.org/jira/browse/ATLAS-4244
> Project: Atlas
>  Issue Type: Bug
>  Components: atlas-webui
>Reporter: Prasad P. Pawar
>Assignee: Prasad P. Pawar
>Priority: Major
> Attachments: 
> 0001-ATLAS-UI-Lineage-without-displayText-key-fixed.patch, 4244_bug.png
>
>
> 1) The lineage tab gives Uncaught TypeError in the console panel, when 
> lineage without displayText & attribute keys.
> LineageLayoutView.js?bust=1576185031805:208 Uncaught TypeError: Cannot read 
> property 'trunc' of undefined
> at N.d. (LineageLayoutView.js?bust=1576185031805:208)
> at LineageLayoutView.js?bust=1576185031805:222
> at Function.s.each.s.forEach (underscore-min.js?bust=1576185031805:1)
> at N.d.crateLineageRelationshipHashMap 
> (LineageLayoutView.js?bust=1576185031805:221)
> at Object.success (LineageLayoutView.js?bust=1576185031805:147)
> at k (jquery.min.js?bust=1576185031805:2)
> at Object.fireWith [as resolveWith] (jquery.min.js?bust=1576185031805:2)
> at d (jquery.min.js?bust=1576185031805:3)
> at XMLHttpRequest. (jquery.min.js?bust=1576185031805:3)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-4244) Atlas: UI Lineage tab gives Uncaught TypeError

2021-04-14 Thread Prasad P. Pawar (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Prasad P. Pawar updated ATLAS-4244:
---
Description: 
1) The lineage tab gives Uncaught TypeError in the console panel, when lineage 
without displayText & attribute keys.

LineageLayoutView.js?bust=1576185031805:208 Uncaught TypeError: Cannot read 
property 'trunc' of undefined
at N.d. (LineageLayoutView.js?bust=1576185031805:208)
at LineageLayoutView.js?bust=1576185031805:222
at Function.s.each.s.forEach (underscore-min.js?bust=1576185031805:1)
at N.d.crateLineageRelationshipHashMap 
(LineageLayoutView.js?bust=1576185031805:221)
at Object.success (LineageLayoutView.js?bust=1576185031805:147)
at k (jquery.min.js?bust=1576185031805:2)
at Object.fireWith [as resolveWith] (jquery.min.js?bust=1576185031805:2)
at d (jquery.min.js?bust=1576185031805:3)
at XMLHttpRequest. (jquery.min.js?bust=1576185031805:3)


  was:
1) The lineage tab gives Uncaught TypeError in the console panel.

LineageLayoutView.js?bust=1576185031805:208 Uncaught TypeError: Cannot read 
property 'trunc' of undefined
at N.d. (LineageLayoutView.js?bust=1576185031805:208)
at LineageLayoutView.js?bust=1576185031805:222
at Function.s.each.s.forEach (underscore-min.js?bust=1576185031805:1)
at N.d.crateLineageRelationshipHashMap 
(LineageLayoutView.js?bust=1576185031805:221)
at Object.success (LineageLayoutView.js?bust=1576185031805:147)
at k (jquery.min.js?bust=1576185031805:2)
at Object.fireWith [as resolveWith] (jquery.min.js?bust=1576185031805:2)
at d (jquery.min.js?bust=1576185031805:3)
at XMLHttpRequest. (jquery.min.js?bust=1576185031805:3)



> Atlas: UI Lineage tab gives Uncaught TypeError
> --
>
> Key: ATLAS-4244
> URL: https://issues.apache.org/jira/browse/ATLAS-4244
> Project: Atlas
>  Issue Type: Bug
>  Components: atlas-webui
>Reporter: Prasad P. Pawar
>Assignee: Prasad P. Pawar
>Priority: Major
> Attachments: 
> 0001-ATLAS-UI-Lineage-without-displayText-key-fixed.patch, 4244_bug.png
>
>
> 1) The lineage tab gives Uncaught TypeError in the console panel, when 
> lineage without displayText & attribute keys.
> LineageLayoutView.js?bust=1576185031805:208 Uncaught TypeError: Cannot read 
> property 'trunc' of undefined
> at N.d. (LineageLayoutView.js?bust=1576185031805:208)
> at LineageLayoutView.js?bust=1576185031805:222
> at Function.s.each.s.forEach (underscore-min.js?bust=1576185031805:1)
> at N.d.crateLineageRelationshipHashMap 
> (LineageLayoutView.js?bust=1576185031805:221)
> at Object.success (LineageLayoutView.js?bust=1576185031805:147)
> at k (jquery.min.js?bust=1576185031805:2)
> at Object.fireWith [as resolveWith] (jquery.min.js?bust=1576185031805:2)
> at d (jquery.min.js?bust=1576185031805:3)
> at XMLHttpRequest. (jquery.min.js?bust=1576185031805:3)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-4244) Atlas: UI Lineage tab gives Uncaught TypeError

2021-04-14 Thread Prasad P. Pawar (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Prasad P. Pawar updated ATLAS-4244:
---
Description: 
1) The lineage tab gives Uncaught TypeError in the console panel, when lineage 
without displayText & attribute keys. (refer 4244_bug.png)

LineageLayoutView.js?bust=1576185031805:208 Uncaught TypeError: Cannot read 
property 'trunc' of undefined
at N.d. (LineageLayoutView.js?bust=1576185031805:208)
at LineageLayoutView.js?bust=1576185031805:222
at Function.s.each.s.forEach (underscore-min.js?bust=1576185031805:1)
at N.d.crateLineageRelationshipHashMap 
(LineageLayoutView.js?bust=1576185031805:221)
at Object.success (LineageLayoutView.js?bust=1576185031805:147)
at k (jquery.min.js?bust=1576185031805:2)
at Object.fireWith [as resolveWith] (jquery.min.js?bust=1576185031805:2)
at d (jquery.min.js?bust=1576185031805:3)
at XMLHttpRequest. (jquery.min.js?bust=1576185031805:3)


  was:
1) The lineage tab gives Uncaught TypeError in the console panel, when lineage 
without displayText & attribute keys.

LineageLayoutView.js?bust=1576185031805:208 Uncaught TypeError: Cannot read 
property 'trunc' of undefined
at N.d. (LineageLayoutView.js?bust=1576185031805:208)
at LineageLayoutView.js?bust=1576185031805:222
at Function.s.each.s.forEach (underscore-min.js?bust=1576185031805:1)
at N.d.crateLineageRelationshipHashMap 
(LineageLayoutView.js?bust=1576185031805:221)
at Object.success (LineageLayoutView.js?bust=1576185031805:147)
at k (jquery.min.js?bust=1576185031805:2)
at Object.fireWith [as resolveWith] (jquery.min.js?bust=1576185031805:2)
at d (jquery.min.js?bust=1576185031805:3)
at XMLHttpRequest. (jquery.min.js?bust=1576185031805:3)



> Atlas: UI Lineage tab gives Uncaught TypeError
> --
>
> Key: ATLAS-4244
> URL: https://issues.apache.org/jira/browse/ATLAS-4244
> Project: Atlas
>  Issue Type: Bug
>  Components: atlas-webui
>Reporter: Prasad P. Pawar
>Assignee: Prasad P. Pawar
>Priority: Major
> Attachments: 
> 0001-ATLAS-UI-Lineage-without-displayText-key-fixed.patch, 4244_bug.png
>
>
> 1) The lineage tab gives Uncaught TypeError in the console panel, when 
> lineage without displayText & attribute keys. (refer 4244_bug.png)
> LineageLayoutView.js?bust=1576185031805:208 Uncaught TypeError: Cannot read 
> property 'trunc' of undefined
> at N.d. (LineageLayoutView.js?bust=1576185031805:208)
> at LineageLayoutView.js?bust=1576185031805:222
> at Function.s.each.s.forEach (underscore-min.js?bust=1576185031805:1)
> at N.d.crateLineageRelationshipHashMap 
> (LineageLayoutView.js?bust=1576185031805:221)
> at Object.success (LineageLayoutView.js?bust=1576185031805:147)
> at k (jquery.min.js?bust=1576185031805:2)
> at Object.fireWith [as resolveWith] (jquery.min.js?bust=1576185031805:2)
> at d (jquery.min.js?bust=1576185031805:3)
> at XMLHttpRequest. (jquery.min.js?bust=1576185031805:3)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: Review Request 73271: ATLAS-4238 : Quick Search: handle special characters to get correct results

2021-04-14 Thread Pinal Shah

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73271/
---

(Updated April 14, 2021, 6:40 a.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
and Sarath Subramanian.


Changes
---

addressed comments


Bugs: ATLAS-4238
https://issues.apache.org/jira/browse/ATLAS-4238


Repository: atlas


Description
---

**Current working:** During freetext/quick search, wildcard '*' is appended 
after the search string from UI.
Whenever attribute search value has "**+-&|!(){}[]^"~?:**"  special characters, 
then '*' will not be appended to get the correct result.

('*' is removed because for TEXT type attribute, it tokenize the value on 
special characters)

**Issue:** '@' or 'digit+.' etc there are many other special characters which 
gets tokenize for 'TEXT' type attribute. hence if the search value has these 
special characters which are not added in above list, it doesn't give results.

**Solution:** We need to handle all the special characters which tokenize the 
string

**Note:** This patch doesn't handle escaping special characters when search as 
part of freetext search
 
 - Whenever user tends to search for **'STRING'** type attribute example: 'name'
   i.  **Client has to escape 'space'**
   ii.**For the partial search, client has to append '*' **

   Example: to search string with name = sales department@hdfc, user has to 
search like sales\ department*
   
 - Whenever user tends to search for **'TEXT'** type attribute example: 
'qualifiedName'
   i.  **No Need of escape 'space'**. If it is escaped partial search will not 
work
   ii.**For partial search, no need of appending '*' **

   Example: to search string with qualifiedName = sales department@hdfc, 
user has to search like sales department or sales\ department@hdfc


Diffs (updated)
-

  
repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 
4ae2d1279 
  
repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java
 9846d4310 


Diff: https://reviews.apache.org/r/73271/diff/3/

Changes: https://reviews.apache.org/r/73271/diff/2-3/


Testing
---

added test cases
Precommit: 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/487/console


Thanks,

Pinal Shah



[jira] [Assigned] (ATLAS-4243) UI: Legend in lineage gets duplicated

2021-04-14 Thread Prasad P. Pawar (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Prasad P. Pawar reassigned ATLAS-4243:
--

Assignee: Prasad P. Pawar

> UI: Legend in lineage gets duplicated
> -
>
> Key: ATLAS-4243
> URL: https://issues.apache.org/jira/browse/ATLAS-4243
> Project: Atlas
>  Issue Type: Bug
>Reporter: Rahul Kurup
>Assignee: Prasad P. Pawar
>Priority: Minor
> Attachments: image-2021-04-14-10-21-12-123.png
>
>
> The legend of the lineage gets duplicated whenever a value is selected from 
> the depth field in filters.
>  
> !image-2021-04-14-10-21-12-123.png!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)