Re: [VOTE] Release Apache brpc(incubating) 0.9.6-rc03

2019-10-07 Thread Tan,Zhongyi
Thanks for your input, Von
I will check with jiashun to clean these issues.
Thanks


在 2019/9/27 下午3:03,“Gosling Von” 写入:


Hi,

-1, there are still many places need to be corrected.


1. Highly recommended use the apache mail to sign your release while not  
zhujiashun2...@gmail.com .
2. The mail list is recommended to discuss issues while not join QQ-group 
498837325.
3. Do not throw binary files such as image file in your src.
4. Many source files are missing ASF HEADS, such as  Bazel, BUILD, 
Dockefile and all files in cmake directory, and so on.
5. keep the same name in GitHub and apache dist(incubator-brpc-0.9.6-rc03, 
apache-brpc-0.9.6.rc03-incubating-src).


p.s.  I would like to recommend guys to refer to the best practice from 
other CPP projects, such as Apache RocketMQ CPP[1], Apache thrift[2]

[1] https://github.com/apache/rocketmq-client-cpp
[2] https://github.com/apache/thrift



Best Regards,
Von Gosling

> On Sep 25, 2019, at 12:28 PM, tan zhongyi  wrote:
> 
> Are release files in correct location?
> [ ]Do release files have the word incubating in their name?
> [ ] Are the digital signature and hashes correct?
> [ ] Does DISCLAIMER file exist?
> [ ]Do LICENSE and NOTICE files exists?
> [ ] Is the LICENSE and NOTICE text correct?
> [




-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org


Re: [VOTE] Release Apache brpc(incubating) 0.9.6-rc03

2019-09-27 Thread Gosling Von

Hi,

-1, there are still many places need to be corrected.


1. Highly recommended use the apache mail to sign your release while not  
zhujiashun2...@gmail.com .
2. The mail list is recommended to discuss issues while not join QQ-group 
498837325.
3. Do not throw binary files such as image file in your src.
4. Many source files are missing ASF HEADS, such as  Bazel, BUILD, Dockefile 
and all files in cmake directory, and so on.
5. keep the same name in GitHub and apache dist(incubator-brpc-0.9.6-rc03, 
apache-brpc-0.9.6.rc03-incubating-src).


p.s.  I would like to recommend guys to refer to the best practice from other 
CPP projects, such as Apache RocketMQ CPP[1], Apache thrift[2]

[1] https://github.com/apache/rocketmq-client-cpp
[2] https://github.com/apache/thrift



Best Regards,
Von Gosling

> On Sep 25, 2019, at 12:28 PM, tan zhongyi  wrote:
> 
> Are release files in correct location?
> [ ]Do release files have the word incubating in their name?
> [ ] Are the digital signature and hashes correct?
> [ ] Does DISCLAIMER file exist?
> [ ]Do LICENSE and NOTICE files exists?
> [ ] Is the LICENSE and NOTICE text correct?
> [



Re: [VOTE] Release Apache brpc(incubating) 0.9.6-rc03

2019-09-26 Thread Tan,Zhongyi
Hi, JB & Kevin & Von,
Please take a look, 
Thanks


在 2019/9/25 下午12:28,“tan zhongyi” 写入:

Hi, guys,



Rc03 is ready for vote, here it is.



I am pleased to be calling this vote for the release of  apache 
brpc(incubating) 0.9.6-rc03.


The source code can be found at:

https://dist.apache.org/repos/dist/dev/incubator/brpc/0.9.6-rc03/apache-brpc-0.9.6.rc03-incubating-src.tar.gz


The release candidate has been tagged in GitHub as 0.9.6-rc03, available 
here:
https://github.com/apache/incubator-brpc/releases/tag/0.9.6-rc03


 The SHA-512 checksum is:

a09b1fb80baf041f7d9ac974b4591c1f97b8a4b35df99a421516ed72baa1bd66aed0ce56683b465ae3bdc7216dff404276d76f8e956119d0a1c1c73bed71002a

which can be found via:

https://dist.apache.org/repos/dist/dev/incubator/brpc/0.9.6-rc03/apache-brpc-0.9.6.rc03-incubating-src.tar.gz.sha512





The signature can be found via:

https://dist.apache.org/repos/dist/dev/incubator/brpc/0.9.6-rc03/apache-brpc-0.9.6.rc03-incubating-src.tar.gz.asc



KEYS file is available here:

https://dist.apache.org/repos/dist/dev/incubator/brpc/KEYS





[Release Note]



  *   Health (of a connection) can be checked at rpc-level
  *   Fix SSL-related compilation issues on Mac
  *   Support SSL-replacement lib MesaLink
  *   Support consistent hashing with ketama algo.
  *   bvar variables can be exported for prometheus services
  *   String[Multi]Splitter supports '\0' as separator
  *   Support for bilibili discovery service
  *   Improved CircuitBreaker
  *   grpc impl. supports timeout





Please vote on releasing this package as:

Apache brpc(incubating) 0.9.6-rc03



This vote will be open until “Mon Oct 30 2019 00:00:00 GMT+0800 (CST)" and

passes if a majority of at least three +1 Apache brpc IPMC votes are

cast.



[ ] +1 Release this package

[ ] 0  I don't feel strongly about it, but don't object

[ ] -1 Do not release this package because...


Checklist for reference:
[ ]Are release files in correct location?
[ ]Do release files have the word incubating in their name?
[ ] Are the digital signature and hashes correct?
[ ] Does DISCLAIMER file exist?
[ ]Do LICENSE and NOTICE files exists?
[ ] Is the LICENSE and NOTICE text correct?
[ ] Is the NOTICE year correct?
[ ] Un-included software dependencies are not mentioned in LICENSE or 
NOTICE?
[ ] License information is not mentioned in NOTICE?
Is there any 3rd party code contained inside the release? If so:
[ ] Does the software have a compatible license?
[ ] Are all software licenses mentioned in LICENSE?
[ ] Is the full text of the licenses (or pointers to it) in LICENSE?
Is any of this code Apache licensed? Do they have NOTICE files? If so:
[ ]Have relevant parts of those NOTICE files been added to this NOTICE file?
[ ]Do all source files have ASF headers?
[ ] Do the contents of the release match with what's tagged in version 
control?
[ ] Are there any unexpected binary files in the release?
[ ] Can you compile from source? Are the instruction clear?




Anyone can participate in testing and voting, not just committers, please

feel free to try out the release candidate and provide your votes.

Thanks





[VOTE] Release Apache brpc(incubating) 0.9.6-rc03

2019-09-24 Thread tan zhongyi
Hi, guys,



Rc03 is ready for vote, here it is.



I am pleased to be calling this vote for the release of  apache 
brpc(incubating) 0.9.6-rc03.


The source code can be found at:
https://dist.apache.org/repos/dist/dev/incubator/brpc/0.9.6-rc03/apache-brpc-0.9.6.rc03-incubating-src.tar.gz


The release candidate has been tagged in GitHub as 0.9.6-rc03, available here:
https://github.com/apache/incubator-brpc/releases/tag/0.9.6-rc03


 The SHA-512 checksum is:
a09b1fb80baf041f7d9ac974b4591c1f97b8a4b35df99a421516ed72baa1bd66aed0ce56683b465ae3bdc7216dff404276d76f8e956119d0a1c1c73bed71002a

which can be found via:
https://dist.apache.org/repos/dist/dev/incubator/brpc/0.9.6-rc03/apache-brpc-0.9.6.rc03-incubating-src.tar.gz.sha512





The signature can be found via:
https://dist.apache.org/repos/dist/dev/incubator/brpc/0.9.6-rc03/apache-brpc-0.9.6.rc03-incubating-src.tar.gz.asc



KEYS file is available here:

https://dist.apache.org/repos/dist/dev/incubator/brpc/KEYS





[Release Note]



  *   Health (of a connection) can be checked at rpc-level
  *   Fix SSL-related compilation issues on Mac
  *   Support SSL-replacement lib MesaLink
  *   Support consistent hashing with ketama algo.
  *   bvar variables can be exported for prometheus services
  *   String[Multi]Splitter supports '\0' as separator
  *   Support for bilibili discovery service
  *   Improved CircuitBreaker
  *   grpc impl. supports timeout





Please vote on releasing this package as:

Apache brpc(incubating) 0.9.6-rc03



This vote will be open until “Mon Oct 30 2019 00:00:00 GMT+0800 (CST)" and

passes if a majority of at least three +1 Apache brpc IPMC votes are

cast.



[ ] +1 Release this package

[ ] 0  I don't feel strongly about it, but don't object

[ ] -1 Do not release this package because...


Checklist for reference:
[ ]Are release files in correct location?
[ ]Do release files have the word incubating in their name?
[ ] Are the digital signature and hashes correct?
[ ] Does DISCLAIMER file exist?
[ ]Do LICENSE and NOTICE files exists?
[ ] Is the LICENSE and NOTICE text correct?
[ ] Is the NOTICE year correct?
[ ] Un-included software dependencies are not mentioned in LICENSE or NOTICE?
[ ] License information is not mentioned in NOTICE?
Is there any 3rd party code contained inside the release? If so:
[ ] Does the software have a compatible license?
[ ] Are all software licenses mentioned in LICENSE?
[ ] Is the full text of the licenses (or pointers to it) in LICENSE?
Is any of this code Apache licensed? Do they have NOTICE files? If so:
[ ]Have relevant parts of those NOTICE files been added to this NOTICE file?
[ ]Do all source files have ASF headers?
[ ] Do the contents of the release match with what's tagged in version control?
[ ] Are there any unexpected binary files in the release?
[ ] Can you compile from source? Are the instruction clear?




Anyone can participate in testing and voting, not just committers, please

feel free to try out the release candidate and provide your votes.

Thanks