Build failed in Jenkins: build-master-slowbuild #3036

[jenkins]

See 

--
[...truncated 28713 lines...]
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud ---
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:instrument (default-cli) @ 
cloud-quickcloud ---
[WARNING] No files to instrument.
[INFO] NOT adding cobertura ser file to attached artifacts list.
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-quickcloud ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ 
cloud-quickcloud ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud ---
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Apache CloudStack Developer Tools - Checkstyle Configuration  SUCCESS 
[2.053s]
[INFO] Apache CloudStack . SUCCESS [2.255s]
[INFO] Apache CloudStack Maven Conventions Parent  SUCCESS [0.812s]
[INFO] Apache CloudStack Framework - Managed Context . SUCCESS [18.885s]
[INFO] Apache CloudStack Utils ... SUCCESS [1:29.969s]
[INFO] Apache CloudStack Framework ... SUCCESS [0.107s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [53.038s]
[INFO] Apache CloudStack Framework - Configuration ... SUCCESS [27.673s]
[INFO] Apache CloudStack API . SUCCESS [1:48.280s]
[INFO] Apache CloudStack Framework - REST  SUCCESS [16.079s]
[INFO] Apache CloudStack Framework - IPC . SUCCESS [30.624s]
[INFO] Apache CloudStack Cloud Engine  SUCCESS [0.137s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [28.714s]
[INFO] Apache CloudStack Framework - Security  SUCCESS [24.478s]
[INFO] Apache CloudStack Core  SUCCESS [1:22.279s]
[INFO] Apache CloudStack Agents .. SUCCESS [36.875s]
[INFO] Apache CloudStack Framework - Clustering .. SUCCESS [36.092s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [14.133s]
[INFO] Apache CloudStack Cloud Engine Schema Component ... SUCCESS [2:07.689s]
[INFO] Apache CloudStack Framework - Jobs  SUCCESS [40.789s]
[INFO] Apache CloudStack Cloud Engine Internal Components API  SUCCESS [24.860s]
[INFO] Apache CloudStack Server .. SUCCESS [4:15.654s]
[INFO] Apache CloudStack Framework - Quota ... SUCCESS [37.148s]
[INFO] Apache CloudStack Usage Server  SUCCESS [43.913s]
[INFO] Apache CloudStack Cloud Engine Orchestration Component  SUCCESS 
[1:22.257s]
[INFO] Apache CloudStack Cloud Services .. SUCCESS [0.070s]
[INFO] Apache CloudStack Secondary Storage ... SUCCESS [0.472s]
[INFO] Apache CloudStack Secondary Storage Service ... SUCCESS [54.316s]
[INFO] Apache CloudStack Engine Storage Component  SUCCESS [49.752s]
[INFO] Apache CloudStack Engine Storage Volume Component . SUCCESS [29.858s]
[INFO] Apache CloudStack Engine Storage Image Component .. SUCCESS [26.384s]
[INFO] Apache CloudStack Engine Storage Data Motion Component  SUCCESS [22.380s]
[INFO] Apache CloudStack Engine Storage Cache Component .. SUCCESS [24.524s]
[INFO] Apache CloudStack Engine Storage Snapshot Component  SUCCESS [35.125s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [12.435s]
[INFO] Apache CloudStack Cloud Engine Service  SUCCESS [7.857s]
[INFO] Apache CloudStack Plugin POM .. SUCCESS [0.930s]
[INFO] Apache CloudStack Plugin - API Rate Limit . SUCCESS [27.759s]
[INFO] Apache CloudStack Plugin - Storage Volume default provider  SUCCESS 
[23.617s]
[INFO] Apache CloudStack Plugin - Storage Volume SolidFire Provider  SUCCESS 
[36.999s]
[INFO] Apache CloudStack Plugin - API SolidFire .. SUCCESS [17.185s]
[INFO] Apache CloudStack Plugin - API Discovery .. SUCCESS [23.153s]
[INFO] Apache CloudStack Plugin - ACL Static Role Based .. SUCCESS [15.854s]
[INFO] Apache CloudStack Plugin - Host Anti-Affinity Processor  SUCCESS 
[16.633s]
[INFO] Apache 

[GitHub] cloudstack pull request: CLOUDSTACK-9236: Load Balancing Health Ch...

[nitin-maharana]

Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/1338#issuecomment-173436054
  
Thanks @remibergsma. Sorry I saw your comments bit late. You have already 
figured it out. Thanks @DaanHoogland 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9211: Support passing vRAM siz...

[nvazquez]

Github user nvazquez commented on the pull request:

https://github.com/apache/cloudstack/pull/1310#issuecomment-173439752
  
Thanks for your help @cristofolini!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: build-master-slowbuild #3037

[jenkins]

See 

--
[...truncated 28713 lines...]
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud ---
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:instrument (default-cli) @ 
cloud-quickcloud ---
[WARNING] No files to instrument.
[INFO] NOT adding cobertura ser file to attached artifacts list.
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-quickcloud ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ 
cloud-quickcloud ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud ---
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Apache CloudStack Developer Tools - Checkstyle Configuration  SUCCESS 
[1.749s]
[INFO] Apache CloudStack . SUCCESS [2.080s]
[INFO] Apache CloudStack Maven Conventions Parent  SUCCESS [0.782s]
[INFO] Apache CloudStack Framework - Managed Context . SUCCESS [19.121s]
[INFO] Apache CloudStack Utils ... SUCCESS [1:28.896s]
[INFO] Apache CloudStack Framework ... SUCCESS [0.104s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [53.410s]
[INFO] Apache CloudStack Framework - Configuration ... SUCCESS [27.156s]
[INFO] Apache CloudStack API . SUCCESS [1:50.100s]
[INFO] Apache CloudStack Framework - REST  SUCCESS [16.600s]
[INFO] Apache CloudStack Framework - IPC . SUCCESS [31.044s]
[INFO] Apache CloudStack Cloud Engine  SUCCESS [0.093s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [27.972s]
[INFO] Apache CloudStack Framework - Security  SUCCESS [25.103s]
[INFO] Apache CloudStack Core  SUCCESS [1:22.530s]
[INFO] Apache CloudStack Agents .. SUCCESS [35.833s]
[INFO] Apache CloudStack Framework - Clustering .. SUCCESS [36.464s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [14.438s]
[INFO] Apache CloudStack Cloud Engine Schema Component ... SUCCESS [2:07.323s]
[INFO] Apache CloudStack Framework - Jobs  SUCCESS [40.422s]
[INFO] Apache CloudStack Cloud Engine Internal Components API  SUCCESS [25.085s]
[INFO] Apache CloudStack Server .. SUCCESS [4:14.220s]
[INFO] Apache CloudStack Framework - Quota ... SUCCESS [37.070s]
[INFO] Apache CloudStack Usage Server  SUCCESS [44.241s]
[INFO] Apache CloudStack Cloud Engine Orchestration Component  SUCCESS 
[1:21.583s]
[INFO] Apache CloudStack Cloud Services .. SUCCESS [0.068s]
[INFO] Apache CloudStack Secondary Storage ... SUCCESS [0.444s]
[INFO] Apache CloudStack Secondary Storage Service ... SUCCESS [54.201s]
[INFO] Apache CloudStack Engine Storage Component  SUCCESS [49.517s]
[INFO] Apache CloudStack Engine Storage Volume Component . SUCCESS [30.381s]
[INFO] Apache CloudStack Engine Storage Image Component .. SUCCESS [26.575s]
[INFO] Apache CloudStack Engine Storage Data Motion Component  SUCCESS [31.503s]
[INFO] Apache CloudStack Engine Storage Cache Component .. SUCCESS [20.620s]
[INFO] Apache CloudStack Engine Storage Snapshot Component  SUCCESS [35.412s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [12.095s]
[INFO] Apache CloudStack Cloud Engine Service  SUCCESS [7.645s]
[INFO] Apache CloudStack Plugin POM .. SUCCESS [0.991s]
[INFO] Apache CloudStack Plugin - API Rate Limit . SUCCESS [26.320s]
[INFO] Apache CloudStack Plugin - Storage Volume default provider  SUCCESS 
[23.326s]
[INFO] Apache CloudStack Plugin - Storage Volume SolidFire Provider  SUCCESS 
[35.485s]
[INFO] Apache CloudStack Plugin - API SolidFire .. SUCCESS [17.352s]
[INFO] Apache CloudStack Plugin - API Discovery .. SUCCESS [23.271s]
[INFO] Apache CloudStack Plugin - ACL Static Role Based .. SUCCESS [15.745s]
[INFO] Apache CloudStack Plugin - Host Anti-Affinity Processor  SUCCESS 
[16.911s]
[INFO] Apache 

[GitHub] cloudstack pull request: CLOUDSTACK-9130: Make RebootCommand simil...

[koushik-das]

Github user koushik-das commented on the pull request:

https://github.com/apache/cloudstack/pull/1200#issuecomment-173474463
  
@remibergsma RebootCoomand is used by rebootVirtualMachine API. Refer to 
test_03_reboot_vm in smoke/test_vm_life_cycle.py. It is also used in 
rebootSystemVm API. Check test_07_reboot_ssvm and test_08_reboot_cpvm in 
smoke/test_ssvm.py.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Refactor test_vpc_vpn, add test for multi...

[bheuvel]

GitHub user bheuvel opened a pull request:

https://github.com/apache/cloudstack/pull/1355

Refactor test_vpc_vpn, add test for multiple VPNs

Refactored to clear usage of setup/setupClass, teardown/teardownClass

Refactored TestVpcSite2SiteVpn to include class TestRVPCSite2SiteVpn as a 
test, thereby removing redundant code.

Added test for setting up multiple (3) Site2Site VPNs (from/on one VPC)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bheuvel/cloudstack refactor_test_vpc_vpn

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1355.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1355


commit 44e81cfe791ec8a9ae50594972c2967f9dea22c5
Author: Bob 
Date:   2016-01-20T14:46:12Z

Refactor test_vpc_vpn




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: build-master-slowbuild #3033

[jenkins]

See 

--
[...truncated 28713 lines...]
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud ---
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:instrument (default-cli) @ 
cloud-quickcloud ---
[WARNING] No files to instrument.
[INFO] NOT adding cobertura ser file to attached artifacts list.
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-quickcloud ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ 
cloud-quickcloud ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud ---
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Apache CloudStack Developer Tools - Checkstyle Configuration  SUCCESS 
[1.725s]
[INFO] Apache CloudStack . SUCCESS [2.130s]
[INFO] Apache CloudStack Maven Conventions Parent  SUCCESS [0.793s]
[INFO] Apache CloudStack Framework - Managed Context . SUCCESS [19.406s]
[INFO] Apache CloudStack Utils ... SUCCESS [1:29.440s]
[INFO] Apache CloudStack Framework ... SUCCESS [0.105s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [53.083s]
[INFO] Apache CloudStack Framework - Configuration ... SUCCESS [27.924s]
[INFO] Apache CloudStack API . SUCCESS [1:47.881s]
[INFO] Apache CloudStack Framework - REST  SUCCESS [15.938s]
[INFO] Apache CloudStack Framework - IPC . SUCCESS [29.304s]
[INFO] Apache CloudStack Cloud Engine  SUCCESS [0.089s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [27.681s]
[INFO] Apache CloudStack Framework - Security  SUCCESS [24.321s]
[INFO] Apache CloudStack Core  SUCCESS [1:21.999s]
[INFO] Apache CloudStack Agents .. SUCCESS [35.898s]
[INFO] Apache CloudStack Framework - Clustering .. SUCCESS [36.287s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [14.334s]
[INFO] Apache CloudStack Cloud Engine Schema Component ... SUCCESS [2:07.926s]
[INFO] Apache CloudStack Framework - Jobs  SUCCESS [40.408s]
[INFO] Apache CloudStack Cloud Engine Internal Components API  SUCCESS [25.343s]
[INFO] Apache CloudStack Server .. SUCCESS [4:16.043s]
[INFO] Apache CloudStack Framework - Quota ... SUCCESS [37.471s]
[INFO] Apache CloudStack Usage Server  SUCCESS [44.683s]
[INFO] Apache CloudStack Cloud Engine Orchestration Component  SUCCESS 
[1:22.543s]
[INFO] Apache CloudStack Cloud Services .. SUCCESS [0.069s]
[INFO] Apache CloudStack Secondary Storage ... SUCCESS [0.455s]
[INFO] Apache CloudStack Secondary Storage Service ... SUCCESS [54.228s]
[INFO] Apache CloudStack Engine Storage Component  SUCCESS [47.782s]
[INFO] Apache CloudStack Engine Storage Volume Component . SUCCESS [30.169s]
[INFO] Apache CloudStack Engine Storage Image Component .. SUCCESS [26.253s]
[INFO] Apache CloudStack Engine Storage Data Motion Component  SUCCESS [26.158s]
[INFO] Apache CloudStack Engine Storage Cache Component .. SUCCESS [21.252s]
[INFO] Apache CloudStack Engine Storage Snapshot Component  SUCCESS [35.044s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [12.522s]
[INFO] Apache CloudStack Cloud Engine Service  SUCCESS [8.152s]
[INFO] Apache CloudStack Plugin POM .. SUCCESS [1.009s]
[INFO] Apache CloudStack Plugin - API Rate Limit . SUCCESS [26.535s]
[INFO] Apache CloudStack Plugin - Storage Volume default provider  SUCCESS 
[24.048s]
[INFO] Apache CloudStack Plugin - Storage Volume SolidFire Provider  SUCCESS 
[36.190s]
[INFO] Apache CloudStack Plugin - API SolidFire .. SUCCESS [17.545s]
[INFO] Apache CloudStack Plugin - API Discovery .. SUCCESS [23.361s]
[INFO] Apache CloudStack Plugin - ACL Static Role Based .. SUCCESS [16.673s]
[INFO] Apache CloudStack Plugin - Host Anti-Affinity Processor  SUCCESS 
[16.528s]
[INFO] Apache 

Build failed in Jenkins: build-master-slowbuild #3032

[jenkins]

See 

Changes:

[bharat.kumar] CLOUDSTACK-8860: improve error messages in VM deployment code 
path.

[Rajani Karuturi] updating rabbitmq amqp client to 3.5.4 from 3.4.2

[Rajani Karuturi] CLOUDSTACK-8885: added blocked connection listener for 
rabbitmqeventbus

[koushik] CLOUDSTACK-9195: Cancelled/failed async jobs not getting cleaned up 
from

[nitin.maharana] CLOUDSTACK-9236: Load Balancing Health Check button displayed 
when

[Boris Schrijver] Enhance VR performance by selectively executing tasks instead 
of

[Daan Hoogland] CLOUDSTACK-9239 throw exception on deprecated command

[Remi Bergsma] CLOUDSTACK-9244 Fix setting up RFC1918 routes

[Remi Bergsma] Refactor public ip retrieval into method

--
[...truncated 28713 lines...]
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud ---
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:instrument (default-cli) @ 
cloud-quickcloud ---
[WARNING] No files to instrument.
[INFO] NOT adding cobertura ser file to attached artifacts list.
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-quickcloud ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ 
cloud-quickcloud ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud ---
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Apache CloudStack Developer Tools - Checkstyle Configuration  SUCCESS 
[1.718s]
[INFO] Apache CloudStack . SUCCESS [2.059s]
[INFO] Apache CloudStack Maven Conventions Parent  SUCCESS [0.806s]
[INFO] Apache CloudStack Framework - Managed Context . SUCCESS [19.085s]
[INFO] Apache CloudStack Utils ... SUCCESS [1:30.972s]
[INFO] Apache CloudStack Framework ... SUCCESS [0.113s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [54.590s]
[INFO] Apache CloudStack Framework - Configuration ... SUCCESS [27.554s]
[INFO] Apache CloudStack API . SUCCESS [1:49.164s]
[INFO] Apache CloudStack Framework - REST  SUCCESS [17.692s]
[INFO] Apache CloudStack Framework - IPC . SUCCESS [29.938s]
[INFO] Apache CloudStack Cloud Engine  SUCCESS [0.092s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [27.313s]
[INFO] Apache CloudStack Framework - Security  SUCCESS [25.718s]
[INFO] Apache CloudStack Core  SUCCESS [1:21.892s]
[INFO] Apache CloudStack Agents .. SUCCESS [37.386s]
[INFO] Apache CloudStack Framework - Clustering .. SUCCESS [36.420s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [14.781s]
[INFO] Apache CloudStack Cloud Engine Schema Component ... SUCCESS [2:06.502s]
[INFO] Apache CloudStack Framework - Jobs  SUCCESS [41.333s]
[INFO] Apache CloudStack Cloud Engine Internal Components API  SUCCESS [25.139s]
[INFO] Apache CloudStack Server .. SUCCESS [4:17.692s]
[INFO] Apache CloudStack Framework - Quota ... SUCCESS [37.053s]
[INFO] Apache CloudStack Usage Server  SUCCESS [45.085s]
[INFO] Apache CloudStack Cloud Engine Orchestration Component  SUCCESS 
[1:21.899s]
[INFO] Apache CloudStack Cloud Services .. SUCCESS [0.070s]
[INFO] Apache CloudStack Secondary Storage ... SUCCESS [0.433s]
[INFO] Apache CloudStack Secondary Storage Service ... SUCCESS [54.830s]
[INFO] Apache CloudStack Engine Storage Component  SUCCESS [48.653s]
[INFO] Apache CloudStack Engine Storage Volume Component . SUCCESS [29.593s]
[INFO] Apache CloudStack Engine Storage Image Component .. SUCCESS [25.914s]
[INFO] Apache CloudStack Engine Storage Data Motion Component  SUCCESS [30.878s]
[INFO] Apache CloudStack Engine Storage Cache Component .. SUCCESS [22.351s]
[INFO] Apache CloudStack Engine Storage Snapshot Component  SUCCESS [35.195s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [13.195s]
[INFO] Apache CloudStack 

[GitHub] cloudstack pull request: CLOUDSTACK-9142 Migrate VM changes xmlDes...

[rafaelweingartner]

Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/1348#issuecomment-173358933
  
Hi @DaanHoogland,

I would only suggest you extracting those magic numbers at line 97 to 
constant variables (using some descriptive names).

I also have a doubt, 
Are we using that “@author” directive? Such as the one you have at line 
26 of “LibvirtMigrateCommandWrapperTest”

BTW: I really liked the “replaceIpForVNCInDescFile” method. Very nice 
and descriptive method name, comprehensive java doc, test cases and the method 
itself is not complicated. I believe that should be our code quality goal. 
Congratulations !


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9142 Migrate VM changes xmlDes...

[bhaisaab]

Github user bhaisaab commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1348#discussion_r50319348
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtMigrateCommandWrapper.java
 ---
@@ -190,4 +196,28 @@ Use VIR_DOMAIN_XML_SECURE (value = 1) prior to v1.0.0.
 
 return new MigrateAnswer(command, result == null, result, null);
 }
-}
\ No newline at end of file
+
+/**
+ * This function assumes an qemu machine desription containing a 
single graphics element like
--- End diff --

What is there are multiple graphics element? Can we ever hit a case where 
there may be more than one  element?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9235: Autoscale button is miss...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1337


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9211: Support passing vRAM siz...

[cristofolini]

Github user cristofolini commented on the pull request:

https://github.com/apache/cloudstack/pull/1310#issuecomment-173364669
  
Thanks again, @nvazquez. The unit test you wrote is a nice improvement and 
I'm fine with it. :)
Code LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9229: Autoscale policy creatio...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1334#issuecomment-173364778
  
LGTM :+1: 

Based on code review and screenshot from remi


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9211: Support passing vRAM siz...

[nvazquez]

Github user nvazquez commented on the pull request:

https://github.com/apache/cloudstack/pull/1310#issuecomment-173350754
  
Thanks @cristofolini 
I've tryied writing a marvin test for testing this feature which would be:
* Select (or create) a vm (id=) which is already running and stop it.
* For vm with id= do the following:

INSERT INTO cloud.user_vm_details (vm_id, name, value) VALUES 
('', 'mks.enable3d', 'true');
INSERT INTO cloud.user_vm_details (vm_id, name, value) VALUES 
('', 'mks.use3dRenderer', 'automatic');
INSERT INTO cloud.user_vm_details (vm_id, name, value) VALUES 
('', 'svga.autodetect', 'false');
INSERT INTO cloud.user_vm_details (vm_id, name, value) VALUES 
('', 'svga.vramSize', '');


Where  is the ram size in KB
* Start vm  again

In previous behaviour, it all worked except vram size, which was always set 
to 64MB, ignoring size  provided. With this fix, vram size is 
set to  when provided.


I couldn't be able to write a marvin test which follows these steps, 
however I wrote a unit test for this new method, which is only accessed through 
execute(StartCommand) method.

Nicolas


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9237: Create LB Healthcheck is...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1340#issuecomment-173357915
  
LGTM, wasn't able to check it with a Netscaler setup. Looks good and syntax 
of js is OK.
https://cloud.githubusercontent.com/assets/1630096/12462979/7f44d4c2-bfc1-11e5-8857-f0fd8f8fa133.png;>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9237: Create LB Healthcheck is...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1340


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9142 Migrate VM changes xmlDes...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1348#issuecomment-173360077
  
Except for the concern that there may be multiple graphics element where 
the method would clearly fail, LGTM. Please also squash your commits.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: build-master-slowbuild #3034

[jenkins]

See 

--
[...truncated 28713 lines...]
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud ---
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:instrument (default-cli) @ 
cloud-quickcloud ---
[WARNING] No files to instrument.
[INFO] NOT adding cobertura ser file to attached artifacts list.
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-quickcloud ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ 
cloud-quickcloud ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud ---
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Apache CloudStack Developer Tools - Checkstyle Configuration  SUCCESS 
[1.770s]
[INFO] Apache CloudStack . SUCCESS [2.078s]
[INFO] Apache CloudStack Maven Conventions Parent  SUCCESS [0.933s]
[INFO] Apache CloudStack Framework - Managed Context . SUCCESS [19.542s]
[INFO] Apache CloudStack Utils ... SUCCESS [1:30.367s]
[INFO] Apache CloudStack Framework ... SUCCESS [0.104s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [53.312s]
[INFO] Apache CloudStack Framework - Configuration ... SUCCESS [27.756s]
[INFO] Apache CloudStack API . SUCCESS [1:49.902s]
[INFO] Apache CloudStack Framework - REST  SUCCESS [16.062s]
[INFO] Apache CloudStack Framework - IPC . SUCCESS [29.564s]
[INFO] Apache CloudStack Cloud Engine  SUCCESS [0.082s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [28.391s]
[INFO] Apache CloudStack Framework - Security  SUCCESS [24.321s]
[INFO] Apache CloudStack Core  SUCCESS [1:20.394s]
[INFO] Apache CloudStack Agents .. SUCCESS [36.440s]
[INFO] Apache CloudStack Framework - Clustering .. SUCCESS [36.829s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [14.118s]
[INFO] Apache CloudStack Cloud Engine Schema Component ... SUCCESS [2:08.034s]
[INFO] Apache CloudStack Framework - Jobs  SUCCESS [40.144s]
[INFO] Apache CloudStack Cloud Engine Internal Components API  SUCCESS [25.316s]
[INFO] Apache CloudStack Server .. SUCCESS [4:11.540s]
[INFO] Apache CloudStack Framework - Quota ... SUCCESS [36.529s]
[INFO] Apache CloudStack Usage Server  SUCCESS [43.584s]
[INFO] Apache CloudStack Cloud Engine Orchestration Component  SUCCESS 
[1:21.533s]
[INFO] Apache CloudStack Cloud Services .. SUCCESS [0.070s]
[INFO] Apache CloudStack Secondary Storage ... SUCCESS [0.447s]
[INFO] Apache CloudStack Secondary Storage Service ... SUCCESS [54.244s]
[INFO] Apache CloudStack Engine Storage Component  SUCCESS [50.401s]
[INFO] Apache CloudStack Engine Storage Volume Component . SUCCESS [30.475s]
[INFO] Apache CloudStack Engine Storage Image Component .. SUCCESS [26.216s]
[INFO] Apache CloudStack Engine Storage Data Motion Component  SUCCESS [31.062s]
[INFO] Apache CloudStack Engine Storage Cache Component .. SUCCESS [23.433s]
[INFO] Apache CloudStack Engine Storage Snapshot Component  SUCCESS [34.890s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [12.862s]
[INFO] Apache CloudStack Cloud Engine Service  SUCCESS [7.987s]
[INFO] Apache CloudStack Plugin POM .. SUCCESS [0.966s]
[INFO] Apache CloudStack Plugin - API Rate Limit . SUCCESS [26.331s]
[INFO] Apache CloudStack Plugin - Storage Volume default provider  SUCCESS 
[23.597s]
[INFO] Apache CloudStack Plugin - Storage Volume SolidFire Provider  SUCCESS 
[37.292s]
[INFO] Apache CloudStack Plugin - API SolidFire .. SUCCESS [17.545s]
[INFO] Apache CloudStack Plugin - API Discovery .. SUCCESS [23.357s]
[INFO] Apache CloudStack Plugin - ACL Static Role Based .. SUCCESS [16.186s]
[INFO] Apache CloudStack Plugin - Host Anti-Affinity Processor  SUCCESS 
[17.175s]
[INFO] Apache 

[GitHub] cloudstack pull request: CLOUDSTACK-9229: Autoscale policy creatio...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1334


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9142 Migrate VM changes xmlDes...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1348#issuecomment-173364862
  
@DaanHoogland This test is failing:

```
Test migrate VM ... === TestName: test_08_migrate_vm | Status : EXCEPTION 
===
ERROR
```

Details:
```
==
ERROR: Test migrate VM
--
Traceback (most recent call last):
  File 
"/data/git/cs1/cloudstack/test/integration/smoke/test_vm_life_cycle.py", line 
594, in test_08_migrate_vm
self.vm_to_migrate.migrate(self.apiclient, migrate_host.id)
  File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 653, in 
migrate
apiclient.migrateVirtualMachine(cmd)
  File 
"/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", 
line 772, in migrateVirtualMachine
response = self.connection.marvinRequest(command, 
response_type=response, method=method)
  File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", 
line 379, in marvinRequest
raise e
Exception: Job failed: {jobprocstatus : 0, created : 
u'2016-01-20T21:19:08+', cmd : 
u'org.apache.cloudstack.api.command.admin.vm.MigrateVMCmd', userid : 
u'95279fda-bed0-11e5-90a2-5254001daa61', jobstatus : 2, jobid : 
u'e7a1bb0f-39a5-4868-97c9-8fda5f8a8aa1', jobresultcode : 530, jobresulttype : 
u'object', jobresult : {errorcode : 530, errortext : 
u"org.libvirt.LibvirtException: internal error: process exited while connecting 
to monitor: 2016-01-20T21:19:09.852246Z qemu-kvm: Failed to start VNC server on 
`192.168.22.22:0,password': Failed to bind socket: Cannot assign requested 
address\n"}, accountid : u'95278d2a-bed0-11e5-90a2-5254001daa61'}
```

Tried the test again and it failed again. Can you investigate please?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9142 Migrate VM changes xmlDes...

[wido]

Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/1348#issuecomment-173357364
  
Looking at this test I see the problem indeed. I actually created this 
regression while fixing it.

One thing though, you mean that the IP of the NFS server is part of the XML 
desc, can you show me an example? I can't think of a way though.

The code seems good to me, but running a integration test on this is indeed 
hard to do.

This would btw also apply for a Ceph cluster. If a Ceph monitor has a IP 
which 'matches' that of the host the same situation could arrise.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9142 Migrate VM changes xmlDes...

[borisroman]

Github user borisroman commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1348#discussion_r50335474
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtMigrateCommandWrapper.java
 ---
@@ -190,4 +196,28 @@ Use VIR_DOMAIN_XML_SECURE (value = 1) prior to v1.0.0.
 
 return new MigrateAnswer(command, result == null, result, null);
 }
-}
\ No newline at end of file
+
+/**
+ * This function assumes an qemu machine desription containing a 
single graphics element like
+ * 
+ *   
+ * 
+ * @param xmlDesc the qemu xml description
+ * @param source the ip address to migrate from
--- End diff --

not used?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9142 Migrate VM changes xmlDes...

[DaanHoogland]

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1348#discussion_r50336727
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtMigrateCommandWrapper.java
 ---
@@ -190,4 +196,28 @@ Use VIR_DOMAIN_XML_SECURE (value = 1) prior to v1.0.0.
 
 return new MigrateAnswer(command, result == null, result, null);
 }
-}
\ No newline at end of file
+
+/**
+ * This function assumes an qemu machine desription containing a 
single graphics element like
+ * 
+ *   
+ * 
+ * @param xmlDesc the qemu xml description
+ * @param source the ip address to migrate from
--- End diff --

no, will remove. tnx. it was used in the initial version.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9142 Migrate VM changes xmlDes...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1348#issuecomment-173392186
  
@remibergsma that is serious. migration is failing for us with the tested 
code and the test is failing with the fix. I have work to do it seems. :) Can 
you send me the full log for comparison, please.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[VOTE] Apache CloudStack 4.8.0

[Remi Bergsma]

Hi all,

I've created a 4.8.0 release candidate, with the following artifacts up for a 
vote:

Git Branch and Commit SH:
https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=4.8.0-RC20160120T2343

Commit: 62f218b7bd005d201d1c8516180d8e6d6797

Source release (checksums and signatures are available at the same location):
https://dist.apache.org/repos/dist/dev/cloudstack/4.8.0/

PGP release keys (signed using A47DDC4F):
https://dist.apache.org/repos/dist/release/cloudstack/KEYS

Vote will be open for at least 72 hours.

For sanity in tallying the vote, can PMC members please be sure to indicate 
"(binding)" with their vote?

[ ] +1  approve
[ ] +0  no opinion
[ ] -1  disapprove (and reason why)

[GitHub] cloudstack pull request: CLOUDSTACK-9142 Migrate VM changes xmlDes...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1348#issuecomment-173398341
  
@rafaelweingartner I have no idea about 'those magic numbers' I didn't 
touch them.
I can remove the @author. it was auto generated.
thanks for the compliment, though I myself think the javadoc could have 
been even more terse.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9142 Migrate VM changes xmlDes...

[DaanHoogland]

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1348#discussion_r50333689
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtMigrateCommandWrapper.java
 ---
@@ -1,4 +1,5 @@
 //
+
--- End diff --

doesn't seem intentional, will have a look


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[VOTE] Apache CloudStack 4.7.1

[Remi Bergsma]

Hi all,

I've created a 4.7.1 release candidate, with the following artifacts up for a 
vote:

Git Branch and Commit SH:
https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=4.7.1-RC20160120T2318

Commit: 5ea07dc93799f28dd6c268b17514867d92dc53f7

Source release (checksums and signatures are available at the same location):
https://dist.apache.org/repos/dist/dev/cloudstack/4.7.1/

PGP release keys (signed using A47DDC4F):
https://dist.apache.org/repos/dist/release/cloudstack/KEYS

Vote will be open for at least 72 hours.

For sanity in tallying the vote, can PMC members please be sure to indicate 
"(binding)" with their vote?

[ ] +1  approve
[ ] +0  no opinion
[ ] -1  disapprove (and reason why)

[GitHub] cloudstack pull request: CLOUDSTACK-9142 Migrate VM changes xmlDes...

[DaanHoogland]

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1348#discussion_r50333804
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtMigrateCommandWrapper.java
 ---
@@ -48,6 +49,9 @@
 @ResourceWrapper(handles =  MigrateCommand.class)
 public final class LibvirtMigrateCommandWrapper extends 
CommandWrapper {
 
+private static final String CONTENTS_WILDCARD = ".*";
+private static final String GRAPHICS_ELEM_END = "/graphics>";
--- End diff --

why would that be needed, the match is conclusive enough without it. Adding 
it would be purely cosmetic, wouldn't it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9142 Migrate VM changes xmlDes...

[DaanHoogland]

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1348#discussion_r50334011
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtMigrateCommandWrapper.java
 ---
@@ -190,4 +196,28 @@ Use VIR_DOMAIN_XML_SECURE (value = 1) prior to v1.0.0.
 
 return new MigrateAnswer(command, result == null, result, null);
 }
-}
\ No newline at end of file
+
+/**
+ * This function assumes an qemu machine desription containing a 
single graphics element like
--- End diff --

@bhaisaab not in a cloudstack generated desc file. But you are right 
inprinciple it could exist.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9142 Migrate VM changes xmlDes...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1348#issuecomment-173389882
  
@wido the problem we encountered in our env is not with NFS servers but 
with RBD. sorry for the misdirection.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9142 Migrate VM changes xmlDes...

[borisroman]

Github user borisroman commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1348#discussion_r50325672
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtMigrateCommandWrapper.java
 ---
@@ -48,6 +49,9 @@
 @ResourceWrapper(handles =  MigrateCommand.class)
 public final class LibvirtMigrateCommandWrapper extends 
CommandWrapper {
 
+private static final String CONTENTS_WILDCARD = ".*";
+private static final String GRAPHICS_ELEM_END = "/graphics>";
--- End diff --

This doesn't look correct... ?

"<" missing?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9142 Migrate VM changes xmlDes...

[borisroman]

Github user borisroman commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1348#discussion_r50325617
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtMigrateCommandWrapper.java
 ---
@@ -1,4 +1,5 @@
 //
+
--- End diff --

Why?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: build-master-slowbuild #3035

[jenkins]

See 

Changes:

[nitin.maharana] CLOUDSTACK-9229: Autoscale policy creation failing in VPC due 
to zoneid

[nitin.maharana] CLOUDSTACK-9235: Autoscale button is missing in VPC

[nitin.maharana] CLOUDSTACK-9237: Create LB Healthcheck issues - button 
alignment and

--
[...truncated 28723 lines...]
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud ---
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:instrument (default-cli) @ 
cloud-quickcloud ---
[WARNING] No files to instrument.
[INFO] NOT adding cobertura ser file to attached artifacts list.
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-quickcloud ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ 
cloud-quickcloud ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud ---
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Apache CloudStack Developer Tools - Checkstyle Configuration  SUCCESS 
[1.738s]
[INFO] Apache CloudStack . SUCCESS [2.121s]
[INFO] Apache CloudStack Maven Conventions Parent  SUCCESS [0.784s]
[INFO] Apache CloudStack Framework - Managed Context . SUCCESS [18.730s]
[INFO] Apache CloudStack Utils ... SUCCESS [1:30.968s]
[INFO] Apache CloudStack Framework ... SUCCESS [0.103s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [52.528s]
[INFO] Apache CloudStack Framework - Configuration ... SUCCESS [27.703s]
[INFO] Apache CloudStack API . SUCCESS [1:49.158s]
[INFO] Apache CloudStack Framework - REST  SUCCESS [16.151s]
[INFO] Apache CloudStack Framework - IPC . SUCCESS [29.730s]
[INFO] Apache CloudStack Cloud Engine  SUCCESS [0.086s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [28.411s]
[INFO] Apache CloudStack Framework - Security  SUCCESS [24.935s]
[INFO] Apache CloudStack Core  SUCCESS [1:21.230s]
[INFO] Apache CloudStack Agents .. SUCCESS [36.580s]
[INFO] Apache CloudStack Framework - Clustering .. SUCCESS [36.155s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [14.163s]
[INFO] Apache CloudStack Cloud Engine Schema Component ... SUCCESS [2:08.198s]
[INFO] Apache CloudStack Framework - Jobs  SUCCESS [40.817s]
[INFO] Apache CloudStack Cloud Engine Internal Components API  SUCCESS [25.379s]
[INFO] Apache CloudStack Server .. SUCCESS [4:15.186s]
[INFO] Apache CloudStack Framework - Quota ... SUCCESS [37.511s]
[INFO] Apache CloudStack Usage Server  SUCCESS [44.596s]
[INFO] Apache CloudStack Cloud Engine Orchestration Component  SUCCESS 
[1:21.992s]
[INFO] Apache CloudStack Cloud Services .. SUCCESS [0.092s]
[INFO] Apache CloudStack Secondary Storage ... SUCCESS [0.456s]
[INFO] Apache CloudStack Secondary Storage Service ... SUCCESS [53.619s]
[INFO] Apache CloudStack Engine Storage Component  SUCCESS [47.670s]
[INFO] Apache CloudStack Engine Storage Volume Component . SUCCESS [29.693s]
[INFO] Apache CloudStack Engine Storage Image Component .. SUCCESS [26.556s]
[INFO] Apache CloudStack Engine Storage Data Motion Component  SUCCESS [25.885s]
[INFO] Apache CloudStack Engine Storage Cache Component .. SUCCESS [20.787s]
[INFO] Apache CloudStack Engine Storage Snapshot Component  SUCCESS [35.078s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [12.424s]
[INFO] Apache CloudStack Cloud Engine Service  SUCCESS [8.386s]
[INFO] Apache CloudStack Plugin POM .. SUCCESS [0.958s]
[INFO] Apache CloudStack Plugin - API Rate Limit . SUCCESS [26.656s]
[INFO] Apache CloudStack Plugin - Storage Volume default provider  SUCCESS 
[23.969s]
[INFO] Apache CloudStack Plugin - Storage Volume SolidFire Provider  SUCCESS 
[37.592s]
[INFO] Apache CloudStack Plugin - API SolidFire .. SUCCESS 

Build failed in Jenkins: build-master-slowbuild #3030

[jenkins]

See 

--
[...truncated 28713 lines...]
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud ---
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:instrument (default-cli) @ 
cloud-quickcloud ---
[WARNING] No files to instrument.
[INFO] NOT adding cobertura ser file to attached artifacts list.
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-quickcloud ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ 
cloud-quickcloud ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud ---
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Apache CloudStack Developer Tools - Checkstyle Configuration  SUCCESS 
[1.796s]
[INFO] Apache CloudStack . SUCCESS [2.201s]
[INFO] Apache CloudStack Maven Conventions Parent  SUCCESS [0.781s]
[INFO] Apache CloudStack Framework - Managed Context . SUCCESS [20.879s]
[INFO] Apache CloudStack Utils ... SUCCESS [1:29.072s]
[INFO] Apache CloudStack Framework ... SUCCESS [0.106s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [53.769s]
[INFO] Apache CloudStack Framework - Configuration ... SUCCESS [27.370s]
[INFO] Apache CloudStack API . SUCCESS [1:48.619s]
[INFO] Apache CloudStack Framework - REST  SUCCESS [16.696s]
[INFO] Apache CloudStack Framework - IPC . SUCCESS [30.193s]
[INFO] Apache CloudStack Cloud Engine  SUCCESS [0.108s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [27.820s]
[INFO] Apache CloudStack Framework - Security  SUCCESS [25.541s]
[INFO] Apache CloudStack Core  SUCCESS [1:21.155s]
[INFO] Apache CloudStack Agents .. SUCCESS [35.884s]
[INFO] Apache CloudStack Framework - Clustering .. SUCCESS [37.103s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [14.428s]
[INFO] Apache CloudStack Cloud Engine Schema Component ... SUCCESS [2:07.941s]
[INFO] Apache CloudStack Framework - Jobs  SUCCESS [40.677s]
[INFO] Apache CloudStack Cloud Engine Internal Components API  SUCCESS [25.327s]
[INFO] Apache CloudStack Server .. SUCCESS [4:13.178s]
[INFO] Apache CloudStack Framework - Quota ... SUCCESS [37.559s]
[INFO] Apache CloudStack Usage Server  SUCCESS [44.488s]
[INFO] Apache CloudStack Cloud Engine Orchestration Component  SUCCESS 
[1:22.386s]
[INFO] Apache CloudStack Cloud Services .. SUCCESS [0.074s]
[INFO] Apache CloudStack Secondary Storage ... SUCCESS [0.454s]
[INFO] Apache CloudStack Secondary Storage Service ... SUCCESS [52.873s]
[INFO] Apache CloudStack Engine Storage Component  SUCCESS [48.894s]
[INFO] Apache CloudStack Engine Storage Volume Component . SUCCESS [30.429s]
[INFO] Apache CloudStack Engine Storage Image Component .. SUCCESS [26.217s]
[INFO] Apache CloudStack Engine Storage Data Motion Component  SUCCESS [31.191s]
[INFO] Apache CloudStack Engine Storage Cache Component .. SUCCESS [21.662s]
[INFO] Apache CloudStack Engine Storage Snapshot Component  SUCCESS [35.218s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [12.686s]
[INFO] Apache CloudStack Cloud Engine Service  SUCCESS [7.586s]
[INFO] Apache CloudStack Plugin POM .. SUCCESS [0.955s]
[INFO] Apache CloudStack Plugin - API Rate Limit . SUCCESS [27.351s]
[INFO] Apache CloudStack Plugin - Storage Volume default provider  SUCCESS 
[24.014s]
[INFO] Apache CloudStack Plugin - Storage Volume SolidFire Provider  SUCCESS 
[36.343s]
[INFO] Apache CloudStack Plugin - API SolidFire .. SUCCESS [17.811s]
[INFO] Apache CloudStack Plugin - API Discovery .. SUCCESS [23.687s]
[INFO] Apache CloudStack Plugin - ACL Static Role Based .. SUCCESS [15.939s]
[INFO] Apache CloudStack Plugin - Host Anti-Affinity Processor  SUCCESS 
[16.960s]
[INFO] Apache 

Re: Help with JUnits

[B Prakash]

Ok.  I have extended rootdiskresize functionality for xenserver.  It was an 
existing KVM implementation and I extended it to include xenserver.  I was also 
hoping to reuse its junits but couldnt find.

Please let me know if you are aware of any means of finding junits for 
UserVmManagerImpl.commitUserVm.  If I am unable to trace this, I will write 
junits for this afresh.

From: Mike Tutkowski 
Sent: Wednesday, January 20, 2016 12:38 AM
To: dev@cloudstack.apache.org
Subject: Re: Help with JUnits

I'm not sure what CloudStack's test-coverage numbers look like (for either
unit or integration), but I suspect we are quite well below 100% coverage.

On Tue, Jan 19, 2016 at 10:34 PM, B Prakash  wrote:

> Yes it does, thanks.  Next I am going through the code to identify a
> pattern (like class name ending with TEST :-)) to identify junit code.   I
> am unable to zero in on few of the operations ie I am unable to find unit
> test for this operation UserVmManagerImpl.commitUserVm.   I am still
> looking for it.  Is the Junit coverage 100%?
>
> 
> From: Mike Tutkowski 
> Sent: Tuesday, January 19, 2016 3:01 AM
> To: dev@cloudstack.apache.org
> Subject: Re: Help with JUnits
>
> So, yeah, unit tests are written in Java while integration tests are
> written in Python using Marvin...if that helps clarify things a bit more.
>
> On Tue, Jan 19, 2016 at 12:45 AM, B Prakash  wrote:
>
> > Thanks Mike, I read through the link and also saw the video, this answers
> > part of my question about executing the unit tests.  The other part of
> the
> > questions still remains ie were are junits written in Java for this class
> > and operation UserVmManagerImpl.commitUserVm.
> >
> > How do we check the junit coverage for a particular class and
> > implementation in it?  Where do I start looking for them and confirm if
> > they exist?
> >
> > 
> > From: Mike Tutkowski 
> > Sent: Monday, January 18, 2016 11:51 PM
> > To: dev@cloudstack.apache.org
> > Subject: Re: Help with JUnits
> >
> > Here's a video of a presentation I gave about Marvin (from CloudStack
> Days
> > in Austin last year):
> >
> > https://www.youtube.com/watch?v=N_eKBA_TeOs
> >
> > On Mon, Jan 18, 2016 at 9:49 PM, Mike Tutkowski <
> > mike.tutkow...@solidfire.com> wrote:
> >
> > > Does this help?
> > >
> > >
> > >
> >
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Marvin+-+Testing+with+Python
> > >
> > > On Mon, Jan 18, 2016 at 8:56 PM, B Prakash  wrote:
> > >
> > >> Hi,
> > >>
> > >>
> > >> Please can someone help me with identifying and amending junits
> for
> > >> UserVmManagerImpl.commitUserVm?  I see a test class called
> > >> UserVmManagerTest but I dont see a good junits coverage here.  Also
> > link in
> > >> the 'Developer > Testing > Unit testing with JUnit and Spring' doesnt
> > give
> > >> out lot of details on junits.
> > >>
> > >>   1.  Am I looking at the right place for junits for the class
> > >> UserVmManagerImpl.commitUserVm?
> > >>   2.  Is there any other link that provides more details on JUnits?
> > >>   3.  Any document or resource explaing cloudstack JUnit
> implementation
> > >> in greater detail would be of great help.
> > >>   4.  If I want to track junit of this class, how do I track and
> execute
> > >> them?
> > >>
> > >>
> > >> Regards,
> > >>
> > >> Prakash
> > >>
> > >
> > >
> > >
> > > --
> > > *Mike Tutkowski*
> > > *Senior CloudStack Developer, SolidFire Inc.*
> > > e: mike.tutkow...@solidfire.com
> > > o: 303.746.7302
> > > Advancing the way the world uses the cloud
> > > *™*
> > >
> >
> >
> >
> > --
> > *Mike Tutkowski*
> > *Senior CloudStack Developer, SolidFire Inc.*
> > e: mike.tutkow...@solidfire.com
> > o: 303.746.7302
> > Advancing the way the world uses the cloud
> > *™*
> >
>
>
>
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkow...@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the cloud
> *™*
>



--
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
*™*

Re: [PROPOSAL] LTS Release Cycle

[Daan Hoogland]

John, I really don't see any reason to allow backporting. We refuse new
features in LTS and with that have no excuse to backport anything any more.
Can you give an example to prove me wrong?

On Tue, Jan 19, 2016 at 10:01 PM, Paul Angus 
wrote:

> Hi Ilya (and all others),
>
> We (ShapeBlue) agree with you regarding the importance of automated
> integration testing. The consulting team are currently working to
> understand Marvin fully and what pieces we need to be able deploy properly
> representative (virtualised) infrastructures to test against. We intend to
> open source our resultant framework, with a view to community members being
> able to use it themselves in their own labs but also so that as a community
> we can build it out somewhere to be used as part of the projects' testing
> regime.
>
> We'll be reaching out to the community soon to work on the failures we're
> seeing currently and understand where they come from - ie Marvin build, the
> environment, the tests or CloudStack (watch out Mike T - I'm about to watch
> your presentation video).
>
> We see this an important initiative for CloudStack as a whole, agile or
> otherwise. But ultimately this is 'only' regression testing and the
> organisations which need/want LTS, require it for a number of reasons,
> including the fact new features bring new bugs which, if we knew we had to
> test for, probably wouldn't have been there in the first place.
>
>
>
> Paul Angus
> VP Technology   ,   ShapeBlue
>
>
> t:  @cloudyangus
>
> e:  paul.an...@shapeblue.com
> |  w:  www.shapeblue.com
>
>
>
>
>
> -Original Message-
> From: ilya [mailto:ilya.mailing.li...@gmail.com]
> Sent: Tuesday, January 19, 2016 6:39 PM
> To: dev@cloudstack.apache.org
> Subject: Re: [PROPOSAL] LTS Release Cycle
>
> > Therefore, the process should strive to make as a few releases as
> necessary to achieve this goal.
>
> I guess part two to this question would be - we need the automated testing
> environments. This can ensure rapid release testing and acutal release, and
> we dont have to restrains ourselves to limited number of releases LTS
> release due to QA pains.
>
> We need a separate initiative with CloudStack testing framework.
>
> On 1/18/16 6:54 PM, John Burwell wrote:
> > Ilya,
> >
> > Unless we have a bug fix that addresses a significant, widespread system
> stability problem or a high priority/impact security issue, an LTS will
> roll up a number of fixes. Each release would receive the full system test
> to verify that the patch set does not introduce regression defects. I
> believe that most LTS users want a few releases as necessary to keep their
> systems up-to-date and stable because each upgrade carries operational risk
> and downtime. Therefore, the process should strive to make as a few
> releases as necessary to achieve this goal.
> >
> > Thanks,
> > -John
> >
> >> On Jan 15, 2016, at 3:22 PM, ilya  wrote:
> >>
> >> John
> >>
> >> Thank you for taking time writing out the LTS proposal.
> >>
> >>> Broad community support is vital to guarantee the twenty (20) month
> >>> support period for each LTS branch. Given the ebbs and flows of
> >>> contribution and committer priorities, ShapeBlue will provide a
> >>> release manager, as well as, engineering support to fill any
> >>> contribution gaps to ensure that the community fulfills LTS
> commitments.
> >>
> >> You guys rock!!
> >>
> >> I'm +1 on this,
> >>
> >> Can you please expand on the QA side of LTS. Since this is more
> >> around long term bug/security fix - i'd think - the testing will be
> >> minimal, to the scope that fix applies - which will speed up the
> >> release process in general. What are your thoughts on this?
> >>
> >>
> >> Thanks
> >> ilya
> >>
> >>
> >>
> >>
> >>
> >> On 1/15/16 10:48 AM, John Burwell wrote:
> >>> Motivation
> >>> 
> >>>
> >>> The current monthly release cycle addresses the needs of users
> >>> focused on deploying new functionality as quickly as possible. It
> >>> does not address the needs of users oriented towards stability
> >>> rather than new functionality. These users typically employ QA
> >>> processes to comply with corporate policy and/or regulatory
> >>> requirements. To maintain a growing, thriving community, we must
> address the needs of both user types.
> >>> Therefore, I propose that we overlay a LTS release cycle onto the
> >>> monthly release cycle to address the needs of stability-oriented
> >>> users with minimal to no impact on the monthly release cycle. This
> >>> proposed LTS release cycle has the following goals:
> >>>
> >>> * Prefer Stability to New Functionality: Deliver releases that only
> >>> address defects and CVEs. This narrowly focused change scope greatly
> >>> reduces the upgrade risk/operational impact and shorter internal QA
> cycles.
> >>> * Reliable Release Lifetimes: 

[GitHub] cloudstack pull request: CLOUDSTACK-9244 Fix setting up RFC1918 ro...

[nislim]

Github user nislim commented on the pull request:

https://github.com/apache/cloudstack/pull/1352#issuecomment-173123805
  
Same result with the refactored code:
```
root@v-23-VM:~# route -n
Kernel IP routing table
Destination Gateway Genmask Flags Metric RefUse 
Iface
0.0.0.0 10.0.12.254 0.0.0.0 UG0  00 eth2
10.0.10.0   0.0.0.0 255.255.255.0   U 0  00 eth1
10.0.12.0   0.0.0.0 255.255.255.0   U 0  00 eth2
169.254.0.0 0.0.0.0 255.255.0.0 U 0  00 eth0
```
Code looks good to me



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9244 Fix setting up RFC1918 ro...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1352


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [PROPOSAL] LTS Release Cycle

[Remi Bergsma]

Hi Paul,

I just hope you won’t reinvent the wheel ;-) Feel free to use what was build to 
test the 500+ PRs that got merged over the last couple of months to build 4.6, 
4.7 and 4.8. For results see the comments in all these PRs.



More info:
https://github.com/schubergphilis/MCT-shared

This is already being used by PCExtreme, Leaseweb and Schuberg Philis.

Regards,
Remi


On 19/01/16 22:01, "Paul Angus"  wrote:

>Hi Ilya (and all others),
>
>We (ShapeBlue) agree with you regarding the importance of automated 
>integration testing. The consulting team are currently working to understand 
>Marvin fully and what pieces we need to be able deploy properly representative 
>(virtualised) infrastructures to test against. We intend to open source our 
>resultant framework, with a view to community members being able to use it 
>themselves in their own labs but also so that as a community we can build it 
>out somewhere to be used as part of the projects' testing regime.
>
>We'll be reaching out to the community soon to work on the failures we're 
>seeing currently and understand where they come from - ie Marvin build, the 
>environment, the tests or CloudStack (watch out Mike T - I'm about to watch 
>your presentation video).
>
>We see this an important initiative for CloudStack as a whole, agile or 
>otherwise. But ultimately this is 'only' regression testing and the 
>organisations which need/want LTS, require it for a number of reasons, 
>including the fact new features bring new bugs which, if we knew we had to 
>test for, probably wouldn't have been there in the first place.
>
>
>
>Paul Angus
>VP Technology   ,   ShapeBlue
>
>
>t:  @cloudyangus
>
>e:  paul.an...@shapeblue.com| 
> w:  www.shapeblue.com
>
>
>
>
>
>-Original Message-
>From: ilya [mailto:ilya.mailing.li...@gmail.com]
>Sent: Tuesday, January 19, 2016 6:39 PM
>To: dev@cloudstack.apache.org
>Subject: Re: [PROPOSAL] LTS Release Cycle
>
>> Therefore, the process should strive to make as a few releases as
>necessary to achieve this goal.
>
>I guess part two to this question would be - we need the automated testing 
>environments. This can ensure rapid release testing and acutal release, and we 
>dont have to restrains ourselves to limited number of releases LTS release due 
>to QA pains.
>
>We need a separate initiative with CloudStack testing framework.
>
>On 1/18/16 6:54 PM, John Burwell wrote:
>> Ilya,
>>
>> Unless we have a bug fix that addresses a significant, widespread system 
>> stability problem or a high priority/impact security issue, an LTS will roll 
>> up a number of fixes. Each release would receive the full system test to 
>> verify that the patch set does not introduce regression defects. I believe 
>> that most LTS users want a few releases as necessary to keep their systems 
>> up-to-date and stable because each upgrade carries operational risk and 
>> downtime. Therefore, the process should strive to make as a few releases as 
>> necessary to achieve this goal.
>>
>> Thanks,
>> -John
>>
>>> On Jan 15, 2016, at 3:22 PM, ilya  wrote:
>>>
>>> John
>>>
>>> Thank you for taking time writing out the LTS proposal.
>>>
 Broad community support is vital to guarantee the twenty (20) month
 support period for each LTS branch. Given the ebbs and flows of
 contribution and committer priorities, ShapeBlue will provide a
 release manager, as well as, engineering support to fill any
 contribution gaps to ensure that the community fulfills LTS commitments.
>>>
>>> You guys rock!!
>>>
>>> I'm +1 on this,
>>>
>>> Can you please expand on the QA side of LTS. Since this is more
>>> around long term bug/security fix - i'd think - the testing will be
>>> minimal, to the scope that fix applies - which will speed up the
>>> release process in general. What are your thoughts on this?
>>>
>>>
>>> Thanks
>>> ilya
>>>
>>>
>>>
>>>
>>>
>>> On 1/15/16 10:48 AM, John Burwell wrote:
 Motivation
 

 The current monthly release cycle addresses the needs of users
 focused on deploying new functionality as quickly as possible. It
 does not address the needs of users oriented towards stability
 rather than new functionality. These users typically employ QA
 processes to comply with corporate policy and/or regulatory
 requirements. To maintain a growing, thriving community, we must address 
 the needs of both user types.
 Therefore, I propose that we overlay a LTS release cycle onto the
 monthly release cycle to address the needs of stability-oriented
 users with minimal to no impact on the monthly release cycle. This
 proposed LTS release cycle has the following goals:

 * Prefer Stability to New Functionality: Deliver releases that only
 address defects and CVEs. This narrowly focused change scope greatly

Re: [PROPOSAL] LTS Release Cycle

[Rohit Yadav]

Based on my long-time experience with maintaining and doing release work on 4.3 
and later 4.5, there are many reasons where backporting is needed and forward 
merge won’t work;

1. Due to high codebase changes mostly due to major refactorings, it is not 
possible to simply cherry-pick a commit; backporting many times involved 
writing the fix manually based on the commit diff that I wanted to backport. 
Cherry-picking becomes impossible if anyone has changed package names, 
file/directory paths, removed code etc.

2. Forward merging will also start failing (due to same reason as above) as 
time progress the codebase diverges due to refactoring, new code and any 
design/architectural changes. The other issue with forward merging is that it 
would require merging from the oldest branch to the newest, with time there 
would be several branches (given the monthly pace) between the LTS branch and 
the future master branch. So, in my experience backporting may become necessary.

3. The bugfix author may not send their fix/PR against old branches, as time 
progresses developers won’t care much about the older LTS branch(es). Wrt 
4.3/4.5 at times I had to backport changes myself after failing to get the 
original author send the fix against 4.3/4.5 branch. This is expected of 
developers, as they contribute in our own *free* time and they may not have the 
time, bandwidth or interest in seeing those fixes in older branches.

For example, we’ve 4.7 and 4.8 (upcoming) where forwarding merging will work 
for sometime, but in 14-20 months the developers may not send bugfix/PRs 
against 4.7 and expect future RMs to merge them forward as that would require 
both merge-conflict fixing and testing for all intermediate branches 4.8 to 
4.20 (assuming, monthly releases we’ll at least reach 4.20 in 14-20 months and 
I’m not sure if RMs will have time and dedication to test all 12+ 
releases/branches ). For non-LTS branches, it may not make sense to even have 
those bugfixes.

In my experience (with pseudo LTS branches, 4.3/4.5) and opinion, LTS branches 
are going to diverge wrt master with time but they are going to have a dead-end.

About cherry-picking, the way we’re going git commits/merge at least I’m not 
able to follow the git history at all, it looks like a mess to me. We talk 
about ability to trace commits through branches, but I cannot even follow 
changes in the same branch now (say master). I personally use git diff and git 
log -p to trace changes using differences now (in files or paths/folders). 
Cherry-picking is not bad, if done right (always include the git commit ID from 
where it was picked using -x -s) you can trace it.

Regards.

[ShapeBlue]
Rohit Yadav
Software Architect  ,   ShapeBlue


d:   | s: +44 203 603 0540  |  
m:  +91 8826230892

e:  rohit.ya...@shapeblue.com | t: 
   |  w:  
www.shapeblue.com

a:  53 Chandos Place, Covent Garden London WC2N 4HS UK


[cid:image608ca6.png@adf34d27.428e2635]


Shape Blue Ltd is a company incorporated in England & Wales. ShapeBlue Services 
India LLP is a company incorporated in India and is operated under license from 
Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in 
Brasil and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd 
is a company registered by The Republic of South Africa and is traded under 
license from Shape Blue Ltd. ShapeBlue is a registered trademark.
This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error.




Find out more about ShapeBlue and our range of CloudStack related services:
IaaS Cloud Design & Build | 
CSForge – rapid IaaS deployment framework
CloudStack Consulting | 
CloudStack Software 
Engineering
CloudStack Infrastructure 
Support | CloudStack 
Bootcamp Training Courses

[GitHub] cloudstack pull request: Enhance VR performance

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/1346#issuecomment-173169424
  
Ping @borisroman @remibergsma 

PR LGTM :+1: 

* Environment
  * Hardware required: TRUE
  * Management Server + MySQL on CentOS 7.1
  * One KVM Host on CentOS 7.1
  * Agent + Common RPMs built from 4.7.0  source

* Tests Suites Executed

```
nosetests --with-marvin 
--marvin-config=/data/shared/marvin/mct-zone1-kvm1-ISOLATED.cfg -s -a 
tags=advanced,required_hardware=true smoke/test_vpc_redundant.py 
smoke/test_routers_iptables_default_policy.py smoke/test_routers_network_ops.py 
smoke/test_vpc_router_nics.py smoke/test_password_server.py 
smoke/test_router_dhcphosts.py smoke/test_loadbalance.py 
smoke/test_internal_lb.py smoke/test_ssvm.py smoke/test_vpc_vpn.py 
smoke/test_network.py smoke/test_privategw_acl.py
```

* Results

```
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status : 
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and 
check default routes ... === TestName: test_02_redundant_VPC_default_routes | 
Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: 
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Status : 
SUCCESS ===
ok
Create a redundant VPC with 1 Tier, 1 VM, 1 ACL, 1 PF and test Network GC 
Nics ... === TestName: test_04_rvpc_network_garbage_collector_nics | Status : 
SUCCESS ===
ok
Create a redundant VPC with 1 Tier, 1 VM, 1 ACL, 1 PF and test Network GC 
Nics ... === TestName: test_05_rvpc_multi_tiers | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName: 
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... === 
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_03_RVR_Network_check_router_state | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics 
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : 
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default 
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Check the password file in the Router VM ... === TestName: 
test_isolate_network_password_server | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... === 
TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName: 
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: 
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: 
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's in a Single VPC ... === TestName: 
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Status : SUCCESS ===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's in a Redundant VPC ... === TestName: 
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test_03_vpc_internallb_haproxy_stats_on_all_interfaces | Status : 
SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | Status : 
SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : 
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : 
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === 

[GitHub] cloudstack pull request: Enhance VR performance

[borisroman]

Github user borisroman commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1346#discussion_r50241366
  
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py ---
@@ -901,79 +901,123 @@ def processStaticNatRule(self, rule):
 
 
 def main(argv):
+# The file we are currently processing, if it is "cmd_line.json" 
everything will be processed.
+process_file = argv[1]
+
+# process_file can be None, if so assume cmd_line.json
+if process_file is None:
+process_file = "cmd_line.json"
+
+# Track if changes need to be committed to NetFilter
+iptables_change = False
+
+# The "GLOBAL" Configuration object
 config = CsConfig()
+
 logging.basicConfig(filename=config.get_logger(),
 level=config.get_level(),
 format=config.get_format())
+
+# Load stored ip adresses from disk to CsConfig()
 config.set_address()
 
 logging.debug("Configuring ip addresses")
-# IP configuration
 config.address().compare()
 config.address().process()
 
-logging.debug("Configuring vmpassword")
-password = CsPassword("vmpassword", config)
-password.process()
+if process_file == "cmd_line.json" or process_file == 
"guest_network.json":
--- End diff --

Done!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [PROPOSAL] LTS Release Cycle

[Daan Hoogland]

Rohit,

I don't see any reasons beyond lack of discipline, ignorance, and laziness
in your description. Not of an RM or other individual btw but of the
community as a whole. In point 1 and 2 you are describing how cherry-pick
and forward merge are actually the same amount of work. In the case of
forward merge however we will have a merge commit describing what that work
was and still a link in later branches to the commit.

Point 3 is actually where we should be proactive. If they don't care we
should tell them to create a branch against the offending commit and work
from there.


On Wed, Jan 20, 2016 at 11:32 AM, Rohit Yadav 
wrote:

> Based on my long-time experience with maintaining and doing release work
> on 4.3 and later 4.5, there are many reasons where backporting is needed
> and forward merge won’t work;
>
> 1. Due to high codebase changes mostly due to major refactorings, it is
> not possible to simply cherry-pick a commit; backporting many times
> involved writing the fix manually based on the commit diff that I wanted to
> backport. Cherry-picking becomes impossible if anyone has changed package
> names, file/directory paths, removed code etc.
>
> 2. Forward merging will also start failing (due to same reason as above)
> as time progress the codebase diverges due to refactoring, new code and any
> design/architectural changes. The other issue with forward merging is that
> it would require merging from the oldest branch to the newest, with time
> there would be several branches (given the monthly pace) between the LTS
> branch and the future master branch. So, in my experience backporting may
> become necessary.
>
> 3. The bugfix author may not send their fix/PR against old branches, as
> time progresses developers won’t care much about the older LTS branch(es).
> Wrt 4.3/4.5 at times I had to backport changes myself after failing to get
> the original author send the fix against 4.3/4.5 branch. This is expected
> of developers, as they contribute in our own *free* time and they may not
> have the time, bandwidth or interest in seeing those fixes in older
> branches.
>
> For example, we’ve 4.7 and 4.8 (upcoming) where forwarding merging will
> work for sometime, but in 14-20 months the developers may not send
> bugfix/PRs against 4.7 and expect future RMs to merge them forward as that
> would require both merge-conflict fixing and testing for all intermediate
> branches 4.8 to 4.20 (assuming, monthly releases we’ll at least reach 4.20
> in 14-20 months and I’m not sure if RMs will have time and dedication to
> test all 12+ releases/branches ). For non-LTS branches, it may not make
> sense to even have those bugfixes.
>
> In my experience (with pseudo LTS branches, 4.3/4.5) and opinion, LTS
> branches are going to diverge wrt master with time but they are going to
> have a dead-end.
>
> About cherry-picking, the way we’re going git commits/merge at least I’m
> not able to follow the git history at all, it looks like a mess to me. We
> talk about ability to trace commits through branches, but I cannot even
> follow changes in the same branch now (say master). I personally use git
> diff and git log -p to trace changes using differences now (in files or
> paths/folders). Cherry-picking is not bad, if done right (always include
> the git commit ID from where it was picked using -x -s) you can trace it.
>
> Regards.
>
> [image: ShapeBlue] 
> Rohit Yadav
> Software Architect ,  ShapeBlue
> d:  * | s: +44 203 603 0540* <%7C%20s:%20+44%20203%20603%200540>  |  m:
> *+91 8826230892* <+91%208826230892>
> e:  *rohit.ya...@shapeblue.com | t: *
>   |  w:  *www.shapeblue.com*
> 
> a:  53 Chandos Place, Covent Garden London WC2N 4HS UK
> Shape Blue Ltd is a company incorporated in England & Wales. ShapeBlue
> Services India LLP is a company incorporated in India and is operated under
> license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a
> company incorporated in Brasil and is operated under license from Shape
> Blue Ltd. ShapeBlue SA Pty Ltd is a company registered by The Republic of
> South Africa and is traded under license from Shape Blue Ltd. ShapeBlue is
> a registered trademark.
> This email and any attachments to it may be confidential and are intended
> solely for the use of the individual to whom it is addressed. Any views or
> opinions expressed are solely those of the author and do not necessarily
> represent those of Shape Blue Ltd or related companies. If you are not the
> intended recipient of this email, you must neither take any action based
> upon its contents, nor copy or show it to anyone. Please contact the sender
> if you believe you have received this email in error.
>
>
> Find out more about ShapeBlue and our range of CloudStack related services:
> IaaS Cloud Design & Build
>  | CSForge – rapid
> IaaS 

[GitHub] cloudstack pull request: [FUTURE]CLOUDSTACK-8872: Replaced all occ...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/832#issuecomment-173184982
  
Most of them have already been resolved.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [FUTURE]CLOUDSTACK-8872: Replaced all occ...

[borisroman]

Github user borisroman closed the pull request at:

https://github.com/apache/cloudstack/pull/832


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [FUTURE]CLOUDSTACK-8907: POD Gateway opti...

[borisroman]

Github user borisroman closed the pull request at:

https://github.com/apache/cloudstack/pull/886


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [FUTURE]CLOUDSTACK-8907: POD Gateway opti...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/886#issuecomment-173185222
  
When the network stack get's refactored this won't be necessary anymore.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8308: Adding automation testca...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/720#issuecomment-173186487
  
Been open for 3 months, closing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8308: Adding automation testca...

[borisroman]

Github user borisroman closed the pull request at:

https://github.com/apache/cloudstack/pull/720


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9160: Remove unused folder(s)/...

[borisroman]

Github user borisroman closed the pull request at:

https://github.com/apache/cloudstack/pull/1238


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Enhance VR performance

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1346#issuecomment-173187438
  
LGTM based on these tests:

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=true \
component/test_vpc_redundant.py \
component/test_routers_iptables_default_policy.py \
component/test_routers_network_ops.py \
component/test_vpc_router_nics.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_network.py

```

Result:

```
Check the password file in the Router VM ... === TestName: 
test_isolate_network_password_server | Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status : 
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and 
check default routes ... === TestName: test_02_redundant_VPC_default_routes | 
Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: 
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Status : 
SUCCESS ===
ok
Create a redundant VPC with 1 Tier, 1 VM, 1 ACL, 1 PF and test Network GC 
Nics ... === TestName: test_04_rvpc_network_garbage_collector_nics | Status : 
FAILED ===
FAIL
Create a redundant VPC with 1 Tier, 1 VM, 1 ACL, 1 PF and test Network GC 
Nics ... === TestName: test_05_rvpc_multi_tiers | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName: 
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... === 
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : FAILED ===
FAIL
Test redundant router internals ... === TestName: 
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : FAILED ===
FAIL
Test redundant router internals ... === TestName: 
test_03_RVR_Network_check_router_state | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics 
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : 
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default 
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... === 
TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName: 
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: 
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: 
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's in a Single VPC ... === TestName: 
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Status : SUCCESS ===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's in a Redundant VPC ... === TestName: 
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test_03_vpc_internallb_haproxy_stats_on_all_interfaces | Status : 
SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | Status : 
SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : 
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : 
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS 
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS 
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS 
===
ok
...skipping...
Check the password file in the Router VM ... === TestName: 

Re: [PROPOSE] Dynamic inter VPC routing

[Erik Weber]

Thans Abhi, glad to hear :-)

-- 
Erik

On Wed, Jan 20, 2016 at 1:06 PM, Abhinandan Prateek <
abhinandan.prat...@shapeblue.com> wrote:

> Erik,
>
> Updated the doc to reflect that the CIDR partitioning is not rigid.
>
>
>
>
>
> [image: ShapeBlue] 
> Abhinandan Prateek
> Software Architect ,  ShapeBlue
> d:  * | s: +44 203 603 0540* <%7C%20s:%20+44%20203%20603%200540>  |  m:
> *+91 970 11 99011* <+91%20970%2011%2099011>
> e:  *abhinandan.prat...@shapeblue.com | t: *
>   |  w:  *www.shapeblue.com*
> 
> a:  53 Chandos Place, Covent Garden London WC2N 4HS UK
> Shape Blue Ltd is a company incorporated in England & Wales. ShapeBlue
> Services India LLP is a company incorporated in India and is operated under
> license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a
> company incorporated in Brasil and is operated under license from Shape
> Blue Ltd. ShapeBlue SA Pty Ltd is a company registered by The Republic of
> South Africa and is traded under license from Shape Blue Ltd. ShapeBlue is
> a registered trademark.
> This email and any attachments to it may be confidential and are intended
> solely for the use of the individual to whom it is addressed. Any views or
> opinions expressed are solely those of the author and do not necessarily
> represent those of Shape Blue Ltd or related companies. If you are not the
> intended recipient of this email, you must neither take any action based
> upon its contents, nor copy or show it to anyone. Please contact the sender
> if you believe you have received this email in error.
>
>
> On 05/01/16, 9:17 PM, "Erik Weber"  wrote:
>
> >On Mon, Jan 4, 2016 at 3:10 PM, Abhinandan Prateek <
> >abhinandan.prat...@shapeblue.com> wrote:
> >
> >> Hi All,
> >>
> >> Currently the inter VPC traffic has to go thru the public gateway.
> >> This means the traffic has to be nat-ed across public internet via
> >> core-routers, which is inefficient in itself. A more efficient approach
> >> will be to route the traffic locally.
> >>
> >> The proposal is to enable quagga- ospf on VPC routers so that the
> >> traffic between VPC’s is routed efficiently.
> >>
> >> The design doc is here:
> >>
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Dynamically+routed+VPC
> >>
> >>
> >
> >Regarding Super-CIDRs it states that a Super-CIDR will be divided into /24
> >and /27s, but it is unclear to me if this is hard coded or just an
> example.
> >
> >What if a user wants to use /26 as their Tier-network within a /16
> >Super-CIDR?
> >
> >
> >--
> >Erik
> Find out more about ShapeBlue and our range of CloudStack related services:
> IaaS Cloud Design & Build
>  | CSForge – rapid
> IaaS deployment framework 
> CloudStack Consulting  | 
> CloudStack
> Software Engineering
> 
> CloudStack Infrastructure Support
>  | CloudStack
> Bootcamp Training Courses 
>

[GitHub] cloudstack pull request: UI: improve filter dropdown width

[resmo]

GitHub user resmo opened a pull request:

https://github.com/apache/cloudstack/pull/1354

UI: improve filter dropdown width

Giving a little more space to fix new line, see [after and 
before](https://photos.google.com/share/AF1QipP6ZeMO4B_fSLCBocr0MQmgbbq3gAf0vDY8Hy4YjUgqLH_VY8vpP2y5U6RMWL9Vfw?key=ZFVxcjUxcXZvVmZGTTQzOER6VUxYWENVODJfXzhB)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/resmo/cloudstack fix/ui-div-filter-width

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1354.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1354


commit d53dd0a671e635edcefcae332e1b7d428ac7600b
Author: Rene Moser 
Date:   2016-01-20T12:22:34Z

UI: improve filter dropdown width




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9239 throw exception on deprec...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1349#issuecomment-173194446
  
LGTM based on these tests:

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=true \
component/test_vpc_redundant.py \
component/test_routers_iptables_default_policy.py \
component/test_routers_network_ops.py \
component/test_vpc_router_nics.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_network.py

```

Result:

```
Check the password file in the Router VM ... === TestName: 
test_isolate_network_password_server | Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status : 
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and 
check default routes ... === TestName: test_02_redundant_VPC_default_routes | 
Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: 
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Status : 
SUCCESS ===
ok
Create a redundant VPC with 1 Tier, 1 VM, 1 ACL, 1 PF and test Network GC 
Nics ... === TestName: test_04_rvpc_network_garbage_collector_nics | Status : 
SUCCESS ===
ok
Create a redundant VPC with 1 Tier, 1 VM, 1 ACL, 1 PF and test Network GC 
Nics ... === TestName: test_05_rvpc_multi_tiers | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName: 
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... === 
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_03_RVR_Network_check_router_state | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics 
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : 
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default 
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... === 
TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName: 
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: 
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: 
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's in a Single VPC ... === TestName: 
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Status : SUCCESS ===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's in a Redundant VPC ... === TestName: 
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test_03_vpc_internallb_haproxy_stats_on_all_interfaces | Status : 
SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | Status : 
SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : 
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : 
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS 
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS 
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS 
===
ok
ok
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: 

RE: [PROPOSAL] LTS Release Cycle

[Paul Angus]

Absolutely Remi, we're looking to learn all that we can from those who already 
use Marvin. It's tougher for us non-developers to get started, but once we get 
the understanding in terms which we are used to working with, then we can 
better explain it to users and expand the number of people who can carry out 
testing.




Paul Angus
VP Technology   ,   ShapeBlue


t:  @cloudyangus

e:  paul.an...@shapeblue.com|  
w:  www.shapeblue.com





-Original Message-
From: Remi Bergsma [mailto:rberg...@schubergphilis.com]
Sent: 20 January 2016 10:48
To: dev@cloudstack.apache.org
Subject: Re: [PROPOSAL] LTS Release Cycle

Hi Paul,

I just hope you won’t reinvent the wheel ;-) Feel free to use what was build to 
test the 500+ PRs that got merged over the last couple of months to build 4.6, 
4.7 and 4.8. For results see the comments in all these PRs.



More info:
https://github.com/schubergphilis/MCT-shared

This is already being used by PCExtreme, Leaseweb and Schuberg Philis.

Regards,
Remi


On 19/01/16 22:01, "Paul Angus"  wrote:

>Hi Ilya (and all others),
>
>We (ShapeBlue) agree with you regarding the importance of automated 
>integration testing. The consulting team are currently working to understand 
>Marvin fully and what pieces we need to be able deploy properly representative 
>(virtualised) infrastructures to test against. We intend to open source our 
>resultant framework, with a view to community members being able to use it 
>themselves in their own labs but also so that as a community we can build it 
>out somewhere to be used as part of the projects' testing regime.
>
>We'll be reaching out to the community soon to work on the failures we're 
>seeing currently and understand where they come from - ie Marvin build, the 
>environment, the tests or CloudStack (watch out Mike T - I'm about to watch 
>your presentation video).
>
>We see this an important initiative for CloudStack as a whole, agile or 
>otherwise. But ultimately this is 'only' regression testing and the 
>organisations which need/want LTS, require it for a number of reasons, 
>including the fact new features bring new bugs which, if we knew we had to 
>test for, probably wouldn't have been there in the first place.
>
>
>
>Paul Angus
>VP Technology , ShapeBlue
>
>
>t: @cloudyangus
>
>e: paul.an...@shapeblue.com | w: 
>www.shapeblue.com
>
>
>
>
>
>-Original Message-
>From: ilya [mailto:ilya.mailing.li...@gmail.com]
>Sent: Tuesday, January 19, 2016 6:39 PM
>To: dev@cloudstack.apache.org
>Subject: Re: [PROPOSAL] LTS Release Cycle
>
>> Therefore, the process should strive to make as a few releases as
>necessary to achieve this goal.
>
>I guess part two to this question would be - we need the automated testing 
>environments. This can ensure rapid release testing and acutal release, and we 
>dont have to restrains ourselves to limited number of releases LTS release due 
>to QA pains.
>
>We need a separate initiative with CloudStack testing framework.
>
>On 1/18/16 6:54 PM, John Burwell wrote:
>> Ilya,
>>
>> Unless we have a bug fix that addresses a significant, widespread system 
>> stability problem or a high priority/impact security issue, an LTS will roll 
>> up a number of fixes. Each release would receive the full system test to 
>> verify that the patch set does not introduce regression defects. I believe 
>> that most LTS users want a few releases as necessary to keep their systems 
>> up-to-date and stable because each upgrade carries operational risk and 
>> downtime. Therefore, the process should strive to make as a few releases as 
>> necessary to achieve this goal.
>>
>> Thanks,
>> -John
>>
>>> On Jan 15, 2016, at 3:22 PM, ilya  wrote:
>>>
>>> John
>>>
>>> Thank you for taking time writing out the LTS proposal.
>>>
 Broad community support is vital to guarantee the twenty (20) month
 support period for each LTS branch. Given the ebbs and flows of
 contribution and committer priorities, ShapeBlue will provide a
 release manager, as well as, engineering support to fill any
 contribution gaps to ensure that the community fulfills LTS commitments.
>>>
>>> You guys rock!!
>>>
>>> I'm +1 on this,
>>>
>>> Can you please expand on the QA side of LTS. Since this is more
>>> around long term bug/security fix - i'd think - the testing will be
>>> minimal, to the scope that fix applies - which will speed up the
>>> release process in general. What are your thoughts on this?
>>>
>>>
>>> Thanks
>>> ilya
>>>
>>>
>>>
>>>
>>>
>>> On 1/15/16 10:48 AM, John Burwell wrote:
 Motivation
 

 The current monthly release cycle addresses the needs of users
 focused on deploying new functionality as quickly as possible. It
 does not address the needs of 

[GitHub] cloudstack pull request: [CLOUDSTACK-9218]Test to verify restart n...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/1323#issuecomment-173196099
  
Ping @remibergsma @borisroman 

This one needs to be tested.

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9114: restartnetwork with clea...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/1198#issuecomment-173196826
  
Ping @remibergsma @borisroman 

This one needs an integration test to cover the changes. Worth writing one 
for. Who got time left? :)

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Cloudstack-8885 added blocked connection ...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/857#issuecomment-173197191
  
Ping @remibergsma @borisroman 

I don;t have a way to test it now, but looked at the code - just like 
@DaanHoogland @wido and @runseb did. I trust the manual tests  @karuturi 
performed. So, LGTM :+1: 

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Enhance VR performance

[wilderrodrigues]

Github user wilderrodrigues commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1346#discussion_r50251563
  
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py ---
@@ -901,79 +901,123 @@ def processStaticNatRule(self, rule):
 
 
 def main(argv):
+# The file we are currently processing, if it is "cmd_line.json" 
everything will be processed.
+process_file = argv[1]
+
+# process_file can be None, if so assume cmd_line.json
+if process_file is None:
+process_file = "cmd_line.json"
+
+# Track if changes need to be committed to NetFilter
+iptables_change = False
+
+# The "GLOBAL" Configuration object
 config = CsConfig()
+
 logging.basicConfig(filename=config.get_logger(),
 level=config.get_level(),
 format=config.get_format())
+
+# Load stored ip adresses from disk to CsConfig()
 config.set_address()
 
 logging.debug("Configuring ip addresses")
-# IP configuration
 config.address().compare()
 config.address().process()
 
-logging.debug("Configuring vmpassword")
-password = CsPassword("vmpassword", config)
-password.process()
+if process_file in ["cmd_line.json", "guest_network.json"]:
+logging.debug("Configuring Guest Network")
+iptables_change = True
+
+if process_file in ["cmd_line.json", "vm_password.json"]:
+logging.debug("Configuring vmpassword")
+password = CsPassword("vmpassword", config)
+password.process()
 
-logging.debug("Configuring vmdata")
-metadata = CsVmMetadata('vmdata', config)
-metadata.process()
+if process_file in ["cmd_line.json", "vm_metadata.json"]:
+logging.debug("Configuring vmdata")
+metadata = CsVmMetadata('vmdata', config)
+metadata.process()
 
-logging.debug("Configuring networkacl")
+# Always run both CsAcl().process() methods
+# They fill the base rules in config.fw[]
 acls = CsAcl('networkacl', config)
 acls.process()
 
-logging.debug("Configuring firewall rules")
 acls = CsAcl('firewallrules', config)
 acls.process()
 
-logging.debug("Configuring PF rules")
--- End diff --

@pdube 

The logging was not removed, it was just added underneath the IF blocks. 
All the logging is still there, but will only be executed by the given commands.

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Enhance VR performance

[remibergsma]

Github user remibergsma commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1346#discussion_r50251651
  
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsDhcp.py ---
@@ -96,29 +96,8 @@ def configure_server(self):
 self.conf.search(sline, line)
 
 def delete_leases(self):
-changed = []
-leases = []
 try:
-for line in open(LEASES):
-bits = line.strip().split(' ')
-to = {"device": bits[0],
-  "mac": bits[1],
-  "ip": bits[2],
-  "host": bits[3:],
-  "del": False
-  }
-changed.append(to)
-
-for v in changed:
-if v['mac'] == to['mac'] or v['ip'] == to['ip'] or 
v['host'] == to['host']:
-to['del'] = True
-leases.append(to)
-
-for o in leases:
-if o['del']:
-cmd = "dhcp_release eth%s %s %s" % (o['device'], 
o['ip'], o['mac'])
-logging.info(cmd)
-CsHelper.execute(cmd)
+open(LEASES, 'w').close()
--- End diff --

Instead of removing one entry, everything gets deleted and then the ones 
needed are added again later on.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Enhance VR performance

[wilderrodrigues]

Github user wilderrodrigues commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1346#discussion_r50251936
  
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py ---
@@ -901,79 +901,123 @@ def processStaticNatRule(self, rule):
 
 
 def main(argv):
+# The file we are currently processing, if it is "cmd_line.json" 
everything will be processed.
+process_file = argv[1]
+
+# process_file can be None, if so assume cmd_line.json
+if process_file is None:
+process_file = "cmd_line.json"
+
+# Track if changes need to be committed to NetFilter
+iptables_change = False
+
+# The "GLOBAL" Configuration object
 config = CsConfig()
+
 logging.basicConfig(filename=config.get_logger(),
 level=config.get_level(),
 format=config.get_format())
+
+# Load stored ip adresses from disk to CsConfig()
 config.set_address()
 
 logging.debug("Configuring ip addresses")
-# IP configuration
 config.address().compare()
 config.address().process()
 
-logging.debug("Configuring vmpassword")
-password = CsPassword("vmpassword", config)
-password.process()
+if process_file in ["cmd_line.json", "guest_network.json"]:
+logging.debug("Configuring Guest Network")
+iptables_change = True
+
+if process_file in ["cmd_line.json", "vm_password.json"]:
+logging.debug("Configuring vmpassword")
+password = CsPassword("vmpassword", config)
+password.process()
 
-logging.debug("Configuring vmdata")
-metadata = CsVmMetadata('vmdata', config)
-metadata.process()
+if process_file in ["cmd_line.json", "vm_metadata.json"]:
+logging.debug("Configuring vmdata")
+metadata = CsVmMetadata('vmdata', config)
+metadata.process()
 
-logging.debug("Configuring networkacl")
+# Always run both CsAcl().process() methods
+# They fill the base rules in config.fw[]
 acls = CsAcl('networkacl', config)
 acls.process()
 
-logging.debug("Configuring firewall rules")
 acls = CsAcl('firewallrules', config)
 acls.process()
 
-logging.debug("Configuring PF rules")
 fwd = CsForwardingRules("forwardingrules", config)
 fwd.process()
 
-logging.debug("Configuring s2s vpn")
 vpns = CsSite2SiteVpn("site2sitevpn", config)
 vpns.process()
 
-logging.debug("Configuring remote access vpn")
-#remote access vpn
 rvpn = CsRemoteAccessVpn("remoteaccessvpn", config)
 rvpn.process()
 
-logging.debug("Configuring vpn users list")
-#remote access vpn users
-vpnuser = CsVpnUser("vpnuserlist", config)
-vpnuser.process()
-
-logging.debug("Configuring dhcp entry")
-dhcp = CsDhcp("dhcpentry", config)
-dhcp.process()
-
-logging.debug("Configuring load balancer")
 lb = CsLoadBalancer("loadbalancer", config)
 lb.process()
 
-logging.debug("Configuring monitor service")
-mon = CsMonitor("monitorservice", config)
-mon.process()
+if process_file in ["cmd_line.json", "network_acl.json"]:
+logging.debug("Configuring networkacl")
+iptables_change = True
+
+if process_file in ["cmd_line.json", "firewall_rules.json"]:
+logging.debug("Configuring firewall rules")
+iptables_change = True
+
+if process_file in ["cmd_line.json", "forwarding_rules.json", 
"staticnat_rules.json"]:
+logging.debug("Configuring PF rules")
--- End diff --

@pdube 

The point behind those changes was to avoid all the commands in the routers 
being called all the time. For example, add a FW rule to a router, all the 
other methods, not even related, were being executed. That was causing issues 
when one wanted to send several commands to the routers. Sometimes ACS was even 
timing out.

The difference in the code added by @borisroman is that now all the 
configuration files are checked before executing the methods.

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9237: Create LB Healthcheck is...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1340#issuecomment-173184740
  
LGTM :+1: 

Reviewed code, and according to the screenshots it works.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9147: In hypervisor-plugin-kvm...

[borisroman]

Github user borisroman closed the pull request at:

https://github.com/apache/cloudstack/pull/1225


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9146: Refactor Hypervisor KVM ...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1224#issuecomment-173185348
  
Conflicts, won't resolve them.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9146: Refactor Hypervisor KVM ...

[borisroman]

Github user borisroman closed the pull request at:

https://github.com/apache/cloudstack/pull/1224


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9147: In hypervisor-plugin-kvm...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1225#issuecomment-173185402
  
Conflicts, won't resolve them.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Remove unused folder(s)/file(s); HypervDu...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1237#issuecomment-173185763
  
No reviews, so closing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Remove unused folder(s)/file(s); HypervDu...

[borisroman]

Github user borisroman closed the pull request at:

https://github.com/apache/cloudstack/pull/1237


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9180: Optimize concurrent VM d...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/1251#issuecomment-173195505
  
Ping @remibergsma 

This one ca have the integrations tests executed against.

@pedro-martins: no need to add javadocs. The code should be 
self-documented. A private method called ```isRouterDeployed``` is already 
clear enough.

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8860: improve error messages i...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/864#issuecomment-173197587
  
Ping @remibergsma @borisroman 

Please, make it happen! :)

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Enhance VR performance

[remibergsma]

Github user remibergsma commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1346#discussion_r50251745
  
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py ---
@@ -901,79 +901,123 @@ def processStaticNatRule(self, rule):
 
 
 def main(argv):
+# The file we are currently processing, if it is "cmd_line.json" 
everything will be processed.
+process_file = argv[1]
+
+# process_file can be None, if so assume cmd_line.json
+if process_file is None:
+process_file = "cmd_line.json"
+
+# Track if changes need to be committed to NetFilter
+iptables_change = False
+
+# The "GLOBAL" Configuration object
 config = CsConfig()
+
 logging.basicConfig(filename=config.get_logger(),
 level=config.get_level(),
 format=config.get_format())
+
+# Load stored ip adresses from disk to CsConfig()
 config.set_address()
 
 logging.debug("Configuring ip addresses")
-# IP configuration
 config.address().compare()
 config.address().process()
 
-logging.debug("Configuring vmpassword")
-password = CsPassword("vmpassword", config)
-password.process()
+if process_file in ["cmd_line.json", "guest_network.json"]:
+logging.debug("Configuring Guest Network")
+iptables_change = True
+
+if process_file in ["cmd_line.json", "vm_password.json"]:
+logging.debug("Configuring vmpassword")
+password = CsPassword("vmpassword", config)
+password.process()
 
-logging.debug("Configuring vmdata")
-metadata = CsVmMetadata('vmdata', config)
-metadata.process()
+if process_file in ["cmd_line.json", "vm_metadata.json"]:
+logging.debug("Configuring vmdata")
+metadata = CsVmMetadata('vmdata', config)
+metadata.process()
 
-logging.debug("Configuring networkacl")
+# Always run both CsAcl().process() methods
+# They fill the base rules in config.fw[]
 acls = CsAcl('networkacl', config)
 acls.process()
 
-logging.debug("Configuring firewall rules")
 acls = CsAcl('firewallrules', config)
 acls.process()
 
-logging.debug("Configuring PF rules")
--- End diff --

We discussed that but there were some issues we need to investigate. This 
already improves it, once we figure out how to make it conditional we'll add a 
new PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Enhance VR performance

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1346


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [PROPOSE] Dynamic inter VPC routing

[Abhinandan Prateek]

Erik,

Updated the doc to reflect that the CIDR partitioning is not rigid.





[ShapeBlue]
Abhinandan Prateek
Software Architect  ,   ShapeBlue


d:   | s: +44 203 603 0540  |  
m:  +91 970 11 99011

e:  abhinandan.prat...@shapeblue.com | t: 
 |  w:  
www.shapeblue.com

a:  53 Chandos Place, Covent Garden London WC2N 4HS UK


[cid:image30a874.png@4d1f2b2d.4285da73]


Shape Blue Ltd is a company incorporated in England & Wales. ShapeBlue Services 
India LLP is a company incorporated in India and is operated under license from 
Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in 
Brasil and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd 
is a company registered by The Republic of South Africa and is traded under 
license from Shape Blue Ltd. ShapeBlue is a registered trademark.
This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error.




On 05/01/16, 9:17 PM, "Erik Weber"  wrote:

>On Mon, Jan 4, 2016 at 3:10 PM, Abhinandan Prateek <
>abhinandan.prat...@shapeblue.com> wrote:
>
>> Hi All,
>>
>> Currently the inter VPC traffic has to go thru the public gateway.
>> This means the traffic has to be nat-ed across public internet via
>> core-routers, which is inefficient in itself. A more efficient approach
>> will be to route the traffic locally.
>>
>> The proposal is to enable quagga- ospf on VPC routers so that the
>> traffic between VPC’s is routed efficiently.
>>
>> The design doc is here:
>> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Dynamically+routed+VPC
>>
>>
>
>Regarding Super-CIDRs it states that a Super-CIDR will be divided into /24
>and /27s, but it is unclear to me if this is hard coded or just an example.
>
>What if a user wants to use /26 as their Tier-network within a /16
>Super-CIDR?
>
>
>--
>Erik
Find out more about ShapeBlue and our range of CloudStack related services:
IaaS Cloud Design & Build | 
CSForge – rapid IaaS deployment framework
CloudStack Consulting | 
CloudStack Software 
Engineering
CloudStack Infrastructure 
Support | CloudStack 
Bootcamp Training Courses

[GitHub] cloudstack pull request: CLOUDSTACK-9158: Removed SLF4J, it's abun...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1236#issuecomment-173185634
  
Closing because of preference to logback.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9158: Removed SLF4J, it's abun...

[borisroman]

Github user borisroman closed the pull request at:

https://github.com/apache/cloudstack/pull/1236


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9152: Remove unused folder(s)/...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1232#issuecomment-173186549
  
Closing!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: build-master-slowbuild #3031

[jenkins]

See 

--
[...truncated 28713 lines...]
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud ---
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:instrument (default-cli) @ 
cloud-quickcloud ---
[WARNING] No files to instrument.
[INFO] NOT adding cobertura ser file to attached artifacts list.
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-quickcloud ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ 
cloud-quickcloud ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud ---
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Apache CloudStack Developer Tools - Checkstyle Configuration  SUCCESS 
[1.722s]
[INFO] Apache CloudStack . SUCCESS [2.495s]
[INFO] Apache CloudStack Maven Conventions Parent  SUCCESS [0.812s]
[INFO] Apache CloudStack Framework - Managed Context . SUCCESS [19.511s]
[INFO] Apache CloudStack Utils ... SUCCESS [1:30.985s]
[INFO] Apache CloudStack Framework ... SUCCESS [0.118s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [53.061s]
[INFO] Apache CloudStack Framework - Configuration ... SUCCESS [27.637s]
[INFO] Apache CloudStack API . SUCCESS [1:49.897s]
[INFO] Apache CloudStack Framework - REST  SUCCESS [16.561s]
[INFO] Apache CloudStack Framework - IPC . SUCCESS [29.902s]
[INFO] Apache CloudStack Cloud Engine  SUCCESS [0.113s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [28.420s]
[INFO] Apache CloudStack Framework - Security  SUCCESS [24.679s]
[INFO] Apache CloudStack Core  SUCCESS [1:21.795s]
[INFO] Apache CloudStack Agents .. SUCCESS [36.672s]
[INFO] Apache CloudStack Framework - Clustering .. SUCCESS [36.160s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [14.660s]
[INFO] Apache CloudStack Cloud Engine Schema Component ... SUCCESS [2:07.274s]
[INFO] Apache CloudStack Framework - Jobs  SUCCESS [42.251s]
[INFO] Apache CloudStack Cloud Engine Internal Components API  SUCCESS [25.665s]
[INFO] Apache CloudStack Server .. SUCCESS [4:14.948s]
[INFO] Apache CloudStack Framework - Quota ... SUCCESS [36.952s]
[INFO] Apache CloudStack Usage Server  SUCCESS [43.864s]
[INFO] Apache CloudStack Cloud Engine Orchestration Component  SUCCESS 
[1:23.070s]
[INFO] Apache CloudStack Cloud Services .. SUCCESS [0.077s]
[INFO] Apache CloudStack Secondary Storage ... SUCCESS [0.471s]
[INFO] Apache CloudStack Secondary Storage Service ... SUCCESS [55.344s]
[INFO] Apache CloudStack Engine Storage Component  SUCCESS [48.104s]
[INFO] Apache CloudStack Engine Storage Volume Component . SUCCESS [29.621s]
[INFO] Apache CloudStack Engine Storage Image Component .. SUCCESS [27.155s]
[INFO] Apache CloudStack Engine Storage Data Motion Component  SUCCESS [25.954s]
[INFO] Apache CloudStack Engine Storage Cache Component .. SUCCESS [20.739s]
[INFO] Apache CloudStack Engine Storage Snapshot Component  SUCCESS [35.236s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [12.548s]
[INFO] Apache CloudStack Cloud Engine Service  SUCCESS [8.813s]
[INFO] Apache CloudStack Plugin POM .. SUCCESS [0.932s]
[INFO] Apache CloudStack Plugin - API Rate Limit . SUCCESS [26.226s]
[INFO] Apache CloudStack Plugin - Storage Volume default provider  SUCCESS 
[23.822s]
[INFO] Apache CloudStack Plugin - Storage Volume SolidFire Provider  SUCCESS 
[35.935s]
[INFO] Apache CloudStack Plugin - API SolidFire .. SUCCESS [17.389s]
[INFO] Apache CloudStack Plugin - API Discovery .. SUCCESS [23.362s]
[INFO] Apache CloudStack Plugin - ACL Static Role Based .. SUCCESS [16.885s]
[INFO] Apache CloudStack Plugin - Host Anti-Affinity Processor  SUCCESS 
[17.004s]
[INFO] Apache 

[GitHub] cloudstack pull request: CLOUDSTACK-9152: Remove unused folder(s)/...

[borisroman]

Github user borisroman closed the pull request at:

https://github.com/apache/cloudstack/pull/1232


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9160: Remove unused folder(s)/...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1238#issuecomment-173186580
  
Closing!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9239 throw exception on deprec...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1349


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9130: Make RebootCommand simil...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/1200#issuecomment-173196336
  
@koushik-das 

Is there any integration test that can cover this?

If so, we will run it and get this merged. Otherwise I can help writing one.

Ping @remibergsma @borisroman 

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Bug-ID: CLOUDSTACK-8870: Skip external de...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/846#issuecomment-173198529
  
Ping @remibergsma @borisroman 

@kishankavala added a unit test to cover his change. I went through the 
code and haven't found any issue.

The if block 
```if(_hostDao.listByType(Host.Type.ExternalFirewall).isEmpty() && 
_hostDao.listByType(Host.Type.ExternalLoadBalancer).isEmpty()){``` added to 
ExternalDeviceUsageManagerImpl make sense and are covered.

Please give it a go with the integration tests we have.

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Enhance VR performance

[wilderrodrigues]

Github user wilderrodrigues commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1346#discussion_r50252187
  
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsDhcp.py ---
@@ -96,29 +96,8 @@ def configure_server(self):
 self.conf.search(sline, line)
 
 def delete_leases(self):
-changed = []
-leases = []
 try:
-for line in open(LEASES):
-bits = line.strip().split(' ')
-to = {"device": bits[0],
-  "mac": bits[1],
-  "ip": bits[2],
-  "host": bits[3:],
-  "del": False
-  }
-changed.append(to)
-
-for v in changed:
-if v['mac'] == to['mac'] or v['ip'] == to['ip'] or 
v['host'] == to['host']:
-to['del'] = True
-leases.append(to)
-
-for o in leases:
-if o['del']:
-cmd = "dhcp_release eth%s %s %s" % (o['device'], 
o['ip'], o['mac'])
-logging.info(cmd)
-CsHelper.execute(cmd)
+open(LEASES, 'w').close()
--- End diff --

Hi @pdube 

From an static analysis point of view, I understand your concerns. However, 
when we tested this in the lab, we found out that it was always trying to 
execute the dhcp_lease command against eth0, only eth0. The result of given 
command was actually nothing!

What is being done now takes care of getting rid of the leases in the file, 
because they have already been deleted.

@borisroman, please add more if I forgot something.

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9195: Cancelled/failed async j...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1272#issuecomment-173205246
  
LGTM based on these tests:

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=true \
component/test_vpc_redundant.py \
component/test_routers_iptables_default_policy.py \
component/test_routers_network_ops.py \
component/test_vpc_router_nics.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_network.py

```

Result:

```
Check the password file in the Router VM ... === TestName: 
test_isolate_network_password_server | Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status : 
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and 
check default routes ... === TestName: test_02_redundant_VPC_default_routes | 
Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: 
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Status : 
SUCCESS ===
ok
Create a redundant VPC with 1 Tier, 1 VM, 1 ACL, 1 PF and test Network GC 
Nics ... === TestName: test_04_rvpc_network_garbage_collector_nics | Status : 
SUCCESS ===
ok
Create a redundant VPC with 1 Tier, 1 VM, 1 ACL, 1 PF and test Network GC 
Nics ... === TestName: test_05_rvpc_multi_tiers | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName: 
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... === 
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_03_RVR_Network_check_router_state | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics 
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : 
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default 
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... === 
TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName: 
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: 
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: 
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's in a Single VPC ... === TestName: 
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Status : SUCCESS ===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's in a Redundant VPC ... === TestName: 
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test_03_vpc_internallb_haproxy_stats_on_all_interfaces | Status : 
SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | Status : 
SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : 
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : 
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS 
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS 
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS 
===
ok
ok
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: 

[GitHub] cloudstack pull request: Enhance VR performance

[pdube]

Github user pdube commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1346#discussion_r50259649
  
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsDhcp.py ---
@@ -96,29 +96,8 @@ def configure_server(self):
 self.conf.search(sline, line)
 
 def delete_leases(self):
-changed = []
-leases = []
 try:
-for line in open(LEASES):
-bits = line.strip().split(' ')
-to = {"device": bits[0],
-  "mac": bits[1],
-  "ip": bits[2],
-  "host": bits[3:],
-  "del": False
-  }
-changed.append(to)
-
-for v in changed:
-if v['mac'] == to['mac'] or v['ip'] == to['ip'] or 
v['host'] == to['host']:
-to['del'] = True
-leases.append(to)
-
-for o in leases:
-if o['del']:
-cmd = "dhcp_release eth%s %s %s" % (o['device'], 
o['ip'], o['mac'])
-logging.info(cmd)
-CsHelper.execute(cmd)
+open(LEASES, 'w').close()
--- End diff --

That clears that up then!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [CLOUDSTACK-9218]Test to verify restart n...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1323#issuecomment-173214346
  
:) @wilderrodrigues obviously; it is a test, @sanju1010 tested it himself, 
do you want to test it in different environments?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9180: Optimize concurrent VM d...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1251#issuecomment-173220018
  
@wilderrodrigues Agreed @pedro-martins comments, persé should add to the 
clarity of the code, even javadoc. If the name is explanatory and there are no 
unexpected side effects we should not create them, especially for private 
methods. It doubles the maintenance needed. When changes are done both the code 
and the comments needs to change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Enhance VR performance

[pdube]

Github user pdube commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1346#discussion_r50259430
  
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py ---
@@ -901,79 +901,123 @@ def processStaticNatRule(self, rule):
 
 
 def main(argv):
+# The file we are currently processing, if it is "cmd_line.json" 
everything will be processed.
+process_file = argv[1]
+
+# process_file can be None, if so assume cmd_line.json
+if process_file is None:
+process_file = "cmd_line.json"
+
+# Track if changes need to be committed to NetFilter
+iptables_change = False
+
+# The "GLOBAL" Configuration object
 config = CsConfig()
+
 logging.basicConfig(filename=config.get_logger(),
 level=config.get_level(),
 format=config.get_format())
+
+# Load stored ip adresses from disk to CsConfig()
 config.set_address()
 
 logging.debug("Configuring ip addresses")
-# IP configuration
 config.address().compare()
 config.address().process()
 
-logging.debug("Configuring vmpassword")
-password = CsPassword("vmpassword", config)
-password.process()
+if process_file in ["cmd_line.json", "guest_network.json"]:
+logging.debug("Configuring Guest Network")
+iptables_change = True
+
+if process_file in ["cmd_line.json", "vm_password.json"]:
+logging.debug("Configuring vmpassword")
+password = CsPassword("vmpassword", config)
+password.process()
 
-logging.debug("Configuring vmdata")
-metadata = CsVmMetadata('vmdata', config)
-metadata.process()
+if process_file in ["cmd_line.json", "vm_metadata.json"]:
+logging.debug("Configuring vmdata")
+metadata = CsVmMetadata('vmdata', config)
+metadata.process()
 
-logging.debug("Configuring networkacl")
+# Always run both CsAcl().process() methods
+# They fill the base rules in config.fw[]
 acls = CsAcl('networkacl', config)
 acls.process()
 
-logging.debug("Configuring firewall rules")
 acls = CsAcl('firewallrules', config)
 acls.process()
 
-logging.debug("Configuring PF rules")
 fwd = CsForwardingRules("forwardingrules", config)
 fwd.process()
 
-logging.debug("Configuring s2s vpn")
 vpns = CsSite2SiteVpn("site2sitevpn", config)
 vpns.process()
 
-logging.debug("Configuring remote access vpn")
-#remote access vpn
 rvpn = CsRemoteAccessVpn("remoteaccessvpn", config)
 rvpn.process()
 
-logging.debug("Configuring vpn users list")
-#remote access vpn users
-vpnuser = CsVpnUser("vpnuserlist", config)
-vpnuser.process()
-
-logging.debug("Configuring dhcp entry")
-dhcp = CsDhcp("dhcpentry", config)
-dhcp.process()
-
-logging.debug("Configuring load balancer")
 lb = CsLoadBalancer("loadbalancer", config)
 lb.process()
 
-logging.debug("Configuring monitor service")
-mon = CsMonitor("monitorservice", config)
-mon.process()
+if process_file in ["cmd_line.json", "network_acl.json"]:
+logging.debug("Configuring networkacl")
+iptables_change = True
+
+if process_file in ["cmd_line.json", "firewall_rules.json"]:
+logging.debug("Configuring firewall rules")
+iptables_change = True
+
+if process_file in ["cmd_line.json", "forwarding_rules.json", 
"staticnat_rules.json"]:
+logging.debug("Configuring PF rules")
+iptables_change = True
+
+if process_file in ["cmd_line.json", "site_2_site_vpn.json"]:
+logging.debug("Configuring s2s vpn")
+iptables_change = True
--- End diff --

Here, it is misleading. The vpns.process has already been executed, then a 
log appears (configur*ing*)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9195: Cancelled/failed async j...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1272


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8860: improve error messages i...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/864


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Cloudstack-8885 added blocked connection ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/857


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [ANNOUNCE] New PMC member: Boris Roman Schrijver

[Patrick Dube]

Congratulations!

On Wed, Jan 20, 2016 at 12:57 AM, Sanjeev N  wrote:

> Congrats Boris !!
>
> On Wed, Jan 20, 2016 at 12:10 AM, ilya 
> wrote:
>
> > Warm welcome Boris..
> >
> > On 1/19/16 4:15 AM, Wilder Rodrigues wrote:
> > > The Project Management Committee (PMC) for Apache CloudStack is pleased
> > to
> > > announce that Boris Roman Schrijver has accepted our invitation to join
> > the PMC.
> > >
> > > Please join me in congratulating him.
> > >
> > > On behalf of the Apache CloudStack PMC
> > > Wilder Rodrigues
> > >
> >
>

[GitHub] cloudstack pull request: UI: improve filter dropdown width

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1354#issuecomment-173218473
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Enhance VR performance

[pdube]

Github user pdube commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1346#discussion_r50259089
  
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py ---
@@ -901,79 +901,123 @@ def processStaticNatRule(self, rule):
 
 
 def main(argv):
+# The file we are currently processing, if it is "cmd_line.json" 
everything will be processed.
+process_file = argv[1]
+
+# process_file can be None, if so assume cmd_line.json
+if process_file is None:
+process_file = "cmd_line.json"
+
+# Track if changes need to be committed to NetFilter
+iptables_change = False
+
+# The "GLOBAL" Configuration object
 config = CsConfig()
+
 logging.basicConfig(filename=config.get_logger(),
 level=config.get_level(),
 format=config.get_format())
+
+# Load stored ip adresses from disk to CsConfig()
 config.set_address()
 
 logging.debug("Configuring ip addresses")
-# IP configuration
 config.address().compare()
 config.address().process()
 
-logging.debug("Configuring vmpassword")
-password = CsPassword("vmpassword", config)
-password.process()
+if process_file in ["cmd_line.json", "guest_network.json"]:
+logging.debug("Configuring Guest Network")
+iptables_change = True
+
+if process_file in ["cmd_line.json", "vm_password.json"]:
+logging.debug("Configuring vmpassword")
+password = CsPassword("vmpassword", config)
+password.process()
 
-logging.debug("Configuring vmdata")
-metadata = CsVmMetadata('vmdata', config)
-metadata.process()
+if process_file in ["cmd_line.json", "vm_metadata.json"]:
+logging.debug("Configuring vmdata")
+metadata = CsVmMetadata('vmdata', config)
+metadata.process()
 
-logging.debug("Configuring networkacl")
+# Always run both CsAcl().process() methods
+# They fill the base rules in config.fw[]
 acls = CsAcl('networkacl', config)
 acls.process()
 
-logging.debug("Configuring firewall rules")
 acls = CsAcl('firewallrules', config)
 acls.process()
 
-logging.debug("Configuring PF rules")
 fwd = CsForwardingRules("forwardingrules", config)
 fwd.process()
 
-logging.debug("Configuring s2s vpn")
 vpns = CsSite2SiteVpn("site2sitevpn", config)
 vpns.process()
 
-logging.debug("Configuring remote access vpn")
-#remote access vpn
 rvpn = CsRemoteAccessVpn("remoteaccessvpn", config)
 rvpn.process()
 
-logging.debug("Configuring vpn users list")
-#remote access vpn users
-vpnuser = CsVpnUser("vpnuserlist", config)
-vpnuser.process()
-
-logging.debug("Configuring dhcp entry")
-dhcp = CsDhcp("dhcpentry", config)
-dhcp.process()
-
-logging.debug("Configuring load balancer")
 lb = CsLoadBalancer("loadbalancer", config)
 lb.process()
 
-logging.debug("Configuring monitor service")
-mon = CsMonitor("monitorservice", config)
-mon.process()
+if process_file in ["cmd_line.json", "network_acl.json"]:
+logging.debug("Configuring networkacl")
+iptables_change = True
+
+if process_file in ["cmd_line.json", "firewall_rules.json"]:
+logging.debug("Configuring firewall rules")
+iptables_change = True
+
+if process_file in ["cmd_line.json", "forwarding_rules.json", 
"staticnat_rules.json"]:
+logging.debug("Configuring PF rules")
--- End diff --

Hey @wilderrodrigues,

I understand the checks that are being made. However, I do not think it is 
appropriate to log that you are configuring PFR, after they have already been 
processed and configured. I think it can be misleading while 
debugging/searching logs. 

There are certain code paths that are executed regardless of the config 
file and they are only logged after the fact -> acls, fwd, vpns, rvpn, lb. So, 
if an error occurs in any of the functions, there are no logs to see what was 
being executed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Quota: consolidated lockable account chec...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1350#issuecomment-173218775
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Enhance VR performance

[pdube]

Github user pdube commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1346#discussion_r50259249
  
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py ---
@@ -901,79 +901,123 @@ def processStaticNatRule(self, rule):
 
 
 def main(argv):
+# The file we are currently processing, if it is "cmd_line.json" 
everything will be processed.
+process_file = argv[1]
+
+# process_file can be None, if so assume cmd_line.json
+if process_file is None:
+process_file = "cmd_line.json"
+
+# Track if changes need to be committed to NetFilter
+iptables_change = False
+
+# The "GLOBAL" Configuration object
 config = CsConfig()
+
 logging.basicConfig(filename=config.get_logger(),
 level=config.get_level(),
 format=config.get_format())
+
+# Load stored ip adresses from disk to CsConfig()
 config.set_address()
 
 logging.debug("Configuring ip addresses")
-# IP configuration
 config.address().compare()
 config.address().process()
 
-logging.debug("Configuring vmpassword")
-password = CsPassword("vmpassword", config)
-password.process()
+if process_file in ["cmd_line.json", "guest_network.json"]:
+logging.debug("Configuring Guest Network")
+iptables_change = True
+
+if process_file in ["cmd_line.json", "vm_password.json"]:
+logging.debug("Configuring vmpassword")
+password = CsPassword("vmpassword", config)
+password.process()
 
-logging.debug("Configuring vmdata")
-metadata = CsVmMetadata('vmdata', config)
-metadata.process()
+if process_file in ["cmd_line.json", "vm_metadata.json"]:
+logging.debug("Configuring vmdata")
+metadata = CsVmMetadata('vmdata', config)
+metadata.process()
 
-logging.debug("Configuring networkacl")
+# Always run both CsAcl().process() methods
+# They fill the base rules in config.fw[]
 acls = CsAcl('networkacl', config)
 acls.process()
 
-logging.debug("Configuring firewall rules")
 acls = CsAcl('firewallrules', config)
 acls.process()
 
-logging.debug("Configuring PF rules")
 fwd = CsForwardingRules("forwardingrules", config)
 fwd.process()
 
-logging.debug("Configuring s2s vpn")
 vpns = CsSite2SiteVpn("site2sitevpn", config)
 vpns.process()
 
-logging.debug("Configuring remote access vpn")
-#remote access vpn
 rvpn = CsRemoteAccessVpn("remoteaccessvpn", config)
 rvpn.process()
 
-logging.debug("Configuring vpn users list")
-#remote access vpn users
-vpnuser = CsVpnUser("vpnuserlist", config)
-vpnuser.process()
-
-logging.debug("Configuring dhcp entry")
-dhcp = CsDhcp("dhcpentry", config)
-dhcp.process()
-
-logging.debug("Configuring load balancer")
 lb = CsLoadBalancer("loadbalancer", config)
 lb.process()
 
-logging.debug("Configuring monitor service")
-mon = CsMonitor("monitorservice", config)
-mon.process()
+if process_file in ["cmd_line.json", "network_acl.json"]:
+logging.debug("Configuring networkacl")
+iptables_change = True
+
+if process_file in ["cmd_line.json", "firewall_rules.json"]:
+logging.debug("Configuring firewall rules")
+iptables_change = True
+
+if process_file in ["cmd_line.json", "forwarding_rules.json", 
"staticnat_rules.json"]:
+logging.debug("Configuring PF rules")
+iptables_change = True
+
+if process_file in ["cmd_line.json", "site_2_site_vpn.json"]:
+logging.debug("Configuring s2s vpn")
+iptables_change = True
+
+if process_file in ["cmd_line.json", "remote_access_vpn.json"]:
+logging.debug("Configuring remote access vpn")
+iptables_change = True
+
+if process_file in ["cmd_line.json", "vpn_user_list.json"]:
+logging.debug("Configuring vpn users list")
+vpnuser = CsVpnUser("vpnuserlist", config)
+vpnuser.process()
--- End diff --

Here, it is done as expected. The config file is checked, then it is 
logged, then the vpnuser.process gets executed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---