Review Request 13424: CLOUDSTACK-4123: 3.0.6 to ASF 4.2 Upgrade: On Adding VMWare Cluster to the Setup, 3.0.6 System VM Template for VMWare is downloaded instead of 4.2
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13424/ --- Review request for cloudstack and Kishan Kavala. Bugs: CLOUDSTACK-4123 Repository: cloudstack-git Description --- CLOUDSTACK-4123: 3.0.6 to ASF 4.2 Upgrade: On Adding VMWare Cluster to the Setup, 3.0.6 System VM Template for VMWare is downloaded instead of 4.2 Updating the new system template URLs for the existing templates during upgrade to 4.2. If new 4.2 system template is registered before upgrade then marking the old templates as removed during upgrade. Diffs - engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java 0941408 Diff: https://reviews.apache.org/r/13424/diff/ Testing --- Thanks, Harikrishna Patnala
Re: [Discuss] Using XenServer 6.2's Clone-on-Boot feature on CloudStack
If we can control fall back of IntelliCache reads and writes back to the storage then it won't hinder with host maintenance mode and Xenmotion, and I think it helps handling volatile VMs without recreating the root disks. Thanks, Harikrishna On 09-Aug-2013, at 11:39 AM, Prasanna Santhanam t...@apache.org wrote: On Fri, Aug 09, 2013 at 09:34:38AM +0700, Nguyen Anh Tu wrote: 2013/8/9 Chiradeep Vittal chiradeep.vit...@citrix.com I think Intellicache is different. I found a discussion here: http://s.apache.org/NIX I see no different. Maybe I didn't explain obviously. Let see it: http://speakvirtual.com/2012/02/06/intellicache-what-how-and-when/ http://blogs.citrix.com/2011/06/22/xendesktop-and-local-storage-intellicache/ It appears Intellicache hinders with putting hosts into maintenance and the recently introduced XenMotion: https://cwiki.apache.org/confluence/x/TiTVAQ feature in cloudstack -- Prasanna., Powered by BigRock.com
Re: Review Request 13424: CLOUDSTACK-4123: 3.0.6 to ASF 4.2 Upgrade: On Adding VMWare Cluster to the Setup, 3.0.6 System VM Template for VMWare is downloaded instead of 4.2
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13424/ --- (Updated Aug. 9, 2013, 11:50 a.m.) Review request for cloudstack and Kishan Kavala. Bugs: CLOUDSTACK-4123 and CLOUDSTACK-4205 Repository: cloudstack-git Description (updated) --- CLOUDSTACK-4123: 3.0.6 to ASF 4.2 Upgrade: On Adding VMWare Cluster to the Setup, 3.0.6 System VM Template for VMWare is downloaded instead of 4.2 Updating the new system template URLs for the existing templates during upgrade to 4.2. If new 4.2 system template is registered before upgrade then marking the old templates as removed during upgrade. CLOUDSTACK-4205: System VMs are not booting up with new templates after Upgrade from 3.0.6 to 4.2. Diffs (updated) - engine/schema/src/com/cloud/storage/dao/VMTemplateDaoImpl.java 9243225 engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java 0941408 server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java a583954 server/src/com/cloud/resource/ResourceManagerImpl.java e5441af server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java 17cbf5c Diff: https://reviews.apache.org/r/13424/diff/ Testing --- Thanks, Harikrishna Patnala
Review Request 13441: CLOUDSTACK-3850: CPU cap should be per VM not per VCPU
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13441/ --- Review request for cloudstack and Koushik Das. Bugs: CLOUDSTACK-3850 Repository: cloudstack-git Description --- CLOUDSTACK-3850: CPU cap should be per VM not per VCPU Diffs - plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java e100211 plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java d230be1 Diff: https://reviews.apache.org/r/13441/diff/ Testing --- Thanks, Harikrishna Patnala
Re: Review Request 13424: CLOUDSTACK-4123: 3.0.6 to ASF 4.2 Upgrade: On Adding VMWare Cluster to the Setup, 3.0.6 System VM Template for VMWare is downloaded instead of 4.2
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13424/ --- (Updated Aug. 10, 2013, 10:16 a.m.) Review request for cloudstack and Kishan Kavala. Changes --- Updated patch after rebasing Bugs: CLOUDSTACK-4123 and CLOUDSTACK-4205 Repository: cloudstack-git Description --- CLOUDSTACK-4123: 3.0.6 to ASF 4.2 Upgrade: On Adding VMWare Cluster to the Setup, 3.0.6 System VM Template for VMWare is downloaded instead of 4.2 Updating the new system template URLs for the existing templates during upgrade to 4.2. If new 4.2 system template is registered before upgrade then marking the old templates as removed during upgrade. CLOUDSTACK-4205: System VMs are not booting up with new templates after Upgrade from 3.0.6 to 4.2. Diffs (updated) - engine/schema/src/com/cloud/storage/dao/VMTemplateDaoImpl.java 9243225 engine/schema/src/com/cloud/upgrade/dao/Upgrade412to420.java d703cc3 server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java a583954 server/src/com/cloud/resource/ResourceManagerImpl.java e5441af server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java 17cbf5c Diff: https://reviews.apache.org/r/13424/diff/ Testing --- Thanks, Harikrishna Patnala
Review Request 13468: CLOUDSTACK-3228: system vms are not comming up in zone with two cluster xen and kvm; Zone host is ready, but secondary storage vm template: 3 is not ready on secondary storage: 2
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13468/ --- Review request for cloudstack and Nitin Mehta. Bugs: CLOUDSTACK-3228 Repository: cloudstack-git Description --- CLOUDSTACK-3228: system vms are not comming up in zone with two cluster xen and kvm;Zone host is ready, but secondary storage vm template: 3 is not ready on secondary storage: 2 Diffs - server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java c5faccb server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java d1c148b Diff: https://reviews.apache.org/r/13468/diff/ Testing --- Tested the scenario mentioned in the bug ticket Thanks, Harikrishna Patnala
Re: Review Request 13441: CLOUDSTACK-3850: CPU cap should be per VM not per VCPU
On Aug. 10, 2013, 1:11 p.m., Koushik Das wrote: plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java, line 663 https://reviews.apache.org/r/13441/diff/1/?file=339183#file339183line663 CPU weight computation is not considering the number of CPUs in the VM but utilization is considering it. Shouldn't both follow the same logic? If not can you explain the logic and put a comment in the code for the same. Also what is logic for multiplying the speed with 0.99? This is as per the design of xenserver. CPU weight is calculated per VCPU. So whatever the weight we assign Xenserver allocates to each VCPU and cpu cap is per VM. Please refer For CPU Weight: http://blog.xen.org/index.php/2010/08/13/rfc-credit1-make-weight-per-vcpu/ For CPU cap: http://mail-archives.apache.org/mod_mbox/incubator-cloudstack-dev/201206.mbox/%3cb1df26ecc0458748ac97cece2da98d41012f9d61a...@sjcpmailbox01.citrite.net%3E Multiplication with 0.99 is what we follow during vm deployment may be for some overhead calculations, So It should be the same during scale vm also. - Harikrishna --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13441/#review24968 --- On Aug. 9, 2013, 1 p.m., Harikrishna Patnala wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13441/ --- (Updated Aug. 9, 2013, 1 p.m.) Review request for cloudstack and Koushik Das. Bugs: CLOUDSTACK-3850 Repository: cloudstack-git Description --- CLOUDSTACK-3850: CPU cap should be per VM not per VCPU Diffs - plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java e100211 plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java d230be1 Diff: https://reviews.apache.org/r/13441/diff/ Testing --- Thanks, Harikrishna Patnala
Re: Review Request 13441: CLOUDSTACK-3850: CPU cap should be per VM not per VCPU
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13441/ --- (Updated Aug. 10, 2013, 7:08 p.m.) Review request for cloudstack and Koushik Das. Changes --- updated patch.(added comments) Bugs: CLOUDSTACK-3850 Repository: cloudstack-git Description --- CLOUDSTACK-3850: CPU cap should be per VM not per VCPU Diffs (updated) - plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java e100211 plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java d230be1 Diff: https://reviews.apache.org/r/13441/diff/ Testing --- Thanks, Harikrishna Patnala
Re: db exception?
Please check you cluster_details table for memory and cpu overcommit values. This statement expects to have these details in cluster_details table. -Harikrishna On 11-Aug-2013, at 4:45 AM, Pedro Roque Marques pedro.r.marq...@gmail.com wrote: I've bumped into exceptions with similar signature in the past when the database schema has not been updated to match the Dao objects. Check whether the cloud.cluster database has all the fields listed in the select statement displayed in the exception. Pedro. On Aug 10, 2013, at 3:03 PM, Vijayendra Bhamidipati wrote: On a fresh nonoss dev setup of the latest 4.2 branch, I'm running into this DB exception when the SSVM is being started upon enabling a zone: INFO [storage.endpoint.DefaultEndPointSelector] (StatsCollector-2:) No running ssvm is found, so command will be sent to LocalHostEndPoint INFO [cloud.secstorage.PremiumSecondaryStorageManagerImpl] (secstorage-1:) No running secondary storage vms found in datacenter id=1, starting one INFO [storage.secondary.SecondaryStorageManagerImpl] (secstorage-1:) No stopped secondary storage vm is available, need to allocate a new secondary storage vm WARN [storage.secondary.SecondaryStorageManagerImpl] (secstorage-1:) Exception while trying to start secondary storage vm com.cloud.utils.exception.CloudRuntimeException: DB Exception on: SELECT clusterList.cluster_id FROM ( SELECT cluster.cluster_id cluster_id, ( (sum(cluster.used) + sum(cluster.reserved) + ?)/sum(cluster.total) ) ratio, cluster.configValue value FROM (SELECT capacity.cluster_id cluster_id, capacity.used_capacity used, capacity.reserved_capacity reserved, capacity.total_capacity * overcommit.value total, CASE (SELECT count(*) FROM `cloud`.`cluster_details` details WHERE details.cluster_id = capacity.cluster_id AND details.name = ? ) WHEN 1 THEN ( CASE WHEN (SELECT details.value FROM `cloud`.`cluster_details` details WHERE details.cluster_id = capacity.cluster_id AND details.name = ?) is NULL THEN (SELECT config.value FROM `cloud`.`configuration` config WHERE config.name = ?)ELSE (SELECT details.value FROM `cloud`.`cluster_details` details WHERE details.cluster_id = capacity.cluster_id AND details.name = ? ) END )ELSE ( SELECT config.value FROM `cloud`.`configuration` config WHERE config.name = ?) END configValue FROM `cloud`.`op_host_capacity` capacity INNER JOIN `cloud`.`cluster_details` overcommit ON overcommit.cluster_id = capacity.cluster_id WHERE capacity.data_center_id = ? AND capacity.capacity_type = ? AND capacity.total_capacity 0 AND overcommit.name = ?) cluster GROUP BY cluster.cluster_id) clusterList WHERE clusterList.ratio clusterList.value; at com.cloud.capacity.dao.CapacityDaoImpl.listClustersCrossingThreshold(CapacityDaoImpl.java:217) at com.cloud.utils.component.ComponentInstantiationPostProcessor$InterceptorDispatcher.intercept(ComponentInstantiationPostProcessor.java:125) at com.cloud.deploy.FirstFitPlanner.removeClustersCrossingThreshold(FirstFitPlanner.java:284) at com.cloud.deploy.FirstFitPlanner.scanClustersForDestinationInZoneOrPod(FirstFitPlanner.java:339) at com.cloud.deploy.FirstFitPlanner.orderClusters(FirstFitPlanner.java:175) at com.cloud.deploy.DeploymentPlanningManagerImpl.planDeployment(DeploymentPlanningManagerImpl.java:405) at com.cloud.vm.VirtualMachineManagerImpl.advanceStart(VirtualMachineManagerImpl.java:822) at com.cloud.vm.VirtualMachineManagerImpl.start(VirtualMachineManagerImpl.java:574) at com.cloud.vm.VirtualMachineManagerImpl.start(VirtualMachineManagerImpl.java:567) at com.cloud.storage.secondary.SecondaryStorageManagerImpl.startSecStorageVm(SecondaryStorageManagerImpl.java:268) at com.cloud.storage.secondary.SecondaryStorageManagerImpl.allocCapacity(SecondaryStorageManagerImpl.java:693) at com.cloud.storage.secondary.SecondaryStorageManagerImpl.expandPool(SecondaryStorageManagerImpl.java:1300) at com.cloud.secstorage.PremiumSecondaryStorageManagerImpl.scanPool(PremiumSecondaryStorageManagerImpl.java:123) at com.cloud.secstorage.PremiumSecondaryStorageManagerImpl.scanPool(PremiumSecondaryStorageManagerImpl.java:50) at com.cloud.vm.SystemVmLoadScanner.loadScan(SystemVmLoadScanner.java:104) at com.cloud.vm.SystemVmLoadScanner.access$100(SystemVmLoadScanner.java:33) at com.cloud.vm.SystemVmLoadScanner$1.reallyRun(SystemVmLoadScanner.java:81) at com.cloud.vm.SystemVmLoadScanner$1.run(SystemVmLoadScanner.java:72) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471) at java.util.concurrent.FutureTask$Sync.innerRunAndReset(FutureTask.java:351) at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:178) at
Re: [ANNOUNCE] New Committer: Vijay Bhamidipati
Congratulations -Harikrishna On 11-Aug-2013, at 12:55 PM, Abhinav Roy abhinav@citrix.com wrote: Congrats Vijay. Regards, Abhinav -Original Message- From: Sanjay Tripathi [mailto:sanjay.tripa...@citrix.com] Sent: Sunday, August 11, 2013 12:53 PM To: dev@cloudstack.apache.org Subject: RE: [ANNOUNCE] New Committer: Vijay Bhamidipati Congratulations Vijay! --Sanjay -Original Message- From: Prasanna Santhanam [mailto:t...@apache.org] Sent: Saturday, August 10, 2013 10:31 AM To: CloudStack Dev Subject: [ANNOUNCE] New Committer: Vijay Bhamidipati The Project Management Committee (PMC) for Apache CloudStack has asked Vijay Bhamidipati to become a committer and we are pleased to announce that they have accepted. Being a committer allows many contributors to contribute more autonomously. For developers, it makes it easier to submit changes and eliminates the need to have contributions reviewed via the patch submission process. Whether contributions are development-related or otherwise, it is a recognition of a contributor's participation in the project and commitment to the project and the Apache Way. Please join me in congratulating Vijay! -- Prasanna., on behalf of the Apache CloudStack PMC Powered by BigRock.com
Re: [ACS42] Listtemplates API respone without any Zone configuration
We mark all the system and default templates as downloaded and during template
sync we remove the template entries that are not there.
I guess this we have introduced recently, this may cause listing all the
templates.
Thanks
Harikrishna
On 12-Aug-2013, at 1:46 PM, Sailaja Mada sailaja.m...@citrix.com
wrote:
Hi,
I have the setup with latest code. When I tried to view the list if
templates without configuring zone , it is listing all the system vm
templates and default cent OS templates .
I have not observed this behavior before. Is it introduced intentionally or
is It a issue with API response ?
Please confirm.
2013-08-12 13:18:53,916 INFO [cloud.api.ApiServer] (catalina-exec-3:null)
(userId=2 accountId=2 sessionId=2C596448B0E7D3291B7FA76334A085A7) 10.144.7.12
-- GET
command=listTemplatesresponse=jsonsessionkey=wMUCQaSUAhWg4JmNNXrmhPGIOzc%3DlistAll=truepage=1pagesize=20templatefilter=all_=1376293976571
200 { listtemplatesresponse : { count:8 ,template : [
{id:4b58341c-031a-11e3-b7b2-5641688b41e2,name:SystemVM Template
(LXC),displaytext:SystemVM Template
(LXC),ispublic:false,isready:false,passwordenabled:false,format:QCOW2,isfeatured:false,crossZones:true,ostypeid:ecbdeaba-0318-11e3-b7b2-5641688b41e2,ostypename:Debian
GNU/Linux 5.0
(32-bit),account:system,templatetype:SYSTEM,hypervisor:LXC,domain:ROOT,domainid:ec8ad800-0318-11e3-b7b2-5641688b41e2,isextractable:false,checksum:2755de1f9ef2ce4d6f2bee2efbb4da92,tags:[],sshkeyenabled:false,isdynamicallyscalable:false},
{id:ec8e64b6-0318-11e3-b7b2-5641688b41e2,name:SystemVM Template
(XenServer),displaytext:SystemVM Template
(XenServer),ispublic:false,isready:false,passwordenabled:false,format:VHD,isfeatured:false,crossZones:true,ostypeid:ed81a824-0318-11e3-b7b2-5641688b41e2,ostypename:Debian
GNU/Linux
7(32-bit),account:system,templatetype:SYSTEM,hypervisor:XenServer,domain:ROOT,domainid:ec8ad800-0318-11e3-b7b2-5641688b41e2,isextractable:false,checksum:74b92f031cc5c2089ee89efb81344dcf,tags:[],sshkeyenabled:false,isdynamicallyscalable:false},
{id:ec98be84-0318-11e3-b7b2-5641688b41e2,name:SystemVM Template
(HyperV),displaytext:SystemVM Template
(HyperV),ispublic:false,isready:false,passwordenabled:false,format:VHD,isfeatured:false,crossZones:true,ostypeid:ecbdeaba-0318-11e3-b7b2-5641688b41e2,ostypename:Debian
GNU/Linux 5.0
(32-bit),account:system,templatetype:SYSTEM,hypervisor:Hyperv,domain:ROOT,domainid:ec8ad800-0318-11e3-b7b2-5641688b41e2,isextractable:false,checksum:fb1b6e032a160d86f2c28feb5add6d83,tags:[],sshkeyenabled:false,isdynamicallyscalable:false},
{id:ec931e0c-0318-11e3-b7b2-5641688b41e2,name:SystemVM Template
(KVM),displaytext:SystemVM Template
(KVM),ispublic:false,isready:false,passwordenabled:false,format:QCOW2,isfeatured:false,crossZones:true,ostypeid:ecbdeaba-0318-11e3-b7b2-5641688b41e2,ostypename:Debian
GNU/Linux 5.0
(32-bit),account:system,templatetype:SYSTEM,hypervisor:KVM,domain:ROOT,domainid:ec8ad800-0318-11e3-b7b2-5641688b41e2,isextractable:false,checksum:6cea42b2633841648040becb588bd8f0,tags:[],sshkeyenabled:false,isdynamicallyscalable:false},
{id:ec95eaf6-0318-11e3-b7b2-5641688b41e2,name:SystemVM Template
(vSphere),displaytext:SystemVM Template
(vSphere),ispublic:false,isready:false,passwordenabled:false,format:OVA,isfeatured:false,crossZones:true,ostypeid:ecbdeaba-0318-11e3-b7b2-5641688b41e2,ostypename:Debian
GNU/Linux 5.0
(32-bit),account:system,templatetype:SYSTEM,hypervisor:VMware,domain:ROOT,domainid:ec8ad800-0318-11e3-b7b2-5641688b41e2,isextractable:false,checksum:8fde62b1089e5844a9cd3b9b953f9596,tags:[],sshkeyenabled:false,isdynamicallyscalable:true},
{id:ec947a86-0318-11e3-b7b2-5641688b41e2,name:CentOS 5.6(64-bit) no
GUI (XenServer),displaytext:CentOS 5.6(64-bit) no GUI
(XenServer),ispublic:true,isready:false,passwordenabled:false,format:VHD,isfeatured:true,crossZones:true,ostypeid:ecbc066e-0318-11e3-b7b2-5641688b41e2,ostypename:CentOS
5.3
(64-bit),account:system,templatetype:BUILTIN,hypervisor:XenServer,domain:ROOT,domainid:ec8ad800-0318-11e3-b7b2-5641688b41e2,isextractable:true,checksum:905cec879afd9c9d22ecc8036131a180,tags:[],sshkeyenabled:false,isdynamicallyscalable:true},
{id:ec95326e-0318-11e3-b7b2-5641688b41e2,name:CentOS 5.3(64-bit) no
GUI (vSphere),displaytext:CentOS 5.3(64-bit) no GUI
(vSphere),ispublic:true,isready:false,passwordenabled:false,format:OVA,isfeatured:true,crossZones:true,ostypeid:ecbc066e-0318-11e3-b7b2-5641688b41e2,ostypename:CentOS
5.3
(64-bit),account:system,templatetype:BUILTIN,hypervisor:VMware,domain:ROOT,domainid:ec8ad800-0318-11e3-b7b2-5641688b41e2,isextractable:true,checksum:f6f881b7f2292948d8494db837fe0f47,tags:[],sshkeyenabled:false,isdynamicallyscalable:false},
{id:ec93cb72-0318-11e3-b7b2-5641688b41e2,name:CentOS 5.5(64-bit) no
GUI (KVM),displaytext:CentOS 5.5(64-bit) no GUI
Review Request 13525: CLOUDSTACK-4271: ASF 4.1 to 4.2 Upgrade: Missing Global Configuration parameter vmware.nested.virtualization on the Upgraded Setup.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13525/ --- Review request for cloudstack and Nitin Mehta. Bugs: CLOUDSTACK-4271 Repository: cloudstack-git Description --- CLOUDSTACK-4271: ASF 4.1 to 4.2 Upgrade: Missing Global Configuration parameter vmware.nested.virtualization on the Upgraded Setup. Diffs - setup/db/db/schema-412to420.sql 3b613a2 Diff: https://reviews.apache.org/r/13525/diff/ Testing --- Thanks, Harikrishna Patnala
Re: [ACS42]Regarding Scaleup ( CPU/Memory )
Yes. we need to the improve the error message. Previously it was put to say any resource value should not less than the old value. On 14-Aug-2013, at 12:13 PM, Sailaja Mada sailaja.m...@citrix.com wrote: Hi, I am trying to scale up my VM memory from 512 MB to 1024 MB. It does not allow me to update service offering saying Only scaling up the vm is supported, new service offering should have both cpu and memory greater than the old values I wanted to increase only Memory and not CPU. Why are we mandating to have both resources values to be higher ? I tried from VMWARE , It does allow me to increase each resource separately. I think it's a issue to be handled from Cloudstack. Please correct me If not. Thanks, Sailaja.M
Re: [ACS42]Regarding Scaleup ( CPU/Memory )
Created a ticket for tracking https://issues.apache.org/jira/browse/CLOUDSTACK-4313 On 14-Aug-2013, at 12:37 PM, Harikrishna Patnala harikrishna.patn...@citrix.com wrote: Yes. we need to the improve the error message. Previously it was put to say any resource value should not less than the old value. On 14-Aug-2013, at 12:13 PM, Sailaja Mada sailaja.m...@citrix.com wrote: Hi, I am trying to scale up my VM memory from 512 MB to 1024 MB. It does not allow me to update service offering saying Only scaling up the vm is supported, new service offering should have both cpu and memory greater than the old values I wanted to increase only Memory and not CPU. Why are we mandating to have both resources values to be higher ? I tried from VMWARE , It does allow me to increase each resource separately. I think it's a issue to be handled from Cloudstack. Please correct me If not. Thanks, Sailaja.M
Re: [Doc] Please review: VM root disk reset on reboot doc
Thank you Jessica, doc looks good for me. -Harikrishna On 15-Aug-2013, at 8:54 AM, Jessica Tomechak jessica.tomec...@gmail.commailto:jessica.tomec...@gmail.com wrote: Since no comments have been made against this doc, I am resolving the bug. Jessica T. On Thu, Aug 8, 2013 at 11:16 PM, Jessica Tomechak jessica.tomec...@gmail.commailto:jessica.tomec...@gmail.com wrote: Hi, New doc on resetting VM on reboot is ready for review. You can view the updated text at the link below. This is checked in to both master and 4.2 branch. Please provide your feedback. Diff: https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=26f1eab323672d54f2a7dfa5da89c779c9d8f5c2 Bug: https://issues.apache.org/jira/browse/CLOUDSTACK-1682 Regards, Jessica T.
Re: [Doc] Developer Guide API Section for Review
Hi Radhika, Thank you for the doc. Some changes are required, 1) updateCluster: The following request parameters are added: cpuovercommitratio, ramovercommitratio - These parameters are removed from the updateCluster API. Please remove from the doc as well. - Same doc entry exists in Page 24 and 29. please remove from both pages 2) addCluster: - cpuovercommitratio, ramovercommitratio parameters are removed from the API, need to remove from the doc also 3) scaleSystemVm: Scales the service offering for a systemVM, console proxy, or secondary storage. The system VM must be in Stopped state for this command to take effect. - System vm need not be in stopped state. works for both stopped vm and running vm. 4) restoreVirtualMachine: - please add this line. The parameter templateId can be an ISO id in case of restore vm deployed using ISO Please make these changes. Thankyou -Harikrishna On 05-Aug-2013, at 11:44 AM, Radhika Puthiyetath radhika.puthiyet...@citrix.commailto:radhika.puthiyet...@citrix.com wrote: Hi, Developer Guide API section is ready for review. The doc is attached at https://issues.apache.org/jira/browse/CLOUDSTACK-3546 Please see section4.1. What's New in the API for 4.2, and provide your feedback. Also, please let me know other than the API changes what you think what should be covered in the What's New Section. Regards -Radhika
Review Request 13682: CLOUDSTACK-2247: Automation - Reset a VM on Reboot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13682/ --- Review request for cloudstack and Prasanna Santhanam. Bugs: CLOUDSTACK-2247 Repository: cloudstack-git Description --- CLOUDSTACK-2247: Automation - Reset a VM on Reboot Created a vm with service offering (marked as volatile) and rebooted it. Checking if the volumes are different before and after reboot. Diffs - test/integration/smoke/test_reset_vm_on_reboot.py PRE-CREATION Diff: https://reviews.apache.org/r/13682/diff/ Testing --- Thanks, Harikrishna Patnala
Re: registerSSHKeyPair
Hi, RegisterSSHKey API is used when we have SSH key pair and if we want to register that key pair in Cloudstack. So when we provide public key it just calculates fingerprint and registers the SSH key pair. CS doesn't know about private key. It just returns null as private key. Our doc is showing private key because we include that in SSHKeyPairResponse object. -Harikrishna On 22-Aug-2013, at 2:21 PM, Sebastien Goasguen run...@gmail.com wrote: Hi folks, I am troubled by: http://cloudstack.apache.org/docs/api/apidocs-4.1/user/registerSSHKeyPair.html It says that it returns the private key . This can't be right. I tried it with cloudmonkey and it does not return the private key (does not know it..) Unless I am missing something with what this api is supposed to do, I will file an apidoc bug. -Sebastien
Re: System VMs not running
Please follow the link to seed the system template
http://cloudstack.apache.org/docs/en-US/Apache_CloudStack/4.1.1/html/Installation_Guide/management-server-install-flow.html#prepare-system-vm-template
-Harikrishna
On 22-Aug-2013, at 5:08 PM, Amit Das amit@cloudbyte.com
wrote:
Hi,
I have not seeded the secondary storage with system vm template.
The directory ../template/tmpl/1/1 is not present.
Regards,
Amit
*CloudByte Inc.* http://www.cloudbyte.com/
On Thu, Aug 22, 2013 at 4:58 PM, Devdeep Singh
devdeep.si...@citrix.comwrote:
Did you seed the secondary storage with the systemvm template before
starting the setup? If not, can you check if under your secondary storage
the ../template/tmpl/1/1 directory is present?
Regards,
Devdeep
-Original Message-
From: Amit Das [mailto:amit@cloudbyte.com]
Sent: Thursday, August 22, 2013 4:50 PM
To: dev@cloudstack.apache.org
Subject: System VMs not running
Hi folks,
I am running CloudStack 4.1.1. running the NFS share on the same box as
CloudStack management server (CentOS 6). The hypervisor is a separate Xen
server.
I am not able to get the system vms in a running state.
We had not downloaded the vhd-util initially but it has been downloaded
now.
The management server has been restarted appropriate rpcbind, nfs
services started. The configuration was redone from scratch. However, we
are
stuck with below error always.
com.cloud.utils.exception.CloudRuntimeException: can't mount
10.10.171.155:/export/secondary/template/tmpl/1/1
to /var/run/cloud_mount/2cc7d1a3-130b-4ae9-9381-5f8ec6bf751a at
com.cloud.hypervisor.xen.resource.CitrixResourceBase.
copy_vhd_from_secondarystorage(CitrixResourceBase.java:2707)
..
2013-08-22 16:30:52,866 DEBUG [agent.transport.Request] (secstorage-
1:null) Seq 12-749863191: Executing: { Cmd , MgmtId: 268749071320359,
via: 12,
Ver: v1, Flags: 100111, [{storage.*PrimaryStorageDownloadCommand*
:{localPath:/mnt/15370e0e-c8ae-32bb-94e1-
74f1fad0cce3,poolUuid:15370e0e-c8ae-32bb-94e1-
74f1fad0cce3,poolId:211,primaryPool:{id:211,uuid:15370e0e-c8ae-
32bb-94e1-
74f1fad0cce3,host:10.10.171.155,path:/export/primary,port:2049,
type:NetworkFilesystem},secondaryStorageUrl:nfs://
10.10.171.155/export/secondary,primaryStorageUrl:nfs://
10.10.171.155/export/primary,url:nfs://
10.10.171.155/export/secondary/template/tmpl/1/1/,format:VHD,acco
untId:1,name:routing-1,wait:10800}}]
}
..
2013-08-22 16:30:55,128 DEBUG [agent.transport.Request]
(DirectAgent-244:null) Seq 12-749863191: Processing: { Ans: , MgmtId:
268749071320359, via: 12, Ver: v1, Flags: 110, [{storage.*
PrimaryStorageDownloadAnswer*:{templateSize:0,result:false,details:
Catch
Exception com.cloud.utils.exception.CloudRuntimeException on
host:21318624-cfd9-412d-aeb4-b1418424f287 for template: nfs://
10.10.171.155/export/secondary/template/tmpl/1/1/ due to
com.cloud.utils.exception.CloudRuntimeException: can't mount
10.10.171.155:/export/secondary/template/tmpl/1/1
to /var/run/cloud_mount/60e04e29-8064-4a3f-90c2-
b1e639b9b05a,wait:0}}] }
Regards,
Amit
*CloudByte Inc.* http://www.cloudbyte.com/
Re: registerSSHKeyPair
We generate docs based on the response object. Since we use the same response object for create/register ssh key pair APIs, doc shows same return values. We follow this for all API responses. Say list virtual machine API response does not include all the fields that are in api doc. -Harikrishna On 22-Aug-2013, at 4:34 PM, Sebastien Goasguen run...@gmail.com wrote: it's not returned at all.. so even if it's stored as null in the db, the apidoc should not say it returns 'privatkey' thoughts ? On Aug 22, 2013, at 5:31 AM, Wei ZHOU ustcweiz...@gmail.com wrote: *privatekey is set to null if registerSSHKeyPair * 2013/8/22 Sebastien Goasguen run...@gmail.com Hi folks, I am troubled by: http://cloudstack.apache.org/docs/api/apidocs-4.1/user/registerSSHKeyPair.html It says that it returns the private key . This can't be right. I tried it with cloudmonkey and it does not return the private key (does not know it..) Unless I am missing something with what this api is supposed to do, I will file an apidoc bug. -Sebastien
Re: registerSSHKeyPair
I have created a bug ticket for tracking https://issues.apache.org/jira/browse/CLOUDSTACK-4493 and this needs to be resolved. -Harikrishna On 23-Aug-2013, at 6:41 PM, Chip Childers chip.child...@sungard.com wrote: On Thu, Aug 22, 2013 at 08:33:42AM -0400, Sebastien Goasguen wrote: On Aug 22, 2013, at 7:57 AM, Harikrishna Patnala harikrishna.patn...@citrix.com wrote: We generate docs based on the response object. Since we use the same response object for create/register ssh key pair APIs, doc shows same return values. We follow this for all API responses. Say list virtual machine API response does not include all the fields that are in api doc. I understand, but that's a case where it's misleading. Maybe the response objects should not be the same after all. +1 - this is another example of where the CS API leaks implementation details all over the place, in this case manifested as a documentation issue.
Review Request 13842: CLOUDSTACK-4482: getVMPassword() API call does not return password for Vms that are deployed with password enabled templates.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13842/ --- Review request for cloudstack and Koushik Das. Bugs: CLOUDSTACK-4482 Repository: cloudstack-git Description --- CLOUDSTACK-4482: getVMPassword() API call does not return password for Vms that are deployed with password enabled templates. Improving the error message saying no ssh key pair is assinged to VM to get the encrypted password and included a check for password enabled template Diffs - server/src/com/cloud/server/ManagementServerImpl.java d1e4e5f Diff: https://reviews.apache.org/r/13842/diff/ Testing --- Thanks, Harikrishna Patnala
Re: Review Request 13842: CLOUDSTACK-4482: getVMPassword() API call does not return password for Vms that are deployed with password enabled templates.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13842/ --- (Updated Aug. 27, 2013, 6:20 a.m.) Review request for cloudstack, Abhinandan Prateek and Koushik Das. Bugs: CLOUDSTACK-4482 Repository: cloudstack-git Description --- CLOUDSTACK-4482: getVMPassword() API call does not return password for Vms that are deployed with password enabled templates. Improving the error message saying no ssh key pair is assinged to VM to get the encrypted password and included a check for password enabled template Diffs - server/src/com/cloud/server/ManagementServerImpl.java d1e4e5f Diff: https://reviews.apache.org/r/13842/diff/ Testing --- Thanks, Harikrishna Patnala
Re: Review Request 13842: CLOUDSTACK-4482: getVMPassword() API call does not return password for Vms that are deployed with password enabled templates.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13842/ --- (Updated Aug. 27, 2013, 10:51 a.m.) Review request for cloudstack, Abhinandan Prateek and Koushik Das. Bugs: CLOUDSTACK-4482 Repository: cloudstack-git Description (updated) --- CLOUDSTACK-4482: getVMPassword() API call does not return password for Vms that are deployed with password enabled templates. Improving the error message saying ssh key pair should be assinged to VM to get the encrypted password. Diffs - server/src/com/cloud/server/ManagementServerImpl.java d1e4e5f Diff: https://reviews.apache.org/r/13842/diff/ Testing --- Thanks, Harikrishna Patnala
Re: Review Request 13842: CLOUDSTACK-4482: getVMPassword() API call does not return password for Vms that are deployed with password enabled templates.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13842/ --- (Updated Aug. 27, 2013, 10:53 a.m.) Review request for cloudstack, Abhinandan Prateek and Koushik Das. Bugs: CLOUDSTACK-4482 Repository: cloudstack-git Description --- CLOUDSTACK-4482: getVMPassword() API call does not return password for Vms that are deployed with password enabled templates. Improving the error message saying ssh key pair should be assinged to VM to get the encrypted password. Diffs (updated) - server/src/com/cloud/server/ManagementServerImpl.java d1e4e5f Diff: https://reviews.apache.org/r/13842/diff/ Testing --- Thanks, Harikrishna Patnala
Re: Review Request 12545: CLOUDSTACK-1800: Add automation tests for reset sshkey to access VM
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12545/#review25616 --- Hi Girish Shilamkar, Apologies for late review. Some changes needs to be taken care of. 1) I think we do not have service like SSHKey to get the sshkey enabled template. We need to create a vm, put the ssh/password scripts accordingly in the VM, create template from that VM and then use this template for our tests. You can refer to marvin test in test_vm_passwdenabled.py 2) We have 10 tests in this file and each test tries to create separate account, networks, router vms and guest vms. Could you please try clubbing the resources in the tests that use common resources. - Harikrishna Patnala On Aug. 13, 2013, 7:41 a.m., Girish Shilamkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12545/ --- (Updated Aug. 13, 2013, 7:41 a.m.) Review request for cloudstack, Harikrishna Patnala and Prasanna Santhanam. Bugs: CLOUDSTACK-1800 Repository: cloudstack-git Description --- CLOUDSTACK-1800: Add automation tests for reset sshkey to access VM Diffs - test/integration/component/test_reset_ssh_keypair.py PRE-CREATION Diff: https://reviews.apache.org/r/12545/diff/ Testing --- Thanks, Girish Shilamkar
Re: [Doc] Please review: Granular configuration parameters doc
Thank you Likitha for the doc. Some text need to be added. 1) There is no need of restarting the management server after setting the local configuration parameters. 2) If we set value 'null' in the local configuration then CS considers the value from global configuration. Could you please make these changes. Thanks Harikrishna On 29-Aug-2013, at 9:58 AM, Likitha Shetty likitha.she...@citrix.com wrote: +Harikrishna -Original Message- From: Jessica Tomechak [mailto:jessica.tomec...@gmail.com] Sent: Thursday, August 29, 2013 12:00 AM To: dev@cloudstack.apache.org Cc: us...@cloudstack.apache.org; Sudha Ponnaganti; Likitha Shetty Subject: [Doc] Please review: Granular configuration parameters doc Hi, Documentation on granular configuration parameters is ready for review. You can view the updated text at the link below. This is checked in to both master and 4.2-forward. Please provide your feedback. Diff: https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=bdc87ab Bug: https://issues.apache.org/jira/browse/CLOUDSTACK-2289 Regards, Jessica T.
Wiki on Adding config parameters at different scopes
Hi all, As we know we have now the configuration parameters at different scopes (account, zone, cluster, or primary storage). https://issues.apache.org/jira/browse/CLOUDSTACK-741 I have prepared a wiki on how to use and add configuration parameters at different scopes. LINK: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Adding+a+global+config+-+configurable+at+different+scopes Please follow the wiki on this. Thanks and regards, Harikrishna
Re: cpvm and ssvm but no host entries
Seems like in both the cases agent is not up. please try troubleshooting SSVM https://cwiki.apache.org/CLOUDSTACK/ssvm-templates-secondary-storage-troubleshooting.html -Harikrishna On 05-Sep-2013, at 8:13 AM, Mike Tutkowski mike.tutkow...@solidfire.com wrote: I've been trying to set up a CS env without devcloud, as well, with 4.2 recently and having trouble. I notice my system VMs come up, but - in the CSMS console - it continues to say SSVM is not running. When I look at them in the GUI, they show as Up, but the Agent Status is just a hyphen. On Wed, Sep 4, 2013 at 7:46 PM, Travis Graham tgra...@tgraham.us wrote: That is weird, do you have entries for them in the console_proxy and secondary_storage_vm tables? Have you tried to destroy them and let the Management server recreate them to see if that creates the entry in the hosts table? Travis On Sep 4, 2013, at 7:38 PM, Darren Shepherd darren.s.sheph...@gmail.com wrote: So I'm trying to setup a cloudstack environment from scratch. Not a devcloud environment, but more like a production setup. Anyhow, so I managed to get the cpvm and ssvm running, but there is no host entry for them. Is that supposed to happen? Darren -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloudhttp://solidfire.com/solution/overview/?video=play *™*
Re: Question about CentOS 5.5(64-bit) no GUI (KVM)
Hi, Have you set the global parameter secstorage.allowed.internal.sites ? On 11-Sep-2013, at 10:34 AM, Mike Tutkowski mike.tutkow...@solidfire.com wrote: Hi, I'm new to using KVM with CS. I noticed under Templates there is CentOS 5.5(64-bit) no GUI (KVM). When I drill down to look at its details, it says it is built in and not ready. Any advice on how I can make it ready? Thanks! -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloudhttp://solidfire.com/solution/overview/?video=play *™*
Re: Creating an instance with ssh key pair
SSH script pulls only the ssh public key that is associated with the vm instance. There is an API to reset the SSH key pair associated to the VM. This is will associate new ssh key pair to the vm and on reboot of vm this ssh script gets the new ssh public key into the VM. If you can modify the ssh script in the vm to append the new ssh public key to the authorised_keys file we can use both old and new ssh key pair. -Harikrishna On 12-Sep-2013, at 9:35 PM, Travis Graham tgra...@tgraham.us wrote: Will this only pull down one key pair or can it pull down many? We have a need to pull in our keys as well as all of our customers keys. If the script can only pull down one, we can make it work, but would be nice to pull down all keys from the project an instance is associated with. Travis On Sep 12, 2013, at 11:55 AM, Sangeetha Hariharan sangeetha.hariha...@citrix.com wrote: To deploy Vm using ssh key pairs you will need to use a template that has SSH Key Gen Scripts in it. Only then you will be able to ssh into the instance using ssh key. -Thanks Sangeetha -Original Message- From: Gaurav Aradhye [mailto:gaurav.arad...@clogeny.com] Sent: Thursday, September 12, 2013 5:00 AM To: dev@cloudstack.apache.org Subject: Creating an instance with ssh key pair Hello all, If I create an instance providing ssh key pair while creation, and using a normal template from the cloudstack setup, then will the SSH to vm using the keyPairFlieLocation always work? Or the template which I am using for creating the instance has to be supporting SSH keys? as explained in 5.2.1 section at http://cloudstack.apache.org/docs/en-US/Apache_CloudStack/4.0.2/html/Installation_Guide/using-sshkeys.html In short, Is the SSH using keyPairFileLocation - template dependent or will it always work if I provide ssh key pair while creating instance and use normal template? Regards, Gaurav
Re: Review Request 12545: CLOUDSTACK-1800: Add automation tests for reset sshkey to access VM
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12545/#review26131 --- Ship it! Ship It! - Harikrishna Patnala On Sept. 14, 2013, 7:46 a.m., Girish Shilamkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12545/ --- (Updated Sept. 14, 2013, 7:46 a.m.) Review request for cloudstack, Harikrishna Patnala and Prasanna Santhanam. Bugs: CLOUDSTACK-1800 Repository: cloudstack-git Description --- CLOUDSTACK-1800: Add automation tests for reset sshkey to access VM Diffs - test/integration/component/test_reset_ssh_keypair.py PRE-CREATION Diff: https://reviews.apache.org/r/12545/diff/ Testing --- Thanks, Girish Shilamkar
Review Request 14227: CLOUDSTACK-4707: sourcetemplateid field is not getting set for derived templates
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14227/ --- Review request for cloudstack, Abhinandan Prateek and Kishan Kavala. Bugs: CLOUDSTACK-4707 Repository: cloudstack-git Description --- CLOUDSTACK-4707: sourcetemplateid field is not getting set for derived templates Template created from a volume or snapshot did not have the sourcetemplateid field set in vm_template table. Diffs - engine/schema/src/com/cloud/storage/VolumeVO.java ea3d6bf setup/db/db/schema-410to420.sql f7f10b9 Diff: https://reviews.apache.org/r/14227/diff/ Testing --- Tested by 1) creating template from root volume of VM 2) created snapshot of root volume and create template from that snapshot In both the cases sourcetemplateId is set in vm_template table Thanks, Harikrishna Patnala
Re: Review Request 14227: CLOUDSTACK-4707: sourcetemplateid field is not getting set for derived templates
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14227/ --- (Updated Sept. 19, 2013, 10:25 a.m.) Review request for cloudstack and Kishan Kavala. Bugs: CLOUDSTACK-4707 Repository: cloudstack-git Description --- CLOUDSTACK-4707: sourcetemplateid field is not getting set for derived templates Template created from a volume or snapshot did not have the sourcetemplateid field set in vm_template table. Diffs - engine/schema/src/com/cloud/storage/VolumeVO.java ea3d6bf setup/db/db/schema-410to420.sql f7f10b9 Diff: https://reviews.apache.org/r/14227/diff/ Testing --- Tested by 1) creating template from root volume of VM 2) created snapshot of root volume and create template from that snapshot In both the cases sourcetemplateId is set in vm_template table Thanks, Harikrishna Patnala
Re: Volunteers to Complete the 4.2 Release Notes
Hi Abhinav, Can you please close this ticket it the new systemvm name changes are fixed. https://issues.apache.org/jira/browse/CLOUDSTACK-3355 On 24-Sep-2013, at 8:16 PM, Abhinav Roy abhinav@citrix.com wrote: Yes Indra, It is confirmed. We have tested using below names only. It was my fault that I overlooked it during documentation. Thanks and regards, Abhinav -Original Message- From: Indra Pramana [mailto:in...@sg.or.id] Sent: Tuesday, September 24, 2013 12:12 PM To: dev@cloudstack.apache.org Cc: us...@cloudstack.apache.org; Radhika Puthiyetath; Harikrishna Patnala Subject: Re: Volunteers to Complete the 4.2 Release Notes Hi Abhinav and all, So is it confirmed that the correct system VM template name should be below? 1) systemvm-xenserver-4.2 2) systemvm-kvm-4.2 3) systemvm-vmware-4.2 4) systemvm-hyperv-4.2 5) systemvm-lxc-4.2 Looking forward to your reply, thank you. Cheers. On Tue, Sep 24, 2013 at 1:47 AM, Abhinav Roy abhinav@citrix.com wrote: Yes , that's true Milamber. It's my fault, Somehow I overlooked it. But, the check for 8096 API port is already there for 4.1.x to 4.2 upgrades. Thanks and regards, Abhinav -Original Message- From: Milamber [mailto:milam...@apache.org] Sent: Monday, September 23, 2013 10:53 PM To: us...@cloudstack.apache.org; dev@cloudstack.apache.org; Radhika Puthiyetath; Harikrishna Patnala Subject: Re: Volunteers to Complete the 4.2 Release Notes Le 23/09/2013 10:48, Abhinav Roy a ecrit : Hi, Here are some of the steps which are missing from the release notes, 1. Before upgrading from any version to 4.2 we need to register the new 4.2 systemvm templates . This step is there in section 3.3 i.e for upgrade from 2.2.14 to 4.2, but it is missing in section 3.1 and 3.2 . + entryparaName: systemvm-kvm-4.2.0/para +paraDescription: + systemvm-kvm-4.2.0/para My upgrade test (from 4.1.1 to 4.2) have failed, because I used systemvm-kvm-4.2.0 for the name of new system vm... (my system vms still in debian 6.0) Please Note: The name for the new system vms (xen, kvm, vmware, etc) must be only 4.2 (not 4.2.0) at the end. 1) systemvm-xenserver-4.2 2) systemvm-kvm-4.2 3) systemvm-vmware-4.2 4) systemvm-hyperv-4.2 5) systemvm-lxc-4.2 Reference: https://issues.apache.org/jira/browse/CLOUDSTACK-3355 (close this issue?) Have you enabled the integration.api.port under Global Settings menu in CS management GUI? If not, set it to 8096, restart management and see if the problem goes away. Add some lines to check if the key intergration.api.port is set to 8096 before the upgrade seems important too. (for section 4.1.x to 4.2) Milamber 2. Section 3.1 Step 34 : it should be cloudstack-management and cloudstack-usage as the naming conventions have been changed from 4.1 onwards. Step 6 : The cloudstack 4.2 repo has not been published yet, currently at http://cloudstack.apt-get.eu/ the repo is available only for 4.0.x and 4.1.x What Indira pointed to, needs to be removed, step 6.g) and 6.h) and step 8 also need to be removed In step 6.f) It should be service cloudstack-agent stop Step 9.b) : It should be sudo yum upgrade cloudstack-client Step 9.c) : it should be sudo yum upgrade cloudstack-agent and the following line is not required [[ During the installation of cloudstack-agent, the RPM will copy your agent.properties,log4j-cloud.xml, and environment.properties from /etc/cloud/agent to /etc/cloudstack/agent ]] Step 9.d.ii) : it should be sudo yum upgrade cloudstack-usage 3. Section 3.2 Step 1.e) : The URL of the vmware systemvm template is wrong. It should be http://download.cloud.com/templates/4.2/systemvmtemplate-4.2-vh7.ova . The OSType should be [[Debian GNU/Linux 7.0 (32-bit) (or the highestDebian release number available in the dropdown)]] Similarly, add templates for xenserver and kvm also. Step 7 : Delete this step, it's not needed. Step 16 : It should be cloudstack-sysvmadm 4. Section 3.3 Step 4.d) : For all the newly registered templates, make the OStype as [[Debian GNU/Linux 7.0 (32-bit) (or the highest Debian release number available in the dropdown)]] Step 13.c) : It should be /etc/cloudstack/management/components.xml Step 15.c) : It should be /etc/cloudstack/management/db.properties Step 20 : Remove this step, it's not needed Step 21.e) : It should be /etc/cloudstack/agent/agent.properties Step 23.a) : It should be cloudstack-sysvmadm 5. In addition to all this, If we are using KVM hosts as rhel6.0/6.1 then these extra steps need to be documented for each section, 3.2 and 3.3 (KVM on RHEL 6.0/6.1 only) If your existing CloudStack deployment
Re: Database upgrade
My comments inline -Harikrishna On 25-Sep-2013, at 10:18 AM, Indra Pramana in...@sg.or.id wrote: Dear all, During my (failed) upgrade attempt from CloudStack 4.1.1 to 4.2.0 early this week, I noted that CloudStack management server will automatically detect the database version and upgrade the database automatically. === 2013-09-24 02:23:48,145 INFO [utils.component.ComponentContext] (Timer-1:null) Running SystemIntegrityChecker managementServerNode 2013-09-24 02:23:48,145 INFO [utils.component.ComponentContext] (Timer-1:null) Running SystemIntegrityChecker databaseUpgradeChecker 2013-09-24 02:23:48,145 INFO [cloud.upgrade.DatabaseUpgradeChecker] (Timer-1:null) Grabbing lock to check for database upgrade. 2013-09-24 02:23:48,147 DEBUG [upgrade.dao.VersionDaoImpl] (Timer-1:null) Checking to see if the database is at a version before it was the version table is created 2013-09-24 02:23:48,154 INFO [cloud.upgrade.DatabaseUpgradeChecker] (Timer-1:null) DB version = 4.1.1 Code Version = 4.2.0 2013-09-24 02:23:48,154 INFO [cloud.upgrade.DatabaseUpgradeChecker] (Timer-1:null) Database upgrade must be performed from 4.1.1 to 4.2.0 2013-09-24 02:23:48,154 DEBUG [cloud.upgrade.DatabaseUpgradeChecker] (Timer-1:null) Running upgrade Upgrade410to420 to upgrade from 4.1.0-4.1.1 to 4.2.0 2013-09-24 02:23:48,159 DEBUG [utils.script.Script] (Timer-1:null) Looking for db/schema-410to420.sql in the classpath 2013-09-24 02:23:48,160 DEBUG [utils.script.Script] (Timer-1:null) System resource: file:/usr/share/cloudstack-management/setup/db/schema-410to420.sql 2013-09-24 02:23:48,160 DEBUG [utils.script.Script] (Timer-1:null) Absolute path = /usr/share/cloudstack-management/setup/db/schema-410to420.sql === My questions: (1) Am I right to say that this database check and upgrade is done when the cloudstack-management 4.2.0 service is started? It's not performed during the installation/upgrade of the cloudstack-management app (in my case, apt-get install cloudstack-management)? Yes database upgrade happens during the start of MS. It compares the CS version in DB and MS version if upgrade path is defined DB upgrades to the MS version. Even during any fresh install, DB points to 4.0 and during start of MS, DB upgrade happens to the MS version. (2) I used a new set of disk for my upgrade attempt by cloning the existing disk to a new one (using dd), and perform the upgrade on the new disk. When I failed the upgrade attempt, I just reverted back to the old disk and restore the database (which is hosted on a different server). The new set of disk is still containing the new 4.2.0 of cloudstack-management app inside. To perform another upgrade attempt, can I just boot-up using the new set of disk (instead of re-cloning and re-doing the upgrade)? Will it again detect that the existing database is still version 4.1.1, and will automatically upgrade the database to version 4.2.0 when the service is started? Yes, upgrade happens again since you have restored the DB to 4.1 and during MS start it gets the DB version from version table(here it is 4.1). Looking forward to your reply, thank you. Cheers.
Re: [ANNOUNCE] New committer: Rajesh Battala
Congratulations Rajesh :) On 25-Sep-2013, at 10:26 AM, Venkata SwamyBabu Budumuru venkataswamybabu.budum...@citrix.com wrote: Congrats Rajesh! On 25/09/13 10:00 AM, Abhinav Roy abhinav@citrix.com wrote: Congrats Rajesh :) -Original Message- From: Sanjay Tripathi [mailto:sanjay.tripa...@citrix.com] Sent: Wednesday, September 25, 2013 9:58 AM To: dev@cloudstack.apache.org Subject: RE: [ANNOUNCE] New committer: Rajesh Battala Congrats Rajesh!! --Sanjay -Original Message- From: Chip Childers [mailto:chip.child...@sungard.com] Sent: Tuesday, September 24, 2013 9:00 PM To: dev@cloudstack.apache.org Subject: [ANNOUNCE] New committer: Rajesh Battala The Project Management Committee (PMC) for Apache CloudStack has asked Rajesh Battala to become a committer and we are pleased to announce that they have accepted. Being a committer allows many contributors to contribute more autonomously. For developers, it makes it easier to submit changes and eliminates the need to have contributions reviewed via the patch submission process. Whether contributions are development-related or otherwise, it is a recognition of a contributor's participation in the project and commitment to the project and the Apache Way. Please join me in congratulating Rajesh! -chip on behalf of the CloudStack PMC
RE: [4.2] [xenserver] [system vms] Xentools
Hi, Earlier there was discussion on putting xen tools in systemvms. Please look into that. http://mail-archives.apache.org/mod_mbox/cloudstack-dev/201309.mbox/%3cce676527.4398b%25abhinandan.prat...@citrix.com%3E From: Paul Angus [mailto:paul.an...@shapeblue.com] Sent: Tuesday, October 08, 2013 1:36 PM To: dev@cloudstack.apache.org Subject: [4.2] [xenserver] [system vms] Xentools Hi all, The current XenServer system VM template doesn't seem to include XenServer Tools - is this by design? systemvmtemplate-2013-07-12-master-xen.vhd.bz2 Regards Paul Angus Senior Consultant / Cloud Architect [cid:image002.png@01CE1071.C6CC9C10] S: +44 20 3603 0540tel:+442036030540 | M: +4tel:+44796816158147711418784 | T: CloudyAngus paul.an...@shapeblue.commailto:geoff.higginbot...@shapeblue.com | www.shapeblue.com | Twitter:@shapebluehttps://twitter.com/ ShapeBlue Ltd, 53 Chandos Place, Covent Garden, London, WC2N 4HS Apache CloudStack Bootcamp training courses 02/03 October, Londonhttp://www.shapeblue.com/cloudstack-bootcamp-training-course/ 13/14 November, Londonhttp://www.shapeblue.com/cloudstack-bootcamp-training-course/ 27/28 November, Bangalorehttp://www.shapeblue.com/cloudstack-bootcamp-training-course/ 08/09 January 2014, Londonhttp://www.shapeblue.com/cloudstack-bootcamp-training-course/ This email and any attachments to it may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of Shape Blue Ltd or related companies. If you are not the intended recipient of this email, you must neither take any action based upon its contents, nor copy or show it to anyone. Please contact the sender if you believe you have received this email in error. Shape Blue Ltd is a company incorporated in England Wales. ShapeBlue Services India LLP is a company incorporated in India and is operated under license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is operated under license from Shape Blue Ltd. ShapeBlue is a registered trademark.
RE: Dynamically scalable?
Hi , While registering template we can specify whether xenserver/vmware tools installed in the template using this flag(dynamically scalable). This is required while deploying vm to set some parameters for dynamic scaling of cpu and ram feature to work. The same flag is reflected in the vm instance details. Thanks HArikrishna -Original Message- From: Indra Pramana [mailto:in...@sg.or.id] Sent: Wednesday, October 09, 2013 3:52 PM To: dev@cloudstack.apache.org; us...@cloudstack.apache.org Subject: Dynamically scalable? Dear all, What does dynamically scalable means on a VM instance or a template? Looking forward to your reply, thank you. Cheers.
Re: Review Request 14227: CLOUDSTACK-4707: sourcetemplateid field is not getting set for derived templates
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14227/ --- (Updated Oct. 9, 2013, 11:03 a.m.) Review request for cloudstack and Kishan Kavala. Bugs: CLOUDSTACK-4707 Repository: cloudstack-git Description --- CLOUDSTACK-4707: sourcetemplateid field is not getting set for derived templates Template created from a volume or snapshot did not have the sourcetemplateid field set in vm_template table. Diffs (updated) - engine/schema/src/com/cloud/storage/VolumeVO.java ea3d6bf Diff: https://reviews.apache.org/r/14227/diff/ Testing --- Tested by 1) creating template from root volume of VM 2) created snapshot of root volume and create template from that snapshot In both the cases sourcetemplateId is set in vm_template table Thanks, Harikrishna Patnala
Review Request: Fix for CLOUDSTACK-2728: 41-42 DB upgrade: add step to upgrade system templates
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11618/ --- Review request for cloudstack and Kishan Kavala. Description --- CLOUDSTACK-2728: 41-42 DB upgrade: add step to upgrade system templates Added fix to update systemvm templates for the hypervisors Xenserver, VMware, KVM, Hyperv, LXC. And also modifying image_data_store_id to 1 for all the SYSTEM/BUILT in templates including the newly registered system vm templates. This addresses bug CLOUDSTACK-2728. Diffs - engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java 16ab05c Diff: https://reviews.apache.org/r/11618/diff/ Testing --- Tested locally by checking the upgrade from 4.1 to 4.2 with newly registered systemvm template. Thanks, Harikrishna Patnala
Review Request: Fix for CLOUDSTACK-1622, CLOUDSTACK-1704
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11780/ --- Review request for cloudstack, Abhinandan Prateek and Nitin Mehta. Description --- Global parameter cluster.memory.allocated.capacity.disablethreshold and cluster.cpu.allocated.capacity.disablethreshold are not disabling cluster after threshold values. This is due to unhandled sql query when these parameters have null values in the DB. Fixed by adding that case in the query. This addresses bugs CLOUDSTACK-1622 and CLOUDSTACK-1704. Diffs - engine/schema/src/com/cloud/capacity/dao/CapacityDaoImpl.java 0b9ff1a Diff: https://reviews.apache.org/r/11780/diff/ Testing --- Tested locally Thanks, Harikrishna Patnala
Review Request: fix for CLOUDSTACK-2347: Zone filter for listSnapshots API
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11820/ --- Review request for cloudstack, Abhinandan Prateek, Nitin Mehta, and Koushik Das. Description --- CLOUDSTACK-2347: Zone filter for listSnapshots API Added new optional parameter zone id in listSnapshots API which allows to list snapshots with additional criteria. This addresses bug CLOUDSTACK-2347. Diffs - api/src/org/apache/cloudstack/api/command/user/snapshot/ListSnapshotsCmd.java d7e6bc8 api/src/org/apache/cloudstack/api/response/SnapshotResponse.java 7484ac9 server/src/com/cloud/api/ApiResponseHelper.java 0c98abc server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java 92d80ee Diff: https://reviews.apache.org/r/11820/diff/ Testing --- Tested locally Thanks, Harikrishna Patnala
Review Request: Fix for CLOUDSTACK-2502 and CLOUDSTACK-2939
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11860/ --- Review request for cloudstack and Nitin Mehta. Description --- CLOUDSTACK-2502: Scalevm and over provisioning should respect each other During Scale up of VM, memory/cpu calculations should consider the memory/cpu overprovisioning factors which are set per cluster. CLOUDSTACK-2939: CPU limit is not getting set for vm after scaleup to a service offering which have cpu cap enabled This addresses bugs CLOUDSTACK-2502 and CLOUDSTACK-2939. Diffs - core/src/com/cloud/agent/api/ScaleVmCommand.java 35d22ad plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 46219c3 plugins/hypervisors/vmware/test/com/cloud/hypervisor/vmware/resource/VmwareResourceTest.java 3ca0b60 plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java e92c3fc plugins/hypervisors/xen/test/com/cloud/hypervisor/xen/resource/CitrixResourceBaseTest.java 3328d4b server/src/com/cloud/hypervisor/HypervisorGuruBase.java d8945af server/src/com/cloud/vm/VirtualMachineManagerImpl.java 568fe55 server/test/com/cloud/vm/VirtualMachineManagerImplTest.java dd51e74 Diff: https://reviews.apache.org/r/11860/diff/ Testing --- Tested locally Thanks, Harikrishna Patnala
Review Request: Fix for CLOUDSTACK-2987 Ensure XStools to be there in template inorder to enable dynamic scaling of vm
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11910/ --- Review request for cloudstack, Abhinandan Prateek and Nitin Mehta. Description --- CLOUDSTACK-2987 Ensure XStools to be there in template inorder to enable dynamic scaling of vm CLOUDSTACK-3042 - handle Scaling up of vm memory/CPU based on the presence of XS tools in the template This should also take care of updation of VM after XS tools are installed in the vm and set memory values accordingly to support dynamic scaling after stop start of VM This addresses bugs CLOUDSTACK-2987 and CLOUDSTACK-3042. Diffs - api/src/com/cloud/agent/api/to/VirtualMachineTO.java 46ee01b api/src/com/cloud/template/VirtualMachineTemplate.java cedc793 api/src/org/apache/cloudstack/api/ApiConstants.java ab1402c api/src/org/apache/cloudstack/api/BaseUpdateTemplateOrIsoCmd.java 6fd9773 api/src/org/apache/cloudstack/api/command/user/iso/RegisterIsoCmd.java 284d553 api/src/org/apache/cloudstack/api/command/user/template/RegisterTemplateCmd.java c9da0c2 api/src/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java 2860283 api/src/org/apache/cloudstack/api/response/TemplateResponse.java 896154a api/src/org/apache/cloudstack/api/response/UserVmResponse.java 1f9eb1a core/src/com/cloud/agent/api/ScaleVmCommand.java b361485 engine/schema/src/com/cloud/storage/VMTemplateVO.java e643d75 engine/schema/src/com/cloud/vm/VMInstanceVO.java fbe03dc engine/storage/src/org/apache/cloudstack/storage/image/TemplateEntityImpl.java 4d162bb plugins/hypervisors/xen/src/com/cloud/hypervisor/XenServerGuru.java 8c38a69 plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 5e8283a plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java 8e37809 server/src/com/cloud/api/ApiResponseHelper.java 94c5d6c server/src/com/cloud/api/query/dao/UserVmJoinDaoImpl.java dbfe94d server/src/com/cloud/api/query/vo/UserVmJoinVO.java 8ad0fdd server/src/com/cloud/hypervisor/HypervisorGuruBase.java 1ad9a1f server/src/com/cloud/server/ManagementServerImpl.java 96c72e4 server/src/com/cloud/storage/TemplateProfile.java 0b55f1f server/src/com/cloud/template/TemplateAdapter.java 9a2d877 server/src/com/cloud/template/TemplateAdapterBase.java 0940d3e server/src/com/cloud/vm/UserVmManagerImpl.java 1c8ab75 server/src/com/cloud/vm/VirtualMachineManagerImpl.java f946cd1 server/test/com/cloud/vm/VirtualMachineManagerImplTest.java 8715c9e setup/db/db/schema-410to420.sql 272fc42 Diff: https://reviews.apache.org/r/11910/diff/ Testing --- Tested locally Thanks, Harikrishna Patnala
Re: Review Request: Fix for CLOUDSTACK-2987 Ensure XStools to be there in template inorder to enable dynamic scaling of vm
On June 17, 2013, 3:12 p.m., Prasanna Santhanam wrote: server/src/com/cloud/vm/UserVmManagerImpl.java, line 1818 https://reviews.apache.org/r/11910/diff/1/?file=306800#file306800line1818 can this be made case insensitive? so comparisons can compare as equalIgnoreCase? Hi Prasanna, There are no comparisons for this, as IsScalable is name of a value. We retrieve the value corresponding to the name IsScalable and do comparisons on that value at some places. On June 17, 2013, 3:12 p.m., Prasanna Santhanam wrote: server/test/com/cloud/vm/VirtualMachineManagerImplTest.java, line 77 https://reviews.apache.org/r/11910/diff/1/?file=306802#file306802line77 Can you remove the wildcard import? This is due to auto import 'll fix this. Thankyou - Harikrishna --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11910/#review21982 --- On June 17, 2013, 2:44 p.m., Harikrishna Patnala wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11910/ --- (Updated June 17, 2013, 2:44 p.m.) Review request for cloudstack, Abhinandan Prateek and Nitin Mehta. Description --- CLOUDSTACK-2987 Ensure XStools to be there in template inorder to enable dynamic scaling of vm CLOUDSTACK-3042 - handle Scaling up of vm memory/CPU based on the presence of XS tools in the template This should also take care of updation of VM after XS tools are installed in the vm and set memory values accordingly to support dynamic scaling after stop start of VM This addresses bugs CLOUDSTACK-2987 and CLOUDSTACK-3042. Diffs - api/src/com/cloud/agent/api/to/VirtualMachineTO.java 46ee01b api/src/com/cloud/template/VirtualMachineTemplate.java cedc793 api/src/org/apache/cloudstack/api/ApiConstants.java ab1402c api/src/org/apache/cloudstack/api/BaseUpdateTemplateOrIsoCmd.java 6fd9773 api/src/org/apache/cloudstack/api/command/user/iso/RegisterIsoCmd.java 284d553 api/src/org/apache/cloudstack/api/command/user/template/RegisterTemplateCmd.java c9da0c2 api/src/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java 2860283 api/src/org/apache/cloudstack/api/response/TemplateResponse.java 896154a api/src/org/apache/cloudstack/api/response/UserVmResponse.java 1f9eb1a core/src/com/cloud/agent/api/ScaleVmCommand.java b361485 engine/schema/src/com/cloud/storage/VMTemplateVO.java e643d75 engine/schema/src/com/cloud/vm/VMInstanceVO.java fbe03dc engine/storage/src/org/apache/cloudstack/storage/image/TemplateEntityImpl.java 4d162bb plugins/hypervisors/xen/src/com/cloud/hypervisor/XenServerGuru.java 8c38a69 plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 5e8283a plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java 8e37809 server/src/com/cloud/api/ApiResponseHelper.java 94c5d6c server/src/com/cloud/api/query/dao/UserVmJoinDaoImpl.java dbfe94d server/src/com/cloud/api/query/vo/UserVmJoinVO.java 8ad0fdd server/src/com/cloud/hypervisor/HypervisorGuruBase.java 1ad9a1f server/src/com/cloud/server/ManagementServerImpl.java 96c72e4 server/src/com/cloud/storage/TemplateProfile.java 0b55f1f server/src/com/cloud/template/TemplateAdapter.java 9a2d877 server/src/com/cloud/template/TemplateAdapterBase.java 0940d3e server/src/com/cloud/vm/UserVmManagerImpl.java 1c8ab75 server/src/com/cloud/vm/VirtualMachineManagerImpl.java f946cd1 server/test/com/cloud/vm/VirtualMachineManagerImplTest.java 8715c9e setup/db/db/schema-410to420.sql 272fc42 Diff: https://reviews.apache.org/r/11910/diff/ Testing --- Tested locally Thanks, Harikrishna Patnala
Re: Review Request: Fix for CLOUDSTACK-2987 Ensure XStools to be there in template inorder to enable dynamic scaling of vm
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11910/ --- (Updated June 17, 2013, 6:37 p.m.) Review request for cloudstack, Abhinandan Prateek and Nitin Mehta. Changes --- Updated patch with fixes that are due to auto import. Description --- CLOUDSTACK-2987 Ensure XStools to be there in template inorder to enable dynamic scaling of vm CLOUDSTACK-3042 - handle Scaling up of vm memory/CPU based on the presence of XS tools in the template This should also take care of updation of VM after XS tools are installed in the vm and set memory values accordingly to support dynamic scaling after stop start of VM This addresses bugs CLOUDSTACK-2987 and CLOUDSTACK-3042. Diffs (updated) - api/src/com/cloud/agent/api/to/VirtualMachineTO.java 46ee01b api/src/com/cloud/template/VirtualMachineTemplate.java cedc793 api/src/org/apache/cloudstack/api/ApiConstants.java ab1402c api/src/org/apache/cloudstack/api/BaseUpdateTemplateOrIsoCmd.java 6fd9773 api/src/org/apache/cloudstack/api/command/user/iso/RegisterIsoCmd.java 284d553 api/src/org/apache/cloudstack/api/command/user/template/RegisterTemplateCmd.java c9da0c2 api/src/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java 2860283 api/src/org/apache/cloudstack/api/response/TemplateResponse.java 896154a api/src/org/apache/cloudstack/api/response/UserVmResponse.java 1f9eb1a core/src/com/cloud/agent/api/ScaleVmCommand.java b361485 engine/schema/src/com/cloud/storage/VMTemplateVO.java e643d75 engine/schema/src/com/cloud/vm/VMInstanceVO.java fbe03dc engine/storage/src/org/apache/cloudstack/storage/image/TemplateEntityImpl.java 4d162bb plugins/hypervisors/xen/src/com/cloud/hypervisor/XenServerGuru.java 8c38a69 plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 5e8283a plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java 8e37809 server/src/com/cloud/api/ApiResponseHelper.java 94c5d6c server/src/com/cloud/api/query/dao/UserVmJoinDaoImpl.java dbfe94d server/src/com/cloud/api/query/vo/UserVmJoinVO.java 8ad0fdd server/src/com/cloud/hypervisor/HypervisorGuruBase.java 1ad9a1f server/src/com/cloud/server/ManagementServerImpl.java 96c72e4 server/src/com/cloud/storage/TemplateProfile.java 0b55f1f server/src/com/cloud/template/TemplateAdapter.java 9a2d877 server/src/com/cloud/template/TemplateAdapterBase.java 0940d3e server/src/com/cloud/vm/UserVmManagerImpl.java 1c8ab75 server/src/com/cloud/vm/VirtualMachineManagerImpl.java f946cd1 server/test/com/cloud/vm/VirtualMachineManagerImplTest.java 8715c9e setup/db/db/schema-410to420.sql 272fc42 Diff: https://reviews.apache.org/r/11910/diff/ Testing --- Tested locally Thanks, Harikrishna Patnala
Re: [ANNOUNCE] New committer: Jayapal Reddy Uradi
Congratulations Jayapal. On 17-Jun-2013, at 10:29 PM, Abhinandan Prateek cloudst...@aprateek.com wrote: Congrats Jayapal ! Well deserved. On 17/06/13 9:00 PM, Chip Childers chip.child...@sungard.com wrote: The Project Management Committee (PMC) for Apache CloudStack has asked Jayapal Reddy Uradi to become a committer and we are pleased to announce that they have accepted. Being a committer allows many contributors to contribute more autonomously. For developers, it makes it easier to submit changes and eliminates the need to have contributions reviewed via the patch submission process. Whether contributions are development-related or otherwise, it is a recognition of a contributor's participation in the project and commitment to the project and the Apache Way. Please join me in congratulating Jayapal! -chip on behalf of the CloudStack PMC
Re: Review Request: Fix for CLOUDSTACK-2987 Ensure XStools to be there in template inorder to enable dynamic scaling of vm
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11910/ --- (Updated June 18, 2013, 7:05 a.m.) Review request for cloudstack, Abhinandan Prateek and Nitin Mehta. Changes --- Added upgrade case. Added case insensitivity for the flag we use to check scalability of VM. Description --- CLOUDSTACK-2987 Ensure XStools to be there in template inorder to enable dynamic scaling of vm CLOUDSTACK-3042 - handle Scaling up of vm memory/CPU based on the presence of XS tools in the template This should also take care of updation of VM after XS tools are installed in the vm and set memory values accordingly to support dynamic scaling after stop start of VM This addresses bugs CLOUDSTACK-2987 and CLOUDSTACK-3042. Diffs (updated) - api/src/com/cloud/agent/api/to/VirtualMachineTO.java 46ee01b api/src/com/cloud/template/VirtualMachineTemplate.java cedc793 api/src/org/apache/cloudstack/api/ApiConstants.java ab1402c api/src/org/apache/cloudstack/api/BaseUpdateTemplateOrIsoCmd.java 6fd9773 api/src/org/apache/cloudstack/api/command/user/iso/RegisterIsoCmd.java 284d553 api/src/org/apache/cloudstack/api/command/user/template/RegisterTemplateCmd.java c9da0c2 api/src/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java 2860283 api/src/org/apache/cloudstack/api/response/TemplateResponse.java 896154a api/src/org/apache/cloudstack/api/response/UserVmResponse.java 1f9eb1a core/src/com/cloud/agent/api/ScaleVmCommand.java b361485 engine/schema/src/com/cloud/storage/VMTemplateVO.java e643d75 engine/schema/src/com/cloud/vm/VMInstanceVO.java fbe03dc engine/storage/src/org/apache/cloudstack/storage/image/TemplateEntityImpl.java 4d162bb plugins/hypervisors/xen/src/com/cloud/hypervisor/XenServerGuru.java 8c38a69 plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 5e8283a plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java 8e37809 server/src/com/cloud/api/ApiResponseHelper.java 94c5d6c server/src/com/cloud/api/query/dao/UserVmJoinDaoImpl.java dbfe94d server/src/com/cloud/api/query/vo/UserVmJoinVO.java 8ad0fdd server/src/com/cloud/hypervisor/HypervisorGuruBase.java 1ad9a1f server/src/com/cloud/server/ManagementServerImpl.java 96c72e4 server/src/com/cloud/storage/TemplateProfile.java 0b55f1f server/src/com/cloud/template/TemplateAdapter.java 9a2d877 server/src/com/cloud/template/TemplateAdapterBase.java 0940d3e server/src/com/cloud/vm/UserVmManagerImpl.java 1c8ab75 server/src/com/cloud/vm/VirtualMachineManagerImpl.java f946cd1 server/test/com/cloud/vm/VirtualMachineManagerImplTest.java 8715c9e setup/db/db/schema-410to420.sql 272fc42 Diff: https://reviews.apache.org/r/11910/diff/ Testing --- Tested locally Thanks, Harikrishna Patnala
Re: Review Request: Fix for CLOUDSTACK-2987 Ensure XStools to be there in template inorder to enable dynamic scaling of vm
On June 17, 2013, 3:12 p.m., Prasanna Santhanam wrote: Since XCP shares the same resource (XcpOssResource-CitrixResourceBase) can the command ScaleVmCommand be implemented for XCP too? Prasanna Santhanam wrote: Any comments about adding the XCP support? Agreed we may have to put this, but currently based on the bandwidth we have, we did this for Advanced and Enterprise editions of xenserver. I'll file a bug to track this support for XCP. Thank you - Harikrishna --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11910/#review21982 --- On June 18, 2013, 7:05 a.m., Harikrishna Patnala wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11910/ --- (Updated June 18, 2013, 7:05 a.m.) Review request for cloudstack, Abhinandan Prateek and Nitin Mehta. Description --- CLOUDSTACK-2987 Ensure XStools to be there in template inorder to enable dynamic scaling of vm CLOUDSTACK-3042 - handle Scaling up of vm memory/CPU based on the presence of XS tools in the template This should also take care of updation of VM after XS tools are installed in the vm and set memory values accordingly to support dynamic scaling after stop start of VM This addresses bugs CLOUDSTACK-2987 and CLOUDSTACK-3042. Diffs - api/src/com/cloud/agent/api/to/VirtualMachineTO.java 46ee01b api/src/com/cloud/template/VirtualMachineTemplate.java cedc793 api/src/org/apache/cloudstack/api/ApiConstants.java ab1402c api/src/org/apache/cloudstack/api/BaseUpdateTemplateOrIsoCmd.java 6fd9773 api/src/org/apache/cloudstack/api/command/user/iso/RegisterIsoCmd.java 284d553 api/src/org/apache/cloudstack/api/command/user/template/RegisterTemplateCmd.java c9da0c2 api/src/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java 2860283 api/src/org/apache/cloudstack/api/response/TemplateResponse.java 896154a api/src/org/apache/cloudstack/api/response/UserVmResponse.java 1f9eb1a core/src/com/cloud/agent/api/ScaleVmCommand.java b361485 engine/schema/src/com/cloud/storage/VMTemplateVO.java e643d75 engine/schema/src/com/cloud/vm/VMInstanceVO.java fbe03dc engine/storage/src/org/apache/cloudstack/storage/image/TemplateEntityImpl.java 4d162bb plugins/hypervisors/xen/src/com/cloud/hypervisor/XenServerGuru.java 8c38a69 plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 5e8283a plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java 8e37809 server/src/com/cloud/api/ApiResponseHelper.java 94c5d6c server/src/com/cloud/api/query/dao/UserVmJoinDaoImpl.java dbfe94d server/src/com/cloud/api/query/vo/UserVmJoinVO.java 8ad0fdd server/src/com/cloud/hypervisor/HypervisorGuruBase.java 1ad9a1f server/src/com/cloud/server/ManagementServerImpl.java 96c72e4 server/src/com/cloud/storage/TemplateProfile.java 0b55f1f server/src/com/cloud/template/TemplateAdapter.java 9a2d877 server/src/com/cloud/template/TemplateAdapterBase.java 0940d3e server/src/com/cloud/vm/UserVmManagerImpl.java 1c8ab75 server/src/com/cloud/vm/VirtualMachineManagerImpl.java f946cd1 server/test/com/cloud/vm/VirtualMachineManagerImplTest.java 8715c9e setup/db/db/schema-410to420.sql 272fc42 Diff: https://reviews.apache.org/r/11910/diff/ Testing --- Tested locally Thanks, Harikrishna Patnala
Review Request: Fix for CLOUDSTACK-2181: Scale down is allowed, which is not expected
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11936/ --- Review request for cloudstack and Nitin Mehta. Description --- CLOUDSTACK-2181: Scale down is allowed when one resource(say cpu) is being scale up and other resource (say ram) is being scale down ;but not allowed when both resources are being scaledown This addresses bug CLOUDSTACK-2181. Diffs - server/src/com/cloud/vm/UserVmManagerImpl.java e8ea024 Diff: https://reviews.apache.org/r/11936/diff/ Testing --- Tested locally Thanks, Harikrishna Patnala
Re: Review Request: Fix for CLOUDSTACK-2987 Ensure XStools to be there in template inorder to enable dynamic scaling of vm
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11910/ --- (Updated June 19, 2013, 11 a.m.) Review request for cloudstack, Abhinandan Prateek and Nitin Mehta. Changes --- Updated patch with changes as suggested Description --- CLOUDSTACK-2987 Ensure XStools to be there in template inorder to enable dynamic scaling of vm CLOUDSTACK-3042 - handle Scaling up of vm memory/CPU based on the presence of XS tools in the template This should also take care of updation of VM after XS tools are installed in the vm and set memory values accordingly to support dynamic scaling after stop start of VM This addresses bugs CLOUDSTACK-2987 and CLOUDSTACK-3042. Diffs (updated) - api/src/com/cloud/template/VirtualMachineTemplate.java cedc793 api/src/com/cloud/vm/VirtualMachine.java ce9add6 api/src/org/apache/cloudstack/api/ApiConstants.java ab1402c api/src/org/apache/cloudstack/api/BaseUpdateTemplateOrIsoCmd.java 6fd9773 api/src/org/apache/cloudstack/api/command/user/iso/RegisterIsoCmd.java 284d553 api/src/org/apache/cloudstack/api/command/user/template/RegisterTemplateCmd.java c9da0c2 api/src/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java 2860283 api/src/org/apache/cloudstack/api/response/TemplateResponse.java 896154a api/src/org/apache/cloudstack/api/response/UserVmResponse.java 1f9eb1a core/src/com/cloud/agent/api/ScaleVmCommand.java b361485 engine/schema/src/com/cloud/storage/VMTemplateVO.java e643d75 engine/schema/src/com/cloud/vm/VMInstanceVO.java fbe03dc engine/storage/src/org/apache/cloudstack/storage/image/TemplateEntityImpl.java 4d162bb plugins/hypervisors/xen/src/com/cloud/hypervisor/XenServerGuru.java 8c38a69 plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 5e8283a plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java 8e37809 server/src/com/cloud/api/ApiResponseHelper.java 94c5d6c server/src/com/cloud/api/query/dao/UserVmJoinDaoImpl.java dbfe94d server/src/com/cloud/api/query/vo/UserVmJoinVO.java 8ad0fdd server/src/com/cloud/hypervisor/HypervisorGuruBase.java 1ad9a1f server/src/com/cloud/server/ManagementServerImpl.java 96c72e4 server/src/com/cloud/storage/TemplateProfile.java 0b55f1f server/src/com/cloud/template/TemplateAdapter.java 9a2d877 server/src/com/cloud/template/TemplateAdapterBase.java 0940d3e server/src/com/cloud/vm/UserVmManagerImpl.java 1c8ab75 server/src/com/cloud/vm/VirtualMachineManagerImpl.java f946cd1 server/test/com/cloud/vm/VirtualMachineManagerImplTest.java 8715c9e setup/db/db/schema-410to420.sql 272fc42 Diff: https://reviews.apache.org/r/11910/diff/ Testing --- Tested locally Thanks, Harikrishna Patnala
Re: Review Request: Fix for CLOUDSTACK-2987 Ensure XStools to be there in template inorder to enable dynamic scaling of vm
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11910/ --- (Updated June 20, 2013, 5:19 a.m.) Review request for cloudstack, Abhinandan Prateek and Nitin Mehta. Changes --- Updated patch after resolving merge conflicts Description --- CLOUDSTACK-2987 Ensure XStools to be there in template inorder to enable dynamic scaling of vm CLOUDSTACK-3042 - handle Scaling up of vm memory/CPU based on the presence of XS tools in the template This should also take care of updation of VM after XS tools are installed in the vm and set memory values accordingly to support dynamic scaling after stop start of VM This addresses bugs CLOUDSTACK-2987 and CLOUDSTACK-3042. Diffs (updated) - api/src/com/cloud/template/VirtualMachineTemplate.java cedc793 api/src/com/cloud/vm/VirtualMachine.java ce9add6 api/src/org/apache/cloudstack/api/ApiConstants.java 12e5097 api/src/org/apache/cloudstack/api/BaseUpdateTemplateOrIsoCmd.java 6fd9773 api/src/org/apache/cloudstack/api/command/user/iso/RegisterIsoCmd.java 284d553 api/src/org/apache/cloudstack/api/command/user/template/RegisterTemplateCmd.java c9da0c2 api/src/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java 2860283 api/src/org/apache/cloudstack/api/response/TemplateResponse.java ed933ff api/src/org/apache/cloudstack/api/response/UserVmResponse.java 5b71ba2 core/src/com/cloud/agent/api/ScaleVmCommand.java b361485 engine/schema/src/com/cloud/storage/VMTemplateVO.java e643d75 engine/schema/src/com/cloud/vm/VMInstanceVO.java fbe03dc engine/storage/src/org/apache/cloudstack/storage/image/TemplateEntityImpl.java 4d162bb plugins/hypervisors/xen/src/com/cloud/hypervisor/XenServerGuru.java 8c38a69 plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 5e8283a plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java 8e37809 server/src/com/cloud/api/ApiResponseHelper.java 7ffa30f server/src/com/cloud/api/query/dao/UserVmJoinDaoImpl.java f9877ab server/src/com/cloud/api/query/vo/UserVmJoinVO.java c97d71a server/src/com/cloud/hypervisor/HypervisorGuruBase.java 1ad9a1f server/src/com/cloud/server/ManagementServerImpl.java cfc8333 server/src/com/cloud/storage/TemplateProfile.java 0b55f1f server/src/com/cloud/template/TemplateAdapter.java 9a2d877 server/src/com/cloud/template/TemplateAdapterBase.java 0940d3e server/src/com/cloud/vm/UserVmManagerImpl.java e8ea024 server/src/com/cloud/vm/VirtualMachineManagerImpl.java 5814075 server/test/com/cloud/vm/VirtualMachineManagerImplTest.java 8715c9e setup/db/db/schema-410to420.sql c782234 Diff: https://reviews.apache.org/r/11910/diff/ Testing --- Tested locally Thanks, Harikrishna Patnala
Review Request: Fix for CLOUDSTACK-2916, CLOUDSTACK-2457: validation for weight based configuration parameters
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11989/ --- Review request for cloudstack, Abhinandan Prateek and Nitin Mehta. Description --- CLOUDSTACK-2916: admin is not able to login through UI after setting GP cluster.cpu.allocated.capacity.notificationthreshold to some string CLOUDSTACK-2457: No check for input values,special character,-ive values can be assigne to GLobal parameter cluster.cpu.allocated.capacity.disablethreshold Added validation for float values and checking limit for weight based parameters by creating a set of parameters. This addresses bugs CLOUDSTACK-2457 and CLOUDSTACK-2916. Diffs - server/src/com/cloud/configuration/ConfigurationManagerImpl.java 131d340 Diff: https://reviews.apache.org/r/11989/diff/ Testing --- Tested locally Thanks, Harikrishna Patnala
Review Request: Fix for CLOUDSTACK-2835: Registering router template and usage of router.template.* configuration parameter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12063/ --- Review request for cloudstack, Abhinandan Prateek, Kishan Kavala, and Nitin Mehta. Description --- CLOUDSTACK-2835: VR Deployement from admin registered template is failing because registered template type is user. Additional parameter isrouter in register/update template API for the root admin. True if registered template is of type ROUTING. A new template type is introduced named ROUTING which is used to deploy router. Admin registers a ROUTING type template and provides the value zone/global level configuration parameters in routing.template.xenserver/kvm/hyperv/vmware/lxc So that router deploys using that template. By default router can be deployed by the normal SYSTEM template. Added upgrade case to update the configuration parameter values routing.template.xenserver/kvm/hyperv/vmware/lxc This addresses bug CLOUDSTACK-2835. Diffs - api/src/com/cloud/storage/Storage.java 16ef019 api/src/org/apache/cloudstack/api/ApiConstants.java 8ac7c3f api/src/org/apache/cloudstack/api/BaseUpdateTemplateOrIsoCmd.java b01c8d0 api/src/org/apache/cloudstack/api/command/user/template/RegisterTemplateCmd.java 6a8e555 api/src/org/apache/cloudstack/api/command/user/template/UpdateTemplateCmd.java 9f55f9d engine/schema/src/com/cloud/storage/dao/VMTemplateDaoImpl.java e7b85f8 engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java 8f63a6c server/src/com/cloud/server/ManagementServerImpl.java 97bac1b server/src/com/cloud/storage/TemplateProfile.java 00aab4d server/src/com/cloud/template/TemplateAdapter.java d50d45b server/src/com/cloud/template/TemplateAdapterBase.java c1f0604 server/src/com/cloud/template/TemplateManagerImpl.java 273614c Diff: https://reviews.apache.org/r/12063/diff/ Testing --- Tested locally. Registered ROUTING template and checked router deployment by setting the configuration parameter routing.template.xenserver to the new ROUTING template. Tested the default behavior of router deployment from SYSTEM template. Tested upgrade case from 4.1 to 4.2 Thanks, Harikrishna Patnala
Review Request 12078: Fix for CLOUDSTACK-3187: cluster.(cpu/memory).allocated.capacity.disablethreshold in not considering overcommit factor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12078/ --- Review request for cloudstack, Abhinandan Prateek and Nitin Mehta. Bugs: CLOUDSTACK-3187 Repository: cloudstack-git Description --- CLOUDSTACK-3187: cluster.(cpu/memory).allocated.capacity.disablethreshold in not considering overcommit factor. cluster is getting disable based on actual use. While checking for clusters that crosses disable threshold utilization is calculated based on the actual memory value of cluster. This should consider the overcommit ratio from cluster_details table. Diffs - engine/schema/src/com/cloud/capacity/dao/CapacityDaoImpl.java d14ad87 Diff: https://reviews.apache.org/r/12078/diff/ Testing --- Tested locally Thanks, Harikrishna Patnala
Review Request 12079: Fix for CLOUDSTACK-2794: Global parameter router.template.idshould be removed.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12079/ --- Review request for cloudstack and Abhinandan Prateek. Bugs: CLOUDSTACK-2794 Repository: cloudstack-git Description --- CLOUDSTACK-2794: Global parameter router.template.idshould be removed. Diffs - server/src/com/cloud/agent/manager/AgentManagerImpl.java fb857a7 server/src/com/cloud/configuration/Config.java 3a6d3aa server/src/com/cloud/template/TemplateManagerImpl.java 273614c setup/db/db/schema-410to420.sql d2add32 Diff: https://reviews.apache.org/r/12079/diff/ Testing --- Tested with latest master, also upgrade case. Thanks, Harikrishna Patnala
Review Request 12102: Fix for CLOUDSTACK-3208: showing xenhost username and password details in plain text in logs when we pefrom removehost from CS
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12102/ --- Review request for cloudstack and Abhinandan Prateek. Bugs: CLOUDSTACK-3208 Repository: cloudstack-git Description --- CLOUDSTACK-3208: showing xenhost username and password details in plain text in logs when we pefrom removehost from CS Diffs - plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServerConnectionPool.java e4dd675 Diff: https://reviews.apache.org/r/12102/diff/ Testing --- Thanks, Harikrishna Patnala
Review Request 12136: Fix for CLOUDSTACK-3245: non admin user not able to register template
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12136/ --- Review request for cloudstack, Alena Prokharchyk and Abhinandan Prateek. Bugs: CLOUDSTACK-3245 Repository: cloudstack-git Description --- CLOUDSTACK-3245: non admin user not able to register template During registering template Admin only API parameter is set defaulted to false in the API layer if it is not set which causing user to fail registering template. Diffs - api/src/org/apache/cloudstack/api/command/user/template/RegisterTemplateCmd.java 13bd5da server/src/com/cloud/template/TemplateAdapterBase.java 7835680 Diff: https://reviews.apache.org/r/12136/diff/ Testing --- Thanks, Harikrishna Patnala
Re: Unable to register templates and ISOs
Can you try troubleshooting the SSVM by following this link
https://cwiki.apache.org/CLOUDSTACK/ssvm-templates-secondary-storage-troubleshooting.html
Probably agent is not running in the SSVM due to which no entry is created in
the host table.
please try building systemvm and recreate ssvm
-Harikrishna
On 29-Jun-2013, at 9:37 AM, Nguyen Anh Tu
ng.t...@gmail.commailto:ng.t...@gmail.com
wrote:
Hi,
I got the same issue. Log say there is no secondary storage... and I see
no record for ssvm in host table in DB.
I cc your question to dev maillist. Anyone can help?
Sent from my GT-N7000
On 29 Jun 2013 03:30, Tim Schultheiss
tschulthe...@dynamicquest.commailto:tschulthe...@dynamicquest.com
wrote:
Hi all,
I have a CS 4.1 zone with XenServer 6.1 hosts. They were configured
locally,
disconnected and sent to a remote site, and then reconnected. After
reconnecting, I cannot register anything to the secondary storage in this
zone. I checked the logs and saw that it said that my two secondary storage
shares have no storage hosts. I have restarted the SSVM, deleted both it
and
the Console Proxy, and verified that they were remade.
I can create instances from any templates already imported. The status of
any template or ISO created is blank, and if I attempt to copy one over
from
another zone, it fails as well.
Can anyone offer any insight?
Here's what the log says:
2013-06-28 14:21:45,987 DEBUG [cloud.api.ApiServlet]
(catalina-exec-23:null)
===START=== 74.122.165.4 -- GET
command=registerIsoresponse=jsonsessionkey=H4EadP%2Bc8GKR0Ym224FWLav13Tw%3
Dname=CentOS+6.4+MinimaldisplayText=CentOS+6.4+Minimalurl=http%3A%2F%2Fmi
rrors.vpsnoc.comhttp://rrors.vpsnoc.com
%2FCentOS%2F6%2Fisos%2Fx86_642FCentOS-6.4-x86_64-minimal.iso
zoneid=5f86ad9d-d8bc-4832-8fcb-838586f2ba5cisextractable=falsebootable=tr
ueosTypeId=63d22a42-d9a9-11e2-a93bb6bd483074ccispublic=falseisfeatured=fa
lse_=1372443705867
2013-06-28 14:21:46,225 WARN [storage.download.DownloadMonitorImpl]
(catalina-exec-23:null) There is no secondary storage VM for secondary
storage host nfs://10.147.36.75/export/secondary
2013-06-28 14:21:46,325 DEBUG [cloud.api.ApiServlet]
(catalina-exec-23:null)
===END=== 74.122.165.4 -- GET
command=registerIsoresponse=jsonsessionkey=H4EadP%2Bc8GKR0Ym224FWLav13Tw%3
Dname=CentOS+6.4+MinimaldisplayText=CentOS+6.4+Minimalurl=http%3A%2F%2Fmi
rrors.vpsnoc.com
%2FCentOS%2F6%2Fisos%2Fx86_642FCentOS-6.4-x86_64-minimal.iso
zoneid=5f86ad9d-d8bc-4832-8fcb-838586f2ba5cisextractable=falsebootable=tr
ueosTypeId=63d22a42-d9a9-11e2-a93bb6bd483074ccispublic=falseisfeatured=fa
lse_=1372443705867
2013-06-28 14:22:00,453 DEBUG
[storage.secondary.SecondaryStorageManagerImpl] (secstorage-1:null) Zone 10
is ready to launch secondary storage VM
2013-06-28 14:22:01,218 DEBUG [cloud.consoleproxy.ConsoleProxyManagerImpl]
(consoleproxy-1:null) Zone 10 is ready to launch console proxy
2013-06-28 14:22:03,252 DEBUG [cloud.server.StatsCollector]
(StatsCollector-2:null) VmStatsCollector is running...
2013-06-28 14:22:03,295 DEBUG [agent.manager.ClusteredAgentAttache]
(StatsCollector-2:null) Seq 26-927141969: Forwarding null to
147455086999471
2013-06-28 14:22:04,256 DEBUG [agent.transport.Request]
(StatsCollector-2:null) Seq 26-927141969: Received: { Ans: , MgmtId:
227165843378938, via: 26, Ver: v1, Flags: 10, {GetVmStatsAnswer } }
2013-06-28 14:22:04,282 DEBUG [agent.manager.ClusteredAgentAttache]
(StatsCollector-2:null) Seq 27-1832978880: Forwarding null to
147455086999471
2013-06-28 14:22:05,365 DEBUG [agent.transport.Request]
(StatsCollector-2:null) Seq 27-1832978880: Received: { Ans: , MgmtId:
227165843378938, via: 27, Ver: v1, Flags: 10, {GetVmStatsAnswer } }
2013-06-28 14:22:18,465 DEBUG [cloud.server.StatsCollector]
(StatsCollector-2:null) StorageCollector is running...
2013-06-28 14:22:18,476 DEBUG [cloud.server.StatsCollector]
(StatsCollector-2:null) There is no secondary storage VM for secondary
storage host nfs://10.147.36.75/export/secondary
2013-06-28 14:22:18,480 DEBUG [cloud.server.StatsCollector]
(StatsCollector-2:null) There is no secondary storage VM for secondary
storage host nfs://10.147.36.76/export/secondary
2013-06-28 14:22:18,501 DEBUG [agent.manager.ClusteredAgentAttache]
(StatsCollector-2:null) Seq 26-927141970: Forwarding null to
147455086999471
Review Request 12232: CLOUDSTACK-3324: Fix/Improve upgrade system vm templates 41 to 42
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12232/ --- Review request for cloudstack, Abhinandan Prateek and Kishan Kavala. Bugs: CLOUDSTACK-3324 Repository: cloudstack-git Description --- CLOUDSTACK-3324: Fix/Improve upgrade system vm template 41 to 42 During upgrade system vm template from 4.1 to 4.2 there are case sensitive checks happening which needs to be fixed and improve by generalizing the code for all hypervisors Diffs - engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java da68348 Diff: https://reviews.apache.org/r/12232/diff/ Testing --- Tested locally Thanks, Harikrishna Patnala
Review Request 12233: CLOUDSTACK-3324: Fix/Improve upgrade system vm templates 41 to 42 (Stable master Patch)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12233/ --- Review request for cloudstack, Abhinandan Prateek and Kishan Kavala. Bugs: CLOUDSTACK-3324 Repository: cloudstack-git Description --- CLOUDSTACK-3324: Fix/Improve upgrade system vm template 41 to 42 During upgrade system vm template from 4.1 to 4.2 there are case sensitive checks happening which needs to be fixed and improve by generalizing the code for all hypervisors Diffs - engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java 90a311b Diff: https://reviews.apache.org/r/12233/diff/ Testing --- Tested locally Thanks, Harikrishna Patnala
Review Request 12242: CLOUDSTACK-3302: [Multiple_IP_Ranges][VmWare] VM deployement failed due to dnsmasq configuration issue in case of multiple subnets in a vlan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12242/ --- Review request for cloudstack and Abhinandan Prateek. Bugs: CLOUDSTACK-3302 Repository: cloudstack-git Description --- CLOUDSTACK-3302: [Multiple_IP_Ranges][VmWare] VM deployement failed due to dnsmasq configuration issue in case of multiple subnets in a vlan Diffs - plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 46e5cf9 Diff: https://reviews.apache.org/r/12242/diff/ Testing --- Tested locally Thanks, Harikrishna Patnala
Review Request 12263: CLOUDSTACK-3354: [automation] scale up VM is failing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12263/ --- Review request for cloudstack, Abhinandan Prateek and Nitin Mehta. Bugs: CLOUDSTACK-3354 Repository: cloudstack-git Description --- CLOUDSTACK-3354: [automation] scale up VM is failing Marking default centos template as dynamically_scalable template. Diffs - setup/db/db/schema-410to420.sql 11204c7 Diff: https://reviews.apache.org/r/12263/diff/ Testing --- Thanks, Harikrishna Patnala
Review Request 12264: CLOUDSTACK-3351: Fix add cluster API to set right hypervisor type
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12264/ --- Review request for cloudstack and Abhinandan Prateek. Bugs: CLOUDSTACK-3351 Repository: cloudstack-git Description --- CLOUDSTACK-3351: Fix add cluster API to set right hypervisor type In AddCluster API we validate Hypervisor type parameter even if it is case insensitive. We should not put this case insensitive value in the DB which may lead to mismatch with hypervisor type with other tables in DB leading to failure of various DB queries. Diffs - server/src/com/cloud/resource/ResourceManagerImpl.java c6e8d7d Diff: https://reviews.apache.org/r/12264/diff/ Testing --- Thanks, Harikrishna Patnala
Re: Review Request 12264: CLOUDSTACK-3351: Fix add cluster API to set right hypervisor type
On July 4, 2013, 9:10 a.m., Nitin Mehta wrote: Since we have already put it to be case insensitive will this be causing issues for upgrade or anywhere else we are comparing. This is concerning As long as we get hypervisor type from clusterVO there is no problem since VO converts it to right hypervisor type. But there might be a problem if there are any queries taking hypervisor type from cluster table. - Harikrishna --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12264/#review22759 --- On July 4, 2013, 8:40 a.m., Harikrishna Patnala wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12264/ --- (Updated July 4, 2013, 8:40 a.m.) Review request for cloudstack and Abhinandan Prateek. Bugs: CLOUDSTACK-3351 Repository: cloudstack-git Description --- CLOUDSTACK-3351: Fix add cluster API to set right hypervisor type In AddCluster API we validate Hypervisor type parameter even if it is case insensitive. We should not put this case insensitive value in the DB which may lead to mismatch with hypervisor type with other tables in DB leading to failure of various DB queries. Diffs - server/src/com/cloud/resource/ResourceManagerImpl.java c6e8d7d Diff: https://reviews.apache.org/r/12264/diff/ Testing --- Thanks, Harikrishna Patnala
Re: Review Request 12263: CLOUDSTACK-3354: [automation] scale up VM is failing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12263/ --- (Updated July 8, 2013, 6:46 a.m.) Review request for cloudstack, Abhinandan Prateek and Nitin Mehta. Changes --- Updated patch to apply on master Bugs: CLOUDSTACK-3354 Repository: cloudstack-git Description --- CLOUDSTACK-3354: [automation] scale up VM is failing Marking default centos template as dynamically_scalable template. Diffs (updated) - setup/db/db/schema-410to420.sql 8130999 Diff: https://reviews.apache.org/r/12263/diff/ Testing --- Thanks, Harikrishna Patnala
Review Request 12324: CLOUDSTACK-3358: create template from a volume/snapshot should also take input from User/Admin whether xstools / vmware tools installed in the VM
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12324/ --- Review request for cloudstack, Abhinandan Prateek and Nitin Mehta. Bugs: CLOUDSTACK-3358 Repository: cloudstack-git Description --- CLOUDSTACK-3358: create template from a volume/snapshot should also take input from User/Admin whether xstools / vmware tools installed in the VM Diffs - api/src/org/apache/cloudstack/api/command/user/template/CreateTemplateCmd.java 07aeb0a server/src/com/cloud/hypervisor/HypervisorGuruBase.java 50bfb30 server/src/com/cloud/template/TemplateManagerImpl.java 5a54656 Diff: https://reviews.apache.org/r/12324/diff/ Testing --- Thanks, Harikrishna Patnala
Re: Review Request 12324: CLOUDSTACK-3358: create template from a volume/snapshot should also take input from User/Admin whether xstools / vmware tools installed in the VM
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12324/ --- (Updated July 8, 2013, 9:43 a.m.) Review request for cloudstack, Abhinandan Prateek and Nitin Mehta. Bugs: CLOUDSTACK-3358 Repository: cloudstack-git Description --- CLOUDSTACK-3358: create template from a volume/snapshot should also take input from User/Admin whether xstools / vmware tools installed in the VM Diffs (updated) - api/src/org/apache/cloudstack/api/command/user/template/CreateTemplateCmd.java 07aeb0a server/src/com/cloud/hypervisor/HypervisorGuruBase.java 50bfb30 server/src/com/cloud/template/TemplateManagerImpl.java 5a54656 Diff: https://reviews.apache.org/r/12324/diff/ Testing --- Thanks, Harikrishna Patnala
Re: Review Request 12358: CLOUDSTACK-3228: system vms are not comming up in zone with two cluster xen and kvm
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12358/ --- (Updated July 9, 2013, 10:34 a.m.) Review request for cloudstack, Abhinandan Prateek and Nitin Mehta. Bugs: CLOUDSTACK-3228 Repository: cloudstack-git Description --- CLOUDSTACK-3228: system vms are not comming up in zone with two cluster xen and kvm;Zone host is ready, but secondary storage vm template: 3 is not ready on secondary storage: 2 Shuffling the hypervisors list before getting the first hypervisor in list so that on every retry of system vm deployment it chooses different hypervisor and checking whether template is downloaded or not. Diffs - plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java 407f069 server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java 5983aa7 server/src/com/cloud/resource/ResourceManagerImpl.java 41c6ad7 server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java 05256a8 Diff: https://reviews.apache.org/r/12358/diff/ Testing --- tested locally Thanks, Harikrishna Patnala
Re: Review Request 12358: CLOUDSTACK-3228: system vms are not comming up in zone with two cluster xen and kvm
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12358/ --- (Updated July 9, 2013, 3:02 p.m.) Review request for cloudstack, Abhinandan Prateek and Nitin Mehta. Changes --- Changed the way of getting right template. Instead of shuffling the hypervisor list, we make a try on each hypervisor until it gets a right template. Bugs: CLOUDSTACK-3228 Repository: cloudstack-git Description --- CLOUDSTACK-3228: system vms are not comming up in zone with two cluster xen and kvm;Zone host is ready, but secondary storage vm template: 3 is not ready on secondary storage: 2 Shuffling the hypervisors list before getting the first hypervisor in list so that on every retry of system vm deployment it chooses different hypervisor and checking whether template is downloaded or not. Diffs (updated) - engine/schema/src/com/cloud/storage/dao/VMTemplateDaoImpl.java 9e75990 plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java 407f069 server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java 5983aa7 server/src/com/cloud/resource/ResourceManager.java e35e89a server/src/com/cloud/resource/ResourceManagerImpl.java 41c6ad7 server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java 05256a8 server/test/com/cloud/resource/MockResourceManagerImpl.java 18cff80 Diff: https://reviews.apache.org/r/12358/diff/ Testing --- tested locally Thanks, Harikrishna Patnala
Re: Review Request 12427: Fix for CLOUDSTACK-3365 and CLOUDSTACK-2536
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12427/ --- (Updated July 10, 2013, 10:14 a.m.) Review request for cloudstack, Abhinandan Prateek and Koushik Das. Changes --- Added fix for CLOUDSTACK-2536 Summary (updated) - Fix for CLOUDSTACK-3365 and CLOUDSTACK-2536 Bugs: CLOUDSTACK-2536 and CLOUDSTACK-3365 Repository: cloudstack-git Description (updated) --- CLOUDSTACK-3365: cluster level parameters cluster.(cpu/memory).allocated.capacity.notificationthreshold is not considering overcommit value CLOUDSTACK-2536: parameters (cpu/memory)overcommit ratio and (cpu/memory).overprosioning.factor are redundant(cluster level) Diffs (updated) - server/src/com/cloud/alert/AlertManagerImpl.java 9b7cd27 server/src/com/cloud/configuration/Config.java 1a2c620 server/src/com/cloud/vm/VirtualMachineManagerImpl.java 30ee2d7 server/test/com/cloud/vm/VirtualMachineManagerImplTest.java 44e22e2 Diff: https://reviews.apache.org/r/12427/diff/ Testing --- Tested locally both with actual usage and over committed values for memory. Thanks, Harikrishna Patnala
Re: Review Request 12427: Fix for CLOUDSTACK-3365 and CLOUDSTACK-2536
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12427/ --- (Updated July 10, 2013, 10:19 a.m.) Review request for cloudstack, Abhinandan Prateek and Koushik Das. Bugs: CLOUDSTACK-2536 and CLOUDSTACK-3365 Repository: cloudstack-git Description --- CLOUDSTACK-3365: cluster level parameters cluster.(cpu/memory).allocated.capacity.notificationthreshold is not considering overcommit value CLOUDSTACK-2536: parameters (cpu/memory)overcommit ratio and (cpu/memory).overprosioning.factor are redundant(cluster level) Diffs (updated) - server/src/com/cloud/alert/AlertManagerImpl.java 9b7cd27 server/src/com/cloud/configuration/Config.java d3ed718 server/src/com/cloud/vm/VirtualMachineManagerImpl.java 30ee2d7 server/test/com/cloud/vm/VirtualMachineManagerImplTest.java 44e22e2 Diff: https://reviews.apache.org/r/12427/diff/ Testing --- Tested locally both with actual usage and over committed values for memory. Thanks, Harikrishna Patnala
Re: Review Request 12358: CLOUDSTACK-3228: system vms are not comming up in zone with two cluster xen and kvm
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12358/ --- (Updated July 10, 2013, 10:56 a.m.) Review request for cloudstack and Nitin Mehta. Bugs: CLOUDSTACK-3228 Repository: cloudstack-git Description --- CLOUDSTACK-3228: system vms are not comming up in zone with two cluster xen and kvm;Zone host is ready, but secondary storage vm template: 3 is not ready on secondary storage: 2 Shuffling the hypervisors list before getting the first hypervisor in list so that on every retry of system vm deployment it chooses different hypervisor and checking whether template is downloaded or not. Diffs - engine/schema/src/com/cloud/storage/dao/VMTemplateDaoImpl.java 9e75990 plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java 407f069 server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java 5983aa7 server/src/com/cloud/resource/ResourceManager.java e35e89a server/src/com/cloud/resource/ResourceManagerImpl.java 41c6ad7 server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java 05256a8 server/test/com/cloud/resource/MockResourceManagerImpl.java 18cff80 Diff: https://reviews.apache.org/r/12358/diff/ Testing --- tested locally Thanks, Harikrishna Patnala
Review Request 12498: CLOUDSTACK-2987: Fixing dynamicallyscalable flag in register and update template API
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12498/ --- Review request for cloudstack, Abhinandan Prateek and edison su. Bugs: CLOUDSTACK-2987 Repository: cloudstack-git Description --- CLOUDSTACK-2987: Fixing dynamicallyscalable flag in register and update template API This has to be fixed due to the merges post to my commit 7b6b8d7a077478620232ea1ac4ec2304289e8661 which is working fine. Diffs - engine/schema/src/com/cloud/storage/VMTemplateVO.java 3e71191 server/src/com/cloud/template/TemplateAdapterBase.java fce2506 server/src/com/cloud/template/TemplateManagerImpl.java 5a54656 Diff: https://reviews.apache.org/r/12498/diff/ Testing --- Thanks, Harikrishna Patnala
Re: Review Request 12498: CLOUDSTACK-2987: Fixing dynamicallyscalable flag in register and update template API
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12498/ --- (Updated July 12, 2013, 9:48 a.m.) Review request for cloudstack, Abhinandan Prateek, edison su, and Nitin Mehta. Bugs: CLOUDSTACK-2987 Repository: cloudstack-git Description --- CLOUDSTACK-2987: Fixing dynamicallyscalable flag in register and update template API This has to be fixed due to the merges post to my commit 7b6b8d7a077478620232ea1ac4ec2304289e8661 which is working fine. Diffs - engine/schema/src/com/cloud/storage/VMTemplateVO.java 3e71191 server/src/com/cloud/template/TemplateAdapterBase.java fce2506 server/src/com/cloud/template/TemplateManagerImpl.java 5a54656 Diff: https://reviews.apache.org/r/12498/diff/ Testing --- Thanks, Harikrishna Patnala
Re: Review Request 12324: CLOUDSTACK-3358: create template from a volume/snapshot should also take input from User/Admin whether xstools / vmware tools installed in the VM
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12324/ --- (Updated July 15, 2013, 12:10 p.m.) Review request for cloudstack, Abhinandan Prateek and Nitin Mehta. Changes --- updated diff after rebase Bugs: CLOUDSTACK-3358 Repository: cloudstack-git Description --- CLOUDSTACK-3358: create template from a volume/snapshot should also take input from User/Admin whether xstools / vmware tools installed in the VM Diffs (updated) - api/src/org/apache/cloudstack/api/command/user/template/CreateTemplateCmd.java 07aeb0a server/src/com/cloud/hypervisor/HypervisorGuruBase.java 769648a server/src/com/cloud/template/TemplateManagerImpl.java 18a69ca Diff: https://reviews.apache.org/r/12324/diff/ Testing --- Thanks, Harikrishna Patnala
Re: Review board is not accessible.
Me too not able to access Review board. Fix for a blocker bug is in pending so attaching the patch to the bug ticket itself. https://issues.apache.org/jira/browse/CLOUDSTACK-3551 Can someone review my patch and commit. Thanks, Harikrishna On 16-Jul-2013, at 3:46 PM, Bharat Kumar bharat.ku...@citrix.com wrote: Can some one restart it .
Re: Review Request 12324: CLOUDSTACK-3358: create template from a volume/snapshot should also take input from User/Admin whether xstools / vmware tools installed in the VM
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12324/#review23243 --- api/src/org/apache/cloudstack/api/command/user/template/CreateTemplateCmd.java https://reviews.apache.org/r/12324/#comment47140 This will be inconsistent at some times when we create template from snapshot. Lets consider this case. 1) Template1: does not have xstools 2) install XS tools on the VM. 3) create vm and take snapshot of that volume. 4) now create template from snapshot created in step(3) We don't know whether tools are installed in the VM or not at the time of creation of snapshot. Steps 2 and 3 may occur many times. We cannot decide whether snapshot have XS tools are not? Please let me know if I'm missing anything. Thankyou - Harikrishna Patnala On July 15, 2013, 12:10 p.m., Harikrishna Patnala wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12324/ --- (Updated July 15, 2013, 12:10 p.m.) Review request for cloudstack, Abhinandan Prateek and Nitin Mehta. Bugs: CLOUDSTACK-3358 Repository: cloudstack-git Description --- CLOUDSTACK-3358: create template from a volume/snapshot should also take input from User/Admin whether xstools / vmware tools installed in the VM Diffs - api/src/org/apache/cloudstack/api/command/user/template/CreateTemplateCmd.java 07aeb0a server/src/com/cloud/hypervisor/HypervisorGuruBase.java 769648a server/src/com/cloud/template/TemplateManagerImpl.java 18a69ca Diff: https://reviews.apache.org/r/12324/diff/ Testing --- Thanks, Harikrishna Patnala
Review Request 12632: CLOUDSTACK-3551: Fix value over flow due to type conversion
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12632/ --- Review request for cloudstack and Nitin Mehta. Bugs: CLOUDSTACK-3551 Repository: cloudstack-git Description --- CLOUDSTACK-3551: scaling up VM to service offering with 2gbram Fixed the type overflow of Ram value. Diffs - plugins/hypervisors/baremetal/src/com/cloud/baremetal/manager/BareMetalPlanner.java 97b2840 server/src/com/cloud/capacity/CapacityManagerImpl.java d54624d server/src/com/cloud/vm/VirtualMachineManagerImpl.java 827e233 Diff: https://reviews.apache.org/r/12632/diff/ Testing --- Tested locally Thanks, Harikrishna Patnala
Re: Review Request 12427: Fix for CLOUDSTACK-3365 and CLOUDSTACK-2536
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12427/ --- (Updated July 17, 2013, 7:37 a.m.) Review request for cloudstack, Abhinandan Prateek, Koushik Das, and Nitin Mehta. Changes --- Updated patch based on review comments Bugs: CLOUDSTACK-2536 and CLOUDSTACK-3365 Repository: cloudstack-git Description --- CLOUDSTACK-3365: cluster level parameters cluster.(cpu/memory).allocated.capacity.notificationthreshold is not considering overcommit value CLOUDSTACK-2536: parameters (cpu/memory)overcommit ratio and (cpu/memory).overprosioning.factor are redundant(cluster level) Diffs (updated) - server/src/com/cloud/alert/AlertManagerImpl.java 9b7cd27 server/src/com/cloud/configuration/Config.java e77f6ce server/src/com/cloud/vm/VirtualMachineManagerImpl.java 827e233 server/test/com/cloud/vm/VirtualMachineManagerImplTest.java 44e22e2 Diff: https://reviews.apache.org/r/12427/diff/ Testing --- Tested locally both with actual usage and over committed values for memory. Thanks, Harikrishna Patnala
Re: Review Request 12427: Fix for CLOUDSTACK-3365 and CLOUDSTACK-2536
On July 17, 2013, 5:38 a.m., Nitin Mehta wrote: server/src/com/cloud/configuration/Config.java, line 202 https://reviews.apache.org/r/12427/diff/3/?file=319814#file319814line202 Please clarify - Are they not at cluster level anymore ? These are cluster level parameters but can be modified only using UpdateCluster API since this needs some other updates not just DB change that we do in UpdateConfiguration. On July 17, 2013, 5:38 a.m., Nitin Mehta wrote: server/src/com/cloud/vm/VirtualMachineManagerImpl.java, line 3243 https://reviews.apache.org/r/12427/diff/3/?file=319815#file319815line3243 What was wrong here...why not taking it from Config ? Since we have removed the scope of these parameters from cluster. This method cant be used to get the value. - Harikrishna --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12427/#review23239 --- On July 10, 2013, 10:56 a.m., Harikrishna Patnala wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12427/ --- (Updated July 10, 2013, 10:56 a.m.) Review request for cloudstack, Abhinandan Prateek, Koushik Das, and Nitin Mehta. Bugs: CLOUDSTACK-2536 and CLOUDSTACK-3365 Repository: cloudstack-git Description --- CLOUDSTACK-3365: cluster level parameters cluster.(cpu/memory).allocated.capacity.notificationthreshold is not considering overcommit value CLOUDSTACK-2536: parameters (cpu/memory)overcommit ratio and (cpu/memory).overprosioning.factor are redundant(cluster level) Diffs - server/src/com/cloud/alert/AlertManagerImpl.java 9b7cd27 server/src/com/cloud/configuration/Config.java d3ed718 server/src/com/cloud/vm/VirtualMachineManagerImpl.java 30ee2d7 server/test/com/cloud/vm/VirtualMachineManagerImplTest.java 44e22e2 Diff: https://reviews.apache.org/r/12427/diff/ Testing --- Tested locally both with actual usage and over committed values for memory. Thanks, Harikrishna Patnala
Re: Review Request 12358: CLOUDSTACK-3228: system vms are not comming up in zone with two cluster xen and kvm
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12358/ --- (Updated July 18, 2013, 9:23 a.m.) Review request for cloudstack and Nitin Mehta. Changes --- Updated patch based on review comments and included an enhancement on retry mechanism of system vm deployment Bugs: CLOUDSTACK-3228 and CLOUDSTACK-3631 Repository: cloudstack-git Description (updated) --- CLOUDSTACK-3228: system vms are not comming up in zone with two cluster xen and kvm;Zone host is ready, but secondary storage vm template: 3 is not ready on secondary storage: 2 CLOUDSTACK-3631: Enhance System vm deployment retry mechanism Diffs (updated) - engine/schema/src/com/cloud/storage/dao/VMTemplateDao.java c3d44bd engine/schema/src/com/cloud/storage/dao/VMTemplateDaoImpl.java 9e75990 plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java 2cc592d server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java 5983aa7 server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java 6859b0b Diff: https://reviews.apache.org/r/12358/diff/ Testing --- tested locally Thanks, Harikrishna Patnala
Review Request 12719: CLOUDSTACK-3634: Adding router.template.xen/kvm/hyperv/kvm/lxc in upgrade setup
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12719/ --- Review request for cloudstack, Abhinandan Prateek and Kishan Kavala. Bugs: CLOUDSTACK-3634 Repository: cloudstack-git Description --- CLOUDSTACK-3634: Adding router.template.xen/kvm/hyperv/kvm/lxc in upgrade setup Presently during system vm template upgrade from 4.1 to 4.2 takes care of inserting these parameters. Adding now in 4.1 to 4.2 sql file so that normal developer upgrade does not fail in deploying router. Diffs - engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java e37ccd5 setup/db/db/schema-410to420.sql 40e3d2b Diff: https://reviews.apache.org/r/12719/diff/ Testing --- Thanks, Harikrishna Patnala
Re: Review Request 12719: CLOUDSTACK-3634: Adding router.template.xen/kvm/hyperv/kvm/lxc in upgrade setup
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12719/ --- (Updated July 19, 2013, 6:55 a.m.) Review request for cloudstack, Abhinandan Prateek, Jayapal Reddy, and Kishan Kavala. Bugs: CLOUDSTACK-3634 Repository: cloudstack-git Description --- CLOUDSTACK-3634: Adding router.template.xen/kvm/hyperv/kvm/lxc in upgrade setup Presently during system vm template upgrade from 4.1 to 4.2 takes care of inserting these parameters. Adding now in 4.1 to 4.2 sql file so that normal developer upgrade does not fail in deploying router. Diffs - engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java e37ccd5 setup/db/db/schema-410to420.sql 40e3d2b Diff: https://reviews.apache.org/r/12719/diff/ Testing --- Thanks, Harikrishna Patnala
Review Request 12757: CLOUDSTACK-3634: Adding router.template.xen/kvm/hyperv/kvm/lxc in upgrade setup
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12757/ --- Review request for cloudstack, Jayapal Reddy and Kishan Kavala. Bugs: CLOUDSTACK-3634 Repository: cloudstack-git Description --- CLOUDSTACK-3634: Adding router.template.xen/kvm/hyperv/kvm/lxc in upgrade setup Presently during system vm template upgrade from 4.1 to 4.2 takes care of inserting these parameters. Adding now in 4.1 to 4.2 sql file so that normal developer upgrade does not fail in deploying router. Diffs - engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java e54a699 setup/db/db/schema-410to420.sql 921d5fa Diff: https://reviews.apache.org/r/12757/diff/ Testing --- Thanks, Harikrishna Patnala
Re: Review Request 12757: [4.2]CLOUDSTACK-3634: Adding router.template.xen/kvm/hyperv/kvm/lxc in upgrade setup
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12757/ --- (Updated July 19, 2013, 8:52 a.m.) Review request for cloudstack, Jayapal Reddy and Kishan Kavala. Summary (updated) - [4.2]CLOUDSTACK-3634: Adding router.template.xen/kvm/hyperv/kvm/lxc in upgrade setup Bugs: CLOUDSTACK-3634 Repository: cloudstack-git Description --- CLOUDSTACK-3634: Adding router.template.xen/kvm/hyperv/kvm/lxc in upgrade setup Presently during system vm template upgrade from 4.1 to 4.2 takes care of inserting these parameters. Adding now in 4.1 to 4.2 sql file so that normal developer upgrade does not fail in deploying router. Diffs - engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java e54a699 setup/db/db/schema-410to420.sql 921d5fa Diff: https://reviews.apache.org/r/12757/diff/ Testing --- Thanks, Harikrishna Patnala
Re: Review Request 12427: Fix for CLOUDSTACK-3365: cluster level parameters cluster.(cpu/memory).allocated.capacity.notificationthreshold is not considering overcommit value
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12427/ --- (Updated July 19, 2013, 10:14 a.m.) Review request for cloudstack, Abhinandan Prateek, Koushik Das, and Nitin Mehta. Changes --- removed the fix for 2536. Summary (updated) - Fix for CLOUDSTACK-3365: cluster level parameters cluster.(cpu/memory).allocated.capacity.notificationthreshold is not considering overcommit value Bugs: CLOUDSTACK-3365 Repository: cloudstack-git Description (updated) --- CLOUDSTACK-3365: cluster level parameters cluster.(cpu/memory).allocated.capacity.notificationthreshold is not considering overcommit value Diffs (updated) - server/src/com/cloud/alert/AlertManagerImpl.java 9b7cd27 Diff: https://reviews.apache.org/r/12427/diff/ Testing --- Tested locally both with actual usage and over committed values for memory. Thanks, Harikrishna Patnala
Re: 41-42 db upgrade
Hi During system vm template upgrade from 41 to 42 takes care of insertion of router.template.xen/* parameters. But checked in my part so that it does nt break any upgrade by developer. Thanks Harikrishna On 18-Jul-2013, at 2:39 AM, Min Chen min.c...@citrix.commailto:min.c...@citrix.com wrote: Checked in my part into 4.2 and master branch. Thanks -min From: Alena Prokharchyk alena.prokharc...@citrix.commailto:alena.prokharc...@citrix.com Date: Wednesday, July 17, 2013 1:26 PM To: Harikrishna Patnala harikrishna.patn...@citrix.commailto:harikrishna.patn...@citrix.com, Min Chen min.c...@citrix.commailto:min.c...@citrix.com, Rajesh Battala rajesh.batt...@citrix.commailto:rajesh.batt...@citrix.com, Edison Su edison...@citrix.commailto:edison...@citrix.com, Sateesh Chodapuneedi sateesh.chodapune...@citrix.commailto:sateesh.chodapune...@citrix.com, Hugo Trippaers htrippa...@schubergphilis.commailto:htrippa...@schubergphilis.com, mice xia mice_...@tcloudcomputing.commailto:mice_...@tcloudcomputing.com Cc: Animesh Chaturvedi animesh.chaturv...@citrix.commailto:animesh.chaturv...@citrix.com, Chandan Purushothama chandan.purushoth...@citrix.commailto:chandan.purushoth...@citrix.com, Sudha Ponnaganti sudha.ponnaga...@citrix.commailto:sudha.ponnaga...@citrix.com, dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org Subject: 41-42 db upgrade There is a bug in 41-42 db upgrade process – some global configs are missing in upgraded setup: https://issues.apache.org/jira/browse/CLOUDSTACK-3601 Can please everyone from below list, insert them in as a part of 41-42 db upgrade sql script, as it is a part of your feature(s)? * Harikrishna: router.template.hyperv and the rest of template related configuration * Min: s3.rrs.enabled * Rajesh: healthcheck.update.interval * Edison: snapshot.backup.rightafter, storage.cache*' * Sateesh: vmware.ports.per.dvportgroup, vmware.use.dvswitch * Hugo: vmware.nested.virtualization * Mice: vmsnapshot.max, vmsnapshot.create.wait Thanks! -Alena.
Review Request 12759: CLOUDSTACK-3669: Bringing down the dynamic scalable check (for VM whether it has xstools or vmware tools in it) to the management layer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12759/ --- Review request for cloudstack, Abhinandan Prateek and Nitin Mehta. Bugs: CLOUDSTACK-3669 Repository: cloudstack-git Description --- CLOUDSTACK-3669: Bringing down the dynamic scalable check (for VM whether it has xstools or vmware tools in it) to the management layer. Diffs - core/src/com/cloud/agent/api/ScaleVmCommand.java 83cdcac plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java f80d4b6 server/src/com/cloud/vm/UserVmManagerImpl.java adcf475 server/src/com/cloud/vm/VirtualMachineManagerImpl.java 7a4bf50 server/test/com/cloud/vm/VirtualMachineManagerImplTest.java 1e6d005 Diff: https://reviews.apache.org/r/12759/diff/ Testing --- Thanks, Harikrishna Patnala
Review Request 12808: Fix for CLOUDSTACK-2536: updating parameters (cpu/memory)overcommit ratio and (cpu/memory).overprosioning.factor are redundant(cluster level)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12808/ --- Review request for cloudstack, Koushik Das and Nitin Mehta. Bugs: CLOUDSTACK-2536 Repository: cloudstack-git Description --- CLOUDSTACK-2536: updating parameters (cpu/memory)overcommit ratio and (cpu/memory).overprosioning.factor are redundant(cluster level) There are two APIs updateCluster and UpdateConfiguration where we can update these parameters. Ideally this should get updated using updateConfiguration API, so removing from updateCluster API Diffs - api/src/com/cloud/resource/ResourceService.java 25298cc api/src/org/apache/cloudstack/api/command/admin/cluster/UpdateClusterCmd.java a14f905 server/src/com/cloud/configuration/ConfigurationManagerImpl.java 92178c9 server/src/com/cloud/resource/ResourceManagerImpl.java d7652f4 server/test/com/cloud/resource/MockResourceManagerImpl.java 2c66134 Diff: https://reviews.apache.org/r/12808/diff/ Testing --- Thanks, Harikrishna Patnala
Re: Review Request 12809: Fix for CLOUDSTACK-3703: change service offering of stopped vm on kvm is failing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12809/ --- (Updated July 22, 2013, 1:42 p.m.) Review request for cloudstack, Koushik Das and Nitin Mehta. Changes --- Updated patch with test case changes Bugs: CLOUDSTACK-3703 Repository: cloudstack-git Description --- CLOUDSTACK-3703: change service offering of stopped vm on kvm is failing Diffs (updated) - server/src/com/cloud/vm/UserVmManagerImpl.java adcf475 server/test/com/cloud/vm/UserVmManagerTest.java 0eb9a08 Diff: https://reviews.apache.org/r/12809/diff/ Testing --- Thanks, Harikrishna Patnala
Re: Review Request 12808: Fix for CLOUDSTACK-2536: updating parameters (cpu/memory)overcommit ratio and (cpu/memory).overprosioning.factor are redundant(cluster level)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12808/ --- (Updated July 23, 2013, 11:41 a.m.) Review request for cloudstack, Koushik Das and Nitin Mehta. Changes --- Removing parameters from both AddCluster and UpdateCluster APIs. While creating new cluster by default (cpu/memory).overprosioning.factor values are taken from global configuration parameters Bugs: CLOUDSTACK-1528 and CLOUDSTACK-2536 Repository: cloudstack-git Description --- CLOUDSTACK-2536: updating parameters (cpu/memory)overcommit ratio and (cpu/memory).overprosioning.factor are redundant(cluster level) There are two APIs updateCluster and UpdateConfiguration where we can update these parameters. Ideally this should get updated using updateConfiguration API, so removing from updateCluster API Diffs (updated) - api/src/com/cloud/resource/ResourceService.java 25298cc api/src/org/apache/cloudstack/api/ApiConstants.java 0550a39 api/src/org/apache/cloudstack/api/command/admin/cluster/AddClusterCmd.java c6ca9bc6 api/src/org/apache/cloudstack/api/command/admin/cluster/UpdateClusterCmd.java a14f905 server/src/com/cloud/configuration/ConfigurationManagerImpl.java 92178c9 server/src/com/cloud/resource/ResourceManagerImpl.java d7652f4 server/test/com/cloud/resource/MockResourceManagerImpl.java 2c66134 Diff: https://reviews.apache.org/r/12808/diff/ Testing --- Thanks, Harikrishna Patnala
Re: Review Request 12809: Fix for CLOUDSTACK-3703: change service offering of stopped vm on kvm is failing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12809/ --- (Updated July 24, 2013, 11:43 a.m.) Review request for cloudstack, Abhinandan Prateek and Nitin Mehta. Bugs: CLOUDSTACK-3703 Repository: cloudstack-git Description --- CLOUDSTACK-3703: change service offering of stopped vm on kvm is failing Diffs - server/src/com/cloud/vm/UserVmManagerImpl.java adcf475 server/test/com/cloud/vm/UserVmManagerTest.java 0eb9a08 Diff: https://reviews.apache.org/r/12809/diff/ Testing --- Thanks, Harikrishna Patnala
Re: Review Request 12759: CLOUDSTACK-3669: Bringing down the dynamic scalable check (for VM whether it has xstools or vmware tools in it) to the management layer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12759/ --- (Updated July 25, 2013, 6:05 a.m.) Review request for cloudstack, Abhinandan Prateek and Nitin Mehta. Changes --- resolved conflicts with master Bugs: CLOUDSTACK-3669 Repository: cloudstack-git Description --- CLOUDSTACK-3669: Bringing down the dynamic scalable check (for VM whether it has xstools or vmware tools in it) to the management layer. Diffs (updated) - core/src/com/cloud/agent/api/ScaleVmCommand.java 83cdcac plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 0fba0d9 server/src/com/cloud/vm/UserVmManagerImpl.java ae12523 server/src/com/cloud/vm/VirtualMachineManagerImpl.java 33dadf0 server/test/com/cloud/vm/VirtualMachineManagerImplTest.java 44a703d Diff: https://reviews.apache.org/r/12759/diff/ Testing --- Thanks, Harikrishna Patnala
Re: Review Request 12808: Fix for CLOUDSTACK-2536: updating parameters (cpu/memory)overcommit ratio and (cpu/memory).overprosioning.factor are redundant(cluster level)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12808/ --- (Updated July 25, 2013, 7:19 a.m.) Review request for cloudstack, Koushik Das and Nitin Mehta. Bugs: CLOUDSTACK-1528 and CLOUDSTACK-2536 Repository: cloudstack-git Description --- CLOUDSTACK-2536: updating parameters (cpu/memory)overcommit ratio and (cpu/memory).overprosioning.factor are redundant(cluster level) There are two APIs updateCluster and UpdateConfiguration where we can update these parameters. Ideally this should get updated using updateConfiguration API, so removing from updateCluster API Diffs (updated) - api/src/com/cloud/resource/ResourceService.java 25298cc api/src/org/apache/cloudstack/api/ApiConstants.java 0550a39 api/src/org/apache/cloudstack/api/command/admin/cluster/AddClusterCmd.java c6ca9bc6 api/src/org/apache/cloudstack/api/command/admin/cluster/UpdateClusterCmd.java a14f905 server/src/com/cloud/configuration/ConfigurationManagerImpl.java 9bc8efd server/src/com/cloud/resource/ResourceManagerImpl.java 342b9fd server/test/com/cloud/resource/MockResourceManagerImpl.java 2c66134 Diff: https://reviews.apache.org/r/12808/diff/ Testing --- Thanks, Harikrishna Patnala
Re: Review Request 12937: CLOUDSTACK-3779: Support System vm scaling on VMWare
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12937/ --- (Updated July 25, 2013, 10:44 a.m.) Review request for cloudstack and Nitin Mehta. Changes --- Included check for system vm on xenserver and throwing an exception accordingly Bugs: CLOUDSTACK-3779 Repository: cloudstack-git Description --- CLOUDSTACK-3779: Support System vm scaling on VMWare Marked the system template new system template as dynamicallyScalable - handled upgrade case - moved dynamicallyScalable flag to vm_instance table from user_vm_details to support dynamic scaling of system vm This patch depends on previous review request https://reviews.apache.org/r/12759/ . please review and commit accordingly Diffs (updated) - engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java d4b7b6d engine/schema/src/com/cloud/vm/VMInstanceVO.java e1d2892 engine/schema/src/com/cloud/vm/dao/UserVmDao.java b4f9991 engine/schema/src/com/cloud/vm/dao/UserVmDaoImpl.java 1c11563 plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java 2cc592d server/src/com/cloud/hypervisor/HypervisorGuruBase.java 6d368bd server/src/com/cloud/server/ManagementServerImpl.java 7ac1254 server/src/com/cloud/vm/UserVmManagerImpl.java ae12523 server/test/com/cloud/vm/VirtualMachineManagerImplTest.java 44a703d setup/db/db/schema-410to420.sql 82ca403 Diff: https://reviews.apache.org/r/12937/diff/ Testing --- Thanks, Harikrishna Patnala
Re: Review Request 12937: CLOUDSTACK-3779: Support System vm scaling on VMWare
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12937/ --- (Updated July 25, 2013, 10:45 a.m.) Review request for cloudstack and Nitin Mehta. Bugs: CLOUDSTACK-3637 and CLOUDSTACK-3779 Repository: cloudstack-git Description --- CLOUDSTACK-3779: Support System vm scaling on VMWare Marked the system template new system template as dynamicallyScalable - handled upgrade case - moved dynamicallyScalable flag to vm_instance table from user_vm_details to support dynamic scaling of system vm This patch depends on previous review request https://reviews.apache.org/r/12759/ . please review and commit accordingly Diffs - engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java d4b7b6d engine/schema/src/com/cloud/vm/VMInstanceVO.java e1d2892 engine/schema/src/com/cloud/vm/dao/UserVmDao.java b4f9991 engine/schema/src/com/cloud/vm/dao/UserVmDaoImpl.java 1c11563 plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java 2cc592d server/src/com/cloud/hypervisor/HypervisorGuruBase.java 6d368bd server/src/com/cloud/server/ManagementServerImpl.java 7ac1254 server/src/com/cloud/vm/UserVmManagerImpl.java ae12523 server/test/com/cloud/vm/VirtualMachineManagerImplTest.java 44a703d setup/db/db/schema-410to420.sql 82ca403 Diff: https://reviews.apache.org/r/12937/diff/ Testing --- Thanks, Harikrishna Patnala
Re: Review Request 12937: CLOUDSTACK-3779: Support System vm scaling on VMWare
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12937/ --- (Updated July 26, 2013, 8:41 a.m.) Review request for cloudstack and Nitin Mehta. Changes --- Changed the log message Bugs: CLOUDSTACK-3637 and CLOUDSTACK-3779 Repository: cloudstack-git Description --- CLOUDSTACK-3779: Support System vm scaling on VMWare Marked the system template new system template as dynamicallyScalable - handled upgrade case - moved dynamicallyScalable flag to vm_instance table from user_vm_details to support dynamic scaling of system vm This patch depends on previous review request https://reviews.apache.org/r/12759/ . please review and commit accordingly Diffs (updated) - engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java d4b7b6d engine/schema/src/com/cloud/vm/VMInstanceVO.java e1d2892 engine/schema/src/com/cloud/vm/dao/UserVmDao.java b4f9991 engine/schema/src/com/cloud/vm/dao/UserVmDaoImpl.java 1c11563 plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java 2cc592d server/src/com/cloud/hypervisor/HypervisorGuruBase.java 6d368bd server/src/com/cloud/server/ManagementServerImpl.java 7ac1254 server/src/com/cloud/vm/UserVmManagerImpl.java ae12523 server/test/com/cloud/vm/VirtualMachineManagerImplTest.java 44a703d setup/db/db/schema-410to420.sql 82ca403 Diff: https://reviews.apache.org/r/12937/diff/ Testing --- Thanks, Harikrishna Patnala
Re: Review Request 12937: CLOUDSTACK-3779: Support System vm scaling on VMWare
On July 26, 2013, 6:45 a.m., Nitin Mehta wrote: engine/schema/src/com/cloud/vm/VMInstanceVO.java, line 149 https://reviews.apache.org/r/12937/diff/2/?file=327891#file327891line149 we need to start showing it in response as well I have changed the uservm view table to get the value from vm_instance. Please refer to the change in schema-410to420.sql https://reviews.apache.org/r/12937/diff/#9 On July 26, 2013, 6:45 a.m., Nitin Mehta wrote: server/src/com/cloud/server/ManagementServerImpl.java, line 3749 https://reviews.apache.org/r/12937/diff/2/?file=327896#file327896line3749 Will this block KVM upgrade when the system vms are stopped This is a specific check for xenserver and running system vm. For KVM or other hypervisors condition will fail in first check itself. - Harikrishna --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12937/#review23914 --- On July 26, 2013, 8:41 a.m., Harikrishna Patnala wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12937/ --- (Updated July 26, 2013, 8:41 a.m.) Review request for cloudstack and Nitin Mehta. Bugs: CLOUDSTACK-3637 and CLOUDSTACK-3779 Repository: cloudstack-git Description --- CLOUDSTACK-3779: Support System vm scaling on VMWare Marked the system template new system template as dynamicallyScalable - handled upgrade case - moved dynamicallyScalable flag to vm_instance table from user_vm_details to support dynamic scaling of system vm This patch depends on previous review request https://reviews.apache.org/r/12759/ . please review and commit accordingly Diffs - engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java d4b7b6d engine/schema/src/com/cloud/vm/VMInstanceVO.java e1d2892 engine/schema/src/com/cloud/vm/dao/UserVmDao.java b4f9991 engine/schema/src/com/cloud/vm/dao/UserVmDaoImpl.java 1c11563 plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java 2cc592d server/src/com/cloud/hypervisor/HypervisorGuruBase.java 6d368bd server/src/com/cloud/server/ManagementServerImpl.java 7ac1254 server/src/com/cloud/vm/UserVmManagerImpl.java ae12523 server/test/com/cloud/vm/VirtualMachineManagerImplTest.java 44a703d setup/db/db/schema-410to420.sql 82ca403 Diff: https://reviews.apache.org/r/12937/diff/ Testing --- Thanks, Harikrishna Patnala
