Re: [GitHub] [daffodil] stevedlawrence commented on pull request #567: Update scala-library, scala-reflect to 2.13.6

[Beckerle, Mike]

Is scala reflect 2.13.6 actually about scala 2.13, or is it just a coincidence 
of the numbering that their sub-version number just rolled up to 13?


From: GitBox 
Sent: Tuesday, May 18, 2021 12:55 PM
To: comm...@daffodil.apache.org 
Subject: [GitHub] [daffodil] stevedlawrence commented on pull request #567: 
Update scala-library, scala-reflect to 2.13.6


stevedlawrence commented on pull request #567:
URL: https://github.com/apache/daffodil/pull/567#issuecomment-843359666


   We should just close this PR.

   There's a significant amount of changes needed to get Daffodil compiling on 
2.13.x, and we have an bug already open for this issue: 
[DAFFODIL-2152](https://issues.apache.org/jira/browse/DAFFODIL-2152). Also, PR 
#246 has some initial changes to get 2.13 to work. That PR is likely too old to 
cleanly rebase, but that is a better reference for 2.13 updates than this PR.


--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [GitHub] [daffodil] stevedlawrence commented on pull request #567: Update scala-library, scala-reflect to 2.13.6

[Steve Lawrence]

According to the scala-relfect pom [1], scala-reflect 2.13.6 depends on
scala-library 2.13.6, so I think it's the same as scala 2.13 and they
need to be upgraded together.  I'd guess that scala-reflect is split
into a separate jar because it's still considered experimental.

[1]
https://search.maven.org/artifact/org.scala-lang/scala-reflect/2.13.6/jar


On 5/18/21 1:28 PM, Beckerle, Mike wrote:
> Is scala reflect 2.13.6 actually about scala 2.13, or is it just a 
> coincidence of the numbering that their sub-version number just rolled up to 
> 13?
> 
> 
> From: GitBox 
> Sent: Tuesday, May 18, 2021 12:55 PM
> To: comm...@daffodil.apache.org 
> Subject: [GitHub] [daffodil] stevedlawrence commented on pull request #567: 
> Update scala-library, scala-reflect to 2.13.6
> 
> 
> stevedlawrence commented on pull request #567:
> URL: https://github.com/apache/daffodil/pull/567#issuecomment-843359666
> 
> 
>We should just close this PR.
> 
>There's a significant amount of changes needed to get Daffodil compiling 
> on 2.13.x, and we have an bug already open for this issue: 
> [DAFFODIL-2152](https://issues.apache.org/jira/browse/DAFFODIL-2152). Also, 
> PR #246 has some initial changes to get 2.13 to work. That PR is likely too 
> old to cleanly rebase, but that is a better reference for 2.13 updates than 
> this PR.
> 
> 
> --
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on to GitHub and use the
> URL above to go to the specific comment.
> 
> For queries about this service, please contact Infrastructure at:
> us...@infra.apache.org
> 
> 
> 

224 legacy Resolved Daffodil JIRA tickets

[Thompson, Dave]

All,

There are currently 224 Daffodil JIRA tickets resolved in previous releases, 
all but 2 from v2.5.0 (1/2/2020) and earlier.

I want to check with the group to see if it would be acceptable to close these 
tickets with "Closed due to no activity."

Any other suggestions would be appreciated.

Thanks

Dave


Dave Thompson | Senior Engineer, Services
 [cid:image001.png@01D6EB27.668D0C60]
dthomp...@owlcyberdefense.com
(410) 290-1411 x162
Connect with us!
 [cid:image007.png@01D6EB27.831BAFD0] 
  
[cid:image008.png@01D6EB27.831BAFD0] 
 [cid:image006.jpg@01D6EB27.668D0C60] 


The information contained in this transmission is for the personal and 
confidential use of the individual or entity to which it is addressed. If the 
reader is not the intended recipient, you are hereby notified that any review, 
dissemination, or copying of this communication is strictly prohibited. If you 
have received this transmission in error, please notify the sender immediately

Re: Windows debug clues needed

[Beckerle, Mike]

So some of these errors seem to be font & charset related.

I installed the japanese language pack, so I have unicode character capability, 
but perhaps I have to set something up to tell it to use unicode and a sensible 
font which has the Kanji characters that are in our tests, for example.



From: Steve Lawrence 
Sent: Tuesday, May 18, 2021 12:35 PM
To: dev@daffodil.apache.org 
Subject: Re: Windows debug clues needed

I'm not sure where it exists on windows, but if you run

  git config --global core.autocrlf true

then it should enable it globally. I think you could also try
reinstallting git for Windows. Last I installed git on Windows (a long
time ago) I think the installer let me pick how to handle line endings.
I'm not sure if it explicitly mentions the autocrlf option though, or if
it even gives that option anymore.


On 5/18/21 12:30 PM, Beckerle, Mike wrote:
> The XML comments was definitely part of it. Found that one and fixed it with 
> the override def comment(..) as you suggest.
>
> There are still other tests failing though.
>
> I have been spinning up a windows dev environment and I noticed that the 
> comments contain CRLFs on windows, and likely due to autoCRLF stuff, do not 
> on Linux.
>
> Where do I find this autoCRLF setting? The .gitconfig in my linux home 
> doesn't have an autocrlf setting. And I am not finding one on Windows, though 
> not sure entirely where that would live on Windows.
>
>
> 
> From: Steve Lawrence 
> Sent: Tuesday, May 18, 2021 11:57 AM
> To: dev@daffodil.apache.org 
> Subject: Re: Windows debug clues needed
>
> Finished the review and I didn't find anything, but I just noticed that
> some of the failed TMDL tests have infosets that include comments, that
> include newlines.
>
> I'm guessing these comments aren't stripped out by the loader and also
> aren't normalized. So when git autocrlf kicks in, it changes these
> comments to have \r\n, we don't normalize that, and the the infoset does
> contain \r's and we error.
>
> It looks like the ConstructingParser has a 'def comment' function, so
> maybe we just need to override that to normalize the comment contents?
>
> - Steve
>
>
> On 5/18/21 8:58 AM, Beckerle, Mike wrote:
>> My PR https://github.com/apache/daffodil/pull/560
>> 
>>
>> Keeps failing its tests on MS-Windows.
>>
>> I am unable to reproduce the failures on Linux obviously.
>>
>> But... I am also unable to reproduce these failures on MS-Windows.
>>
>> I have installed sbt, git, intellij idea, emacs, etc. all on MS-Windows. 
>> When I
>> run the tests via sbt test... they all pass.
>>
>> So one possibility is that I have git configured differently (w.r.t the 
>> autocrlf
>> stuff) than is done by the windows CI systems.
>>
>> Suggestions?
>>
>>
>>
>>
>> Mike Beckerle | Principal Engineer
>>
>> mbecke...@owlcyberdefense.com 
>>
>> P +1-781-330-0412
>>
>
>

Re: Windows debug clues needed

[Steve Lawrence]

I'm not sure where it exists on windows, but if you run

  git config --global core.autocrlf true

then it should enable it globally. I think you could also try
reinstallting git for Windows. Last I installed git on Windows (a long
time ago) I think the installer let me pick how to handle line endings.
I'm not sure if it explicitly mentions the autocrlf option though, or if
it even gives that option anymore.


On 5/18/21 12:30 PM, Beckerle, Mike wrote:
> The XML comments was definitely part of it. Found that one and fixed it with 
> the override def comment(..) as you suggest.
> 
> There are still other tests failing though.
> 
> I have been spinning up a windows dev environment and I noticed that the 
> comments contain CRLFs on windows, and likely due to autoCRLF stuff, do not 
> on Linux.
> 
> Where do I find this autoCRLF setting? The .gitconfig in my linux home 
> doesn't have an autocrlf setting. And I am not finding one on Windows, though 
> not sure entirely where that would live on Windows.
> 
> 
> 
> From: Steve Lawrence 
> Sent: Tuesday, May 18, 2021 11:57 AM
> To: dev@daffodil.apache.org 
> Subject: Re: Windows debug clues needed
> 
> Finished the review and I didn't find anything, but I just noticed that
> some of the failed TMDL tests have infosets that include comments, that
> include newlines.
> 
> I'm guessing these comments aren't stripped out by the loader and also
> aren't normalized. So when git autocrlf kicks in, it changes these
> comments to have \r\n, we don't normalize that, and the the infoset does
> contain \r's and we error.
> 
> It looks like the ConstructingParser has a 'def comment' function, so
> maybe we just need to override that to normalize the comment contents?
> 
> - Steve
> 
> 
> On 5/18/21 8:58 AM, Beckerle, Mike wrote:
>> My PR https://github.com/apache/daffodil/pull/560
>> 
>>
>> Keeps failing its tests on MS-Windows.
>>
>> I am unable to reproduce the failures on Linux obviously.
>>
>> But... I am also unable to reproduce these failures on MS-Windows.
>>
>> I have installed sbt, git, intellij idea, emacs, etc. all on MS-Windows. 
>> When I
>> run the tests via sbt test... they all pass.
>>
>> So one possibility is that I have git configured differently (w.r.t the 
>> autocrlf
>> stuff) than is done by the windows CI systems.
>>
>> Suggestions?
>>
>>
>>
>>
>> Mike Beckerle | Principal Engineer
>>
>> mbecke...@owlcyberdefense.com 
>>
>> P +1-781-330-0412
>>
> 
> 

Re: Windows debug clues needed

[Beckerle, Mike]

The XML comments was definitely part of it. Found that one and fixed it with 
the override def comment(..) as you suggest.

There are still other tests failing though.

I have been spinning up a windows dev environment and I noticed that the 
comments contain CRLFs on windows, and likely due to autoCRLF stuff, do not on 
Linux.

Where do I find this autoCRLF setting? The .gitconfig in my linux home doesn't 
have an autocrlf setting. And I am not finding one on Windows, though not sure 
entirely where that would live on Windows.



From: Steve Lawrence 
Sent: Tuesday, May 18, 2021 11:57 AM
To: dev@daffodil.apache.org 
Subject: Re: Windows debug clues needed

Finished the review and I didn't find anything, but I just noticed that
some of the failed TMDL tests have infosets that include comments, that
include newlines.

I'm guessing these comments aren't stripped out by the loader and also
aren't normalized. So when git autocrlf kicks in, it changes these
comments to have \r\n, we don't normalize that, and the the infoset does
contain \r's and we error.

It looks like the ConstructingParser has a 'def comment' function, so
maybe we just need to override that to normalize the comment contents?

- Steve


On 5/18/21 8:58 AM, Beckerle, Mike wrote:
> My PR https://github.com/apache/daffodil/pull/560
> 
>
> Keeps failing its tests on MS-Windows.
>
> I am unable to reproduce the failures on Linux obviously.
>
> But... I am also unable to reproduce these failures on MS-Windows.
>
> I have installed sbt, git, intellij idea, emacs, etc. all on MS-Windows. When 
> I
> run the tests via sbt test... they all pass.
>
> So one possibility is that I have git configured differently (w.r.t the 
> autocrlf
> stuff) than is done by the windows CI systems.
>
> Suggestions?
>
>
>
>
> Mike Beckerle | Principal Engineer
>
> mbecke...@owlcyberdefense.com 
>
> P +1-781-330-0412
>

Re: Windows debug clues needed

[Steve Lawrence]

Finished the review and I didn't find anything, but I just noticed that
some of the failed TMDL tests have infosets that include comments, that
include newlines.

I'm guessing these comments aren't stripped out by the loader and also
aren't normalized. So when git autocrlf kicks in, it changes these
comments to have \r\n, we don't normalize that, and the the infoset does
contain \r's and we error.

It looks like the ConstructingParser has a 'def comment' function, so
maybe we just need to override that to normalize the comment contents?

- Steve


On 5/18/21 8:58 AM, Beckerle, Mike wrote:
> My PR https://github.com/apache/daffodil/pull/560 
> 
> 
> Keeps failing its tests on MS-Windows.
> 
> I am unable to reproduce the failures on Linux obviously.
> 
> But... I am also unable to reproduce these failures on MS-Windows.
> 
> I have installed sbt, git, intellij idea, emacs, etc. all on MS-Windows. When 
> I 
> run the tests via sbt test... they all pass.
> 
> So one possibility is that I have git configured differently (w.r.t the 
> autocrlf 
> stuff) than is done by the windows CI systems.
> 
> Suggestions?
> 
> 
> 
> 
> Mike Beckerle | Principal Engineer
> 
> mbecke...@owlcyberdefense.com 
> 
> P +1-781-330-0412
> 

[RESULT][VOTE] Release Apache Daffodil 3.1.0-rc2

[Steve Lawrence]

The VOTE to release Apache Daffodil 3.1.0-rc2 is now
closed. The vote passes with 7 +1 votes, and NO -1 votes.

The VOTE thread:

https://lists.apache.org/thread.html/r9a3d0a52f863b29db3c0b3c1e5b212f72b5fc1074510f38697f4449a%40%3Cdev.daffodil.apache.org%3E

+1's were:

John Interrante (binding)
Steve Lawrence (binding)
Josh Adams (binding)
Mike Beckerle (binding)
John Wass (binding)
Lola Kilo (binding)
Dave Thompson (binding)

Thanks to everyone who voted!

Re: [VOTE] Release Apache Daffodil 3.1.0-rc2

[Olabusayo Kilo]

+1

I checked:

[OK] links in email are correct
[OK] verified Summary of Changes pages (maven, sbt and download)
[OK] JavaDoc and ScalaDoc are correct
[OK] RAT check passes

On 5/14/21 3:26 PM, Steve Lawrence wrote:

Hi all,

I'd like to call a vote to release Apache Daffodil 3.1.0-rc2.

All distribution packages, including signatures, digests, etc. can be
found at:

https://dist.apache.org/repos/dist/dev/daffodil/3.1.0-rc2/

Staging artifacts can be found at:

https://repository.apache.org/content/repositories/orgapachedaffodil-1023/

This release has been signed with PGP key 36F3494B033AE661,
corresponding to slawre...@apache.org, which is included in the KEYS
file here:

https://downloads.apache.org/daffodil/KEYS

The release candidate has been tagged in git with v3.1.0-rc2.

For reference, here is a list of all closed JIRAs tagged with 3.1.0:

https://s.apache.org/daffodil-issues-3.1.0

For a summary of the changes in this release, see:

https://daffodil.apache.org/releases/3.1.0/

Please review and vote. The vote will be open for at least 72 hours
(Monday, 17 May 2021, 4pm EST).

[ ] +1 approve
[ ] +0 no opinion
[ ] -1 disapprove (and reason why)


--
Best Regards,
Lola K.

RE: [VOTE] Release Apache Daffodil 3.1.0-rc2

[Thompson, Dave]

Vote +1

Verified and closed all "Resolved" v3.1.0 JIRA tickets.
Verified all Daffodil sub-project SBT test suites execute successfully.
Verified all nightly performance test schemas compile and save successfully on 
java 8, 11 and 16.
Verified the nightly performance test suite successfully executed with java 8, 
11 and 16.

Dave

-Original Message-
From: Steve Lawrence 
Sent: Friday, May 14, 2021 3:27 PM
To: dev@daffodil.apache.org
Subject: [VOTE] Release Apache Daffodil 3.1.0-rc2

Hi all,

I'd like to call a vote to release Apache Daffodil 3.1.0-rc2.

All distribution packages, including signatures, digests, etc. can be found at:

https://dist.apache.org/repos/dist/dev/daffodil/3.1.0-rc2/

Staging artifacts can be found at:

https://repository.apache.org/content/repositories/orgapachedaffodil-1023/

This release has been signed with PGP key 36F3494B033AE661, corresponding to 
slawre...@apache.org, which is included in the KEYS file here:

https://downloads.apache.org/daffodil/KEYS

The release candidate has been tagged in git with v3.1.0-rc2.

For reference, here is a list of all closed JIRAs tagged with 3.1.0:

https://s.apache.org/daffodil-issues-3.1.0

For a summary of the changes in this release, see:

https://daffodil.apache.org/releases/3.1.0/

Please review and vote. The vote will be open for at least 72 hours (Monday, 17 
May 2021, 4pm EST).

[ ] +1 approve
[ ] +0 no opinion
[ ] -1 disapprove (and reason why)

Re: [VOTE] Release Apache Daffodil 3.1.0-rc2

[Steve Lawrence]

I've talked to a couple others that are still reviewing and planning to
vote. Just giving a chance for extra votes to come in and make sure
there are no issues. Especially since much of the 72 hours was over the
weekend and people may not have had time yesterday.

On 5/18/21 9:24 AM, Interrante, John A (GE Research, US) wrote:
> More than 72 hours have passed and we're up to 5 +1's now with no 0's or 
> -1's.  When will the release come out? :-)
> 
> John
> 
> -Original Message-
> From: John Wass  
> Sent: Tuesday, May 18, 2021 8:55 AM
> To: dev@daffodil.apache.org
> Subject: EXT: Re: [VOTE] Release Apache Daffodil 3.1.0-rc2
> 
> +1
> 
> I checked
> 
> [OK] RPM install in centos 8 and fedora 32 [OK] spot check schematron 
> validation and svrl output [OK] misc CLI operations [OK] hash of each 
> download matches [OK] rat check passes [OK] use of staged artifacts in 
> existing applications
> 
> 
> 
> On Fri, May 14, 2021 at 3:26 PM Steve Lawrence  wrote:
> 
>> Hi all,
>>
>> I'd like to call a vote to release Apache Daffodil 3.1.0-rc2.
>>
>> All distribution packages, including signatures, digests, etc. can be 
>> found at:
>>
>> https://dist.apache.org/repos/dist/dev/daffodil/3.1.0-rc2/
>>
>> Staging artifacts can be found at:
>>
>> https://repository.apache.org/content/repositories/orgapachedaffodil-1
>> 023/
>>
>> This release has been signed with PGP key 36F3494B033AE661, 
>> corresponding to slawre...@apache.org, which is included in the KEYS 
>> file here:
>>
>> https://downloads.apache.org/daffodil/KEYS
>>
>> The release candidate has been tagged in git with v3.1.0-rc2.
>>
>> For reference, here is a list of all closed JIRAs tagged with 3.1.0:
>>
>> https://s.apache.org/daffodil-issues-3.1.0
>>
>> For a summary of the changes in this release, see:
>>
>> https://daffodil.apache.org/releases/3.1.0/
>>
>> Please review and vote. The vote will be open for at least 72 hours 
>> (Monday, 17 May 2021, 4pm EST).
>>
>> [ ] +1 approve
>> [ ] +0 no opinion
>> [ ] -1 disapprove (and reason why)
>>
>>

[VOTE] Release Apache Daffodil 3.1.0-rc2

[Interrante, John A (GE Research, US)]

More than 72 hours have passed and we're up to 5 +1's now with no 0's or -1's.  
When will the release come out? :-)

John

-Original Message-
From: John Wass  
Sent: Tuesday, May 18, 2021 8:55 AM
To: dev@daffodil.apache.org
Subject: EXT: Re: [VOTE] Release Apache Daffodil 3.1.0-rc2

+1

I checked

[OK] RPM install in centos 8 and fedora 32 [OK] spot check schematron 
validation and svrl output [OK] misc CLI operations [OK] hash of each download 
matches [OK] rat check passes [OK] use of staged artifacts in existing 
applications



On Fri, May 14, 2021 at 3:26 PM Steve Lawrence  wrote:

> Hi all,
>
> I'd like to call a vote to release Apache Daffodil 3.1.0-rc2.
>
> All distribution packages, including signatures, digests, etc. can be 
> found at:
>
> https://dist.apache.org/repos/dist/dev/daffodil/3.1.0-rc2/
>
> Staging artifacts can be found at:
>
> https://repository.apache.org/content/repositories/orgapachedaffodil-1
> 023/
>
> This release has been signed with PGP key 36F3494B033AE661, 
> corresponding to slawre...@apache.org, which is included in the KEYS 
> file here:
>
> https://downloads.apache.org/daffodil/KEYS
>
> The release candidate has been tagged in git with v3.1.0-rc2.
>
> For reference, here is a list of all closed JIRAs tagged with 3.1.0:
>
> https://s.apache.org/daffodil-issues-3.1.0
>
> For a summary of the changes in this release, see:
>
> https://daffodil.apache.org/releases/3.1.0/
>
> Please review and vote. The vote will be open for at least 72 hours 
> (Monday, 17 May 2021, 4pm EST).
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove (and reason why)
>
>

Re: Windows debug clues needed

[Steve Lawrence]

I'm reviewing the PR now, I'll let you know if I see anything that jumps
out at me.

My guess is this probably an autocrlf issue. It's possible your windows
git installation didn't set this to true so git isn't replacing LF with
CRLF. If you change the core.autocrlf git config option to true and
reclone the repo, you might be able to reproduce the issue.

On 5/18/21 8:58 AM, Beckerle, Mike wrote:
> My PR https://github.com/apache/daffodil/pull/560 
> 
> 
> Keeps failing its tests on MS-Windows.
> 
> I am unable to reproduce the failures on Linux obviously.
> 
> But... I am also unable to reproduce these failures on MS-Windows.
> 
> I have installed sbt, git, intellij idea, emacs, etc. all on MS-Windows. When 
> I 
> run the tests via sbt test... they all pass.
> 
> So one possibility is that I have git configured differently (w.r.t the 
> autocrlf 
> stuff) than is done by the windows CI systems.
> 
> Suggestions?
> 
> 
> 
> 
> Mike Beckerle | Principal Engineer
> 
> mbecke...@owlcyberdefense.com 
> 
> P +1-781-330-0412
> 

Windows debug clues needed

[Beckerle, Mike]

My PR https://github.com/apache/daffodil/pull/560

Keeps failing its tests on MS-Windows.

I am unable to reproduce the failures on Linux obviously.

But... I am also unable to reproduce these failures on MS-Windows.

I have installed sbt, git, intellij idea, emacs, etc. all on MS-Windows. When I 
run the tests via sbt test... they all pass.

So one possibility is that I have git configured differently (w.r.t the 
autocrlf stuff) than is done by the windows CI systems.

Suggestions?




Mike Beckerle | Principal Engineer

[cid:a2c52957-7bf9-4dbc-b1c3-17e950b58bf8]

mbecke...@owlcyberdefense.com

P +1-781-330-0412

Re: [VOTE] Release Apache Daffodil 3.1.0-rc2

[John Wass]

+1

I checked

[OK] RPM install in centos 8 and fedora 32
[OK] spot check schematron validation and svrl output
[OK] misc CLI operations
[OK] hash of each download matches
[OK] rat check passes
[OK] use of staged artifacts in existing applications



On Fri, May 14, 2021 at 3:26 PM Steve Lawrence  wrote:

> Hi all,
>
> I'd like to call a vote to release Apache Daffodil 3.1.0-rc2.
>
> All distribution packages, including signatures, digests, etc. can be
> found at:
>
> https://dist.apache.org/repos/dist/dev/daffodil/3.1.0-rc2/
>
> Staging artifacts can be found at:
>
> https://repository.apache.org/content/repositories/orgapachedaffodil-1023/
>
> This release has been signed with PGP key 36F3494B033AE661,
> corresponding to slawre...@apache.org, which is included in the KEYS
> file here:
>
> https://downloads.apache.org/daffodil/KEYS
>
> The release candidate has been tagged in git with v3.1.0-rc2.
>
> For reference, here is a list of all closed JIRAs tagged with 3.1.0:
>
> https://s.apache.org/daffodil-issues-3.1.0
>
> For a summary of the changes in this release, see:
>
> https://daffodil.apache.org/releases/3.1.0/
>
> Please review and vote. The vote will be open for at least 72 hours
> (Monday, 17 May 2021, 4pm EST).
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove (and reason why)
>
>