回复：[VOTE] Adopt the Drill Test Framework from MapR

[王腾飞(飞腾)]

Hi Abhishek,

Thanks a lot for your effort, test is very important for an open-source 
project. Does the test framework allow to do performance test? Any doc about 
that


--
发件人：Abhishek Girish 
发送时间：2022年3月24日(星期四) 10:40
收件人：dev 
抄　送：agozhiy 
主　题：Re: [VOTE] Adopt the Drill Test Framework from MapR

Hi all,

I'm fully supportive of this.

Years back, I led the effort to open-source this framework - for very
similar reasons. It was well received, but we realized it not being part of
the official Drill repo was not letting it realize it's full potential and
hence remained on the sidelines. It remains heavily used inside MapR/HPE,
but isn't part of our pre-commit or pre-release criteria. We discussed
making the test framework part of the apache/drill repo, but that wasn't
ideal, as it would have significantly added to the overall repo size and
footprint.

After looking at the Arrow Project, I had similar ideas as James now, to
create a set of repos - one for the test framework
(apache/drill-test-framework), one for a Jenkins env (apache/drill-jenkins)
and such. Only I didn't do anything about it then!

I discussed the current proposal with Anton & James - on ways to proceed.
Transferring the existing test framework repo ownership to Apache would
have been ideal, but it appears it's not straightforward. So I have to
abandon that plan. I think we should proceed with the plan of pushing a
clone of mapr/drill-test-framework to apache/drill-test-framework. And in
fact, I already did :)

https://github.com/apache/drill-test-framework is now live!

We'll plan to archive mapr/drill-test-framework and move all future
activity to apache/drill-test-framework

This is a big milestone. But there is more to be done (including for
example, creating the Jenkins repo - which can be very useful to schedule &
operate tests).

Regards,
Abhishek

On Fri, Mar 18, 2022 at 6:49 AM James Turton  wrote:

> Hi Cong Luo
>
> Yes, this is the same project as DRILL-8120.  Anton Gozhiy is actively
> working on the test framework, I'm not sure if there are others too.  I
> agree that an introduction would be helpful.  Maybe in the next
> community meetup someone who is familiar with the test framework, like
> Anton or Abhishek, can introduce the rest of us in the Drill dev
> community to it, so that we can all start adding and maintaining tests,
> and benefiting from it.
>
> A related point is that I went and looked at the specs of the VMs that
> the ASF allocates to projects and we'd need a special motivation to get
> more than one VM with 1GiB of RAM.  Meanwhile I think that the full test
> framework would like to run with resources than that, and probably
> against a cluster.  So I suspect that we can find some other use for the
> small VM from the ASF, and one or more of our corporate sponsors can run
> the test framework in an elastic way in one of the clouds (create a
> cluster, then destroy all allocated instances once the tests have run).
>
> James
>
> On 2022/03/18 13:09, luoc wrote:
> > Hi all,
> >
> > If the new repository is created, I hope this is the new progress with
> DRILL-8120 .
> >
> > Then, can test framework contributors answer the following questions?
> >
> > 1. Who are the active contributors to this test framework?
> >
> > 2. Are we planning to add more contributors (and how do we implement it)?
> >
> > 3. Can the contributors outline the design idea and function set of the
> test framework here?
> >
> > Again, thanks to Charles's company and HPE team for supporting Apache
> Drill.
> >
> > Thanks.
> >
> >> 2022年3月18日 下午12:56，Paul Rogers  写道：
> >>
> >> Abhishek used to have that thing running like a charm. Great to see it
> >> getting attention again.
> >>
> >> +1
> >>
> >> - Paul
> >>
> >> On Thu, Mar 17, 2022 at 2:03 AM James Turton  wrote:
> >>
> >>> Hi dev community!
> >>>
> >>> Many of you need no introduction to the test framework developed by
> MapR
> >>>
> >>> https://github.com/mapr/drill-test-framework
> >>>
> >>> . For those who don't know, the test framework contains around 10k
> tests
> >>> often exercising scenarios not covered by Drill's unit tests. Just
> weeks
> >>> ago it revealed a regression in a Drill 1.20 RC and saved us from
> >>> shipping with that bug. The linked repository has been dormant for
> going
> >>> on two years but I am aware of bits of work that have been done on the
> >>> test framework since, and today Anton is actively dusting off and
> >>> updating it. Since the codebase is under the Apache 2.0 license, we are
> >>> free to bring a copy into the Drill project. I've created a new
> >>> (currently empty) possible home for the test framework at
> >>>
> >>> https://github.com/apache/drill-test-framework
> >>>
> >>> Before I proceed to push a clone there, please vote if you support or
> >>> oppose our adoption of the test framework.
> >>>
> >>> P.S. I have also sent a 

Re: [VOTE] Adopt the Drill Test Framework from MapR

[Abhishek Girish]

Hi all,

I'm fully supportive of this.

Years back, I led the effort to open-source this framework - for very
similar reasons. It was well received, but we realized it not being part of
the official Drill repo was not letting it realize it's full potential and
hence remained on the sidelines. It remains heavily used inside MapR/HPE,
but isn't part of our pre-commit or pre-release criteria. We discussed
making the test framework part of the apache/drill repo, but that wasn't
ideal, as it would have significantly added to the overall repo size and
footprint.

After looking at the Arrow Project, I had similar ideas as James now, to
create a set of repos - one for the test framework
(apache/drill-test-framework), one for a Jenkins env (apache/drill-jenkins)
and such. Only I didn't do anything about it then!

I discussed the current proposal with Anton & James - on ways to proceed.
Transferring the existing test framework repo ownership to Apache would
have been ideal, but it appears it's not straightforward. So I have to
abandon that plan. I think we should proceed with the plan of pushing a
clone of mapr/drill-test-framework to apache/drill-test-framework. And in
fact, I already did :)

https://github.com/apache/drill-test-framework is now live!

We'll plan to archive mapr/drill-test-framework and move all future
activity to apache/drill-test-framework

This is a big milestone. But there is more to be done (including for
example, creating the Jenkins repo - which can be very useful to schedule &
operate tests).

Regards,
Abhishek

On Fri, Mar 18, 2022 at 6:49 AM James Turton  wrote:

> Hi Cong Luo
>
> Yes, this is the same project as DRILL-8120.  Anton Gozhiy is actively
> working on the test framework, I'm not sure if there are others too.  I
> agree that an introduction would be helpful.  Maybe in the next
> community meetup someone who is familiar with the test framework, like
> Anton or Abhishek, can introduce the rest of us in the Drill dev
> community to it, so that we can all start adding and maintaining tests,
> and benefiting from it.
>
> A related point is that I went and looked at the specs of the VMs that
> the ASF allocates to projects and we'd need a special motivation to get
> more than one VM with 1GiB of RAM.  Meanwhile I think that the full test
> framework would like to run with resources than that, and probably
> against a cluster.  So I suspect that we can find some other use for the
> small VM from the ASF, and one or more of our corporate sponsors can run
> the test framework in an elastic way in one of the clouds (create a
> cluster, then destroy all allocated instances once the tests have run).
>
> James
>
> On 2022/03/18 13:09, luoc wrote:
> > Hi all,
> >
> > If the new repository is created, I hope this is the new progress with
> DRILL-8120 .
> >
> > Then, can test framework contributors answer the following questions?
> >
> > 1. Who are the active contributors to this test framework?
> >
> > 2. Are we planning to add more contributors (and how do we implement it)?
> >
> > 3. Can the contributors outline the design idea and function set of the
> test framework here?
> >
> > Again, thanks to Charles's company and HPE team for supporting Apache
> Drill.
> >
> > Thanks.
> >
> >> 2022年3月18日 下午12:56，Paul Rogers  写道：
> >>
> >> Abhishek used to have that thing running like a charm. Great to see it
> >> getting attention again.
> >>
> >> +1
> >>
> >> - Paul
> >>
> >> On Thu, Mar 17, 2022 at 2:03 AM James Turton  wrote:
> >>
> >>> Hi dev community!
> >>>
> >>> Many of you need no introduction to the test framework developed by
> MapR
> >>>
> >>> https://github.com/mapr/drill-test-framework
> >>>
> >>> . For those who don't know, the test framework contains around 10k
> tests
> >>> often exercising scenarios not covered by Drill's unit tests. Just
> weeks
> >>> ago it revealed a regression in a Drill 1.20 RC and saved us from
> >>> shipping with that bug. The linked repository has been dormant for
> going
> >>> on two years but I am aware of bits of work that have been done on the
> >>> test framework since, and today Anton is actively dusting off and
> >>> updating it. Since the codebase is under the Apache 2.0 license, we are
> >>> free to bring a copy into the Drill project. I've created a new
> >>> (currently empty) possible home for the test framework at
> >>>
> >>> https://github.com/apache/drill-test-framework
> >>>
> >>> Before I proceed to push a clone there, please vote if you support or
> >>> oppose our adoption of the test framework.
> >>>
> >>> P.S. I have also sent a message to a contact at HPE just in case they
> >>> might be aware of some concern applicable to our copying this repo but,
> >>> given the license applied, I cannot see that there will be be one.
> >>> Should anything get raised (and we'd decided to proceed) I would, of
> >>> course, pause so that we can discuss.
> >>>
> >>> Regards
> >>> James
> >>>
> >
>
>

[GitHub] [drill] jnturton commented on a change in pull request #2485: DRILL-8086: Convert the CSV (AKA "compliant text") reader to EVF V2

[GitBox]

jnturton commented on a change in pull request #2485:
URL: https://github.com/apache/drill/pull/2485#discussion_r833325749



##
File path: 
exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/TextFormatPlugin.java
##
@@ -81,9 +68,8 @@
  * to allow tight control of the size of produced batches (as well
  * as to support provided schema.)
  */
-public class TextFormatPlugin extends 
EasyFormatPlugin {
-
-  private final static String PLUGIN_NAME = "text";
+public class TextFormatPlugin extends EasyFormatPlugin {
+  final static String PLUGIN_NAME = "text";

Review comment:
   @cgivre @paul-rogers the master branch is now rolling towards 2.0.  If 
we don't take the chance in this cycle to improve user-facing stuff, it's a 
long time until the next chance.
   
   I do think we should try to segregate our breaking changes into their own 
PRs, and therefore squashed commits, as much as we can so that our ability to 
cherry pick from master back to a 1.20.1 or, god forbid, a 1.21 is maximally 
preserved.  We could also label such commits with "[BREAKING]", or apply a 
`breaking` tag to the PR in GitHub, I wonder if that would be helpful.
   
   FWIW, I'm +1 for turning `columns[n]` into `column_n` (and I think this 
terminolgy is more standard for SQL result sets than `field`), +1 for "text" 
becoming "delimited" and +0 for the default value of `extractHeaders`, which is 
trivial for users to set for themselves.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [drill] jnturton commented on a change in pull request #2485: DRILL-8086: Convert the CSV (AKA "compliant text") reader to EVF V2

[GitBox]

jnturton commented on a change in pull request #2485:
URL: https://github.com/apache/drill/pull/2485#discussion_r833325749



##
File path: 
exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/TextFormatPlugin.java
##
@@ -81,9 +68,8 @@
  * to allow tight control of the size of produced batches (as well
  * as to support provided schema.)
  */
-public class TextFormatPlugin extends 
EasyFormatPlugin {
-
-  private final static String PLUGIN_NAME = "text";
+public class TextFormatPlugin extends EasyFormatPlugin {
+  final static String PLUGIN_NAME = "text";

Review comment:
   @cgivre @paul-rogers the master branch is now rolling towards 2.0.  If 
we don't take the chance in this cycle to improve user-facing stuff, it's a 
long time until the next chance.
   
   I do think we should try to segregate our breaking changes into their own 
PRs, and therefore squashed commits, as much as we can so that our ability to 
cherry pick back to a 1.20.1 or, god forbid, a 1.21 is maximally preserved.
   
   FWIW, I'm +1 for turning `columns[n]` into `column_n` (and I think this 
terminolgy is more standard for SQL result sets than `field`), +1 for "text" 
becoming "delimited" and +0 for the default value of `extractHeaders`, which is 
trivial for users to set for themselves.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [drill] jnturton commented on a change in pull request #2485: DRILL-8086: Convert the CSV (AKA "compliant text") reader to EVF V2

[GitBox]

jnturton commented on a change in pull request #2485:
URL: https://github.com/apache/drill/pull/2485#discussion_r833325749



##
File path: 
exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/TextFormatPlugin.java
##
@@ -81,9 +68,8 @@
  * to allow tight control of the size of produced batches (as well
  * as to support provided schema.)
  */
-public class TextFormatPlugin extends 
EasyFormatPlugin {
-
-  private final static String PLUGIN_NAME = "text";
+public class TextFormatPlugin extends EasyFormatPlugin {
+  final static String PLUGIN_NAME = "text";

Review comment:
   @cgivre @paul-rogers the master branch is now rolling towards 2.0.  If 
we don't take the chance in this cycle to improve user-facing stuff, it's a 
long time until the next chance.
   
   I do think we should try to segregate our breaking changes into their own 
PRs, and therefore squashed commits, as much as we can so that our ability to 
cherry pick back to a 1.20.1 or, god forbid, a 1.21 is maxmimally preserved.
   
   FWIW, I'm +1 for turning `columns[n]` into `column_n` (and I think this 
terminolgy is more standard for SQL result sets than `field`), +1 for "text" 
becoming "delimited" and +0 for the default value of `extractHeaders`, which is 
trivial for users to set for themselves.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [drill] kingswanwho commented on a change in pull request #2499: DRILL-8117: Clean up deprecated Apache code in Drill

[GitBox]

kingswanwho commented on a change in pull request #2499:
URL: https://github.com/apache/drill/pull/2499#discussion_r833325247



##
File path: 
exec/java-exec/src/test/java/org/apache/drill/exec/impersonation/TestInboundImpersonation.java
##
@@ -156,22 +159,25 @@ public void unauthorizedTarget() throws Exception {
 
   @Test
   public void invalidPolicy() throws Exception {
-thrownException.expect(new 
UserExceptionMatcher(UserBitShared.DrillPBError.ErrorType.VALIDATION,
-"Invalid impersonation policies."));
+String query = "ALTER SYSTEM SET `%s`='%s'";

Review comment:
   Hi Paul,
   Greetings to you!
   I did this because the UT code in Drill used `ExpectedException thrown = 
ExpectedException.none();`
   for ExpectedException instantiation.
   However the method `ExpectedException.none()` has been deprecated, so I 
replaced `ExpectedException.none()` by `Assert.assertThrows` as the 
[deprecation 
notice](https://junit.org/junit4/javadoc/latest/org/junit/rules/ExpectedException.html#none())
 suggested.
   Could you please give some suggestions will be really appreciated.
   Best,
   Jingchuan




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: Application for release manager of the next Drill release

[James Turton]

Hi Jingchuan Hu!

It's a long way off and I will leave this planning to the "elders" like 
Cong Luo and Charles but I do want to say that I will certainly offer 
you my support if you do manage the next release, since I have some 
experience now.


Regards
James

On 2022/03/20 17:15, Jingchuan Hu wrote:

Hi team,

I am here to apply for the role as the release manager of the next drill
release.

As a newcomer to the Drill community. I tried to help the community to get
known by more users through the Drill web-site Chinese version setup.
Committed several PRs for Drill bug fix. Also, helped to summarize the
keynotes of Drill online meetup for our community members to easily "Async"
with Drill activities. And I want to keep those contributions with better
quality in the future.

Over the six months after I joined the community, I am deeply impressed by
our community member's dedication and intelligence. No matter whether I
could be the release manager, I hope that I can grow with Drill.

If there are some suggestions for me, I would really appreciate it.

Sincerely,
Jingchuan

[GitHub] [drill] jnturton commented on pull request #2485: DRILL-8086: Convert the CSV (AKA "compliant text") reader to EVF V2

[GitBox]

jnturton commented on pull request #2485:
URL: https://github.com/apache/drill/pull/2485#issuecomment-1076404891


   > Drill 2.0 is an opportunity to reorient Drill away from fading big data 
space and toward the data science use cases that most PRs now seem to support. 
(It's not that big data itself is gone, it'd just that most folks who need that 
kind of scale now run in the cloud where Drill is not common.) As one of many 
examples, REST APIs make no sense at scale, but do make sense for a "small 
data" tool.
   > Or, have two Drill additions, the old-school "distributed systems" edition 
and the newer "data science edition". Those who still need Drill to work 
distributed can keep that edition going (along with the big data CSV quirks), 
while the data science folks can fork the data science edition, chuck the 
distributed systems stuff that gets in the way, and focus on things that data 
scientists do (such as reading Excel and PDF files.)
   
   @paul-rogers supporting two editions of Drill would be even harder for our 
small band of developers than supporting one, surely?  Also, I think it would 
be a major loss to unpick all of the MPP work done in Drill to make big data 
queryable, in any notional edition.  Indeed, for a small-data-only query 
engine, I doubt that there would be any sense in starting from Drill at all.  A 
fresh start based on Calcite, Pandas or Julia would be simpler and cleaner.
   
   Many people do their big data processing in the cloud but not all of them 
want the vendor lock-in of the SAAS products so prefer to deploy open source in 
the cloud.  Others remain on-prem.  In addition, I still contend that the 
worlds of small and big data are not disjoint, and that a single system that 
can query over many storages, formats and data sizes is valuable to a viable 
audience.  If the contrib/ plugins can be sufficiently separated away from the 
rest of Drill then the variability in their scalability and behaviour is 
quarantined away from core Drill.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [drill] cgivre commented on a change in pull request #2485: DRILL-8086: Convert the CSV (AKA "compliant text") reader to EVF V2

[GitBox]

cgivre commented on a change in pull request #2485:
URL: https://github.com/apache/drill/pull/2485#discussion_r833240470



##
File path: 
exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/TextFormatPlugin.java
##
@@ -81,9 +68,8 @@
  * to allow tight control of the size of produced batches (as well
  * as to support provided schema.)
  */
-public class TextFormatPlugin extends 
EasyFormatPlugin {
-
-  private final static String PLUGIN_NAME = "text";
+public class TextFormatPlugin extends EasyFormatPlugin {
+  final static String PLUGIN_NAME = "text";

Review comment:
   I wonder if it might make sense to follow the model of some of the other 
format readers where if the column headers are not known, it assigns a name of 
`field_n` to them.  That way you still get columns instead of the columns 
array.  
   
   My view is that if we change the default, but still allow the users to 
revert back with a config change, it's not that big of a deal.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [drill] cgivre commented on pull request #2485: DRILL-8086: Convert the CSV (AKA "compliant text") reader to EVF V2

[GitBox]

cgivre commented on pull request #2485:
URL: https://github.com/apache/drill/pull/2485#issuecomment-1076351190


   @paul-rogers I'd second @luocooong 's message.  The Travis CI has been a 
pain and I think rebasing will solve the issues.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [drill] cgivre commented on a change in pull request #2493: DRILL-8164: Upgrade metadata-extractor because of CVE-2022-24613

[GitBox]

cgivre commented on a change in pull request #2493:
URL: https://github.com/apache/drill/pull/2493#discussion_r833234640



##
File path: 
metastore/rdbms-metastore/src/main/java/org/apache/drill/metastore/rdbms/RdbmsMetastore.java
##
@@ -117,6 +117,8 @@ private HikariDataSource dataSource(DrillConfig config) {
   private void initTables(DataSource dataSource) {
 try (Connection connection = dataSource.getConnection()) {
   JdbcConnection jdbcConnection = new JdbcConnection(connection);
+  // TODO Replace the following steps with new function once this issue is 
resolved.

Review comment:
   @luocooong Let's hold off on merging to see if they release a new 
version.  I'm actually not so sure that this is actually an issue.  If you look 
at the report, the CVE seems like it was derived from a bug list rather than a 
vulnerability. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [drill] luocooong commented on a change in pull request #2493: DRILL-8164: Upgrade metadata-extractor because of CVE-2022-24613

[GitBox]

luocooong commented on a change in pull request #2493:
URL: https://github.com/apache/drill/pull/2493#discussion_r833082032



##
File path: 
metastore/rdbms-metastore/src/main/java/org/apache/drill/metastore/rdbms/RdbmsMetastore.java
##
@@ -117,6 +117,8 @@ private HikariDataSource dataSource(DrillConfig config) {
   private void initTables(DataSource dataSource) {
 try (Connection connection = dataSource.getConnection()) {
   JdbcConnection jdbcConnection = new JdbcConnection(connection);
+  // TODO Replace the following steps with new function once this issue is 
resolved.

Review comment:
   @cgivre Thanks. If we need to merge this pull request now, should the 
title be replaced with: `Upgrade metadata-extractor to 2.16.0`? Because the 
reader author is not currently released a version higher than 2.16.0.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [drill] luocooong commented on pull request #2485: DRILL-8086: Convert the CSV (AKA "compliant text") reader to EVF V2

[GitBox]

luocooong commented on pull request #2485:
URL: https://github.com/apache/drill/pull/2485#issuecomment-1076006502


   @paul-rogers Hi. Could you pelase do a rebase on the master branch? Because 
it contains a patch for the Travis CI issue, Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [drill] paul-rogers commented on pull request #2485: DRILL-8086: Convert the CSV (AKA "compliant text") reader to EVF V2

[GitBox]

paul-rogers commented on pull request #2485:
URL: https://github.com/apache/drill/pull/2485#issuecomment-1075988349


   Looks like some of the secondary builds failed due to issues outside this 
PR. Can someone who understands that stuff please double-check?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [drill] paul-rogers commented on a change in pull request #2499: DRILL-8117: Clean up deprecated Apache code in Drill

[GitBox]

paul-rogers commented on a change in pull request #2499:
URL: https://github.com/apache/drill/pull/2499#discussion_r832902877



##
File path: 
exec/java-exec/src/test/java/org/apache/drill/exec/impersonation/TestInboundImpersonation.java
##
@@ -156,22 +159,25 @@ public void unauthorizedTarget() throws Exception {
 
   @Test
   public void invalidPolicy() throws Exception {
-thrownException.expect(new 
UserExceptionMatcher(UserBitShared.DrillPBError.ErrorType.VALIDATION,
-"Invalid impersonation policies."));
+String query = "ALTER SYSTEM SET `%s`='%s'";

Review comment:
   We have methods that do this work: it is very common. Maybe the required 
clients are not available in this particular test?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org