[GitHub] drill pull request #931: DRILL-5763: Fix NPE during MapRDBSubScan deserializ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/drill/pull/931


---

[GitHub] drill pull request #931: DRILL-5763: Fix NPE during MapRDBSubScan deserializ...

[amansinha100]

Github user amansinha100 commented on a diff in the pull request:

https://github.com/apache/drill/pull/931#discussion_r136856876
  
--- Diff: 
contrib/format-maprdb/src/main/java/org/apache/drill/exec/store/mapr/db/MapRDBSubScan.java
 ---
@@ -71,14 +71,32 @@ public MapRDBSubScan(String userName, 
MapRDBFormatPlugin formatPlugin,
 this.tableType = tableType;
   }
 
+
+  @JsonProperty("formatPluginConfig")
--- End diff --

Ok, yes since the fields are primitive types, they are not adding a 
dependency on other classes.  
Separately, we need to increase test coverage for these types of 
serialization/deserialization issues for the most commonly used storage and 
format plugins but that's a different discussion. 
I am good with this.  +1


---

[GitHub] drill pull request #931: DRILL-5763: Fix NPE during MapRDBSubScan deserializ...

[arina-ielchiieva]

Github user arina-ielchiieva commented on a diff in the pull request:

https://github.com/apache/drill/pull/931#discussion_r136605378
  
--- Diff: 
contrib/format-maprdb/src/main/java/org/apache/drill/exec/store/mapr/db/MapRDBSubScan.java
 ---
@@ -71,14 +71,32 @@ public MapRDBSubScan(String userName, 
MapRDBFormatPlugin formatPlugin,
 this.tableType = tableType;
   }
 
+
+  @JsonProperty("formatPluginConfig")
--- End diff --

We need to serialize `formatPluginConfig` to be able to create 
`MapRDBFormatPlugin` during deserialization.
`MapRDBFormatPluginConfig` contains five fields only:
```
  public boolean allTextMode = false;
  public boolean enablePushdown = true;
  public boolean ignoreSchemaChange = false;
  public boolean readAllNumbersAsDouble = false;
  public boolean disableCountOptimization = false;
```
Regarding the change, DRILL-5714 fixed initially incorrect implementation 
logic in `MapRDBSubScan`. 
Current implementation is similar to `EasySubScan`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill pull request #931: DRILL-5763: Fix NPE during MapRDBSubScan deserializ...

[amansinha100]

Github user amansinha100 commented on a diff in the pull request:

https://github.com/apache/drill/pull/931#discussion_r136601989
  
--- Diff: 
contrib/format-maprdb/src/main/java/org/apache/drill/exec/store/mapr/db/MapRDBSubScan.java
 ---
@@ -71,14 +71,32 @@ public MapRDBSubScan(String userName, 
MapRDBFormatPlugin formatPlugin,
 this.tableType = tableType;
   }
 
+
+  @JsonProperty("formatPluginConfig")
--- End diff --

There are trade-offs with serializing/deserializing more than the minimum 
needed.  One is the extra amount of data being sent as part of the plan 
fragment.  Another, somewhat more problematic is that the serialization brings 
in dependent classes and if the latter are not serialized properly then query 
fails.  Any thoughts about these ?  I understand the motivation for the change 
to fix DRILL-5714 and subsequently this Jira.  Just want to explore it further 
to see if the downsides can be avoided. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill pull request #931: DRILL-5763: Fix NPE during MapRDBSubScan deserializ...

[arina-ielchiieva]

GitHub user arina-ielchiieva opened a pull request:

https://github.com/apache/drill/pull/931

DRILL-5763: Fix NPE during MapRDBSubScan deserialization



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/arina-ielchiieva/drill DRILL-5763

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/drill/pull/931.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #931


commit 8c15edf6981a454f026bc469772d4bb4d9ce923d
Author: Arina Ielchiieva 
Date:   2017-09-01T11:51:46Z

DRILL-5763: Fix NPE during MapRDBSubScan deserialization




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---