build failed for latest master branch

[Yuhao Bi]

Hi there,

When I trying to compile against latest master branch I got compile error.
It seems something wrong in dubbo-demo-xml-consumer/pom.xml .
I did a little modification and it worked.

It's a little wired the travis build passed.
I'm not sure if it's my own fault, but I'll still send a PR.
Feel free to close it, if I was wrong.

Thanks,
Yuhao

Here is the console ouput from my local environment

./mvnw clean install -DskipTests
[INFO] Scanning for projects...
[ERROR] [ERROR] Some problems were encountered while processing the POMs:
[FATAL] Non-resolvable parent POM for
org.apache.dubbo:dubbo-demo-xml-consumer:[unknown-version]: Could not find
artifact org.apache.dubbo:dubbo-demo:pom:2.7.0-SNAPSHOT and
'parent.relativePath' points at wrong local POM @ line 19, column 13
[WARNING] 'dependencies.dependency.(groupId:artifactId:type:classifier)'
must be unique: org.apache.dubbo:dubbo-metadata-definition:jar -> duplicate
declaration of version ${project.parent.version} @
org.apache.dubbo:dubbo-metadata-report-api:[unknown-version],
/root/codes/incubator-dubbo/dubbo-metadata-report/dubbo-metadata-report-api/pom.xml,
line 71, column 21
[WARNING] 'dependencies.dependency.(groupId:artifactId:type:classifier)'
must be unique: com.google.code.gson:gson:jar -> duplicate declaration of
version (?) @ org.apache.dubbo:dubbo-metadata-report-api:[unknown-version],
/root/codes/incubator-dubbo/dubbo-metadata-report/dubbo-metadata-report-api/pom.xml,
line 76, column 21

Re: slow on pull request and issue

[田 小波]

Many people usually participate in the community in their spare time. 
Many companies have a long working time (996), which leads to the 
compression of their spare time. which ultimately leads to the low 
activity of Committers. This is also very helpless.

大家平时都是在下班后参与到社区中。不少公司工作时间比较长（996），
导致业余时间被压缩，最终导致 Committer 们的活跃度不高，这也是很无奈的事情。

Re: slow on pull request and issue

[华 钟明]

I also think that we should contact the recently inactive committer and collect 
their views on the community.

 
Best Regards！
Zhongming Hua
 

在 2019/1/3 下午1:31，“Imteyaz Khan” 写入:

+1 on this.

One suggestion,as I see there are currently 162 contributor for dubbo
core.  Lots of people who has participated in long past and may not be
active in community in recent past may be due to some reason. Do you should
we get in touch with them for their feedback as well support for community?

This is just an suggestion from my side and as being new in open source
community, I might express some ideas which may not be appropriate. So
please correct me.



On Thursday, January 3, 2019, Huxing Zhang  wrote:

> Hi,
>
> I've noticed that the response time is slow for Dubbo's core
> repository, including reviewing pull request, issue triage and issue
> cleanup, it seems that not everyone has enough time to deal with
> things like this.
>
> My idea is to identify the active contributors of the community, and
> invite to become a committer, let more people come in and help. In
> addition, we should also use robot to help us.
>
> The problem is how to find such people, I think it can be collected by
> the data, such as GitHub activities, how often do they participate in
> the discussion, how often do they participate in the review code.
>
> Furthermore, I think that people who often send pull requests, and
> those who often participate in the community, may be two types of
> people. The former requires large amount of  time, and the latter can
> participate using their fragmented time.
>
> For example, if I want to send a pr, I need to understand an issue,
> fix, test, which takes a lot of time. However,  leaving a message on
> the issue, labelling an issue, or closing the issue, these tasks can
> be done small granularity.
>
> Maybe we know a lot about the first type of people, but we need to
> identify and discover the second type of people and let them come in
> to help manage the community.
>
>
> 最近Dubbo的仓库，响应比较慢，包括pr的review，issue的分类和清理，似乎没有人处理。
> 我的想法是发展一部分活跃的contributor成为committer，让更多的人参与进来一起帮忙。
> 另外机器人也要参与进来。现在的问题是要找到这样的人，我觉得可以通过数据反映出来，比如GitHub上经常参加讨论的，经常参与review代码的。
>
> 另外我觉得经常提pull request的人，和经常参与社区的人，可能是两类人，前者对时间的的颗粒度要求很高，后者对时间颗粒度的要求度低。
>
> 比如我要提一个pr，需要理解一个issue,
> 修复，测试，需要花较大的时间，而在issue上留个言，打个label，close下issue，对时间的要求相对较低。
>
> 我们对第一类人的了解是比较多的，但需要识别和发现第二类人，让他们进来帮助管理社区。
>
> On Sat, Dec 29, 2018 at 5:13 PM Ian Luo  wrote:
> >
> > Hello folks,
> >
> > I'd like to apologize first since recently we are slow on issue and pull
> > request. We are very busy on ramping up Dubbo 2.7.0 which is expected to
> be
> > public available soon. I hope we could come back in one or two weeks so
> > depending on how soon we could finish. The code review for dubbo 2.7.0
> > release is happening now on Github pull request. Feel free to join us to
> > raise issue or submit pull request against the recent code changes on 
the
> > master branch.
> >
> > You are also very welcomed to interact on other issues and pull requests
> > irrelevant to release 2.7.0. They are piling up and we can do nothing
> right
> > now :)
> >
> > I really hope we can ramp up release 2.7.0 very soon, and your
> > comments/efforts are appreciated. After that, I plan to continue the
> > discussion on release 3.0.
> >
> > Cheers,
> > -Ian.
>
>
>
> --
> Best Regards！
> Huxing
>

Re: slow on pull request and issue

[Imteyaz Khan]

+1 on this.

One suggestion,as I see there are currently 162 contributor for dubbo
core.  Lots of people who has participated in long past and may not be
active in community in recent past may be due to some reason. Do you should
we get in touch with them for their feedback as well support for community?

This is just an suggestion from my side and as being new in open source
community, I might express some ideas which may not be appropriate. So
please correct me.



On Thursday, January 3, 2019, Huxing Zhang  wrote:

> Hi,
>
> I've noticed that the response time is slow for Dubbo's core
> repository, including reviewing pull request, issue triage and issue
> cleanup, it seems that not everyone has enough time to deal with
> things like this.
>
> My idea is to identify the active contributors of the community, and
> invite to become a committer, let more people come in and help. In
> addition, we should also use robot to help us.
>
> The problem is how to find such people, I think it can be collected by
> the data, such as GitHub activities, how often do they participate in
> the discussion, how often do they participate in the review code.
>
> Furthermore, I think that people who often send pull requests, and
> those who often participate in the community, may be two types of
> people. The former requires large amount of  time, and the latter can
> participate using their fragmented time.
>
> For example, if I want to send a pr, I need to understand an issue,
> fix, test, which takes a lot of time. However,  leaving a message on
> the issue, labelling an issue, or closing the issue, these tasks can
> be done small granularity.
>
> Maybe we know a lot about the first type of people, but we need to
> identify and discover the second type of people and let them come in
> to help manage the community.
>
>
> 最近Dubbo的仓库，响应比较慢，包括pr的review，issue的分类和清理，似乎没有人处理。
> 我的想法是发展一部分活跃的contributor成为committer，让更多的人参与进来一起帮忙。
> 另外机器人也要参与进来。现在的问题是要找到这样的人，我觉得可以通过数据反映出来，比如GitHub上经常参加讨论的，经常参与review代码的。
>
> 另外我觉得经常提pull request的人，和经常参与社区的人，可能是两类人，前者对时间的的颗粒度要求很高，后者对时间颗粒度的要求度低。
>
> 比如我要提一个pr，需要理解一个issue,
> 修复，测试，需要花较大的时间，而在issue上留个言，打个label，close下issue，对时间的要求相对较低。
>
> 我们对第一类人的了解是比较多的，但需要识别和发现第二类人，让他们进来帮助管理社区。
>
> On Sat, Dec 29, 2018 at 5:13 PM Ian Luo  wrote:
> >
> > Hello folks,
> >
> > I'd like to apologize first since recently we are slow on issue and pull
> > request. We are very busy on ramping up Dubbo 2.7.0 which is expected to
> be
> > public available soon. I hope we could come back in one or two weeks so
> > depending on how soon we could finish. The code review for dubbo 2.7.0
> > release is happening now on Github pull request. Feel free to join us to
> > raise issue or submit pull request against the recent code changes on the
> > master branch.
> >
> > You are also very welcomed to interact on other issues and pull requests
> > irrelevant to release 2.7.0. They are piling up and we can do nothing
> right
> > now :)
> >
> > I really hope we can ramp up release 2.7.0 very soon, and your
> > comments/efforts are appreciated. After that, I plan to continue the
> > discussion on release 3.0.
> >
> > Cheers,
> > -Ian.
>
>
>
> --
> Best Regards！
> Huxing
>

Re: slow on pull request and issue

[Huxing Zhang]

Hi,

I've noticed that the response time is slow for Dubbo's core
repository, including reviewing pull request, issue triage and issue
cleanup, it seems that not everyone has enough time to deal with
things like this.

My idea is to identify the active contributors of the community, and
invite to become a committer, let more people come in and help. In
addition, we should also use robot to help us.

The problem is how to find such people, I think it can be collected by
the data, such as GitHub activities, how often do they participate in
the discussion, how often do they participate in the review code.

Furthermore, I think that people who often send pull requests, and
those who often participate in the community, may be two types of
people. The former requires large amount of  time, and the latter can
participate using their fragmented time.

For example, if I want to send a pr, I need to understand an issue,
fix, test, which takes a lot of time. However,  leaving a message on
the issue, labelling an issue, or closing the issue, these tasks can
be done small granularity.

Maybe we know a lot about the first type of people, but we need to
identify and discover the second type of people and let them come in
to help manage the community.


最近Dubbo的仓库，响应比较慢，包括pr的review，issue的分类和清理，似乎没有人处理。我的想法是发展一部分活跃的contributor成为committer，让更多的人参与进来一起帮忙。另外机器人也要参与进来。现在的问题是要找到这样的人，我觉得可以通过数据反映出来，比如GitHub上经常参加讨论的，经常参与review代码的。

另外我觉得经常提pull request的人，和经常参与社区的人，可能是两类人，前者对时间的的颗粒度要求很高，后者对时间颗粒度的要求度低。

比如我要提一个pr，需要理解一个issue,
修复，测试，需要花较大的时间，而在issue上留个言，打个label，close下issue，对时间的要求相对较低。

我们对第一类人的了解是比较多的，但需要识别和发现第二类人，让他们进来帮助管理社区。

On Sat, Dec 29, 2018 at 5:13 PM Ian Luo  wrote:
>
> Hello folks,
>
> I'd like to apologize first since recently we are slow on issue and pull
> request. We are very busy on ramping up Dubbo 2.7.0 which is expected to be
> public available soon. I hope we could come back in one or two weeks so
> depending on how soon we could finish. The code review for dubbo 2.7.0
> release is happening now on Github pull request. Feel free to join us to
> raise issue or submit pull request against the recent code changes on the
> master branch.
>
> You are also very welcomed to interact on other issues and pull requests
> irrelevant to release 2.7.0. They are piling up and we can do nothing right
> now :)
>
> I really hope we can ramp up release 2.7.0 very soon, and your
> comments/efforts are appreciated. After that, I plan to continue the
> discussion on release 3.0.
>
> Cheers,
> -Ian.



-- 
Best Regards！
Huxing

Re: Happy new year 2019

[Huxing Zhang]

Hi,

On Wed, Jan 2, 2019 at 2:20 PM Xin Wang  wrote:
>
> > How about using get the current year by javascript?
> So that, the year in the copyright do't need to update at next year.
> Not a very good method . The javascript function depend on the user's pc .
> If he time of pc is incorrect, the website will appear  incorrect.

+1 It is better to use static numbers.

>
> 老五 <176402...@qq.com> 于2019年1月2日周三 下午1:18写道：
>
> > Happy New Year!
> >
> >
> > How about using get the current year by javascript?
> > So that, the year in the copyright do't need to update at next year.
> >
> >
> > Here is my PR:
> > https://github.com/apache/incubator-dubbo-website/pull/226
> >
> >
> > -- 原始邮件 --
> > 发件人: "Huxing Zhang";
> > 发送时间: 2019年1月2日(星期三) 中午11:11
> > 收件人: "dev";
> >
> > 主题: Happy new year 2019
> >
> >
> >
> > Hi community.
> >
> > Happy New Year!
> >
> > It is already 2019, we need to update the copyright NOTICE file for
> > the new year.
> >
> > I filed an issue for incubator-dubbo and incubator-dubbo-website:
> >
> > * https://github.com/apache/incubator-dubbo/issues/3111
> > * https://github.com/apache/incubator-dubbo-website/issues/224
> >
> > Please add more if there are something missing.
> > Please send pull request if you are interested in contribution. :)
> >
> >
> > --
> > Best Regards！
> > Huxing



-- 
Best Regards！
Huxing

[incubator-dubbo-samples] branch samples-for-2.7.0-SNAPSHOT updated: change config

[liujun]

This is an automated email from the ASF dual-hosted git repository.

liujun pushed a commit to branch samples-for-2.7.0-SNAPSHOT
in repository https://gitbox.apache.org/repos/asf/incubator-dubbo-samples.git


The following commit(s) were added to refs/heads/samples-for-2.7.0-SNAPSHOT by 
this push:
 new 04c345f  change config
04c345f is described below

commit 04c345f369e78402f9b15b89c63cbfe4596b7923
Author: ken.lj 
AuthorDate: Wed Jan 2 20:27:23 2019 +0800

change config
---
 .../apache/dubbo/samples/metadatareport/configcenter/ZKTools.java   | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git 
a/dubbo-samples-metadata-report/dubbo-samples-metadata-report-configcenter/src/main/java/org/apache/dubbo/samples/metadatareport/configcenter/ZKTools.java
 
b/dubbo-samples-metadata-report/dubbo-samples-metadata-report-configcenter/src/main/java/org/apache/dubbo/samples/metadatareport/configcenter/ZKTools.java
index 35cf47c..5eaee3c 100644
--- 
a/dubbo-samples-metadata-report/dubbo-samples-metadata-report-configcenter/src/main/java/org/apache/dubbo/samples/metadatareport/configcenter/ZKTools.java
+++ 
b/dubbo-samples-metadata-report/dubbo-samples-metadata-report-configcenter/src/main/java/org/apache/dubbo/samples/metadatareport/configcenter/ZKTools.java
@@ -16,10 +16,11 @@
  */
 package org.apache.dubbo.samples.metadatareport.configcenter;
 
+import org.apache.dubbo.common.utils.StringUtils;
+
 import org.apache.curator.framework.CuratorFramework;
 import org.apache.curator.framework.CuratorFrameworkFactory;
 import org.apache.curator.retry.ExponentialBackoffRetry;
-import org.apache.dubbo.common.utils.StringUtils;
 
 /**
  *
@@ -39,8 +40,7 @@ public class ZKTools {
 }
 
 public static void generateDubboPropertiesForGlobal() {
-String str = "dubbo.registry.address=zookeeper://127.0.0.1:2181\n" +
-"dubbo.metadatareport.address=zookeeper://127.0.0.1:2181\n" +
+String str = "dubbo.registry.address=zookeeper://127.0.0.1:2181\n" + 
"dubbo.metadataReport.address=zookeeper://127.0.0.1:2181\n" +
 "#global config for consumer\n" +
 "dubbo.consumer.timeout=6000\n" +
 "#global config for provider\n" +

[incubator-dubbo-samples] 02/03: Merge remote-tracking branch 'origin/samples-for-2.7.0-SNAPSHOT' into samples-for-2.7.0-SNAPSHOT

[liujun]

This is an automated email from the ASF dual-hosted git repository.

liujun pushed a commit to branch samples-for-2.7.0-SNAPSHOT
in repository https://gitbox.apache.org/repos/asf/incubator-dubbo-samples.git

commit ebfb4b6dcc2d44e1798e55022e459e6dba587ebb
Merge: 8660a3f f8ed983
Author: ken.lj 
AuthorDate: Wed Jan 2 19:55:49 2019 +0800

Merge remote-tracking branch 'origin/samples-for-2.7.0-SNAPSHOT' into 
samples-for-2.7.0-SNAPSHOT

# Conflicts:
#   
dubbo-samples-api/src/main/java/org/apache/dubbo/samples/api/GreetingsService.java
#   
dubbo-samples-async/dubbo-samples-async-generated-future/src/main/java/org/apache/dubbo/samples/governance/AsyncConsumer.java
#   
dubbo-samples-async/dubbo-samples-async-original-future/src/main/java/org/apache/dubbo/samples/governance/filter/AsyncPostprocessFilter.java

 .../main/resources/spring/dubbo-demo-consumer.xml  |   2 +-
 .../main/resources/spring/dubbo-demo-provider.xml  |   4 +-
 .../Resilience4jAnnotationConsumer.java|   2 +-
 .../resilience4j/action/AnnotationAction.java  |  39 --
 .../filter/Resilience4jCircuitBreakerFilter.java   |  39 +-
 .../filter/Resilience4jRateLimiterFilter.java  |  13 +-
 .../resilience4j/impl/AnnotationServiceImpl.java   |   2 +-
 .../impl/CircuitBreakerServiceImpl.java|  14 ++-
 .../resilience4j/impl/RateLimiterServiceImpl.java  |   2 +-
 .../resources/spring/dubbo-consumer.properties |   3 +-
 .../resources/spring/dubbo-provider.properties |   2 +-
 .../dubbo-samples-resilience4j-springboot2/pom.xml |  95 ++
 .../Resilience4jBootAnnotationConsumer.java|  58 -
 .../Resilience4jBootAnnotationProvider.java|  61 -
 .../EmbeddedZooKeeper.java |   2 +-
 .../api/AnnotationService.java |   2 +-
 .../api/CircuitBreakerService.java}|  10 +-
 .../api/RateLimiterService.java}   |  10 +-
 .../Resilience4jBootConsumerApplication.java   |  57 +
 .../consumer}/action/AnnotationAction.java |  10 +-
 .../action/CircuitBreakMethodWrapper.java} |  28 ++---
 .../consumer/action/CircuitBreakTypeWrapper.java}  |  28 ++---
 .../consumer/action/CircuitBreakerAction.java  | 138 +
 .../consumer/action/RateLimiterAction.java |  75 +++
 .../consumer/controller/TestController.java| 103 +++
 .../provider/DubbConfiguration.java}   |  19 ++-
 .../Resilience4jBootProviderApplication.java   |  67 ++
 .../provider}/impl/AnnotationServiceImpl.java  |  10 +-
 .../provider}/impl/CircuitBreakerServiceImpl.java  |  18 ++-
 .../provider}/impl/RateLimiterServiceImpl.java |   8 +-
 ...onsumer.properties => application-consumer.yml} |  16 ++-
 ...onsumer.properties => application-provider.yml} |  15 ++-
 .../{log4j.properties => application.yml}  |  28 +++--
 .../src/main/resources/logback-spring.xml  |  45 +++
 .../resources/spring/dubbo-consumer.properties |  11 +-
 .../resources/spring/dubbo-provider.properties |  11 +-
 dubbo-samples-resilience4j/pom.xml |   2 +-
 .../src/main/resources/dubbo.properties|   8 +-
 dubbo-samples-spring-boot-hystrix/pom.xml  |   6 +
 39 files changed, 801 insertions(+), 262 deletions(-)

[incubator-dubbo-samples] branch samples-for-2.7.0-SNAPSHOT updated (f8ed983 -> bf1ca2a)

[liujun]

This is an automated email from the ASF dual-hosted git repository.

liujun pushed a change to branch samples-for-2.7.0-SNAPSHOT
in repository https://gitbox.apache.org/repos/asf/incubator-dubbo-samples.git.


from f8ed983  properties configuration format from aa-bc-dd to aaBcDd
 new 8660a3f  rewrite async sample
 new ebfb4b6  Merge remote-tracking branch 
'origin/samples-for-2.7.0-SNAPSHOT' into samples-for-2.7.0-SNAPSHOT
 new bf1ca2a  change configcenter to configCenter

The 3 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 dubbo-samples-api/pom.xml  | 17 +++---
 .../apache/dubbo/samples/api/GreetingsService.java | 12 ++
 .../dubbo/samples/governance/AsyncConsumer.java| 26 ++
 .../resources/META-INF/spring/async-consumer.xml   |  3 +--
 .../governance/filter/AsyncPostprocessFilter.java  | 11 -
 .../resources/spring/dubbo-consumer.properties |  2 +-
 .../resources/spring/dubbo-provider.properties |  4 ++--
 7 files changed, 44 insertions(+), 31 deletions(-)

[incubator-dubbo-samples] 01/03: rewrite async sample

[liujun]

This is an automated email from the ASF dual-hosted git repository.

liujun pushed a commit to branch samples-for-2.7.0-SNAPSHOT
in repository https://gitbox.apache.org/repos/asf/incubator-dubbo-samples.git

commit 8660a3f80081d27975d7387f48c055b64351f9e1
Author: ken.lj 
AuthorDate: Wed Jan 2 19:52:20 2019 +0800

rewrite async sample
---
 dubbo-samples-api/pom.xml   | 17 +
 .../org/apache/dubbo/samples/api/GreetingsService.java  | 10 +++---
 .../apache/dubbo/samples/governance/AsyncConsumer.java  |  9 ++---
 .../main/resources/META-INF/spring/async-consumer.xml   |  3 +--
 .../governance/filter/AsyncPostprocessFilter.java   |  8 
 5 files changed, 27 insertions(+), 20 deletions(-)

diff --git a/dubbo-samples-api/pom.xml b/dubbo-samples-api/pom.xml
index d343e93..6d9900e 100644
--- a/dubbo-samples-api/pom.xml
+++ b/dubbo-samples-api/pom.xml
@@ -32,7 +32,7 @@
 
 com.alibaba
 dubbo-async-processer
-1.0.0-SNAPSHOT
+1.0.0
 
 
 
@@ -57,13 +57,14 @@
 
 1.8
 1.8
-
-
-com.alibaba
-dubbo-async-processer
-1.0.0-SNAPSHOT
-
-
+
+
+
+
+
+
+
+
 
 
 
diff --git 
a/dubbo-samples-api/src/main/java/org/apache/dubbo/samples/api/GreetingsService.java
 
b/dubbo-samples-api/src/main/java/org/apache/dubbo/samples/api/GreetingsService.java
index 5d21f1d..cb002f5 100644
--- 
a/dubbo-samples-api/src/main/java/org/apache/dubbo/samples/api/GreetingsService.java
+++ 
b/dubbo-samples-api/src/main/java/org/apache/dubbo/samples/api/GreetingsService.java
@@ -1,4 +1,3 @@
-
 /*
  * Licensed to the Apache Software Foundation (ASF) under one or more
  * contributor license agreements.  See the NOTICE file distributed with
@@ -18,9 +17,14 @@
 
 package org.apache.dubbo.samples.api;
 
-import com.alibaba.dubbo.config.async.DubboAsync;
+import com.alibaba.dubbo.config.async.AsyncSignal;
+
+import java.util.concurrent.CompletableFuture;
 
-@DubboAsync
 public interface GreetingsService {
 String sayHi(String name);
+
+default CompletableFuture sayHi(String name, AsyncSignal signal) {
+return CompletableFuture.completedFuture(sayHi(name));
+}
 }
diff --git 
a/dubbo-samples-async/dubbo-samples-async-generated-future/src/main/java/org/apache/dubbo/samples/governance/AsyncConsumer.java
 
b/dubbo-samples-async/dubbo-samples-async-generated-future/src/main/java/org/apache/dubbo/samples/governance/AsyncConsumer.java
index 7198a88..84359b0 100644
--- 
a/dubbo-samples-async/dubbo-samples-async-generated-future/src/main/java/org/apache/dubbo/samples/governance/AsyncConsumer.java
+++ 
b/dubbo-samples-async/dubbo-samples-async-generated-future/src/main/java/org/apache/dubbo/samples/governance/AsyncConsumer.java
@@ -19,7 +19,10 @@
 
 package org.apache.dubbo.samples.governance;
 
-import org.apache.dubbo.samples.api.GreetingsServiceAsync;
+import org.apache.dubbo.samples.api.GreetingsService;
+
+import com.alibaba.dubbo.config.async.AsyncSignal;
+
 import org.springframework.context.support.ClassPathXmlApplicationContext;
 
 import java.util.concurrent.CompletableFuture;
@@ -33,9 +36,9 @@ public class AsyncConsumer {
 ClassPathXmlApplicationContext context = new 
ClassPathXmlApplicationContext(new 
String[]{"META-INF/spring/async-consumer.xml"});
 context.start();
 
-final GreetingsServiceAsync greetingsService = (GreetingsServiceAsync) 
context.getBean("greetingsService");
+final GreetingsService greetingsService = (GreetingsService) 
context.getBean("greetingsService");
 
-CompletableFuture future = greetingsService.sayHiAsync("async 
call reqeust");
+CompletableFuture future = greetingsService.sayHi("async call 
reqeust", AsyncSignal.SIGNAL);
 System.out.println("async call ret :" + future.get());
 
 System.out.println(greetingsService.sayHi("normal sync call request"));
diff --git 
a/dubbo-samples-async/dubbo-samples-async-generated-future/src/main/resources/META-INF/spring/async-consumer.xml
 
b/dubbo-samples-async/dubbo-samples-async-generated-future/src/main/resources/META-INF/spring/async-consumer.xml
index ed47276..43e3b61 100644
--- 
a/dubbo-samples-async/dubbo-samples-async-generated-future/src/main/resources/META-INF/spring/async-consumer.xml
+++ 
b/dubbo-samples-async/dubbo-samples-async-generated-future/src/main/resources/META-INF/spring/async-consumer.xml
@@ -28,6 +28,5 @@
 
 
 
-
-
+
 
\ No newline at end of file
diff --git 
a/dubbo-samples-async/dubbo-samples-async-original-future/src/main/java/o

[incubator-dubbo-samples] 03/03: change configcenter to configCenter

[liujun]

This is an automated email from the ASF dual-hosted git repository.

liujun pushed a commit to branch samples-for-2.7.0-SNAPSHOT
in repository https://gitbox.apache.org/repos/asf/incubator-dubbo-samples.git

commit bf1ca2a63b20209f32e25fbc98fb8af897ad
Author: ken.lj 
AuthorDate: Wed Jan 2 20:24:54 2019 +0800

change configcenter to configCenter
---
 .../src/main/resources/spring/dubbo-consumer.properties   | 2 +-
 .../src/main/resources/spring/dubbo-provider.properties   | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git 
a/dubbo-samples-metadata-report/dubbo-samples-metadata-report-configcenter/src/main/resources/spring/dubbo-consumer.properties
 
b/dubbo-samples-metadata-report/dubbo-samples-metadata-report-configcenter/src/main/resources/spring/dubbo-consumer.properties
index 9953908..c98fb80 100644
--- 
a/dubbo-samples-metadata-report/dubbo-samples-metadata-report-configcenter/src/main/resources/spring/dubbo-consumer.properties
+++ 
b/dubbo-samples-metadata-report/dubbo-samples-metadata-report-configcenter/src/main/resources/spring/dubbo-consumer.properties
@@ -17,7 +17,7 @@
 #
 #
 dubbo.application.name=metadatareport-configcenter-consumer
-dubbo.configcenter.address=zookeeper://127.0.0.1:2181
+dubbo.configCenter.address=zookeeper://127.0.0.1:2181
 # The common part, for example registry, protocol can be stored under the 
global group in ConfigCenter
 #dubbo.registry.address=zookeeper://127.0.0.1:2181
 # The application specific part, can be stored under the app group in the 
ConfigCenter
diff --git 
a/dubbo-samples-metadata-report/dubbo-samples-metadata-report-configcenter/src/main/resources/spring/dubbo-provider.properties
 
b/dubbo-samples-metadata-report/dubbo-samples-metadata-report-configcenter/src/main/resources/spring/dubbo-provider.properties
index 54aa2fd..1171526 100644
--- 
a/dubbo-samples-metadata-report/dubbo-samples-metadata-report-configcenter/src/main/resources/spring/dubbo-provider.properties
+++ 
b/dubbo-samples-metadata-report/dubbo-samples-metadata-report-configcenter/src/main/resources/spring/dubbo-provider.properties
@@ -17,8 +17,8 @@
 #
 #
 dubbo.application.name=metadatareport-configcenter-provider
-dubbo.configcenter.address=zookeeper://127.0.0.1:2181
-dubbo.configcenter.configfile=dubbo.properties
+dubbo.configCenter.address=zookeeper://127.0.0.1:2181
+dubbo.configCenter.configFile=dubbo.properties
 
 # The common part, for example registry, protocol can be stored under the 
global group in ConfigCenter
 # The application specific part, can be stored under the app group in the 
ConfigCenter

[incubator-dubbo-samples] branch samples-for-2.7.0-SNAPSHOT updated: properties configuration format from aa-bc-dd to aaBcDd

[victory]

This is an automated email from the ASF dual-hosted git repository.

victory pushed a commit to branch samples-for-2.7.0-SNAPSHOT
in repository https://gitbox.apache.org/repos/asf/incubator-dubbo-samples.git


The following commit(s) were added to refs/heads/samples-for-2.7.0-SNAPSHOT by 
this push:
 new f8ed983  properties configuration format from aa-bc-dd to aaBcDd
f8ed983 is described below

commit f8ed98353155beaa66f9a79f63712eebf66d66b6
Author: cvictory 
AuthorDate: Wed Jan 2 19:06:10 2019 +0800

properties configuration format from aa-bc-dd to aaBcDd
---
 .../src/main/resources/dubbo.properties   | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git 
a/dubbo-samples-simplified-registry/dubbo-samples-simplified-registry-xml/src/main/resources/dubbo.properties
 
b/dubbo-samples-simplified-registry/dubbo-samples-simplified-registry-xml/src/main/resources/dubbo.properties
index 9636821..c420ab3 100644
--- 
a/dubbo-samples-simplified-registry/dubbo-samples-simplified-registry-xml/src/main/resources/dubbo.properties
+++ 
b/dubbo-samples-simplified-registry/dubbo-samples-simplified-registry-xml/src/main/resources/dubbo.properties
@@ -17,7 +17,7 @@
 #
 #
 
-dubbo.registrydata.simple-provider-config=true
-dubbo.registrydata.extra-provider-keys=retries,owner
-dubbo.registrydata.simple-consumer-config=true
-dubbo.registrydata.extra-consumer-keys=actives,owner
+dubbo.registryData.simpleProviderConfig=true
+dubbo.registryData.extraProviderKeys=retries,owner
+dubbo.registryData.simpleConsumerConfig=true
+dubbo.registryData.extraConsumerKeys=actives,owner

Re: Dubbo and its microservice Ecosystem

[Huxing Zhang]

Hi,

Several days ago I have posted an email to describe Dubbo has its ecosystem.

These days I thought more about this topic, and I'd like to share some
of the thoughts here.

For years Dubbo has been played important role in helping users to
migration from monolithic application to distributed services. It is
good to see that Dubbo has offered help in areas like service
registration, service discovery, and service governance for a
distributed applications.

As more and more companies are embracing micro-services, we found that
Dubbo, as a RPC framework, could not meet the various need of
micro-services, such as API gateway, circuit breaker, monitoring,
distributed transactions, etc. We lack an entire solution to build
micro-service with Dubbo. It should cover all the areas of when
building microservices. The components should be selected and
evaluated by the community. They should be well integrated with Dubbo,
battle tested in the production system, and easy for developers to
use.

Therefore I am going to propose that:

1. Update Dubbo's positioning. Dubbo is more than a RPC framework, it
is a micro-service framework which helps developers to build high
performance micro-service applications.
2. Establish Apache Dubbo Ecosystem. It contains multiple projects
around Apache Dubbo, which provides production-ready best practices to
build microservices applications.

According to the importance to build microservices, I suggest to
divide the components into different levels:

* Level 0: RPC/Rest/Mesh, this level includes the core infrastructure
of micro-services
* Level 1: Registry, Configuration, Metrics, Reliability(e.g. Circuit
breaker) , these are crucial components of micro-services
* Level 2: API gateway, Tracing, Diagnostics, Transaction
* Level 3: Scheduling, Event, Authentication, etc.

Another feature of the components in the ecosystem is that the data of
different components can be easily retrieved by each other, so that it
can have one-stop monitoring and management. For example, we can use
dubbo-ops to monitor and manage these components in the ecosystem.

What needs to be included in the ecosystem remains to be discussed.
For example, for service registry we support Apache Zookeeper, and it
is better to add support for Etcd, and Nacos. For configuration,
Apollo and Nacos seems to be good candidates. For circuit breaker,
Sentinel looks really promising.

It is important to note that not every component should be built from
scratch, instead it is better to integrate with well-known,
production-ready projects.

This is my initial thoughts, any feedback is welcome.

Below is the Chinese version:

随着近几年微服务的流行，越来越多的用户选择从单体应用向分布式应用进行转型。很高兴的看到近几年的过程中，Dubbo提供的服务注册发现，远程服务调用，以及服务监控治理的能力帮助到企业在架构转型中受益。

但是微服务化的逐渐深入，我们也发现Dubbo目前提供的能力逐渐无法满足微服务的各个方面需求。例如API
gateway，熔断限流，分布式监控，分布式事务等方面，缺乏一套比较完整的围绕Dubbo的解决方案，基本上要么是是各个公司自研，要么需要调研外面开源的各种框架进行调研选型，花费了比较大的时间和精力在这上面，却无法形成一套体系化的方案。我们应当围绕Dubbo打造一整套微服务的解决方案，它包含了一系列的项目，涵盖微服务开发中的各个方面。这里面的项目都是经过Dubbo社区共同评估过，和Dubbo进行高度集成，且在生产中得到过验证的项目。

基于此，我建议：

1. 更新Dubbo的定位，Dubbo不仅仅是一个RPC框架，它是一个微服务框架，帮助开发者快速构建高性能微服务应用
2. 建立Apache Dubbo Ecosystem ，它是围绕 Apache Dubbo 打造的微服务生态，是经过生产验证的微服务的最佳实践组合

根据微服务构建的重要性，我们可以把各个组件划分为几个层级：

* Level 0: RPC/Rest/Mesh,
* Level 1: 服务注册发现, 服务配置, Metrics, 熔断限流
* Level 2: API gateway, 分布式追踪, 诊断, 分布式事务
* Level 3: 分布式调度, 事件, 鉴权等等

各组件之间的数据能够互通，使得各个组件之间能够进行一站式的管控。例如可以通过dubbo-ops对熔断限流的阈值进行配置等等。

生态里面的各个组件的实现具体应当选择谁，这个是另外一个话题。比如服务注册发现目前已经支持了Zookeeper，后续可以考虑支持Etcd和Nacos。配置中心Apollo和Nacos都是很好的候选。熔断限流方面Sentinel看起来是一个不错的选择。应该和那些进行集成，希望大家一起来参与讨论，由社区共同决定。并不是所有的组件都要重新实现一遍，和已有的成熟的开源组件进行集成是一条更为可行的路。

以上是我的一些想法，希望大家多多提意见。


On Fri, Dec 14, 2018 at 12:53 AM Huxing Zhang  wrote:
>
> Hi,
>
> Recently, I have seen people asking questions like:
> - What is the difference between Dubbo and Spring Cloud?
> - Can Dubbo support restful service?
>
> This makes me think about the relationship between Dubbo as an RPC
> framework and Micro-services.
>
> When talking about micro-services, we are talking about service
> registry and discovery, configuration, circuit breaker, observability
> like tracing, logging, API gateway, load balancing and etc.
>
> When I looked into Dubbo, actually I see very well integration with
> most of components.
>
> - service registry and discovery: zookeeper, Nacos, etc...
> - configuration: Nacos, Apollo, etc...
> - circuit breaker: hystrix, sentinel
> - tracing: zipkin, sleuth, skywalking
>
> Some other components might need some extra work, for example, API
> gateway, client side load balancing. But this should be achieved
> without too much work. What we are missing is some official guidance.
>
> With these components surrounded by, I am thinking that the Dubbo
> Ecosystem is not only RPC Ecosystem, it is actually a Microservice
> Ecosystem.
>
> There is currently a Dubbo ecosystem in the community page on the
> website[1], I suggest we build a dedicated page on the website, to
> introduce the new Dubbo Ecosystem.
>
> Now back to the questions:
>
> - What is 

Re: PR raised for dubbo-config-api

[Imteyaz Khan]

Ian, I have incorporated the changes, could you have a look and provide me
your feedback.

On Wed, Jan 2, 2019 at 3:08 PM Imteyaz Khan  wrote:

> Sure. I appreciate you comment and I am on it.
>
> On Wed, Jan 2, 2019 at 2:49 PM Ian Luo  wrote:
>
>> Imteyaz,
>>
>> The change looks good to me, but I have a minor comment on your change.
>> Would you mind to take a look?
>>
>> Thanks,
>> -Ian.
>>
>> On Mon, Dec 31, 2018 at 10:57 PM Imteyaz Khan 
>> wrote:
>>
>> > Hi All,
>> >   I have raised PR  <
>> https://github.com/apache/incubator-dubbo/pull/3108>
>> > for
>> > dubbo-config-api. In this PR have replaced the pending hard coded values
>> > with constant so that we can minimize accidental issue due to hard coded
>> > value used in multiple places. I have created the issue (3107
>> > ) for the same.
>> >
>> > Please review.
>> >
>> > https://github.com/apache/incubator-dubbo/pull/3108
>> >
>>
>

PR raised

[华 钟明]

Hi All,
I have raised PR  https://github.com/apache/incubator-dubbo/pull/3043
For
event setting is wrong when the event is READONLY_EVENT.

Best Regards！
Zhongming Hua

Re: PR raised for dubbo-config-api

[Imteyaz Khan]

Sure. I appreciate you comment and I am on it.

On Wed, Jan 2, 2019 at 2:49 PM Ian Luo  wrote:

> Imteyaz,
>
> The change looks good to me, but I have a minor comment on your change.
> Would you mind to take a look?
>
> Thanks,
> -Ian.
>
> On Mon, Dec 31, 2018 at 10:57 PM Imteyaz Khan 
> wrote:
>
> > Hi All,
> >   I have raised PR   >
> > for
> > dubbo-config-api. In this PR have replaced the pending hard coded values
> > with constant so that we can minimize accidental issue due to hard coded
> > value used in multiple places. I have created the issue (3107
> > ) for the same.
> >
> > Please review.
> >
> > https://github.com/apache/incubator-dubbo/pull/3108
> >
>

Re: PR raised for dubbo-config-api

[Ian Luo]

Imteyaz,

The change looks good to me, but I have a minor comment on your change.
Would you mind to take a look?

Thanks,
-Ian.

On Mon, Dec 31, 2018 at 10:57 PM Imteyaz Khan 
wrote:

> Hi All,
>   I have raised PR  
> for
> dubbo-config-api. In this PR have replaced the pending hard coded values
> with constant so that we can minimize accidental issue due to hard coded
> value used in multiple places. I have created the issue (3107
> ) for the same.
>
> Please review.
>
> https://github.com/apache/incubator-dubbo/pull/3108
>

A blog about `Understand distributed trace easier in the incoming 6-GA`

[???? Sheng Wu]

Hi.


We always talk about why need distributed trace, but actually more important is 
how to use it. 
So I wrote this blog to talk this, there are several typical scenarios. 
The blog is http://skywalking.apache.org/blog/2019-01-01-Understand-Trace.html 
, 
the twitter linked to this blog 
https://twitter.com/wusheng1108/status/1080385534625669120


I am forwarding this mail to SkyWalking, Zipkin, ShardingSphere, Dubbo 
communities, considering these are all related to distributed tracing field
and SkyWalking.
Feedback is welcome. Please re-twitter this if you think this is helpful.


Hope this document will help the people who have interests in using distributed 
tracing system.


Thanks Adrian for helping on this blog. 


--
Sheng Wu
Apache SkyWalking, ShardingSphere, Zipkin
Twitter, wusheng1108