[jira] [Commented] (FINERACT-423) Compilation fails due to missing licence header in some files

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15974388#comment-15974388
 ] 

ASF GitHub Bot commented on FINERACT-423:
-

GitHub user raj140916 opened a pull request:

https://github.com/apache/incubator-fineract/pull/334

FIX FINERACT-423: Compilation fails due to missing licence header in …

…some files

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/raj140916/incubator-fineract develop

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-fineract/pull/334.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #334


commit 187faf5153d36af6ce2dbdfd441046f6de3c5754
Author: unknown 
Date:   2017-04-19T09:26:56Z

FIX FINERACT-423: Compilation fails due to missing licence header in some 
files




> Compilation fails due to missing licence  header in some files 
> ---
>
> Key: FINERACT-423
> URL: https://issues.apache.org/jira/browse/FINERACT-423
> Project: Apache Fineract
>  Issue Type: Task
>Reporter: Raju Metgiri
>Assignee: Markus Geiss
>Priority: Trivial
>  Labels: p3
> Attachments: Screen Shot 2017-04-09 at 15.59.00.png
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> if a developer does git clone of the current repo and starts a build, the 
> build will fail. This caused due to the task "licenseMain" as some of the 
> files are missing licence headers. I would like to correct this and submit 
> the changes.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FINERACT-389) Arrange the accounts that fall under one account type in order of their GL codes

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15963303#comment-15963303
 ] 

ASF GitHub Bot commented on FINERACT-389:
-

GitHub user ThisuraThejith opened a pull request:

https://github.com/apache/incubator-fineract/pull/330

Fix FINERACT-389

ordere by gl_code added to sql query in retrieveAllGLAccounts

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ThisuraThejith/incubator-fineract FINERACT-389

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-fineract/pull/330.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #330


commit 1b438021421f6f64414cc5889735987a622f1f3a
Author: ThisuraThejith 
Date:   2017-04-10T18:32:02Z

ordere by gl_code added to sql query in retrieveAllGLAccounts




> Arrange the accounts that fall under one account type in order of their GL 
> codes
> 
>
> Key: FINERACT-389
> URL: https://issues.apache.org/jira/browse/FINERACT-389
> Project: Apache Fineract
>  Issue Type: Improvement
>  Components: Accounting
>Reporter: Santosh Math
>Assignee: Markus Geiss
>Priority: Minor
>  Labels: p2
>
> Reported by Mexina Daniel at https://mifosforge.jira.com/browse/MIFOSX-2825
> Original Description:
> Accounts in chart of accounts are arranged by their account type but those 
> accounts in the specific account type are randomly arranged.
> I was recommending for the accounts in the same account type to be arranged 
> by their GL code. Since the relating accounts will be under one header and so 
> their GL codes will be following each other and bring presentable 
> arrangement. (accounts in the same header, their GL codes should have 
> relation)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FINERACT-78) Specified due date percentage charge calculation uses loan principal amount instead of installment principal amount

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15948866#comment-15948866
 ] 

ASF GitHub Bot commented on FINERACT-78:


Github user asfgit closed the pull request at:

https://github.com/apache/incubator-fineract/pull/324


> Specified due date percentage charge calculation uses loan principal amount 
> instead of installment principal amount
> ---
>
> Key: FINERACT-78
> URL: https://issues.apache.org/jira/browse/FINERACT-78
> Project: Apache Fineract
>  Issue Type: Bug
>Reporter: Emmanuel Nnaa
>Assignee: Markus Geiss
>  Labels: p1
> Attachments: Sp. Charge 1.png, Sp. Charge 2.png, Sp. Charge 3.png, 
> Sp. Charge 4.png
>
>
> Specified due date percentage charge calculation uses loan principal amount 
> instead of installment principal amount.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FINERACT-78) Specified due date percentage charge calculation uses loan principal amount instead of installment principal amount

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15944754#comment-15944754
 ] 

ASF GitHub Bot commented on FINERACT-78:


GitHub user nazeer1100126 opened a pull request:

https://github.com/apache/incubator-fineract/pull/324

FINERACT-78 : Specified due date percentage charge calculation uses loan 
principal amount instead of installment principal amount



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nazeer1100126/incubator-fineract FINERACT-78

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-fineract/pull/324.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #324


commit 8baf9f4cd0de899ae015f1994e17b1b0e8b39641
Author: nazeer1100126 
Date:   2017-03-27T12:04:20Z

FINERACT-78 : Specified due date percentage charge calculation uses loan 
principal amount instead of installment principal amount




> Specified due date percentage charge calculation uses loan principal amount 
> instead of installment principal amount
> ---
>
> Key: FINERACT-78
> URL: https://issues.apache.org/jira/browse/FINERACT-78
> Project: Apache Fineract
>  Issue Type: Bug
>Reporter: Emmanuel Nnaa
>Assignee: Markus Geiss
>  Labels: p1
> Attachments: Sp. Charge 1.png, Sp. Charge 2.png, Sp. Charge 3.png, 
> Sp. Charge 4.png
>
>
> Specified due date percentage charge calculation uses loan principal amount 
> instead of installment principal amount.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FINERACT-360) Individual Collection Sheet is not considering 'Installment Fee' during payment

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15943213#comment-15943213
 ] 

ASF GitHub Bot commented on FINERACT-360:
-

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-fineract/pull/323


> Individual Collection Sheet is not considering 'Installment Fee' during 
> payment
> ---
>
> Key: FINERACT-360
> URL: https://issues.apache.org/jira/browse/FINERACT-360
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Loan
>Reporter: Santosh Math
>Assignee: Markus Geiss
>  Labels: p1
> Attachments: 1.png
>
>
> 1. Create a client under Head Office. 
> 2. Create a loan account for a client(with Installment Fee and staff 
> attached) and weekly repayment. Disburse it on 02 January 2015.
> 3. Go to Individual Collection Sheet and furnish following details:
>  Branch  Office : Head Office
>  Repayment Date: 09 January 2015
>  Staff: *Give the name of the  staff assigned to loan account*
> 4. Click on Collection Sheet. 
> >> When we observe collection sheet, the amount is reflecting 
> >> Principal+Interest but not installment fee. 
> >>If we submit it, in repayment schedule, the Installment  Fee is shown as 
> >>'Outstanding' Balance.
>  If we consider 'Specified Due Date' Fee in stead of 'Installment Fee', the 
> individual sheet is working fine. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FINERACT-303) "% Loan Amount + Interest or %Amount" if collected as disbursement fees it is not working as expected

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940209#comment-15940209
 ] 

ASF GitHub Bot commented on FINERACT-303:
-

GitHub user nazeer1100126 opened a pull request:

https://github.com/apache/incubator-fineract/pull/322

FINERACT-303 - % Loan Amount + Interest or %Amount if collected as 
disbursement fees it is not working as expected



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nazeer1100126/incubator-fineract FINERACT-303

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-fineract/pull/322.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #322


commit f59dacbfc8a04031cd9521ed1c23bc57245d2c26
Author: nazeer1100126 
Date:   2017-03-24T11:50:40Z

FINERACT-303 - % Loan Amount + Interest or %Amount if collected as 
disbursement fees it is not working as expected




> "% Loan Amount + Interest or %Amount" if collected as disbursement fees it is 
> not working as expected
> -
>
> Key: FINERACT-303
> URL: https://issues.apache.org/jira/browse/FINERACT-303
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Loan
>Reporter: Santosh Math
>Assignee: Markus Geiss
>  Labels: p1
> Attachments: Scr-689.png, Scr-690.png
>
>
> Reported  by Subramanya at https://mifosforge.jira.com/browse/MIFOSX-2056
> Original  Description:
> 1. Create a charge of 1% as Disbursement fees as "% Loan Amount + Interest or 
> % Approved Amount".
> 2. Create a loan product with 2 tranche and amount as 1 and add above 
> mentioned charge to it.
> 3. Create a client and submit new loan application with above mentioned loan 
> product on 01 May 2015 with 2 tranches added
> first tranche on 01 May 2015 and amount as 5000.
> Second tranche on 15 May 2015 and amount as 5000.
> 4. Approve and disburse first tranche on 01 May 2015.
> > Since charge applied on %loan amount total+interest, it should collect 
> > charge as 109.39,
> but it is collecting 59.39.
> 5. After making the second disbursement on 15 May 2015 it is getting 
> collected 109.39,
> but in charges it is displaying as 50 outstanding.
> 6. If the disbursement amount is modified during loan approval then in 
> repayment schedule the charge is not getting updated. (eg. submit loan 
> application with first tranch 5000 and second tranch 5000, during approval 
> change amount as 4000 and 4000 for first and second tranch. then %amount 
> charge is displaying with respect to first tranche amount only.)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FINERACT-270) Unable to waive all Loan charges

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15938279#comment-15938279
 ] 

ASF GitHub Bot commented on FINERACT-270:
-

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-fineract/pull/321


> Unable to waive all Loan charges
> 
>
> Key: FINERACT-270
> URL: https://issues.apache.org/jira/browse/FINERACT-270
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Loan
> Environment: Reproducible on demo.openmf.org. 
> Create new client Loan with FINERACT_7-MIFOS_2495
>Reporter: Abdul Aziz Ali
>Assignee: Markus Geiss
>Priority: Trivial
>  Labels: p1
> Attachments: pruned_catalina.log
>
>
> Create Loan and Charge similar to FINERACT-7
> 
> (verbatim from FINERACT-7)
> 1. Create Installment fee for a loan as 100-Flat-Regular. 
> 2. Create loan product with following datasets and attache above installment 
> fee to that.
> Terms vary based on loan cycle :  FALSE
> Principal:10,000 ( Min: , Max : )
> Number of Repayments: 12 ( Min: , Max
> Repay Every:  1 Months
> Nominal Interest Rate:1 ( Min: , Max Per month
> Minimum days between disbursal and first repayment date   
> Amortization  Equal installments
> Interest Method   Declining Balance
> Interest Calculation Period   Daily
> Repayment StrategyOverdue/Due Fee/Int,Principal
> Account moves out of NPA only after all arrears have been cleared?No
> Days in year  Actual
> Days in month Actual
> Principal Threshold (%) for Last Instalment   0
> Allow fixing of the installment amountNo
> Interest Recalculation
> Recalculate Interest  Yes
> Advance payments adjustment type  Reduce number of installments
> Pre-closure interest calculation rule Calculate till pre closure date
> Interest recalculation compounding on None
> Frequency for recalculate Outstanding Principal   Daily
> Frequency Interval for recalculation  1
> Frequency Date for recalculation  01-Jan-15
> Is Arrears recognization based on original schedule:No.
> 3. Submit new loan application on 01 October 2015. Approve and disburse loan 
> on same date.
> 4. Click on waive charge and select for 1st repayment.
> 5. Repayment schedule generated after waive charge is not proper
> >Waive charge is happening not for first installment instead for other 
> >installment it is happening.
> 6. For first repayment the due is getting displayed.
> 
> 7. Keep waiving all charges until the last one
> The last one does not get waived nor does the Exception get raised to the UI.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FINERACT-418) Penalties should be calculated until yesterday

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15935817#comment-15935817
 ] 

ASF GitHub Bot commented on FINERACT-418:
-

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-fineract/pull/319


> Penalties should be calculated until yesterday
> --
>
> Key: FINERACT-418
> URL: https://issues.apache.org/jira/browse/FINERACT-418
> Project: Apache Fineract
>  Issue Type: Improvement
>  Components: Loan
>Reporter: Lionel Raymundi
>Assignee: Markus Geiss
>  Labels: p2
> Attachments: tests_with_modified_penalties_calculation_process.odt, 
> tests_with_monthly_penalties.ods
>
>
> If the Apply Penalties to Overdued loans job is run on the N day, and 
> considering that system properties Grace on Penalty posting = 0 and 
> penalty-wait-period = 0, then charges should be generated until N-1 (the day 
> before N). But I see only charges generated until N-2 (Two days before).
> We have noticed that penalty charges are being generated one day late for 
> some cases. For example: 
> .- Lets suppose the due date of an installment is on march the 5th.
> .- Overdue penalty is configured as 1% of installment interest, charged daily.
> .- System configuration has Grace on Penalty posting = 0 and 
> penalty-wait-period = 0
> .- Run the Apply penalties to Overdued Loans job.
> .- Today is march the 7th, so I would expect to see penalties on that 
> installment on the repayment schedule considering the following:
> a) Client didn't pay On march 5th. One penalty charge should be generated.
> b) Client didn't pay On march 6th. Two penalty charges should be generated.
> .- I would also expect to see the charge generated with due as of date 05 and 
> 06 March 2017 under "Charges" tab. But I only see one penalty, as of 05.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FINERACT-321) Manual Journal entries should not allowed to reverse after accounting closure is done for that branch

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15935807#comment-15935807
 ] 

ASF GitHub Bot commented on FINERACT-321:
-

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-fineract/pull/318


> Manual Journal entries should not allowed to reverse after accounting closure 
> is done for that branch
> -
>
> Key: FINERACT-321
> URL: https://issues.apache.org/jira/browse/FINERACT-321
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Accounting
>Reporter: Santosh Math
>Assignee: Markus Geiss
>  Labels: p2
>
> Reported by Subramanya  at https://mifosforge.jira.com/browse/MIFOSX-2519
> Original Description:
> 1. Create 2 Chart of accounts with Asset1 and Asset 2.
> 2. Click on accounting -> Add Journal entries -> Add one debit and Credit 
> entries with above entities on 31 January 2016.
> 3. Click on Accounting and Click on Closing entries and close the accounting 
> entries for the organization on 01 February 2016.
> 4. Navigate back to the journal entries created and click on reverse entries. 
> It is allowing to reverse.
> > It should not allowed to reverse the entries once Accounting entry is 
> > closed for the branch



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FINERACT-330) No error message is getting displayed in productive collection sheet if meeting is not attached to center/group

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15935804#comment-15935804
 ] 

ASF GitHub Bot commented on FINERACT-330:
-

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-fineract/pull/317


> No error message is  getting displayed in productive collection sheet if 
> meeting is not attached  to center/group
> -
>
> Key: FINERACT-330
> URL: https://issues.apache.org/jira/browse/FINERACT-330
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Client, Groups
>Reporter: Santosh Math
>Assignee: Santosh Math
>Priority: Minor
>  Labels: p2
> Fix For: 0.7.0-incubating
>
> Attachments: 1.png
>
>
> Steps to reproduce:
> 1. Create a center under Head Office and activate it on 01 Jan 2013.Attach 
> staff. Don't attach meeting.
> 2. Create a group under this center and activate it on 01 Jan 2013.
> 3. Create a client in this group with activation date 01 Jan 2013
> 4. Approve and Disburse JLG Loan(Frequeny weekly repayment) 02 Jan 2015.
> 5. Go to collection sheet. and select:
> Branch Office: Head Office
> Meeting Calender: 09 Jan 2015
> Staff: *provide same staff name of the  center
> 6. Click on "Productive Collection Sheet".
> In Productive Collection Sheet page, there is no error message is displayed 
> related to meeting not attached.
> Expected Result: the error message should be displayed as "Collection can not 
> be generated without meeting attached to center"
>   



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FINERACT-243) Constitution Type Required Field

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15935801#comment-15935801
 ] 

ASF GitHub Bot commented on FINERACT-243:
-

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-fineract/pull/313


> Constitution Type Required Field
> 
>
> Key: FINERACT-243
> URL: https://issues.apache.org/jira/browse/FINERACT-243
> Project: Apache Fineract
>  Issue Type: Improvement
>Reporter: Dayna Harp
>Assignee: Santosh Math
>Priority: Critical
>  Labels: p2
> Fix For: 0.7.0-incubating
>
>
> when creating a client with Legal Form "Entity", Constitution is a required 
> field.  This does not need to be required.  It is an optional field for those 
> financial institutions serving groups that have a constitution.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FINERACT-345) Should not allow to add guarantor, If savings account transaction date is greater that loan application submitted date

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15935796#comment-15935796
 ] 

ASF GitHub Bot commented on FINERACT-345:
-

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-fineract/pull/312


> Should not allow to add guarantor, If savings account transaction date is 
> greater that loan application submitted date
> --
>
> Key: FINERACT-345
> URL: https://issues.apache.org/jira/browse/FINERACT-345
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Loan
>Reporter: Santosh Math
>Assignee: Markus Geiss
>  Labels: p1
>
> Reported by  Savita Pujar at https://mifosforge.jira.com/browse/MIFOSX-2128
> Original Description:
> 1. Create a Loan Product with the following credentials
> -->principal amount as 1,Number of repayments 12,Nominal Interest rate 1% 
> p.a,Rapid every 1 month,Amortization as Equal installments ,Interest Method 
> as Declining Balance,Interest Calculation Period as Same as repayment 
> period,Repayment Strategy as Mifos style ,In Guarantee Requirements check 
> Place Guarantee Funds On-Hold? give Mandatory Guarantee: (%) as 100, Minimum 
> Guarantee from Own Funds: (%) as 50, Minimum from Guarantor Funds: (%) 50.
> 2.Create 2 Clients and activate on 1 jan 2014, active 1 saving account for 
> each client with balance 500 on 1 December 2014.
> 3. Deposit 5 amount in each savings account on 1 Feb 2015
> 4. Submit new loan application for the same client on 1 jan 2015 
> 5.Click on more in same loan account page ,click on create guarantor , select 
> self guarantor with 5000 and external guarantor as 5000
> 6.Now approve the loan
> >Should not allow to approve the loan since saving account transaction date 
> >is grater than loan submitted date.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FINERACT-418) Penalties should be calculated until yesterday

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15932072#comment-15932072
 ] 

ASF GitHub Bot commented on FINERACT-418:
-

GitHub user lionelraymundi opened a pull request:

https://github.com/apache/incubator-fineract/pull/319

FINERACT-418 penalties should be applied until the day before running job

changed diff condition to <1. Previous version made penalties to be 
calculated until the same day the job was running

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/lionelraymundi/incubator-fineract FINERACT-418

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-fineract/pull/319.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #319


commit a7b27d6d363198c6017408a768d90015b047ef0c
Author: Lionel Raymundi - Poincenot 
Date:   2017-03-20T02:11:29Z

FINERACT-418 penalties should be applied until the day before running job




> Penalties should be calculated until yesterday
> --
>
> Key: FINERACT-418
> URL: https://issues.apache.org/jira/browse/FINERACT-418
> Project: Apache Fineract
>  Issue Type: Improvement
>  Components: Loan
>Reporter: Lionel Raymundi
>Assignee: Markus Geiss
>  Labels: p2
> Attachments: tests_with_modified_penalties_calculation_process.odt, 
> tests_with_monthly_penalties.ods
>
>
> If the Apply Penalties to Overdued loans job is run on the N day, and 
> considering that system properties Grace on Penalty posting = 0 and 
> penalty-wait-period = 0, then charges should be generated until N-1 (the day 
> before N). But I see only charges generated until N-2 (Two days before).
> We have noticed that penalty charges are being generated one day late for 
> some cases. For example: 
> .- Lets suppose the due date of an installment is on march the 5th.
> .- Overdue penalty is configured as 1% of installment interest, charged daily.
> .- System configuration has Grace on Penalty posting = 0 and 
> penalty-wait-period = 0
> .- Run the Apply penalties to Overdued Loans job.
> .- Today is march the 7th, so I would expect to see penalties on that 
> installment on the repayment schedule considering the following:
> a) Client didn't pay On march 5th. One penalty charge should be generated.
> b) Client didn't pay On march 6th. Two penalty charges should be generated.
> .- I would also expect to see the charge generated with due as of date 05 and 
> 06 March 2017 under "Charges" tab. But I only see one penalty, as of 05.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FINERACT-321) Manual Journal entries should not allowed to reverse after accounting closure is done for that branch

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15929849#comment-15929849
 ] 

ASF GitHub Bot commented on FINERACT-321:
-

GitHub user nazeer1100126 opened a pull request:

https://github.com/apache/incubator-fineract/pull/318

FINERACT-321 - Manual Journal entries should not allowed to reverse after 
accounting closure is done for that branch.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nazeer1100126/incubator-fineract FINERACT-321

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-fineract/pull/318.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #318


commit 5f74453606db080ae96fafbd58b0a5df96b5362c
Author: nazeer1100126 
Date:   2017-03-17T12:19:05Z

FINERACT-321 - Manual Journal entries should not allowed to reverse after 
accounting closure is done for that branch




> Manual Journal entries should not allowed to reverse after accounting closure 
> is done for that branch
> -
>
> Key: FINERACT-321
> URL: https://issues.apache.org/jira/browse/FINERACT-321
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Accounting
>Reporter: Santosh Math
>Assignee: Markus Geiss
>  Labels: p2
>
> Reported by Subramanya  at https://mifosforge.jira.com/browse/MIFOSX-2519
> Original Description:
> 1. Create 2 Chart of accounts with Asset1 and Asset 2.
> 2. Click on accounting -> Add Journal entries -> Add one debit and Credit 
> entries with above entities on 31 January 2016.
> 3. Click on Accounting and Click on Closing entries and close the accounting 
> entries for the organization on 01 February 2016.
> 4. Navigate back to the journal entries created and click on reverse entries. 
> It is allowing to reverse.
> > It should not allowed to reverse the entries once Accounting entry is 
> > closed for the branch



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FINERACT-384) Product Mix - for Saving Accounts

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15926121#comment-15926121
 ] 

ASF GitHub Bot commented on FINERACT-384:
-

GitHub user Ippezrobert opened a pull request:

https://github.com/apache/incubator-fineract/pull/314

FINERACT-384 - Product Mix - for Saving Accounts



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Ippezrobert/incubator-fineract 
product_mix_savings

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-fineract/pull/314.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #314


commit ef715578665849b043df5ab141542325036b5948
Author: Ippez Robert 
Date:   2017-03-15T12:55:31Z

FINERACT-384 - Product Mix - for Saving Accounts




> Product Mix - for Saving Accounts
> -
>
> Key: FINERACT-384
> URL: https://issues.apache.org/jira/browse/FINERACT-384
> Project: Apache Fineract
>  Issue Type: Improvement
>Reporter: Ippez Roberts
>Assignee: Markus Geiss
>  Labels: p2
>
> The Product mix for Loan Accounts needs to be added to cater for Savings 
> Products as some MFI have a policy to restrict a client from opening some 
> savings product together by the same client.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FINERACT-345) Should not allow to add guarantor, If savings account transaction date is greater that loan application submitted date

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15924233#comment-15924233
 ] 

ASF GitHub Bot commented on FINERACT-345:
-

GitHub user nazeer1100126 opened a pull request:

https://github.com/apache/incubator-fineract/pull/312

FINERACT-345 : Should not allow to add guarantor, If savings account 
transaction date is greter that loan application submitted date



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nazeer1100126/incubator-fineract FINERACT-345

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-fineract/pull/312.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #312


commit e47f4dde8b33701d3c3a092abc9b4e54c747d913
Author: nazeer1100126 
Date:   2017-03-14T12:58:08Z

FINERACT-345 : Should not allow to add guarantor, If savings account 
transaction date is greter that loan application submitted date




> Should not allow to add guarantor, If savings account transaction date is 
> greater that loan application submitted date
> --
>
> Key: FINERACT-345
> URL: https://issues.apache.org/jira/browse/FINERACT-345
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Loan
>Reporter: Santosh Math
>Assignee: Markus Geiss
>  Labels: p1
>
> Reported by  Savita Pujar at https://mifosforge.jira.com/browse/MIFOSX-2128
> Original Description:
> 1. Create a Loan Product with the following credentials
> -->principal amount as 1,Number of repayments 12,Nominal Interest rate 1% 
> p.a,Rapid every 1 month,Amortization as Equal installments ,Interest Method 
> as Declining Balance,Interest Calculation Period as Same as repayment 
> period,Repayment Strategy as Mifos style ,In Guarantee Requirements check 
> Place Guarantee Funds On-Hold? give Mandatory Guarantee: (%) as 100, Minimum 
> Guarantee from Own Funds: (%) as 50, Minimum from Guarantor Funds: (%) 50.
> 2.Create 2 Clients and activate on 1 jan 2014, active 1 saving account for 
> each client with balance 500 on 1 December 2014.
> 3. Deposit 5 amount in each savings account on 1 Feb 2015
> 4. Submit new loan application for the same client on 1 jan 2015 
> 5.Click on more in same loan account page ,click on create guarantor , select 
> self guarantor with 5000 and external guarantor as 5000
> 6.Now approve the loan
> >Should not allow to approve the loan since saving account transaction date 
> >is grater than loan submitted date.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FINERACT-326) Edit datatable page not able to save if the single character is entered in New Name field

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15907342#comment-15907342
 ] 

ASF GitHub Bot commented on FINERACT-326:
-

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-fineract/pull/311


> Edit datatable page not able to save if the single character is entered in 
> New Name field 
> --
>
> Key: FINERACT-326
> URL: https://issues.apache.org/jira/browse/FINERACT-326
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Data Tables
>Reporter: Santosh Math
>Assignee: Markus Geiss
>Priority: Minor
>  Labels: p1
> Attachments: Edit datatables.png
>
>
> Reported by  Subramanya  at https://mifosforge.jira.com/browse/MIFOSX-2624
> Original Description:
> 1. Create a datatable for a client with string and length as 25.
> 2. Click on edit and enter value as S in New name field.
> 3. Click on submit button
> > Not able to submit the page displayed error message as "The parameter `new 
> > Name` has been passed and is not supported for this request."



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FINERACT-331) In edit client if the Legal Form is modified from entity to person not getting updated as person after submission

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15907336#comment-15907336
 ] 

ASF GitHub Bot commented on FINERACT-331:
-

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-fineract/pull/309


> In edit client if the Legal Form is modified from entity to person not 
> getting updated as person after submission
> -
>
> Key: FINERACT-331
> URL: https://issues.apache.org/jira/browse/FINERACT-331
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Client
>Reporter: Santosh Math
>Assignee: Markus Geiss
>  Labels: p1
>
> Reported  by Subramanya at https://mifosforge.jira.com/browse/MIFOSX-2742
> Original Description:
> 1. Create a client under pending state with Legal Form as Entity.
> 2. Click on edit client and change the Legal Form as Person and enter valid 
> inputs and click on submit button.
> > The client is not getting saved with Legal Form Person, but it is remaining 
> > as Legal Form Entity only.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FINERACT-378) Not able to link savings account in Bulk JLG Loan application page

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15907330#comment-15907330
 ] 

ASF GitHub Bot commented on FINERACT-378:
-

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-fineract/pull/308


> Not able to link savings account in Bulk JLG Loan application page
> --
>
> Key: FINERACT-378
> URL: https://issues.apache.org/jira/browse/FINERACT-378
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Loan
>Reporter: Santosh Math
>Assignee: Markus Geiss
>  Labels: p1
> Attachments: 11.png
>
>
> Reported by Subramanya at https://mifosforge.jira.com/browse/MIFOSX-1570
> And also: https://github.com/openMF/community-app/issues/1681
> Original Description:
> Create a Center with meeting date, create Group under that Center and attach 
> 3 Clients under that Group, Create a Loan product
> Click on the Center -> Groups -> Select a particular Group ->Click on Bulk 
> JLG Loan Application button -> Select the Loan product - In which Link 
> savings account drop-down is not displaying.
> If any loan charges due is need to be collected from Linked savings account 
> then it is not possible in this case. Check  the screenshot.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FINERACT-117) Tranche disbursement charge % disbursed amount is displaying as -ve amount if the 2nd tranche disbursed is with lesser amount and charge was waived before 2nd disburs

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15907327#comment-15907327
 ] 

ASF GitHub Bot commented on FINERACT-117:
-

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-fineract/pull/306


> Tranche disbursement charge % disbursed amount is displaying as -ve amount if 
> the 2nd tranche disbursed is with lesser amount and charge was waived before 
> 2nd disbursement
> ---
>
> Key: FINERACT-117
> URL: https://issues.apache.org/jira/browse/FINERACT-117
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Charges
>Reporter: subramanyasn
>Assignee: Markus Geiss
>  Labels: p1
> Attachments: Mifos X Client 2016-03-24 15-30-57.png
>
>
> 1. Create a tranche disbursement charge with % disbursement amount.
> 2. Create a tranche loan with 2 tranche count, attache the above charge to it.
> 3. Submit new loan application for a client on 01 January 2016 with first 
> tranche of 5000 on same date and second tranche of 5000 on 01 March 2016.
> 4. Approve and disburse the first tranche on 01 January 2016.
> 5. Click on Charges and waive charge on 01 March 2016.
> 6. Disburse the 2nd tranche on 01 March 2016 and while disbursement change 
> the amount to 2000.
> 7. Click on Repayment schedule in which the tranche disbursement charge is 
> displaying as -30 (Suppose to disburse 5000 so 1%of 5000=50. Waived 50 and 
> Disbursed 2000. 1% of 2000=20.)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FINERACT-344) Should not allow to add guarantor ,If savings account activation date is gretar than loan application submitted date

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15907049#comment-15907049
 ] 

ASF GitHub Bot commented on FINERACT-344:
-

GitHub user nazeer1100126 opened a pull request:

https://github.com/apache/incubator-fineract/pull/310

FINERACT-344 : Should not allow to add guarantor ,If savings account 
activation date is gretar than loan application submitted date



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nazeer1100126/incubator-fineract FINERACT-344

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-fineract/pull/310.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #310


commit fb1a8909404afa11229da0c63ccc7c7e55a567a0
Author: nazeer1100126 
Date:   2017-03-13T08:03:13Z

FINERACT-344 : Should not allow to add guarantor ,If savings account 
activation date is gretar than loan application submitted date




> Should not allow to add guarantor ,If savings account activation date is 
> gretar than loan application submitted date
> 
>
> Key: FINERACT-344
> URL: https://issues.apache.org/jira/browse/FINERACT-344
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Loan
>Reporter: Santosh Math
>Assignee: Markus Geiss
>  Labels: p1
> Attachments: create external guarantor.png, Creater self 
> guarantor.png, New loan application.png
>
>
> Original Description:
> 1. Create a Loan Product with the following credentials
> -->principal amount as 1,Number of repayments 12,Nominal Interest rate 1% 
> p.a,Rapid every 1 month,Amortization as Equal installments ,Interest Method 
> as Declining Balance,Interest Calculation Period as Same as repayment 
> period,Repayment Strategy as Mifos style ,In Guarantee Requirements check 
> Place Guarantee Funds On-Hold? give Mandatory Guarantee: (%) as 100, Minimum 
> Guarantee from Own Funds: (%) as 50, Minimum from Guarantor Funds: (%) 50.
> 2.Create 2 Clients and activate on 1 jan 2014, active 1 saving account for 
> each client with balance 5 on 1 may 2015
> 3. Submit new loan application for the same client on 1 jan 2015 
> 4. Click on more in same loan account page ,click on create guarantor , 
> select self guarantor with 5000 and external guarantor as 5000
> 5.Now approve the loan
> >Should not allow to approve the loan since saving account activation date is 
> >grater than loan submitted date.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FINERACT-331) In edit client if the Legal Form is modified from entity to person not getting updated as person after submission

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15904956#comment-15904956
 ] 

ASF GitHub Bot commented on FINERACT-331:
-

GitHub user nazeer1100126 opened a pull request:

https://github.com/apache/incubator-fineract/pull/309

FINERACT-331 : In edit client if the Legal Form is modified from entity to 
person not getting updated as person after submission



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nazeer1100126/incubator-fineract FINERACT-331

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-fineract/pull/309.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #309


commit fffc8374ebcfcd5819f08de749f23a2a012c637f
Author: nazeer1100126 
Date:   2017-03-10T11:44:02Z

FINERACT-331 : In edit client if the Legal Form is modified from entity to 
person not getting updated as person after submission




> In edit client if the Legal Form is modified from entity to person not 
> getting updated as person after submission
> -
>
> Key: FINERACT-331
> URL: https://issues.apache.org/jira/browse/FINERACT-331
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Client
>Reporter: Santosh Math
>Assignee: Markus Geiss
>  Labels: p1
>
> Reported  by Subramanya at https://mifosforge.jira.com/browse/MIFOSX-2742
> Original Description:
> 1. Create a client under pending state with Legal Form as Entity.
> 2. Click on edit client and change the Legal Form as Person and enter valid 
> inputs and click on submit button.
> > The client is not getting saved with Legal Form Person, but it is remaining 
> > as Legal Form Entity only.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FINERACT-89) 1st tranche will appear twice in repayment schedule when disbursement date and first repayment date is on same date

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15899503#comment-15899503
 ] 

ASF GitHub Bot commented on FINERACT-89:


GitHub user nazeer1100126 opened a pull request:

https://github.com/apache/incubator-fineract/pull/304

FINERACT-89 : 1st tranche will appear twice in repayment schedule when 
disbursement date and first repayment date is on same date



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nazeer1100126/incubator-fineract 
FINERACT_BUG_89

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-fineract/pull/304.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #304


commit 069c8ada5688eda871246969fe1bf7d1f3c39f5a
Author: nazeer1100126 
Date:   2017-03-07T14:15:29Z

FINERACT-89 : 1st tranche will appear twice in repayment schedule when 
disbursement date and first repayment date is on same date




> 1st tranche will appear twice in repayment schedule when disbursement date 
> and first repayment date is on same date
> ---
>
> Key: FINERACT-89
> URL: https://issues.apache.org/jira/browse/FINERACT-89
> Project: Apache Fineract
>  Issue Type: Bug
>Reporter: bharath c
>Assignee: Markus Geiss
>  Labels: p1
> Attachments: issue.png
>
>
> 1st tranche will appear twice in repayment schedule when disbursement date 
> and first repayment date is on same date
> steps to produce:-
> example
> create a tranche loan
> 1.expected disbursement date =04 January 2016
> 2. first repayment date = 04 January 2016
> see loan no-  308 in demo serveer 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FINERACT-228) As a manager, i want to get reports on "Deposits to Staff Account "

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15898974#comment-15898974
 ] 

ASF GitHub Bot commented on FINERACT-228:
-

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-fineract/pull/301


> As a manager, i want to get reports on "Deposits to Staff Account "
> ---
>
> Key: FINERACT-228
> URL: https://issues.apache.org/jira/browse/FINERACT-228
> Project: Apache Fineract
>  Issue Type: Improvement
>Reporter: Ippez Roberts
>Assignee: Markus Geiss
>
> During Client creation, Include "Is Staff" as a Boolean so that i can filter 
> loan and savings accounts that belong to a staff and any deposit activities 
> associated with it. This is to avoid malicious staff from posting 
> transactions into their accounts.
> Design a report to fetch "Deposit to Staff Account". This includes both Loan 
> Repayment, Disbursements and Savings Deposit to a staff client for a range or 
> period (FROM DATE TO DATE ...)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FINERACT-412) Add Share account in Global Search

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15898935#comment-15898935
 ] 

ASF GitHub Bot commented on FINERACT-412:
-

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-fineract/pull/300


> Add Share account in Global Search
> --
>
> Key: FINERACT-412
> URL: https://issues.apache.org/jira/browse/FINERACT-412
> Project: Apache Fineract
>  Issue Type: Improvement
>  Components: Shares
>Reporter: Ippez Roberts
>Assignee: Markus Geiss
>  Labels: Volunteer, p3
>
> Currently its not possible to search for Share Account in community-app using 
> the global search



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FINERACT-232) Ability to Post General Ledger Entries Directly to Customer Account

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15898891#comment-15898891
 ] 

ASF GitHub Bot commented on FINERACT-232:
-

Github user Ippezrobert commented on a diff in the pull request:

https://github.com/apache/incubator-fineract/pull/302#discussion_r104605492
  
--- Diff: 
fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/service/SavingsApplicationProcessWritePlatformServiceJpaRepositoryImpl.java
 ---
@@ -446,6 +446,72 @@ public CommandProcessingResult rejectApplication(final 
Long savingsId, final Jso
 .build();
 }
 
+   @Transactional
+@Override
+public CommandProcessingResult undoApplicationRejection(final Long 
savingsId, final JsonCommand command) {
+this.context.authenticatedUser();
+
+
this.savingsAccountApplicationTransitionApiJsonValidator.validateForUndo(command.json());
+
+final SavingsAccount savingsAccount = 
this.savingAccountAssembler.assembleFrom(savingsId);
+checkClientOrGroupActive(savingsAccount);
+
+final Map changes = 
savingsAccount.undoApplicationRejection();
+if (!changes.isEmpty()) {
+this.savingAccountRepository.save(savingsAccount);
+
+final String noteText = 
command.stringValueOfParameterNamed("note");
+if (StringUtils.isNotBlank(noteText)) {
+final Note note = Note.savingNote(savingsAccount, 
noteText);
+changes.put("note", noteText);
+this.noteRepository.save(note);
+}
+}
+
+return new CommandProcessingResultBuilder() //
+.withCommandId(command.commandId()) //
+.withEntityId(savingsId) //
+.withOfficeId(savingsAccount.officeId()) //
+.withClientId(savingsAccount.clientId()) //
+.withGroupId(savingsAccount.groupId()) //
+.withSavingsId(savingsId) //
+.with(changes) //
+.build();
+}
+
+@Transactional
+@Override
+public CommandProcessingResult reopen(final Long savingsId, final 
JsonCommand command) {
--- End diff --

@nazeer1100126 , These changes will only be possible if the issues 
https://issues.apache.org/jira/browse/FINERACT-232 and  
https://issues.apache.org/jira/browse/FINERACT-408 are implemented and those 
are more technical for me.


> Ability to Post General Ledger Entries Directly to Customer Account
> ---
>
> Key: FINERACT-232
> URL: https://issues.apache.org/jira/browse/FINERACT-232
> Project: Apache Fineract
>  Issue Type: Improvement
>Reporter: Dayna Harp
>Assignee: Markus Geiss
> Attachments: Complete New UI Mock up for Journal Entry Screen.png, 
> Enhancements for Journal Entry.pdf
>
>
> https://mifosforge.jira.com/browse/MIFOSX-2182
> From MIFOS X: As an accountant, i would like to be able to make a transfer 
> from a client's account (Savings Account or Loan Account) to a GL Account and 
> also be able to make transfer from a GL Account (e.g Cash at Hand) to 
> Client's Account (e.g Savings Account or Loan Account)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FINERACT-406) Loan top up having same disbursement date of last transaction date of loan account is not allowing

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15898879#comment-15898879
 ] 

ASF GitHub Bot commented on FINERACT-406:
-

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-fineract/pull/298


> Loan top up having same disbursement date of last transaction date of loan 
> account is not allowing
> --
>
> Key: FINERACT-406
> URL: https://issues.apache.org/jira/browse/FINERACT-406
> Project: Apache Fineract
>  Issue Type: Improvement
>  Components: Loan
>Reporter: Santosh Math
>Assignee: Shaik Nazeer Hussain
>
> Steps to reproduce:
> 1. create two loan products one of which top up enabled.
> 2. Disburse loan(non-top-up) on 01 January 2016.
> 3. Make first repayment on schedule date(say, 01 February 2016)
> 4. Create another loan account(top-up enabled) and  check 'Is Topup Loan' and 
> select the previous account and set 'Disbursement on' date as 01 February 
> 2016(Last transaction date of previous loan account).
> >Not allowing to submit and throwing the error:
> "error.msg.loan.disbursal.date.should.be.after.last.transaction.date.of.loan.to.be.closed"
> Loan topup should not be allowed for disbursement dates prior to the last 
> transaction date of the  previous loan account but it should allow on same 
> date. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FINERACT-228) As a manager, i want to get reports on "Deposits to Staff Account "

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15897006#comment-15897006
 ] 

ASF GitHub Bot commented on FINERACT-228:
-

Github user nazeer1100126 commented on the issue:

https://github.com/apache/incubator-fineract/pull/301
  
Changes Looks OK


> As a manager, i want to get reports on "Deposits to Staff Account "
> ---
>
> Key: FINERACT-228
> URL: https://issues.apache.org/jira/browse/FINERACT-228
> Project: Apache Fineract
>  Issue Type: Improvement
>Reporter: Ippez Roberts
>Assignee: Markus Geiss
>
> During Client creation, Include "Is Staff" as a Boolean so that i can filter 
> loan and savings accounts that belong to a staff and any deposit activities 
> associated with it. This is to avoid malicious staff from posting 
> transactions into their accounts.
> Design a report to fetch "Deposit to Staff Account". This includes both Loan 
> Repayment, Disbursements and Savings Deposit to a staff client for a range or 
> period (FROM DATE TO DATE ...)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FINERACT-412) Add Share account in Global Search

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15896848#comment-15896848
 ] 

ASF GitHub Bot commented on FINERACT-412:
-

Github user nazeer1100126 commented on the issue:

https://github.com/apache/incubator-fineract/pull/300
  
Changes Looks OK. 


> Add Share account in Global Search
> --
>
> Key: FINERACT-412
> URL: https://issues.apache.org/jira/browse/FINERACT-412
> Project: Apache Fineract
>  Issue Type: Improvement
>  Components: Shares
>Reporter: Ippez Roberts
>Assignee: Markus Geiss
>  Labels: Volunteer, p3
>
> Currently its not possible to search for Share Account in community-app using 
> the global search



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FINERACT-412) Add Share account in Global Search

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15894070#comment-15894070
 ] 

ASF GitHub Bot commented on FINERACT-412:
-

GitHub user Ippezrobert opened a pull request:

https://github.com/apache/incubator-fineract/pull/300

FINERACT-412 - Add Share account in Global Search



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Ippezrobert/incubator-fineract 
search_share_global

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-fineract/pull/300.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #300






> Add Share account in Global Search
> --
>
> Key: FINERACT-412
> URL: https://issues.apache.org/jira/browse/FINERACT-412
> Project: Apache Fineract
>  Issue Type: Improvement
>  Components: Shares
>Reporter: Ippez Roberts
>Assignee: Markus Geiss
>  Labels: Volunteer, p3
>
> Currently its not possible to search for Share Account in community-app using 
> the global search



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FINERACT-412) Add Share account in Global Search

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15894051#comment-15894051
 ] 

ASF GitHub Bot commented on FINERACT-412:
-

Github user Ippezrobert closed the pull request at:

https://github.com/apache/incubator-fineract/pull/299


> Add Share account in Global Search
> --
>
> Key: FINERACT-412
> URL: https://issues.apache.org/jira/browse/FINERACT-412
> Project: Apache Fineract
>  Issue Type: Improvement
>  Components: Shares
>Reporter: Ippez Roberts
>Assignee: Markus Geiss
>  Labels: Volunteer, p3
>
> Currently its not possible to search for Share Account in community-app using 
> the global search



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FINERACT-412) Add Share account in Global Search

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15892300#comment-15892300
 ] 

ASF GitHub Bot commented on FINERACT-412:
-

Github user Ippezrobert commented on a diff in the pull request:

https://github.com/apache/incubator-fineract/pull/299#discussion_r103930777
  
--- Diff: 
fineract-provider/src/main/java/org/apache/fineract/portfolio/search/data/SearchConditions.java
 ---
@@ -43,18 +44,21 @@ public SearchConditions(final String searchQueryParam, 
final String searchResour
 SEARCH_SUPPORTED_RESOURCES.LOANS.name().toLowerCase())) ? 
true : false;
 this.savingSeach = (null == searchResource || 
searchResource.toLowerCase().contains(
 SEARCH_SUPPORTED_RESOURCES.SAVINGS.name().toLowerCase())) 
? true : false;
+   this.shareSeach = (null == searchResource || 
searchResource.toLowerCase().contains(
+SEARCH_SUPPORTED_RESOURCES.SAVINGS.name().toLowerCase())) 
? true : false;
--- End diff --

I will fix that and send new PR


> Add Share account in Global Search
> --
>
> Key: FINERACT-412
> URL: https://issues.apache.org/jira/browse/FINERACT-412
> Project: Apache Fineract
>  Issue Type: Improvement
>  Components: Shares
>Reporter: Ippez Roberts
>Assignee: Markus Geiss
>  Labels: Volunteer, p3
>
> Currently its not possible to search for Share Account in community-app using 
> the global search



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FINERACT-406) Loan top up having same disbursement date of last transaction date of loan account is not allowing

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15892268#comment-15892268
 ] 

ASF GitHub Bot commented on FINERACT-406:
-

Github user nazeer1100126 commented on the issue:

https://github.com/apache/incubator-fineract/pull/298
  
Change looks good. 


> Loan top up having same disbursement date of last transaction date of loan 
> account is not allowing
> --
>
> Key: FINERACT-406
> URL: https://issues.apache.org/jira/browse/FINERACT-406
> Project: Apache Fineract
>  Issue Type: Improvement
>  Components: Loan
>Reporter: Santosh Math
>Assignee: Shaik Nazeer Hussain
>
> Steps to reproduce:
> 1. create two loan products one of which top up enabled.
> 2. Disburse loan(non-top-up) on 01 January 2016.
> 3. Make first repayment on schedule date(say, 01 February 2016)
> 4. Create another loan account(top-up enabled) and  check 'Is Topup Loan' and 
> select the previous account and set 'Disbursement on' date as 01 February 
> 2016(Last transaction date of previous loan account).
> >Not allowing to submit and throwing the error:
> "error.msg.loan.disbursal.date.should.be.after.last.transaction.date.of.loan.to.be.closed"
> Loan topup should not be allowed for disbursement dates prior to the last 
> transaction date of the  previous loan account but it should allow on same 
> date. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FINERACT-365) The 'Transactions' tab showing wrong balance in RD account

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15882412#comment-15882412
 ] 

ASF GitHub Bot commented on FINERACT-365:
-

GitHub user nazeer1100126 opened a pull request:

https://github.com/apache/incubator-fineract/pull/297

FINERACT-365 : The 'Transactions' tab showing wrong balance in RD account



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nazeer1100126/incubator-fineract FINERACT-365

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-fineract/pull/297.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #297


commit 652059c24693f9c10ddcc025de49e45f4cf18fbc
Author: satish-conflux 
Date:   2017-02-24T10:21:56Z

FINERACT-365 : The 'Transactions' tab showing wrong balance in RD account




> The 'Transactions' tab showing wrong balance in RD account
> --
>
> Key: FINERACT-365
> URL: https://issues.apache.org/jira/browse/FINERACT-365
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Savings
>Reporter: Santosh Math
>Assignee: Markus Geiss
>  Labels: p1
> Fix For: 0.7.0-incubating
>
> Attachments: transaction.png
>
>
> "> Go to Client's page, Click on 'More' and click on 'New Recurring Deposit' 
> >select the RD product from drop-down  menu  and then  enter the  following 
> >data sets:
> Recurring Deposit Amount: 5000
> Deposit Frequency: 1  month
> Deposit  Start Date: 01 January 2015
> Deposit Period: 6 months
> >Submit , Approve and Activate it  on 01 Jan 2015.
> >Make  deposits on  01 April 2015
> As first deposit is made on 01 April 2015, the  balance in transaction should 
> show 5000. But the balance in transaction is showing 15000(Check the attached 
> file)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FINERACT-399) Barebones and Sampledata sql files are broken

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15882251#comment-15882251
 ] 

ASF GitHub Bot commented on FINERACT-399:
-

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-fineract/pull/296


> Barebones and Sampledata sql files are broken
> -
>
> Key: FINERACT-399
> URL: https://issues.apache.org/jira/browse/FINERACT-399
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Migration Scripts
>Reporter: Shaik Nazeer Hussain
>Assignee: Shaik Nazeer Hussain
>Priority: Blocker
>  Labels: p1
> Fix For: 0.7.0-incubating
>
>
> Barebones and Sampledata sql files are broken



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FINERACT-399) Barebones and Sampledata sql files are broken

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15882250#comment-15882250
 ] 

ASF GitHub Bot commented on FINERACT-399:
-

GitHub user nazeer1100126 opened a pull request:

https://github.com/apache/incubator-fineract/pull/296

FINERACT-399-Barebones and Sampledata sql files are broken



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nazeer1100126/incubator-fineract FINERACT-399

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-fineract/pull/296.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #296


commit c1af6d66853e363a30ccd44864ed4a01248faa33
Author: Nazeer Hussain Shaik 
Date:   2017-02-24T08:54:57Z

FINERACT-399-Barebones and Sampledata sql files are broken




> Barebones and Sampledata sql files are broken
> -
>
> Key: FINERACT-399
> URL: https://issues.apache.org/jira/browse/FINERACT-399
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Migration Scripts
>Reporter: Shaik Nazeer Hussain
>Assignee: Shaik Nazeer Hussain
>Priority: Blocker
>  Labels: p1
> Fix For: 0.7.0-incubating
>
>
> Barebones and Sampledata sql files are broken



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FINERACT-374) Add Gradle wrapper download location in readme file

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879930#comment-15879930
 ] 

ASF GitHub Bot commented on FINERACT-374:
-

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-fineract/pull/294


> Add Gradle wrapper download location in readme file 
> 
>
> Key: FINERACT-374
> URL: https://issues.apache.org/jira/browse/FINERACT-374
> Project: Apache Fineract
>  Issue Type: Task
>Reporter: Shaik Nazeer Hussain
>Assignee: Shaik Nazeer Hussain
>Priority: Blocker
> Fix For: 0.7.0-incubating
>
>
> Relevant e-mails:
> http://mail-archives.apache.org/mod_mbox/incubator-general/201701.mbox/%3CC8F9C232-D844-4920-BC9F-7DA536FAB6F5%40classsoftware.com%3E



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FINERACT-374) Add Gradle wrapper download location in readme file

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879926#comment-15879926
 ] 

ASF GitHub Bot commented on FINERACT-374:
-

GitHub user nazeer1100126 opened a pull request:

https://github.com/apache/incubator-fineract/pull/294

FINERACT-374-Add Gradle wrapper download location in readme file



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nazeer1100126/incubator-fineract FINERACT-374

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-fineract/pull/294.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #294






> Add Gradle wrapper download location in readme file 
> 
>
> Key: FINERACT-374
> URL: https://issues.apache.org/jira/browse/FINERACT-374
> Project: Apache Fineract
>  Issue Type: Task
>Reporter: Shaik Nazeer Hussain
>Assignee: Shaik Nazeer Hussain
>Priority: Blocker
> Fix For: 0.7.0-incubating
>
>
> Relevant e-mails:
> http://mail-archives.apache.org/mod_mbox/incubator-general/201701.mbox/%3CC8F9C232-D844-4920-BC9F-7DA536FAB6F5%40classsoftware.com%3E



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FINERACT-374) Add Gradle wrapper download location in readme file

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879903#comment-15879903
 ] 

ASF GitHub Bot commented on FINERACT-374:
-

Github user nazeer1100126 commented on the issue:

https://github.com/apache/incubator-fineract/pull/292
  
Closing this PR as there is conflict in the changed file. 


> Add Gradle wrapper download location in readme file 
> 
>
> Key: FINERACT-374
> URL: https://issues.apache.org/jira/browse/FINERACT-374
> Project: Apache Fineract
>  Issue Type: Task
>Reporter: Shaik Nazeer Hussain
>Assignee: Shaik Nazeer Hussain
>Priority: Blocker
> Fix For: 0.7.0-incubating
>
>
> Relevant e-mails:
> http://mail-archives.apache.org/mod_mbox/incubator-general/201701.mbox/%3CC8F9C232-D844-4920-BC9F-7DA536FAB6F5%40classsoftware.com%3E



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FINERACT-374) Add Gradle wrapper download location in readme file

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879904#comment-15879904
 ] 

ASF GitHub Bot commented on FINERACT-374:
-

Github user nazeer1100126 closed the pull request at:

https://github.com/apache/incubator-fineract/pull/292


> Add Gradle wrapper download location in readme file 
> 
>
> Key: FINERACT-374
> URL: https://issues.apache.org/jira/browse/FINERACT-374
> Project: Apache Fineract
>  Issue Type: Task
>Reporter: Shaik Nazeer Hussain
>Assignee: Shaik Nazeer Hussain
>Priority: Blocker
> Fix For: 0.7.0-incubating
>
>
> Relevant e-mails:
> http://mail-archives.apache.org/mod_mbox/incubator-general/201701.mbox/%3CC8F9C232-D844-4920-BC9F-7DA536FAB6F5%40classsoftware.com%3E



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FINERACT-371) Make gradle callable from the top level directory.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15878133#comment-15878133
 ] 

ASF GitHub Bot commented on FINERACT-371:
-

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-fineract/pull/291


> Make gradle callable from the top level directory.
> --
>
> Key: FINERACT-371
> URL: https://issues.apache.org/jira/browse/FINERACT-371
> Project: Apache Fineract
>  Issue Type: Wish
>Reporter: Myrle Krantz
>Assignee: Shaik Nazeer Hussain
>Priority: Minor
> Fix For: 0.7.0-incubating
>
>
> Relevant e-mails:
> http://mail-archives.apache.org/mod_mbox/incubator-general/201612.mbox/%3CCA%2BULb%2BvcXGe5C%2ByiXdGS2gTD3vnpcs1e%3DoW5D6hffLSt%2BmOn0A%40mail.gmail.com%3E



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FINERACT-371) Make gradle callable from the top level directory.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877384#comment-15877384
 ] 

ASF GitHub Bot commented on FINERACT-371:
-

Github user nazeer1100126 commented on the issue:

https://github.com/apache/incubator-fineract/pull/291
  
@myrle-krantz Thank you :-). I will merge these changes today. 


> Make gradle callable from the top level directory.
> --
>
> Key: FINERACT-371
> URL: https://issues.apache.org/jira/browse/FINERACT-371
> Project: Apache Fineract
>  Issue Type: Wish
>Reporter: Myrle Krantz
>Assignee: Shaik Nazeer Hussain
>Priority: Minor
> Fix For: 0.7.0-incubating
>
>
> Relevant e-mails:
> http://mail-archives.apache.org/mod_mbox/incubator-general/201612.mbox/%3CCA%2BULb%2BvcXGe5C%2ByiXdGS2gTD3vnpcs1e%3DoW5D6hffLSt%2BmOn0A%40mail.gmail.com%3E



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FINERACT-371) Make gradle callable from the top level directory.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15876623#comment-15876623
 ] 

ASF GitHub Bot commented on FINERACT-371:
-

Github user myrle-krantz commented on the issue:

https://github.com/apache/incubator-fineract/pull/291
  
I pulled and ran the build.  It works for me.  The change is also simple.


> Make gradle callable from the top level directory.
> --
>
> Key: FINERACT-371
> URL: https://issues.apache.org/jira/browse/FINERACT-371
> Project: Apache Fineract
>  Issue Type: Wish
>Reporter: Myrle Krantz
>Assignee: Shaik Nazeer Hussain
>Priority: Minor
> Fix For: 0.7.0-incubating
>
>
> Relevant e-mails:
> http://mail-archives.apache.org/mod_mbox/incubator-general/201612.mbox/%3CCA%2BULb%2BvcXGe5C%2ByiXdGS2gTD3vnpcs1e%3DoW5D6hffLSt%2BmOn0A%40mail.gmail.com%3E



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FINERACT-366) Issue With Creating RD account with 'Charge Time Type' Savings Activation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15875641#comment-15875641
 ] 

ASF GitHub Bot commented on FINERACT-366:
-

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-fineract/pull/293


> Issue With Creating RD account with 'Charge Time Type' Savings Activation 
> --
>
> Key: FINERACT-366
> URL: https://issues.apache.org/jira/browse/FINERACT-366
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Savings
>Reporter: Santosh Math
>Assignee: Satish S
>  Labels: p1
> Fix For: 0.7.0-incubating
>
> Attachments: activate.png, savact.png
>
>
> Steps to reproduce:
> > Create a Charge with following data set:
>Charge Applies To: Savings & Deposits
>Charge Time Type: Savings Activation
>Charge Calculation:  Flat
>Amount: 50
> > Go to Client's page, Click on 'More' and click on 'New Recurring Deposit' 
> >select the RD product from drop-down  menu and then  enter the  following 
> >data sets:
> Recurring Deposit Amount: 5000
> Deposit Frequency: 1 month
> Deposit period: 6 month
> >Add the above created charge
> >Submit  it  on 01 Jan 2015.
> >Approve it and Activate it  on 01 Feb 2015.
> >In  RD account page, go to Charges Tab and select the charge and click on 
> >'Pay Charge'
> >Provide the date 01 January 2015 and 'Submit' it. 
> Then it throws the error, 
> "field is required
> validation.msg.savingsaccount.transaction.not.valid.cannot.pay.activation.time.charge.is.automated"
> Check  the screenshot 'activate.png'.
> Expected: When creating RD account with charge type 'Savings Activation', the 
>  charge  must be paid just after activation of RD account similar to  Savings 
> Activation.  check the screenshot savact.png 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FINERACT-366) Issue With Creating RD account with 'Charge Time Type' Savings Activation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15874227#comment-15874227
 ] 

ASF GitHub Bot commented on FINERACT-366:
-

GitHub user satish-conflux opened a pull request:

https://github.com/apache/incubator-fineract/pull/293

FINERACT-366 : Issue With Creating RD account with 'Charge Time Type'  
Savings Activation



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/satish-conflux/incubator-fineract FINERACT-366

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-fineract/pull/293.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #293


commit 8e9674b4aaf9d4a493ba54dbda1d08dc8468aea4
Author: satish-conflux 
Date:   2017-02-20T07:55:55Z

FINERACT-366 : Issue With Creating RD account with 'Charge Time Type' 
Savings Activation




> Issue With Creating RD account with 'Charge Time Type' Savings Activation 
> --
>
> Key: FINERACT-366
> URL: https://issues.apache.org/jira/browse/FINERACT-366
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Savings
>Reporter: Santosh Math
>Assignee: Satish S
>  Labels: p1
> Attachments: activate.png, savact.png
>
>
> Steps to reproduce:
> > Create a Charge with following data set:
>Charge Applies To: Savings & Deposits
>Charge Time Type: Savings Activation
>Charge Calculation:  Flat
>Amount: 50
> > Go to Client's page, Click on 'More' and click on 'New Recurring Deposit' 
> >select the RD product from drop-down  menu and then  enter the  following 
> >data sets:
> Recurring Deposit Amount: 5000
> Deposit Frequency: 1 month
> Deposit period: 6 month
> >Add the above created charge
> >Submit  it  on 01 Jan 2015.
> >Approve it and Activate it  on 01 Feb 2015.
> >In  RD account page, go to Charges Tab and select the charge and click on 
> >'Pay Charge'
> >Provide the date 01 January 2015 and 'Submit' it. 
> Then it throws the error, 
> "field is required
> validation.msg.savingsaccount.transaction.not.valid.cannot.pay.activation.time.charge.is.automated"
> Check  the screenshot 'activate.png'.
> Expected: When creating RD account with charge type 'Savings Activation', the 
>  charge  must be paid just after activation of RD account similar to  Savings 
> Activation.  check the screenshot savact.png 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FINERACT-377) Reinvesting Recurring Deposit is taking present date in stead of maturity date

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15871784#comment-15871784
 ] 

ASF GitHub Bot commented on FINERACT-377:
-

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-fineract/pull/289


> Reinvesting Recurring Deposit is taking present date in stead of maturity date
> --
>
> Key: FINERACT-377
> URL: https://issues.apache.org/jira/browse/FINERACT-377
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Savings
>Reporter: Santosh Math
>Assignee: Santosh Math
>  Labels: p1
> Fix For: 0.7.0-incubating
>
> Attachments: reinv.png
>
>
> 1. Create a Recurring deposit account for a client on 01 January 2016, term 
> is 3 months repaid every  month -> Approve and disburse on same date.
> 2. Make Deposits on 01 Jan, 01 Feb, and 01 March
> 3. Also run the scheduler job "Update Deposit Accounts Maturity details" -> 
> Navigate back to the Recurring deposit account page -> Click on Close button.
> 4. In Close account page, select the date as 01 April 2015(maturity date) and 
> in action drop-down select Reinvest as option -> Click on 'Submit' button.
> After clicking 'Submit' button, the previous RD account gets closed and new 
> RD account gets created with deposit amount = closing amount of previous RD 
> account. The reinvesting date should be 01 April 2015, but the application is 
> taking present date as 'Reinvesting Date'. Check the screenshot. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FINERACT-312) For Loan with interest recalculation periodic accrual with respect to current date is not getting modified after repayment in Transaction page

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15871733#comment-15871733
 ] 

ASF GitHub Bot commented on FINERACT-312:
-

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-fineract/pull/286


> For Loan with interest recalculation periodic accrual with respect to current 
> date is not getting modified after repayment in Transaction page
> --
>
> Key: FINERACT-312
> URL: https://issues.apache.org/jira/browse/FINERACT-312
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Loan
>Reporter: Santosh Math
>Assignee: Shaik Nazeer Hussain
>  Labels: p1
> Fix For: 0.7.0-incubating
>
> Attachments: 35.png, 36.png, 37.png
>
>
> Reported by Subramanya at https://mifosforge.jira.com/browse/MIFOSX-2119
> Original Description:
> 1. Create a loan product with following datasets:
> Principal: 1, no. of Installments: 12, repaid every 1 month, Nominal 
> interest rate: 1%pm,Amortization: Equal installments, Interest Method: 
> Declining Balance, Interest Calculation Period: Same as repayment 
> period,Repayment Strategy:RBI (India),Recalculate Interest: Yes,Advance 
> payments adjustment type: Reduce number of installments, Pre-closure interest 
> calculation rule: Calculate till pre closure date, Interest recalculation 
> compounding on:None, Frequency for recalculate Outstanding Principal: Same as 
> repayment period, with accounting enabled for periodic accrual.
> 2. Submit new loan application for a client on 01 March 2015 approve and 
> disburse on same date.
> 3. Click on Admin -> system -> Scheduler job - run scheduler job "Add 
> Periodic Accrual Transactions".
> 4. Navigate back to Transactions page and verify the accrued interest as on 
> current date.
> 5. Make first repayment on exact due date then verify the transaction page 
> the accrued interest as on current date is not modified.
> > The accrued interest as on current date is not getting modified even after 
> > multiple repayments. 
> Please refer the screen shot attached.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FINERACT-234) Can't process bulk JLG loan application [MIFOSX-2137]

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15871676#comment-15871676
 ] 

ASF GitHub Bot commented on FINERACT-234:
-

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-fineract/pull/285


> Can't process bulk JLG loan application [MIFOSX-2137]
> -
>
> Key: FINERACT-234
> URL: https://issues.apache.org/jira/browse/FINERACT-234
> Project: Apache Fineract
>  Issue Type: Bug
>Reporter: Edward Cable
>Assignee: Shaik Nazeer Hussain
>  Labels: p1
> Fix For: 0.7.0-incubating
>
>
> Moved over from https://mifosforge.jira.com/browse/MIFOSX-2137
> I still am unable to save new bulk JLG loan applications even when the 
> meeting frequency matches so it seems like this is still not working.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FINERACT-311) Issue With 'Payment Due On Non Working Days'

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15871540#comment-15871540
 ] 

ASF GitHub Bot commented on FINERACT-311:
-

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-fineract/pull/284


> Issue  With 'Payment Due On Non Working Days'
> -
>
> Key: FINERACT-311
> URL: https://issues.apache.org/jira/browse/FINERACT-311
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: System
>Affects Versions: 0.7.0-incubating
>Reporter: Santosh Math
>Assignee: Shaik Nazeer Hussain
>  Labels: p1
> Fix For: 0.7.0-incubating
>
> Attachments: paymentDueOnNonWorkingDay.png
>
>
> 1. Go To Admin>>Organization and click on Working Days
> 2.  Un-check Sunday.
> 3. Change  'Payment Due On Non Working Days' from 'same day' to 'Move to Next 
> Working Day' or any other parameters.
> 4. Click on Submit button.
> 5. Go Back to Admin>>Organization>>Working Days
> You can observe that   'Payment Due On Non Working Days' remains as 'same 
> day' though we changed it to other parameters like 'Move to Next Working Day' 
> , etc.
> Note: This issue doesn't appear every time but still exists. You can check it 
> by frequently changing 'Payment Due On Non Working  Days'



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FINERACT-374) Add Gradle wrapper download location in readme file

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15871287#comment-15871287
 ] 

ASF GitHub Bot commented on FINERACT-374:
-

GitHub user nazeer1100126 opened a pull request:

https://github.com/apache/incubator-fineract/pull/292

FINERACT-374-Add Gradle wrapper download location in readme file



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nazeer1100126/incubator-fineract FINERACT-374

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-fineract/pull/292.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #292


commit fff5cef6a4bf6f7e094af6820b4b71d5cb6692d4
Author: Nazeer Hussain Shaik 
Date:   2017-02-17T06:44:23Z

FINERACT-374-Add Gradle wrapper download location in readme file




> Add Gradle wrapper download location in readme file 
> 
>
> Key: FINERACT-374
> URL: https://issues.apache.org/jira/browse/FINERACT-374
> Project: Apache Fineract
>  Issue Type: Task
>Reporter: Shaik Nazeer Hussain
>Assignee: Shaik Nazeer Hussain
>Priority: Blocker
>
> Relevant e-mails:
> http://mail-archives.apache.org/mod_mbox/incubator-general/201701.mbox/%3CC8F9C232-D844-4920-BC9F-7DA536FAB6F5%40classsoftware.com%3E



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FINERACT-371) Make gradle callable from the top level directory.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15869981#comment-15869981
 ] 

ASF GitHub Bot commented on FINERACT-371:
-

GitHub user nazeer1100126 opened a pull request:

https://github.com/apache/incubator-fineract/pull/291

FINERACT-371 - Make gradle callable from the top level directory.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nazeer1100126/incubator-fineract FINERACT-371

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-fineract/pull/291.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #291


commit 1dabd44b45662fc6c5104239bd7cda43f0b0258c
Author: Nazeer Hussain Shaik 
Date:   2017-02-16T14:08:08Z

FINERACT-371 - Make gradle callable from the top level directory.




> Make gradle callable from the top level directory.
> --
>
> Key: FINERACT-371
> URL: https://issues.apache.org/jira/browse/FINERACT-371
> Project: Apache Fineract
>  Issue Type: Wish
>Reporter: Myrle Krantz
>Assignee: Shaik Nazeer Hussain
>Priority: Minor
>
> Relevant e-mails:
> http://mail-archives.apache.org/mod_mbox/incubator-general/201612.mbox/%3CCA%2BULb%2BvcXGe5C%2ByiXdGS2gTD3vnpcs1e%3DoW5D6hffLSt%2BmOn0A%40mail.gmail.com%3E



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FINERACT-371) Make gradle callable from the top level directory.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15869953#comment-15869953
 ] 

ASF GitHub Bot commented on FINERACT-371:
-

Github user nazeer1100126 commented on the issue:

https://github.com/apache/incubator-fineract/pull/290
  
Closing this as RAT is still generating the report file in 
fineract-provider/build/report/rat/


> Make gradle callable from the top level directory.
> --
>
> Key: FINERACT-371
> URL: https://issues.apache.org/jira/browse/FINERACT-371
> Project: Apache Fineract
>  Issue Type: Wish
>Reporter: Myrle Krantz
>Assignee: Shaik Nazeer Hussain
>Priority: Minor
>
> Relevant e-mails:
> http://mail-archives.apache.org/mod_mbox/incubator-general/201612.mbox/%3CCA%2BULb%2BvcXGe5C%2ByiXdGS2gTD3vnpcs1e%3DoW5D6hffLSt%2BmOn0A%40mail.gmail.com%3E



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FINERACT-371) Make gradle callable from the top level directory.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15869778#comment-15869778
 ] 

ASF GitHub Bot commented on FINERACT-371:
-

GitHub user nazeer1100126 opened a pull request:

https://github.com/apache/incubator-fineract/pull/290

FINERACT-371 - Make gradle callable from the top level directory.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nazeer1100126/incubator-fineract FINERACT-371

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-fineract/pull/290.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #290


commit 739af7552b817b989ad3eed25152fda6a73bb1f3
Author: Nazeer Hussain Shaik 
Date:   2017-02-16T11:30:19Z

FINERACT-371 - Make gradle callable from the top level directory.




> Make gradle callable from the top level directory.
> --
>
> Key: FINERACT-371
> URL: https://issues.apache.org/jira/browse/FINERACT-371
> Project: Apache Fineract
>  Issue Type: Wish
>Reporter: Myrle Krantz
>Assignee: Shaik Nazeer Hussain
>Priority: Minor
>
> Relevant e-mails:
> http://mail-archives.apache.org/mod_mbox/incubator-general/201612.mbox/%3CCA%2BULb%2BvcXGe5C%2ByiXdGS2gTD3vnpcs1e%3DoW5D6hffLSt%2BmOn0A%40mail.gmail.com%3E



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FINERACT-377) Reinvesting Recurring Deposit is taking present date in stead of maturity date

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15869698#comment-15869698
 ] 

ASF GitHub Bot commented on FINERACT-377:
-

GitHub user satish-conflux opened a pull request:

https://github.com/apache/incubator-fineract/pull/289

FINERACT-377 : Reinvesting Recurring Deposit is taking present date in 
stead of maturity date.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/satish-conflux/incubator-fineract FINERACT-377

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-fineract/pull/289.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #289


commit abeab28cd7269bb61e68ea6a31f00184511f3da1
Author: satish-conflux 
Date:   2017-02-16T10:31:39Z

FINERACT-377 : Reinvesting Recurring Deposit is taking present date in 
stead of maturity date




> Reinvesting Recurring Deposit is taking present date in stead of maturity date
> --
>
> Key: FINERACT-377
> URL: https://issues.apache.org/jira/browse/FINERACT-377
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Savings
>Reporter: Santosh Math
>Assignee: Markus Geiss
>  Labels: p1
> Attachments: reinv.png
>
>
> 1. Create a Recurring deposit account for a client on 01 January 2016, term 
> is 3 months repaid every  month -> Approve and disburse on same date.
> 2. Make Deposits on 01 Jan, 01 Feb, and 01 March
> 3. Also run the scheduler job "Update Deposit Accounts Maturity details" -> 
> Navigate back to the Recurring deposit account page -> Click on Close button.
> 4. In Close account page, select the date as 01 April 2015(maturity date) and 
> in action drop-down select Reinvest as option -> Click on 'Submit' button.
> After clicking 'Submit' button, the previous RD account gets closed and new 
> RD account gets created with deposit amount = closing amount of previous RD 
> account. The reinvesting date should be 01 April 2015, but the application is 
> taking present date as 'Reinvesting Date'. Check the screenshot. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FINERACT-312) For Loan with interest recalculation periodic accrual with respect to current date is not getting modified after repayment in Transaction page

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1586#comment-1586
 ] 

ASF GitHub Bot commented on FINERACT-312:
-

GitHub user satish-conflux opened a pull request:

https://github.com/apache/incubator-fineract/pull/286

FINERACT-312 : For Loan with interest recalculation periodic accrual with 
respect to current date is not getting modified after repayment in Transaction 
page.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/satish-conflux/incubator-fineract FINERACT-312

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-fineract/pull/286.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #286


commit 7ceb68fec9adfbb58cb916a7077d01b21794172f
Author: satish-conflux 
Date:   2017-02-15T12:52:09Z

FINERACT-312 : For Loan with interest recalculation periodic accrual with 
respect to current date is not getting modified after repayment in Transaction 
page




> For Loan with interest recalculation periodic accrual with respect to current 
> date is not getting modified after repayment in Transaction page
> --
>
> Key: FINERACT-312
> URL: https://issues.apache.org/jira/browse/FINERACT-312
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Loan
>Reporter: Santosh Math
>Assignee: Markus Geiss
>  Labels: p1
> Attachments: 35.png, 36.png, 37.png
>
>
> Reported by Subramanya at https://mifosforge.jira.com/browse/MIFOSX-2119
> Original Description:
> 1. Create a loan product with following datasets:
> Principal: 1, no. of Installments: 12, repaid every 1 month, Nominal 
> interest rate: 1%pm,Amortization: Equal installments, Interest Method: 
> Declining Balance, Interest Calculation Period: Same as repayment 
> period,Repayment Strategy:RBI (India),Recalculate Interest: Yes,Advance 
> payments adjustment type: Reduce number of installments, Pre-closure interest 
> calculation rule: Calculate till pre closure date, Interest recalculation 
> compounding on:None, Frequency for recalculate Outstanding Principal: Same as 
> repayment period, with accounting enabled for periodic accrual.
> 2. Submit new loan application for a client on 01 March 2015 approve and 
> disburse on same date.
> 3. Click on Admin -> system -> Scheduler job - run scheduler job "Add 
> Periodic Accrual Transactions".
> 4. Navigate back to Transactions page and verify the accrued interest as on 
> current date.
> 5. Make first repayment on exact due date then verify the transaction page 
> the accrued interest as on current date is not modified.
> > The accrued interest as on current date is not getting modified even after 
> > multiple repayments. 
> Please refer the screen shot attached.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FINERACT-311) Issue With 'Payment Due On Non Working Days'

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15855656#comment-15855656
 ] 

ASF GitHub Bot commented on FINERACT-311:
-

GitHub user nazeer1100126 opened a pull request:

https://github.com/apache/incubator-fineract/pull/284

FINERACT-311 - Issue With 'Payment Due On Non Working Days



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nazeer1100126/incubator-fineract FINERACT-311

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-fineract/pull/284.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #284


commit c6da909d615df4c9c13f96c6bdd04f01c35b46bc
Author: Nazeer Hussain Shaik 
Date:   2017-02-07T09:39:49Z

FINERACT-311 - Issue With 'Payment Due On Non Working Days




> Issue  With 'Payment Due On Non Working Days'
> -
>
> Key: FINERACT-311
> URL: https://issues.apache.org/jira/browse/FINERACT-311
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: System
>Affects Versions: 0.7.0-incubating
>Reporter: Santosh Math
>Assignee: Shaik Nazeer Hussain
>  Labels: p1
> Fix For: 0.7.0-incubating
>
> Attachments: paymentDueOnNonWorkingDay.png
>
>
> 1. Go To Admin>>Organization and click on Working Days
> 2.  Un-check Sunday.
> 3. Change  'Payment Due On Non Working Days' from 'same day' to 'Move to Next 
> Working Day' or any other parameters.
> 4. Click on Submit button.
> 5. Go Back to Admin>>Organization>>Working Days
> You can observe that   'Payment Due On Non Working Days' remains as 'same 
> day' though we changed it to other parameters like 'Move to Next Working Day' 
> , etc.
> Note: This issue doesn't appear every time but still exists. You can check it 
> by frequently changing 'Payment Due On Non Working  Days'



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FINERACT-221) After submitting the modify application the currency is not getting updated as per the new product

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15834471#comment-15834471
 ] 

ASF GitHub Bot commented on FINERACT-221:
-

GitHub user nazeer1100126 opened a pull request:

https://github.com/apache/incubator-fineract/pull/281

FINERACT-221-After submitting the modify application the currency is not 
getting updated as per the new product



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nazeer1100126/incubator-fineract FINERACT-221

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-fineract/pull/281.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #281


commit e92b6b171218ff7113248583beedddf4ac43512d
Author: Nazeer Hussain Shaik 
Date:   2017-01-23T13:18:28Z

FINERACT-221-After submitting the modify application the currency is not 
getting updated as per the new product




> After submitting the modify application the currency is not getting updated 
> as per the new product
> --
>
> Key: FINERACT-221
> URL: https://issues.apache.org/jira/browse/FINERACT-221
> Project: Apache Fineract
>  Issue Type: Bug
>Reporter: subramanyasn
>Assignee: Markus Geiss
>  Labels: p1
>
> 1. Create 2 loan products, one with Indian rupees as currency and another 
> with US Dollar
> 2. Submit new loan application for a client with the loan prouduct1.
> 3. Click on modify application and modify to product2.
> 4. In the loan general page currency is not getting updated to US Dollar, 
> rather it is remaining as Indian Rupees only.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FINERACT-364) Submitting Collection Sheet through Maker Checker Throwing Error

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15831373#comment-15831373
 ] 

ASF GitHub Bot commented on FINERACT-364:
-

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-fineract/pull/276


> Submitting Collection Sheet through Maker Checker Throwing Error
> 
>
> Key: FINERACT-364
> URL: https://issues.apache.org/jira/browse/FINERACT-364
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Loan
>Reporter: Santosh Math
>Assignee: Shaik Nazeer Hussain
>Priority: Blocker
>  Labels: p1
> Attachments: 1.png, 2.png, Screen Shot 2017-01-09 at 9.40.16 AM.png
>
>
> 1. Enable Maker Checker in System>>Configuration.
> 2. Go to  System>>Configure Maker Checker Tasks and click on 'Edit', select 
> the center and check 'SAVECOLLECTIONSHEET CENTER'. (check attached screenshot)
> 3. Disburse JLG Loan to a client.
> 4. Go to collection sheet and fill the details and select the center name but 
> don't select the group name.
> 5. Click  on Submit button, which goes to Checker Inbox. 
> 6. When you try to approve it , it throws the error.
> "The parameter `loanTransactions` has been passed and is not supported for 
> this request.
> The parameter `SavingsTransactions` has been passed and is not supported for 
> this request."  
> Check the attached file/screenshots.
> The above same error is thrown when,
> > You select both center and group and submit collection sheet. 
> > We try to submit through 'productive collection sheet'.
> > We try to submit 'Individual Collection Sheet'. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FINERACT-380) S3 permission issue -- add system property

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15831370#comment-15831370
 ] 

ASF GitHub Bot commented on FINERACT-380:
-

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-fineract/pull/278


> S3 permission issue -- add system property
> --
>
> Key: FINERACT-380
> URL: https://issues.apache.org/jira/browse/FINERACT-380
> Project: Apache Fineract
>  Issue Type: Improvement
>Reporter: thynn win
>Assignee: Shaik Nazeer Hussain
>Priority: Critical
>  Labels: p1
>
> Due to signature version 4 issue, I am unable to use S3 with Mifos.
> Amazon suggested we add a system property and could you please help us add 
> this in the next version?
> AWS Error Code: InvalidRequest, AWS Error Message: The authorization 
> mechanism you have provided is not supported. Please use AWS4-HMAC-SHA256.
> http://docs.aws.amazon.com/AmazonS3/latest/dev/UsingAWSSDK.html#specify-signature-version



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FINERACT-16) Cannot close Savings Account when linked to a loan even when loan status is closed

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-16?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15831367#comment-15831367
 ] 

ASF GitHub Bot commented on FINERACT-16:


Github user asfgit closed the pull request at:

https://github.com/apache/incubator-fineract/pull/277


> Cannot close Savings Account when linked to a loan even when loan status is 
> closed
> --
>
> Key: FINERACT-16
> URL: https://issues.apache.org/jira/browse/FINERACT-16
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Savings
>Reporter: Dayna Harp
>Assignee: Shaik Nazeer Hussain
>Priority: Critical
>  Labels: p1
>
> https://mifosforge.jira.com/browse/MIFOSX-2293
> 1. Create and activate a client 
> 2. Create and activated a savings account for the client, deposit some amount 
> in the account
> 3. Link the above savings account to a new loan application and  Submit the 
> loan application, Don't approve, it close the loan.
> 4. Try to close the above savings account and check the Withdraw Balance
> _Error
> Closing savings account with id:11 is not allowed, since it is linked with 
> one of the active loans_
> The same error is got if even the loan account is paid all and closed.
> I think the cause is, when a loan account is closed, withdrawn, or rejected 
> the linked savings account remains linked.to the loan account hence this 
> error.
> This is very critical barrier



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FINERACT-380) S3 permission issue -- add system property

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15829691#comment-15829691
 ] 

ASF GitHub Bot commented on FINERACT-380:
-

GitHub user nazeer1100126 opened a pull request:

https://github.com/apache/incubator-fineract/pull/278

FINERACT-380 S3 permission issue -- add system property



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nazeer1100126/incubator-fineract FINERACT-380

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-fineract/pull/278.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #278


commit b4156ed1ef703b29777005fbec673ab7f1e9c5ad
Author: Nazeer Hussain Shaik 
Date:   2017-01-19T10:30:34Z

FINERACT-380 S3 permission issue -- add system property




> S3 permission issue -- add system property
> --
>
> Key: FINERACT-380
> URL: https://issues.apache.org/jira/browse/FINERACT-380
> Project: Apache Fineract
>  Issue Type: Improvement
>Reporter: thynn win
>Assignee: Shaik Nazeer Hussain
>Priority: Critical
>  Labels: p1
>
> Due to signature version 4 issue, I am unable to use S3 with Mifos.
> Amazon suggested we add a system property and could you please help us add 
> this in the next version?
> AWS Error Code: InvalidRequest, AWS Error Message: The authorization 
> mechanism you have provided is not supported. Please use AWS4-HMAC-SHA256.
> http://docs.aws.amazon.com/AmazonS3/latest/dev/UsingAWSSDK.html#specify-signature-version



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FINERACT-16) Cannot close Savings Account when linked to a loan even when loan status is closed

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-16?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15827650#comment-15827650
 ] 

ASF GitHub Bot commented on FINERACT-16:


GitHub user nazeer1100126 opened a pull request:

https://github.com/apache/incubator-fineract/pull/277

FINERACT-16-Cannot close Savings Account when linked to a loan even when 
loan status is closed



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nazeer1100126/incubator-fineract FINERACT-16

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-fineract/pull/277.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #277






> Cannot close Savings Account when linked to a loan even when loan status is 
> closed
> --
>
> Key: FINERACT-16
> URL: https://issues.apache.org/jira/browse/FINERACT-16
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Savings
>Reporter: Dayna Harp
>Assignee: Markus Geiss
>Priority: Critical
>  Labels: p1
>
> https://mifosforge.jira.com/browse/MIFOSX-2293
> 1. Create and activate a client 
> 2. Create and activated a savings account for the client, deposit some amount 
> in the account
> 3. Link the above savings account to a new loan application and  Submit the 
> loan application, Don't approve, it close the loan.
> 4. Try to close the above savings account and check the Withdraw Balance
> _Error
> Closing savings account with id:11 is not allowed, since it is linked with 
> one of the active loans_
> The same error is got if even the loan account is paid all and closed.
> I think the cause is, when a loan account is closed, withdrawn, or rejected 
> the linked savings account remains linked.to the loan account hence this 
> error.
> This is very critical barrier



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FINERACT-364) Submitting Collection Sheet through Maker Checker Throwing Error

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15825956#comment-15825956
 ] 

ASF GitHub Bot commented on FINERACT-364:
-

GitHub user nazeer1100126 opened a pull request:

https://github.com/apache/incubator-fineract/pull/276

FINERACT-364 - Submitting Collection Sheet through Maker Checker Throwing 
Error



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nazeer1100126/incubator-fineract 
develop_FINERACT-364

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-fineract/pull/276.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #276


commit 0173c8d05fd33a7ac59358beb4321edcca6f9b68
Author: Nazeer Hussain Shaik 
Date:   2017-01-17T12:08:01Z

FINERACT-364




> Submitting Collection Sheet through Maker Checker Throwing Error
> 
>
> Key: FINERACT-364
> URL: https://issues.apache.org/jira/browse/FINERACT-364
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Loan
>Reporter: Santosh Math
>Assignee: Shaik Nazeer Hussain
>Priority: Blocker
>  Labels: p1
> Attachments: 1.png, 2.png, Screen Shot 2017-01-09 at 9.40.16 AM.png
>
>
> 1. Enable Maker Checker in System>>Configuration.
> 2. Go to  System>>Configure Maker Checker Tasks and click on 'Edit', select 
> the center and check 'SAVECOLLECTIONSHEET CENTER'. (check attached screenshot)
> 3. Disburse JLG Loan to a client.
> 4. Go to collection sheet and fill the details and select the center name but 
> don't select the group name.
> 5. Click  on Submit button, which goes to Checker Inbox. 
> 6. When you try to approve it , it throws the error.
> "The parameter `loanTransactions` has been passed and is not supported for 
> this request.
> The parameter `SavingsTransactions` has been passed and is not supported for 
> this request."  
> Check the attached file/screenshots.
> The above same error is thrown when,
> > You select both center and group and submit collection sheet. 
> > We try to submit through 'productive collection sheet'.
> > We try to submit 'Individual Collection Sheet'. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FINERACT-352) Penalties for last loan installment are not shown on summary

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15821089#comment-15821089
 ] 

ASF GitHub Bot commented on FINERACT-352:
-

GitHub user lionelraymundi opened a pull request:

https://github.com/apache/incubator-fineract/pull/274

FINERACT-352 fix showing penalties after last loan's installment

The new installment created in which penalties should be applied after 
loan's maturity date, was created twice. This messed up with the charges 
recalculation.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/lionelraymundi/incubator-fineract FINERACT-352

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-fineract/pull/274.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #274


commit 392dff0cd1408632cf994063f1a0901c331b35d9
Author: lionel 
Date:   2017-01-12T14:11:50Z

FINERACT-352 fix showing penalties after last loan's installment




> Penalties for last loan installment are not shown on summary
> 
>
> Key: FINERACT-352
> URL: https://issues.apache.org/jira/browse/FINERACT-352
> Project: Apache Fineract
>  Issue Type: Bug
>Reporter: Lionel Raymundi
>Assignee: Markus Geiss
>
> When penalties are configured for a loan, if the last installment is not paid 
> on term a new installment is created, where penalties should be applied. 
> It seems that the penalties are being correctly created, but on installment 
> summary they are not properly shown.
> There is an example of this on https://demo.openmf.org/#/viewloanaccount/399



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FINERACT-7) Repayment Schedule after waive fee not correct

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15795343#comment-15795343
 ] 

ASF GitHub Bot commented on FINERACT-7:
---

Github user abdulazizali77 commented on the issue:

https://github.com/apache/incubator-fineract/pull/256
  
@nazeer1100126 Hi, sorry i didnt run the integration test before. I did 
give the integration tests a run with and without the changes and it seems i 
get identical failures on ClientLoanIntegrationTest (and other tests).
I will ascertain whether the two modified methods in the PR are called 
during any of the integration tests. From first glance however 
testLoanScheduleWithInterestRecalculation_WITH_REST_SAME_AS_REPAYMENT_INTEREST_COMPOUND_NONE_STRATEGY_REDUCE_EMI_WITH_INSTALLMENT_CHARGE
 doesnt seem to be calling Loan.generateInstallmentLoanCharges nor 
LoanCharge.updateInstallmentCharges. (possibly i am wrong)



> Repayment Schedule after waive fee not correct
> --
>
> Key: FINERACT-7
> URL: https://issues.apache.org/jira/browse/FINERACT-7
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Loan
>Reporter: Dayna Harp
>Assignee: Markus Geiss
> Attachments: 1.jpg, 2.jpg, 3.jpg
>
>
> https://mifosforge.jira.com/browse/MIFOSX-2495
> After waive installment fee the repayment schedule generated is not proper
> 1. Create Installment fee for a loan as 100-Flat-Regular. 
> 2. Create loan product with following datasets and attache above installment 
> fee to that.
> Terms vary based on loan cycle :  FALSE
> Principal:10,000   ( Min: , Max : )
> Number of Repayments: 12   ( Min: , Max
> Repay Every:  1  Months
> Nominal Interest Rate:1   ( Min: , Max  Per month
> Minimum days between disbursal and first repayment date   
> Amortization  Equal installments
> Interest Method   Declining Balance
> Interest Calculation Period   Daily
> Repayment StrategyOverdue/Due Fee/Int,Principal
> Account moves out of NPA only after all arrears have been cleared?No
> Days in year  Actual
> Days in month Actual
> Principal Threshold (%) for Last Instalment   0
> Allow fixing of the installment amountNo
> Interest Recalculation
> Recalculate Interest  Yes
> Advance payments adjustment type  Reduce number of installments
> Pre-closure interest calculation rule Calculate till pre closure date
> Interest recalculation compounding on None
> Frequency for recalculate Outstanding Principal   Daily
> Frequency Interval for recalculation  1
> Frequency Date for recalculation  01-Jan-15
> Is Arrears recognization based on original schedule:No.
> 3. Submit new loan application on 01 October 2015. Approve and disburse loan 
> on same date.
> 4. Click on waive charge and select for 1st repayment.
> 5. Repayment schedule generated after waive charge is not proper
> >Waive charge is happening not for first installment instead for other 
> >installment it is happening.
> 6. For first repayment the due is getting displayed.
> Attachments here: https://mifosforge.jira.com/browse/MIFOSX-2495



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FINERACT-7) Repayment Schedule after waive fee not correct

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15772367#comment-15772367
 ] 

ASF GitHub Bot commented on FINERACT-7:
---

Github user nazeer1100126 commented on the issue:

https://github.com/apache/incubator-fineract/pull/256
  
@abdulazizali77 I am seeing following integration test failure with these 
changes 
ClientLoanIntegrationTest.testLoanScheduleWithInterestRecalculation_WITH_REST_SAME_AS_REPAYMENT_INTEREST_COMPOUND_NONE_STRATEGY_REDUCE_EMI_WITH_INSTALLMENT_CHARGE()
Have you run integration tests before sending this PR?


> Repayment Schedule after waive fee not correct
> --
>
> Key: FINERACT-7
> URL: https://issues.apache.org/jira/browse/FINERACT-7
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Loan
>Reporter: Dayna Harp
>Assignee: Markus Geiss
> Attachments: 1.jpg, 2.jpg, 3.jpg
>
>
> https://mifosforge.jira.com/browse/MIFOSX-2495
> After waive installment fee the repayment schedule generated is not proper
> 1. Create Installment fee for a loan as 100-Flat-Regular. 
> 2. Create loan product with following datasets and attache above installment 
> fee to that.
> Terms vary based on loan cycle :  FALSE
> Principal:10,000   ( Min: , Max : )
> Number of Repayments: 12   ( Min: , Max
> Repay Every:  1  Months
> Nominal Interest Rate:1   ( Min: , Max  Per month
> Minimum days between disbursal and first repayment date   
> Amortization  Equal installments
> Interest Method   Declining Balance
> Interest Calculation Period   Daily
> Repayment StrategyOverdue/Due Fee/Int,Principal
> Account moves out of NPA only after all arrears have been cleared?No
> Days in year  Actual
> Days in month Actual
> Principal Threshold (%) for Last Instalment   0
> Allow fixing of the installment amountNo
> Interest Recalculation
> Recalculate Interest  Yes
> Advance payments adjustment type  Reduce number of installments
> Pre-closure interest calculation rule Calculate till pre closure date
> Interest recalculation compounding on None
> Frequency for recalculate Outstanding Principal   Daily
> Frequency Interval for recalculation  1
> Frequency Date for recalculation  01-Jan-15
> Is Arrears recognization based on original schedule:No.
> 3. Submit new loan application on 01 October 2015. Approve and disburse loan 
> on same date.
> 4. Click on waive charge and select for 1st repayment.
> 5. Repayment schedule generated after waive charge is not proper
> >Waive charge is happening not for first installment instead for other 
> >installment it is happening.
> 6. For first repayment the due is getting displayed.
> Attachments here: https://mifosforge.jira.com/browse/MIFOSX-2495



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FINERACT-7) Repayment Schedule after waive fee not correct

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15753549#comment-15753549
 ] 

ASF GitHub Bot commented on FINERACT-7:
---

Github user nazeer1100126 commented on the issue:

https://github.com/apache/incubator-fineract/pull/256
  
@abdulazizali77 we will accept PR(s) with a single commit to maintain 
cleaner history. Can you please send PR with a single commit.


> Repayment Schedule after waive fee not correct
> --
>
> Key: FINERACT-7
> URL: https://issues.apache.org/jira/browse/FINERACT-7
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Loan
>Reporter: Dayna Harp
>Assignee: Markus Geiss
> Attachments: 1.jpg, 2.jpg, 3.jpg
>
>
> https://mifosforge.jira.com/browse/MIFOSX-2495
> After waive installment fee the repayment schedule generated is not proper
> 1. Create Installment fee for a loan as 100-Flat-Regular. 
> 2. Create loan product with following datasets and attache above installment 
> fee to that.
> Terms vary based on loan cycle :  FALSE
> Principal:10,000   ( Min: , Max : )
> Number of Repayments: 12   ( Min: , Max
> Repay Every:  1  Months
> Nominal Interest Rate:1   ( Min: , Max  Per month
> Minimum days between disbursal and first repayment date   
> Amortization  Equal installments
> Interest Method   Declining Balance
> Interest Calculation Period   Daily
> Repayment StrategyOverdue/Due Fee/Int,Principal
> Account moves out of NPA only after all arrears have been cleared?No
> Days in year  Actual
> Days in month Actual
> Principal Threshold (%) for Last Instalment   0
> Allow fixing of the installment amountNo
> Interest Recalculation
> Recalculate Interest  Yes
> Advance payments adjustment type  Reduce number of installments
> Pre-closure interest calculation rule Calculate till pre closure date
> Interest recalculation compounding on None
> Frequency for recalculate Outstanding Principal   Daily
> Frequency Interval for recalculation  1
> Frequency Date for recalculation  01-Jan-15
> Is Arrears recognization based on original schedule:No.
> 3. Submit new loan application on 01 October 2015. Approve and disburse loan 
> on same date.
> 4. Click on waive charge and select for 1st repayment.
> 5. Repayment schedule generated after waive charge is not proper
> >Waive charge is happening not for first installment instead for other 
> >installment it is happening.
> 6. For first repayment the due is getting displayed.
> Attachments here: https://mifosforge.jira.com/browse/MIFOSX-2495



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FINERACT-7) Repayment Schedule after waive fee not correct

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15751133#comment-15751133
 ] 

ASF GitHub Bot commented on FINERACT-7:
---

Github user abdulazizali77 commented on a diff in the pull request:

https://github.com/apache/incubator-fineract/pull/256#discussion_r92592186
  
--- Diff: 
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanCharge.java
 ---
@@ -494,17 +494,29 @@ private void updateInstallmentCharges() {
 this.loanInstallmentCharge.addAll(chargePerInstallments);
 } else {
 int index = 0;
-final LoanInstallmentCharge[] loanChargePerInstallments = new 
LoanInstallmentCharge[chargePerInstallments.size()];
-final LoanInstallmentCharge[] loanChargePerInstallmentArray = 
chargePerInstallments.toArray(loanChargePerInstallments);
-for (final LoanInstallmentCharge chargePerInstallment : 
this.loanInstallmentCharge) {
+//FINERACT-7: NB: this is really overkill and slow, without 
changing the Sets and or Entities this is the most
+//locally safe way to fix this issue
+ArrayList oldChargeInstallments = new 
ArrayList();
+ArrayList newChargeInstallments = new 
ArrayList();
+
+oldChargeInstallments.addAll(this.loanInstallmentCharge);
+newChargeInstallments.addAll(chargePerInstallments);
+Collections.sort(oldChargeInstallments);
+Collections.sort(newChargeInstallments);
+final LoanInstallmentCharge[] loanChargePerInstallmentArray = 
chargePerInstallments.toArray(new 
LoanInstallmentCharge[chargePerInstallments.size()]);
--- End diff --

Youre right, have modified the interface accordingly


> Repayment Schedule after waive fee not correct
> --
>
> Key: FINERACT-7
> URL: https://issues.apache.org/jira/browse/FINERACT-7
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Loan
>Reporter: Dayna Harp
>Assignee: Markus Geiss
> Attachments: 1.jpg, 2.jpg, 3.jpg
>
>
> https://mifosforge.jira.com/browse/MIFOSX-2495
> After waive installment fee the repayment schedule generated is not proper
> 1. Create Installment fee for a loan as 100-Flat-Regular. 
> 2. Create loan product with following datasets and attache above installment 
> fee to that.
> Terms vary based on loan cycle :  FALSE
> Principal:10,000   ( Min: , Max : )
> Number of Repayments: 12   ( Min: , Max
> Repay Every:  1  Months
> Nominal Interest Rate:1   ( Min: , Max  Per month
> Minimum days between disbursal and first repayment date   
> Amortization  Equal installments
> Interest Method   Declining Balance
> Interest Calculation Period   Daily
> Repayment StrategyOverdue/Due Fee/Int,Principal
> Account moves out of NPA only after all arrears have been cleared?No
> Days in year  Actual
> Days in month Actual
> Principal Threshold (%) for Last Instalment   0
> Allow fixing of the installment amountNo
> Interest Recalculation
> Recalculate Interest  Yes
> Advance payments adjustment type  Reduce number of installments
> Pre-closure interest calculation rule Calculate till pre closure date
> Interest recalculation compounding on None
> Frequency for recalculate Outstanding Principal   Daily
> Frequency Interval for recalculation  1
> Frequency Date for recalculation  01-Jan-15
> Is Arrears recognization based on original schedule:No.
> 3. Submit new loan application on 01 October 2015. Approve and disburse loan 
> on same date.
> 4. Click on waive charge and select for 1st repayment.
> 5. Repayment schedule generated after waive charge is not proper
> >Waive charge is happening not for first installment instead for other 
> >installment it is happening.
> 6. For first repayment the due is getting displayed.
> Attachments here: https://mifosforge.jira.com/browse/MIFOSX-2495



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FINERACT-267) Foreclosure Issue: Loan with Installment fee status is overpaid

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15744941#comment-15744941
 ] 

ASF GitHub Bot commented on FINERACT-267:
-

Github user nazeer1100126 commented on the issue:

https://github.com/apache/incubator-fineract/pull/251
  
FINERACT-267


> Foreclosure Issue: Loan with Installment fee status is overpaid
> ---
>
> Key: FINERACT-267
> URL: https://issues.apache.org/jira/browse/FINERACT-267
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Charges, Loan
> Environment: Ubuntu
>Reporter: Ram Awale
>Assignee: Markus Geiss
>
> Foreclosure for a loan which has a installment fee is changing status to over 
> payment instead of closed loan.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FINERACT-260) Validation need to be added if the client charge is applied before client activation date

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15744926#comment-15744926
 ] 

ASF GitHub Bot commented on FINERACT-260:
-

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-fineract/pull/250


> Validation need to be added if the client charge is applied before client 
> activation date
> -
>
> Key: FINERACT-260
> URL: https://issues.apache.org/jira/browse/FINERACT-260
> Project: Apache Fineract
>  Issue Type: Bug
>Reporter: Edward Cable
>Assignee: Markus Geiss
>Priority: Minor
> Attachments: Screen Shot 2016-11-22 at 3.21.31 PM.png
>
>
> Migrated over from MifosForge.
> Original Description:
> If the client activation date is on 01 June 2016 and the charge for a client 
> is getting applied before that date then validation need to be added, and 
> proper error message should get displayed
> Steps to Reproduce
> 1. Add a client charge, select a due date prior to client activation date. 
> 2. Submit and it successfully goes through.
> Expected Behavior
> 1. Upon submission of charge with a due date prior to activation date of the 
> client, a proper error message should be displayed stating that the the 
> charge due date is before the client activation date. 
> See https://demo3.openmf.org/#/viewclient/10 for an example. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FINERACT-7) Repayment Schedule after waive fee not correct

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15725022#comment-15725022
 ] 

ASF GitHub Bot commented on FINERACT-7:
---

GitHub user abdulazizali77 opened a pull request:

https://github.com/apache/incubator-fineract/pull/256

FINERACT-7: Sort loanInstallmentCharges before updating

Less than ideal fix (sorting overhead), but most topically contained. 
Potentially we should change the Sets to Lists, and or redefine the Entities, 
but that would affect too many things.

Have left a potentially iffy corner case in updateInstallmentCharges as is.

Additionally there is a pre-existing defect where a PersistenceException 
caused by an FK constraint is raised when all of the charges are waived. Have 
not investigated, potentially there is an existing bug.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/abdulazizali77/incubator-fineract FINERACT-7

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-fineract/pull/256.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #256


commit ebea611024d237e5388d5ba987a1798321fbd58f
Author: abdulazizali77 
Date:   2016-12-06T10:09:03Z

FINERACT-7: Make LoanInstallmentCharge and LoanRepaymentSchedule sortable

commit 515a4a28c8a945f35229e7f60098f010091baee3
Author: abdulazizali77 
Date:   2016-12-06T10:10:14Z

FINERACT-7: Sort old loanInstallmentCharges and new lic before updating




> Repayment Schedule after waive fee not correct
> --
>
> Key: FINERACT-7
> URL: https://issues.apache.org/jira/browse/FINERACT-7
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Loan
>Reporter: Dayna Harp
>Assignee: Markus Geiss
> Attachments: 1.jpg, 2.jpg, 3.jpg
>
>
> https://mifosforge.jira.com/browse/MIFOSX-2495
> After waive installment fee the repayment schedule generated is not proper
> 1. Create Installment fee for a loan as 100-Flat-Regular. 
> 2. Create loan product with following datasets and attache above installment 
> fee to that.
> Terms vary based on loan cycle :  FALSE
> Principal:10,000   ( Min: , Max : )
> Number of Repayments: 12   ( Min: , Max
> Repay Every:  1  Months
> Nominal Interest Rate:1   ( Min: , Max  Per month
> Minimum days between disbursal and first repayment date   
> Amortization  Equal installments
> Interest Method   Declining Balance
> Interest Calculation Period   Daily
> Repayment StrategyOverdue/Due Fee/Int,Principal
> Account moves out of NPA only after all arrears have been cleared?No
> Days in year  Actual
> Days in month Actual
> Principal Threshold (%) for Last Instalment   0
> Allow fixing of the installment amountNo
> Interest Recalculation
> Recalculate Interest  Yes
> Advance payments adjustment type  Reduce number of installments
> Pre-closure interest calculation rule Calculate till pre closure date
> Interest recalculation compounding on None
> Frequency for recalculate Outstanding Principal   Daily
> Frequency Interval for recalculation  1
> Frequency Date for recalculation  01-Jan-15
> Is Arrears recognization based on original schedule:No.
> 3. Submit new loan application on 01 October 2015. Approve and disburse loan 
> on same date.
> 4. Click on waive charge and select for 1st repayment.
> 5. Repayment schedule generated after waive charge is not proper
> >Waive charge is happening not for first installment instead for other 
> >installment it is happening.
> 6. For first repayment the due is getting displayed.
> Attachments here: https://mifosforge.jira.com/browse/MIFOSX-2495



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FINERACT-266) Handling License issues for both source and binary distributions

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15722057#comment-15722057
 ] 

ASF GitHub Bot commented on FINERACT-266:
-

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-fineract/pull/254


> Handling License issues for both source and binary distributions
> 
>
> Key: FINERACT-266
> URL: https://issues.apache.org/jira/browse/FINERACT-266
> Project: Apache Fineract
>  Issue Type: Task
>Reporter: Shaik Nazeer Hussain
>Assignee: Shaik Nazeer Hussain
>
> Copy license files while building war file



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FINERACT-266) Handling License issues for both source and binary distributions

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15722014#comment-15722014
 ] 

ASF GitHub Bot commented on FINERACT-266:
-

GitHub user nazeer1100126 opened a pull request:

https://github.com/apache/incubator-fineract/pull/254

FINERACT-266 - Handling License issues for both source and binary 
distributions



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nazeer1100126/incubator-fineract 
develop_releasebinaryupdates

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-fineract/pull/254.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #254


commit 3d03595ffd2a00393164c2f2e9b96b547908f11b
Author: Nazeer Hussain Shaik 
Date:   2016-12-05T11:18:36Z

FINERACT-266 - Handling License issues for both source and binary 
distributions




> Handling License issues for both source and binary distributions
> 
>
> Key: FINERACT-266
> URL: https://issues.apache.org/jira/browse/FINERACT-266
> Project: Apache Fineract
>  Issue Type: Task
>Reporter: Shaik Nazeer Hussain
>Assignee: Shaik Nazeer Hussain
>
> Copy license files while building war file



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FINERACT-266) Handling License issues for both source and binary distributions

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15721846#comment-15721846
 ] 

ASF GitHub Bot commented on FINERACT-266:
-

Github user nazeer1100126 closed the pull request at:

https://github.com/apache/incubator-fineract/pull/253


> Handling License issues for both source and binary distributions
> 
>
> Key: FINERACT-266
> URL: https://issues.apache.org/jira/browse/FINERACT-266
> Project: Apache Fineract
>  Issue Type: Task
>Reporter: Shaik Nazeer Hussain
>Assignee: Shaik Nazeer Hussain
>
> Copy license files while building war file



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FINERACT-266) Handling License issues for both source and binary distributions

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15721779#comment-15721779
 ] 

ASF GitHub Bot commented on FINERACT-266:
-

GitHub user nazeer1100126 opened a pull request:

https://github.com/apache/incubator-fineract/pull/253

FINERACT-266 - Handling License issues for both source and binary dis…

…tributions

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nazeer1100126/incubator-fineract 
develop_releasebinaryupdates

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-fineract/pull/253.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #253


commit 873c108a1b391d25f8b669ddad6c267e14d82339
Author: Nazeer Hussain Shaik 
Date:   2016-12-05T09:44:56Z

FINERACT-266 - Handling License issues for both source and binary 
distributions




> Handling License issues for both source and binary distributions
> 
>
> Key: FINERACT-266
> URL: https://issues.apache.org/jira/browse/FINERACT-266
> Project: Apache Fineract
>  Issue Type: Task
>Reporter: Shaik Nazeer Hussain
>Assignee: Shaik Nazeer Hussain
>
> Copy license files while building war file



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FINERACT-266) Handling License issues for both source and binary distributions

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15721678#comment-15721678
 ] 

ASF GitHub Bot commented on FINERACT-266:
-

Github user nazeer1100126 closed the pull request at:

https://github.com/apache/incubator-fineract/pull/252


> Handling License issues for both source and binary distributions
> 
>
> Key: FINERACT-266
> URL: https://issues.apache.org/jira/browse/FINERACT-266
> Project: Apache Fineract
>  Issue Type: Task
>Reporter: Shaik Nazeer Hussain
>Assignee: Shaik Nazeer Hussain
>
> Copy license files while building war file



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FINERACT-266) Handling License issues for both source and binary distributions

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15721660#comment-15721660
 ] 

ASF GitHub Bot commented on FINERACT-266:
-

GitHub user nazeer1100126 opened a pull request:

https://github.com/apache/incubator-fineract/pull/252

FINERACT-266 - Handling License issues for both source and binary 
distributions



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nazeer1100126/incubator-fineract 
develop_releasebinaryupdates

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-fineract/pull/252.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #252


commit bae5558f38540af45d05a6092d0488484ded44c1
Author: Nazeer Hussain Shaik 
Date:   2016-12-05T08:56:11Z

FINERACT-266 - Handling License issues for both source and binary 
distributions




> Handling License issues for both source and binary distributions
> 
>
> Key: FINERACT-266
> URL: https://issues.apache.org/jira/browse/FINERACT-266
> Project: Apache Fineract
>  Issue Type: Task
>Reporter: Shaik Nazeer Hussain
>Assignee: Shaik Nazeer Hussain
>
> Copy license files while building war file



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FINERACT-245) Introduce RAT checks

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689350#comment-15689350
 ] 

ASF GitHub Bot commented on FINERACT-245:
-

Github user rajuan commented on the issue:

https://github.com/apache/incubator-fineract/pull/249
  
Looks fine


> Introduce RAT checks
> 
>
> Key: FINERACT-245
> URL: https://issues.apache.org/jira/browse/FINERACT-245
> Project: Apache Fineract
>  Issue Type: Task
>Reporter: Myrle Krantz
>Assignee: Shaik Nazeer Hussain
>
> GIVEN a contributor or committer forks the fineract code base, and builds it 
> locally to fix bugs and add features,
> WHEN an apache policy violating library dependency is accidentally introduced 
> to the source code,
> THEN the build fails.
> See https://github.com/apache/incubator-geode/blob/develop/gradle/rat.gradle 
> for an example of how to do this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FINERACT-245) Introduce RAT checks

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689254#comment-15689254
 ] 

ASF GitHub Bot commented on FINERACT-245:
-

GitHub user nazeer1100126 opened a pull request:

https://github.com/apache/incubator-fineract/pull/249

Integrating Apache RAT FINERACT-245



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nazeer1100126/incubator-fineract 
RAT_Integration

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-fineract/pull/249.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #249


commit e9e3326f5b8ad18586a11f1bf2faa149d6afcacb
Author: Nazeer Hussain Shaik 
Date:   2016-11-23T07:53:13Z

Integrating Apache RAT FINERACT-245




> Introduce RAT checks
> 
>
> Key: FINERACT-245
> URL: https://issues.apache.org/jira/browse/FINERACT-245
> Project: Apache Fineract
>  Issue Type: Task
>Reporter: Myrle Krantz
>Assignee: Shaik Nazeer Hussain
>
> GIVEN a contributor or committer forks the fineract code base, and builds it 
> locally to fix bugs and add features,
> WHEN an apache policy violating library dependency is accidentally introduced 
> to the source code,
> THEN the build fails.
> See https://github.com/apache/incubator-geode/blob/develop/gradle/rat.gradle 
> for an example of how to do this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FINERACT-37) Support rescheduling repayments on holidays

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15644792#comment-15644792
 ] 

ASF GitHub Bot commented on FINERACT-37:


Github user jroweboy closed the pull request at:

https://github.com/apache/incubator-fineract/pull/110


> Support rescheduling repayments on holidays
> ---
>
> Key: FINERACT-37
> URL: https://issues.apache.org/jira/browse/FINERACT-37
> Project: Apache Fineract
>  Issue Type: Improvement
>  Components: System
>Reporter: James Rowe
>Assignee: Markus Geiss
>
> Our client is currently trying to migrate from their current financial 
> software, but one of the configuration options is not present in Fineract. 
> The option changes the way Fineract schedules loan repayments. Instead of 
> rescheduling a repayment to a different day in the week, holidays would 
> reschedule the repayment to the next due date and extend the schedule. For 
> example with a holiday like this http://i.imgur.com/Dl8B3DX.png a loan that 
> has a repayment fall in the holiday will be rescheduled to the next week and 
> the following repayments will be postponed. http://i.imgur.com/l9OfTDm.png 
> With this the loan term is extended and the repayment that landed on a 
> holiday is repaid on the next due date. 
> I already have a proof of concept patch for this, but I think there are some 
> issues with it. As such, I would like to work with a developer to discuss the 
> best way to implement this, or if you would like, we can just figure out why 
> my patch occasionally enters an infinite loop...
> As a related request, the client is looking to have the interest due at this 
> repayment to be redistributed across the full loan schedule. I wasn't sure if 
> I should include this in this issue report or to make a new one that is 
> related to this issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FINERACT-37) Support rescheduling repayments on holidays

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15584692#comment-15584692
 ] 

ASF GitHub Bot commented on FINERACT-37:


Github user asfgit closed the pull request at:

https://github.com/apache/incubator-fineract/pull/219


> Support rescheduling repayments on holidays
> ---
>
> Key: FINERACT-37
> URL: https://issues.apache.org/jira/browse/FINERACT-37
> Project: Apache Fineract
>  Issue Type: Improvement
>  Components: System
>Reporter: James Rowe
>Assignee: Markus Geiss
>
> Our client is currently trying to migrate from their current financial 
> software, but one of the configuration options is not present in Fineract. 
> The option changes the way Fineract schedules loan repayments. Instead of 
> rescheduling a repayment to a different day in the week, holidays would 
> reschedule the repayment to the next due date and extend the schedule. For 
> example with a holiday like this http://i.imgur.com/Dl8B3DX.png a loan that 
> has a repayment fall in the holiday will be rescheduled to the next week and 
> the following repayments will be postponed. http://i.imgur.com/l9OfTDm.png 
> With this the loan term is extended and the repayment that landed on a 
> holiday is repaid on the next due date. 
> I already have a proof of concept patch for this, but I think there are some 
> issues with it. As such, I would like to work with a developer to discuss the 
> best way to implement this, or if you would like, we can just figure out why 
> my patch occasionally enters an infinite loop...
> As a related request, the client is looking to have the interest due at this 
> repayment to be redistributed across the full loan schedule. I wasn't sure if 
> I should include this in this issue report or to make a new one that is 
> related to this issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FINERACT-37) Support rescheduling repayments on holidays

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15584537#comment-15584537
 ] 

ASF GitHub Bot commented on FINERACT-37:


Github user nazeer1100126 commented on the issue:

https://github.com/apache/incubator-fineract/pull/219
  
I agree to your point :-)


> Support rescheduling repayments on holidays
> ---
>
> Key: FINERACT-37
> URL: https://issues.apache.org/jira/browse/FINERACT-37
> Project: Apache Fineract
>  Issue Type: Improvement
>  Components: System
>Reporter: James Rowe
>Assignee: Markus Geiss
>
> Our client is currently trying to migrate from their current financial 
> software, but one of the configuration options is not present in Fineract. 
> The option changes the way Fineract schedules loan repayments. Instead of 
> rescheduling a repayment to a different day in the week, holidays would 
> reschedule the repayment to the next due date and extend the schedule. For 
> example with a holiday like this http://i.imgur.com/Dl8B3DX.png a loan that 
> has a repayment fall in the holiday will be rescheduled to the next week and 
> the following repayments will be postponed. http://i.imgur.com/l9OfTDm.png 
> With this the loan term is extended and the repayment that landed on a 
> holiday is repaid on the next due date. 
> I already have a proof of concept patch for this, but I think there are some 
> issues with it. As such, I would like to work with a developer to discuss the 
> best way to implement this, or if you would like, we can just figure out why 
> my patch occasionally enters an infinite loop...
> As a related request, the client is looking to have the interest due at this 
> repayment to be redistributed across the full loan schedule. I wasn't sure if 
> I should include this in this issue report or to make a new one that is 
> related to this issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FINERACT-37) Support rescheduling repayments on holidays

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15568368#comment-15568368
 ] 

ASF GitHub Bot commented on FINERACT-37:


Github user terencemo commented on the issue:

https://github.com/apache/incubator-fineract/pull/219
  
extendTermForDailyRepayments flag is for a different purpose than 
extendTermForRepaymentsOnHolidays. There should be a way to specify which of 
the 2 is required and hence 2 bools. If a single bool is used, what is the 
behaviour if its set? Does it extend the term for both loans with daily 
repayment schedule and for holidays? What if the API user needs one of these 2 
functionalities?


> Support rescheduling repayments on holidays
> ---
>
> Key: FINERACT-37
> URL: https://issues.apache.org/jira/browse/FINERACT-37
> Project: Apache Fineract
>  Issue Type: Improvement
>  Components: System
>Reporter: James Rowe
>Assignee: Markus Geiss
>
> Our client is currently trying to migrate from their current financial 
> software, but one of the configuration options is not present in Fineract. 
> The option changes the way Fineract schedules loan repayments. Instead of 
> rescheduling a repayment to a different day in the week, holidays would 
> reschedule the repayment to the next due date and extend the schedule. For 
> example with a holiday like this http://i.imgur.com/Dl8B3DX.png a loan that 
> has a repayment fall in the holiday will be rescheduled to the next week and 
> the following repayments will be postponed. http://i.imgur.com/l9OfTDm.png 
> With this the loan term is extended and the repayment that landed on a 
> holiday is repaid on the next due date. 
> I already have a proof of concept patch for this, but I think there are some 
> issues with it. As such, I would like to work with a developer to discuss the 
> best way to implement this, or if you would like, we can just figure out why 
> my patch occasionally enters an infinite loop...
> As a related request, the client is looking to have the interest due at this 
> repayment to be redistributed across the full loan schedule. I wasn't sure if 
> I should include this in this issue report or to make a new one that is 
> related to this issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FINERACT-37) Support rescheduling repayments on holidays

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15568359#comment-15568359
 ] 

ASF GitHub Bot commented on FINERACT-37:


Github user terencemo commented on a diff in the pull request:

https://github.com/apache/incubator-fineract/pull/219#discussion_r82979521
  
--- Diff: 
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/DefaultScheduledDateGenerator.java
 ---
@@ -96,10 +96,33 @@ public LocalDate generateNextRepaymentDate(final 
LocalDate lastRepaymentDate, fi
 loanApplicationTerms.getNumberOfdays());
 }
 }
-
+if (currentCalendar == null && 
holidayDetailDTO.getWorkingDays().getExtendTermForRepaymentsOnHolidays()) {
--- End diff --

Tried calling adjustRepaymentDate. It doesn't reschedule for holidays other 
than weekend. Went through the code of adjustRepaymentDate and found nothing 
that handles holidays. The code block after the if does something which I 
couldn't find in any existing function in the codebase.


> Support rescheduling repayments on holidays
> ---
>
> Key: FINERACT-37
> URL: https://issues.apache.org/jira/browse/FINERACT-37
> Project: Apache Fineract
>  Issue Type: Improvement
>  Components: System
>Reporter: James Rowe
>Assignee: Markus Geiss
>
> Our client is currently trying to migrate from their current financial 
> software, but one of the configuration options is not present in Fineract. 
> The option changes the way Fineract schedules loan repayments. Instead of 
> rescheduling a repayment to a different day in the week, holidays would 
> reschedule the repayment to the next due date and extend the schedule. For 
> example with a holiday like this http://i.imgur.com/Dl8B3DX.png a loan that 
> has a repayment fall in the holiday will be rescheduled to the next week and 
> the following repayments will be postponed. http://i.imgur.com/l9OfTDm.png 
> With this the loan term is extended and the repayment that landed on a 
> holiday is repaid on the next due date. 
> I already have a proof of concept patch for this, but I think there are some 
> issues with it. As such, I would like to work with a developer to discuss the 
> best way to implement this, or if you would like, we can just figure out why 
> my patch occasionally enters an infinite loop...
> As a related request, the client is looking to have the interest due at this 
> repayment to be redistributed across the full loan schedule. I wasn't sure if 
> I should include this in this issue report or to make a new one that is 
> related to this issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FINERACT-37) Support rescheduling repayments on holidays

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15467008#comment-15467008
 ] 

ASF GitHub Bot commented on FINERACT-37:


Github user nazeer1100126 commented on a diff in the pull request:

https://github.com/apache/incubator-fineract/pull/219#discussion_r77605384
  
--- Diff: 
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/DefaultScheduledDateGenerator.java
 ---
@@ -96,10 +96,33 @@ public LocalDate generateNextRepaymentDate(final 
LocalDate lastRepaymentDate, fi
 loanApplicationTerms.getNumberOfdays());
 }
 }
-
+if (currentCalendar == null && 
holidayDetailDTO.getWorkingDays().getExtendTermForRepaymentsOnHolidays()) {
--- End diff --

if extendTermForRepaymentsOnHolidays is true, why can't we call 
adjustRepaymentDate method  and return that date? 


> Support rescheduling repayments on holidays
> ---
>
> Key: FINERACT-37
> URL: https://issues.apache.org/jira/browse/FINERACT-37
> Project: Apache Fineract
>  Issue Type: Improvement
>  Components: System
>Reporter: James Rowe
>Assignee: Markus Geiss
>
> Our client is currently trying to migrate from their current financial 
> software, but one of the configuration options is not present in Fineract. 
> The option changes the way Fineract schedules loan repayments. Instead of 
> rescheduling a repayment to a different day in the week, holidays would 
> reschedule the repayment to the next due date and extend the schedule. For 
> example with a holiday like this http://i.imgur.com/Dl8B3DX.png a loan that 
> has a repayment fall in the holiday will be rescheduled to the next week and 
> the following repayments will be postponed. http://i.imgur.com/l9OfTDm.png 
> With this the loan term is extended and the repayment that landed on a 
> holiday is repaid on the next due date. 
> I already have a proof of concept patch for this, but I think there are some 
> issues with it. As such, I would like to work with a developer to discuss the 
> best way to implement this, or if you would like, we can just figure out why 
> my patch occasionally enters an infinite loop...
> As a related request, the client is looking to have the interest due at this 
> repayment to be redistributed across the full loan schedule. I wasn't sure if 
> I should include this in this issue report or to make a new one that is 
> related to this issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FINERACT-227) Option For Creating Loan Loss provisioning for total principle outstanding or total outstanding

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15440919#comment-15440919
 ] 

ASF GitHub Bot commented on FINERACT-227:
-

Github user venkatconflux closed the pull request at:

https://github.com/apache/incubator-fineract/pull/221


> Option For Creating Loan Loss provisioning for total principle outstanding or 
> total outstanding
> ---
>
> Key: FINERACT-227
> URL: https://issues.apache.org/jira/browse/FINERACT-227
> Project: Apache Fineract
>  Issue Type: Improvement
>Reporter: venkat Ganesh
>Assignee: Markus Geiss
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FINERACT-227) Option For Creating Loan Loss provisioning for total principle outstanding or total outstanding

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15440862#comment-15440862
 ] 

ASF GitHub Bot commented on FINERACT-227:
-

GitHub user venkatconflux opened a pull request:

https://github.com/apache/incubator-fineract/pull/221

FINERACT-227 : added The option For loan loss provisioning to select …

…total out standing or total principle outstanding

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/venkatconflux/incubator-fineract FINERACT-227

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-fineract/pull/221.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #221


commit 62c20248b3d22f5646707480fa5f13ebbc6323fb
Author: venkatconflux 
Date:   2016-08-27T06:02:47Z

FINERACT-227 : added The option For loan loss provisioning to select total 
out standing or total principle outstanding




> Option For Creating Loan Loss provisioning for total principle outstanding or 
> total outstanding
> ---
>
> Key: FINERACT-227
> URL: https://issues.apache.org/jira/browse/FINERACT-227
> Project: Apache Fineract
>  Issue Type: Improvement
>Reporter: venkat Ganesh
>Assignee: Markus Geiss
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FINERACT-37) Support rescheduling repayments on holidays

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15436741#comment-15436741
 ] 

ASF GitHub Bot commented on FINERACT-37:


GitHub user terencemo opened a pull request:

https://github.com/apache/incubator-fineract/pull/219

FINERACT-37 Reschedule repayment on holidays+extend term

Based on PR #110.
Adds a WorkingDays flag extendTermForRepaymentOnHoliday when this is set
If a repayment occurs on a holiday, shift it to the next repayment date and
extend the loan term by the repayment interval, e.g
if repayment is weekly and one repayment occurs on holiday, move that to 
the next original schedule repayment date and extend loan term by 1 week

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/terencemo/incubator-fineract 
i37-holidays-repayment

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-fineract/pull/219.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #219


commit b478064ac0fe74a7130b9a0c2f07a5ccd30631a5
Author: Terence Denzil Monteiro 
Date:   2016-08-25T12:15:14Z

Reschedule repayment on holidays+extend term




> Support rescheduling repayments on holidays
> ---
>
> Key: FINERACT-37
> URL: https://issues.apache.org/jira/browse/FINERACT-37
> Project: Apache Fineract
>  Issue Type: Improvement
>  Components: System
>Reporter: James Rowe
>Assignee: Markus Geiss
>
> Our client is currently trying to migrate from their current financial 
> software, but one of the configuration options is not present in Fineract. 
> The option changes the way Fineract schedules loan repayments. Instead of 
> rescheduling a repayment to a different day in the week, holidays would 
> reschedule the repayment to the next due date and extend the schedule. For 
> example with a holiday like this http://i.imgur.com/Dl8B3DX.png a loan that 
> has a repayment fall in the holiday will be rescheduled to the next week and 
> the following repayments will be postponed. http://i.imgur.com/l9OfTDm.png 
> With this the loan term is extended and the repayment that landed on a 
> holiday is repaid on the next due date. 
> I already have a proof of concept patch for this, but I think there are some 
> issues with it. As such, I would like to work with a developer to discuss the 
> best way to implement this, or if you would like, we can just figure out why 
> my patch occasionally enters an infinite loop...
> As a related request, the client is looking to have the interest due at this 
> repayment to be redistributed across the full loan schedule. I wasn't sure if 
> I should include this in this issue report or to make a new one that is 
> related to this issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FINERACT-211) Not able to make loan repayment from savings account through standing instructions after executing the scheduler job

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15434737#comment-15434737
 ] 

ASF GitHub Bot commented on FINERACT-211:
-

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-fineract/pull/218


> Not able to make loan repayment from savings account through standing 
> instructions after executing the scheduler job
> 
>
> Key: FINERACT-211
> URL: https://issues.apache.org/jira/browse/FINERACT-211
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Loan
>Reporter: subramanyasn
>Priority: Critical
> Attachments: Standing isntructions.png
>
>
> 1. Create simple loan product with monthly repayment, Create a simple savings 
> product.
> 2. Submit new savings application for a client on 16 May 2016, approve and 
> activate on same date with minimum deposit of 1.
> 3. Create new loan application for the same client with monthly repayment on 
> 16 May 2016.
> 4. Approve and disburse loan on 16 May 2016.
> 5. Create standing instruction for loan repayment from 16 August 2016.
> 6. Click on Admin -> System -> Scheduler job -> Execute standing instructions.
> > Standing instruction is getting failed, please find the attached error log.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FINERACT-211) Not able to make loan repayment from savings account through standing instructions after executing the scheduler job

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15434637#comment-15434637
 ] 

ASF GitHub Bot commented on FINERACT-211:
-

GitHub user rajuan opened a pull request:

https://github.com/apache/incubator-fineract/pull/218

[FINERACT-211] Corrected code to avoid detached entity persist exception



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rajuan/incubator-fineract FINERACT-211

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-fineract/pull/218.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #218


commit ff58f74d79e5ac62e304c00624fa9497e4ff1df9
Author: Adi Narayana Raju 
Date:   2016-08-24T10:05:21Z

[FINERACT-211] Corrected code to avoid detached entity persist exception




> Not able to make loan repayment from savings account through standing 
> instructions after executing the scheduler job
> 
>
> Key: FINERACT-211
> URL: https://issues.apache.org/jira/browse/FINERACT-211
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Loan
>Reporter: subramanyasn
>Priority: Critical
> Attachments: Standing isntructions.png
>
>
> 1. Create simple loan product with monthly repayment, Create a simple savings 
> product.
> 2. Submit new savings application for a client on 16 May 2016, approve and 
> activate on same date with minimum deposit of 1.
> 3. Create new loan application for the same client with monthly repayment on 
> 16 May 2016.
> 4. Approve and disburse loan on 16 May 2016.
> 5. Create standing instruction for loan repayment from 16 August 2016.
> 6. Click on Admin -> System -> Scheduler job -> Execute standing instructions.
> > Standing instruction is getting failed, please find the attached error log.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FINERACT-223) In topup loan if the "Choose loan to close" is selected in modified loan product then internal server error is displaying.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15432337#comment-15432337
 ] 

ASF GitHub Bot commented on FINERACT-223:
-

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-fineract/pull/217


>  In topup loan if the "Choose loan to close" is selected in modified loan 
> product then internal server error is displaying.
> ---
>
> Key: FINERACT-223
> URL: https://issues.apache.org/jira/browse/FINERACT-223
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Loan
>Reporter: subramanyasn
>Assignee: Markus Geiss
>
> 1. Create a loan product with top up enabled and disburse for a client on 01 
> July 2015.
> 2. Click on the same client and submit new loan application with above loan 
> product.
> 3. Click on modify application and check check box "Is Topup Loan?" and " 
> Choose loan to close" as above disbursed loan, and submit this loan 
> application on 01 August 2016.
> > Not able to save the page displays internal server error.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FINERACT-223) In topup loan if the "Choose loan to close" is selected in modified loan product then internal server error is displaying.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15432327#comment-15432327
 ] 

ASF GitHub Bot commented on FINERACT-223:
-

GitHub user rajuan opened a pull request:

https://github.com/apache/incubator-fineract/pull/217

[FINERACT-223] In topup loan if the "Choose loan to close" is selecte…

…d in modified loan product then internal server error is displaying.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rajuan/incubator-fineract FINERACT-223

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-fineract/pull/217.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #217






>  In topup loan if the "Choose loan to close" is selected in modified loan 
> product then internal server error is displaying.
> ---
>
> Key: FINERACT-223
> URL: https://issues.apache.org/jira/browse/FINERACT-223
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Loan
>Reporter: subramanyasn
>Assignee: Markus Geiss
>
> 1. Create a loan product with top up enabled and disburse for a client on 01 
> July 2015.
> 2. Click on the same client and submit new loan application with above loan 
> product.
> 3. Click on modify application and check check box "Is Topup Loan?" and " 
> Choose loan to close" as above disbursed loan, and submit this loan 
> application on 01 August 2016.
> > Not able to save the page displays internal server error.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FINERACT-212) In Modify loan application able to reduce loan amount than existing loan(added for topup)

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15430323#comment-15430323
 ] 

ASF GitHub Bot commented on FINERACT-212:
-

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-fineract/pull/216


> In Modify loan application able to reduce loan amount than existing 
> loan(added for topup)
> -
>
> Key: FINERACT-212
> URL: https://issues.apache.org/jira/browse/FINERACT-212
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Loan
>Reporter: subramanyasn
>Assignee: Markus Geiss
>
> 1. Create loan product with topup option.
> 2. Submit new loan application for a client with above loan product, approve 
> and disburse loan on 01 August 2016 with amount of 1. (assume interest 
> accumulated as 600 total)
> 3. Submit another loan application for the same client with above loan 
> product with 11000, and while submitting the application select loan account 
> as mentioned in point no. 2.
> 4. Click on modify the loan application and change principal amount to 1. 
> > It is allowing to submit the modify application page though the principal 
> > amount is less than the amount required to close the previous loan.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FINERACT-214) Not able to reschedule loan if the overdue charge is applied

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15430286#comment-15430286
 ] 

ASF GitHub Bot commented on FINERACT-214:
-

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-fineract/pull/214


> Not able to reschedule loan if the overdue charge is applied 
> -
>
> Key: FINERACT-214
> URL: https://issues.apache.org/jira/browse/FINERACT-214
> Project: Apache Fineract
>  Issue Type: Bug
>Reporter: subramanyasn
>Assignee: Markus Geiss
>Priority: Critical
> Attachments: Rescheduling Loan.png
>
>
> 1. Create loan product without interest recalculation add overdue charge of 
> 100 flat,
> 2. Submit new loan application for a client on 01 January 2016 approve and 
> disburse on same date.
> 3. Execute scheduler  job 'apply penalty for overdue loans'.
> 4. Navigate back to the above loan account, click on more and click on 
> rescheduling.
> 5. In Loan rescheduling page change repayment date from 01 Feb 2016 to 10 Feb 
> 2016 -> Click on Submit -> Click on approve
> >Not able to approve displayed Internal server error



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FINERACT-212) In Modify loan application able to reduce loan amount than existing loan(added for topup)

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15430213#comment-15430213
 ] 

ASF GitHub Bot commented on FINERACT-212:
-

GitHub user rajuan opened a pull request:

https://github.com/apache/incubator-fineract/pull/216

[FINERACT-212] & [FINERACT-216] & [FINERACT-218] & Correction of error 
messages on loan to be closed status and application submitted date



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rajuan/incubator-fineract topupissues

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-fineract/pull/216.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #216


commit bf48c97de30707ad6d45153e69eb3be111834924
Author: Adi Narayana Raju 
Date:   2016-08-22T07:05:19Z

[FINERACT-212] & [FINERACT-216] & [FINERACT-218] & Correction of error 
messages on loan to be closed status and application submitted date




> In Modify loan application able to reduce loan amount than existing 
> loan(added for topup)
> -
>
> Key: FINERACT-212
> URL: https://issues.apache.org/jira/browse/FINERACT-212
> Project: Apache Fineract
>  Issue Type: Bug
>  Components: Loan
>Reporter: subramanyasn
>Assignee: Markus Geiss
>
> 1. Create loan product with topup option.
> 2. Submit new loan application for a client with above loan product, approve 
> and disburse loan on 01 August 2016 with amount of 1. (assume interest 
> accumulated as 600 total)
> 3. Submit another loan application for the same client with above loan 
> product with 11000, and while submitting the application select loan account 
> as mentioned in point no. 2.
> 4. Click on modify the loan application and change principal amount to 1. 
> > It is allowing to submit the modify application page though the principal 
> > amount is less than the amount required to close the previous loan.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FINERACT-215) For equal principal payment not able to reschedule the loan with extend number of repayments

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15430195#comment-15430195
 ] 

ASF GitHub Bot commented on FINERACT-215:
-

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-fineract/pull/213


> For equal principal payment not able to reschedule the loan with extend 
> number of repayments
> 
>
> Key: FINERACT-215
> URL: https://issues.apache.org/jira/browse/FINERACT-215
> Project: Apache Fineract
>  Issue Type: Bug
>Reporter: subramanyasn
>Assignee: Markus Geiss
>Priority: Critical
> Attachments: Extend repayments.png
>
>
> 1. Create loan product without interest recalculation add overdue charge of 
> 100 flat,
> 2. Submit new loan application for a client on 01 January 2016 approve and 
> disburse on same date.
> 4. Navigate back to the above loan account, click on more and click on 
> rescheduling.
> 5. In Loan rescheduling page change repayment date from 01 Feb 2016 to extend 
> number of repayment 5 -> Click on Submit -> Click on approve
> 6. Click on repayment schedule in which the number of repayments should get 
> extended by 5 more repayments, but only 1 repayment is getting added to the 
> last installment.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FINERACT-72) Speed up the retrieval of journal entries when "transactionDetails" is set to true

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15418347#comment-15418347
 ] 

ASF GitHub Bot commented on FINERACT-72:


Github user nazeer1100126 commented on a diff in the pull request:

https://github.com/apache/incubator-fineract/pull/199#discussion_r74540135
  
--- Diff: 
fineract-provider/src/main/java/org/apache/fineract/accounting/journalentry/service/AccountingProcessorHelper.java
 ---
@@ -820,11 +820,12 @@ private void createCreditJournalEntryForSavings(final 
Office office, final Strin
 SavingsAccountTransaction savingsAccountTransaction = null;
 ClientTransaction clientTransaction = null;
 final Long shareTransactionId = null;
-final PaymentDetail paymentDetail = null;
+PaymentDetail paymentDetail = null;
 String modifiedTransactionId = transactionId;
 if (StringUtils.isNumeric(transactionId)) {
 long id = Long.parseLong(transactionId);
 savingsAccountTransaction = 
this.savingsAccountTransactionRepository.findOne(id);
+paymentDetail = 
this.savingsAccountTransactionRepository.findOne(id).getPaymentDetail();
--- End diff --

unnecessary repository call.  You can make use of savingsAccountTransaction 
object to retrieve payment details 


> Speed up the retrieval of journal entries when "transactionDetails" is set to 
> true
> --
>
> Key: FINERACT-72
> URL: https://issues.apache.org/jira/browse/FINERACT-72
> Project: Apache Fineract
>  Issue Type: Improvement
>Reporter: Emmanuel Nnaa
>Assignee: Markus Geiss
>
> It takes a little over 3 minutes to retrieve about 360 journal entries if the 
> "transactionDetails" parameter is set to true.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FINERACT-65) Implement ability to schedule & e-mail reports

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-65?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15418312#comment-15418312
 ] 

ASF GitHub Bot commented on FINERACT-65:


Github user asfgit closed the pull request at:

https://github.com/apache/incubator-fineract/pull/197


> Implement ability to schedule & e-mail reports
> --
>
> Key: FINERACT-65
> URL: https://issues.apache.org/jira/browse/FINERACT-65
> Project: Apache Fineract
>  Issue Type: New Feature
>Reporter: Emmanuel Nnaa
>Assignee: Markus Geiss
>Priority: Minor
>
> Some reports take a bit longer to run, therefore we should be able to allow 
> our users to schedule them overnight to be e-mailed. 
> The way this should work is:
> - Add e-mailaddress to users and make it mandatory (possibly already in 
> MifosX)
> - Allow users to configure schedule entries which consist of:
> - One or multiple target users (e-mailaddresses)
> - Set the preferred subject and content of the e-mail (Look at user generated 
> documents API in MifosX for replacing certain variables)
> - Choose the run frequency of the report (daily, weekly, every x'th day of 
> the month etc, cron-like flexibility with a UI)
> - Pick the preferred output format (PDF/XLS/CSV)
> These reports should be picked up by a scheduled job overnight and then run 
> in serial to avoid performance hits and sent out to the users.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FINERACT-72) Speed up the retrieval of journal entries when "transactionDetails" is set to true

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411863#comment-15411863
 ] 

ASF GitHub Bot commented on FINERACT-72:


GitHub user emmanuelnnaa opened a pull request:

https://github.com/apache/incubator-fineract/pull/199

commit for FINERACT-72 (Speed up the retrieval of journal entries when 
'transactionDetails' is set to true)



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/emmanuelnnaa/incubator-fineract FINERACT-72

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-fineract/pull/199.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #199


commit 1dc59e29a790f1246b39f084bfff9816db50659e
Author: Emmanuel Nnaa 
Date:   2016-08-08T14:20:13Z

commit for FINERACT-72 (Speed up the retrieval of journal entries when 
'transactionDetails' is set to true)




> Speed up the retrieval of journal entries when "transactionDetails" is set to 
> true
> --
>
> Key: FINERACT-72
> URL: https://issues.apache.org/jira/browse/FINERACT-72
> Project: Apache Fineract
>  Issue Type: Improvement
>Reporter: Emmanuel Nnaa
>Assignee: Markus Geiss
>
> It takes a little over 3 minutes to retrieve about 360 journal entries if the 
> "transactionDetails" parameter is set to true.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FINERACT-71) "AuditReadPlatformServiceImpl.retrieveEntries" returns duplicate results for users without the "ALL_FUNCTIONS" and "CHECKER_SUPER_USER" permissions.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FINERACT-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411758#comment-15411758
 ] 

ASF GitHub Bot commented on FINERACT-71:


GitHub user emmanuelnnaa opened a pull request:

https://github.com/apache/incubator-fineract/pull/198

commit for FINERACT-71 ('AuditReadPlatformServiceImpl.retrieveEntries' 
returns duplicate results for users without the 'ALL_FUNCTIONS' and 
'CHECKER_SUPER_USER' permissions.)



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/emmanuelnnaa/incubator-fineract FINERACT-71

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-fineract/pull/198.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #198


commit 4cfd56fa927e90f1666fe3e66b57032cf7a1aafd
Author: Emmanuel Nnaa 
Date:   2016-08-08T12:49:52Z

commit for FINERACT-71 ('AuditReadPlatformServiceImpl.retrieveEntries' 
returns duplicate results for users without the 'ALL_FUNCTIONS' and 
'CHECKER_SUPER_USER' permissions.)




> "AuditReadPlatformServiceImpl.retrieveEntries" returns duplicate results for 
> users without the "ALL_FUNCTIONS" and "CHECKER_SUPER_USER" permissions.
> 
>
> Key: FINERACT-71
> URL: https://issues.apache.org/jira/browse/FINERACT-71
> Project: Apache Fineract
>  Issue Type: Bug
>Reporter: Emmanuel Nnaa
>Assignee: Markus Geiss
>Priority: Minor
>
> "AuditReadPlatformServiceImpl.retrieveEntries" returns duplicate results for 
> users without the "ALL_FUNCTIONS" and "CHECKER_SUPER_USER" permissions.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)