[jira] [Commented] (GEODE-265) Remove deprecated methods on Execution interface

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16037319#comment-16037319
 ] 

ASF GitHub Bot commented on GEODE-265:
--

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/509


> Remove deprecated methods on Execution interface
> 
>
> Key: GEODE-265
> URL: https://issues.apache.org/jira/browse/GEODE-265
> Project: Geode
>  Issue Type: Sub-task
>Reporter: Darrel Schneider
>Assignee: Deepak Dixit
>   Original Estimate: 5h
>  Remaining Estimate: 5h
>
> The Execution interface has a number of execute methods that have been 
> deprecated. It looks like these could be easily removed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-194) Geode Spark Connector does not support Spark 2.0

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16037257#comment-16037257
 ] 

ASF GitHub Bot commented on GEODE-194:
--

Github user jhuynh1 commented on the issue:

https://github.com/apache/geode/pull/558
  
Looks good to me


> Geode Spark Connector does not support Spark 2.0
> 
>
> Key: GEODE-194
> URL: https://issues.apache.org/jira/browse/GEODE-194
> Project: Geode
>  Issue Type: Bug
>  Components: extensions
>Reporter: Jianxia Chen
>  Labels: experimental, gsoc2016
>
> The BasicIntegrationTest fails when using spark 1.4. e.g.
> [info] - GemFire OQL query with more complex UDT: Partitioned Region *** 
> FAILED ***
> [info]   org.apache.spark.SparkException: Job aborted due to stage failure: 
> Task 0 in stage 24.0 failed 1 times, most recent failure: Lost task 0.0 in 
> stage 24.0 (TID 48, localhost): scala.MatchError: 
> [info]Portfolio [id=3 status=active type=type3
> [info]AOL:Position [secId=AOL qty=978.0 mktValue=40.373], 
> [info]MSFT:Position [secId=MSFT qty=98327.0 mktValue=23.32]] 
> (of class ittest.io.pivotal.gemfire.spark.connector.Portfolio)
> [info]at 
> org.apache.spark.sql.catalyst.CatalystTypeConverters$$anonfun$createToCatalystConverter$4.apply(CatalystTypeConverters.scala:178)
> [info]at 
> org.apache.spark.sql.execution.RDDConversions$$anonfun$rowToRowRdd$1$$anonfun$apply$2.apply(ExistingRDD.scala:62)
> [info]at 
> org.apache.spark.sql.execution.RDDConversions$$anonfun$rowToRowRdd$1$$anonfun$apply$2.apply(ExistingRDD.scala:59)
> [info]at scala.collection.Iterator$$anon$11.next(Iterator.scala:328)
> [info]at scala.collection.Iterator$$anon$11.next(Iterator.scala:328)
> [info]at scala.collection.Iterator$class.foreach(Iterator.scala:727)
> [info]at 
> scala.collection.AbstractIterator.foreach(Iterator.scala:1157)
> [info]at 
> scala.collection.generic.Growable$class.$plus$plus$eq(Growable.scala:48)
> [info]at 
> scala.collection.mutable.ArrayBuffer.$plus$plus$eq(ArrayBuffer.scala:103)
> [info]at 
> scala.collection.mutable.ArrayBuffer.$plus$plus$eq(ArrayBuffer.scala:47)
> [info]at 
> scala.collection.TraversableOnce$class.to(TraversableOnce.scala:273)
> [info]at scala.collection.AbstractIterator.to(Iterator.scala:1157)
> [info]at 
> scala.collection.TraversableOnce$class.toBuffer(TraversableOnce.scala:265)
> [info]at 
> scala.collection.AbstractIterator.toBuffer(Iterator.scala:1157)
> [info]at 
> scala.collection.TraversableOnce$class.toArray(TraversableOnce.scala:252)
> [info]at 
> scala.collection.AbstractIterator.toArray(Iterator.scala:1157)
> [info]at 
> org.apache.spark.rdd.RDD$$anonfun$collect$1$$anonfun$12.apply(RDD.scala:885)
> [info]at 
> org.apache.spark.rdd.RDD$$anonfun$collect$1$$anonfun$12.apply(RDD.scala:885)
> [info]at 
> org.apache.spark.SparkContext$$anonfun$runJob$5.apply(SparkContext.scala:1765)
> [info]at 
> org.apache.spark.SparkContext$$anonfun$runJob$5.apply(SparkContext.scala:1765)
> [info]at 
> org.apache.spark.scheduler.ResultTask.runTask(ResultTask.scala:63)
> [info]at org.apache.spark.scheduler.Task.run(Task.scala:70)
> [info]at 
> org.apache.spark.executor.Executor$TaskRunner.run(Executor.scala:213)
> [info]at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> [info]at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> [info]at java.lang.Thread.run(Thread.java:745)
> [info] 
> [info] Driver stacktrace:
> [info]   at 
> org.apache.spark.scheduler.DAGScheduler.org$apache$spark$scheduler$DAGScheduler$$failJobAndIndependentStages(DAGScheduler.scala:1266)
> [info]   at 
> org.apache.spark.scheduler.DAGScheduler$$anonfun$abortStage$1.apply(DAGScheduler.scala:1257)
> [info]   at 
> org.apache.spark.scheduler.DAGScheduler$$anonfun$abortStage$1.apply(DAGScheduler.scala:1256)
> [info]   at 
> scala.collection.mutable.ResizableArray$class.foreach(ResizableArray.scala:59)
> [info]   at scala.collection.mutable.ArrayBuffer.foreach(ArrayBuffer.scala:47)
> [info]   at 
> org.apache.spark.scheduler.DAGScheduler.abortStage(DAGScheduler.scala:1256)
> [info]   at 
> org.apache.spark.scheduler.DAGScheduler$$anonfun$handleTaskSetFailed$1.apply(DAGScheduler.scala:730)
> [info]   at 
> org.apache.spark.scheduler.DAGScheduler$$anonfun$handleTaskSetFailed$1.apply(DAGScheduler.scala:730)
> [info]   at scala.Option.foreach(Option.scala:236)
> [info]   at 
> org.apache.spark.scheduler.DAGScheduler.handleTaskSetFailed(DAGScheduler.scala:730)
> [info]   ...



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-194) Geode Spark Connector does not support Spark 2.0

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16037209#comment-16037209
 ] 

ASF GitHub Bot commented on GEODE-194:
--

GitHub user metatype opened a pull request:

https://github.com/apache/geode/pull/558

GEODE-194: Remove spark connector

Remove the spark connector code until it can be updated
for the current spark release. We should also integrate
the build lifecycle and consider how to extract this into
a separate reo.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [X] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [X] Is your initial contribution a single, squashed commit?

- [X] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/metatype/incubator-geode remove-spark

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/558.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #558


commit d95993b944d706baeb0c5e6c13a7d00754159123
Author: Anthony Baker 
Date:   2017-05-06T00:00:02Z

GEODE-194: Remove spark connector

Remove the spark connector code until it can be updated
for the current spark release. We should also integrate
the build lifecycle and consider how to extract this into
a separate reo.




> Geode Spark Connector does not support Spark 2.0
> 
>
> Key: GEODE-194
> URL: https://issues.apache.org/jira/browse/GEODE-194
> Project: Geode
>  Issue Type: Bug
>  Components: extensions
>Reporter: Jianxia Chen
>  Labels: experimental, gsoc2016
>
> The BasicIntegrationTest fails when using spark 1.4. e.g.
> [info] - GemFire OQL query with more complex UDT: Partitioned Region *** 
> FAILED ***
> [info]   org.apache.spark.SparkException: Job aborted due to stage failure: 
> Task 0 in stage 24.0 failed 1 times, most recent failure: Lost task 0.0 in 
> stage 24.0 (TID 48, localhost): scala.MatchError: 
> [info]Portfolio [id=3 status=active type=type3
> [info]AOL:Position [secId=AOL qty=978.0 mktValue=40.373], 
> [info]MSFT:Position [secId=MSFT qty=98327.0 mktValue=23.32]] 
> (of class ittest.io.pivotal.gemfire.spark.connector.Portfolio)
> [info]at 
> org.apache.spark.sql.catalyst.CatalystTypeConverters$$anonfun$createToCatalystConverter$4.apply(CatalystTypeConverters.scala:178)
> [info]at 
> org.apache.spark.sql.execution.RDDConversions$$anonfun$rowToRowRdd$1$$anonfun$apply$2.apply(ExistingRDD.scala:62)
> [info]at 
> org.apache.spark.sql.execution.RDDConversions$$anonfun$rowToRowRdd$1$$anonfun$apply$2.apply(ExistingRDD.scala:59)
> [info]at scala.collection.Iterator$$anon$11.next(Iterator.scala:328)
> [info]at scala.collection.Iterator$$anon$11.next(Iterator.scala:328)
> [info]at scala.collection.Iterator$class.foreach(Iterator.scala:727)
> [info]at 
> scala.collection.AbstractIterator.foreach(Iterator.scala:1157)
> [info]at 
> scala.collection.generic.Growable$class.$plus$plus$eq(Growable.scala:48)
> [info]at 
> scala.collection.mutable.ArrayBuffer.$plus$plus$eq(ArrayBuffer.scala:103)
> [info]at 
> scala.collection.mutable.ArrayBuffer.$plus$plus$eq(ArrayBuffer.scala:47)
> [info]at 
> scala.collection.TraversableOnce$class.to(TraversableOnce.scala:273)
> [info]at scala.collection.AbstractIterator.to(Iterator.scala:1157)
> [info]at 
> scala.collection.TraversableOnce$class.toBuffer(TraversableOnce.scala:265)
> [info]at 
> scala.collection.AbstractIterator.toBuffer(Iterator.scala:1157)
> [info]at 
> scala.collection.TraversableOnce$class.toArray(TraversableOnce.scala:252)
> [info]at 
> 

[jira] [Commented] (GEODE-2818) add alias to any command's options that involves "group", "member", "jar"

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16037106#comment-16037106
 ] 

ASF GitHub Bot commented on GEODE-2818:
---

Github user YehEmily commented on a diff in the pull request:

https://github.com/apache/geode/pull/548#discussion_r120137950
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommands.java
 ---
@@ -412,7 +411,7 @@ public Result compactDiskStore(
   @CliOption(key = CliStrings.COMPACT_DISK_STORE__NAME, mandatory = 
true,
   optionContext = ConverterHint.DISKSTORE,
   help = CliStrings.COMPACT_DISK_STORE__NAME__HELP) String 
diskStoreName,
-  @CliOption(key = CliStrings.COMPACT_DISK_STORE__GROUP,
+  @CliOption(key = CliStrings.GROUP,
--- End diff --

Sure thing! I'll update the PR once this is done!


> add alias to any command's options that involves "group", "member", "jar"
> -
>
> Key: GEODE-2818
> URL: https://issues.apache.org/jira/browse/GEODE-2818
> Project: Geode
>  Issue Type: New Feature
>  Components: docs, gfsh
>Reporter: Jinmei Liao
>Assignee: Emily Yeh
>
> Or anything that would have confusion about if we are going to use singular 
> or plural at all.
> 1) add alias for those options
> 2) make sure it parameter type is an array type, some method only accepts a 
> string and split it inside the command.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2818) add alias to any command's options that involves "group", "member", "jar"

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16037092#comment-16037092
 ] 

ASF GitHub Bot commented on GEODE-2818:
---

Github user jinmeiliao commented on a diff in the pull request:

https://github.com/apache/geode/pull/548#discussion_r120134823
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommands.java
 ---
@@ -412,7 +411,7 @@ public Result compactDiskStore(
   @CliOption(key = CliStrings.COMPACT_DISK_STORE__NAME, mandatory = 
true,
   optionContext = ConverterHint.DISKSTORE,
   help = CliStrings.COMPACT_DISK_STORE__NAME__HELP) String 
diskStoreName,
-  @CliOption(key = CliStrings.COMPACT_DISK_STORE__GROUP,
+  @CliOption(key = CliStrings.GROUP,
--- End diff --

looks like this can have "groups" as synonym as well. Can you go through 
all your changes and make sure that member/group CliOption that take String[] 
as the option type needs to have synonym defined. Thanks!


> add alias to any command's options that involves "group", "member", "jar"
> -
>
> Key: GEODE-2818
> URL: https://issues.apache.org/jira/browse/GEODE-2818
> Project: Geode
>  Issue Type: New Feature
>  Components: docs, gfsh
>Reporter: Jinmei Liao
>Assignee: Emily Yeh
>
> Or anything that would have confusion about if we are going to use singular 
> or plural at all.
> 1) add alias for those options
> 2) make sure it parameter type is an array type, some method only accepts a 
> string and split it inside the command.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2981) Fix the line feed code of the test expected value

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16037069#comment-16037069
 ] 

ASF GitHub Bot commented on GEODE-2981:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/530


> Fix the line feed code of the test expected value
> -
>
> Key: GEODE-2981
> URL: https://issues.apache.org/jira/browse/GEODE-2981
> Project: Geode
>  Issue Type: Test
>  Components: management, tests
>Reporter: Masaki Yamakawa
>Priority: Minor
>
> I mainly use the Windows. When I run the test on Windows, because Assertion 
> fails due to the difference in line feed code, I want to change this so that 
> it does not depend on the runtime environment.
> The target classes are as follows:
> - org.apache.geode.management.internal.cli.shell.GfshJunitTest
> - org.apache.geode.management.internal.cli.help.HelpBlockUnitTest
> - org.apache.geode.management.internal.cli.help.HelperUnitTest



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-3028) Fix the expected value of the test that depended on Locale

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16036284#comment-16036284
 ] 

ASF GitHub Bot commented on GEODE-3028:
---

GitHub user masaki-yamakawa opened a pull request:

https://github.com/apache/geode/pull/556

GEODE-3028: Fix the expected value of the test that depended on Locale

Fix the test that uses the English message as the expected value so that it 
does not depend on the locale at runtime environment.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [X] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [X] Is your initial contribution a single, squashed commit?

- [X] Does `gradlew build` run cleanly?

- [X] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/masaki-yamakawa/geode feature/GEODE-3028

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/556.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #556


commit 0ee38f3ac60d50d16297343a330024e4c8afc133
Author: masaki.yamakawa 
Date:   2017-05-28T23:17:10Z

GEODE-3028: Fix the expected value of the test that depended on Locale

Fix the test that uses the English message as the expected value so that
it does not depend on the locale at runtime environment.




> Fix the expected value of the test that depended on Locale
> --
>
> Key: GEODE-3028
> URL: https://issues.apache.org/jira/browse/GEODE-3028
> Project: Geode
>  Issue Type: Test
>  Components: tests
>Reporter: Masaki Yamakawa
>Priority: Minor
>
> I am testing in Japanese environment. Running the test in the Japanese 
> environment will cause the Assertion to fail due to the difference in Locale, 
> so I want to change this so that it does not depend on the runtime 
> environment.
> The target classes are as follows:
> - 
> org.apache.geode.distributed.internal.membership.gms.auth.GMSAuthenticatorWithAuthenticatorTest
> - 
> org.apache.geode.distributed.internal.membership.gms.auth.GMSAuthenticatorWithSecurityManagerTest
> - org.apache.geode.internal.cache.tier.sockets.ServerConnectionTest
> - org.apache.geode.internal.cache.ColocationHelperTest



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2947) Improve error message (seen in gfsh) when attempting to destroy a region before destroying lucene indexes

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16035526#comment-16035526
 ] 

ASF GitHub Bot commented on GEODE-2947:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/555


> Improve error message (seen in gfsh) when attempting to destroy a region 
> before destroying lucene indexes
> -
>
> Key: GEODE-2947
> URL: https://issues.apache.org/jira/browse/GEODE-2947
> Project: Geode
>  Issue Type: Bug
>  Components: docs, lucene
>Affects Versions: 1.2.0
>Reporter: Shelley Lynn Hughes-Godfrey
>Assignee: Karen Smoler Miller
> Fix For: 1.2.0
>
>
> If a user attempta to destroy region before destroying the lucene index (via 
> gfsh), the error message returned is not clear.  It should state that the 
> lucene index should be destroyed prior to destroying the region.  
> Instead it states this:
> {noformat}
> Error occurred while destroying region "testRegion". Reason: The parent 
> region [/testRegion] in colocation chain cannot be destroyed, unless all its 
> children [[/testIndex#_testRegion.files]] are destroyed
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2947) Improve error message (seen in gfsh) when attempting to destroy a region before destroying lucene indexes

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16035182#comment-16035182
 ] 

ASF GitHub Bot commented on GEODE-2947:
---

Github user dihardman commented on the issue:

https://github.com/apache/geode/pull/555
  
+1 Looks good. Thanks!

On Fri, Jun 2, 2017 at 9:26 AM, Karen Miller 
wrote:

> @dihardman  @boglesby
>  @ladyVader 
> Please review.
> --
> You can view, comment on, or merge this pull request online at:
>
>   https://github.com/apache/geode/pull/555
> Commit Summary
>
>- GEODE-2947: Document revised gfsh destroy error message
>
> File Changes
>
>- *M* geode-docs/tools_modules/lucene_integration.html.md.erb
> (5)
>
> Patch Links:
>
>- https://github.com/apache/geode/pull/555.patch
>- https://github.com/apache/geode/pull/555.diff
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> , or mute the thread
> 

> .
>



> Improve error message (seen in gfsh) when attempting to destroy a region 
> before destroying lucene indexes
> -
>
> Key: GEODE-2947
> URL: https://issues.apache.org/jira/browse/GEODE-2947
> Project: Geode
>  Issue Type: Bug
>  Components: docs, lucene
>Affects Versions: 1.2.0
>Reporter: Shelley Lynn Hughes-Godfrey
>Assignee: Karen Smoler Miller
> Fix For: 1.2.0
>
>
> If a user attempta to destroy region before destroying the lucene index (via 
> gfsh), the error message returned is not clear.  It should state that the 
> lucene index should be destroyed prior to destroying the region.  
> Instead it states this:
> {noformat}
> Error occurred while destroying region "testRegion". Reason: The parent 
> region [/testRegion] in colocation chain cannot be destroyed, unless all its 
> children [[/testIndex#_testRegion.files]] are destroyed
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2444) Making Redis Adapter easier to use and more robust

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16035033#comment-16035033
 ] 

ASF GitHub Bot commented on GEODE-2444:
---

Github user kohlmu-pivotal commented on the issue:

https://github.com/apache/geode/pull/404
  
@yhilem @ggreen @bbaynes, there is currently a feature branch 
https://github.com/apache/geode/tree/feature/GEODE-2444, which started 
splitting the Redis Adapter into its own module.
I would prefer this splitting of the Redis adapter into its own module to 
be part of the integration.


> Making Redis Adapter easier to use and more robust
> --
>
> Key: GEODE-2444
> URL: https://issues.apache.org/jira/browse/GEODE-2444
> Project: Geode
>  Issue Type: Wish
>  Components: redis
>Reporter: Addison
>
> The goal of this effort is to further test and complete the Redis Adapter to 
> make the code more readable and performant. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2981) Fix the line feed code of the test expected value

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16035030#comment-16035030
 ] 

ASF GitHub Bot commented on GEODE-2981:
---

Github user jaredjstewart commented on the issue:

https://github.com/apache/geode/pull/530
  
Thank you for your contribution, looks good to me!


> Fix the line feed code of the test expected value
> -
>
> Key: GEODE-2981
> URL: https://issues.apache.org/jira/browse/GEODE-2981
> Project: Geode
>  Issue Type: Test
>  Components: management, tests
>Reporter: Masaki Yamakawa
>Priority: Minor
>
> I mainly use the Windows. When I run the test on Windows, because Assertion 
> fails due to the difference in line feed code, I want to change this so that 
> it does not depend on the runtime environment.
> The target classes are as follows:
> - org.apache.geode.management.internal.cli.shell.GfshJunitTest
> - org.apache.geode.management.internal.cli.help.HelpBlockUnitTest
> - org.apache.geode.management.internal.cli.help.HelperUnitTest



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2981) Fix the line feed code of the test expected value

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16035027#comment-16035027
 ] 

ASF GitHub Bot commented on GEODE-2981:
---

Github user jinmeiliao commented on the issue:

https://github.com/apache/geode/pull/530
  
will pull this in after testing


> Fix the line feed code of the test expected value
> -
>
> Key: GEODE-2981
> URL: https://issues.apache.org/jira/browse/GEODE-2981
> Project: Geode
>  Issue Type: Test
>  Components: management, tests
>Reporter: Masaki Yamakawa
>Priority: Minor
>
> I mainly use the Windows. When I run the test on Windows, because Assertion 
> fails due to the difference in line feed code, I want to change this so that 
> it does not depend on the runtime environment.
> The target classes are as follows:
> - org.apache.geode.management.internal.cli.shell.GfshJunitTest
> - org.apache.geode.management.internal.cli.help.HelpBlockUnitTest
> - org.apache.geode.management.internal.cli.help.HelperUnitTest



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2947) Improve error message (seen in gfsh) when attempting to destroy a region before destroying lucene indexes

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16034996#comment-16034996
 ] 

ASF GitHub Bot commented on GEODE-2947:
---

GitHub user karensmolermiller opened a pull request:

https://github.com/apache/geode/pull/555

GEODE-2947: Document revised gfsh destroy error message

@dihardman @boglesby @ladyVader Please review.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/karensmolermiller/geode feature/GEODE-2947

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/555.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #555






> Improve error message (seen in gfsh) when attempting to destroy a region 
> before destroying lucene indexes
> -
>
> Key: GEODE-2947
> URL: https://issues.apache.org/jira/browse/GEODE-2947
> Project: Geode
>  Issue Type: Bug
>  Components: docs, lucene
>Affects Versions: 1.2.0
>Reporter: Shelley Lynn Hughes-Godfrey
>Assignee: Karen Smoler Miller
> Fix For: 1.2.0
>
>
> If a user attempta to destroy region before destroying the lucene index (via 
> gfsh), the error message returned is not clear.  It should state that the 
> lucene index should be destroyed prior to destroying the region.  
> Instead it states this:
> {noformat}
> Error occurred while destroying region "testRegion". Reason: The parent 
> region [/testRegion] in colocation chain cannot be destroyed, unless all its 
> children [[/testIndex#_testRegion.files]] are destroyed
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2935) Add Events link to Geode site footer

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16034953#comment-16034953
 ] 

ASF GitHub Bot commented on GEODE-2935:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode-site/pull/3


> Add Events link to Geode site footer
> 
>
> Key: GEODE-2935
> URL: https://issues.apache.org/jira/browse/GEODE-2935
> Project: Geode
>  Issue Type: Task
>  Components: web-content
>Reporter: Joey McAllister
>Assignee: Joey McAllister
>Priority: Minor
>  Labels: website
>
> From [~mbretl]:
> {quote}
> ASF has created a new tool for scanning TLP sites for compliance and other
> requests. The new tool is located at https://whimsy.apache.org/site, with our 
> own Geode report at https://whimsy.apache.org/site/project/geode. The report 
> looks good, with only one missing requirement of an Events page.
> When I searched for 'event' on the [source of the 
> tool|https://gitbox.apache.org/repos/asf?p=whimsy.git;a=blob_plain;f=tools/site-scan.rb;hb=HEAD],
>  I found http://www.apache.org/events/README.txt, with more event information.
> However, looking at the code, it is searching for: 'apache.org/events/'. So
> we can either create the link as text or use the image as a link.
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-3014) Document gfsh create lucene index and region failure sequence

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16033275#comment-16033275
 ] 

ASF GitHub Bot commented on GEODE-3014:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/554


> Document gfsh create lucene index and region failure sequence
> -
>
> Key: GEODE-3014
> URL: https://issues.apache.org/jira/browse/GEODE-3014
> Project: Geode
>  Issue Type: Bug
>  Components: docs
>Reporter: Barry Oglesby
>Assignee: Karen Smoler Miller
>
> When creating a lucene index and region using gfsh, there is a specific 
> command sequence that causes the region to not be created successfully.
> The sequence that fails is:
> - start server(s)
> - create lucene index
> - start additional server(s)
> - create region
> What fails about this sequence is the lucene index is not saved in cluster 
> configuration until after the region is created. Before the region is 
> created, its only saved locally in existing servers. Since new servers don't 
> have the index when the region is created, the index definitions aren't 
> consistent across servers. This causes the region to be created only in some 
> servers (either all the original ones with the index or all the new ones 
> without the index).
> An alternate sequence that succeeds is:
> - start server(s)
> - create lucene index
> - create region
> - start additional server(s)
> Once the region has been created, then both the lucene index and region are 
> saved in cluster configuration, so new servers will create both the region 
> and index.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-3014) Document gfsh create lucene index and region failure sequence

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16032257#comment-16032257
 ] 

ASF GitHub Bot commented on GEODE-3014:
---

Github user dihardman commented on the issue:

https://github.com/apache/geode/pull/554
  
+1

On Wed, May 31, 2017 at 4:24 PM, Karen Miller 
wrote:

> @joeymcallister  @dihardman
>  @boglesby 
> Please review.
> --
> You can view, comment on, or merge this pull request online at:
>
>   https://github.com/apache/geode/pull/554
> Commit Summary
>
>- GEODE-3014 Document server/region/Lucene index start-up sequence
>
> File Changes
>
>- *M* geode-docs/tools_modules/lucene_integration.html.md.erb
> (12)
>
> Patch Links:
>
>- https://github.com/apache/geode/pull/554.patch
>- https://github.com/apache/geode/pull/554.diff
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> , or mute the thread
> 

> .
>



> Document gfsh create lucene index and region failure sequence
> -
>
> Key: GEODE-3014
> URL: https://issues.apache.org/jira/browse/GEODE-3014
> Project: Geode
>  Issue Type: Bug
>  Components: docs
>Reporter: Barry Oglesby
>Assignee: Karen Smoler Miller
>
> When creating a lucene index and region using gfsh, there is a specific 
> command sequence that causes the region to not be created successfully.
> The sequence that fails is:
> - start server(s)
> - create lucene index
> - start additional server(s)
> - create region
> What fails about this sequence is the lucene index is not saved in cluster 
> configuration until after the region is created. Before the region is 
> created, its only saved locally in existing servers. Since new servers don't 
> have the index when the region is created, the index definitions aren't 
> consistent across servers. This causes the region to be created only in some 
> servers (either all the original ones with the index or all the new ones 
> without the index).
> An alternate sequence that succeeds is:
> - start server(s)
> - create lucene index
> - create region
> - start additional server(s)
> Once the region has been created, then both the lucene index and region are 
> saved in cluster configuration, so new servers will create both the region 
> and index.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-3013) Reduce logging level for FunctionExceptions : InternalFunctionInvocationTargetException: Multiple target nodes found for single hop operation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1603#comment-1603
 ] 

ASF GitHub Bot commented on GEODE-3013:
---

Github user ladyVader closed the pull request at:

https://github.com/apache/geode/pull/552


> Reduce logging level for FunctionExceptions : 
> InternalFunctionInvocationTargetException: Multiple target nodes found for 
> single hop operation
> -
>
> Key: GEODE-3013
> URL: https://issues.apache.org/jira/browse/GEODE-3013
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Affects Versions: 1.2.0
>Reporter: Shelley Lynn Hughes-Godfrey
>Assignee: Shelley Lynn Hughes-Godfrey
>
> The following exception should not be logged as a warning with a full stack 
> dump (as it is not actionable by the user).
> Changing this to debug log level.
> {noformat}
> Multiple target nodes found for single hop operation
> [warning 2017/04/04 14:53:06.031 PDT bridgegemfire1_monaco_15778 
>  tid=0x98] Exception on server while 
> executing function : 
> org.apache.geode.cache.lucene.internal.distributed.LuceneQueryFunction
> org.apache.geode.internal.cache.execute.InternalFunctionInvocationTargetException:
>  Multiple target nodes found for single hop operation
> at 
> org.apache.geode.internal.cache.PartitionedRegion.executeOnBucketSet(PartitionedRegion.java:3684)
> at 
> org.apache.geode.internal.cache.PartitionedRegion.executeFunction(PartitionedRegion.java:3344)
> at 
> org.apache.geode.internal.cache.execute.PartitionedRegionFunctionExecutor.executeFunction(PartitionedRegionFunctionExecutor.java:225)
> at 
> org.apache.geode.internal.cache.execute.AbstractExecution.execute(AbstractExecution.java:563)
> at 
> org.apache.geode.internal.cache.tier.sockets.command.ExecuteRegionFunctionSingleHop.cmdExecute(ExecuteRegionFunctionSingleHop.java:264)
> at 
> org.apache.geode.internal.cache.tier.sockets.BaseCommand.execute(BaseCommand.java:141)
> at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.doNormalMsg(ServerConnection.java:783)
> at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.doOneMessage(ServerConnection.java:914)
> at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1171)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl$1$1.run(AcceptorImpl.java:519)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-3013) Reduce logging level for FunctionExceptions : InternalFunctionInvocationTargetException: Multiple target nodes found for single hop operation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16032221#comment-16032221
 ] 

ASF GitHub Bot commented on GEODE-3013:
---

Github user ladyVader commented on the issue:

https://github.com/apache/geode/pull/552
  
Actually, with this change, I'm still seeing these log messages in testing, 
so retracting this pull request.


> Reduce logging level for FunctionExceptions : 
> InternalFunctionInvocationTargetException: Multiple target nodes found for 
> single hop operation
> -
>
> Key: GEODE-3013
> URL: https://issues.apache.org/jira/browse/GEODE-3013
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Affects Versions: 1.2.0
>Reporter: Shelley Lynn Hughes-Godfrey
>Assignee: Shelley Lynn Hughes-Godfrey
>
> The following exception should not be logged as a warning with a full stack 
> dump (as it is not actionable by the user).
> Changing this to debug log level.
> {noformat}
> Multiple target nodes found for single hop operation
> [warning 2017/04/04 14:53:06.031 PDT bridgegemfire1_monaco_15778 
>  tid=0x98] Exception on server while 
> executing function : 
> org.apache.geode.cache.lucene.internal.distributed.LuceneQueryFunction
> org.apache.geode.internal.cache.execute.InternalFunctionInvocationTargetException:
>  Multiple target nodes found for single hop operation
> at 
> org.apache.geode.internal.cache.PartitionedRegion.executeOnBucketSet(PartitionedRegion.java:3684)
> at 
> org.apache.geode.internal.cache.PartitionedRegion.executeFunction(PartitionedRegion.java:3344)
> at 
> org.apache.geode.internal.cache.execute.PartitionedRegionFunctionExecutor.executeFunction(PartitionedRegionFunctionExecutor.java:225)
> at 
> org.apache.geode.internal.cache.execute.AbstractExecution.execute(AbstractExecution.java:563)
> at 
> org.apache.geode.internal.cache.tier.sockets.command.ExecuteRegionFunctionSingleHop.cmdExecute(ExecuteRegionFunctionSingleHop.java:264)
> at 
> org.apache.geode.internal.cache.tier.sockets.BaseCommand.execute(BaseCommand.java:141)
> at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.doNormalMsg(ServerConnection.java:783)
> at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.doOneMessage(ServerConnection.java:914)
> at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1171)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl$1$1.run(AcceptorImpl.java:519)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-3014) Document gfsh create lucene index and region failure sequence

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16032208#comment-16032208
 ] 

ASF GitHub Bot commented on GEODE-3014:
---

Github user joeymcallister commented on the issue:

https://github.com/apache/geode/pull/554
  
+1


> Document gfsh create lucene index and region failure sequence
> -
>
> Key: GEODE-3014
> URL: https://issues.apache.org/jira/browse/GEODE-3014
> Project: Geode
>  Issue Type: Bug
>  Components: docs
>Reporter: Barry Oglesby
>Assignee: Karen Smoler Miller
>
> When creating a lucene index and region using gfsh, there is a specific 
> command sequence that causes the region to not be created successfully.
> The sequence that fails is:
> - start server(s)
> - create lucene index
> - start additional server(s)
> - create region
> What fails about this sequence is the lucene index is not saved in cluster 
> configuration until after the region is created. Before the region is 
> created, its only saved locally in existing servers. Since new servers don't 
> have the index when the region is created, the index definitions aren't 
> consistent across servers. This causes the region to be created only in some 
> servers (either all the original ones with the index or all the new ones 
> without the index).
> An alternate sequence that succeeds is:
> - start server(s)
> - create lucene index
> - create region
> - start additional server(s)
> Once the region has been created, then both the lucene index and region are 
> saved in cluster configuration, so new servers will create both the region 
> and index.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-3014) Document gfsh create lucene index and region failure sequence

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16032193#comment-16032193
 ] 

ASF GitHub Bot commented on GEODE-3014:
---

GitHub user karensmolermiller opened a pull request:

https://github.com/apache/geode/pull/554

GEODE-3014 Document server/region/Lucene index start-up sequence

@joeymcallister @dihardman @boglesby Please review.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/karensmolermiller/geode feature/GEODE-3014

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/554.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #554


commit 8d1a1e68ac8b062a2cb78aa6ce232e0c0e43adce
Author: Karen Miller 
Date:   2017-05-31T23:21:27Z

GEODE-3014 Document server/region/Lucene index start-up sequence




> Document gfsh create lucene index and region failure sequence
> -
>
> Key: GEODE-3014
> URL: https://issues.apache.org/jira/browse/GEODE-3014
> Project: Geode
>  Issue Type: Bug
>  Components: docs
>Reporter: Barry Oglesby
>Assignee: Karen Smoler Miller
>
> When creating a lucene index and region using gfsh, there is a specific 
> command sequence that causes the region to not be created successfully.
> The sequence that fails is:
> - start server(s)
> - create lucene index
> - start additional server(s)
> - create region
> What fails about this sequence is the lucene index is not saved in cluster 
> configuration until after the region is created. Before the region is 
> created, its only saved locally in existing servers. Since new servers don't 
> have the index when the region is created, the index definitions aren't 
> consistent across servers. This causes the region to be created only in some 
> servers (either all the original ones with the index or all the new ones 
> without the index).
> An alternate sequence that succeeds is:
> - start server(s)
> - create lucene index
> - create region
> - start additional server(s)
> Once the region has been created, then both the lucene index and region are 
> saved in cluster configuration, so new servers will create both the region 
> and index.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-3011) gfsh example to do a Lucene query is incorrect

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16032093#comment-16032093
 ] 

ASF GitHub Bot commented on GEODE-3011:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/553


> gfsh example to do a Lucene query is incorrect
> --
>
> Key: GEODE-3011
> URL: https://issues.apache.org/jira/browse/GEODE-3011
> Project: Geode
>  Issue Type: Bug
>  Components: docs
>Reporter: Diane Hardman
>Assignee: Karen Smoler Miller
>
> In the Lucene integration section of the docs is the following incorrect gfsh 
> command example:
> gfsh> lucene search --regionName=/orders -queryStrings="John*" 
> --defaultField=field1
> Instead it should be:
> gfsh> search lucene --name=indexName --region=/orders --queryStrings="John*" 
> --defaultField=customer --limit=100



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-3011) gfsh example to do a Lucene query is incorrect

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16032080#comment-16032080
 ] 

ASF GitHub Bot commented on GEODE-3011:
---

Github user joeymcallister commented on the issue:

https://github.com/apache/geode/pull/553
  
+1


> gfsh example to do a Lucene query is incorrect
> --
>
> Key: GEODE-3011
> URL: https://issues.apache.org/jira/browse/GEODE-3011
> Project: Geode
>  Issue Type: Bug
>  Components: docs
>Reporter: Diane Hardman
>Assignee: Karen Smoler Miller
>
> In the Lucene integration section of the docs is the following incorrect gfsh 
> command example:
> gfsh> lucene search --regionName=/orders -queryStrings="John*" 
> --defaultField=field1
> Instead it should be:
> gfsh> search lucene --name=indexName --region=/orders --queryStrings="John*" 
> --defaultField=customer --limit=100



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2994) Doc task: interactions of backups with persistence

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16032069#comment-16032069
 ] 

ASF GitHub Bot commented on GEODE-2994:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/544


> Doc task: interactions of backups with persistence
> --
>
> Key: GEODE-2994
> URL: https://issues.apache.org/jira/browse/GEODE-2994
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
>
> Document that an inconsistent state can occur by using a backup to restore 
> system state, if the backup is made at the wrong time.
> There are 2 examples where persistence and taking a backup might cause an 
> inconsistency with region data, if that backup is used to restore a system.
> # *A Lucene index.* The Lucene index is persistent. If a backup is unlucky 
> enough to be taken between a persisted write to a region (disk op) and a 
> persisted write to the Lucene index (disk op), then the backup represents 
> inconsistent data in the region and Lucene index.
> # *An AEQ.* The AEQ is persistent. If a backup is unlucky enough to be taken 
> between a persisted write to a region (disk op) and a persisted write to the 
> AEQ (disk op), then the backup represents inconsistent data in the region and 
> the AEQ.
> The solution is to make sure that backups are taken when the system is 
> quiescent WRT region operations.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2994) Doc task: interactions of backups with persistence

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16032056#comment-16032056
 ] 

ASF GitHub Bot commented on GEODE-2994:
---

Github user dihardman commented on the issue:

https://github.com/apache/geode/pull/544
  
+1, looks good.

On Wed, May 31, 2017 at 2:46 PM, Barrett Oglesby 
wrote:

> *@boglesby* approved this pull request.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> , or 
mute
> the thread
> 

> .
>



> Doc task: interactions of backups with persistence
> --
>
> Key: GEODE-2994
> URL: https://issues.apache.org/jira/browse/GEODE-2994
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
>
> Document that an inconsistent state can occur by using a backup to restore 
> system state, if the backup is made at the wrong time.
> There are 2 examples where persistence and taking a backup might cause an 
> inconsistency with region data, if that backup is used to restore a system.
> # *A Lucene index.* The Lucene index is persistent. If a backup is unlucky 
> enough to be taken between a persisted write to a region (disk op) and a 
> persisted write to the Lucene index (disk op), then the backup represents 
> inconsistent data in the region and Lucene index.
> # *An AEQ.* The AEQ is persistent. If a backup is unlucky enough to be taken 
> between a persisted write to a region (disk op) and a persisted write to the 
> AEQ (disk op), then the backup represents inconsistent data in the region and 
> the AEQ.
> The solution is to make sure that backups are taken when the system is 
> quiescent WRT region operations.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2994) Doc task: interactions of backups with persistence

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16032017#comment-16032017
 ] 

ASF GitHub Bot commented on GEODE-2994:
---

Github user karensmolermiller commented on a diff in the pull request:

https://github.com/apache/geode/pull/544#discussion_r119481660
  
--- Diff: geode-docs/tools_modules/lucene_integration.html.md.erb ---
@@ -294,8 +294,11 @@ will return `object_2`.
 will return `object_3`.
 - Backups should only be made for regions with Lucene indexes
 when there are no puts, updates, or deletes in progress.
-Incremental backups will not be consistent for the region and
-its index upon restart if these operations were in progress,
-due to the delayed processing associated with the asynchronous event queue.
-If region data needs to be restored from a backup,
-follow the same procedure as given for changing an index.
+A backup might cause an inconsistency between region data and a Lucene 
index,
+if that backup is used to restore a system.
+The Lucene index is persistent.
+If a backup is unlucky enough to be taken between
+a persisted write to a region (causing a disk operation)
+and the resulting persisted write to the Lucene index
+(causing a disk operation),
+then the backup represents inconsistent data in the region and Lucene 
index.
--- End diff --

Reworded.


> Doc task: interactions of backups with persistence
> --
>
> Key: GEODE-2994
> URL: https://issues.apache.org/jira/browse/GEODE-2994
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
>
> Document that an inconsistent state can occur by using a backup to restore 
> system state, if the backup is made at the wrong time.
> There are 2 examples where persistence and taking a backup might cause an 
> inconsistency with region data, if that backup is used to restore a system.
> # *A Lucene index.* The Lucene index is persistent. If a backup is unlucky 
> enough to be taken between a persisted write to a region (disk op) and a 
> persisted write to the Lucene index (disk op), then the backup represents 
> inconsistent data in the region and Lucene index.
> # *An AEQ.* The AEQ is persistent. If a backup is unlucky enough to be taken 
> between a persisted write to a region (disk op) and a persisted write to the 
> AEQ (disk op), then the backup represents inconsistent data in the region and 
> the AEQ.
> The solution is to make sure that backups are taken when the system is 
> quiescent WRT region operations.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2994) Doc task: interactions of backups with persistence

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16032016#comment-16032016
 ] 

ASF GitHub Bot commented on GEODE-2994:
---

Github user karensmolermiller commented on a diff in the pull request:

https://github.com/apache/geode/pull/544#discussion_r119481618
  
--- Diff: 
geode-docs/managing/disk_storage/backup_restore_disk_store.html.md.erb ---
@@ -38,6 +38,15 @@ Do not try to create backup files from a running system 
by using your operating
 **Preparing to Make a Backup**
 
 -   Consider compacting your disk store before making a backup. If 
auto-compaction is turned off, you may want to do a manual compaction to save 
on the quantity of data copied over the network by the backup. For more 
information on configuring a manual compaction, see [Manual 
Compaction](compacting_disk_stores.html#compacting_disk_stores__li_63CF8C35153D4173AADF7DC35FEC61F9).
+-   Take the backup when region operations are quiescent,
+to avoid the possibility of an inconsistency between region data and
+an asyncronous event queue (AEQ),
+if that backup were to be used to restore a system.
+The AEQ is persistent.
+If a backup is unlucky enough to be taken between
--- End diff --

Reworded.  


> Doc task: interactions of backups with persistence
> --
>
> Key: GEODE-2994
> URL: https://issues.apache.org/jira/browse/GEODE-2994
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
>
> Document that an inconsistent state can occur by using a backup to restore 
> system state, if the backup is made at the wrong time.
> There are 2 examples where persistence and taking a backup might cause an 
> inconsistency with region data, if that backup is used to restore a system.
> # *A Lucene index.* The Lucene index is persistent. If a backup is unlucky 
> enough to be taken between a persisted write to a region (disk op) and a 
> persisted write to the Lucene index (disk op), then the backup represents 
> inconsistent data in the region and Lucene index.
> # *An AEQ.* The AEQ is persistent. If a backup is unlucky enough to be taken 
> between a persisted write to a region (disk op) and a persisted write to the 
> AEQ (disk op), then the backup represents inconsistent data in the region and 
> the AEQ.
> The solution is to make sure that backups are taken when the system is 
> quiescent WRT region operations.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2994) Doc task: interactions of backups with persistence

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16032014#comment-16032014
 ] 

ASF GitHub Bot commented on GEODE-2994:
---

Github user karensmolermiller commented on a diff in the pull request:

https://github.com/apache/geode/pull/544#discussion_r119481506
  
--- Diff: 
geode-docs/managing/disk_storage/backup_restore_disk_store.html.md.erb ---
@@ -38,6 +38,15 @@ Do not try to create backup files from a running system 
by using your operating
 **Preparing to Make a Backup**
 
 -   Consider compacting your disk store before making a backup. If 
auto-compaction is turned off, you may want to do a manual compaction to save 
on the quantity of data copied over the network by the backup. For more 
information on configuring a manual compaction, see [Manual 
Compaction](compacting_disk_stores.html#compacting_disk_stores__li_63CF8C35153D4173AADF7DC35FEC61F9).
+-   Take the backup when region operations are quiescent,
+to avoid the possibility of an inconsistency between region data and
+an asyncronous event queue (AEQ),
+if that backup were to be used to restore a system.
--- End diff --

Done.


> Doc task: interactions of backups with persistence
> --
>
> Key: GEODE-2994
> URL: https://issues.apache.org/jira/browse/GEODE-2994
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
>
> Document that an inconsistent state can occur by using a backup to restore 
> system state, if the backup is made at the wrong time.
> There are 2 examples where persistence and taking a backup might cause an 
> inconsistency with region data, if that backup is used to restore a system.
> # *A Lucene index.* The Lucene index is persistent. If a backup is unlucky 
> enough to be taken between a persisted write to a region (disk op) and a 
> persisted write to the Lucene index (disk op), then the backup represents 
> inconsistent data in the region and Lucene index.
> # *An AEQ.* The AEQ is persistent. If a backup is unlucky enough to be taken 
> between a persisted write to a region (disk op) and a persisted write to the 
> AEQ (disk op), then the backup represents inconsistent data in the region and 
> the AEQ.
> The solution is to make sure that backups are taken when the system is 
> quiescent WRT region operations.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2994) Doc task: interactions of backups with persistence

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16032009#comment-16032009
 ] 

ASF GitHub Bot commented on GEODE-2994:
---

Github user karensmolermiller commented on a diff in the pull request:

https://github.com/apache/geode/pull/544#discussion_r119481045
  
--- Diff: 
geode-docs/managing/disk_storage/backup_restore_disk_store.html.md.erb ---
@@ -38,6 +38,15 @@ Do not try to create backup files from a running system 
by using your operating
 **Preparing to Make a Backup**
 
 -   Consider compacting your disk store before making a backup. If 
auto-compaction is turned off, you may want to do a manual compaction to save 
on the quantity of data copied over the network by the backup. For more 
information on configuring a manual compaction, see [Manual 
Compaction](compacting_disk_stores.html#compacting_disk_stores__li_63CF8C35153D4173AADF7DC35FEC61F9).
+-   Take the backup when region operations are quiescent,
+to avoid the possibility of an inconsistency between region data and
+an asyncronous event queue (AEQ),
+if that backup were to be used to restore a system.
+The AEQ is persistent.
+If a backup is unlucky enough to be taken between
+a persisted write to a region (causing a disk operation)
+and the resulting persisted write to the AEQ (causing a disk operation),
+then the backup represents inconsistent data in the region and the AEQ.
--- End diff --

Could you please create a new JIRA if you want to refine the restoration 
procedure?  I think that we ought to be much more specific about how to destroy 
any queue.

I'd like this JIRA to just make sure to warn users about the possibility of 
inconsistency in their backups.


> Doc task: interactions of backups with persistence
> --
>
> Key: GEODE-2994
> URL: https://issues.apache.org/jira/browse/GEODE-2994
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
>
> Document that an inconsistent state can occur by using a backup to restore 
> system state, if the backup is made at the wrong time.
> There are 2 examples where persistence and taking a backup might cause an 
> inconsistency with region data, if that backup is used to restore a system.
> # *A Lucene index.* The Lucene index is persistent. If a backup is unlucky 
> enough to be taken between a persisted write to a region (disk op) and a 
> persisted write to the Lucene index (disk op), then the backup represents 
> inconsistent data in the region and Lucene index.
> # *An AEQ.* The AEQ is persistent. If a backup is unlucky enough to be taken 
> between a persisted write to a region (disk op) and a persisted write to the 
> AEQ (disk op), then the backup represents inconsistent data in the region and 
> the AEQ.
> The solution is to make sure that backups are taken when the system is 
> quiescent WRT region operations.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-3011) gfsh example to do a Lucene query is incorrect

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16031987#comment-16031987
 ] 

ASF GitHub Bot commented on GEODE-3011:
---

Github user dihardman commented on the issue:

https://github.com/apache/geode/pull/553
  
+1 looks good!

On Wed, May 31, 2017 at 1:33 PM, Karen Miller 
wrote:

> @dihardman  @boglesby
>  @upthewaterspout
>  @ladyVader
>  @nabarunnag 
> @DivineEnder  @jhuynh1
>  @davebarnes97
>  @joeymcallister
> 
> Please review.
> --
> You can view, comment on, or merge this pull request online at:
>
>   https://github.com/apache/geode/pull/553
> Commit Summary
>
>- GEODE-3011 Correct a Lucene gfsh query example
>
> File Changes
>
>- *M* geode-docs/tools_modules/lucene_integration.html.md.erb
> (4)
>
> Patch Links:
>
>- https://github.com/apache/geode/pull/553.patch
>- https://github.com/apache/geode/pull/553.diff
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> , or mute the thread
> 

> .
>



> gfsh example to do a Lucene query is incorrect
> --
>
> Key: GEODE-3011
> URL: https://issues.apache.org/jira/browse/GEODE-3011
> Project: Geode
>  Issue Type: Bug
>  Components: docs
>Reporter: Diane Hardman
>Assignee: Karen Smoler Miller
>
> In the Lucene integration section of the docs is the following incorrect gfsh 
> command example:
> gfsh> lucene search --regionName=/orders -queryStrings="John*" 
> --defaultField=field1
> Instead it should be:
> gfsh> search lucene --name=indexName --region=/orders --queryStrings="John*" 
> --defaultField=customer --limit=100



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-3011) gfsh example to do a Lucene query is incorrect

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16031911#comment-16031911
 ] 

ASF GitHub Bot commented on GEODE-3011:
---

GitHub user karensmolermiller opened a pull request:

https://github.com/apache/geode/pull/553

GEODE-3011 Correct a Lucene gfsh query example

@dihardman @boglesby @upthewaterspout @ladyVader @nabarunnag @DivineEnder 
@jhuynh1 @davebarnes97 @joeymcallister 
Please review.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/karensmolermiller/geode feature/GEODE-3011

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/553.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #553


commit 9ddafd9428bf6084915b8e53ae1cad13b28bae90
Author: Karen Miller 
Date:   2017-05-31T20:28:28Z

GEODE-3011 Correct a Lucene gfsh query example




> gfsh example to do a Lucene query is incorrect
> --
>
> Key: GEODE-3011
> URL: https://issues.apache.org/jira/browse/GEODE-3011
> Project: Geode
>  Issue Type: Bug
>  Components: docs
>Reporter: Diane Hardman
>Assignee: Karen Smoler Miller
>
> In the Lucene integration section of the docs is the following incorrect gfsh 
> command example:
> gfsh> lucene search --regionName=/orders -queryStrings="John*" 
> --defaultField=field1
> Instead it should be:
> gfsh> search lucene --name=indexName --region=/orders --queryStrings="John*" 
> --defaultField=customer --limit=100



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2994) Doc task: interactions of backups with persistence

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16031734#comment-16031734
 ] 

ASF GitHub Bot commented on GEODE-2994:
---

Github user dihardman commented on a diff in the pull request:

https://github.com/apache/geode/pull/544#discussion_r119445495
  
--- Diff: geode-docs/tools_modules/lucene_integration.html.md.erb ---
@@ -294,8 +294,11 @@ will return `object_2`.
 will return `object_3`.
 - Backups should only be made for regions with Lucene indexes
 when there are no puts, updates, or deletes in progress.
-Incremental backups will not be consistent for the region and
-its index upon restart if these operations were in progress,
-due to the delayed processing associated with the asynchronous event queue.
-If region data needs to be restored from a backup,
-follow the same procedure as given for changing an index.
+A backup might cause an inconsistency between region data and a Lucene 
index,
+if that backup is used to restore a system.
+The Lucene index is persistent.
+If a backup is unlucky enough to be taken between
+a persisted write to a region (causing a disk operation)
+and the resulting persisted write to the Lucene index
+(causing a disk operation),
+then the backup represents inconsistent data in the region and Lucene 
index.
--- End diff --

See comments added to backup_restore_disk_store.erb


> Doc task: interactions of backups with persistence
> --
>
> Key: GEODE-2994
> URL: https://issues.apache.org/jira/browse/GEODE-2994
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
>
> Document that an inconsistent state can occur by using a backup to restore 
> system state, if the backup is made at the wrong time.
> There are 2 examples where persistence and taking a backup might cause an 
> inconsistency with region data, if that backup is used to restore a system.
> # *A Lucene index.* The Lucene index is persistent. If a backup is unlucky 
> enough to be taken between a persisted write to a region (disk op) and a 
> persisted write to the Lucene index (disk op), then the backup represents 
> inconsistent data in the region and Lucene index.
> # *An AEQ.* The AEQ is persistent. If a backup is unlucky enough to be taken 
> between a persisted write to a region (disk op) and a persisted write to the 
> AEQ (disk op), then the backup represents inconsistent data in the region and 
> the AEQ.
> The solution is to make sure that backups are taken when the system is 
> quiescent WRT region operations.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2994) Doc task: interactions of backups with persistence

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16031728#comment-16031728
 ] 

ASF GitHub Bot commented on GEODE-2994:
---

Github user dihardman commented on a diff in the pull request:

https://github.com/apache/geode/pull/544#discussion_r119445110
  
--- Diff: 
geode-docs/managing/disk_storage/backup_restore_disk_store.html.md.erb ---
@@ -38,6 +38,15 @@ Do not try to create backup files from a running system 
by using your operating
 **Preparing to Make a Backup**
 
 -   Consider compacting your disk store before making a backup. If 
auto-compaction is turned off, you may want to do a manual compaction to save 
on the quantity of data copied over the network by the backup. For more 
information on configuring a manual compaction, see [Manual 
Compaction](compacting_disk_stores.html#compacting_disk_stores__li_63CF8C35153D4173AADF7DC35FEC61F9).
+-   Take the backup when region operations are quiescent,
+to avoid the possibility of an inconsistency between region data and
+an asyncronous event queue (AEQ),
+if that backup were to be used to restore a system.
+The AEQ is persistent.
+If a backup is unlucky enough to be taken between
+a persisted write to a region (causing a disk operation)
+and the resulting persisted write to the AEQ (causing a disk operation),
+then the backup represents inconsistent data in the region and the AEQ.
--- End diff --

Add a workaround strategy:
If this backup must be used to restore your system, consider the region 
data as the valid system of record, destroy the AEQ, export the region data, 
remove all data from the region and re-import it using the command line option 
invoking listeners. This will re-create the AEQ in a consistent state with the 
region data.


> Doc task: interactions of backups with persistence
> --
>
> Key: GEODE-2994
> URL: https://issues.apache.org/jira/browse/GEODE-2994
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
>
> Document that an inconsistent state can occur by using a backup to restore 
> system state, if the backup is made at the wrong time.
> There are 2 examples where persistence and taking a backup might cause an 
> inconsistency with region data, if that backup is used to restore a system.
> # *A Lucene index.* The Lucene index is persistent. If a backup is unlucky 
> enough to be taken between a persisted write to a region (disk op) and a 
> persisted write to the Lucene index (disk op), then the backup represents 
> inconsistent data in the region and Lucene index.
> # *An AEQ.* The AEQ is persistent. If a backup is unlucky enough to be taken 
> between a persisted write to a region (disk op) and a persisted write to the 
> AEQ (disk op), then the backup represents inconsistent data in the region and 
> the AEQ.
> The solution is to make sure that backups are taken when the system is 
> quiescent WRT region operations.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2994) Doc task: interactions of backups with persistence

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16031676#comment-16031676
 ] 

ASF GitHub Bot commented on GEODE-2994:
---

Github user boglesby commented on a diff in the pull request:

https://github.com/apache/geode/pull/544#discussion_r119441378
  
--- Diff: 
geode-docs/managing/disk_storage/backup_restore_disk_store.html.md.erb ---
@@ -38,6 +38,15 @@ Do not try to create backup files from a running system 
by using your operating
 **Preparing to Make a Backup**
 
 -   Consider compacting your disk store before making a backup. If 
auto-compaction is turned off, you may want to do a manual compaction to save 
on the quantity of data copied over the network by the backup. For more 
information on configuring a manual compaction, see [Manual 
Compaction](compacting_disk_stores.html#compacting_disk_stores__li_63CF8C35153D4173AADF7DC35FEC61F9).
+-   Take the backup when region operations are quiescent,
+to avoid the possibility of an inconsistency between region data and
+an asyncronous event queue (AEQ),
+if that backup were to be used to restore a system.
+The AEQ is persistent.
+If a backup is unlucky enough to be taken between
--- End diff --

I think Diane captured some of this already.

I'm not sure I understand the formatting in this passage. I'm looking at it 
on github, though, so maybe thats why. I'm not sure I understand this sentence: 
"The AEQ is persistent." Is it meant to emphasize both the region and queue are 
persistent and writes to them are not atomic?

asyncronous -> asynchronous

Its not just AEQs that could be inconsistent. Also WAN GatewaySenders. They 
both use the same queueing code underneath the covers. Its the persistent queue 
that could be out of sync with the persistent data region, so both AEQs and WAN 
GatewaySenders can have the same issue.



> Doc task: interactions of backups with persistence
> --
>
> Key: GEODE-2994
> URL: https://issues.apache.org/jira/browse/GEODE-2994
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
>
> Document that an inconsistent state can occur by using a backup to restore 
> system state, if the backup is made at the wrong time.
> There are 2 examples where persistence and taking a backup might cause an 
> inconsistency with region data, if that backup is used to restore a system.
> # *A Lucene index.* The Lucene index is persistent. If a backup is unlucky 
> enough to be taken between a persisted write to a region (disk op) and a 
> persisted write to the Lucene index (disk op), then the backup represents 
> inconsistent data in the region and Lucene index.
> # *An AEQ.* The AEQ is persistent. If a backup is unlucky enough to be taken 
> between a persisted write to a region (disk op) and a persisted write to the 
> AEQ (disk op), then the backup represents inconsistent data in the region and 
> the AEQ.
> The solution is to make sure that backups are taken when the system is 
> quiescent WRT region operations.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2994) Doc task: interactions of backups with persistence

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16031667#comment-16031667
 ] 

ASF GitHub Bot commented on GEODE-2994:
---

Github user dihardman commented on a diff in the pull request:

https://github.com/apache/geode/pull/544#discussion_r119439870
  
--- Diff: 
geode-docs/managing/disk_storage/backup_restore_disk_store.html.md.erb ---
@@ -38,6 +38,15 @@ Do not try to create backup files from a running system 
by using your operating
 **Preparing to Make a Backup**
 
 -   Consider compacting your disk store before making a backup. If 
auto-compaction is turned off, you may want to do a manual compaction to save 
on the quantity of data copied over the network by the backup. For more 
information on configuring a manual compaction, see [Manual 
Compaction](compacting_disk_stores.html#compacting_disk_stores__li_63CF8C35153D4173AADF7DC35FEC61F9).
+-   Take the backup when region operations are quiescent,
+to avoid the possibility of an inconsistency between region data and
+an asyncronous event queue (AEQ),
+if that backup were to be used to restore a system.
+The AEQ is persistent.
+If a backup is unlucky enough to be taken between
--- End diff --

Instead of "If the backup is unlucky enough to be taken between", consider:
If the timing of the backup occurs between...


> Doc task: interactions of backups with persistence
> --
>
> Key: GEODE-2994
> URL: https://issues.apache.org/jira/browse/GEODE-2994
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
>
> Document that an inconsistent state can occur by using a backup to restore 
> system state, if the backup is made at the wrong time.
> There are 2 examples where persistence and taking a backup might cause an 
> inconsistency with region data, if that backup is used to restore a system.
> # *A Lucene index.* The Lucene index is persistent. If a backup is unlucky 
> enough to be taken between a persisted write to a region (disk op) and a 
> persisted write to the Lucene index (disk op), then the backup represents 
> inconsistent data in the region and Lucene index.
> # *An AEQ.* The AEQ is persistent. If a backup is unlucky enough to be taken 
> between a persisted write to a region (disk op) and a persisted write to the 
> AEQ (disk op), then the backup represents inconsistent data in the region and 
> the AEQ.
> The solution is to make sure that backups are taken when the system is 
> quiescent WRT region operations.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2994) Doc task: interactions of backups with persistence

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16031657#comment-16031657
 ] 

ASF GitHub Bot commented on GEODE-2994:
---

Github user dihardman commented on a diff in the pull request:

https://github.com/apache/geode/pull/544#discussion_r119438727
  
--- Diff: 
geode-docs/managing/disk_storage/backup_restore_disk_store.html.md.erb ---
@@ -38,6 +38,15 @@ Do not try to create backup files from a running system 
by using your operating
 **Preparing to Make a Backup**
 
 -   Consider compacting your disk store before making a backup. If 
auto-compaction is turned off, you may want to do a manual compaction to save 
on the quantity of data copied over the network by the backup. For more 
information on configuring a manual compaction, see [Manual 
Compaction](compacting_disk_stores.html#compacting_disk_stores__li_63CF8C35153D4173AADF7DC35FEC61F9).
+-   Take the backup when region operations are quiescent,
+to avoid the possibility of an inconsistency between region data and
+an asyncronous event queue (AEQ),
+if that backup were to be used to restore a system.
--- End diff --

I recommend taking out the clause "if that backup were to be used to 
restore a system". The explanation that follows fully explains this.


> Doc task: interactions of backups with persistence
> --
>
> Key: GEODE-2994
> URL: https://issues.apache.org/jira/browse/GEODE-2994
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
>
> Document that an inconsistent state can occur by using a backup to restore 
> system state, if the backup is made at the wrong time.
> There are 2 examples where persistence and taking a backup might cause an 
> inconsistency with region data, if that backup is used to restore a system.
> # *A Lucene index.* The Lucene index is persistent. If a backup is unlucky 
> enough to be taken between a persisted write to a region (disk op) and a 
> persisted write to the Lucene index (disk op), then the backup represents 
> inconsistent data in the region and Lucene index.
> # *An AEQ.* The AEQ is persistent. If a backup is unlucky enough to be taken 
> between a persisted write to a region (disk op) and a persisted write to the 
> AEQ (disk op), then the backup represents inconsistent data in the region and 
> the AEQ.
> The solution is to make sure that backups are taken when the system is 
> quiescent WRT region operations.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-3013) Reduce logging level for FunctionExceptions : InternalFunctionInvocationTargetException: Multiple target nodes found for single hop operation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16031650#comment-16031650
 ] 

ASF GitHub Bot commented on GEODE-3013:
---

GitHub user ladyVader opened a pull request:

https://github.com/apache/geode/pull/552

GEODE-3013: Reduce log level for FunctionInvocationTargetException

GEODE-3013: Reduce log level for FunctionInvocationTargetExceptions

- Modified to display at debug vs. warning level (includes full stack trace)

@upthewaterspout @nabarunnag, @boglesby, @jhuynh1, @gesterzhou

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/geode feature/GEODE-3013

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/552.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #552


commit d9f219ad048668a99ccdf4ac630326c1e13c6f19
Author: Lynn Hughes-Godfrey 
Date:   2017-05-31T01:16:34Z

GEODE-3013: Reduce logging level for FunctionInvocationTargetException: 
Multiple target nodes found for single hop operation

- Modified to display at debug vs. warning level




> Reduce logging level for FunctionExceptions : 
> InternalFunctionInvocationTargetException: Multiple target nodes found for 
> single hop operation
> -
>
> Key: GEODE-3013
> URL: https://issues.apache.org/jira/browse/GEODE-3013
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Affects Versions: 1.2.0
>Reporter: Shelley Lynn Hughes-Godfrey
>Assignee: Shelley Lynn Hughes-Godfrey
>
> The following exception should not be logged as a warning with a full stack 
> dump (as it is not actionable by the user).
> Changing this to debug log level.
> {noformat}
> Multiple target nodes found for single hop operation
> [warning 2017/04/04 14:53:06.031 PDT bridgegemfire1_monaco_15778 
>  tid=0x98] Exception on server while 
> executing function : 
> org.apache.geode.cache.lucene.internal.distributed.LuceneQueryFunction
> org.apache.geode.internal.cache.execute.InternalFunctionInvocationTargetException:
>  Multiple target nodes found for single hop operation
> at 
> org.apache.geode.internal.cache.PartitionedRegion.executeOnBucketSet(PartitionedRegion.java:3684)
> at 
> org.apache.geode.internal.cache.PartitionedRegion.executeFunction(PartitionedRegion.java:3344)
> at 
> org.apache.geode.internal.cache.execute.PartitionedRegionFunctionExecutor.executeFunction(PartitionedRegionFunctionExecutor.java:225)
> at 
> org.apache.geode.internal.cache.execute.AbstractExecution.execute(AbstractExecution.java:563)
> at 
> org.apache.geode.internal.cache.tier.sockets.command.ExecuteRegionFunctionSingleHop.cmdExecute(ExecuteRegionFunctionSingleHop.java:264)
> at 
> org.apache.geode.internal.cache.tier.sockets.BaseCommand.execute(BaseCommand.java:141)
> at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.doNormalMsg(ServerConnection.java:783)
> at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.doOneMessage(ServerConnection.java:914)
> at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1171)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at 
> 

[jira] [Commented] (GEODE-3002) Improve doc of (Lucene) __REGION_VALUE_FIELD

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16031584#comment-16031584
 ] 

ASF GitHub Bot commented on GEODE-3002:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/550


> Improve doc of (Lucene) __REGION_VALUE_FIELD
> 
>
> Key: GEODE-3002
> URL: https://issues.apache.org/jira/browse/GEODE-3002
> Project: Geode
>  Issue Type: Bug
>  Components: docs
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
>Priority: Minor
>
> The original description of {{__REGION_VALUE_FIELD}} is not quite right. In 
> addition, there is an example gfsh command using this value that is wrong.  
> It is in the {{gfsh create lucene index}} command reference page.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2203) gfsh status locator/server - Give more descriptive output on empty parameter

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16031565#comment-16031565
 ] 

ASF GitHub Bot commented on GEODE-2203:
---

Github user YehEmily commented on a diff in the pull request:

https://github.com/apache/geode/pull/549#discussion_r119422035
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java
 ---
@@ -771,11 +771,19 @@ public Result statusLocator(
   CliStrings.STATUS_SERVICE__GFSH_NOT_CONNECTED_ERROR_MESSAGE, 
LOCATOR_TERM_NAME));
 }
   } else {
-final LocatorLauncher locatorLauncher =
-new 
LocatorLauncher.Builder().setCommand(LocatorLauncher.Command.STATUS)
-
.setBindAddress(locatorHost).setDebug(isDebugging()).setPid(pid)
-
.setPort(locatorPort).setWorkingDirectory(workingDirectory).build();
-
+final LocatorLauncher locatorLauncher;
+
+if ((locatorHost == null) && (locatorPort == null) && 
(workingDirectory == null)
+&& (pid == null)) {
+  return ResultBuilder.createShellClientErrorResult(
+  
String.format(CliStrings.STATUS_LOCATOR__NO_LOCATOR_SPECIFIED_ERROR_MESSAGE,
+  getLocatorId(locatorHost, locatorPort),
+  StringUtils.defaultIfBlank(workingDirectory, 
SystemUtils.CURRENT_DIRECTORY)));
--- End diff --

Oops! Sorry, I'll fix that right away - thank you!


> gfsh status locator/server - Give more descriptive output on empty parameter
> 
>
> Key: GEODE-2203
> URL: https://issues.apache.org/jira/browse/GEODE-2203
> Project: Geode
>  Issue Type: Improvement
>  Components: gfsh
>Reporter: Alyssa Kim
>Assignee: Emily Yeh
>Priority: Minor
>  Labels: StatusLocatorCommand, StatusServerCommand, gfsh, status
>
> Currently, executing some status commands in gfsh without valid parameters 
> gives a vague explanation/output that might be misleading. Although we have 
> help  for usage description, displaying 'null' as an output 
> might not be the best idea.
> Current Result
> {code}
> gfsh>status locator
> null
> {code}
> {code}
> gfsh>status server
> Server in 
> C:\Users\XXX\git\incubator-geode\geode-assembly\build\install\apache-geode\bin
>  on null is currently not responding.
> {code}
> Improvement
> {code}
> gfsh>status locator
> SYNTAX
> status locator [--name=value] [--host=value] [--port=value] [--pid=value]
> Use help status locator to display detailed usage information
> {code}
> {code}
> gfsh>status server
> SYNTAX
> status server [--name=value] [--pid=value] [--dir=value]
> Use help status server to display detailed usage information
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2971) Inconsistency in gfsh status command

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16031554#comment-16031554
 ] 

ASF GitHub Bot commented on GEODE-2971:
---

Github user jaredjstewart commented on a diff in the pull request:

https://github.com/apache/geode/pull/551#discussion_r119420029
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/internal/ShellExitCode.java ---
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
+ * or implied. See the License for the specific language governing 
permissions and limitations under
+ * the License.
+ */
+package org.apache.geode.internal;
+
+public class ShellExitCode {
--- End diff --

E.g. 

```
 public enum ShellExitCode {
NORMAL(0),FATAL(1), INVALID(1);

private MyEnum(int exitCode) {
  this.exitCode = exitCode;
}

private int exitCode;

public int getExitCode(){
  return this.exitCode;
}
  }
```


> Inconsistency in gfsh status command
> 
>
> Key: GEODE-2971
> URL: https://issues.apache.org/jira/browse/GEODE-2971
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Reporter: Patrick Rhomberg
>
> There is a general inconsistency in gfsh's exit status to the shell.  This 
> makes scripting rather difficult.  For instance:
> * Locator & Server Online (+)
> ** --pid: exit code {{0}} for both, all good.
> ** --name: exit code {{0}} for both, all good.
> ** --dir: exit code {{0}} for both, all good.
> * Locator Online, Server Offline (-)
> ** --pid: exit code is {{0}} for both. Nevertheless, the return string when 
> executing the command for the server returns a {{null}} within the message 
> (where the ip and port should be). As an example: {{Server in 
> /path/to/server/directory on null is currently not responding}}.
> ** --name: exit code is {{0}} for the locator, {{1}} for the server because 
> there's no online member with the specified name... which raises the 
> question: there wasn't any exceptions during the execution, shouldn't we 
> return {{0}}?.
> ** --dir: exit code is {{0}} for both. Nevertheless, the return string when 
> executing the command for the server returns a {{null}} within the message 
> (where the ip and port should be). As an example: {{Server in 
> /path/to/server/directory on null is currently not responding}}.
> * Locator & Server Offline (-)
> ** --pid: exit code for locator is {{1}}, and the return string only contains 
> {{null}}. The exit code for server is {{0}}, but the return string contains a 
> {{null}} within the message (where the ip and port should be). As an example: 
> {{Server in /path/to/server/directory on null is currently not responding}}.
> ** --name: both return {{1}}, which is expected since there's no jmx manager 
> running and this option requires gfsh to be connected.
> ** --dir: exit code for locator is {{1}}, and the return string only contains 
> {{null}}. The exit code for server is {{0}}, but the return string contains a 
> {{null}} within the message (where the ip and port should be). As an example: 
> {{Server in /path/to/server/directory on null is currently not responding}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2203) gfsh status locator/server - Give more descriptive output on empty parameter

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16031552#comment-16031552
 ] 

ASF GitHub Bot commented on GEODE-2203:
---

Github user pdxrunner commented on a diff in the pull request:

https://github.com/apache/geode/pull/549#discussion_r119419356
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java
 ---
@@ -771,11 +771,19 @@ public Result statusLocator(
   CliStrings.STATUS_SERVICE__GFSH_NOT_CONNECTED_ERROR_MESSAGE, 
LOCATOR_TERM_NAME));
 }
   } else {
-final LocatorLauncher locatorLauncher =
-new 
LocatorLauncher.Builder().setCommand(LocatorLauncher.Command.STATUS)
-
.setBindAddress(locatorHost).setDebug(isDebugging()).setPid(pid)
-
.setPort(locatorPort).setWorkingDirectory(workingDirectory).build();
-
+final LocatorLauncher locatorLauncher;
+
+if ((locatorHost == null) && (locatorPort == null) && 
(workingDirectory == null)
+&& (pid == null)) {
+  return ResultBuilder.createShellClientErrorResult(
+  
String.format(CliStrings.STATUS_LOCATOR__NO_LOCATOR_SPECIFIED_ERROR_MESSAGE,
+  getLocatorId(locatorHost, locatorPort),
+  StringUtils.defaultIfBlank(workingDirectory, 
SystemUtils.CURRENT_DIRECTORY)));
--- End diff --

I thought that the simplification of this argument (don't need the 
defaultIfBlank call) was in a previous commit, but it seems to have been 
reverted in your latest commit.


> gfsh status locator/server - Give more descriptive output on empty parameter
> 
>
> Key: GEODE-2203
> URL: https://issues.apache.org/jira/browse/GEODE-2203
> Project: Geode
>  Issue Type: Improvement
>  Components: gfsh
>Reporter: Alyssa Kim
>Assignee: Emily Yeh
>Priority: Minor
>  Labels: StatusLocatorCommand, StatusServerCommand, gfsh, status
>
> Currently, executing some status commands in gfsh without valid parameters 
> gives a vague explanation/output that might be misleading. Although we have 
> help  for usage description, displaying 'null' as an output 
> might not be the best idea.
> Current Result
> {code}
> gfsh>status locator
> null
> {code}
> {code}
> gfsh>status server
> Server in 
> C:\Users\XXX\git\incubator-geode\geode-assembly\build\install\apache-geode\bin
>  on null is currently not responding.
> {code}
> Improvement
> {code}
> gfsh>status locator
> SYNTAX
> status locator [--name=value] [--host=value] [--port=value] [--pid=value]
> Use help status locator to display detailed usage information
> {code}
> {code}
> gfsh>status server
> SYNTAX
> status server [--name=value] [--pid=value] [--dir=value]
> Use help status server to display detailed usage information
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2971) Inconsistency in gfsh status command

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16031551#comment-16031551
 ] 

ASF GitHub Bot commented on GEODE-2971:
---

Github user jaredjstewart commented on a diff in the pull request:

https://github.com/apache/geode/pull/551#discussion_r119419341
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/internal/ShellExitCode.java ---
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
+ * or implied. See the License for the specific language governing 
permissions and limitations under
+ * the License.
+ */
+package org.apache.geode.internal;
+
+public class ShellExitCode {
--- End diff --

This should be an `enum` rather than a `class`.  


> Inconsistency in gfsh status command
> 
>
> Key: GEODE-2971
> URL: https://issues.apache.org/jira/browse/GEODE-2971
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Reporter: Patrick Rhomberg
>
> There is a general inconsistency in gfsh's exit status to the shell.  This 
> makes scripting rather difficult.  For instance:
> * Locator & Server Online (+)
> ** --pid: exit code {{0}} for both, all good.
> ** --name: exit code {{0}} for both, all good.
> ** --dir: exit code {{0}} for both, all good.
> * Locator Online, Server Offline (-)
> ** --pid: exit code is {{0}} for both. Nevertheless, the return string when 
> executing the command for the server returns a {{null}} within the message 
> (where the ip and port should be). As an example: {{Server in 
> /path/to/server/directory on null is currently not responding}}.
> ** --name: exit code is {{0}} for the locator, {{1}} for the server because 
> there's no online member with the specified name... which raises the 
> question: there wasn't any exceptions during the execution, shouldn't we 
> return {{0}}?.
> ** --dir: exit code is {{0}} for both. Nevertheless, the return string when 
> executing the command for the server returns a {{null}} within the message 
> (where the ip and port should be). As an example: {{Server in 
> /path/to/server/directory on null is currently not responding}}.
> * Locator & Server Offline (-)
> ** --pid: exit code for locator is {{1}}, and the return string only contains 
> {{null}}. The exit code for server is {{0}}, but the return string contains a 
> {{null}} within the message (where the ip and port should be). As an example: 
> {{Server in /path/to/server/directory on null is currently not responding}}.
> ** --name: both return {{1}}, which is expected since there's no jmx manager 
> running and this option requires gfsh to be connected.
> ** --dir: exit code for locator is {{1}}, and the return string only contains 
> {{null}}. The exit code for server is {{0}}, but the return string contains a 
> {{null}} within the message (where the ip and port should be). As an example: 
> {{Server in /path/to/server/directory on null is currently not responding}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2971) Inconsistency in gfsh status command

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16031489#comment-16031489
 ] 

ASF GitHub Bot commented on GEODE-2971:
---

GitHub user PurelyApplied opened a pull request:

https://github.com/apache/geode/pull/551

GEODE-2971: consistency in shell exit codes for status commands.

* Replaced all System.exit parameters with ShellExitCode references for 
extensibility
* Added FakeLaunchers to Locator- and ServerStarterRules to spoof member 
status and to register the instance to the Launcher class.  The spoofed status 
is of mixed reliability and only used when connected via jmx (via `--name`, not 
`--dir` or `--pid`).
* Expanded starter rules to spawn PID files in working directory.
* Made `getMemberMXBean` static, added public `isMemberMXBeanAvailable` to 
allow tests to delay tests until server is ready.
* Code cleanup of touched files.

Precheckin ran nearly-fully-green.  One test failure which I suspect to be 
unrelated to these changes.  This test passed cleanly when run with `gradlew 
-distributedTest.single=...`.  Currently rerunning DUnits together to verify.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/PurelyApplied/geode gem-1370

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/551.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #551


commit 91ee3d79102fafa9521a219aa8d3527bea519922
Author: Patrick Rhomberg 
Date:   2017-05-30T21:25:47Z

GEODE-2971: consistency in shell exit codes for status commands.

* Replaced all System.exit calls with ShellExitCode references for 
extensibility
* Added FakeLaunchers to Locator- and ServerStarterRules to spoof member 
status made via jmx (not --pid or --dir options)
* Expanded starter rules to spawn PID files
* Made getMemberMXBean static, made public isMemberMXBeanAvailable to delay 
tests until server is ready.
* Code cleanup of touched files.




> Inconsistency in gfsh status command
> 
>
> Key: GEODE-2971
> URL: https://issues.apache.org/jira/browse/GEODE-2971
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Reporter: Patrick Rhomberg
>
> There is a general inconsistency in gfsh's exit status to the shell.  This 
> makes scripting rather difficult.  For instance:
> * Locator & Server Online (+)
> ** --pid: exit code {{0}} for both, all good.
> ** --name: exit code {{0}} for both, all good.
> ** --dir: exit code {{0}} for both, all good.
> * Locator Online, Server Offline (-)
> ** --pid: exit code is {{0}} for both. Nevertheless, the return string when 
> executing the command for the server returns a {{null}} within the message 
> (where the ip and port should be). As an example: {{Server in 
> /path/to/server/directory on null is currently not responding}}.
> ** --name: exit code is {{0}} for the locator, {{1}} for the server because 
> there's no online member with the specified name... which raises the 
> question: there wasn't any exceptions during the execution, shouldn't we 
> return {{0}}?.
> ** --dir: exit code is {{0}} for both. Nevertheless, the return string when 
> executing the command for the server returns a {{null}} within the message 
> (where the ip and port should be). As an example: {{Server in 
> /path/to/server/directory on null is currently not responding}}.
> * Locator & Server Offline (-)
> ** --pid: exit code for locator is {{1}}, and the return string only contains 
> {{null}}. The exit code for server is {{0}}, but the return string contains a 
> {{null}} within the message (where the ip and port should be). As an example: 
> {{Server in /path/to/server/directory on null is currently not responding}}.
> ** --name: both return {{1}}, which is expected since there's no jmx manager 
> running and this option requires gfsh to be connected.
> ** --dir: exit code for locator is {{1}}, and the return string only contains 
> {{null}}. The exit code for server is {{0}}, but the return string contains a 
> {{null}} within the message (where the ip and port should be). As an example: 
> {{Server in /path/to/server/directory on null is currently not responding}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2957) null used as a default parameter when specifying analyzers

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16030296#comment-16030296
 ] 

ASF GitHub Bot commented on GEODE-2957:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/543


> null used as a default parameter when specifying analyzers
> --
>
> Key: GEODE-2957
> URL: https://issues.apache.org/jira/browse/GEODE-2957
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Jason Huynh
>Assignee: David Anuta
> Fix For: 1.2.0
>
>
> null seems to be the way to specify using the default 
> StandardKeywordAnalyzer. This can be used when specifying a long list of 
> field/analyzers.  
> So the line may look like 
> --analyzers="null,SomeAnalyzer,null,null,SomeAnalyzer}
>  We should probably change that to default or some other keyword.  null seems 
> a bit confusing.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2957) null used as a default parameter when specifying analyzers

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16030285#comment-16030285
 ] 

ASF GitHub Bot commented on GEODE-2957:
---

Github user joeymcallister commented on a diff in the pull request:

https://github.com/apache/geode/pull/543#discussion_r119232692
  
--- Diff: geode-docs/tools_modules/lucene_integration.html.md.erb ---
@@ -89,10 +89,10 @@ gfsh>create lucene index --name=indexName 
--region=/orders --field=customer,tags
 
 ``` pre
 // Create an index, specifying a custom analyzer for the second field
-// Note: "null" in the first analyzer position uses the default analyzer
+// Note: "DEFAULT" in the first analyzer position uses the default analyzer
 // for the first field
 gfsh>create lucene index --name=indexName --region=/orders
-  --field=customer,tags 
--analyzer=null,org.apache.lucene.analysis.bg.BulgarianAnalyzer
+  --field=customer,tags 
--analyzer=DEFAULT,org.apache.lucene.analysis.bg.BulgarianAnalyzer
 ```
 To use the entire value as a single field set the required `--field`
--- End diff --

Cool. LGTM, then. +1


> null used as a default parameter when specifying analyzers
> --
>
> Key: GEODE-2957
> URL: https://issues.apache.org/jira/browse/GEODE-2957
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Jason Huynh
>Assignee: David Anuta
> Fix For: 1.2.0
>
>
> null seems to be the way to specify using the default 
> StandardKeywordAnalyzer. This can be used when specifying a long list of 
> field/analyzers.  
> So the line may look like 
> --analyzers="null,SomeAnalyzer,null,null,SomeAnalyzer}
>  We should probably change that to default or some other keyword.  null seems 
> a bit confusing.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2957) null used as a default parameter when specifying analyzers

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16030274#comment-16030274
 ] 

ASF GitHub Bot commented on GEODE-2957:
---

Github user karensmolermiller commented on a diff in the pull request:

https://github.com/apache/geode/pull/543#discussion_r119231641
  
--- Diff: geode-docs/tools_modules/lucene_integration.html.md.erb ---
@@ -89,10 +89,10 @@ gfsh>create lucene index --name=indexName 
--region=/orders --field=customer,tags
 
 ``` pre
 // Create an index, specifying a custom analyzer for the second field
-// Note: "null" in the first analyzer position uses the default analyzer
+// Note: "DEFAULT" in the first analyzer position uses the default analyzer
 // for the first field
 gfsh>create lucene index --name=indexName --region=/orders
-  --field=customer,tags 
--analyzer=null,org.apache.lucene.analysis.bg.BulgarianAnalyzer
+  --field=customer,tags 
--analyzer=DEFAULT,org.apache.lucene.analysis.bg.BulgarianAnalyzer
 ```
 To use the entire value as a single field set the required `--field`
--- End diff --

The sentence that needs the comma has been completely rewritten for 
GEODE-3002. See PR https://github.com/apache/geode/pull/550 for the rewrite.  
Not implementing, as it would only cause a conflict upon merging in GEODE-3002.


> null used as a default parameter when specifying analyzers
> --
>
> Key: GEODE-2957
> URL: https://issues.apache.org/jira/browse/GEODE-2957
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Jason Huynh
>Assignee: David Anuta
> Fix For: 1.2.0
>
>
> null seems to be the way to specify using the default 
> StandardKeywordAnalyzer. This can be used when specifying a long list of 
> field/analyzers.  
> So the line may look like 
> --analyzers="null,SomeAnalyzer,null,null,SomeAnalyzer}
>  We should probably change that to default or some other keyword.  null seems 
> a bit confusing.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2203) gfsh status locator/server - Give more descriptive output on empty parameter

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16030267#comment-16030267
 ] 

ASF GitHub Bot commented on GEODE-2203:
---

Github user jaredjstewart commented on a diff in the pull request:

https://github.com/apache/geode/pull/549#discussion_r119231037
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java
 ---
@@ -2747,6 +2749,8 @@
   public static final String STATUS_SERVER__DIR = "dir";
   public static final String STATUS_SERVER__DIR__HELP =
   "Working directory in which the Cache Server is running. The default 
is the current directory.";
+  public static final String 
STATUS_SERVER__NO_SERVER_SPECIFIED_ERROR_MESSAGE =
--- End diff --

I believe the `running in %2$s` portion of this output is going to be 
misleading when the status locator command has omitted the `workingDirectory` 
option.  For example, if I ask for the status of a remote locator by specifying 
its hostname and port, this message will suggest that we expect the locator to 
be running in the current directory on the GFSH client machine.  It might also 
be helpful for this message to explain *why* we are unable to determine the 
status of this Locator.  Maybe something like  "At least one of the following 
options must be specified:  `--name`, `--host`, or `--port`.   Use 'help status 
server' to display detailed usage information." would be more helpful.


> gfsh status locator/server - Give more descriptive output on empty parameter
> 
>
> Key: GEODE-2203
> URL: https://issues.apache.org/jira/browse/GEODE-2203
> Project: Geode
>  Issue Type: Improvement
>  Components: gfsh
>Reporter: Alyssa Kim
>Assignee: Emily Yeh
>Priority: Minor
>  Labels: StatusLocatorCommand, StatusServerCommand, gfsh, status
>
> Currently, executing some status commands in gfsh without valid parameters 
> gives a vague explanation/output that might be misleading. Although we have 
> help  for usage description, displaying 'null' as an output 
> might not be the best idea.
> Current Result
> {code}
> gfsh>status locator
> null
> {code}
> {code}
> gfsh>status server
> Server in 
> C:\Users\XXX\git\incubator-geode\geode-assembly\build\install\apache-geode\bin
>  on null is currently not responding.
> {code}
> Improvement
> {code}
> gfsh>status locator
> SYNTAX
> status locator [--name=value] [--host=value] [--port=value] [--pid=value]
> Use help status locator to display detailed usage information
> {code}
> {code}
> gfsh>status server
> SYNTAX
> status server [--name=value] [--pid=value] [--dir=value]
> Use help status server to display detailed usage information
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2203) gfsh status locator/server - Give more descriptive output on empty parameter

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16030245#comment-16030245
 ] 

ASF GitHub Bot commented on GEODE-2203:
---

Github user jaredjstewart commented on a diff in the pull request:

https://github.com/apache/geode/pull/549#discussion_r119229190
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java
 ---
@@ -771,11 +771,18 @@ public Result statusLocator(
   CliStrings.STATUS_SERVICE__GFSH_NOT_CONNECTED_ERROR_MESSAGE, 
LOCATOR_TERM_NAME));
 }
   } else {
-final LocatorLauncher locatorLauncher =
-new 
LocatorLauncher.Builder().setCommand(LocatorLauncher.Command.STATUS)
-
.setBindAddress(locatorHost).setDebug(isDebugging()).setPid(pid)
-
.setPort(locatorPort).setWorkingDirectory(workingDirectory).build();
+final LocatorLauncher locatorLauncher;
 
+if ((locatorHost == null) && (locatorPort == null) && 
(workingDirectory == null)) {
--- End diff --

I had thought that `locatorPort` would not uniquely identify a locator 
without also specifying a `locatorHost`, but it looks like we might end up 
falling back to a default value of localhost.  It would be nice to add a test 
that make sure this works as expected.  (I can pair with you on that if you'd 
like!)


> gfsh status locator/server - Give more descriptive output on empty parameter
> 
>
> Key: GEODE-2203
> URL: https://issues.apache.org/jira/browse/GEODE-2203
> Project: Geode
>  Issue Type: Improvement
>  Components: gfsh
>Reporter: Alyssa Kim
>Assignee: Emily Yeh
>Priority: Minor
>  Labels: StatusLocatorCommand, StatusServerCommand, gfsh, status
>
> Currently, executing some status commands in gfsh without valid parameters 
> gives a vague explanation/output that might be misleading. Although we have 
> help  for usage description, displaying 'null' as an output 
> might not be the best idea.
> Current Result
> {code}
> gfsh>status locator
> null
> {code}
> {code}
> gfsh>status server
> Server in 
> C:\Users\XXX\git\incubator-geode\geode-assembly\build\install\apache-geode\bin
>  on null is currently not responding.
> {code}
> Improvement
> {code}
> gfsh>status locator
> SYNTAX
> status locator [--name=value] [--host=value] [--port=value] [--pid=value]
> Use help status locator to display detailed usage information
> {code}
> {code}
> gfsh>status server
> SYNTAX
> status server [--name=value] [--pid=value] [--dir=value]
> Use help status server to display detailed usage information
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2975) Attributes are not validated in lucene xml configuration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16030227#comment-16030227
 ] 

ASF GitHub Bot commented on GEODE-2975:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode-site/pull/5


> Attributes are not validated in lucene xml configuration
> 
>
> Key: GEODE-2975
> URL: https://issues.apache.org/jira/browse/GEODE-2975
> Project: Geode
>  Issue Type: Bug
>  Components: docs, lucene
>Reporter: Barry Oglesby
> Fix For: 1.2.0
>
>
> No exception is thrown for a lucene xml configuration missing a required 
> attribute.
> No exception is thrown for a lucene xml configuration including an unknown 
> attribute.
> If a {{lucene:field}} element is defined like below, no exception is thrown 
> for the invalid attribute called {{namexx}} and no exceptio is thrown because 
> the required attribute called {{name}} is not included.
> {noformat}
> 
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2203) gfsh status locator/server - Give more descriptive output on empty parameter

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16030212#comment-16030212
 ] 

ASF GitHub Bot commented on GEODE-2203:
---

Github user YehEmily commented on a diff in the pull request:

https://github.com/apache/geode/pull/549#discussion_r119225797
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java
 ---
@@ -1794,18 +1801,20 @@ public Result statusServer(
   
.format(CliStrings.STATUS_SERVICE__GFSH_NOT_CONNECTED_ERROR_MESSAGE, "Cache 
Server"));
 }
   } else {
-final ServerLauncher serverLauncher = new ServerLauncher.Builder()
-
.setCommand(ServerLauncher.Command.STATUS).setDebug(isDebugging())
-// NOTE since we do not know whether the "CacheServer" was 
enabled or not on the GemFire
-// server when it was started, set the disableDefaultServer 
property in the
-// ServerLauncher.Builder to default status
-// to the MemberMBean
-// TODO fix this hack! (how, the 'start server' loop needs it)
-
.setDisableDefaultServer(true).setPid(pid).setWorkingDirectory(workingDirectory)
-.build();
-
+final ServerLauncher serverLauncher;
+if ((member == null)) {
--- End diff --

Oops, that's very true - thanks! I'll update the PR.


> gfsh status locator/server - Give more descriptive output on empty parameter
> 
>
> Key: GEODE-2203
> URL: https://issues.apache.org/jira/browse/GEODE-2203
> Project: Geode
>  Issue Type: Improvement
>  Components: gfsh
>Reporter: Alyssa Kim
>Assignee: Emily Yeh
>Priority: Minor
>  Labels: StatusLocatorCommand, StatusServerCommand, gfsh, status
>
> Currently, executing some status commands in gfsh without valid parameters 
> gives a vague explanation/output that might be misleading. Although we have 
> help  for usage description, displaying 'null' as an output 
> might not be the best idea.
> Current Result
> {code}
> gfsh>status locator
> null
> {code}
> {code}
> gfsh>status server
> Server in 
> C:\Users\XXX\git\incubator-geode\geode-assembly\build\install\apache-geode\bin
>  on null is currently not responding.
> {code}
> Improvement
> {code}
> gfsh>status locator
> SYNTAX
> status locator [--name=value] [--host=value] [--port=value] [--pid=value]
> Use help status locator to display detailed usage information
> {code}
> {code}
> gfsh>status server
> SYNTAX
> status server [--name=value] [--pid=value] [--dir=value]
> Use help status server to display detailed usage information
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2203) gfsh status locator/server - Give more descriptive output on empty parameter

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16030207#comment-16030207
 ] 

ASF GitHub Bot commented on GEODE-2203:
---

Github user YehEmily commented on a diff in the pull request:

https://github.com/apache/geode/pull/549#discussion_r119225532
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java
 ---
@@ -771,11 +771,18 @@ public Result statusLocator(
   CliStrings.STATUS_SERVICE__GFSH_NOT_CONNECTED_ERROR_MESSAGE, 
LOCATOR_TERM_NAME));
 }
   } else {
-final LocatorLauncher locatorLauncher =
-new 
LocatorLauncher.Builder().setCommand(LocatorLauncher.Command.STATUS)
-
.setBindAddress(locatorHost).setDebug(isDebugging()).setPid(pid)
-
.setPort(locatorPort).setWorkingDirectory(workingDirectory).build();
+final LocatorLauncher locatorLauncher;
 
+if ((locatorHost == null) && (locatorPort == null) && 
(workingDirectory == null)) {
--- End diff --

I think that if a value is given for locatorPort but not for locatorHost, 
`locatorLauncher` will just have a null value for locatorPort, with no errors 
(in the `else` statement). Do you mean there will be an error in a different 
part of the code?


> gfsh status locator/server - Give more descriptive output on empty parameter
> 
>
> Key: GEODE-2203
> URL: https://issues.apache.org/jira/browse/GEODE-2203
> Project: Geode
>  Issue Type: Improvement
>  Components: gfsh
>Reporter: Alyssa Kim
>Assignee: Emily Yeh
>Priority: Minor
>  Labels: StatusLocatorCommand, StatusServerCommand, gfsh, status
>
> Currently, executing some status commands in gfsh without valid parameters 
> gives a vague explanation/output that might be misleading. Although we have 
> help  for usage description, displaying 'null' as an output 
> might not be the best idea.
> Current Result
> {code}
> gfsh>status locator
> null
> {code}
> {code}
> gfsh>status server
> Server in 
> C:\Users\XXX\git\incubator-geode\geode-assembly\build\install\apache-geode\bin
>  on null is currently not responding.
> {code}
> Improvement
> {code}
> gfsh>status locator
> SYNTAX
> status locator [--name=value] [--host=value] [--port=value] [--pid=value]
> Use help status locator to display detailed usage information
> {code}
> {code}
> gfsh>status server
> SYNTAX
> status server [--name=value] [--pid=value] [--dir=value]
> Use help status server to display detailed usage information
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2203) gfsh status locator/server - Give more descriptive output on empty parameter

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16030208#comment-16030208
 ] 

ASF GitHub Bot commented on GEODE-2203:
---

Github user YehEmily commented on a diff in the pull request:

https://github.com/apache/geode/pull/549#discussion_r119225590
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java
 ---
@@ -771,11 +771,18 @@ public Result statusLocator(
   CliStrings.STATUS_SERVICE__GFSH_NOT_CONNECTED_ERROR_MESSAGE, 
LOCATOR_TERM_NAME));
 }
   } else {
-final LocatorLauncher locatorLauncher =
-new 
LocatorLauncher.Builder().setCommand(LocatorLauncher.Command.STATUS)
-
.setBindAddress(locatorHost).setDebug(isDebugging()).setPid(pid)
-
.setPort(locatorPort).setWorkingDirectory(workingDirectory).build();
+final LocatorLauncher locatorLauncher;
 
+if ((locatorHost == null) && (locatorPort == null) && 
(workingDirectory == null)) {
+  return ResultBuilder.createShellClientErrorResult(
+  
String.format(CliStrings.STATUS_LOCATOR__NO_LOCATOR_SPECIFIED_ERROR_MESSAGE,
+  getLocatorId(locatorHost, locatorPort),
+  StringUtils.defaultIfBlank(workingDirectory, 
SystemUtils.CURRENT_DIRECTORY)));
--- End diff --

Got it - thanks! I'll update the PR.


> gfsh status locator/server - Give more descriptive output on empty parameter
> 
>
> Key: GEODE-2203
> URL: https://issues.apache.org/jira/browse/GEODE-2203
> Project: Geode
>  Issue Type: Improvement
>  Components: gfsh
>Reporter: Alyssa Kim
>Assignee: Emily Yeh
>Priority: Minor
>  Labels: StatusLocatorCommand, StatusServerCommand, gfsh, status
>
> Currently, executing some status commands in gfsh without valid parameters 
> gives a vague explanation/output that might be misleading. Although we have 
> help  for usage description, displaying 'null' as an output 
> might not be the best idea.
> Current Result
> {code}
> gfsh>status locator
> null
> {code}
> {code}
> gfsh>status server
> Server in 
> C:\Users\XXX\git\incubator-geode\geode-assembly\build\install\apache-geode\bin
>  on null is currently not responding.
> {code}
> Improvement
> {code}
> gfsh>status locator
> SYNTAX
> status locator [--name=value] [--host=value] [--port=value] [--pid=value]
> Use help status locator to display detailed usage information
> {code}
> {code}
> gfsh>status server
> SYNTAX
> status server [--name=value] [--pid=value] [--dir=value]
> Use help status server to display detailed usage information
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2203) gfsh status locator/server - Give more descriptive output on empty parameter

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16030177#comment-16030177
 ] 

ASF GitHub Bot commented on GEODE-2203:
---

Github user pdxrunner commented on a diff in the pull request:

https://github.com/apache/geode/pull/549#discussion_r119221757
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java
 ---
@@ -771,11 +771,18 @@ public Result statusLocator(
   CliStrings.STATUS_SERVICE__GFSH_NOT_CONNECTED_ERROR_MESSAGE, 
LOCATOR_TERM_NAME));
 }
   } else {
-final LocatorLauncher locatorLauncher =
-new 
LocatorLauncher.Builder().setCommand(LocatorLauncher.Command.STATUS)
-
.setBindAddress(locatorHost).setDebug(isDebugging()).setPid(pid)
-
.setPort(locatorPort).setWorkingDirectory(workingDirectory).build();
+final LocatorLauncher locatorLauncher;
 
+if ((locatorHost == null) && (locatorPort == null) && 
(workingDirectory == null)) {
+  return ResultBuilder.createShellClientErrorResult(
+  
String.format(CliStrings.STATUS_LOCATOR__NO_LOCATOR_SPECIFIED_ERROR_MESSAGE,
+  getLocatorId(locatorHost, locatorPort),
+  StringUtils.defaultIfBlank(workingDirectory, 
SystemUtils.CURRENT_DIRECTORY)));
--- End diff --

workingDirectory == null in this clause of the if, so this argument can 
just be SystemUtils.CURRENT_DIRECTORY


> gfsh status locator/server - Give more descriptive output on empty parameter
> 
>
> Key: GEODE-2203
> URL: https://issues.apache.org/jira/browse/GEODE-2203
> Project: Geode
>  Issue Type: Improvement
>  Components: gfsh
>Reporter: Alyssa Kim
>Assignee: Emily Yeh
>Priority: Minor
>  Labels: StatusLocatorCommand, StatusServerCommand, gfsh, status
>
> Currently, executing some status commands in gfsh without valid parameters 
> gives a vague explanation/output that might be misleading. Although we have 
> help  for usage description, displaying 'null' as an output 
> might not be the best idea.
> Current Result
> {code}
> gfsh>status locator
> null
> {code}
> {code}
> gfsh>status server
> Server in 
> C:\Users\XXX\git\incubator-geode\geode-assembly\build\install\apache-geode\bin
>  on null is currently not responding.
> {code}
> Improvement
> {code}
> gfsh>status locator
> SYNTAX
> status locator [--name=value] [--host=value] [--port=value] [--pid=value]
> Use help status locator to display detailed usage information
> {code}
> {code}
> gfsh>status server
> SYNTAX
> status server [--name=value] [--pid=value] [--dir=value]
> Use help status server to display detailed usage information
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2203) gfsh status locator/server - Give more descriptive output on empty parameter

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16030169#comment-16030169
 ] 

ASF GitHub Bot commented on GEODE-2203:
---

Github user jaredjstewart commented on a diff in the pull request:

https://github.com/apache/geode/pull/549#discussion_r119220596
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java
 ---
@@ -1794,18 +1801,20 @@ public Result statusServer(
   
.format(CliStrings.STATUS_SERVICE__GFSH_NOT_CONNECTED_ERROR_MESSAGE, "Cache 
Server"));
 }
   } else {
-final ServerLauncher serverLauncher = new ServerLauncher.Builder()
-
.setCommand(ServerLauncher.Command.STATUS).setDebug(isDebugging())
-// NOTE since we do not know whether the "CacheServer" was 
enabled or not on the GemFire
-// server when it was started, set the disableDefaultServer 
property in the
-// ServerLauncher.Builder to default status
-// to the MemberMBean
-// TODO fix this hack! (how, the 'start server' loop needs it)
-
.setDisableDefaultServer(true).setPid(pid).setWorkingDirectory(workingDirectory)
-.build();
-
+final ServerLauncher serverLauncher;
+if ((member == null)) {
--- End diff --

It looks like we're guaranteed that `member` is not blank in this `else` 
block, so I think we are guaranteed that `member` is not null here.


> gfsh status locator/server - Give more descriptive output on empty parameter
> 
>
> Key: GEODE-2203
> URL: https://issues.apache.org/jira/browse/GEODE-2203
> Project: Geode
>  Issue Type: Improvement
>  Components: gfsh
>Reporter: Alyssa Kim
>Assignee: Emily Yeh
>Priority: Minor
>  Labels: StatusLocatorCommand, StatusServerCommand, gfsh, status
>
> Currently, executing some status commands in gfsh without valid parameters 
> gives a vague explanation/output that might be misleading. Although we have 
> help  for usage description, displaying 'null' as an output 
> might not be the best idea.
> Current Result
> {code}
> gfsh>status locator
> null
> {code}
> {code}
> gfsh>status server
> Server in 
> C:\Users\XXX\git\incubator-geode\geode-assembly\build\install\apache-geode\bin
>  on null is currently not responding.
> {code}
> Improvement
> {code}
> gfsh>status locator
> SYNTAX
> status locator [--name=value] [--host=value] [--port=value] [--pid=value]
> Use help status locator to display detailed usage information
> {code}
> {code}
> gfsh>status server
> SYNTAX
> status server [--name=value] [--pid=value] [--dir=value]
> Use help status server to display detailed usage information
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2203) gfsh status locator/server - Give more descriptive output on empty parameter

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16030170#comment-16030170
 ] 

ASF GitHub Bot commented on GEODE-2203:
---

Github user jaredjstewart commented on a diff in the pull request:

https://github.com/apache/geode/pull/549#discussion_r119219867
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java
 ---
@@ -771,11 +771,18 @@ public Result statusLocator(
   CliStrings.STATUS_SERVICE__GFSH_NOT_CONNECTED_ERROR_MESSAGE, 
LOCATOR_TERM_NAME));
 }
   } else {
-final LocatorLauncher locatorLauncher =
-new 
LocatorLauncher.Builder().setCommand(LocatorLauncher.Command.STATUS)
-
.setBindAddress(locatorHost).setDebug(isDebugging()).setPid(pid)
-
.setPort(locatorPort).setWorkingDirectory(workingDirectory).build();
+final LocatorLauncher locatorLauncher;
 
+if ((locatorHost == null) && (locatorPort == null) && 
(workingDirectory == null)) {
--- End diff --

What if `locatorPort` is specified, but `locatorHost` is not?  It seems 
like that might pass this check, but still result in an error.


> gfsh status locator/server - Give more descriptive output on empty parameter
> 
>
> Key: GEODE-2203
> URL: https://issues.apache.org/jira/browse/GEODE-2203
> Project: Geode
>  Issue Type: Improvement
>  Components: gfsh
>Reporter: Alyssa Kim
>Assignee: Emily Yeh
>Priority: Minor
>  Labels: StatusLocatorCommand, StatusServerCommand, gfsh, status
>
> Currently, executing some status commands in gfsh without valid parameters 
> gives a vague explanation/output that might be misleading. Although we have 
> help  for usage description, displaying 'null' as an output 
> might not be the best idea.
> Current Result
> {code}
> gfsh>status locator
> null
> {code}
> {code}
> gfsh>status server
> Server in 
> C:\Users\XXX\git\incubator-geode\geode-assembly\build\install\apache-geode\bin
>  on null is currently not responding.
> {code}
> Improvement
> {code}
> gfsh>status locator
> SYNTAX
> status locator [--name=value] [--host=value] [--port=value] [--pid=value]
> Use help status locator to display detailed usage information
> {code}
> {code}
> gfsh>status server
> SYNTAX
> status server [--name=value] [--pid=value] [--dir=value]
> Use help status server to display detailed usage information
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2957) null used as a default parameter when specifying analyzers

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16030156#comment-16030156
 ] 

ASF GitHub Bot commented on GEODE-2957:
---

Github user joeymcallister commented on a diff in the pull request:

https://github.com/apache/geode/pull/543#discussion_r119218480
  
--- Diff: geode-docs/tools_modules/lucene_integration.html.md.erb ---
@@ -89,10 +89,10 @@ gfsh>create lucene index --name=indexName 
--region=/orders --field=customer,tags
 
 ``` pre
 // Create an index, specifying a custom analyzer for the second field
-// Note: "null" in the first analyzer position uses the default analyzer
+// Note: "DEFAULT" in the first analyzer position uses the default analyzer
 // for the first field
 gfsh>create lucene index --name=indexName --region=/orders
-  --field=customer,tags 
--analyzer=null,org.apache.lucene.analysis.bg.BulgarianAnalyzer
+  --field=customer,tags 
--analyzer=DEFAULT,org.apache.lucene.analysis.bg.BulgarianAnalyzer
 ```
 To use the entire value as a single field set the required `--field`
--- End diff --

Add a comma between "field" and "set"



> null used as a default parameter when specifying analyzers
> --
>
> Key: GEODE-2957
> URL: https://issues.apache.org/jira/browse/GEODE-2957
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Jason Huynh
>Assignee: David Anuta
> Fix For: 1.2.0
>
>
> null seems to be the way to specify using the default 
> StandardKeywordAnalyzer. This can be used when specifying a long list of 
> field/analyzers.  
> So the line may look like 
> --analyzers="null,SomeAnalyzer,null,null,SomeAnalyzer}
>  We should probably change that to default or some other keyword.  null seems 
> a bit confusing.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2975) Attributes are not validated in lucene xml configuration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16030155#comment-16030155
 ] 

ASF GitHub Bot commented on GEODE-2975:
---

Github user upthewaterspout commented on the issue:

https://github.com/apache/geode/pull/538
  
@boglesby - Let me know what you think of the new changes. I added some 
validation to the code.


> Attributes are not validated in lucene xml configuration
> 
>
> Key: GEODE-2975
> URL: https://issues.apache.org/jira/browse/GEODE-2975
> Project: Geode
>  Issue Type: Bug
>  Components: docs, lucene
>Reporter: Barry Oglesby
> Fix For: 1.2.0
>
>
> No exception is thrown for a lucene xml configuration missing a required 
> attribute.
> No exception is thrown for a lucene xml configuration including an unknown 
> attribute.
> If a {{lucene:field}} element is defined like below, no exception is thrown 
> for the invalid attribute called {{namexx}} and no exceptio is thrown because 
> the required attribute called {{name}} is not included.
> {noformat}
> 
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-3002) Improve doc of (Lucene) __REGION_VALUE_FIELD

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16030145#comment-16030145
 ] 

ASF GitHub Bot commented on GEODE-3002:
---

Github user joeymcallister commented on a diff in the pull request:

https://github.com/apache/geode/pull/550#discussion_r119217398
  
--- Diff: geode-docs/tools_modules/gfsh/command-pages/search.html.md.erb ---
@@ -62,12 +62,12 @@ search lucene --name=value --region=value 
--queryStrings=value --defaultField=va
 
 
 queryStrings
-Required. Query string to search the lucene index.
+Required. Query string to search the lucene index. Use 
__REGION_VALUE_FIELD as the field name within the query string 
when the field is a primitive value.
--- End diff --

Is there a contextual reason to use "lucene index" here, rather than 
"Lucene" index with a capital L?


> Improve doc of (Lucene) __REGION_VALUE_FIELD
> 
>
> Key: GEODE-3002
> URL: https://issues.apache.org/jira/browse/GEODE-3002
> Project: Geode
>  Issue Type: Bug
>  Components: docs
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
>Priority: Minor
>
> The original description of {{__REGION_VALUE_FIELD}} is not quite right. In 
> addition, there is an example gfsh command using this value that is wrong.  
> It is in the {{gfsh create lucene index}} command reference page.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-3002) Improve doc of (Lucene) __REGION_VALUE_FIELD

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16030142#comment-16030142
 ] 

ASF GitHub Bot commented on GEODE-3002:
---

Github user dihardman commented on the issue:

https://github.com/apache/geode/pull/550
  
+1, thanks the new description is more accurate.

On Tue, May 30, 2017 at 2:12 PM, Dave Barnes 
wrote:

> *@davebarnes97* approved this pull request.
>
> +! LGTM
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> , or 
mute
> the thread
> 

> .
>



> Improve doc of (Lucene) __REGION_VALUE_FIELD
> 
>
> Key: GEODE-3002
> URL: https://issues.apache.org/jira/browse/GEODE-3002
> Project: Geode
>  Issue Type: Bug
>  Components: docs
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
>Priority: Minor
>
> The original description of {{__REGION_VALUE_FIELD}} is not quite right. In 
> addition, there is an example gfsh command using this value that is wrong.  
> It is in the {{gfsh create lucene index}} command reference page.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2975) Attributes are not validated in lucene xml configuration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16030138#comment-16030138
 ] 

ASF GitHub Bot commented on GEODE-2975:
---

Github user upthewaterspout commented on the issue:

https://github.com/apache/geode/pull/538
  
@boglesby - I see the problem with lucene:indexxx. It looks like in 
cache-1.0.xsd, which specify this in order to allow other schemas (like 
lucene.xsd) to extend region with additional elements:

`
  
`

Unfortunately, using 'lax' instead of 'strict' here means that we don't 
validate the new xsd as strictly - additional elements are ignored, etc.

I'm worried about the impact of changing this validation. I think the thing 
to do maybe is just to give a little better error message in our java code and 
call it a day.


> Attributes are not validated in lucene xml configuration
> 
>
> Key: GEODE-2975
> URL: https://issues.apache.org/jira/browse/GEODE-2975
> Project: Geode
>  Issue Type: Bug
>  Components: docs, lucene
>Reporter: Barry Oglesby
> Fix For: 1.2.0
>
>
> No exception is thrown for a lucene xml configuration missing a required 
> attribute.
> No exception is thrown for a lucene xml configuration including an unknown 
> attribute.
> If a {{lucene:field}} element is defined like below, no exception is thrown 
> for the invalid attribute called {{namexx}} and no exceptio is thrown because 
> the required attribute called {{name}} is not included.
> {noformat}
> 
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2957) null used as a default parameter when specifying analyzers

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16030135#comment-16030135
 ] 

ASF GitHub Bot commented on GEODE-2957:
---

Github user DivineEnder commented on the issue:

https://github.com/apache/geode/pull/543
  
Looks good  


> null used as a default parameter when specifying analyzers
> --
>
> Key: GEODE-2957
> URL: https://issues.apache.org/jira/browse/GEODE-2957
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Jason Huynh
>Assignee: David Anuta
> Fix For: 1.2.0
>
>
> null seems to be the way to specify using the default 
> StandardKeywordAnalyzer. This can be used when specifying a long list of 
> field/analyzers.  
> So the line may look like 
> --analyzers="null,SomeAnalyzer,null,null,SomeAnalyzer}
>  We should probably change that to default or some other keyword.  null seems 
> a bit confusing.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2952) gfsh doesn't support exact match lucene queries

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16030111#comment-16030111
 ] 

ASF GitHub Bot commented on GEODE-2952:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/545


> gfsh doesn't support exact match lucene queries
> ---
>
> Key: GEODE-2952
> URL: https://issues.apache.org/jira/browse/GEODE-2952
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Barry Oglesby
>Assignee: David Anuta
> Fix For: 1.2.0
>
>
> This command:
> {noformat}
> gfsh>search lucene --name=index --region=data 
> --defaultField=Resolution_Description --queryStrings='Police Dept'
> {noformat}
> Runs this lucene query:
> {noformat}
> Resolution_Description:police Resolution_Description:dept
> {noformat}
> I also tried this command which ran the same lucene query as above:
> {noformat}
> gfsh>search lucene --name=index --region=data 
> --defaultField=Resolution_Description --queryStrings='\"Police Dept\"'
> {noformat}
> The java API supports exact match queries with "" around the queryString. 
> Doing this causes this lucene query to be run:
> {noformat}
> Resolution_Description:"police dept"
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-3002) Improve doc of (Lucene) __REGION_VALUE_FIELD

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16030094#comment-16030094
 ] 

ASF GitHub Bot commented on GEODE-3002:
---

GitHub user karensmolermiller opened a pull request:

https://github.com/apache/geode/pull/550

GEODE-3002 Clarify __REGION_VALUE_FIELD in Lucene docs

 Review please: @nabarunnag @upthewaterspout @jhuynh1 @DevineEnder 
@dihardman @boglesby @joeymcallister  @davebarnes97 


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/karensmolermiller/geode feature/GEODE-3002

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/550.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #550


commit 4c0c86a25e788444b510f26aa1c5c8e3837ef32d
Author: Karen Miller 
Date:   2017-05-30T20:39:00Z

GEODE-3002 Clarify __REGION_VALUE_FIELD in Lucene docs




> Improve doc of (Lucene) __REGION_VALUE_FIELD
> 
>
> Key: GEODE-3002
> URL: https://issues.apache.org/jira/browse/GEODE-3002
> Project: Geode
>  Issue Type: Bug
>  Components: docs
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
>Priority: Minor
>
> The original description of {{__REGION_VALUE_FIELD}} is not quite right. In 
> addition, there is an example gfsh command using this value that is wrong.  
> It is in the {{gfsh create lucene index}} command reference page.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2203) gfsh status locator/server - Give more descriptive output on empty parameter

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16030064#comment-16030064
 ] 

ASF GitHub Bot commented on GEODE-2203:
---

GitHub user YehEmily opened a pull request:

https://github.com/apache/geode/pull/549

GEODE-2203: gfsh status locator/server - Command now gives more descr…

…iptive output on empty parameter

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/YehEmily/geode GEODE-2203

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/549.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #549


commit 784ded407a0d16dc7fbf3c6693d0e1a8443fdd44
Author: YehEmily 
Date:   2017-05-26T22:54:46Z

GEODE-2203: gfsh status locator/server - Command now gives more descriptive 
output on empty parameter




> gfsh status locator/server - Give more descriptive output on empty parameter
> 
>
> Key: GEODE-2203
> URL: https://issues.apache.org/jira/browse/GEODE-2203
> Project: Geode
>  Issue Type: Improvement
>  Components: gfsh
>Reporter: Alyssa Kim
>Assignee: Emily Yeh
>Priority: Minor
>  Labels: StatusLocatorCommand, StatusServerCommand, gfsh, status
>
> Currently, executing some status commands in gfsh without valid parameters 
> gives a vague explanation/output that might be misleading. Although we have 
> help  for usage description, displaying 'null' as an output 
> might not be the best idea.
> Current Result
> {code}
> gfsh>status locator
> null
> {code}
> {code}
> gfsh>status server
> Server in 
> C:\Users\XXX\git\incubator-geode\geode-assembly\build\install\apache-geode\bin
>  on null is currently not responding.
> {code}
> Improvement
> {code}
> gfsh>status locator
> SYNTAX
> status locator [--name=value] [--host=value] [--port=value] [--pid=value]
> Use help status locator to display detailed usage information
> {code}
> {code}
> gfsh>status server
> SYNTAX
> status server [--name=value] [--pid=value] [--dir=value]
> Use help status server to display detailed usage information
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2203) gfsh status locator/server - Give more descriptive output on empty parameter

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16030065#comment-16030065
 ] 

ASF GitHub Bot commented on GEODE-2203:
---

Github user YehEmily commented on the issue:

https://github.com/apache/geode/pull/549
  
Precheckin pending!


> gfsh status locator/server - Give more descriptive output on empty parameter
> 
>
> Key: GEODE-2203
> URL: https://issues.apache.org/jira/browse/GEODE-2203
> Project: Geode
>  Issue Type: Improvement
>  Components: gfsh
>Reporter: Alyssa Kim
>Assignee: Emily Yeh
>Priority: Minor
>  Labels: StatusLocatorCommand, StatusServerCommand, gfsh, status
>
> Currently, executing some status commands in gfsh without valid parameters 
> gives a vague explanation/output that might be misleading. Although we have 
> help  for usage description, displaying 'null' as an output 
> might not be the best idea.
> Current Result
> {code}
> gfsh>status locator
> null
> {code}
> {code}
> gfsh>status server
> Server in 
> C:\Users\XXX\git\incubator-geode\geode-assembly\build\install\apache-geode\bin
>  on null is currently not responding.
> {code}
> Improvement
> {code}
> gfsh>status locator
> SYNTAX
> status locator [--name=value] [--host=value] [--port=value] [--pid=value]
> Use help status locator to display detailed usage information
> {code}
> {code}
> gfsh>status server
> SYNTAX
> status server [--name=value] [--pid=value] [--dir=value]
> Use help status server to display detailed usage information
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2818) add alias to any command's options that involves "group", "member", "jar"

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16030043#comment-16030043
 ] 

ASF GitHub Bot commented on GEODE-2818:
---

GitHub user YehEmily opened a pull request:

https://github.com/apache/geode/pull/548

GEODE-2818: add alias to any command's options that involves "group",…

… "member", "jar" and replace CliString variables with GROUP, MEMBER, JAR, 
etc.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/YehEmily/geode GEODE-2818

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/548.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #548


commit 96df68ea155e63fa80be8f0a4be2f7b7e0cc6363
Author: YehEmily 
Date:   2017-05-30T17:56:48Z

GEODE-2818: add alias to any command's options that involves "group", 
"member", "jar" and replace CliString variables with GROUP, MEMBER, JAR, etc.




> add alias to any command's options that involves "group", "member", "jar"
> -
>
> Key: GEODE-2818
> URL: https://issues.apache.org/jira/browse/GEODE-2818
> Project: Geode
>  Issue Type: New Feature
>  Components: docs, gfsh
>Reporter: Jinmei Liao
>Assignee: Emily Yeh
>
> Or anything that would have confusion about if we are going to use singular 
> or plural at all.
> 1) add alias for those options
> 2) make sure it parameter type is an array type, some method only accepts a 
> string and split it inside the command.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2818) add alias to any command's options that involves "group", "member", "jar"

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16030044#comment-16030044
 ] 

ASF GitHub Bot commented on GEODE-2818:
---

Github user YehEmily commented on the issue:

https://github.com/apache/geode/pull/548
  
Precheckin in progress!


> add alias to any command's options that involves "group", "member", "jar"
> -
>
> Key: GEODE-2818
> URL: https://issues.apache.org/jira/browse/GEODE-2818
> Project: Geode
>  Issue Type: New Feature
>  Components: docs, gfsh
>Reporter: Jinmei Liao
>Assignee: Emily Yeh
>
> Or anything that would have confusion about if we are going to use singular 
> or plural at all.
> 1) add alias for those options
> 2) make sure it parameter type is an array type, some method only accepts a 
> string and split it inside the command.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2818) add alias to any command's options that involves "group", "member", "jar"

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16030039#comment-16030039
 ] 

ASF GitHub Bot commented on GEODE-2818:
---

Github user YehEmily closed the pull request at:

https://github.com/apache/geode/pull/546


> add alias to any command's options that involves "group", "member", "jar"
> -
>
> Key: GEODE-2818
> URL: https://issues.apache.org/jira/browse/GEODE-2818
> Project: Geode
>  Issue Type: New Feature
>  Components: docs, gfsh
>Reporter: Jinmei Liao
>Assignee: Emily Yeh
>
> Or anything that would have confusion about if we are going to use singular 
> or plural at all.
> 1) add alias for those options
> 2) make sure it parameter type is an array type, some method only accepts a 
> string and split it inside the command.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2957) null used as a default parameter when specifying analyzers

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16029985#comment-16029985
 ] 

ASF GitHub Bot commented on GEODE-2957:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/547


> null used as a default parameter when specifying analyzers
> --
>
> Key: GEODE-2957
> URL: https://issues.apache.org/jira/browse/GEODE-2957
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Jason Huynh
>Assignee: David Anuta
> Fix For: 1.2.0
>
>
> null seems to be the way to specify using the default 
> StandardKeywordAnalyzer. This can be used when specifying a long list of 
> field/analyzers.  
> So the line may look like 
> --analyzers="null,SomeAnalyzer,null,null,SomeAnalyzer}
>  We should probably change that to default or some other keyword.  null seems 
> a bit confusing.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2960) gfsh create index should trim from field names

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16029937#comment-16029937
 ] 

ASF GitHub Bot commented on GEODE-2960:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/541


> gfsh create index should trim from field names
> --
>
> Key: GEODE-2960
> URL: https://issues.apache.org/jira/browse/GEODE-2960
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Jason Huynh
>Assignee: Deepak Dixit
>
> When creating an index with specific fields, the parameter expects a comma 
> separated string.  However we are not trimming after splitting the string.  
> So if fields are defined as --field="name, age, height, weight" the indexed 
> fields are actually "name", " age", " height", " weight"
> The command should probably trim the spaces before creating the index.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2957) null used as a default parameter when specifying analyzers

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16029915#comment-16029915
 ] 

ASF GitHub Bot commented on GEODE-2957:
---

Github user nabarunnag commented on the issue:

https://github.com/apache/geode/pull/547
  
I will be merging this.


> null used as a default parameter when specifying analyzers
> --
>
> Key: GEODE-2957
> URL: https://issues.apache.org/jira/browse/GEODE-2957
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Jason Huynh
>Assignee: David Anuta
> Fix For: 1.2.0
>
>
> null seems to be the way to specify using the default 
> StandardKeywordAnalyzer. This can be used when specifying a long list of 
> field/analyzers.  
> So the line may look like 
> --analyzers="null,SomeAnalyzer,null,null,SomeAnalyzer}
>  We should probably change that to default or some other keyword.  null seems 
> a bit confusing.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2957) null used as a default parameter when specifying analyzers

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16029914#comment-16029914
 ] 

ASF GitHub Bot commented on GEODE-2957:
---

Github user nabarunnag commented on the issue:

https://github.com/apache/geode/pull/543
  
I will be merging this.


> null used as a default parameter when specifying analyzers
> --
>
> Key: GEODE-2957
> URL: https://issues.apache.org/jira/browse/GEODE-2957
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Jason Huynh
>Assignee: David Anuta
> Fix For: 1.2.0
>
>
> null seems to be the way to specify using the default 
> StandardKeywordAnalyzer. This can be used when specifying a long list of 
> field/analyzers.  
> So the line may look like 
> --analyzers="null,SomeAnalyzer,null,null,SomeAnalyzer}
>  We should probably change that to default or some other keyword.  null seems 
> a bit confusing.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2960) gfsh create index should trim from field names

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16029832#comment-16029832
 ] 

ASF GitHub Bot commented on GEODE-2960:
---

Github user nabarunnag commented on the issue:

https://github.com/apache/geode/pull/541
  
Working on merging this.


> gfsh create index should trim from field names
> --
>
> Key: GEODE-2960
> URL: https://issues.apache.org/jira/browse/GEODE-2960
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Jason Huynh
>Assignee: Deepak Dixit
>
> When creating an index with specific fields, the parameter expects a comma 
> separated string.  However we are not trimming after splitting the string.  
> So if fields are defined as --field="name, age, height, weight" the indexed 
> fields are actually "name", " age", " height", " weight"
> The command should probably trim the spaces before creating the index.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2975) Attributes are not validated in lucene xml configuration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16029828#comment-16029828
 ] 

ASF GitHub Bot commented on GEODE-2975:
---

GitHub user upthewaterspout opened a pull request:

https://github.com/apache/geode-site/pull/5

GEODE-2975: Change the location of the lucene xsd

The lucene xsd was not in the correct location on the website.

Also, fixing the website generation so that it copies the xsds to the
output directory.

@joeymcallister @karensmolermiller

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/upthewaterspout/geode-site feature/GEODE-2975

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-site/pull/5.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #5


commit 0f96bc1b520f7442f513e2849be418b62a0b9d47
Author: Dan Smith 
Date:   2017-05-30T17:24:35Z

GEODE-2975: Change the location of the lucene xsd

The lucene xsd was not in the correct location on the website.

Also, fixing the website generation so that it copies the xsds to the
output directory.




> Attributes are not validated in lucene xml configuration
> 
>
> Key: GEODE-2975
> URL: https://issues.apache.org/jira/browse/GEODE-2975
> Project: Geode
>  Issue Type: Bug
>  Components: docs, lucene
>Reporter: Barry Oglesby
> Fix For: 1.2.0
>
>
> No exception is thrown for a lucene xml configuration missing a required 
> attribute.
> No exception is thrown for a lucene xml configuration including an unknown 
> attribute.
> If a {{lucene:field}} element is defined like below, no exception is thrown 
> for the invalid attribute called {{namexx}} and no exceptio is thrown because 
> the required attribute called {{name}} is not included.
> {noformat}
> 
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2957) null used as a default parameter when specifying analyzers

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16029758#comment-16029758
 ] 

ASF GitHub Bot commented on GEODE-2957:
---

Github user DivineEnder commented on the issue:

https://github.com/apache/geode/pull/547
  
@ladyVader @nabarunnag @boglesby @jhuynh1 @upthewaterspout @gesterzhou 


> null used as a default parameter when specifying analyzers
> --
>
> Key: GEODE-2957
> URL: https://issues.apache.org/jira/browse/GEODE-2957
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Jason Huynh
>Assignee: David Anuta
> Fix For: 1.2.0
>
>
> null seems to be the way to specify using the default 
> StandardKeywordAnalyzer. This can be used when specifying a long list of 
> field/analyzers.  
> So the line may look like 
> --analyzers="null,SomeAnalyzer,null,null,SomeAnalyzer}
>  We should probably change that to default or some other keyword.  null seems 
> a bit confusing.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2818) add alias to any command's options that involves "group", "member", "jar"

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16029755#comment-16029755
 ] 

ASF GitHub Bot commented on GEODE-2818:
---

Github user jinmeiliao commented on a diff in the pull request:

https://github.com/apache/geode/pull/546#discussion_r119159305
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java
 ---
@@ -726,13 +733,13 @@
   public static final String CREATE_INDEX__REGION = "region";
   public static final String CREATE_INDEX__REGION__HELP =
   "Name/Path of the region which corresponds to the \"from\" clause in 
a query.";
-  public static final String CREATE_INDEX__MEMBER = "member";
+  public static final String CREATE_INDEX__MEMBER = MEMBER;
--- End diff --

I am wondering if you can delete all these other xxx_GROUP or xxx_MEMBER 
string declarations and change all reference of them to use the generic ones.


> add alias to any command's options that involves "group", "member", "jar"
> -
>
> Key: GEODE-2818
> URL: https://issues.apache.org/jira/browse/GEODE-2818
> Project: Geode
>  Issue Type: New Feature
>  Components: docs, gfsh
>Reporter: Jinmei Liao
>Assignee: Emily Yeh
>
> Or anything that would have confusion about if we are going to use singular 
> or plural at all.
> 1) add alias for those options
> 2) make sure it parameter type is an array type, some method only accepts a 
> string and split it inside the command.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2818) add alias to any command's options that involves "group", "member", "jar"

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16029739#comment-16029739
 ] 

ASF GitHub Bot commented on GEODE-2818:
---

GitHub user YehEmily opened a pull request:

https://github.com/apache/geode/pull/546

GEODE-2818: add alias to any command's options that involves "group", 
"member", "jar"

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/YehEmily/geode synonyms.rerun.rererun

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/546.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #546


commit 80871fe2fc68247c8f53ac3ac78aaff16adc483a
Author: YehEmily 
Date:   2017-05-25T19:18:45Z

GEODE-2818: Edited command files and testing files to allow either 'group' 
or 'groups' and 'member' or 'members' and 'jar' or 'jars'

commit 3fd97485d708cdd489968e12c08153f0a39fa243
Author: YehEmily 
Date:   2017-05-26T18:50:35Z

GEODE-2818: Edited command files and testing files to allow either 'group' 
or 'groups' and 'member' or 'members' and 'jar' or 'jars'

commit bcf2e7d6940cddb241418463da41a44df5e883bb
Author: YehEmily 
Date:   2017-05-29T22:21:40Z

GEODE-2818: add alias to any command's options that involves "group", 
"member", "jar"




> add alias to any command's options that involves "group", "member", "jar"
> -
>
> Key: GEODE-2818
> URL: https://issues.apache.org/jira/browse/GEODE-2818
> Project: Geode
>  Issue Type: New Feature
>  Components: docs, gfsh
>Reporter: Jinmei Liao
>Assignee: Emily Yeh
>
> Or anything that would have confusion about if we are going to use singular 
> or plural at all.
> 1) add alias for those options
> 2) make sure it parameter type is an array type, some method only accepts a 
> string and split it inside the command.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-1994) Change geode StringUtils to extend commons StringUtils

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16029730#comment-16029730
 ] 

ASF GitHub Bot commented on GEODE-1994:
---

Github user PurelyApplied closed the pull request at:

https://github.com/apache/geode/pull/528


> Change geode StringUtils to extend commons StringUtils
> --
>
> Key: GEODE-1994
> URL: https://issues.apache.org/jira/browse/GEODE-1994
> Project: Geode
>  Issue Type: Wish
>  Components: general, management
>Reporter: Kirk Lund
>Assignee: Patrick Rhomberg
>
> org.apache.geode.internal.lang.StringUtils duplicates some of the methods in 
> org.apache.commons.lang.StringUtils with some inconsistencies.
> isBlank is implemented identically
> isEmpty is inconsistent -- commons version returns true if string is null, 
> while geode version returns false if string is null



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2951) A gfsh lucene query specifying --pageSize fails with a NullPointerException

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16029685#comment-16029685
 ] 

ASF GitHub Bot commented on GEODE-2951:
---

Github user karensmolermiller closed the pull request at:

https://github.com/apache/geode/pull/542


> A gfsh lucene query specifying --pageSize fails with a NullPointerException
> ---
>
> Key: GEODE-2951
> URL: https://issues.apache.org/jira/browse/GEODE-2951
> Project: Geode
>  Issue Type: Bug
>  Components: docs, lucene
>Reporter: Barry Oglesby
>Assignee: Karen Smoler Miller
> Fix For: 1.2.0
>
>
> A gfsh lucene query specifying {{--pageSize}} fails with a 
> NullPointerException:
> {noformat}
> gfsh>search lucene --name=index --region=data --queryStrings=NYPD 
> --defaultField=Agency --pageSize=10
> Could not process command due to GemFire error. An error occurred while 
> searching lucene index across the Geode cluster: null
> {noformat}
> This exception is logged in the locator.log:
> {noformat}
> [info 2017/05/18 12:42:22.317 PDT locator  
> tid=0x7f] null
> java.lang.NullPointerException
>   at 
> org.apache.geode.cache.lucene.internal.cli.LuceneIndexCommands.displayResults(LuceneIndexCommands.java:476)
>   at 
> org.apache.geode.cache.lucene.internal.cli.LuceneIndexCommands.searchIndex(LuceneIndexCommands.java:299)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> {noformat}
> The same query without the {{--pageSize=10}} setting works fine.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2951) A gfsh lucene query specifying --pageSize fails with a NullPointerException

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16029684#comment-16029684
 ] 

ASF GitHub Bot commented on GEODE-2951:
---

Github user karensmolermiller commented on the issue:

https://github.com/apache/geode/pull/542
  
Merged in with d3543d229de46a3a582881484bccf3b77d8ac505.


> A gfsh lucene query specifying --pageSize fails with a NullPointerException
> ---
>
> Key: GEODE-2951
> URL: https://issues.apache.org/jira/browse/GEODE-2951
> Project: Geode
>  Issue Type: Bug
>  Components: docs, lucene
>Reporter: Barry Oglesby
>Assignee: Karen Smoler Miller
> Fix For: 1.2.0
>
>
> A gfsh lucene query specifying {{--pageSize}} fails with a 
> NullPointerException:
> {noformat}
> gfsh>search lucene --name=index --region=data --queryStrings=NYPD 
> --defaultField=Agency --pageSize=10
> Could not process command due to GemFire error. An error occurred while 
> searching lucene index across the Geode cluster: null
> {noformat}
> This exception is logged in the locator.log:
> {noformat}
> [info 2017/05/18 12:42:22.317 PDT locator  
> tid=0x7f] null
> java.lang.NullPointerException
>   at 
> org.apache.geode.cache.lucene.internal.cli.LuceneIndexCommands.displayResults(LuceneIndexCommands.java:476)
>   at 
> org.apache.geode.cache.lucene.internal.cli.LuceneIndexCommands.searchIndex(LuceneIndexCommands.java:299)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> {noformat}
> The same query without the {{--pageSize=10}} setting works fine.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2788) Add official Socket timeout parameter when connecting to servers/locators

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16027125#comment-16027125
 ] 

ASF GitHub Bot commented on GEODE-2788:
---

Github user masaki-yamakawa commented on the issue:

https://github.com/apache/geode/pull/474
  
@galen-pivotal
Thank you very much. I confirmed the message sent to the dev mailing list.


> Add official Socket timeout parameter when connecting to servers/locators
> -
>
> Key: GEODE-2788
> URL: https://issues.apache.org/jira/browse/GEODE-2788
> Project: Geode
>  Issue Type: Improvement
>  Components: client/server, docs
>Reporter: Masaki Yamakawa
>Priority: Minor
>  Labels: patch
>
> When connecting from the client to the servers/locators, if the 
> servers/locators is not started, the connection can not be established and a 
> Socket timeout occurs.
> This timeout value is 59 seconds by default. This timeout value is too long. 
> This timeout value can be changed by specifying the unofficial parameter 
> "gemfire.PoolImpl.HANDSHAKE_TIMEOUT" in java system property, but I 
> corresponded so that it can be specified by official parameters.
> Like the NativeClient, the official parameters should be specified by 
> "connect-timeout" in gemfire.properties.
> Timeout values ​​are determined in the following order of priority.
> 1. java system property:gemfire.PoolImpl.HANDSHAKE_TIMEOUT
> 2. java system property:gemfire.connect-timeout
> 3. gemfire.properties:connect-timeout
> 4. default:59000 milli seconds
> As another idea, there is also an idea to make it possible to specify it as 
> an attribute of Pool. In that case NativeClient needs the same modification.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2952) gfsh doesn't support exact match lucene queries

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16027005#comment-16027005
 ] 

ASF GitHub Bot commented on GEODE-2952:
---

Github user dihardman commented on the issue:

https://github.com/apache/geode/pull/545
  
+1 Looks good!

On Fri, May 26, 2017 at 3:15 PM, Karen Miller 
wrote:

> @DivineEnder  @upthewaterspout
>  @boglesby
>  @nabarunnag 
> @ladyVader  @dihardman
> 
> Please review.
> --
> You can view, comment on, or merge this pull request online at:
>
>   https://github.com/apache/geode/pull/545
> Commit Summary
>
>- GEODE-2952 document quoting of exact match Lucene queries
>
> File Changes
>
>- *M* geode-docs/tools_modules/gfsh/command-pages/search.html.md.erb
> (15)
>
> Patch Links:
>
>- https://github.com/apache/geode/pull/545.patch
>- https://github.com/apache/geode/pull/545.diff
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> , or mute the thread
> 

> .
>



> gfsh doesn't support exact match lucene queries
> ---
>
> Key: GEODE-2952
> URL: https://issues.apache.org/jira/browse/GEODE-2952
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Barry Oglesby
>Assignee: David Anuta
> Fix For: 1.2.0
>
>
> This command:
> {noformat}
> gfsh>search lucene --name=index --region=data 
> --defaultField=Resolution_Description --queryStrings='Police Dept'
> {noformat}
> Runs this lucene query:
> {noformat}
> Resolution_Description:police Resolution_Description:dept
> {noformat}
> I also tried this command which ran the same lucene query as above:
> {noformat}
> gfsh>search lucene --name=index --region=data 
> --defaultField=Resolution_Description --queryStrings='\"Police Dept\"'
> {noformat}
> The java API supports exact match queries with "" around the queryString. 
> Doing this causes this lucene query to be run:
> {noformat}
> Resolution_Description:"police dept"
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2951) A gfsh lucene query specifying --pageSize fails with a NullPointerException

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16026955#comment-16026955
 ] 

ASF GitHub Bot commented on GEODE-2951:
---

Github user joeymcallister commented on the issue:

https://github.com/apache/geode/pull/542
  
+1


> A gfsh lucene query specifying --pageSize fails with a NullPointerException
> ---
>
> Key: GEODE-2951
> URL: https://issues.apache.org/jira/browse/GEODE-2951
> Project: Geode
>  Issue Type: Bug
>  Components: docs, lucene
>Reporter: Barry Oglesby
>Assignee: Karen Smoler Miller
> Fix For: 1.2.0
>
>
> A gfsh lucene query specifying {{--pageSize}} fails with a 
> NullPointerException:
> {noformat}
> gfsh>search lucene --name=index --region=data --queryStrings=NYPD 
> --defaultField=Agency --pageSize=10
> Could not process command due to GemFire error. An error occurred while 
> searching lucene index across the Geode cluster: null
> {noformat}
> This exception is logged in the locator.log:
> {noformat}
> [info 2017/05/18 12:42:22.317 PDT locator  
> tid=0x7f] null
> java.lang.NullPointerException
>   at 
> org.apache.geode.cache.lucene.internal.cli.LuceneIndexCommands.displayResults(LuceneIndexCommands.java:476)
>   at 
> org.apache.geode.cache.lucene.internal.cli.LuceneIndexCommands.searchIndex(LuceneIndexCommands.java:299)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> {noformat}
> The same query without the {{--pageSize=10}} setting works fine.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2952) gfsh doesn't support exact match lucene queries

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16026941#comment-16026941
 ] 

ASF GitHub Bot commented on GEODE-2952:
---

GitHub user karensmolermiller opened a pull request:

https://github.com/apache/geode/pull/545

GEODE-2952 document quoting of exact match Lucene queries

@DivineEnder @upthewaterspout @boglesby @nabarunnag @ladyVader @dihardman
Please review.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/karensmolermiller/geode feature/GEODE-2952

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/545.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #545


commit 71f01758e1fa7535fc19dffb542293b8eddbac31
Author: Karen Miller 
Date:   2017-05-26T22:10:43Z

GEODE-2952 document quoting of exact match Lucene queries




> gfsh doesn't support exact match lucene queries
> ---
>
> Key: GEODE-2952
> URL: https://issues.apache.org/jira/browse/GEODE-2952
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Barry Oglesby
>Assignee: David Anuta
> Fix For: 1.2.0
>
>
> This command:
> {noformat}
> gfsh>search lucene --name=index --region=data 
> --defaultField=Resolution_Description --queryStrings='Police Dept'
> {noformat}
> Runs this lucene query:
> {noformat}
> Resolution_Description:police Resolution_Description:dept
> {noformat}
> I also tried this command which ran the same lucene query as above:
> {noformat}
> gfsh>search lucene --name=index --region=data 
> --defaultField=Resolution_Description --queryStrings='\"Police Dept\"'
> {noformat}
> The java API supports exact match queries with "" around the queryString. 
> Doing this causes this lucene query to be run:
> {noformat}
> Resolution_Description:"police dept"
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2994) Doc task: interactions of backups with persistence

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16026725#comment-16026725
 ] 

ASF GitHub Bot commented on GEODE-2994:
---

GitHub user karensmolermiller opened a pull request:

https://github.com/apache/geode/pull/544

GEODE-2994 Take backups when region ops are quiescent

@upthewaterspout @joeymcallister @davebarnes97 @dihardman @ladyVader 
@boglesby 
Please review.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/karensmolermiller/geode feature/GEODE-2994

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/544.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #544


commit 4affd0b7103b7b6630b38c63ba8c2e1b5f4bd1a0
Author: Karen Miller 
Date:   2017-05-26T17:29:29Z

GEODE-2994 Take backups when region ops are quiescent




> Doc task: interactions of backups with persistence
> --
>
> Key: GEODE-2994
> URL: https://issues.apache.org/jira/browse/GEODE-2994
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
>
> Document that an inconsistent state can occur by using a backup to restore 
> system state, if the backup is made at the wrong time.
> There are 2 examples where persistence and taking a backup might cause an 
> inconsistency with region data, if that backup is used to restore a system.
> # *A Lucene index.* The Lucene index is persistent. If a backup is unlucky 
> enough to be taken between a persisted write to a region (disk op) and a 
> persisted write to the Lucene index (disk op), then the backup represents 
> inconsistent data in the region and Lucene index.
> # *An AEQ.* The AEQ is persistent. If a backup is unlucky enough to be taken 
> between a persisted write to a region (disk op) and a persisted write to the 
> AEQ (disk op), then the backup represents inconsistent data in the region and 
> the AEQ.
> The solution is to make sure that backups are taken when the system is 
> quiescent WRT region operations.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2957) null used as a default parameter when specifying analyzers

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16026686#comment-16026686
 ] 

ASF GitHub Bot commented on GEODE-2957:
---

GitHub user karensmolermiller opened a pull request:

https://github.com/apache/geode/pull/543

GEODE-2957 gfsh create lucene index "null" becomes "DEFAULT"

@DivineEnder @nabarunnag @ladyVader @boglesby @joeymcallister @davebarnes97 
Please review.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/karensmolermiller/geode feature/GEODE-2957

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/543.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #543


commit fd7dfd0f61f8e46ff8b3a157ffa8f8dacdf74d31
Author: Karen Miller 
Date:   2017-05-26T18:57:49Z

GEODE-2957 gfsh create lucene index "null" becomes "DEFAULT"




> null used as a default parameter when specifying analyzers
> --
>
> Key: GEODE-2957
> URL: https://issues.apache.org/jira/browse/GEODE-2957
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Jason Huynh
>Assignee: David Anuta
> Fix For: 1.2.0
>
>
> null seems to be the way to specify using the default 
> StandardKeywordAnalyzer. This can be used when specifying a long list of 
> field/analyzers.  
> So the line may look like 
> --analyzers="null,SomeAnalyzer,null,null,SomeAnalyzer}
>  We should probably change that to default or some other keyword.  null seems 
> a bit confusing.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2951) A gfsh lucene query specifying --pageSize fails with a NullPointerException

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16026603#comment-16026603
 ] 

ASF GitHub Bot commented on GEODE-2951:
---

GitHub user karensmolermiller opened a pull request:

https://github.com/apache/geode/pull/542

GEODE-2951 Remove --pageSize from docs of gfsh search lucene

The code commit to remove this gfsh search lucene command line option has 
already been completed.  This PR updates the docs to remove the option from the 
command reference page.

@boglesby @davebarnes97 @joeymcallister @dihardman @upthewaterspout 
@nabarunnag @DivineEnder @ladyVader @jhuynh1 and any other interested parties
Can a couple of you do an ultra-quick review of this simple change to the 
docs, so that it can be merged in for inclusion in a Geode 1.2 release?

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/karensmolermiller/geode feature/GEODE-2951

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/542.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #542


commit aaf6b546067477e41bcafb3153a1b49c4eb6
Author: Karen Miller 
Date:   2017-05-26T17:54:58Z

GEODE-2951 Remove --pageSize from docs of gfsh search lucene




> A gfsh lucene query specifying --pageSize fails with a NullPointerException
> ---
>
> Key: GEODE-2951
> URL: https://issues.apache.org/jira/browse/GEODE-2951
> Project: Geode
>  Issue Type: Bug
>  Components: docs, lucene
>Reporter: Barry Oglesby
>Assignee: Karen Smoler Miller
> Fix For: 1.2.0
>
>
> A gfsh lucene query specifying {{--pageSize}} fails with a 
> NullPointerException:
> {noformat}
> gfsh>search lucene --name=index --region=data --queryStrings=NYPD 
> --defaultField=Agency --pageSize=10
> Could not process command due to GemFire error. An error occurred while 
> searching lucene index across the Geode cluster: null
> {noformat}
> This exception is logged in the locator.log:
> {noformat}
> [info 2017/05/18 12:42:22.317 PDT locator  
> tid=0x7f] null
> java.lang.NullPointerException
>   at 
> org.apache.geode.cache.lucene.internal.cli.LuceneIndexCommands.displayResults(LuceneIndexCommands.java:476)
>   at 
> org.apache.geode.cache.lucene.internal.cli.LuceneIndexCommands.searchIndex(LuceneIndexCommands.java:299)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> {noformat}
> The same query without the {{--pageSize=10}} setting works fine.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2582) Prototype Protobuf Protocol: Client can send Put Request

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16026572#comment-16026572
 ] 

ASF GitHub Bot commented on GEODE-2582:
---

Github user galen-pivotal commented on the issue:

https://github.com/apache/geode/pull/520
  
Closing, work is on the `feature/GEODE-2582` branch of `apache/geode`.


> Prototype Protobuf Protocol: Client can send Put Request
> 
>
> Key: GEODE-2582
> URL: https://issues.apache.org/jira/browse/GEODE-2582
> Project: Geode
>  Issue Type: Sub-task
>  Components: client/server
>Reporter: Addison
>Assignee: Galen O'Sullivan
>
> Using protobuf as the IDL for the [client-server 
> protocol|https://cwiki.apache.org/confluence/display/GEODE/New+Client+Server+Protocol],
> GIVEN I'm a community developer writing a new client
> AND I was given some protofiles
> AND I have established a connection to the Gemfire server
> WHEN the client sends over a put message and some data
> THEN I should be able to see my data in the cache as *JSON*
>  Out of scope:
> * Stats
> * PDX
> * Retry



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2788) Add official Socket timeout parameter when connecting to servers/locators

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16026542#comment-16026542
 ] 

ASF GitHub Bot commented on GEODE-2788:
---

Github user galen-pivotal commented on the issue:

https://github.com/apache/geode/pull/474
  
@masaki-yamakawa  Looks like Travis doesn't think the build has started. 
I've sent a message to the developer list; someone there should have an idea 
what the issue is.


> Add official Socket timeout parameter when connecting to servers/locators
> -
>
> Key: GEODE-2788
> URL: https://issues.apache.org/jira/browse/GEODE-2788
> Project: Geode
>  Issue Type: Improvement
>  Components: client/server, docs
>Reporter: Masaki Yamakawa
>Priority: Minor
>  Labels: patch
>
> When connecting from the client to the servers/locators, if the 
> servers/locators is not started, the connection can not be established and a 
> Socket timeout occurs.
> This timeout value is 59 seconds by default. This timeout value is too long. 
> This timeout value can be changed by specifying the unofficial parameter 
> "gemfire.PoolImpl.HANDSHAKE_TIMEOUT" in java system property, but I 
> corresponded so that it can be specified by official parameters.
> Like the NativeClient, the official parameters should be specified by 
> "connect-timeout" in gemfire.properties.
> Timeout values ​​are determined in the following order of priority.
> 1. java system property:gemfire.PoolImpl.HANDSHAKE_TIMEOUT
> 2. java system property:gemfire.connect-timeout
> 3. gemfire.properties:connect-timeout
> 4. default:59000 milli seconds
> As another idea, there is also an idea to make it possible to specify it as 
> an attribute of Pool. In that case NativeClient needs the same modification.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2818) add alias to any command's options that involves "group", "member", "jar"

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16026541#comment-16026541
 ] 

ASF GitHub Bot commented on GEODE-2818:
---

Github user YehEmily closed the pull request at:

https://github.com/apache/geode/pull/539


> add alias to any command's options that involves "group", "member", "jar"
> -
>
> Key: GEODE-2818
> URL: https://issues.apache.org/jira/browse/GEODE-2818
> Project: Geode
>  Issue Type: New Feature
>  Components: docs, gfsh
>Reporter: Jinmei Liao
>
> Or anything that would have confusion about if we are going to use singular 
> or plural at all.
> 1) add alias for those options
> 2) make sure it parameter type is an array type, some method only accepts a 
> string and split it inside the command.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2788) Add official Socket timeout parameter when connecting to servers/locators

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16026240#comment-16026240
 ] 

ASF GitHub Bot commented on GEODE-2788:
---

Github user masaki-yamakawa commented on the issue:

https://github.com/apache/geode/pull/474
  
I am sorry, once I rebase to confirm the build, travis-ci hangs for some 
reason.


> Add official Socket timeout parameter when connecting to servers/locators
> -
>
> Key: GEODE-2788
> URL: https://issues.apache.org/jira/browse/GEODE-2788
> Project: Geode
>  Issue Type: Improvement
>  Components: client/server, docs
>Reporter: Masaki Yamakawa
>Priority: Minor
>  Labels: patch
>
> When connecting from the client to the servers/locators, if the 
> servers/locators is not started, the connection can not be established and a 
> Socket timeout occurs.
> This timeout value is 59 seconds by default. This timeout value is too long. 
> This timeout value can be changed by specifying the unofficial parameter 
> "gemfire.PoolImpl.HANDSHAKE_TIMEOUT" in java system property, but I 
> corresponded so that it can be specified by official parameters.
> Like the NativeClient, the official parameters should be specified by 
> "connect-timeout" in gemfire.properties.
> Timeout values ​​are determined in the following order of priority.
> 1. java system property:gemfire.PoolImpl.HANDSHAKE_TIMEOUT
> 2. java system property:gemfire.connect-timeout
> 3. gemfire.properties:connect-timeout
> 4. default:59000 milli seconds
> As another idea, there is also an idea to make it possible to specify it as 
> an attribute of Pool. In that case NativeClient needs the same modification.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2960) gfsh create index should trim from field names

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16026168#comment-16026168
 ] 

ASF GitHub Bot commented on GEODE-2960:
---

GitHub user deepakddixit opened a pull request:

https://github.com/apache/geode/pull/541

GEODE-2960 : Trim field parameter values from create lucene index.

Added logic to trim leading and trailing spaces from values provided 
against 'field'.
Modify existing test case to verify changes.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [x] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [x] Is your initial contribution a single, squashed commit?

- [x] Does `gradlew build` run cleanly?

- [x] Have you written or updated unit tests to verify your changes?
   Updated existing test.
- [x] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
No new dependency added.

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/deepakddixit/incubator-geode bug/GEODE-2960

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/541.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #541


commit cd853456c2622412dbcb2cd0807be613070d1269
Author: Deepak Dixit 
Date:   2017-05-26T11:29:41Z

GEODE-2960 : Trim field parameter values from create lucene index.
Added logic to trim leading and trailing spaces from values provided 
against 'field'.
Modify existing test case to verify changes.




> gfsh create index should trim from field names
> --
>
> Key: GEODE-2960
> URL: https://issues.apache.org/jira/browse/GEODE-2960
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Jason Huynh
>Assignee: Deepak Dixit
>
> When creating an index with specific fields, the parameter expects a comma 
> separated string.  However we are not trimming after splitting the string.  
> So if fields are defined as --field="name, age, height, weight" the indexed 
> fields are actually "name", " age", " height", " weight"
> The command should probably trim the spaces before creating the index.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2957) null used as a default parameter when specifying analyzers

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16025572#comment-16025572
 ] 

ASF GitHub Bot commented on GEODE-2957:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/537


> null used as a default parameter when specifying analyzers
> --
>
> Key: GEODE-2957
> URL: https://issues.apache.org/jira/browse/GEODE-2957
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Jason Huynh
>
> null seems to be the way to specify using the default 
> StandardKeywordAnalyzer. This can be used when specifying a long list of 
> field/analyzers.  
> So the line may look like 
> --analyzers="null,SomeAnalyzer,null,null,SomeAnalyzer}
>  We should probably change that to default or some other keyword.  null seems 
> a bit confusing.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2950) Lucene index names should be restricted to valid region names since the index name becomes part of a region

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16025541#comment-16025541
 ] 

ASF GitHub Bot commented on GEODE-2950:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/540


> Lucene index names should be restricted to valid region names since the index 
> name becomes part of a region
> ---
>
> Key: GEODE-2950
> URL: https://issues.apache.org/jira/browse/GEODE-2950
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Barry Oglesby
>Assignee: David Anuta
> Fix For: 1.2.0
>
>
> Currently, invalid region name characters can be used as index names. The 
> index name becomes part of the async event queue id which becomes part of the 
> colocated region name, so invalid characters shouldn't be allowed as index 
> names. LocalRegion has a validateRegionName method that restricts the names 
> to {{\[aA-zZ0-9-_.\]+}}. This method should be called to validate index names.
> Here is an example (option-j creates the ∆):
> {noformat}
> gfsh>create lucene index --name=∆∆∆ --region=data --field=text
>   Member| Status
> --- | -
> 192.168.2.4(server2:53308):1025 | Successfully created lucene index
> 192.168.2.4(server1:53315):1026 | Successfully created lucene index
> {noformat}
> {noformat}
> gfsh>create region --name=data --type=PARTITION
> Member  | Status
> --- | ---
> server2 | Region "/data" created on "server2"
> server1 | Region "/data" created on "server1"
> {noformat}
> {noformat}
> gfsh>put --key=0 --value=0 --region=data
> Result  : true
> Key Class   : java.lang.String
> Key : 0
> Value Class : java.lang.String
> Old Value   : 
> {noformat}
> {noformat}
> gfsh>describe lucene index --name=∆∆∆ --region=/data
> Index Name | Region Path | Server Name | Indexed Fields | Field Analyzer  
> |   Status| Query Executions | Updates | Commits | Documents
> -- | --- | --- | -- | 
> --- | --- |  | --- | --- 
> | -
> ∆∆∆| /data   | server1 | [text] | 
> {text=StandardAnalyzer} | Initialized | 0| 0   | 0   
> | 0
> ∆∆∆| /data   | server2 | [text] | 
> {text=StandardAnalyzer} | Initialized | 0| 1   | 1   
> | 1
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2818) add alias to any command's options that involves "group", "member", "jar"

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16025538#comment-16025538
 ] 

ASF GitHub Bot commented on GEODE-2818:
---

Github user jaredjstewart commented on the issue:

https://github.com/apache/geode/pull/539
  
Thanks for your contribution, Emily!  It looks like this branch will need 
to be rebased onto the latest develop to apply cleanly.  Would you mind 
updating the PR with a rebased version of these changes?


> add alias to any command's options that involves "group", "member", "jar"
> -
>
> Key: GEODE-2818
> URL: https://issues.apache.org/jira/browse/GEODE-2818
> Project: Geode
>  Issue Type: New Feature
>  Components: docs, gfsh
>Reporter: Jinmei Liao
>
> Or anything that would have confusion about if we are going to use singular 
> or plural at all.
> 1) add alias for those options
> 2) make sure it parameter type is an array type, some method only accepts a 
> string and split it inside the command.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2950) Lucene index names should be restricted to valid region names since the index name becomes part of a region

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16025481#comment-16025481
 ] 

ASF GitHub Bot commented on GEODE-2950:
---

GitHub user DivineEnder opened a pull request:

https://github.com/apache/geode/pull/540

GEODE-2950: Updated error messages

* Different error messages are displayed when validating region names 
versus indexes.
* Added flexible enum allowing for expanded error messages and name 
validation.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/DivineEnder/geode feature/GEODE-2950

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/540.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #540


commit 382f3e672964c76c3854f33c3b628c5a0234eb66
Author: David Anuta 
Date:   2017-05-25T22:18:40Z

GEODE-2950: Updated error messages

* Different error messages are displayed when validating region names 
versus indexes.
* Added flexible enum allowing for expanded error messages and name 
validation.




> Lucene index names should be restricted to valid region names since the index 
> name becomes part of a region
> ---
>
> Key: GEODE-2950
> URL: https://issues.apache.org/jira/browse/GEODE-2950
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Barry Oglesby
>Assignee: David Anuta
> Fix For: 1.2.0
>
>
> Currently, invalid region name characters can be used as index names. The 
> index name becomes part of the async event queue id which becomes part of the 
> colocated region name, so invalid characters shouldn't be allowed as index 
> names. LocalRegion has a validateRegionName method that restricts the names 
> to {{\[aA-zZ0-9-_.\]+}}. This method should be called to validate index names.
> Here is an example (option-j creates the ∆):
> {noformat}
> gfsh>create lucene index --name=∆∆∆ --region=data --field=text
>   Member| Status
> --- | -
> 192.168.2.4(server2:53308):1025 | Successfully created lucene index
> 192.168.2.4(server1:53315):1026 | Successfully created lucene index
> {noformat}
> {noformat}
> gfsh>create region --name=data --type=PARTITION
> Member  | Status
> --- | ---
> server2 | Region "/data" created on "server2"
> server1 | Region "/data" created on "server1"
> {noformat}
> {noformat}
> gfsh>put --key=0 --value=0 --region=data
> Result  : true
> Key Class   : java.lang.String
> Key : 0
> Value Class : java.lang.String
> Old Value   : 
> {noformat}
> {noformat}
> gfsh>describe lucene index --name=∆∆∆ --region=/data
> Index Name | Region Path | Server Name | Indexed Fields | Field Analyzer  
> |   Status| Query Executions | Updates | Commits | Documents
> -- | --- | --- | -- | 
> --- | --- |  | --- | --- 
> | -
> ∆∆∆| /data   | server1 | [text] | 
> {text=StandardAnalyzer} | Initialized | 0| 0   | 0   
> | 0
> ∆∆∆| /data   | server2 | [text] | 
> {text=StandardAnalyzer} | Initialized | 0| 1   | 1   
> | 1
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2950) Lucene index names should be restricted to valid region names since the index name becomes part of a region

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16025482#comment-16025482
 ] 

ASF GitHub Bot commented on GEODE-2950:
---

Github user DivineEnder commented on the issue:

https://github.com/apache/geode/pull/540
  
@ladyVader @nabarunnag @boglesby @jhuynh1 @upthewaterspout @gesterzhou 


> Lucene index names should be restricted to valid region names since the index 
> name becomes part of a region
> ---
>
> Key: GEODE-2950
> URL: https://issues.apache.org/jira/browse/GEODE-2950
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Barry Oglesby
>Assignee: David Anuta
> Fix For: 1.2.0
>
>
> Currently, invalid region name characters can be used as index names. The 
> index name becomes part of the async event queue id which becomes part of the 
> colocated region name, so invalid characters shouldn't be allowed as index 
> names. LocalRegion has a validateRegionName method that restricts the names 
> to {{\[aA-zZ0-9-_.\]+}}. This method should be called to validate index names.
> Here is an example (option-j creates the ∆):
> {noformat}
> gfsh>create lucene index --name=∆∆∆ --region=data --field=text
>   Member| Status
> --- | -
> 192.168.2.4(server2:53308):1025 | Successfully created lucene index
> 192.168.2.4(server1:53315):1026 | Successfully created lucene index
> {noformat}
> {noformat}
> gfsh>create region --name=data --type=PARTITION
> Member  | Status
> --- | ---
> server2 | Region "/data" created on "server2"
> server1 | Region "/data" created on "server1"
> {noformat}
> {noformat}
> gfsh>put --key=0 --value=0 --region=data
> Result  : true
> Key Class   : java.lang.String
> Key : 0
> Value Class : java.lang.String
> Old Value   : 
> {noformat}
> {noformat}
> gfsh>describe lucene index --name=∆∆∆ --region=/data
> Index Name | Region Path | Server Name | Indexed Fields | Field Analyzer  
> |   Status| Query Executions | Updates | Commits | Documents
> -- | --- | --- | -- | 
> --- | --- |  | --- | --- 
> | -
> ∆∆∆| /data   | server1 | [text] | 
> {text=StandardAnalyzer} | Initialized | 0| 0   | 0   
> | 0
> ∆∆∆| /data   | server2 | [text] | 
> {text=StandardAnalyzer} | Initialized | 0| 1   | 1   
> | 1
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2977) commands should take string[] as the value for --group and --memberId(--name) whenever possible

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16025462#comment-16025462
 ] 

ASF GitHub Bot commented on GEODE-2977:
---

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/536


> commands should take string[] as the value for --group and --memberId(--name) 
> whenever possible
> ---
>
> Key: GEODE-2977
> URL: https://issues.apache.org/jira/browse/GEODE-2977
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Reporter: Jinmei Liao
>
> some commands takes string[], and some takes only String and split them 
> manually. We should make this consistent and the help message would be a lot 
> clearer if taking string[].



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2975) Attributes are not validated in lucene xml configuration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16025385#comment-16025385
 ] 

ASF GitHub Bot commented on GEODE-2975:
---

Github user boglesby commented on the issue:

https://github.com/apache/geode/pull/538
  
This looks good for these xmls:
```

```
```

```
it still throws a ClassCastException for this, though:
```

```
I'm not sure if thats a problem or if its ok.




> Attributes are not validated in lucene xml configuration
> 
>
> Key: GEODE-2975
> URL: https://issues.apache.org/jira/browse/GEODE-2975
> Project: Geode
>  Issue Type: Bug
>  Components: docs, lucene
>Reporter: Barry Oglesby
> Fix For: 1.2.0
>
>
> No exception is thrown for a lucene xml configuration missing a required 
> attribute.
> No exception is thrown for a lucene xml configuration including an unknown 
> attribute.
> If a {{lucene:field}} element is defined like below, no exception is thrown 
> for the invalid attribute called {{namexx}} and no exceptio is thrown because 
> the required attribute called {{name}} is not included.
> {noformat}
> 
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2818) add alias to any command's options that involves "group", "member", "jar"

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16025357#comment-16025357
 ] 

ASF GitHub Bot commented on GEODE-2818:
---

GitHub user YehEmily opened a pull request:

https://github.com/apache/geode/pull/539

GEODE-2818: add alias to any command's options that involves "group", 
"member", "jar"

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/YehEmily/geode synonyms

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/539.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #539


commit 01c5119654f27a254f8fb334b9fe8a2d5c4039ac
Author: YehEmily 
Date:   2017-05-23T19:27:40Z

GEODE-2977: make group/name option values consistent

commit 2076f03d8cd3748f204518c47b3a6245f9f6a714
Author: YehEmily 
Date:   2017-05-25T19:18:45Z

Edited command files to allow either 'group' or 'groups' and 'member' or 
'members




> add alias to any command's options that involves "group", "member", "jar"
> -
>
> Key: GEODE-2818
> URL: https://issues.apache.org/jira/browse/GEODE-2818
> Project: Geode
>  Issue Type: New Feature
>  Components: docs, gfsh
>Reporter: Jinmei Liao
>
> Or anything that would have confusion about if we are going to use singular 
> or plural at all.
> 1) add alias for those options
> 2) make sure it parameter type is an array type, some method only accepts a 
> string and split it inside the command.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2818) add alias to any command's options that involves "group", "member", "jar"

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16025358#comment-16025358
 ] 

ASF GitHub Bot commented on GEODE-2818:
---

Github user YehEmily commented on the issue:

https://github.com/apache/geode/pull/539
  
Precheckin pending!


> add alias to any command's options that involves "group", "member", "jar"
> -
>
> Key: GEODE-2818
> URL: https://issues.apache.org/jira/browse/GEODE-2818
> Project: Geode
>  Issue Type: New Feature
>  Components: docs, gfsh
>Reporter: Jinmei Liao
>
> Or anything that would have confusion about if we are going to use singular 
> or plural at all.
> 1) add alias for those options
> 2) make sure it parameter type is an array type, some method only accepts a 
> string and split it inside the command.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)