Re: Experimental features for 1.0

[Dave Barnes]

JVSD is not fully-featured, yet. Does it belong on the list?

> On Aug 10, 2016, at 6:26 PM, Kirk Lund  wrote:
> 
> +1 for Jira tickets with "experimental" label
> 
> Also, don't forget we have the @Experimental annotation defined in
> geode-common that should be applied to any experimental user APIs before
> final 1.0.0 release.
> 
> -Kirk
> 
>> On Wednesday, August 10, 2016, William Markito  wrote:
>> 
>> As we move forward to 1.0 I'd like to propose creating JIRAS with the
>> "experimental" label to capture everything we have that is classified as
>> such.
>> 
>> This would help users and projects consume Geode to consider those
>> features properly and decide to add support (or not) to them as well.
>> 
>> AFAIK this is the current list:
>> 
>> Redis Adapter
>> Spark Connector
>> OQL Aggregates
>> Lucene integration
>> Auto Rebalancer
>> 
>> Is there anything else ? Are any of these not considered experimental
>> anymore ?
>> 
>> If by the time we get to 1.0 they're complete we'd remove be label
>> obviously.
>> 
>> Thoughts ?
>> 
>> 
>> 
>> 
>> 

Re: Experimental features for 1.0

[Kirk Lund]

+1 for Jira tickets with "experimental" label

Also, don't forget we have the @Experimental annotation defined in
geode-common that should be applied to any experimental user APIs before
final 1.0.0 release.

-Kirk

On Wednesday, August 10, 2016, William Markito  wrote:

> As we move forward to 1.0 I'd like to propose creating JIRAS with the
> "experimental" label to capture everything we have that is classified as
> such.
>
> This would help users and projects consume Geode to consider those
> features properly and decide to add support (or not) to them as well.
>
> AFAIK this is the current list:
>
> Redis Adapter
> Spark Connector
> OQL Aggregates
> Lucene integration
> Auto Rebalancer
>
> Is there anything else ? Are any of these not considered experimental
> anymore ?
>
>  If by the time we get to 1.0 they're complete we'd remove be label
> obviously.
>
> Thoughts ?
>
>
>
>
>

Re: Experimental features for 1.0

[John Blum]

+1

What about HDFS storage support, or was this dropped completely?

On Wed, Aug 10, 2016 at 6:12 PM, Joey McAllister 
wrote:

> +1 - Great idea
>
> On Wed, Aug 10, 2016 at 6:10 PM Michael Stolz  wrote:
>
> > Yes we should definitely do this
> >
> > --
> > Mike Stolz
> > Principal Engineer - Gemfire Product Manager
> > Mobile: 631-835-4771
> > On Aug 10, 2016 9:01 PM, "William Markito"  wrote:
> >
> > > As we move forward to 1.0 I'd like to propose creating JIRAS with the
> > > "experimental" label to capture everything we have that is classified
> as
> > > such.
> > >
> > > This would help users and projects consume Geode to consider those
> > > features properly and decide to add support (or not) to them as well.
> > >
> > > AFAIK this is the current list:
> > >
> > > Redis Adapter
> > > Spark Connector
> > > OQL Aggregates
> > > Lucene integration
> > > Auto Rebalancer
> > >
> > > Is there anything else ? Are any of these not considered experimental
> > > anymore ?
> > >
> > >  If by the time we get to 1.0 they're complete we'd remove be label
> > > obviously.
> > >
> > > Thoughts ?
> > >
> > >
> > >
> > >
> > >
> >
>



-- 
-John
503-504-8657
john.blum10101 (skype)

Re: Experimental features for 1.0

[Joey McAllister]

+1 - Great idea

On Wed, Aug 10, 2016 at 6:10 PM Michael Stolz  wrote:

> Yes we should definitely do this
>
> --
> Mike Stolz
> Principal Engineer - Gemfire Product Manager
> Mobile: 631-835-4771
> On Aug 10, 2016 9:01 PM, "William Markito"  wrote:
>
> > As we move forward to 1.0 I'd like to propose creating JIRAS with the
> > "experimental" label to capture everything we have that is classified as
> > such.
> >
> > This would help users and projects consume Geode to consider those
> > features properly and decide to add support (or not) to them as well.
> >
> > AFAIK this is the current list:
> >
> > Redis Adapter
> > Spark Connector
> > OQL Aggregates
> > Lucene integration
> > Auto Rebalancer
> >
> > Is there anything else ? Are any of these not considered experimental
> > anymore ?
> >
> >  If by the time we get to 1.0 they're complete we'd remove be label
> > obviously.
> >
> > Thoughts ?
> >
> >
> >
> >
> >
>

Re: Experimental features for 1.0

[Michael Stolz]

Yes we should definitely do this

--
Mike Stolz
Principal Engineer - Gemfire Product Manager
Mobile: 631-835-4771
On Aug 10, 2016 9:01 PM, "William Markito"  wrote:

> As we move forward to 1.0 I'd like to propose creating JIRAS with the
> "experimental" label to capture everything we have that is classified as
> such.
>
> This would help users and projects consume Geode to consider those
> features properly and decide to add support (or not) to them as well.
>
> AFAIK this is the current list:
>
> Redis Adapter
> Spark Connector
> OQL Aggregates
> Lucene integration
> Auto Rebalancer
>
> Is there anything else ? Are any of these not considered experimental
> anymore ?
>
>  If by the time we get to 1.0 they're complete we'd remove be label
> obviously.
>
> Thoughts ?
>
>
>
>
>

Experimental features for 1.0

[William Markito]

As we move forward to 1.0 I'd like to propose creating JIRAS with the 
"experimental" label to capture everything we have that is classified as such. 

This would help users and projects consume Geode to consider those features 
properly and decide to add support (or not) to them as well. 

AFAIK this is the current list:

Redis Adapter
Spark Connector
OQL Aggregates
Lucene integration
Auto Rebalancer 

Is there anything else ? Are any of these not considered experimental anymore ?

 If by the time we get to 1.0 they're complete we'd remove be label obviously. 

Thoughts ?

Re: Revised SSL properties failure scenario advice.

[Kirk Lund]

+1 to introduce "ssl-default-alias" and fail if it's not set for multi-key
keystore


On Wed, Aug 10, 2016 at 4:34 PM, Bruce Schuchardt 
wrote:

> +1 for ssl-default-alias and failing
>
>
> Le 8/10/2016 à 3:36 PM, Udo Kohlmeyer a écrit :
>
>> Hi there guys,
>>
>> As per the proposal for the revision of the SSL configuration <
>> https://cwiki.apache.org/confluence/display/GEODE/Revised+SSL+properties>,
>> I'm nearing the completion of this feature.
>>
>> What I have come across is some scenarios where a system is configured
>> with a multi-key keystore and all Geode components are marked to use SSL.
>> As the ssl configuration factory would not know what key to use, it might
>> fail to correctly configure SSL comms.
>>
>> In this scenario, would it make sense to introduce another property
>> "ssl-default-alias" which specifies the default certificate alias to be
>> used in a multi-key keystore?
>>
>> Also, in the scenario where a single component specifies a different
>> alias to be used, should we fail if the "ssl-default-alias" has not been
>> set for a multi-key keystore?
>>
>> Any advice or opinions would be appreciated.
>>
>> --Udo
>>
>>
>>
>

Re: Revised SSL properties failure scenario advice.

[Bruce Schuchardt]

+1 for ssl-default-alias and failing

Le 8/10/2016 à 3:36 PM, Udo Kohlmeyer a écrit :

Hi there guys,

As per the proposal for the revision of the SSL configuration 
, 
I'm nearing the completion of this feature.


What I have come across is some scenarios where a system is configured 
with a multi-key keystore and all Geode components are marked to use 
SSL. As the ssl configuration factory would not know what key to use, 
it might fail to correctly configure SSL comms.


In this scenario, would it make sense to introduce another property 
"ssl-default-alias" which specifies the default certificate alias to 
be used in a multi-key keystore?


Also, in the scenario where a single component specifies a different 
alias to be used, should we fail if the "ssl-default-alias" has not 
been set for a multi-key keystore?


Any advice or opinions would be appreciated.

--Udo

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #397 was SUCCESSFUL (with 1423 tests)

[Spring CI]

---
Spring Data GemFire > Nightly-ApacheGeode > #397 was successful.
---
Scheduled
1425 tests in total.

https://build.spring.io/browse/SGF-NAG-397/





--
This message is automatically generated by Atlassian Bamboo

Revised SSL properties failure scenario advice.

[Udo Kohlmeyer]

Hi there guys,

As per the proposal for the revision of the SSL configuration 
, 
I'm nearing the completion of this feature.


What I have come across is some scenarios where a system is configured 
with a multi-key keystore and all Geode components are marked to use 
SSL. As the ssl configuration factory would not know what key to use, it 
might fail to correctly configure SSL comms.


In this scenario, would it make sense to introduce another property 
"ssl-default-alias" which specifies the default certificate alias to be 
used in a multi-key keystore?


Also, in the scenario where a single component specifies a different 
alias to be used, should we fail if the "ssl-default-alias" has not been 
set for a multi-key keystore?


Any advice or opinions would be appreciated.

--Udo

[GitHub] incubator-geode pull request #230: GEODE-1744: Probable bugs from == use fix...

[kjduling]

Github user kjduling commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/230#discussion_r74340943
  
--- Diff: 
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/AbstractCliAroundInterceptor.java
 ---
@@ -88,7 +88,7 @@ protected Response readYesNo(String message, Response 
defaultResponse) {
   try {
 String userInput = interact(message);
 
-if (userInput == null || userInput == "") {
+if (userInput.isEmpty()) {
--- End diff --

Here you need to keep the null check or it could throw an NPE, so:
  if (userInput == null || userInput.isEmpty()) {



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 49962: Removed extra fields from distributedmember while serialization/de

[Bruce Schuchardt]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49962/#review145409
---



It looks good but you need to change the GMSMember reference in JoinLeave to 
NetMember so that we don't tie this interface to the implementation classes.

Fix it, then ship it!

- Bruce Schuchardt


On Aug. 10, 2016, 9:25 p.m., Hitesh Khamesra wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49962/
> ---
> 
> (Updated Aug. 10, 2016, 9:25 p.m.)
> 
> 
> Review request for geode, Bruce Schuchardt and Udo Kohlmeyer.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Removed extra fields from distributedmember while serialization/de. Planning 
> to do this in udp-security branch.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/GMSMember.java
>  d5d0b8e 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/interfaces/JoinLeave.java
>  87409c5 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeave.java
>  080bdb3 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessenger.java
>  5c0a327 
>   
> geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/GMSMemberJUnitTest.java
>  7eef594 
> 
> Diff: https://reviews.apache.org/r/49962/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Hitesh Khamesra
> 
>

[GitHub] incubator-geode pull request #230: GEODE-1744: Probable bugs from == use fix...

[kjduling]

Github user kjduling commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/230#discussion_r74340020
  
--- Diff: 
geode-core/src/main/java/com/gemstone/gemfire/admin/AlertLevel.java ---
@@ -145,8 +147,8 @@ public boolean equals(Object other) {
final AlertLevel that = (AlertLevel) other;
 
if (this.severity != that.severity) return false;
-   if (this.name != that.name &&
-   !(this.name != null &&
+   if (!Objects.equals(this.name, that.name) &&
+!(this.name != null &&
this.name.equals(that.name))) return false;
 
--- End diff --

Yep, absolutely correct.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-geode issue #231: Feature/geode 1743

[metatype]

Github user metatype commented on the issue:

https://github.com/apache/incubator-geode/pull/231
  
LGTM +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-geode pull request #230: GEODE-1744: Probable bugs from == use fix...

[kjduling]

Github user kjduling commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/230#discussion_r74338007
  
--- Diff: 
geode-core/src/main/java/com/gemstone/gemfire/admin/AlertLevel.java ---
@@ -145,8 +147,8 @@ public boolean equals(Object other) {
final AlertLevel that = (AlertLevel) other;
 
if (this.severity != that.severity) return false;
-   if (this.name != that.name &&
-   !(this.name != null &&
+   if (!Objects.equals(this.name, that.name) &&
+!(this.name != null &&
this.name.equals(that.name))) return false;
 
--- End diff --

I think that the point of this code is to compare whether or not the 
'other' name is the equivalent string to this.name.  A better way to test for 
that is to move the NPE check up, then compare:

if (this.name != null && 
this.name.equals(that.name)) return false;


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-geode pull request #230: GEODE-1744: Probable bugs from == use fix...

[metatype]

Github user metatype commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/230#discussion_r74339073
  
--- Diff: 
geode-core/src/main/java/com/gemstone/gemfire/admin/AlertLevel.java ---
@@ -145,8 +147,8 @@ public boolean equals(Object other) {
final AlertLevel that = (AlertLevel) other;
 
if (this.severity != that.severity) return false;
-   if (this.name != that.name &&
-   !(this.name != null &&
+   if (!Objects.equals(this.name, that.name) &&
+!(this.name != null &&
this.name.equals(that.name))) return false;
 
--- End diff --

@kjduling I think you need a `!` in there somewhere.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-geode issue #230: GEODE-1744: Probable bugs from == use fixed

[metatype]

Github user metatype commented on the issue:

https://github.com/apache/incubator-geode/pull/230
  
Is there a test that exposes the probable bug and verifies that the issue 
is fixed?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 49962: Removed extra fields from distributedmember while serialization/de

[Hitesh Khamesra]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49962/
---

(Updated Aug. 10, 2016, 9:25 p.m.)


Review request for geode, Bruce Schuchardt and Udo Kohlmeyer.


Changes
---

Updated patch. Now we look preparedview as well to find the 
InternalDistributedMember from view. Some other calenup.


Repository: geode


Description
---

Removed extra fields from distributedmember while serialization/de. Planning to 
do this in udp-security branch.


Diffs (updated)
-

  
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/GMSMember.java
 d5d0b8e 
  
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/interfaces/JoinLeave.java
 87409c5 
  
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeave.java
 080bdb3 
  
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessenger.java
 5c0a327 
  
geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/GMSMemberJUnitTest.java
 7eef594 

Diff: https://reviews.apache.org/r/49962/diff/


Testing
---


Thanks,

Hitesh Khamesra

[GitHub] incubator-geode pull request #231: Feature/geode 1743

[joeymcallister]

GitHub user joeymcallister opened a pull request:

https://github.com/apache/incubator-geode/pull/231

Feature/geode 1743

Add Mike Stolz to committers

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/joeymcallister/incubator-geode 
feature/GEODE-1743

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/231.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #231


commit 9cbd00047f4d58083d9eab198ed4713ed05c796d
Author: Joey McAllister 
Date:   2016-08-10T17:49:42Z

Merge remote-tracking branch 'apache/develop' into develop

commit 354121857e6aa2e112b170cde2ccb4b0bf51c874
Author: Joey McAllister 
Date:   2016-08-10T21:20:44Z

GEODE-1743: Add Mike Stolz to committers




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-geode pull request #230: GEODE-1744: Probable bugs from == use fix...

[gracemeilen]

GitHub user gracemeilen opened a pull request:

https://github.com/apache/incubator-geode/pull/230

GEODE-1744: Probable bugs from == use fixed



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gracemeilen/incubator-geode feature/GEODE-1744

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/230.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #230


commit 5f1077151108acdbab6b7459f175c48e10cf7cba
Author: gmeilen 
Date:   2016-08-09T16:48:32Z

GEODE-1648: Introduce security-enabled-components and tests

commit 4edd4569ada4ac706800c55d860850145822355b
Author: gmeilen 
Date:   2016-08-10T21:18:32Z

GEODE-1744:Probable bugs from == use fixed




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 50962: GEODE-1742: Fixing synchronization of cqListeners in CqAttributesImpl

[anilkumar gingade]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50962/#review145401
---


Ship it!




Ship It!

- anilkumar gingade


On Aug. 10, 2016, 6:13 p.m., Dan Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50962/
> ---
> 
> (Updated Aug. 10, 2016, 6:13 p.m.)
> 
> 
> Review request for geode and anilkumar gingade.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Extracted CQAttributesImpl to it's own class, and fixed the
> synchronization of cqListeners so that we grab a snapshot of the
> listeners to check to avoid races where the listeners can change after
> we check for null.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/query/CqAttributesFactory.java
>  101c9e66be031be1b375150feaf410a025fd3efa 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/query/internal/cq/CqAttributesImpl.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/internal/cq/CqAttributesImplJUnitTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50962/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dan Smith
> 
>

Re: Review Request 50903: GEODE-1583: Always pass the keep alive flag when destroying a connection

[anilkumar gingade]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50903/#review145399
---


Ship it!




Ship It!

- anilkumar gingade


On Aug. 10, 2016, 8:39 p.m., Dan Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50903/
> ---
> 
> (Updated Aug. 10, 2016, 8:39 p.m.)
> 
> 
> Review request for geode and anilkumar gingade.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> The queue manager was closing connections without sending the
> CloseConnectionOp to the server. Changing the code to call close instead
> of destroy and passing the keepAlive flag along with the close. Also,
> changing the cache to set keepAlive *before* marking the cache as
> closed.
> 
> This should prevent any races where cache closure triggers the cache
> client updater to destroy connections or close them with the wrong
> keepAlive setting while the cache is being closed.
> 
> Note that I changed the default value for keepAlive in the cache and the
> pool to be true. I did this because the DurableClientNetDown test forces
> the connections to be closed without closing the cache, so it uses the default
> value, but also because I think this is probably safer for cases of abnormal
> termination that connections are closed by default with keepAlive=true until
> the cache is actually closing.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/InternalPool.java
>  fcb0ae8358a1ec2394bf74bd7929867dd5e6f77e 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/PoolImpl.java
>  65a4dd13c25f5363f4d5a6bc2d4da1f7806596a0 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/QueueManagerImpl.java
>  7c9b187c6bc7ed6db64ac5670eb1daa3c594372f 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/GemFireCacheImpl.java
>  05bc83837032c95114da118e197c01ca2b3cd4f4 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/client/internal/AutoConnectionSourceImplJUnitTest.java
>  8deedc18491c6308cc1628e006098ec22640fe5d 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/client/internal/QueueManagerJUnitTest.java
>  c2872e798cec373b6fba4a07a3ce8608cf235c37 
> 
> Diff: https://reviews.apache.org/r/50903/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dan Smith
> 
>

Re: Review Request 50903: GEODE-1583: Always pass the keep alive flag when destroying a connection

[Dan Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50903/
---

(Updated Aug. 10, 2016, 8:39 p.m.)


Review request for geode and anilkumar gingade.


Changes
---

Based on Anils feedback, I updated the changes to only close the connection if 
a cache client updater exits. If an endpoint crashes, we will still call 
destroyConnection.


Repository: geode


Description
---

The queue manager was closing connections without sending the
CloseConnectionOp to the server. Changing the code to call close instead
of destroy and passing the keepAlive flag along with the close. Also,
changing the cache to set keepAlive *before* marking the cache as
closed.

This should prevent any races where cache closure triggers the cache
client updater to destroy connections or close them with the wrong
keepAlive setting while the cache is being closed.

Note that I changed the default value for keepAlive in the cache and the
pool to be true. I did this because the DurableClientNetDown test forces
the connections to be closed without closing the cache, so it uses the default
value, but also because I think this is probably safer for cases of abnormal
termination that connections are closed by default with keepAlive=true until
the cache is actually closing.


Diffs (updated)
-

  
geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/InternalPool.java
 fcb0ae8358a1ec2394bf74bd7929867dd5e6f77e 
  
geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/PoolImpl.java
 65a4dd13c25f5363f4d5a6bc2d4da1f7806596a0 
  
geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/QueueManagerImpl.java
 7c9b187c6bc7ed6db64ac5670eb1daa3c594372f 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/GemFireCacheImpl.java
 05bc83837032c95114da118e197c01ca2b3cd4f4 
  
geode-core/src/test/java/com/gemstone/gemfire/cache/client/internal/AutoConnectionSourceImplJUnitTest.java
 8deedc18491c6308cc1628e006098ec22640fe5d 
  
geode-core/src/test/java/com/gemstone/gemfire/cache/client/internal/QueueManagerJUnitTest.java
 c2872e798cec373b6fba4a07a3ce8608cf235c37 

Diff: https://reviews.apache.org/r/50903/diff/


Testing
---


Thanks,

Dan Smith

Re: Geode M3 docs: Review opportunity

[William Markito]

LGTM.  +1

Thanks Dave!

On Mon, Aug 8, 2016 at 11:40 AM, Dave Barnes  wrote:

> I've posted the Geode User docs for the upcoming M3 release here:
>
> http://geode-review.cfapps.io/
>
> Please have a look at the section(s) describing the features you've
> implemented and send me any suggestions or corrections.
> Deadline is Code Release or this Friday, Aug 12, whichever comes first.
> Thanks,
> -Dave
>



-- 

~/William

Review Request 50962: GEODE-1742: Fixing synchronization of cqListeners in CqAttributesImpl

[Dan Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50962/
---

Review request for geode and anilkumar gingade.


Repository: geode


Description
---

Extracted CQAttributesImpl to it's own class, and fixed the
synchronization of cqListeners so that we grab a snapshot of the
listeners to check to avoid races where the listeners can change after
we check for null.


Diffs
-

  
geode-core/src/main/java/com/gemstone/gemfire/cache/query/CqAttributesFactory.java
 101c9e66be031be1b375150feaf410a025fd3efa 
  
geode-core/src/main/java/com/gemstone/gemfire/cache/query/internal/cq/CqAttributesImpl.java
 PRE-CREATION 
  
geode-core/src/test/java/com/gemstone/gemfire/cache/query/internal/cq/CqAttributesImplJUnitTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/50962/diff/


Testing
---


Thanks,

Dan Smith

Build failed in Jenkins: Geode-nightly #556

[Apache Jenkins Server]

See 

Changes:

[gzhou] This closes #229

--
[...truncated 509 lines...]
:geode-wan:javadocJar
:geode-wan:sourcesJar
:geode-wan:signArchives SKIPPED
:geode-web:javadoc UP-TO-DATE
:geode-web:javadocJar
:geode-web:sourcesJar
:geode-web:war
:geode-web:signArchives SKIPPED
:geode-web-api:jar
:geode-web-api:javadoc
:geode-web-api:javadocJar
:geode-web-api:sourcesJar
:geode-web-api:war
:geode-web-api:signArchives SKIPPED
:geode-assembly:distTar
:geode-assembly:distZip
:geode-assembly:writeBuildInfo
:geode-assembly:srcDistTar
:geode-assembly:srcDistZip
:geode-assembly:signArchives SKIPPED
:geode-assembly:assemble
:geode-assembly:compileTestJavaNote: Some input files use or override a 
deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-assembly:processTestResources
:geode-assembly:testClasses
:geode-assembly:checkMissedTests
:geode-assembly:installDist
:geode-assembly:test
:geode-assembly:check
:geode-assembly:build
:geode-assembly:distributedTest
:geode-assembly:flakyTest
:geode-assembly:integrationTest
:geode-common:assemble
:geode-common:compileTestJava
:geode-common:processTestResources UP-TO-DATE
:geode-common:testClasses
:geode-common:checkMissedTests
:geode-common:test
:geode-common:check
:geode-common:build
:geode-common:distributedTest
:geode-common:flakyTest
:geode-common:integrationTest
:geode-core:assemble
:geode-core:checkMissedTests
:geode-core:test
:geode-core:check
:geode-core:build
:geode-core:distributedTest

com.gemstone.gemfire.internal.cache.PartitionedRegionSingleHopDUnitTest > 
testMetadataIsSameOnAllServersAndClients FAILED
java.lang.AssertionError: Event never occurred after 6 ms: bucket 
copies are not created
at org.junit.Assert.fail(Assert.java:88)
at com.gemstone.gemfire.test.dunit.Wait.waitForCriterion(Wait.java:185)
at 
com.gemstone.gemfire.internal.cache.PartitionedRegionSingleHopDUnitTest.testMetadataIsSameOnAllServersAndClients(PartitionedRegionSingleHopDUnitTest.java:807)

7441 tests completed, 1 failed, 586 skipped
:geode-core:distributedTest FAILED
:geode-core:flakyTest
:geode-core:integrationTest
:geode-cq:assemble
:geode-cq:compileTestJavaNote: Some input files use or override a deprecated 
API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-cq:processTestResources
:geode-cq:testClasses
:geode-cq:checkMissedTests
:geode-cq:test
:geode-cq:check
:geode-cq:build
:geode-cq:distributedTest
:geode-cq:flakyTest
:geode-cq:integrationTest
:geode-json:assemble
:geode-json:compileTestJava UP-TO-DATE
:geode-json:processTestResources UP-TO-DATE
:geode-json:testClasses UP-TO-DATE
:geode-json:checkMissedTests UP-TO-DATE
:geode-json:test UP-TO-DATE
:geode-json:check
:geode-json:build
:geode-json:distributedTest UP-TO-DATE
:geode-json:flakyTest UP-TO-DATE
:geode-json:integrationTest UP-TO-DATE
:geode-junit:javadoc
:geode-junit:javadocJar
:geode-junit:sourcesJar
:geode-junit:signArchives SKIPPED
:geode-junit:assemble
:geode-junit:compileTestJava
:geode-junit:processTestResources UP-TO-DATE
:geode-junit:testClasses
:geode-junit:checkMissedTests
:geode-junit:test
:geode-junit:check
:geode-junit:build
:geode-junit:distributedTest
:geode-junit:flakyTest
:geode-junit:integrationTest
:geode-lucene:assemble
:geode-lucene:compileTestJavaNote: Some input files use or override a 
deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-lucene:processTestResources
:geode-lucene:testClasses
:geode-lucene:checkMissedTests
:geode-lucene:test
:geode-lucene:check
:geode-lucene:build
:geode-lucene:distributedTest
:geode-lucene:flakyTest
:geode-lucene:integrationTest
:geode-pulse:assemble
:geode-pulse:compileTestJavaNote: 

 uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-pulse:processTestResources
:geode-pulse:testClasses
:geode-pulse:checkMissedTests
:geode-pulse:test
:geode-pulse:check
:geode-pulse:build
:geode-pulse:distributedTest
:geode-pulse:flakyTest
:geode-pulse:integrationTest
:geode-rebalancer:jar
:geode-rebalancer:javadoc
:geode-rebalancer:javadocJar
:geode-rebalancer:sourcesJar
:geode-rebalancer:signArchives SKIPPED
:geode-rebalancer:assemble
:geode-rebalancer:compileTestJava
:geode-rebalancer:processTestResources UP-TO-DATE
:geode-rebalancer:testClasses
:geode-rebalancer:checkMissedTests