[jira] [Created] (HIVE-14670) org.apache.hadoop.hive.ql.TestMTQueries failure
Hari Sankar Sivarama Subramaniyan created HIVE-14670: Summary: org.apache.hadoop.hive.ql.TestMTQueries failure Key: HIVE-14670 URL: https://issues.apache.org/jira/browse/HIVE-14670 Project: Hive Issue Type: Sub-task Reporter: Hari Sankar Sivarama Subramaniyan Assignee: Hari Sankar Sivarama Subramaniyan Introduced by HIVE-14627. We used to have a common q_init file for MR and CliDriver tests till HIVE-14627 was committed. Now, that the init files are separate and join1.q and groupby2.q are run as part of minimr tests, we cannot use these tests to test multi-threaded queries with the same setup file because they would result in different stats (due to the way the init scripts are written). The easy fix would be to substitute join1.q and groupby2.q with 2 files that actually run in CliDriver mode. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HIVE-14665) vector_join_part_col_char.q failure
Hari Sankar Sivarama Subramaniyan created HIVE-14665: Summary: vector_join_part_col_char.q failure Key: HIVE-14665 URL: https://issues.apache.org/jira/browse/HIVE-14665 Project: Hive Issue Type: Sub-task Reporter: Hari Sankar Sivarama Subramaniyan Assignee: Hari Sankar Sivarama Subramaniyan Happens 100% of the time. Looks like a missed golden file update from HIVE-14502. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HIVE-14612) org.apache.hive.service.cli.operation.TestOperationLoggingLayout.testSwitchLogLayout failure
Hari Sankar Sivarama Subramaniyan created HIVE-14612: Summary: org.apache.hive.service.cli.operation.TestOperationLoggingLayout.testSwitchLogLayout failure Key: HIVE-14612 URL: https://issues.apache.org/jira/browse/HIVE-14612 Project: Hive Issue Type: Sub-task Reporter: Hari Sankar Sivarama Subramaniyan Assignee: Hari Sankar Sivarama Subramaniyan Failing for some time -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Review Request 51119: HIVE-14503: Remove explicit order by in qfiles for union tests
> On Aug. 18, 2016, 10:07 p.m., Hari Sankar Sivarama Subramaniyan wrote: > > ql/src/test/queries/clientpositive/union_type_chk.q, line 8 > > <https://reviews.apache.org/r/51119/diff/2/?file=1478771#file1478771line8> > > > > Not related to your change, but this could end up being a flaky test in > > future because of the limit clause without an order by. > > Prasanth_J wrote: > This order by is only for the outer most query right? The limits are for > the subquery. When the outer query has "order by" will that be pushed to > subqueries as well? I dont think the orderby gets pushed to the subquery (may be if there is a join, then it might make sense). The limits for the subquery itself can return any 2 rows, however I just noticed that the result of the subquery itself is a constant (as long as we have 2 rows) since we select a constant."select cast(1 as decimal(10,0)) x from (select * from src limit 2)", so we should be good here. - Hari Sankar --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51119/#review146136 --- On Aug. 18, 2016, 9:47 p.m., Prasanth_J wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51119/ > ------- > > (Updated Aug. 18, 2016, 9:47 p.m.) > > > Review request for hive, Hari Sankar Sivarama Subramaniyan and Siddharth Seth. > > > Bugs: HIVE-14503 > https://issues.apache.org/jira/browse/HIVE-14503 > > > Repository: hive-git > > > Description > --- > > HIVE-14503: Remove explicit order by in qfiles for union tests > > > Diffs > - > > ql/src/test/queries/clientpositive/union23.q > 052f34a92ec4397411501c2fa58d46b3bed2ae5a > ql/src/test/queries/clientpositive/union32.q > f47f0afae2dba196da285d73de879c6c6ab91da3 > ql/src/test/queries/clientpositive/union34.q > 2ab16de307a6c624d11bc0cd9ca5ef9926c1c6a1 > ql/src/test/queries/clientpositive/union36.q > c38e7b1287fe0f28cc3176558b5f35070c8e00c5 > ql/src/test/queries/clientpositive/unionDistinct_1.q > 0d53a961a4d9fb55eadcd8226598f5c75eb964b4 > ql/src/test/queries/clientpositive/union_remove_1.q > 702f71a66d18c52e96cd28fb5dc07a3b3babad38 > ql/src/test/queries/clientpositive/union_remove_10.q > 508f3540d04caa8cfb603a83e4c91ea5a8dcef2f > ql/src/test/queries/clientpositive/union_remove_11.q > bdfbf66a4419e52aea474cd5cdb8ea75e9410dd9 > ql/src/test/queries/clientpositive/union_remove_12.q > f6436f5e979b90403d8ec342d69c4e25382866c3 > ql/src/test/queries/clientpositive/union_remove_13.q > b02451b0458a6c79c28d8d4f0f0c894a9f0e11cb > ql/src/test/queries/clientpositive/union_remove_14.q > bec622605e0f04afbc23e61b7025727f2040e6da > ql/src/test/queries/clientpositive/union_remove_15.q > e38473975703d662a2937fdd925562f2eed9ade0 > ql/src/test/queries/clientpositive/union_remove_16.q > 41305bfe3f5689ed07ed0d500639515c09c56f0b > ql/src/test/queries/clientpositive/union_remove_17.q > 8f91d03e4046682577ac7a59f19db3f70ce64c1a > ql/src/test/queries/clientpositive/union_remove_18.q > ad38742ecd845c5b1f0a122c05f3bf3a339a445b > ql/src/test/queries/clientpositive/union_remove_19.q > 34f8b5a2427b7a40c5f990edc2372f6664bbcf7e > ql/src/test/queries/clientpositive/union_remove_2.q > 274608cb0b2b546b3a4916e68ff2a118abfea364 > ql/src/test/queries/clientpositive/union_remove_20.q > 93a49f3bebe5667e0f76948d6494c91b35c3ca0d > ql/src/test/queries/clientpositive/union_remove_21.q > fa8ff2731d0d4c2e26b12e50c2cb6432cb57f43d > ql/src/test/queries/clientpositive/union_remove_22.q > 0e97cae8099b9ef96f8648c846f8aa106a4a7080 > ql/src/test/queries/clientpositive/union_remove_24.q > 3a1e2257b03b7df770dbb27cc77bd5e665b8 > ql/src/test/queries/clientpositive/union_remove_25.q > d70adb959571854f0d817ebbbd5b6121b4194268 > ql/src/test/queries/clientpositive/union_remove_26.q > d35d4e259afd0643ab2535f299731654c6c8a627 > ql/src/test/queries/clientpositive/union_remove_3.q > 2e6e3e665843eb6741ff40491ad6bfaa0a804e29 > ql/src/test/queries/clientpositive/union_remove_4.q > a08bcc194dd00d42a94e821a593800ae2e7d21b2 > ql/src/test/queries/clientpositive/union_remove_5.q > 4ac3edf0711ed63e50ace2ca6c06a0fe89b762d8 > ql/src/test/queries/clientpositive/union_remove_6.q > f37f409d22802f551fd32884fafc052693445479 > ql/src/test/queries/clientpositive/union_remove_6_subq.q > 68537280efa4636e1adece2d004366fcece5360e
[jira] [Created] (HIVE-14578) Fixes to TestEncryptedHDFSCliDriver
Hari Sankar Sivarama Subramaniyan created HIVE-14578: Summary: Fixes to TestEncryptedHDFSCliDriver Key: HIVE-14578 URL: https://issues.apache.org/jira/browse/HIVE-14578 Project: Hive Issue Type: Sub-task Reporter: Hari Sankar Sivarama Subramaniyan Assignee: Hari Sankar Sivarama Subramaniyan 900s runtime. One of the stragglers. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Review Request 51119: HIVE-14503: Remove explicit order by in qfiles for union tests
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51119/#review146136 --- Fix it, then Ship it! The rest of the changes look good to me. ql/src/test/queries/clientpositive/union_type_chk.q (line 7) <https://reviews.apache.org/r/51119/#comment212512> Not related to your change, but this could end up being a flaky test in future because of the limit clause without an order by. - Hari Sankar Sivarama Subramaniyan On Aug. 18, 2016, 9:47 p.m., Prasanth_J wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51119/ > --- > > (Updated Aug. 18, 2016, 9:47 p.m.) > > > Review request for hive, Hari Sankar Sivarama Subramaniyan and Siddharth Seth. > > > Bugs: HIVE-14503 > https://issues.apache.org/jira/browse/HIVE-14503 > > > Repository: hive-git > > > Description > --- > > HIVE-14503: Remove explicit order by in qfiles for union tests > > > Diffs > - > > ql/src/test/queries/clientpositive/union23.q > 052f34a92ec4397411501c2fa58d46b3bed2ae5a > ql/src/test/queries/clientpositive/union32.q > f47f0afae2dba196da285d73de879c6c6ab91da3 > ql/src/test/queries/clientpositive/union34.q > 2ab16de307a6c624d11bc0cd9ca5ef9926c1c6a1 > ql/src/test/queries/clientpositive/union36.q > c38e7b1287fe0f28cc3176558b5f35070c8e00c5 > ql/src/test/queries/clientpositive/unionDistinct_1.q > 0d53a961a4d9fb55eadcd8226598f5c75eb964b4 > ql/src/test/queries/clientpositive/union_remove_1.q > 702f71a66d18c52e96cd28fb5dc07a3b3babad38 > ql/src/test/queries/clientpositive/union_remove_10.q > 508f3540d04caa8cfb603a83e4c91ea5a8dcef2f > ql/src/test/queries/clientpositive/union_remove_11.q > bdfbf66a4419e52aea474cd5cdb8ea75e9410dd9 > ql/src/test/queries/clientpositive/union_remove_12.q > f6436f5e979b90403d8ec342d69c4e25382866c3 > ql/src/test/queries/clientpositive/union_remove_13.q > b02451b0458a6c79c28d8d4f0f0c894a9f0e11cb > ql/src/test/queries/clientpositive/union_remove_14.q > bec622605e0f04afbc23e61b7025727f2040e6da > ql/src/test/queries/clientpositive/union_remove_15.q > e38473975703d662a2937fdd925562f2eed9ade0 > ql/src/test/queries/clientpositive/union_remove_16.q > 41305bfe3f5689ed07ed0d500639515c09c56f0b > ql/src/test/queries/clientpositive/union_remove_17.q > 8f91d03e4046682577ac7a59f19db3f70ce64c1a > ql/src/test/queries/clientpositive/union_remove_18.q > ad38742ecd845c5b1f0a122c05f3bf3a339a445b > ql/src/test/queries/clientpositive/union_remove_19.q > 34f8b5a2427b7a40c5f990edc2372f6664bbcf7e > ql/src/test/queries/clientpositive/union_remove_2.q > 274608cb0b2b546b3a4916e68ff2a118abfea364 > ql/src/test/queries/clientpositive/union_remove_20.q > 93a49f3bebe5667e0f76948d6494c91b35c3ca0d > ql/src/test/queries/clientpositive/union_remove_21.q > fa8ff2731d0d4c2e26b12e50c2cb6432cb57f43d > ql/src/test/queries/clientpositive/union_remove_22.q > 0e97cae8099b9ef96f8648c846f8aa106a4a7080 > ql/src/test/queries/clientpositive/union_remove_24.q > 3a1e2257b03b7df770dbb27cc77bd5e665b8 > ql/src/test/queries/clientpositive/union_remove_25.q > d70adb959571854f0d817ebbbd5b6121b4194268 > ql/src/test/queries/clientpositive/union_remove_26.q > d35d4e259afd0643ab2535f299731654c6c8a627 > ql/src/test/queries/clientpositive/union_remove_3.q > 2e6e3e665843eb6741ff40491ad6bfaa0a804e29 > ql/src/test/queries/clientpositive/union_remove_4.q > a08bcc194dd00d42a94e821a593800ae2e7d21b2 > ql/src/test/queries/clientpositive/union_remove_5.q > 4ac3edf0711ed63e50ace2ca6c06a0fe89b762d8 > ql/src/test/queries/clientpositive/union_remove_6.q > f37f409d22802f551fd32884fafc052693445479 > ql/src/test/queries/clientpositive/union_remove_6_subq.q > 68537280efa4636e1adece2d004366fcece5360e > ql/src/test/queries/clientpositive/union_remove_7.q > cd6a75a125c6835910bbf93fdc4000e558484af3 > ql/src/test/queries/clientpositive/union_remove_8.q > 93aabe618d0b76f77e5c9386a20958e5c42a9d81 > ql/src/test/queries/clientpositive/union_remove_9.q > 1bb8d6d7b779b40960c8b1bcd9284fdb458f1384 > ql/src/test/queries/clientpositive/union_script.q > 76871048556eda87ec5823e913e317219ba1ec16 > ql/src/test/queries/clientpositive/union_type_chk.q > a25aedadc3c04d317fcb15dc8108a63643ce6513 > ql/src/test/queries/clientpositive/union_view.q > fa394508cb829a7d78e9816108c37f30ce6d347f > ql/src/test/results/clientpositive/spark/
[jira] [Created] (HIVE-14552) TestParseNegative fix
Hari Sankar Sivarama Subramaniyan created HIVE-14552: Summary: TestParseNegative fix Key: HIVE-14552 URL: https://issues.apache.org/jira/browse/HIVE-14552 Project: Hive Issue Type: Sub-task Reporter: Hari Sankar Sivarama Subramaniyan Assignee: Hari Sankar Sivarama Subramaniyan 1300s runtime. Straggler towards the end of the build. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HIVE-14546) TestMiniTezCliDriver plan diffs
Hari Sankar Sivarama Subramaniyan created HIVE-14546:
Summary: TestMiniTezCliDriver plan diffs
Key: HIVE-14546
URL: https://issues.apache.org/jira/browse/HIVE-14546
Project: Hive
Issue Type: Bug
Reporter: Hari Sankar Sivarama Subramaniyan
Assignee: Hari Sankar Sivarama Subramaniyan
The following tests are failing consistently for the last some days in
precommit runs:
{code}
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[tez_join_hash]
56 sec 5
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainuser_2]
35 sec 19
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainuser_1]
58 sec 19
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[load_dyn_part1]
2.8 sec 19
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[transform_ppr1]
2.4 sec 19
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (HIVE-14520) We should set a timeout for the blocking calls in TestMsgBusConnection
Hari Sankar Sivarama Subramaniyan created HIVE-14520: Summary: We should set a timeout for the blocking calls in TestMsgBusConnection Key: HIVE-14520 URL: https://issues.apache.org/jira/browse/HIVE-14520 Project: Hive Issue Type: Bug Reporter: Hari Sankar Sivarama Subramaniyan Assignee: Hari Sankar Sivarama Subramaniyan consumer.receive() is a blocking call and if it fails, it will block for ever. Need to set timeout at the bare minimum to force the test to fail incase of failure rather than timing out. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HIVE-14507) org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver_orc_llap_counters failure
Hari Sankar Sivarama Subramaniyan created HIVE-14507: Summary: org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver_orc_llap_counters failure Key: HIVE-14507 URL: https://issues.apache.org/jira/browse/HIVE-14507 Project: Hive Issue Type: Sub-task Reporter: Hari Sankar Sivarama Subramaniyan Assignee: Hari Sankar Sivarama Subramaniyan Fails locally. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HIVE-14506) TestQueryLifeTimeHook hang
Hari Sankar Sivarama Subramaniyan created HIVE-14506: Summary: TestQueryLifeTimeHook hang Key: HIVE-14506 URL: https://issues.apache.org/jira/browse/HIVE-14506 Project: Hive Issue Type: Sub-task Reporter: Hari Sankar Sivarama Subramaniyan Assignee: Hari Sankar Sivarama Subramaniyan The test hangs locally. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HIVE-14505) Analyze org.apache.hive.jdbc.TestJdbcWithMiniHS2.testAddJarConstructorUnCaching failure
Hari Sankar Sivarama Subramaniyan created HIVE-14505: Summary: Analyze org.apache.hive.jdbc.TestJdbcWithMiniHS2.testAddJarConstructorUnCaching failure Key: HIVE-14505 URL: https://issues.apache.org/jira/browse/HIVE-14505 Project: Hive Issue Type: Sub-task Reporter: Hari Sankar Sivarama Subramaniyan Assignee: Hari Sankar Sivarama Subramaniyan Flaky test failure. Fails ~50% of the time locally. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Review Request 49965: HIVE-13995 Hive generates inefficient metastore queries for TPCDS tables with 1800+ partitions leading to higher compile time
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49965/ --- (Updated July 20, 2016, 10:16 p.m.) Review request for hive and Ashutosh Chauhan. Repository: hive-git Description --- Hive generates inefficient metastore queries for TPCDS tables with 1800+ partitions leading to higher compile time Diffs (updated) - itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java d90085b itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/hbase/TestHBaseAggrStatsCacheIntegration.java 51d96dd metastore/if/hive_metastore.thrift 4d92b73 metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 38c0eed metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 909d8eb metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java b6fe502 metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 9c900af metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 5adfa02 metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java bbd47b8 metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseStore.java c65c7a4 metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java 1ea72a0 metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java 3e6acc7 metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseAggregateStatsCache.java 6cd3a46 metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseAggregateStatsCacheWithBitVector.java e0c4094 metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseAggregateStatsExtrapolation.java f4e55ed metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseAggregateStatsNDVUniformDist.java 62918be ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java ef0bb3d ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionPruner.java 26e936e ql/src/java/org/apache/hadoop/hive/ql/parse/PrunedPartitionList.java da2e1e2 ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java d8acf94 Diff: https://reviews.apache.org/r/49965/diff/ Testing --- Thanks, Hari Sankar Sivarama Subramaniyan
Re: Review Request 49965: HIVE-13995 Hive generates inefficient metastore queries for TPCDS tables with 1800+ partitions leading to higher compile time
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49965/ --- (Updated July 20, 2016, 6:15 a.m.) Review request for hive and Ashutosh Chauhan. Repository: hive-git Description --- Hive generates inefficient metastore queries for TPCDS tables with 1800+ partitions leading to higher compile time Diffs (updated) - metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 38c0eed metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 909d8eb metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 9c900af ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionPruner.java 26e936e ql/src/java/org/apache/hadoop/hive/ql/parse/PrunedPartitionList.java da2e1e2 ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java d8acf94 Diff: https://reviews.apache.org/r/49965/diff/ Testing --- Thanks, Hari Sankar Sivarama Subramaniyan
Re: Review Request 49965: HIVE-13995 Hive generates inefficient metastore queries for TPCDS tables with 1800+ partitions leading to higher compile time
> On July 19, 2016, 9:40 p.m., Ashutosh Chauhan wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java, > > lines 1255-1258 > > <https://reviews.apache.org/r/49965/diff/3/?file=1447530#file1447530line1255> > > > > I don't think this null check is needed. Ok, noticed we wont hit this code if partNames is null. > On July 19, 2016, 9:40 p.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java, line 310 > > <https://reviews.apache.org/r/49965/diff/3/?file=1447533#file1447533line310> > > > > getPartsFound() should be set correctly from server and this means this > > logic can be improved here. In the case where partNames = null, does it not mean that we have retrieved column stats for all the partitions and hence not set the colState to State.PARTIAL. - Hari Sankar --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49965/#review142839 ------- On July 19, 2016, 9:19 p.m., Hari Sankar Sivarama Subramaniyan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49965/ > --- > > (Updated July 19, 2016, 9:19 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Repository: hive-git > > > Description > --- > > Hive generates inefficient metastore queries for TPCDS tables with 1800+ > partitions leading to higher compile time > > > Diffs > - > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 38c0eed > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java > 909d8eb > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java > 9c900af > ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionPruner.java > 26e936e > ql/src/java/org/apache/hadoop/hive/ql/parse/PrunedPartitionList.java > da2e1e2 > ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java d8acf94 > > Diff: https://reviews.apache.org/r/49965/diff/ > > > Testing > --- > > > Thanks, > > Hari Sankar Sivarama Subramaniyan > >
Re: Review Request 49965: HIVE-13995 Hive generates inefficient metastore queries for TPCDS tables with 1800+ partitions leading to higher compile time
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49965/ --- (Updated July 19, 2016, 9:19 p.m.) Review request for hive and Ashutosh Chauhan. Changes --- Ran the failing clidriver test suites, checked hive.log to make sure that we are successfully removing the in clause at metastoredirectsql when all partitions are found. Repository: hive-git Description --- Hive generates inefficient metastore queries for TPCDS tables with 1800+ partitions leading to higher compile time Diffs (updated) - metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 38c0eed metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 909d8eb metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 9c900af ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionPruner.java 26e936e ql/src/java/org/apache/hadoop/hive/ql/parse/PrunedPartitionList.java da2e1e2 ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java d8acf94 Diff: https://reviews.apache.org/r/49965/diff/ Testing --- Thanks, Hari Sankar Sivarama Subramaniyan
Re: Review Request 49965: HIVE-13995 Hive generates inefficient metastore queries for TPCDS tables with 1800+ partitions leading to higher compile time
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49965/#review142821 --- ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java (line 275) <https://reviews.apache.org/r/49965/#comment208476> This should be (partNames == null || partNames.size() > 0) - Hari Sankar Sivarama Subramaniyan On July 19, 2016, 8:01 p.m., Hari Sankar Sivarama Subramaniyan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49965/ > --- > > (Updated July 19, 2016, 8:01 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Repository: hive-git > > > Description > --- > > Hive generates inefficient metastore queries for TPCDS tables with 1800+ > partitions leading to higher compile time > > > Diffs > - > > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java > 9c900af > ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionPruner.java > 26e936e > ql/src/java/org/apache/hadoop/hive/ql/parse/PrunedPartitionList.java > da2e1e2 > ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java d8acf94 > > Diff: https://reviews.apache.org/r/49965/diff/ > > > Testing > --- > > > Thanks, > > Hari Sankar Sivarama Subramaniyan > >
Re: Review Request 49965: HIVE-13995 Hive generates inefficient metastore queries for TPCDS tables with 1800+ partitions leading to higher compile time
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49965/ --- (Updated July 19, 2016, 8:01 p.m.) Review request for hive and Ashutosh Chauhan. Repository: hive-git Description --- Hive generates inefficient metastore queries for TPCDS tables with 1800+ partitions leading to higher compile time Diffs (updated) - metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 9c900af ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionPruner.java 26e936e ql/src/java/org/apache/hadoop/hive/ql/parse/PrunedPartitionList.java da2e1e2 ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java d8acf94 Diff: https://reviews.apache.org/r/49965/diff/ Testing --- Thanks, Hari Sankar Sivarama Subramaniyan
Re: Review Request 49965: HIVE-13995 Hive generates inefficient metastore queries for TPCDS tables with 1800+ partitions leading to higher compile time
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49965/ --- (Updated July 19, 2016, 7:26 a.m.) Review request for hive and Ashutosh Chauhan. Repository: hive-git Description --- Hive generates inefficient metastore queries for TPCDS tables with 1800+ partitions leading to higher compile time Diffs (updated) - metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 9c900af ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionPruner.java 26e936e ql/src/java/org/apache/hadoop/hive/ql/parse/PrunedPartitionList.java da2e1e2 ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java d8acf94 Diff: https://reviews.apache.org/r/49965/diff/ Testing --- Thanks, Hari Sankar Sivarama Subramaniyan
Review Request 49965: HIVE-13995 Hive generates inefficient metastore queries for TPCDS tables with 1800+ partitions leading to higher compile time
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49965/ --- Review request for hive and Ashutosh Chauhan. Repository: hive-git Description --- Hive generates inefficient metastore queries for TPCDS tables with 1800+ partitions leading to higher compile time Diffs - metastore/if/hive_metastore.thrift 4d92b73 metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/AggregatePartitionsStatsRequest.java PRE-CREATION metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/AggregatePartitionsStatsResponse.java PRE-CREATION metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java c945bf7 metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 44d73d4 metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java b6fe502 metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 9c900af metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 5adfa02 metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java bbd47b8 metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseStore.java c65c7a4 metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java 1ea72a0 metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java 3e6acc7 ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/RelOptHiveTable.java 73ca9bf ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionPruner.java 26e936e ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java 5625091 ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java d8acf94 Diff: https://reviews.apache.org/r/49965/diff/ Testing --- Thanks, Hari Sankar Sivarama Subramaniyan
Review Request 49274: HIVE-13995
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49274/ --- Review request for hive and Ashutosh Chauhan. Repository: hive-git Description --- Hive generates inefficient metastore queries for TPCDS tables with 1800+ partitions leading to higher compile time Diffs - metastore/if/hive_metastore.thrift 4d92b73 metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/AggregatePartitionsStatsRequest.java PRE-CREATION metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/AggregatePartitionsStatsResponse.java PRE-CREATION metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java c0827ea metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java f47dfa1 metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java b6fe502 metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java b809269 metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java f67efcd metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java a6d3f53 metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseStore.java 30bb439 metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java 3152e77 metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java 86a2436 ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/RelOptHiveTable.java 73ca9bf ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionPruner.java 26e936e ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java 5625091 ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java d8acf94 Diff: https://reviews.apache.org/r/49274/diff/ Testing --- Local testing done. Testing in cluster pending. Thanks, Hari Sankar Sivarama Subramaniyan
[jira] [Created] (HIVE-14020) Hive MS restart failed during EU with ORA-00922 error as part of DB schema upgrade
Hari Sankar Sivarama Subramaniyan created HIVE-14020:
Summary: Hive MS restart failed during EU with ORA-00922 error as
part of DB schema upgrade
Key: HIVE-14020
URL: https://issues.apache.org/jira/browse/HIVE-14020
Project: Hive
Issue Type: Bug
Reporter: Hari Sankar Sivarama Subramaniyan
Assignee: Hari Sankar Sivarama Subramaniyan
The underlying failure seems to be visible from --verbose :
{noformat}
Metastore connection URL:jdbc:oracle:thin:@//172.22.66.99:1521/XE
Metastore Connection Driver :oracle.jdbc.driver.OracleDriver
Metastore connection User: hiveuser
Starting upgrade metastore schema from version 2.0.0 to 2.1.0
Upgrade script upgrade-2.0.0-to-2.1.0.oracle.sql
Connecting to jdbc:oracle:thin:@//172.22.66.99:1521/XE
Connected to: Oracle (version Oracle Database 11g Express Edition Release
11.2.0.2.0 - 64bit Production)
Driver: Oracle JDBC driver (version 11.2.0.4.0)
Transaction isolation: TRANSACTION_READ_COMMITTED
0: jdbc:oracle:thin:@//172.22.66.99:1521/XE> !autocommit on
Autocommit status: true
0: jdbc:oracle:thin:@//172.22.66.99:1521/XE> SELECT 'Upgrading MetaStore schema
from 2.0.0 to 2.1.0' AS Status from dual
+-+--+
| STATUS |
+-+--+
| Upgrading MetaStore schema from 2.0.0 to 2.1.0 |
+-+--+
1 row selected (0.072 seconds)
0: jdbc:oracle:thin:@//172.22.66.99:1521/XE> CREATE TABLE IF NOT EXISTS
KEY_CONSTRAINTS ( CHILD_CD_ID NUMBER, CHILD_INTEGER_IDX NUMBER, CHILD_TBL_ID
NUMBER, PARENT_CD_ID NUMBER NOT NULL, PARENT_INTEGER_IDX ^M NUMBER NOT NULL,
PARENT_TBL_ID NUMBER NOT NULL, POSITION NUMBER NOT NULL, CONSTRAINT_NAME
VARCHAR(400) NOT NULL, CONSTRAINT_TYPE NUMBER NOT NULL, UPDATE_RULE NUMBER,
DELETE_RULE NUMBER, ENABLE_VALIDATE_REL ^MY NUMBER NOT NULL )
Error: ORA-00922: missing or invalid option (state=42000,code=922)
Closing: 0: jdbc:oracle:thin:@//172.22.66.99:1521/XE
org.apache.hadoop.hive.metastore.HiveMetaException: Upgrade FAILED! Metastore
state would be inconsistent !!
Underlying cause: java.io.IOException : Schema script failed, errorcode 2
org.apache.hadoop.hive.metastore.HiveMetaException: Upgrade FAILED! Metastore
state would be inconsistent !!
at
org.apache.hive.beeline.HiveSchemaTool.doUpgrade(HiveSchemaTool.java:250)
at
org.apache.hive.beeline.HiveSchemaTool.doUpgrade(HiveSchemaTool.java:218)
at org.apache.hive.beeline.HiveSchemaTool.main(HiveSchemaTool.java:500)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at org.apache.hadoop.util.RunJar.run(RunJar.java:221)
at org.apache.hadoop.util.RunJar.main(RunJar.java:136)
Caused by: java.io.IOException: Schema script failed, errorcode 2
at
org.apache.hive.beeline.HiveSchemaTool.runBeeLine(HiveSchemaTool.java:390)
at
org.apache.hive.beeline.HiveSchemaTool.runBeeLine(HiveSchemaTool.java:347)
at
org.apache.hive.beeline.HiveSchemaTool.doUpgrade(HiveSchemaTool.java:245)
... 8 more
*** schemaTool failed ***
{noformat}
At the face of it, it looks like bad ^Ms got added from the actual script (
034-HIVE-13076.oracle.sql ) that's provided:
{noformat}
CREATE TABLE IF NOT EXISTS KEY_CONSTRAINTS
(
CHILD_CD_ID NUMBER,
CHILD_INTEGER_IDX NUMBER,
CHILD_TBL_ID NUMBER,
PARENT_CD_ID NUMBER NOT NULL,
PARENT_INTEGER_IDX NUMBER NOT NULL,
PARENT_TBL_ID NUMBER NOT NULL,
POSITION NUMBER NOT NULL,
CONSTRAINT_NAME VARCHAR(400) NOT NULL,
CONSTRAINT_TYPE NUMBER NOT NULL,
UPDATE_RULE NUMBER,
DELETE_RULE NUMBER,
ENABLE_VALIDATE_RELY NUMBER NOT NULL
) ;
ALTER TABLE KEY_CONSTRAINTS ADD CONSTRAINT CONSTRAINTS_PK PRIMARY KEY
(CONSTRAINT_NAME, POSITION);
CREATE INDEX CONSTRAINTS_PT_INDEX ON KEY_CONSTRAINTS(PARENT_TBL_ID);
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Re: Review Request 48520: Use multi-threaded approach to listing files for msck
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48520/#review137096 --- ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMetaStoreChecker.java (line 385) <https://reviews.apache.org/r/48520/#comment202258> My bad for the not catching this earlier. Realized this could be dangerous as it is inside a recursive call. For each level of the directory, you are creating a new thread pool, which means that you can potentially go all the way to create (#THREADS)^(#levels) worker threads instead of (#THREADS) and effectively choke the system. You need to share the thread pool amongst all the recursive calls, so that way you dont create a new pool for each level of recursion. - Hari Sankar Sivarama Subramaniyan On June 10, 2016, 11:58 p.m., pengcheng xiong wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48520/ > --- > > (Updated June 10, 2016, 11:58 p.m.) > > > Review request for hive and Hari Sankar Sivarama Subramaniyan. > > > Repository: hive-git > > > Description > --- > > HIVE-13984 > > > Diffs > - > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 285caa3 > ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMetaStoreChecker.java > 10fa561 > > Diff: https://reviews.apache.org/r/48520/diff/ > > > Testing > --- > > > Thanks, > > pengcheng xiong > >
Re: Review Request 48520: Use multi-threaded approach to listing files for msck
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48520/#review137095 --- ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMetaStoreChecker.java (line 390) <https://reviews.apache.org/r/48520/#comment202257> I think it will be a cleaner and more maintanable approach to move this serial code path into a separate function and make the correct function call(i.e. parallel or serial) in getAllLeafDirs(Path basePath, Set allDirs) based on the value of HIVE_MOVE_FILES_THREAD_COUNT around line 374. This will also prevent creating unnecessary nextLevel queue altogether in the serial code path for each recursive call. i.e. you can make the recursive call inside for loop itself as done in the existing code for serial path instead of adding the item to the queue and then making a recursive call. - Hari Sankar Sivarama Subramaniyan On June 10, 2016, 11:58 p.m., pengcheng xiong wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48520/ > --- > > (Updated June 10, 2016, 11:58 p.m.) > > > Review request for hive and Hari Sankar Sivarama Subramaniyan. > > > Repository: hive-git > > > Description > --- > > HIVE-13984 > > > Diffs > - > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 285caa3 > ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMetaStoreChecker.java > 10fa561 > > Diff: https://reviews.apache.org/r/48520/diff/ > > > Testing > --- > > > Thanks, > > pengcheng xiong > >
Re: Review Request 48520: Use multi-threaded approach to listing files for msck
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48520/#review137089 --- ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMetaStoreChecker.java (line 379) <https://reviews.apache.org/r/48520/#comment202253> Yes, it is a nit. I meant the getAllLeafDirs(.., final SynchronizedSet allDirs, ...). It is fine with the way it is since it is a private fn and used only at one place, but if someone is to make this public in future for some reason, it could be misused. - Hari Sankar Sivarama Subramaniyan On June 10, 2016, 11:58 p.m., pengcheng xiong wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48520/ > --- > > (Updated June 10, 2016, 11:58 p.m.) > > > Review request for hive and Hari Sankar Sivarama Subramaniyan. > > > Repository: hive-git > > > Description > --- > > HIVE-13984 > > > Diffs > - > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 285caa3 > ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMetaStoreChecker.java > 10fa561 > > Diff: https://reviews.apache.org/r/48520/diff/ > > > Testing > --- > > > Thanks, > > pengcheng xiong > >
Re: Review Request 48520: Use multi-threaded approach to listing files for msck
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48520/#review136931 --- ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMetaStoreChecker.java (line 379) <https://reviews.apache.org/r/48520/#comment202051> nit: is it possible to make allDirs as SynchronizedSet so that someone doesnt misuse this in future. ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMetaStoreChecker.java (line 385) <https://reviews.apache.org/r/48520/#comment202037> Can you please update this parameter description in HiveConf. ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMetaStoreChecker.java (line 390) <https://reviews.apache.org/r/48520/#comment202046> nit: Fine to use a Void return type and return null object instead of true always. ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMetaStoreChecker.java (line 394) <https://reviews.apache.org/r/48520/#comment202052> This will be effectively a serial operation if we have a skewed directory structure (very rare or possibly no scenarios ??) Another thing I remembered is that HIVE_MOVE_FILES_THREAD_COUNT does support a value of 0, which runs the entire thing in serial mode. So if you are reusing that configuration, you will have to keep the serial code path or else you need to introduce a new param. Otherwise there will be a conflict. - Hari Sankar Sivarama Subramaniyan On June 9, 2016, 11:16 p.m., pengcheng xiong wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48520/ > --- > > (Updated June 9, 2016, 11:16 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Repository: hive-git > > > Description > --- > > HIVE-13984 > > > Diffs > - > > ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMetaStoreChecker.java > 10fa561 > > Diff: https://reviews.apache.org/r/48520/diff/ > > > Testing > --- > > > Thanks, > > pengcheng xiong > >
[jira] [Created] (HIVE-13911) load inpath fails throwing org.apache.hadoop.security.AccessControlException
Hari Sankar Sivarama Subramaniyan created HIVE-13911: Summary: load inpath fails throwing org.apache.hadoop.security.AccessControlException Key: HIVE-13911 URL: https://issues.apache.org/jira/browse/HIVE-13911 Project: Hive Issue Type: Bug Reporter: Hari Sankar Sivarama Subramaniyan Assignee: Hari Sankar Sivarama Subramaniyan Attachments: HIVE-13911.1.patch Similar to HIVE-13857 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Review Request 47916: HIVE-13857 insert overwrite select from some table fails throwing org.apache.hadoop.security.AccessControlException - II
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47916/ --- (Updated May 27, 2016, 9:50 p.m.) Review request for hive and Ashutosh Chauhan. Repository: hive-git Description --- insert overwrite select from some table fails throwing org.apache.hadoop.security.AccessControlException - II Diffs (updated) - ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java bc39994 ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 379eddc shims/common/src/main/java/org/apache/hadoop/hive/io/HdfsUtils.java c2060fc Diff: https://reviews.apache.org/r/47916/diff/ Testing --- Thanks, Hari Sankar Sivarama Subramaniyan
Re: Review Request 47916: HIVE-13857 insert overwrite select from some table fails throwing org.apache.hadoop.security.AccessControlException - II
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47916/ --- (Updated May 27, 2016, 7:42 p.m.) Review request for hive and Ashutosh Chauhan. Repository: hive-git Description --- insert overwrite select from some table fails throwing org.apache.hadoop.security.AccessControlException - II Diffs (updated) - ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 717589a ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 3fa1233 shims/common/src/main/java/org/apache/hadoop/hive/io/HdfsUtils.java c2060fc Diff: https://reviews.apache.org/r/47916/diff/ Testing --- Thanks, Hari Sankar Sivarama Subramaniyan
Re: Review Request 47916: HIVE-13857 insert overwrite select from some table fails throwing org.apache.hadoop.security.AccessControlException - II
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47916/ --- (Updated May 26, 2016, 9:28 p.m.) Review request for hive and Ashutosh Chauhan. Changes --- Missed out uploading the missing callsite changes in the previous one. Repository: hive-git Description --- insert overwrite select from some table fails throwing org.apache.hadoop.security.AccessControlException - II Diffs (updated) - ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 717589a ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 3fa1233 shims/common/src/main/java/org/apache/hadoop/hive/io/HdfsUtils.java c2060fc Diff: https://reviews.apache.org/r/47916/diff/ Testing --- Thanks, Hari Sankar Sivarama Subramaniyan
Re: Review Request 47916: HIVE-13857 insert overwrite select from some table fails throwing org.apache.hadoop.security.AccessControlException - II
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47916/ --- (Updated May 26, 2016, 9:14 p.m.) Review request for hive and Ashutosh Chauhan. Repository: hive-git Description --- insert overwrite select from some table fails throwing org.apache.hadoop.security.AccessControlException - II Diffs (updated) - ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 3fa1233 shims/common/src/main/java/org/apache/hadoop/hive/io/HdfsUtils.java c2060fc Diff: https://reviews.apache.org/r/47916/diff/ Testing --- Thanks, Hari Sankar Sivarama Subramaniyan
Re: Review Request 47916: HIVE-13857 insert overwrite select from some table fails throwing org.apache.hadoop.security.AccessControlException - II
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47916/#review135068 --- ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java (line 2889) <https://reviews.apache.org/r/47916/#comment200045> ah makes sense. Thanks. - Hari Sankar Sivarama Subramaniyan On May 26, 2016, 8:10 p.m., Hari Sankar Sivarama Subramaniyan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47916/ > --- > > (Updated May 26, 2016, 8:10 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Repository: hive-git > > > Description > --- > > insert overwrite select from some table fails throwing > org.apache.hadoop.security.AccessControlException - II > > > Diffs > - > > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 3fa1233 > shims/common/src/main/java/org/apache/hadoop/hive/io/HdfsUtils.java c2060fc > > Diff: https://reviews.apache.org/r/47916/diff/ > > > Testing > --- > > > Thanks, > > Hari Sankar Sivarama Subramaniyan > >
Re: Review Request 47916: HIVE-13857 insert overwrite select from some table fails throwing org.apache.hadoop.security.AccessControlException - II
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47916/#review135063 --- ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java (line 2889) <https://reviews.apache.org/r/47916/#comment200040> Do you mean to say destFs.getFileStatus(destf) is incorrect here. If so, which object should I use. - Hari Sankar Sivarama Subramaniyan On May 26, 2016, 8:10 p.m., Hari Sankar Sivarama Subramaniyan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47916/ > --- > > (Updated May 26, 2016, 8:10 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Repository: hive-git > > > Description > --- > > insert overwrite select from some table fails throwing > org.apache.hadoop.security.AccessControlException - II > > > Diffs > - > > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 3fa1233 > shims/common/src/main/java/org/apache/hadoop/hive/io/HdfsUtils.java c2060fc > > Diff: https://reviews.apache.org/r/47916/diff/ > > > Testing > --- > > > Thanks, > > Hari Sankar Sivarama Subramaniyan > >
Review Request 47916: HIVE-13857 insert overwrite select from some table fails throwing org.apache.hadoop.security.AccessControlException - II
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47916/ --- Review request for hive and Ashutosh Chauhan. Repository: hive-git Description --- insert overwrite select from some table fails throwing org.apache.hadoop.security.AccessControlException - II Diffs - ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 3fa1233 shims/common/src/main/java/org/apache/hadoop/hive/io/HdfsUtils.java c2060fc Diff: https://reviews.apache.org/r/47916/diff/ Testing --- Thanks, Hari Sankar Sivarama Subramaniyan
[jira] [Created] (HIVE-13857) insert overwrite select from some table fails throwing org.apache.hadoop.security.AccessControlException - II
Hari Sankar Sivarama Subramaniyan created HIVE-13857: Summary: insert overwrite select from some table fails throwing org.apache.hadoop.security.AccessControlException - II Key: HIVE-13857 URL: https://issues.apache.org/jira/browse/HIVE-13857 Project: Hive Issue Type: Bug Reporter: Hari Sankar Sivarama Subramaniyan Assignee: Hari Sankar Sivarama Subramaniyan HIVE-13810 missed a fix, tracking it here. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HIVE-13822) TestPerfCliDriver throws warning in StatsSetupConst that JsonParser cannot parse COLUMN_STATS
Hari Sankar Sivarama Subramaniyan created HIVE-13822:
Summary: TestPerfCliDriver throws warning in StatsSetupConst that
JsonParser cannot parse COLUMN_STATS
Key: HIVE-13822
URL: https://issues.apache.org/jira/browse/HIVE-13822
Project: Hive
Issue Type: Bug
Reporter: Hari Sankar Sivarama Subramaniyan
Assignee: Hari Sankar Sivarama Subramaniyan
Thanks to [~jcamachorodriguez] for uncovering this issue as part of HIVE-13269.
StatsSetupConst.areColumnStatsUptoDate() is used to check whether stats are
up-to-date. In case of PerfCliDriver, ‘false’ (thus, not up-to-date) is
returned and the following debug message in the logs:
{code}
In StatsSetupConst, JsonParser can not parse COLUMN_STATS. (line 190 in
StatsSetupConst)
{code}
Looks like the issue started happening after HIVE-12261 went in.
The fix would be to replace
{{COLUMN_STATS_ACCURATE,true}}
with
{{COLUMN_STATS_ACCURATE,{"COLUMN_STATS":{"key":"true","value":"true"},"BASIC_STATS":"true"}}}
in data/files/tpcds-perf/metastore_export/csv/TABLE_PARAMS.txt
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (HIVE-13810) insert overwrite select from some table fails throwing org.apache.hadoop.security.AccessControlException
Hari Sankar Sivarama Subramaniyan created HIVE-13810:
Summary: insert overwrite select from some table fails throwing
org.apache.hadoop.security.AccessControlException
Key: HIVE-13810
URL: https://issues.apache.org/jira/browse/HIVE-13810
Project: Hive
Issue Type: Bug
Reporter: Hari Sankar Sivarama Subramaniyan
Assignee: Hari Sankar Sivarama Subramaniyan
{noformat} CREATE EXTERNAL TABLE Batters_txt(
Player STRING ,
Team STRING ,
League STRING ,
Year SMALLINT,
Games DOUBLE,
AB DOUBLE,
R DOUBLE,
H DOUBLE,
Doubles DOUBLE,
Triples DOUBLE,
HR DOUBLE,
RBI DOUBLE,
SB DOUBLE,
CS DOUBLE,
BB DOUBLE,
SO DOUBLE,
IBB DOUBLE,
HBP DOUBLE,
SH DOUBLE,
SF DOUBLE,
GIDP DOUBLE
)
location '/user/tableau/Batters';
drop table if exists Batters;
CREATE TABLE Batters (
Player STRING ,
Team STRING ,
League STRING ,
Year SMALLINT,
Games DOUBLE,
AB DOUBLE,
R DOUBLE,
H DOUBLE,
Doubles DOUBLE,
Triples DOUBLE,
HR DOUBLE,
RBI DOUBLE,
SB DOUBLE,
CS DOUBLE,
BB DOUBLE,
SO DOUBLE,
IBB DOUBLE,
HBP DOUBLE,
SH DOUBLE,
SF DOUBLE,
GIDP DOUBLE
)
STORED AS orc tblproperties ("orc.compress"="SNAPPY");
insert overwrite table Batters select * from Batters_txt;
{noformat}
runs into the following error:
{code}
2016-05-18T19:59:00,883 ERROR [HiveServer2-Background-Pool: Thread-306]:
operation.Operation (:()) - Error running hive query:
org.apache.hive.service.cli.HiveSQLException: Error while processing statement:
FAILED: Execution Error, return code 1 from
org.apache.hadoop.hive.ql.exec.MoveTask.
org.apache.hadoop.security.AccessControlException: User does not belong to hdfs
at
org.apache.hadoop.hdfs.server.namenode.FSDirAttrOp.setOwner(FSDirAttrOp.java:88)
at
org.apache.hadoop.hdfs.server.namenode.FSNamesystem.setOwner(FSNamesystem.java:1706)
at
org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer.setOwner(NameNodeRpcServer.java:818)
at
org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolServerSideTranslatorPB.setOwner(ClientNamenodeProtocolServerSideTranslatorPB.java:472)
at
org.apache.hadoop.hdfs.protocol.proto.ClientNamenodeProtocolProtos$ClientNamenodeProtocol$2.callBlockingMethod(ClientNamenodeProtocolProtos.java)
at
org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:644)
at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:969)
at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:2273)
at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:2269)
at java.security.AccessController.doPrivileged(Native Method)
at javax.security.auth.Subject.doAs(Subject.java:422)
at
org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1724)
at org.apache.hadoop.ipc.Server$Handler.run(Server.java:2267)
at
org.apache.hive.service.cli.operation.Operation.toSQLException(Operation.java:387)
at
org.apache.hive.service.cli.operation.SQLOperation.runQuery(SQLOperation.java:237)
at
org.apache.hive.service.cli.operation.SQLOperation.access$300(SQLOperation.java:90)
at
org.apache.hive.service.cli.operation.SQLOperation$2$1.run(SQLOperation.java:290)
at java.security.AccessController.doPrivileged(Native Method)
at javax.security.auth.Subject.doAs(Subject.java:422)
at
org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1724)
at
org.apache.hive.service.cli.operation.SQLOperation$2.run(SQLOperation.java:303)
at
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)
Caused by: org.apache.hadoop.hive.ql.metadata.HiveException:
org.apache.hadoop.security.AccessControlException: User does not belong to hdfs
at
org.apache.hadoop.hdfs.server.namenode.FSDirAttrOp.setOwner(FSDirAttrOp.java:88)
at
org.apache.hadoop.hdfs.server.namenode.FSNamesystem.setOwner(FSNamesystem.java:1706)
at
org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer.setOwner(NameNodeRpcServer.java:818)
at
org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolServerSideTranslatorPB.setOwner(ClientNamenodeProtocolServerSideT
[jira] [Created] (HIVE-13784) Hive Metastore start failed on Oracle DB
Hari Sankar Sivarama Subramaniyan created HIVE-13784:
Summary: Hive Metastore start failed on Oracle DB
Key: HIVE-13784
URL: https://issues.apache.org/jira/browse/HIVE-13784
Project: Hive
Issue Type: Bug
Reporter: Hari Sankar Sivarama Subramaniyan
Assignee: Hari Sankar Sivarama Subramaniyan
During hive metastore start, hive is trying to execute this script
{{hive-schema-2.1.0.oracle.sql}}:
{code}
Metastore connection URL:jdbc:oracle:thin:@//172.22.114.220:1521/XE
Metastore Connection Driver :oracle.jdbc.driver.OracleDriver
Metastore connection User: hiveuser
Starting metastore schema initialization to 2.1.0
Initialization script hive-schema-2.1.0.oracle.sql
Connecting to jdbc:oracle:thin:@//172.22.114.220:1521/XE
Connected to: Oracle (version Oracle Database 11g Express Edition Release
11.2.0.2.0 - 64bit Production)
Driver: Oracle JDBC driver (version 11.2.0.2.0)
Transaction isolation: TRANSACTION_READ_COMMITTED
0: jdbc:oracle:thin:@//172.22.114.220:1521/XE> !autocommit on
Autocommit status: true
0: jdbc:oracle:thin:@//172.22.114.220:1521/XE> CREATE TABLE SEQUENCE_TABLE (
SEQ
UENCE_NAME VARCHAR2(255) NOT NULL, NEXT_VAL NUMBER NOT NULL )
No rows affected (0.208 seconds)
..
{code}
but inthe end of this script we are getting Error:
{code}
0: jdbc:oracle:thin:@//172.22.114.220:1521/XE> CREATE INDEX
CONSTRAINTS_PARENT_T
BL_ID_INDEX ON KEY_CONSTRAINTS(PARENT_TBL_ID)
Error: ORA-00972: identifier is too long (state=42000,code=972)
Closing: 0: jdbc:oracle:thin:@//172.22.114.220:1521/XE
org.apache.hadoop.hive.metastore.HiveMetaException: Schema initialization
FAILED! Metastore state would be inconsistent !!
org.apache.hadoop.hive.metastore.HiveMetaException: Schema initialization
FAILED! Metastore state would be inconsistent !!
at
org.apache.hive.beeline.HiveSchemaTool.doInit(HiveSchemaTool.java:291)
at
org.apache.hive.beeline.HiveSchemaTool.doInit(HiveSchemaTool.java:264)
at org.apache.hive.beeline.HiveSchemaTool.main(HiveSchemaTool.java:505)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at org.apache.hadoop.util.RunJar.run(RunJar.java:221)
at org.apache.hadoop.util.RunJar.main(RunJar.java:136)
Caused by: java.io.IOException: Schema script failed, errorcode 2
at
org.apache.hive.beeline.HiveSchemaTool.runBeeLine(HiveSchemaTool.java:390)
at
org.apache.hive.beeline.HiveSchemaTool.runBeeLine(HiveSchemaTool.java:347)
at
org.apache.hive.beeline.HiveSchemaTool.doInit(HiveSchemaTool.java:287)
... 8 more
*** schemaTool failed ***
{code}
We have a problem with too long identifier: {{CONSTRAINTS_PARENT_TBL_ID_INDEX}}
(31 symbol), it should be 30 symbols of max length.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Review Request 47432: HIVE-13708: Create table should verify datatypes supported by the serde
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47432/ --- Review request for hive, Ashutosh Chauhan and Thejas Nair. Repository: hive-git Description --- Create table should verify datatypes supported by the serde Diffs - itests/custom-serde/src/main/java/org/apache/hadoop/hive/serde2/CustomSerDeWithFaultyInspector.java PRE-CREATION ql/src/test/queries/clientnegative/create_table_faulty_oi_serde.q PRE-CREATION ql/src/test/results/clientnegative/create_table_faulty_oi_serde.q.out PRE-CREATION serde/src/java/org/apache/hadoop/hive/serde2/SerDeUtils.java 6e08dfd Diff: https://reviews.apache.org/r/47432/diff/ Testing --- Thanks, Hari Sankar Sivarama Subramaniyan
Re: Review Request 47196: HIVE-13350: Support Alter commands for Rely/NoRely novalidate for PK/FK constraints
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47196/ --- (Updated May 11, 2016, 3:04 a.m.) Review request for hive and Ashutosh Chauhan. Changes --- Added -ve test cases. Repository: hive-git Description --- Support Alter commands for Rely/NoRely novalidate for PK/FK constraints Diffs (updated) - metastore/if/hive_metastore.thrift 2eac836 metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 8d4e8f3 metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 3a63551 metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 68972fb metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java fea4fc5 metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 07d8119 metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseStore.java e97d4a9 metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java 7f4b77e metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java 25ccced ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 0204fcd ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 981b961 ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 7fcbd6a ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 0a892e8 ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 685ab6a ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java 23a7f6e ql/src/java/org/apache/hadoop/hive/ql/plan/AlterTableDesc.java 38d8d5a ql/src/java/org/apache/hadoop/hive/ql/plan/HiveOperation.java c6044b9 ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveOperationType.java 810da48 ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/Operation2Privilege.java 3f138fb ql/src/test/queries/clientnegative/alter_table_constraint_duplicate_pk.q PRE-CREATION ql/src/test/queries/clientnegative/alter_table_constraint_invalid_fk_col1.q PRE-CREATION ql/src/test/queries/clientnegative/alter_table_constraint_invalid_fk_col2.q PRE-CREATION ql/src/test/queries/clientnegative/alter_table_constraint_invalid_fk_tbl1.q PRE-CREATION ql/src/test/queries/clientnegative/alter_table_constraint_invalid_fk_tbl2.q PRE-CREATION ql/src/test/queries/clientnegative/alter_table_constraint_invalid_pk_col.q PRE-CREATION ql/src/test/queries/clientnegative/alter_table_constraint_invalid_pk_tbl.q PRE-CREATION ql/src/test/queries/clientpositive/create_with_constraints.q 7aabf74 ql/src/test/results/clientnegative/alter_table_constraint_duplicate_pk.q.out PRE-CREATION ql/src/test/results/clientnegative/alter_table_constraint_invalid_fk_col1.q.out PRE-CREATION ql/src/test/results/clientnegative/alter_table_constraint_invalid_fk_col2.q.out PRE-CREATION ql/src/test/results/clientnegative/alter_table_constraint_invalid_fk_tbl1.q.out PRE-CREATION ql/src/test/results/clientnegative/alter_table_constraint_invalid_fk_tbl2.q.out PRE-CREATION ql/src/test/results/clientnegative/alter_table_constraint_invalid_pk_col.q.out PRE-CREATION ql/src/test/results/clientnegative/alter_table_constraint_invalid_pk_tbl.q.out PRE-CREATION ql/src/test/results/clientpositive/create_with_constraints.q.out 34dac30 Diff: https://reviews.apache.org/r/47196/diff/ Testing --- Local testing done. Thanks, Hari Sankar Sivarama Subramaniyan
Review Request 47196: HIVE-13350: Support Alter commands for Rely/NoRely novalidate for PK/FK constraints
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47196/ --- Review request for hive and Ashutosh Chauhan. Repository: hive-git Description --- Support Alter commands for Rely/NoRely novalidate for PK/FK constraints Diffs - metastore/if/hive_metastore.thrift 2eac836 metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 8d4e8f3 metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 3a63551 metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 68972fb metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java fea4fc5 metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 07d8119 metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseStore.java e97d4a9 metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java 7f4b77e metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java 25ccced ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 0204fcd ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 981b961 ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 7fcbd6a ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 0a892e8 ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 685ab6a ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java 23a7f6e ql/src/java/org/apache/hadoop/hive/ql/plan/AlterTableDesc.java 38d8d5a ql/src/java/org/apache/hadoop/hive/ql/plan/HiveOperation.java c6044b9 ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveOperationType.java 810da48 ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/Operation2Privilege.java 3f138fb ql/src/test/queries/clientpositive/create_with_constraints.q 7aabf74 ql/src/test/results/clientpositive/create_with_constraints.q.out 34dac30 Diff: https://reviews.apache.org/r/47196/diff/ Testing --- Local testing done. Thanks, Hari Sankar Sivarama Subramaniyan
[jira] [Created] (HIVE-13715) Show create table should show the primary keys/foreign keys associated with the table
Hari Sankar Sivarama Subramaniyan created HIVE-13715: Summary: Show create table should show the primary keys/foreign keys associated with the table Key: HIVE-13715 URL: https://issues.apache.org/jira/browse/HIVE-13715 Project: Hive Issue Type: Bug Reporter: Hari Sankar Sivarama Subramaniyan Assignee: Hari Sankar Sivarama Subramaniyan Follow up for HIVE-13598 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Review Request 46671: HIVE-13598 : Describe extended table should show the primary keys/foreign keys associated with the table
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46671/ --- (Updated May 7, 2016, 9:34 p.m.) Review request for hive and Ashutosh Chauhan. Changes --- Integrated changes as per Ashutosh's comments Repository: hive-git Description --- Describe extended table should show the primary keys/foreign keys associated with the table Diffs (updated) - itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java 9863d6c metastore/scripts/upgrade/derby/034-HIVE-13076.derby.sql b062c56 metastore/scripts/upgrade/derby/hive-schema-2.1.0.derby.sql dc27afc metastore/scripts/upgrade/mssql/019-HIVE-13076.mssql.sql 00ddb73 metastore/scripts/upgrade/mssql/hive-schema-2.1.0.mssql.sql d9194ff metastore/scripts/upgrade/mysql/034-HIVE-13076.mysql.sql c9a5e1d metastore/scripts/upgrade/mysql/hive-schema-2.1.0.mysql.sql a6b783c metastore/scripts/upgrade/oracle/034-HIVE-13076.oracle.sql baf855c metastore/scripts/upgrade/oracle/hive-schema-2.1.0.oracle.sql d003a16 metastore/scripts/upgrade/postgres/033-HIVE-13076.postgres.sql ec1fb48 metastore/scripts/upgrade/postgres/hive-schema-2.1.0.postgres.sql 43e984c metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 744512f metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 5c49be9 metastore/src/model/org/apache/hadoop/hive/metastore/model/MConstraint.java 3806e28 metastore/src/model/package.jdo b40df39 ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java c4d3bfb ql/src/java/org/apache/hadoop/hive/ql/metadata/ForeignKeyInfo.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java f4a9772 ql/src/java/org/apache/hadoop/hive/ql/metadata/PrimaryKeyInfo.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/JsonMetaDataFormatter.java 75c2dd9 ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/MetaDataFormatUtils.java e76fb91 ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/MetaDataFormatter.java 55e1b3b ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/TextMetaDataFormatter.java b5dc0b4 ql/src/test/queries/clientpositive/create_with_constraints.q 0bb92e4 ql/src/test/results/clientpositive/create_with_constraints.q.out 7a7a50a Diff: https://reviews.apache.org/r/46671/diff/ Testing --- Thanks, Hari Sankar Sivarama Subramaniyan
Re: Review Request 46671: HIVE-13598 : Describe extended table should show the primary keys/foreign keys associated with the table
> On May 3, 2016, 5:37 p.m., Ashutosh Chauhan wrote: > > ql/src/test/results/clientpositive/create_with_constraints.q.out, line 137 > > <https://reviews.apache.org/r/46671/diff/4/?file=1369599#file1369599line137> > > > > I think words Qualified and child are redundant here. > > Hari Sankar Sivarama Subramaniyan wrote: > IMO Child is not redundant since this is a Parent-Child relationship. > Agree 'Qualified' can be omitted. > > Ashutosh Chauhan wrote: > I think child is also redundant because its a describe statement on a > table, so its obvious that info printed is for columns belonging to this > table. ok. > On May 3, 2016, 5:37 p.m., Ashutosh Chauhan wrote: > > ql/src/test/queries/clientpositive/create_with_constraints.q, line 17 > > <https://reviews.apache.org/r/46671/diff/4/?file=1369598#file1369598line17> > > > > describe formatted should also print constraints info. can you add a > > test case for that as well. > > Also for describe extended/formatted dbName.tblName; > > Hari Sankar Sivarama Subramaniyan wrote: > This required a patch of changes in the MetaDataFormatUtils class. Will > upload in the next patch. > > Ashutosh Chauhan wrote: > For dbName.tblName or for formatted? Either ways, its ok to do it in a > follow-up where we also add support for show create table. Ashutosh, for "show create table" I will followup with a separate jira. The rest, I am planning to support it here. - Hari Sankar --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46671/#review131529 --- On May 5, 2016, 1:16 a.m., Hari Sankar Sivarama Subramaniyan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46671/ > --- > > (Updated May 5, 2016, 1:16 a.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Repository: hive-git > > > Description > --- > > Describe extended table should show the primary keys/foreign keys associated > with the table > > > Diffs > - > > itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java a6e8efa > metastore/scripts/upgrade/derby/034-HIVE-13076.derby.sql b062c56 > metastore/scripts/upgrade/derby/hive-schema-2.1.0.derby.sql 1d00499 > metastore/scripts/upgrade/mssql/019-HIVE-13076.mssql.sql 00ddb73 > metastore/scripts/upgrade/mssql/hive-schema-2.1.0.mssql.sql 2d9cf76 > metastore/scripts/upgrade/mysql/034-HIVE-13076.mysql.sql c9a5e1d > metastore/scripts/upgrade/mysql/hive-schema-2.1.0.mysql.sql 466e950 > metastore/scripts/upgrade/oracle/034-HIVE-13076.oracle.sql baf855c > metastore/scripts/upgrade/oracle/hive-schema-2.1.0.oracle.sql f57e588 > metastore/scripts/upgrade/postgres/033-HIVE-13076.postgres.sql ec1fb48 > metastore/scripts/upgrade/postgres/hive-schema-2.1.0.postgres.sql e209489 > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java > 744512f > metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java > 5c49be9 > metastore/src/model/org/apache/hadoop/hive/metastore/model/MConstraint.java > 3806e28 > metastore/src/model/package.jdo b40df39 > ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java c4d3bfb > ql/src/java/org/apache/hadoop/hive/ql/metadata/ForeignKeyInfo.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java f4a9772 > ql/src/java/org/apache/hadoop/hive/ql/metadata/PrimaryKeyInfo.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/JsonMetaDataFormatter.java > 75c2dd9 > > ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/MetaDataFormatUtils.java > e76fb91 > > ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/MetaDataFormatter.java > 55e1b3b > > ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/TextMetaDataFormatter.java > b5dc0b4 > ql/src/test/queries/clientpositive/create_with_constraints.q 0bb92e4 > ql/src/test/results/clientpositive/create_with_constraints.q.out 7a7a50a > > Diff: https://reviews.apache.org/r/46671/diff/ > > > Testing > --- > > > Thanks, > > Hari Sankar Sivarama Subramaniyan > >
Re: Review Request 46671: HIVE-13598 : Describe extended table should show the primary keys/foreign keys associated with the table
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46671/ --- (Updated May 5, 2016, 1:16 a.m.) Review request for hive and Ashutosh Chauhan. Repository: hive-git Description --- Describe extended table should show the primary keys/foreign keys associated with the table Diffs (updated) - itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java a6e8efa metastore/scripts/upgrade/derby/034-HIVE-13076.derby.sql b062c56 metastore/scripts/upgrade/derby/hive-schema-2.1.0.derby.sql 1d00499 metastore/scripts/upgrade/mssql/019-HIVE-13076.mssql.sql 00ddb73 metastore/scripts/upgrade/mssql/hive-schema-2.1.0.mssql.sql 2d9cf76 metastore/scripts/upgrade/mysql/034-HIVE-13076.mysql.sql c9a5e1d metastore/scripts/upgrade/mysql/hive-schema-2.1.0.mysql.sql 466e950 metastore/scripts/upgrade/oracle/034-HIVE-13076.oracle.sql baf855c metastore/scripts/upgrade/oracle/hive-schema-2.1.0.oracle.sql f57e588 metastore/scripts/upgrade/postgres/033-HIVE-13076.postgres.sql ec1fb48 metastore/scripts/upgrade/postgres/hive-schema-2.1.0.postgres.sql e209489 metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 744512f metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 5c49be9 metastore/src/model/org/apache/hadoop/hive/metastore/model/MConstraint.java 3806e28 metastore/src/model/package.jdo b40df39 ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java c4d3bfb ql/src/java/org/apache/hadoop/hive/ql/metadata/ForeignKeyInfo.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java f4a9772 ql/src/java/org/apache/hadoop/hive/ql/metadata/PrimaryKeyInfo.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/JsonMetaDataFormatter.java 75c2dd9 ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/MetaDataFormatUtils.java e76fb91 ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/MetaDataFormatter.java 55e1b3b ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/TextMetaDataFormatter.java b5dc0b4 ql/src/test/queries/clientpositive/create_with_constraints.q 0bb92e4 ql/src/test/results/clientpositive/create_with_constraints.q.out 7a7a50a Diff: https://reviews.apache.org/r/46671/diff/ Testing --- Thanks, Hari Sankar Sivarama Subramaniyan
Re: Review Request 46671: HIVE-13598 : Describe extended table should show the primary keys/foreign keys associated with the table
> On May 3, 2016, 5:37 p.m., Ashutosh Chauhan wrote: > > ql/src/test/queries/clientpositive/create_with_constraints.q, line 19 > > <https://reviews.apache.org/r/46671/diff/4/?file=1369598#file1369598line19> > > > > Can you also add tests for describe formatted tblName colName; where > > colName is part of constraint. This should print out constraints relevant > > for that column. > > Hari Sankar Sivarama Subramaniyan wrote: > I dont see a reason why this should be allowed. This will make the column > details look complicated unnecessarily (for example, when there are multiple > foreign keys associated with the table column). Just printing out the partial > constraint information wont be of much use to the end user. Also, constraints > are not an entity of the column. Rather if the end-user wants to see the > constraints, he/she should do it on a table level. > > Ashutosh Chauhan wrote: > MySQL prints out what kind of constraint given column is a part of like > PK,FK,unique etc. Ref: https://dev.mysql.com/doc/refman/5.0/en/explain.html > Adding such an info for Hive will be useful. I dont think we can include any option other than PRIMARY KEY since UNIQUE, MUL, etc are out of scope for this jira. Also, FOREIGN KEY cannot be shown because although its technically a key, it is a parent-child constraint relationship with bidirectional mapping (for e.g we can have PK which is also a FK, which one do we show in this scenario ?, also even if we mark a KEY field as a FK, it can be associated with multiple table columns and in this case just showing FK is of not much use to the end user). Below is the snippet from the documentation you have mentioned: The Key field indicates whether the column is indexed: If Key is empty, the column either is not indexed or is indexed only as a secondary column in a multiple-column, nonunique index. If Key is PRI, the column is a PRIMARY KEY or is one of the columns in a multiple-column PRIMARY KEY. If Key is UNI, the column is the first column of a UNIQUE index. (A UNIQUE index permits multiple NULL values, but you can tell whether the column permits NULL by checking the Null field.) If Key is MUL, the column is the first column of a nonunique index in which multiple occurrences of a given value are permitted within the column. - Hari Sankar --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46671/#review131529 ------- On May 3, 2016, 3:46 a.m., Hari Sankar Sivarama Subramaniyan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46671/ > --- > > (Updated May 3, 2016, 3:46 a.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Repository: hive-git > > > Description > --- > > Describe extended table should show the primary keys/foreign keys associated > with the table > > > Diffs > - > > itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java a6e8efa > metastore/scripts/upgrade/derby/034-HIVE-13076.derby.sql b062c56 > metastore/scripts/upgrade/derby/hive-schema-2.1.0.derby.sql 1d00499 > metastore/scripts/upgrade/mssql/019-HIVE-13076.mssql.sql 00ddb73 > metastore/scripts/upgrade/mssql/hive-schema-2.1.0.mssql.sql 2d9cf76 > metastore/scripts/upgrade/mysql/034-HIVE-13076.mysql.sql c9a5e1d > metastore/scripts/upgrade/mysql/hive-schema-2.1.0.mysql.sql 466e950 > metastore/scripts/upgrade/oracle/034-HIVE-13076.oracle.sql baf855c > metastore/scripts/upgrade/oracle/hive-schema-2.1.0.oracle.sql f57e588 > metastore/scripts/upgrade/postgres/033-HIVE-13076.postgres.sql ec1fb48 > metastore/scripts/upgrade/postgres/hive-schema-2.1.0.postgres.sql e209489 > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java > 744512f > metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java > f651a13 > metastore/src/model/org/apache/hadoop/hive/metastore/model/MConstraint.java > 3806e28 > metastore/src/model/package.jdo b40df39 > ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 39a1efc > ql/src/java/org/apache/hadoop/hive/ql/metadata/ForeignKeyInfo.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 4d9c3d2 > ql/src/java/org/apache/hadoop/hive/ql/metadata/PrimaryKeyInfo.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/JsonMetaDataFormatter.java > 75c2dd9 > > ql/src/java/org/apache/hadoop/hive/ql/me
Re: Review Request 46671: HIVE-13598 : Describe extended table should show the primary keys/foreign keys associated with the table
> On May 3, 2016, 5:37 p.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/JsonMetaDataFormatter.java, > > line 119 > > <https://reviews.apache.org/r/46671/diff/4/?file=1369595#file1369595line119> > > > > These words (primaryKeyInfo etc) should be identical across all > > formatters. The contents are the same. primaryKeyInfo is the key of the json entry. > On May 3, 2016, 5:37 p.m., Ashutosh Chauhan wrote: > > ql/src/test/queries/clientpositive/create_with_constraints.q, line 17 > > <https://reviews.apache.org/r/46671/diff/4/?file=1369598#file1369598line17> > > > > describe formatted should also print constraints info. can you add a > > test case for that as well. > > Also for describe extended/formatted dbName.tblName; This required a patch of changes in the MetaDataFormatUtils class. Will upload in the next patch. > On May 3, 2016, 5:37 p.m., Ashutosh Chauhan wrote: > > ql/src/test/results/clientpositive/create_with_constraints.q.out, line 137 > > <https://reviews.apache.org/r/46671/diff/4/?file=1369599#file1369599line137> > > > > I think words Qualified and child are redundant here. IMO Child is not redundant since this is a Parent-Child relationship. Agree 'Qualified' can be omitted. > On May 3, 2016, 5:37 p.m., Ashutosh Chauhan wrote: > > ql/src/test/queries/clientpositive/create_with_constraints.q, line 19 > > <https://reviews.apache.org/r/46671/diff/4/?file=1369598#file1369598line19> > > > > Can you also add tests for describe formatted tblName colName; where > > colName is part of constraint. This should print out constraints relevant > > for that column. I dont see a reason why this should be allowed. This will make the column details look complicated unnecessarily (for example, when there are multiple foreign keys associated with the table column). Just printing out the partial constraint information wont be of much use to the end user. Also, constraints are not an entity of the column. Rather if the end-user wants to see the constraints, he/she should do it on a table level. - Hari Sankar --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46671/#review131529 --- On May 3, 2016, 3:46 a.m., Hari Sankar Sivarama Subramaniyan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46671/ > --- > > (Updated May 3, 2016, 3:46 a.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Repository: hive-git > > > Description > --- > > Describe extended table should show the primary keys/foreign keys associated > with the table > > > Diffs > - > > itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java a6e8efa > metastore/scripts/upgrade/derby/034-HIVE-13076.derby.sql b062c56 > metastore/scripts/upgrade/derby/hive-schema-2.1.0.derby.sql 1d00499 > metastore/scripts/upgrade/mssql/019-HIVE-13076.mssql.sql 00ddb73 > metastore/scripts/upgrade/mssql/hive-schema-2.1.0.mssql.sql 2d9cf76 > metastore/scripts/upgrade/mysql/034-HIVE-13076.mysql.sql c9a5e1d > metastore/scripts/upgrade/mysql/hive-schema-2.1.0.mysql.sql 466e950 > metastore/scripts/upgrade/oracle/034-HIVE-13076.oracle.sql baf855c > metastore/scripts/upgrade/oracle/hive-schema-2.1.0.oracle.sql f57e588 > metastore/scripts/upgrade/postgres/033-HIVE-13076.postgres.sql ec1fb48 > metastore/scripts/upgrade/postgres/hive-schema-2.1.0.postgres.sql e209489 > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java > 744512f > metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java > f651a13 > metastore/src/model/org/apache/hadoop/hive/metastore/model/MConstraint.java > 3806e28 > metastore/src/model/package.jdo b40df39 > ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 39a1efc > ql/src/java/org/apache/hadoop/hive/ql/metadata/ForeignKeyInfo.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 4d9c3d2 > ql/src/java/org/apache/hadoop/hive/ql/metadata/PrimaryKeyInfo.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/JsonMetaDataFormatter.java > 75c2dd9 > > ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/MetaDataFormatter.java > 55e1b3b > > ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/TextMetaDataFormatter.java > b5dc0b4 > ql/src/test/queries/clientpositive/create_with_constraints.q eef0c64 > ql/src/test/results/clientpositive/create_with_constraints.q.out 5cf8d83 > > Diff: https://reviews.apache.org/r/46671/diff/ > > > Testing > --- > > > Thanks, > > Hari Sankar Sivarama Subramaniyan > >
Re: Review Request 46913: HIVE-13351 : Support drop Primary Key/Foreign Key constraints
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46913/ --- (Updated May 3, 2016, 7:14 p.m.) Review request for hive and Ashutosh Chauhan. Changes --- Incorporated Ashutosh's comments Repository: hive-git Description --- Support drop Primary Key/Foreign Key constraints Diffs (updated) - metastore/if/hive_metastore.thrift acebf7a metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 4ada9c1 metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 7d37d07 metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java c900a2d metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java f651a13 metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 100c396 metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseStore.java d4e5da4 metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java 86e7bea metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java 5b32f00 ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 9887d77 ql/src/java/org/apache/hadoop/hive/ql/hooks/WriteEntity.java 515f8b2 ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 26c458c ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 04e2a41 ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 6531b03 ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java fb8a33c ql/src/java/org/apache/hadoop/hive/ql/plan/AlterTableDesc.java 4ba51ec ql/src/java/org/apache/hadoop/hive/ql/plan/HiveOperation.java 188cd6f ql/src/test/queries/clientnegative/drop_invalid_constraint1.q PRE-CREATION ql/src/test/queries/clientnegative/drop_invalid_constraint2.q PRE-CREATION ql/src/test/queries/clientnegative/drop_invalid_constraint3.q PRE-CREATION ql/src/test/queries/clientnegative/drop_invalid_constraint4.q PRE-CREATION ql/src/test/queries/clientpositive/create_with_constraints.q eef0c64 ql/src/test/results/clientnegative/drop_invalid_constraint1.q.out PRE-CREATION ql/src/test/results/clientnegative/drop_invalid_constraint2.q.out PRE-CREATION ql/src/test/results/clientnegative/drop_invalid_constraint3.q.out PRE-CREATION ql/src/test/results/clientnegative/drop_invalid_constraint4.q.out PRE-CREATION ql/src/test/results/clientpositive/create_with_constraints.q.out 5cf8d83 service/src/gen/thrift/gen-py/__init__.py e69de29 Diff: https://reviews.apache.org/r/46913/diff/ Testing --- Thanks, Hari Sankar Sivarama Subramaniyan
Re: Review Request 46671: HIVE-13598 : Describe extended table should show the primary keys/foreign keys associated with the table
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46671/ --- (Updated May 3, 2016, 3:46 a.m.) Review request for hive and Ashutosh Chauhan. Repository: hive-git Description --- Describe extended table should show the primary keys/foreign keys associated with the table Diffs (updated) - itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java a6e8efa metastore/scripts/upgrade/derby/034-HIVE-13076.derby.sql b062c56 metastore/scripts/upgrade/derby/hive-schema-2.1.0.derby.sql 1d00499 metastore/scripts/upgrade/mssql/019-HIVE-13076.mssql.sql 00ddb73 metastore/scripts/upgrade/mssql/hive-schema-2.1.0.mssql.sql 2d9cf76 metastore/scripts/upgrade/mysql/034-HIVE-13076.mysql.sql c9a5e1d metastore/scripts/upgrade/mysql/hive-schema-2.1.0.mysql.sql 466e950 metastore/scripts/upgrade/oracle/034-HIVE-13076.oracle.sql baf855c metastore/scripts/upgrade/oracle/hive-schema-2.1.0.oracle.sql f57e588 metastore/scripts/upgrade/postgres/033-HIVE-13076.postgres.sql ec1fb48 metastore/scripts/upgrade/postgres/hive-schema-2.1.0.postgres.sql e209489 metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 744512f metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java f651a13 metastore/src/model/org/apache/hadoop/hive/metastore/model/MConstraint.java 3806e28 metastore/src/model/package.jdo b40df39 ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 39a1efc ql/src/java/org/apache/hadoop/hive/ql/metadata/ForeignKeyInfo.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 4d9c3d2 ql/src/java/org/apache/hadoop/hive/ql/metadata/PrimaryKeyInfo.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/JsonMetaDataFormatter.java 75c2dd9 ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/MetaDataFormatter.java 55e1b3b ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/TextMetaDataFormatter.java b5dc0b4 ql/src/test/queries/clientpositive/create_with_constraints.q eef0c64 ql/src/test/results/clientpositive/create_with_constraints.q.out 5cf8d83 Diff: https://reviews.apache.org/r/46671/diff/ Testing --- Thanks, Hari Sankar Sivarama Subramaniyan
Re: Review Request 46913: HIVE-13351 : Support drop Primary Key/Foreign Key constraints
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46913/#review131402 --- metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java (line 1822) <https://reviews.apache.org/r/46913/#comment195360> Please discard all the diffs in MetaStoreDirectSql.java. The change was added by mistake and is not part of this jira. - Hari Sankar Sivarama Subramaniyan On May 2, 2016, 10:23 p.m., Hari Sankar Sivarama Subramaniyan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46913/ > --- > > (Updated May 2, 2016, 10:23 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Repository: hive-git > > > Description > --- > > Support drop Primary Key/Foreign Key constraints > > > Diffs > - > > metastore/if/hive_metastore.thrift acebf7a > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 4ada9c1 > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java > 7d37d07 > metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java > c900a2d > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java > 744512f > metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java > f651a13 > metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 100c396 > metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseStore.java > d4e5da4 > > metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java > 86e7bea > > metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java > 5b32f00 > ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 39a1efc > ql/src/java/org/apache/hadoop/hive/ql/hooks/WriteEntity.java 515f8b2 > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 4d9c3d2 > ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java > 04e2a41 > ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 6531b03 > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java > fb8a33c > ql/src/java/org/apache/hadoop/hive/ql/plan/AlterTableDesc.java 4ba51ec > ql/src/java/org/apache/hadoop/hive/ql/plan/HiveOperation.java 188cd6f > ql/src/test/queries/clientnegative/drop_invalid_constraint1.q PRE-CREATION > ql/src/test/queries/clientnegative/drop_invalid_constraint2.q PRE-CREATION > ql/src/test/queries/clientnegative/drop_invalid_constraint3.q PRE-CREATION > ql/src/test/queries/clientnegative/drop_invalid_constraint4.q PRE-CREATION > ql/src/test/queries/clientpositive/create_with_constraints.q eef0c64 > ql/src/test/results/clientnegative/drop_invalid_constraint1.q.out > PRE-CREATION > ql/src/test/results/clientnegative/drop_invalid_constraint2.q.out > PRE-CREATION > ql/src/test/results/clientnegative/drop_invalid_constraint3.q.out > PRE-CREATION > ql/src/test/results/clientnegative/drop_invalid_constraint4.q.out > PRE-CREATION > ql/src/test/results/clientpositive/create_with_constraints.q.out 5cf8d83 > service/src/gen/thrift/gen-py/__init__.py e69de29 > > Diff: https://reviews.apache.org/r/46913/diff/ > > > Testing > --- > > > Thanks, > > Hari Sankar Sivarama Subramaniyan > >
Review Request 46913: HIVE-13351 : Support drop Primary Key/Foreign Key constraints
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46913/ --- Review request for hive and Ashutosh Chauhan. Repository: hive-git Description --- Support drop Primary Key/Foreign Key constraints Diffs - metastore/if/hive_metastore.thrift acebf7a metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 4ada9c1 metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 7d37d07 metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java c900a2d metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 744512f metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java f651a13 metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 100c396 metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseStore.java d4e5da4 metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java 86e7bea metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java 5b32f00 ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 39a1efc ql/src/java/org/apache/hadoop/hive/ql/hooks/WriteEntity.java 515f8b2 ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 4d9c3d2 ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 04e2a41 ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 6531b03 ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java fb8a33c ql/src/java/org/apache/hadoop/hive/ql/plan/AlterTableDesc.java 4ba51ec ql/src/java/org/apache/hadoop/hive/ql/plan/HiveOperation.java 188cd6f ql/src/test/queries/clientnegative/drop_invalid_constraint1.q PRE-CREATION ql/src/test/queries/clientnegative/drop_invalid_constraint2.q PRE-CREATION ql/src/test/queries/clientnegative/drop_invalid_constraint3.q PRE-CREATION ql/src/test/queries/clientnegative/drop_invalid_constraint4.q PRE-CREATION ql/src/test/queries/clientpositive/create_with_constraints.q eef0c64 ql/src/test/results/clientnegative/drop_invalid_constraint1.q.out PRE-CREATION ql/src/test/results/clientnegative/drop_invalid_constraint2.q.out PRE-CREATION ql/src/test/results/clientnegative/drop_invalid_constraint3.q.out PRE-CREATION ql/src/test/results/clientnegative/drop_invalid_constraint4.q.out PRE-CREATION ql/src/test/results/clientpositive/create_with_constraints.q.out 5cf8d83 service/src/gen/thrift/gen-py/__init__.py e69de29 Diff: https://reviews.apache.org/r/46913/diff/ Testing --- Thanks, Hari Sankar Sivarama Subramaniyan
Re: Review Request 46671: HIVE-13598 : Describe extended table should show the primary keys/foreign keys associated with the table
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46671/ --- (Updated April 28, 2016, 1:25 a.m.) Review request for hive and Ashutosh Chauhan. Repository: hive-git Description --- Describe extended table should show the primary keys/foreign keys associated with the table Diffs (updated) - itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java a6e8efa metastore/scripts/upgrade/derby/034-HIVE-13076.derby.sql b062c56 metastore/scripts/upgrade/derby/hive-schema-2.1.0.derby.sql 1d00499 metastore/scripts/upgrade/mssql/019-HIVE-13076.mssql.sql 00ddb73 metastore/scripts/upgrade/mssql/hive-schema-2.1.0.mssql.sql 2d9cf76 metastore/scripts/upgrade/mysql/034-HIVE-13076.mysql.sql c9a5e1d metastore/scripts/upgrade/mysql/hive-schema-2.1.0.mysql.sql 466e950 metastore/scripts/upgrade/oracle/034-HIVE-13076.oracle.sql baf855c metastore/scripts/upgrade/oracle/hive-schema-2.1.0.oracle.sql f57e588 metastore/scripts/upgrade/postgres/033-HIVE-13076.postgres.sql ec1fb48 metastore/scripts/upgrade/postgres/hive-schema-2.1.0.postgres.sql e209489 metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 744512f metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java f651a13 metastore/src/model/org/apache/hadoop/hive/metastore/model/MConstraint.java 3806e28 metastore/src/model/package.jdo b40df39 ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java cbeb361 ql/src/java/org/apache/hadoop/hive/ql/metadata/ForeignKeyInfo.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java ab165f1 ql/src/java/org/apache/hadoop/hive/ql/metadata/PrimaryKeyInfo.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/JsonMetaDataFormatter.java 75c2dd9 ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/MetaDataFormatter.java 55e1b3b ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/TextMetaDataFormatter.java b5dc0b4 ql/src/test/queries/clientpositive/create_with_constraints.q eef0c64 ql/src/test/results/clientpositive/create_with_constraints.q.out 5cf8d83 Diff: https://reviews.apache.org/r/46671/diff/ Testing --- Thanks, Hari Sankar Sivarama Subramaniyan
Re: Review Request 46671: HIVE-13598 : Describe extended table should show the primary keys/foreign keys associated with the table
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46671/ --- (Updated April 26, 2016, 3:06 a.m.) Review request for hive and Ashutosh Chauhan. Repository: hive-git Description --- Describe extended table should show the primary keys/foreign keys associated with the table Diffs (updated) - itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java a6e8efa metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 744512f ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java cbeb361 ql/src/java/org/apache/hadoop/hive/ql/metadata/ForeignKeyInfo.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java ab165f1 ql/src/java/org/apache/hadoop/hive/ql/metadata/PrimaryKeyInfo.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/JsonMetaDataFormatter.java 75c2dd9 ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/MetaDataFormatter.java 55e1b3b ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/TextMetaDataFormatter.java b5dc0b4 ql/src/test/queries/clientpositive/create_with_constraints.q eef0c64 ql/src/test/results/clientpositive/create_with_constraints.q.out 5cf8d83 Diff: https://reviews.apache.org/r/46671/diff/ Testing --- Thanks, Hari Sankar Sivarama Subramaniyan
Review Request 46671: HIVE-13598 : Describe extended table should show the primary keys/foreign keys associated with the table
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46671/ --- Review request for hive and Ashutosh Chauhan. Repository: hive-git Description --- Describe extended table should show the primary keys/foreign keys associated with the table Diffs - itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java a6e8efa metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 744512f ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java cbeb361 ql/src/java/org/apache/hadoop/hive/ql/metadata/ForeignKeyInfo.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java ab165f1 ql/src/java/org/apache/hadoop/hive/ql/metadata/PrimaryKeyInfo.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/JsonMetaDataFormatter.java 75c2dd9 ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/MetaDataFormatter.java 55e1b3b ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/TextMetaDataFormatter.java b5dc0b4 ql/src/test/queries/clientpositive/create_with_constraints.q eef0c64 ql/src/test/results/clientpositive/create_with_constraints.q.out 5cf8d83 Diff: https://reviews.apache.org/r/46671/diff/ Testing --- Thanks, Hari Sankar Sivarama Subramaniyan
[jira] [Created] (HIVE-13608) We should provide better error message while constraints with duplicate names are created
Hari Sankar Sivarama Subramaniyan created HIVE-13608:
Summary: We should provide better error message while constraints
with duplicate names are created
Key: HIVE-13608
URL: https://issues.apache.org/jira/browse/HIVE-13608
Project: Hive
Issue Type: Bug
Reporter: Hari Sankar Sivarama Subramaniyan
Assignee: Hari Sankar Sivarama Subramaniyan
{code}
PREHOOK: query: create table t1(x int, constraint pk1 primary key (x) disable
novalidate)
PREHOOK: type: CREATETABLE
PREHOOK: Output: database:default
PREHOOK: Output: default@t1
POSTHOOK: query: create table t1(x int, constraint pk1 primary key (x) disable
novalidate)
POSTHOOK: type: CREATETABLE
POSTHOOK: Output: database:default
POSTHOOK: Output: default@t1
PREHOOK: query: create table t2(x int, constraint pk1 primary key (x) disable
novalidate)
PREHOOK: type: CREATETABLE
PREHOOK: Output: database:default
PREHOOK: Output: default@t2
FAILED: Execution Error, return code 1 from
org.apache.hadoop.hive.ql.exec.DDLTask. MetaException(message:For direct
MetaStore DB connections, we don't support retries at the client level.)
{code}
In the above case, it seems like useful error message is lost. It looks like a
generic problem with metastore server/client exception handling and message
propagation. Seems like exception parsing logic of
RetryingMetaStoreClient::invoke() needs to be updated.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (HIVE-13601) Deadline is not registered at some places in HiveMetastore before the ObjectStore/MetaStoreDirectSQL APIs are invoked
Hari Sankar Sivarama Subramaniyan created HIVE-13601:
Summary: Deadline is not registered at some places in
HiveMetastore before the ObjectStore/MetaStoreDirectSQL APIs are invoked
Key: HIVE-13601
URL: https://issues.apache.org/jira/browse/HIVE-13601
Project: Hive
Issue Type: Bug
Reporter: Hari Sankar Sivarama Subramaniyan
Assignee: Hari Sankar Sivarama Subramaniyan
HIVE-13542 exposed this issue as shown below when making Metastore API calls
via CBO code path.
{code}
16-04-21T11:45:55,201 DEBUG [f2995fd1-e4fc-4783-86cb-9264f715e540 main[]]:
metastore.MetaStoreDirectSql (MetaStoreDirectSql.java:timingTrace(864)) -
Direct SQL query in 14.825303ms + 0.086336ms, the query is [select
"COLUMN_NAME", "COLUMN_TYPE", "LONG_LOW_VALUE", "LONG_HIGH_VALUE",
"DOUBLE_LOW_VALU\
E", "DOUBLE_HIGH_VALUE", "BIG_DECIMAL_LOW_VALUE", "BIG_DECIMAL_HIGH_VALUE",
"NUM_NULLS", "NUM_DISTINCTS", "AVG_COL_LEN", "MAX_COL_LEN", "NUM_TRUES",
"NUM_FALSES", "LAST_ANALYZED" from "TAB_COL_STATS" where "DB_NAME" = ? and
"TABLE_NAME" = ? and "COLUMN_NAME" in (...)]
2016-04-21T11:45:55,242 WARN [f2995fd1-e4fc-4783-86cb-9264f715e540 main[]]:
metastore.ObjectStore (ObjectStore.java:handleDirectSqlError(2602)) - Direct
SQL failed, falling back to ORM
org.apache.hadoop.hive.metastore.api.MetaException: The threadlocal Deadline is
null, please register it first.
at
org.apache.hadoop.hive.metastore.Deadline.newMetaException(Deadline.java:178)
~[hive-metastore-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
at
org.apache.hadoop.hive.metastore.Deadline.checkTimeout(Deadline.java:149)
~[hive-metastore-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
at
org.apache.hadoop.hive.metastore.MetaStoreDirectSql.makeColumnStats(MetaStoreDirectSql.java:1717)
~[hive-metastore-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
at
org.apache.hadoop.hive.metastore.MetaStoreDirectSql.getTableStats(MetaStoreDirectSql.java:1201)
~[hive-metastore-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
at
org.apache.hadoop.hive.metastore.ObjectStore$7.getSqlResult(ObjectStore.java:6849)
~[hive-metastore-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
at
org.apache.hadoop.hive.metastore.ObjectStore$7.getSqlResult(ObjectStore.java:6846)
~[hive-metastore-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
at
org.apache.hadoop.hive.metastore.ObjectStore$GetHelper.run(ObjectStore.java:2567)
[hive-metastore-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
at
org.apache.hadoop.hive.metastore.ObjectStore.getTableColumnStatisticsInternal(ObjectStore.java:6845)
[hive-metastore-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
at
org.apache.hadoop.hive.metastore.ObjectStore.getTableColumnStatistics(ObjectStore.java:6839)
[hive-metastore-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
at
org.apache.hadoop.hive.metastore.HiveMetaStore$HMSHandler.get_table_statistics_req(HiveMetaStore.java:4361)
[hive-metastore-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
at
org.apache.hadoop.hive.metastore.HiveMetaStoreClient.getTableColumnStatistics(HiveMetaStoreClient.java:1613)
[hive-metastore-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
at
org.apache.hadoop.hive.ql.metadata.SessionHiveMetaStoreClient.getTableColumnStatistics(SessionHiveMetaStoreClient.java:347)
[hive-exec-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
at
org.apache.hadoop.hive.ql.metadata.Hive.getTableColumnStatistics(Hive.java:3317)
[hive-exec-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
at
org.apache.hadoop.hive.ql.stats.StatsUtils.getTableColumnStats(StatsUtils.java:758)
[hive-exec-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
at
org.apache.hadoop.hive.ql.optimizer.calcite.RelOptHiveTable.updateColStats(RelOptHiveTable.java:302)
[hive-exec-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
at
org.apache.hadoop.hive.ql.optimizer.calcite.RelOptHiveTable.getColStat(RelOptHiveTable.java:417)
[hive-exec-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
at
org.apache.hadoop.hive.ql.optimizer.calcite.RelOptHiveTable.getColStat(RelOptHiveTable.java:410)
[hive-exec-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
at
org.apache.hadoop.hive.ql.optimizer.calcite.reloperators.HiveTableScan.getColStat(HiveTableScan.java:158)
[hive-exec-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
at
org.apache.hadoop.hive.ql.optimizer.calcite.stats.HiveRelMdDistinctRowCount.getDistinctRowCount(HiveRelMdDistinctRowCount.java:77)
[hive-exec-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
at
org.apache.hadoop.hive.ql.optimizer.calcite.stats.HiveRelMdDistinctRowCount.getDistinctRowCount(HiveRelMdDistinctRowCount.java:64)
[hive-exec-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
~[?:1.7.0_79]
at
[jira] [Created] (HIVE-13598) Describe extended table should show the primary keys/foreign keys associated with the table
Hari Sankar Sivarama Subramaniyan created HIVE-13598: Summary: Describe extended table should show the primary keys/foreign keys associated with the table Key: HIVE-13598 URL: https://issues.apache.org/jira/browse/HIVE-13598 Project: Hive Issue Type: Bug Reporter: Hari Sankar Sivarama Subramaniyan Assignee: Hari Sankar Sivarama Subramaniyan After HIVE-13290 is committed, we need to show the constraints as part of table description when extended label is used. Currently, the constraints would not be shown as part of table description since Constraint is a separate entity. The purpose of the jira is to modify Hive.describeTable() to enable the user to view the constraints associated with the table when the user does a "describe extended table"; -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Review Request 45274: HIVE-13290 : Support PK/FK constraint as part of create table command
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45274/ --- (Updated April 23, 2016, 8:20 p.m.) Review request for hive and Ashutosh Chauhan. Repository: hive-git Description --- Support primary keys/foreign keys constraint as part of create table command in Hive Diffs (updated) - metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java ae6f084 ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java f091f67 ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java b26f09d ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 4c9acce ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 19342a8 ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g dd997f0 ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 50c53db ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g a192fa7 ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java 549d24f ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 005b53f ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableDesc.java 03b4d8b ql/src/test/queries/clientnegative/create_with_constraints_duplicate_name.q PRE-CREATION ql/src/test/queries/clientnegative/create_with_constraints_enable.q PRE-CREATION ql/src/test/queries/clientnegative/create_with_constraints_validate.q PRE-CREATION ql/src/test/queries/clientpositive/create_with_constraints.q PRE-CREATION ql/src/test/results/clientnegative/create_with_constraints_duplicate_name.q.out PRE-CREATION ql/src/test/results/clientnegative/create_with_constraints_enable.q.out PRE-CREATION ql/src/test/results/clientnegative/create_with_constraints_validate.q.out PRE-CREATION ql/src/test/results/clientpositive/create_with_constraints.q.out PRE-CREATION Diff: https://reviews.apache.org/r/45274/diff/ Testing --- Local testing done Thanks, Hari Sankar Sivarama Subramaniyan
Re: Review Request 45274: HIVE-13290 : Support PK/FK constraint as part of create table command
> On April 23, 2016, 5:45 p.m., Ashutosh Chauhan wrote: > > ql/src/test/queries/clientpositive/create_with_constraints.q, line 2 > > <https://reviews.apache.org/r/45274/diff/4/?file=1358471#file1358471line2> > > > > Please add describe statement for all tables. They should list all > > constraints of table. This is not trivial with the current implementation. The constraints are a separate entity altogether and not part of the Table. I need to make some changes to DDLTask.describeTable() to support this(fetch primarykeys, foreignkeys for the table and update the metadataformatter implementation to show this information when in extended mode). Would be good to get the current changes in and do this in a follow-up jira? - Hari Sankar --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45274/#review130263 --- On April 23, 2016, 7:17 a.m., Hari Sankar Sivarama Subramaniyan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45274/ > --- > > (Updated April 23, 2016, 7:17 a.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Repository: hive-git > > > Description > --- > > Support primary keys/foreign keys constraint as part of create table command > in Hive > > > Diffs > - > > metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java > ae6f084 > ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java f091f67 > ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java b26f09d > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 4c9acce > ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java > 19342a8 > ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g dd997f0 > ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 50c53db > ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g a192fa7 > ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java > 549d24f > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 005b53f > ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableDesc.java 03b4d8b > ql/src/test/queries/clientnegative/create_with_constraints_enable.q > PRE-CREATION > ql/src/test/queries/clientnegative/create_with_constraints_validate.q > PRE-CREATION > ql/src/test/queries/clientpositive/create_with_constraints.q PRE-CREATION > ql/src/test/results/clientnegative/create_with_constraints_enable.q.out > PRE-CREATION > ql/src/test/results/clientnegative/create_with_constraints_validate.q.out > PRE-CREATION > ql/src/test/results/clientpositive/create_with_constraints.q.out > PRE-CREATION > > Diff: https://reviews.apache.org/r/45274/diff/ > > > Testing > --- > > Local testing done > > > Thanks, > > Hari Sankar Sivarama Subramaniyan > >
Re: Review Request 45274: HIVE-13290 : Support PK/FK constraint as part of create table command
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45274/ --- (Updated April 23, 2016, 7:17 a.m.) Review request for hive and Ashutosh Chauhan. Changes --- Incorporated Pengcheng's comments. Repository: hive-git Description --- Support primary keys/foreign keys constraint as part of create table command in Hive Diffs (updated) - metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java ae6f084 ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java f091f67 ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java b26f09d ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 4c9acce ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 19342a8 ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g dd997f0 ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 50c53db ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g a192fa7 ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java 549d24f ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 005b53f ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableDesc.java 03b4d8b ql/src/test/queries/clientnegative/create_with_constraints_enable.q PRE-CREATION ql/src/test/queries/clientnegative/create_with_constraints_validate.q PRE-CREATION ql/src/test/queries/clientpositive/create_with_constraints.q PRE-CREATION ql/src/test/results/clientnegative/create_with_constraints_enable.q.out PRE-CREATION ql/src/test/results/clientnegative/create_with_constraints_validate.q.out PRE-CREATION ql/src/test/results/clientpositive/create_with_constraints.q.out PRE-CREATION Diff: https://reviews.apache.org/r/45274/diff/ Testing --- Local testing done Thanks, Hari Sankar Sivarama Subramaniyan
Re: Review Request 45274: HIVE-13290 : Support PK/FK constraint as part of create table command
> On April 22, 2016, 6:06 p.m., pengcheng xiong wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g, line 1997 > > <https://reviews.apache.org/r/45274/diff/3/?file=1352133#file1352133line1997> > > > > IMHO, this is a little bit verbose. Now we have 8 branches for 2^3 > > combinations... For example, The options for relySpec are only "rely" and > > "noreply", we can make them keywords but not reserved ones. Then we have > > "^(TOK_RELY) replyOption ^(TOK_DISABLE) disableOption ^(TOK_NOVALIDATE)" > > noValidateOption". The parser can try to match the grammer automatically > > and we do not need TOK_INVALID_KEY_SPEC any more. Pengcheng, that makes a lot of sense and avoids a lot of complexity in the Parser's generated state machine. I am in the process of uploading the patch but can you look at the grammar for HiveParser in Revision 2. The changes are the same as that except that we make all the KEYWORDs non-reserved - Hari Sankar --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45274/#review130137 ------- On April 20, 2016, 12:20 a.m., Hari Sankar Sivarama Subramaniyan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45274/ > --- > > (Updated April 20, 2016, 12:20 a.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Repository: hive-git > > > Description > --- > > Support primary keys/foreign keys constraint as part of create table command > in Hive > > > Diffs > - > > ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java f091f67 > ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java b26f09d > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 4c9acce > ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java > 19342a8 > ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 50c53db > ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java > 549d24f > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 96df189 > ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableDesc.java 03b4d8b > > Diff: https://reviews.apache.org/r/45274/diff/ > > > Testing > --- > > Local testing done > > > Thanks, > > Hari Sankar Sivarama Subramaniyan > >
Re: Review Request 45274: HIVE-13290 : Support PK/FK constraint as part of create table command
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45274/ --- (Updated April 20, 2016, 12:20 a.m.) Review request for hive and Ashutosh Chauhan. Repository: hive-git Description --- Support primary keys/foreign keys constraint as part of create table command in Hive Diffs (updated) - ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java f091f67 ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java b26f09d ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 4c9acce ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 19342a8 ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 50c53db ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java 549d24f ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 96df189 ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableDesc.java 03b4d8b Diff: https://reviews.apache.org/r/45274/diff/ Testing --- Local testing done Thanks, Hari Sankar Sivarama Subramaniyan
Re: Review Request 44031: HIVE-13130: HS2 changes: API calls for retrieving primary keys and foreign keys information
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44031/ --- (Updated April 19, 2016, 8:50 p.m.) Review request for hive and Ashutosh Chauhan. Repository: hive-git Description --- HS2 changes: API calls for retrieving primary keys and foreign keys information. Changes without the generated thrift files. Diffs (updated) - jdbc/src/java/org/apache/hive/jdbc/HiveDatabaseMetaData.java 7e54d1f service-rpc/if/TCLIService.thrift aa28b6e service/src/java/org/apache/hive/service/cli/CLIService.java ab30ae2 service/src/java/org/apache/hive/service/cli/EmbeddedCLIServiceClient.java 9cad5be service/src/java/org/apache/hive/service/cli/ICLIService.java 0a54bdd service/src/java/org/apache/hive/service/cli/operation/GetCrossReferenceOperation.java PRE-CREATION service/src/java/org/apache/hive/service/cli/operation/GetPrimaryKeysOperation.java PRE-CREATION service/src/java/org/apache/hive/service/cli/operation/OperationManager.java 56a9c18 service/src/java/org/apache/hive/service/cli/session/HiveSession.java 4f4e92d service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 0f36cd6 service/src/java/org/apache/hive/service/cli/thrift/RetryingThriftCLIServiceClient.java 14191e5 service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java e789a38 service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceClient.java ccce6dc Diff: https://reviews.apache.org/r/44031/diff/ Testing --- Thanks, Hari Sankar Sivarama Subramaniyan
[jira] [Created] (HIVE-13542) Missing stats for tables in TPCDS performance regression suite
Hari Sankar Sivarama Subramaniyan created HIVE-13542: Summary: Missing stats for tables in TPCDS performance regression suite Key: HIVE-13542 URL: https://issues.apache.org/jira/browse/HIVE-13542 Project: Hive Issue Type: Bug Reporter: Hari Sankar Sivarama Subramaniyan Assignee: Hari Sankar Sivarama Subramaniyan These are the tables whose stats are missing in data/files/tpcds-perf/metastore_export/csv/TAB_COL_STATS.txt: * catalog_returns * catalog_sales * inventory * store_returns * store_sales * web_returns * web_sales Thanks to [~jcamachorodriguez] for discovering this issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Review Request 45274: HIVE-13290 : Support PK/FK constraint as part of create table command
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45274/ --- (Updated April 15, 2016, 7:54 a.m.) Review request for hive and Ashutosh Chauhan. Repository: hive-git Description --- Support primary keys/foreign keys constraint as part of create table command in Hive Diffs (updated) - ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java f091f67 ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java b26f09d ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 4c9acce ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 19342a8 ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g dd997f0 ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 50c53db ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java 549d24f ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java d3e7040 ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableDesc.java 03b4d8b Diff: https://reviews.apache.org/r/45274/diff/ Testing --- Local testing done Thanks, Hari Sankar Sivarama Subramaniyan
Re: Review Request 45406: HIVE-13349: Metastore Changes : API calls for retrieving primary keys and foreign keys information
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45406/ --- (Updated April 14, 2016, 10:44 p.m.) Review request for hive and Ashutosh Chauhan. Changes --- 1. Added enable/validate/rely bits to the metastore. 2. Validate fk name, pk names check for duplicates. 3. Generate constraint names if the user does not provide one. Repository: hive-git Description --- Metastore Changes : API calls for retrieving primary keys and foreign keys information Diffs (updated) - metastore/if/hive_metastore.thrift 6a55962 metastore/scripts/upgrade/derby/034-HIVE-13076.derby.sql PRE-CREATION metastore/scripts/upgrade/derby/hive-schema-2.1.0.derby.sql 42f4eb6 metastore/scripts/upgrade/derby/upgrade-2.0.0-to-2.1.0.derby.sql a0bac3c metastore/scripts/upgrade/mssql/019-HIVE-13076.mssql.sql PRE-CREATION metastore/scripts/upgrade/mssql/hive-schema-2.1.0.mssql.sql cf5a662 metastore/scripts/upgrade/mssql/upgrade-2.0.0-to-2.1.0.mssql.sql f25daf2 metastore/scripts/upgrade/mysql/034-HIVE-13076.mysql.sql PRE-CREATION metastore/scripts/upgrade/mysql/hive-schema-2.1.0.mysql.sql 6fd3209 metastore/scripts/upgrade/mysql/upgrade-2.0.0-to-2.1.0.mysql.sql e790636 metastore/scripts/upgrade/oracle/034-HIVE-13076.oracle.sql PRE-CREATION metastore/scripts/upgrade/oracle/hive-schema-2.1.0.oracle.sql 774f6be metastore/scripts/upgrade/oracle/upgrade-2.0.0-to-2.1.0.oracle.sql 8368d08 metastore/scripts/upgrade/postgres/033-HIVE-13076.postgres.sql PRE-CREATION metastore/scripts/upgrade/postgres/hive-schema-2.1.0.postgres.sql 7463a37 metastore/scripts/upgrade/postgres/upgrade-2.0.0-to-2.1.0.postgres.sql 6172407 metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ForeignKeysRequest.java PRE-CREATION metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ForeignKeysResponse.java PRE-CREATION metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PrimaryKeysRequest.java PRE-CREATION metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PrimaryKeysResponse.java PRE-CREATION metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/SQLForeignKey.java PRE-CREATION metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/SQLPrimaryKey.java PRE-CREATION metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java c9fadad metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 64a26ac metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 39cf927 metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 06e9f78 metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java ac293b9 metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java e49f757 metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseStore.java a73dbeb metastore/src/model/org/apache/hadoop/hive/metastore/model/MConstraint.java PRE-CREATION metastore/src/model/org/apache/hadoop/hive/metastore/model/MConstraintPK.java PRE-CREATION metastore/src/model/package.jdo 7385a13 metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java 94ca835 metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java b108f95 Diff: https://reviews.apache.org/r/45406/diff/ Testing --- Thanks, Hari Sankar Sivarama Subramaniyan
Re: Review Request 45406: HIVE-13349: Metastore Changes : API calls for retrieving primary keys and foreign keys information
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45406/ --- (Updated April 13, 2016, 7:59 p.m.) Review request for hive and Ashutosh Chauhan. Repository: hive-git Description --- Metastore Changes : API calls for retrieving primary keys and foreign keys information Diffs (updated) - metastore/if/hive_metastore.thrift 6a55962 metastore/scripts/upgrade/derby/034-HIVE-13076.derby.sql PRE-CREATION metastore/scripts/upgrade/derby/hive-schema-2.1.0.derby.sql 42f4eb6 metastore/scripts/upgrade/derby/upgrade-2.0.0-to-2.1.0.derby.sql a0bac3c metastore/scripts/upgrade/mssql/019-HIVE-13076.mssql.sql PRE-CREATION metastore/scripts/upgrade/mssql/hive-schema-2.1.0.mssql.sql cf5a662 metastore/scripts/upgrade/mssql/upgrade-2.0.0-to-2.1.0.mssql.sql f25daf2 metastore/scripts/upgrade/mysql/034-HIVE-13076.mysql.sql PRE-CREATION metastore/scripts/upgrade/mysql/hive-schema-2.1.0.mysql.sql 6fd3209 metastore/scripts/upgrade/mysql/upgrade-2.0.0-to-2.1.0.mysql.sql e790636 metastore/scripts/upgrade/oracle/034-HIVE-13076.oracle.sql PRE-CREATION metastore/scripts/upgrade/oracle/hive-schema-2.1.0.oracle.sql 774f6be metastore/scripts/upgrade/oracle/upgrade-2.0.0-to-2.1.0.oracle.sql 8368d08 metastore/scripts/upgrade/postgres/033-HIVE-13076.postgres.sql PRE-CREATION metastore/scripts/upgrade/postgres/hive-schema-2.1.0.postgres.sql 7463a37 metastore/scripts/upgrade/postgres/upgrade-2.0.0-to-2.1.0.postgres.sql 6172407 metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java c9fadad metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 64a26ac metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 39cf927 metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 06e9f78 metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java ac293b9 metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java e49f757 metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseStore.java a73dbeb metastore/src/model/org/apache/hadoop/hive/metastore/model/MConstraint.java PRE-CREATION metastore/src/model/package.jdo 7385a13 metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java 94ca835 metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java b108f95 Diff: https://reviews.apache.org/r/45406/diff/ Testing --- Thanks, Hari Sankar Sivarama Subramaniyan
Re: Review Request 45406: HIVE-13349: Metastore Changes : API calls for retrieving primary keys and foreign keys information
> On April 11, 2016, 11:23 p.m., Ashutosh Chauhan wrote: > > metastore/scripts/upgrade/derby/034-HIVE-13076.derby.sql, line 2 > > <https://reviews.apache.org/r/45406/diff/3/?file=1339577#file1339577line2> > > > > Any reason for index on constraint name, position? > > I think on CD_ID it makes more sense. This is required for disallowing duplicate constraint names. Also, index is created on parent table id. > On April 11, 2016, 11:23 p.m., Ashutosh Chauhan wrote: > > metastore/scripts/upgrade/derby/034-HIVE-13076.derby.sql, line 1 > > <https://reviews.apache.org/r/45406/diff/3/?file=1339577#file1339577line1> > > > > Do you need TBL_ID? > > Since you need a join with TBLS anyway and CD_ID is unique, I don't > > think its useful to store TBL_ID here. Without TBL_ID, a join with SDS is required on SD_ID to retrieve all the columns associated with a table. - Hari Sankar --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45406/#review128275 ------- On April 12, 2016, 8:47 p.m., Hari Sankar Sivarama Subramaniyan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45406/ > --- > > (Updated April 12, 2016, 8:47 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Repository: hive-git > > > Description > --- > > Metastore Changes : API calls for retrieving primary keys and foreign keys > information > > > Diffs > - > > metastore/if/hive_metastore.thrift 6a55962 > metastore/scripts/upgrade/derby/034-HIVE-13076.derby.sql PRE-CREATION > metastore/scripts/upgrade/derby/hive-schema-2.1.0.derby.sql 42f4eb6 > metastore/scripts/upgrade/derby/upgrade-2.0.0-to-2.1.0.derby.sql a0bac3c > metastore/scripts/upgrade/mssql/019-HIVE-13076.mssql.sql PRE-CREATION > metastore/scripts/upgrade/mssql/hive-schema-2.1.0.mssql.sql cf5a662 > metastore/scripts/upgrade/mssql/upgrade-2.0.0-to-2.1.0.mssql.sql f25daf2 > metastore/scripts/upgrade/mysql/034-HIVE-13076.mysql.sql PRE-CREATION > metastore/scripts/upgrade/mysql/hive-schema-2.1.0.mysql.sql 6fd3209 > metastore/scripts/upgrade/mysql/upgrade-2.0.0-to-2.1.0.mysql.sql e790636 > metastore/scripts/upgrade/oracle/034-HIVE-13076.oracle.sql PRE-CREATION > metastore/scripts/upgrade/oracle/hive-schema-2.1.0.oracle.sql 774f6be > metastore/scripts/upgrade/oracle/upgrade-2.0.0-to-2.1.0.oracle.sql 8368d08 > metastore/scripts/upgrade/postgres/033-HIVE-13076.postgres.sql PRE-CREATION > metastore/scripts/upgrade/postgres/hive-schema-2.1.0.postgres.sql 7463a37 > metastore/scripts/upgrade/postgres/upgrade-2.0.0-to-2.1.0.postgres.sql > 6172407 > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > c9fadad > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java > 64a26ac > metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java > 39cf927 > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java > 06e9f78 > metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java > ac293b9 > metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java e49f757 > metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseStore.java > a73dbeb > metastore/src/model/org/apache/hadoop/hive/metastore/model/MConstraint.java > PRE-CREATION > metastore/src/model/package.jdo 7385a13 > > metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java > 94ca835 > > metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java > b108f95 > > Diff: https://reviews.apache.org/r/45406/diff/ > > > Testing > --- > > > Thanks, > > Hari Sankar Sivarama Subramaniyan > >
Re: Review Request 45406: HIVE-13349: Metastore Changes : API calls for retrieving primary keys and foreign keys information
> On April 13, 2016, 3:12 p.m., Ashutosh Chauhan wrote: > > In hive-schema-2.1-***.sql instead of adding run you may just > > inline new create table statements which is consistent with other create > > table statements there. Ok makes sense. Will do it in the new upload. > On April 13, 2016, 3:12 p.m., Ashutosh Chauhan wrote: > > metastore/if/hive_metastore.thrift, lines 62-63 > > <https://reviews.apache.org/r/45406/diff/4/?file=1341804#file1341804line62> > > > > fk_constraint_name, pk_constraint_name ? The naming convention is based on https://docs.oracle.com/javase/7/docs/api/java/sql/DatabaseMetaData.html#getPrimaryKeys(java.lang.String,%20java.lang.String,%20java.lang.String). > On April 13, 2016, 3:12 p.m., Ashutosh Chauhan wrote: > > metastore/if/hive_metastore.thrift, line 49 > > <https://reviews.apache.org/r/45406/diff/4/?file=1341804#file1341804line49> > > > > should this be called constraint name ? https://docs.oracle.com/javase/7/docs/api/java/sql/DatabaseMetaData.html#getPrimaryKeys(java.lang.String,%20java.lang.String,%20java.lang.String) is the naming standard followed > On April 13, 2016, 3:12 p.m., Ashutosh Chauhan wrote: > > metastore/scripts/upgrade/mssql/019-HIVE-13076.mssql.sql, line 1 > > <https://reviews.apache.org/r/45406/diff/4/?file=1341808#file1341808line1> > > > > IF NOT Exists missing Create table without an IF NOT EXISTS is in convention with the create statements in the *mssql.sql files. I added "IF EXISTS" on oracle/postgres scripts based on the comments. But in hindsight, it is not necessary/rather may be a bad approach to add the IF NOT Exists clause since we should throw error if the table already exists and not silently ignore the create statement which can cause issue if the already existing table definition is not the same as the one expected by hive. - Hari Sankar --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45406/#review128681 --- On April 12, 2016, 8:47 p.m., Hari Sankar Sivarama Subramaniyan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45406/ > --- > > (Updated April 12, 2016, 8:47 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Repository: hive-git > > > Description > --- > > Metastore Changes : API calls for retrieving primary keys and foreign keys > information > > > Diffs > - > > metastore/if/hive_metastore.thrift 6a55962 > metastore/scripts/upgrade/derby/034-HIVE-13076.derby.sql PRE-CREATION > metastore/scripts/upgrade/derby/hive-schema-2.1.0.derby.sql 42f4eb6 > metastore/scripts/upgrade/derby/upgrade-2.0.0-to-2.1.0.derby.sql a0bac3c > metastore/scripts/upgrade/mssql/019-HIVE-13076.mssql.sql PRE-CREATION > metastore/scripts/upgrade/mssql/hive-schema-2.1.0.mssql.sql cf5a662 > metastore/scripts/upgrade/mssql/upgrade-2.0.0-to-2.1.0.mssql.sql f25daf2 > metastore/scripts/upgrade/mysql/034-HIVE-13076.mysql.sql PRE-CREATION > metastore/scripts/upgrade/mysql/hive-schema-2.1.0.mysql.sql 6fd3209 > metastore/scripts/upgrade/mysql/upgrade-2.0.0-to-2.1.0.mysql.sql e790636 > metastore/scripts/upgrade/oracle/034-HIVE-13076.oracle.sql PRE-CREATION > metastore/scripts/upgrade/oracle/hive-schema-2.1.0.oracle.sql 774f6be > metastore/scripts/upgrade/oracle/upgrade-2.0.0-to-2.1.0.oracle.sql 8368d08 > metastore/scripts/upgrade/postgres/033-HIVE-13076.postgres.sql PRE-CREATION > metastore/scripts/upgrade/postgres/hive-schema-2.1.0.postgres.sql 7463a37 > metastore/scripts/upgrade/postgres/upgrade-2.0.0-to-2.1.0.postgres.sql > 6172407 > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > c9fadad > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java > 64a26ac > metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java > 39cf927 > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java > 06e9f78 > metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java > ac293b9 > metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java e49f757 > metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseStore.java > a73dbeb > metastore/src/model/org/apache/hadoop/hive/metastore/model/MConstraint.java > PRE-CREATION > metastore/src/model/package.jdo 7385a13 > > metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java > 94ca835 > > metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java > b108f95 > > Diff: https://reviews.apache.org/r/45406/diff/ > > > Testing > --- > > > Thanks, > > Hari Sankar Sivarama Subramaniyan > >
Re: Review Request 45406: HIVE-13349: Metastore Changes : API calls for retrieving primary keys and foreign keys information
> On April 4, 2016, 11:11 p.m., Ashutosh Chauhan wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseStore.java, > > line 2601 > > <https://reviews.apache.org/r/45406/diff/2/?file=1324927#file1324927line2601> > > > > We need to implement these methods. Will do in a followup jira - Hari Sankar --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45406/#review126950 --- On April 12, 2016, 8:47 p.m., Hari Sankar Sivarama Subramaniyan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45406/ > --- > > (Updated April 12, 2016, 8:47 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Repository: hive-git > > > Description > --- > > Metastore Changes : API calls for retrieving primary keys and foreign keys > information > > > Diffs > - > > metastore/if/hive_metastore.thrift 6a55962 > metastore/scripts/upgrade/derby/034-HIVE-13076.derby.sql PRE-CREATION > metastore/scripts/upgrade/derby/hive-schema-2.1.0.derby.sql 42f4eb6 > metastore/scripts/upgrade/derby/upgrade-2.0.0-to-2.1.0.derby.sql a0bac3c > metastore/scripts/upgrade/mssql/019-HIVE-13076.mssql.sql PRE-CREATION > metastore/scripts/upgrade/mssql/hive-schema-2.1.0.mssql.sql cf5a662 > metastore/scripts/upgrade/mssql/upgrade-2.0.0-to-2.1.0.mssql.sql f25daf2 > metastore/scripts/upgrade/mysql/034-HIVE-13076.mysql.sql PRE-CREATION > metastore/scripts/upgrade/mysql/hive-schema-2.1.0.mysql.sql 6fd3209 > metastore/scripts/upgrade/mysql/upgrade-2.0.0-to-2.1.0.mysql.sql e790636 > metastore/scripts/upgrade/oracle/034-HIVE-13076.oracle.sql PRE-CREATION > metastore/scripts/upgrade/oracle/hive-schema-2.1.0.oracle.sql 774f6be > metastore/scripts/upgrade/oracle/upgrade-2.0.0-to-2.1.0.oracle.sql 8368d08 > metastore/scripts/upgrade/postgres/033-HIVE-13076.postgres.sql PRE-CREATION > metastore/scripts/upgrade/postgres/hive-schema-2.1.0.postgres.sql 7463a37 > metastore/scripts/upgrade/postgres/upgrade-2.0.0-to-2.1.0.postgres.sql > 6172407 > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > c9fadad > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java > 64a26ac > metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java > 39cf927 > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java > 06e9f78 > metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java > ac293b9 > metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java e49f757 > metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseStore.java > a73dbeb > metastore/src/model/org/apache/hadoop/hive/metastore/model/MConstraint.java > PRE-CREATION > metastore/src/model/package.jdo 7385a13 > > metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java > 94ca835 > > metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java > b108f95 > > Diff: https://reviews.apache.org/r/45406/diff/ > > > Testing > --- > > > Thanks, > > Hari Sankar Sivarama Subramaniyan > >
Re: Review Request 45406: HIVE-13349: Metastore Changes : API calls for retrieving primary keys and foreign keys information
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45406/ --- (Updated April 12, 2016, 8:47 p.m.) Review request for hive and Ashutosh Chauhan. Repository: hive-git Description --- Metastore Changes : API calls for retrieving primary keys and foreign keys information Diffs (updated) - metastore/if/hive_metastore.thrift 6a55962 metastore/scripts/upgrade/derby/034-HIVE-13076.derby.sql PRE-CREATION metastore/scripts/upgrade/derby/hive-schema-2.1.0.derby.sql 42f4eb6 metastore/scripts/upgrade/derby/upgrade-2.0.0-to-2.1.0.derby.sql a0bac3c metastore/scripts/upgrade/mssql/019-HIVE-13076.mssql.sql PRE-CREATION metastore/scripts/upgrade/mssql/hive-schema-2.1.0.mssql.sql cf5a662 metastore/scripts/upgrade/mssql/upgrade-2.0.0-to-2.1.0.mssql.sql f25daf2 metastore/scripts/upgrade/mysql/034-HIVE-13076.mysql.sql PRE-CREATION metastore/scripts/upgrade/mysql/hive-schema-2.1.0.mysql.sql 6fd3209 metastore/scripts/upgrade/mysql/upgrade-2.0.0-to-2.1.0.mysql.sql e790636 metastore/scripts/upgrade/oracle/034-HIVE-13076.oracle.sql PRE-CREATION metastore/scripts/upgrade/oracle/hive-schema-2.1.0.oracle.sql 774f6be metastore/scripts/upgrade/oracle/upgrade-2.0.0-to-2.1.0.oracle.sql 8368d08 metastore/scripts/upgrade/postgres/033-HIVE-13076.postgres.sql PRE-CREATION metastore/scripts/upgrade/postgres/hive-schema-2.1.0.postgres.sql 7463a37 metastore/scripts/upgrade/postgres/upgrade-2.0.0-to-2.1.0.postgres.sql 6172407 metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java c9fadad metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 64a26ac metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 39cf927 metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 06e9f78 metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java ac293b9 metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java e49f757 metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseStore.java a73dbeb metastore/src/model/org/apache/hadoop/hive/metastore/model/MConstraint.java PRE-CREATION metastore/src/model/package.jdo 7385a13 metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java 94ca835 metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java b108f95 Diff: https://reviews.apache.org/r/45406/diff/ Testing --- Thanks, Hari Sankar Sivarama Subramaniyan
Re: Review Request 45406: HIVE-13349: Metastore Changes : API calls for retrieving primary keys and foreign keys information
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45406/ --- (Updated April 11, 2016, 5:45 p.m.) Review request for hive and Ashutosh Chauhan. Repository: hive-git Description --- Metastore Changes : API calls for retrieving primary keys and foreign keys information Diffs (updated) - metastore/if/hive_metastore.thrift 6a55962 metastore/scripts/upgrade/derby/034-HIVE-13076.derby.sql PRE-CREATION metastore/scripts/upgrade/derby/hive-schema-2.1.0.derby.sql 42f4eb6 metastore/scripts/upgrade/derby/upgrade-2.0.0-to-2.1.0.derby.sql a0bac3c metastore/scripts/upgrade/mssql/hive-schema-2.1.0.mssql.sql cf5a662 metastore/scripts/upgrade/mssql/upgrade-2.0.0-to-2.1.0.mssql.sql f25daf2 metastore/scripts/upgrade/mysql/hive-schema-2.1.0.mysql.sql 6fd3209 metastore/scripts/upgrade/mysql/upgrade-2.0.0-to-2.1.0.mysql.sql e790636 metastore/scripts/upgrade/oracle/hive-schema-2.1.0.oracle.sql 774f6be metastore/scripts/upgrade/oracle/upgrade-2.0.0-to-2.1.0.oracle.sql 8368d08 metastore/scripts/upgrade/postgres/hive-schema-2.1.0.postgres.sql 7463a37 metastore/scripts/upgrade/postgres/upgrade-2.0.0-to-2.1.0.postgres.sql 6172407 metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java c9fadad metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java cdd12ab metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 39cf927 metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 06e9f78 metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java ac293b9 metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java e49f757 metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseStore.java a73dbeb metastore/src/model/package.jdo 7385a13 metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java 94ca835 metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java b108f95 service/src/gen/thrift/gen-py/hive_service/ThriftHive-remote 9a2322f Diff: https://reviews.apache.org/r/45406/diff/ Testing --- Thanks, Hari Sankar Sivarama Subramaniyan
Re: Review Request 45406: HIVE-13349: Metastore Changes : API calls for retrieving primary keys and foreign keys information
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45406/ --- (Updated April 4, 2016, 8:45 p.m.) Review request for hive and Ashutosh Chauhan. Repository: hive-git Description --- Metastore Changes : API calls for retrieving primary keys and foreign keys information Diffs (updated) - metastore/if/hive_metastore.thrift 6a55962 metastore/scripts/upgrade/derby/034-HIVE-13076.derby.sql PRE-CREATION metastore/scripts/upgrade/derby/hive-schema-2.1.0.derby.sql 42f4eb6 metastore/scripts/upgrade/derby/upgrade-2.0.0-to-2.1.0.derby.sql a0bac3c metastore/scripts/upgrade/mssql/hive-schema-2.1.0.mssql.sql cf5a662 metastore/scripts/upgrade/mssql/upgrade-2.0.0-to-2.1.0.mssql.sql f25daf2 metastore/scripts/upgrade/mysql/034-HIVE-13076.mysql.sql PRE-CREATION metastore/scripts/upgrade/mysql/hive-schema-2.1.0.mysql.sql 6fd3209 metastore/scripts/upgrade/mysql/upgrade-2.0.0-to-2.1.0.mysql.sql e790636 metastore/scripts/upgrade/oracle/034-HIVE-13076.oracle.sql PRE-CREATION metastore/scripts/upgrade/oracle/hive-schema-2.1.0.oracle.sql 774f6be metastore/scripts/upgrade/oracle/upgrade-2.0.0-to-2.1.0.oracle.sql 8368d08 metastore/scripts/upgrade/postgres/033-HIVE-13076.postgres.sql PRE-CREATION metastore/scripts/upgrade/postgres/hive-schema-2.1.0.postgres.sql 7463a37 metastore/scripts/upgrade/postgres/upgrade-2.0.0-to-2.1.0.postgres.sql 6172407 metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java c9fadad metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java cdd12ab metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 39cf927 metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 06e9f78 metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java ac293b9 metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java e49f757 metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseStore.java a73dbeb metastore/src/model/org/apache/hadoop/hive/metastore/model/MTable.java 2a78ce9 metastore/src/model/package.jdo 7385a13 metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java 94ca835 metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java b108f95 metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStorePartitionSpecs.java 922a4bf metastore/src/test/org/apache/hadoop/hive/metastore/TestObjectStore.java 2e1f5f4 metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseAggregateStatsCache.java 6cd3a46 metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseAggregateStatsCacheWithBitVector.java e0c4094 metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseAggregateStatsExtrapolation.java f4e55ed metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseAggregateStatsNDVUniformDist.java 62918be metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseStore.java e4723f6 metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseStoreBitVector.java b1dc542 metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseStoreCached.java cfe9cd0 Diff: https://reviews.apache.org/r/45406/diff/ Testing --- Thanks, Hari Sankar Sivarama Subramaniyan
[jira] [Created] (HIVE-13407) Add more subtlety to TezCompiler Perf Logging
Hari Sankar Sivarama Subramaniyan created HIVE-13407: Summary: Add more subtlety to TezCompiler Perf Logging Key: HIVE-13407 URL: https://issues.apache.org/jira/browse/HIVE-13407 Project: Hive Issue Type: Bug Reporter: Hari Sankar Sivarama Subramaniyan Assignee: Hari Sankar Sivarama Subramaniyan We can add more subtlety to perf logging information in TezCompiler -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Review Request 45406: HIVE-13349: Metastore Changes : API calls for retrieving primary keys and foreign keys information
/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/OpenTxnsResponse.java e11a2b3 metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Partition.java a247221 metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionListComposingSpec.java e8232b9 metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionSpecWithSharedSD.java 2c41912 metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionWithoutSD.java f0c5ce1 metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionsByExprResult.java 12ae66d metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionsStatsRequest.java 8416369 metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionsStatsResult.java 2e903f1 metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PrincipalPrivilegeSet.java e1792bd metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PrivilegeBag.java bba2d40 metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PutFileMetadataRequest.java ab151b1 metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/RequestPartsSpec.java 7f8a044 metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Schema.java 75d0ebb metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/SerDeInfo.java d5a8d99 metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/SetPartitionsStatsRequest.java 6e334f6 metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ShowCompactResponse.java afa832c metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ShowLocksResponse.java b9b7f3c metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/SkewedInfo.java c32f50c metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/StorageDescriptor.java 938f06b metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Table.java 5d683fb metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/TableStatsRequest.java d0daee5 metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/TableStatsResult.java 78d4250 metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 13e30db metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Type.java 14cd42e metastore/src/gen/thrift/gen-php/metastore/ThriftHiveMetastore.php 05a0749 metastore/src/gen/thrift/gen-php/metastore/Types.php 488a920 metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote 516b926 metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py ac8d8a4 metastore/src/gen/thrift/gen-py/hive_metastore/ttypes.py 10eaf4a metastore/src/gen/thrift/gen-rb/hive_metastore_types.rb 1cf40ae metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb e782bb5 metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java c9fadad metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java cdd12ab metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 39cf927 metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 06e9f78 metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 35adb39 metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java e49f757 metastore/src/model/org/apache/hadoop/hive/metastore/model/MForeignKeyRel.java PRE-CREATION metastore/src/model/org/apache/hadoop/hive/metastore/model/MPKFKMapping.java PRE-CREATION metastore/src/model/org/apache/hadoop/hive/metastore/model/MTable.java 2a78ce9 metastore/src/model/package.jdo 7385a13 metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStorePartitionSpecs.java 922a4bf metastore/src/test/org/apache/hadoop/hive/metastore/TestObjectStore.java 2e1f5f4 metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseAggregateStatsCache.java 6cd3a46 metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseAggregateStatsCacheWithBitVector.java e0c4094 metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseAggregateStatsExtrapolation.java f4e55ed metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseAggregateStatsNDVUniformDist.java 62918be metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseStore.java e4723f6 metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseStoreBitVector.java b1dc542 metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseStoreCached.java cfe9cd0 Diff: https://reviews.apache.org/r/45406/diff/ Testing --- Thanks, Hari Sankar Sivarama Subramaniyan
Re: Review Request 44031: HIVE-13130: HS2 changes: API calls for retrieving primary keys and foreign keys information
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44031/ --- (Updated March 29, 2016, 12:11 a.m.) Review request for hive and Ashutosh Chauhan. Summary (updated) - HIVE-13130: HS2 changes: API calls for retrieving primary keys and foreign keys information Repository: hive-git Description (updated) --- HS2 changes: API calls for retrieving primary keys and foreign keys information. Changes without the generated thrift files. Diffs - jdbc/src/java/org/apache/hive/jdbc/HiveDatabaseMetaData.java 7e54d1f service-rpc/if/TCLIService.thrift aa28b6e service-rpc/src/gen/thrift/gen-cpp/TCLIService.h 3407564 service-rpc/src/gen/thrift/gen-cpp/TCLIService.cpp fc82b88 service-rpc/src/gen/thrift/gen-cpp/TCLIService_server.skeleton.cpp 66ed6a7 service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.h 7f1d9dd service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.cpp 3a27a60 service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TCLIService.java c684f89 service-rpc/src/gen/thrift/gen-php/TCLIService.php eba62f1 service-rpc/src/gen/thrift/gen-php/Types.php b7df50a service-rpc/src/gen/thrift/gen-py/TCLIService/TCLIService-remote 56f5c5d service-rpc/src/gen/thrift/gen-py/TCLIService/TCLIService.py ad2d71d service-rpc/src/gen/thrift/gen-py/TCLIService/ttypes.py c691781 service-rpc/src/gen/thrift/gen-rb/t_c_l_i_service.rb 7d7f7a7 service-rpc/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb 07ed97c service/src/java/org/apache/hive/service/cli/CLIService.java ab30ae2 service/src/java/org/apache/hive/service/cli/EmbeddedCLIServiceClient.java 9cad5be service/src/java/org/apache/hive/service/cli/ICLIService.java 0a54bdd service/src/java/org/apache/hive/service/cli/operation/GetCrossReferenceOperation.java PRE-CREATION service/src/java/org/apache/hive/service/cli/operation/GetPrimaryKeysOperation.java PRE-CREATION service/src/java/org/apache/hive/service/cli/operation/OperationManager.java 56a9c18 service/src/java/org/apache/hive/service/cli/session/HiveSession.java 4f4e92d service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 80a1844 service/src/java/org/apache/hive/service/cli/thrift/RetryingThriftCLIServiceClient.java 14191e5 service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 62fcde5 service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceClient.java ccce6dc Diff: https://reviews.apache.org/r/44031/diff/ Testing --- Thanks, Hari Sankar Sivarama Subramaniyan
Re: Review Request 45406: HIVE-13349: Metastore Changes : API calls for retrieving primary keys and foreign keys information
/TestHBaseStoreCached.java cfe9cd0 Diff: https://reviews.apache.org/r/45406/diff/ Testing --- Thanks, Hari Sankar Sivarama Subramaniyan
Re: Review Request 44031: HIVE-13130: API calls for retrieving primary keys and foreign keys information
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44031/ --- (Updated March 29, 2016, 12:10 a.m.) Review request for hive and Ashutosh Chauhan. Changes --- Just the JDBC/HS2 related changes. Repository: hive-git Description --- API calls for retrieving primary keys and foreign keys information. Changes without the generated thrift files. Diffs (updated) - jdbc/src/java/org/apache/hive/jdbc/HiveDatabaseMetaData.java 7e54d1f service-rpc/if/TCLIService.thrift aa28b6e service-rpc/src/gen/thrift/gen-cpp/TCLIService.h 3407564 service-rpc/src/gen/thrift/gen-cpp/TCLIService.cpp fc82b88 service-rpc/src/gen/thrift/gen-cpp/TCLIService_server.skeleton.cpp 66ed6a7 service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.h 7f1d9dd service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.cpp 3a27a60 service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TCLIService.java c684f89 service-rpc/src/gen/thrift/gen-php/TCLIService.php eba62f1 service-rpc/src/gen/thrift/gen-php/Types.php b7df50a service-rpc/src/gen/thrift/gen-py/TCLIService/TCLIService-remote 56f5c5d service-rpc/src/gen/thrift/gen-py/TCLIService/TCLIService.py ad2d71d service-rpc/src/gen/thrift/gen-py/TCLIService/ttypes.py c691781 service-rpc/src/gen/thrift/gen-rb/t_c_l_i_service.rb 7d7f7a7 service-rpc/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb 07ed97c service/src/java/org/apache/hive/service/cli/CLIService.java ab30ae2 service/src/java/org/apache/hive/service/cli/EmbeddedCLIServiceClient.java 9cad5be service/src/java/org/apache/hive/service/cli/ICLIService.java 0a54bdd service/src/java/org/apache/hive/service/cli/operation/GetCrossReferenceOperation.java PRE-CREATION service/src/java/org/apache/hive/service/cli/operation/GetPrimaryKeysOperation.java PRE-CREATION service/src/java/org/apache/hive/service/cli/operation/OperationManager.java 56a9c18 service/src/java/org/apache/hive/service/cli/session/HiveSession.java 4f4e92d service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 80a1844 service/src/java/org/apache/hive/service/cli/thrift/RetryingThriftCLIServiceClient.java 14191e5 service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 62fcde5 service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceClient.java ccce6dc Diff: https://reviews.apache.org/r/44031/diff/ Testing --- Thanks, Hari Sankar Sivarama Subramaniyan
Review Request 45406: HIVE-13349: Metastore Changes : HS2 changes : API calls for retrieving primary keys and foreign keys information
/hive/metastore/api/OpenTxnsResponse.java e11a2b3 metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Partition.java a247221 metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionListComposingSpec.java e8232b9 metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionSpecWithSharedSD.java 2c41912 metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionWithoutSD.java f0c5ce1 metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionsByExprResult.java 12ae66d metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionsStatsRequest.java 8416369 metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionsStatsResult.java 2e903f1 metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PrincipalPrivilegeSet.java e1792bd metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PrivilegeBag.java bba2d40 metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PutFileMetadataRequest.java ab151b1 metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/RequestPartsSpec.java 7f8a044 metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Schema.java 75d0ebb metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/SerDeInfo.java d5a8d99 metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/SetPartitionsStatsRequest.java 6e334f6 metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ShowCompactResponse.java afa832c metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ShowLocksResponse.java b9b7f3c metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/SkewedInfo.java c32f50c metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/StorageDescriptor.java 938f06b metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Table.java 5d683fb metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/TableStatsRequest.java d0daee5 metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/TableStatsResult.java 78d4250 metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 13e30db metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Type.java 14cd42e metastore/src/gen/thrift/gen-php/metastore/ThriftHiveMetastore.php 05a0749 metastore/src/gen/thrift/gen-php/metastore/Types.php 488a920 metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote 516b926 metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py ac8d8a4 metastore/src/gen/thrift/gen-py/hive_metastore/ttypes.py 10eaf4a metastore/src/gen/thrift/gen-rb/hive_metastore_types.rb 1cf40ae metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb e782bb5 metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java c9fadad metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java cdd12ab metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 39cf927 metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 06e9f78 metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 35adb39 metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java e49f757 metastore/src/model/org/apache/hadoop/hive/metastore/model/MForeignKeyRel.java PRE-CREATION metastore/src/model/org/apache/hadoop/hive/metastore/model/MPKFKMapping.java PRE-CREATION metastore/src/model/org/apache/hadoop/hive/metastore/model/MTable.java 2a78ce9 metastore/src/model/package.jdo 7385a13 metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStorePartitionSpecs.java 922a4bf metastore/src/test/org/apache/hadoop/hive/metastore/TestObjectStore.java 2e1f5f4 metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseAggregateStatsCache.java 6cd3a46 metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseAggregateStatsCacheWithBitVector.java e0c4094 metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseAggregateStatsExtrapolation.java f4e55ed metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseAggregateStatsNDVUniformDist.java 62918be metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseStore.java e4723f6 metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseStoreBitVector.java b1dc542 metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseStoreCached.java cfe9cd0 Diff: https://reviews.apache.org/r/45406/diff/ Testing --- Thanks, Hari Sankar Sivarama Subramaniyan
[jira] [Created] (HIVE-13351) Support drop Primary Key/Foreign Key constraints
Hari Sankar Sivarama Subramaniyan created HIVE-13351: Summary: Support drop Primary Key/Foreign Key constraints Key: HIVE-13351 URL: https://issues.apache.org/jira/browse/HIVE-13351 Project: Hive Issue Type: Sub-task Reporter: Hari Sankar Sivarama Subramaniyan -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HIVE-13350) Support Alter commands for Rely/NoRely novalidate
Hari Sankar Sivarama Subramaniyan created HIVE-13350: Summary: Support Alter commands for Rely/NoRely novalidate Key: HIVE-13350 URL: https://issues.apache.org/jira/browse/HIVE-13350 Project: Hive Issue Type: Sub-task Reporter: Hari Sankar Sivarama Subramaniyan Assignee: Hari Sankar Sivarama Subramaniyan -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HIVE-13349) Metastore Changes : HS2 changes : API calls for retrieving primary keys and foreign keys information
Hari Sankar Sivarama Subramaniyan created HIVE-13349: Summary: Metastore Changes : HS2 changes : API calls for retrieving primary keys and foreign keys information Key: HIVE-13349 URL: https://issues.apache.org/jira/browse/HIVE-13349 Project: Hive Issue Type: Sub-task Reporter: Hari Sankar Sivarama Subramaniyan -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Review Request 45274: HIVE-13290 : Support PK/FK constraint as part of create table command
/apache/hadoop/hive/ql/parse/HiveParser.g 50c53db ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java 549d24f ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java 5f13277 ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java d9db1d5 ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableDesc.java 03b4d8b Diff: https://reviews.apache.org/r/45274/diff/ Testing --- Local testing done Thanks, Hari Sankar Sivarama Subramaniyan
[jira] [Created] (HIVE-13290) Support primary keys/foreign keys constraint as part of create table command in Hive
Hari Sankar Sivarama Subramaniyan created HIVE-13290: Summary: Support primary keys/foreign keys constraint as part of create table command in Hive Key: HIVE-13290 URL: https://issues.apache.org/jira/browse/HIVE-13290 Project: Hive Issue Type: Sub-task Reporter: Hari Sankar Sivarama Subramaniyan Assignee: Hari Sankar Sivarama Subramaniyan -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HIVE-13192) OOM error when MapJoinBytesTableContainer memory threshold is too low
Hari Sankar Sivarama Subramaniyan created HIVE-13192:
Summary: OOM error when MapJoinBytesTableContainer memory
threshold is too low
Key: HIVE-13192
URL: https://issues.apache.org/jira/browse/HIVE-13192
Project: Hive
Issue Type: Bug
Reporter: Hari Sankar Sivarama Subramaniyan
Assignee: Hari Sankar Sivarama Subramaniyan
HIVE-11449 covered the scenario with HybridHashTableContainer, but we can still
the error as shown below:
{code}
Vertex failed, vertexName=Map 1, vertexId=vertex_1454464706407_0225_1_19,
diagnostics=[Task failed, taskId=task_1454464706407_0225_1_19_00,
diagnostics=[TaskAttempt 0 failed, info=[Error: Failure while running
task:java.lang.RuntimeException: java.lang.OutOfMemoryError: Java heap space
at
org.apache.hadoop.hive.ql.exec.tez.TezProcessor.initializeAndRunProcessor(TezProcessor.java:172)
at org.apache.hadoop.hive.ql.exec.tez.TezProcessor.run(TezProcessor.java:138)
at
org.apache.tez.runtime.LogicalIOProcessorRuntimeTask.run(LogicalIOProcessorRuntimeTask.java:333)
at
org.apache.tez.runtime.task.TezTaskRunner$TaskRunnerCallable$1.run(TezTaskRunner.java:177)
at
org.apache.tez.runtime.task.TezTaskRunner$TaskRunnerCallable$1.run(TezTaskRunner.java:168)
at java.security.AccessController.doPrivileged(Native Method)
at javax.security.auth.Subject.doAs(Subject.java:415)
at
org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1671)
at
org.apache.tez.runtime.task.TezTaskRunner$TaskRunnerCallable.call(TezTaskRunner.java:168)
at
org.apache.tez.runtime.task.TezTaskRunner$TaskRunnerCallable.call(TezTaskRunner.java:163)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:745)
Caused by: java.lang.OutOfMemoryError: Java heap space
at
org.apache.hadoop.hive.serde2.WriteBuffers.nextBufferToWrite(WriteBuffers.java:206)
at org.apache.hadoop.hive.serde2.WriteBuffers.write(WriteBuffers.java:182)
at
org.apache.hadoop.hive.serde2.lazybinary.LazyBinaryUtils.writeVLong(LazyBinaryUtils.java:411)
at org.apache.hadoop.hive.serde2.WriteBuffers.writeVLong(WriteBuffers.java:294)
at
org.apache.hadoop.hive.ql.exec.persistence.BytesBytesMultiHashMap.addRecordToList(BytesBytesMultiHashMap.java:540)
at
org.apache.hadoop.hive.ql.exec.persistence.BytesBytesMultiHashMap.put(BytesBytesMultiHashMap.java:219)
at
org.apache.hadoop.hive.ql.exec.persistence.MapJoinBytesTableContainer.putRow(MapJoinBytesTableContainer.java:285)
at
org.apache.hadoop.hive.ql.exec.tez.HashTableLoader.load(HashTableLoader.java:114)
at
org.apache.hadoop.hive.ql.exec.MapJoinOperator.loadHashTable(MapJoinOperator.java:190)
at
org.apache.hadoop.hive.ql.exec.MapJoinOperator.cleanUpInputFileChangedOp(MapJoinOperator.java:216)
at
org.apache.hadoop.hive.ql.exec.Operator.cleanUpInputFileChanged(Operator.java:1051)
at
org.apache.hadoop.hive.ql.exec.Operator.cleanUpInputFileChanged(Operator.java:1055)
at
org.apache.hadoop.hive.ql.exec.Operator.cleanUpInputFileChanged(Operator.java:1055)
at
org.apache.hadoop.hive.ql.exec.Operator.cleanUpInputFileChanged(Operator.java:1055)
at
org.apache.hadoop.hive.ql.exec.vector.VectorMapOperator.process(VectorMapOperator.java:37)
at
org.apache.hadoop.hive.ql.exec.tez.MapRecordSource.processRow(MapRecordSource.java:83)
at
org.apache.hadoop.hive.ql.exec.tez.MapRecordSource.pushRecord(MapRecordSource.java:68)
at
org.apache.hadoop.hive.ql.exec.tez.MapRecordProcessor.run(MapRecordProcessor.java:316)
at
org.apache.hadoop.hive.ql.exec.tez.TezProcessor.initializeAndRunProcessor(TezProcessor.java:163)
... 13 more
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Review Request 44031: HIVE-13130: API calls for retrieving primary keys and foreign keys information
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44031/ --- Review request for hive and Ashutosh Chauhan. Repository: hive-git Description --- API calls for retrieving primary keys and foreign keys information. Changes without the generated thrift files. Diffs - jdbc/src/java/org/apache/hive/jdbc/HiveDatabaseMetaData.java 7e54d1f metastore/if/hive_metastore.thrift e8f0a68 metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java bfebfdc metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java b5c4d1d metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java cb092d1 service-rpc/if/TCLIService.thrift 0aa9d13 service/src/java/org/apache/hive/service/cli/CLIService.java cc6e138 service/src/java/org/apache/hive/service/cli/EmbeddedCLIServiceClient.java 9cad5be service/src/java/org/apache/hive/service/cli/ICLIService.java 0a54bdd service/src/java/org/apache/hive/service/cli/operation/GetCrossReferenceOperation.java PRE-CREATION service/src/java/org/apache/hive/service/cli/operation/GetPrimaryKeysOperation.java PRE-CREATION service/src/java/org/apache/hive/service/cli/operation/OperationManager.java 56a9c18 service/src/java/org/apache/hive/service/cli/session/HiveSession.java 4f4e92d service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 4aa1875 service/src/java/org/apache/hive/service/cli/thrift/RetryingThriftCLIServiceClient.java a81c600 service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 8dff264 service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceClient.java 5f01165 Diff: https://reviews.apache.org/r/44031/diff/ Testing --- Thanks, Hari Sankar Sivarama Subramaniyan
[jira] [Created] (HIVE-13130) API calls for retrieving primary keys and foreign keys information
Hari Sankar Sivarama Subramaniyan created HIVE-13130: Summary: API calls for retrieving primary keys and foreign keys information Key: HIVE-13130 URL: https://issues.apache.org/jira/browse/HIVE-13130 Project: Hive Issue Type: Bug Reporter: Hari Sankar Sivarama Subramaniyan Assignee: Hari Sankar Sivarama Subramaniyan ODBC exposes the SQLPrimaryKeys and SQLForeignKeys API calls and JDBC exposes getPrimaryKeys and getCrossReference API calls. We need to provide these interfaces as part of PK/FK implementation in Hive. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Review Request 43115: HIVE-12924 CBO: Calcite Operator To Hive Operator (Calcite Return Path): TestCliDriver groupby_ppr_multi_distinct.q failure
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43115/ --- (Updated Feb. 10, 2016, 12:12 a.m.) Review request for hive, Jesús Camacho Rodríguez and John Pullokkaran. Repository: hive-git Description --- CBO: Calcite Operator To Hive Operator (Calcite Return Path): TestCliDriver groupby_ppr_multi_distinct.q failure Diffs (updated) - ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/HiveGBOpConvUtil.java 7fbf8cd ql/src/test/results/clientpositive/cbo_rp_groupby3_noskew_multi_distinct.q.out 95233b0 Diff: https://reviews.apache.org/r/43115/diff/ Testing --- Precommit runs Thanks, Hari Sankar Sivarama Subramaniyan
Re: Review Request 43143: HIVE-12923 : CBO: Calcite Operator To Hive Operator (Calcite Return Path): TestCliDriver groupby_grouping_sets4.q failure
> On Feb. 5, 2016, 6:21 p.m., Jesús Camacho Rodríguez wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinProjectTransposeRule.java, > > line 153 > > <https://reviews.apache.org/r/43143/diff/2/?file=1231783#file1231783line153> > > > > This rule is only applied over the Project children. Thus, why is the > > parameter for the method hasAggregateChildWithIndicator e.g. leftJoinChild > > instead of leftProj? > > Jesús Camacho Rodríguez wrote: > OK, you still need to check because you might pull up every column from > one of the sides... > > Jesús Camacho Rodríguez wrote: > Please Hari, mark it as fixed if you agree. leftJoinChild is indeed obtained from getProjectChild(). I took the variable name/relevant part of the code except hasAggregateChildWithIndicator () from super.onMatch(). Maybe I should rename the variables/function name to hasAggregateDescendantWithIndicator(). Thanks Hari - Hari Sankar --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43143/#review118045 ------- On Feb. 3, 2016, 8:54 p.m., Hari Sankar Sivarama Subramaniyan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43143/ > --- > > (Updated Feb. 3, 2016, 8:54 p.m.) > > > Review request for hive, Jesús Camacho Rodríguez and John Pullokkaran. > > > Repository: hive-git > > > Description > --- > > CBO: Calcite Operator To Hive Operator (Calcite Return Path): TestCliDriver > groupby_grouping_sets4.q failure > > > Diffs > - > > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinProjectTransposeRule.java > f6b2d84 > > Diff: https://reviews.apache.org/r/43143/diff/ > > > Testing > --- > > Precommit runs > > > Thanks, > > Hari Sankar Sivarama Subramaniyan > >
[jira] [Created] (HIVE-13005) CBO: Calcite Operator To Hive Operator (Calcite Return Path): RexNode convert(ExprNodeConstantDesc literal) decimal support bug
Hari Sankar Sivarama Subramaniyan created HIVE-13005:
Summary: CBO: Calcite Operator To Hive Operator (Calcite Return
Path): RexNode convert(ExprNodeConstantDesc literal) decimal support bug
Key: HIVE-13005
URL: https://issues.apache.org/jira/browse/HIVE-13005
Project: Hive
Issue Type: Sub-task
Reporter: Hari Sankar Sivarama Subramaniyan
HIVE-8064 seems to have introduced this code in RexNodeConverter::convert(),
but the parameters look like they are wrongly passed :
{code}
RelDataType relType =
cluster.getTypeFactory().createSqlType(SqlTypeName.DECIMAL,
bd.scale(), unscaled.toString().length());
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Re: Review Request 43115: HIVE-12924 CBO: Calcite Operator To Hive Operator (Calcite Return Path): TestCliDriver groupby_ppr_multi_distinct.q failure
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43115/ --- (Updated Feb. 4, 2016, 9:29 p.m.) Review request for hive, Jesús Camacho Rodríguez and John Pullokkaran. Changes --- Thanks John for the review. The naming convention for the Distinct UDAF field for the GBY in the reduce side : :._col_. It seems that currently we dont generate the colExprMap correctly for the above convention in HiveGBOpUtil.genMapSideRS(). The ReduceSide GBY pipeling looks good to me in the current return path code. Since we are not generating the entries for the correct columns in the MapSide Reduce Operator, we run into an exception when we look for an entry corresponding to a column in the reduce side aggreagation. There is another optimization which can possibly done in the below scenario(after turning off mapside aggr): explain FROM srcpart src SELECT count(DISTINCT src.value), count(DISTINCT src.key,src.key), sum(DISTINCT src.value) WHERE src.ds = '2008-04-08' GROUP BY substr(src.key,1,1); The Reduce Operator Tree : ... Reduce Operator Tree: Group By Operator aggregations: count(DISTINCT KEY._col1:0._col0), count(DISTINCT KEY._col1:1._col0, KEY._col1:1._col1), sum(DISTINCT KEY._col1:2._col0) keys: KEY._col0 (type: string) mode: complete outputColumnNames: _col0, _col1, _col2, _col3 Statistics: Num rows: 1 Data size: 0 Basic stats: PARTIAL Column stats: NONE Select Operator .. As you can see, 1. KEY._col1:1._col0, KEY._col1:1._col1 is mapped to the same column and hence we could have used the same column in the rowschema of the ReduceSink Operator pipeline 2. KEY._col1:2._col0, KEY._col1:0._col0 is mapped to the same column and we can do the same thing mentioned in 1. I verified that this happens even in the non-return path code and should be covered as a general change as a further optimization in a separate jira. Thanks Hari Repository: hive-git Description --- CBO: Calcite Operator To Hive Operator (Calcite Return Path): TestCliDriver groupby_ppr_multi_distinct.q failure Diffs (updated) - ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/HiveGBOpConvUtil.java 7fbf8cd Diff: https://reviews.apache.org/r/43115/diff/ Testing --- Precommit runs Thanks, Hari Sankar Sivarama Subramaniyan
Re: Review Request 43143: HIVE-12923 : CBO: Calcite Operator To Hive Operator (Calcite Return Path): TestCliDriver groupby_grouping_sets4.q failure
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43143/ --- (Updated Feb. 3, 2016, 8:54 p.m.) Review request for hive, Jesús Camacho Rodríguez and John Pullokkaran. Changes --- Minor change to fix the diff in cbo_rp_outer_join_ppr.q Repository: hive-git Description --- CBO: Calcite Operator To Hive Operator (Calcite Return Path): TestCliDriver groupby_grouping_sets4.q failure Diffs (updated) - ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinProjectTransposeRule.java f6b2d84 Diff: https://reviews.apache.org/r/43143/diff/ Testing --- Precommit runs Thanks, Hari Sankar Sivarama Subramaniyan
Review Request 43143: HIVE-12923 : CBO: Calcite Operator To Hive Operator (Calcite Return Path): TestCliDriver groupby_grouping_sets4.q failure
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43143/ --- Review request for hive, Jesús Camacho Rodríguez and John Pullokkaran. Repository: hive-git Description --- CBO: Calcite Operator To Hive Operator (Calcite Return Path): TestCliDriver groupby_grouping_sets4.q failure Diffs - ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinProjectTransposeRule.java f6b2d84 Diff: https://reviews.apache.org/r/43143/diff/ Testing --- Precommit runs Thanks, Hari Sankar Sivarama Subramaniyan
Review Request 43115: HIVE-12924 CBO: Calcite Operator To Hive Operator (Calcite Return Path): TestCliDriver groupby_ppr_multi_distinct.q failure
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43115/ --- Review request for hive, Jesús Camacho Rodríguez and John Pullokkaran. Repository: hive-git Description --- CBO: Calcite Operator To Hive Operator (Calcite Return Path): TestCliDriver groupby_ppr_multi_distinct.q failure Diffs - ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/HiveGBOpConvUtil.java 7fbf8cd Diff: https://reviews.apache.org/r/43115/diff/ Testing --- Precommit runs Thanks, Hari Sankar Sivarama Subramaniyan
Re: Review Request 42359: HIVE-12805: CBO: Calcite Operator To Hive Operator (Calcite Return Path): MiniTezCliDriver skewjoin.q failure
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42359/ --- (Updated Jan. 26, 2016, 10:26 p.m.) Review request for hive, Ashutosh Chauhan, Jesús Camacho Rodríguez, and John Pullokkaran. Repository: hive-git Description --- HIVE-12805 CBO: Calcite Operator To Hive Operator (Calcite Return Path): MiniTezCliDriver skewjoin.q failure Diffs (updated) - ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveMultiJoin.java 660f01d ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveInsertExchange4JoinRule.java d6e3915 ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinToMultiJoinRule.java 5d169a1 Diff: https://reviews.apache.org/r/42359/diff/ Testing --- Clean precommit Thanks, Hari Sankar Sivarama Subramaniyan
[jira] [Created] (HIVE-12923) CBO: Calcite Operator To Hive Operator (Calcite Return Path): TestCliDriver groupby_grouping_sets4.q failure
Hari Sankar Sivarama Subramaniyan created HIVE-12923:
Summary: CBO: Calcite Operator To Hive Operator (Calcite Return
Path): TestCliDriver groupby_grouping_sets4.q failure
Key: HIVE-12923
URL: https://issues.apache.org/jira/browse/HIVE-12923
Project: Hive
Issue Type: Sub-task
Reporter: Hari Sankar Sivarama Subramaniyan
Assignee: Hari Sankar Sivarama Subramaniyan
{code}
EXPLAIN
SELECT * FROM
(SELECT a, b, count(*) from T1 where a < 3 group by a, b with cube) subq1
join
(SELECT a, b, count(*) from T1 where a < 3 group by a, b with cube) subq2
on subq1.a = subq2.a
{code}
Stack trace:
{code}
java.lang.NullPointerException
at
org.apache.hadoop.hive.ql.optimizer.ColumnPrunerProcFactory.pruneJoinOperator(ColumnPrunerProcFactory.java:1110)
at
org.apache.hadoop.hive.ql.optimizer.ColumnPrunerProcFactory.access$400(ColumnPrunerProcFactory.java:85)
at
org.apache.hadoop.hive.ql.optimizer.ColumnPrunerProcFactory$ColumnPrunerJoinProc.process(ColumnPrunerProcFactory.java:941)
at
org.apache.hadoop.hive.ql.lib.DefaultRuleDispatcher.dispatch(DefaultRuleDispatcher.java:90)
at
org.apache.hadoop.hive.ql.lib.DefaultGraphWalker.dispatchAndReturn(DefaultGraphWalker.java:105)
at
org.apache.hadoop.hive.ql.lib.DefaultGraphWalker.dispatch(DefaultGraphWalker.java:89)
at
org.apache.hadoop.hive.ql.optimizer.ColumnPruner$ColumnPrunerWalker.walk(ColumnPruner.java:172)
at
org.apache.hadoop.hive.ql.lib.DefaultGraphWalker.startWalking(DefaultGraphWalker.java:120)
at
org.apache.hadoop.hive.ql.optimizer.ColumnPruner.transform(ColumnPruner.java:135)
at
org.apache.hadoop.hive.ql.optimizer.Optimizer.optimize(Optimizer.java:237)
at
org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.analyzeInternal(SemanticAnalyzer.java:10176)
at
org.apache.hadoop.hive.ql.parse.CalcitePlanner.analyzeInternal(CalcitePlanner.java:229)
at
org.apache.hadoop.hive.ql.parse.BaseSemanticAnalyzer.analyze(BaseSemanticAnalyzer.java:239)
at
org.apache.hadoop.hive.ql.parse.ExplainSemanticAnalyzer.analyzeInternal(ExplainSemanticAnalyzer.java:74)
at
org.apache.hadoop.hive.ql.parse.BaseSemanticAnalyzer.analyze(BaseSemanticAnalyzer.java:239)
at org.apache.hadoop.hive.ql.Driver.compile(Driver.java:472)
at org.apache.hadoop.hive.ql.Driver.compile(Driver.java:312)
at org.apache.hadoop.hive.ql.Driver.compileInternal(Driver.java:1168)
at org.apache.hadoop.hive.ql.Driver.runInternal(Driver.java:1256)
at org.apache.hadoop.hive.ql.Driver.run(Driver.java:1094)
at org.apache.hadoop.hive.ql.Driver.run(Driver.java:1082)
at
org.apache.hadoop.hive.cli.CliDriver.processLocalCmd(CliDriver.java:233)
at org.apache.hadoop.hive.cli.CliDriver.processCmd(CliDriver.java:184)
at org.apache.hadoop.hive.cli.CliDriver.processLine(CliDriver.java:400)
at org.apache.hadoop.hive.cli.CliDriver.processLine(CliDriver.java:336)
at
org.apache.hadoop.hive.ql.QTestUtil.executeClientInternal(QTestUtil.java:1129)
at
org.apache.hadoop.hive.ql.QTestUtil.executeClient(QTestUtil.java:1103)
at
org.apache.hadoop.hive.cli.TestCliDriver.runTest(TestCliDriver.java:10444)
at
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_groupby_grouping_sets4(TestCliDriver.java:3313)
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (HIVE-12924) CBO: Calcite Operator To Hive Operator (Calcite Return Path): TestCliDriver groupby_ppr_multi_distinct.q failure
Hari Sankar Sivarama Subramaniyan created HIVE-12924:
Summary: CBO: Calcite Operator To Hive Operator (Calcite Return
Path): TestCliDriver groupby_ppr_multi_distinct.q failure
Key: HIVE-12924
URL: https://issues.apache.org/jira/browse/HIVE-12924
Project: Hive
Issue Type: Sub-task
Reporter: Hari Sankar Sivarama Subramaniyan
Assignee: Hari Sankar Sivarama Subramaniyan
{code}
EXPLAIN EXTENDED
FROM srcpart src
INSERT OVERWRITE TABLE dest1
SELECT substr(src.key,1,1), count(DISTINCT substr(src.value,5)),
concat(substr(src.key,1,1),sum(substr(src.value,5))), sum(DISTINCT
substr(src.value, 5)), count(DISTINCT src.value)
WHERE src.ds = '2008-04-08'
GROUP BY substr(src.key,1,1)
{code}
Stack trace:
{code}
2016-01-25T14:27:56,694 DEBUG [4e6a139e-a78c-4f61-bb10-57af2b0d4381 main[]]:
parse.TypeCheckCtx (TypeCheckCtx.java:setError(159)) - Setting error: [Line
6:79 Expression not in GROUP BY key 'key'] from (tok_table_or_col src)
java.lang.Exception
at
org.apache.hadoop.hive.ql.parse.TypeCheckCtx.setError(TypeCheckCtx.java:159)
[hive-exec-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
at
org.apache.hadoop.hive.ql.parse.TypeCheckProcFactory$ColumnExprProcessor.process(TypeCheckProcFactory.java:628)
[hive-exec-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
at
org.apache.hadoop.hive.ql.lib.DefaultRuleDispatcher.dispatch(DefaultRuleDispatcher.java:90)
[hive-exec-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
at
org.apache.hadoop.hive.ql.lib.DefaultGraphWalker.dispatchAndReturn(DefaultGraphWalker.java:105)
[hive-exec-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
at
org.apache.hadoop.hive.ql.lib.DefaultGraphWalker.dispatch(DefaultGraphWalker.java:89)
[hive-exec-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
at
org.apache.hadoop.hive.ql.lib.DefaultGraphWalker.walk(DefaultGraphWalker.java:158)
[hive-exec-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
at
org.apache.hadoop.hive.ql.lib.DefaultGraphWalker.startWalking(DefaultGraphWalker.java:120)
[hive-exec-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
at
org.apache.hadoop.hive.ql.parse.TypeCheckProcFactory.genExprNode(TypeCheckProcFactory.java:213)
[hive-exec-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
at
org.apache.hadoop.hive.ql.parse.TypeCheckProcFactory.genExprNode(TypeCheckProcFactory.java:157)
[hive-exec-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
at
org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.genAllExprNodeDesc(SemanticAnalyzer.java:10512)
[hive-exec-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
at
org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.genExprNodeDesc(SemanticAnalyzer.java:10468)
[hive-exec-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
at
org.apache.hadoop.hive.ql.parse.CalcitePlanner$CalcitePlannerAction.genSelectLogicalPlan(CalcitePlanner.java:2920)
[hive-exec-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
at
org.apache.hadoop.hive.ql.parse.CalcitePlanner$CalcitePlannerAction.genLogicalPlan(CalcitePlanner.java:3053)
[hive-exec-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
at
org.apache.hadoop.hive.ql.parse.CalcitePlanner$CalcitePlannerAction.apply(CalcitePlanner.java:874)
[hive-exec-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
at
org.apache.hadoop.hive.ql.parse.CalcitePlanner$CalcitePlannerAction.apply(CalcitePlanner.java:832)
[hive-exec-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
at org.apache.calcite.tools.Frameworks$1.apply(Frameworks.java:112)
[calcite-core-1.5.0.jar:1.5.0]
at
org.apache.calcite.prepare.CalcitePrepareImpl.perform(CalcitePrepareImpl.java:971)
[calcite-core-1.5.0.jar:1.5.0]
at org.apache.calcite.tools.Frameworks.withPrepare(Frameworks.java:148)
[calcite-core-1.5.0.jar:1.5.0]
at org.apache.calcite.tools.Frameworks.withPlanner(Frameworks.java:105)
[calcite-core-1.5.0.jar:1.5.0]
at
org.apache.hadoop.hive.ql.parse.CalcitePlanner.getOptimizedHiveOPDag(CalcitePlanner.java:677)
[hive-exec-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
at
org.apache.hadoop.hive.ql.parse.CalcitePlanner.genOPTree(CalcitePlanner.java:264)
[hive-exec-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
at
org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.analyzeInternal(SemanticAnalyzer.java:10100)
[hive-exec-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
at
org.apache.hadoop.hive.ql.parse.CalcitePlanner.analyzeInternal(CalcitePlanner.java:229)
[hive-exec-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
at
org.apache.hadoop.hive.ql.parse.BaseSemanticAnalyzer.analyze(BaseSemanticAnalyzer.java:239)
[hive-exec-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
at
org.apache.hadoop.hive.ql.parse.ExplainSemanticAnalyzer.analyzeInternal(ExplainSemanticAnalyzer.java:74)
[hive-exec-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
at
org.apache.hadoop.hive.ql.parse.BaseSemanticAnalyzer.analyze(BaseSemanticAnalyzer.java:239)
[hive-exec-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT
Re: Review Request 42521: HIVE-12867 : Semantic Exception Error Msg should be with in the range of "10000 to 19999"
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42521/ --- (Updated Jan. 21, 2016, 11:08 p.m.) Review request for hive and John Pullokkaran. Repository: hive-git Description --- Semantic Exception Error Msg should be with in the range of "1 to 1" Diffs (updated) - ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java 6a62592 ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 8a9411a ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 141c2e6 ql/src/java/org/apache/hadoop/hive/ql/parse/EximUtil.java 179f9c2 ql/src/java/org/apache/hadoop/hive/ql/parse/ExportSemanticAnalyzer.java ff385d0 ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java 88c4b95 ql/src/java/org/apache/hadoop/hive/ql/parse/TaskCompiler.java a8f9f50 ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableDesc.java 3f38f74 Diff: https://reviews.apache.org/r/42521/diff/ Testing --- Precommit build runs Thanks, Hari Sankar Sivarama Subramaniyan
Review Request 42626: CBO: Calcite Operator To Hive Operator (Calcite Return Path): MiniTezCliDriver.vector_join_filters.q failure
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42626/ --- Review request for hive, Jesús Camacho Rodríguez and John Pullokkaran. Repository: hive-git Description --- Please see the jira. Diffs - ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveRelFieldTrimmer.java f677f68 Diff: https://reviews.apache.org/r/42626/diff/ Testing --- Precommit runs Thanks, Hari Sankar Sivarama Subramaniyan
Re: Review Request 42626: CBO: Calcite Operator To Hive Operator (Calcite Return Path): MiniTezCliDriver.vector_join_filters.q failure
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42626/ --- (Updated Jan. 22, 2016, 12:27 a.m.) Review request for hive, Jesús Camacho Rodríguez and John Pullokkaran. Repository: hive-git Description (updated) --- Please see the jira https://issues.apache.org/jira/browse/HIVE-12802 Diffs - ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveRelFieldTrimmer.java f677f68 Diff: https://reviews.apache.org/r/42626/diff/ Testing --- Precommit runs Thanks, Hari Sankar Sivarama Subramaniyan
