----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48520/#review137089 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMetaStoreChecker.java (line 379) <https://reviews.apache.org/r/48520/#comment202253> Yes, it is a nit. I meant the getAllLeafDirs(.., final SynchronizedSet<Path> allDirs, ...). It is fine with the way it is since it is a private fn and used only at one place, but if someone is to make this public in future for some reason, it could be misused. - Hari Sankar Sivarama Subramaniyan On June 10, 2016, 11:58 p.m., pengcheng xiong wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48520/ > ----------------------------------------------------------- > > (Updated June 10, 2016, 11:58 p.m.) > > > Review request for hive and Hari Sankar Sivarama Subramaniyan. > > > Repository: hive-git > > > Description > ------- > > HIVE-13984 > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 285caa3 > ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMetaStoreChecker.java > 10fa561 > > Diff: https://reviews.apache.org/r/48520/diff/ > > > Testing > ------- > > > Thanks, > > pengcheng xiong > >
