Re: [RESULT] [VOTE] Release httpd-2.4.32

[William A Rowe Jr]

That still leaves the headache of fallback-to-release when a candidate on
these many projects isn't present (actually, the smart election between
candidate and release if both exist!) But great pointer, TY!

On Mar 15, 2018 21:46, "Jan Ehrhardt"  wrote:

> William A Rowe Jr in gmane.comp.apache.devel (Thu, 15 Mar 2018 16:11:10
> -0500):
> >https://github.com/appsuite/oss-httpd-build is where this all lives, and
> is
> >where the localized PERL5LIB schema for all the components will land.
> >This can be further streamlined, and the really big caveat is that the
> gather
> >phase requires bash on Windows (SFU makes this trivial.)
>
> bash is standard installed on Appveyor images, as part of Windows GIT.
> See
> https://github.com/ImageMagick/ImageMagick-Windows/blob/master/
> CloneRepositories.cmd#L12
>
> This just executes
> https://github.com/ImageMagick/ImageMagick-Windows/blob/master/
> CloneRepositories.sh
> --
> Jan
>
>

Re: [RESULT] [VOTE] Release httpd-2.4.32

[Jan Ehrhardt]

William A Rowe Jr in gmane.comp.apache.devel (Thu, 15 Mar 2018 16:11:10
-0500):
>https://github.com/appsuite/oss-httpd-build is where this all lives, and is
>where the localized PERL5LIB schema for all the components will land.
>This can be further streamlined, and the really big caveat is that the gather
>phase requires bash on Windows (SFU makes this trivial.)

bash is standard installed on Appveyor images, as part of Windows GIT.
See
https://github.com/ImageMagick/ImageMagick-Windows/blob/master/CloneRepositories.cmd#L12

This just executes
https://github.com/ImageMagick/ImageMagick-Windows/blob/master/CloneRepositories.sh
-- 
Jan

Re: [RESULT] [VOTE] Release httpd-2.4.32

[William A Rowe Jr]

On Thu, Mar 15, 2018 at 4:43 PM, Yann Ylavic  wrote:
> On Thu, Mar 15, 2018 at 10:39 PM, William A Rowe Jr  
> wrote:
>> On Thu, Mar 15, 2018 at 4:28 PM, Eric Covener  wrote:
 This looks sensible, or do we say that users of mod_proxy_balancer
 on Windows should defer their upgrade? A more limited audience?
>>>
>>> +1
>>
>> Should we also mention the regression against mod_security on Windows?
>> (Nobody can reproduce on Unix, correct?)
>
> This is not a regression, always been there (or almost) in 2.4.x.

Thanks for clarifying (not worthy of mention then)

>> What about the mod_md pegged infinite retry problem that was raised
>> a month or two back, particularly evident on Windows? Is the fact that
>> the module is experimental enough to evade mention in Announcement?
>
> We don't have much details on it yet, configuration issue?

I think we were waiting on json data, or Stefan has an inkling of how
we received  negative delta now.

Re: [RESULT] [VOTE] Release httpd-2.4.32

[Yann Ylavic]

On Thu, Mar 15, 2018 at 10:39 PM, William A Rowe Jr  wrote:
> On Thu, Mar 15, 2018 at 4:28 PM, Eric Covener  wrote:
>>> This looks sensible, or do we say that users of mod_proxy_balancer
>>> on Windows should defer their upgrade? A more limited audience?
>>
>> +1
>
> Should we also mention the regression against mod_security on Windows?
> (Nobody can reproduce on Unix, correct?)

This is not a regression, always been there (or almost) in 2.4.x.

>
> What about the mod_md pegged infinite retry problem that was raised
> a month or two back, particularly evident on Windows? Is the fact that
> the module is experimental enough to evade mention in Announcement?

We don't have much details on it yet, configuration issue?

Re: [RESULT] [VOTE] Release httpd-2.4.32

[William A Rowe Jr]

On Thu, Mar 15, 2018 at 4:28 PM, Eric Covener  wrote:
>> This looks sensible, or do we say that users of mod_proxy_balancer
>> on Windows should defer their upgrade? A more limited audience?
>
> +1

Should we also mention the regression against mod_security on Windows?
(Nobody can reproduce on Unix, correct?)

What about the mod_md pegged infinite retry problem that was raised
a month or two back, particularly evident on Windows? Is the fact that
the module is experimental enough to evade mention in Announcement?

RE: [RESULT] [VOTE] Release httpd-2.4.32

[Daniel Ruggeri]

> -Original Message-
> From: William A Rowe Jr 
> Sent: Thursday, March 15, 2018 4:28 PM
> To: httpd 
> Subject: Re: [RESULT] [VOTE] Release httpd-2.4.32
> 
> On Thu, Mar 15, 2018 at 4:19 PM, Daniel Ruggeri 
> wrote:
> >
> > *** Changes here
> >We consider this release to be the best version of Apache available for
> >non-Windows platforms, and encourage users of all prior versions to
> upgrade.
> >
> >Please note, a bug after shipping this release was discovered that
> prevents
> >the server from starting on Windows when mod_proxy_balancer is used.
> >This manifests in error message "AH01179: balancer slotmem_create
> failed."
> >Windows users are encouraged to postpone upgrades until the soon-to-
> be-available
> >2.4.33+ release is made.
> > *** End Changes
> 
> This looks sensible, or do we say that users of mod_proxy_balancer
> on Windows should defer their upgrade? A more limited audience?
> 
 
Yes, definitely. Thanks for the pointer.

> >Please note that while the Apache HTTP Server Project may publish some
> >security patches to the 2.2.x flavor through at least December of 2017,
> >no further maintenance patches of 2.2.x will be considered and no further
> >releases will be distributed. The 2.2.x branch has now reached the end of
> >its maintenance, and users are strongly encouraged to promptly complete
> >their transitions to this 2.4.x flavor of httpd to benefit from security
> >and bug fixes, as well as new features.
> 
> This is not current, see /repos/dist/dev/httpd/ for the current
> Announcement
> text draft, please.

Right. I'll use that one.

-- 
Daniel Ruggeri

Re: [RESULT] [VOTE] Release httpd-2.4.32

[Eric Covener]

> This looks sensible, or do we say that users of mod_proxy_balancer
> on Windows should defer their upgrade? A more limited audience?

+1

Re: [RESULT] [VOTE] Release httpd-2.4.32

[William A Rowe Jr]

On Thu, Mar 15, 2018 at 4:19 PM, Daniel Ruggeri  wrote:
>
> *** Changes here
>We consider this release to be the best version of Apache available for
>non-Windows platforms, and encourage users of all prior versions to 
> upgrade.
>
>Please note, a bug after shipping this release was discovered that prevents
>the server from starting on Windows when mod_proxy_balancer is used.
>This manifests in error message "AH01179: balancer slotmem_create failed."
>Windows users are encouraged to postpone upgrades until the 
> soon-to-be-available
>2.4.33+ release is made.
> *** End Changes

This looks sensible, or do we say that users of mod_proxy_balancer
on Windows should defer their upgrade? A more limited audience?

>Please note that while the Apache HTTP Server Project may publish some
>security patches to the 2.2.x flavor through at least December of 2017,
>no further maintenance patches of 2.2.x will be considered and no further
>releases will be distributed. The 2.2.x branch has now reached the end of
>its maintenance, and users are strongly encouraged to promptly complete
>their transitions to this 2.4.x flavor of httpd to benefit from security
>and bug fixes, as well as new features.

This is not current, see /repos/dist/dev/httpd/ for the current Announcement
text draft, please.

RE: [RESULT] [VOTE] Release httpd-2.4.32

[Daniel Ruggeri]

> -Original Message-
> From: Rainer Jung 
> Sent: Thursday, March 15, 2018 12:09 PM
> To: dev@httpd.apache.org
> Subject: Re: [RESULT] [VOTE] Release httpd-2.4.32
> 
> Am 15.03.2018 um 17:34 schrieb Yann Ylavic:
> > On Thu, Mar 15, 2018 at 5:20 PM, Daniel Ruggeri 
> wrote:
> >>
> >> Personally, I would like to see *another* T (again, I volunteer and will
> >> see it through quickly) and no mention of this release be made public via
> >> ANNOUNCE.
> >> Thoughts?
> >
> > I think we should complete this release, with a warning somewhere for
> > mod_proxy_lb users on Windows. It's mirrored already.
> > Then we can provide 2.4.33 shortly.
> 
> +1 and s/mod_proxy_lb/mod_proxy_balancer/
> 
> Rainer

Agreed - once the mirrors have it... it's in the wild. I've been occupied the 
past few hours and have been mulling over this. WDYT about this verbiage? I'm 
poised and ready to send this and will do so in the next few hours if no 
additional feedback is given.



Apache HTTP Server 2.4.32 Released

   March 15, 2018

   The Apache Software Foundation and the Apache HTTP Server Project
   are pleased to announce the release of version 2.4.32 of the Apache
   HTTP Server ("Apache").  This version of Apache is our latest GA
   release of the new generation 2.4.x branch of Apache HTTPD and
   represents fifteen years of innovation by the project, and is
   recommended over all previous releases. This release of Apache is
   a security, feature, and bug fix release.

*** Changes here
   We consider this release to be the best version of Apache available for 
   non-Windows platforms, and encourage users of all prior versions to upgrade.
   
   Please note, a bug after shipping this release was discovered that prevents
   the server from starting on Windows when mod_proxy_balancer is used.
   This manifests in error message "AH01179: balancer slotmem_create failed."
   Windows users are encouraged to postpone upgrades until the 
soon-to-be-available
   2.4.33+ release is made.
*** End Changes

   Apache HTTP Server 2.4.32 is available for download from:

 http://httpd.apache.org/download.cgi

   Apache 2.4 offers numerous enhancements, improvements, and performance
   boosts over the 2.2 codebase.  For an overview of new features
   introduced since 2.4 please see:

 http://httpd.apache.org/docs/trunk/new_features_2_4.html

   Please see the CHANGES_2.4 file, linked from the download page, for a
   full list of changes. A condensed list, CHANGES_2.4.32 includes only
   those changes introduced since the prior 2.4 release.  A summary of all 
   of the security vulnerabilities addressed in this and earlier releases 
   is available:

 http://httpd.apache.org/security/vulnerabilities_24.html

   This release requires the Apache Portable Runtime (APR), minimum
   version 1.5.x, and APR-Util, minimum version 1.5.x. Some features may
   require the 1.6.x version of both APR and APR-Util. The APR libraries
   must be upgraded for all features of httpd to operate correctly.

   This release builds on and extends the Apache 2.2 API.  Modules written
   for Apache 2.2 will need to be recompiled in order to run with Apache
   2.4, and require minimal or no source code changes.

 http://svn.apache.org/repos/asf/httpd/httpd/trunk/VERSIONING

   When upgrading or installing this version of Apache, please bear in mind
   that if you intend to use Apache with one of the threaded MPMs (other
   than the Prefork MPM), you must ensure that any modules you will be
   using (and the libraries they depend on) are thread-safe.

   Please note that while the Apache HTTP Server Project may publish some
   security patches to the 2.2.x flavor through at least December of 2017,
   no further maintenance patches of 2.2.x will be considered and no further
   releases will be distributed. The 2.2.x branch has now reached the end of
   its maintenance, and users are strongly encouraged to promptly complete
   their transitions to this 2.4.x flavor of httpd to benefit from security
   and bug fixes, as well as new features.

-- 
Daniel Ruggeri

Re: [RESULT] [VOTE] Release httpd-2.4.32

[William A Rowe Jr]

On Thu, Mar 15, 2018 at 3:59 PM, Jan Ehrhardt  wrote:
> William A Rowe Jr in gmane.comp.apache.devel (Thu, 15 Mar 2018 13:52:48
> -0500):
>>The largest headache is provisioning the entire suite of non-default perl
>>modules required. Running the framework is trivial. I've been working on
>>some workaround to this for unix and windows for "stock" test boxes.
>
> Any chance to make this publicly available? To give you an idea,
> ImageMagick does a fairly standard Perl install on Appveyor:
> https://github.com/ImageMagick/ImageMagick-Windows/blob/master/AppVeyor/Install.cmd#L37
> They are downloading
> https://github.com/ImageMagick/ImageMagick-Windows/releases/download/20160630/strawberry-perl-5.20.1.1-64bit.msi

Yes, but the perl logic isn't done yet. Even the OpenSSL project refused
to support RedHat/CentOS without perl-core extensions installed (or alert
to their absence.) Seems perl test logic authors are traditionally and
continuously obtuse to their test suites' pain points.

https://github.com/appsuite/oss-httpd-build is where this all lives, and is
where the localized PERL5LIB schema for all the components will land.
This can be further streamlined, and the really big caveat is that the gather
phase requires bash on Windows (SFU makes this trivial.) I've given up on
extending makefile syntax, and looking at a python (or perl) script to deal
with both the Windows native checkout, and conditional BLD=candidate
flavor, because various bits will or will not have a pending release when
combining those packages, and that's something nmake, and even gmake
won't support trivially.

Re: [RESULT] [VOTE] Release httpd-2.4.32

[Jan Ehrhardt]

William A Rowe Jr in gmane.comp.apache.devel (Thu, 15 Mar 2018 13:52:48
-0500):
>The largest headache is provisioning the entire suite of non-default perl
>modules required. Running the framework is trivial. I've been working on
>some workaround to this for unix and windows for "stock" test boxes.

Any chance to make this publicly available? To give you an idea,
ImageMagick does a fairly standard Perl install on Appveyor:
https://github.com/ImageMagick/ImageMagick-Windows/blob/master/AppVeyor/Install.cmd#L37
They are downloading
https://github.com/ImageMagick/ImageMagick-Windows/releases/download/20160630/strawberry-perl-5.20.1.1-64bit.msi

And install it, using chocolatey
https://github.com/ImageMagick/ImageMagick-Windows/blob/master/AppVeyor/Install-StrawberryPerl-x64.ps1#L1

Could something like this be extended to install the non-standard
modules as well? If this is not possible using the msi-installer, would
a self-extracting exe be another way?

>With that resolved, just about anyone in the windows community should
>easily build and test when they will, against release, candidate, snapshot
>or bleed.
-- 
Jan

Re: [RESULT] [VOTE] Release httpd-2.4.32

[Jan Ehrhardt]

Rainer Jung in gmane.comp.apache.devel (Thu, 15 Mar 2018 18:15:13
+0100):
>The artefacts are on the mirrors and out in the wild, so we can not get 
>them back. Best is to soon proceed with the release and document the 
>mod_proxy_balancer on Windows regression in the announcement.

+1

>About "not catching ahead of time": it would be great, if at least one 
>of us had a Windows system with the ability to run the test suite.

Something that crosses my mind from time to time: appveyor.com is free
for open source projects. PHP uses it for running the test suite:
https://ci.appveyor.com/project/php/php-src/build/master.build.6478/job/ios1a5p0vjuqkmik#L5609

Libexpat does the same:
https://ci.appveyor.com/project/libexpat/libexpat/build/libexpat-131
In these test they are building Debug\expatd.dll and running the tests
in Debug mode, but with some adjustments a static release\expat.lib can
also be built:
https://ci.appveyor.com/project/Jan-E/libexpat/build/libexpat-10/job/e98ai0uf5wu5vmde#L269

Complex projects with a lot of dependencies are no problem as well. See
for instance the build log of ImageMagick for Windows:
https://ci.appveyor.com/project/Jan-E/imagemagick-windows/build/job/ef3gvikn64m6ddoo?fullLog=true

In theory, httpd and all of its dependencies could be built as well on a
Appveyor virtual Windows machine. I do not have the time to do that
right now, but if anyone feels inclined...
-- 
Jan

Re: [RESULT] [VOTE] Release httpd-2.4.32

[William A Rowe Jr]

On Thu, Mar 15, 2018 at 12:15 PM, Rainer Jung  wrote:
> Am 15.03.2018 um 18:09 schrieb Eric Covener:
>>
>> On Thu, Mar 15, 2018 at 12:54 PM, Jan Ehrhardt  wrote:
>>>
>>> Eric Covener in gmane.comp.apache.devel (Thu, 15 Mar 2018 12:35:38
>>> -0400):

 +1, probably the least confusing, and Windows users aren't
 quickly/casually picking up source releases.
>>>
>>>
>>> Hmm. 2.4.32 coincided with the monthly Windows Update and with a curl
>>> release. I upgraded everything yesterday...
>>
>>
>> Sorry -- I should have said "most/typical" Windows users.
>>
>> The question now is about the pro/con of completely finalizing the
>> 2.4.32 release or not -- either way even your upgrade already
>> happened.
>>
>> Of course not catching the regression ahead of time is unfortunate.
>
>
> The artefacts are on the mirrors and out in the wild, so we can not get them
> back. Best is to soon proceed with the release and document the
> mod_proxy_balancer on Windows regression in the announcement. At least the
> symptoms described here are failure during start, so the bug does not
> produce vague or rare symptoms. Any one updating and being hit by the bug
> will notice immediately.

+1 (actually, no choice to continue to "publish"; the announcement could be
held back if we were rolling and voting up a 2.4.33 release right now, but we
do not "withdraw" a published (mirrored) release.

> We can also add the patch to
> http://www.apache.org/dist/httpd/patches/apply_to_2.4.32/ once it is done,
> just in case a 2.4.33 takes a little longer for reasons not yet known.

+1

> About "not catching ahead of time": it would be great, if at least one of us
> had a Windows system with the ability to run the test suite.

The largest headache is provisioning the entire suite of non-default perl
modules required. Running the framework is trivial. I've been working on
some workaround to this for unix and windows for "stock" test boxes.
With that resolved, just about anyone in the windows community should
easily build and test when they will, against release, candidate, snapshot
or bleed.

Re: [RESULT] [VOTE] Release httpd-2.4.32

[Christophe Jaillet]

Le 15/03/2018 à 17:34, Yann Ylavic a écrit :

On Thu, Mar 15, 2018 at 5:20 PM, Daniel Ruggeri  wrote:


Personally, I would like to see *another* T (again, I volunteer and will
see it through quickly) and no mention of this release be made public via
ANNOUNCE.
Thoughts?


I think we should complete this release, with a warning somewhere for
mod_proxy_lb users on Windows. It's mirrored already.
Then we can provide 2.4.33 shortly.


Regards,
Yann.



+1 as well for me.
It's unfortunate but the release has been voted and is in the wild now.
The best is to mitigate the announce as proposed by Yann and release a 
2.4.n+1 ASAP.


CJ

Re: svn commit: r1826279 - /httpd/httpd/branches/2.4.x/STATUS

[Luca Toscano]

Hi Yann,

2018-03-08 23:05 GMT+01:00 Yann Ylavic :

> On Thu, Mar 8, 2018 at 11:00 PM,   wrote:
> >
> >*) mod_access_compat, mod_authz_host: Prevent access control
> misconfiguration
> >   due to interpretation of #comments in Require host or Allow/Deny
> directives.
> >   trunk patch: http://svn.apache.org/r1667676
> >http://svn.apache.org/r1826207
> >   2.4.x patch: trunk works, svn merge -c 1667676,1826207
> ^/httpd/httpd/trunk .
> > - +1: jorton,  jim,
> > + +1: jorton, jim, ylavic
>
> This one possibly/later could be addressed at
> ap_getword_conf[_nocomment)() level, many/most directives should stop
> on #comments no?
>

+1, I just came across:

~/httpd-trunk$ sudo /usr/local/apache2/bin/apachectl -S
VirtualHost configuration:
*:80   is a NameVirtualHost
 default server test1.com (/usr/local/apache2/conf/httpd.conf:186)
 port 80 namevhost test1.com
(/usr/local/apache2/conf/httpd.conf:186)
 alias test2.com
 alias #This
 alias is
 alias a
 alias comment

Generated by:

ServerAlias test2.com #This is a comment

Luca

Re: mod_proxy_balancer doesn't work with 2.4.32

[Rainer Jung]

Am 15.03.2018 um 18:25 schrieb lucas29252:

Steffen sent me the patched module and it works!


Same here.

Regards,

Rainer

Re: mod_proxy_balancer doesn't work with 2.4.32

[Eric Covener]

On Thu, Mar 15, 2018 at 1:25 PM, lucas29252  wrote:
> Steffen sent me the patched module and it works!

Thanks Steffen and Lucas!

(and Yann)

Re: mod_proxy_balancer doesn't work with 2.4.32

[lucas29252]

Steffen sent me the patched module and it works!



--
Sent from: 
http://apache-http-server.18135.x6.nabble.com/Apache-HTTP-Server-Dev-f4771363.html

Re: [RESULT] [VOTE] Release httpd-2.4.32

[Rainer Jung]

Am 15.03.2018 um 18:09 schrieb Eric Covener:

On Thu, Mar 15, 2018 at 12:54 PM, Jan Ehrhardt  wrote:

Eric Covener in gmane.comp.apache.devel (Thu, 15 Mar 2018 12:35:38
-0400):

+1, probably the least confusing, and Windows users aren't
quickly/casually picking up source releases.


Hmm. 2.4.32 coincided with the monthly Windows Update and with a curl
release. I upgraded everything yesterday...


Sorry -- I should have said "most/typical" Windows users.

The question now is about the pro/con of completely finalizing the
2.4.32 release or not -- either way even your upgrade already
happened.

Of course not catching the regression ahead of time is unfortunate.


The artefacts are on the mirrors and out in the wild, so we can not get 
them back. Best is to soon proceed with the release and document the 
mod_proxy_balancer on Windows regression in the announcement. At least 
the symptoms described here are failure during start, so the bug does 
not produce vague or rare symptoms. Any one updating and being hit by 
the bug will notice immediately.


We can also add the patch to 
http://www.apache.org/dist/httpd/patches/apply_to_2.4.32/ once it is 
done, just in case a 2.4.33 takes a little longer for reasons not yet known.


About "not catching ahead of time": it would be great, if at least one 
of us had a Windows system with the ability to run the test suite.


Regards,

Rainer

Re: mod_proxy_balancer doesn't work with 2.4.32

[Yann Ylavic]

On Thu, Mar 15, 2018 at 6:07 PM, Rainer Jung  wrote:
> Am 15.03.2018 um 16:48 schrieb Yann Ylavic:
>>
>> On Thu, Mar 15, 2018 at 3:20 PM, Rainer Jung 
>> wrote:
>> Index: modules/slotmem/mod_slotmem_shm.c
>> ===
>> --- modules/slotmem/mod_slotmem_shm.c   (revision 1826753)
>> +++ modules/slotmem/mod_slotmem_shm.c   (working copy)
>> @@ -447,9 +466,9 @@ static apr_status_t slotmem_create(ap_slotmem_inst
>>  }
>>  ap_log_error(APLOG_MARK, rv == APR_SUCCESS ? APLOG_DEBUG :
>> APLOG_ERR,
>>   rv, ap_server_conf, APLOGNO(02611)
>> - "create: apr_shm_create(%s) %s",
>> - fname ? fname : "",
>> - rv == APR_SUCCESS ? "succeeded" : "failed");
>> + "create: apr_shm_%s(%s) %s",
>> + fbased && is_child_process() ? "attach" : "create",
>> + fname, rv == APR_SUCCESS ? "succeeded" : "failed");
>>  if (rv != APR_SUCCESS) {
>>  return rv;
>>  }
>
>
> Removing the fname null check was intentional?

Can't happen, either fbased (this fname != NULL), or fname is set to
"none" above.

Thanks,
Yann.

Re: [RESULT] [VOTE] Release httpd-2.4.32

[Rainer Jung]

Am 15.03.2018 um 17:34 schrieb Yann Ylavic:

On Thu, Mar 15, 2018 at 5:20 PM, Daniel Ruggeri  wrote:


Personally, I would like to see *another* T (again, I volunteer and will
see it through quickly) and no mention of this release be made public via
ANNOUNCE.
Thoughts?


I think we should complete this release, with a warning somewhere for
mod_proxy_lb users on Windows. It's mirrored already.
Then we can provide 2.4.33 shortly.


+1 and s/mod_proxy_lb/mod_proxy_balancer/

Rainer

Re: [RESULT] [VOTE] Release httpd-2.4.32

[Eric Covener]

On Thu, Mar 15, 2018 at 12:54 PM, Jan Ehrhardt  wrote:
> Eric Covener in gmane.comp.apache.devel (Thu, 15 Mar 2018 12:35:38
> -0400):
>>+1, probably the least confusing, and Windows users aren't
>>quickly/casually picking up source releases.
>
> Hmm. 2.4.32 coincided with the monthly Windows Update and with a curl
> release. I upgraded everything yesterday...

Sorry -- I should have said "most/typical" Windows users.

The question now is about the pro/con of completely finalizing the
2.4.32 release or not -- either way even your upgrade already
happened.

Of course not catching the regression ahead of time is unfortunate.

Re: mod_proxy_balancer doesn't work with 2.4.32

[Rainer Jung]

Am 15.03.2018 um 16:48 schrieb Yann Ylavic:

On Thu, Mar 15, 2018 at 3:20 PM, Rainer Jung  wrote:
Index: modules/slotmem/mod_slotmem_shm.c
===
--- modules/slotmem/mod_slotmem_shm.c   (revision 1826753)
+++ modules/slotmem/mod_slotmem_shm.c   (working copy)
@@ -447,9 +466,9 @@ static apr_status_t slotmem_create(ap_slotmem_inst
 }
 ap_log_error(APLOG_MARK, rv == APR_SUCCESS ? APLOG_DEBUG : APLOG_ERR,
  rv, ap_server_conf, APLOGNO(02611)
- "create: apr_shm_create(%s) %s",
- fname ? fname : "",
- rv == APR_SUCCESS ? "succeeded" : "failed");
+ "create: apr_shm_%s(%s) %s",
+ fbased && is_child_process() ? "attach" : "create",
+ fname, rv == APR_SUCCESS ? "succeeded" : "failed");
 if (rv != APR_SUCCESS) {
 return rv;
 }


Removing the fname null check was intentional?

Probably, just want to make sure.

Thanks as always,

Rainer

Re: mod_proxy_balancer doesn't work with 2.4.32

[Rainer Jung]

Am 15.03.2018 um 16:48 schrieb Yann Ylavic:

On Thu, Mar 15, 2018 at 3:20 PM, Rainer Jung  wrote:


For the sake of completeness, here are the full trace8 (failed) startup logs
for this reproduction scenario:


Thanks Rainer!

Could you (or Steffen, or Lucas) try the attached patch? It's based on
2.4.x, but should work for trunk too..


I currently do not have a quick way to do builds on Windows, but if 
Steffen could provide a build including your patch I could easily redo 
the described test.


Regards,

Rainer

Re: [RESULT] [VOTE] Release httpd-2.4.32

[Yann Ylavic]

On Thu, Mar 15, 2018 at 5:54 PM, Jan Ehrhardt  wrote:
> Eric Covener in gmane.comp.apache.devel (Thu, 15 Mar 2018 12:35:38
> -0400):
>>+1, probably the least confusing, and Windows users aren't
>>quickly/casually picking up source releases.
>
> Hmm. 2.4.32 coincided with the monthly Windows Update and with a curl
> release. I upgraded everything yesterday...

There is no (known) issue if mod_proxy_loadbalancer is not involved, is it?

Re: [RESULT] [VOTE] Release httpd-2.4.32

[Jan Ehrhardt]

Eric Covener in gmane.comp.apache.devel (Thu, 15 Mar 2018 12:35:38
-0400):
>+1, probably the least confusing, and Windows users aren't
>quickly/casually picking up source releases.

Hmm. 2.4.32 coincided with the monthly Windows Update and with a curl
release. I upgraded everything yesterday...
-- 
Jan

Re: [RESULT] [VOTE] Release httpd-2.4.32

[Eric Covener]

On Thu, Mar 15, 2018 at 12:34 PM, Yann Ylavic  wrote:
> On Thu, Mar 15, 2018 at 5:20 PM, Daniel Ruggeri  wrote:
>>
>> Personally, I would like to see *another* T (again, I volunteer and will
>> see it through quickly) and no mention of this release be made public via
>> ANNOUNCE.
>> Thoughts?
>
> I think we should complete this release, with a warning somewhere for
> mod_proxy_lb users on Windows. It's mirrored already.
> Then we can provide 2.4.33 shortly.

+1, probably the least confusing, and Windows users aren't
quickly/casually picking up source releases.

Re: [RESULT] [VOTE] Release httpd-2.4.32

[Yann Ylavic]

On Thu, Mar 15, 2018 at 5:20 PM, Daniel Ruggeri  wrote:
>
> Personally, I would like to see *another* T (again, I volunteer and will
> see it through quickly) and no mention of this release be made public via
> ANNOUNCE.
> Thoughts?

I think we should complete this release, with a warning somewhere for
mod_proxy_lb users on Windows. It's mirrored already.
Then we can provide 2.4.33 shortly.


Regards,
Yann.

RE: [RESULT] [VOTE] Release httpd-2.4.32

[Daniel Ruggeri]

> -Original Message-
> From: Daniel Ruggeri 
> Sent: Tuesday, March 13, 2018 12:00 PM
> To: dev@httpd.apache.org
> Subject: [RESULT] [VOTE] Release httpd-2.4.32
> 
> Hi, all;
> 
> On 2018/03/10 02:49:15, "Daniel Ruggeri"  wrote:
> > Hi, all;
> >
> >Please find below the proposed release tarball and signatures:
> >
> > https://dist.apache.org/repos/dist/dev/httpd/
> >
> >
> >
> > I would like to call a VOTE over the next few days to release this
candidate
> > tarball as 2.4.32:
> >
> > [ ] +1: It's not just good, it's good enough!
> >
> > [ ] +0: Let's have a talk.
> >
> > [ ] -1: There's trouble in paradise. Here's what's wrong.
> >
> >
> >
> > The computed digests of the tarball up for vote are:
> >
> > md5: cddf45e036657ea209145169a554bbff *httpd-2.4.32.tar.gz
> >
> > sha1: fc1f26a4d302639932332ea12b40de7503f8aab0 *httpd-2.4.32.tar.gz
> >
> > sha256:
> 11cd0c43135ffe89706d0558abc0d19cb4a1f203e11ada52f2e1c3f790959300
> > *httpd-2.4.32.tar.gz
> >
> >
> >
> > --
> >
> > Daniel Ruggeri
> 
>I am pleased to report that the vote for releasing httpd-2.4.32 has
PASSED
> with five binding +1 votes. I will continue with the process to release
and
> distribute the tarball. Bear with me as I learn through the procedure :-)
> 
> I do know that Announcement2.4.* and CHANGES_2.4 also require updates -
> feel free to point out anything missing.
> 
> --
> Daniel Ruggeri

Well, this is an interesting predicament indeed. A release has passed, but a
regression was found after the fact...

I volunteer to T 2.4.33 as soon as we're able to resolve this regression,
but in any event,  I am not comfortable sending the announcement that this
represents the latest and best version at this point - especially given that
we appear to have a patch for testing:
https://lists.apache.org/thread.html/adc854d8b395367ede75f327c1324c088d00701
33d0c7f6931822d0e@%3Cdev.httpd.apache.org%3E

So... that leaves me wondering how we would treat this. By now, most of the
mirrors should have caught up with the new version, announcement text and
CHANGES*. I did not update the CURRENT-IS- pointer yet, though. How do
we treat this version in STATUS - as in... at what point does a release
become a release? When it gets the votes? When it's pushed to dist/release?
When the announcement is made?

Personally, I would like to see *another* T (again, I volunteer and will
see it through quickly) and no mention of this release be made public via
ANNOUNCE.
Thoughts?

-- 
Daniel Ruggeri

Re: A hang with mod_md renew

[Yann Ylavic]

On Thu, Mar 15, 2018 at 4:45 PM, Steffen  wrote:
> Thinking.
>
> Because an issue can be a configuration fault and not a bug. I think
> best is post it to the user list first or dev can reply in the AL
> forum.  Bugzilla is not so suited for discussions.

Yes, technical discussions and (possible) configuration issues are not
nice/appropriate for bz.
Qualified bugs are, and we can always (usually do) continue related
technical discussions on dev@, if needed.
There remain the description of the issue, final patches and where
they are committed/backported to in bz, which is nice for those who
didn't upgrade (for instance).

So once qualified it's always worth creating a bz for the record.

> Experience learns that AL users not always willing to be directed to
> bugzilla or to lists.
>
> Yep, hard for a non coder to understand what to do to report issues
> from my own test frame work, reported to me by mail, reported in the
> forum.

It's hard to get a fix without reporting appropriately, the less time
spent by the committer, the faster the issue gets resolved.

>
> For years I and others report issues on the dev list, but suddenly it
> seems not be the way anymore.
>
> What is changed lately ?

Well, it sometimes works on the one or the other, the preferred way is
(and has always been AFAICT) to fill a bz and ping on dev@ if it lacks
attention...

Re: mod_proxy_balancer doesn't work with 2.4.32

[Jim Jagielski]

*bringo*!

https://www.youtube.com/watch?v=4MpyHBoiTwk

> On Mar 15, 2018, at 9:58 AM, Eric Covener  wrote:
> 
> On Thu, Mar 15, 2018 at 9:44 AM, Yann Ylavic  wrote:
>> On Thu, Mar 15, 2018 at 2:22 PM, Yann Ylavic  wrote:
>>> On Thu, Mar 15, 2018 at 11:56 AM, Steffen  wrote:
 
 
 Looks a serious regression.
 
 Reported:  www.apachelounge.com/viewtopic.php?p=36597
>>> 
>>> It does not look like mod_slotmem_shm is used (missing some error
>>> logging from there), mod_slotmem_plain maybe?
>>> 
>>> Also, more context would be appreciated, full/relevant VirtualHost
>>> config (including IP:port, ServerName/ServerAlias eventually
>>> "anonymized"), BalancerPersist on/off(?) and whether or not other
>>> balancers are configured elsewhere (i.e. full httpd.conf if
>>> possible...).
>>> 
>>> Can Windows users reproduce this very basic case here with
>>> mod_slotmem_shm (it doesn't seem Windows specific to me)?
>> 
>> Wait:
>> [pid 19136:tid 136] mod_proxy_balancer.c(917): AH01178: Doing
>> balancers create: 552, 1 (6)
>> [pid 19136:tid 136] mod_proxy_balancer.c(986): AH01184: Doing workers
>> create: balancer://mycluster (p111c5be7_mycluster), 984, 2 [0]
>> [pid 30160:tid 756] mod_proxy_balancer.c(917): AH01178: Doing
>> balancers create: 552, 1 (6)
>> [pid 30160:tid 756] (17)File exists: AH01179: balancer slotmem_create failed
>> 
>> Two processes (PIDs) creating the same balancer, two httpd instances
>> with the same configuration?
> 
>> (IIRC, Windows MPM is threaded only, no "forking" right?).
> 
> the parent and child both run postconfig though on Windows.
> 
> -- 
> Eric Covener
> cove...@gmail.com

Re: mod_proxy_balancer doesn't work with 2.4.32

[Yann Ylavic]

On Thu, Mar 15, 2018 at 3:20 PM, Rainer Jung  wrote:
>
> For the sake of completeness, here are the full trace8 (failed) startup logs
> for this reproduction scenario:

Thanks Rainer!

Could you (or Steffen, or Lucas) try the attached patch? It's based on
2.4.x, but should work for trunk too..


Regards,
Yann.
Index: modules/slotmem/mod_slotmem_shm.c
===
--- modules/slotmem/mod_slotmem_shm.c	(revision 1826753)
+++ modules/slotmem/mod_slotmem_shm.c	(working copy)
@@ -274,11 +274,25 @@ static apr_status_t restore_slotmem(sharedslotdesc
 return rv;
 }
 
+static APR_INLINE int is_child_process(void)
+{
+#ifdef WIN32
+return getenv("AP_PARENT_PID") != NULL;
+#else
+return 0;
+#endif
+}
+
 static apr_status_t cleanup_slotmem(void *is_startup)
 {
 int is_exiting = (ap_state_query(AP_SQ_MAIN_STATE) == AP_SQ_MS_EXITING);
 ap_slotmem_instance_t *mem;
 
+if (is_child_process()) {
+*retained_globallistmem = globallistmem = NULL;
+return APR_SUCCESS;
+}
+
 /* When in startup/pre-config's cleanup, the retained data and global pool
  * are not used yet, but the SHMs contents were untouched hence they don't
  * need to be persisted, simply unlink them.
@@ -439,8 +453,13 @@ static apr_status_t slotmem_create(ap_slotmem_inst
 
 {
 if (fbased) {
-apr_shm_remove(fname, pool);
-rv = apr_shm_create(, size, fname, gpool);
+if (is_child_process()) {
+rv = apr_shm_attach(, fname, gpool);
+}
+else {
+apr_shm_remove(fname, pool);
+rv = apr_shm_create(, size, fname, gpool);
+}
 }
 else {
 rv = apr_shm_create(, size, NULL, pool);
@@ -447,9 +466,9 @@ static apr_status_t slotmem_create(ap_slotmem_inst
 }
 ap_log_error(APLOG_MARK, rv == APR_SUCCESS ? APLOG_DEBUG : APLOG_ERR,
  rv, ap_server_conf, APLOGNO(02611)
- "create: apr_shm_create(%s) %s",
- fname ? fname : "",
- rv == APR_SUCCESS ? "succeeded" : "failed");
+ "create: apr_shm_%s(%s) %s",
+ fbased && is_child_process() ? "attach" : "create",
+ fname, rv == APR_SUCCESS ? "succeeded" : "failed");
 if (rv != APR_SUCCESS) {
 return rv;
 }
@@ -811,7 +830,10 @@ static int pre_config(apr_pool_t *pconf, apr_pool_
 }
 globallistmem = *retained_globallistmem;
 
-if (ap_state_query(AP_SQ_MAIN_STATE) != AP_SQ_MS_CREATE_PRE_CONFIG) {
+if (is_child_process()) {
+gpool = pconf;
+}
+else if (ap_state_query(AP_SQ_MAIN_STATE) != AP_SQ_MS_CREATE_PRE_CONFIG) {
 gpool = ap_pglobal;
 }
 else {

Re: A hang with mod_md renew

[Steffen]

Thinking. 

Because an issue can be a configuration fault and not a bug. I think best is 
post it to the user list first or dev can reply in the AL forum.  Bugzilla is 
not so suited for discussions. 

Experience learns that AL users not always willing to be directed to bugzilla 
or to lists. 

Yep, hard for a non coder to understand what to do to report issues from my own 
test frame work, reported to me by mail, reported in the forum. 

For years I and others report issues on the dev list, but suddenly it seems not 
be the way anymore. 

What is changed lately ?

Btw. 
Stefan want also issues reported in Git issues thread:  “I want to use 'Issues' 
for support”. 


> Op 15 mrt. 2018 om 15:20 heeft Steffen  het volgende 
> geschreven:
> 
> Ok, my fault.  I shall stop reporting here. 
> 
> Btw.. official is 32 not announced and in the vote thread I said: When there 
> some pop's up from the AL community, I let it know. 
> 
> 
> 
 Op 15 mrt. 2018 om 15:07 heeft Yann Ylavic  het 
 volgende geschreven:
 
 On Thu, Mar 15, 2018 at 3:05 PM, Eric Covener  wrote:
 On Thu, Mar 15, 2018 at 10:04 AM, Steffen  wrote:
 
 I am just passing the issues to list. I hope the reporter follows this 
 list, the link I posted in the forum.
>>> 
>>> The best thing for everyone would be to direct users to bugzilla to
>>> report bugs, when they're not in the packaging of course.
>> 
>> +1
> 

Re: A hang with mod_md renew

[Yann Ylavic]

On Thu, Mar 15, 2018 at 3:20 PM, Steffen  wrote:
> Ok, my fault.  I shall stop reporting here.
>
>  Btw.. official is 32 not announced and in the vote thread I said: When there 
> some pop's up from the AL community, I let it know.

Bug reports are always very welcome, at any time!
Bugzilla is simply easier for tracing (relevant) discussions and
follow successive patches.
It also provides a reference for CHANGES entries...

Re: mod_proxy_balancer doesn't work with 2.4.32

[Eric Covener]

IIRC they use a combo of AP_PARENT_PID and postconfig userdata to tell
between parent/child an first/second pass.

But i also vaguely recall there is a helper for it now?

On Thu, Mar 15, 2018 at 10:25 AM, Yann Ylavic  wrote:
> On Thu, Mar 15, 2018 at 3:05 PM, Yann Ylavic  wrote:
>> On Thu, Mar 15, 2018 at 2:58 PM, Eric Covener  wrote:
>>> On Thu, Mar 15, 2018 at 9:44 AM, Yann Ylavic  wrote:

 (IIRC, Windows MPM is threaded only, no "forking" right?).
>>>
>>> the parent and child both run postconfig though on Windows.
>>
>> Argh, that's it! (weird behaviour though, IMHO).
>>
>> The slotmem does not try to attach() first anymore, this needs to be 
>> restored...
>
> Is there a way for a module to know whether it's run by the parent or
> child process on Windows?



-- 
Eric Covener
cove...@gmail.com

Re: mod_proxy_balancer doesn't work with 2.4.32

[Yann Ylavic]

On Thu, Mar 15, 2018 at 3:05 PM, Yann Ylavic  wrote:
> On Thu, Mar 15, 2018 at 2:58 PM, Eric Covener  wrote:
>> On Thu, Mar 15, 2018 at 9:44 AM, Yann Ylavic  wrote:
>>>
>>> (IIRC, Windows MPM is threaded only, no "forking" right?).
>>
>> the parent and child both run postconfig though on Windows.
>
> Argh, that's it! (weird behaviour though, IMHO).
>
> The slotmem does not try to attach() first anymore, this needs to be 
> restored...

Is there a way for a module to know whether it's run by the parent or
child process on Windows?

Re: A hang with mod_md renew

[Steffen]

Ok, my fault.  I shall stop reporting here. 

 Btw.. official is 32 not announced and in the vote thread I said: When there 
some pop's up from the AL community, I let it know. 



>>> Op 15 mrt. 2018 om 15:07 heeft Yann Ylavic  het 
>>> volgende geschreven:
>>> 
>>> On Thu, Mar 15, 2018 at 3:05 PM, Eric Covener  wrote:
>>> On Thu, Mar 15, 2018 at 10:04 AM, Steffen  wrote:
>>> 
>>> I am just passing the issues to list. I hope the reporter follows this 
>>> list, the link I posted in the forum.
>> 
>> The best thing for everyone would be to direct users to bugzilla to
>> report bugs, when they're not in the packaging of course.
> 
> +1

Re: mod_proxy_balancer doesn't work with 2.4.32

[Rainer Jung]

Am 15.03.2018 um 15:06 schrieb Yann Ylavic:

On Thu, Mar 15, 2018 at 2:59 PM, lucas29252  wrote:

Hi, I'm the original reporter.

I've just make a fresh install of  httpd-2.4.32-Win64-VC15.zip


And then uncommented the following modules:

lbmethod_byrequests_module
proxy_module
slotmem_shm_module

And in the #Virtual hosts section added the following:


 ServerAdmin webmas...@dummy-host.example.com
 DocumentRoot "C:/Apache24/docs/dummy-host.example.com"
 ServerName dummy-host.example.com
 ServerAlias www.dummy-host.example.com
 ErrorLog "logs/dummy-host.example.com-error.log"
 CustomLog "logs/dummy-host.example.com-access.log" common

 LogLevel debug

 
   BalancerMember http://localhost:8080 retry=0
   BalancerMember http://localhost:8880 retry=0 status=+H
 

 ProxyPass /  "balancer://mycluster/"
 ProxyPassReverse  /  "balancer://mycluster/"




Thanks, I think I see where it comes from, will provide a patch soon.


For the sake of completeness, here are the full trace8 (failed) startup 
logs for this reproduction scenario:


C:\Users\myuser\Apache\Apache24\bin>httpd
AH00112: Warning: DocumentRoot [C:/Apache24/docs/dummy-host.example.com] 
does not exist
[Thu Mar 15 15:16:22.739001 2018] [core:trace3] [pid 5968:tid 428] 
core.c(3345): Setting LogLevel for all modules to trace8
[Thu Mar 15 15:16:22.739001 2018] [proxy:debug] [pid 5968:tid 428] 
mod_proxy.c(2327): AH01147: Defining worker 'http://localhost:8080' for 
balancer 'balancer://mycluster'
[Thu Mar 15 15:16:22.739001 2018] [proxy:debug] [pid 5968:tid 428] 
mod_proxy.c(2332): AH01148: Defined worker 'http://localhost:8080' for 
balancer 'balancer://mycluster'
[Thu Mar 15 15:16:22.739001 2018] [proxy:debug] [pid 5968:tid 428] 
mod_proxy.c(2327): AH01147: Defining worker 'http://localhost:8880' for 
balancer 'balancer://mycluster'
[Thu Mar 15 15:16:22.739001 2018] [proxy:debug] [pid 5968:tid 428] 
mod_proxy.c(2332): AH01148: Defined worker 'http://localhost:8880' for 
balancer 'balancer://mycluster'



C:\Users\myuser\Apache\Apache24\logs>type dummy-host.example.com-error.log
[Thu Mar 15 15:16:22.801414 2018] [proxy_balancer:debug] [pid 5968:tid 
428] mod_proxy_balancer.c(917): AH01178: Doing balancers create: 552, 1 (6)
[Thu Mar 15 15:16:22.816981 2018] [proxy_balancer:debug] [pid 5968:tid 
428] mod_proxy_balancer.c(986): AH01184: Doing workers create: 
balancer://mycluster (p36f4bd69_mycluster), 984, 2 [0]
[Thu Mar 15 15:16:23.332625 2018] [proxy_balancer:debug] [pid 7520:tid 
416] mod_proxy_balancer.c(917): AH01178: Doing balancers create: 552, 1 (6)
[Thu Mar 15 15:16:23.332625 2018] [proxy_balancer:emerg] [pid 7520:tid 
416] (17)File exists: AH01179: balancer slotmem_create failed



C:\Users\myuser\Apache\Apache24\logs>type error.log
AH00112: Warning: DocumentRoot [C:/Apache24/docs/dummy-host.example.com] 
does not exist
[Thu Mar 15 15:16:22.785730 2018] [core:trace3] [pid 5968:tid 428] 
core.c(3345): Setting LogLevel for all modules to trace8
[Thu Mar 15 15:16:22.785730 2018] [proxy:debug] [pid 5968:tid 428] 
mod_proxy.c(2327): AH01147: Defining worker 'http://localhost:8080' for 
balancer 'balancer://mycluster'
[Thu Mar 15 15:16:22.785730 2018] [proxy:debug] [pid 5968:tid 428] 
mod_proxy.c(2332): AH01148: Defined worker 'http://localhost:8080' for 
balancer 'balancer://mycluster'
[Thu Mar 15 15:16:22.785730 2018] [proxy:debug] [pid 5968:tid 428] 
mod_proxy.c(2327): AH01147: Defining worker 'http://localhost:8880' for 
balancer 'balancer://mycluster'
[Thu Mar 15 15:16:22.785730 2018] [proxy:debug] [pid 5968:tid 428] 
mod_proxy.c(2332): AH01148: Defined worker 'http://localhost:8880' for 
balancer 'balancer://mycluster'
[Thu Mar 15 15:16:22.816981 2018] [mpm_winnt:notice] [pid 5968:tid 428] 
AH00455: Apache/2.4.32 (Win64) configured -- resuming normal operations
[Thu Mar 15 15:16:22.816981 2018] [mpm_winnt:notice] [pid 5968:tid 428] 
AH00456: Apache Lounge VC15 Server built: Mar 12 2018 15:30:34
[Thu Mar 15 15:16:22.816981 2018] [core:notice] [pid 5968:tid 428] 
AH00094: Command line: 'httpd -d C:/Users/myuser/Apache/Apache24'
[Thu Mar 15 15:16:22.848233 2018] [mpm_winnt:notice] [pid 5968:tid 428] 
AH00418: Parent: Created child process 7520
AH00112: Warning: DocumentRoot [C:/Apache24/docs/dummy-host.example.com] 
does not exist
[Thu Mar 15 15:16:23.270113 2018] [core:trace3] [pid 7520:tid 416] 
core.c(3345): Setting LogLevel for all modules to trace8
[Thu Mar 15 15:16:23.270113 2018] [proxy:debug] [pid 7520:tid 416] 
mod_proxy.c(2327): AH01147: Defining worker 'http://localhost:8080' for 
balancer 'balancer://mycluster'
[Thu Mar 15 15:16:23.270113 2018] [proxy:debug] [pid 7520:tid 416] 
mod_proxy.c(2332): AH01148: Defined worker 'http://localhost:8080' for 
balancer 'balancer://mycluster'
[Thu Mar 15 15:16:23.270113 2018] [proxy:debug] [pid 7520:tid 416] 
mod_proxy.c(2327): 

Re: A hang with mod_md renew

[Yann Ylavic]

On Thu, Mar 15, 2018 at 3:05 PM, Eric Covener  wrote:
> On Thu, Mar 15, 2018 at 10:04 AM, Steffen  wrote:
>>
>> I am just passing the issues to list. I hope the reporter follows this list, 
>> the link I posted in the forum.
>
> The best thing for everyone would be to direct users to bugzilla to
> report bugs, when they're not in the packaging of course.

+1

Re: mod_proxy_balancer doesn't work with 2.4.32

[Yann Ylavic]

On Thu, Mar 15, 2018 at 2:59 PM, lucas29252  wrote:
> Hi, I'm the original reporter.
>
> I've just make a fresh install of  httpd-2.4.32-Win64-VC15.zip
> 
>
> And then uncommented the following modules:
>
> lbmethod_byrequests_module
> proxy_module
> slotmem_shm_module
>
> And in the #Virtual hosts section added the following:
>
> 
> ServerAdmin webmas...@dummy-host.example.com
> DocumentRoot "C:/Apache24/docs/dummy-host.example.com"
> ServerName dummy-host.example.com
> ServerAlias www.dummy-host.example.com
> ErrorLog "logs/dummy-host.example.com-error.log"
> CustomLog "logs/dummy-host.example.com-access.log" common
>
> LogLevel debug
>
> 
>   BalancerMember http://localhost:8080 retry=0
>   BalancerMember http://localhost:8880 retry=0 status=+H
> 
>
> ProxyPass /  "balancer://mycluster/"
> ProxyPassReverse  /  "balancer://mycluster/"
>
> 

Thanks, I think I see where it comes from, will provide a patch soon.

Re: A hang with mod_md renew

[Eric Covener]

On Thu, Mar 15, 2018 at 10:04 AM, Steffen  wrote:
>
> I am just passing the issues to list. I hope the reporter follows this list, 
> the link I posted in the forum.

The best thing for everyone would be to direct users to bugzilla to
report bugs, when they're not in the packaging of course.

Re: mod_proxy_balancer doesn't work with 2.4.32

[Yann Ylavic]

On Thu, Mar 15, 2018 at 2:58 PM, Eric Covener  wrote:
> On Thu, Mar 15, 2018 at 9:44 AM, Yann Ylavic  wrote:
>>
>> (IIRC, Windows MPM is threaded only, no "forking" right?).
>
> the parent and child both run postconfig though on Windows.

Argh, that's it! (weird behaviour though, IMHO).

The slotmem does not try to attach() first anymore, this needs to be restored...

Re: A hang with mod_md renew

[Steffen]

I am just passing the issues to list. I hope the reporter follows this list, 
the link I posted in the forum. 

> Op 15 mrt. 2018 om 09:58 heeft Stefan Eissing  
> het volgende geschreven:
> 
> My bet would be on mod_md.c, line 701 that could place the job->next_run in
> the past. That would cause then the watchdog to run immediately again.
> 
> Since the log shows the expiry date to be ok, the md->renew_window seems
> to be wrong. It would also be interesting to see the content of
> 
> $SERVERROOT/md/domains/ftp.pbhq.com/md.json
> 
> Cheers, Stefan
> 
>> Am 14.03.2018 um 23:21 schrieb Yann Ylavic :
>> 
>> On Wed, Mar 14, 2018 at 11:07 PM, Yann Ylavic  wrote:
>>> Hi Steffen,
>>> 
 On Wed, Mar 14, 2018 at 6:55 PM, Steffen  wrote:
 
 See :  https://www.apachelounge.com/viewtopic.php?p=36588#36588
>>> 
>>> Could we have the log messages at LogLevel trace1?
>> 
>> Also, what's the configuration for MDRenewWindow there?
>> 
>>> 
>>> Regards,
>>> Yann.
> 

Re: mod_proxy_balancer doesn't work with 2.4.32

[lucas29252]

Hi, I'm the original reporter.

I've just make a fresh install of  httpd-2.4.32-Win64-VC15.zip

  

And then uncommented the following modules:

lbmethod_byrequests_module
proxy_module
slotmem_shm_module

And in the #Virtual hosts section added the following:


ServerAdmin webmas...@dummy-host.example.com
DocumentRoot "C:/Apache24/docs/dummy-host.example.com"
ServerName dummy-host.example.com
ServerAlias www.dummy-host.example.com
ErrorLog "logs/dummy-host.example.com-error.log"
CustomLog "logs/dummy-host.example.com-access.log" common

LogLevel debug


  BalancerMember http://localhost:8080 retry=0
  BalancerMember http://localhost:8880 retry=0 status=+H


ProxyPass /  "balancer://mycluster/"  
ProxyPassReverse  /  "balancer://mycluster/"  





You get the same error in the log:

[proxy_balancer:debug] [pid 23672:tid 520] mod_proxy_balancer.c(917):
AH01178: Doing balancers create: 552, 1 (6)
[proxy_balancer:debug] [pid 23672:tid 520] mod_proxy_balancer.c(986):
AH01184: Doing workers create: balancer://mycluster (pfbbe1180_mycluster),
984, 2 [0]
[proxy_balancer:debug] [pid 29888:tid 544] mod_proxy_balancer.c(917):
AH01178: Doing balancers create: 552, 1 (6)
[proxy_balancer:emerg] [pid 29888:tid 544] (17)File exists: AH01179:
balancer slotmem_create failed





--
Sent from: 
http://apache-http-server.18135.x6.nabble.com/Apache-HTTP-Server-Dev-f4771363.html

Re: mod_proxy_balancer doesn't work with 2.4.32

[Eric Covener]

On Thu, Mar 15, 2018 at 9:44 AM, Yann Ylavic  wrote:
> On Thu, Mar 15, 2018 at 2:22 PM, Yann Ylavic  wrote:
>> On Thu, Mar 15, 2018 at 11:56 AM, Steffen  wrote:
>>>
>>>
>>> Looks a serious regression.
>>>
>>> Reported:  www.apachelounge.com/viewtopic.php?p=36597
>>
>> It does not look like mod_slotmem_shm is used (missing some error
>> logging from there), mod_slotmem_plain maybe?
>>
>> Also, more context would be appreciated, full/relevant VirtualHost
>> config (including IP:port, ServerName/ServerAlias eventually
>> "anonymized"), BalancerPersist on/off(?) and whether or not other
>> balancers are configured elsewhere (i.e. full httpd.conf if
>> possible...).
>>
>> Can Windows users reproduce this very basic case here with
>> mod_slotmem_shm (it doesn't seem Windows specific to me)?
>
> Wait:
>  [pid 19136:tid 136] mod_proxy_balancer.c(917): AH01178: Doing
> balancers create: 552, 1 (6)
>  [pid 19136:tid 136] mod_proxy_balancer.c(986): AH01184: Doing workers
> create: balancer://mycluster (p111c5be7_mycluster), 984, 2 [0]
>  [pid 30160:tid 756] mod_proxy_balancer.c(917): AH01178: Doing
> balancers create: 552, 1 (6)
>  [pid 30160:tid 756] (17)File exists: AH01179: balancer slotmem_create failed
>
> Two processes (PIDs) creating the same balancer, two httpd instances
> with the same configuration?

> (IIRC, Windows MPM is threaded only, no "forking" right?).

the parent and child both run postconfig though on Windows.

-- 
Eric Covener
cove...@gmail.com

Re: mod_proxy_balancer doesn't work with 2.4.32

[Steffen]

I am just passing the issue to list. I hope the reporter follows this list, the 
link I posted in the forum. 



> Op 15 mrt. 2018 om 14:34 heeft Yann Ylavic  het 
> volgende geschreven:
> 
>> On Thu, Mar 15, 2018 at 2:22 PM, Yann Ylavic  wrote:

> LogLevel debug maybe Steffen?

Re: mod_proxy_balancer doesn't work with 2.4.32

[Yann Ylavic]

On Thu, Mar 15, 2018 at 2:22 PM, Yann Ylavic  wrote:
> On Thu, Mar 15, 2018 at 11:56 AM, Steffen  wrote:
>>
>>
>> Looks a serious regression.
>>
>> Reported:  www.apachelounge.com/viewtopic.php?p=36597
>
> It does not look like mod_slotmem_shm is used (missing some error
> logging from there), mod_slotmem_plain maybe?
>
> Also, more context would be appreciated, full/relevant VirtualHost
> config (including IP:port, ServerName/ServerAlias eventually
> "anonymized"), BalancerPersist on/off(?) and whether or not other
> balancers are configured elsewhere (i.e. full httpd.conf if
> possible...).
>
> Can Windows users reproduce this very basic case here with
> mod_slotmem_shm (it doesn't seem Windows specific to me)?

Wait:
 [pid 19136:tid 136] mod_proxy_balancer.c(917): AH01178: Doing
balancers create: 552, 1 (6)
 [pid 19136:tid 136] mod_proxy_balancer.c(986): AH01184: Doing workers
create: balancer://mycluster (p111c5be7_mycluster), 984, 2 [0]
 [pid 30160:tid 756] mod_proxy_balancer.c(917): AH01178: Doing
balancers create: 552, 1 (6)
 [pid 30160:tid 756] (17)File exists: AH01179: balancer slotmem_create failed

Two processes (PIDs) creating the same balancer, two httpd instances
with the same configuration?
(IIRC, Windows MPM is threaded only, no "forking" right?).

Re: mod_proxy_balancer doesn't work with 2.4.32

[Yann Ylavic]

On Thu, Mar 15, 2018 at 2:22 PM, Yann Ylavic  wrote:
> On Thu, Mar 15, 2018 at 11:56 AM, Steffen  wrote:
>>
>>
>> Looks a serious regression.
>>
>> Reported:  www.apachelounge.com/viewtopic.php?p=36597
>
> It does not look like mod_slotmem_shm is used (missing some error
> logging from there), mod_slotmem_plain maybe?

Hmm no, mod_proxy_balancer is asking for slotmem_shm explicitely, so
it can't be _plain.

I really wonder why mod_slotmem_shm::slotmem_create() fails w/o its
own error message (AH02611)...
LogLevel debug maybe Steffen?

Re: mod_proxy_balancer doesn't work with 2.4.32

[Jim Jagielski]

Besides, isn't this specifically tested in the Perl test framework?

> On Mar 15, 2018, at 9:28 AM, Jim Jagielski  wrote:
> 
> I can't...
> 
>> On Mar 15, 2018, at 9:22 AM, Ruediger Pluem  wrote:
>> 
>> Can anyone reproduce outside of Windows?
>> 
>> Regards
>> 
>> Rüdiger
>> 
>> On 03/15/2018 01:47 PM, Jim Jagielski wrote:
>>> No doubt something in Yann's slotmem changes that affect Windows.
>>> 
 On Mar 15, 2018, at 6:56 AM, Steffen  wrote:
 
 
 
 Looks a serious regression.
 
 Reported:  www.apachelounge.com/viewtopic.php?p=36597
 
 
>>> 
>>> 
> 

Re: mod_proxy_balancer doesn't work with 2.4.32

[Jim Jagielski]

I can't...

> On Mar 15, 2018, at 9:22 AM, Ruediger Pluem  wrote:
> 
> Can anyone reproduce outside of Windows?
> 
> Regards
> 
> Rüdiger
> 
> On 03/15/2018 01:47 PM, Jim Jagielski wrote:
>> No doubt something in Yann's slotmem changes that affect Windows.
>> 
>>> On Mar 15, 2018, at 6:56 AM, Steffen  wrote:
>>> 
>>> 
>>> 
>>> Looks a serious regression.
>>> 
>>> Reported:  www.apachelounge.com/viewtopic.php?p=36597
>>> 
>>> 
>> 
>> 

Re: mod_proxy_balancer doesn't work with 2.4.32

[Yann Ylavic]

On Thu, Mar 15, 2018 at 11:56 AM, Steffen  wrote:
>
>
> Looks a serious regression.
>
> Reported:  www.apachelounge.com/viewtopic.php?p=36597

It does not look like mod_slotmem_shm is used (missing some error
logging from there), mod_slotmem_plain maybe?

Also, more context would be appreciated, full/relevant VirtualHost
config (including IP:port, ServerName/ServerAlias eventually
"anonymized"), BalancerPersist on/off(?) and whether or not other
balancers are configured elsewhere (i.e. full httpd.conf if
possible...).

Can Windows users reproduce this very basic case here with
mod_slotmem_shm (it doesn't seem Windows specific to me)?


Regards,
Yann.

Re: mod_proxy_balancer doesn't work with 2.4.32

[Ruediger Pluem]

Can anyone reproduce outside of Windows?

Regards

Rüdiger

On 03/15/2018 01:47 PM, Jim Jagielski wrote:
> No doubt something in Yann's slotmem changes that affect Windows.
> 
>> On Mar 15, 2018, at 6:56 AM, Steffen  wrote:
>>
>>
>>
>> Looks a serious regression.
>>
>> Reported:  www.apachelounge.com/viewtopic.php?p=36597
>>
>>
> 
> 

Re: mod_proxy_balancer doesn't work with 2.4.32

[Jim Jagielski]

No doubt something in Yann's slotmem changes that affect Windows.

> On Mar 15, 2018, at 6:56 AM, Steffen  wrote:
> 
> 
> 
> Looks a serious regression.
> 
> Reported:  www.apachelounge.com/viewtopic.php?p=36597
> 
> 

mod_proxy_balancer doesn't work with 2.4.32

[Steffen]

Looks a serious regression.

Reported:  www.apachelounge.com/viewtopic.php?p=36597

Re: [RESULT] [VOTE] Release httpd-2.4.32

[Exonetric]

Hi 

> On 13 Mar 2018, at 16:59, Daniel Ruggeri  wrote:
> 
> Hi, all;
> 
>> On 2018/03/10 02:49:15, "Daniel Ruggeri"  wrote: 
>> Hi, all;
>> 
>>   Please find below the proposed release tarball and signatures:
>> 
>> https://dist.apache.org/repos/dist/dev/httpd/
>> 
>> 
>> 
>> I would like to call a VOTE over the next few days to release this candidate
>> tarball as 2.4.32:
>> 
>> [ ] +1: It's not just good, it's good enough!
>> 
>> [ ] +0: Let's have a talk.
>> 
>> [ ] -1: There's trouble in paradise. Here's what's wrong.
>> 
>> 
>> 
>> The computed digests of the tarball up for vote are:
>> 
>> md5: cddf45e036657ea209145169a554bbff *httpd-2.4.32.tar.gz
>> 
>> sha1: fc1f26a4d302639932332ea12b40de7503f8aab0 *httpd-2.4.32.tar.gz
>> 
>> sha256: 11cd0c43135ffe89706d0558abc0d19cb4a1f203e11ada52f2e1c3f790959300
>> *httpd-2.4.32.tar.gz
>> 
>> 
>> 
>> -- 
>> 
>> Daniel Ruggeri
> 
>   I am pleased to report that the vote for releasing httpd-2.4.32 has PASSED 
> with five binding +1 votes. I will continue with the process to release and 
> distribute the tarball. Bear with me as I learn through the procedure :-)
> 
> I do know that Announcement2.4.* and CHANGES_2.4 also require updates - feel 
> free to point out anything missing.

Is it safe to assume this will be announced today or tomorrow, 15/16 March?

Cheers
Mark

Re: A hang with mod_md renew

[Stefan Eissing]

My bet would be on mod_md.c, line 701 that could place the job->next_run in
the past. That would cause then the watchdog to run immediately again.

Since the log shows the expiry date to be ok, the md->renew_window seems
to be wrong. It would also be interesting to see the content of

$SERVERROOT/md/domains/ftp.pbhq.com/md.json

Cheers, Stefan

> Am 14.03.2018 um 23:21 schrieb Yann Ylavic :
> 
> On Wed, Mar 14, 2018 at 11:07 PM, Yann Ylavic  wrote:
>> Hi Steffen,
>> 
>> On Wed, Mar 14, 2018 at 6:55 PM, Steffen  wrote:
>>> 
>>> See :  https://www.apachelounge.com/viewtopic.php?p=36588#36588
>> 
>> Could we have the log messages at LogLevel trace1?
> 
> Also, what's the configuration for MDRenewWindow there?
> 
>> 
>> Regards,
>> Yann.