Re: Review Request 40638: Base framework for scheduler.

2015-12-10 Thread Ajay Yadava 


> On Dec. 10, 2015, 8:29 a.m., Amareshwari Sriramadasu wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java,
> >  line 57
> > 
> >
> > return would be void.

It's just to be consistent with SubmitAndSchedule. If you want I can change it.


- Ajay


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40638/#review109707
---


On Dec. 10, 2015, 8:01 a.m., Ajay Yadava wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40638/
> ---
> 
> (Updated Dec. 10, 2015, 8:01 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-879
> https://issues.apache.org/jira/browse/LENS-879
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Base framework for lens scheduler service and job definition.
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java 
> PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInfo.java 
> PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java
>  PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceInfo.java
>  PRE-CREATION 
>   lens-api/src/main/resources/scheduler-job-0.1.xsd PRE-CREATION 
>   lens-examples/src/main/resources/example-job.xml PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java
>  9f48d27 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobStats.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java
>  3389aba 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java
>  24949bd 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java
>  PRE-CREATION 
>   lens-server/src/main/resources/lensserver-default.xml 39b72dc 
>   
> lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java
>  e11413e 
>   pom.xml 732b3bb 
>   src/site/apt/admin/config.apt bcf4b7d 
> 
> Diff: https://reviews.apache.org/r/40638/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ajay Yadava
> 
>

Re: Review Request 40638: Base framework for scheduler.

2015-12-10 Thread Ajay Yadava 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40638/
---

(Updated Dec. 10, 2015, 8:47 a.m.)


Review request for lens.


Changes
---

Changed the return type to void for scheduleJob method.


Bugs: LENS-879
https://issues.apache.org/jira/browse/LENS-879


Repository: lens


Description
---

Base framework for lens scheduler service and job definition.


Diffs (updated)
-

  lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java 
PRE-CREATION 
  lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInfo.java 
PRE-CREATION 
  
lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java
 PRE-CREATION 
  
lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceInfo.java 
PRE-CREATION 
  lens-api/src/main/resources/scheduler-job-0.1.xsd PRE-CREATION 
  lens-examples/src/main/resources/example-job.xml PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java
 9f48d27 
  
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobStats.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java
 PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java
 3389aba 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java
 24949bd 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java
 PRE-CREATION 
  lens-server/src/main/resources/lensserver-default.xml 39b72dc 
  
lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java
 e11413e 
  pom.xml 732b3bb 
  src/site/apt/admin/config.apt bcf4b7d 

Diff: https://reviews.apache.org/r/40638/diff/


Testing
---


Thanks,

Ajay Yadava

Re: Review Request 40638: Base framework for scheduler.

2015-12-09 Thread Ajay Yadava 


> On Dec. 10, 2015, 6:01 a.m., Amareshwari Sriramadasu wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java,
> >  line 93
> > 
> >
> > Please update the comment with "updates will be applied only for newer 
> > instances. Running instances will be running with old definition"

Done.


> On Dec. 10, 2015, 6:01 a.m., Amareshwari Sriramadasu wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java,
> >  line 192
> > 
> >
> > Should there be api to kill/stop running instance ?

Added a kill api.


- Ajay


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40638/#review109690
---


On Dec. 8, 2015, 2:06 p.m., Ajay Yadava wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40638/
> ---
> 
> (Updated Dec. 8, 2015, 2:06 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-879
> https://issues.apache.org/jira/browse/LENS-879
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Base framework for lens scheduler service and job definition.
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java 
> PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInfo.java 
> PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java
>  PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceInfo.java
>  PRE-CREATION 
>   lens-api/src/main/resources/scheduler-job-0.1.xsd PRE-CREATION 
>   lens-examples/src/main/resources/example-job.xml PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java
>  9f48d27 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobStats.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java
>  3389aba 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java
>  24949bd 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java
>  PRE-CREATION 
>   lens-server/src/main/resources/lensserver-default.xml 39b72dc 
>   
> lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java
>  e11413e 
>   pom.xml 732b3bb 
>   src/site/apt/admin/config.apt bcf4b7d 
> 
> Diff: https://reviews.apache.org/r/40638/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ajay Yadava
> 
>

Re: Review Request 40638: Base framework for scheduler.

2015-12-09 Thread Amareshwari Sriramadasu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40638/#review109690
---



lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceInfo.java 
(line 34)


Shouldnt we add its corresponding scheduleJobHandle also ?



lens-api/src/main/resources/scheduler-job-0.1.xsd (lines 102 - 106)


Please add comments for these also.



lens-api/src/main/resources/scheduler-job-0.1.xsd (line 153)


Needs update



lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java
 (line 47)


return object should be SchedulerJobHandle for all three methods below.



lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java
 (line 57)


Shouldnt this take SchedulerJobHandle as the param?



lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java
 (line 93)


Please update the comment with "updates will be applied only for newer 
instances. Running instances will be running with old definition"



lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java
 (line 192)


Should there be api to kill/stop running instance ?


- Amareshwari Sriramadasu


On Dec. 8, 2015, 2:06 p.m., Ajay Yadava wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40638/
> ---
> 
> (Updated Dec. 8, 2015, 2:06 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-879
> https://issues.apache.org/jira/browse/LENS-879
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Base framework for lens scheduler service and job definition.
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java 
> PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInfo.java 
> PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java
>  PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceInfo.java
>  PRE-CREATION 
>   lens-api/src/main/resources/scheduler-job-0.1.xsd PRE-CREATION 
>   lens-examples/src/main/resources/example-job.xml PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java
>  9f48d27 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobStats.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java
>  3389aba 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java
>  24949bd 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java
>  PRE-CREATION 
>   lens-server/src/main/resources/lensserver-default.xml 39b72dc 
>   
> lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java
>  e11413e 
>   pom.xml 732b3bb 
>   src/site/apt/admin/config.apt bcf4b7d 
> 
> Diff: https://reviews.apache.org/r/40638/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ajay Yadava
> 
>

Re: Review Request 40638: Base framework for scheduler.

2015-12-09 Thread Ajay Yadava 


> On Dec. 10, 2015, 6:01 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/resources/scheduler-job-0.1.xsd, line 153
> > 
> >
> > Needs update

Sorry, I fixed it but looks like I missed it in the patch. willf ix.


> On Dec. 10, 2015, 6:01 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/resources/scheduler-job-0.1.xsd, lines 102-106
> > 
> >
> > Please add comments for these also.

will do.


> On Dec. 10, 2015, 6:01 a.m., Amareshwari Sriramadasu wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java,
> >  line 57
> > 
> >
> > Shouldnt this take SchedulerJobHandle as the param?

Yes. Will fix.


> On Dec. 10, 2015, 6:01 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceInfo.java,
> >  line 34
> > 
> >
> > Shouldnt we add its corresponding scheduleJobHandle also ?

Makes sense. Will add.


> On Dec. 10, 2015, 6:01 a.m., Amareshwari Sriramadasu wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java,
> >  line 47
> > 
> >
> > return object should be SchedulerJobHandle for all three methods below.

Will fix everywhere.


- Ajay


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40638/#review109690
---


On Dec. 8, 2015, 2:06 p.m., Ajay Yadava wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40638/
> ---
> 
> (Updated Dec. 8, 2015, 2:06 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-879
> https://issues.apache.org/jira/browse/LENS-879
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Base framework for lens scheduler service and job definition.
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java 
> PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInfo.java 
> PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java
>  PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceInfo.java
>  PRE-CREATION 
>   lens-api/src/main/resources/scheduler-job-0.1.xsd PRE-CREATION 
>   lens-examples/src/main/resources/example-job.xml PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java
>  9f48d27 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobStats.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java
>  3389aba 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java
>  24949bd 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java
>  PRE-CREATION 
>   lens-server/src/main/resources/lensserver-default.xml 39b72dc 
>   
> lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java
>  e11413e 
>   pom.xml 732b3bb 
>   src/site/apt/admin/config.apt bcf4b7d 
> 
> Diff: https://reviews.apache.org/r/40638/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ajay Yadava
> 
>

Re: Review Request 40638: Base framework for scheduler.

2015-12-08 Thread Ajay Yadava 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40638/
---

(Updated Dec. 8, 2015, 2:06 p.m.)


Review request for lens.


Changes
---

Addressed the latest review comments.


Bugs: LENS-879
https://issues.apache.org/jira/browse/LENS-879


Repository: lens


Description
---

Base framework for lens scheduler service and job definition.


Diffs (updated)
-

  lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java 
PRE-CREATION 
  lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInfo.java 
PRE-CREATION 
  
lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java
 PRE-CREATION 
  
lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceInfo.java 
PRE-CREATION 
  lens-api/src/main/resources/scheduler-job-0.1.xsd PRE-CREATION 
  lens-examples/src/main/resources/example-job.xml PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java
 9f48d27 
  
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobStats.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java
 PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java
 3389aba 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java
 24949bd 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java
 PRE-CREATION 
  lens-server/src/main/resources/lensserver-default.xml 39b72dc 
  
lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java
 e11413e 
  pom.xml 732b3bb 
  src/site/apt/admin/config.apt bcf4b7d 

Diff: https://reviews.apache.org/r/40638/diff/


Testing
---


Thanks,

Ajay Yadava

Re: Review Request 40638: Base framework for scheduler.

2015-12-08 Thread Ajay Yadava 


> On Nov. 30, 2015, 5:16 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInfo.java, 
> > line 38
> > 
> >
> > Is this not ScheduleJobHandle ?

Yes. It changed after review request and I forgot to update. Will fix it.


> On Nov. 30, 2015, 5:16 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInfo.java, 
> > lines 47-87
> > 
> >
> > I think all of these fields should be replaced with single object XJob

Agreed, will fix.


> On Nov. 30, 2015, 5:16 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceInfo.java,
> >  line 33
> > 
> >
> > Should be SchedulerJobInstanceHandle

Yes. Will fix it.


> On Nov. 30, 2015, 5:16 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceInfo.java,
> >  line 36
> > 
> >
> > Why is this new session handle. Should be "session handle in which 
> > instance was run"

The thought was that the setter gets the new value which needs to be set.


> On Nov. 30, 2015, 5:16 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceInfo.java,
> >  line 39
> > 
> >
> > Return LensSessionHandle ?

Will fix.


> On Nov. 30, 2015, 5:16 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceInfo.java,
> >  line 42
> > 
> >
> > StartTime - when the instance started to run.
> > 
> > I see all other comments are also saying the values to be set. Instead 
> > they are actually when it ran.

These are the documentations which will be generated on the setter methods. You 
pass in the value which you want to be set and hence the language. @returns 
documentation is exactly what you have suggested. I think it is correct, let me 
know if you think otherwise.


> On Nov. 30, 2015, 5:16 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/resources/scheduler-job-0.1.xsd, line 47
> > 
> >
> > Should be "Name of the scheduled job" ?

Yes. Will update.


> On Nov. 30, 2015, 5:16 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/resources/scheduler-job-0.1.xsd, line 102
> > 
> >
> > If we are separating session into separate type, resource_path should 
> > be actually part of session.

Sure. Fixed it.


> On Nov. 30, 2015, 5:16 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/resources/scheduler-job-0.1.xsd, line 117
> > 
> >
> > Can we be consistent with names for types and elements? All types can 
> > start with x_type and elements would contain actual names and no x_ ?

Definitely. Sorry for the oversight.


> On Nov. 30, 2015, 5:16 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/resources/scheduler-job-0.1.xsd, line 153
> > 
> >
> > Comment needs to be updated.

Will fix.


> On Nov. 30, 2015, 5:16 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/resources/scheduler-job-0.1.xsd, line 122
> > 
> >
> > Can you change the comment to "Database name to be used in session" ?

Sure. Will update.


> On Nov. 30, 2015, 5:16 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceInfo.java,
> >  line 81
> > 
> >
> > I dont think we would allow modification of an instance, so should not 
> > be required.

Yes. will fix


> On Nov. 30, 2015, 5:16 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInfo.java, 
> > line 55
> > 
> >
> > we should return XJob instead of Clob.

Makes sense, will fix.


> On Nov. 30, 2015, 5:16 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInfo.java, 
> > line 63
> > 
> >
> > Instead of Clob we should return correspondig objects. Applies for all 
> > Clob objects.

Re: Review Request 40638: Base framework for scheduler.

2015-11-27 Thread Ajay Yadava 


> On Nov. 25, 2015, 7:11 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/resources/job-0.1.xsd, line 35
> > 
> >
> > Please add  for all elements and 
> > attributes.
> > 
> > See cube-0.1.xsd, for example.
> 
> Ajay Yadava wrote:
>  is added at the definition of type not at the usage of 
> type, it is already there for this type(and most others). I will again do a 
> thorough check again if I have missed something.
> 
> Amareshwari Sriramadasu wrote:
> I feel xs:annotation should be added for elements, because type 
> documentation will be very much generic and context will be misisng. For ex: 
> map_type is saying key, value pairs. session_conf which is a map_type element 
> needs further explanation wrt what the configuration is for. Same applies to 
> session_db and so on.

Sorry I didn't understand what you meant the first time. Got it. Will add 
documentation.


- Ajay


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40638/#review107921
---


On Nov. 25, 2015, 3:57 p.m., Ajay Yadava wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40638/
> ---
> 
> (Updated Nov. 25, 2015, 3:57 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-879
> https://issues.apache.org/jira/browse/LENS-879
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Base framework for lens scheduler service and job definition.
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java 
> PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java
>  PRE-CREATION 
>   lens-api/src/main/resources/example-job.xml PRE-CREATION 
>   lens-api/src/main/resources/scheduler-job-0.1.xsd PRE-CREATION 
>   lens-examples/src/main/resources/example-job.xml PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/JobStats.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java
>  9f48d27 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInfo.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceInfo.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java
>  3389aba 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java
>  24949bd 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java
>  PRE-CREATION 
>   lens-server/src/main/resources/lensserver-default.xml 5f268cb 
>   
> lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java
>  e11413e 
>   pom.xml b19857f 
>   src/site/apt/admin/config.apt 88c1489 
> 
> Diff: https://reviews.apache.org/r/40638/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ajay Yadava
> 
>

Re: Review Request 40638: Base framework for scheduler.

2015-11-27 Thread Ajay Yadava 


> On Nov. 27, 2015, 11:03 a.m., Rajat Khandelwal wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/JobStats.java,
> >  line 27
> > 
> >
> > `SchedulerJobStats`?

Will rename.


- Ajay


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40638/#review108210
---


On Nov. 25, 2015, 3:57 p.m., Ajay Yadava wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40638/
> ---
> 
> (Updated Nov. 25, 2015, 3:57 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-879
> https://issues.apache.org/jira/browse/LENS-879
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Base framework for lens scheduler service and job definition.
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java 
> PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java
>  PRE-CREATION 
>   lens-api/src/main/resources/example-job.xml PRE-CREATION 
>   lens-api/src/main/resources/scheduler-job-0.1.xsd PRE-CREATION 
>   lens-examples/src/main/resources/example-job.xml PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/JobStats.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java
>  9f48d27 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInfo.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceInfo.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java
>  3389aba 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java
>  24949bd 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java
>  PRE-CREATION 
>   lens-server/src/main/resources/lensserver-default.xml 5f268cb 
>   
> lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java
>  e11413e 
>   pom.xml b19857f 
>   src/site/apt/admin/config.apt 88c1489 
> 
> Diff: https://reviews.apache.org/r/40638/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ajay Yadava
> 
>

Re: Review Request 40638: Base framework for scheduler.

2015-11-27 Thread Ajay Yadava 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40638/
---

(Updated Nov. 27, 2015, 7:46 p.m.)


Review request for lens.


Changes
---

Addressed the review comments.


Bugs: LENS-879
https://issues.apache.org/jira/browse/LENS-879


Repository: lens


Description
---

Base framework for lens scheduler service and job definition.


Diffs (updated)
-

  lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java 
PRE-CREATION 
  lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInfo.java 
PRE-CREATION 
  
lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java
 PRE-CREATION 
  
lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceInfo.java 
PRE-CREATION 
  lens-api/src/main/resources/scheduler-job-0.1.xsd PRE-CREATION 
  lens-examples/src/main/resources/example-job.xml PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java
 9f48d27 
  
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobStats.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java
 PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java
 3389aba 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java
 24949bd 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java
 PRE-CREATION 
  lens-server/src/main/resources/lensserver-default.xml 5f268cb 
  
lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java
 e11413e 
  pom.xml b19857f 
  src/site/apt/admin/config.apt 88c1489 

Diff: https://reviews.apache.org/r/40638/diff/


Testing
---


Thanks,

Ajay Yadava

Re: Review Request 40638: Base framework for scheduler.

2015-11-27 Thread Rajat Khandelwal 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40638/#review108210
---



lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/JobStats.java
 (line 27)


`SchedulerJobStats`?


- Rajat Khandelwal


On Nov. 25, 2015, 9:27 p.m., Ajay Yadava wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40638/
> ---
> 
> (Updated Nov. 25, 2015, 9:27 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-879
> https://issues.apache.org/jira/browse/LENS-879
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Base framework for lens scheduler service and job definition.
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java 
> PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java
>  PRE-CREATION 
>   lens-api/src/main/resources/example-job.xml PRE-CREATION 
>   lens-api/src/main/resources/scheduler-job-0.1.xsd PRE-CREATION 
>   lens-examples/src/main/resources/example-job.xml PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/JobStats.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java
>  9f48d27 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInfo.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceInfo.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java
>  3389aba 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java
>  24949bd 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java
>  PRE-CREATION 
>   lens-server/src/main/resources/lensserver-default.xml 5f268cb 
>   
> lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java
>  e11413e 
>   pom.xml b19857f 
>   src/site/apt/admin/config.apt 88c1489 
> 
> Diff: https://reviews.apache.org/r/40638/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ajay Yadava
> 
>

Re: Review Request 40638: Base framework for scheduler.

2015-11-27 Thread Amareshwari Sriramadasu 


> On Nov. 26, 2015, 6:51 a.m., Rajat Khandelwal wrote:
> > lens-api/src/main/resources/example-job.xml, lines 27-35
> > 
> >
> > Feels like keeping two conf is only useful when they are present on 
> > different heirarchies. 
> > 
> > If we are creating session just to run a single query, then there is no 
> > point of having session level and query level configurations. One 
> > configuration should be enough
> > 
> > Thinking in those terms, an execution shouldn't be a `query`, it should 
> > be a session. Inside that session there can be multiple actions, which 
> > might decide the next actions. Any of those actions can be a `query` 
> > action. 
> > 
> > Thoughts?
> 
> Amareshwari Sriramadasu wrote:
> I agree there can be many actions in session. But we cannot support each 
> action through xsd. I think what we can support is List of REST Actions, we 
> would be generic. Whether we want to support Lens REST actions to be 
> schedulable or not is something debatable. But can be done later.
> 
> We can start with query as one execution and minimally run on a session 
> in a db, as it is put up now. 
> 
> Coming back to merging session conf and query conf into single one, it 
> should be fine as long as it is single query, but we should not take away the 
> fact that query conf can be different for each query when there are multiple 
> queries. So, I'm fine merging them into one in this jira.
> 
> Rajat Khandelwal wrote:
> Considering the important distinction of session conf and query conf, 
> would the following make more sense?
> 
> ```
>
> 
> http://192.168.30.30:5000/
> 
> sessionKey1
> sessionValue1
> 
> 
> 
> select name from name_table;
> 
> queryKey1
> queryValue1
> 
> 
> 
> 
> ```
> 
> As a sequence of two actions, open a session with a conf and run a query 
> with a conf. 
> 
> The following might also make sense:
> 
> ```
>
> 
> session1
> http://192.168.30.30:5000/
> 
> sessionKey1
> sessionValue1
> 
> 
> 
> session1
> select name from name_table;
> 
> queryKey1
> queryValue1
> 
> 
> 
> 
> ```
> 
> With this you can open multiple sessions and associate any other action 
> to take place in any of the sessions. Also, it's more explicit. Here, there 
> will be an implicit parallel execution of actions of a different sessions. 
> 
> 
> Third option is, we note that any execution will happen in a session, so:
> 
> ```
>
> 
> http://192.168.30.30:5000/
> 
> sessionKey1
> sessionValue1
> 
> 
> 
> session1
> select name from name_table;
> 
> queryKey1
> queryValue1
> 
> 
> 
> 
> ```
> Here, opening multiple sessions will happen thorugh multiple `execution` 
> tags. 
> 
> 
> Would like to hear the views from implementation and use-case standpoints.
> 
> Rajat Khandelwal wrote:
> Come to think of it, first and third are functionaly equivalent.
> 
> Ajay Yadava wrote:
> I am still not clear on why multiple sessions are required, won't they 
> all be from same user?
> 
> Amareshwari Sriramadasu wrote:
> I agree with Ajay, one schedule would only work with one session, I don't 
> think we need to support multiple sessions at all. 
> 
> Let us keep the version1 simple with one session and one query.
> 
> Ajay Yadava wrote:
> Is it possible that we can unblock this JIRA and discuss the use case and 
> requirements for multiple actions/sessions in parallel? I will be happy to 
> incorporate any changes which might result as part of that discussion.

Rajat, are you suggesting any more changes in this jira? If not, can this be 
dropped?


- Amareshwari


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40638/#review108090
---


On Nov. 25, 2015, 3:57 p.m., Ajay Yadava wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
>

Re: Review Request 40638: Base framework for scheduler.

2015-11-27 Thread Amareshwari Sriramadasu 


> On Nov. 25, 2015, 7:11 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/resources/job-0.1.xsd, line 35
> > 
> >
> > Please add  for all elements and 
> > attributes.
> > 
> > See cube-0.1.xsd, for example.
> 
> Ajay Yadava wrote:
>  is added at the definition of type not at the usage of 
> type, it is already there for this type(and most others). I will again do a 
> thorough check again if I have missed something.

I feel xs:annotation should be added for elements, because type documentation 
will be very much generic and context will be misisng. For ex: map_type is 
saying key, value pairs. session_conf which is a map_type element needs further 
explanation wrt what the configuration is for. Same applies to session_db and 
so on.


- Amareshwari


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40638/#review107921
---


On Nov. 25, 2015, 3:57 p.m., Ajay Yadava wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40638/
> ---
> 
> (Updated Nov. 25, 2015, 3:57 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-879
> https://issues.apache.org/jira/browse/LENS-879
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Base framework for lens scheduler service and job definition.
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java 
> PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java
>  PRE-CREATION 
>   lens-api/src/main/resources/example-job.xml PRE-CREATION 
>   lens-api/src/main/resources/scheduler-job-0.1.xsd PRE-CREATION 
>   lens-examples/src/main/resources/example-job.xml PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/JobStats.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java
>  9f48d27 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInfo.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceInfo.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java
>  3389aba 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java
>  24949bd 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java
>  PRE-CREATION 
>   lens-server/src/main/resources/lensserver-default.xml 5f268cb 
>   
> lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java
>  e11413e 
>   pom.xml b19857f 
>   src/site/apt/admin/config.apt 88c1489 
> 
> Diff: https://reviews.apache.org/r/40638/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ajay Yadava
> 
>

Re: Review Request 40638: Base framework for scheduler.

2015-11-27 Thread Amareshwari Sriramadasu 


> On Nov. 27, 2015, 5:25 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java, 
> > line 42
> > 
> >
> > I feel we should call the class ScheduleHandle instead of 
> > SchedulerJobHandler. 
> > 
> > and similarly others. what do you think?
> 
> Ajay Yadava wrote:
> Do you mean to use Schedule instead of SchedulerJob everywhere? I had 
> given my reasons above for not incorporating those changes earlier. If it 
> still looks out of place to you then I am happy to change it. Just let me 
> know what would you like for the following:
> SchdulerJob -> ?
> SchedulerJobInstance -> ?

OK. Thinking again, current naming seems fine. Dropping my comment.


- Amareshwari


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40638/#review108188
---


On Nov. 25, 2015, 3:57 p.m., Ajay Yadava wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40638/
> ---
> 
> (Updated Nov. 25, 2015, 3:57 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-879
> https://issues.apache.org/jira/browse/LENS-879
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Base framework for lens scheduler service and job definition.
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java 
> PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java
>  PRE-CREATION 
>   lens-api/src/main/resources/example-job.xml PRE-CREATION 
>   lens-api/src/main/resources/scheduler-job-0.1.xsd PRE-CREATION 
>   lens-examples/src/main/resources/example-job.xml PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/JobStats.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java
>  9f48d27 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInfo.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceInfo.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java
>  3389aba 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java
>  24949bd 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java
>  PRE-CREATION 
>   lens-server/src/main/resources/lensserver-default.xml 5f268cb 
>   
> lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java
>  e11413e 
>   pom.xml b19857f 
>   src/site/apt/admin/config.apt 88c1489 
> 
> Diff: https://reviews.apache.org/r/40638/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ajay Yadava
> 
>

Re: Review Request 40638: Base framework for scheduler.

2015-11-26 Thread Rajat Khandelwal 


> On Nov. 26, 2015, 12:21 p.m., Rajat Khandelwal wrote:
> > lens-api/src/main/resources/example-job.xml, lines 27-35
> > 
> >
> > Feels like keeping two conf is only useful when they are present on 
> > different heirarchies. 
> > 
> > If we are creating session just to run a single query, then there is no 
> > point of having session level and query level configurations. One 
> > configuration should be enough
> > 
> > Thinking in those terms, an execution shouldn't be a `query`, it should 
> > be a session. Inside that session there can be multiple actions, which 
> > might decide the next actions. Any of those actions can be a `query` 
> > action. 
> > 
> > Thoughts?
> 
> Amareshwari Sriramadasu wrote:
> I agree there can be many actions in session. But we cannot support each 
> action through xsd. I think what we can support is List of REST Actions, we 
> would be generic. Whether we want to support Lens REST actions to be 
> schedulable or not is something debatable. But can be done later.
> 
> We can start with query as one execution and minimally run on a session 
> in a db, as it is put up now. 
> 
> Coming back to merging session conf and query conf into single one, it 
> should be fine as long as it is single query, but we should not take away the 
> fact that query conf can be different for each query when there are multiple 
> queries. So, I'm fine merging them into one in this jira.

Considering the important distinction of session conf and query conf, would the 
following make more sense?

```
   

http://192.168.30.30:5000/

sessionKey1
sessionValue1



select name from name_table;

queryKey1
queryValue1




```

As a sequence of two actions, open a session with a conf and run a query with a 
conf. 

The following might also make sense:

```
   

session1
http://192.168.30.30:5000/

sessionKey1
sessionValue1



session1
select name from name_table;

queryKey1
queryValue1




```

With this you can open multiple sessions and associate any other action to take 
place in any of the sessions. Also, it's more explicit. Here, there will be an 
implicit parallel execution of actions of a different sessions. 


Third option is, we note that any execution will happen in a session, so:

```
   

http://192.168.30.30:5000/

sessionKey1
sessionValue1



session1
select name from name_table;

queryKey1
queryValue1




```
Here, opening multiple sessions will happen thorugh multiple `execution` tags. 


Would like to hear the views from implementation and use-case standpoints.


- Rajat


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40638/#review108090
---


On Nov. 25, 2015, 9:27 p.m., Ajay Yadava wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40638/
> ---
> 
> (Updated Nov. 25, 2015, 9:27 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-879
> https://issues.apache.org/jira/browse/LENS-879
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Base framework for lens scheduler service and job definition.
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java 
> PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java
>  PRE-CREATION 
>   lens-api/src/main/resources/example-job.xml PRE-CREATION 
>   lens-api/src/main/resources/scheduler-job-0.1.xsd PRE-CREATION 
>   lens-examples/src/main/resources/example-job.xml PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/JobStats.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java
>  9f48d27 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInfo.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceInfo.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java

Re: Review Request 40638: Base framework for scheduler.

2015-11-26 Thread Rajat Khandelwal 


> On Nov. 26, 2015, 12:21 p.m., Rajat Khandelwal wrote:
> > lens-api/src/main/resources/example-job.xml, lines 27-35
> > 
> >
> > Feels like keeping two conf is only useful when they are present on 
> > different heirarchies. 
> > 
> > If we are creating session just to run a single query, then there is no 
> > point of having session level and query level configurations. One 
> > configuration should be enough
> > 
> > Thinking in those terms, an execution shouldn't be a `query`, it should 
> > be a session. Inside that session there can be multiple actions, which 
> > might decide the next actions. Any of those actions can be a `query` 
> > action. 
> > 
> > Thoughts?
> 
> Amareshwari Sriramadasu wrote:
> I agree there can be many actions in session. But we cannot support each 
> action through xsd. I think what we can support is List of REST Actions, we 
> would be generic. Whether we want to support Lens REST actions to be 
> schedulable or not is something debatable. But can be done later.
> 
> We can start with query as one execution and minimally run on a session 
> in a db, as it is put up now. 
> 
> Coming back to merging session conf and query conf into single one, it 
> should be fine as long as it is single query, but we should not take away the 
> fact that query conf can be different for each query when there are multiple 
> queries. So, I'm fine merging them into one in this jira.
> 
> Rajat Khandelwal wrote:
> Considering the important distinction of session conf and query conf, 
> would the following make more sense?
> 
> ```
>
> 
> http://192.168.30.30:5000/
> 
> sessionKey1
> sessionValue1
> 
> 
> 
> select name from name_table;
> 
> queryKey1
> queryValue1
> 
> 
> 
> 
> ```
> 
> As a sequence of two actions, open a session with a conf and run a query 
> with a conf. 
> 
> The following might also make sense:
> 
> ```
>
> 
> session1
> http://192.168.30.30:5000/
> 
> sessionKey1
> sessionValue1
> 
> 
> 
> session1
> select name from name_table;
> 
> queryKey1
> queryValue1
> 
> 
> 
> 
> ```
> 
> With this you can open multiple sessions and associate any other action 
> to take place in any of the sessions. Also, it's more explicit. Here, there 
> will be an implicit parallel execution of actions of a different sessions. 
> 
> 
> Third option is, we note that any execution will happen in a session, so:
> 
> ```
>
> 
> http://192.168.30.30:5000/
> 
> sessionKey1
> sessionValue1
> 
> 
> 
> session1
> select name from name_table;
> 
> queryKey1
> queryValue1
> 
> 
> 
> 
> ```
> Here, opening multiple sessions will happen thorugh multiple `execution` 
> tags. 
> 
> 
> Would like to hear the views from implementation and use-case standpoints.

Come to think of it, first and third are functionaly equivalent.


- Rajat


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40638/#review108090
---


On Nov. 25, 2015, 9:27 p.m., Ajay Yadava wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40638/
> ---
> 
> (Updated Nov. 25, 2015, 9:27 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-879
> https://issues.apache.org/jira/browse/LENS-879
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Base framework for lens scheduler service and job definition.
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java 
> PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java
>  PRE-CREATION 
>   lens-api/src/main/resources/example-job.xml PRE-CREATION 
>   lens-api/src/main/resources/scheduler-job-0.1.xsd PRE-CREATION 
>

Re: Review Request 40638: Base framework for scheduler.

2015-11-26 Thread Amareshwari Sriramadasu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40638/#review108188
---



lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java (line 
42)


I feel we should call the class ScheduleHandle instead of 
SchedulerJobHandler. 

and similarly others. what do you think?



lens-api/src/main/resources/example-job.xml (line 1)


Seems forgot to remove the class from lens-api.



lens-examples/src/main/resources/example-job.xml (line 31)


session_db here is the db name : like default or db1 or mydb or any



lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInfo.java
 (line 29)


Is this the class returned to client. It should be moved to lens-api module



lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceInfo.java
 (line 27)


move to lens-api module


- Amareshwari Sriramadasu


On Nov. 25, 2015, 3:57 p.m., Ajay Yadava wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40638/
> ---
> 
> (Updated Nov. 25, 2015, 3:57 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-879
> https://issues.apache.org/jira/browse/LENS-879
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Base framework for lens scheduler service and job definition.
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java 
> PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java
>  PRE-CREATION 
>   lens-api/src/main/resources/example-job.xml PRE-CREATION 
>   lens-api/src/main/resources/scheduler-job-0.1.xsd PRE-CREATION 
>   lens-examples/src/main/resources/example-job.xml PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/JobStats.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java
>  9f48d27 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInfo.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceInfo.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java
>  3389aba 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java
>  24949bd 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java
>  PRE-CREATION 
>   lens-server/src/main/resources/lensserver-default.xml 5f268cb 
>   
> lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java
>  e11413e 
>   pom.xml b19857f 
>   src/site/apt/admin/config.apt 88c1489 
> 
> Diff: https://reviews.apache.org/r/40638/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ajay Yadava
> 
>

Re: Review Request 40638: Base framework for scheduler.

2015-11-26 Thread Ajay Yadava 


> On Nov. 26, 2015, 6:51 a.m., Rajat Khandelwal wrote:
> > lens-api/src/main/resources/example-job.xml, lines 27-35
> > 
> >
> > Feels like keeping two conf is only useful when they are present on 
> > different heirarchies. 
> > 
> > If we are creating session just to run a single query, then there is no 
> > point of having session level and query level configurations. One 
> > configuration should be enough
> > 
> > Thinking in those terms, an execution shouldn't be a `query`, it should 
> > be a session. Inside that session there can be multiple actions, which 
> > might decide the next actions. Any of those actions can be a `query` 
> > action. 
> > 
> > Thoughts?
> 
> Amareshwari Sriramadasu wrote:
> I agree there can be many actions in session. But we cannot support each 
> action through xsd. I think what we can support is List of REST Actions, we 
> would be generic. Whether we want to support Lens REST actions to be 
> schedulable or not is something debatable. But can be done later.
> 
> We can start with query as one execution and minimally run on a session 
> in a db, as it is put up now. 
> 
> Coming back to merging session conf and query conf into single one, it 
> should be fine as long as it is single query, but we should not take away the 
> fact that query conf can be different for each query when there are multiple 
> queries. So, I'm fine merging them into one in this jira.
> 
> Rajat Khandelwal wrote:
> Considering the important distinction of session conf and query conf, 
> would the following make more sense?
> 
> ```
>
> 
> http://192.168.30.30:5000/
> 
> sessionKey1
> sessionValue1
> 
> 
> 
> select name from name_table;
> 
> queryKey1
> queryValue1
> 
> 
> 
> 
> ```
> 
> As a sequence of two actions, open a session with a conf and run a query 
> with a conf. 
> 
> The following might also make sense:
> 
> ```
>
> 
> session1
> http://192.168.30.30:5000/
> 
> sessionKey1
> sessionValue1
> 
> 
> 
> session1
> select name from name_table;
> 
> queryKey1
> queryValue1
> 
> 
> 
> 
> ```
> 
> With this you can open multiple sessions and associate any other action 
> to take place in any of the sessions. Also, it's more explicit. Here, there 
> will be an implicit parallel execution of actions of a different sessions. 
> 
> 
> Third option is, we note that any execution will happen in a session, so:
> 
> ```
>
> 
> http://192.168.30.30:5000/
> 
> sessionKey1
> sessionValue1
> 
> 
> 
> session1
> select name from name_table;
> 
> queryKey1
> queryValue1
> 
> 
> 
> 
> ```
> Here, opening multiple sessions will happen thorugh multiple `execution` 
> tags. 
> 
> 
> Would like to hear the views from implementation and use-case standpoints.
> 
> Rajat Khandelwal wrote:
> Come to think of it, first and third are functionaly equivalent.

I am still not clear on why multiple sessions are required, won't they all be 
from same user?


- Ajay


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40638/#review108090
---


On Nov. 25, 2015, 3:57 p.m., Ajay Yadava wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40638/
> ---
> 
> (Updated Nov. 25, 2015, 3:57 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-879
> https://issues.apache.org/jira/browse/LENS-879
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Base framework for lens scheduler service and job definition.
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java 
> PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java
>  PRE-CREATION 
>   lens-api/src/main/resources/example-job.xml

Re: Review Request 40638: Base framework for scheduler.

2015-11-25 Thread Ajay Yadava 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40638/
---

(Updated Nov. 25, 2015, 3:57 p.m.)


Review request for lens.


Changes
---

Addressed review comments.


Bugs: LENS-879
https://issues.apache.org/jira/browse/LENS-879


Repository: lens


Description
---

Base framework for lens scheduler service and job definition.


Diffs (updated)
-

  lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java 
PRE-CREATION 
  
lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java
 PRE-CREATION 
  lens-api/src/main/resources/example-job.xml PRE-CREATION 
  lens-api/src/main/resources/scheduler-job-0.1.xsd PRE-CREATION 
  lens-examples/src/main/resources/example-job.xml PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/JobStats.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java
 9f48d27 
  
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInfo.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceInfo.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java
 PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java
 3389aba 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java
 24949bd 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java
 PRE-CREATION 
  lens-server/src/main/resources/lensserver-default.xml 5f268cb 
  
lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java
 e11413e 
  pom.xml b19857f 
  src/site/apt/admin/config.apt 88c1489 

Diff: https://reviews.apache.org/r/40638/diff/


Testing
---


Thanks,

Ajay Yadava

Re: Review Request 40638: Base framework for scheduler.

2015-11-25 Thread Ajay Yadava 


> On Nov. 25, 2015, 7:11 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/java/org/apache/lens/api/util/DateUtil.java, line 56
> > 
> >
> > Instead of RuntimeException, can they defined as LensException or 
> > LensAPIException with error codes added?
> 
> Ajay Yadava wrote:
> Makes sense, will add.

Removed these classes and used xs:dateTime


- Ajay


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40638/#review107921
---


On Nov. 25, 2015, 3:57 p.m., Ajay Yadava wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40638/
> ---
> 
> (Updated Nov. 25, 2015, 3:57 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-879
> https://issues.apache.org/jira/browse/LENS-879
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Base framework for lens scheduler service and job definition.
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java 
> PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java
>  PRE-CREATION 
>   lens-api/src/main/resources/example-job.xml PRE-CREATION 
>   lens-api/src/main/resources/scheduler-job-0.1.xsd PRE-CREATION 
>   lens-examples/src/main/resources/example-job.xml PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/JobStats.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java
>  9f48d27 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInfo.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceInfo.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java
>  3389aba 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java
>  24949bd 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java
>  PRE-CREATION 
>   lens-server/src/main/resources/lensserver-default.xml 5f268cb 
>   
> lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java
>  e11413e 
>   pom.xml b19857f 
>   src/site/apt/admin/config.apt 88c1489 
> 
> Diff: https://reviews.apache.org/r/40638/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ajay Yadava
> 
>

Re: Review Request 40638: Base framework for scheduler.

2015-11-25 Thread Ajay Yadava 


> On Nov. 26, 2015, 6:51 a.m., Rajat Khandelwal wrote:
> > pom.xml, line 61
> > 
> >
> > Can you mention which new feature you are using?
> > 
> > And please verify this version is backward compatible.

@Utility

Even otherwise it is good to stay on the latest whenever feasible. I went 
through the change logs before using it and I didn't see any backward 
incompatible changes.


- Ajay


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40638/#review108090
---


On Nov. 25, 2015, 3:57 p.m., Ajay Yadava wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40638/
> ---
> 
> (Updated Nov. 25, 2015, 3:57 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-879
> https://issues.apache.org/jira/browse/LENS-879
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Base framework for lens scheduler service and job definition.
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java 
> PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java
>  PRE-CREATION 
>   lens-api/src/main/resources/example-job.xml PRE-CREATION 
>   lens-api/src/main/resources/scheduler-job-0.1.xsd PRE-CREATION 
>   lens-examples/src/main/resources/example-job.xml PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/JobStats.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java
>  9f48d27 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInfo.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceInfo.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java
>  3389aba 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java
>  24949bd 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java
>  PRE-CREATION 
>   lens-server/src/main/resources/lensserver-default.xml 5f268cb 
>   
> lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java
>  e11413e 
>   pom.xml b19857f 
>   src/site/apt/admin/config.apt 88c1489 
> 
> Diff: https://reviews.apache.org/r/40638/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ajay Yadava
> 
>

Re: Review Request 40638: Base framework for scheduler.

2015-11-25 Thread Ajay Yadava 


> On Nov. 24, 2015, 1:33 p.m., Rajat Khandelwal wrote:
> > lens-api/src/main/resources/example-job.xml, line 26
> > 
> >
> > remove semicolon. And we should give cube queries in examples.

Will fix.


> On Nov. 24, 2015, 1:33 p.m., Rajat Khandelwal wrote:
> > lens-api/src/main/java/org/apache/lens/api/util/DateUtil.java, line 32
> > 
> >
> > We already have a class with this name in lens-cube module. Maybe we 
> > can re-think on the name?

As long as these are in different packages it should be fine.


> On Nov. 24, 2015, 1:33 p.m., Rajat Khandelwal wrote:
> > lens-api/src/main/resources/example-job.xml, line 22
> > 
> >
> > Maybe this can be in lens-examples module

Will move.


> On Nov. 24, 2015, 1:33 p.m., Rajat Khandelwal wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInfo.java,
> >  line 31
> > 
> >
> > What are intended usages of this class? I couldn't find any.

This was slightly future looking. Amareshwari has also pointed a use case for 
the same.


> On Nov. 24, 2015, 1:33 p.m., Rajat Khandelwal wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceInfo.java,
> >  line 28
> > 
> >
> > see https://projectlombok.org/features/Data.html

Will fix.


- Ajay


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40638/#review107770
---


On Nov. 24, 2015, 12:20 p.m., Ajay Yadava wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40638/
> ---
> 
> (Updated Nov. 24, 2015, 12:20 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-879
> https://issues.apache.org/jira/browse/LENS-879
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Base framework for lens scheduler service and job definition.
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/util/DateUtil.java PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/util/DateValidator.java 
> PRE-CREATION 
>   lens-api/src/main/resources/example-job.xml PRE-CREATION 
>   lens-api/src/main/resources/job-0.1.xsd PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/JobStats.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java
>  9f48d27 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/Scheduler.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInfo.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceInfo.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java
>  3389aba 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java
>  24949bd 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerService.java
>  PRE-CREATION 
>   lens-server/src/main/resources/lensserver-default.xml 5f268cb 
>   
> lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java
>  e11413e 
>   pom.xml b19857f 
>   src/site/apt/admin/config.apt 88c1489 
> 
> Diff: https://reviews.apache.org/r/40638/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ajay Yadava
> 
>

Re: Review Request 40638: Base framework for scheduler.

2015-11-24 Thread Amareshwari Sriramadasu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40638/#review107921
---



lens-api/src/main/java/org/apache/lens/api/util/DateUtil.java (line 32)


Can you add comments on what each method is for here? Since this goes in 
lens-api, i'm thinking you are planning to use all these on client side.

If validation happens server side, we should move the class to 
lens-server-api



lens-api/src/main/java/org/apache/lens/api/util/DateUtil.java (line 56)


Instead of RuntimeException, can they defined as LensException or 
LensAPIException with error codes added?



lens-api/src/main/resources/example-job.xml (line 43)


start_time says it is starting from 2014, but cron says run in 2005. We 
should change this to be a different year - something between start and end



lens-api/src/main/resources/job-0.1.xsd (line 1)


file name as job-0.1.xsd seems very generic. We should have it as 
schedule-0.1.xsd or schedule-job-0.1.xsd



lens-api/src/main/resources/job-0.1.xsd (line 35)


Please add  for all elements and 
attributes.

See cube-0.1.xsd, for example.



lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/Scheduler.java
 (line 32)


I would say lets have class name as SchedulerService for interface and 
SchedulerServiceImpl for implementation to be consistent with other classes.



lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/Scheduler.java
 (line 67)


Please explain return value for all methods



lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/Scheduler.java
 (line 70)


Instead of simple String  for jobID, Should we have a pojo similar to 
QueryHandle ?



lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/Scheduler.java
 (line 71)


We should add getJobDetails - which returns SchedulerJobInfo.



lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/Scheduler.java
 (line 134)


why is getAllJobStats taking jobId?

Also lets add  state, user, name, long fromDate and toDate as other filters 
for getAllJobStats. You can look at getAllQueries in QueryExecutionService



lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInfo.java
 (line 31)


Shall we name the class ScheduleJobInfo instead of SchedulerJobInfo ?



lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInfo.java
 (line 75)


Please add comments to all params in all classes



lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceInfo.java
 (line 29)


ScheduleJobInstanceInfo?


- Amareshwari Sriramadasu


On Nov. 24, 2015, 12:20 p.m., Ajay Yadava wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40638/
> ---
> 
> (Updated Nov. 24, 2015, 12:20 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-879
> https://issues.apache.org/jira/browse/LENS-879
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Base framework for lens scheduler service and job definition.
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/util/DateUtil.java PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/util/DateValidator.java 
> PRE-CREATION 
>   lens-api/src/main/resources/example-job.xml PRE-CREATION 
>   lens-api/src/main/resources/job-0.1.xsd PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/JobStats.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java
>  9f48d27 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/Scheduler.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInfo.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceInfo.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java
>  3389aba

Review Request 40638: Base framework for scheduler.

2015-11-24 Thread Ajay Yadava 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40638/
---

Review request for lens.


Bugs: LENS-879
https://issues.apache.org/jira/browse/LENS-879


Repository: lens


Description
---

Base framework for lens scheduler service and job definition.


Diffs
-

  lens-api/src/main/java/org/apache/lens/api/util/DateUtil.java PRE-CREATION 
  lens-api/src/main/java/org/apache/lens/api/util/DateValidator.java 
PRE-CREATION 
  lens-api/src/main/resources/example-job.xml PRE-CREATION 
  lens-api/src/main/resources/job-0.1.xsd PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/JobStats.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java
 9f48d27 
  
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/Scheduler.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInfo.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceInfo.java
 PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java
 3389aba 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java
 24949bd 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerService.java
 PRE-CREATION 
  lens-server/src/main/resources/lensserver-default.xml 5f268cb 
  
lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java
 e11413e 
  pom.xml b19857f 
  src/site/apt/admin/config.apt 88c1489 

Diff: https://reviews.apache.org/r/40638/diff/


Testing
---


Thanks,

Ajay Yadava

Re: Review Request 40638: Base framework for scheduler.

2015-11-24 Thread Rajat Khandelwal 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40638/#review107770
---



lens-api/src/main/java/org/apache/lens/api/util/DateUtil.java (line 32)


We already have a class with this name in lens-cube module. Maybe we can 
re-think on the name?



lens-api/src/main/resources/example-job.xml (line 22)


Maybe this can be in lens-examples module



lens-api/src/main/resources/example-job.xml (line 26)


remove semicolon. And we should give cube queries in examples.



lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInfo.java
 (line 31)


What are intended usages of this class? I couldn't find any.



lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceInfo.java
 (line 28)


see https://projectlombok.org/features/Data.html


- Rajat Khandelwal


On Nov. 24, 2015, 5:50 p.m., Ajay Yadava wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40638/
> ---
> 
> (Updated Nov. 24, 2015, 5:50 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-879
> https://issues.apache.org/jira/browse/LENS-879
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Base framework for lens scheduler service and job definition.
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/util/DateUtil.java PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/util/DateValidator.java 
> PRE-CREATION 
>   lens-api/src/main/resources/example-job.xml PRE-CREATION 
>   lens-api/src/main/resources/job-0.1.xsd PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/JobStats.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java
>  9f48d27 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/Scheduler.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInfo.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceInfo.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java
>  3389aba 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java
>  24949bd 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerService.java
>  PRE-CREATION 
>   lens-server/src/main/resources/lensserver-default.xml 5f268cb 
>   
> lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java
>  e11413e 
>   pom.xml b19857f 
>   src/site/apt/admin/config.apt 88c1489 
> 
> Diff: https://reviews.apache.org/r/40638/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ajay Yadava
> 
>