[jira] [Commented] (SOLR-11879) avoid creating a new Exception object for EOFException in FastinputStream
[ https://issues.apache.org/jira/browse/SOLR-11879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353026#comment-16353026 ] ASF subversion and git services commented on SOLR-11879: Commit ab1e1550dc554aa291e69dfee154b9c7de33a145 in lucene-solr's branch refs/heads/branch_7x from [~noble.paul] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=ab1e155 ] SOLR-11879: avoid EOFException for empty input streams > avoid creating a new Exception object for EOFException in FastinputStream > - > > Key: SOLR-11879 > URL: https://issues.apache.org/jira/browse/SOLR-11879 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Environment: FastI >Reporter: Noble Paul >Assignee: Noble Paul >Priority: Trivial > Attachments: SOLR-11879.patch, SOLR-11879.patch, SOLR-11879.patch, > Screen Shot 2018-01-24 at 7.26.16 PM.png > > > FastInputStream creates and throws a new EOFException, every time an end of > stream is encountered. This is wasteful as we never use the stack trace > anywhere -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11879) avoid creating a new Exception object for EOFException in FastinputStream
[ https://issues.apache.org/jira/browse/SOLR-11879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353023#comment-16353023 ] ASF subversion and git services commented on SOLR-11879: Commit 5240f697d39d9cc235fed93e79ee25e8b8981792 in lucene-solr's branch refs/heads/master from [~noble.paul] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=5240f69 ] SOLR-11879: avoid EOFException for empty input streams > avoid creating a new Exception object for EOFException in FastinputStream > - > > Key: SOLR-11879 > URL: https://issues.apache.org/jira/browse/SOLR-11879 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Environment: FastI >Reporter: Noble Paul >Assignee: Noble Paul >Priority: Trivial > Attachments: SOLR-11879.patch, SOLR-11879.patch, SOLR-11879.patch, > Screen Shot 2018-01-24 at 7.26.16 PM.png > > > FastInputStream creates and throws a new EOFException, every time an end of > stream is encountered. This is wasteful as we never use the stack trace > anywhere -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11879) avoid creating a new Exception object for EOFException in FastinputStream
[ https://issues.apache.org/jira/browse/SOLR-11879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16345497#comment-16345497 ] Erick Erickson commented on SOLR-11879: --- [~ysee...@gmail.com] There are three places in FastInputStream that I saw on a quick glance that follow this pattern, they should all get attention. This patch eliminates the most egregious one found with JFR. WDYT about creating a new JIRA to deal with all of them in a bunch? With a couple of separate commits already, this one is starting to sprawl. It might be easier to deal with in a new JIRA. > avoid creating a new Exception object for EOFException in FastinputStream > - > > Key: SOLR-11879 > URL: https://issues.apache.org/jira/browse/SOLR-11879 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Environment: FastI >Reporter: Noble Paul >Assignee: Noble Paul >Priority: Trivial > Attachments: SOLR-11879.patch, SOLR-11879.patch, SOLR-11879.patch, > Screen Shot 2018-01-24 at 7.26.16 PM.png > > > FastInputStream creates and throws a new EOFException, every time an end of > stream is encountered. This is wasteful as we never use the stack trace > anywhere -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11879) avoid creating a new Exception object for EOFException in FastinputStream
[ https://issues.apache.org/jira/browse/SOLR-11879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344964#comment-16344964 ] Yonik Seeley commented on SOLR-11879: - We should also remove the exception being ignored as it should always be an error if it happens now? > avoid creating a new Exception object for EOFException in FastinputStream > - > > Key: SOLR-11879 > URL: https://issues.apache.org/jira/browse/SOLR-11879 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Environment: FastI >Reporter: Noble Paul >Assignee: Noble Paul >Priority: Trivial > Attachments: SOLR-11879.patch, SOLR-11879.patch, SOLR-11879.patch, > Screen Shot 2018-01-24 at 7.26.16 PM.png > > > FastInputStream creates and throws a new EOFException, every time an end of > stream is encountered. This is wasteful as we never use the stack trace > anywhere -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11879) avoid creating a new Exception object for EOFException in FastinputStream
[ https://issues.apache.org/jira/browse/SOLR-11879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344617#comment-16344617 ] ASF subversion and git services commented on SOLR-11879: Commit 1ef988a26378137b1e1f022985dacee1f557f4fc in lucene-solr's branch refs/heads/branch_7x from [~noble.paul] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=1ef988a ] SOLR-11879: moved the peek() call inside the for loop > avoid creating a new Exception object for EOFException in FastinputStream > - > > Key: SOLR-11879 > URL: https://issues.apache.org/jira/browse/SOLR-11879 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Environment: FastI >Reporter: Noble Paul >Assignee: Noble Paul >Priority: Trivial > Attachments: SOLR-11879.patch, SOLR-11879.patch, SOLR-11879.patch, > Screen Shot 2018-01-24 at 7.26.16 PM.png > > > FastInputStream creates and throws a new EOFException, every time an end of > stream is encountered. This is wasteful as we never use the stack trace > anywhere -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11879) avoid creating a new Exception object for EOFException in FastinputStream
[ https://issues.apache.org/jira/browse/SOLR-11879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344612#comment-16344612 ] ASF subversion and git services commented on SOLR-11879: Commit e2a5d46b9cdc5686051f4de34cca176b50c11fb1 in lucene-solr's branch refs/heads/master from [~noble.paul] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=e2a5d46 ] SOLR-11879: moved the peek() call inside the for loop > avoid creating a new Exception object for EOFException in FastinputStream > - > > Key: SOLR-11879 > URL: https://issues.apache.org/jira/browse/SOLR-11879 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Environment: FastI >Reporter: Noble Paul >Assignee: Noble Paul >Priority: Trivial > Attachments: SOLR-11879.patch, SOLR-11879.patch, SOLR-11879.patch, > Screen Shot 2018-01-24 at 7.26.16 PM.png > > > FastInputStream creates and throws a new EOFException, every time an end of > stream is encountered. This is wasteful as we never use the stack trace > anywhere -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11879) avoid creating a new Exception object for EOFException in FastinputStream
[ https://issues.apache.org/jira/browse/SOLR-11879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343759#comment-16343759 ] Varun Thacker commented on SOLR-11879: -- Hi Noble, We should add a CHANGES entry for this right? > avoid creating a new Exception object for EOFException in FastinputStream > - > > Key: SOLR-11879 > URL: https://issues.apache.org/jira/browse/SOLR-11879 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Environment: FastI >Reporter: Noble Paul >Assignee: Noble Paul >Priority: Trivial > Attachments: SOLR-11879.patch, SOLR-11879.patch, Screen Shot > 2018-01-24 at 7.26.16 PM.png > > > FastInputStream creates and throws a new EOFException, every time an end of > stream is encountered. This is wasteful as we never use the stack trace > anywhere -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11879) avoid creating a new Exception object for EOFException in FastinputStream
[ https://issues.apache.org/jira/browse/SOLR-11879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343197#comment-16343197 ] ASF subversion and git services commented on SOLR-11879: Commit 2c21498621426861393358b5da85195e0caafa48 in lucene-solr's branch refs/heads/branch_7x from [~noble.paul] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=2c21498 ] SOLR-11879: avoid EOFException when content is send without a payload > avoid creating a new Exception object for EOFException in FastinputStream > - > > Key: SOLR-11879 > URL: https://issues.apache.org/jira/browse/SOLR-11879 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Environment: FastI >Reporter: Noble Paul >Assignee: Noble Paul >Priority: Trivial > Attachments: SOLR-11879.patch, SOLR-11879.patch, Screen Shot > 2018-01-24 at 7.26.16 PM.png > > > FastInputStream creates and throws a new EOFException, every time an end of > stream is encountered. This is wasteful as we never use the stack trace > anywhere -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11879) avoid creating a new Exception object for EOFException in FastinputStream
[ https://issues.apache.org/jira/browse/SOLR-11879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343201#comment-16343201 ] ASF subversion and git services commented on SOLR-11879: Commit 586aa65110ab873d5faaf7630341deb1674b29a3 in lucene-solr's branch refs/heads/master from [~noble.paul] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=586aa65 ] SOLR-11879: avoid EOFException when content is send without a payload > avoid creating a new Exception object for EOFException in FastinputStream > - > > Key: SOLR-11879 > URL: https://issues.apache.org/jira/browse/SOLR-11879 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Environment: FastI >Reporter: Noble Paul >Assignee: Noble Paul >Priority: Trivial > Attachments: SOLR-11879.patch, SOLR-11879.patch, Screen Shot > 2018-01-24 at 7.26.16 PM.png > > > FastInputStream creates and throws a new EOFException, every time an end of > stream is encountered. This is wasteful as we never use the stack trace > anywhere -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11879) avoid creating a new Exception object for EOFException in FastinputStream
[ https://issues.apache.org/jira/browse/SOLR-11879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16341809#comment-16341809 ] Noble Paul commented on SOLR-11879: --- right. I have attached a patch with that change > avoid creating a new Exception object for EOFException in FastinputStream > - > > Key: SOLR-11879 > URL: https://issues.apache.org/jira/browse/SOLR-11879 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Environment: FastI >Reporter: Noble Paul >Assignee: Noble Paul >Priority: Trivial > Attachments: SOLR-11879.patch, SOLR-11879.patch, Screen Shot > 2018-01-24 at 7.26.16 PM.png > > > FastInputStream creates and throws a new EOFException, every time an end of > stream is encountered. This is wasteful as we never use the stack trace > anywhere -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11879) avoid creating a new Exception object for EOFException in FastinputStream
[ https://issues.apache.org/jira/browse/SOLR-11879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338708#comment-16338708 ] Yonik Seeley commented on SOLR-11879: - I guess the easiest solution (without digging into the binary update protocol) is to simply replace the exception catch (which can obscure real issues) with FastInputStream.peek() before the call to unmarshal() to see if there is more data. > avoid creating a new Exception object for EOFException in FastinputStream > - > > Key: SOLR-11879 > URL: https://issues.apache.org/jira/browse/SOLR-11879 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Environment: FastI >Reporter: Noble Paul >Assignee: Noble Paul >Priority: Trivial > Attachments: SOLR-11879.patch, Screen Shot 2018-01-24 at 7.26.16 > PM.png > > > FastInputStream creates and throws a new EOFException, every time an end of > stream is encountered. This is wasteful as we never use the stack trace > anywhere -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11879) avoid creating a new Exception object for EOFException in FastinputStream
[ https://issues.apache.org/jira/browse/SOLR-11879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338674#comment-16338674 ] Erick Erickson commented on SOLR-11879: --- The back-story here is that Java Flight Recorder is reporting this exception when it's used to analyze fast-n-furious indexing stream. I've attached a screenshot with the limited stack trace. This is for a 1 minute run. As you can see 200K+ exceptions were thrown. > avoid creating a new Exception object for EOFException in FastinputStream > - > > Key: SOLR-11879 > URL: https://issues.apache.org/jira/browse/SOLR-11879 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Environment: FastI >Reporter: Noble Paul >Assignee: Noble Paul >Priority: Trivial > Attachments: SOLR-11879.patch, Screen Shot 2018-01-24 at 7.26.16 > PM.png > > > FastInputStream creates and throws a new EOFException, every time an end of > stream is encountered. This is wasteful as we never use the stack trace > anywhere -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11879) avoid creating a new Exception object for EOFException in FastinputStream
[ https://issues.apache.org/jira/browse/SOLR-11879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338665#comment-16338665 ] Noble Paul commented on SOLR-11879: --- bq.It's bad practice to use exceptions as signaling... I assume there should be an easy way to avoid doing so here? yes. there should be a better way to avoid this by using a different method which is not expected to throw an Exception. > avoid creating a new Exception object for EOFException in FastinputStream > - > > Key: SOLR-11879 > URL: https://issues.apache.org/jira/browse/SOLR-11879 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Environment: FastI >Reporter: Noble Paul >Assignee: Noble Paul >Priority: Trivial > Attachments: SOLR-11879.patch > > > FastInputStream creates and throws a new EOFException, every time an end of > stream is encountered. This is wasteful as we never use the stack trace > anywhere -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11879) avoid creating a new Exception object for EOFException in FastinputStream
[ https://issues.apache.org/jira/browse/SOLR-11879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338492#comment-16338492 ] Yonik Seeley commented on SOLR-11879: - bq. The EOFException is actually a signaling mechanism. It's not really an exception It depends on context. For this specific class (FastInputStream), do we have code (i.e. uses of FastInputStream) that cause an exception to be thrown in non-error cases? > avoid creating a new Exception object for EOFException in FastinputStream > - > > Key: SOLR-11879 > URL: https://issues.apache.org/jira/browse/SOLR-11879 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Environment: FastI >Reporter: Noble Paul >Assignee: Noble Paul >Priority: Trivial > Attachments: SOLR-11879.patch > > > FastInputStream creates and throws a new EOFException, every time an end of > stream is encountered. This is wasteful as we never use the stack trace > anywhere -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11879) avoid creating a new Exception object for EOFException in FastinputStream
[ https://issues.apache.org/jira/browse/SOLR-11879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338431#comment-16338431 ] Noble Paul commented on SOLR-11879: --- The EOFException is actually a signaling mechanism. It's not really an exception > avoid creating a new Exception object for EOFException in FastinputStream > - > > Key: SOLR-11879 > URL: https://issues.apache.org/jira/browse/SOLR-11879 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Environment: FastI >Reporter: Noble Paul >Assignee: Noble Paul >Priority: Trivial > Attachments: SOLR-11879.patch > > > FastInputStream creates and throws a new EOFException, every time an end of > stream is encountered. This is wasteful as we never use the stack trace > anywhere -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11879) avoid creating a new Exception object for EOFException in FastinputStream
[ https://issues.apache.org/jira/browse/SOLR-11879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338409#comment-16338409 ] Yonik Seeley commented on SOLR-11879: - This only seems useful if we have code that reads until an exception is hit (i.e. uses the exception as a signaling mechanism). Do we? If we don't, then making this change would obscure the source of a real bug if it does happen. > avoid creating a new Exception object for EOFException in FastinputStream > - > > Key: SOLR-11879 > URL: https://issues.apache.org/jira/browse/SOLR-11879 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Environment: FastI >Reporter: Noble Paul >Assignee: Noble Paul >Priority: Trivial > Attachments: SOLR-11879.patch > > > FastInputStream creates and throws a new EOFException, every time an end of > stream is encountered. This is wasteful as we never use the stack trace > anywhere -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11879) avoid creating a new Exception object for EOFException in FastinputStream
[ https://issues.apache.org/jira/browse/SOLR-11879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338358#comment-16338358 ] Varun Thacker commented on SOLR-11879: -- Hi Noble, Can this be committed ? > avoid creating a new Exception object for EOFException in FastinputStream > - > > Key: SOLR-11879 > URL: https://issues.apache.org/jira/browse/SOLR-11879 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Environment: FastI >Reporter: Noble Paul >Assignee: Noble Paul >Priority: Trivial > Attachments: SOLR-11879.patch > > > FastInputStream creates and throws a new EOFException, every time an end of > stream is encountered. This is wasteful as we never use the stack trace > anywhere -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
