subject:"Profile Activation"



pzygielo commented on a change in pull request #225:
URL: https://github.com/apache/maven-site/pull/225#discussion_r554014876



##
File path: content/apt/guides/introduction/introduction-to-profiles.apt
##
@@ -307,7 +309,7 @@ mvn groupId:artifactId:goal -Denvironment=test
   identifier with either the character '!' or '-' as shown below:
   
 +---+
-mvn groupId:artifactId:goal -P !profile-1,!profile-2
+mvn groupId:artifactId:goal -P !profile-1,!profile-2,!?profile-3

Review comment:
   > Instead of ! you can also use the minus sign, by the way.
   
   Then you might be affected by something like MNG-7011.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-site] MartinKanters commented on a change in pull request #225: [MNG-7051] Add examples of ? prefix in profile activation



MartinKanters commented on a change in pull request #225:
URL: https://github.com/apache/maven-site/pull/225#discussion_r554007128



##
File path: content/apt/guides/introduction/introduction-to-profiles.apt
##
@@ -307,7 +309,7 @@ mvn groupId:artifactId:goal -Denvironment=test
   identifier with either the character '!' or '-' as shown below:
   
 +---+
-mvn groupId:artifactId:goal -P !profile-1,!profile-2
+mvn groupId:artifactId:goal -P !profile-1,!profile-2,!?profile-3

Review comment:
   Instead of ! you can also use the minus sign, by the way.

##
File path: content/apt/guides/introduction/introduction-to-profiles.apt
##
@@ -307,7 +309,7 @@ mvn groupId:artifactId:goal -Denvironment=test
   identifier with either the character '!' or '-' as shown below:
   
 +---+
-mvn groupId:artifactId:goal -P !profile-1,!profile-2
+mvn groupId:artifactId:goal -P !profile-1,!profile-2,!?profile-3

Review comment:
   In the current implementation there is an order in place:
   - !? is correct and means: "do not activate the profile, but do not fail if 
it does not exist"
   - ?! is not correct.. do you think we should support this as well?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-site] michael-o commented on a change in pull request #225: [MNG-7051] Add examples of ? prefix in profile activation



michael-o commented on a change in pull request #225:
URL: https://github.com/apache/maven-site/pull/225#discussion_r553996067



##
File path: content/apt/guides/introduction/introduction-to-profiles.apt
##
@@ -307,7 +309,7 @@ mvn groupId:artifactId:goal -Denvironment=test
   identifier with either the character '!' or '-' as shown below:
   
 +---+
-mvn groupId:artifactId:goal -P !profile-1,!profile-2
+mvn groupId:artifactId:goal -P !profile-1,!profile-2,!?profile-3

Review comment:
   Correct the ! can be disabled in bash and is a bash problem, not ours.

##
File path: content/apt/guides/introduction/introduction-to-profiles.apt
##
@@ -307,7 +309,7 @@ mvn groupId:artifactId:goal -Denvironment=test
   identifier with either the character '!' or '-' as shown below:
   
 +---+
-mvn groupId:artifactId:goal -P !profile-1,!profile-2
+mvn groupId:artifactId:goal -P !profile-1,!profile-2,!?profile-3

Review comment:
   How do I interprete `!?`? Is it the same as `?!`?

##
File path: content/apt/guides/introduction/introduction-to-profiles.apt
##
@@ -307,7 +309,7 @@ mvn groupId:artifactId:goal -Denvironment=test
   identifier with either the character '!' or '-' as shown below:
   
 +---+
-mvn groupId:artifactId:goal -P !profile-1,!profile-2
+mvn groupId:artifactId:goal -P !profile-1,!profile-2,!?profile-3

Review comment:
   Alright. Keep one consistent option.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-site] slawekjaranowski commented on a change in pull request #225: [MNG-7051] Add examples of ? prefix in profile activation



slawekjaranowski commented on a change in pull request #225:
URL: https://github.com/apache/maven-site/pull/225#discussion_r553961399



##
File path: content/apt/guides/introduction/introduction-to-profiles.apt
##
@@ -100,9 +100,11 @@ Introduction to Build Profiles
   profile IDs to use. The profile(s) specified in the option
   are activated in addition to any profiles which are activated by their 
activation
   configuration or the <<<\>>> section in <<>>.
+  Maven will refuse to activate or deactivate a profile that cannot be 
resolved.
+  To prevent this, prefix the profile identifier with an <<>>, marking it 
as optional:

Review comment:
   Does this behavior will be implemented in current version `3.6.x`? - if 
not, information which version will be impact will be useful

##
File path: content/apt/guides/introduction/introduction-to-profiles.apt
##
@@ -307,7 +309,7 @@ mvn groupId:artifactId:goal -Denvironment=test
   identifier with either the character '!' or '-' as shown below:
   
 +---+
-mvn groupId:artifactId:goal -P !profile-1,!profile-2
+mvn groupId:artifactId:goal -P !profile-1,!profile-2,!?profile-3

Review comment:
   did you try from console ... I have :
   ```
   $ mvn -N validate -P !profile-1,!profile-2
   bash: !profile-1,!profile-2: event not found
   ```
   
   ```
   $ bash --version 
   GNU bash, version 5.1.4(1)-release (x86_64-apple-darwin19.6.0)
   ```

##
File path: content/apt/guides/introduction/introduction-to-profiles.apt
##
@@ -307,7 +309,7 @@ mvn groupId:artifactId:goal -Denvironment=test
   identifier with either the character '!' or '-' as shown below:
   
 +---+
-mvn groupId:artifactId:goal -P !profile-1,!profile-2
+mvn groupId:artifactId:goal -P !profile-1,!profile-2,!?profile-3

Review comment:
   did you try from console ... I have :
   ```
   $ mvn -N validate -P !profile-1,!profile-2
   bash: !profile-1,!profile-2: event not found
   ```
   
   ```
   $ bash --version 
   GNU bash, version 5.1.4(1)-release (x86_64-apple-darwin19.6.0)
   ```
   
   ```
   $ mvn --version 
   Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
   ```





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-site] mthmulders commented on a change in pull request #225: [MNG-7051] Add examples of ? prefix in profile activation



mthmulders commented on a change in pull request #225:
URL: https://github.com/apache/maven-site/pull/225#discussion_r553965389



##
File path: content/apt/guides/introduction/introduction-to-profiles.apt
##
@@ -100,9 +100,11 @@ Introduction to Build Profiles
   profile IDs to use. The profile(s) specified in the option
   are activated in addition to any profiles which are activated by their 
activation
   configuration or the <<<\>>> section in <<>>.
+  Maven will refuse to activate or deactivate a profile that cannot be 
resolved.
+  To prevent this, prefix the profile identifier with an <<>>, marking it 
as optional:

Review comment:
   Makes sense, updated.

##
File path: content/apt/guides/introduction/introduction-to-profiles.apt
##
@@ -307,7 +309,7 @@ mvn groupId:artifactId:goal -Denvironment=test
   identifier with either the character '!' or '-' as shown below:
   
 +---+
-mvn groupId:artifactId:goal -P !profile-1,!profile-2
+mvn groupId:artifactId:goal -P !profile-1,!profile-2,!?profile-3

Review comment:
   Should be `mvn -N validate -P \!profile-1,\!profile-2`, but I think it 
depends on the shell you use. For now, I followed the existing guide...

##
File path: content/apt/guides/introduction/introduction-to-profiles.apt
##
@@ -307,7 +309,7 @@ mvn groupId:artifactId:goal -Denvironment=test
   identifier with either the character '!' or '-' as shown below:
   
 +---+
-mvn groupId:artifactId:goal -P !profile-1,!profile-2
+mvn groupId:artifactId:goal -P !profile-1,!profile-2,!?profile-3

Review comment:
   > Then you might be affected by something like MNG-7011.
   
   Correct - although that is not something that is introduced by 
[MNG-7051](https://issues.apache.org/jira/browse/MNG-7051).





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-site] michael-o commented on a change in pull request #225: [MNG-7051] Add examples of ? prefix in profile activation



michael-o commented on a change in pull request #225:
URL: https://github.com/apache/maven-site/pull/225#discussion_r554064780



##
File path: content/apt/guides/introduction/introduction-to-profiles.apt
##
@@ -307,7 +309,7 @@ mvn groupId:artifactId:goal -Denvironment=test
   identifier with either the character '!' or '-' as shown below:
   
 +---+
-mvn groupId:artifactId:goal -P !profile-1,!profile-2
+mvn groupId:artifactId:goal -P !profile-1,!profile-2,!?profile-3

Review comment:
   Alright. Keep one consistent option.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-site] MartinKanters commented on a change in pull request #225: [MNG-7051] Add examples of ? prefix in profile activation



MartinKanters commented on a change in pull request #225:
URL: https://github.com/apache/maven-site/pull/225#discussion_r554058099



##
File path: content/apt/guides/introduction/introduction-to-profiles.apt
##
@@ -307,7 +309,7 @@ mvn groupId:artifactId:goal -Denvironment=test
   identifier with either the character '!' or '-' as shown below:
   
 +---+
-mvn groupId:artifactId:goal -P !profile-1,!profile-2
+mvn groupId:artifactId:goal -P !profile-1,!profile-2,!?profile-3

Review comment:
   In the current implementation there is an order in place:
   - !? is correct and means: "do not activate the profile, but do not fail if 
it does not exist"
   - ?! is not correct.. do you think we should support this as well?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-site] michael-o commented on a change in pull request #225: [MNG-7051] Add examples of ? prefix in profile activation



michael-o commented on a change in pull request #225:
URL: https://github.com/apache/maven-site/pull/225#discussion_r554041608



##
File path: content/apt/guides/introduction/introduction-to-profiles.apt
##
@@ -307,7 +309,7 @@ mvn groupId:artifactId:goal -Denvironment=test
   identifier with either the character '!' or '-' as shown below:
   
 +---+
-mvn groupId:artifactId:goal -P !profile-1,!profile-2
+mvn groupId:artifactId:goal -P !profile-1,!profile-2,!?profile-3

Review comment:
   How do I interprete `!?`? Is it the same as `?!`?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-site] mthmulders commented on a change in pull request #225: [MNG-7051] Add examples of ? prefix in profile activation



mthmulders commented on a change in pull request #225:
URL: https://github.com/apache/maven-site/pull/225#discussion_r554024978



##
File path: content/apt/guides/introduction/introduction-to-profiles.apt
##
@@ -307,7 +309,7 @@ mvn groupId:artifactId:goal -Denvironment=test
   identifier with either the character '!' or '-' as shown below:
   
 +---+
-mvn groupId:artifactId:goal -P !profile-1,!profile-2
+mvn groupId:artifactId:goal -P !profile-1,!profile-2,!?profile-3

Review comment:
   > Then you might be affected by something like MNG-7011.
   
   Correct - although that is not something that is introduced by 
[MNG-7051](https://issues.apache.org/jira/browse/MNG-7051).





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-site] pzygielo commented on a change in pull request #225: [MNG-7051] Add examples of ? prefix in profile activation



pzygielo commented on a change in pull request #225:
URL: https://github.com/apache/maven-site/pull/225#discussion_r554014876



##
File path: content/apt/guides/introduction/introduction-to-profiles.apt
##
@@ -307,7 +309,7 @@ mvn groupId:artifactId:goal -Denvironment=test
   identifier with either the character '!' or '-' as shown below:
   
 +---+
-mvn groupId:artifactId:goal -P !profile-1,!profile-2
+mvn groupId:artifactId:goal -P !profile-1,!profile-2,!?profile-3

Review comment:
   > Instead of ! you can also use the minus sign, by the way.
   
   Then you might be affected by something like MNG-7011.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-site] MartinKanters commented on a change in pull request #225: [MNG-7051] Add examples of ? prefix in profile activation



MartinKanters commented on a change in pull request #225:
URL: https://github.com/apache/maven-site/pull/225#discussion_r554007128



##
File path: content/apt/guides/introduction/introduction-to-profiles.apt
##
@@ -307,7 +309,7 @@ mvn groupId:artifactId:goal -Denvironment=test
   identifier with either the character '!' or '-' as shown below:
   
 +---+
-mvn groupId:artifactId:goal -P !profile-1,!profile-2
+mvn groupId:artifactId:goal -P !profile-1,!profile-2,!?profile-3

Review comment:
   Instead of ! you can also use the minus sign, by the way.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-site] michael-o commented on a change in pull request #225: [MNG-7051] Add examples of ? prefix in profile activation



michael-o commented on a change in pull request #225:
URL: https://github.com/apache/maven-site/pull/225#discussion_r553996067



##
File path: content/apt/guides/introduction/introduction-to-profiles.apt
##
@@ -307,7 +309,7 @@ mvn groupId:artifactId:goal -Denvironment=test
   identifier with either the character '!' or '-' as shown below:
   
 +---+
-mvn groupId:artifactId:goal -P !profile-1,!profile-2
+mvn groupId:artifactId:goal -P !profile-1,!profile-2,!?profile-3

Review comment:
   Correct the ! can be disabled in bash and is a bash problem, not ours.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-site] mthmulders commented on a change in pull request #225: [MNG-7051] Add examples of ? prefix in profile activation



mthmulders commented on a change in pull request #225:
URL: https://github.com/apache/maven-site/pull/225#discussion_r553966399



##
File path: content/apt/guides/introduction/introduction-to-profiles.apt
##
@@ -307,7 +309,7 @@ mvn groupId:artifactId:goal -Denvironment=test
   identifier with either the character '!' or '-' as shown below:
   
 +---+
-mvn groupId:artifactId:goal -P !profile-1,!profile-2
+mvn groupId:artifactId:goal -P !profile-1,!profile-2,!?profile-3

Review comment:
   Should be `mvn -N validate -P \!profile-1,\!profile-2`, but I think it 
depends on the shell you use. For now, I followed the existing guide...





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-site] mthmulders commented on a change in pull request #225: [MNG-7051] Add examples of ? prefix in profile activation



mthmulders commented on a change in pull request #225:
URL: https://github.com/apache/maven-site/pull/225#discussion_r553965389



##
File path: content/apt/guides/introduction/introduction-to-profiles.apt
##
@@ -100,9 +100,11 @@ Introduction to Build Profiles
   profile IDs to use. The profile(s) specified in the option
   are activated in addition to any profiles which are activated by their 
activation
   configuration or the <<<\>>> section in <<>>.
+  Maven will refuse to activate or deactivate a profile that cannot be 
resolved.
+  To prevent this, prefix the profile identifier with an <<>>, marking it 
as optional:

Review comment:
   Makes sense, updated.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-site] slawekjaranowski commented on a change in pull request #225: [MNG-7051] Add examples of ? prefix in profile activation



slawekjaranowski commented on a change in pull request #225:
URL: https://github.com/apache/maven-site/pull/225#discussion_r553964597



##
File path: content/apt/guides/introduction/introduction-to-profiles.apt
##
@@ -307,7 +309,7 @@ mvn groupId:artifactId:goal -Denvironment=test
   identifier with either the character '!' or '-' as shown below:
   
 +---+
-mvn groupId:artifactId:goal -P !profile-1,!profile-2
+mvn groupId:artifactId:goal -P !profile-1,!profile-2,!?profile-3

Review comment:
   did you try from console ... I have :
   ```
   $ mvn -N validate -P !profile-1,!profile-2
   bash: !profile-1,!profile-2: event not found
   ```
   
   ```
   $ bash --version 
   GNU bash, version 5.1.4(1)-release (x86_64-apple-darwin19.6.0)
   ```
   
   ```
   $ mvn --version 
   Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
   ```





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-site] slawekjaranowski commented on a change in pull request #225: [MNG-7051] Add examples of ? prefix in profile activation



slawekjaranowski commented on a change in pull request #225:
URL: https://github.com/apache/maven-site/pull/225#discussion_r553964597



##
File path: content/apt/guides/introduction/introduction-to-profiles.apt
##
@@ -307,7 +309,7 @@ mvn groupId:artifactId:goal -Denvironment=test
   identifier with either the character '!' or '-' as shown below:
   
 +---+
-mvn groupId:artifactId:goal -P !profile-1,!profile-2
+mvn groupId:artifactId:goal -P !profile-1,!profile-2,!?profile-3

Review comment:
   did you try from console ... I have :
   ```
   $ mvn -N validate -P !profile-1,!profile-2
   bash: !profile-1,!profile-2: event not found
   ```
   
   ```
   $ bash --version 
   GNU bash, version 5.1.4(1)-release (x86_64-apple-darwin19.6.0)
   ```





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-site] slawekjaranowski commented on a change in pull request #225: [MNG-7051] Add examples of ? prefix in profile activation



slawekjaranowski commented on a change in pull request #225:
URL: https://github.com/apache/maven-site/pull/225#discussion_r553961399



##
File path: content/apt/guides/introduction/introduction-to-profiles.apt
##
@@ -100,9 +100,11 @@ Introduction to Build Profiles
   profile IDs to use. The profile(s) specified in the option
   are activated in addition to any profiles which are activated by their 
activation
   configuration or the <<<\>>> section in <<>>.
+  Maven will refuse to activate or deactivate a profile that cannot be 
resolved.
+  To prevent this, prefix the profile identifier with an <<>>, marking it 
as optional:

Review comment:
   Does this behavior will be implemented in current version `3.6.x`? - if 
not, information which version will be impact will be useful





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] [maven-site] mthmulders opened a new pull request #225: [MNG-7051] Add examples of ? prefix in profile activation



mthmulders opened a new pull request #225:
URL: https://github.com/apache/maven-site/pull/225


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: Profile Activation

2016-08-15 Thread Chas Honton

The behavior is AND. You can have multiple profiles for OR. 

Chas

> On Aug 15, 2016, at 11:45 AM, Christopher <ctubb...@apache.org> wrote:
> 
> If there could be "AND" and "OR" primitives for profile activation
> conditions, you could do something like:
> 
>   
> 
>   !profilea
> 
> 
>   profilea
>   !true
> 
>   
> 
> Sadly, this feature does not exist.
> 
>> On Fri, Aug 12, 2016, 11:45 Karl Heinz Marbaise <khmarba...@gmx.de> wrote:
>> 
>> Hi to all,
>> 
>> I have the following profile:
>> 
>> 
>>   
>>   profile-not-value-true
>>   
>> 
>>   profilea
>>   !true
>> 
>>   
>>   
>> 
>>   
>> com.soebes.maven.plugins
>> echo-maven-plugin
>> 
>>   
>> initialize
>> 
>>   echo
>> 
>>   
>> 
>> 
>>   
>> profile not value true
>>   
>> 
>>   
>> 
>>   
>> 
>> 
>> So the question is: What would you expect you need to do to activate
>> this profile?
>> 
>> Currently this profile is activated cause if I don't define the property
>> "profilea" at all it seemed to that Maven is assuming this means "not
>> value 'true'" ?
>> 
>> I have assumed it should be activated if the property exists which means
>> giving it on command line like this:
>> 
>> mvn -Dprofilea
>> 
>> 
>> 
>> WDYT ?
>> 
>> Kind regards
>> Karl Heinz Marbaise
>> 
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
>> For additional commands, e-mail: dev-h...@maven.apache.org
>> 
>> 

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: Profile Activation

2016-08-15 Thread Christopher

If there could be "AND" and "OR" primitives for profile activation
conditions, you could do something like:

   
 
   !profilea
 
 
   profilea
   !true
 
   

Sadly, this feature does not exist.

On Fri, Aug 12, 2016, 11:45 Karl Heinz Marbaise <khmarba...@gmx.de> wrote:

> Hi to all,
>
> I have the following profile:
>
>
>
>profile-not-value-true
>
>  
>profilea
>!true
>  
>
>
>  
>
>  com.soebes.maven.plugins
>  echo-maven-plugin
>  
>
>  initialize
>  
>echo
>  
>
>  
>  
>
>  profile not value true
>
>  
>
>  
>
>  
>
> So the question is: What would you expect you need to do to activate
> this profile?
>
> Currently this profile is activated cause if I don't define the property
> "profilea" at all it seemed to that Maven is assuming this means "not
> value 'true'" ?
>
> I have assumed it should be activated if the property exists which means
> giving it on command line like this:
>
> mvn -Dprofilea
>
>
>
> WDYT ?
>
> Kind regards
> Karl Heinz Marbaise
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
>

Re: Profile Activation

2016-08-12 Thread Robert Scholte

Hi,

I could also reverse the question: how can I have an active profile by  
default, which should not be activated when skipITs is set to true. I  
don't think there's another solution than the current one. The fact that  
skipITs is treated as a boolean makes this example always work and there's  
no discussion. Confusion starts because the property can have more than 2  
values.
It all depends on the definition. For me it makes perfectly sense that  
'mvn package -Denvironment=prod' and 'mvn package', since it fits with  
"always active unless environment is production".
AFAIK the current logic has been there since the early versions of Maven,  
so I consider it as "works as designed".
The funny thing is that we say you cannot program within the pom, but this  
not-expression is the only with some logic and not it seems it is causing  
trouble.

Robert

On Fri, 12 Aug 2016 21:18:06 +0200, Karl Heinz Marbaise  
<khmarba...@gmx.de> wrote:

Hi,

First I have added the documentation about the opportunities like this  
(and other one as well a few days before, cause there had been no  
documentation about that at all  
https://issues.apache.org/jira/browse/MNGSITE-234):

 !debug

 ...

which means if the property does not exist...and also works exactly like  
this. The value does not matter nor is needed to give some.

If I argue from a logical point of view I would say (and expect):

 debug
 !true

 ...

This would mean: The value is not equal "true"...but the property must  
exist...so something like "-Ddebug=WHATEVER"

The current behaviour is that the previous sentence will be calculated  
by Maven as:

The property is not important nor is needed to exists..and the values is  
not equal to "true"..which I think is wrong...

So it is not possible to express a thing like this:

 environment
 !dev

 ...

So this will be activated always...So the call:

mvn package -Denvironment=prod
mvn package

would be equivalent...which I think is wrong...

So it is not possible to identify a difference between those two Maven  
calls.

Furthermore if I like to use a combination of two profiles like this:

 not-existing

 !environment

 ...

 not-dev

 environment
 !dev

 ...

So if I call maven via:

mvn package

the last will take precendence...

Kind regards
Karl Heinz Marbaise

On 12/08/16 19:32, Robert Scholte wrote:

Hi,

Yes, this is correct. Just to clarify: -Dx is always the same is
-Dx=true [1]
I'd like to add -Dprofilea= : profile activated

5. mvn initialize -Dprofilea= : profile activated

maybe if the property was called skipITs instead of profilea the
examples are better to follow, i.e. always activate this profile (with
integration-tests), *unless* skipITs is true.

Robert

[1]
https://maven.apache.org/ref/3.3.9/maven-embedder/xref/org/apache/maven/cli/MavenCli.html#L1544

On Fri, 12 Aug 2016 18:59:14 +0200, Guillaume Boué <gb...@apache.org>
wrote:

Hi Robert,

 If this is expected, I think the documentation in
http://maven.apache.org/guides/introduction/introduction-to-profiles.html
should indeed be clarified. Currently, in that situation, it says

 "The following profile will be activated when the system property
"debug" is defined with a value which is not "true"."

 In this case, when invoking Maven with "mvn initialize", profilea
isn't defined so I would expect the profile not to be activated. This
is also what would happen if the value in the profile activation was
commented out.

 To recap, this is the current result with Maven 3.3.9 for this
situation (and latest 3.4.0-SNAPSHOT):

  1. mvn initialize: profile activated

 2. mvn initialize -Dprofilea: profile not activated

 3. mvn initialize -Dprofilea=false: profile activated

 4. mvn initialize -Dprofilea=true: profile not activated

 Guillaume

Message du 12/08/16 18:34
De : "Robert Scholte"
A : "Maven Developers List"
Copie à :
Objet : Re: Profile Activation

Hi Karl Heinz,

you should read the activation like this:
always activate, *unless* profilea is true.
So it says nothing about the availability of the property.
Maybe the documentation isn't clear enough.

Robert

On Fri, 12 Aug 2016 17:45:21 +0200, Karl Heinz Marbaise
 wrote:

> Hi to all,
>
> I have the following profile:
>
>
>
> profile-not-value-true
>
>
> profilea
> !true
>
>
>
>
>
> com.soebes.maven.plugins
> echo-maven-plugin
>
>
> initialize
>
> echo
>
>
>
>
>
> profile not value true
>
>
>
>
>
>
>
> So the question is: What would you expect you need to do to act

Re: Profile Activation

2016-08-12 Thread Karl Heinz Marbaise

Hi,

First I have added the documentation about the opportunities like this 
(and other one as well a few days before, cause there had been no 
documentation about that at all 
https://issues.apache.org/jira/browse/MNGSITE-234):

!debug

...

which means if the property does not exist...and also works exactly like 
this. The value does not matter nor is needed to give some.

If I argue from a logical point of view I would say (and expect):

debug
!true

...

This would mean: The value is not equal "true"...but the property must 
exist...so something like "-Ddebug=WHATEVER"

The current behaviour is that the previous sentence will be calculated 
by Maven as:

The property is not important nor is needed to exists..and the values is 
not equal to "true"..which I think is wrong...

So it is not possible to express a thing like this:

environment
!dev

...

So this will be activated always...So the call:

mvn package -Denvironment=prod
mvn package

would be equivalent...which I think is wrong...

So it is not possible to identify a difference between those two Maven 
calls.

Furthermore if I like to use a combination of two profiles like this:

not-existing

!environment

...

not-dev

environment
!dev

...

So if I call maven via:

mvn package

the last will take precendence...

Kind regards
Karl Heinz Marbaise

On 12/08/16 19:32, Robert Scholte wrote:

Hi,

Yes, this is correct. Just to clarify: -Dx is always the same is
-Dx=true [1]
I'd like to add -Dprofilea= : profile activated

5. mvn initialize -Dprofilea= : profile activated

maybe if the property was called skipITs instead of profilea the
examples are better to follow, i.e. always activate this profile (with
integration-tests), *unless* skipITs is true.

Robert

[1]
https://maven.apache.org/ref/3.3.9/maven-embedder/xref/org/apache/maven/cli/MavenCli.html#L1544

On Fri, 12 Aug 2016 18:59:14 +0200, Guillaume Boué <gb...@apache.org>
wrote:

Hi Robert,

 If this is expected, I think the documentation in
http://maven.apache.org/guides/introduction/introduction-to-profiles.html
should indeed be clarified. Currently, in that situation, it says

 "The following profile will be activated when the system property
"debug" is defined with a value which is not "true"."

 In this case, when invoking Maven with "mvn initialize", profilea
isn't defined so I would expect the profile not to be activated. This
is also what would happen if the value in the profile activation was
commented out.

 To recap, this is the current result with Maven 3.3.9 for this
situation (and latest 3.4.0-SNAPSHOT):

  1. mvn initialize: profile activated

 2. mvn initialize -Dprofilea: profile not activated

 3. mvn initialize -Dprofilea=false: profile activated

 4. mvn initialize -Dprofilea=true: profile not activated

 Guillaume

Message du 12/08/16 18:34
De : "Robert Scholte"
A : "Maven Developers List"
Copie à :
Objet : Re: Profile Activation

Hi Karl Heinz,

you should read the activation like this:
always activate, *unless* profilea is true.
So it says nothing about the availability of the property.
Maybe the documentation isn't clear enough.

Robert

On Fri, 12 Aug 2016 17:45:21 +0200, Karl Heinz Marbaise
 wrote:

> Hi to all,
>
> I have the following profile:
>
>
>
> profile-not-value-true
>
>
> profilea
> !true
>
>
>
>
>
> com.soebes.maven.plugins
> echo-maven-plugin
>
>
> initialize
>
> echo
>
>
>
>
>
> profile not value true
>
>
>
>
>
>
>
> So the question is: What would you expect you need to do to activate
> this profile?
>
> Currently this profile is activated cause if I don't define the
property
> "profilea" at all it seemed to that Maven is assuming this means "not
> value 'true'" ?
>
> I have assumed it should be activated if the property exists which
means
> giving it on command line like this:
>
> mvn -Dprofilea
>
>
>
> WDYT ?
>
> Kind regards
> Karl Heinz Marbaise
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mai

Re: Profile Activation

2016-08-12 Thread Karl Heinz Marbaise


On 12/08/16 18:34, Robert Scholte wrote:

Maybe the documentation isn't clear enough.


I have added the documentation about the property activation with "!" 
things a few days ago...


Either my assumption was wrong or the the intention is wrong...

Kind regards
Karl Heinz

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: Profile Activation

2016-08-12 Thread Robert Scholte

Hi,

Yes, this is correct. Just to clarify: -Dx is always the same is -Dx=true  
[1]

I'd like to add -Dprofilea= : profile activated

5. mvn initialize -Dprofilea= : profile activated

maybe if the property was called skipITs instead of profilea the examples  
are better to follow, i.e. always activate this profile (with  
integration-tests), *unless* skipITs is true.

Robert

[1]  
https://maven.apache.org/ref/3.3.9/maven-embedder/xref/org/apache/maven/cli/MavenCli.html#L1544

On Fri, 12 Aug 2016 18:59:14 +0200, Guillaume Boué <gb...@apache.org>  
wrote:

Hi Robert,

If this is expected, I think the documentation in  
http://maven.apache.org/guides/introduction/introduction-to-profiles.html  
should indeed be clarified. Currently, in that situation, it says

"The following profile will be activated when the system property  
"debug" is defined with a value which is not "true"."

In this case, when invoking Maven with "mvn initialize", profilea isn't  
defined so I would expect the profile not to be activated. This is also  
what would happen if the value in the profile activation was commented  
out.

To recap, this is the current result with Maven 3.3.9 for this situation  
(and latest 3.4.0-SNAPSHOT):

 1. mvn initialize: profile activated

 2. mvn initialize -Dprofilea: profile not activated

 3. mvn initialize -Dprofilea=false: profile activated

 4. mvn initialize -Dprofilea=true: profile not activated

Guillaume

Message du 12/08/16 18:34
De : "Robert Scholte"
A : "Maven Developers List"
Copie à :
Objet : Re: Profile Activation

Hi Karl Heinz,

you should read the activation like this:
always activate, *unless* profilea is true.
So it says nothing about the availability of the property.
Maybe the documentation isn't clear enough.

Robert

On Fri, 12 Aug 2016 17:45:21 +0200, Karl Heinz Marbaise
 wrote:

> Hi to all,
>
> I have the following profile:
>
>
>
> profile-not-value-true
>
>
> profilea
> !true
>
>
>
>
>
> com.soebes.maven.plugins
> echo-maven-plugin
>
>
> initialize
>
> echo
>
>
>
>
>
> profile not value true
>
>
>
>
>
>
>
> So the question is: What would you expect you need to do to activate
> this profile?
>
> Currently this profile is activated cause if I don't define the  
property

> "profilea" at all it seemed to that Maven is assuming this means "not
> value 'true'" ?
>
> I have assumed it should be activated if the property exists which  
means

> giving it on command line like this:
>
> mvn -Dprofilea
>
>
>
> WDYT ?
>
> Kind regards
> Karl Heinz Marbaise
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: Profile Activation

2016-08-12 Thread Guillaume Boué

Hi Robert,

If this is expected, I think the documentation in 
http://maven.apache.org/guides/introduction/introduction-to-profiles.html 
should indeed be clarified. Currently, in that situation, it says 

"The following profile will be activated when the system property "debug" is 
defined with a value which is not "true"."

In this case, when invoking Maven with "mvn initialize", profilea isn't defined 
so I would expect the profile not to be activated. This is also what would 
happen if the value in the profile activation was commented out.

To recap, this is the current result with Maven 3.3.9 for this situation (and 
latest 3.4.0-SNAPSHOT):

 1. mvn initialize: profile activated

 2. mvn initialize -Dprofilea: profile not activated

 3. mvn initialize -Dprofilea=false: profile activated

 4. mvn initialize -Dprofilea=true: profile not activated

Guillaume

> Message du 12/08/16 18:34
> De : "Robert Scholte" 
> A : "Maven Developers List" 
> Copie à : 
> Objet : Re: Profile Activation
> 
> Hi Karl Heinz,
> 
> you should read the activation like this:
> always activate, *unless* profilea is true.
> So it says nothing about the availability of the property.
> Maybe the documentation isn't clear enough.
> 
> Robert
> 
> On Fri, 12 Aug 2016 17:45:21 +0200, Karl Heinz Marbaise 
>  wrote:
> 
> > Hi to all,
> >
> > I have the following profile:
> >
> >
> > 
> > profile-not-value-true
> > 
> > 
> > profilea
> > !true
> > 
> > 
> > 
> > 
> > 
> > com.soebes.maven.plugins
> > echo-maven-plugin
> > 
> > 
> > initialize
> > 
> > echo
> > 
> > 
> > 
> > 
> > 
> > profile not value true
> > 
> > 
> > 
> > 
> > 
> > 
> >
> > So the question is: What would you expect you need to do to activate 
> > this profile?
> >
> > Currently this profile is activated cause if I don't define the property 
> > "profilea" at all it seemed to that Maven is assuming this means "not 
> > value 'true'" ?
> >
> > I have assumed it should be activated if the property exists which means 
> > giving it on command line like this:
> >
> > mvn -Dprofilea
> >
> >
> >
> > WDYT ?
> >
> > Kind regards
> > Karl Heinz Marbaise
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> > For additional commands, e-mail: dev-h...@maven.apache.org
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
> 
>

Re: Profile Activation

2016-08-12 Thread Robert Scholte


Hi Karl Heinz,

you should read the activation like this:
always activate, *unless* profilea is true.
So it says nothing about the availability of the property.
Maybe the documentation isn't clear enough.

Robert

On Fri, 12 Aug 2016 17:45:21 +0200, Karl Heinz Marbaise  
 wrote:



Hi to all,

I have the following profile:


   
   profile-not-value-true
   
 
   profilea
   !true
 
   
   
 
   
 com.soebes.maven.plugins
 echo-maven-plugin
 
   
 initialize
 
   echo
 
   
 
 
   
 profile not value true
   
 
   
 
   
 

So the question is: What would you expect you need to do to activate  
this profile?


Currently this profile is activated cause if I don't define the property  
"profilea" at all it seemed to that Maven is assuming this means "not  
value 'true'" ?


I have assumed it should be activated if the property exists which means  
giving it on command line like this:


mvn -Dprofilea



WDYT ?

Kind regards
Karl Heinz Marbaise

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

RE: Profile Activation

2016-08-12 Thread Martin Gainty

MG>quick comment
> To: dev@maven.apache.org
> From: khmarba...@gmx.de
> Subject: Profile Activation
> Date: Fri, 12 Aug 2016 17:45:21 +0200
> 
> Hi to all,
> 
> I have the following profile:
> 
> 
>
>profile-not-value-true
>
>  
>profilea
>!true
>  
>
>
>  
>
>  com.soebes.maven.plugins
>  echo-maven-plugin
>  
>
>  initialize
>  
>echo
>  
>
>  
>  
>
>  profile not value true
>
>  
>
>  
>
>  
> 
> So the question is: What would you expect you need to do to activate 
> this profile?
> 
> Currently this profile is activated cause if I don't define the property 
> "profilea" at all it seemed to that Maven is assuming this means "not 
> value 'true'" ?
> 
> I have assumed it should be activated if the property exists which means 
> giving it on command line like this:
> 
> mvn -DprofileaMG>assumes the property *must* exist as documented at

MG>http://maven.apache.org/guides/introduction/introduction-to-profiles.html
MG>if ok for system property to not exist or system property to *not* be 
defined then either:
MG>fix code to detect system property must exist to conform to doc
MG>ORMG>change doc to say : The following profile will be activated when the 
system property "debug" is defined with a value which is not "true" -OR- when 
system property "debug" does not exist or when system property "debug" was 
never defined
> 
MG>*Methinks you found a bug Karl*
> 
> WDYT ?
> 
> Kind regards
> Karl Heinz Marbaise
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>

Profile Activation

2016-08-12 Thread Karl Heinz Marbaise


Hi to all,

I have the following profile:


  
  profile-not-value-true
  

  profilea
  !true

  
  

  
com.soebes.maven.plugins
echo-maven-plugin

  
initialize

  echo

  


  
profile not value true
  

  

  


So the question is: What would you expect you need to do to activate 
this profile?


Currently this profile is activated cause if I don't define the property 
"profilea" at all it seemed to that Maven is assuming this means "not 
value 'true'" ?


I have assumed it should be activated if the property exists which means 
giving it on command line like this:


mvn -Dprofilea



WDYT ?

Kind regards
Karl Heinz Marbaise

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Fwd: About profile activation with JSR223

2015-09-07 Thread Ramón Rial

I have redesigned the project. It is available at
https://github.com/rrialq/jsr223-profile-activator-extension.

Instead of resolving properties  the extension resolves expressions with
the help of Maven interpolator, so it is possible use the original names of
properties and it is possible to write complex expressions.
An example (please, keep in mind that the following example was written
considering the simplicity of the same, not its correct syntax, so the XML
presented here is not well formed. For example, instead of the && you must
write ):



MY_SITE_SKIP_ACTIVATED

=

var mySiteSkip =
aitor.eval('${MY_SITE_SKIP}').getBoolean(false);
var reportsEnabled =
aitor.eval('${REPORTS_ENABLED}').getBoolean(false);
var reportsLevel = aitor.eval('${REPORTS_LEVEL}').getInt(0);
var siteUrl = aitor.eval('${SITE_URL}').getString('');
var siteDefined = ( siteUrl != '' );
mySiteSkip && reportsEnabled && ( reportsLevel > 0 ) &&
siteDefined



--
Reply
 message --
From: Ramón Rial <rri...@gmail.com>
Date: 2015-08-25 19:57 GMT+02:00
Subject: About profile activation with JSR223
To: dev@maven.apache.org


Hello.

*About JSR223 support for activating Profiles*
I have a modified version of *PropertyProfileActivation.java* that allows
activate a profile evaluating a script.
I've done that with JSR223, and it is a minimal modification.
The idea is:

   - Keep the old funcionality for property profile activation.
   - Allow the evaluation of scripts in some of the JSR223 languages
   allowed.
   - Add to the context of the evaluation the *ProjectProperties*, the
   *UserProperties* and *SystemProperties*.

*An example of this:*







=JavaScript

( projectProperty == 'value'  systemProperty
== '45' )

|| ( userProperty == 'development' )







The explanation

The key to get this without modifying the current model of pom and choose
an ScriptEngine is the name of the property.

It begins with "*=*" (equals) char, to indicate that value is a JSR223
script, and after the equals char the name of the script engine.

We write the script in the value tag.

You can see in the example that we use system properties, project
properties and user properties, *AND* and *OR* logical operators, so you
can write so complex scripts as you want.

The logical AND should be written as  because of XML.

*IMPORTANT*: The new *PropertyProfileActivation.java* converts the name of
the project properties, system properties and user properties to a safe
name, to allow use them in the script, so if you have a project property
with the name "*my.project.property*" it will be replaced in the script
context to "*my_project_property*".

Question

Do you think this could be interesting for Maven 3?

Greetings.

About profile activation with JSR223

2015-08-25 Thread Ramón Rial

Hello.

*About JSR223 support for activating Profiles*
I have a modified version of *PropertyProfileActivation.java* that allows
activate a profile evaluating a script.
I've done that with JSR223, and it is a minimal modification.
The idea is:

   - Keep the old funcionality for property profile activation.
   - Allow the evaluation of scripts in some of the JSR223 languages
   allowed.
   - Add to the context of the evaluation the *ProjectProperties*, the
   *UserProperties* and *SystemProperties*.

*An example of this:*

profile

activation

property

name=JavaScript/name

value( projectProperty == 'value' amp;amp; systemProperty
== '45' )

|| ( userProperty == 'development' )/value

/property

/activation

/profile

The explanation

The key to get this without modifying the current model of pom and choose
an ScriptEngine is the name of the property.

It begins with *=* (equals) char, to indicate that value is a JSR223
script, and after the equals char the name of the script engine.

We write the script in the value tag.

You can see in the example that we use system properties, project
properties and user properties, *AND* and *OR* logical operators, so you
can write so complex scripts as you want.

The logical AND should be written as amp;amp; because of XML.

*IMPORTANT*: The new *PropertyProfileActivation.java* converts the name of
the project properties, system properties and user properties to a safe
name, to allow use them in the script, so if you have a project property
with the name *my.project.property* it will be replaced in the script
context to *my_project_property*.

Question

Do you think this could be interesting for Maven 3?

Greetings.

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-20 Thread mikebrock

Github user mikebrock commented on the pull request:

https://github.com/apache/maven/pull/20#issuecomment-46737130
  
I think that could be pretty cool. I see no reason why not. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-19 Thread ChristianSchulte

Github user ChristianSchulte commented on the pull request:

https://github.com/apache/maven/pull/20#issuecomment-46546268
  
Another option would be to provide support for activations based on some 
language like:
activation
  expressionOS IS 'Linux' AND ( PROPERTY 'Some Name' IS 'true' OR JDK IS 
'1.6 )/expression
/activation
Maybe some scripting language provided by the platform ScriptEngine.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-19 Thread ChristianSchulte

Github user ChristianSchulte commented on the pull request:

https://github.com/apache/maven/pull/20#issuecomment-46547866
  
Could be as simple as:
```
activation
  script engine-name= || extension= || mime-type=simple script 
evaluating to a boolean/script
/activation
```
'engine-name' translates to javax.script.ScriptEngine.getEngineByName()
'extension' translates to javax.script.ScriptEngine.getEngineByExtension()
'mime-type' translates to javax.script.ScriptEngine.getEngineByMimeType()

All you need to do is populating the corresponding script engine scope with 
some pre-defined values.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-19 Thread jvanzyl

Github user jvanzyl commented on the pull request:

https://github.com/apache/maven/pull/20#issuecomment-46555048
  
I think Christian's idea is better as the logic is contained to the 
specific activator. I'm not keen at all to add conditional logic to the POM 
model anywhere, or any type of expression language being required for the POM 
4.0.0 model or general XML model. Maybe an activator using MVEL would work well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-19 Thread jvanzyl

Github user jvanzyl commented on the pull request:

https://github.com/apache/maven/pull/20#issuecomment-46562788
  
@mikebrock Do you think MVEL would be suitable for a one expression 
evaluator for a Maven profile activator? Imagine putting a MavenProject/pom.xml 
in the MVEL context and doing some boolean evaluation.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-18 Thread FredipusRex

Github user FredipusRex commented on the pull request:

https://github.com/apache/maven/pull/20#issuecomment-46523185
  
You do realize that the current OR condition is actually out in use right 
now in many POM files, right? This was previously the subject of a patch 
(MNG-3106) - originally only one condition was accepted which was patched to 
allow for ORing of conditions - arguably the wrong thing to do, but it's pretty 
well understood out in the Maven community. While this patch finally matches 
Maven to the Sonatype book, it will break a lot of POMs without recourse other 
than multiple, near duplicate activations.

The right way to fix this would have been to add the ability to specify the 
condition (AND, OR), perhaps through a set of tag attributes.

activation
property
nameJDKCheck/name
valuetrue/value
/property
property
nameNeedsJava4or5/name
/property
os group=1 condition=OR group-condition=AND
nameLinux/name
/os
jdk group=11.6/jdk
jdk group=2 condition=AND group-condition=OR1.4/jdk
jdk group=21.5/jdk
/activation

All conditions now belong to a group - either the default group or a named 
group attribute. Members of the default group have no attributes and are AND'd 
together (keeping the functionality of your patch). There do not need to be any 
members of the default group - in which case, it acts purely as glue to named 
groups.

One member of each named group must indicate how the group relates to the 
default group via the condition attribute and how the members of the group are 
related to each other via the group-condition attribute.

This allows compact but complex relationships. The above example is 
activated when the JDKCheck property is true and the NeedsJava4or5 property 
exists and the JDK is 1.4 or 1.5, or when compiling under Linux and the JDK is 
1.6. It does not allow infinite numbers of levels and parenthetical statements, 
but does provide for most common build scenarios. When there are no members of 
the default group, it should be assumed to be not activated and the first group 
(if any) with the AND condition should be considered the default group. This 
allows something like group 1-OR with group 2-AND to act like an either/or 
choice.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-18 Thread MysterionRise

Github user MysterionRise commented on the pull request:

https://github.com/apache/maven/pull/20#issuecomment-46524647
  
First of all - thanks for your email.
I understand, that this will ruin current ORing technique, but at least it
could be fixed with copying for a while.

What about complex conditions - it's my next step, I see that people needs
complicated conditions, so definitely me or somebody else could provide it
. 4565 was the first step, to try how it will going.

So, next step would be formalizing task for AND and OR in activation
section and then it could be fixed too.

Konstantin
On Jun 19, 2014 8:45 AM, FredipusRex notificati...@github.com wrote:

 You do realize that the current OR condition is actually out in use right
 now in many POM files, right? This was previously the subject of a patch
 (MNG-3106) - originally only one condition was accepted which was patched
 to allow for ORing of conditions - arguably the wrong thing to do, but 
it's
 pretty well understood out in the Maven community. While this patch 
finally
 matches Maven to the Sonatype book, it will break a lot of POMs without
 recourse other than multiple, near duplicate activations.

 The right way to fix this would have been to add the ability to specify
 the condition (AND, OR), perhaps through a set of tag attributes.



 JDKCheck
 true


 NeedsJava4or5


 Linux

 1.6
 1.4
 1.5

 All conditions now belong to a group - either the default group or a named
 group attribute. Members of the default group have no attributes and are
 AND'd together (keeping the functionality of your patch). There do not 
need
 to be any members of the default group - in which case, it acts purely as
 glue to named groups.

 One member of each named group must indicate how the group relates to the
 default group via the condition attribute and how the members of the group
 are related to each other via the group-condition attribute.

 This allows compact but complex relationships. The above example is
 activated when the JDKCheck property is true and the NeedsJava4or5 
property
 exists and the JDK is 1.4 or 1.5, or when compiling under Linux and the 
JDK
 is 1.6. It does not allow infinite numbers of levels and parenthetical
 statements, but does provide for most common build scenarios. When there
 are no members of the default group, it should be assumed to be not
 activated and the first group (if any) with the AND condition should be
 considered the default group. This allows something like group 1-OR with
 group 2-AND to act like an either/or choice.

 â
 Reply to this email directly or view it on GitHub
 https://github.com/apache/maven/pull/20#issuecomment-46523185.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: MNG-3106 implemented profile activation incorrectly

2014-06-12 Thread Hervé BOUTEMY

the canonical documentation for that should be 
http://maven.apache.org/ref/3-LATEST/maven-model/maven.html#class_activation 
IMHO

and yes, AND seems the right choice

Regards,

Hervé

Le mardi 10 juin 2014 18:25:28 Jason van Zyl a écrit :
 I'm working on a PR for http://jira.codehaus.org/browse/MNG-4565, which is
 related to what happened in http://jira.codehaus.org/browse/MNG-3106 in
 that profiles with multiple activators undergo an OR instead of an AND.
 
 If you want OR behaviour you can specify multiple profiles each with a
 single activator for the condition you want satisfied. It doesn't make any
 sense to OR multiple activators within a single profile because it's
 impossible to require multiple conditions to met for a profile to be
 activated.
 
 The Sonatype book is not our canonical documentation for Maven but has the
 only reference I can find describing the logic for multiple activators
 within a profile and it describes activators being AND'd:
 
 http://books.sonatype.com/mvnref-book/reference/profiles-sect-activation.htm
 l#profiles-sect-activation-config
 
 At the cost of potentially having to duplicate a profile to get OR behavior,
 at least it's possible to have AND behaviour with multiple activators being
 AND'd. In it's current form profile activation makes it impossible to do
 often required.
 
 Unless anyone objects I'm going to process 
 http://jira.codehaus.org/browse/MNG-4565 and make multiple activators be
 AND'd. It's just been implemented incorrectly.
 
 Thanks,
 
 Jason
 
 --
 Jason van Zyl
 Founder,  Apache Maven
 http://twitter.com/jvanzyl
 http://twitter.com/takari_io
 -
 
 To do two things at once is to do neither.
 
  -- Publilius Syrus, Roman slave, first century B.C.


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-12 Thread MysterionRise

Github user MysterionRise closed the pull request at:

https://github.com/apache/maven/pull/20


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

Github user jvanzyl commented on the pull request:

https://github.com/apache/maven/pull/20#issuecomment-45731097
  
What's the link you used for reference?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

Github user MysterionRise commented on the pull request:

https://github.com/apache/maven/pull/20#issuecomment-45731386
  
http://jira.codehaus.org/browse/MNG-4565 - take a look here. It have link 
for reference

http://books.sonatype.com/mvnref-book/reference/profiles-sect-activation.html#profiles-sect-activation-config

Quote: Activations can contain one of more selectors including JDK 
versions, Operating System parameters, files, and properties. A profile is 
activated when all activation criteria has been satisfied.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

Github user jvanzyl commented on the pull request:

https://github.com/apache/maven/pull/20#issuecomment-45731568
  
Yes, that is the Sonatype book which is the de facto reference for Maven 
but not the official specification but probably as close to one as we have. The 
actual documentation on the site regarding profiles is pretty vague.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

Github user MysterionRise commented on the pull request:

https://github.com/apache/maven/pull/20#issuecomment-45731774
  
Hm, probably you are correct. I've just have strong feeling, when somebody 
said 'Sonatype' - think about 'Maven' and vice-versa.

Regarding PR, let me know, if I need to fix something or anything else. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

Github user jvanzyl commented on the pull request:

https://github.com/apache/maven/pull/20#issuecomment-45732464
  
Yes, that's not uncommon. The PR is fine, just waiting for any feedback on 
the Maven dev list. There is one IT I would disable going forward (which tests 
that the activators are OR'd) and write a new one that tests that activators 
are AND'd.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

Github user jvanzyl commented on the pull request:

https://github.com/apache/maven/pull/20#issuecomment-45744828
  
Ok, I've written an integration test and I'll see what falls out on the 
Maven dev list today.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-11 Thread mosabua

Github user mosabua commented on the pull request:

https://github.com/apache/maven/pull/20#issuecomment-45811127
  
if we need to change something in the book - I can take care of that. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

Github user jvanzyl commented on the pull request:

https://github.com/apache/maven/pull/20#issuecomment-45811451
  
This change will actually make it match the book.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

Github user jvanzyl commented on the pull request:

https://github.com/apache/maven/pull/20#issuecomment-45820916
  
@Konstantin, I've applied your patch and pushed the integration test. Try 
it out and if it's good then close the pull request.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

Github user MysterionRise commented on the pull request:

https://github.com/apache/maven/pull/20#issuecomment-45825613
  
Let me check.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

Github user MysterionRise commented on the pull request:

https://github.com/apache/maven/pull/20#issuecomment-45826259
  
@jvanzyl Looks correct, please close this PR


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-10 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/maven/pull/16


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-10 Thread MysterionRise

Github user MysterionRise commented on the pull request:

https://github.com/apache/maven/pull/16#issuecomment-45643803
  
I'm sorry, I don't understand, why you close this PR? Does it bad? I miss 
something?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-10 Thread jvanzyl

Github user jvanzyl commented on the pull request:

https://github.com/apache/maven/pull/16#issuecomment-45644286
  
Sorry, cut and paste error on my part when closing the other issues. Can 
you reopen the PR again and I'll process it this afternoon.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-10 Thread MysterionRise

GitHub user MysterionRise opened a pull request:

https://github.com/apache/maven/pull/20

[MNG-4565] Multiple profile activation conditions does not work

Add possibilty to use multiple activators and have AND between them

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MysterionRise/maven MNG-4565

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/maven/pull/20.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #20






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-10 Thread jvanzyl

Github user jvanzyl commented on the pull request:

https://github.com/apache/maven/pull/16#issuecomment-45673757
  
I'm looking for a way to make this work, but this breaks MNG-3106 where the 
current behaviour is to OR the activators. I agree there are cases where AND is 
preferable but I don't want to break the existing behavior. Let me see what I 
can do.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

MNG-3106 implemented profile activation incorrectly

2014-06-10 Thread Jason van Zyl

I'm working on a PR for http://jira.codehaus.org/browse/MNG-4565, which is 
related to what happened in http://jira.codehaus.org/browse/MNG-3106 in that 
profiles with multiple activators undergo an OR instead of an AND.

If you want OR behaviour you can specify multiple profiles each with a single 
activator for the condition you want satisfied. It doesn't make any sense to OR 
multiple activators within a single profile because it's impossible to require 
multiple conditions to met for a profile to be activated.

The Sonatype book is not our canonical documentation for Maven but has the only 
reference I can find describing the logic for multiple activators within a 
profile and it describes activators being AND'd:

http://books.sonatype.com/mvnref-book/reference/profiles-sect-activation.html#profiles-sect-activation-config

At the cost of potentially having to duplicate a profile to get OR behavior, at 
least it's possible to have AND behaviour with multiple activators being AND'd. 
In it's current form profile activation makes it impossible to do often 
required.

Unless anyone objects I'm going to process  
http://jira.codehaus.org/browse/MNG-4565 and make multiple activators be AND'd. 
It's just been implemented incorrectly.

Thanks,

Jason

--
Jason van Zyl
Founder,  Apache Maven
http://twitter.com/jvanzyl
http://twitter.com/takari_io
-

To do two things at once is to do neither.
 
 -- Publilius Syrus, Roman slave, first century B.C.

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-10 Thread jvanzyl

Github user jvanzyl commented on the pull request:

https://github.com/apache/maven/pull/20#issuecomment-45681556
  
I have argued on the Maven dev list to process your patch. The current 
implementation I believe to be incorrect.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: MNG-3106 implemented profile activation incorrectly

2014-06-10 Thread Paul Benedict

No problem for me. While you are at it, the Maven Release notes on the
website (if it exists yet for the upcoming version) should probably get a
compatibility issue note about this.

Cheers,
Paul

On Tue, Jun 10, 2014 at 5:25 PM, Jason van Zyl ja...@takari.io wrote:

I'm working on a PR for http://jira.codehaus.org/browse/MNG-4565, which
is related to what happened in http://jira.codehaus.org/browse/MNG-3106
in that profiles with multiple activators undergo an OR instead of an AND.

If you want OR behaviour you can specify multiple profiles each with a
single activator for the condition you want satisfied. It doesn't make any
sense to OR multiple activators within a single profile because it's
impossible to require multiple conditions to met for a profile to be
activated.

The Sonatype book is not our canonical documentation for Maven but has the
only reference I can find describing the logic for multiple activators
within a profile and it describes activators being AND'd:

http://books.sonatype.com/mvnref-book/reference/profiles-sect-activation.html#profiles-sect-activation-config

At the cost of potentially having to duplicate a profile to get OR
behavior, at least it's possible to have AND behaviour with multiple
activators being AND'd. In it's current form profile activation makes it
impossible to do often required.

Unless anyone objects I'm going to process
http://jira.codehaus.org/browse/MNG-4565 and make multiple activators be
AND'd. It's just been implemented incorrectly.

Thanks,

Jason

--
Jason van Zyl
Founder, Apache Maven
http://twitter.com/jvanzyl
http://twitter.com/takari_io
-

To do two things at once is to do neither.

-- Publilius Syrus, Roman slave, first century B.C.

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-10 Thread MysterionRise

Github user MysterionRise commented on the pull request:

https://github.com/apache/maven/pull/20#issuecomment-45704618
  
I've implement this patch, only cause it's 100% relates with official 
documentation.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-08 Thread MysterionRise

Github user MysterionRise commented on the pull request:

https://github.com/apache/maven/pull/16#issuecomment-45431277
  
Just wonder, is there anything I could do?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-08 Thread jvanzyl

Github user jvanzyl commented on the pull request:

https://github.com/apache/maven/pull/16#issuecomment-45442939
  
Tonight I'll try to process all the outstanding PRs. I'll let you know if I 
need anything.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-04 Thread MysterionRise

Github user MysterionRise commented on the pull request:

https://github.com/apache/maven/pull/16#issuecomment-45134460
  
I've update pull request. I change my approach, so it will not now a 
platform dependable. But ITs are still failing at weird place. I'm 100% sure, 
that it's not my fault


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-04 Thread jvanzyl

Github user jvanzyl commented on the pull request:

https://github.com/apache/maven/pull/16#issuecomment-45138360
  
Cool, I'll take a look at look at the specific IT failure.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-02 Thread MysterionRise

Github user MysterionRise commented on the pull request:

https://github.com/apache/maven/pull/16#issuecomment-44831587
  
Good stuff. I will try it today.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-01 Thread jvanzyl

Github user jvanzyl commented on the pull request:

https://github.com/apache/maven/pull/16#issuecomment-44797771
  
I created a simple shell script to help validate a pull request against the 
Maven integration tests. This script is not great, and running the Maven 
integration tests is not exactly straight forward but this is a step in the 
right direction. Here is the shell script:

https://gist.github.com/jvanzyl/16da25976f8ad27293fa

Save the file to something like `maven-pr-validator.sh` and you run it by 
providing the PR #. So in your case you will run it as `maven-pr-validator.sh 
16` and this will check out Maven, apply your patch, build Maven, check out the 
integration tests and run them against the just-build Maven. You will see that 
one of the integration tests is broken as a result of the patch. I will help 
you debug and fix it. This is not ideal but it's a step in the right direction 
in helping interested users vet their contributions automatically.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

Github user MysterionRise commented on the pull request:

https://github.com/apache/maven/pull/16#issuecomment-44749028
  
Any updates on my pull request? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: [GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-05-31 Thread Jason van Zyl

I applied your changes and your test fails. If you want to take look and 
validate I will take a look later in the weekend.

---
 T E S T S
---
Running org.apache.maven.model.building.ComplexActivationTest
Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.171 sec  
FAILURE! - in org.apache.maven.model.building.ComplexActivationTest
testAndConditionInActivation(org.apache.maven.model.building.ComplexActivationTest)
  Time elapsed: 0.158 sec   FAILURE!
junit.framework.AssertionFailedError
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at junit.framework.Assert.assertNull(Assert.java:230)
at junit.framework.Assert.assertNull(Assert.java:223)
at 
org.apache.maven.model.building.ComplexActivationTest.testAndConditionInActivation(ComplexActivationTest.java:52)

Running org.apache.maven.model.building.DefaultModelBuilderFactoryTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.005 sec - in 
org.apache.maven.model.building.DefaultModelBuilderFactoryTest
Running org.apache.maven.model.inheritance.DefaultInheritanceAssemblerTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.678 sec - in 
org.apache.maven.model.inheritance.DefaultInheritanceAssemblerTest
Running org.apache.maven.model.interpolation.StringSearchModelInterpolatorTest
Tests run: 28, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.579 sec - in 
org.apache.maven.model.interpolation.StringSearchModelInterpolatorTest
Running org.apache.maven.model.path.DefaultUrlNormalizerTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 sec - in 
org.apache.maven.model.path.DefaultUrlNormalizerTest
Running org.apache.maven.model.profile.activation.JdkVersionProfileActivatorTest
Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.103 sec - in 
org.apache.maven.model.profile.activation.JdkVersionProfileActivatorTest
Running org.apache.maven.model.profile.activation.PropertyProfileActivatorTest
Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.13 sec - in 
org.apache.maven.model.profile.activation.PropertyProfileActivatorTest
Running org.apache.maven.model.validation.DefaultModelValidatorTest
Tests run: 44, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.512 sec - in 
org.apache.maven.model.validation.DefaultModelValidatorTest

Results :

Failed tests: 
  
org.apache.maven.model.building.ComplexActivationTest#testAndConditionInActivation
 AssertionFailedError

On May 31, 2014, at 10:00 AM, MysterionRise g...@git.apache.org wrote:

 Github user MysterionRise commented on the pull request:
 
https://github.com/apache/maven/pull/16#issuecomment-44749028
 
Any updates on my pull request? 
 
 
 ---
 If your project is set up for it, you can reply to this email and have your
 reply appear on GitHub as well. If your project does not have this feature
 enabled and wishes so, or if the feature is enabled but not working, please
 contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
 with INFRA.
 ---
 
 -
 To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
 For additional commands, e-mail: dev-h...@maven.apache.org
 

Thanks,

Jason

--
Jason van Zyl
Founder,  Apache Maven
http://twitter.com/jvanzyl
http://twitter.com/takari_io
-

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

Github user MysterionRise commented on the pull request:

https://github.com/apache/maven/pull/16#issuecomment-44751378
  
Could you tell me, what did you use?

I've run tests on Linux:

mvn -version
Apache Maven 3.0.5 (r01de14724cdef164cd33c7c8c2fe155faf9602da; 2013-02-19 
17:51:28+0400)
Maven home: /home/mysterion/Downloads/apache-maven-3.0.5
Java version: 1.7.0_25, vendor: Oracle Corporation
Java home: /home/mysterion/Downloads/jdk1.7.0_25/jre
Default locale: en_US, platform encoding: UTF-8
OS name: linux, version: 3.13.0-27-generic, arch: amd64, family: 
unix

also, i've try with windows

mvn -version
Apache Maven 3.2.1 (ea8b2b07643dbb1b84b6d16e1f08391b666bc1e9; 
2014-02-14T21:37:5
2+04:00)
Maven home: 
C:\Users\User\Downloads\apache-maven-3.2.1-bin\apache-maven-3.2.1\bi
n\..
Java version: 1.7.0_55, vendor: Oracle Corporation
Java home: C:\Program Files (x86)\Java\jdk1.7.0_55\jre
Default locale: ru_RU, platform encoding: Cp1251
OS name: windows 8, version: 6.2, arch: x86, family: windows

and all tests are also passed.

Did you use anything that isn't from family: windows or unix?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

Github user jvanzyl commented on the pull request:

https://github.com/apache/maven/pull/16#issuecomment-44755377
  
I used Maven, master branch at revision 
73d35ba9597cd867717310ae8813376888debb9b. I applied your patch to master, and 
ran the tests with Maven 3.2.1 on OSX.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

Github user MysterionRise commented on the pull request:

https://github.com/apache/maven/pull/16#issuecomment-44755927
  
Awesome,this is the only platform, I couldn't test against.Could you 
specify your _mvn -version_ output? I will try to fix test.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

Github user jvanzyl commented on the pull request:

https://github.com/apache/maven/pull/16#issuecomment-44756291
  
Apache Maven 3.2.1 (ea8b2b07643dbb1b84b6d16e1f08391b666bc1e9; 
2014-02-14T12:37:52-05:00)
Maven home: /Users/jvanzyl/m2
Java version: 1.7.0_21, vendor: Oracle Corporation
Java home: 
/Library/Java/JavaVirtualMachines/jdk1.7.0_21.jdk/Contents/Home/jre
Default locale: en_US, platform encoding: UTF-8
OS name: mac os x, version: 10.9.2, arch: x86_64, family: mac

But the same test fails against master as well. You might not want to use 
platform activators in the tests.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

Github user MysterionRise commented on the pull request:

https://github.com/apache/maven/pull/16#issuecomment-44756590
  
Not understand your point about failing against master.

I agree that platform activators is not good idea. So same with JDK 
activator, right? I'm only left with existing/missing file (what I've already 
use) and property activator (which is tricky for testing)

So, how we could resolve it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

Github user jvanzyl commented on the pull request:

https://github.com/apache/maven/pull/16#issuecomment-44756676
  
I will take a look as soon as I can. Maybe making an activator specifically 
for helping us test this will be better. Thanks for being patient, we'll get 
this sorted and integrated.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

Github user jvanzyl commented on the pull request:

https://github.com/apache/maven/pull/16#issuecomment-44756700
  
Maybe creating an activator specifically for testing this might be better. 
I will take a look as soon as I can. Likely tomorrow. Thanks for your patience, 
we'll get this integrated shortly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...