Re: Build Error

2009-11-13 Thread Jacques Le Roux

Thanks Adrian,

Yes I did not care and build with ant from Eclipse where I use the 1.6 JDK. I'm on it, not as simple as I thought some problem 
appeared...

In the meantime can you use 1.6 to build ?
BTW, could we not change from 1.5 to 1.6, is there any blocking reasons I don't 
remember ?

Jacques

From: Adrian Crum adrian.c...@yahoo.com

Latest trunk:

Compiling 129 source files to C:\ofbiz\framework\entity\build\classes
 [javac15] C:\ofbiz\framework\entity\src\org\ofbiz\entity\connection\DBCPConnectionFactory.java:21: cannot access 
org.apache.commons.dbcp.ConnectionFactory
 [javac15] bad class file: 
C:\ofbiz\framework\entity\lib\commons-dbcp-1.3-2009-r834702.jar(org/apache/commons/dbcp/ConnectionFactory.class)

 [javac15] class file has wrong version 50.0, should be 49.0
 [javac15] Please remove or make sure it appears in the correct subdirectory of 
the classpath.
 [javac15] import org.apache.commons.dbcp.ConnectionFactory;
 [javac15]^
 [javac15] 1 error










Re: adding salesOrder data to the BI component

2009-11-13 Thread Hans Bakker
Thank you Jacopo, we will work in that direction...

Regards,
hans

On Fri, 2009-11-13 at 08:43 +0100, Jacopo Cappellato wrote:
 Hans,
 
 first of all: it is great that you are interested on enhancing the star 
 schemas and dimensions; also using Birt on top of them will be a great way of 
 using them.
 I would really suggest the following book:
 
 http://www.amazon.com/gp/product/0471200247
 
 If you can get it (or a digital copy of it) you will appreciate the way it is 
 written; I can also help to point you to the most important sections to speed 
 up.
 BTW, regarding sales orders:
 
 1) I would suggest to implement the new star schema (and supporting 
 eca/services) for sales orders in the order component 
 (org.ofbiz.bi.starschema.order)
 2) the start schema could be based on the schema described in the book at 
 page 116;
 2.1) its name could be SalesOrderItemFact and its field could be: orderId*, 
 orderItemSeqId*, dateDimensionId, productDimentionId, currencyDimensionId, 
 orderQuantity, grossOrderTotalAmount, orderDiscountDollarAmount, 
 netOrderDollarAmount
 
 Let me know if I can help more, I would be happy to.
 
 Jacopo
 
 On Nov 13, 2009, at 7:19 AM, Hans Bakker wrote:
 
  for example we like to see which sales oriented data: which orders where 
  made through promotions,
  which orders are back-ordered etc...
  
  should be start a org.ofbiz.bi.starschema.salesOrders next to 
  org.ofbiz.bi.starschema.accounting?
  
  are there any rules to follow?
  
  The reason for all this: using birt to do sales reporting.
  
  -- 
  Antwebsystems.com: Quality OFBiz services for competitive rates
  
 
-- 
Antwebsystems.com: Quality OFBiz services for competitive rates



Re: Build Error in Tools?

2009-11-13 Thread Hans Bakker
In 1.6 it also not builds.

The error:
BUILD FAILED
/home/hans/ofbiz/svn/build.xml:182: The following error occurred while
executing this line:
/home/hans/ofbiz/svn/framework/build.xml:147: The following error
occurred while executing this line:
/home/hans/ofbiz/svn/macros.xml:27: The following error occurred while
executing this line:
/home/hans/ofbiz/svn/framework/entity/build.xml:56: The following error
occurred while executing this line:
/home/hans/ofbiz/svn/macros.xml:83: Problem: failed to create task or
type javacc
Cause: the class org.apache.tools.ant.taskdefs.optional.javacc.JavaCC
was not found.
This looks like one of Ant's optional components.
Action: Check that the appropriate optional JAR exists in
-/home/hans/ofbiz/svn/framework/base/lib
-/home/hans/.ant/lib
-a directory added on the command line with the -lib argument

Do not panic, this is a common problem.
The commonest cause is a missing JAR.

This is not a bug; it is a configuration problem




On Fri, 2009-11-13 at 08:59 +0100, Jacques Le Roux wrote:
 Thanks Adrian,
 
 Yes I did not care and build with ant from Eclipse where I use the 1.6 JDK. 
 I'm on it, not as simple as I thought some problem 
 appeared...
 In the meantime can you use 1.6 to build ?
 BTW, could we not change from 1.5 to 1.6, is there any blocking reasons I 
 don't remember ?
 
 Jacques
 
 From: Adrian Crum adrian.c...@yahoo.com
  Latest trunk:
 
  Compiling 129 source files to C:\ofbiz\framework\entity\build\classes
   [javac15] 
  C:\ofbiz\framework\entity\src\org\ofbiz\entity\connection\DBCPConnectionFactory.java:21:
   cannot access 
  org.apache.commons.dbcp.ConnectionFactory
   [javac15] bad class file: 
  C:\ofbiz\framework\entity\lib\commons-dbcp-1.3-2009-r834702.jar(org/apache/commons/dbcp/ConnectionFactory.class)
   [javac15] class file has wrong version 50.0, should be 49.0
   [javac15] Please remove or make sure it appears in the correct 
  subdirectory of the classpath.
   [javac15] import org.apache.commons.dbcp.ConnectionFactory;
   [javac15]^
   [javac15] 1 error
 
 
 
 
  
 
 
-- 
Antwebsystems.com: Quality OFBiz services for competitive rates



Re: Build Error in Tools?

2009-11-13 Thread Adam Heath
Hans Bakker wrote:
 In 1.6 it also not builds.
 
 The error:
 BUILD FAILED
 /home/hans/ofbiz/svn/build.xml:182: The following error occurred while
 executing this line:
 /home/hans/ofbiz/svn/framework/build.xml:147: The following error
 occurred while executing this line:
 /home/hans/ofbiz/svn/macros.xml:27: The following error occurred while
 executing this line:
 /home/hans/ofbiz/svn/framework/entity/build.xml:56: The following error
 occurred while executing this line:
 /home/hans/ofbiz/svn/macros.xml:83: Problem: failed to create task or
 type javacc
 Cause: the class org.apache.tools.ant.taskdefs.optional.javacc.JavaCC
 was not found.
 This looks like one of Ant's optional components.
 Action: Check that the appropriate optional JAR exists in
 -/home/hans/ofbiz/svn/framework/base/lib
 -/home/hans/.ant/lib
 -a directory added on the command line with the -lib argument
 
 Do not panic, this is a common problem.
 The commonest cause is a missing JAR.
 
 This is not a bug; it is a configuration problem

Fixed in 835774.


Re: Build Error in Tools?

2009-11-13 Thread Jacques Le Roux

It seems that this it's a combination with recent Adam's changes. I have an 
instance that I have not updated and I'm able to compile
it with 1.6. But with an updated instance I get the same error with 1.6.

The problem I get compiling DBCP with 1.5 is about JDBC 4, still on...

Jacques

From: Hans Bakker mailingl...@antwebsystems.com

In 1.6 it also not builds.

The error:
BUILD FAILED
/home/hans/ofbiz/svn/build.xml:182: The following error occurred while
executing this line:
/home/hans/ofbiz/svn/framework/build.xml:147: The following error
occurred while executing this line:
/home/hans/ofbiz/svn/macros.xml:27: The following error occurred while
executing this line:
/home/hans/ofbiz/svn/framework/entity/build.xml:56: The following error
occurred while executing this line:
/home/hans/ofbiz/svn/macros.xml:83: Problem: failed to create task or
type javacc
Cause: the class org.apache.tools.ant.taskdefs.optional.javacc.JavaCC
was not found.
   This looks like one of Ant's optional components.
Action: Check that the appropriate optional JAR exists in
   -/home/hans/ofbiz/svn/framework/base/lib
   -/home/hans/.ant/lib
   -a directory added on the command line with the -lib argument

Do not panic, this is a common problem.
The commonest cause is a missing JAR.

This is not a bug; it is a configuration problem




On Fri, 2009-11-13 at 08:59 +0100, Jacques Le Roux wrote:

Thanks Adrian,

Yes I did not care and build with ant from Eclipse where I use the 1.6 JDK. I'm 
on it, not as simple as I thought some problem
appeared...
In the meantime can you use 1.6 to build ?
BTW, could we not change from 1.5 to 1.6, is there any blocking reasons I don't 
remember ?

Jacques

From: Adrian Crum adrian.c...@yahoo.com
 Latest trunk:

 Compiling 129 source files to C:\ofbiz\framework\entity\build\classes
  [javac15] 
C:\ofbiz\framework\entity\src\org\ofbiz\entity\connection\DBCPConnectionFactory.java:21:
 cannot access
 org.apache.commons.dbcp.ConnectionFactory
  [javac15] bad class file:
 
C:\ofbiz\framework\entity\lib\commons-dbcp-1.3-2009-r834702.jar(org/apache/commons/dbcp/ConnectionFactory.class)
  [javac15] class file has wrong version 50.0, should be 49.0
  [javac15] Please remove or make sure it appears in the correct subdirectory 
of the classpath.
  [javac15] import org.apache.commons.dbcp.ConnectionFactory;
  [javac15]^
  [javac15] 1 error








--
Antwebsystems.com: Quality OFBiz services for competitive rates






Re: svn commit: r831098 - /ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/event/ServiceMultiEventHandler.java (Manual return functionality is broken)

2009-11-13 Thread Divesh Dutta

Hello Bilgin and others,

I found that Manual refund functionality is broken due to this commit . 
Steps to reproduce the error:


1) Create a sales order from Order manager application with two or more 
items.


2) Then approve and Quick ship the entire Order which will complete 
the order.


3) Then click on Create Return button on Actions Block.

4) You will land on Create new Return Page: Also attaching the screen 
shot. (Screenshot-1)


5) Click on select all check box and then click on Return Selected 
items button.


6) You will find that page is broken. Also attaching the screen shot for 
the same.  (Screenshot-2)


After doing research on this I found that reason for this code failure 
is in createReturnAndItemOrAdjustment simple method in 
OrderReturnServices.xml. This is because in below given code snippet :


   1if-empty field=parameters.returnId
   2  set-service-fields service-name=createReturnHeader 
map=parameters to-map=returnHeaderInMap/
   3  call-service service-name=createReturnHeader 
in-map-name=returnHeaderInMap

   4  result-to-field result-name=returnId field=returnId/
   5  /call-service
   6  check-errors/
   7  set field=parameters.returnId from-field=returnId/
   8  field-to-result field=returnId result-name=returnId/
   9   /if-empty

parameters.returnId field is always empty when this service is called as 
service-multi even though it is set in line #7.


And if I revert your this commit then this functionality is working fine.
So It will be great if you or any one else, give the reason of this 
commit and also provide fix or alternate way to solve this issue.


Thanks
--
Divesh Dutta.


bibr...@apache.org wrote:

Author: bibryam
Date: Thu Oct 29 21:35:49 2009
New Revision: 831098

URL: http://svn.apache.org/viewvc?rev=831098view=rev
Log:
Prevent overriding of service results in a service-multi type events.

Modified:

ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/event/ServiceMultiEventHandler.java

Modified: 
ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/event/ServiceMultiEventHandler.java
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/event/ServiceMultiEventHandler.java?rev=831098r1=831097r2=831098view=diff
==
--- 
ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/event/ServiceMultiEventHandler.java
 (original)
+++ 
ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/event/ServiceMultiEventHandler.java
 Thu Oct 29 21:35:49 2009
@@ -339,7 +339,7 @@
 if 
(!UtilValidate.isEmpty(result.get(ModelService.SUCCESS_MESSAGE_LIST))) {
 ListString newSuccessMessages = 
UtilGenerics.StringcheckList(result.get(ModelService.SUCCESS_MESSAGE_LIST));
 for (int j = 0; j  newSuccessMessages.size(); j++) {
-String newSuccessMessage = 
(String)newSuccessMessages.get(j);
+String newSuccessMessage = 
newSuccessMessages.get(j);
 if (!successMessages.contains(newSuccessMessage)) {
 successMessages.add(newSuccessMessage);
 }
@@ -355,7 +355,7 @@
 if (resultKey != null  
!ModelService.RESPONSE_MESSAGE.equals(resultKey)  
!ModelService.ERROR_MESSAGE.equals(resultKey) 
 !ModelService.ERROR_MESSAGE_LIST.equals(resultKey)  
!ModelService.ERROR_MESSAGE_MAP.equals(resultKey) 
 !ModelService.SUCCESS_MESSAGE.equals(resultKey) 
 !ModelService.SUCCESS_MESSAGE_LIST.equals(resultKey)) {
-request.setAttribute(resultKey, resultValue);
+request.setAttribute(resultKey + curSuffix, 
resultValue);
 }
 }
 }


  




Re: Build Error

2009-11-13 Thread Jacques Le Roux
I not totally sure but yet it seems that new versions of DBCP needs the 1.6 jdk (or jdk 1.4) . Extract from README.TXT : This 
release of JDBC compiles with and supports JDK 1.3 (JDBC 2.0), JDK 1.4-1.5 (JDBC 3.0) and JDK 1.6 (JDBC 4.0). 


I tried to build with 1.5 but it failed and I began to find a way out, not 
obvious...

So the alternative is
1) revert DBCP upgrade (fix a bug)
2) Decide to use jdk 1.6 for OFBiz

I would not like to push now for the 2d solution but as this upgrade was 
intended to fix a bug, I wonder if it's not the right time

In the meantime (before a decision is taken), I will continue to search a solution to compile with 1.5 but does not seem easy 
(conditional ANT compile deal with JDBC versions), and I'd not like to rewrite DBCP, even a part, I've other fish to fry ;o)


Jacques

From: Jacques Le Roux jacques.le.r...@les7arts.com

Thanks Adrian,

Yes I did not care and build with ant from Eclipse where I use the 1.6 JDK. I'm 
on it, not as simple as I thought some problem
appeared...
In the meantime can you use 1.6 to build ?
BTW, could we not change from 1.5 to 1.6, is there any blocking reasons I don't 
remember ?

Jacques

From: Adrian Crum adrian.c...@yahoo.com

Latest trunk:

Compiling 129 source files to C:\ofbiz\framework\entity\build\classes
 [javac15] 
C:\ofbiz\framework\entity\src\org\ofbiz\entity\connection\DBCPConnectionFactory.java:21:
 cannot access
org.apache.commons.dbcp.ConnectionFactory
 [javac15] bad class file:
C:\ofbiz\framework\entity\lib\commons-dbcp-1.3-2009-r834702.jar(org/apache/commons/dbcp/ConnectionFactory.class)
 [javac15] class file has wrong version 50.0, should be 49.0
 [javac15] Please remove or make sure it appears in the correct subdirectory of 
the classpath.
 [javac15] import org.apache.commons.dbcp.ConnectionFactory;
 [javac15]^
 [javac15] 1 error













Re: svn commit: r831098 - /ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/event/ServiceMultiEventHandler.java (Manual return functionality is broken)

2009-11-13 Thread Divesh Dutta
Also Adding urls of the image which I described. Please see my comments 
inline:


Divesh Dutta wrote:

Hello Bilgin and others,

I found that Manual refund functionality is broken due to this commit 
. Steps to reproduce the error:


1) Create a sales order from Order manager application with two or 
more items.


2) Then approve and Quick ship the entire Order which will complete 
the order.


3) Then click on Create Return button on Actions Block.

4) You will land on Create new Return Page: Also attaching the screen 
shot. (Screenshot-1)

http://img156.yfrog.com/i/screenshot1jw.png/



5) Click on select all check box and then click on Return Selected 
items button.


6) You will find that page is broken. Also attaching the screen shot 
for the same.  (Screenshot-2)

http://img156.yfrog.com/i/screenshot2kn.png/




After doing research on this I found that reason for this code failure 
is in createReturnAndItemOrAdjustment simple method in 
OrderReturnServices.xml. This is because in below given code snippet :


   1if-empty field=parameters.returnId
   2  set-service-fields service-name=createReturnHeader 
map=parameters to-map=returnHeaderInMap/
   3  call-service service-name=createReturnHeader 
in-map-name=returnHeaderInMap

   4  result-to-field result-name=returnId field=returnId/
   5  /call-service
   6  check-errors/
   7  set field=parameters.returnId from-field=returnId/
   8  field-to-result field=returnId result-name=returnId/
   9   /if-empty

parameters.returnId field is always empty when this service is called 
as service-multi even though it is set in line #7.


And if I revert your this commit then this functionality is working fine.
So It will be great if you or any one else, give the reason of this 
commit and also provide fix or alternate way to solve this issue.


Thanks
--
Divesh Dutta.


bibr...@apache.org wrote:

Author: bibryam
Date: Thu Oct 29 21:35:49 2009
New Revision: 831098

URL: http://svn.apache.org/viewvc?rev=831098view=rev
Log:
Prevent overriding of service results in a service-multi type events.

Modified:

ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/event/ServiceMultiEventHandler.java 



Modified: 
ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/event/ServiceMultiEventHandler.java 

URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/event/ServiceMultiEventHandler.java?rev=831098r1=831097r2=831098view=diff 

== 

--- 
ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/event/ServiceMultiEventHandler.java 
(original)
+++ 
ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/event/ServiceMultiEventHandler.java 
Thu Oct 29 21:35:49 2009

@@ -339,7 +339,7 @@
 if 
(!UtilValidate.isEmpty(result.get(ModelService.SUCCESS_MESSAGE_LIST))) {
 ListString newSuccessMessages = 
UtilGenerics.StringcheckList(result.get(ModelService.SUCCESS_MESSAGE_LIST)); 

 for (int j = 0; j  
newSuccessMessages.size(); j++) {
-String newSuccessMessage = 
(String)newSuccessMessages.get(j);
+String newSuccessMessage = 
newSuccessMessages.get(j);
 if 
(!successMessages.contains(newSuccessMessage)) {

 successMessages.add(newSuccessMessage);
 }
@@ -355,7 +355,7 @@
 if (resultKey != null  
!ModelService.RESPONSE_MESSAGE.equals(resultKey)  
!ModelService.ERROR_MESSAGE.equals(resultKey) 
 
!ModelService.ERROR_MESSAGE_LIST.equals(resultKey)  
!ModelService.ERROR_MESSAGE_MAP.equals(resultKey) 
 
!ModelService.SUCCESS_MESSAGE.equals(resultKey)  
!ModelService.SUCCESS_MESSAGE_LIST.equals(resultKey)) {
-request.setAttribute(resultKey, 
resultValue);
+request.setAttribute(resultKey + 
curSuffix, resultValue);

 }
 }
 }


  






Re: ERROR : Conversion from java.sql.Timestamp to java.sql.Date is not working

2009-11-13 Thread Divesh Dutta

Thanks Adrian for your quick turn around on this.

Regards
--
Divesh Dutta.

Adrian Crum wrote:

Fixed, rev 835032.

-Adrian

Divesh Dutta wrote:

Hello Adrian,

I saw your commits conversion related commits  to use only new 
conversion framework. I am working on latest revision number, and 
facing issue in Quick ship entire order functionality.


Reason is  below given code snippet in simple-method, 
findCustomTimePeriods of  PeriodServices.xml file :
condition-expr field-name=fromDate operator=less-equals 
from-field=parameters.findDate/  (here parameters.findDate is 
java.sql.Timestamp and fromDate is java.sql.Date)


is blocking the order to complete.

Here is the error which I am getting in console:

Could not convert field value for the field: [fromDate] on the 
[CustomTimePeriod] entity to the [java.sql.Date] type for the value 
[2009-11-11 16:41:09.053]: org.ofbiz.base.util.GeneralException: 
Conversion from java.sql.Timestamp to java.sql.Date not currently 
supported

Exception: org.ofbiz.base.util.GeneralException
Message: Conversion from java.sql.Timestamp to java.sql.Date not 
currently supported


i.e Currently OFBiz is not supporting conversion from 
java.sql.Timestamp to java.sql.Date.


It will be great if you look into the issue, as you asked to report 
on developer mailing list.


Thanks
--
Divesh Dutta






Re: Build Error

2009-11-13 Thread Scott Gray

I'd suggest that you revert it for now.

Regards
Scott

HotWax Media
http://www.hotwaxmedia.com

On 13/11/2009, at 10:20 PM, Jacques Le Roux wrote:

I not totally sure but yet it seems that new versions of DBCP needs  
the 1.6 jdk (or jdk 1.4) . Extract from README.TXT : This release  
of JDBC compiles with and supports JDK 1.3 (JDBC 2.0), JDK 1.4-1.5  
(JDBC 3.0) and JDK 1.6 (JDBC 4.0). 


I tried to build with 1.5 but it failed and I began to find a way  
out, not obvious...


So the alternative is
1) revert DBCP upgrade (fix a bug)
2) Decide to use jdk 1.6 for OFBiz

I would not like to push now for the 2d solution but as this upgrade  
was intended to fix a bug, I wonder if it's not the right time


In the meantime (before a decision is taken), I will continue to  
search a solution to compile with 1.5 but does not seem easy  
(conditional ANT compile deal with JDBC versions), and I'd not like  
to rewrite DBCP, even a part, I've other fish to fry ;o)


Jacques

From: Jacques Le Roux jacques.le.r...@les7arts.com

Thanks Adrian,

Yes I did not care and build with ant from Eclipse where I use the  
1.6 JDK. I'm on it, not as simple as I thought some problem

appeared...
In the meantime can you use 1.6 to build ?
BTW, could we not change from 1.5 to 1.6, is there any blocking  
reasons I don't remember ?


Jacques

From: Adrian Crum adrian.c...@yahoo.com

Latest trunk:

Compiling 129 source files to C:\ofbiz\framework\entity\build 
\classes
[javac15] C:\ofbiz\framework\entity\src\org\ofbiz\entity\connection 
\DBCPConnectionFactory.java:21: cannot access

org.apache.commons.dbcp.ConnectionFactory
[javac15] bad class file:
C:\ofbiz\framework\entity\lib\commons-dbcp-1.3-2009- 
r834702.jar(org/apache/commons/dbcp/ConnectionFactory.class)

[javac15] class file has wrong version 50.0, should be 49.0
[javac15] Please remove or make sure it appears in the correct  
subdirectory of the classpath.

[javac15] import org.apache.commons.dbcp.ConnectionFactory;
[javac15]^
[javac15] 1 error














smime.p7s
Description: S/MIME cryptographic signature


Re: svn commit: r834479 - in /ofbiz/trunk: applications/manufacturing/src/org/ofbiz/manufacturing/jobshopmgt/ applications/order/config/ applications/order/webapp/ordermgr/WEB-INF/ applications/order/

2009-11-13 Thread Divesh Dutta

Thanks for the appreciation Jacques :-)


Regards
--
Divesh Dutta.

Jacques Le Roux wrote:

Thank you Divesh!

Jacques

From: Ashish Vijaywargiya vijaywargiya.ash...@gmail.com

Thanks Jacques for your appreciation.
It really encourage us to work more and more for the community.

PS: Divesh please don't get upset - Jacques also said thank you by 
saying to

me ;-).

--
Ashish

On Thu, Nov 12, 2009 at 9:28 PM, Jacques Le Roux 
jacques.le.r...@les7arts.com wrote:


Hi Ashish,

I had a look, I like it very much (notably the production run link)

Thanks!

Jacques

 Author: ashish

Date: Tue Nov 10 14:32:53 2009
New Revision: 834479

URL: http://svn.apache.org/viewvc?rev=834479view=rev
Log:
Applied patch from jira issue OFBIZ-3173 - Better supportability for
products of type MARKETING_PKG_AUTO in order processing and 
fulfillment

process.
Following points are covered in this patch:
1) Show associated products for product of type 
MARKETING_PKG_AUTO on

order items section of show cart page in order manager application.

2) Marketing packages should only shown backordered when ATP of 
product
which compose Marketing packages product are less than quantity 
added in

cart.

3) Pick sheets should show Products of type Marketing Packages 
along with

the products which compose Marketing Packages.

4) Show link of production run created on order items section of Order
detail page while placing order for product of type 
MARKETING_PKG_AUTO.


5) Product of type Marketing Packages should be shown on Verify Pick
Screen along with Products they are composed of.

Thanks Divesh for the contribution - this is very nice addition to the
trunk.
I would be more then happy to see comments / concern from - Jacopo? 
Scott?

Anil? or others?













Re: Build Error

2009-11-13 Thread Divesh Dutta

+1

Regards
--
Divesh Dutta.


Scott Gray wrote:

I'd suggest that you revert it for now.

Regards
Scott

HotWax Media
http://www.hotwaxmedia.com

On 13/11/2009, at 10:20 PM, Jacques Le Roux wrote:

I not totally sure but yet it seems that new versions of DBCP needs 
the 1.6 jdk (or jdk 1.4) . Extract from README.TXT : This release 
of JDBC compiles with and supports JDK 1.3 (JDBC 2.0), JDK 1.4-1.5 
(JDBC 3.0) and JDK 1.6 (JDBC 4.0). 


I tried to build with 1.5 but it failed and I began to find a way 
out, not obvious...


So the alternative is
1) revert DBCP upgrade (fix a bug)
2) Decide to use jdk 1.6 for OFBiz

I would not like to push now for the 2d solution but as this upgrade 
was intended to fix a bug, I wonder if it's not the right time


In the meantime (before a decision is taken), I will continue to 
search a solution to compile with 1.5 but does not seem easy 
(conditional ANT compile deal with JDBC versions), and I'd not like 
to rewrite DBCP, even a part, I've other fish to fry ;o)


Jacques

From: Jacques Le Roux jacques.le.r...@les7arts.com

Thanks Adrian,

Yes I did not care and build with ant from Eclipse where I use the 
1.6 JDK. I'm on it, not as simple as I thought some problem

appeared...
In the meantime can you use 1.6 to build ?
BTW, could we not change from 1.5 to 1.6, is there any blocking 
reasons I don't remember ?


Jacques

From: Adrian Crum adrian.c...@yahoo.com

Latest trunk:

Compiling 129 source files to C:\ofbiz\framework\entity\build\classes
[javac15] 
C:\ofbiz\framework\entity\src\org\ofbiz\entity\connection\DBCPConnectionFactory.java:21: 
cannot access

org.apache.commons.dbcp.ConnectionFactory
[javac15] bad class file:
C:\ofbiz\framework\entity\lib\commons-dbcp-1.3-2009-r834702.jar(org/apache/commons/dbcp/ConnectionFactory.class) 


[javac15] class file has wrong version 50.0, should be 49.0
[javac15] Please remove or make sure it appears in the correct 
subdirectory of the classpath.

[javac15] import org.apache.commons.dbcp.ConnectionFactory;
[javac15]^
[javac15] 1 error
















[jira] Commented: (OFBIZ-3071) assigning security group to a party without validations

2009-11-13 Thread Abdullah Shaikh (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-3071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12777427#action_12777427
 ] 

Abdullah Shaikh commented on OFBIZ-3071:


Hmm.. yes I agree with David's explanation but there were some doubts in my 
mind, but I couldn't recollect them as its been a long time I opened this issue.

But the doubt I remember is regarding the permission without thruDate, I 
couldn't understand you could not create a temporary permission for a limited 
span of time, I guess if its a temporary permission it should be for a limited 
time.

Let me modify my example as per my argument regarding thruDate:

2007-10-10 10:55:10.000  NO THRU DATE
2007-11-10 10:55:10.000  NO THRU DATE

In the above example the first permission 2007-10-10 as been specified without 
thruDate this means the records will go on forever.
The second permission 2007-11-10 also doesn't have thruDate and this too will 
go on forever.

So as per the above scenario both the permissions will go on forever, for the 
same thing there are 2 permissions.

What I feel is we shouldn't allow the user to enter one more record without 
thruDate for the same permission type as no use of the second record.

If the second record is enter with thruDate then it makes sense as it will 
expire on the mentioned thruDate and the record without thruDate will be active.

I don't know if this is making sense, I mean this was what I was having in 
mind. Maybe I am missing something else.

Let me know what do you think of this.

 assigning security group to a party without validations
 ---

 Key: OFBIZ-3071
 URL: https://issues.apache.org/jira/browse/OFBIZ-3071
 Project: OFBiz
  Issue Type: Improvement
Reporter: Abdullah Shaikh
Priority: Minor
 Attachments: OFBIZ-3071_assigning security group to a party without 
 validations.patch


 When adding user login to Security Group, the fromDate  thruDate input 
 fields are not mandatory, if not specified the fromDate is set to current 
 timestamop and thruDate is entered in database as null, which means the user 
 login is assigned that Security Group forever, but when if the same Security 
 Group is added, it again adds it, but instead it should check that if the 
 thruDate is null in the already entered record then shouldn't add new record.
 If incase the thruDate is specified during the creation of 1st record then 
 while adding the 2nd record for the same Security Group, it should check if 
 the thruDate of previous record is before the fromDate of the new record, 
 this check also doesn't happen.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



Re: Build Error

2009-11-13 Thread Ashish Vijaywargiya
+1 for reverting the changes unless and until we find stable solution of
problem with Jdk1.5.
Thanks Jacques for your quick comment on this.

--
Ashish

On Fri, Nov 13, 2009 at 2:50 PM, Jacques Le Roux 
jacques.le.r...@les7arts.com wrote:

 I not totally sure but yet it seems that new versions of DBCP needs the 1.6
 jdk (or jdk 1.4) . Extract from README.TXT : This release of JDBC compiles
 with and supports JDK 1.3 (JDBC 2.0), JDK 1.4-1.5 (JDBC 3.0) and JDK 1.6
 (JDBC 4.0). 

 I tried to build with 1.5 but it failed and I began to find a way out, not
 obvious...

 So the alternative is
 1) revert DBCP upgrade (fix a bug)
 2) Decide to use jdk 1.6 for OFBiz

 I would not like to push now for the 2d solution but as this upgrade was
 intended to fix a bug, I wonder if it's not the right time

 In the meantime (before a decision is taken), I will continue to search a
 solution to compile with 1.5 but does not seem easy (conditional ANT compile
 deal with JDBC versions), and I'd not like to rewrite DBCP, even a part,
 I've other fish to fry ;o)

 Jacques

 From: Jacques Le Roux jacques.le.r...@les7arts.com

  Thanks Adrian,

 Yes I did not care and build with ant from Eclipse where I use the 1.6
 JDK. I'm on it, not as simple as I thought some problem
 appeared...
 In the meantime can you use 1.6 to build ?
 BTW, could we not change from 1.5 to 1.6, is there any blocking reasons I
 don't remember ?

 Jacques

 From: Adrian Crum adrian.c...@yahoo.com

 Latest trunk:

 Compiling 129 source files to C:\ofbiz\framework\entity\build\classes
  [javac15]
 C:\ofbiz\framework\entity\src\org\ofbiz\entity\connection\DBCPConnectionFactory.java:21:
 cannot access
 org.apache.commons.dbcp.ConnectionFactory
  [javac15] bad class file:

 C:\ofbiz\framework\entity\lib\commons-dbcp-1.3-2009-r834702.jar(org/apache/commons/dbcp/ConnectionFactory.class)
  [javac15] class file has wrong version 50.0, should be 49.0
  [javac15] Please remove or make sure it appears in the correct
 subdirectory of the classpath.
  [javac15] import org.apache.commons.dbcp.ConnectionFactory;
  [javac15]^
  [javac15] 1 error












Re: Build Error

2009-11-13 Thread Scott Gray
BTW, the latest nightly build from dbcp works just fine on 1.5 for me,  
why are you trying to compile dbcp?


Regards
Scott

On 13/11/2009, at 10:36 PM, Scott Gray wrote:


I'd suggest that you revert it for now.

Regards
Scott

HotWax Media
http://www.hotwaxmedia.com

On 13/11/2009, at 10:20 PM, Jacques Le Roux wrote:

I not totally sure but yet it seems that new versions of DBCP needs  
the 1.6 jdk (or jdk 1.4) . Extract from README.TXT : This release  
of JDBC compiles with and supports JDK 1.3 (JDBC 2.0), JDK 1.4-1.5  
(JDBC 3.0) and JDK 1.6 (JDBC 4.0). 


I tried to build with 1.5 but it failed and I began to find a way  
out, not obvious...


So the alternative is
1) revert DBCP upgrade (fix a bug)
2) Decide to use jdk 1.6 for OFBiz

I would not like to push now for the 2d solution but as this  
upgrade was intended to fix a bug, I wonder if it's not the right  
time


In the meantime (before a decision is taken), I will continue to  
search a solution to compile with 1.5 but does not seem easy  
(conditional ANT compile deal with JDBC versions), and I'd not like  
to rewrite DBCP, even a part, I've other fish to fry ;o)


Jacques

From: Jacques Le Roux jacques.le.r...@les7arts.com

Thanks Adrian,

Yes I did not care and build with ant from Eclipse where I use the  
1.6 JDK. I'm on it, not as simple as I thought some problem

appeared...
In the meantime can you use 1.6 to build ?
BTW, could we not change from 1.5 to 1.6, is there any blocking  
reasons I don't remember ?


Jacques

From: Adrian Crum adrian.c...@yahoo.com

Latest trunk:

Compiling 129 source files to C:\ofbiz\framework\entity\build 
\classes
[javac15] C:\ofbiz\framework\entity\src\org\ofbiz\entity 
\connection\DBCPConnectionFactory.java:21: cannot access

org.apache.commons.dbcp.ConnectionFactory
[javac15] bad class file:
C:\ofbiz\framework\entity\lib\commons-dbcp-1.3-2009- 
r834702.jar(org/apache/commons/dbcp/ConnectionFactory.class)

[javac15] class file has wrong version 50.0, should be 49.0
[javac15] Please remove or make sure it appears in the correct  
subdirectory of the classpath.

[javac15] import org.apache.commons.dbcp.ConnectionFactory;
[javac15]^
[javac15] 1 error
















smime.p7s
Description: S/MIME cryptographic signature


[jira] Commented: (OFBIZ-3190) Drag 'n' Drop for myPortal + update prototype and script.aculo.us

2009-11-13 Thread Bruno Busco (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-3190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12777437#action_12777437
 ] 

Bruno Busco commented on OFBIZ-3190:


Hi Sascha,
thank you for the great job you did.
I have reviewed your patch. Here are my comments:
1) It seems to me that the patch includes two different contributions: a) A 
script.aculo.us upgrade b) The portlet drag  drop feature.
The best would be to submit two different patches for this so that two 
different commits can be done.

2) I have noted that if I drag a portlet in a screen zone where no drop area is 
activated, the portlet remains in this position while it should go back to the 
original position aborting the move.

Thank you again for this work.


 Drag 'n' Drop for myPortal + update prototype and script.aculo.us
 -

 Key: OFBIZ-3190
 URL: https://issues.apache.org/jira/browse/OFBIZ-3190
 Project: OFBiz
  Issue Type: New Feature
  Components: framework
Affects Versions: SVN trunk
Reporter: Sascha Rodekamp
 Fix For: SVN trunk

 Attachments: Editing icon.jpg, myPortalDragNDrop.patch


 My first patch :-)
 Hi,
 I try to extend the myPortal component with a drag 'n' drop feature, using 
 the script.aculo.us libary.
 Therefor i updated prototype and script.aculo.us.
 What do you think of the implementation?
 Best regards
 Sascha

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



Re: Build Error

2009-11-13 Thread Jacques Le Roux

Hi Scott,

At which date was done this nightly build ? Where did you find it ?

BTW I have reverted both trunk and 9.04

Jacques

From: Scott Gray scott.g...@hotwaxmedia.com
BTW, the latest nightly build from dbcp works just fine on 1.5 for me,  
why are you trying to compile dbcp?


Regards
Scott

On 13/11/2009, at 10:36 PM, Scott Gray wrote:


I'd suggest that you revert it for now.

Regards
Scott

HotWax Media
http://www.hotwaxmedia.com

On 13/11/2009, at 10:20 PM, Jacques Le Roux wrote:

I not totally sure but yet it seems that new versions of DBCP needs  
the 1.6 jdk (or jdk 1.4) . Extract from README.TXT : This release  
of JDBC compiles with and supports JDK 1.3 (JDBC 2.0), JDK 1.4-1.5  
(JDBC 3.0) and JDK 1.6 (JDBC 4.0). 


I tried to build with 1.5 but it failed and I began to find a way  
out, not obvious...


So the alternative is
1) revert DBCP upgrade (fix a bug)
2) Decide to use jdk 1.6 for OFBiz

I would not like to push now for the 2d solution but as this  
upgrade was intended to fix a bug, I wonder if it's not the right  
time


In the meantime (before a decision is taken), I will continue to  
search a solution to compile with 1.5 but does not seem easy  
(conditional ANT compile deal with JDBC versions), and I'd not like  
to rewrite DBCP, even a part, I've other fish to fry ;o)


Jacques

From: Jacques Le Roux jacques.le.r...@les7arts.com

Thanks Adrian,

Yes I did not care and build with ant from Eclipse where I use the  
1.6 JDK. I'm on it, not as simple as I thought some problem

appeared...
In the meantime can you use 1.6 to build ?
BTW, could we not change from 1.5 to 1.6, is there any blocking  
reasons I don't remember ?


Jacques

From: Adrian Crum adrian.c...@yahoo.com

Latest trunk:

Compiling 129 source files to C:\ofbiz\framework\entity\build 
\classes
[javac15] C:\ofbiz\framework\entity\src\org\ofbiz\entity 
\connection\DBCPConnectionFactory.java:21: cannot access

org.apache.commons.dbcp.ConnectionFactory
[javac15] bad class file:
C:\ofbiz\framework\entity\lib\commons-dbcp-1.3-2009- 
r834702.jar(org/apache/commons/dbcp/ConnectionFactory.class)

[javac15] class file has wrong version 50.0, should be 49.0
[javac15] Please remove or make sure it appears in the correct  
subdirectory of the classpath.

[javac15] import org.apache.commons.dbcp.ConnectionFactory;
[javac15]^
[javac15] 1 error



















[jira] Commented: (OFBIZ-3071) assigning security group to a party without validations

2009-11-13 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-3071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12777439#action_12777439
 ] 

Jacques Le Roux commented on OFBIZ-3071:


Yes it makes sens but do we really need to constrain that ? 
What kind of trouble may we have ? For me it's only redundant and not a big 
deal;
Also is your patch handling this issue and only this issue ?

 assigning security group to a party without validations
 ---

 Key: OFBIZ-3071
 URL: https://issues.apache.org/jira/browse/OFBIZ-3071
 Project: OFBiz
  Issue Type: Improvement
Reporter: Abdullah Shaikh
Priority: Minor
 Attachments: OFBIZ-3071_assigning security group to a party without 
 validations.patch


 When adding user login to Security Group, the fromDate  thruDate input 
 fields are not mandatory, if not specified the fromDate is set to current 
 timestamop and thruDate is entered in database as null, which means the user 
 login is assigned that Security Group forever, but when if the same Security 
 Group is added, it again adds it, but instead it should check that if the 
 thruDate is null in the already entered record then shouldn't add new record.
 If incase the thruDate is specified during the creation of 1st record then 
 while adding the 2nd record for the same Security Group, it should check if 
 the thruDate of previous record is before the fromDate of the new record, 
 this check also doesn't happen.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



Re: Build Error

2009-11-13 Thread Jacopo Cappellato
http://people.apache.org/builds/commons/nightly/commons-dbcp/

Jacopo

On Nov 13, 2009, at 11:29 AM, Jacques Le Roux wrote:

 Hi Scott,
 
 At which date was done this nightly build ? Where did you find it ?
 
 BTW I have reverted both trunk and 9.04
 
 Jacques
 
 From: Scott Gray scott.g...@hotwaxmedia.com
 BTW, the latest nightly build from dbcp works just fine on 1.5 for me,  why 
 are you trying to compile dbcp?
 Regards
 Scott
 On 13/11/2009, at 10:36 PM, Scott Gray wrote:
 I'd suggest that you revert it for now.
 
 Regards
 Scott
 
 HotWax Media
 http://www.hotwaxmedia.com
 
 On 13/11/2009, at 10:20 PM, Jacques Le Roux wrote:
 
 I not totally sure but yet it seems that new versions of DBCP needs  the 
 1.6 jdk (or jdk 1.4) . Extract from README.TXT : This release  of JDBC 
 compiles with and supports JDK 1.3 (JDBC 2.0), JDK 1.4-1.5  (JDBC 3.0) and 
 JDK 1.6 (JDBC 4.0). 
 
 I tried to build with 1.5 but it failed and I began to find a way  out, 
 not obvious...
 
 So the alternative is
 1) revert DBCP upgrade (fix a bug)
 2) Decide to use jdk 1.6 for OFBiz
 
 I would not like to push now for the 2d solution but as this  upgrade was 
 intended to fix a bug, I wonder if it's not the right  time
 
 In the meantime (before a decision is taken), I will continue to  search a 
 solution to compile with 1.5 but does not seem easy  (conditional ANT 
 compile deal with JDBC versions), and I'd not like  to rewrite DBCP, even 
 a part, I've other fish to fry ;o)
 
 Jacques
 
 From: Jacques Le Roux jacques.le.r...@les7arts.com
 Thanks Adrian,
 
 Yes I did not care and build with ant from Eclipse where I use the  1.6 
 JDK. I'm on it, not as simple as I thought some problem
 appeared...
 In the meantime can you use 1.6 to build ?
 BTW, could we not change from 1.5 to 1.6, is there any blocking  reasons 
 I don't remember ?
 
 Jacques
 
 From: Adrian Crum adrian.c...@yahoo.com
 Latest trunk:
 
 Compiling 129 source files to C:\ofbiz\framework\entity\build \classes
 [javac15] C:\ofbiz\framework\entity\src\org\ofbiz\entity 
 \connection\DBCPConnectionFactory.java:21: cannot access
 org.apache.commons.dbcp.ConnectionFactory
 [javac15] bad class file:
 C:\ofbiz\framework\entity\lib\commons-dbcp-1.3-2009- 
 r834702.jar(org/apache/commons/dbcp/ConnectionFactory.class)
 [javac15] class file has wrong version 50.0, should be 49.0
 [javac15] Please remove or make sure it appears in the correct  
 subdirectory of the classpath.
 [javac15] import org.apache.commons.dbcp.ConnectionFactory;
 [javac15]^
 [javac15] 1 error
 
 
 
 
 
 
 
 
 
 
 



[jira] Commented: (OFBIZ-3084) Order with service type product payed with an offline payment generates multi invoices

2009-11-13 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-3084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12777443#action_12777443
 ] 

Jacques Le Roux commented on OFBIZ-3084:


Scott,

Yes, it works well in R9.04

Thanks

 Order with service type product payed with an offline payment generates multi 
 invoices
 --

 Key: OFBIZ-3084
 URL: https://issues.apache.org/jira/browse/OFBIZ-3084
 Project: OFBiz
  Issue Type: Bug
  Components: accounting, order
Affects Versions: Release Branch 9.04, SVN trunk
Reporter: Jacques Le Roux
Assignee: Scott Gray
 Fix For: SVN trunk


 If I buy a service type product with an offline payment an invoice with an 
 outstanding  payment is generated automatically for the corresponding order.
 If I hold the order and approve it again a new invoice is generated, and this 
 of course again and again.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



Re: Build Error

2009-11-13 Thread Jacques Le Roux

Thanks Jacopo,

These are really old ones or do I miss something ?

Jacques

From: Jacopo Cappellato jacopo.cappell...@hotwaxmedia.com

http://people.apache.org/builds/commons/nightly/commons-dbcp/

Jacopo

On Nov 13, 2009, at 11:29 AM, Jacques Le Roux wrote:


Hi Scott,

At which date was done this nightly build ? Where did you find it ?

BTW I have reverted both trunk and 9.04

Jacques

From: Scott Gray scott.g...@hotwaxmedia.com

BTW, the latest nightly build from dbcp works just fine on 1.5 for me,  why are 
you trying to compile dbcp?
Regards
Scott
On 13/11/2009, at 10:36 PM, Scott Gray wrote:

I'd suggest that you revert it for now.

Regards
Scott

HotWax Media
http://www.hotwaxmedia.com

On 13/11/2009, at 10:20 PM, Jacques Le Roux wrote:

I not totally sure but yet it seems that new versions of DBCP needs  the 1.6 jdk (or jdk 1.4) . Extract from README.TXT : 
This release  of JDBC compiles with and supports JDK 1.3 (JDBC 2.0), JDK 1.4-1.5  (JDBC 3.0) and JDK 1.6 (JDBC 4.0). 


I tried to build with 1.5 but it failed and I began to find a way  out, not 
obvious...

So the alternative is
1) revert DBCP upgrade (fix a bug)
2) Decide to use jdk 1.6 for OFBiz

I would not like to push now for the 2d solution but as this  upgrade was intended to fix a bug, I wonder if it's not the 
right  time


In the meantime (before a decision is taken), I will continue to  search a solution to compile with 1.5 but does not seem easy 
(conditional ANT compile deal with JDBC versions), and I'd not like  to rewrite DBCP, even a part, I've other fish to fry ;o)


Jacques

From: Jacques Le Roux jacques.le.r...@les7arts.com

Thanks Adrian,

Yes I did not care and build with ant from Eclipse where I use the  1.6 JDK. I'm on it, not as simple as I thought some 
problem

appeared...
In the meantime can you use 1.6 to build ?
BTW, could we not change from 1.5 to 1.6, is there any blocking  reasons I 
don't remember ?

Jacques

From: Adrian Crum adrian.c...@yahoo.com

Latest trunk:

Compiling 129 source files to C:\ofbiz\framework\entity\build \classes
[javac15] C:\ofbiz\framework\entity\src\org\ofbiz\entity 
\connection\DBCPConnectionFactory.java:21: cannot access
org.apache.commons.dbcp.ConnectionFactory
[javac15] bad class file:
C:\ofbiz\framework\entity\lib\commons-dbcp-1.3-2009- 
r834702.jar(org/apache/commons/dbcp/ConnectionFactory.class)
[javac15] class file has wrong version 50.0, should be 49.0
[javac15] Please remove or make sure it appears in the correct  subdirectory of 
the classpath.
[javac15] import org.apache.commons.dbcp.ConnectionFactory;
[javac15]^
[javac15] 1 error
























Re: Build Error

2009-11-13 Thread Scott Gray
Yep that's where I went and I now realize the latest nightly build was  
actually from 2007 :-/


Regards
Scott

On 13/11/2009, at 11:45 PM, Jacopo Cappellato wrote:


http://people.apache.org/builds/commons/nightly/commons-dbcp/

Jacopo

On Nov 13, 2009, at 11:29 AM, Jacques Le Roux wrote:


Hi Scott,

At which date was done this nightly build ? Where did you find it ?

BTW I have reverted both trunk and 9.04

Jacques

From: Scott Gray scott.g...@hotwaxmedia.com
BTW, the latest nightly build from dbcp works just fine on 1.5 for  
me,  why are you trying to compile dbcp?

Regards
Scott
On 13/11/2009, at 10:36 PM, Scott Gray wrote:

I'd suggest that you revert it for now.

Regards
Scott

HotWax Media
http://www.hotwaxmedia.com

On 13/11/2009, at 10:20 PM, Jacques Le Roux wrote:

I not totally sure but yet it seems that new versions of DBCP  
needs  the 1.6 jdk (or jdk 1.4) . Extract from README.TXT :  
This release  of JDBC compiles with and supports JDK 1.3 (JDBC  
2.0), JDK 1.4-1.5  (JDBC 3.0) and JDK 1.6 (JDBC 4.0). 


I tried to build with 1.5 but it failed and I began to find a  
way  out, not obvious...


So the alternative is
1) revert DBCP upgrade (fix a bug)
2) Decide to use jdk 1.6 for OFBiz

I would not like to push now for the 2d solution but as this   
upgrade was intended to fix a bug, I wonder if it's not the  
right  time


In the meantime (before a decision is taken), I will continue  
to  search a solution to compile with 1.5 but does not seem  
easy  (conditional ANT compile deal with JDBC versions), and I'd  
not like  to rewrite DBCP, even a part, I've other fish to fry ;o)


Jacques

From: Jacques Le Roux jacques.le.r...@les7arts.com

Thanks Adrian,

Yes I did not care and build with ant from Eclipse where I use  
the  1.6 JDK. I'm on it, not as simple as I thought some problem

appeared...
In the meantime can you use 1.6 to build ?
BTW, could we not change from 1.5 to 1.6, is there any  
blocking  reasons I don't remember ?


Jacques

From: Adrian Crum adrian.c...@yahoo.com

Latest trunk:

Compiling 129 source files to C:\ofbiz\framework\entity\build  
\classes
[javac15] C:\ofbiz\framework\entity\src\org\ofbiz\entity  
\connection\DBCPConnectionFactory.java:21: cannot access

org.apache.commons.dbcp.ConnectionFactory
[javac15] bad class file:
C:\ofbiz\framework\entity\lib\commons-dbcp-1.3-2009-  
r834702.jar(org/apache/commons/dbcp/ConnectionFactory.class)

[javac15] class file has wrong version 50.0, should be 49.0
[javac15] Please remove or make sure it appears in the  
correct  subdirectory of the classpath.

[javac15] import org.apache.commons.dbcp.ConnectionFactory;
[javac15]^
[javac15] 1 error






















smime.p7s
Description: S/MIME cryptographic signature


[jira] Commented: (OFBIZ-3071) assigning security group to a party without validations

2009-11-13 Thread Abdullah Shaikh (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-3071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12777446#action_12777446
 ] 

Abdullah Shaikh commented on OFBIZ-3071:


Good to hear that it makes sense ..

Even if we don't constrain that it should work just fine, we wont have any 
trouble.

But what I feel is if we have found the issue then lets just fix it, only 
because it wont cause any trouble or it's only redundant that will do, will 
accumulate more and more of this kind of issues and maybe later we will start 
finding this kind of issues and fixing it later.

As Ofbiz is an ERP it maybe grow more  more bigger, it's better if we fix the 
issues irrespective of how big or small the issue is.

I dont remember but I guess the patch was handling more than this ..

If you feel that we can commit the thruDate fix, then I can work on the patch 
to just fix this issue and remove the other stuff, let me know.


 assigning security group to a party without validations
 ---

 Key: OFBIZ-3071
 URL: https://issues.apache.org/jira/browse/OFBIZ-3071
 Project: OFBiz
  Issue Type: Improvement
Reporter: Abdullah Shaikh
Priority: Minor
 Attachments: OFBIZ-3071_assigning security group to a party without 
 validations.patch


 When adding user login to Security Group, the fromDate  thruDate input 
 fields are not mandatory, if not specified the fromDate is set to current 
 timestamop and thruDate is entered in database as null, which means the user 
 login is assigned that Security Group forever, but when if the same Security 
 Group is added, it again adds it, but instead it should check that if the 
 thruDate is null in the already entered record then shouldn't add new record.
 If incase the thruDate is specified during the creation of 1st record then 
 while adding the 2nd record for the same Security Group, it should check if 
 the thruDate of previous record is before the fromDate of the new record, 
 this check also doesn't happen.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (OFBIZ-2984) HTML cleanup for Product Detail page

2009-11-13 Thread Rohit Jain (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-2984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rohit Jain updated OFBIZ-2984:
--

Attachment: productDetailCodeCleanUp.patch

Here is slightly modified patch for latest ofbiz revision.
in this patch first pass of html code clean and css for generated layout issue. 

 HTML cleanup for Product Detail page
 

 Key: OFBIZ-2984
 URL: https://issues.apache.org/jira/browse/OFBIZ-2984
 Project: OFBiz
  Issue Type: Sub-task
  Components: specialpurpose/ecommerce
Affects Versions: SVN trunk
Reporter: Rohit Jain
Priority: Minor
 Fix For: SVN trunk

 Attachments: productDetailCodeCleanUp.patch, 
 productDetailCodeCleanUp.patch


 HTML code cleanup and related layout fixes for product detail page. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (OFBIZ-3190) Drag 'n' Drop for myPortal + update prototype and script.aculo.us

2009-11-13 Thread Sascha Rodekamp (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-3190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sascha Rodekamp updated OFBIZ-3190:
---

Attachment: script.aculo.us.patch
myPortalDragNDrop.patch

 Drag 'n' Drop for myPortal + update prototype and script.aculo.us
 -

 Key: OFBIZ-3190
 URL: https://issues.apache.org/jira/browse/OFBIZ-3190
 Project: OFBiz
  Issue Type: New Feature
  Components: framework
Affects Versions: SVN trunk
Reporter: Sascha Rodekamp
 Fix For: SVN trunk

 Attachments: Editing icon.jpg, myPortalDragNDrop.patch, 
 myPortalDragNDrop.patch, script.aculo.us.patch


 My first patch :-)
 Hi,
 I try to extend the myPortal component with a drag 'n' drop feature, using 
 the script.aculo.us libary.
 Therefor i updated prototype and script.aculo.us.
 What do you think of the implementation?
 Best regards
 Sascha

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-3190) Drag 'n' Drop for myPortal + update prototype and script.aculo.us

2009-11-13 Thread Sascha Rodekamp (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-3190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12777452#action_12777452
 ] 

Sascha Rodekamp commented on OFBIZ-3190:


Hi Bruno,
many thanks for reviewing. 
I split the Patch file and made a seperate one for the script.aculo.us upgrade. 
The Drag'n'Drop patch contains now a reverting to the original position when 
its not dropped over a droppable area. 







 Drag 'n' Drop for myPortal + update prototype and script.aculo.us
 -

 Key: OFBIZ-3190
 URL: https://issues.apache.org/jira/browse/OFBIZ-3190
 Project: OFBiz
  Issue Type: New Feature
  Components: framework
Affects Versions: SVN trunk
Reporter: Sascha Rodekamp
 Fix For: SVN trunk

 Attachments: Editing icon.jpg, myPortalDragNDrop.patch, 
 myPortalDragNDrop.patch, script.aculo.us.patch


 My first patch :-)
 Hi,
 I try to extend the myPortal component with a drag 'n' drop feature, using 
 the script.aculo.us libary.
 Therefor i updated prototype and script.aculo.us.
 What do you think of the implementation?
 Best regards
 Sascha

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



Re: Build Error

2009-11-13 Thread Scott Gray
I think Jacques is right about the current source code, there are a  
few minor issues that make it 1.6 only.  I made some changes and got  
it to compile, I'll give it a test run and see how it goes.


Regards
Scott

On 14/11/2009, at 12:00 AM, Jacopo Cappellato wrote:


Hmm... yes you are right, Jacques, sorry for that.
I will try to find out more information...

Jacopo

On Nov 13, 2009, at 11:49 AM, Jacques Le Roux wrote:


Thanks Jacopo,

These are really old ones or do I miss something ?

Jacques

From: Jacopo Cappellato jacopo.cappell...@hotwaxmedia.com

http://people.apache.org/builds/commons/nightly/commons-dbcp/

Jacopo

On Nov 13, 2009, at 11:29 AM, Jacques Le Roux wrote:


Hi Scott,

At which date was done this nightly build ? Where did you find it ?

BTW I have reverted both trunk and 9.04

Jacques

From: Scott Gray scott.g...@hotwaxmedia.com
BTW, the latest nightly build from dbcp works just fine on 1.5  
for me,  why are you trying to compile dbcp?

Regards
Scott
On 13/11/2009, at 10:36 PM, Scott Gray wrote:

I'd suggest that you revert it for now.

Regards
Scott

HotWax Media
http://www.hotwaxmedia.com

On 13/11/2009, at 10:20 PM, Jacques Le Roux wrote:

I not totally sure but yet it seems that new versions of DBCP  
needs  the 1.6 jdk (or jdk 1.4) . Extract from README.TXT :  
This release  of JDBC compiles with and supports JDK 1.3  
(JDBC 2.0), JDK 1.4-1.5  (JDBC 3.0) and JDK 1.6 (JDBC 4.0). 


I tried to build with 1.5 but it failed and I began to find a  
way  out, not obvious...


So the alternative is
1) revert DBCP upgrade (fix a bug)
2) Decide to use jdk 1.6 for OFBiz

I would not like to push now for the 2d solution but as this   
upgrade was intended to fix a bug, I wonder if it's not the  
right  time


In the meantime (before a decision is taken), I will continue  
to  search a solution to compile with 1.5 but does not seem  
easy (conditional ANT compile deal with JDBC versions), and  
I'd not like  to rewrite DBCP, even a part, I've other fish to  
fry ;o)


Jacques

From: Jacques Le Roux jacques.le.r...@les7arts.com

Thanks Adrian,

Yes I did not care and build with ant from Eclipse where I  
use the  1.6 JDK. I'm on it, not as simple as I thought some  
problem

appeared...
In the meantime can you use 1.6 to build ?
BTW, could we not change from 1.5 to 1.6, is there any  
blocking  reasons I don't remember ?


Jacques

From: Adrian Crum adrian.c...@yahoo.com

Latest trunk:

Compiling 129 source files to C:\ofbiz\framework\entity 
\build \classes
[javac15] C:\ofbiz\framework\entity\src\org\ofbiz\entity  
\connection\DBCPConnectionFactory.java:21: cannot access

org.apache.commons.dbcp.ConnectionFactory
[javac15] bad class file:
C:\ofbiz\framework\entity\lib\commons-dbcp-1.3-2009-  
r834702.jar(org/apache/commons/dbcp/ConnectionFactory.class)

[javac15] class file has wrong version 50.0, should be 49.0
[javac15] Please remove or make sure it appears in the  
correct  subdirectory of the classpath.

[javac15] import org.apache.commons.dbcp.ConnectionFactory;
[javac15]^
[javac15] 1 error



























smime.p7s
Description: S/MIME cryptographic signature


Re: svn commit: r831676 - in /ofbiz/trunk/framework: common/config/CommonUiLabels.xml widget/src/org/ofbiz/widget/form/MacroFormRenderer.java widget/src/org/ofbiz/widget/form/ModelForm.java widget/tem

2009-11-13 Thread Matthieu Bollot
Hi,
Could someone explain me the patch at the bottom ? more precisely the
#if listSize gt 20. It seems that with a view-size less than 20 (eg:
5), and only 19 results (ie between view-size and 20), there will be no
prev/next stuff.

So, should the condition in htmlFormMacroLibrary be deleted, set to
view-size, or should every view-size be set to something greater than
20, or did I miss something ?

Thanks,
Matthieu.

Le dimanche 01 novembre 2009 à 13:51 +, bibr...@apache.org a écrit :
 Modified:
 ofbiz/trunk/framework/widget/templates/htmlFormMacroLibrary.ftl
 URL: 
 http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/templates/htmlFormMacroLibrary.ftl?rev=831676r1=831675r2=831676view=diff
 ==
 --- ofbiz/trunk/framework/widget/templates/htmlFormMacroLibrary.ftl (original)
 +++ ofbiz/trunk/framework/widget/templates/htmlFormMacroLibrary.ftl Sun Nov  
 1 13:51:42 2009
 @@ -422,7 +422,8 @@
  );#rt
  img src=${imgSrc}width=15 height=14 border=0 alt=Lookup//a#rt
  /#macro
 -#macro renderNextPrev paginateStyle paginateFirstStyle viewIndex highIndex 
 listSize viewSize ajaxEnabled javaScriptEnabled ajaxFirstUrl firstUrl 
 paginateFirstLabel paginatePreviousStyle ajaxPreviousUrl previousUrl 
 paginatePreviousLabel pageLabel ajaxSelectUrl selectUrl commonDisplaying 
 paginateNextStyle ajaxNextUrl nextUrl paginateNextLabel paginateLastStyle 
 ajaxLastUrl lastUrl paginateLastLabel
 +#macro renderNextPrev paginateStyle paginateFirstStyle viewIndex highIndex 
 listSize viewSize ajaxEnabled javaScriptEnabled ajaxFirstUrl firstUrl 
 paginateFirstLabel paginatePreviousStyle ajaxPreviousUrl previousUrl 
 paginatePreviousLabel pageLabel ajaxSelectUrl selectUrl ajaxSelectSizeUrl 
 selectSizeUrl commonDisplaying paginateNextStyle ajaxNextUrl nextUrl 
 paginateNextLabel paginateLastStyle ajaxLastUrl lastUrl paginateLastLabel 
 paginateViewSizeLabel
 +#if listSize gt 20
  div class=${paginateStyle}nbsp; ul
  li class=${paginateFirstStyle}#if viewIndex gt 0a href=#if 
 ajaxEnabledjavascript:ajaxUpdateAreas('${ajaxFirstUrl}')#else${firstUrl}/#if${paginateFirstLabel}/a#else-disabled${paginateFirstLabel}/#if/li
  li class=${paginatePreviousStyle}#if viewIndex gt 0a href=#if 
 ajaxEnabledjavascript:ajaxUpdateAreas('${ajaxPreviousUrl}')#else${previousUrl}/#if${paginatePreviousLabel}/a#else-disabled${paginatePreviousLabel}/#if/li
 @@ -432,11 +433,18 @@
  #list 1..x as i
  #if i == (viewIndex+1)option selected=selected value=#elseoption 
 value=/#if${i-1}${i}/option
  /#list
 -/select/lili${commonDisplaying}/li
 -/#if
 +/select/li/#if
 +li${commonDisplaying}/li
  li class=${paginateNextStyle}#if highIndex lt listSizea href=#if 
 ajaxEnabledjavascript:ajaxUpdateAreas('${ajaxNextUrl}')#else${nextUrl}/#if${paginateNextLabel}/a#else-disabled${paginateNextLabel}/#if/li
  li class=${paginateLastStyle}#if highIndex lt listSizea href=#if 
 ajaxEnabledjavascript:ajaxUpdateAreas('${ajaxLastUrl}')#else${lastUrl}/#if${paginateLastLabel}/a#else-disabled${paginateLastLabel}/#if/li
 +#if javaScriptEnabledli class=nav-pagesizeselect name=pageSize 
 size=1 onchange=#if 
 ajaxEnabledjavascript:ajaxUpdateAreas('${ajaxSelectSizeUrl}')#elselocation.href='${selectSizeUrl}';/#if#rt/
 +#assign availPageSizes = [20, 30, 50, 100, 200]
 +#list availPageSizes as ps
 +  option #if viewSize == psselected=selected /#if 
 value=${ps}${ps}/option
 +/#list
 +/select ${paginateViewSizeLabel}/li/#if
  /ul/divbr/
 +/#if
  /#macro
  #macro renderFileField className alert name value size maxlength 
 autocompleteinput type=file @renderClass className alert /#if 
 name?has_content name=${name}/#if#if value?has_content 
 value=${value}/#if#if size?has_content size=${size}/#if#if 
 maxlength?has_content maxlength=${maxlength}/#if#if 
 autocomplete?has_content autocomplete=off/#if/#rt//#macro
  #macro renderPasswordField className alert name value size maxlength id 
 autocompleteinput type=password @renderClass className alert /#if 
 name?has_content name=${name}/#if#if value?has_content 
 value=${value}/#if#if size?has_content size=${size}/#if#if 
 maxlength?has_content maxlength=${maxlength}/#if#if id?has_content 
 id=${id}/#if#if autocomplete?has_content 
 autocomplete=off/#if//#macro
 
 




[jira] Reopened: (OFBIZ-2599) Memory leak due to transaction management

2009-11-13 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-2599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reopened OFBIZ-2599:



I had to revert at r835801 (trunk) and r835802 (R9.04) because we still use jdk 
1.5 in OFBiz and I was not able to build DBCP OOTB with it (was ok with 1.6)
I asked for on u...@commons.apache.org...

 Memory leak due to transaction management
 -

 Key: OFBIZ-2599
 URL: https://issues.apache.org/jira/browse/OFBIZ-2599
 Project: OFBiz
  Issue Type: Bug
  Components: framework
Affects Versions: Release Branch 9.04, SVN trunk
 Environment: jdk5, commons-dbcp-head
Reporter: Philippe Mouawad
Assignee: Jacques Le Roux
Priority: Critical
 Fix For: Release Branch 9.04, SVN trunk

 Attachments: commons-dbcp-1.3-r674758-patched.jar, memory.png, 
 patch-DBCPConneectionFactory.txt


 Hello,
 We are been using Ofbiz with DBCP based implementation.
 Ofbiz uses a Head revision of DBCP (package org.apache.commons.dbcp.managed 
 is the same as current TRUNK) and geronimo-transaction-1.0.
 We are having recurrent OutOfMemory which occur on a 2 days basis.
 See:
 https://issues.apache.org/jira/browse/DBCP-294
 Philippe Mouawad
 http://www.ubik-ingenierie.com

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



Re: Build Error

2009-11-13 Thread Jacques Le Roux

Hi Scott,

FYI, I have asked about it on  u...@commons.apache.org ...

BTW, I can't remember the reasons why we stay to 1.5, are they still valid ?

Jacques

From: Scott Gray scott.g...@hotwaxmedia.com
I think Jacques is right about the current source code, there are a  
few minor issues that make it 1.6 only.  I made some changes and got  
it to compile, I'll give it a test run and see how it goes.


Regards
Scott

On 14/11/2009, at 12:00 AM, Jacopo Cappellato wrote:


Hmm... yes you are right, Jacques, sorry for that.
I will try to find out more information...

Jacopo

On Nov 13, 2009, at 11:49 AM, Jacques Le Roux wrote:


Thanks Jacopo,

These are really old ones or do I miss something ?

Jacques

From: Jacopo Cappellato jacopo.cappell...@hotwaxmedia.com

http://people.apache.org/builds/commons/nightly/commons-dbcp/

Jacopo

On Nov 13, 2009, at 11:29 AM, Jacques Le Roux wrote:


Hi Scott,

At which date was done this nightly build ? Where did you find it ?

BTW I have reverted both trunk and 9.04

Jacques

From: Scott Gray scott.g...@hotwaxmedia.com
BTW, the latest nightly build from dbcp works just fine on 1.5  
for me,  why are you trying to compile dbcp?

Regards
Scott
On 13/11/2009, at 10:36 PM, Scott Gray wrote:

I'd suggest that you revert it for now.

Regards
Scott

HotWax Media
http://www.hotwaxmedia.com

On 13/11/2009, at 10:20 PM, Jacques Le Roux wrote:

I not totally sure but yet it seems that new versions of DBCP  
needs  the 1.6 jdk (or jdk 1.4) . Extract from README.TXT :  
This release  of JDBC compiles with and supports JDK 1.3  
(JDBC 2.0), JDK 1.4-1.5  (JDBC 3.0) and JDK 1.6 (JDBC 4.0). 


I tried to build with 1.5 but it failed and I began to find a  
way  out, not obvious...


So the alternative is
1) revert DBCP upgrade (fix a bug)
2) Decide to use jdk 1.6 for OFBiz

I would not like to push now for the 2d solution but as this   
upgrade was intended to fix a bug, I wonder if it's not the  
right  time


In the meantime (before a decision is taken), I will continue  
to  search a solution to compile with 1.5 but does not seem  
easy (conditional ANT compile deal with JDBC versions), and  
I'd not like  to rewrite DBCP, even a part, I've other fish to  
fry ;o)


Jacques

From: Jacques Le Roux jacques.le.r...@les7arts.com

Thanks Adrian,

Yes I did not care and build with ant from Eclipse where I  
use the  1.6 JDK. I'm on it, not as simple as I thought some  
problem

appeared...
In the meantime can you use 1.6 to build ?
BTW, could we not change from 1.5 to 1.6, is there any  
blocking  reasons I don't remember ?


Jacques

From: Adrian Crum adrian.c...@yahoo.com

Latest trunk:

Compiling 129 source files to C:\ofbiz\framework\entity 
\build \classes
[javac15] C:\ofbiz\framework\entity\src\org\ofbiz\entity  
\connection\DBCPConnectionFactory.java:21: cannot access

org.apache.commons.dbcp.ConnectionFactory
[javac15] bad class file:
C:\ofbiz\framework\entity\lib\commons-dbcp-1.3-2009-  
r834702.jar(org/apache/commons/dbcp/ConnectionFactory.class)

[javac15] class file has wrong version 50.0, should be 49.0
[javac15] Please remove or make sure it appears in the  
correct  subdirectory of the classpath.

[javac15] import org.apache.commons.dbcp.ConnectionFactory;
[javac15]^
[javac15] 1 error






























[jira] Updated: (OFBIZ-3190) Drag 'n' Drop for myPortal + update prototype and script.aculo.us

2009-11-13 Thread Sascha Rodekamp (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-3190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sascha Rodekamp updated OFBIZ-3190:
---

Attachment: myportal_load_bg.png
loader.gif

Images for Loading Screen

loader.gif Location
framework/images/webapp/images/loader.gif

myportal_load_bg.png location:
framework/images/webapp/images/myportal_load_bg.png

 Drag 'n' Drop for myPortal + update prototype and script.aculo.us
 -

 Key: OFBIZ-3190
 URL: https://issues.apache.org/jira/browse/OFBIZ-3190
 Project: OFBiz
  Issue Type: New Feature
  Components: framework
Affects Versions: SVN trunk
Reporter: Sascha Rodekamp
 Fix For: SVN trunk

 Attachments: Editing icon.jpg, loader.gif, myportal_load_bg.png, 
 myPortalDragNDrop.patch, myPortalDragNDrop.patch, script.aculo.us.patch


 My first patch :-)
 Hi,
 I try to extend the myPortal component with a drag 'n' drop feature, using 
 the script.aculo.us libary.
 Therefor i updated prototype and script.aculo.us.
 What do you think of the implementation?
 Best regards
 Sascha

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (OFBIZ-3087) Error with accents and special characters rendering at large in PDF

2009-11-13 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-3087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-3087:
---

Attachment: 9.04.jpg

 Error with accents and special characters rendering at large in PDF
 ---

 Key: OFBIZ-3087
 URL: https://issues.apache.org/jira/browse/OFBIZ-3087
 Project: OFBiz
  Issue Type: Bug
  Components: ALL COMPONENTS
Reporter: Jacques Le Roux
 Fix For: Release Branch 9.04, SVN trunk

 Attachments: 9.04.jpg


 this thread speak about that 
 http://www.mail-archive.com/dev@ofbiz.apache.org/msg29471.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (OFBIZ-2984) HTML cleanup for Product Detail page

2009-11-13 Thread Rohit Jain (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-2984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rohit Jain updated OFBIZ-2984:
--

Attachment: productDetailCodeCleanUp.patch

 HTML cleanup for Product Detail page
 

 Key: OFBIZ-2984
 URL: https://issues.apache.org/jira/browse/OFBIZ-2984
 Project: OFBiz
  Issue Type: Sub-task
  Components: specialpurpose/ecommerce
Affects Versions: SVN trunk
Reporter: Rohit Jain
Priority: Minor
 Fix For: SVN trunk

 Attachments: productDetailCodeCleanUp.patch, 
 productDetailCodeCleanUp.patch, productDetailCodeCleanUp.patch


 HTML code cleanup and related layout fixes for product detail page. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-3087) Error with accents and special characters rendering at large in PDF

2009-11-13 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-3087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12777490#action_12777490
 ] 

Jacques Le Roux commented on OFBIZ-3087:


Hi Scott,

1) Use French (for instance : there are accents)
2) In example component create an example with default values. Hopefully they 
will be in the same order than on a French OS, i tested with is Windows XP 
French, else look for values with accents in description.
3) use the PDF button you should get something like in the screen copies

Mmm, I was to create also a screen copy for trunk, but, not sure why, it does 
not render the type and status descriptions in French :(

 Error with accents and special characters rendering at large in PDF
 ---

 Key: OFBIZ-3087
 URL: https://issues.apache.org/jira/browse/OFBIZ-3087
 Project: OFBiz
  Issue Type: Bug
  Components: ALL COMPONENTS
Reporter: Jacques Le Roux
 Fix For: Release Branch 9.04, SVN trunk

 Attachments: 9.04.jpg


 this thread speak about that 
 http://www.mail-archive.com/dev@ofbiz.apache.org/msg29471.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-3087) Error with accents and special characters rendering at large in PDF

2009-11-13 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-3087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12777491#action_12777491
 ] 

Jacques Le Roux commented on OFBIZ-3087:


And you know what : I'm able to edit using Ajax, weird :(

 Error with accents and special characters rendering at large in PDF
 ---

 Key: OFBIZ-3087
 URL: https://issues.apache.org/jira/browse/OFBIZ-3087
 Project: OFBiz
  Issue Type: Bug
  Components: ALL COMPONENTS
Reporter: Jacques Le Roux
 Fix For: Release Branch 9.04, SVN trunk

 Attachments: 9.04.jpg


 this thread speak about that 
 http://www.mail-archive.com/dev@ofbiz.apache.org/msg29471.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-3087) Error with accents and special characters rendering at large in PDF

2009-11-13 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-3087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12777499#action_12777499
 ] 

Jacques Le Roux commented on OFBIZ-3087:


Oops, I removed a comment and a screen copy : I used a wrong instance :D. All 
above is still true so (I checked with another trunk instance)

 Error with accents and special characters rendering at large in PDF
 ---

 Key: OFBIZ-3087
 URL: https://issues.apache.org/jira/browse/OFBIZ-3087
 Project: OFBiz
  Issue Type: Bug
  Components: ALL COMPONENTS
Reporter: Jacques Le Roux
 Fix For: Release Branch 9.04, SVN trunk

 Attachments: 9.04.jpg


 this thread speak about that 
 http://www.mail-archive.com/dev@ofbiz.apache.org/msg29471.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (OFBIZ-3087) Error with accents and special characters rendering at large in PDF

2009-11-13 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-3087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-3087:
---

Comment: was deleted

(was: I finally reproduced with anther instance. But there I can't edit with 
Ajax. These instances have only config files adapted (differents ports). I 
begin to wonder if having them running simultaneously could not be a problem, 
but I really can't see why as it works well (but whne you swith from one to the 
other sometimes you get (browser?) cache effets but tha't all as far as I can 
tell)

 Error with accents and special characters rendering at large in PDF
 ---

 Key: OFBIZ-3087
 URL: https://issues.apache.org/jira/browse/OFBIZ-3087
 Project: OFBiz
  Issue Type: Bug
  Components: ALL COMPONENTS
Reporter: Jacques Le Roux
 Fix For: Release Branch 9.04, SVN trunk

 Attachments: 9.04.jpg


 this thread speak about that 
 http://www.mail-archive.com/dev@ofbiz.apache.org/msg29471.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (OFBIZ-3087) Error with accents and special characters rendering at large in PDF

2009-11-13 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-3087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-3087:
---

Attachment: trunk.jpg

I finally reproduced with anther instance. But there I can't edit with Ajax. 
These instances have only config files adapted (differents ports). I begin to 
wonder if having them running simultaneously could not be a problem, but I 
really can't see why as it works well (but whne you swith from one to the other 
sometimes you get (browser?) cache effets but tha't all as far as I can tell

 Error with accents and special characters rendering at large in PDF
 ---

 Key: OFBIZ-3087
 URL: https://issues.apache.org/jira/browse/OFBIZ-3087
 Project: OFBiz
  Issue Type: Bug
  Components: ALL COMPONENTS
Reporter: Jacques Le Roux
 Fix For: Release Branch 9.04, SVN trunk

 Attachments: 9.04.jpg, trunk.jpg


 this thread speak about that 
 http://www.mail-archive.com/dev@ofbiz.apache.org/msg29471.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (OFBIZ-3191) Danish translations for ContentEntityLabels

2009-11-13 Thread JIRA

 [ 
https://issues.apache.org/jira/browse/OFBIZ-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

André Herbst updated OFBIZ-3191:


Attachment: OFBIZ-3191_ContentEntityLabels.patch

 Danish translations for ContentEntityLabels
 ---

 Key: OFBIZ-3191
 URL: https://issues.apache.org/jira/browse/OFBIZ-3191
 Project: OFBiz
  Issue Type: Sub-task
  Components: content
Affects Versions: SVN trunk
Reporter: André Herbst
Priority: Trivial
 Fix For: SVN trunk

 Attachments: OFBIZ-3191_ContentEntityLabels.patch




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (OFBIZ-2494) On Windows with FF3 you can't edit a textfield using the inplace ajax editor

2009-11-13 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-2494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-2494.
--

Resolution: Fixed

It works well both in trunk and r9.04.  It needed an ant clean-all to work 
(Itought It could be a browser cache issue but clearing it did not fix the 
issue)

 On Windows with FF3 you can't edit a textfield using the inplace ajax editor
 

 Key: OFBIZ-2494
 URL: https://issues.apache.org/jira/browse/OFBIZ-2494
 Project: OFBiz
  Issue Type: Bug
  Components: ALL COMPONENTS
Affects Versions: Release Branch 9.04, SVN trunk
 Environment: FF3 on Windows.
Reporter: Jacques Le Roux
Assignee: Scott Gray
Priority: Trivial
 Fix For: Release Branch 9.04, SVN trunk


 It works with Opera, Chrome, Safari and even IE8. I did not test on Linux. 
 Not to be confused with the other related issue OFBIZ-2491

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-3087) Error with accents and special characters rendering at large in PDF

2009-11-13 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-3087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12777509#action_12777509
 ] 

Jacques Le Roux commented on OFBIZ-3087:


At least I have closed OFBIZ-2494, tt needed an ant clean-all to work 

 Error with accents and special characters rendering at large in PDF
 ---

 Key: OFBIZ-3087
 URL: https://issues.apache.org/jira/browse/OFBIZ-3087
 Project: OFBiz
  Issue Type: Bug
  Components: ALL COMPONENTS
Reporter: Jacques Le Roux
 Fix For: Release Branch 9.04, SVN trunk

 Attachments: 9.04.jpg


 this thread speak about that 
 http://www.mail-archive.com/dev@ofbiz.apache.org/msg29471.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (OFBIZ-3191) Danish translations for ContentEntityLabels

2009-11-13 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-3191.
--

Resolution: Fixed
  Assignee: Jacques Le Roux

Thanks André,

Your patch is in trunk at r835850  

And congratulations for the good work. I know from experience that it's not 
easy to not duplicate a key here or there ;)
By chance we have now the labels manager to check

 Danish translations for ContentEntityLabels
 ---

 Key: OFBIZ-3191
 URL: https://issues.apache.org/jira/browse/OFBIZ-3191
 Project: OFBiz
  Issue Type: Sub-task
  Components: content
Affects Versions: SVN trunk
Reporter: André Herbst
Assignee: Jacques Le Roux
Priority: Trivial
 Fix For: SVN trunk

 Attachments: OFBIZ-3191_ContentEntityLabels.patch




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



jdk 1.5 or 1.6

2009-11-13 Thread Jacques Le Roux

Hi devs,

I don't remember why we still use 1.5. Here is a thread from 2006 
http://markmail.org/message/5j5es63hpsh543ct.
Maybe it's time to think anew about it, don't you think so ?

Jacques



[jira] Assigned: (OFBIZ-2984) HTML cleanup for Product Detail page

2009-11-13 Thread Ashish Vijaywargiya (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-2984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashish Vijaywargiya reassigned OFBIZ-2984:
--

Assignee: Ashish Vijaywargiya

 HTML cleanup for Product Detail page
 

 Key: OFBIZ-2984
 URL: https://issues.apache.org/jira/browse/OFBIZ-2984
 Project: OFBiz
  Issue Type: Sub-task
  Components: specialpurpose/ecommerce
Affects Versions: SVN trunk
Reporter: Rohit Jain
Assignee: Ashish Vijaywargiya
Priority: Minor
 Fix For: SVN trunk

 Attachments: productDetailCodeCleanUp.patch, 
 productDetailCodeCleanUp.patch, productDetailCodeCleanUp.patch


 HTML code cleanup and related layout fixes for product detail page. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (OFBIZ-2984) HTML cleanup for Product Detail page

2009-11-13 Thread Ashish Vijaywargiya (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-2984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashish Vijaywargiya closed OFBIZ-2984.
--

Resolution: Fixed

Thanks Rohit - Done at r835861.

--
Ashish Vijaywargiya

 HTML cleanup for Product Detail page
 

 Key: OFBIZ-2984
 URL: https://issues.apache.org/jira/browse/OFBIZ-2984
 Project: OFBiz
  Issue Type: Sub-task
  Components: specialpurpose/ecommerce
Affects Versions: SVN trunk
Reporter: Rohit Jain
Assignee: Ashish Vijaywargiya
Priority: Minor
 Fix For: SVN trunk

 Attachments: productDetailCodeCleanUp.patch, 
 productDetailCodeCleanUp.patch, productDetailCodeCleanUp.patch


 HTML code cleanup and related layout fixes for product detail page. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



Re: jdk 1.5 or 1.6

2009-11-13 Thread Adrian Crum
Running OFBiz on 1.6 is a good idea, because (Sun claims) 1.6 performs 
better than 1.5.


The downside is, there might be servers out there that don't have a 1.6 
JRE available. I would like to see us move on to 1.6 (especially now 
that 1.7 is near), but I'm concerned for existing installations.


-Adrian

Jacques Le Roux wrote:

Hi devs,

I don't remember why we still use 1.5. Here is a thread from 2006 
http://markmail.org/message/5j5es63hpsh543ct.

Maybe it's time to think anew about it, don't you think so ?

Jacques




Re: jdk 1.5 or 1.6

2009-11-13 Thread Jacques Le Roux

Thanks Adrian,

So it's the same concern than 3 years ago, I will check...

Jacques

From: Adrian Crum adri...@hlmksw.com
Running OFBiz on 1.6 is a good idea, because (Sun claims) 1.6 performs 
better than 1.5.


The downside is, there might be servers out there that don't have a 1.6 
JRE available. I would like to see us move on to 1.6 (especially now 
that 1.7 is near), but I'm concerned for existing installations.


-Adrian

Jacques Le Roux wrote:

Hi devs,

I don't remember why we still use 1.5. Here is a thread from 2006 
http://markmail.org/message/5j5es63hpsh543ct.

Maybe it's time to think anew about it, don't you think so ?

Jacques








[jira] Created: (OFBIZ-3193) Séparation bet ween products extent into right and left bar

2009-11-13 Thread Jacques Le Roux (JIRA)
Séparation between products extent into right and left bar
--

 Key: OFBIZ-3193
 URL: https://issues.apache.org/jira/browse/OFBIZ-3193
 Project: OFBiz
  Issue Type: Sub-task
Affects Versions: SVN trunk
Reporter: Jacques Le Roux
 Attachments: screenshot-1.jpg

Also I got stuck on this page with only the Pay on one page  (it was in 
French not sure of the label) and Google Checkout buttons working. I then 
switched to English then only the Google Checkout button was working. 

How I got there :
# I  bought the service product, 
# got to quick checkout
# tried to use quick add (I was not able to use somehow :( )
# then I bought a Tiny Gizmo

I did not test with R9.04

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-3193) Séparation be tween products extent into right and left bar

2009-11-13 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-3193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12777545#action_12777545
 ] 

Jacques Le Roux commented on OFBIZ-3193:


I tried to go to main : then any buttons is working anymore  (the ones between 
cart and google checkout)

 Séparation between products extent into right and left bar
 --

 Key: OFBIZ-3193
 URL: https://issues.apache.org/jira/browse/OFBIZ-3193
 Project: OFBiz
  Issue Type: Sub-task
Affects Versions: SVN trunk
Reporter: Jacques Le Roux
 Attachments: screenshot-1.jpg


 Also I got stuck on this page with only the Pay on one page  (it was in 
 French not sure of the label) and Google Checkout buttons working. I then 
 switched to English then only the Google Checkout button was working. 
 How I got there :
 # I  bought the service product, 
 # got to quick checkout
 # tried to use quick add (I was not able to use somehow :( )
 # then I bought a Tiny Gizmo
 I did not test with R9.04

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (OFBIZ-3193) Séparation bet ween products extent into right and left bar

2009-11-13 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-3193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-3193:
---

Attachment: screenshot-2.jpg

If I continue (logout, login, after a try with google checkout) it's even worse 
: no butttons at al. OK I restart the instance...

 Séparation between products extent into right and left bar
 --

 Key: OFBIZ-3193
 URL: https://issues.apache.org/jira/browse/OFBIZ-3193
 Project: OFBiz
  Issue Type: Sub-task
Affects Versions: SVN trunk
Reporter: Jacques Le Roux
 Attachments: screenshot-1.jpg, screenshot-2.jpg


 Also I got stuck on this page with only the Pay on one page  (it was in 
 French not sure of the label) and Google Checkout buttons working. I then 
 switched to English then only the Google Checkout button was working. 
 How I got there :
 # I  bought the service product, 
 # got to quick checkout
 # tried to use quick add (I was not able to use somehow :( )
 # then I bought a Tiny Gizmo
 I did not test with R9.04

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-3193) Séparation be tween products extent into right and left bar

2009-11-13 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-3193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12777550#action_12777550
 ] 

Jacques Le Roux commented on OFBIZ-3193:


This works well on the demo server today. So I suspect it's a change in the 
code since (I tried on 2 local instances). We will see tomorrow...

 Séparation between products extent into right and left bar
 --

 Key: OFBIZ-3193
 URL: https://issues.apache.org/jira/browse/OFBIZ-3193
 Project: OFBiz
  Issue Type: Sub-task
Affects Versions: SVN trunk
Reporter: Jacques Le Roux
 Attachments: screenshot-1.jpg, screenshot-2.jpg


 Also I got stuck on this page with only the Pay on one page  (it was in 
 French not sure of the label) and Google Checkout buttons working. I then 
 switched to English then only the Google Checkout button was working. 
 How I got there :
 # I  bought the service product, 
 # got to quick checkout
 # tried to use quick add (I was not able to use somehow :( )
 # then I bought a Tiny Gizmo
 I did not test with R9.04

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (OFBIZ-3193) Dividing lines between products extent into right and left bar

2009-11-13 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-3193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-3193:
---

Summary: Dividing lines between products extent into right and left bar  
(was: Séparation between products extent into right and left bar)

 Dividing lines between products extent into right and left bar
 --

 Key: OFBIZ-3193
 URL: https://issues.apache.org/jira/browse/OFBIZ-3193
 Project: OFBiz
  Issue Type: Sub-task
Affects Versions: SVN trunk
Reporter: Jacques Le Roux
 Attachments: screenshot-1.jpg, screenshot-2.jpg


 Also I got stuck on this page with only the Pay on one page  (it was in 
 French not sure of the label) and Google Checkout buttons working. I then 
 switched to English then only the Google Checkout button was working. 
 How I got there :
 # I  bought the service product, 
 # got to quick checkout
 # tried to use quick add (I was not able to use somehow :( )
 # then I bought a Tiny Gizmo
 I did not test with R9.04

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (OFBIZ-3194) Quick look are showing pagination renderNextPrev pagination style when list size is greater than 20

2009-11-13 Thread Divesh Dutta (JIRA)
Quick look are showing pagination renderNextPrev pagination style when list 
size is greater than 20
---

 Key: OFBIZ-3194
 URL: https://issues.apache.org/jira/browse/OFBIZ-3194
 Project: OFBiz
  Issue Type: Bug
  Components: order
Affects Versions: SVN trunk
Reporter: Divesh Dutta
 Fix For: SVN trunk


Quick look are showing pagination renderNextPrev pagination style when list 
size is greater than 20.

In htmlFormMacroLibrary.ftl below given code snippet is hard-coded. :

 {#if listSize gt 20}

This can be changed to

 {#if listSize gt viewSize}

as viewSize is passed as parameter in macro renderNextPrev. This is also 
reported by Matthieu Bollot in developer mailing list.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (OFBIZ-3194) Quick look are showing pagination renderNextPrev pagination style when list size is greater than 20

2009-11-13 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-3194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta updated OFBIZ-3194:


Attachment: OFBiz-3194.patch

Here is the path for the same.

Avoiding hard-code value and using viewSize instead. This was blocking to show 
all the products in Quick look up while placing purchase order

 Quick look are showing pagination renderNextPrev pagination style when list 
 size is greater than 20
 ---

 Key: OFBIZ-3194
 URL: https://issues.apache.org/jira/browse/OFBIZ-3194
 Project: OFBiz
  Issue Type: Bug
  Components: order
Affects Versions: SVN trunk
Reporter: Divesh Dutta
 Fix For: SVN trunk

 Attachments: OFBiz-3194.patch


 Quick look are showing pagination renderNextPrev pagination style when list 
 size is greater than 20.
 In htmlFormMacroLibrary.ftl below given code snippet is hard-coded. :
  {#if listSize gt 20}
 This can be changed to
  {#if listSize gt viewSize}
 as viewSize is passed as parameter in macro renderNextPrev. This is also 
 reported by Matthieu Bollot in developer mailing list.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (OFBIZ-3194) Quick look are showing pagination renderNextPrev pagination style when list size is greater than 20

2009-11-13 Thread Divesh Dutta (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-3194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divesh Dutta updated OFBIZ-3194:


Component/s: (was: order)
 framework

 Quick look are showing pagination renderNextPrev pagination style when list 
 size is greater than 20
 ---

 Key: OFBIZ-3194
 URL: https://issues.apache.org/jira/browse/OFBIZ-3194
 Project: OFBiz
  Issue Type: Bug
  Components: framework
Affects Versions: SVN trunk
Reporter: Divesh Dutta
 Fix For: SVN trunk

 Attachments: OFBiz-3194.patch


 Quick look are showing pagination renderNextPrev pagination style when list 
 size is greater than 20.
 In htmlFormMacroLibrary.ftl below given code snippet is hard-coded. :
  {#if listSize gt 20}
 This can be changed to
  {#if listSize gt viewSize}
 as viewSize is passed as parameter in macro renderNextPrev. This is also 
 reported by Matthieu Bollot in developer mailing list.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



Re: svn commit: r831676 - in /ofbiz/trunk/framework: common/config/CommonUiLabels.xml widget/src/org/ofbiz/widget/form/MacroFormRenderer.java widget/src/org/ofbiz/widget/form/ModelForm.java widget/tem

2009-11-13 Thread Divesh Dutta

Hello Matthieu/ Bilgin ,

I think we should not delete the condition. But we can omit hard-coded 
check here and use viewSize instead. I have created jira issue for 
this and also updated the patch for the same. Here is the link:


https://issues.apache.org/jira/browse/OFBIZ-3194

PS: Please commit this patch or give alternate solution for this as soon 
as you get time.


Thanks
--
Divesh Dutta.




Matthieu Bollot wrote:

Hi,
Could someone explain me the patch at the bottom ? more precisely the
#if listSize gt 20. It seems that with a view-size less than 20 (eg:
5), and only 19 results (ie between view-size and 20), there will be no
prev/next stuff.

So, should the condition in htmlFormMacroLibrary be deleted, set to
view-size, or should every view-size be set to something greater than
20, or did I miss something ?

Thanks,
Matthieu.

Le dimanche 01 novembre 2009 à 13:51 +, bibr...@apache.org a écrit :
  

Modified:
ofbiz/trunk/framework/widget/templates/htmlFormMacroLibrary.ftl
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/templates/htmlFormMacroLibrary.ftl?rev=831676r1=831675r2=831676view=diff
==
--- ofbiz/trunk/framework/widget/templates/htmlFormMacroLibrary.ftl (original)
+++ ofbiz/trunk/framework/widget/templates/htmlFormMacroLibrary.ftl Sun Nov  1 
13:51:42 2009
@@ -422,7 +422,8 @@
 );#rt
 img src=${imgSrc}width=15 height=14 border=0 alt=Lookup//a#rt
 /#macro
-#macro renderNextPrev paginateStyle paginateFirstStyle viewIndex highIndex 
listSize viewSize ajaxEnabled javaScriptEnabled ajaxFirstUrl firstUrl 
paginateFirstLabel paginatePreviousStyle ajaxPreviousUrl previousUrl 
paginatePreviousLabel pageLabel ajaxSelectUrl selectUrl commonDisplaying 
paginateNextStyle ajaxNextUrl nextUrl paginateNextLabel paginateLastStyle ajaxLastUrl 
lastUrl paginateLastLabel
+#macro renderNextPrev paginateStyle paginateFirstStyle viewIndex highIndex 
listSize viewSize ajaxEnabled javaScriptEnabled ajaxFirstUrl firstUrl 
paginateFirstLabel paginatePreviousStyle ajaxPreviousUrl previousUrl 
paginatePreviousLabel pageLabel ajaxSelectUrl selectUrl ajaxSelectSizeUrl 
selectSizeUrl commonDisplaying paginateNextStyle ajaxNextUrl nextUrl 
paginateNextLabel paginateLastStyle ajaxLastUrl lastUrl paginateLastLabel 
paginateViewSizeLabel
+#if listSize gt 20
 div class=${paginateStyle}nbsp; ul
 li class=${paginateFirstStyle}#if viewIndex gt 0a href=#if 
ajaxEnabledjavascript:ajaxUpdateAreas('${ajaxFirstUrl}')#else${firstUrl}/#if${paginateFirstLabel}/a#else-disabled${paginateFirstLabel}/#if/li
 li class=${paginatePreviousStyle}#if viewIndex gt 0a href=#if 
ajaxEnabledjavascript:ajaxUpdateAreas('${ajaxPreviousUrl}')#else${previousUrl}/#if${paginatePreviousLabel}/a#else-disabled${paginatePreviousLabel}/#if/li
@@ -432,11 +433,18 @@
 #list 1..x as i
 #if i == (viewIndex+1)option selected=selected value=#elseoption 
value=/#if${i-1}${i}/option
 /#list
-/select/lili${commonDisplaying}/li
-/#if
+/select/li/#if
+li${commonDisplaying}/li
 li class=${paginateNextStyle}#if highIndex lt listSizea href=#if 
ajaxEnabledjavascript:ajaxUpdateAreas('${ajaxNextUrl}')#else${nextUrl}/#if${paginateNextLabel}/a#else-disabled${paginateNextLabel}/#if/li
 li class=${paginateLastStyle}#if highIndex lt listSizea href=#if 
ajaxEnabledjavascript:ajaxUpdateAreas('${ajaxLastUrl}')#else${lastUrl}/#if${paginateLastLabel}/a#else-disabled${paginateLastLabel}/#if/li
+#if javaScriptEnabledli class=nav-pagesizeselect name=pageSize size=1 onchange=#if 
ajaxEnabledjavascript:ajaxUpdateAreas('${ajaxSelectSizeUrl}')#elselocation.href='${selectSizeUrl}';/#if#rt/
+#assign availPageSizes = [20, 30, 50, 100, 200]
+#list availPageSizes as ps
+  option #if viewSize == psselected=selected /#if 
value=${ps}${ps}/option
+/#list
+/select ${paginateViewSizeLabel}/li/#if
 /ul/divbr/
+/#if
 /#macro
 #macro renderFileField className alert name value size maxlength autocompleteinput type=file @renderClass className alert /#if name?has_content name=${name}/#if#if 
value?has_content value=${value}/#if#if size?has_content size=${size}/#if#if maxlength?has_content maxlength=${maxlength}/#if#if 
autocomplete?has_content autocomplete=off/#if/#rt//#macro
 #macro renderPasswordField className alert name value size maxlength id autocompleteinput type=password @renderClass className alert /#if name?has_content name=${name}/#if#if 
value?has_content value=${value}/#if#if size?has_content size=${size}/#if#if maxlength?has_content maxlength=${maxlength}/#if#if id?has_content 
id=${id}/#if#if autocomplete?has_content autocomplete=off/#if//#macro






  




[jira] Created: (OFBIZ-3195) next/prev missing

2009-11-13 Thread matthieu bollot (JIRA)
next/prev missing
-

 Key: OFBIZ-3195
 URL: https://issues.apache.org/jira/browse/OFBIZ-3195
 Project: OFBiz
  Issue Type: Bug
  Components: order
Affects Versions: SVN trunk
Reporter: matthieu bollot


by default, with view-size set to 5, and with less than 20 results, there is no 
prev/next navig bar in a lookup

two screenshots to be understood and a quick patch follow

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Assigned: (OFBIZ-3194) Quick look are showing pagination renderNextPrev pagination style when list size is greater than 20

2009-11-13 Thread Jacopo Cappellato (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-3194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato reassigned OFBIZ-3194:


Assignee: Jacopo Cappellato

 Quick look are showing pagination renderNextPrev pagination style when list 
 size is greater than 20
 ---

 Key: OFBIZ-3194
 URL: https://issues.apache.org/jira/browse/OFBIZ-3194
 Project: OFBiz
  Issue Type: Bug
  Components: framework
Affects Versions: SVN trunk
Reporter: Divesh Dutta
Assignee: Jacopo Cappellato
 Fix For: SVN trunk

 Attachments: OFBiz-3194.patch


 Quick look are showing pagination renderNextPrev pagination style when list 
 size is greater than 20.
 In htmlFormMacroLibrary.ftl below given code snippet is hard-coded. :
  {#if listSize gt 20}
 This can be changed to
  {#if listSize gt viewSize}
 as viewSize is passed as parameter in macro renderNextPrev. This is also 
 reported by Matthieu Bollot in developer mailing list.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



Re: svn commit: r831676 - in /ofbiz/trunk/framework: common/config/CommonUiLabels.xml widget/src/org/ofbiz/widget/form/MacroFormRenderer.java widget/src/org/ofbiz/widget/form/ModelForm.java widget/tem

2009-11-13 Thread Jacopo Cappellato
Thank you Divesh,

your code is in rev. 835925

Jacopo

On Nov 13, 2009, at 5:58 PM, Divesh Dutta wrote:

 Hello Matthieu/ Bilgin ,
 
 I think we should not delete the condition. But we can omit hard-coded check 
 here and use viewSize instead. I have created jira issue for this and also 
 updated the patch for the same. Here is the link:
 
 https://issues.apache.org/jira/browse/OFBIZ-3194
 
 PS: Please commit this patch or give alternate solution for this as soon as 
 you get time.
 
 Thanks
 --
 Divesh Dutta.
 
 
 
 
 Matthieu Bollot wrote:
 Hi,
 Could someone explain me the patch at the bottom ? more precisely the
 #if listSize gt 20. It seems that with a view-size less than 20 (eg:
 5), and only 19 results (ie between view-size and 20), there will be no
 prev/next stuff.
 
 So, should the condition in htmlFormMacroLibrary be deleted, set to
 view-size, or should every view-size be set to something greater than
 20, or did I miss something ?
 
 Thanks,
 Matthieu.
 
 Le dimanche 01 novembre 2009 à 13:51 +, bibr...@apache.org a écrit :
  
 Modified:
 ofbiz/trunk/framework/widget/templates/htmlFormMacroLibrary.ftl
 URL: 
 http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/templates/htmlFormMacroLibrary.ftl?rev=831676r1=831675r2=831676view=diff
 ==
 --- ofbiz/trunk/framework/widget/templates/htmlFormMacroLibrary.ftl 
 (original)
 +++ ofbiz/trunk/framework/widget/templates/htmlFormMacroLibrary.ftl Sun Nov 
  1 13:51:42 2009
 @@ -422,7 +422,8 @@
 );#rt
 img src=${imgSrc}width=15 height=14 border=0 
 alt=Lookup//a#rt
 /#macro
 -#macro renderNextPrev paginateStyle paginateFirstStyle viewIndex 
 highIndex listSize viewSize ajaxEnabled javaScriptEnabled ajaxFirstUrl 
 firstUrl paginateFirstLabel paginatePreviousStyle ajaxPreviousUrl 
 previousUrl paginatePreviousLabel pageLabel ajaxSelectUrl selectUrl 
 commonDisplaying paginateNextStyle ajaxNextUrl nextUrl paginateNextLabel 
 paginateLastStyle ajaxLastUrl lastUrl paginateLastLabel
 +#macro renderNextPrev paginateStyle paginateFirstStyle viewIndex 
 highIndex listSize viewSize ajaxEnabled javaScriptEnabled ajaxFirstUrl 
 firstUrl paginateFirstLabel paginatePreviousStyle ajaxPreviousUrl 
 previousUrl paginatePreviousLabel pageLabel ajaxSelectUrl selectUrl 
 ajaxSelectSizeUrl selectSizeUrl commonDisplaying paginateNextStyle 
 ajaxNextUrl nextUrl paginateNextLabel paginateLastStyle ajaxLastUrl lastUrl 
 paginateLastLabel paginateViewSizeLabel
 +#if listSize gt 20
 div class=${paginateStyle}nbsp; ul
 li class=${paginateFirstStyle}#if viewIndex gt 0a href=#if 
 ajaxEnabledjavascript:ajaxUpdateAreas('${ajaxFirstUrl}')#else${firstUrl}/#if${paginateFirstLabel}/a#else-disabled${paginateFirstLabel}/#if/li
 li class=${paginatePreviousStyle}#if viewIndex gt 0a href=#if 
 ajaxEnabledjavascript:ajaxUpdateAreas('${ajaxPreviousUrl}')#else${previousUrl}/#if${paginatePreviousLabel}/a#else-disabled${paginatePreviousLabel}/#if/li
 @@ -432,11 +433,18 @@
 #list 1..x as i
 #if i == (viewIndex+1)option selected=selected value=#elseoption 
 value=/#if${i-1}${i}/option
 /#list
 -/select/lili${commonDisplaying}/li
 -/#if
 +/select/li/#if
 +li${commonDisplaying}/li
 li class=${paginateNextStyle}#if highIndex lt listSizea href=#if 
 ajaxEnabledjavascript:ajaxUpdateAreas('${ajaxNextUrl}')#else${nextUrl}/#if${paginateNextLabel}/a#else-disabled${paginateNextLabel}/#if/li
 li class=${paginateLastStyle}#if highIndex lt listSizea href=#if 
 ajaxEnabledjavascript:ajaxUpdateAreas('${ajaxLastUrl}')#else${lastUrl}/#if${paginateLastLabel}/a#else-disabled${paginateLastLabel}/#if/li
 +#if javaScriptEnabledli class=nav-pagesizeselect name=pageSize 
 size=1 onchange=#if 
 ajaxEnabledjavascript:ajaxUpdateAreas('${ajaxSelectSizeUrl}')#elselocation.href='${selectSizeUrl}';/#if#rt/
 +#assign availPageSizes = [20, 30, 50, 100, 200]
 +#list availPageSizes as ps
 +  option #if viewSize == psselected=selected /#if 
 value=${ps}${ps}/option
 +/#list
 +/select ${paginateViewSizeLabel}/li/#if
 /ul/divbr/
 +/#if
 /#macro
 #macro renderFileField className alert name value size maxlength 
 autocompleteinput type=file @renderClass className alert /#if 
 name?has_content name=${name}/#if#if value?has_content 
 value=${value}/#if#if size?has_content size=${size}/#if#if 
 maxlength?has_content maxlength=${maxlength}/#if#if 
 autocomplete?has_content autocomplete=off/#if/#rt//#macro
 #macro renderPasswordField className alert name value size maxlength id 
 autocompleteinput type=password @renderClass className alert /#if 
 name?has_content name=${name}/#if#if value?has_content 
 value=${value}/#if#if size?has_content size=${size}/#if#if 
 maxlength?has_content maxlength=${maxlength}/#if#if id?has_content 
 id=${id}/#if#if autocomplete?has_content 
 autocomplete=off/#if//#macro
 
 

 
 
  
 



[jira] Closed: (OFBIZ-3194) Quick look are showing pagination renderNextPrev pagination style when list size is greater than 20

2009-11-13 Thread Jacopo Cappellato (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-3194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato closed OFBIZ-3194.



 Quick look are showing pagination renderNextPrev pagination style when list 
 size is greater than 20
 ---

 Key: OFBIZ-3194
 URL: https://issues.apache.org/jira/browse/OFBIZ-3194
 Project: OFBiz
  Issue Type: Bug
  Components: framework
Affects Versions: SVN trunk
Reporter: Divesh Dutta
Assignee: Jacopo Cappellato
 Fix For: SVN trunk

 Attachments: OFBiz-3194.patch


 Quick look are showing pagination renderNextPrev pagination style when list 
 size is greater than 20.
 In htmlFormMacroLibrary.ftl below given code snippet is hard-coded. :
  {#if listSize gt 20}
 This can be changed to
  {#if listSize gt viewSize}
 as viewSize is passed as parameter in macro renderNextPrev. This is also 
 reported by Matthieu Bollot in developer mailing list.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Resolved: (OFBIZ-3194) Quick look are showing pagination renderNextPrev pagination style when list size is greater than 20

2009-11-13 Thread Jacopo Cappellato (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-3194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato resolved OFBIZ-3194.
--

Resolution: Fixed

Thank you Divesh,

your code is in rev. 835925

Jacopo

 Quick look are showing pagination renderNextPrev pagination style when list 
 size is greater than 20
 ---

 Key: OFBIZ-3194
 URL: https://issues.apache.org/jira/browse/OFBIZ-3194
 Project: OFBiz
  Issue Type: Bug
  Components: framework
Affects Versions: SVN trunk
Reporter: Divesh Dutta
Assignee: Jacopo Cappellato
 Fix For: SVN trunk

 Attachments: OFBiz-3194.patch


 Quick look are showing pagination renderNextPrev pagination style when list 
 size is greater than 20.
 In htmlFormMacroLibrary.ftl below given code snippet is hard-coded. :
  {#if listSize gt 20}
 This can be changed to
  {#if listSize gt viewSize}
 as viewSize is passed as parameter in macro renderNextPrev. This is also 
 reported by Matthieu Bollot in developer mailing list.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (OFBIZ-3195) next/prev missing

2009-11-13 Thread matthieu bollot (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-3195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

matthieu bollot updated OFBIZ-3195:
---

Attachment: OFBIZ-3195

may be a reflexion will be needed about this stuff, as I'm sure this will 
happen in a lot of forms

 next/prev missing
 -

 Key: OFBIZ-3195
 URL: https://issues.apache.org/jira/browse/OFBIZ-3195
 Project: OFBiz
  Issue Type: Bug
  Components: order
Affects Versions: SVN trunk
Reporter: matthieu bollot
 Attachments: OFBIZ-3195


 by default, with view-size set to 5, and with less than 20 results, there is 
 no prev/next navig bar in a lookup
 two screenshots to be understood and a quick patch follow

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (OFBIZ-3195) next/prev missing

2009-11-13 Thread matthieu bollot (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-3195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

matthieu bollot updated OFBIZ-3195:
---

Attachment: Capture-OFBizOrderManagerBulkAddSupplierProductIceweaselwork.png

Capture-OFBizOrderManagerBulkAddSupplierProductIceweaseldontwork.png

 next/prev missing
 -

 Key: OFBIZ-3195
 URL: https://issues.apache.org/jira/browse/OFBIZ-3195
 Project: OFBiz
  Issue Type: Bug
  Components: order
Affects Versions: SVN trunk
Reporter: matthieu bollot
 Attachments: 
 Capture-OFBizOrderManagerBulkAddSupplierProductIceweaseldontwork.png, 
 Capture-OFBizOrderManagerBulkAddSupplierProductIceweaselwork.png, OFBIZ-3195


 by default, with view-size set to 5, and with less than 20 results, there is 
 no prev/next navig bar in a lookup
 two screenshots to be understood and a quick patch follow

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (OFBIZ-3196) Manual refund functionality is broken.

2009-11-13 Thread Divesh Dutta (JIRA)
Manual refund functionality is broken. 
---

 Key: OFBIZ-3196
 URL: https://issues.apache.org/jira/browse/OFBIZ-3196
 Project: OFBiz
  Issue Type: Bug
  Components: order
Affects Versions: SVN trunk
Reporter: Divesh Dutta
 Fix For: SVN trunk


Manual refund functionality is broken.  I have also reported this on developer 
mailing list. But creating issue so that this can be tracked well.

Steps to reproduce the bug:
1) Create a sales order from Order manager application with two or more items.

2) Then approve and Quick ship the entire Order which will complete the order.

3) Then click on Create Return button on Actions Block.

4) You will land on Create new Return Page: Also attaching the screen shot. 

Here is the link of image:  http://img156.yfrog.com/i/screenshot1jw.png/

5) Click on select all check box and then click on Return Selected items 
button.

6) You will find that page is broken. Also attaching the screen shot for the 
same.  

Here is the link of image:  http://img156.yfrog.com/i/screenshot2kn.png/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (OFBIZ-3195) next/prev missing

2009-11-13 Thread matthieu bollot (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-3195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

matthieu bollot closed OFBIZ-3195.
--

Resolution: Fixed

corrected by jacopo 20 minutes ago, sorry for the noise, and thanks to jacopo

 next/prev missing
 -

 Key: OFBIZ-3195
 URL: https://issues.apache.org/jira/browse/OFBIZ-3195
 Project: OFBiz
  Issue Type: Bug
  Components: order
Affects Versions: SVN trunk
Reporter: matthieu bollot
 Attachments: 
 Capture-OFBizOrderManagerBulkAddSupplierProductIceweaseldontwork.png, 
 Capture-OFBizOrderManagerBulkAddSupplierProductIceweaselwork.png, OFBIZ-3195


 by default, with view-size set to 5, and with less than 20 results, there is 
 no prev/next navig bar in a lookup
 two screenshots to be understood and a quick patch follow

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-3195) next/prev missing

2009-11-13 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-3195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12777575#action_12777575
 ] 

Divesh Dutta commented on OFBIZ-3195:
-

Hello Matthieu, 

I have already created jira issue for this with my fix. Here is the link

https://issues.apache.org/jira/browse/OFBIZ-3194

And this is committed by Jacopo in r: 835925. 

So you take update and try once more. Hope fully this issue will get resolved. 
Also you may close this issue if your purpose is solved. 

Thanks
--
Divesh Dutta.

 next/prev missing
 -

 Key: OFBIZ-3195
 URL: https://issues.apache.org/jira/browse/OFBIZ-3195
 Project: OFBiz
  Issue Type: Bug
  Components: order
Affects Versions: SVN trunk
Reporter: matthieu bollot
 Attachments: 
 Capture-OFBizOrderManagerBulkAddSupplierProductIceweaseldontwork.png, 
 Capture-OFBizOrderManagerBulkAddSupplierProductIceweaselwork.png, OFBIZ-3195


 by default, with view-size set to 5, and with less than 20 results, there is 
 no prev/next navig bar in a lookup
 two screenshots to be understood and a quick patch follow

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-3195) next/prev missing

2009-11-13 Thread Divesh Dutta (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-3195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12777576#action_12777576
 ] 

Divesh Dutta commented on OFBIZ-3195:
-

oops I am also bit late to see your comments. Sorry and discard my comments. 

 next/prev missing
 -

 Key: OFBIZ-3195
 URL: https://issues.apache.org/jira/browse/OFBIZ-3195
 Project: OFBiz
  Issue Type: Bug
  Components: order
Affects Versions: SVN trunk
Reporter: matthieu bollot
 Attachments: 
 Capture-OFBizOrderManagerBulkAddSupplierProductIceweaseldontwork.png, 
 Capture-OFBizOrderManagerBulkAddSupplierProductIceweaselwork.png, OFBIZ-3195


 by default, with view-size set to 5, and with less than 20 results, there is 
 no prev/next navig bar in a lookup
 two screenshots to be understood and a quick patch follow

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



Re: [jira] Closed: (OFBIZ-3195) next/prev missing

2009-11-13 Thread Matthieu Bollot
Le vendredi 13 novembre 2009 à 17:29 +, matthieu bollot (JIRA) a 
 corrected by jacopo 20 minutes ago, sorry for the noise, and thanks to jacopo

which was written by Divesh…
So thx to him too.

It's late here, but TGIF !



Re: jdk 1.5 or 1.6

2009-11-13 Thread Jacques Le Roux

Sun :
Java SE  Java SE for Business Support Road Map (JDKs End of Life)
http://java.sun.com/products/archive/eol.policy.html

1.6 supported systems
http://java.sun.com/javase/6/webnotes/install/system-configurations.html

15 supported systems
http://java.sun.com/j2se/1.5.0/system-configurations.html

Conclusion (I don't list what is better, only what miss from 1.5 to 1.6)
Better for Solaris (no surprises)

Windows x86
no longer : Windows 98 (2nd Edition) and  Windows ME (who cares ?)
no longer : Windows Server 2003, Web Edition (R2, SP1, SP2)   and Windows 
Server 2003, Standard Edition (R2, SP1, SP2) ( a bit more
annoying maybe)
but still : Windows Server 2003, Enterprise Edition (R2, SP1, SP2) and Windows 
Server 2003, DataCenter Edition (R2, SP1, SP2)

Windows x64 32-bit mode
no longer : Windows Server 2008 Datacenter (SP1, SP2)  and Windows Web Server 
2008 (SP1, SP2)
but still : Windows Server 2008 Standard (SP1, SP2) and Windows Server 2008 
Enterprise (SP1, SP2)

Linux x86
no longer : TurboLinux 8.0
but : Turbo Linux 10 (ONLY Chinese and Japanese Locales. No English.)

Linux x64 32-bit mode
new : Turbo Linux 10 (ONLY Chinese and Japanese Locales. No English.)


From this I can see only problems with

Windows Server 2003, Web Edition and Standard Edition
Windows Server 2008 Datacenter and Web Server
TurboLinux 8.0

Should this only stop us to migrate to jdk 1.6? Personnaly I don't think so, 
now it's the community to decide...

Jacques
PS :
Postgres does not really bring much with JDBC4 drivers (could be : 
http://www.artima.com/lejava/articles/jdbc_four.html)
JDK 1.6 - JDBC4. Support for JDBC4 methods is limited. The driver builds, but the 
majority of new methods are stubbed out. 
http://jdbc.postgresql.org/download.html
I come to it from this discussion 
http://archives.free.net.ph/thread/20090925.160633.e1923a69.fr.html#20090925.160633.e1923a69

A benchmark while at it 
http://benjchristensen.com/2009/02/12/java-jdk-15-vs-16-performance/


From: Jacques Le Roux jacques.le.r...@les7arts.com

Thanks Adrian,

So it's the same concern than 3 years ago, I will check...

Jacques

From: Adrian Crum adri...@hlmksw.com

Running OFBiz on 1.6 is a good idea, because (Sun claims) 1.6 performs
better than 1.5.

The downside is, there might be servers out there that don't have a 1.6
JRE available. I would like to see us move on to 1.6 (especially now
that 1.7 is near), but I'm concerned for existing installations.

-Adrian

Jacques Le Roux wrote:

Hi devs,

I don't remember why we still use 1.5. Here is a thread from 2006
http://markmail.org/message/5j5es63hpsh543ct.
Maybe it's time to think anew about it, don't you think so ?

Jacques











Re: Build Error

2009-11-13 Thread Jacques Le Roux

Phil Steitz  has fixed it in DBCP at r835956
I will give a try, but it's not a reason to not argument about 1.5 vs 1.6 ;o)

Thanks

Jacques

From: Jacques Le Roux jacques.le.r...@les7arts.com

Hi Scott,

FYI, I have asked about it on  u...@commons.apache.org ...

BTW, I can't remember the reasons why we stay to 1.5, are they still valid ?

Jacques

From: Scott Gray scott.g...@hotwaxmedia.com
I think Jacques is right about the current source code, there are a  
few minor issues that make it 1.6 only.  I made some changes and got  
it to compile, I'll give it a test run and see how it goes.


Regards
Scott

On 14/11/2009, at 12:00 AM, Jacopo Cappellato wrote:


Hmm... yes you are right, Jacques, sorry for that.
I will try to find out more information...

Jacopo

On Nov 13, 2009, at 11:49 AM, Jacques Le Roux wrote:


Thanks Jacopo,

These are really old ones or do I miss something ?

Jacques

From: Jacopo Cappellato jacopo.cappell...@hotwaxmedia.com

http://people.apache.org/builds/commons/nightly/commons-dbcp/

Jacopo

On Nov 13, 2009, at 11:29 AM, Jacques Le Roux wrote:


Hi Scott,

At which date was done this nightly build ? Where did you find it ?

BTW I have reverted both trunk and 9.04

Jacques

From: Scott Gray scott.g...@hotwaxmedia.com
BTW, the latest nightly build from dbcp works just fine on 1.5  
for me,  why are you trying to compile dbcp?

Regards
Scott
On 13/11/2009, at 10:36 PM, Scott Gray wrote:

I'd suggest that you revert it for now.

Regards
Scott

HotWax Media
http://www.hotwaxmedia.com

On 13/11/2009, at 10:20 PM, Jacques Le Roux wrote:

I not totally sure but yet it seems that new versions of DBCP  
needs  the 1.6 jdk (or jdk 1.4) . Extract from README.TXT :  
This release  of JDBC compiles with and supports JDK 1.3  
(JDBC 2.0), JDK 1.4-1.5  (JDBC 3.0) and JDK 1.6 (JDBC 4.0). 


I tried to build with 1.5 but it failed and I began to find a  
way  out, not obvious...


So the alternative is
1) revert DBCP upgrade (fix a bug)
2) Decide to use jdk 1.6 for OFBiz

I would not like to push now for the 2d solution but as this   
upgrade was intended to fix a bug, I wonder if it's not the  
right  time


In the meantime (before a decision is taken), I will continue  
to  search a solution to compile with 1.5 but does not seem  
easy (conditional ANT compile deal with JDBC versions), and  
I'd not like  to rewrite DBCP, even a part, I've other fish to  
fry ;o)


Jacques

From: Jacques Le Roux jacques.le.r...@les7arts.com

Thanks Adrian,

Yes I did not care and build with ant from Eclipse where I  
use the  1.6 JDK. I'm on it, not as simple as I thought some  
problem

appeared...
In the meantime can you use 1.6 to build ?
BTW, could we not change from 1.5 to 1.6, is there any  
blocking  reasons I don't remember ?


Jacques

From: Adrian Crum adrian.c...@yahoo.com

Latest trunk:

Compiling 129 source files to C:\ofbiz\framework\entity 
\build \classes
[javac15] C:\ofbiz\framework\entity\src\org\ofbiz\entity  
\connection\DBCPConnectionFactory.java:21: cannot access

org.apache.commons.dbcp.ConnectionFactory
[javac15] bad class file:
C:\ofbiz\framework\entity\lib\commons-dbcp-1.3-2009-  
r834702.jar(org/apache/commons/dbcp/ConnectionFactory.class)

[javac15] class file has wrong version 50.0, should be 49.0
[javac15] Please remove or make sure it appears in the  
correct  subdirectory of the classpath.

[javac15] import org.apache.commons.dbcp.ConnectionFactory;
[javac15]^
[javac15] 1 error
































Re: jdk 1.5 or 1.6

2009-11-13 Thread Adrian Crum
Thank you for the info! That certainly helps.

-Adrian

--- On Fri, 11/13/09, Jacques Le Roux jacques.le.r...@les7arts.com wrote:

 From: Jacques Le Roux jacques.le.r...@les7arts.com
 Subject: Re: jdk 1.5 or 1.6
 To: dev@ofbiz.apache.org
 Date: Friday, November 13, 2009, 11:46 AM
 Sun :
 Java SE  Java SE for Business Support Road Map (JDKs
 End of Life)
 http://java.sun.com/products/archive/eol.policy.html
 
 1.6 supported systems
 http://java.sun.com/javase/6/webnotes/install/system-configurations.html
 
 15 supported systems
 http://java.sun.com/j2se/1.5.0/system-configurations.html
 
 Conclusion (I don't list what is better, only what miss
 from 1.5 to 1.6)
 Better for Solaris (no surprises)
 
 Windows x86
 no longer : Windows 98 (2nd Edition) and  Windows ME
 (who cares ?)
 no longer : Windows Server 2003, Web Edition (R2, SP1,
 SP2)   and Windows Server 2003, Standard
 Edition (R2, SP1, SP2) ( a bit more
 annoying maybe)
 but still : Windows Server 2003, Enterprise Edition (R2,
 SP1, SP2) and Windows Server 2003, DataCenter Edition (R2,
 SP1, SP2)
 
 Windows x64 32-bit mode
 no longer : Windows Server 2008 Datacenter (SP1, SP2) 
 and Windows Web Server 2008 (SP1, SP2)
 but still : Windows Server 2008 Standard (SP1, SP2) and
 Windows Server 2008 Enterprise (SP1, SP2)
 
 Linux x86
 no longer : TurboLinux 8.0
 but : Turbo Linux 10 (ONLY Chinese and Japanese Locales. No
 English.)
 
 Linux x64 32-bit mode
 new : Turbo Linux 10 (ONLY Chinese and Japanese Locales. No
 English.)
 
 From this I can see only problems with
 Windows Server 2003, Web Edition and Standard Edition
 Windows Server 2008 Datacenter and Web Server
 TurboLinux 8.0
 
 Should this only stop us to migrate to jdk 1.6? Personnaly
 I don't think so, now it's the community to decide...
 
 Jacques
 PS :
 Postgres does not really bring much with JDBC4 drivers
 (could be : http://www.artima.com/lejava/articles/jdbc_four.html)
 JDK 1.6 - JDBC4. Support for JDBC4 methods is
 limited. The driver builds, but the majority of new methods
 are stubbed out. 
 http://jdbc.postgresql.org/download.html
 I come to it from this discussion 
 http://archives.free.net.ph/thread/20090925.160633.e1923a69.fr.html#20090925.160633.e1923a69
 
 A benchmark while at it 
 http://benjchristensen.com/2009/02/12/java-jdk-15-vs-16-performance/
 
 
 From: Jacques Le Roux jacques.le.r...@les7arts.com
  Thanks Adrian,
 
  So it's the same concern than 3 years ago, I will
 check...
 
  Jacques
 
  From: Adrian Crum adri...@hlmksw.com
  Running OFBiz on 1.6 is a good idea, because (Sun
 claims) 1.6 performs
  better than 1.5.
 
  The downside is, there might be servers out there
 that don't have a 1.6
  JRE available. I would like to see us move on to
 1.6 (especially now
  that 1.7 is near), but I'm concerned for existing
 installations.
 
  -Adrian
 
  Jacques Le Roux wrote:
  Hi devs,
 
  I don't remember why we still use 1.5. Here is
 a thread from 2006
  http://markmail.org/message/5j5es63hpsh543ct.
  Maybe it's time to think anew about it, don't
 you think so ?
 
  Jacques
 
 
 
 
 
 
 





Re: Build Error

2009-11-13 Thread Jacques Le Roux

It works like a charm, I will replace...

Jacques

From: Jacques Le Roux jacques.le.r...@les7arts.com

Phil Steitz  has fixed it in DBCP at r835956
I will give a try, but it's not a reason to not argument about 1.5 vs 1.6 ;o)

Thanks

Jacques

From: Jacques Le Roux jacques.le.r...@les7arts.com

Hi Scott,

FYI, I have asked about it on  u...@commons.apache.org ...

BTW, I can't remember the reasons why we stay to 1.5, are they still valid ?

Jacques

From: Scott Gray scott.g...@hotwaxmedia.com
I think Jacques is right about the current source code, there are a  
few minor issues that make it 1.6 only.  I made some changes and got  
it to compile, I'll give it a test run and see how it goes.


Regards
Scott

On 14/11/2009, at 12:00 AM, Jacopo Cappellato wrote:


Hmm... yes you are right, Jacques, sorry for that.
I will try to find out more information...

Jacopo

On Nov 13, 2009, at 11:49 AM, Jacques Le Roux wrote:


Thanks Jacopo,

These are really old ones or do I miss something ?

Jacques

From: Jacopo Cappellato jacopo.cappell...@hotwaxmedia.com

http://people.apache.org/builds/commons/nightly/commons-dbcp/

Jacopo

On Nov 13, 2009, at 11:29 AM, Jacques Le Roux wrote:


Hi Scott,

At which date was done this nightly build ? Where did you find it ?

BTW I have reverted both trunk and 9.04

Jacques

From: Scott Gray scott.g...@hotwaxmedia.com
BTW, the latest nightly build from dbcp works just fine on 1.5  
for me,  why are you trying to compile dbcp?

Regards
Scott
On 13/11/2009, at 10:36 PM, Scott Gray wrote:

I'd suggest that you revert it for now.

Regards
Scott

HotWax Media
http://www.hotwaxmedia.com

On 13/11/2009, at 10:20 PM, Jacques Le Roux wrote:

I not totally sure but yet it seems that new versions of DBCP  
needs  the 1.6 jdk (or jdk 1.4) . Extract from README.TXT :  
This release  of JDBC compiles with and supports JDK 1.3  
(JDBC 2.0), JDK 1.4-1.5  (JDBC 3.0) and JDK 1.6 (JDBC 4.0). 


I tried to build with 1.5 but it failed and I began to find a  
way  out, not obvious...


So the alternative is
1) revert DBCP upgrade (fix a bug)
2) Decide to use jdk 1.6 for OFBiz

I would not like to push now for the 2d solution but as this   
upgrade was intended to fix a bug, I wonder if it's not the  
right  time


In the meantime (before a decision is taken), I will continue  
to  search a solution to compile with 1.5 but does not seem  
easy (conditional ANT compile deal with JDBC versions), and  
I'd not like  to rewrite DBCP, even a part, I've other fish to  
fry ;o)


Jacques

From: Jacques Le Roux jacques.le.r...@les7arts.com

Thanks Adrian,

Yes I did not care and build with ant from Eclipse where I  
use the  1.6 JDK. I'm on it, not as simple as I thought some  
problem

appeared...
In the meantime can you use 1.6 to build ?
BTW, could we not change from 1.5 to 1.6, is there any  
blocking  reasons I don't remember ?


Jacques

From: Adrian Crum adrian.c...@yahoo.com

Latest trunk:

Compiling 129 source files to C:\ofbiz\framework\entity 
\build \classes
[javac15] C:\ofbiz\framework\entity\src\org\ofbiz\entity  
\connection\DBCPConnectionFactory.java:21: cannot access

org.apache.commons.dbcp.ConnectionFactory
[javac15] bad class file:
C:\ofbiz\framework\entity\lib\commons-dbcp-1.3-2009-  
r834702.jar(org/apache/commons/dbcp/ConnectionFactory.class)

[javac15] class file has wrong version 50.0, should be 49.0
[javac15] Please remove or make sure it appears in the  
correct  subdirectory of the classpath.

[javac15] import org.apache.commons.dbcp.ConnectionFactory;
[javac15]^
[javac15] 1 error


































Re: jdk 1.5 or 1.6

2009-11-13 Thread Scott Gray
What is not clear to me is what are we missing out on by supporting  
both as we currently do,  I think DBCP is an odd case because they  
obviously have tried to support 1.5 but it seems there are a couple of  
very minor bugs that prevent that support.


Other than DBCP what would we actually change (and why) that would  
prevent 1.5 support?


Thanks
Scott

HotWax Media
http://www.hotwaxmedia.com

On 14/11/2009, at 8:46 AM, Jacques Le Roux wrote:


Sun :
Java SE  Java SE for Business Support Road Map (JDKs End of Life)
http://java.sun.com/products/archive/eol.policy.html

1.6 supported systems
http://java.sun.com/javase/6/webnotes/install/system-configurations.html

15 supported systems
http://java.sun.com/j2se/1.5.0/system-configurations.html

Conclusion (I don't list what is better, only what miss from 1.5 to  
1.6)

Better for Solaris (no surprises)

Windows x86
no longer : Windows 98 (2nd Edition) and  Windows ME (who cares ?)
no longer : Windows Server 2003, Web Edition (R2, SP1, SP2)   and  
Windows Server 2003, Standard Edition (R2, SP1, SP2) ( a bit more

annoying maybe)
but still : Windows Server 2003, Enterprise Edition (R2, SP1, SP2)  
and Windows Server 2003, DataCenter Edition (R2, SP1, SP2)


Windows x64 32-bit mode
no longer : Windows Server 2008 Datacenter (SP1, SP2)  and Windows  
Web Server 2008 (SP1, SP2)
but still : Windows Server 2008 Standard (SP1, SP2) and Windows  
Server 2008 Enterprise (SP1, SP2)


Linux x86
no longer : TurboLinux 8.0
but : Turbo Linux 10 (ONLY Chinese and Japanese Locales. No English.)

Linux x64 32-bit mode
new : Turbo Linux 10 (ONLY Chinese and Japanese Locales. No English.)

From this I can see only problems with
Windows Server 2003, Web Edition and Standard Edition
Windows Server 2008 Datacenter and Web Server
TurboLinux 8.0

Should this only stop us to migrate to jdk 1.6? Personnaly I don't  
think so, now it's the community to decide...


Jacques
PS :
Postgres does not really bring much with JDBC4 drivers (could be : 
http://www.artima.com/lejava/articles/jdbc_four.html)
JDK 1.6 - JDBC4. Support for JDBC4 methods is limited. The driver  
builds, but the majority of new methods are stubbed out. 

http://jdbc.postgresql.org/download.html
I come to it from this discussion 
http://archives.free.net.ph/thread/20090925.160633.e1923a69.fr.html#20090925.160633.e1923a69

A benchmark while at it 
http://benjchristensen.com/2009/02/12/java-jdk-15-vs-16-performance/


From: Jacques Le Roux jacques.le.r...@les7arts.com

Thanks Adrian,

So it's the same concern than 3 years ago, I will check...

Jacques

From: Adrian Crum adri...@hlmksw.com
Running OFBiz on 1.6 is a good idea, because (Sun claims) 1.6  
performs

better than 1.5.

The downside is, there might be servers out there that don't have  
a 1.6

JRE available. I would like to see us move on to 1.6 (especially now
that 1.7 is near), but I'm concerned for existing installations.

-Adrian

Jacques Le Roux wrote:

Hi devs,

I don't remember why we still use 1.5. Here is a thread from 2006
http://markmail.org/message/5j5es63hpsh543ct.
Maybe it's time to think anew about it, don't you think so ?

Jacques













smime.p7s
Description: S/MIME cryptographic signature


Re: jdk 1.5 or 1.6

2009-11-13 Thread Jacques Le Roux

I will commit soon using DBCP r835956 and this problem will have dissapeared.
As not much as been done from Postgres to support JDBC 4 we don't need really to turn to new drivers OOTB and if someone needs them 
(on another DB or context or what else) s/he could do it anyway but will have to replace the DBCP (it's easily done)


It's also good to know that not much has been lost, from a platform POV, when 
using 1.6.

Jacques

From: Scott Gray scott.g...@hotwaxmedia.com
What is not clear to me is what are we missing out on by supporting  both as we currently do,  I think DBCP is an odd case because 
they  obviously have tried to support 1.5 but it seems there are a couple of  very minor bugs that prevent that support.


Other than DBCP what would we actually change (and why) that would  prevent 1.5 
support?

Thanks
Scott

HotWax Media
http://www.hotwaxmedia.com

On 14/11/2009, at 8:46 AM, Jacques Le Roux wrote:


Sun :
Java SE  Java SE for Business Support Road Map (JDKs End of Life)
http://java.sun.com/products/archive/eol.policy.html

1.6 supported systems
http://java.sun.com/javase/6/webnotes/install/system-configurations.html

15 supported systems
http://java.sun.com/j2se/1.5.0/system-configurations.html

Conclusion (I don't list what is better, only what miss from 1.5 to  1.6)
Better for Solaris (no surprises)

Windows x86
no longer : Windows 98 (2nd Edition) and  Windows ME (who cares ?)
no longer : Windows Server 2003, Web Edition (R2, SP1, SP2)   and  Windows Server 2003, Standard Edition (R2, SP1, SP2) ( a bit 
more

annoying maybe)
but still : Windows Server 2003, Enterprise Edition (R2, SP1, SP2)  and Windows 
Server 2003, DataCenter Edition (R2, SP1, SP2)

Windows x64 32-bit mode
no longer : Windows Server 2008 Datacenter (SP1, SP2)  and Windows  Web Server 
2008 (SP1, SP2)
but still : Windows Server 2008 Standard (SP1, SP2) and Windows  Server 2008 
Enterprise (SP1, SP2)

Linux x86
no longer : TurboLinux 8.0
but : Turbo Linux 10 (ONLY Chinese and Japanese Locales. No English.)

Linux x64 32-bit mode
new : Turbo Linux 10 (ONLY Chinese and Japanese Locales. No English.)

From this I can see only problems with
Windows Server 2003, Web Edition and Standard Edition
Windows Server 2008 Datacenter and Web Server
TurboLinux 8.0

Should this only stop us to migrate to jdk 1.6? Personnaly I don't  think so, 
now it's the community to decide...

Jacques
PS :
Postgres does not really bring much with JDBC4 drivers (could be : 
http://www.artima.com/lejava/articles/jdbc_four.html)
JDK 1.6 - JDBC4. Support for JDBC4 methods is limited. The driver  builds, but the 
majority of new methods are stubbed out. 
http://jdbc.postgresql.org/download.html
I come to it from this discussion 
http://archives.free.net.ph/thread/20090925.160633.e1923a69.fr.html#20090925.160633.e1923a69

A benchmark while at it 
http://benjchristensen.com/2009/02/12/java-jdk-15-vs-16-performance/


From: Jacques Le Roux jacques.le.r...@les7arts.com

Thanks Adrian,

So it's the same concern than 3 years ago, I will check...

Jacques

From: Adrian Crum adri...@hlmksw.com

Running OFBiz on 1.6 is a good idea, because (Sun claims) 1.6  performs
better than 1.5.

The downside is, there might be servers out there that don't have  a 1.6
JRE available. I would like to see us move on to 1.6 (especially now
that 1.7 is near), but I'm concerned for existing installations.

-Adrian

Jacques Le Roux wrote:

Hi devs,

I don't remember why we still use 1.5. Here is a thread from 2006
http://markmail.org/message/5j5es63hpsh543ct.
Maybe it's time to think anew about it, don't you think so ?

Jacques

















[jira] Commented: (OFBIZ-3194) Quick look are showing pagination renderNextPrev pagination style when list size is greater than 20

2009-11-13 Thread Bruno Busco (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-3194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12777683#action_12777683
 ] 

Bruno Busco commented on OFBIZ-3194:


The value 20 hardcoded was used because it is the minimum of the available 
viewSize.
With the change you have done the problem is that when you select, lets say 30 
as viewSize, and you have a listSize of 25 there is no way to switch back to 
viewSize 20 because the pagination is not rendered anymore.


 Quick look are showing pagination renderNextPrev pagination style when list 
 size is greater than 20
 ---

 Key: OFBIZ-3194
 URL: https://issues.apache.org/jira/browse/OFBIZ-3194
 Project: OFBiz
  Issue Type: Bug
  Components: framework
Affects Versions: SVN trunk
Reporter: Divesh Dutta
Assignee: Jacopo Cappellato
 Fix For: SVN trunk

 Attachments: OFBiz-3194.patch


 Quick look are showing pagination renderNextPrev pagination style when list 
 size is greater than 20.
 In htmlFormMacroLibrary.ftl below given code snippet is hard-coded. :
  {#if listSize gt 20}
 This can be changed to
  {#if listSize gt viewSize}
 as viewSize is passed as parameter in macro renderNextPrev. This is also 
 reported by Matthieu Bollot in developer mailing list.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (OFBIZ-3156) A draft version of a new theme

2009-11-13 Thread Bruno Busco (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-3156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bruno Busco updated OFBIZ-3156:
---

Attachment: OFBIZ-3156+newtabbar.patch

An updated patch to be used to show correctly the tabbars with this theme.

 A draft version of a new theme
 --

 Key: OFBIZ-3156
 URL: https://issues.apache.org/jira/browse/OFBIZ-3156
 Project: OFBiz
  Issue Type: Improvement
Reporter: Bruno Busco
Priority: Minor
 Attachments: French not translated.jpg, French translated.jpg, 
 newlight.zip, newlight.zip, OFBIZ-3156 newtabbar.patch, 
 OFBIZ-3156+newtabbar.patch, OFBIZ-3156+newtabbar.patch, ss1.GIF, ss2.GIF, 
 ss3.GIF, ss4.GIF, ss5.GIF, ss6.GIF, Sub-menu not visible.jpg


 Hi,
 I have a draft version of a new theme I would like to show you.
 This has been developed (not yet finished) following the great Ryan Foster's 
 suggestions you can read here 
 http://n4.nabble.com/Feedbacks-on-Bluelight-theme-td252746.html#a252817
 The main Idea is to make it more clear how the menu selection works combining 
 a breadcrumbs function with a navigation function.
 The theme is attached as a zip file that should be installed in the themes 
 folder.
 A further change I propose here is to slightly modify how the application 
 tabbar is rendered. You can find the change in the attached patch.
 Basically, as you can see in the screenshots, the tab bar is rendered 
 attached to the navigation menu with the same background color. This gives 
 the clear idea that the tabbar is an extension of the selection in the menu.
 In the patch only some of the screens have been modified to this new pattern 
 but a change in the other themes is also included so that nothing should 
 change when other themes are selected.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (OFBIZ-2599) Memory leak due to transaction management

2009-11-13 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-2599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-2599.
--

Resolution: Fixed

Finally fixed, after a fix from Phil Steitz in DBCP at r835966.
Trunk r836015, R9.04 r836020  


 Memory leak due to transaction management
 -

 Key: OFBIZ-2599
 URL: https://issues.apache.org/jira/browse/OFBIZ-2599
 Project: OFBiz
  Issue Type: Bug
  Components: framework
Affects Versions: Release Branch 9.04, SVN trunk
 Environment: jdk5, commons-dbcp-head
Reporter: Philippe Mouawad
Assignee: Jacques Le Roux
Priority: Critical
 Fix For: Release Branch 9.04, SVN trunk

 Attachments: commons-dbcp-1.3-r674758-patched.jar, memory.png, 
 patch-DBCPConneectionFactory.txt


 Hello,
 We are been using Ofbiz with DBCP based implementation.
 Ofbiz uses a Head revision of DBCP (package org.apache.commons.dbcp.managed 
 is the same as current TRUNK) and geronimo-transaction-1.0.
 We are having recurrent OutOfMemory which occur on a 2 days basis.
 See:
 https://issues.apache.org/jira/browse/DBCP-294
 Philippe Mouawad
 http://www.ubik-ingenierie.com

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-3194) Quick look are showing pagination renderNextPrev pagination style when list size is greater than 20

2009-11-13 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-3194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12777694#action_12777694
 ] 

Jacques Le Roux commented on OFBIZ-3194:


Then we should reopen, isn'it ?

 Quick look are showing pagination renderNextPrev pagination style when list 
 size is greater than 20
 ---

 Key: OFBIZ-3194
 URL: https://issues.apache.org/jira/browse/OFBIZ-3194
 Project: OFBiz
  Issue Type: Bug
  Components: framework
Affects Versions: SVN trunk
Reporter: Divesh Dutta
Assignee: Jacopo Cappellato
 Fix For: SVN trunk

 Attachments: OFBiz-3194.patch


 Quick look are showing pagination renderNextPrev pagination style when list 
 size is greater than 20.
 In htmlFormMacroLibrary.ftl below given code snippet is hard-coded. :
  {#if listSize gt 20}
 This can be changed to
  {#if listSize gt viewSize}
 as viewSize is passed as parameter in macro renderNextPrev. This is also 
 reported by Matthieu Bollot in developer mailing list.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (OFBIZ-3156) A draft version of a new theme

2009-11-13 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-3156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-3156:
---

Attachment: Hard to read menu in order creation.jpg

Hi Bruno,

I really like it, but I find the order creation menu still difficukt to read 
(FF3.5.5 on XP)

Thanks!

 A draft version of a new theme
 --

 Key: OFBIZ-3156
 URL: https://issues.apache.org/jira/browse/OFBIZ-3156
 Project: OFBiz
  Issue Type: Improvement
Reporter: Bruno Busco
Priority: Minor
 Attachments: French not translated.jpg, French translated.jpg, Hard 
 to read menu in order creation.jpg, newlight.zip, newlight.zip, OFBIZ-3156 
 newtabbar.patch, OFBIZ-3156+newtabbar.patch, OFBIZ-3156+newtabbar.patch, 
 ss1.GIF, ss2.GIF, ss3.GIF, ss4.GIF, ss5.GIF, ss6.GIF, Sub-menu not visible.jpg


 Hi,
 I have a draft version of a new theme I would like to show you.
 This has been developed (not yet finished) following the great Ryan Foster's 
 suggestions you can read here 
 http://n4.nabble.com/Feedbacks-on-Bluelight-theme-td252746.html#a252817
 The main Idea is to make it more clear how the menu selection works combining 
 a breadcrumbs function with a navigation function.
 The theme is attached as a zip file that should be installed in the themes 
 folder.
 A further change I propose here is to slightly modify how the application 
 tabbar is rendered. You can find the change in the attached patch.
 Basically, as you can see in the screenshots, the tab bar is rendered 
 attached to the navigation menu with the same background color. This gives 
 the clear idea that the tabbar is an extension of the selection in the menu.
 In the patch only some of the screens have been modified to this new pattern 
 but a change in the other themes is also included so that nothing should 
 change when other themes are selected.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-3156) A draft version of a new theme

2009-11-13 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-3156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1206#action_1206
 ] 

Jacques Le Roux commented on OFBIZ-3156:


The screen copy is Hard to read menu in order creation.jpg (sorry to be 
verbose, tired)

 A draft version of a new theme
 --

 Key: OFBIZ-3156
 URL: https://issues.apache.org/jira/browse/OFBIZ-3156
 Project: OFBiz
  Issue Type: Improvement
Reporter: Bruno Busco
Priority: Minor
 Attachments: French not translated.jpg, French translated.jpg, Hard 
 to read menu in order creation.jpg, newlight.zip, newlight.zip, OFBIZ-3156 
 newtabbar.patch, OFBIZ-3156+newtabbar.patch, OFBIZ-3156+newtabbar.patch, 
 ss1.GIF, ss2.GIF, ss3.GIF, ss4.GIF, ss5.GIF, ss6.GIF, Sub-menu not visible.jpg


 Hi,
 I have a draft version of a new theme I would like to show you.
 This has been developed (not yet finished) following the great Ryan Foster's 
 suggestions you can read here 
 http://n4.nabble.com/Feedbacks-on-Bluelight-theme-td252746.html#a252817
 The main Idea is to make it more clear how the menu selection works combining 
 a breadcrumbs function with a navigation function.
 The theme is attached as a zip file that should be installed in the themes 
 folder.
 A further change I propose here is to slightly modify how the application 
 tabbar is rendered. You can find the change in the attached patch.
 Basically, as you can see in the screenshots, the tab bar is rendered 
 attached to the navigation menu with the same background color. This gives 
 the clear idea that the tabbar is an extension of the selection in the menu.
 In the patch only some of the screens have been modified to this new pattern 
 but a change in the other themes is also included so that nothing should 
 change when other themes are selected.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-3156) A draft version of a new theme

2009-11-13 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-3156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1205#action_1205
 ] 

Jacques Le Roux commented on OFBIZ-3156:


I have added a screen-copy. I have not used it much yet. But I believe it will 
be my prefered... Sober and clean (despite dropping crumbs ;) )

 A draft version of a new theme
 --

 Key: OFBIZ-3156
 URL: https://issues.apache.org/jira/browse/OFBIZ-3156
 Project: OFBiz
  Issue Type: Improvement
Reporter: Bruno Busco
Priority: Minor
 Attachments: French not translated.jpg, French translated.jpg, Hard 
 to read menu in order creation.jpg, newlight.zip, newlight.zip, OFBIZ-3156 
 newtabbar.patch, OFBIZ-3156+newtabbar.patch, OFBIZ-3156+newtabbar.patch, 
 ss1.GIF, ss2.GIF, ss3.GIF, ss4.GIF, ss5.GIF, ss6.GIF, Sub-menu not visible.jpg


 Hi,
 I have a draft version of a new theme I would like to show you.
 This has been developed (not yet finished) following the great Ryan Foster's 
 suggestions you can read here 
 http://n4.nabble.com/Feedbacks-on-Bluelight-theme-td252746.html#a252817
 The main Idea is to make it more clear how the menu selection works combining 
 a breadcrumbs function with a navigation function.
 The theme is attached as a zip file that should be installed in the themes 
 folder.
 A further change I propose here is to slightly modify how the application 
 tabbar is rendered. You can find the change in the attached patch.
 Basically, as you can see in the screenshots, the tab bar is rendered 
 attached to the navigation menu with the same background color. This gives 
 the clear idea that the tabbar is an extension of the selection in the menu.
 In the patch only some of the screens have been modified to this new pattern 
 but a change in the other themes is also included so that nothing should 
 change when other themes are selected.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-3156) A draft version of a new theme

2009-11-13 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-3156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1208#action_1208
 ] 

Jacques Le Roux commented on OFBIZ-3156:


Ha, also it would be maybe preferable to split he 1st long menu in 2 columns 
(int the same menu, like in BIzness Time) else it's too long

 A draft version of a new theme
 --

 Key: OFBIZ-3156
 URL: https://issues.apache.org/jira/browse/OFBIZ-3156
 Project: OFBiz
  Issue Type: Improvement
Reporter: Bruno Busco
Priority: Minor
 Attachments: French not translated.jpg, French translated.jpg, Hard 
 to read menu in order creation.jpg, newlight.zip, newlight.zip, OFBIZ-3156 
 newtabbar.patch, OFBIZ-3156+newtabbar.patch, OFBIZ-3156+newtabbar.patch, 
 ss1.GIF, ss2.GIF, ss3.GIF, ss4.GIF, ss5.GIF, ss6.GIF, Sub-menu not visible.jpg


 Hi,
 I have a draft version of a new theme I would like to show you.
 This has been developed (not yet finished) following the great Ryan Foster's 
 suggestions you can read here 
 http://n4.nabble.com/Feedbacks-on-Bluelight-theme-td252746.html#a252817
 The main Idea is to make it more clear how the menu selection works combining 
 a breadcrumbs function with a navigation function.
 The theme is attached as a zip file that should be installed in the themes 
 folder.
 A further change I propose here is to slightly modify how the application 
 tabbar is rendered. You can find the change in the attached patch.
 Basically, as you can see in the screenshots, the tab bar is rendered 
 attached to the navigation menu with the same background color. This gives 
 the clear idea that the tabbar is an extension of the selection in the menu.
 In the patch only some of the screens have been modified to this new pattern 
 but a change in the other themes is also included so that nothing should 
 change when other themes are selected.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-3156) A draft version of a new theme

2009-11-13 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-3156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1212#action_1212
 ] 

Jacques Le Roux commented on OFBIZ-3156:


I have commited OFBIZ-3156+newtabbar.patch at r836044  


 A draft version of a new theme
 --

 Key: OFBIZ-3156
 URL: https://issues.apache.org/jira/browse/OFBIZ-3156
 Project: OFBiz
  Issue Type: Improvement
Reporter: Bruno Busco
Priority: Minor
 Attachments: French not translated.jpg, French translated.jpg, Hard 
 to read menu in order creation.jpg, newlight.zip, newlight.zip, OFBIZ-3156 
 newtabbar.patch, OFBIZ-3156+newtabbar.patch, OFBIZ-3156+newtabbar.patch, 
 ss1.GIF, ss2.GIF, ss3.GIF, ss4.GIF, ss5.GIF, ss6.GIF, Sub-menu not visible.jpg


 Hi,
 I have a draft version of a new theme I would like to show you.
 This has been developed (not yet finished) following the great Ryan Foster's 
 suggestions you can read here 
 http://n4.nabble.com/Feedbacks-on-Bluelight-theme-td252746.html#a252817
 The main Idea is to make it more clear how the menu selection works combining 
 a breadcrumbs function with a navigation function.
 The theme is attached as a zip file that should be installed in the themes 
 folder.
 A further change I propose here is to slightly modify how the application 
 tabbar is rendered. You can find the change in the attached patch.
 Basically, as you can see in the screenshots, the tab bar is rendered 
 attached to the navigation menu with the same background color. This gives 
 the clear idea that the tabbar is an extension of the selection in the menu.
 In the patch only some of the screens have been modified to this new pattern 
 but a change in the other themes is also included so that nothing should 
 change when other themes are selected.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



Re: javascript new files

2009-11-13 Thread Jacques Le Roux

OK I guess the answers are YES

Jacques

From: Jacques Le Roux jacques.le.r...@les7arts.com

Hi,

It seems that there would be more and more new javascript files not parts of a library (Dojo, etc.). 
Should we not recommend to this OFBiz specific files to use the same best tractices (no tabs, etc.) than for others ?


Thanks

Jacques





Apache Infrastructure

2009-11-13 Thread Tim Ruppert
All, Gavin just closed the issue for setting up everything on Apache  
Infrastructure.  At this point, he is saying that the only thing left  
to do is move the docs.ofbiz.org stuff over to the Apache based  
confluence and we should be good to go.  I have not had much time to  
look into what he's been doing over there - other than providing  
pointers and helpful hints as to how I set this stuff up in the past.


For those of you that were looking for this to be on Apache Infra -  
here's your chance to dive in and make it happen!  Please let me know  
when it's all ready and we can shutdown the servers that we've been  
maintaining.  If you need any additional support from me as to  
ensuring that nothing's getting missed, I'm happy to provide it as well.


Thanks again to everyone who's been helping look at these servers at  
Contegix - I think they've done an amazing job and will continue to  
until we get word that the community is ready for the move.


Cheers,
Ruppert
--
Tim Ruppert
HotWax Media
http://www.hotwaxmedia.com

o:801.649.6594
f:801.649.6595



smime.p7s
Description: S/MIME cryptographic signature


Re: jdk 1.5 or 1.6

2009-11-13 Thread David E Jones


We had to make this decision before with 1.4 - 1.5, and if I remember  
right from 1.3 - 1.4 too.


Sooner or later we need to deprecate support for 1.5 in order to move  
on, and to more easily be able to update various libraries and such.  
The 1.5 - 1.6 transition is a bit of a pain because they did a few  
changes that were not backwards compatible. Because of that it would  
be particularly nice to deprecate support for 1.5 and require 1.6 (or  
later, as possible/available).


In any case, our criteria before was to deprecate support for the  
older version of Java as soon as the newer version was widely  
available. At this point I think 1.6 qualifies well for that... unless  
there are specific systems people use that still can't run 1.6 then we  
should just update that requirement.


-David


On Nov 13, 2009, at 1:02 PM, Scott Gray wrote:

What is not clear to me is what are we missing out on by supporting  
both as we currently do,  I think DBCP is an odd case because they  
obviously have tried to support 1.5 but it seems there are a couple  
of very minor bugs that prevent that support.


Other than DBCP what would we actually change (and why) that would  
prevent 1.5 support?


Thanks
Scott

HotWax Media
http://www.hotwaxmedia.com

On 14/11/2009, at 8:46 AM, Jacques Le Roux wrote:


Sun :
Java SE  Java SE for Business Support Road Map (JDKs End of Life)
http://java.sun.com/products/archive/eol.policy.html

1.6 supported systems
http://java.sun.com/javase/6/webnotes/install/system-configurations.html

15 supported systems
http://java.sun.com/j2se/1.5.0/system-configurations.html

Conclusion (I don't list what is better, only what miss from 1.5 to  
1.6)

Better for Solaris (no surprises)

Windows x86
no longer : Windows 98 (2nd Edition) and  Windows ME (who cares ?)
no longer : Windows Server 2003, Web Edition (R2, SP1, SP2)   and  
Windows Server 2003, Standard Edition (R2, SP1, SP2) ( a bit more

annoying maybe)
but still : Windows Server 2003, Enterprise Edition (R2, SP1, SP2)  
and Windows Server 2003, DataCenter Edition (R2, SP1, SP2)


Windows x64 32-bit mode
no longer : Windows Server 2008 Datacenter (SP1, SP2)  and Windows  
Web Server 2008 (SP1, SP2)
but still : Windows Server 2008 Standard (SP1, SP2) and Windows  
Server 2008 Enterprise (SP1, SP2)


Linux x86
no longer : TurboLinux 8.0
but : Turbo Linux 10 (ONLY Chinese and Japanese Locales. No English.)

Linux x64 32-bit mode
new : Turbo Linux 10 (ONLY Chinese and Japanese Locales. No English.)

From this I can see only problems with
Windows Server 2003, Web Edition and Standard Edition
Windows Server 2008 Datacenter and Web Server
TurboLinux 8.0

Should this only stop us to migrate to jdk 1.6? Personnaly I don't  
think so, now it's the community to decide...


Jacques
PS :
Postgres does not really bring much with JDBC4 drivers (could be : http://www.artima.com/lejava/articles/jdbc_four.html 
)
JDK 1.6 - JDBC4. Support for JDBC4 methods is limited. The driver  
builds, but the majority of new methods are stubbed out. 

http://jdbc.postgresql.org/download.html
I come to it from this discussion 
http://archives.free.net.ph/thread/20090925.160633.e1923a69.fr.html#20090925.160633.e1923a69

A benchmark while at it 
http://benjchristensen.com/2009/02/12/java-jdk-15-vs-16-performance/


From: Jacques Le Roux jacques.le.r...@les7arts.com

Thanks Adrian,

So it's the same concern than 3 years ago, I will check...

Jacques

From: Adrian Crum adri...@hlmksw.com
Running OFBiz on 1.6 is a good idea, because (Sun claims) 1.6  
performs

better than 1.5.

The downside is, there might be servers out there that don't have  
a 1.6
JRE available. I would like to see us move on to 1.6 (especially  
now

that 1.7 is near), but I'm concerned for existing installations.

-Adrian

Jacques Le Roux wrote:

Hi devs,

I don't remember why we still use 1.5. Here is a thread from 2006
http://markmail.org/message/5j5es63hpsh543ct.
Maybe it's time to think anew about it, don't you think so ?

Jacques















Re: jdk 1.5 or 1.6

2009-11-13 Thread Tim Ruppert
+1 - I totally agree.  People can always run the release branch if  
they need to stay on 1.5, but the show must go on!


Cheers,
Ruppert

On Nov 13, 2009, at 9:32 PM, David E Jones wrote:



We had to make this decision before with 1.4 - 1.5, and if I  
remember right from 1.3 - 1.4 too.


Sooner or later we need to deprecate support for 1.5 in order to  
move on, and to more easily be able to update various libraries and  
such. The 1.5 - 1.6 transition is a bit of a pain because they did  
a few changes that were not backwards compatible. Because of that it  
would be particularly nice to deprecate support for 1.5 and require  
1.6 (or later, as possible/available).


In any case, our criteria before was to deprecate support for the  
older version of Java as soon as the newer version was widely  
available. At this point I think 1.6 qualifies well for that...  
unless there are specific systems people use that still can't run  
1.6 then we should just update that requirement.


-David


On Nov 13, 2009, at 1:02 PM, Scott Gray wrote:

What is not clear to me is what are we missing out on by supporting  
both as we currently do,  I think DBCP is an odd case because they  
obviously have tried to support 1.5 but it seems there are a couple  
of very minor bugs that prevent that support.


Other than DBCP what would we actually change (and why) that would  
prevent 1.5 support?


Thanks
Scott

HotWax Media
http://www.hotwaxmedia.com

On 14/11/2009, at 8:46 AM, Jacques Le Roux wrote:


Sun :
Java SE  Java SE for Business Support Road Map (JDKs End of Life)
http://java.sun.com/products/archive/eol.policy.html

1.6 supported systems
http://java.sun.com/javase/6/webnotes/install/system-configurations.html

15 supported systems
http://java.sun.com/j2se/1.5.0/system-configurations.html

Conclusion (I don't list what is better, only what miss from 1.5  
to 1.6)

Better for Solaris (no surprises)

Windows x86
no longer : Windows 98 (2nd Edition) and  Windows ME (who cares ?)
no longer : Windows Server 2003, Web Edition (R2, SP1, SP2)   and  
Windows Server 2003, Standard Edition (R2, SP1, SP2) ( a bit more

annoying maybe)
but still : Windows Server 2003, Enterprise Edition (R2, SP1, SP2)  
and Windows Server 2003, DataCenter Edition (R2, SP1, SP2)


Windows x64 32-bit mode
no longer : Windows Server 2008 Datacenter (SP1, SP2)  and Windows  
Web Server 2008 (SP1, SP2)
but still : Windows Server 2008 Standard (SP1, SP2) and Windows  
Server 2008 Enterprise (SP1, SP2)


Linux x86
no longer : TurboLinux 8.0
but : Turbo Linux 10 (ONLY Chinese and Japanese Locales. No  
English.)


Linux x64 32-bit mode
new : Turbo Linux 10 (ONLY Chinese and Japanese Locales. No  
English.)


From this I can see only problems with
Windows Server 2003, Web Edition and Standard Edition
Windows Server 2008 Datacenter and Web Server
TurboLinux 8.0

Should this only stop us to migrate to jdk 1.6? Personnaly I don't  
think so, now it's the community to decide...


Jacques
PS :
Postgres does not really bring much with JDBC4 drivers (could be : http://www.artima.com/lejava/articles/jdbc_four.html 
)
JDK 1.6 - JDBC4. Support for JDBC4 methods is limited. The  
driver builds, but the majority of new methods are stubbed out. 

http://jdbc.postgresql.org/download.html
I come to it from this discussion 
http://archives.free.net.ph/thread/20090925.160633.e1923a69.fr.html#20090925.160633.e1923a69

A benchmark while at it 
http://benjchristensen.com/2009/02/12/java-jdk-15-vs-16-performance/


From: Jacques Le Roux jacques.le.r...@les7arts.com

Thanks Adrian,

So it's the same concern than 3 years ago, I will check...

Jacques

From: Adrian Crum adri...@hlmksw.com
Running OFBiz on 1.6 is a good idea, because (Sun claims) 1.6  
performs

better than 1.5.

The downside is, there might be servers out there that don't  
have a 1.6
JRE available. I would like to see us move on to 1.6 (especially  
now

that 1.7 is near), but I'm concerned for existing installations.

-Adrian

Jacques Le Roux wrote:

Hi devs,

I don't remember why we still use 1.5. Here is a thread from 2006
http://markmail.org/message/5j5es63hpsh543ct.
Maybe it's time to think anew about it, don't you think so ?

Jacques

















smime.p7s
Description: S/MIME cryptographic signature


[jira] Commented: (OFBIZ-3197) Batch payment issue

2009-11-13 Thread Sumit Pandit (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-3197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12777823#action_12777823
 ] 

Sumit Pandit commented on OFBIZ-3197:
-

Proposed solution - 
Payment Batches are created by assigning of Payments to FinAccount. In batching 
FinAccountTrans record is created and then it is assigned to Payment. So on 
canceling payment batch if FinAccountTrans status set to cancel. And then 
association of Payment to FinAccount break and it will available for another 
batch.  

 Batch payment issue
 ---

 Key: OFBIZ-3197
 URL: https://issues.apache.org/jira/browse/OFBIZ-3197
 Project: OFBiz
  Issue Type: Improvement
  Components: accounting
Reporter: Sumit Pandit
Priority: Minor
 Fix For: SVN trunk


 On canceling a payment batch (payment group), payment group members 
 (payments) should available for any another batch. Currently it is not 
 happen. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (OFBIZ-3197) Batch payment issue

2009-11-13 Thread Sumit Pandit (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-3197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sumit Pandit updated OFBIZ-3197:


Attachment: OFBIZ_3197.patch

Patch is attached for specified functionality.

 Batch payment issue
 ---

 Key: OFBIZ-3197
 URL: https://issues.apache.org/jira/browse/OFBIZ-3197
 Project: OFBiz
  Issue Type: Improvement
  Components: accounting
Reporter: Sumit Pandit
Priority: Minor
 Fix For: SVN trunk

 Attachments: OFBIZ_3197.patch


 On canceling a payment batch (payment group), payment group members 
 (payments) should available for any another batch. Currently it is not 
 happen. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Assigned: (OFBIZ-3197) Batch payment issue

2009-11-13 Thread Ashish Vijaywargiya (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-3197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashish Vijaywargiya reassigned OFBIZ-3197:
--

Assignee: Ashish Vijaywargiya

 Batch payment issue
 ---

 Key: OFBIZ-3197
 URL: https://issues.apache.org/jira/browse/OFBIZ-3197
 Project: OFBiz
  Issue Type: Improvement
  Components: accounting
Reporter: Sumit Pandit
Assignee: Ashish Vijaywargiya
Priority: Minor
 Fix For: SVN trunk

 Attachments: OFBIZ_3197.patch


 On canceling a payment batch (payment group), payment group members 
 (payments) should available for any another batch. Currently it is not 
 happen. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (OFBIZ-3197) Batch payment issue

2009-11-13 Thread Ashish Vijaywargiya (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-3197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashish Vijaywargiya closed OFBIZ-3197.
--

Resolution: Fixed

Thanks Sumit - Done at r836129.

--
Ashish

 Batch payment issue
 ---

 Key: OFBIZ-3197
 URL: https://issues.apache.org/jira/browse/OFBIZ-3197
 Project: OFBiz
  Issue Type: Improvement
  Components: accounting
Reporter: Sumit Pandit
Assignee: Ashish Vijaywargiya
Priority: Minor
 Fix For: SVN trunk

 Attachments: OFBIZ_3197.patch


 On canceling a payment batch (payment group), payment group members 
 (payments) should available for any another batch. Currently it is not 
 happen. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



Re: jdk 1.5 or 1.6

2009-11-13 Thread Ashish Vijaywargiya
+1.

--
Ashish

On Sat, Nov 14, 2009 at 10:02 AM, David E Jones d...@me.com wrote:


 We had to make this decision before with 1.4 - 1.5, and if I remember
 right from 1.3 - 1.4 too.

 Sooner or later we need to deprecate support for 1.5 in order to move on,
 and to more easily be able to update various libraries and such. The 1.5 -
 1.6 transition is a bit of a pain because they did a few changes that were
 not backwards compatible. Because of that it would be particularly nice to
 deprecate support for 1.5 and require 1.6 (or later, as possible/available).

 In any case, our criteria before was to deprecate support for the older
 version of Java as soon as the newer version was widely available. At this
 point I think 1.6 qualifies well for that... unless there are specific
 systems people use that still can't run 1.6 then we should just update that
 requirement.

 -David


Re: jdk 1.5 or 1.6

2009-11-13 Thread Ashish Vijaywargiya
+1

--
Ashish

On Sat, Nov 14, 2009 at 10:14 AM, Tim Ruppert
tim.rupp...@hotwaxmedia.comwrote:

 +1 - I totally agree.  People can always run the release branch if they
 need to stay on 1.5, but the show must go on!

 Cheers,
 Ruppert


Re: svn commit: r831098 - /ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/event/ServiceMultiEventHandler.java (Manual return functionality is broken)

2009-11-13 Thread Jacques Le Roux

Hi Divesh,

Did you open a Jira for that ?

Thanks

Jacques

From: Divesh Dutta divesh.du...@hotwaxmedia.com

Also Adding urls of the image which I described. Please see my comments inline:

Divesh Dutta wrote:

Hello Bilgin and others,

I found that Manual refund functionality is broken due to this commit . Steps 
to reproduce the error:

1) Create a sales order from Order manager application with two or more items.

2) Then approve and Quick ship the entire Order which will complete the order.

3) Then click on Create Return button on Actions Block.

4) You will land on Create new Return Page: Also attaching the screen shot. 
(Screenshot-1)

http://img156.yfrog.com/i/screenshot1jw.png/



5) Click on select all check box and then click on Return Selected items 
button.

6) You will find that page is broken. Also attaching the screen shot for the 
same.  (Screenshot-2)

http://img156.yfrog.com/i/screenshot2kn.png/




After doing research on this I found that reason for this code failure is in createReturnAndItemOrAdjustment simple method in 
OrderReturnServices.xml. This is because in below given code snippet :


   1if-empty field=parameters.returnId
   2  set-service-fields service-name=createReturnHeader map=parameters 
to-map=returnHeaderInMap/
   3  call-service service-name=createReturnHeader 
in-map-name=returnHeaderInMap
   4  result-to-field result-name=returnId field=returnId/
   5  /call-service
   6  check-errors/
   7  set field=parameters.returnId from-field=returnId/
   8  field-to-result field=returnId result-name=returnId/
   9   /if-empty

parameters.returnId field is always empty when this service is called as 
service-multi even though it is set in line #7.

And if I revert your this commit then this functionality is working fine.
So It will be great if you or any one else, give the reason of this commit and also provide fix or alternate way to solve this 
issue.


Thanks
--
Divesh Dutta.


bibr...@apache.org wrote:

Author: bibryam
Date: Thu Oct 29 21:35:49 2009
New Revision: 831098

URL: http://svn.apache.org/viewvc?rev=831098view=rev
Log:
Prevent overriding of service results in a service-multi type events.

Modified:

ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/event/ServiceMultiEventHandler.java

Modified: 
ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/event/ServiceMultiEventHandler.java
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/event/ServiceMultiEventHandler.java?rev=831098r1=831097r2=831098view=diff

==
--- 
ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/event/ServiceMultiEventHandler.java (original)

+++ 
ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/event/ServiceMultiEventHandler.java
 Thu Oct 29 21:35:49 2009
@@ -339,7 +339,7 @@
 if 
(!UtilValidate.isEmpty(result.get(ModelService.SUCCESS_MESSAGE_LIST))) {
 ListString newSuccessMessages = 
UtilGenerics.StringcheckList(result.get(ModelService.SUCCESS_MESSAGE_LIST));

 for (int j = 0; j  newSuccessMessages.size(); j++) {
-String newSuccessMessage = 
(String)newSuccessMessages.get(j);
+String newSuccessMessage = 
newSuccessMessages.get(j);
 if (!successMessages.contains(newSuccessMessage)) {
 successMessages.add(newSuccessMessage);
 }
@@ -355,7 +355,7 @@
 if (resultKey != null  !ModelService.RESPONSE_MESSAGE.equals(resultKey)  
!ModelService.ERROR_MESSAGE.equals(resultKey) 
 !ModelService.ERROR_MESSAGE_LIST.equals(resultKey)  
!ModelService.ERROR_MESSAGE_MAP.equals(resultKey) 
 !ModelService.SUCCESS_MESSAGE.equals(resultKey)  
!ModelService.SUCCESS_MESSAGE_LIST.equals(resultKey)) {

-request.setAttribute(resultKey, resultValue);
+request.setAttribute(resultKey + curSuffix, 
resultValue);
 }
 }
 }












[jira] Created: (OFBIZ-3198) Because of the elevation field in GeoPoint we need a many relationship for (at least) PostalAddress and Facility

2009-11-13 Thread Jacques Le Roux (JIRA)
Because of the elevation field in GeoPoint we need a many relationship for (at 
least) PostalAddress and Facility


 Key: OFBIZ-3198
 URL: https://issues.apache.org/jira/browse/OFBIZ-3198
 Project: OFBiz
  Issue Type: Sub-task
Affects Versions: SVN trunk
Reporter: Jacques Le Roux
Assignee: Jacques Le Roux
Priority: Trivial




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.