Build failed in Jenkins: oodt-trunk #377

[Apache Jenkins Server]

See 

Changes:

[bfoster] - Introduce a CAS-Metadata based renaming interface (CAS-Metadata 
changes)

-
OODT-426

--
[...truncated 4627 lines...]
Mar 27, 2012 6:52:15 AM 
org.springframework.context.support.AbstractApplicationContext 
obtainFreshBeanFactory
INFO: Bean factory for application context 
[org.springframework.context.support.FileSystemXmlApplicationContext@b7b3f9]: 
org.springframework.beans.factory.support.DefaultListableBeanFactory@eaf40c
Mar 27, 2012 6:52:15 AM 
org.springframework.beans.factory.support.DefaultListableBeanFactory 
preInstantiateSingletons
INFO: Pre-instantiating singletons in 
org.springframework.beans.factory.support.DefaultListableBeanFactory@eaf40c: 
defining beans 
[PrintMessageAction,PrintHelloWorldAction,TestSetContextInjectAction]; root of 
factory hierarchy
Mar 27, 2012 6:52:15 AM 
org.springframework.context.support.AbstractApplicationContext prepareRefresh
INFO: Refreshing 
org.springframework.context.support.FileSystemXmlApplicationContext@1fa6d18: 
display name 
[org.springframework.context.support.FileSystemXmlApplicationContext@1fa6d18]; 
startup date [Tue Mar 27 06:52:15 UTC 2012]; root of context hierarchy
Mar 27, 2012 6:52:15 AM 
org.springframework.beans.factory.xml.XmlBeanDefinitionReader 
loadBeanDefinitions
INFO: Loading XML bean definitions from file 
[
Mar 27, 2012 6:52:15 AM 
org.springframework.context.support.AbstractApplicationContext 
obtainFreshBeanFactory
INFO: Bean factory for application context 
[org.springframework.context.support.FileSystemXmlApplicationContext@1fa6d18]: 
org.springframework.beans.factory.support.DefaultListableBeanFactory@1efb4be
Mar 27, 2012 6:52:15 AM 
org.springframework.beans.factory.support.DefaultListableBeanFactory 
preInstantiateSingletons
INFO: Pre-instantiating singletons in 
org.springframework.beans.factory.support.DefaultListableBeanFactory@1efb4be: 
defining beans 
[PrintMessageAction,PrintHelloWorldAction,TestSetContextInjectAction]; root of 
factory hierarchy
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.073 sec
Running org.apache.oodt.cas.cli.TestCmdLineUtility
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.007 sec

Results :

Tests run: 61, Failures: 0, Errors: 0, Skipped: 0

[JENKINS] Recording test results
[INFO] [jar:jar {execution: default-jar}]
[INFO] Building jar: 

[INFO] Preparing javadoc:javadoc
[WARNING] Removing: javadoc from forked lifecycle, to prevent recursive 
invocation.
[INFO] No goals needed for project - skipping
[WARNING] DEPRECATED [aggregate]: since 2.5. Use the goals 
javadoc:aggregate and javadoc:test-aggregate instead.
[INFO] [javadoc:javadoc {execution: attach-javadocs}]
Downloading: 
http://repo1.maven.org/maven2/aspectj/aspectjrt/1.5.3/aspectjrt-1.5.3.pom

Downloading: 
http://repo1.maven.org/maven2/org/codehaus/plexus/plexus-archiver/1.0-alpha-10/plexus-archiver-1.0-alpha-10.pom

Downloading: 
http://repo1.maven.org/maven2/org/codehaus/plexus/plexus-utils/1.3/plexus-utils-1.3.pom

Downloading: 
http://repo1.maven.org/maven2/org/codehaus/plexus/plexus-io/1.0-alpha-2/plexus-io-1.0-alpha-2.pom

Downloading: 
http://repo1.maven.org/maven2/org/apache/maven/shared/file-management/1.1/file-management-1.1.pom

Downloading: 
http://repo1.maven.org/maven2/org/apache/maven/shared/maven-shared-io/1.0/maven-shared-io-1.0.pom

Downloading: 
http://repo1.maven.org/maven2/org/apache/maven/maven-artifact/2.0.2/maven-artifact-2.0.2.pom

Downloading: 
http://repo1.maven.org/maven2/org/apache/maven/maven/2.0.2/maven-2.0.2.pom

Downloading: 
http://repo1.maven.org/maven2/org/apache/maven/maven-artifact-manager/2.0.2/maven-artifact-manager-2.0.2.pom

Downloading: 
http://repo1.maven.org/maven2/org/apache/maven/maven-repository-metadata/2.0.2/maven-repository-metadata-2.0.2.pom

Downloading: 
http://repo1.maven.org/maven2/org/apache/maven/wagon/wagon-provider-api/1.0-alpha-6/wagon-provider-api-1.0-alpha-6.pom

Downloading: 
http://repo1.maven.org/maven2/org/apache/maven/wagon/wagon/1.0-alpha-6/wagon-1.0-alpha-6.pom

Downloading: 
http://repo1.maven.org/maven2/org/apache/maven/shared/maven-shared-io/1.1/maven-shared-io-1.1.pom

Downloading: 
http://repo1.maven.org/maven2/org/codehaus/plexus/plexus-utils/1.4.6/plexus-utils-1.4.6.pom

Downloading: 
http://repo1.maven.org/maven2/org/codehaus/plexus/plexus-active-collections/1.0-beta-2/plexus-active-collections-1.0-beta-2.pom

Downloading: 
http://repo1.maven.org/maven2/org/codehaus/plexus/plexus-container-default/1.0-alpha-22/plexus-container-default-1.0-alpha-22.pom

Downloading: 
http://repo1.maven.org/maven2/org/codehaus/plexus/plexus-containers/1.0-alpha-22/plexus-containers-1.0-alpha-22.pom

Downloading: 
http://repo1.maven.org/maven2/org/apa

Build failed in Jenkins: oodt-trunk » Catalog and Archive Service Generic Multi-valued Metadata Container #377

[Apache Jenkins Server]

See 


Changes:

[bfoster] - Introduce a CAS-Metadata based renaming interface (CAS-Metadata 
changes)

-
OODT-426

--
[INFO] 
[INFO] Building Catalog and Archive Service Generic Multi-valued Metadata 
Container
[INFO]task-segment: [install]
[INFO] 
Downloading: 
http://repo1.maven.org/maven2/org/apache/maven/plugins/maven-surefire-plugin/2.8.1/maven-surefire-plugin-2.8.1.pom

Downloading: 
http://repo1.maven.org/maven2/org/apache/maven/surefire/surefire/2.8.1/surefire-2.8.1.pom

Downloading: 
http://repo1.maven.org/maven2/org/apache/maven/maven-parent/19/maven-parent-19.pom

Downloading: 
http://repo1.maven.org/maven2/org/apache/maven/plugins/maven-surefire-plugin/2.8.1/maven-surefire-plugin-2.8.1.jar

[INFO] [remote-resources:process {execution: default}]
Downloading: 
http://repo1.maven.org/maven2/org/apache/tika/tika-core/0.8/tika-core-0.8.pom

Downloading: 
http://repo1.maven.org/maven2/org/apache/tika/tika-parent/0.8/tika-parent-0.8.pom

Downloading: 
http://repo1.maven.org/maven2/org/apache/tika/tika-core/0.8/tika-core-0.8.jar

[INFO] [resources:resources {execution: default-resources}]
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 1 resource to org/apache/oodt/cas/metadata/util
[INFO] Copying 3 resources
[INFO] [compiler:compile {execution: default-compile}]
[INFO] Compiling 39 source files to 

[INFO] [resources:testResources {execution: default-testResources}]
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 9 resources to org/apache/oodt/cas/metadata
[INFO] Copying 3 resources
[INFO] [compiler:testCompile {execution: default-testCompile}]
[INFO] Compiling 11 source files to 

[INFO] -
[ERROR] COMPILATION ERROR : 
[INFO] -
[ERROR] 
:[19,51]
 cannot find symbol
symbol: class TestCase
public class TestPathUtilsNamingConvention extends TestCase {
[INFO] 1 error
[INFO] -
[JENKINS] Archiving 

 to 
/home/hudson/hudson/jobs/oodt-trunk/modules/org.apache.oodt$cas-metadata/builds/2012-03-27_06-47-09/archive/org.apache.oodt/cas-metadata/0.4-SNAPSHOT/cas-metadata-0.4-SNAPSHOT.pom
[INFO] 
[ERROR] BUILD FAILURE
[INFO] 
[INFO] Compilation failure
:[19,51]
 cannot find symbol
symbol: class TestCase
public class TestPathUtilsNamingConvention extends TestCase {

[INFO] 
[INFO] For more information, run Maven with the -e switch
[INFO] 
[INFO] Total time: 6 minutes 19 seconds
[INFO] Finished at: Tue Mar 27 06:53:58 UTC 2012
[INFO] Final Memory: 80M/251M
[INFO] 

Jenkins build became unstable: oodt-trunk #376

[Apache Jenkins Server]

See 

Re: Review Request: Introduce a CAS-Metadata based renaming interface (CAS-Crawler changes)

[brian Foster]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r//
---

(Updated 2012-03-27 00:47:30.189828)


Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and Thomas 
Bennett.


Changes
---

- Updated unit-tests -- ProductCrawler has a unit-test for each possible path 
that can be taken through handleFile(File) and verifies the appropriate methods 
where called


Summary
---

- Introduced NamingConvention support, which for MetExtractorProductCrawler now 
takes an ID for the NamingConvention to use and AutoDetectProductCrawler has a 
new element  in MimeExtractorRepo
- Also cleaned up handleFile(File)... documented better and is now public and 
returns the IngestResult for what happened when called.


This addresses bug OODT-426.
https://issues.apache.org/jira/browse/OODT-426


Diffs (updated)
-

  trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/ProductCrawler.java 
1305657 
  
trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/MetExtractorProductCrawler.java
 1305657 
  trunk/crawler/pom.xml 1305657 
  
trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/AutoDetectProductCrawler.java
 1305657 
  trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/StdProductCrawler.java 
1305657 
  
trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/typedetection/MetExtractorSpec.java
 1305657 
  
trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/typedetection/MimeExtractorConfigMetKeys.java
 1305657 
  
trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/typedetection/MimeExtractorConfigReader.java
 1305657 
  
trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/typedetection/MimeExtractorRepo.java
 1305657 
  trunk/crawler/src/main/resources/cmd-line-options.xml 1305657 
  trunk/crawler/src/main/resources/crawler-config.xml 1305657 
  trunk/crawler/src/main/resources/examples/mime-extractor-map.xml 1305657 
  trunk/crawler/src/main/resources/naming-beans.xml PRE-CREATION 
  
trunk/crawler/src/test/org/apache/oodt/cas/crawl/StateAwareProductCrawler.java 
PRE-CREATION 
  trunk/crawler/src/test/org/apache/oodt/cas/crawl/TestProductCrawler.java 
PRE-CREATION 
  
trunk/crawler/src/test/org/apache/oodt/cas/crawl/typedetection/TestMimeExtractorConfigReader.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r//diff


Testing (updated)
---

Wrote several unit-tests


Thanks,

brian

Re: Review Request: Introduce a CAS-Metadata based renaming interface (CAS-Crawler changes)

[brian Foster]

> On 2012-03-26 15:50:17, Chris Mattmann wrote:
> > trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/ProductCrawler.java, 
> > line 326
> > 
> >
> > Are all of these @VisibleForTesting coupling our test system too much 
> > with the code? Just wondering...

I just changing the visibility on these methods from private to package 
level... then i notated them with the @VisibleForTesting to then make this 
clear to other developers that the only reason for these methods being package 
level is to make them unit-test-able


> On 2012-03-26 15:50:17, Chris Mattmann wrote:
> > trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/StdProductCrawler.java,
> >  line 71
> > 
> >
> > Should we augment the ProductCrawler super class to declare this 
> > function as an abstract method since all sub class crawlers implement it?

it is... this method does need a @Override above it to make it clear... i'll 
add this


- brian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r//#review6349
---


On 2012-03-25 01:55:32, brian Foster wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r//
> ---
> 
> (Updated 2012-03-25 01:55:32)
> 
> 
> Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and 
> Thomas Bennett.
> 
> 
> Summary
> ---
> 
> - Introduced NamingConvention support, which for MetExtractorProductCrawler 
> now takes an ID for the NamingConvention to use and AutoDetectProductCrawler 
> has a new element  in MimeExtractorRepo
> - Also cleaned up handleFile(File)... documented better and is now public and 
> returns the IngestResult for what happened when called.
> 
> 
> This addresses bug OODT-426.
> https://issues.apache.org/jira/browse/OODT-426
> 
> 
> Diffs
> -
> 
>   trunk/crawler/src/main/resources/naming-beans.xml PRE-CREATION 
>   trunk/crawler/src/test/org/apache/oodt/cas/crawl/TestProductCrawler.java 
> PRE-CREATION 
>   trunk/crawler/src/main/resources/cmd-line-options.xml 1302790 
>   trunk/crawler/src/main/resources/crawler-config.xml 1302790 
>   trunk/crawler/src/main/resources/examples/mime-extractor-map.xml 1302790 
>   
> trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/typedetection/MimeExtractorRepo.java
>  1302790 
>   
> trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/StdProductCrawler.java 
> 1302790 
>   
> trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/typedetection/MimeExtractorConfigMetKeys.java
>  1302790 
>   
> trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/typedetection/MimeExtractorConfigReader.java
>  1302790 
>   trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/ProductCrawler.java 
> 1302790 
>   trunk/crawler/pom.xml 1302790 
>   
> trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/AutoDetectProductCrawler.java
>  1302790 
>   
> trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/MetExtractorProductCrawler.java
>  1302790 
> 
> Diff: https://reviews.apache.org/r//diff
> 
> 
> Testing
> ---
> 
> Still need to unit-test up cas-crawler
> 
> 
> Thanks,
> 
> brian
> 
>

Re: Review Request: Introduce a CAS-Metadata based renaming interface (CAS-Crawler changes)

[Chris Mattmann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r//#review6391
---

Ship it!


LGTM!

- Chris


On 2012-03-27 00:47:30, brian Foster wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r//
> ---
> 
> (Updated 2012-03-27 00:47:30)
> 
> 
> Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and 
> Thomas Bennett.
> 
> 
> Summary
> ---
> 
> - Introduced NamingConvention support, which for MetExtractorProductCrawler 
> now takes an ID for the NamingConvention to use and AutoDetectProductCrawler 
> has a new element  in MimeExtractorRepo
> - Also cleaned up handleFile(File)... documented better and is now public and 
> returns the IngestResult for what happened when called.
> 
> 
> This addresses bug OODT-426.
> https://issues.apache.org/jira/browse/OODT-426
> 
> 
> Diffs
> -
> 
>   trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/ProductCrawler.java 
> 1305657 
>   
> trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/MetExtractorProductCrawler.java
>  1305657 
>   trunk/crawler/pom.xml 1305657 
>   
> trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/AutoDetectProductCrawler.java
>  1305657 
>   
> trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/StdProductCrawler.java 
> 1305657 
>   
> trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/typedetection/MetExtractorSpec.java
>  1305657 
>   
> trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/typedetection/MimeExtractorConfigMetKeys.java
>  1305657 
>   
> trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/typedetection/MimeExtractorConfigReader.java
>  1305657 
>   
> trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/typedetection/MimeExtractorRepo.java
>  1305657 
>   trunk/crawler/src/main/resources/cmd-line-options.xml 1305657 
>   trunk/crawler/src/main/resources/crawler-config.xml 1305657 
>   trunk/crawler/src/main/resources/examples/mime-extractor-map.xml 1305657 
>   trunk/crawler/src/main/resources/naming-beans.xml PRE-CREATION 
>   
> trunk/crawler/src/test/org/apache/oodt/cas/crawl/StateAwareProductCrawler.java
>  PRE-CREATION 
>   trunk/crawler/src/test/org/apache/oodt/cas/crawl/TestProductCrawler.java 
> PRE-CREATION 
>   
> trunk/crawler/src/test/org/apache/oodt/cas/crawl/typedetection/TestMimeExtractorConfigReader.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r//diff
> 
> 
> Testing
> ---
> 
> Wrote several unit-tests
> 
> 
> Thanks,
> 
> brian
> 
>

Re: Review Request: filemgr query throws NPE when sorting by key with possibly empty values

[brian Foster]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4458/#review6368
---



trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/structs/query/QueryResultComparator.java


i don't think this case is ever true... this checks that the 2 references 
are equal (i.e. pointing to the same object)... perhaps you meant: 
m1.equals(m2)... however if m1 is null, then NullPointerException will be 
thrown here



trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/structs/query/TestQueryResultComparator.java


nice test... thanks!


- brian


On 2012-03-23 21:19:16, Ricky Nguyen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4458/
> ---
> 
> (Updated 2012-03-23 21:19:16)
> 
> 
> Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, Sheryl 
> John, and Thomas Bennett.
> 
> 
> Summary
> ---
> 
> putting nulls last
> 
> 
> This addresses bug OODT-429.
> https://issues.apache.org/jira/browse/OODT-429
> 
> 
> Diffs
> -
> 
>   
> trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/structs/query/QueryResultComparator.java
>  1303205 
>   
> trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/structs/query/TestQueryResultComparator.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/4458/diff
> 
> 
> Testing
> ---
> 
> wrote unit test
> 
> 
> Thanks,
> 
> Ricky
> 
>

Re: Review Request: CrawlerBeansPropHandler doesn't set list properties for Spring PropertyOverrideConfigurer correctly

[brian Foster]

> On 2012-03-26 14:22:31, Chris Mattmann wrote:
> > trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/cli/option/handler/CrawlerBeansPropHandler.java,
> >  line 60
> > 
> >
> > Agree with Tom here, do we need a check on if getValues() == null too?

i think what i'll do here is check if it is empty and then throw an Exception 
explicitly so it is clear that a no arg option it wrong here... boolean options 
should have a static arg specifying either true or false value.


- brian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4454/#review6347
---


On 2012-03-22 21:27:55, brian Foster wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4454/
> ---
> 
> (Updated 2012-03-22 21:27:55)
> 
> 
> Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and 
> Thomas Bennett.
> 
> 
> Summary
> ---
> 
> It currently was setting lists keys to: value1,value2,value3,...
> 
> This patch will instead change it to:
> key[0] = value1
> key[1] = value2
> 
> 
> This addresses bug OODT-428.
> https://issues.apache.org/jira/browse/OODT-428
> 
> 
> Diffs
> -
> 
>   
> trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/cli/option/handler/CrawlerBeansPropHandler.java
>  1304041 
> 
> Diff: https://reviews.apache.org/r/4454/diff
> 
> 
> Testing
> ---
> 
> still need a unit-test for this... will write when i get the time
> 
> 
> Thanks,
> 
> brian
> 
>

Re: Review Request: CrawlerBeansPropHandler doesn't set list properties for Spring PropertyOverrideConfigurer correctly

[brian Foster]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4454/
---

(Updated 2012-03-26 20:55:22.461160)


Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and Thomas 
Bennett.


Changes
---

- For case optionInstance.getValues().isEmpty() now throws RuntimeException
- Added Unit-tests


Summary
---

It currently was setting lists keys to: value1,value2,value3,...

This patch will instead change it to:
key[0] = value1
key[1] = value2


This addresses bug OODT-428.
https://issues.apache.org/jira/browse/OODT-428


Diffs (updated)
-

  
trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/cli/option/handler/CrawlerBeansPropHandler.java
 1304041 
  
trunk/crawler/src/test/org/apache/oodt/cas/crawl/cli/option/handler/TestCrawlerBeansPropHandler.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/4454/diff


Testing (updated)
---

Wrote unit-test


Thanks,

brian

Re: Review Request: CrawlerBeansPropHandler doesn't set list properties for Spring PropertyOverrideConfigurer correctly

[Chris Mattmann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4454/#review6386
---

Ship it!


LGTM.

- Chris


On 2012-03-26 20:55:22, brian Foster wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4454/
> ---
> 
> (Updated 2012-03-26 20:55:22)
> 
> 
> Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and 
> Thomas Bennett.
> 
> 
> Summary
> ---
> 
> It currently was setting lists keys to: value1,value2,value3,...
> 
> This patch will instead change it to:
> key[0] = value1
> key[1] = value2
> 
> 
> This addresses bug OODT-428.
> https://issues.apache.org/jira/browse/OODT-428
> 
> 
> Diffs
> -
> 
>   
> trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/cli/option/handler/CrawlerBeansPropHandler.java
>  1304041 
>   
> trunk/crawler/src/test/org/apache/oodt/cas/crawl/cli/option/handler/TestCrawlerBeansPropHandler.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/4454/diff
> 
> 
> Testing
> ---
> 
> Wrote unit-test
> 
> 
> Thanks,
> 
> brian
> 
>

Re: Review Request: CrawlerBeansPropHandler doesn't set list properties for Spring PropertyOverrideConfigurer correctly

[Chris Mattmann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4454/#review6380
---

Ship it!


Sounds good LGTM.

- Chris


On 2012-03-26 20:55:22, brian Foster wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4454/
> ---
> 
> (Updated 2012-03-26 20:55:22)
> 
> 
> Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and 
> Thomas Bennett.
> 
> 
> Summary
> ---
> 
> It currently was setting lists keys to: value1,value2,value3,...
> 
> This patch will instead change it to:
> key[0] = value1
> key[1] = value2
> 
> 
> This addresses bug OODT-428.
> https://issues.apache.org/jira/browse/OODT-428
> 
> 
> Diffs
> -
> 
>   
> trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/cli/option/handler/CrawlerBeansPropHandler.java
>  1304041 
>   
> trunk/crawler/src/test/org/apache/oodt/cas/crawl/cli/option/handler/TestCrawlerBeansPropHandler.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/4454/diff
> 
> 
> Testing
> ---
> 
> Wrote unit-test
> 
> 
> Thanks,
> 
> brian
> 
>

Cleanup ReviewBoard...

[Brian Foster]

hey guys,If you have ReviewBoard requests which are for JIRA issues that have been resolved can you mark your reviews in ReviewBoard as Close -> Submitted... the ReviewBoard dashboard is starting to get cluttered and hard to figure out which ones still need attention.thanks!-brian

Re: svn commit: r1304212 - /oodt/trunk/crawler/src/main/resources/cmd-line-options.xml

[Mattmann, Chris A (388J)]

No worries, bud you are pw0oning it! 

Keep rockin' on...

Cheers,
Chris

On Mar 26, 2012, at 11:40 AM, Thomas Bennett wrote:

> Hey Chris,
> 
> Ooops. Thanks for the pointers.
> 
> Hopefully I'll iron out all the noob mistakes soon enough! I sensed I was 
> missing something hence my email reply with the issue summary.
> 
>> Thanks for this. If this was tied to a JIRA issue, it's always a good 
>> practice to ref the JIRA issue
>> in your commit msg, e.g., OODT-xxx: MoveMetadataToFailureDir should read 
>> as the message.
>> Then in JIRA, we can look up all associated SVN commits, via the Subversion 
>> Commits pane.
> 
> Yes I've committed code a few times and closed the issue, only then realising 
> my mistake. I'll put a sticky reminder on my monitor! 
> 
>> No biggie, just wanted to pass along. Also, if you haven't had a chance to 
>> yet, please remember
>> to update CHANGES.txt with an entry for this fix.
> 
> Will do.
> 
> Cheers,
> Tom


++
Chris Mattmann, Ph.D.
Senior Computer Scientist
NASA Jet Propulsion Laboratory Pasadena, CA 91109 USA
Office: 171-266B, Mailstop: 171-246
Email: chris.a.mattm...@nasa.gov
WWW:   http://sunset.usc.edu/~mattmann/
++
Adjunct Assistant Professor, Computer Science Department
University of Southern California, Los Angeles, CA 90089 USA
++

Re: crawler actionIds

[Mattmann, Chris A (388J)]

Hi Tom,

Yep that was my question but it looks like you two had this one under control, 
so no need for my help! Great work!

Cheers,
Chris

On Mar 26, 2012, at 12:32 AM, Thomas Bennett wrote:

> Hi Chris,
> 
> I'm wondering if the beans are named DeleteDataFile and DeleteMetadataFile:
>> have you checked the action-beans.xml file?
>> 
> 
> If I understand you're question correctly, yes, the beans are
> named DeleteDataFile and DeleteMetadataFile in the action-beans.xml.
> 
> Since there have been a few issues that have been resolved relating to the
> crawler cli (thanks to Brian's efforts), here's a quick summary:
> 
> * MoveMetadataToFailureDir renamed MoveMetadataFileToFailureDir. see JIRA
> issue OODT-412 
> * Specifying multiple actionIds on the command line. Brian has posted the
> fix (pending review) - see JIRA issue
> OODT-428
> .
> * Executing boolean beans on the command line. Brian has supplied a fix
> (which I committed). See JIRA issue
> OODT-430
> 
> Cheers,
> Tom


++
Chris Mattmann, Ph.D.
Senior Computer Scientist
NASA Jet Propulsion Laboratory Pasadena, CA 91109 USA
Office: 171-266B, Mailstop: 171-246
Email: chris.a.mattm...@nasa.gov
WWW:   http://sunset.usc.edu/~mattmann/
++
Adjunct Assistant Professor, Computer Science Department
University of Southern California, Los Angeles, CA 90089 USA
++

Re: [jira] [Commented] (OODT-430) CrawlerBeansPropHandler throws IndexOutOfBoundsException when parsing boolean command line options like noRecur

[Mattmann, Chris A (388J)]

Great work guys!

Cheers,
Chris

On Mar 23, 2012, at 11:59 AM, Thomas Bennett wrote:

> Hey Brian,
> 
> Thanks for the help sorting this out.
> 
> I'm happy to take over writing the unit tests ;-) no problem. 
> 
> I'll check out some of your other unit tests and let you know if I get stuck.
> 
> Cheers,
> Tom
> 
> Sent from my iPhone
> 
> On 23 Mar 2012, at 7:23 PM, "Brian Foster (Commented) (JIRA)" 
>  wrote:
> 
>> 
>>   [ 
>> https://issues.apache.org/jira/browse/OODT-430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236801#comment-13236801
>>  ] 
>> 
>> Brian Foster commented on OODT-430:
>> ---
>> 
>> i just need to add a bunch of unit-tests for crawler cli usages like i did 
>> for filegr, wmgr, and resmgr... by the time i got to the crawler i was so 
>> sick of writing cas-cli unit-tests i just said screw it and check it in... 
>> lol... glad you are using it though and helping smoke out the bugs!... these 
>> unit-tests are on my list of things to do though!
>> 
>>> CrawlerBeansPropHandler throws IndexOutOfBoundsException when parsing 
>>> boolean command line options like noRecur
>>> ---
>>> 
>>>   Key: OODT-430
>>>   URL: https://issues.apache.org/jira/browse/OODT-430
>>>   Project: OODT
>>>Issue Type: Bug
>>>Components: crawler
>>>  Affects Versions: 0.4
>>>  Reporter: Thomas Bennett
>>>  Priority: Minor
>>>Labels: patch
>>>   Fix For: 0.4
>>> 
>>> 
>>> Executing the crawler with --noRecur command line option throws the 
>>> following exception:
>>> Executed command:
>>> java ... --operation --launchAutoCrawler... --productPath /var/kat/data.. 
>>> --noRecur
>>> Output:
>>> Setting property 'StdProductCrawler.filemgrUrl'
>>> Setting property 'MetExtractorProductCrawler.filemgrUrl'
>>> Setting property 'AutoDetectProductCrawler.filemgrUrl'
>>> Setting property 'StdProductCrawler.clientTransferer'
>>> Setting property 'MetExtractorProductCrawler.clientTransferer'
>>> Setting property 'AutoDetectProductCrawler.clientTransferer'
>>> Setting property 'AutoDetectProductCrawler.mimeExtractorRepo'
>>> Setting property 'MoveMetadataFileToFailureDir.toDir'
>>> Setting property 'MovePushpullMetFileToFailureDir.toDir'
>>> Setting property 'MoveDataFileToFailureDir.toDir'
>>> Exception in thread "main" java.lang.RuntimeException: 
>>> java.lang.IndexOutOfBoundsException: Index: 0, Size: 0
>>>   at org.apache.oodt.cas.cli.CmdLineUtility.run(CmdLineUtility.java:191)
>>>   at org.apache.oodt.cas.crawl.CrawlerLauncher.main(CrawlerLauncher.java:36)
>>> Caused by: java.lang.IndexOutOfBoundsException: Index: 0, Size: 0
>>>   at java.util.ArrayList.rangeCheck(ArrayList.java:571)
>>>   at java.util.ArrayList.get(ArrayList.java:349)
>>>   at 
>>> org.apache.oodt.cas.crawl.cli.option.handler.CrawlerBeansPropHandler.handleOption(CrawlerBeansPropHandler.java:56)
>>>   at 
>>> org.apache.oodt.cas.cli.util.CmdLineUtils.handle(CmdLineUtils.java:1034)
>>>   at org.apache.oodt.cas.cli.CmdLineUtility.handle(CmdLineUtility.java:383)
>>>   at org.apache.oodt.cas.cli.CmdLineUtility.execute(CmdLineUtility.java:328)
>>>   at org.apache.oodt.cas.cli.CmdLineUtility.run(CmdLineUtility.java:187)
>>>   ... 1 more
>> 
>> --
>> This message is automatically generated by JIRA.
>> If you think it was sent incorrectly, please contact your JIRA 
>> administrators: 
>> https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
>> For more information on JIRA, see: http://www.atlassian.com/software/jira
>> 
>> 


++
Chris Mattmann, Ph.D.
Senior Computer Scientist
NASA Jet Propulsion Laboratory Pasadena, CA 91109 USA
Office: 171-266B, Mailstop: 171-246
Email: chris.a.mattm...@nasa.gov
WWW:   http://sunset.usc.edu/~mattmann/
++
Adjunct Assistant Professor, Computer Science Department
University of Southern California, Los Angeles, CA 90089 USA
++

Re: Review Request: filemgr query throws "String index out of range: -1" when some products have undefined metadata values

[brian Foster]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4451/#review6325
---

Ship it!


LGTM

- brian


On 2012-03-23 21:02:03, Ricky Nguyen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4451/
> ---
> 
> (Updated 2012-03-23 21:02:03)
> 
> 
> Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, Sheryl 
> John, and Thomas Bennett.
> 
> 
> Summary
> ---
> 
> Cleaned up metadata to string methods of QueryResult. If metadata was empty, 
> it was trying to delete a trailing comma that doesn't exist.
> 
> 
> This addresses bug OODT-427.
> https://issues.apache.org/jira/browse/OODT-427
> 
> 
> Diffs
> -
> 
>   
> trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/structs/query/QueryResult.java
>  1303205 
>   
> trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/cli/action/TestSqlQueryCliAction.java
>  1303205 
>   
> trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/structs/query/TestQueryResult.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/4451/diff
> 
> 
> Testing
> ---
> 
> Added unit test to check for empty metadata.
> 
> Changed existing unit test to account for implementation-dependent ordering 
> of keys.
> 
> 
> Thanks,
> 
> Ricky
> 
>

Re: Review Request: filemgr query throws NPE when sorting by key with possibly empty values

[Ricky Nguyen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4458/
---

(Updated 2012-03-23 21:19:16.059506)


Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, Sheryl 
John, and Thomas Bennett.


Changes
---

test with multiple nulls. since order of null items is indeterminate, take 
sublist of null items, then test size and test contains.


Summary
---

putting nulls last


This addresses bug OODT-429.
https://issues.apache.org/jira/browse/OODT-429


Diffs (updated)
-

  
trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/structs/query/QueryResultComparator.java
 1303205 
  
trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/structs/query/TestQueryResultComparator.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/4458/diff


Testing
---

wrote unit test


Thanks,

Ricky

Re: svn commit: r1303182 - in /oodt/trunk/opendapps/src/main/java/org/apache/oodt/opendapps: config/ extractors/ util/

[Mattmann, Chris A (388J)]

Thanks Luca!

Cheers,
Chris

On Mar 23, 2012, at 3:29 AM, Cinquini, Luca (3880) wrote:

> Hi Chris,
>   
> On Mar 21, 2012, at 4:31 PM, Mattmann, Chris A (388J) wrote:
> 
>> Hi Luca,
>> 
>> On Mar 21, 2012, at 12:34 AM, Cinquini, Luca (3880) wrote:
>> 
>>> Hey Chris,
>>>  thanks for checking this out!
>> 
>> Anytime! 
>> 
>>> 
>>> Are you referring to the following line:
>>> 
 // 
 http://cmds-gis.jpl.nasa.gov/Export/NetViewer.asp?Height=1024&Width=1280&BrowseImage=Aqua/MODIS
  MHchla|application/gis|NetViewer
>> 
>> +1, yep that one.
>> 
>>> 
>>> That was meant to be an example of the kind of URLs that are checked by the 
>>> ProfileChecker there are other examples of XML elements, all commented 
>>> out, to help users understand what the checker does. I can remove them, or 
>>> maybe better preface them with // example:. ?
>> 
>> I think we should have example stuff like this on the OODT wiki, rather than 
>> in the code. It's a personal preference, but
>> the less commented lines I have to look at, the happier I am :) I also think 
>> it helps developers that look at the software
>> and extend it to not see that type of documentation baked into comments, but 
>> provided easily as part of the wiki. 


++
Chris Mattmann, Ph.D.
Senior Computer Scientist
NASA Jet Propulsion Laboratory Pasadena, CA 91109 USA
Office: 171-266B, Mailstop: 171-246
Email: chris.a.mattm...@nasa.gov
WWW:   http://sunset.usc.edu/~mattmann/
++
Adjunct Assistant Professor, Computer Science Department
University of Southern California, Los Angeles, CA 90089 USA
++

Re: svn commit: r1302489 - in /oodt/trunk: CHANGES.txt filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/DataSourceCatalog.java filemgr/src/test/org/apache/oodt/cas/filemgr/catalog/TestDataSou

[Mattmann, Chris A (388J)]

Hey Ricky,

+1, sounds fine and thanks for fixing them!

Cheers,
Chris

On Mar 23, 2012, at 3:07 PM, Nguyen, Ricky wrote:

> filed subtask OODT-431 under OODT-410.
> simple fix, didn't think i needed review board since all discussion happened 
> for OODT-410 already.
> committed and seems like jenkins build succeeds.
> 
> On Mar 22, 2012, at 8:13 AM, Ramirez, Paul M (388J) wrote:
> 
>> Hey Chris,
>> 
>> Yep, you're right so I'll look into this further. I know that commit broke 
>> the build as Jenkins keeps telling the list. I wonder if the bug was there 
>> before. If I recall you just expanded the unit test. Anyhow when I have more 
>> time I'll try to track this down if someone doesn't get to it first. 
>> Essentially, the unit test is failing right now.
>> 
>> --Paul
>> 
>> On Mar 21, 2012, at 1:18 PM, Mattmann, Chris A (388J) wrote:
>> 
>>> Hi Paul,
>>> 
>>> On Mar 21, 2012, at 3:41 PM, Ramirez, Paul M (388J) wrote:
>>> 
 Hey Guys,
 
 This commit broke the unit test 
 (org.apache.oodt.cas.filemgr.catalog.TestMappedDataSourceCatalog) with the 
 addition of:
 
 assertEquals("ShouldBeFirstForPage.txt", 
 ((Product)myCat.getFirstPage(type).getPageProducts().get(0)).getProductName());
>>> 
>>> Hmmm, that commit was from me. Read on below.
>>> 
 
 The data source catalog is sorted by product id so this test does not 
 succeed (since 20 products were added before it) as it would with the 
 lucene catalog which is naturally sorted by CAS.ProductReceivedTime. I can 
 fix the test to look at the second page but wanted to make sure the intent 
 was captured. Also this is sort of an oddity with our catalogs having one 
 set sorted by default with product id and the other with time.
 
>>> 
>>> Sorting in the DataSourceCatalog by product ID should be equivalent to 
>>> sorting in the Lucene Catalog by ProductReceivedTime, right?
>>> 
>>> Cheers,
>>> Chris
>>> 
>>> ++
>>> Chris Mattmann, Ph.D.
>>> Senior Computer Scientist
>>> NASA Jet Propulsion Laboratory Pasadena, CA 91109 USA
>>> Office: 171-266B, Mailstop: 171-246
>>> Email: chris.a.mattm...@nasa.gov
>>> WWW:   http://sunset.usc.edu/~mattmann/
>>> ++
>>> Adjunct Assistant Professor, Computer Science Department
>>> University of Southern California, Los Angeles, CA 90089 USA
>>> ++
>>> 
>> 
> 
> 
> 
> 
> -
> CONFIDENTIALITY NOTICE: This e-mail message, including any attachments, 
> is for the sole use of the intended recipient(s) and may contain confidential
> or legally privileged information. Any unauthorized review, use, disclosure
> or distribution is prohibited. If you are not the intended recipient, please
> contact the sender by reply e-mail and destroy all copies of this original 
> message.  
> 
> -
> 


++
Chris Mattmann, Ph.D.
Senior Computer Scientist
NASA Jet Propulsion Laboratory Pasadena, CA 91109 USA
Office: 171-266B, Mailstop: 171-246
Email: chris.a.mattm...@nasa.gov
WWW:   http://sunset.usc.edu/~mattmann/
++
Adjunct Assistant Professor, Computer Science Department
University of Southern California, Los Angeles, CA 90089 USA
++

Re: Review Request: filemgr query throws "String index out of range: -1" when some products have undefined metadata values

[Ricky Nguyen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4451/
---

(Updated 2012-03-23 21:02:03.638390)


Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, Sheryl 
John, and Thomas Bennett.


Changes
---

1) updated tests
2) added QueryResult.equals() (eclipse auto generated)


Summary
---

Cleaned up metadata to string methods of QueryResult. If metadata was empty, it 
was trying to delete a trailing comma that doesn't exist.


This addresses bug OODT-427.
https://issues.apache.org/jira/browse/OODT-427


Diffs (updated)
-

  
trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/structs/query/QueryResult.java
 1303205 
  
trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/cli/action/TestSqlQueryCliAction.java
 1303205 
  
trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/structs/query/TestQueryResult.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/4451/diff


Testing
---

Added unit test to check for empty metadata.

Changed existing unit test to account for implementation-dependent ordering of 
keys.


Thanks,

Ricky

Re: Review Request: filemgr query throws "String index out of range: -1" when some products have undefined metadata values

[Ricky Nguyen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4451/#review6310
---



trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/cli/action/TestSqlQueryCliAction.java


multi-value met is comma-separated too, so I removed expected values and 
test for remaining delimiter.



trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/structs/query/TestQueryResult.java


multi-value met is comma-separated too, so I removed expected values and 
test for remaining delimiter.



trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/structs/query/TestQueryResult.java


here is the test bfoster suggested


- Ricky


On 2012-03-23 21:02:03, Ricky Nguyen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4451/
> ---
> 
> (Updated 2012-03-23 21:02:03)
> 
> 
> Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, Sheryl 
> John, and Thomas Bennett.
> 
> 
> Summary
> ---
> 
> Cleaned up metadata to string methods of QueryResult. If metadata was empty, 
> it was trying to delete a trailing comma that doesn't exist.
> 
> 
> This addresses bug OODT-427.
> https://issues.apache.org/jira/browse/OODT-427
> 
> 
> Diffs
> -
> 
>   
> trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/structs/query/QueryResult.java
>  1303205 
>   
> trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/cli/action/TestSqlQueryCliAction.java
>  1303205 
>   
> trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/structs/query/TestQueryResult.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/4451/diff
> 
> 
> Testing
> ---
> 
> Added unit test to check for empty metadata.
> 
> Changed existing unit test to account for implementation-dependent ordering 
> of keys.
> 
> 
> Thanks,
> 
> Ricky
> 
>

Jenkins build is back to stable : oodt-trunk #374

[Apache Jenkins Server]

See 

Re: svn commit: r1304212 - /oodt/trunk/crawler/src/main/resources/cmd-line-options.xml

[Thomas Bennett]

Hey Chris,

Ooops. Thanks for the pointers.

Hopefully I'll iron out all the noob mistakes soon enough! I sensed I was 
missing something hence my email reply with the issue summary.

> Thanks for this. If this was tied to a JIRA issue, it's always a good 
> practice to ref the JIRA issue
> in your commit msg, e.g., OODT-xxx: MoveMetadataToFailureDir should read 
> as the message.
> Then in JIRA, we can look up all associated SVN commits, via the Subversion 
> Commits pane.

Yes I've committed code a few times and closed the issue, only then realising 
my mistake. I'll put a sticky reminder on my monitor! 

> No biggie, just wanted to pass along. Also, if you haven't had a chance to 
> yet, please remember
> to update CHANGES.txt with an entry for this fix.

Will do.

Cheers,
Tom

Re: Review Request: CrawlerBeansPropHandler throws IndexOutOfBoundsException when parsing boolean command line options

[brian Foster]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4465/#review6292
---


Also... when listing the Bugs for the review... i noticed you put the whole web 
link... you just have to put OODT-430 and it will automatically link for you

- brian


On 2012-03-23 09:47:04, Thomas Bennett wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4465/
> ---
> 
> (Updated 2012-03-23 09:47:04)
> 
> 
> Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, and 
> Sheryl John.
> 
> 
> Summary
> ---
> 
> As per Brian's suggestion,  I needed to add 
> 
>   
>   
>  
>   
>   true
>   
>   
> 
> To all boolean type beans in the crawler cmd-line-options.xml file.
> 
> So the following beans have been updated for the crawler: noRecur, 
> crawlForDirs, skipIngest, ignoreInvalidAddresses
> 
> 
> This addresses bug https://issues.apache.org/jira/browse/OODT-430.
> 
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/OODT-430
> 
> 
> Diffs
> -
> 
>   trunk/crawler/src/main/resources/cmd-line-options.xml 1304212 
> 
> Diff: https://reviews.apache.org/r/4465/diff
> 
> 
> Testing
> ---
> 
> I've tested executing with  --noRecur, --crawlForDirs, --skipIngest, 
> --ignoreInvalidAddresses
> 
> 
> Thanks,
> 
> Thomas
> 
>

Re: Review Request: CrawlerBeansPropHandler throws IndexOutOfBoundsException when parsing boolean command line options

[brian Foster]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4465/#review6291
---

Ship it!


LGTM... thanks Tom!

- brian


On 2012-03-23 09:47:04, Thomas Bennett wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4465/
> ---
> 
> (Updated 2012-03-23 09:47:04)
> 
> 
> Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, and 
> Sheryl John.
> 
> 
> Summary
> ---
> 
> As per Brian's suggestion,  I needed to add 
> 
>   
>   
>  
>   
>   true
>   
>   
> 
> To all boolean type beans in the crawler cmd-line-options.xml file.
> 
> So the following beans have been updated for the crawler: noRecur, 
> crawlForDirs, skipIngest, ignoreInvalidAddresses
> 
> 
> This addresses bug https://issues.apache.org/jira/browse/OODT-430.
> 
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/OODT-430
> 
> 
> Diffs
> -
> 
>   trunk/crawler/src/main/resources/cmd-line-options.xml 1304212 
> 
> Diff: https://reviews.apache.org/r/4465/diff
> 
> 
> Testing
> ---
> 
> I've tested executing with  --noRecur, --crawlForDirs, --skipIngest, 
> --ignoreInvalidAddresses
> 
> 
> Thanks,
> 
> Thomas
> 
>

Re: Review Request: filemgr query throws NPE when sorting by key with possibly empty values

[brian Foster]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4458/#review6282
---


Great patch! Couple comments


trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/structs/query/QueryResultComparator.java


Should handle case where both are null... will produce faster sorting time 
in cases where there are several nulls... something along the lines of:

if (m1 == null) {
 If (m2 == null) {
return 0;
  }
  return 1;
}
if (m2 == null) {
  return -1;
}



trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/structs/query/TestQueryResultComparator.java


Maybe add test case with multiple nulls?


- brian


On 2012-03-23 00:10:25, Ricky Nguyen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4458/
> ---
> 
> (Updated 2012-03-23 00:10:25)
> 
> 
> Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, Sheryl 
> John, and Thomas Bennett.
> 
> 
> Summary
> ---
> 
> putting nulls last
> 
> 
> This addresses bug OODT-429.
> https://issues.apache.org/jira/browse/OODT-429
> 
> 
> Diffs
> -
> 
>   
> trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/structs/query/QueryResultComparator.java
>  1303205 
>   
> trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/structs/query/TestQueryResultComparator.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/4458/diff
> 
> 
> Testing
> ---
> 
> wrote unit test
> 
> 
> Thanks,
> 
> Ricky
> 
>

Re: Review Request: Introduce a CAS-Metadata based renaming interface (CAS-Crawler changes)

[brian Foster]

> On 2012-03-22 07:15:57, Chris Mattmann wrote:
> > trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/typedetection/MimeExtractorConfigReader.java,
> >  line 90
> > 
> >
> > does this make it so that Exception is never thrown and that this the 
> > default?

This just allows you to specify a default... See other comment about exception


- brian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r//#review6214
---


On 2012-03-22 06:09:52, brian Foster wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r//
> ---
> 
> (Updated 2012-03-22 06:09:52)
> 
> 
> Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and 
> Thomas Bennett.
> 
> 
> Summary
> ---
> 
> - Introduced NamingConvention support, which for MetExtractorProductCrawler 
> now takes an ID for the NamingConvention to use and AutoDetectProductCrawler 
> has a new element  in MimeExtractorRepo
> - Also cleaned up handleFile(File)... documented better and is now public and 
> returns the IngestResult for what happened when called.
> 
> 
> This addresses bug OODT-426.
> https://issues.apache.org/jira/browse/OODT-426
> 
> 
> Diffs
> -
> 
>   
> trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/AutoDetectProductCrawler.java
>  1302790 
>   
> trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/MetExtractorProductCrawler.java
>  1302790 
>   trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/ProductCrawler.java 
> 1302790 
>   
> trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/StdProductCrawler.java 
> 1302790 
>   
> trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/typedetection/MimeExtractorConfigMetKeys.java
>  1302790 
>   
> trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/typedetection/MimeExtractorConfigReader.java
>  1302790 
>   
> trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/typedetection/MimeExtractorRepo.java
>  1302790 
>   trunk/crawler/src/main/resources/cmd-line-options.xml 1302790 
>   trunk/crawler/src/main/resources/crawler-config.xml 1302790 
>   trunk/crawler/src/main/resources/examples/mime-extractor-map.xml 1302790 
>   trunk/crawler/src/main/resources/naming-beans.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r//diff
> 
> 
> Testing
> ---
> 
> Still need to unit-test up cas-crawler
> 
> 
> Thanks,
> 
> brian
> 
>

Re: Review Request: Introduce a CAS-Metadata based renaming interface (CAS-Crawler changes)

[brian Foster]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r//#review6280
---



trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/MetExtractorProductCrawler.java


Nope, it's backwards compatible... This exception is only thrown if you 
specify a naming convention ID which does not exist... If you don't specify the 
ID... which is what the peeps don't specify... Then the code will never reach 
this IF statement... The IF statement it is contained in will be false


- brian


On 2012-03-22 06:09:52, brian Foster wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r//
> ---
> 
> (Updated 2012-03-22 06:09:52)
> 
> 
> Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and 
> Thomas Bennett.
> 
> 
> Summary
> ---
> 
> - Introduced NamingConvention support, which for MetExtractorProductCrawler 
> now takes an ID for the NamingConvention to use and AutoDetectProductCrawler 
> has a new element  in MimeExtractorRepo
> - Also cleaned up handleFile(File)... documented better and is now public and 
> returns the IngestResult for what happened when called.
> 
> 
> This addresses bug OODT-426.
> https://issues.apache.org/jira/browse/OODT-426
> 
> 
> Diffs
> -
> 
>   
> trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/AutoDetectProductCrawler.java
>  1302790 
>   
> trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/MetExtractorProductCrawler.java
>  1302790 
>   trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/ProductCrawler.java 
> 1302790 
>   
> trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/StdProductCrawler.java 
> 1302790 
>   
> trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/typedetection/MimeExtractorConfigMetKeys.java
>  1302790 
>   
> trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/typedetection/MimeExtractorConfigReader.java
>  1302790 
>   
> trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/typedetection/MimeExtractorRepo.java
>  1302790 
>   trunk/crawler/src/main/resources/cmd-line-options.xml 1302790 
>   trunk/crawler/src/main/resources/crawler-config.xml 1302790 
>   trunk/crawler/src/main/resources/examples/mime-extractor-map.xml 1302790 
>   trunk/crawler/src/main/resources/naming-beans.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r//diff
> 
> 
> Testing
> ---
> 
> Still need to unit-test up cas-crawler
> 
> 
> Thanks,
> 
> brian
> 
>

Re: Review Request: Introduce a CAS-Metadata based renaming interface (CAS-Crawler changes)

[Chris Mattmann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r//#review6349
---

Ship it!


My comments are pretty minor, but check em' out. LGTM.


trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/ProductCrawler.java


Are all of these @VisibleForTesting coupling our test system too much with 
the code? Just wondering...



trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/StdProductCrawler.java


Should we augment the ProductCrawler super class to declare this function 
as an abstract method since all sub class crawlers implement it?


- Chris


On 2012-03-25 01:55:32, brian Foster wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r//
> ---
> 
> (Updated 2012-03-25 01:55:32)
> 
> 
> Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and 
> Thomas Bennett.
> 
> 
> Summary
> ---
> 
> - Introduced NamingConvention support, which for MetExtractorProductCrawler 
> now takes an ID for the NamingConvention to use and AutoDetectProductCrawler 
> has a new element  in MimeExtractorRepo
> - Also cleaned up handleFile(File)... documented better and is now public and 
> returns the IngestResult for what happened when called.
> 
> 
> This addresses bug OODT-426.
> https://issues.apache.org/jira/browse/OODT-426
> 
> 
> Diffs
> -
> 
>   trunk/crawler/src/main/resources/naming-beans.xml PRE-CREATION 
>   trunk/crawler/src/test/org/apache/oodt/cas/crawl/TestProductCrawler.java 
> PRE-CREATION 
>   trunk/crawler/src/main/resources/cmd-line-options.xml 1302790 
>   trunk/crawler/src/main/resources/crawler-config.xml 1302790 
>   trunk/crawler/src/main/resources/examples/mime-extractor-map.xml 1302790 
>   
> trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/typedetection/MimeExtractorRepo.java
>  1302790 
>   
> trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/StdProductCrawler.java 
> 1302790 
>   
> trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/typedetection/MimeExtractorConfigMetKeys.java
>  1302790 
>   
> trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/typedetection/MimeExtractorConfigReader.java
>  1302790 
>   trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/ProductCrawler.java 
> 1302790 
>   trunk/crawler/pom.xml 1302790 
>   
> trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/AutoDetectProductCrawler.java
>  1302790 
>   
> trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/MetExtractorProductCrawler.java
>  1302790 
> 
> Diff: https://reviews.apache.org/r//diff
> 
> 
> Testing
> ---
> 
> Still need to unit-test up cas-crawler
> 
> 
> Thanks,
> 
> brian
> 
>

Re: Review Request: filemgr query throws "String index out of range: -1" when some products have undefined metadata values

[brian Foster]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4451/#review6278
---


Overall great fix!... Just a few comments


trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/structs/query/QueryResult.java


Just an FYI... you can do this instead here:
List outputString = Lists.newArrayList();

I'll leave it up to you though if you want to change it or leave it... I 
just think the Lists class is cool... There are also Sets and Maps classes 
which do similar



trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/cli/action/TestSqlQueryCliAction.java


This doesn't make sure that nothing else is being return in the value... 
For example this test would pass for:
data.dat,Bob,Billy,Bogus

I can see why you changed it, but maybe split it into a list then verify 
size and then that the list contain data.dat and Bob,Billy



trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/structs/query/TestQueryResult.java


Same thing goes here as comment for line 129 in TestSqlQueryCliAction


- brian


On 2012-03-22 23:47:07, Ricky Nguyen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4451/
> ---
> 
> (Updated 2012-03-22 23:47:07)
> 
> 
> Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, Sheryl 
> John, and Thomas Bennett.
> 
> 
> Summary
> ---
> 
> Cleaned up metadata to string methods of QueryResult. If metadata was empty, 
> it was trying to delete a trailing comma that doesn't exist.
> 
> 
> This addresses bug OODT-427.
> https://issues.apache.org/jira/browse/OODT-427
> 
> 
> Diffs
> -
> 
>   
> trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/structs/query/QueryResult.java
>  1303205 
>   
> trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/cli/action/TestSqlQueryCliAction.java
>  1303205 
>   
> trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/structs/query/TestQueryResult.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/4451/diff
> 
> 
> Testing
> ---
> 
> Added unit test to check for empty metadata.
> 
> Changed existing unit test to account for implementation-dependent ordering 
> of keys.
> 
> 
> Thanks,
> 
> Ricky
> 
>

Re: svn commit: r1304212 - /oodt/trunk/crawler/src/main/resources/cmd-line-options.xml

[Mattmann, Chris A (388J)]

Hi Tom,

Thanks for this. If this was tied to a JIRA issue, it's always a good practice 
to ref the JIRA issue
in your commit msg, e.g., OODT-xxx: MoveMetadataToFailureDir should read as 
the message.
Then in JIRA, we can look up all associated SVN commits, via the Subversion 
Commits pane. 

No biggie, just wanted to pass along. Also, if you haven't had a chance to yet, 
please remember
to update CHANGES.txt with an entry for this fix.

Thanks!

Cheers,
Chris

On Mar 23, 2012, at 12:06 AM,   wrote:

> Author: thomas
> Date: Fri Mar 23 07:06:35 2012
> New Revision: 1304212
> 
> URL: http://svn.apache.org/viewvc?rev=1304212&view=rev
> Log:
> Bugfix: MoveMetadataToFailureDir should read MoveMetadataFileToFailureDir
> 
> Modified:
>oodt/trunk/crawler/src/main/resources/cmd-line-options.xml
> 
> Modified: oodt/trunk/crawler/src/main/resources/cmd-line-options.xml
> URL: 
> http://svn.apache.org/viewvc/oodt/trunk/crawler/src/main/resources/cmd-line-options.xml?rev=1304212&r1=1304211&r2=1304212&view=diff
> ==
> --- oodt/trunk/crawler/src/main/resources/cmd-line-options.xml (original)
> +++ oodt/trunk/crawler/src/main/resources/cmd-line-options.xml Fri Mar 23 
> 07:06:35 2012
> @@ -186,7 +186,7 @@
>class="org.apache.oodt.cas.crawl.cli.option.handler.CrawlerBeansPropHandler">
>   
>   
> - 
> MoveMetadataToFailureDir.toDir
> + 
> MoveMetadataFileToFailureDir.toDir
>   
> MovePushpullMetFileToFailureDir.toDir
>   
> MoveDataFileToFailureDir.toDir
>   
> 
> 


++
Chris Mattmann, Ph.D.
Senior Computer Scientist
NASA Jet Propulsion Laboratory Pasadena, CA 91109 USA
Office: 171-266B, Mailstop: 171-246
Email: chris.a.mattm...@nasa.gov
WWW:   http://sunset.usc.edu/~mattmann/
++
Adjunct Assistant Professor, Computer Science Department
University of Southern California, Los Angeles, CA 90089 USA
++

Re: Review Request: filemgr query throws "String index out of range: -1" when some products have undefined metadata values

[Ricky Nguyen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4451/
---

(Updated 2012-03-22 22:55:46.864916)


Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, Sheryl 
John, and Thomas Bennett.


Summary
---

Cleaned up metadata to string methods of QueryResult. If metadata was empty, it 
was trying to delete a trailing comma that doesn't exist.


This addresses bug OODT-427.
https://issues.apache.org/jira/browse/OODT-427


Diffs
-

  
trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/structs/query/QueryResult.java
 1303205 
  
trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/cli/action/TestSqlQueryCliAction.java
 1303205 

Diff: https://reviews.apache.org/r/4451/diff


Testing
---

Added unit test to check for empty metadata.

Changed existing unit test to account for implementation-dependent ordering of 
keys.


Thanks,

Ricky

Re: Review Request: filemgr query throws NPE when sorting by key with possibly empty values

[Chris Mattmann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4458/#review6348
---

Ship it!


LGTM.


trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/structs/query/QueryResultComparator.java


Agreed.


- Chris


On 2012-03-23 21:19:16, Ricky Nguyen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4458/
> ---
> 
> (Updated 2012-03-23 21:19:16)
> 
> 
> Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, Sheryl 
> John, and Thomas Bennett.
> 
> 
> Summary
> ---
> 
> putting nulls last
> 
> 
> This addresses bug OODT-429.
> https://issues.apache.org/jira/browse/OODT-429
> 
> 
> Diffs
> -
> 
>   
> trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/structs/query/QueryResultComparator.java
>  1303205 
>   
> trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/structs/query/TestQueryResultComparator.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/4458/diff
> 
> 
> Testing
> ---
> 
> wrote unit test
> 
> 
> Thanks,
> 
> Ricky
> 
>

Review Request: filemgr query throws NPE when sorting by key with possibly empty values

[Ricky Nguyen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4458/
---

Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, Sheryl 
John, and Thomas Bennett.


Summary
---

putting nulls last


This addresses bug OODT-429.
https://issues.apache.org/jira/browse/OODT-429


Diffs
-

  
trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/structs/query/QueryResultComparator.java
 1303205 
  
trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/structs/query/TestQueryResultComparator.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/4458/diff


Testing
---

wrote unit test


Thanks,

Ricky

Re: Review Request: filemgr query throws "String index out of range: -1" when some products have undefined metadata values

[Ricky Nguyen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4451/
---

(Updated 2012-03-22 23:47:07.464893)


Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, Sheryl 
John, and Thomas Bennett.


Changes
---

decided to write unit tests for QueryResult, instead of adding a test to 
TestSqlQueryCliAction


Summary
---

Cleaned up metadata to string methods of QueryResult. If metadata was empty, it 
was trying to delete a trailing comma that doesn't exist.


This addresses bug OODT-427.
https://issues.apache.org/jira/browse/OODT-427


Diffs (updated)
-

  
trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/structs/query/QueryResult.java
 1303205 
  
trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/cli/action/TestSqlQueryCliAction.java
 1303205 
  
trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/structs/query/TestQueryResult.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/4451/diff


Testing
---

Added unit test to check for empty metadata.

Changed existing unit test to account for implementation-dependent ordering of 
keys.


Thanks,

Ricky

Review Request: CrawlerBeansPropHandler doesn't set list properties for Spring PropertyOverrideConfigurer correctly

[brian Foster]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4454/
---

Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and Thomas 
Bennett.


Summary
---

It currently was setting lists keys to: value1,value2,value3,...

This patch will instead change it to:
key[0] = value1
key[1] = value2


This addresses bug OODT-428.
https://issues.apache.org/jira/browse/OODT-428


Diffs
-

  
trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/cli/option/handler/CrawlerBeansPropHandler.java
 1304041 

Diff: https://reviews.apache.org/r/4454/diff


Testing
---

still need a unit-test for this... will write when i get the time


Thanks,

brian

Re: Review Request: CrawlerBeansPropHandler doesn't set list properties for Spring PropertyOverrideConfigurer correctly

[Chris Mattmann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4454/#review6347
---


LGTM, see my comment about the null?


trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/cli/option/handler/CrawlerBeansPropHandler.java


Agree with Tom here, do we need a check on if getValues() == null too?


- Chris


On 2012-03-22 21:27:55, brian Foster wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4454/
> ---
> 
> (Updated 2012-03-22 21:27:55)
> 
> 
> Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and 
> Thomas Bennett.
> 
> 
> Summary
> ---
> 
> It currently was setting lists keys to: value1,value2,value3,...
> 
> This patch will instead change it to:
> key[0] = value1
> key[1] = value2
> 
> 
> This addresses bug OODT-428.
> https://issues.apache.org/jira/browse/OODT-428
> 
> 
> Diffs
> -
> 
>   
> trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/cli/option/handler/CrawlerBeansPropHandler.java
>  1304041 
> 
> Diff: https://reviews.apache.org/r/4454/diff
> 
> 
> Testing
> ---
> 
> still need a unit-test for this... will write when i get the time
> 
> 
> Thanks,
> 
> brian
> 
>

Re: crawler actionIds

[Thomas Bennett]

Hi Chris,

I'm wondering if the beans are named DeleteDataFile and DeleteMetadataFile:
> have you checked the action-beans.xml file?
>

If I understand you're question correctly, yes, the beans are
named DeleteDataFile and DeleteMetadataFile in the action-beans.xml.

Since there have been a few issues that have been resolved relating to the
crawler cli (thanks to Brian's efforts), here's a quick summary:

* MoveMetadataToFailureDir renamed MoveMetadataFileToFailureDir. see JIRA
issue OODT-412 
* Specifying multiple actionIds on the command line. Brian has posted the
fix (pending review) - see JIRA issue
OODT-428
.
* Executing boolean beans on the command line. Brian has supplied a fix
(which I committed). See JIRA issue
OODT-430

Cheers,
Tom

Re: Review Request: CrawlerBeansPropHandler doesn't set list properties for Spring PropertyOverrideConfigurer correctly

[Thomas Bennett]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4454/#review6279
---

Ship it!


I've tested it. Looks good to me!


trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/cli/option/handler/CrawlerBeansPropHandler.java


May need to test for boolean optionsInstances, i.e. where 
optionInstance.getValues().size() == 0.


- Thomas


On 2012-03-22 21:27:55, brian Foster wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4454/
> ---
> 
> (Updated 2012-03-22 21:27:55)
> 
> 
> Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and 
> Thomas Bennett.
> 
> 
> Summary
> ---
> 
> It currently was setting lists keys to: value1,value2,value3,...
> 
> This patch will instead change it to:
> key[0] = value1
> key[1] = value2
> 
> 
> This addresses bug OODT-428.
> https://issues.apache.org/jira/browse/OODT-428
> 
> 
> Diffs
> -
> 
>   
> trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/cli/option/handler/CrawlerBeansPropHandler.java
>  1304041 
> 
> Diff: https://reviews.apache.org/r/4454/diff
> 
> 
> Testing
> ---
> 
> still need a unit-test for this... will write when i get the time
> 
> 
> Thanks,
> 
> brian
> 
>