[jira] [Commented] (PHOENIX-3374) Wrong data row key is getting generated for local indexes for functions with fixed non null columns

2016-10-28 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15616295#comment-15616295
 ] 

Hudson commented on PHOENIX-3374:
-

SUCCESS: Integrated in Jenkins build Phoenix-4.8-HBase-1.2 #44 (See 
[https://builds.apache.org/job/Phoenix-4.8-HBase-1.2/44/])
PHOENIX-3374 Wrong data row key is getting generated for local indexes 
(rajeshbabu: rev bee0a7cc926f49737f165e5b2d6906d2ed449080)
* (edit) 
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/LocalIndexIT.java
* (edit) 
phoenix-core/src/main/java/org/apache/phoenix/index/IndexMaintainer.java


> Wrong data row key is getting generated for local indexes for functions with 
> fixed non null columns
> ---
>
> Key: PHOENIX-3374
> URL: https://issues.apache.org/jira/browse/PHOENIX-3374
> Project: Phoenix
>  Issue Type: Bug
>Reporter: Rajeshbabu Chintaguntla
>Assignee: Rajeshbabu Chintaguntla
> Fix For: 4.9.0, 4.8.2
>
> Attachments: PHOENIX-3374.patch, PHOENIX-3374_v2.patch, 
> PHOENIX-3374_v3.patch
>
>
> When we create local indexes on functions then while joining back missing 
> columns from data table is generating wrong data row key. 
> When we generated index row key schema we are initializing isNullableToBe to 
> true always even if the expression might be not null. Because of this we 
> might change the column type to other castable one and may consider actual 
> data as separator bytes.
> {noformat}
> ...
> if (indexField == null) {
> Expression e = expressionItr.next();
> isNullableToBe = true;
> dataTypeToBe = 
> IndexUtil.getIndexColumnDataType(isNullableToBe, e.getDataType());
> sortOrderToBe = descIndexColumnBitSet.get(i) ? SortOrder.DESC 
> : SortOrder.ASC;
> maxLengthToBe = e.getMaxLength();
> scaleToBe = e.getScale();
> ...
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (PHOENIX-3374) Wrong data row key is getting generated for local indexes for functions with fixed non null columns

2016-10-28 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15615811#comment-15615811
 ] 

Hudson commented on PHOENIX-3374:
-

FAILURE: Integrated in Jenkins build Phoenix-master #1457 (See 
[https://builds.apache.org/job/Phoenix-master/1457/])
PHOENIX-3374 Wrong data row key is getting generated for local indexes 
(rajeshbabu: rev 10880a37ca8d9594a6c2bfa5d77639368612fae7)
* (edit) 
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/LocalIndexIT.java
* (edit) 
phoenix-core/src/main/java/org/apache/phoenix/index/IndexMaintainer.java


> Wrong data row key is getting generated for local indexes for functions with 
> fixed non null columns
> ---
>
> Key: PHOENIX-3374
> URL: https://issues.apache.org/jira/browse/PHOENIX-3374
> Project: Phoenix
>  Issue Type: Bug
>Reporter: Rajeshbabu Chintaguntla
>Assignee: Rajeshbabu Chintaguntla
> Fix For: 4.9.0, 4.8.2
>
> Attachments: PHOENIX-3374.patch, PHOENIX-3374_v2.patch, 
> PHOENIX-3374_v3.patch
>
>
> When we create local indexes on functions then while joining back missing 
> columns from data table is generating wrong data row key. 
> When we generated index row key schema we are initializing isNullableToBe to 
> true always even if the expression might be not null. Because of this we 
> might change the column type to other castable one and may consider actual 
> data as separator bytes.
> {noformat}
> ...
> if (indexField == null) {
> Expression e = expressionItr.next();
> isNullableToBe = true;
> dataTypeToBe = 
> IndexUtil.getIndexColumnDataType(isNullableToBe, e.getDataType());
> sortOrderToBe = descIndexColumnBitSet.get(i) ? SortOrder.DESC 
> : SortOrder.ASC;
> maxLengthToBe = e.getMaxLength();
> scaleToBe = e.getScale();
> ...
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (PHOENIX-3374) Wrong data row key is getting generated for local indexes for functions with fixed non null columns

2016-10-28 Thread Rajeshbabu Chintaguntla (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15615296#comment-15615296
 ] 

Rajeshbabu Chintaguntla commented on PHOENIX-3374:
--

The test is flaky and not related to the patch.  Here is the my local test 
result.
{noformat}
[INFO] Apache Phoenix . SUCCESS [  1.496 s]
[INFO] Phoenix Core ... SUCCESS [27:11 min]
[INFO] Phoenix - Flume  SUCCESS [01:13 min]
[INFO] Phoenix - Pig .. SUCCESS [08:59 min]
[INFO] Phoenix Query Server Client  SUCCESS [ 12.818 s]
[INFO] Phoenix Query Server ... SUCCESS [01:43 min]
[INFO] Phoenix - Pherf  SUCCESS [01:41 min]
[INFO] Phoenix - Spark  SUCCESS [02:10 min]
[INFO] Phoenix - Hive . SUCCESS [02:47 min]
[INFO] Phoenix Client . SUCCESS [ 49.049 s]
[INFO] Phoenix Server . SUCCESS [  2.947 s]
[INFO] Phoenix Assembly ... SUCCESS [ 25.028 s]
[INFO] Phoenix - Tracing Web Application .. SUCCESS [  6.853 s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 47:26 min
[INFO] Finished at: 2016-10-28T15:14:33+05:30
[INFO] Final Memory: 147M/1662M
[INFO] 
{noformat}

> Wrong data row key is getting generated for local indexes for functions with 
> fixed non null columns
> ---
>
> Key: PHOENIX-3374
> URL: https://issues.apache.org/jira/browse/PHOENIX-3374
> Project: Phoenix
>  Issue Type: Bug
>Reporter: Rajeshbabu Chintaguntla
>Assignee: Rajeshbabu Chintaguntla
> Fix For: 4.9.0, 4.8.2
>
> Attachments: PHOENIX-3374.patch, PHOENIX-3374_v2.patch, 
> PHOENIX-3374_v3.patch
>
>
> When we create local indexes on functions then while joining back missing 
> columns from data table is generating wrong data row key. 
> When we generated index row key schema we are initializing isNullableToBe to 
> true always even if the expression might be not null. Because of this we 
> might change the column type to other castable one and may consider actual 
> data as separator bytes.
> {noformat}
> ...
> if (indexField == null) {
> Expression e = expressionItr.next();
> isNullableToBe = true;
> dataTypeToBe = 
> IndexUtil.getIndexColumnDataType(isNullableToBe, e.getDataType());
> sortOrderToBe = descIndexColumnBitSet.get(i) ? SortOrder.DESC 
> : SortOrder.ASC;
> maxLengthToBe = e.getMaxLength();
> scaleToBe = e.getScale();
> ...
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (PHOENIX-3374) Wrong data row key is getting generated for local indexes for functions with fixed non null columns

2016-10-28 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15614698#comment-15614698
 ] 

Hadoop QA commented on PHOENIX-3374:


{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12835760/PHOENIX-3374_v3.patch
  against master branch at commit 44c5a032818bac2809ef664321542ec77f5df1f9.
  ATTACHMENT ID: 12835760

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 
43 warning messages.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
++ " (user_time UNSIGNED_TIMESTAMP NOT NULL,user_id 
varchar NOT NULL,col1 varchar,col2 double,"
+"select substr(to_char(user_time), 0, 10) as 
ddate, hour(user_time) as hhour, user_id, col1,col2 from "
++ " where hour(user_time)=14 group by 
user_id, col1, col2, ddate, hhour limit 1");

 {color:red}-1 core tests{color}.  The patch failed these unit tests:
   org.apache.phoenix.schema.MutationTest

Test results: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/652//testReport/
Javadoc warnings: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/652//artifact/patchprocess/patchJavadocWarnings.txt
Console output: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/652//console

This message is automatically generated.

> Wrong data row key is getting generated for local indexes for functions with 
> fixed non null columns
> ---
>
> Key: PHOENIX-3374
> URL: https://issues.apache.org/jira/browse/PHOENIX-3374
> Project: Phoenix
>  Issue Type: Bug
>Reporter: Rajeshbabu Chintaguntla
>Assignee: Rajeshbabu Chintaguntla
> Fix For: 4.9.0, 4.8.2
>
> Attachments: PHOENIX-3374.patch, PHOENIX-3374_v2.patch, 
> PHOENIX-3374_v3.patch
>
>
> When we create local indexes on functions then while joining back missing 
> columns from data table is generating wrong data row key. 
> When we generated index row key schema we are initializing isNullableToBe to 
> true always even if the expression might be not null. Because of this we 
> might change the column type to other castable one and may consider actual 
> data as separator bytes.
> {noformat}
> ...
> if (indexField == null) {
> Expression e = expressionItr.next();
> isNullableToBe = true;
> dataTypeToBe = 
> IndexUtil.getIndexColumnDataType(isNullableToBe, e.getDataType());
> sortOrderToBe = descIndexColumnBitSet.get(i) ? SortOrder.DESC 
> : SortOrder.ASC;
> maxLengthToBe = e.getMaxLength();
> scaleToBe = e.getScale();
> ...
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (PHOENIX-3374) Wrong data row key is getting generated for local indexes for functions with fixed non null columns

2016-10-28 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15614652#comment-15614652
 ] 

Hadoop QA commented on PHOENIX-3374:


{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12835759/PHOENIX-3374_v2.patch
  against master branch at commit 44c5a032818bac2809ef664321542ec77f5df1f9.
  ATTACHMENT ID: 12835759

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 
43 warning messages.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
+"CREATE TABLE IF NOT EXISTS test_table (user_time 
UNSIGNED_TIMESTAMP NOT NULL,user_id varchar NOT NULL,col1 varchar,col2 
double,CONSTRAINT pk PRIMARY KEY(user_time,user_id)) SALT_BUCKETS = 20";
+"select substr(to_char(user_time), 0, 10) as 
ddate, hour(user_time) as hhour, user_id, col1,col2 from test_table where 
hour(user_time)=14 group by user_id, col1, col2, ddate, hhour limit 1");

 {color:red}-1 core tests{color}.  The patch failed these unit tests:
   org.apache.phoenix.schema.MutationTest

Test results: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/651//testReport/
Javadoc warnings: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/651//artifact/patchprocess/patchJavadocWarnings.txt
Console output: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/651//console

This message is automatically generated.

> Wrong data row key is getting generated for local indexes for functions with 
> fixed non null columns
> ---
>
> Key: PHOENIX-3374
> URL: https://issues.apache.org/jira/browse/PHOENIX-3374
> Project: Phoenix
>  Issue Type: Bug
>Reporter: Rajeshbabu Chintaguntla
>Assignee: Rajeshbabu Chintaguntla
> Fix For: 4.9.0, 4.8.2
>
> Attachments: PHOENIX-3374.patch, PHOENIX-3374_v2.patch, 
> PHOENIX-3374_v3.patch
>
>
> When we create local indexes on functions then while joining back missing 
> columns from data table is generating wrong data row key. 
> When we generated index row key schema we are initializing isNullableToBe to 
> true always even if the expression might be not null. Because of this we 
> might change the column type to other castable one and may consider actual 
> data as separator bytes.
> {noformat}
> ...
> if (indexField == null) {
> Expression e = expressionItr.next();
> isNullableToBe = true;
> dataTypeToBe = 
> IndexUtil.getIndexColumnDataType(isNullableToBe, e.getDataType());
> sortOrderToBe = descIndexColumnBitSet.get(i) ? SortOrder.DESC 
> : SortOrder.ASC;
> maxLengthToBe = e.getMaxLength();
> scaleToBe = e.getScale();
> ...
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (PHOENIX-3374) Wrong data row key is getting generated for local indexes for functions with fixed non null columns

2016-10-12 Thread James Taylor (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15569401#comment-15569401
 ] 

James Taylor commented on PHOENIX-3374:
---

+1. I can't think of a reason why {{isNullableToBe}} was assumed to be true. 
Please make sure other unit tests pass too with this change.

> Wrong data row key is getting generated for local indexes for functions with 
> fixed non null columns
> ---
>
> Key: PHOENIX-3374
> URL: https://issues.apache.org/jira/browse/PHOENIX-3374
> Project: Phoenix
>  Issue Type: Bug
>Reporter: Rajeshbabu Chintaguntla
>Assignee: Rajeshbabu Chintaguntla
> Fix For: 4.9.0, 4.8.2
>
> Attachments: PHOENIX-3374.patch
>
>
> When we create local indexes on functions then while joining back missing 
> columns from data table is generating wrong data row key. 
> When we generated index row key schema we are initializing isNullableToBe to 
> true always even if the expression might be not null. Because of this we 
> might change the column type to other castable one and may consider actual 
> data as separator bytes.
> {noformat}
> ...
> if (indexField == null) {
> Expression e = expressionItr.next();
> isNullableToBe = true;
> dataTypeToBe = 
> IndexUtil.getIndexColumnDataType(isNullableToBe, e.getDataType());
> sortOrderToBe = descIndexColumnBitSet.get(i) ? SortOrder.DESC 
> : SortOrder.ASC;
> maxLengthToBe = e.getMaxLength();
> scaleToBe = e.getScale();
> ...
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (PHOENIX-3374) Wrong data row key is getting generated for local indexes for functions with fixed non null columns

2016-10-12 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15569345#comment-15569345
 ] 

Hadoop QA commented on PHOENIX-3374:


{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12832939/PHOENIX-3374.patch
  against master branch at commit d1156eaadfc72d9bcfe6418fa98a170d27b18264.
  ATTACHMENT ID: 12832939

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

{color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/623//console

This message is automatically generated.

> Wrong data row key is getting generated for local indexes for functions with 
> fixed non null columns
> ---
>
> Key: PHOENIX-3374
> URL: https://issues.apache.org/jira/browse/PHOENIX-3374
> Project: Phoenix
>  Issue Type: Bug
>Reporter: Rajeshbabu Chintaguntla
>Assignee: Rajeshbabu Chintaguntla
> Fix For: 4.9.0, 4.8.2
>
> Attachments: PHOENIX-3374.patch
>
>
> When we create local indexes on functions then while joining back missing 
> columns from data table is generating wrong data row key. 
> When we generated index row key schema we are initializing isNullableToBe to 
> true always even if the expression might be not null. Because of this we 
> might change the column type to other castable one and may consider actual 
> data as separator bytes.
> {noformat}
> ...
> if (indexField == null) {
> Expression e = expressionItr.next();
> isNullableToBe = true;
> dataTypeToBe = 
> IndexUtil.getIndexColumnDataType(isNullableToBe, e.getDataType());
> sortOrderToBe = descIndexColumnBitSet.get(i) ? SortOrder.DESC 
> : SortOrder.ASC;
> maxLengthToBe = e.getMaxLength();
> scaleToBe = e.getScale();
> ...
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)