Review Request 12275: Platform neutral helper functions.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12275/ --- Review request for qpid, Andrew Stitcher, Kenneth Giusti, and Rafael Schloming. Bugs: proton-348 https://issues.apache.org/jira/browse/proton-348 Repository: qpid Description --- This patch tries to minimize the impact of incorporating platform neutral code into the examples and the native C++ tests. I dislike the thought of dragging around a compatibility library that needs to be linked to some examples and not others. I am also not keen to have the qpid-proton library expose non-core functionality that users start using in real code and expect to be around for all time. As a further wrinkle, we may wish to distribute examples with Visual Studio projects to Windows users without the benefit of CMake infrastructure. The implication being that some platform magic that works in the main build courtesy of CMake may need to be implemented differently. The proposed patch is not particularly pretty, but hopefully leaves light footprints when the helper functions are needed. The code needs to be included exactly once per executable when needed. A portable pragma weak directive, if it existed, could have made this simpler. * Usage for a single compilation unit: * * #include pncompat/misc_funcs.i * * Usage for multiple combined compilation units: chose one to include * pncompat/misc_funcs.i as above and in each other unit needing the * definitions use * * #include pncompat/misc_defs.h The include/pncompat directory is placed under trunk/examples since you can't build the examples without it and the examples might be packaged separately. However the tests and even proton.c can find them when they are normally built. Diffs - http://svn.apache.org/repos/asf/qpid/proton/trunk/examples/include/pncompat/internal/LICENSE PRE-CREATION http://svn.apache.org/repos/asf/qpid/proton/trunk/examples/include/pncompat/internal/getopt.h PRE-CREATION http://svn.apache.org/repos/asf/qpid/proton/trunk/examples/include/pncompat/internal/getopt.c PRE-CREATION http://svn.apache.org/repos/asf/qpid/proton/trunk/examples/include/pncompat/misc_defs.h PRE-CREATION http://svn.apache.org/repos/asf/qpid/proton/trunk/examples/include/pncompat/misc_funcs.i PRE-CREATION http://svn.apache.org/repos/asf/qpid/proton/trunk/examples/messenger/c/recv.c 1499652 http://svn.apache.org/repos/asf/qpid/proton/trunk/examples/messenger/c/send.c 1499652 http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/CMakeLists.txt 1499652 http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/include/proton/object.h 1499652 http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/proton.c 1499652 http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/wincompat/getopt.h 1499652 http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/wincompat/internal/LICENSE 1499652 http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/wincompat/internal/getopt.h 1499652 http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/wincompat/internal/getopt.c 1499652 http://svn.apache.org/repos/asf/qpid/proton/trunk/tests/tools/apps/c/msgr-common.h 1499652 http://svn.apache.org/repos/asf/qpid/proton/trunk/tests/tools/apps/c/msgr-common.c 1499652 Diff: https://reviews.apache.org/r/12275/diff/ Testing --- windows, rhel6 Thanks, Cliff Jansen
[jira] [Updated] (QPID-4948) [AMQP 1.0] browsing queues not supported
[ https://issues.apache.org/jira/browse/QPID-4948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gordon Sim updated QPID-4948: - Attachment: 0001-QPID-4948-add-support-for-browsing-queues.patch Patch to fix issue. Requires latest proton trunk including fix for PROTON-139. Blocked on 0.5 release of proton. [AMQP 1.0] browsing queues not supported Key: QPID-4948 URL: https://issues.apache.org/jira/browse/QPID-4948 Project: Qpid Issue Type: Bug Components: C++ Broker, C++ Client Affects Versions: 0.20 Reporter: Gordon Sim Assignee: Gordon Sim Fix For: Future Attachments: 0001-QPID-4948-add-support-for-browsing-queues.patch Requires means to set and read the distribution-mode of the receiver link in proton engine. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-4978) [AMQP 1.0] support reliability link option
[ https://issues.apache.org/jira/browse/QPID-4978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gordon Sim updated QPID-4978: - Attachment: 0002-QPID-4978-support-reliability-only-at-most-once-and-.patch Patch to fix this using proton from trunk plus additional patch as attached to PROTON-81. Blocked on the 0.5 release of proton. [AMQP 1.0] support reliability link option -- Key: QPID-4978 URL: https://issues.apache.org/jira/browse/QPID-4978 Project: Qpid Issue Type: Bug Components: C++ Broker, C++ Client Affects Versions: 0.22 Reporter: Gordon Sim Assignee: Gordon Sim Fix For: Future Attachments: 0002-QPID-4978-support-reliability-only-at-most-once-and-.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
Re: Review Request 12249: add support for 1.0 lifetime policy to queues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12249/#review22781 --- Ship it! /trunk/qpid/cpp/src/qpid/broker/Queue.h https://reviews.apache.org/r/12249/#comment46484 Not sure what use case means. Is the controller a subscriber? - Alan Conway On July 4, 2013, 7:39 p.m., Gordon Sim wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12249/ --- (Updated July 4, 2013, 7:39 p.m.) Review request for qpid, Alan Conway and Kenneth Giusti. Bugs: QPID-4976 https://issues.apache.org/jira/browse/QPID-4976 Repository: qpid Description --- This adds the ability to have queue autodeleted when no longer used, when empty or when both no longer used and empty as specified in the standard lifetime policies for AMQP 1.0. The ability to only delete if unused and empty is useful for 0-10 also so I've allowed these to be set there as well. The basic change is to have an optional policy specified that dictates what autodelete means. The default is to autodelete when not used. A queue is in use if it is being consumed or browsed, or if in 0-10 it has been declared as an exclusive queue and the declaring session is still active. Additionally over 1.0 the queue is in use if there is any sender attached to it. Autodeletion is now triggered automatically by the queue when some other operation moves it to a state eligible for deletion. To avoid this on a backup in ha, the queue replicator flags the replica as in use. Diffs - /trunk/qpid/cpp/src/qpid/amqp/descriptors.h 1499373 /trunk/qpid/cpp/src/qpid/broker/LossyQueue.cpp 1499373 /trunk/qpid/cpp/src/qpid/broker/Lvq.cpp 1499373 /trunk/qpid/cpp/src/qpid/broker/Queue.h 1499373 /trunk/qpid/cpp/src/qpid/broker/Queue.cpp 1499373 /trunk/qpid/cpp/src/qpid/broker/QueueSettings.h 1499373 /trunk/qpid/cpp/src/qpid/broker/QueueSettings.cpp 1499373 /trunk/qpid/cpp/src/qpid/broker/SemanticState.cpp 1499373 /trunk/qpid/cpp/src/qpid/broker/SessionAdapter.cpp 1499373 /trunk/qpid/cpp/src/qpid/broker/amqp/Connection.cpp 1499373 /trunk/qpid/cpp/src/qpid/broker/amqp/DataReader.cpp 1499373 /trunk/qpid/cpp/src/qpid/broker/amqp/NodeProperties.h 1499373 /trunk/qpid/cpp/src/qpid/broker/amqp/NodeProperties.cpp 1499373 /trunk/qpid/cpp/src/qpid/broker/amqp/Outgoing.h 1499373 /trunk/qpid/cpp/src/qpid/broker/amqp/Outgoing.cpp 1499373 /trunk/qpid/cpp/src/qpid/broker/amqp/Session.h 1499373 /trunk/qpid/cpp/src/qpid/broker/amqp/Session.cpp 1499373 /trunk/qpid/cpp/src/qpid/ha/BrokerReplicator.cpp 1499373 /trunk/qpid/cpp/src/qpid/ha/QueueReplicator.cpp 1499373 /trunk/qpid/cpp/src/qpid/messaging/amqp/AddressHelper.cpp 1499373 /trunk/qpid/cpp/src/tests/QueueTest.cpp 1499373 Diff: https://reviews.apache.org/r/12249/diff/ Testing --- Thanks, Gordon Sim
Re: Review Request 12275: Platform neutral helper functions.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12275/#review22782 --- http://svn.apache.org/repos/asf/qpid/proton/trunk/examples/include/pncompat/internal/getopt.h https://reviews.apache.org/r/12275/#comment46485 I suspect that this condition conflicts with the ASL license. It is certainly more restrictive than the ASL. I'm not a lawyer, though. But as a layman, this seems like it would require all binary copies of proton to have to reproduce this license (how? via a text display? or include a text file?) - Kenneth Giusti On July 5, 2013, 6:17 a.m., Cliff Jansen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12275/ --- (Updated July 5, 2013, 6:17 a.m.) Review request for qpid, Andrew Stitcher, Kenneth Giusti, and Rafael Schloming. Bugs: proton-348 https://issues.apache.org/jira/browse/proton-348 Repository: qpid Description --- This patch tries to minimize the impact of incorporating platform neutral code into the examples and the native C++ tests. I dislike the thought of dragging around a compatibility library that needs to be linked to some examples and not others. I am also not keen to have the qpid-proton library expose non-core functionality that users start using in real code and expect to be around for all time. As a further wrinkle, we may wish to distribute examples with Visual Studio projects to Windows users without the benefit of CMake infrastructure. The implication being that some platform magic that works in the main build courtesy of CMake may need to be implemented differently. The proposed patch is not particularly pretty, but hopefully leaves light footprints when the helper functions are needed. The code needs to be included exactly once per executable when needed. A portable pragma weak directive, if it existed, could have made this simpler. * Usage for a single compilation unit: * * #include pncompat/misc_funcs.i * * Usage for multiple combined compilation units: chose one to include * pncompat/misc_funcs.i as above and in each other unit needing the * definitions use * * #include pncompat/misc_defs.h The include/pncompat directory is placed under trunk/examples since you can't build the examples without it and the examples might be packaged separately. However the tests and even proton.c can find them when they are normally built. Diffs - http://svn.apache.org/repos/asf/qpid/proton/trunk/examples/include/pncompat/internal/LICENSE PRE-CREATION http://svn.apache.org/repos/asf/qpid/proton/trunk/examples/include/pncompat/internal/getopt.h PRE-CREATION http://svn.apache.org/repos/asf/qpid/proton/trunk/examples/include/pncompat/internal/getopt.c PRE-CREATION http://svn.apache.org/repos/asf/qpid/proton/trunk/examples/include/pncompat/misc_defs.h PRE-CREATION http://svn.apache.org/repos/asf/qpid/proton/trunk/examples/include/pncompat/misc_funcs.i PRE-CREATION http://svn.apache.org/repos/asf/qpid/proton/trunk/examples/messenger/c/recv.c 1499652 http://svn.apache.org/repos/asf/qpid/proton/trunk/examples/messenger/c/send.c 1499652 http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/CMakeLists.txt 1499652 http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/include/proton/object.h 1499652 http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/proton.c 1499652 http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/wincompat/getopt.h 1499652 http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/wincompat/internal/LICENSE 1499652 http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/wincompat/internal/getopt.h 1499652 http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/wincompat/internal/getopt.c 1499652 http://svn.apache.org/repos/asf/qpid/proton/trunk/tests/tools/apps/c/msgr-common.h 1499652 http://svn.apache.org/repos/asf/qpid/proton/trunk/tests/tools/apps/c/msgr-common.c 1499652 Diff: https://reviews.apache.org/r/12275/diff/ Testing --- windows, rhel6 Thanks, Cliff Jansen
Formal plug-in API.
Hi all. Designing a new TransactionObserver interface and it struck me that we already have half of a formal plug-in API in the set of *Observer interfaces. They nicely define all the call-out points from the broker to plug-ins. The other half is the set of broker library functions called by plug-ins. This could be formalized but needs a bit of research to find out just what broker functions are being used and to organize them in sensible classes. E.g. there might be a restricted interface to broker::Queue provided to plugins etc. I've got no immediate plans to do this but thought I'd float the idea in case anyone is interested or has better ideas about how to design a plug-in API. Cheers, Alan. - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
Re: Formal plug-in API.
On Fri, 2013-07-05 at 11:04 -0400, Alan Conway wrote: Hi all. Designing a new TransactionObserver interface and it struck me that we already have half of a formal plug-in API in the set of *Observer interfaces. They nicely define all the call-out points from the broker to plug-ins. The other half is the set of broker library functions called by plug-ins. This could be formalized but needs a bit of research to find out just what broker functions are being used and to organize them in sensible classes. E.g. there might be a restricted interface to broker::Queue provided to plugins etc. I've got no immediate plans to do this but thought I'd float the idea in case anyone is interested or has better ideas about how to design a plug-in API. The area which immediately comes to mind is the logging interface. Pretty much every piece of code uses this. I'm very much in favour of a formal plugin interface, but finding time to formalise the all the pieces will be a problem. Andrew - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
Re: Review Request 12249: add support for 1.0 lifetime policy to queues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12249/#review22783 --- Ship it! I like the renaming - the intent is much clearer. /trunk/qpid/cpp/src/qpid/broker/Queue.h https://reviews.apache.org/r/12249/#comment46486 this should read indicate _the_ queue is being used in some other context _than_ by a subscriber, right? - Kenneth Giusti On July 4, 2013, 7:39 p.m., Gordon Sim wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12249/ --- (Updated July 4, 2013, 7:39 p.m.) Review request for qpid, Alan Conway and Kenneth Giusti. Bugs: QPID-4976 https://issues.apache.org/jira/browse/QPID-4976 Repository: qpid Description --- This adds the ability to have queue autodeleted when no longer used, when empty or when both no longer used and empty as specified in the standard lifetime policies for AMQP 1.0. The ability to only delete if unused and empty is useful for 0-10 also so I've allowed these to be set there as well. The basic change is to have an optional policy specified that dictates what autodelete means. The default is to autodelete when not used. A queue is in use if it is being consumed or browsed, or if in 0-10 it has been declared as an exclusive queue and the declaring session is still active. Additionally over 1.0 the queue is in use if there is any sender attached to it. Autodeletion is now triggered automatically by the queue when some other operation moves it to a state eligible for deletion. To avoid this on a backup in ha, the queue replicator flags the replica as in use. Diffs - /trunk/qpid/cpp/src/qpid/amqp/descriptors.h 1499373 /trunk/qpid/cpp/src/qpid/broker/LossyQueue.cpp 1499373 /trunk/qpid/cpp/src/qpid/broker/Lvq.cpp 1499373 /trunk/qpid/cpp/src/qpid/broker/Queue.h 1499373 /trunk/qpid/cpp/src/qpid/broker/Queue.cpp 1499373 /trunk/qpid/cpp/src/qpid/broker/QueueSettings.h 1499373 /trunk/qpid/cpp/src/qpid/broker/QueueSettings.cpp 1499373 /trunk/qpid/cpp/src/qpid/broker/SemanticState.cpp 1499373 /trunk/qpid/cpp/src/qpid/broker/SessionAdapter.cpp 1499373 /trunk/qpid/cpp/src/qpid/broker/amqp/Connection.cpp 1499373 /trunk/qpid/cpp/src/qpid/broker/amqp/DataReader.cpp 1499373 /trunk/qpid/cpp/src/qpid/broker/amqp/NodeProperties.h 1499373 /trunk/qpid/cpp/src/qpid/broker/amqp/NodeProperties.cpp 1499373 /trunk/qpid/cpp/src/qpid/broker/amqp/Outgoing.h 1499373 /trunk/qpid/cpp/src/qpid/broker/amqp/Outgoing.cpp 1499373 /trunk/qpid/cpp/src/qpid/broker/amqp/Session.h 1499373 /trunk/qpid/cpp/src/qpid/broker/amqp/Session.cpp 1499373 /trunk/qpid/cpp/src/qpid/ha/BrokerReplicator.cpp 1499373 /trunk/qpid/cpp/src/qpid/ha/QueueReplicator.cpp 1499373 /trunk/qpid/cpp/src/qpid/messaging/amqp/AddressHelper.cpp 1499373 /trunk/qpid/cpp/src/tests/QueueTest.cpp 1499373 Diff: https://reviews.apache.org/r/12249/diff/ Testing --- Thanks, Gordon Sim
Re: Review Request 12275: Platform neutral helper functions.
On July 5, 2013, 2:50 p.m., Kenneth Giusti wrote: http://svn.apache.org/repos/asf/qpid/proton/trunk/examples/include/pncompat/internal/getopt.h, line 15 https://reviews.apache.org/r/12275/diff/1/?file=318334#file318334line15 I suspect that this condition conflicts with the ASL license. It is certainly more restrictive than the ASL. I'm not a lawyer, though. But as a layman, this seems like it would require all binary copies of proton to have to reproduce this license (how? via a text display? or include a text file?) Maybe the solution is to include this license in a top-level NOTICE file? The ASL requires all derivative works (including binaries) to include the NOTICE file if present. Again, IANAL - Kenneth --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12275/#review22782 --- On July 5, 2013, 6:17 a.m., Cliff Jansen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12275/ --- (Updated July 5, 2013, 6:17 a.m.) Review request for qpid, Andrew Stitcher, Kenneth Giusti, and Rafael Schloming. Bugs: proton-348 https://issues.apache.org/jira/browse/proton-348 Repository: qpid Description --- This patch tries to minimize the impact of incorporating platform neutral code into the examples and the native C++ tests. I dislike the thought of dragging around a compatibility library that needs to be linked to some examples and not others. I am also not keen to have the qpid-proton library expose non-core functionality that users start using in real code and expect to be around for all time. As a further wrinkle, we may wish to distribute examples with Visual Studio projects to Windows users without the benefit of CMake infrastructure. The implication being that some platform magic that works in the main build courtesy of CMake may need to be implemented differently. The proposed patch is not particularly pretty, but hopefully leaves light footprints when the helper functions are needed. The code needs to be included exactly once per executable when needed. A portable pragma weak directive, if it existed, could have made this simpler. * Usage for a single compilation unit: * * #include pncompat/misc_funcs.i * * Usage for multiple combined compilation units: chose one to include * pncompat/misc_funcs.i as above and in each other unit needing the * definitions use * * #include pncompat/misc_defs.h The include/pncompat directory is placed under trunk/examples since you can't build the examples without it and the examples might be packaged separately. However the tests and even proton.c can find them when they are normally built. Diffs - http://svn.apache.org/repos/asf/qpid/proton/trunk/examples/include/pncompat/internal/LICENSE PRE-CREATION http://svn.apache.org/repos/asf/qpid/proton/trunk/examples/include/pncompat/internal/getopt.h PRE-CREATION http://svn.apache.org/repos/asf/qpid/proton/trunk/examples/include/pncompat/internal/getopt.c PRE-CREATION http://svn.apache.org/repos/asf/qpid/proton/trunk/examples/include/pncompat/misc_defs.h PRE-CREATION http://svn.apache.org/repos/asf/qpid/proton/trunk/examples/include/pncompat/misc_funcs.i PRE-CREATION http://svn.apache.org/repos/asf/qpid/proton/trunk/examples/messenger/c/recv.c 1499652 http://svn.apache.org/repos/asf/qpid/proton/trunk/examples/messenger/c/send.c 1499652 http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/CMakeLists.txt 1499652 http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/include/proton/object.h 1499652 http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/proton.c 1499652 http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/wincompat/getopt.h 1499652 http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/wincompat/internal/LICENSE 1499652 http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/wincompat/internal/getopt.h 1499652 http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/wincompat/internal/getopt.c 1499652 http://svn.apache.org/repos/asf/qpid/proton/trunk/tests/tools/apps/c/msgr-common.h 1499652 http://svn.apache.org/repos/asf/qpid/proton/trunk/tests/tools/apps/c/msgr-common.c 1499652 Diff: https://reviews.apache.org/r/12275/diff/ Testing --- windows, rhel6 Thanks, Cliff Jansen
[jira] [Created] (QPID-4979) [Java Broker] Refactor VirtualHost to hide ExchangeRegistry, ExchangeFactory
Rob Godfrey created QPID-4979: - Summary: [Java Broker] Refactor VirtualHost to hide ExchangeRegistry, ExchangeFactory Key: QPID-4979 URL: https://issues.apache.org/jira/browse/QPID-4979 Project: Qpid Issue Type: Improvement Components: Java Broker Reporter: Rob Godfrey Assignee: Rob Godfrey Currently there is duplicated code in a number of places regarding the creation and deletion of exchanges. This code should be moved to a single point. This not only reduces duplication, but makes the eventual migration to having the model objects be the master source of configuration easier. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-4973) [Java Broker] Refactor DurableConfigurationStore interface to be in terms of ConfiguredObject rather than implementation classes
[ https://issues.apache.org/jira/browse/QPID-4973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13700934#comment-13700934 ] ASF subversion and git services commented on QPID-4973: --- Commit 1500047 from [~godfrer] [ https://svn.apache.org/r1500047 ] QPID-4973 : [Java Broker] Refactor DurableConfigurationStore interface to be in terms of ConfiguredObject rather than implementation classes [Java Broker] Refactor DurableConfigurationStore interface to be in terms of ConfiguredObject rather than implementation classes Key: QPID-4973 URL: https://issues.apache.org/jira/browse/QPID-4973 Project: Qpid Issue Type: Improvement Components: Java Broker Reporter: Rob Godfrey Assignee: Rob Godfrey As part of the ongoing changes to the Java Broker configuration model, make the DurableConfigurationStore (essentially the config store for a vhost) expose only a generic interface for configured objects, and not restrict to concrete implementation classes such as Queue, Exchange, Binding, etc. (Note that the representation of the objects in the BDB and JDBC/Derby stores is already in a generic form. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-4979) [Java Broker] Refactor VirtualHost to hide ExchangeRegistry, ExchangeFactory
[ https://issues.apache.org/jira/browse/QPID-4979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13700954#comment-13700954 ] Rob Godfrey commented on QPID-4979: --- This commit was meant for this JIRA: Commit 1500047 from [~godfrer] [ https://svn.apache.org/r1500047 ] [Java Broker] Refactor VirtualHost to hide ExchangeRegistry, ExchangeFactory Key: QPID-4979 URL: https://issues.apache.org/jira/browse/QPID-4979 Project: Qpid Issue Type: Improvement Components: Java Broker Reporter: Rob Godfrey Assignee: Rob Godfrey Currently there is duplicated code in a number of places regarding the creation and deletion of exchanges. This code should be moved to a single point. This not only reduces duplication, but makes the eventual migration to having the model objects be the master source of configuration easier. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-4973) [Java Broker] Refactor DurableConfigurationStore interface to be in terms of ConfiguredObject rather than implementation classes
[ https://issues.apache.org/jira/browse/QPID-4973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13700955#comment-13700955 ] Rob Godfrey commented on QPID-4973: --- Gah - the above commit (r1500047) should have been against QPID-4979 [Java Broker] Refactor DurableConfigurationStore interface to be in terms of ConfiguredObject rather than implementation classes Key: QPID-4973 URL: https://issues.apache.org/jira/browse/QPID-4973 Project: Qpid Issue Type: Improvement Components: Java Broker Reporter: Rob Godfrey Assignee: Rob Godfrey As part of the ongoing changes to the Java Broker configuration model, make the DurableConfigurationStore (essentially the config store for a vhost) expose only a generic interface for configured objects, and not restrict to concrete implementation classes such as Queue, Exchange, Binding, etc. (Note that the representation of the objects in the BDB and JDBC/Derby stores is already in a generic form. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-4627) Implement remaining special identifiers
[ https://issues.apache.org/jira/browse/QPID-4627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13700961#comment-13700961 ] ASF subversion and git services commented on QPID-4627: --- Commit 1500052 from [~astitcher] [ https://svn.apache.org/r1500052 ] QPID-4627: Implement most of the remaining selector special identifiers Implemented: message_id, correlation_id, jms_type, creation_time, absolute_expiry_time There are a couple of caveats: The easily available way to get jms_type doesn't distinguish between an empty string and the property not being sent at all. So we treat this case as property not set as that seems like it will get most cases correct (why bother to send an empty jms_type?). The creation_time property is currently implemented as the time the message was put on the queue (if enabled in the broker) as amqp 0_10 has no standard way to indicate the creation time and we're not currently holding the creation time for amqp 1.0 messages. Implement remaining special identifiers --- Key: QPID-4627 URL: https://issues.apache.org/jira/browse/QPID-4627 Project: Qpid Issue Type: Sub-task Reporter: Andrew Stitcher Assignee: Andrew Stitcher The remaining JMS specified identifiers are: amqp.correlation_id amqp.message_id amqp.creation_time amqp.jms_type The ones remaining from the AMQP Apache filters spec are: amqp.to amqp.reply_to amqp.absolute_expiration_time - amqp.durable (it's not clear this is really there as distinct from amqp.delivery_mode) - amqp.delivery_count (it's not clear this is really there as distinct from amqp.redelivered) In order to implement these special identifiers there will need to be extra work to abstract some of these values from the 0-10 or 1-0 message code. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
Vote results: Was: [VOTE] Only export C++ header files for supported APIs
This vote has now been active for just over a week: The results are: 4 votes in favour, none against. Not an overwhelming show of support, but I think sufficient to go ahead. I'll write an email to the user list, and create a JIRA for a 0.24 release note. Andrew - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
Vote results: Was: [VOTE] Remove autotools build for C++ build
The results of this vote are: 11 votes for, none against. I think this is pretty conclusively approved. I will create a JIRA for a 0.24 release note. Andrew - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
Selectors and JMSTimestamp/creation-time (was Re: svn commit: r1500052 - in /qpid/trunk/qpid/cpp/src/qpid: amqp/ broker/ broker/amqp/ broker/amqp_0_10/)
On 07/05/2013 05:06 PM, astitc...@apache.org wrote: Author: astitcher Date: Fri Jul 5 16:06:14 2013 New Revision: 1500052 URL: http://svn.apache.org/r1500052 Log: QPID-4627: Implement most of the remaining selector special identifiers Implemented: message_id, correlation_id, jms_type, creation_time, absolute_expiry_time The creation_time property is currently implemented as the time the message was put on the queue (if enabled in the broker) as amqp 0_10 has no standard way to indicate the creation time and we're not currently holding the creation time for amqp 1.0 messages. Not sure what you mean by 'not holding'. The creation time is set by the client, not the broker (since it is in the bare message). JMSTimestamp is 'the time a message was handed off to a provider to be sent. It is not the time the message was actually transmitted because the actual send may occur later due to transactions or other client side queueing of messages.' It looks like the JMS client sends JMSTimestamp in the timestamp field of delivery-properties over 0-10 (though the 0-10 spec does say that is set on the server). I think a better solution would therefore be to have a getCreationTime() in Message::Encoding and for the 0-10 encoding pull the timestamp out the delivery properties if there, and for 1.0 use the creation time. That way the implementation will be compliant with both AMQP and JMS when using 1.0, and compliant with JMS when using 0-10. - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
Re: Review Request 12275: Platform neutral helper functions.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12275/#review22786 --- This looks fine, if a little messy (but less messy than the alternatives!). One comment is that the .i extension is confusing in the qpid context as we it's use for swig definition files, my first though looking at the file list was: why has he changed the swig interface files?. So I'd suggest an alternative, maybe .inc would be preferable. - Andrew Stitcher On July 5, 2013, 6:17 a.m., Cliff Jansen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12275/ --- (Updated July 5, 2013, 6:17 a.m.) Review request for qpid, Andrew Stitcher, Kenneth Giusti, and Rafael Schloming. Bugs: proton-348 https://issues.apache.org/jira/browse/proton-348 Repository: qpid Description --- This patch tries to minimize the impact of incorporating platform neutral code into the examples and the native C++ tests. I dislike the thought of dragging around a compatibility library that needs to be linked to some examples and not others. I am also not keen to have the qpid-proton library expose non-core functionality that users start using in real code and expect to be around for all time. As a further wrinkle, we may wish to distribute examples with Visual Studio projects to Windows users without the benefit of CMake infrastructure. The implication being that some platform magic that works in the main build courtesy of CMake may need to be implemented differently. The proposed patch is not particularly pretty, but hopefully leaves light footprints when the helper functions are needed. The code needs to be included exactly once per executable when needed. A portable pragma weak directive, if it existed, could have made this simpler. * Usage for a single compilation unit: * * #include pncompat/misc_funcs.i * * Usage for multiple combined compilation units: chose one to include * pncompat/misc_funcs.i as above and in each other unit needing the * definitions use * * #include pncompat/misc_defs.h The include/pncompat directory is placed under trunk/examples since you can't build the examples without it and the examples might be packaged separately. However the tests and even proton.c can find them when they are normally built. Diffs - http://svn.apache.org/repos/asf/qpid/proton/trunk/examples/include/pncompat/internal/LICENSE PRE-CREATION http://svn.apache.org/repos/asf/qpid/proton/trunk/examples/include/pncompat/internal/getopt.h PRE-CREATION http://svn.apache.org/repos/asf/qpid/proton/trunk/examples/include/pncompat/internal/getopt.c PRE-CREATION http://svn.apache.org/repos/asf/qpid/proton/trunk/examples/include/pncompat/misc_defs.h PRE-CREATION http://svn.apache.org/repos/asf/qpid/proton/trunk/examples/include/pncompat/misc_funcs.i PRE-CREATION http://svn.apache.org/repos/asf/qpid/proton/trunk/examples/messenger/c/recv.c 1499652 http://svn.apache.org/repos/asf/qpid/proton/trunk/examples/messenger/c/send.c 1499652 http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/CMakeLists.txt 1499652 http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/include/proton/object.h 1499652 http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/proton.c 1499652 http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/wincompat/getopt.h 1499652 http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/wincompat/internal/LICENSE 1499652 http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/wincompat/internal/getopt.h 1499652 http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/wincompat/internal/getopt.c 1499652 http://svn.apache.org/repos/asf/qpid/proton/trunk/tests/tools/apps/c/msgr-common.h 1499652 http://svn.apache.org/repos/asf/qpid/proton/trunk/tests/tools/apps/c/msgr-common.c 1499652 Diff: https://reviews.apache.org/r/12275/diff/ Testing --- windows, rhel6 Thanks, Cliff Jansen
Re: Review Request 12249: add support for 1.0 lifetime policy to queues
On July 5, 2013, 3:15 p.m., Kenneth Giusti wrote: /trunk/qpid/cpp/src/qpid/broker/Queue.h, line 342 https://reviews.apache.org/r/12249/diff/1-2/?file=317951#file317951line342 this should read indicate _the_ queue is being used in some other context _than_ by a subscriber, right? Oops, yes, I'll fix. - Gordon --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12249/#review22783 --- On July 4, 2013, 7:39 p.m., Gordon Sim wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12249/ --- (Updated July 4, 2013, 7:39 p.m.) Review request for qpid, Alan Conway and Kenneth Giusti. Bugs: QPID-4976 https://issues.apache.org/jira/browse/QPID-4976 Repository: qpid Description --- This adds the ability to have queue autodeleted when no longer used, when empty or when both no longer used and empty as specified in the standard lifetime policies for AMQP 1.0. The ability to only delete if unused and empty is useful for 0-10 also so I've allowed these to be set there as well. The basic change is to have an optional policy specified that dictates what autodelete means. The default is to autodelete when not used. A queue is in use if it is being consumed or browsed, or if in 0-10 it has been declared as an exclusive queue and the declaring session is still active. Additionally over 1.0 the queue is in use if there is any sender attached to it. Autodeletion is now triggered automatically by the queue when some other operation moves it to a state eligible for deletion. To avoid this on a backup in ha, the queue replicator flags the replica as in use. Diffs - /trunk/qpid/cpp/src/qpid/amqp/descriptors.h 1499373 /trunk/qpid/cpp/src/qpid/broker/LossyQueue.cpp 1499373 /trunk/qpid/cpp/src/qpid/broker/Lvq.cpp 1499373 /trunk/qpid/cpp/src/qpid/broker/Queue.h 1499373 /trunk/qpid/cpp/src/qpid/broker/Queue.cpp 1499373 /trunk/qpid/cpp/src/qpid/broker/QueueSettings.h 1499373 /trunk/qpid/cpp/src/qpid/broker/QueueSettings.cpp 1499373 /trunk/qpid/cpp/src/qpid/broker/SemanticState.cpp 1499373 /trunk/qpid/cpp/src/qpid/broker/SessionAdapter.cpp 1499373 /trunk/qpid/cpp/src/qpid/broker/amqp/Connection.cpp 1499373 /trunk/qpid/cpp/src/qpid/broker/amqp/DataReader.cpp 1499373 /trunk/qpid/cpp/src/qpid/broker/amqp/NodeProperties.h 1499373 /trunk/qpid/cpp/src/qpid/broker/amqp/NodeProperties.cpp 1499373 /trunk/qpid/cpp/src/qpid/broker/amqp/Outgoing.h 1499373 /trunk/qpid/cpp/src/qpid/broker/amqp/Outgoing.cpp 1499373 /trunk/qpid/cpp/src/qpid/broker/amqp/Session.h 1499373 /trunk/qpid/cpp/src/qpid/broker/amqp/Session.cpp 1499373 /trunk/qpid/cpp/src/qpid/ha/BrokerReplicator.cpp 1499373 /trunk/qpid/cpp/src/qpid/ha/QueueReplicator.cpp 1499373 /trunk/qpid/cpp/src/qpid/messaging/amqp/AddressHelper.cpp 1499373 /trunk/qpid/cpp/src/tests/QueueTest.cpp 1499373 Diff: https://reviews.apache.org/r/12249/diff/ Testing --- Thanks, Gordon Sim
[jira] [Commented] (QPID-4977) [Java Broker] the virtualhost creation dialog doesnt display the store related fields on older browsers
[ https://issues.apache.org/jira/browse/QPID-4977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13700998#comment-13700998 ] ASF subversion and git services commented on QPID-4977: --- Commit 1500070 from [~godfrer] [ https://svn.apache.org/r1500070 ] QPID-4977 : [Java Broker] the virtualhost creation dialog doesnt display the store related fields on older browsers [Java Broker] the virtualhost creation dialog doesnt display the store related fields on older browsers --- Key: QPID-4977 URL: https://issues.apache.org/jira/browse/QPID-4977 Project: Qpid Issue Type: Bug Components: Java Broker Affects Versions: 0.23 Reporter: Robbie Gemmell Fix For: 0.23 Following the changes in QPID-4937 to support virtualhosts of specific types, the virtualhost creation dialog in the web management ui doesn't display the store related fields on older browsers (e.g IE8 and older Firefox releases), apparently due to use of a method they don't support: Error: String(type).trim is not a function Source File: http://127.0.0.1:8080/js/qpid/management/addVirtualHost.js Line: 153 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
Re: Review Request 12249: add support for 1.0 lifetime policy to queues
On July 5, 2013, 2:20 p.m., Alan Conway wrote: /trunk/qpid/cpp/src/qpid/broker/Queue.h, line 126 https://reviews.apache.org/r/12249/diff/1-2/?file=317951#file317951line126 Not sure what use case means. Is the controller a subscriber? It could be. Right now in practical terms it is either a sending or receiving link over 1.0 and is only relevant for policy options that are currently only exposed for queues created in response to an attach with the dynamic flag set on the terminus. However in answering the question I realise I haven't set it for sending links, so will fix that. I'll see if I can come up with wording for this comment that is a clearer also. - Gordon --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12249/#review22781 --- On July 4, 2013, 7:39 p.m., Gordon Sim wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12249/ --- (Updated July 4, 2013, 7:39 p.m.) Review request for qpid, Alan Conway and Kenneth Giusti. Bugs: QPID-4976 https://issues.apache.org/jira/browse/QPID-4976 Repository: qpid Description --- This adds the ability to have queue autodeleted when no longer used, when empty or when both no longer used and empty as specified in the standard lifetime policies for AMQP 1.0. The ability to only delete if unused and empty is useful for 0-10 also so I've allowed these to be set there as well. The basic change is to have an optional policy specified that dictates what autodelete means. The default is to autodelete when not used. A queue is in use if it is being consumed or browsed, or if in 0-10 it has been declared as an exclusive queue and the declaring session is still active. Additionally over 1.0 the queue is in use if there is any sender attached to it. Autodeletion is now triggered automatically by the queue when some other operation moves it to a state eligible for deletion. To avoid this on a backup in ha, the queue replicator flags the replica as in use. Diffs - /trunk/qpid/cpp/src/qpid/amqp/descriptors.h 1499373 /trunk/qpid/cpp/src/qpid/broker/LossyQueue.cpp 1499373 /trunk/qpid/cpp/src/qpid/broker/Lvq.cpp 1499373 /trunk/qpid/cpp/src/qpid/broker/Queue.h 1499373 /trunk/qpid/cpp/src/qpid/broker/Queue.cpp 1499373 /trunk/qpid/cpp/src/qpid/broker/QueueSettings.h 1499373 /trunk/qpid/cpp/src/qpid/broker/QueueSettings.cpp 1499373 /trunk/qpid/cpp/src/qpid/broker/SemanticState.cpp 1499373 /trunk/qpid/cpp/src/qpid/broker/SessionAdapter.cpp 1499373 /trunk/qpid/cpp/src/qpid/broker/amqp/Connection.cpp 1499373 /trunk/qpid/cpp/src/qpid/broker/amqp/DataReader.cpp 1499373 /trunk/qpid/cpp/src/qpid/broker/amqp/NodeProperties.h 1499373 /trunk/qpid/cpp/src/qpid/broker/amqp/NodeProperties.cpp 1499373 /trunk/qpid/cpp/src/qpid/broker/amqp/Outgoing.h 1499373 /trunk/qpid/cpp/src/qpid/broker/amqp/Outgoing.cpp 1499373 /trunk/qpid/cpp/src/qpid/broker/amqp/Session.h 1499373 /trunk/qpid/cpp/src/qpid/broker/amqp/Session.cpp 1499373 /trunk/qpid/cpp/src/qpid/ha/BrokerReplicator.cpp 1499373 /trunk/qpid/cpp/src/qpid/ha/QueueReplicator.cpp 1499373 /trunk/qpid/cpp/src/qpid/messaging/amqp/AddressHelper.cpp 1499373 /trunk/qpid/cpp/src/tests/QueueTest.cpp 1499373 Diff: https://reviews.apache.org/r/12249/diff/ Testing --- Thanks, Gordon Sim
[jira] [Resolved] (QPID-4977) [Java Broker] the virtualhost creation dialog doesnt display the store related fields on older browsers
[ https://issues.apache.org/jira/browse/QPID-4977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Godfrey resolved QPID-4977. --- Resolution: Fixed Fixed by using dojo/string.trim() [Java Broker] the virtualhost creation dialog doesnt display the store related fields on older browsers --- Key: QPID-4977 URL: https://issues.apache.org/jira/browse/QPID-4977 Project: Qpid Issue Type: Bug Components: Java Broker Affects Versions: 0.23 Reporter: Robbie Gemmell Assignee: Rob Godfrey Fix For: 0.23 Following the changes in QPID-4937 to support virtualhosts of specific types, the virtualhost creation dialog in the web management ui doesn't display the store related fields on older browsers (e.g IE8 and older Firefox releases), apparently due to use of a method they don't support: Error: String(type).trim is not a function Source File: http://127.0.0.1:8080/js/qpid/management/addVirtualHost.js Line: 153 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (QPID-4977) [Java Broker] the virtualhost creation dialog doesnt display the store related fields on older browsers
[ https://issues.apache.org/jira/browse/QPID-4977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Godfrey reassigned QPID-4977: - Assignee: Rob Godfrey [Java Broker] the virtualhost creation dialog doesnt display the store related fields on older browsers --- Key: QPID-4977 URL: https://issues.apache.org/jira/browse/QPID-4977 Project: Qpid Issue Type: Bug Components: Java Broker Affects Versions: 0.23 Reporter: Robbie Gemmell Assignee: Rob Godfrey Fix For: 0.23 Following the changes in QPID-4937 to support virtualhosts of specific types, the virtualhost creation dialog in the web management ui doesn't display the store related fields on older browsers (e.g IE8 and older Firefox releases), apparently due to use of a method they don't support: Error: String(type).trim is not a function Source File: http://127.0.0.1:8080/js/qpid/management/addVirtualHost.js Line: 153 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
Re: Review Request 12275: Platform neutral helper functions.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12275/#review22788 --- http://svn.apache.org/repos/asf/qpid/proton/trunk/examples/include/pncompat/misc_defs.h https://reviews.apache.org/r/12275/#comment46489 PNCOMPAT ? My experience with CMake and Visual Studio is that you must run cmake on the system where the final generated projects will run. You can't run cmake on your development system to produce VS solutions and projects that can run on an arbitrary system elsewhere. For the qpid WinSDK I started forcing the customers to run cmake in order to generate the examples. If you can get over raising the bar so high that the customer must run cmake then many packaging issues become much simpler. - Chug Rolke On July 5, 2013, 6:17 a.m., Cliff Jansen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12275/ --- (Updated July 5, 2013, 6:17 a.m.) Review request for qpid, Andrew Stitcher, Kenneth Giusti, and Rafael Schloming. Bugs: proton-348 https://issues.apache.org/jira/browse/proton-348 Repository: qpid Description --- This patch tries to minimize the impact of incorporating platform neutral code into the examples and the native C++ tests. I dislike the thought of dragging around a compatibility library that needs to be linked to some examples and not others. I am also not keen to have the qpid-proton library expose non-core functionality that users start using in real code and expect to be around for all time. As a further wrinkle, we may wish to distribute examples with Visual Studio projects to Windows users without the benefit of CMake infrastructure. The implication being that some platform magic that works in the main build courtesy of CMake may need to be implemented differently. The proposed patch is not particularly pretty, but hopefully leaves light footprints when the helper functions are needed. The code needs to be included exactly once per executable when needed. A portable pragma weak directive, if it existed, could have made this simpler. * Usage for a single compilation unit: * * #include pncompat/misc_funcs.i * * Usage for multiple combined compilation units: chose one to include * pncompat/misc_funcs.i as above and in each other unit needing the * definitions use * * #include pncompat/misc_defs.h The include/pncompat directory is placed under trunk/examples since you can't build the examples without it and the examples might be packaged separately. However the tests and even proton.c can find them when they are normally built. Diffs - http://svn.apache.org/repos/asf/qpid/proton/trunk/examples/include/pncompat/internal/LICENSE PRE-CREATION http://svn.apache.org/repos/asf/qpid/proton/trunk/examples/include/pncompat/internal/getopt.h PRE-CREATION http://svn.apache.org/repos/asf/qpid/proton/trunk/examples/include/pncompat/internal/getopt.c PRE-CREATION http://svn.apache.org/repos/asf/qpid/proton/trunk/examples/include/pncompat/misc_defs.h PRE-CREATION http://svn.apache.org/repos/asf/qpid/proton/trunk/examples/include/pncompat/misc_funcs.i PRE-CREATION http://svn.apache.org/repos/asf/qpid/proton/trunk/examples/messenger/c/recv.c 1499652 http://svn.apache.org/repos/asf/qpid/proton/trunk/examples/messenger/c/send.c 1499652 http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/CMakeLists.txt 1499652 http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/include/proton/object.h 1499652 http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/proton.c 1499652 http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/wincompat/getopt.h 1499652 http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/wincompat/internal/LICENSE 1499652 http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/wincompat/internal/getopt.h 1499652 http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/wincompat/internal/getopt.c 1499652 http://svn.apache.org/repos/asf/qpid/proton/trunk/tests/tools/apps/c/msgr-common.h 1499652 http://svn.apache.org/repos/asf/qpid/proton/trunk/tests/tools/apps/c/msgr-common.c 1499652 Diff: https://reviews.apache.org/r/12275/diff/ Testing --- windows, rhel6 Thanks, Cliff Jansen
[jira] [Commented] (QPID-4968) Dispatch - Generalized framework for embedded Python modules
[ https://issues.apache.org/jira/browse/QPID-4968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13701008#comment-13701008 ] ASF subversion and git services commented on QPID-4968: --- Commit 1500073 from [~tedross] [ https://svn.apache.org/r1500073 ] QPID-4968 - Added an adapter module for Python-to-Dispatch calls. Implemented LogAdapter within the dispatch module to allow Python modules to emit logs in Dispatch. Dispatch - Generalized framework for embedded Python modules Key: QPID-4968 URL: https://issues.apache.org/jira/browse/QPID-4968 Project: Qpid Issue Type: New Feature Components: Qpid Dispatch Reporter: Ted Ross Assignee: Ted Ross Dispatch uses embedded python for a number of purposes including configuration file parsing and route computation. This feature is a generalized embedded python capability that provides: - Data conversion between Python objects and Dispatch fields - Native logging from Python -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
Re: Review Request 12275: Platform neutral helper functions.
On July 5, 2013, 2:50 p.m., Kenneth Giusti wrote: http://svn.apache.org/repos/asf/qpid/proton/trunk/examples/include/pncompat/internal/getopt.h, line 15 https://reviews.apache.org/r/12275/diff/1/?file=318334#file318334line15 I suspect that this condition conflicts with the ASL license. It is certainly more restrictive than the ASL. I'm not a lawyer, though. But as a layman, this seems like it would require all binary copies of proton to have to reproduce this license (how? via a text display? or include a text file?) Kenneth Giusti wrote: Maybe the solution is to include this license in a top-level NOTICE file? The ASL requires all derivative works (including binaries) to include the NOTICE file if present. Again, IANAL My recollection is that this license was on the ASL approved list (straight BSD and that's why we chose it), note that the license file is just being moved in the tree. The only platform that would ship it in binary form would be Windows. I don't know if msrg-send is to be shipped in binary form or just built on a test system, the examples shouldn't be precompiled. That leaves proton.c and I think Rafi wanted to retire it. Perhaps I should raise a JIRA to track windows packaging for this issue? - Cliff --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12275/#review22782 --- On July 5, 2013, 6:17 a.m., Cliff Jansen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12275/ --- (Updated July 5, 2013, 6:17 a.m.) Review request for qpid, Andrew Stitcher, Kenneth Giusti, and Rafael Schloming. Bugs: proton-348 https://issues.apache.org/jira/browse/proton-348 Repository: qpid Description --- This patch tries to minimize the impact of incorporating platform neutral code into the examples and the native C++ tests. I dislike the thought of dragging around a compatibility library that needs to be linked to some examples and not others. I am also not keen to have the qpid-proton library expose non-core functionality that users start using in real code and expect to be around for all time. As a further wrinkle, we may wish to distribute examples with Visual Studio projects to Windows users without the benefit of CMake infrastructure. The implication being that some platform magic that works in the main build courtesy of CMake may need to be implemented differently. The proposed patch is not particularly pretty, but hopefully leaves light footprints when the helper functions are needed. The code needs to be included exactly once per executable when needed. A portable pragma weak directive, if it existed, could have made this simpler. * Usage for a single compilation unit: * * #include pncompat/misc_funcs.i * * Usage for multiple combined compilation units: chose one to include * pncompat/misc_funcs.i as above and in each other unit needing the * definitions use * * #include pncompat/misc_defs.h The include/pncompat directory is placed under trunk/examples since you can't build the examples without it and the examples might be packaged separately. However the tests and even proton.c can find them when they are normally built. Diffs - http://svn.apache.org/repos/asf/qpid/proton/trunk/examples/include/pncompat/internal/LICENSE PRE-CREATION http://svn.apache.org/repos/asf/qpid/proton/trunk/examples/include/pncompat/internal/getopt.h PRE-CREATION http://svn.apache.org/repos/asf/qpid/proton/trunk/examples/include/pncompat/internal/getopt.c PRE-CREATION http://svn.apache.org/repos/asf/qpid/proton/trunk/examples/include/pncompat/misc_defs.h PRE-CREATION http://svn.apache.org/repos/asf/qpid/proton/trunk/examples/include/pncompat/misc_funcs.i PRE-CREATION http://svn.apache.org/repos/asf/qpid/proton/trunk/examples/messenger/c/recv.c 1499652 http://svn.apache.org/repos/asf/qpid/proton/trunk/examples/messenger/c/send.c 1499652 http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/CMakeLists.txt 1499652 http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/include/proton/object.h 1499652 http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/proton.c 1499652 http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/wincompat/getopt.h 1499652 http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/wincompat/internal/LICENSE 1499652 http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/wincompat/internal/getopt.h 1499652
Re: Selectors and JMSTimestamp/creation-time (was Re: svn commit: r1500052 - in /qpid/trunk/qpid/cpp/src/qpid: amqp/ broker/ broker/amqp/ broker/amqp_0_10/)
On Fri, 2013-07-05 at 17:41 +0100, Gordon Sim wrote: On 07/05/2013 05:06 PM, astitc...@apache.org wrote: Author: astitcher Date: Fri Jul 5 16:06:14 2013 New Revision: 1500052 URL: http://svn.apache.org/r1500052 Log: QPID-4627: Implement most of the remaining selector special identifiers Implemented: message_id, correlation_id, jms_type, creation_time, absolute_expiry_time The creation_time property is currently implemented as the time the message was put on the queue (if enabled in the broker) as amqp 0_10 has no standard way to indicate the creation time and we're not currently holding the creation time for amqp 1.0 messages. Not sure what you mean by 'not holding'. The creation time is set by the client, not the broker (since it is in the bare message). I mean that the amqp/Message class currently ignores the creation-time, even if one is set. I was a little unsure whether the correct behaviour would be to use the creation-time as the queue timestamp or to keep it separate. It would make sense to use the creation time as the queue timestamp because the expiry time is calculated from it and the supplied ttl, and logically the expiry time is really the *creation-time* + the ttl. On the other hand there may be a specific reason to want the queued time separately from the creation time. JMSTimestamp is 'the time a message was handed off to a provider to be sent. It is not the time the message was actually transmitted because the actual send may occur later due to transactions or other client side queueing of messages.' It looks like the JMS client sends JMSTimestamp in the timestamp field of delivery-properties over 0-10 (though the 0-10 spec does say that is set on the server). Ok, I only looked at the amqp 0-10 classes and didn't find it there, perhaps we should modify the c++ client to do the same, that would make a lot of sense even if it is not strictly according to the standard. I think a better solution would therefore be to have a getCreationTime() in Message::Encoding and for the 0-10 encoding pull the timestamp out the delivery properties if there, and for 1.0 use the creation time. That way the implementation will be compliant with both AMQP and JMS when using 1.0, and compliant with JMS when using 0-10. I agree (I haven't closed the bug because there are still loose ends like this). Adding these comments to the bug itself too will be helpful. Andrew - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-4327) HA support for TX transactions.
[ https://issues.apache.org/jira/browse/QPID-4327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13701084#comment-13701084 ] ASF subversion and git services commented on QPID-4327: --- Commit 1500107 from [~aconway] [ https://svn.apache.org/r1500107 ] QPID-4327: Minor edits to ha-transactions.md HA support for TX transactions. --- Key: QPID-4327 URL: https://issues.apache.org/jira/browse/QPID-4327 Project: Qpid Issue Type: New Feature Components: C++ Clustering Affects Versions: 0.18 Reporter: Alan Conway Assignee: Alan Conway Add support for TX transactions in a HA cluster. Messages and accepts in a transaction must be executed atomically on backup brokers. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
Re: Website update 6
Please have a look at the head. I've made adjustments. http://people.apache.org/~jross/transom/head/ On Wed, Jul 3, 2013 at 6:41 AM, Robbie Gemmell robbie.gemm...@gmail.com wrote: I'm not sure if we are seeing different things, or just disagree on how well the documentation works when using IE8. I see the same thing you do. I think we disagree about the severity. This is what I see for the Java broker docbook content when using IE8 and Firefox http://people.apache.org/~robbie/qpid/website/2ndJuly2013/java_broker_book-ie8.png http://people.apache.org/~robbie/qpid/website/2ndJuly2013/java_broker_book-ff.png Is this what you get? The content being in a bolder and larger font than when using Firefox is a little annoying but obviously survivable, however that it also dwarfs the headings is more of an issue and for me makes the documentation significantly more difficult to use. Although annoying, I can overlook the links magically dropping on to new lines (it doesnt seem to do it all of the time, so that might even be an issue with the docbook source). I've introduced better contrast between the body and heading text on IE now. I have not, however, been able to figure out the problem with the links starting on new lines yet. I am not suggesting that we need to have anything like parity with the modern browsers, but I do think we should ensure the new site doesnt seem actively hostile to those still stuck on older browsers like IE8 (which is unfortunately still a lot of people). I agree, these are problems worth solving, and I will continue to work on them. Should they block the transition to the new site? In my opinion, they should not. Justin - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-4867) Failed cmake build on RHEL5 0.22 RC4
[ https://issues.apache.org/jira/browse/QPID-4867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13701109#comment-13701109 ] Jimmy Jones commented on QPID-4867: --- Still an issue in 0.24 alpha Failed cmake build on RHEL5 0.22 RC4 Key: QPID-4867 URL: https://issues.apache.org/jira/browse/QPID-4867 Project: Qpid Issue Type: Bug Affects Versions: 0.22 Environment: RHEL 5.8 Reporter: Jimmy Jones Fresh RHEL 5.8 VM: sudo yum install cmake boost-devel e2fsprogs-devel pkgconfig gcc-c++ make ruby doxygen graphviz tar xvzf qpid-cpp-0.22.tar.gz cd qpidc-0.22 mkdir BLD cd BLD cmake .. make Scanning dependencies of target docs-user-api Invalid value for DOT_IMAGE_FORMAT: `PNG'. Using the default. Error: tag INPUT: input source `/home/jimmy/qpidc-0.22/docs/api/doxygen_mainpage.h' does not exist make[2]: *** [docs/api/CMakeFiles/docs-user-api] Error 1 make[1]: *** [docs/api/CMakeFiles/docs-user-api.dir/all] Error 2 make: *** [all] Error 2 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
Re: 0.24 release update - alpha is available
Hi, From my testing I've got two issues: QPID-4867: Can't build qpid-cpp-0.24-alpha.tar.gz on RHEL5 (although qpid-0.24-alpha.tar.gz does) QPID-4826 has caused a regression of QPID-4417 so Perl bindings are broken on RHEL5 Jimmy - Original Message - From: Justin Ross Sent: 06/28/13 04:34 PM To: dev@qpid.apache.org Subject: 0.24 release update - alpha is available Hi, everyone. Our first 0.24 distribution is available here: http://people.apache.org/~jross/qpid-0.24-alpha/ My testing (autotools-centric, Fedora 16 x86-64) completed without errors, after a couple distribution issues were repaired first. http://people.apache.org/~jross/qpid-0.24-alpha-testing.txt Please give it a try and tell us what happened. Beta is set for two weeks from now, and with it we branch for release. After that, 0.24 bug fixes need approval, so take advantage of the alpha-beta window now if you can. Thanks! Justin --- 0.24 release page: https://cwiki.apache.org/confluence/display/qpid/0.24+Release - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-4826) Fix memory leak in Perl bindings when building with Swig 1.3.32
[ https://issues.apache.org/jira/browse/QPID-4826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13701110#comment-13701110 ] Jimmy Jones commented on QPID-4826: --- I can confirm a regression of QPID-4417 in 0.24 alpha Fix memory leak in Perl bindings when building with Swig 1.3.32 - Key: QPID-4826 URL: https://issues.apache.org/jira/browse/QPID-4826 Project: Qpid Issue Type: Bug Components: Perl Client Affects Versions: 0.18 Reporter: Darryl L. Pierce Assignee: Darryl L. Pierce Fix For: Future There is a memory leak that occurs when building the Perl language bindings generated with version of Swig earlier than 1.3.32. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (QPID-4980) [Java Broker] In HTTP Management make (standard) virtual host store attributes depended upon store type
Rob Godfrey created QPID-4980: - Summary: [Java Broker] In HTTP Management make (standard) virtual host store attributes depended upon store type Key: QPID-4980 URL: https://issues.apache.org/jira/browse/QPID-4980 Project: Qpid Issue Type: Bug Components: Java Broker Reporter: Rob Godfrey Assignee: Rob Godfrey When creating a standard virtual host through the HTTP management console one is able to choose the type of store to use... however each store has (in reality) different mandatory and optional attributes. The management console (and broker side validation in the REST api) should reflect these per-store-type differences -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-4980) [Java Broker] In HTTP Management make (standard) virtual host store attributes depended upon store type
[ https://issues.apache.org/jira/browse/QPID-4980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Godfrey updated QPID-4980: -- Issue Type: Improvement (was: Bug) [Java Broker] In HTTP Management make (standard) virtual host store attributes depended upon store type --- Key: QPID-4980 URL: https://issues.apache.org/jira/browse/QPID-4980 Project: Qpid Issue Type: Improvement Components: Java Broker Reporter: Rob Godfrey Assignee: Rob Godfrey When creating a standard virtual host through the HTTP management console one is able to choose the type of store to use... however each store has (in reality) different mandatory and optional attributes. The management console (and broker side validation in the REST api) should reflect these per-store-type differences -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-4980) [Java Broker] In HTTP Management make (standard) virtual host store attributes depended upon store type
[ https://issues.apache.org/jira/browse/QPID-4980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13701115#comment-13701115 ] ASF subversion and git services commented on QPID-4980: --- Commit 1500134 from [~godfrer] [ https://svn.apache.org/r1500134 ] QPID-4980 : [Java Broker] In HTTP Management make (standard) virtual host store attributes depended upon store type [Java Broker] In HTTP Management make (standard) virtual host store attributes depended upon store type --- Key: QPID-4980 URL: https://issues.apache.org/jira/browse/QPID-4980 Project: Qpid Issue Type: Improvement Components: Java Broker Reporter: Rob Godfrey Assignee: Rob Godfrey When creating a standard virtual host through the HTTP management console one is able to choose the type of store to use... however each store has (in reality) different mandatory and optional attributes. The management console (and broker side validation in the REST api) should reflect these per-store-type differences -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
Review Request 12289: QPID-4327: TransactionObserver interface.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12289/ --- Review request for qpid, Andrew Stitcher and Gordon Sim. Repository: qpid Description --- QPID-4327: TransactionObserver interface. Plugin can set TransactionObserverFactory to create TransactionObservers. TransactionObserver interface is called at each point in a transactions lifecycle. Currently only allows a single TransactionObserverFactory per broker. This is a bit ugly, any ideas to make it neater would be much appreciated. Diffs - /trunk/qpid/cpp/src/qpid/broker/Broker.h 1500107 /trunk/qpid/cpp/src/qpid/broker/Queue.cpp 1500107 /trunk/qpid/cpp/src/qpid/broker/SemanticState.cpp 1500107 /trunk/qpid/cpp/src/qpid/broker/TransactionObserver.h PRE-CREATION /trunk/qpid/cpp/src/qpid/broker/TxBuffer.h 1500107 /trunk/qpid/cpp/src/tests/brokertest.py 1500107 /trunk/qpid/cpp/src/tests/ha_tests.py 1500107 Diff: https://reviews.apache.org/r/12289/diff/ Testing --- It compiles Thanks, Alan Conway
[jira] [Commented] (QPID-4980) [Java Broker] In HTTP Management make (standard) virtual host store attributes depended upon store type
[ https://issues.apache.org/jira/browse/QPID-4980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13701188#comment-13701188 ] ASF subversion and git services commented on QPID-4980: --- Commit 1500169 from [~godfrer] [ https://svn.apache.org/r1500169 ] QPID-4980 : [Java Broker] add connection pool attributes to http management [Java Broker] In HTTP Management make (standard) virtual host store attributes depended upon store type --- Key: QPID-4980 URL: https://issues.apache.org/jira/browse/QPID-4980 Project: Qpid Issue Type: Improvement Components: Java Broker Reporter: Rob Godfrey Assignee: Rob Godfrey When creating a standard virtual host through the HTTP management console one is able to choose the type of store to use... however each store has (in reality) different mandatory and optional attributes. The management console (and broker side validation in the REST api) should reflect these per-store-type differences -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
