[jira] [Commented] (DISPATCH-848) Direct leak of 48 byte(s) in 1 object(s) allocated from qdr_core_subscribe in router_core/route_tables.c:149
[
https://issues.apache.org/jira/browse/DISPATCH-848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493593#comment-17493593
]
ASF GitHub Bot commented on DISPATCH-848:
-
jiridanek edited a comment on pull request #1052:
URL: https://github.com/apache/qpid-dispatch/pull/1052#issuecomment-1042476123
Marking as draft and dropping it from 1.19 milestone. The PR fixes the
leaks, but causes occasional shutdown crashes, which is not acceptable.
* [ ] don't forget to put the following system_test.py addition to
skupper-router
```python
super(Http2Server, self).__init__(self.args, name=name,
expect=expect)
if wait:
try:
self.wait_ready()
except Exception:
self.teardown()
raise
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Direct leak of 48 byte(s) in 1 object(s) allocated from qdr_core_subscribe in
> router_core/route_tables.c:149
>
>
> Key: DISPATCH-848
> URL: https://issues.apache.org/jira/browse/DISPATCH-848
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Tests
>Affects Versions: 1.1.0
> Environment: Git tip of Proton and Dtspatch, commit hashes follow
> {noformat}
> commit aece4ad2f4e4eb2d141020c59c393a30a79f53a9 (upstream/master)
> Author: Andrew Stitcher
> PROTON-1609: Fix C++ example flags
> {noformat}
> {noformat}
> commit 18c5f8d6293de4227c8c17ef08675cb4eaef689c (HEAD -> master,
> upstream/master)
> Author: Ganesh Murthy
> NO-JIRA - Removed accidental printf inclusion
> {noformat}
>Reporter: Jiri Daněk
>Priority: Minor
> Labels: memory-bug
> Fix For: Backlog
>
> Attachments: LSan.supp
>
>
> Compile Proton and Dispatch with the Address Sanitizer option (c.f.
> DISPATCH-809) and run ctest
> {noformat}
> # proton
> cmake .. -DBUILD_GO=OFF -DENABLE_SANITIZERS=ON
> -DCMAKE_INSTALL_PREFIX=../install_asan -DCMAKE_BUILD_TYPE=Release -GNinja
> {noformat}
> {noformat}
> # dispatch
> cmake .. -DUSE_SANITIZERS=ON
> -DProton_DIR=`pwd`/../../qpid-proton/install_asan/lib64/cmake/Proton/
> -DCMAKE_BUILD_TYPE=Release -GNinja
> LD_PRELOAD=/nix/store/zahs1kwq4742f6l6h7yy4mdj44zzc1kd-gcc-7-20170409-lib/lib/libasan.so
> ASAN_OPTIONS=symbolize=1,color=always
> LSAN_OPTIONS=suppressions=`pwd`/../../qpid-proton/LSan.supp
> PYTHONPATH=`pwd`/../../qpid-proton/install_asan/lib64/proton/bindings/python
> LD_LIBRARY_PATH=`pwd`/../../qpid-proton/install_asan/lib64 ctest -VV
> {noformat}
> {noformat}
> [...]
> 9: Test Case parse_tree_tests.test_matches: PASS
> 9: Test Case parse_tree_tests.test_multiple_matches: PASS
> 9:
> 9: =
> 9: ==25904==ERROR: LeakSanitizer: detected memory leaks
> 9:
> 9: Direct leak of 48 byte(s) in 1 object(s) allocated from:
> 9: #0 0x7fb5442cb050 in __interceptor_malloc
> (/nix/store/zahs1kwq4742f6l6h7yy4mdj44zzc1kd-gcc-7-20170409-lib/lib/libasan.so+0xd9050)
> 9: #1 0x7fb543dd94fe in qdr_core_subscribe
> ../src/router_core/route_tables.c:149
> 9: #2 0x7fb543d89ff0 in IoAdapter_init ../src/python_embedded.c:548
> 9: #3 0x7fb542ba8ecd in type_call
> (/nix/store/1snk2wkpv97an87pk1842fgskl1vqhkr-python-2.7.14/lib/libpython2.7.so.1.0+0x9fecd)
> 9:
> 9: -
> 9: Suppressions used:
> 9: count bytes template
> 9:13102021760 dictresize
> 9: 204 188272 _PyObject_GC_Malloc
> 9: 45 39369 PyString_FromStringAndSize
> 9: 308 15056 list_resize
> 9: 11 9784 PyString_FromString
> 9: 2 1280 _PyObject_GC_Resize
> 9:1035 24104 PyList_New
> 9: 14672 s_init
> 9: 1 32 PyThread_allocate_lock
> 9: 11 11097 type_new
> 9: 3 3984 unicode_resize
> 9: 179 204712 _PyUnicode_New.part.8
> 9: 11 8028 PyObject_Realloc
> 9: 37120 _ctypes_alloc_format_string
> 9: 3 24576 set_table_resize
> 9: -
> 9:
> 9: SUMMARY: AddressSanitizer: 48 byte(s) leaked in 1 allocation(s).
> 9/36 Test #9: unit_tests ***Failed0.21
> sec
> {noformat}
> The relevant functions are
> {code}
> static int IoAdapter_init(IoAdapter *self, PyObject *args, PyObject *kwds)
> {
> PyObject *addr;
> char aclass= 'L';
> char phase =
[GitHub] [qpid-dispatch] jiridanek edited a comment on pull request #1052: DISPATCH-848, DISPATCH-1962 Fix leak of IoAdapter_init
jiridanek edited a comment on pull request #1052: URL: https://github.com/apache/qpid-dispatch/pull/1052#issuecomment-1042476123 Marking as draft and dropping it from 1.19 milestone. The PR fixes the leaks, but causes occasional shutdown crashes, which is not acceptable. * [ ] don't forget to put the following system_test.py addition to skupper-router ```python super(Http2Server, self).__init__(self.args, name=name, expect=expect) if wait: try: self.wait_ready() except Exception: self.teardown() raise ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-848) Direct leak of 48 byte(s) in 1 object(s) allocated from qdr_core_subscribe in router_core/route_tables.c:149
[
https://issues.apache.org/jira/browse/DISPATCH-848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493592#comment-17493592
]
ASF GitHub Bot commented on DISPATCH-848:
-
jiridanek commented on pull request #1052:
URL: https://github.com/apache/qpid-dispatch/pull/1052#issuecomment-1042476123
Marking as draft and dropping it from 1.19 milestone. The PR fixes the
leaks, but causes occasional shutdown crashes, which is not acceptable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Direct leak of 48 byte(s) in 1 object(s) allocated from qdr_core_subscribe in
> router_core/route_tables.c:149
>
>
> Key: DISPATCH-848
> URL: https://issues.apache.org/jira/browse/DISPATCH-848
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Tests
>Affects Versions: 1.1.0
> Environment: Git tip of Proton and Dtspatch, commit hashes follow
> {noformat}
> commit aece4ad2f4e4eb2d141020c59c393a30a79f53a9 (upstream/master)
> Author: Andrew Stitcher
> PROTON-1609: Fix C++ example flags
> {noformat}
> {noformat}
> commit 18c5f8d6293de4227c8c17ef08675cb4eaef689c (HEAD -> master,
> upstream/master)
> Author: Ganesh Murthy
> NO-JIRA - Removed accidental printf inclusion
> {noformat}
>Reporter: Jiri Daněk
>Priority: Minor
> Labels: memory-bug
> Fix For: Backlog
>
> Attachments: LSan.supp
>
>
> Compile Proton and Dispatch with the Address Sanitizer option (c.f.
> DISPATCH-809) and run ctest
> {noformat}
> # proton
> cmake .. -DBUILD_GO=OFF -DENABLE_SANITIZERS=ON
> -DCMAKE_INSTALL_PREFIX=../install_asan -DCMAKE_BUILD_TYPE=Release -GNinja
> {noformat}
> {noformat}
> # dispatch
> cmake .. -DUSE_SANITIZERS=ON
> -DProton_DIR=`pwd`/../../qpid-proton/install_asan/lib64/cmake/Proton/
> -DCMAKE_BUILD_TYPE=Release -GNinja
> LD_PRELOAD=/nix/store/zahs1kwq4742f6l6h7yy4mdj44zzc1kd-gcc-7-20170409-lib/lib/libasan.so
> ASAN_OPTIONS=symbolize=1,color=always
> LSAN_OPTIONS=suppressions=`pwd`/../../qpid-proton/LSan.supp
> PYTHONPATH=`pwd`/../../qpid-proton/install_asan/lib64/proton/bindings/python
> LD_LIBRARY_PATH=`pwd`/../../qpid-proton/install_asan/lib64 ctest -VV
> {noformat}
> {noformat}
> [...]
> 9: Test Case parse_tree_tests.test_matches: PASS
> 9: Test Case parse_tree_tests.test_multiple_matches: PASS
> 9:
> 9: =
> 9: ==25904==ERROR: LeakSanitizer: detected memory leaks
> 9:
> 9: Direct leak of 48 byte(s) in 1 object(s) allocated from:
> 9: #0 0x7fb5442cb050 in __interceptor_malloc
> (/nix/store/zahs1kwq4742f6l6h7yy4mdj44zzc1kd-gcc-7-20170409-lib/lib/libasan.so+0xd9050)
> 9: #1 0x7fb543dd94fe in qdr_core_subscribe
> ../src/router_core/route_tables.c:149
> 9: #2 0x7fb543d89ff0 in IoAdapter_init ../src/python_embedded.c:548
> 9: #3 0x7fb542ba8ecd in type_call
> (/nix/store/1snk2wkpv97an87pk1842fgskl1vqhkr-python-2.7.14/lib/libpython2.7.so.1.0+0x9fecd)
> 9:
> 9: -
> 9: Suppressions used:
> 9: count bytes template
> 9:13102021760 dictresize
> 9: 204 188272 _PyObject_GC_Malloc
> 9: 45 39369 PyString_FromStringAndSize
> 9: 308 15056 list_resize
> 9: 11 9784 PyString_FromString
> 9: 2 1280 _PyObject_GC_Resize
> 9:1035 24104 PyList_New
> 9: 14672 s_init
> 9: 1 32 PyThread_allocate_lock
> 9: 11 11097 type_new
> 9: 3 3984 unicode_resize
> 9: 179 204712 _PyUnicode_New.part.8
> 9: 11 8028 PyObject_Realloc
> 9: 37120 _ctypes_alloc_format_string
> 9: 3 24576 set_table_resize
> 9: -
> 9:
> 9: SUMMARY: AddressSanitizer: 48 byte(s) leaked in 1 allocation(s).
> 9/36 Test #9: unit_tests ***Failed0.21
> sec
> {noformat}
> The relevant functions are
> {code}
> static int IoAdapter_init(IoAdapter *self, PyObject *args, PyObject *kwds)
> {
> PyObject *addr;
> char aclass= 'L';
> char phase = '0';
> int treatment = QD_TREATMENT_ANYCAST_CLOSEST;
> if (!PyArg_ParseTuple(args, "OO|cci", >handler, , ,
> , ))
> return -1;
> if (!PyCallable_Check(self->handler)) {
> PyErr_SetString(PyExc_TypeError, "IoAdapter.__init__ handler is not
> callable");
> return -1;
> }
> if (treatment == QD_TREATMENT_ANYCAST_BALANCED) {
>
[GitHub] [qpid-dispatch] jiridanek commented on pull request #1052: DISPATCH-848, DISPATCH-1962 Fix leak of IoAdapter_init
jiridanek commented on pull request #1052: URL: https://github.com/apache/qpid-dispatch/pull/1052#issuecomment-1042476123 Marking as draft and dropping it from 1.19 milestone. The PR fixes the leaks, but causes occasional shutdown crashes, which is not acceptable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2144) Fatal Python error: _PyMem_DebugMalloc: Python memory allocator called without holding the GIL
[
https://issues.apache.org/jira/browse/DISPATCH-2144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493590#comment-17493590
]
ASF GitHub Bot commented on DISPATCH-2144:
--
jiridanek edited a comment on pull request #1499:
URL: https://github.com/apache/qpid-dispatch/pull/1499#issuecomment-1033898262
@kgiusti This won't work as of yet, for several reasons
1. https://github.com/apache/qpid-dispatch/pull/1052 has to be fixed, but
that PR itself is broken, because I can't do proper shutdown reliably, which is
hopefully addressed in followup work to
https://github.com/skupperproject/skupper-router/pull/50
I think that is all the reasons. I'll add more if I can think of something.
edit: removed no longer valid reason
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Fatal Python error: _PyMem_DebugMalloc: Python memory allocator called
> without holding the GIL
> --
>
> Key: DISPATCH-2144
> URL: https://issues.apache.org/jira/browse/DISPATCH-2144
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Policy Engine
>Affects Versions: 1.16.0
>Reporter: Jiri Daněk
>Assignee: Ken Giusti
>Priority: Major
> Fix For: 1.19.0
>
>
> To reproduce, install python3-debug on Fedora, then use it to build and run
> Dispatch
> https://github.com/jiridanek/qpid-dispatch/runs/2629007367?check_suite_focus=true#step:25:7044
> {noformat}
> 25: Router QDR.Policy output file:
> 25:
> 25:
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/python/qpid_dispatch_internal/policy/policy_util.py:65:
> ResourceWarning: unclosed family=AddressFamily.AF_INET6, type=SocketKind.SOCK_STREAM, proto=0,
> laddr=('::', 0, 0, 0)>
> 25: if is_ipv6_enabled():
> 25: ResourceWarning: Enable tracemalloc to get the object allocation traceback
> 25: Fatal Python error: _PyMem_DebugMalloc: Python memory allocator called
> without holding the GIL
> 25: Python runtime state: initialized
> 25:
> 25: Thread 0x7f0e8fffcec0 (most recent call first):
> 25:
> {noformat}
> Unrelated error in the same log that I noticed at random
> {noformat}
> 23: E /builddir/build/BUILD/Python-3.9.5/Modules/gcmodule.c:114:
> gc_decref: Assertion "gc_get_refs(g) > 0" failed: refcount is too small
> 23: E Enable tracemalloc to get the memory block allocation
> traceback
> 23: E
> 23: E object address : 0x7fd3e1b90cd0
> 23: E object refcount : 117
> 23: E object type : 0x7b695c30
> 23: E object type name: Agent
> 23: E object repr :
>
> 23: E
> 23: E Fatal Python error: _PyObject_AssertFailed:
> _PyObject_AssertFailed
> 23: E Python runtime state: initialized
> 23: E
> 23: E Current thread 0x7fd3e39e3ec0 (most recent call first):
> 23: E
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek edited a comment on pull request #1499: DISPATCH-2144 Use python3-dbg in the Debug GHA build
jiridanek edited a comment on pull request #1499: URL: https://github.com/apache/qpid-dispatch/pull/1499#issuecomment-1033898262 @kgiusti This won't work as of yet, for several reasons 1. https://github.com/apache/qpid-dispatch/pull/1052 has to be fixed, but that PR itself is broken, because I can't do proper shutdown reliably, which is hopefully addressed in followup work to https://github.com/skupperproject/skupper-router/pull/50 I think that is all the reasons. I'll add more if I can think of something. edit: removed no longer valid reason -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2314) TSAN data race when setting the presettled flag
[
https://issues.apache.org/jira/browse/DISPATCH-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493583#comment-17493583
]
ASF subversion and git services commented on DISPATCH-2314:
---
Commit 4c8008b2433028fe165b93a4a1a60b5e55e0f5a2 in qpid-dispatch's branch
refs/heads/dependabot/npm_and_yarn/console/react/react-scripts-5.0.0 from
Ganesh Murthy
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=4c8008b ]
DISPATCH-2314: Added TSAN suppression entry to suppress errors when setting the
presettled flag in qdr_delivery_continue_CT
> TSAN data race when setting the presettled flag
> ---
>
> Key: DISPATCH-2314
> URL: https://issues.apache.org/jira/browse/DISPATCH-2314
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Container
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
> Labels: race-condition, tsan
> Fix For: 1.19.0
>
>
> {noformat}
> 21: E Process 2380 error: exit code 66, expected 0
> 21: E qdrouterd -c test-router.conf -I
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/python
> 21: E
> /__w/qpid-dispatch/qpid-dispatch/qpid-dispatch/build/tests/system_test.dir/system_tests_one_router/OneRouterTest/setUpClass/test-router-9.cmd
> 21: E
> 21: E ==
> 21: E WARNING: ThreadSanitizer: data race (pid=2380)
> 21: E Write of size 1 at 0x7b440003d355 by thread T4:
> 21: E #0 qdr_delivery_set_presettled
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_core/delivery.c:136
> (qdrouterd+0x49d8c5)
> 21: E #1 AMQP_rx_handler
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_node.c:538
> (qdrouterd+0x4d2ff5)
> 21: E #2 deferred_AMQP_rx_handler
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_node.c:922
> (qdrouterd+0x4d37b2)
> 21: E #3 invoke_deferred_calls
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:801
> (qdrouterd+0x4d584b)
> 21: E #4 invoke_deferred_calls
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:790
> (qdrouterd+0x4d8b16)
> 21: E #5 handle
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1058
> (qdrouterd+0x4d8b16)
> 21: E #6 thread_run
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1133
> (qdrouterd+0x4dae84)
> 21: E #7 _thread_init
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/posix/threading.c:172
> (qdrouterd+0x48160d)
> 21: E
> 21: E Previous read of size 1 at 0x7b440003d355 by thread T1:
> 21: E #0 qdr_delivery_continue_CT
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_core/delivery.c:1108
> (qdrouterd+0x49f9e2)
> 21: E #1 router_core_thread
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_core/router_core_thread.c:236
> (qdrouterd+0x4b572a)
> 21: E #2 _thread_init
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/posix/threading.c:172
> (qdrouterd+0x48160d)
> 21: E
> 21: E Location is heap block of size 320 at 0x7b440003d2c0
> allocated by thread T3:
> 21: E #0 posix_memalign (libtsan.so.0+0x32a23)
> 21: E #1 qd_alloc
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/alloc_pool.c:391
> (qdrouterd+0x44ad29)
> 21: E #2 new_qdr_delivery_t
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_core/delivery.c:24
> (qdrouterd+0x49d33c)
> 21: E #3 qdr_link_deliver
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_core/transfer.c:64
> (qdrouterd+0x4bb125)
> 21: E #4 AMQP_rx_handler
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_node.c:877
> (qdrouterd+0x4d3106)
> 21: E #5 do_receive
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/container.c:219
> (qdrouterd+0x45f234)
> 21: E #6 qd_container_handle_event
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/container.c:734
> (qdrouterd+0x45f234)
> 21: E #7 handle
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1108
> (qdrouterd+0x4d8b41)
> 21: E #8 thread_run
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1133
> (qdrouterd+0x4dae84)
> 21: E #9 _thread_init
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/posix/threading.c:172
>
[jira] [Commented] (DISPATCH-2234) Update JavaScript console packages for the 1.19.0 release
[ https://issues.apache.org/jira/browse/DISPATCH-2234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493584#comment-17493584 ] ASF subversion and git services commented on DISPATCH-2234: --- Commit 25261f44f6f6ea20c44816eb8fc8b9535e5c65d0 in qpid-dispatch's branch refs/heads/dependabot/npm_and_yarn/console/react/react-scripts-5.0.0 from Jiri Daněk [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=25261f4 ] DISPATCH-2234: Update JavaScript console packages for the 1.19.0 release (#1517) * Error: A is only ever to be used as the child of element, never rendered directly. Please wrap your in a . * Error: You cannot render a inside another . You should never have more than one in your app. See https://reactrouter.com/docs/en/v6/upgrading/v5, and therein linked https://gist.github.com/mjackson/d54b40a094277b7afdd6b81f51a0393f * BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default. * Module not found: Error: Can't resolve 'os' in '/home/jdanek/repos/qpid/qpid-dispatch/console/react/node_modules/rhea/lib' * https://github.com/facebook/create-react-app/issues/11756 * downgraded and filled https://github.com/amqp/rhea/issues/379 > Update JavaScript console packages for the 1.19.0 release > - > > Key: DISPATCH-2234 > URL: https://issues.apache.org/jira/browse/DISPATCH-2234 > Project: Qpid Dispatch > Issue Type: Task > Components: Console >Reporter: Jiri Daněk >Assignee: Jiri Daněk >Priority: Major > Fix For: 1.19.0 > > -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2330) system_tests_one_router fails in test_30_presettled_overflow test
[
https://issues.apache.org/jira/browse/DISPATCH-2330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493581#comment-17493581
]
ASF subversion and git services commented on DISPATCH-2330:
---
Commit 75607d11fee7d76e681b040f805542074fc16006 in qpid-dispatch's branch
refs/heads/dependabot/npm_and_yarn/console/react/react-scripts-5.0.0 from
Ganesh Murthy
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=75607d1 ]
DISPATCH-2330: Removed test_30_presettled_overflow since that test case is
already covered in system_tests_delivery_counts.OneRouterLinkCountersTest
testMethod=test_06_large_message_released
> system_tests_one_router fails in test_30_presettled_overflow test
> -
>
> Key: DISPATCH-2330
> URL: https://issues.apache.org/jira/browse/DISPATCH-2330
> Project: Qpid Dispatch
> Issue Type: Test
> Components: Tests
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.19.0
>
>
> {noformat}
> self = testMethod=test_30_presettled_overflow>
> def test_30_presettled_overflow(self):
> test = PresettledOverflowTest(self.address)
> test.run()
> > self.assertIsNone(test.error)
>AssertionError: 'No deliveries were dropped' is not None {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2329) system_tests_delivery_count failing on test_06_large_message_released
[
https://issues.apache.org/jira/browse/DISPATCH-2329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493580#comment-17493580
]
ASF subversion and git services commented on DISPATCH-2329:
---
Commit b7918db600decd9b610f8401ff306261674cfdb8 in qpid-dispatch's branch
refs/heads/dependabot/npm_and_yarn/console/react/react-scripts-5.0.0 from
Ganesh Murthy
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=b7918db ]
DISPATCH-2329: Explicity check for released counts instead of delivery counts
of deliveries that are being released
> system_tests_delivery_count failing on test_06_large_message_released
> -
>
> Key: DISPATCH-2329
> URL: https://issues.apache.org/jira/browse/DISPATCH-2329
> Project: Qpid Dispatch
> Issue Type: Test
> Components: Tests
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.19.0
>
>
> {noformat}
> 44: === FAILURES
> ===
> 44: __ OneRouterLinkCountersTest.test_06_large_message_released
> ___
> 44: 44: self = testMethod=test_06_large_message_released>
> 44:
> 44: def test_06_large_message_released(self):
> 44: > self.verify_released(True)
> 44: 44:
> /home/runner/work/skupper-router/skupper-router/skupper-router/tests/system_tests_delivery_counts.py:1198:
>
> 44: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _ _ _
> 44:
> /home/runner/work/skupper-router/skupper-router/skupper-router/tests/system_tests_delivery_counts.py:1059:
> in verify_released
> 44: self.assertEqual(test.receiver_stats['releasedCount'], self.COUNT)
> 44: E AssertionError: 29 != 40
> 44: - generated xml file:
> /__w/skupper-router/skupper-router/skupper-router/build/tests/junitxmls/system_tests_delivery_counts.xml
> -
> 44: === short test summary info
>
> 44: FAILED ::OneRouterLinkCountersTest::test_06_large_message_released -
> Assertio...
> 44: 1 failed, 26 passed in 59.43s
> =
> 23/33 Test #44: system_tests_delivery_counts ...***Failed
> 59.76 sec
> = test session starts
> == {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2326) Remove HTTP1/HTTP2/TCP Adaptors from the source code.
[ https://issues.apache.org/jira/browse/DISPATCH-2326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493582#comment-17493582 ] ASF subversion and git services commented on DISPATCH-2326: --- Commit d7ba0a8557af57744a8e17b25f328e12d8db945a in qpid-dispatch's branch refs/heads/dependabot/npm_and_yarn/console/react/react-scripts-5.0.0 from Ganesh Murthy [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=d7ba0a8 ] DISPATCH-2326: Removed HTTP1/HTTP2/TCP adaptors and other adaptor related code > Remove HTTP1/HTTP2/TCP Adaptors from the source code. > -- > > Key: DISPATCH-2326 > URL: https://issues.apache.org/jira/browse/DISPATCH-2326 > Project: Qpid Dispatch > Issue Type: Task >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.19.0 > > > Remove all adaptor code and all supporting adaptor tests. Do not remove the > adaptor code API. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2328) c_unittests failing on RHEL 7
[
https://issues.apache.org/jira/browse/DISPATCH-2328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493579#comment-17493579
]
ASF subversion and git services commented on DISPATCH-2328:
---
Commit 50ee1d2e6a0ec9497b56024da41717e8423f11ad in qpid-dispatch's branch
refs/heads/dependabot/npm_and_yarn/console/react/react-scripts-5.0.0 from Jiri
Daněk
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=50ee1d2 ]
DISPATCH-2328: detect _FORTIFY_SOURCE in c_unittests and bail out (#1514)
> c_unittests failing on RHEL 7
> -
>
> Key: DISPATCH-2328
> URL: https://issues.apache.org/jira/browse/DISPATCH-2328
> Project: Qpid Dispatch
> Issue Type: Task
> Components: Tests
>Reporter: Ganesh Murthy
>Assignee: Jiri Daněk
>Priority: Major
> Fix For: 1.19.0
>
>
> {noformat}
> /home/jenkins/workspace/rh-qpid-dispatch-dist-el7-main/build/BUILD/qpid-dispatch-1.19.0/tests/c_unittests/test_terminus.cpp:42:
> TEST CASE: test_safe_snprintf
> vsnprintf failure (_STUB_)
> /home/jenkins/workspace/rh-qpid-dispatch-dist-el7-main/build/BUILD/qpid-dispatch-1.19.0/tests/c_unittests/test_terminus.cpp:94:
> ERROR: CHECK( 0 == len ) is NOT correct!
> values: CHECK( 0 == 9 )
> /home/jenkins/workspace/rh-qpid-dispatch-dist-el7-main/build/BUILD/qpid-dispatch-1.19.0/tests/c_unittests/test_terminus.cpp:95:
> ERROR: CHECK( '\0' == output[0] ) is NOT correct!
> values: CHECK( 0 == 115 ) {noformat}
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2323) [http1] system_tests_http1_adaptor failure due to Address already in use issue (second round)
[
https://issues.apache.org/jira/browse/DISPATCH-2323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493576#comment-17493576
]
ASF subversion and git services commented on DISPATCH-2323:
---
Commit d1ae8b218d3cdd7a346d7a5dd0a3afa8ae82d926 in qpid-dispatch's branch
refs/heads/dependabot/npm_and_yarn/console/react/react-scripts-5.0.0 from Jiri
Daněk
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=d1ae8b2 ]
DISPATCH-2323 Simplify test HTTPServer shutdown and fix its leaks
> [http1] system_tests_http1_adaptor failure due to Address already in use
> issue (second round)
> -
>
> Key: DISPATCH-2323
> URL: https://issues.apache.org/jira/browse/DISPATCH-2323
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Protocol Adaptors
>Affects Versions: 1.15.0
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
> Fix For: 1.19.0
>
>
> https://github.com/apache/qpid-dispatch/runs/4993651356?check_suite_focus=true#step:27:1904
> {noformat}
> 36/37 Test #70: system_tests_http1_adaptor ***Failed
> 351.39 sec
> = test session starts
> ==
> platform linux -- Python 3.6.8, pytest-6.2.5, py-1.11.0, pluggy-1.0.0 --
> /usr/bin/python3
> cachedir: .pytest_cache
> rootdir: /__w/qpid-dispatch/qpid-dispatch/qpid-dispatch/build/tests,
> configfile: tox.ini
> collecting ... collected 28 items
> ::Http1AdaptorManagementTest::test_01_create_delete FAILED
> ::Http1AdaptorManagementTest::test_01_delete_active_connector FAILED
> ::Http1AdaptorOneRouterTest::test_000_stats PASSED
> ::Http1AdaptorOneRouterTest::test_001_get PASSED
> ::Http1AdaptorOneRouterTest::test_002_head PASSED
> ::Http1AdaptorOneRouterTest::test_003_post PASSED
> ::Http1AdaptorOneRouterTest::test_004_put PASSED
> ::Http1AdaptorOneRouterTest::test_005_get_10 PASSED
> ::Http1AdaptorOneRouterTest::test_006_head_10 PASSED
> ::Http1AdaptorOneRouterTest::test_007_post_10 PASSED
> ::Http1AdaptorOneRouterTest::test_008_put_10 PASSED
> ::Http1AdaptorEdge2EdgeTest::test_01_concurrent_requests ERROR
> ::Http1AdaptorEdge2EdgeTest::test_02_credit_replenish ERROR
> ::Http1AdaptorEdge2EdgeTest::test_03_server_reconnect ERROR
> ::Http1AdaptorEdge2EdgeTest::test_04_server_pining_for_the_fjords ERROR
> ::Http1AdaptorEdge2EdgeTest::test_05_large_streaming_msg ERROR
> ::Http1AdaptorEdge2EdgeTest::test_1001_client_request_close ERROR
> ::Http1AdaptorEdge2EdgeTest::test_1002_client_response_close ERROR
> ::Http1AdaptorEdge2EdgeTest::test_2000_curl_get ERROR
> ::Http1AdaptorEdge2EdgeTest::test_2001_curl_put ERROR
> ::Http1AdaptorEdge2EdgeTest::test_2002_curl_post ERROR
> ::Http1AdaptorBadEndpointsTest::test_01_unsolicited_response PASSED
> ::Http1AdaptorBadEndpointsTest::test_02_bad_request_message PASSED
> ::Http1AdaptorBadEndpointsTest::test_03_bad_response_message PASSED
> ::Http1AdaptorBadEndpointsTest::test_04_client_request_close PASSED
> ::Http1AdaptorBadEndpointsTest::test_05_client_response_close PASSED
> ::Http1AdaptorQ2Standalone::test_01_backpressure_client PASSED
> ::Http1AdaptorQ2Standalone::test_02_backpressure_server PASSED
> ERRORS
>
> ___ ERROR at setup of Http1AdaptorEdge2EdgeTest.test_01_concurrent_requests
>
> cls =
> name = 'EA2', mode = 'edge'
> extra = [('connector', {'host': '127.0.0.1', 'idleTimeoutSeconds': '120',
> 'name': 'uplink', 'port': 25519, ...}), ('httpConnec...protocolVersion':
> 'HTTP1'}), ('httpConnector', {'address': 'testServer10', 'port': 25522,
> 'protocolVersion': 'HTTP1'})]
> @classmethod
> def router(cls, name, mode, extra):
> config = [
> ('router', {'mode': mode,
> 'id': name,
> 'allowUnsettledMulticast': 'yes'}),
> ('listener', {'role': 'normal',
> 'port': cls.tester.get_port()}),
> ('address', {'prefix': 'closest', 'distribution': 'closest'}),
> ('address', {'prefix': 'multicast', 'distribution': 'multicast'}),
> ]
>
> if extra:
> config.extend(extra)
> config = Qdrouterd.Config(config)
> > cls.routers.append(cls.tester.qdrouterd(name, config, wait=True))
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/tests/http1_tests.py:1198:
>
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/tests/system_test.py:795:
> in qdrouterd
> return self.cleanup(Qdrouterd(*args, **kwargs))
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/tests/system_test.py:481:
>
[jira] [Commented] (DISPATCH-2327) system_tests_multi_tenancy flaky link route test failures
[ https://issues.apache.org/jira/browse/DISPATCH-2327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493578#comment-17493578 ] ASF subversion and git services commented on DISPATCH-2327: --- Commit 5771f8b12ab6b5bd98bc4ac093c5926481e035b4 in qpid-dispatch's branch refs/heads/dependabot/npm_and_yarn/console/react/react-scripts-5.0.0 from Ken Giusti [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=5771f8b ] DISPATCH-2327: clean up link routes at end of tests This closes #1512 > system_tests_multi_tenancy flaky link route test failures > - > > Key: DISPATCH-2327 > URL: https://issues.apache.org/jira/browse/DISPATCH-2327 > Project: Qpid Dispatch > Issue Type: Bug > Components: Tests >Affects Versions: 1.18.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Fix For: 1.19.0 > > > Very occasionally one of the linkRoute tests in the > system_tests_multi_tenancy.py ctests will fail: > 38: FAIL: test_22_two_router_link_route_targeted_no_tenant > (system_tests_multi_tenancy.RouterTest) > > 38: -- > > 38: Traceback (most recent call last): > > 38: File "/home/kgiusti/work/dispatch/qpid-dispatch/test > /system_tests_multi_tenancy.py", line 290, in > test_22_two_router_link_route_targeted_no_tenant > > 38: self.assertIsNone(test.error) > > 38: AssertionError: 'Timeout Expired: n_sent=0 n_rcvd=0 n_settled=0' is not > None > Examining the router logs it appears as if the attempt to use the link route > is rejected with a "no route" error. > I believe the problem is that each test uses the same link route configured > address. Each test starts by establishing the route container connection > then polls the routers waiting for the link route address to propagate. Once > the poll succeeds the test starts. > IIUC what is happening is that at the end of each test the link route address > may still exist in the route tables - it has not been totally removed. This > causes the next test's poll to immediately succeed before the test's link > route has been properly propagated. This results in the failure if the new > link route doesn't establish itself before traffic is sent. > The fix is to have each test wait for all link route addresses to be removed > from the routing tables before the test ends. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2323) [http1] system_tests_http1_adaptor failure due to Address already in use issue (second round)
[
https://issues.apache.org/jira/browse/DISPATCH-2323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493577#comment-17493577
]
ASF subversion and git services commented on DISPATCH-2323:
---
Commit 115aa6237e39e88c271cfcb2c9d1d39d614071d0 in qpid-dispatch's branch
refs/heads/dependabot/npm_and_yarn/console/react/react-scripts-5.0.0 from Jiri
Daněk
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=115aa62 ]
DISPATCH-2323 Add Pytest-compatible logging displayed on test failure
> [http1] system_tests_http1_adaptor failure due to Address already in use
> issue (second round)
> -
>
> Key: DISPATCH-2323
> URL: https://issues.apache.org/jira/browse/DISPATCH-2323
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Protocol Adaptors
>Affects Versions: 1.15.0
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
> Fix For: 1.19.0
>
>
> https://github.com/apache/qpid-dispatch/runs/4993651356?check_suite_focus=true#step:27:1904
> {noformat}
> 36/37 Test #70: system_tests_http1_adaptor ***Failed
> 351.39 sec
> = test session starts
> ==
> platform linux -- Python 3.6.8, pytest-6.2.5, py-1.11.0, pluggy-1.0.0 --
> /usr/bin/python3
> cachedir: .pytest_cache
> rootdir: /__w/qpid-dispatch/qpid-dispatch/qpid-dispatch/build/tests,
> configfile: tox.ini
> collecting ... collected 28 items
> ::Http1AdaptorManagementTest::test_01_create_delete FAILED
> ::Http1AdaptorManagementTest::test_01_delete_active_connector FAILED
> ::Http1AdaptorOneRouterTest::test_000_stats PASSED
> ::Http1AdaptorOneRouterTest::test_001_get PASSED
> ::Http1AdaptorOneRouterTest::test_002_head PASSED
> ::Http1AdaptorOneRouterTest::test_003_post PASSED
> ::Http1AdaptorOneRouterTest::test_004_put PASSED
> ::Http1AdaptorOneRouterTest::test_005_get_10 PASSED
> ::Http1AdaptorOneRouterTest::test_006_head_10 PASSED
> ::Http1AdaptorOneRouterTest::test_007_post_10 PASSED
> ::Http1AdaptorOneRouterTest::test_008_put_10 PASSED
> ::Http1AdaptorEdge2EdgeTest::test_01_concurrent_requests ERROR
> ::Http1AdaptorEdge2EdgeTest::test_02_credit_replenish ERROR
> ::Http1AdaptorEdge2EdgeTest::test_03_server_reconnect ERROR
> ::Http1AdaptorEdge2EdgeTest::test_04_server_pining_for_the_fjords ERROR
> ::Http1AdaptorEdge2EdgeTest::test_05_large_streaming_msg ERROR
> ::Http1AdaptorEdge2EdgeTest::test_1001_client_request_close ERROR
> ::Http1AdaptorEdge2EdgeTest::test_1002_client_response_close ERROR
> ::Http1AdaptorEdge2EdgeTest::test_2000_curl_get ERROR
> ::Http1AdaptorEdge2EdgeTest::test_2001_curl_put ERROR
> ::Http1AdaptorEdge2EdgeTest::test_2002_curl_post ERROR
> ::Http1AdaptorBadEndpointsTest::test_01_unsolicited_response PASSED
> ::Http1AdaptorBadEndpointsTest::test_02_bad_request_message PASSED
> ::Http1AdaptorBadEndpointsTest::test_03_bad_response_message PASSED
> ::Http1AdaptorBadEndpointsTest::test_04_client_request_close PASSED
> ::Http1AdaptorBadEndpointsTest::test_05_client_response_close PASSED
> ::Http1AdaptorQ2Standalone::test_01_backpressure_client PASSED
> ::Http1AdaptorQ2Standalone::test_02_backpressure_server PASSED
> ERRORS
>
> ___ ERROR at setup of Http1AdaptorEdge2EdgeTest.test_01_concurrent_requests
>
> cls =
> name = 'EA2', mode = 'edge'
> extra = [('connector', {'host': '127.0.0.1', 'idleTimeoutSeconds': '120',
> 'name': 'uplink', 'port': 25519, ...}), ('httpConnec...protocolVersion':
> 'HTTP1'}), ('httpConnector', {'address': 'testServer10', 'port': 25522,
> 'protocolVersion': 'HTTP1'})]
> @classmethod
> def router(cls, name, mode, extra):
> config = [
> ('router', {'mode': mode,
> 'id': name,
> 'allowUnsettledMulticast': 'yes'}),
> ('listener', {'role': 'normal',
> 'port': cls.tester.get_port()}),
> ('address', {'prefix': 'closest', 'distribution': 'closest'}),
> ('address', {'prefix': 'multicast', 'distribution': 'multicast'}),
> ]
>
> if extra:
> config.extend(extra)
> config = Qdrouterd.Config(config)
> > cls.routers.append(cls.tester.qdrouterd(name, config, wait=True))
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/tests/http1_tests.py:1198:
>
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/tests/system_test.py:795:
> in qdrouterd
> return self.cleanup(Qdrouterd(*args, **kwargs))
>
[jira] [Commented] (DISPATCH-2234) Update JavaScript console packages for the 1.19.0 release
[ https://issues.apache.org/jira/browse/DISPATCH-2234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493572#comment-17493572 ] ASF subversion and git services commented on DISPATCH-2234: --- Commit 25261f44f6f6ea20c44816eb8fc8b9535e5c65d0 in qpid-dispatch's branch refs/heads/main from Jiri Daněk [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=25261f4 ] DISPATCH-2234: Update JavaScript console packages for the 1.19.0 release (#1517) * Error: A is only ever to be used as the child of element, never rendered directly. Please wrap your in a . * Error: You cannot render a inside another . You should never have more than one in your app. See https://reactrouter.com/docs/en/v6/upgrading/v5, and therein linked https://gist.github.com/mjackson/d54b40a094277b7afdd6b81f51a0393f * BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default. * Module not found: Error: Can't resolve 'os' in '/home/jdanek/repos/qpid/qpid-dispatch/console/react/node_modules/rhea/lib' * https://github.com/facebook/create-react-app/issues/11756 * downgraded and filled https://github.com/amqp/rhea/issues/379 > Update JavaScript console packages for the 1.19.0 release > - > > Key: DISPATCH-2234 > URL: https://issues.apache.org/jira/browse/DISPATCH-2234 > Project: Qpid Dispatch > Issue Type: Task > Components: Console >Reporter: Jiri Daněk >Assignee: Jiri Daněk >Priority: Major > Fix For: 1.19.0 > > -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek commented on pull request #1489: Bump react-scripts from 4.0.3 to 5.0.0 in /console/react
jiridanek commented on pull request #1489: URL: https://github.com/apache/qpid-dispatch/pull/1489#issuecomment-1042448489 https://github.com/amqp/rhea/issues/379 must be resolved first -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] dependabot[bot] closed pull request #1488: Bump react-router-dom from 5.2.0 to 6.2.1 in /console/react
dependabot[bot] closed pull request #1488: URL: https://github.com/apache/qpid-dispatch/pull/1488 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] dependabot[bot] commented on pull request #1488: Bump react-router-dom from 5.2.0 to 6.2.1 in /console/react
dependabot[bot] commented on pull request #1488: URL: https://github.com/apache/qpid-dispatch/pull/1488#issuecomment-1042448396 Looks like react-router-dom is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek removed a comment on pull request #1489: Bump react-scripts from 4.0.3 to 5.0.0 in /console/react
jiridanek removed a comment on pull request #1489: URL: https://github.com/apache/qpid-dispatch/pull/1489#issuecomment-1042447852 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] dependabot[bot] commented on pull request #1492: Bump typescript from 4.3.5 to 4.5.5 in /console/react
dependabot[bot] commented on pull request #1492: URL: https://github.com/apache/qpid-dispatch/pull/1492#issuecomment-1042448037 Looks like typescript is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] dependabot[bot] closed pull request #1492: Bump typescript from 4.3.5 to 4.5.5 in /console/react
dependabot[bot] closed pull request #1492: URL: https://github.com/apache/qpid-dispatch/pull/1492 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek commented on pull request #1488: Bump react-router-dom from 5.2.0 to 6.2.1 in /console/react
jiridanek commented on pull request #1488: URL: https://github.com/apache/qpid-dispatch/pull/1488#issuecomment-1042447954 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek commented on pull request #1489: Bump react-scripts from 4.0.3 to 5.0.0 in /console/react
jiridanek commented on pull request #1489: URL: https://github.com/apache/qpid-dispatch/pull/1489#issuecomment-1042447852 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] dependabot[bot] commented on pull request #1519: Bump @testing-library/react from 12.0.0 to 12.1.3 in /console/react
dependabot[bot] commented on pull request #1519: URL: https://github.com/apache/qpid-dispatch/pull/1519#issuecomment-1042447713 Looks like @testing-library/react is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] dependabot[bot] closed pull request #1520: Bump body-parser from 1.19.0 to 1.19.2 in /console/react
dependabot[bot] closed pull request #1520: URL: https://github.com/apache/qpid-dispatch/pull/1520 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek commented on pull request #1492: Bump typescript from 4.3.5 to 4.5.5 in /console/react
jiridanek commented on pull request #1492: URL: https://github.com/apache/qpid-dispatch/pull/1492#issuecomment-1042447721 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] dependabot[bot] closed pull request #1519: Bump @testing-library/react from 12.0.0 to 12.1.3 in /console/react
dependabot[bot] closed pull request #1519: URL: https://github.com/apache/qpid-dispatch/pull/1519 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] dependabot[bot] commented on pull request #1520: Bump body-parser from 1.19.0 to 1.19.2 in /console/react
dependabot[bot] commented on pull request #1520: URL: https://github.com/apache/qpid-dispatch/pull/1520#issuecomment-1042447667 Looks like body-parser is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek commented on pull request #1519: Bump @testing-library/react from 12.0.0 to 12.1.3 in /console/react
jiridanek commented on pull request #1519: URL: https://github.com/apache/qpid-dispatch/pull/1519#issuecomment-1042447434 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek commented on pull request #1520: Bump body-parser from 1.19.0 to 1.19.2 in /console/react
jiridanek commented on pull request #1520: URL: https://github.com/apache/qpid-dispatch/pull/1520#issuecomment-1042447359 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2234) Update JavaScript console packages for the 1.19.0 release
[ https://issues.apache.org/jira/browse/DISPATCH-2234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493560#comment-17493560 ] ASF GitHub Bot commented on DISPATCH-2234: -- jiridanek merged pull request #1517: URL: https://github.com/apache/qpid-dispatch/pull/1517 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update JavaScript console packages for the 1.19.0 release > - > > Key: DISPATCH-2234 > URL: https://issues.apache.org/jira/browse/DISPATCH-2234 > Project: Qpid Dispatch > Issue Type: Task > Components: Console >Reporter: Jiri Daněk >Assignee: Jiri Daněk >Priority: Major > Fix For: 1.19.0 > > -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek merged pull request #1517: DISPATCH-2234: Update JavaScript console packages for the 1.19.0 release
jiridanek merged pull request #1517: URL: https://github.com/apache/qpid-dispatch/pull/1517 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2234) Update JavaScript console packages for the 1.19.0 release
[
https://issues.apache.org/jira/browse/DISPATCH-2234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493550#comment-17493550
]
ASF GitHub Bot commented on DISPATCH-2234:
--
jiridanek commented on a change in pull request #1517:
URL: https://github.com/apache/qpid-dispatch/pull/1517#discussion_r808559059
##
File path: console/react/src/App.js
##
@@ -28,26 +29,22 @@ import "@patternfly/patternfly/components/Nav/nav.css";
import { QDRService } from "./common/qdrService";
import "./App.css";
import PageLayout from "./overview/dashboard/layout";
-class App extends Component {
- state = {};
-
- render() {
-// service is passed in to make testing easier
-const service = new QDRService();
-// also, a router is used here to provide PageLayout with a history
property
-return (
-
-
- (
-
-)}
- />
-
-
-);
- }
+
+function App(props) {
+
+ // service is passed in to make testing easier
+ let service = new QDRService();
+
+ // also, a router is used here to provide PageLayout with a history property
+ let history = createHashHistory({ window });
+
+ return (
+
Review comment:
Noted in https://issues.apache.org/jira/browse/DISPATCH-2331
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Update JavaScript console packages for the 1.19.0 release
> -
>
> Key: DISPATCH-2234
> URL: https://issues.apache.org/jira/browse/DISPATCH-2234
> Project: Qpid Dispatch
> Issue Type: Task
> Components: Console
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
> Fix For: 1.19.0
>
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek commented on a change in pull request #1517: DISPATCH-2234: Update JavaScript console packages for the 1.19.0 release
jiridanek commented on a change in pull request #1517:
URL: https://github.com/apache/qpid-dispatch/pull/1517#discussion_r808559059
##
File path: console/react/src/App.js
##
@@ -28,26 +29,22 @@ import "@patternfly/patternfly/components/Nav/nav.css";
import { QDRService } from "./common/qdrService";
import "./App.css";
import PageLayout from "./overview/dashboard/layout";
-class App extends Component {
- state = {};
-
- render() {
-// service is passed in to make testing easier
-const service = new QDRService();
-// also, a router is used here to provide PageLayout with a history
property
-return (
-
-
- (
-
-)}
- />
-
-
-);
- }
+
+function App(props) {
+
+ // service is passed in to make testing easier
+ let service = new QDRService();
+
+ // also, a router is used here to provide PageLayout with a history property
+ let history = createHashHistory({ window });
+
+ return (
+
Review comment:
Noted in https://issues.apache.org/jira/browse/DISPATCH-2331
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-2331) Modernize webconsole code related to react-router-dom
Jiri Daněk created DISPATCH-2331:
Summary: Modernize webconsole code related to react-router-dom
Key: DISPATCH-2331
URL: https://issues.apache.org/jira/browse/DISPATCH-2331
Project: Qpid Dispatch
Issue Type: Improvement
Components: Console
Affects Versions: 1.19.0
Reporter: Jiri Daněk
Fix For: 1.20.0
Suggestions from https://github.com/apache/qpid-dispatch/pull/1517
{quote}
* navigating between pages; which is now done inconsistently, either with
, or navigate(), or through history.
* the page structure which is supposed to use the feature but it does
not
{quote}
and
{quote}
Probably one of the things to do is refactor the PageLayout component as a
function (but this is out of the scope of this PR honestly) to use directly
hooks. So we can avoid passing history and use directly useNavigate and
useLocation. Then probably we can avoid passing {...props } because without
typescript we lose a bit the control of what we inject in the component.
Moreover the High order component 'WithRoute' will be deleted
{quote}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-2314) TSAN data race when setting the presettled flag
[
https://issues.apache.org/jira/browse/DISPATCH-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ganesh Murthy resolved DISPATCH-2314.
-
Fix Version/s: 1.19.0
Assignee: Ganesh Murthy
Resolution: Fixed
> TSAN data race when setting the presettled flag
> ---
>
> Key: DISPATCH-2314
> URL: https://issues.apache.org/jira/browse/DISPATCH-2314
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Container
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
> Labels: race-condition, tsan
> Fix For: 1.19.0
>
>
> {noformat}
> 21: E Process 2380 error: exit code 66, expected 0
> 21: E qdrouterd -c test-router.conf -I
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/python
> 21: E
> /__w/qpid-dispatch/qpid-dispatch/qpid-dispatch/build/tests/system_test.dir/system_tests_one_router/OneRouterTest/setUpClass/test-router-9.cmd
> 21: E
> 21: E ==
> 21: E WARNING: ThreadSanitizer: data race (pid=2380)
> 21: E Write of size 1 at 0x7b440003d355 by thread T4:
> 21: E #0 qdr_delivery_set_presettled
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_core/delivery.c:136
> (qdrouterd+0x49d8c5)
> 21: E #1 AMQP_rx_handler
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_node.c:538
> (qdrouterd+0x4d2ff5)
> 21: E #2 deferred_AMQP_rx_handler
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_node.c:922
> (qdrouterd+0x4d37b2)
> 21: E #3 invoke_deferred_calls
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:801
> (qdrouterd+0x4d584b)
> 21: E #4 invoke_deferred_calls
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:790
> (qdrouterd+0x4d8b16)
> 21: E #5 handle
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1058
> (qdrouterd+0x4d8b16)
> 21: E #6 thread_run
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1133
> (qdrouterd+0x4dae84)
> 21: E #7 _thread_init
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/posix/threading.c:172
> (qdrouterd+0x48160d)
> 21: E
> 21: E Previous read of size 1 at 0x7b440003d355 by thread T1:
> 21: E #0 qdr_delivery_continue_CT
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_core/delivery.c:1108
> (qdrouterd+0x49f9e2)
> 21: E #1 router_core_thread
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_core/router_core_thread.c:236
> (qdrouterd+0x4b572a)
> 21: E #2 _thread_init
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/posix/threading.c:172
> (qdrouterd+0x48160d)
> 21: E
> 21: E Location is heap block of size 320 at 0x7b440003d2c0
> allocated by thread T3:
> 21: E #0 posix_memalign (libtsan.so.0+0x32a23)
> 21: E #1 qd_alloc
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/alloc_pool.c:391
> (qdrouterd+0x44ad29)
> 21: E #2 new_qdr_delivery_t
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_core/delivery.c:24
> (qdrouterd+0x49d33c)
> 21: E #3 qdr_link_deliver
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_core/transfer.c:64
> (qdrouterd+0x4bb125)
> 21: E #4 AMQP_rx_handler
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_node.c:877
> (qdrouterd+0x4d3106)
> 21: E #5 do_receive
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/container.c:219
> (qdrouterd+0x45f234)
> 21: E #6 qd_container_handle_event
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/container.c:734
> (qdrouterd+0x45f234)
> 21: E #7 handle
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1108
> (qdrouterd+0x4d8b41)
> 21: E #8 thread_run
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1133
> (qdrouterd+0x4dae84)
> 21: E #9 _thread_init
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/posix/threading.c:172
> (qdrouterd+0x48160d)
> 21: E
> 21: E Thread T4 (tid=2385, running) created by main thread at:
> 21: E #0 pthread_create (libtsan.so.0+0x5bef5)
> 21: E #1 sys_thread
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/posix/threading.c:181
> (qdrouterd+0x481a9c)
> 21: E #2
[jira] [Commented] (DISPATCH-2314) TSAN data race when setting the presettled flag
[
https://issues.apache.org/jira/browse/DISPATCH-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493427#comment-17493427
]
ASF subversion and git services commented on DISPATCH-2314:
---
Commit 4c8008b2433028fe165b93a4a1a60b5e55e0f5a2 in qpid-dispatch's branch
refs/heads/main from Ganesh Murthy
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=4c8008b ]
DISPATCH-2314: Added TSAN suppression entry to suppress errors when setting the
presettled flag in qdr_delivery_continue_CT
> TSAN data race when setting the presettled flag
> ---
>
> Key: DISPATCH-2314
> URL: https://issues.apache.org/jira/browse/DISPATCH-2314
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Container
>Reporter: Ganesh Murthy
>Priority: Major
> Labels: race-condition, tsan
>
> {noformat}
> 21: E Process 2380 error: exit code 66, expected 0
> 21: E qdrouterd -c test-router.conf -I
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/python
> 21: E
> /__w/qpid-dispatch/qpid-dispatch/qpid-dispatch/build/tests/system_test.dir/system_tests_one_router/OneRouterTest/setUpClass/test-router-9.cmd
> 21: E
> 21: E ==
> 21: E WARNING: ThreadSanitizer: data race (pid=2380)
> 21: E Write of size 1 at 0x7b440003d355 by thread T4:
> 21: E #0 qdr_delivery_set_presettled
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_core/delivery.c:136
> (qdrouterd+0x49d8c5)
> 21: E #1 AMQP_rx_handler
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_node.c:538
> (qdrouterd+0x4d2ff5)
> 21: E #2 deferred_AMQP_rx_handler
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_node.c:922
> (qdrouterd+0x4d37b2)
> 21: E #3 invoke_deferred_calls
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:801
> (qdrouterd+0x4d584b)
> 21: E #4 invoke_deferred_calls
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:790
> (qdrouterd+0x4d8b16)
> 21: E #5 handle
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1058
> (qdrouterd+0x4d8b16)
> 21: E #6 thread_run
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1133
> (qdrouterd+0x4dae84)
> 21: E #7 _thread_init
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/posix/threading.c:172
> (qdrouterd+0x48160d)
> 21: E
> 21: E Previous read of size 1 at 0x7b440003d355 by thread T1:
> 21: E #0 qdr_delivery_continue_CT
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_core/delivery.c:1108
> (qdrouterd+0x49f9e2)
> 21: E #1 router_core_thread
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_core/router_core_thread.c:236
> (qdrouterd+0x4b572a)
> 21: E #2 _thread_init
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/posix/threading.c:172
> (qdrouterd+0x48160d)
> 21: E
> 21: E Location is heap block of size 320 at 0x7b440003d2c0
> allocated by thread T3:
> 21: E #0 posix_memalign (libtsan.so.0+0x32a23)
> 21: E #1 qd_alloc
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/alloc_pool.c:391
> (qdrouterd+0x44ad29)
> 21: E #2 new_qdr_delivery_t
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_core/delivery.c:24
> (qdrouterd+0x49d33c)
> 21: E #3 qdr_link_deliver
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_core/transfer.c:64
> (qdrouterd+0x4bb125)
> 21: E #4 AMQP_rx_handler
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_node.c:877
> (qdrouterd+0x4d3106)
> 21: E #5 do_receive
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/container.c:219
> (qdrouterd+0x45f234)
> 21: E #6 qd_container_handle_event
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/container.c:734
> (qdrouterd+0x45f234)
> 21: E #7 handle
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1108
> (qdrouterd+0x4d8b41)
> 21: E #8 thread_run
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1133
> (qdrouterd+0x4dae84)
> 21: E #9 _thread_init
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/posix/threading.c:172
> (qdrouterd+0x48160d)
> 21: E
> 21: E Thread T4 (tid=2385, running) created by main thread at:
> 21: E
[jira] [Commented] (DISPATCH-2314) TSAN data race when setting the presettled flag
[
https://issues.apache.org/jira/browse/DISPATCH-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493428#comment-17493428
]
ASF GitHub Bot commented on DISPATCH-2314:
--
asfgit merged pull request #1518:
URL: https://github.com/apache/qpid-dispatch/pull/1518
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> TSAN data race when setting the presettled flag
> ---
>
> Key: DISPATCH-2314
> URL: https://issues.apache.org/jira/browse/DISPATCH-2314
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Container
>Reporter: Ganesh Murthy
>Priority: Major
> Labels: race-condition, tsan
>
> {noformat}
> 21: E Process 2380 error: exit code 66, expected 0
> 21: E qdrouterd -c test-router.conf -I
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/python
> 21: E
> /__w/qpid-dispatch/qpid-dispatch/qpid-dispatch/build/tests/system_test.dir/system_tests_one_router/OneRouterTest/setUpClass/test-router-9.cmd
> 21: E
> 21: E ==
> 21: E WARNING: ThreadSanitizer: data race (pid=2380)
> 21: E Write of size 1 at 0x7b440003d355 by thread T4:
> 21: E #0 qdr_delivery_set_presettled
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_core/delivery.c:136
> (qdrouterd+0x49d8c5)
> 21: E #1 AMQP_rx_handler
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_node.c:538
> (qdrouterd+0x4d2ff5)
> 21: E #2 deferred_AMQP_rx_handler
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_node.c:922
> (qdrouterd+0x4d37b2)
> 21: E #3 invoke_deferred_calls
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:801
> (qdrouterd+0x4d584b)
> 21: E #4 invoke_deferred_calls
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:790
> (qdrouterd+0x4d8b16)
> 21: E #5 handle
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1058
> (qdrouterd+0x4d8b16)
> 21: E #6 thread_run
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1133
> (qdrouterd+0x4dae84)
> 21: E #7 _thread_init
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/posix/threading.c:172
> (qdrouterd+0x48160d)
> 21: E
> 21: E Previous read of size 1 at 0x7b440003d355 by thread T1:
> 21: E #0 qdr_delivery_continue_CT
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_core/delivery.c:1108
> (qdrouterd+0x49f9e2)
> 21: E #1 router_core_thread
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_core/router_core_thread.c:236
> (qdrouterd+0x4b572a)
> 21: E #2 _thread_init
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/posix/threading.c:172
> (qdrouterd+0x48160d)
> 21: E
> 21: E Location is heap block of size 320 at 0x7b440003d2c0
> allocated by thread T3:
> 21: E #0 posix_memalign (libtsan.so.0+0x32a23)
> 21: E #1 qd_alloc
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/alloc_pool.c:391
> (qdrouterd+0x44ad29)
> 21: E #2 new_qdr_delivery_t
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_core/delivery.c:24
> (qdrouterd+0x49d33c)
> 21: E #3 qdr_link_deliver
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_core/transfer.c:64
> (qdrouterd+0x4bb125)
> 21: E #4 AMQP_rx_handler
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_node.c:877
> (qdrouterd+0x4d3106)
> 21: E #5 do_receive
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/container.c:219
> (qdrouterd+0x45f234)
> 21: E #6 qd_container_handle_event
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/container.c:734
> (qdrouterd+0x45f234)
> 21: E #7 handle
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1108
> (qdrouterd+0x4d8b41)
> 21: E #8 thread_run
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1133
> (qdrouterd+0x4dae84)
> 21: E #9 _thread_init
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/posix/threading.c:172
> (qdrouterd+0x48160d)
> 21: E
> 21: E
[GitHub] [qpid-dispatch] asfgit merged pull request #1518: DISPATCH-2314: Added TSAN suppression entry to suppress errors when s…
asfgit merged pull request #1518: URL: https://github.com/apache/qpid-dispatch/pull/1518 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-2326) Remove HTTP1/HTTP2/TCP Adaptors from the source code.
[ https://issues.apache.org/jira/browse/DISPATCH-2326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ganesh Murthy resolved DISPATCH-2326. - Fix Version/s: 1.19.0 Resolution: Fixed > Remove HTTP1/HTTP2/TCP Adaptors from the source code. > -- > > Key: DISPATCH-2326 > URL: https://issues.apache.org/jira/browse/DISPATCH-2326 > Project: Qpid Dispatch > Issue Type: Task >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.19.0 > > > Remove all adaptor code and all supporting adaptor tests. Do not remove the > adaptor code API. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2326) Remove HTTP1/HTTP2/TCP Adaptors from the source code.
[ https://issues.apache.org/jira/browse/DISPATCH-2326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493409#comment-17493409 ] ASF subversion and git services commented on DISPATCH-2326: --- Commit d7ba0a8557af57744a8e17b25f328e12d8db945a in qpid-dispatch's branch refs/heads/main from Ganesh Murthy [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=d7ba0a8 ] DISPATCH-2326: Removed HTTP1/HTTP2/TCP adaptors and other adaptor related code > Remove HTTP1/HTTP2/TCP Adaptors from the source code. > -- > > Key: DISPATCH-2326 > URL: https://issues.apache.org/jira/browse/DISPATCH-2326 > Project: Qpid Dispatch > Issue Type: Task >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > > Remove all adaptor code and all supporting adaptor tests. Do not remove the > adaptor code API. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] asfgit merged pull request #1491: NO-JIRA: Removed HTTP1/HTTP2/TCP adaptors and other adaptor related code
asfgit merged pull request #1491: URL: https://github.com/apache/qpid-dispatch/pull/1491 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8577) problems when delivering to full queues using AMQP 1.0
[ https://issues.apache.org/jira/browse/QPID-8577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493401#comment-17493401 ] ASF GitHub Bot commented on QPID-8577: -- grs commented on pull request #29: URL: https://github.com/apache/qpid-cpp/pull/29#issuecomment-1041982654 It appears that this causes one of the automated tests to fail. In particular test_reject in the ha_tests.py. From what I can see in the log, it looks like the sending client (which tries to send more than it is allowed), is being disconnected. I'm not sure why your change should cause this, but running the tests in CI without them passes on all tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > problems when delivering to full queues using AMQP 1.0 > -- > > Key: QPID-8577 > URL: https://issues.apache.org/jira/browse/QPID-8577 > Project: Qpid > Issue Type: Bug > Components: C++ Broker >Affects Versions: qpid-cpp-1.39.0 >Reporter: Pete Fawcett >Priority: Major > > Problems have been observed when sending messages to the broker using AMQP > 1.0. > The problems occur if the the messages being sent are routed to an output > queue but cannot be delivered to the queue because of size limits defined on > the queue. > In certain circumstances this scenario can result in the broker crashing with > a segmentation fault. > When a message cannot be delivered to a queue, due to insufficient space, an > exception is thrown. This results in the link being closed and an error > returned to the client. > If previous messages sent from the client have activated "flow control" (due > to the queue getting close to full) then the acknowledgments (acks) for those > messages are held as "pending" in the owning session. When messages are > removed from the destination queue, and flow control allows flow to restart, > the session attempts to deliver the pending acks. > If there has been a link failure, then the pending acks are no longer valid - > the pointer to the owning link has been reset to NULL. The current code > doesn't check the validity of the link pointer and causes a Seg Fault when it > tries to send the acks, > The proposal is to address this problem in two phases: > * Phase One > ** Add defensive code to prevent Seg Fault > ** Remove pending acks from session if the link is being closed > * Phase Two > ** Investigate 'returning' the problematic message rather than closing the > link with an error code > Avoiding closing the link seems preferable as it could reduce the number of > messages that might otherwise be resent by the client. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-cpp] grs commented on pull request #29: QPID-8577 segfault after link error
grs commented on pull request #29: URL: https://github.com/apache/qpid-cpp/pull/29#issuecomment-1041982654 It appears that this causes one of the automated tests to fail. In particular test_reject in the ha_tests.py. From what I can see in the log, it looks like the sending client (which tries to send more than it is allowed), is being disconnected. I'm not sure why your change should cause this, but running the tests in CI without them passes on all tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2208) Dispatch docs build fails if -DRUNTIME_CHECK=asan is used
[
https://issues.apache.org/jira/browse/DISPATCH-2208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493398#comment-17493398
]
Jiri Daněk commented on DISPATCH-2208:
--
Duplicate? Of what? I don't think so.
> Dispatch docs build fails if -DRUNTIME_CHECK=asan is used
> -
>
> Key: DISPATCH-2208
> URL: https://issues.apache.org/jira/browse/DISPATCH-2208
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Documentation
>Affects Versions: 1.15.0
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
> Fix For: 1.19.0
>
>
> https://github.com/jiridanek/qpid-dispatch/runs/2050819641?check_suite_focus=true#step:8:108
> {noformat}
> [ 87%] Generating qdrouterd_help.adoc
> [109|https://github.com/jiridanek/qpid-dispatch/runs/2050819641?check_suite_focus=true#step:8:109]==7773==ASan
> runtime does not come first in initial library list; you should either link
> runtime to your application or manually preload it with LD_PRELOAD.
> [110|https://github.com/jiridanek/qpid-dispatch/runs/2050819641?check_suite_focus=true#step:8:110]Traceback
> (most recent call last):
> [111|https://github.com/jiridanek/qpid-dispatch/runs/2050819641?check_suite_focus=true#step:8:111]
> File
> "/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/build/run.py",
> line 144, in
> [112|https://github.com/jiridanek/qpid-dispatch/runs/2050819641?check_suite_focus=true#step:8:112]
> run_path(sys.argv[0], run_name="__main__")
> [113|https://github.com/jiridanek/qpid-dispatch/runs/2050819641?check_suite_focus=true#step:8:113]
> File
> "/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/build/run.py",
> line 127, in run_path
> [114|https://github.com/jiridanek/qpid-dispatch/runs/2050819641?check_suite_focus=true#step:8:114]
> runpy.run_path(file_path, run_name=run_name)
> [115|https://github.com/jiridanek/qpid-dispatch/runs/2050819641?check_suite_focus=true#step:8:115]
> File "/opt/hostedtoolcache/Python/3.7.10/x64/lib/python3.7/runpy.py", line
> 263, in run_path
> [116|https://github.com/jiridanek/qpid-dispatch/runs/2050819641?check_suite_focus=true#step:8:116]
> pkg_name=pkg_name, script_name=fname)
> [117|https://github.com/jiridanek/qpid-dispatch/runs/2050819641?check_suite_focus=true#step:8:117]
> File "/opt/hostedtoolcache/Python/3.7.10/x64/lib/python3.7/runpy.py", line
> 96, in _run_module_code
> [118|https://github.com/jiridanek/qpid-dispatch/runs/2050819641?check_suite_focus=true#step:8:118]
> mod_name, mod_spec, pkg_name, script_name)
> [119|https://github.com/jiridanek/qpid-dispatch/runs/2050819641?check_suite_focus=true#step:8:119]
> File "/opt/hostedtoolcache/Python/3.7.10/x64/lib/python3.7/runpy.py", line
> 85, in _run_code
> [120|https://github.com/jiridanek/qpid-dispatch/runs/2050819641?check_suite_focus=true#step:8:120]
> exec(code, run_globals)
> [121|https://github.com/jiridanek/qpid-dispatch/runs/2050819641?check_suite_focus=true#step:8:121]
> File
> "/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/docs/man/help2txt.py",
> line 96, in
> [122|https://github.com/jiridanek/qpid-dispatch/runs/2050819641?check_suite_focus=true#step:8:122]
> main(sys.argv)
> [123|https://github.com/jiridanek/qpid-dispatch/runs/2050819641?check_suite_focus=true#step:8:123]
> File
> "/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/docs/man/help2txt.py",
> line 92, in main
> [124|https://github.com/jiridanek/qpid-dispatch/runs/2050819641?check_suite_focus=true#step:8:124]
> print(help2txt(check_output(program)))
> [125|https://github.com/jiridanek/qpid-dispatch/runs/2050819641?check_suite_focus=true#step:8:125]
> File
> "/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/docs/man/help2txt.py",
> line 54, in check_output
> [126|https://github.com/jiridanek/qpid-dispatch/runs/2050819641?check_suite_focus=true#step:8:126]
> raise e
> [127|https://github.com/jiridanek/qpid-dispatch/runs/2050819641?check_suite_focus=true#step:8:127]subprocess.CalledProcessError:
> Command
> '['/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/build/router/qdrouterd',
> '--help']' returned non-zero exit status 1.
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Closed] (DISPATCH-2208) Dispatch docs build fails if -DRUNTIME_CHECK=asan is used
[
https://issues.apache.org/jira/browse/DISPATCH-2208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ken Giusti closed DISPATCH-2208.
Resolution: Duplicate
> Dispatch docs build fails if -DRUNTIME_CHECK=asan is used
> -
>
> Key: DISPATCH-2208
> URL: https://issues.apache.org/jira/browse/DISPATCH-2208
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Documentation
>Affects Versions: 1.15.0
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
> Fix For: 1.19.0
>
>
> https://github.com/jiridanek/qpid-dispatch/runs/2050819641?check_suite_focus=true#step:8:108
> {noformat}
> [ 87%] Generating qdrouterd_help.adoc
> [109|https://github.com/jiridanek/qpid-dispatch/runs/2050819641?check_suite_focus=true#step:8:109]==7773==ASan
> runtime does not come first in initial library list; you should either link
> runtime to your application or manually preload it with LD_PRELOAD.
> [110|https://github.com/jiridanek/qpid-dispatch/runs/2050819641?check_suite_focus=true#step:8:110]Traceback
> (most recent call last):
> [111|https://github.com/jiridanek/qpid-dispatch/runs/2050819641?check_suite_focus=true#step:8:111]
> File
> "/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/build/run.py",
> line 144, in
> [112|https://github.com/jiridanek/qpid-dispatch/runs/2050819641?check_suite_focus=true#step:8:112]
> run_path(sys.argv[0], run_name="__main__")
> [113|https://github.com/jiridanek/qpid-dispatch/runs/2050819641?check_suite_focus=true#step:8:113]
> File
> "/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/build/run.py",
> line 127, in run_path
> [114|https://github.com/jiridanek/qpid-dispatch/runs/2050819641?check_suite_focus=true#step:8:114]
> runpy.run_path(file_path, run_name=run_name)
> [115|https://github.com/jiridanek/qpid-dispatch/runs/2050819641?check_suite_focus=true#step:8:115]
> File "/opt/hostedtoolcache/Python/3.7.10/x64/lib/python3.7/runpy.py", line
> 263, in run_path
> [116|https://github.com/jiridanek/qpid-dispatch/runs/2050819641?check_suite_focus=true#step:8:116]
> pkg_name=pkg_name, script_name=fname)
> [117|https://github.com/jiridanek/qpid-dispatch/runs/2050819641?check_suite_focus=true#step:8:117]
> File "/opt/hostedtoolcache/Python/3.7.10/x64/lib/python3.7/runpy.py", line
> 96, in _run_module_code
> [118|https://github.com/jiridanek/qpid-dispatch/runs/2050819641?check_suite_focus=true#step:8:118]
> mod_name, mod_spec, pkg_name, script_name)
> [119|https://github.com/jiridanek/qpid-dispatch/runs/2050819641?check_suite_focus=true#step:8:119]
> File "/opt/hostedtoolcache/Python/3.7.10/x64/lib/python3.7/runpy.py", line
> 85, in _run_code
> [120|https://github.com/jiridanek/qpid-dispatch/runs/2050819641?check_suite_focus=true#step:8:120]
> exec(code, run_globals)
> [121|https://github.com/jiridanek/qpid-dispatch/runs/2050819641?check_suite_focus=true#step:8:121]
> File
> "/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/docs/man/help2txt.py",
> line 96, in
> [122|https://github.com/jiridanek/qpid-dispatch/runs/2050819641?check_suite_focus=true#step:8:122]
> main(sys.argv)
> [123|https://github.com/jiridanek/qpid-dispatch/runs/2050819641?check_suite_focus=true#step:8:123]
> File
> "/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/docs/man/help2txt.py",
> line 92, in main
> [124|https://github.com/jiridanek/qpid-dispatch/runs/2050819641?check_suite_focus=true#step:8:124]
> print(help2txt(check_output(program)))
> [125|https://github.com/jiridanek/qpid-dispatch/runs/2050819641?check_suite_focus=true#step:8:125]
> File
> "/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/docs/man/help2txt.py",
> line 54, in check_output
> [126|https://github.com/jiridanek/qpid-dispatch/runs/2050819641?check_suite_focus=true#step:8:126]
> raise e
> [127|https://github.com/jiridanek/qpid-dispatch/runs/2050819641?check_suite_focus=true#step:8:127]subprocess.CalledProcessError:
> Command
> '['/home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/build/router/qdrouterd',
> '--help']' returned non-zero exit status 1.
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Closed] (DISPATCH-2297) OneRouter Q2 test failing in system_tests_http2 on rhel 9
[
https://issues.apache.org/jira/browse/DISPATCH-2297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ken Giusti closed DISPATCH-2297.
Resolution: Won't Fix
> OneRouter Q2 test failing in system_tests_http2 on rhel 9
> -
>
> Key: DISPATCH-2297
> URL: https://issues.apache.org/jira/browse/DISPATCH-2297
> Project: Qpid Dispatch
> Issue Type: Test
> Components: Tests
>Affects Versions: 1.18.0
>Reporter: Ganesh Murthy
>Assignee: Ken Giusti
>Priority: Major
>
> {noformat}
> 71: Test command: /usr/bin/python3.9
> "/home/jenkins/workspace/dispatch/dispatch-rhel9-main/source/dispatch/build/tests/run.py"
> "-m" "unittest" "-v" "system_tests_http2"
> 71: Test timeout computed to be: 600
> 71: test_q2_block_unblock (system_tests_http2.Http2Q2OneRouterTest) ... ERROR
> 71:
> 71: Router QDR output file:
> 71:
> 71:
> 71:
> 71:
> 71: Router QDR command file:
> 71:
> 71: qdrouterd -c http2-test-router.conf -I
> /home/jenkins/workspace/dispatch/dispatch-rhel9-main/source/dispatch/python
> 71: pid=7610
> 71:
> 71:
> 71:
> 71: Router QDR log file tail:
> 71:
> 71: 2021-12-08 20:08:23.643322 + ROUTER_CORE (debug) [C3][L2][D1]
> Delivery decref_CT: rc:1 qdr_delivery_unlink_peers_CT - unlinked from peer
> (delivery)
> (/home/jenkins/workspace/dispatch/dispatch-rhel9-main/source/dispatch/src/router_core/delivery.c:640)
> 71: 2021-12-08 20:08:23.643338 + ROUTER_CORE (debug) [C1][L4][D2]
> Delivery decref_CT: rc:2 qdr_delivery_unlink_peers_CT - unlinked from
> delivery (peer)
> (/home/jenkins/workspace/dispatch/dispatch-rhel9-main/source/dispatch/src/router_core/delivery.c:640)
> 71: 2021-12-08 20:08:23.643361 + ROUTER_CORE (debug) [C3][L2][D1]
> Delivery outcome : is unknown (0x0)
> (/home/jenkins/workspace/dispatch/dispatch-rhel9-main/source/dispatch/src/router_core/delivery.c:392)
> 71: 2021-12-08 20:08:23.643373 + ROUTER_CORE (debug) [C3][L2][D1]
> Delivery decref_CT: rc:0 qdr_link_cleanup_deliveries_CT - remove from
> unsettled list
> (/home/jenkins/workspace/dispatch/dispatch-rhel9-main/source/dispatch/src/router_core/delivery.c:640)
> 71: 2021-12-08 20:08:23.643472 + ROUTER_CORE (trace) Core action
> 'link_detach'
> (/home/jenkins/workspace/dispatch/dispatch-rhel9-main/source/dispatch/src/router_core/router_core_thread.c:235)
> 71: 2021-12-08 20:08:23.643493 + ROUTER_CORE (trace) Core action
> 'connection_closed'
> (/home/jenkins/workspace/dispatch/dispatch-rhel9-main/source/dispatch/src/router_core/router_core_thread.c:235)
> 71: 2021-12-08 20:08:23.643514 + ROUTER_CORE (info) [C3][L2] Link closed
> due to connection loss: del=1 presett=0 psdrop=0 acc=0 rej=0 rel=0 mod=0
> delay1=0 delay10=1 blocked=no
> (/home/jenkins/workspace/dispatch/dispatch-rhel9-main/source/dispatch/src/router_core/connections.c:1109)
> 71: 2021-12-08 20:08:23.643546 + ROUTER_CORE (info) [C3][L3] Link closed
> due to connection loss: del=0 presett=0 psdrop=0 acc=0 rej=0 rel=0 mod=0
> delay1=0 delay10=0 blocked=no
> (/home/jenkins/workspace/dispatch/dispatch-rhel9-main/source/dispatch/src/router_core/connections.c:1109)
> 71: 2021-12-08 20:08:23.643559 + ROUTER_CORE (info) [C3] Connection
> Closed
> (/home/jenkins/workspace/dispatch/dispatch-rhel9-main/source/dispatch/src/router_core/connections.c:1604)
> 71: 2021-12-08 20:08:23.643613 + ROUTER_CORE (trace) Core action
> 'delete_http2_connection'
> (/home/jenkins/workspace/dispatch/dispatch-rhel9-main/source/dispatch/src/router_core/router_core_thread.c:235)
> 71: 2021-12-08 20:08:23.643631 + HTTP_ADAPTOR (trace) [C3] Freeing http2
> connection in free_qdr_http2_connection
> (/home/jenkins/workspace/dispatch/dispatch-rhel9-main/source/dispatch/src/adaptors/http2/http2_adaptor.c:459)
> 71: 2021-12-08 20:08:23.643654 + HTTP_ADAPTOR (trace) [C1] Activation
> triggered, calling pn_raw_connection_wake()
> (/home/jenkins/workspace/dispatch/dispatch-rhel9-main/source/dispatch/src/adaptors/http2/http2_adaptor.c:1704)
> 71: 2021-12-08 20:08:23.643765 + HTTP_ADAPTOR (trace) [C1]
> PN_RAW_CONNECTION_WAKE Wake-up
> (/home/jenkins/workspace/dispatch/dispatch-rhel9-main/source/dispatch/src/adaptors/http2/http2_adaptor.c:2539)
> 71: 2021-12-08 20:08:23.643791 + ROUTER_CORE (debug) [C1][L4][D2]
> Delivery incref:rc:3 qdr_link_process_deliveries - holding the
> undelivered delivery locally
> (/home/jenkins/workspace/dispatch/dispatch-rhel9-main/source/dispatch/src/router_core/delivery.c:115)
> 71: 2021-12-08 20:08:23.643825 + HTTP_ADAPTOR (debug) [C1][S1]
> qdr_http_deliver - call handle_outgoing_http
> (/home/jenkins/workspace/dispatch/dispatch-rhel9-main/source/dispatch/src/adaptors/http2/http2_adaptor.c:2076)
> 71: 2021-12-08 20:08:23.643838 + PROTOCOL
[jira] [Assigned] (DISPATCH-2297) OneRouter Q2 test failing in system_tests_http2 on rhel 9
[
https://issues.apache.org/jira/browse/DISPATCH-2297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ken Giusti reassigned DISPATCH-2297:
Assignee: Ken Giusti
> OneRouter Q2 test failing in system_tests_http2 on rhel 9
> -
>
> Key: DISPATCH-2297
> URL: https://issues.apache.org/jira/browse/DISPATCH-2297
> Project: Qpid Dispatch
> Issue Type: Test
> Components: Tests
>Affects Versions: 1.18.0
>Reporter: Ganesh Murthy
>Assignee: Ken Giusti
>Priority: Major
>
> {noformat}
> 71: Test command: /usr/bin/python3.9
> "/home/jenkins/workspace/dispatch/dispatch-rhel9-main/source/dispatch/build/tests/run.py"
> "-m" "unittest" "-v" "system_tests_http2"
> 71: Test timeout computed to be: 600
> 71: test_q2_block_unblock (system_tests_http2.Http2Q2OneRouterTest) ... ERROR
> 71:
> 71: Router QDR output file:
> 71:
> 71:
> 71:
> 71:
> 71: Router QDR command file:
> 71:
> 71: qdrouterd -c http2-test-router.conf -I
> /home/jenkins/workspace/dispatch/dispatch-rhel9-main/source/dispatch/python
> 71: pid=7610
> 71:
> 71:
> 71:
> 71: Router QDR log file tail:
> 71:
> 71: 2021-12-08 20:08:23.643322 + ROUTER_CORE (debug) [C3][L2][D1]
> Delivery decref_CT: rc:1 qdr_delivery_unlink_peers_CT - unlinked from peer
> (delivery)
> (/home/jenkins/workspace/dispatch/dispatch-rhel9-main/source/dispatch/src/router_core/delivery.c:640)
> 71: 2021-12-08 20:08:23.643338 + ROUTER_CORE (debug) [C1][L4][D2]
> Delivery decref_CT: rc:2 qdr_delivery_unlink_peers_CT - unlinked from
> delivery (peer)
> (/home/jenkins/workspace/dispatch/dispatch-rhel9-main/source/dispatch/src/router_core/delivery.c:640)
> 71: 2021-12-08 20:08:23.643361 + ROUTER_CORE (debug) [C3][L2][D1]
> Delivery outcome : is unknown (0x0)
> (/home/jenkins/workspace/dispatch/dispatch-rhel9-main/source/dispatch/src/router_core/delivery.c:392)
> 71: 2021-12-08 20:08:23.643373 + ROUTER_CORE (debug) [C3][L2][D1]
> Delivery decref_CT: rc:0 qdr_link_cleanup_deliveries_CT - remove from
> unsettled list
> (/home/jenkins/workspace/dispatch/dispatch-rhel9-main/source/dispatch/src/router_core/delivery.c:640)
> 71: 2021-12-08 20:08:23.643472 + ROUTER_CORE (trace) Core action
> 'link_detach'
> (/home/jenkins/workspace/dispatch/dispatch-rhel9-main/source/dispatch/src/router_core/router_core_thread.c:235)
> 71: 2021-12-08 20:08:23.643493 + ROUTER_CORE (trace) Core action
> 'connection_closed'
> (/home/jenkins/workspace/dispatch/dispatch-rhel9-main/source/dispatch/src/router_core/router_core_thread.c:235)
> 71: 2021-12-08 20:08:23.643514 + ROUTER_CORE (info) [C3][L2] Link closed
> due to connection loss: del=1 presett=0 psdrop=0 acc=0 rej=0 rel=0 mod=0
> delay1=0 delay10=1 blocked=no
> (/home/jenkins/workspace/dispatch/dispatch-rhel9-main/source/dispatch/src/router_core/connections.c:1109)
> 71: 2021-12-08 20:08:23.643546 + ROUTER_CORE (info) [C3][L3] Link closed
> due to connection loss: del=0 presett=0 psdrop=0 acc=0 rej=0 rel=0 mod=0
> delay1=0 delay10=0 blocked=no
> (/home/jenkins/workspace/dispatch/dispatch-rhel9-main/source/dispatch/src/router_core/connections.c:1109)
> 71: 2021-12-08 20:08:23.643559 + ROUTER_CORE (info) [C3] Connection
> Closed
> (/home/jenkins/workspace/dispatch/dispatch-rhel9-main/source/dispatch/src/router_core/connections.c:1604)
> 71: 2021-12-08 20:08:23.643613 + ROUTER_CORE (trace) Core action
> 'delete_http2_connection'
> (/home/jenkins/workspace/dispatch/dispatch-rhel9-main/source/dispatch/src/router_core/router_core_thread.c:235)
> 71: 2021-12-08 20:08:23.643631 + HTTP_ADAPTOR (trace) [C3] Freeing http2
> connection in free_qdr_http2_connection
> (/home/jenkins/workspace/dispatch/dispatch-rhel9-main/source/dispatch/src/adaptors/http2/http2_adaptor.c:459)
> 71: 2021-12-08 20:08:23.643654 + HTTP_ADAPTOR (trace) [C1] Activation
> triggered, calling pn_raw_connection_wake()
> (/home/jenkins/workspace/dispatch/dispatch-rhel9-main/source/dispatch/src/adaptors/http2/http2_adaptor.c:1704)
> 71: 2021-12-08 20:08:23.643765 + HTTP_ADAPTOR (trace) [C1]
> PN_RAW_CONNECTION_WAKE Wake-up
> (/home/jenkins/workspace/dispatch/dispatch-rhel9-main/source/dispatch/src/adaptors/http2/http2_adaptor.c:2539)
> 71: 2021-12-08 20:08:23.643791 + ROUTER_CORE (debug) [C1][L4][D2]
> Delivery incref:rc:3 qdr_link_process_deliveries - holding the
> undelivered delivery locally
> (/home/jenkins/workspace/dispatch/dispatch-rhel9-main/source/dispatch/src/router_core/delivery.c:115)
> 71: 2021-12-08 20:08:23.643825 + HTTP_ADAPTOR (debug) [C1][S1]
> qdr_http_deliver - call handle_outgoing_http
> (/home/jenkins/workspace/dispatch/dispatch-rhel9-main/source/dispatch/src/adaptors/http2/http2_adaptor.c:2076)
> 71: 2021-12-08 20:08:23.643838 +
[jira] [Resolved] (DISPATCH-2312) Remove test system_tests_one_router.py::test_07_unsettled_undeliverable
[ https://issues.apache.org/jira/browse/DISPATCH-2312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ken Giusti resolved DISPATCH-2312. -- Assignee: Ken Giusti Resolution: Fixed > Remove test system_tests_one_router.py::test_07_unsettled_undeliverable > --- > > Key: DISPATCH-2312 > URL: https://issues.apache.org/jira/browse/DISPATCH-2312 > Project: Qpid Dispatch > Issue Type: Task >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Fix For: 1.19.0 > > > This test appears to do nothing except for pausing for QD_TESTTIMEOUT. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2066) [http1] In system_tests_http1_adaptor Http1AdaptorQ2Standalone backpressure tests, block_ct != unblock_ct
[
https://issues.apache.org/jira/browse/DISPATCH-2066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493391#comment-17493391
]
ASF GitHub Bot commented on DISPATCH-2066:
--
kgiusti commented on pull request #1516:
URL: https://github.com/apache/qpid-dispatch/pull/1516#issuecomment-1041941493
Obsolete
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [http1] In system_tests_http1_adaptor Http1AdaptorQ2Standalone backpressure
> tests, block_ct != unblock_ct
> -
>
> Key: DISPATCH-2066
> URL: https://issues.apache.org/jira/browse/DISPATCH-2066
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Protocol Adaptors
>Affects Versions: 1.16.0
>Reporter: Jiri Daněk
>Assignee: Ken Giusti
>Priority: Major
> Labels: HTTP/1.x
> Fix For: 1.19.0
>
>
> https://travis-ci.com/github/apache/qpid-dispatch/jobs/46271#L11501
> {noformat}
> test 70
> Start 70: system_tests_http1_adaptor
> 70: Test command: /usr/bin/python3.8
> "/home/travis/build/apache/qpid-dispatch/build/tests/run.py" "-m" "unittest"
> "-v" "system_tests_http1_adaptor"
> 70: Test timeout computed to be: 500
> 70: test_01_unsolicited_response
> (system_tests_http1_adaptor.Http1AdaptorBadEndpointsTest)
> 70: Create a server that sends an immediate Request Timeout response ... ok
> 70: test_02_bad_request_message
> (system_tests_http1_adaptor.Http1AdaptorBadEndpointsTest)
> 70: Test various improperly constructed request messages ... ok
> 70: test_03_bad_response_message
> (system_tests_http1_adaptor.Http1AdaptorBadEndpointsTest)
> 70: Test various improperly constructed response messages ... ok
> 70:
> 70: Router TestBadEndpoints output file:
> 70:
> 70: -
> 70: Suppressions used:
> 70: count bytes template
> 70: 1 24 ^pn_condition$
> 70: 1 1536 ^pn_raw_connection$
> 70: 1 56 qdr_core_subscribe
> 70: 2112 ^pn_string_grow$
> 70: 7328 ^pn_object_new$
> 70: 1128 ^pn_list$
> 70: 2 48 ^pni_record_create$
> 70: 597 926857 /libpython3.*.so
> 70: -
> 70:
> 70:
> 70:
> 70: test_01_concurrent_requests
> (system_tests_http1_adaptor.Http1AdaptorEdge2EdgeTest)
> 70: Test multiple concurrent clients sending streaming messages ... ok
> 70: test_02_credit_replenish
> (system_tests_http1_adaptor.Http1AdaptorEdge2EdgeTest)
> 70: Verify credit is replenished by sending > the default credit window ... ok
> 70: test_03_server_reconnect
> (system_tests_http1_adaptor.Http1AdaptorEdge2EdgeTest)
> 70: Verify server reconnect logic. ... ok
> 70: test_04_server_pining_for_the_fjords
> (system_tests_http1_adaptor.Http1AdaptorEdge2EdgeTest)
> 70: Test permanent loss of server ... ok
> 70: test_05_large_streaming_msg
> (system_tests_http1_adaptor.Http1AdaptorEdge2EdgeTest)
> 70: Verify large streaming message transfer ... ok
> 70:
> 70: Router EA2 output file:
> 70:
> 70: -
> 70: Suppressions used:
> 70: count bytes template
> 70: 7 59 ^load_server_config$
> 70: 6401 ^qd_dispatch_configure_connector$
> 70: 1 24 ^pn_condition$
> 70: 1 1536 ^pn_raw_connection$
> 70: 1 64 sys_mutex
> 70: 1 56 qdr_core_subscribe
> 70: 2112 ^pn_string_grow$
> 70: 7328 ^pn_object_new$
> 70: 1128 ^pn_list$
> 70: 2 48 ^pni_record_create$
> 70: 601 929697 /libpython3.*.so
> 70: -
> 70:
> 70:
> 70:
> 70:
> 70: Router EA2 debug dump file:
> 70:
> 70: alloc.c: Items of type 'qd_timer_t' remain allocated at shutdown: 1
> (SUPPRESSED)
> 70: alloc.c: Items of type 'qd_connector_t' remain allocated at shutdown: 1
> (SUPPRESSED)
> 70:
> 70:
> 70:
> 70: Router EA1 output file:
> 70:
> 70: -
> 70: Suppressions used:
> 70: count bytes template
> 70: 7 59 ^load_server_config$
> 70: 6401 ^qd_dispatch_configure_connector$
> 70: 1 64 sys_mutex
> 70: 1 56 qdr_core_subscribe
> 70: 601 929697 /libpython3.*.so
> 70: -
> 70:
> 70:
> 70:
> 70:
> 70:
[jira] [Commented] (DISPATCH-2066) [http1] In system_tests_http1_adaptor Http1AdaptorQ2Standalone backpressure tests, block_ct != unblock_ct
[
https://issues.apache.org/jira/browse/DISPATCH-2066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493390#comment-17493390
]
ASF GitHub Bot commented on DISPATCH-2066:
--
kgiusti closed pull request #1516:
URL: https://github.com/apache/qpid-dispatch/pull/1516
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [http1] In system_tests_http1_adaptor Http1AdaptorQ2Standalone backpressure
> tests, block_ct != unblock_ct
> -
>
> Key: DISPATCH-2066
> URL: https://issues.apache.org/jira/browse/DISPATCH-2066
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Protocol Adaptors
>Affects Versions: 1.16.0
>Reporter: Jiri Daněk
>Assignee: Ken Giusti
>Priority: Major
> Labels: HTTP/1.x
> Fix For: 1.19.0
>
>
> https://travis-ci.com/github/apache/qpid-dispatch/jobs/46271#L11501
> {noformat}
> test 70
> Start 70: system_tests_http1_adaptor
> 70: Test command: /usr/bin/python3.8
> "/home/travis/build/apache/qpid-dispatch/build/tests/run.py" "-m" "unittest"
> "-v" "system_tests_http1_adaptor"
> 70: Test timeout computed to be: 500
> 70: test_01_unsolicited_response
> (system_tests_http1_adaptor.Http1AdaptorBadEndpointsTest)
> 70: Create a server that sends an immediate Request Timeout response ... ok
> 70: test_02_bad_request_message
> (system_tests_http1_adaptor.Http1AdaptorBadEndpointsTest)
> 70: Test various improperly constructed request messages ... ok
> 70: test_03_bad_response_message
> (system_tests_http1_adaptor.Http1AdaptorBadEndpointsTest)
> 70: Test various improperly constructed response messages ... ok
> 70:
> 70: Router TestBadEndpoints output file:
> 70:
> 70: -
> 70: Suppressions used:
> 70: count bytes template
> 70: 1 24 ^pn_condition$
> 70: 1 1536 ^pn_raw_connection$
> 70: 1 56 qdr_core_subscribe
> 70: 2112 ^pn_string_grow$
> 70: 7328 ^pn_object_new$
> 70: 1128 ^pn_list$
> 70: 2 48 ^pni_record_create$
> 70: 597 926857 /libpython3.*.so
> 70: -
> 70:
> 70:
> 70:
> 70: test_01_concurrent_requests
> (system_tests_http1_adaptor.Http1AdaptorEdge2EdgeTest)
> 70: Test multiple concurrent clients sending streaming messages ... ok
> 70: test_02_credit_replenish
> (system_tests_http1_adaptor.Http1AdaptorEdge2EdgeTest)
> 70: Verify credit is replenished by sending > the default credit window ... ok
> 70: test_03_server_reconnect
> (system_tests_http1_adaptor.Http1AdaptorEdge2EdgeTest)
> 70: Verify server reconnect logic. ... ok
> 70: test_04_server_pining_for_the_fjords
> (system_tests_http1_adaptor.Http1AdaptorEdge2EdgeTest)
> 70: Test permanent loss of server ... ok
> 70: test_05_large_streaming_msg
> (system_tests_http1_adaptor.Http1AdaptorEdge2EdgeTest)
> 70: Verify large streaming message transfer ... ok
> 70:
> 70: Router EA2 output file:
> 70:
> 70: -
> 70: Suppressions used:
> 70: count bytes template
> 70: 7 59 ^load_server_config$
> 70: 6401 ^qd_dispatch_configure_connector$
> 70: 1 24 ^pn_condition$
> 70: 1 1536 ^pn_raw_connection$
> 70: 1 64 sys_mutex
> 70: 1 56 qdr_core_subscribe
> 70: 2112 ^pn_string_grow$
> 70: 7328 ^pn_object_new$
> 70: 1128 ^pn_list$
> 70: 2 48 ^pni_record_create$
> 70: 601 929697 /libpython3.*.so
> 70: -
> 70:
> 70:
> 70:
> 70:
> 70: Router EA2 debug dump file:
> 70:
> 70: alloc.c: Items of type 'qd_timer_t' remain allocated at shutdown: 1
> (SUPPRESSED)
> 70: alloc.c: Items of type 'qd_connector_t' remain allocated at shutdown: 1
> (SUPPRESSED)
> 70:
> 70:
> 70:
> 70: Router EA1 output file:
> 70:
> 70: -
> 70: Suppressions used:
> 70: count bytes template
> 70: 7 59 ^load_server_config$
> 70: 6401 ^qd_dispatch_configure_connector$
> 70: 1 64 sys_mutex
> 70: 1 56 qdr_core_subscribe
> 70: 601 929697 /libpython3.*.so
> 70: -
> 70:
> 70:
> 70:
> 70:
> 70: Router EA1 debug dump file:
> 70:
>
[GitHub] [qpid-dispatch] kgiusti commented on pull request #1516: DISPATCH-2066: fix flakey http1 Q2 test
kgiusti commented on pull request #1516: URL: https://github.com/apache/qpid-dispatch/pull/1516#issuecomment-1041941493 Obsolete -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti closed pull request #1516: DISPATCH-2066: fix flakey http1 Q2 test
kgiusti closed pull request #1516: URL: https://github.com/apache/qpid-dispatch/pull/1516 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1403) Consolidate chained qd_buffer_t field handling code
[ https://issues.apache.org/jira/browse/DISPATCH-1403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493389#comment-17493389 ] ASF GitHub Bot commented on DISPATCH-1403: -- kgiusti commented on pull request #1465: URL: https://github.com/apache/qpid-dispatch/pull/1465#issuecomment-1041936149 Closed. This patch is included as a commit in https://github.com/apache/qpid-dispatch/pull/1515 instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Consolidate chained qd_buffer_t field handling code > --- > > Key: DISPATCH-1403 > URL: https://issues.apache.org/jira/browse/DISPATCH-1403 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Router Node >Affects Versions: 1.8.0, 1.9.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Minor > Labels: refactor > Fix For: Backlog > > > There are many places in the router's C codebase where we need to work with > data spanning a chained qd_buffer_t list. In particular the low level > operations such as: > * advance N bytes > * compare N bytes > * copy N bytes > are common throughout the code. > Here are examples from the iterator.c library: > [copy > bytes|https://github.com/apache/qpid-dispatch/blob/master/src/iterator.c#L378] > [advance > cursor|https://github.com/apache/qpid-dispatch/blob/master/src/iterator.c#L424] > [compare|https://github.com/apache/qpid-dispatch/blob/master/src/iterator.c#L467] > Similar logic is implemented in message.c and parse.c. > We should de-duplicate this code by providing a common implementation as part > of the buffer handling code. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti commented on pull request #1465: DISPATCH-1403: define a common lightweight buffer field API
kgiusti commented on pull request #1465: URL: https://github.com/apache/qpid-dispatch/pull/1465#issuecomment-1041936149 Closed. This patch is included as a commit in https://github.com/apache/qpid-dispatch/pull/1515 instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti closed pull request #1465: DISPATCH-1403: define a common lightweight buffer field API
kgiusti closed pull request #1465: URL: https://github.com/apache/qpid-dispatch/pull/1465 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1403) Consolidate chained qd_buffer_t field handling code
[ https://issues.apache.org/jira/browse/DISPATCH-1403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493388#comment-17493388 ] ASF GitHub Bot commented on DISPATCH-1403: -- kgiusti closed pull request #1465: URL: https://github.com/apache/qpid-dispatch/pull/1465 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Consolidate chained qd_buffer_t field handling code > --- > > Key: DISPATCH-1403 > URL: https://issues.apache.org/jira/browse/DISPATCH-1403 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Router Node >Affects Versions: 1.8.0, 1.9.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Minor > Labels: refactor > Fix For: Backlog > > > There are many places in the router's C codebase where we need to work with > data spanning a chained qd_buffer_t list. In particular the low level > operations such as: > * advance N bytes > * compare N bytes > * copy N bytes > are common throughout the code. > Here are examples from the iterator.c library: > [copy > bytes|https://github.com/apache/qpid-dispatch/blob/master/src/iterator.c#L378] > [advance > cursor|https://github.com/apache/qpid-dispatch/blob/master/src/iterator.c#L424] > [compare|https://github.com/apache/qpid-dispatch/blob/master/src/iterator.c#L467] > Similar logic is implemented in message.c and parse.c. > We should de-duplicate this code by providing a common implementation as part > of the buffer handling code. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] dependabot[bot] opened a new pull request #1520: Bump body-parser from 1.19.0 to 1.19.2 in /console/react
dependabot[bot] opened a new pull request #1520: URL: https://github.com/apache/qpid-dispatch/pull/1520 Bumps [body-parser](https://github.com/expressjs/body-parser) from 1.19.0 to 1.19.2. Release notes Sourced from https://github.com/expressjs/body-parser/releases;>body-parser's releases. 1.19.2 deps: bytes@3.1.2 deps: qs@6.9.7 Fix handling of __proto__ keys deps: raw-body@2.4.3 deps: bytes@3.1.2 1.19.1 deps: bytes@3.1.1 deps: http-errors@1.8.1 deps: inherits@2.0.4 deps: toidentifier@1.0.1 deps: setprototypeof@1.2.0 deps: qs@6.9.6 deps: raw-body@2.4.2 deps: bytes@3.1.1 deps: http-errors@1.8.1 deps: safe-buffer@5.2.1 deps: type-is@~1.6.18 Changelog Sourced from https://github.com/expressjs/body-parser/blob/master/HISTORY.md;>body-parser's changelog. 1.19.2 / 2022-02-15 deps: bytes@3.1.2 deps: qs@6.9.7 Fix handling of __proto__ keys deps: raw-body@2.4.3 deps: bytes@3.1.2 1.19.1 / 2021-12-10 deps: bytes@3.1.1 deps: http-errors@1.8.1 deps: inherits@2.0.4 deps: toidentifier@1.0.1 deps: setprototypeof@1.2.0 deps: qs@6.9.6 deps: raw-body@2.4.2 deps: bytes@3.1.1 deps: http-errors@1.8.1 deps: safe-buffer@5.2.1 deps: type-is@~1.6.18 Commits https://github.com/expressjs/body-parser/commit/424dadd312f519bdb320c6ee9463d6672782420c;>424dadd 1.19.2 https://github.com/expressjs/body-parser/commit/11248a2919b033d309ac4045b9bbefdb8486b84c;>11248a2 deps: raw-body@2.4.3 https://github.com/expressjs/body-parser/commit/7a088eb74cbee94c8bf1e44b2f4cfb08ea915952;>7a088eb build: Node.js@14.19 https://github.com/expressjs/body-parser/commit/ecedf31c40c614828604f41a769ffbfdd52cb0b5;>ecedf31 build: Node.js@16.14 https://github.com/expressjs/body-parser/commit/b6bfabd557c0235bb5a61286d97c6bd557cc8b08;>b6bfabd build: Node.js@17.5 https://github.com/expressjs/body-parser/commit/badd6b260efae2f0dd69f138a0f28d2b8e46f985;>badd6b2 build: fix code coverage aggregate upload https://github.com/expressjs/body-parser/commit/96b448a15d02ec10c07ca1b8604fa9340d9e81c4;>96b448a build: Node.js@17.4 https://github.com/expressjs/body-parser/commit/70560b1d30ed4e1d4f3309a97534259571dffeee;>70560b1 build: mocha@9.2.0 https://github.com/expressjs/body-parser/commit/548a06faaffafab72c349adc671a2334b016b9a9;>548a06f build: supertest@6.2.2 https://github.com/expressjs/body-parser/commit/3b00678ee8546ff51fd478b9f32ce2c48a409b7a;>3b00678 deps: bytes@3.1.2 Additional commits viewable in https://github.com/expressjs/body-parser/compare/1.19.0...1.19.2;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) You can trigger a rebase of this PR by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For
[GitHub] [qpid-dispatch] dependabot[bot] closed pull request #1487: Bump body-parser from 1.19.0 to 1.19.1 in /console/react
dependabot[bot] closed pull request #1487: URL: https://github.com/apache/qpid-dispatch/pull/1487 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] dependabot[bot] commented on pull request #1487: Bump body-parser from 1.19.0 to 1.19.1 in /console/react
dependabot[bot] commented on pull request #1487: URL: https://github.com/apache/qpid-dispatch/pull/1487#issuecomment-1041886815 Superseded by #1520. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] dependabot[bot] opened a new pull request #1519: Bump @testing-library/react from 12.0.0 to 12.1.3 in /console/react
dependabot[bot] opened a new pull request #1519: URL: https://github.com/apache/qpid-dispatch/pull/1519 Bumps [@testing-library/react](https://github.com/testing-library/react-testing-library) from 12.0.0 to 12.1.3. Release notes Sourced from https://github.com/testing-library/react-testing-library/releases;>@testing-library/react's releases. v12.1.3 https://github.com/testing-library/react-testing-library/compare/v12.1.2...v12.1.3;>12.1.3 (2022-02-15) Bug Fixes Add @types/react-dom as a direct dependency (https://github-redirect.dependabot.com/testing-library/react-testing-library/issues/1001;>#1001) (https://github.com/testing-library/react-testing-library/commit/149d9a9af3addeb6c49696867b05b87afe0d0b3c;>149d9a9) v12.1.2 https://github.com/testing-library/react-testing-library/compare/v12.1.1...v12.1.2;>12.1.2 (2021-10-03) Bug Fixes render: Don't reject wrapper types based on statics (https://github-redirect.dependabot.com/testing-library/react-testing-library/issues/973;>#973) (https://github.com/testing-library/react-testing-library/commit/7f53b5673f64ff72a54c19b0685f901cfec96b03;>7f53b56) v12.1.1 https://github.com/testing-library/react-testing-library/compare/v12.1.0...v12.1.1;>12.1.1 (2021-09-27) Bug Fixes TS: make wrapper allow a simple function comp (https://github-redirect.dependabot.com/testing-library/react-testing-library/issues/966;>#966) (https://github.com/testing-library/react-testing-library/commit/cde904cd161782090d7ab7256bcb9b13e771d0ea;>cde904c) v12.1.0 https://github.com/testing-library/react-testing-library/compare/v12.0.0...v12.1.0;>12.1.0 (2021-09-11) Features improve JSDocs for RenderOptions (https://github-redirect.dependabot.com/testing-library/react-testing-library/issues/909;>#909) (https://github.com/testing-library/react-testing-library/commit/fbacb0da993518c2975efee17604e99a3180664f;>fbacb0d) Commits https://github.com/testing-library/react-testing-library/commit/b0f9d9741205c54836bf82b76b86ec001a8c0e1f;>b0f9d97 docs: add fmeum as a contributor for code, bug (https://github-redirect.dependabot.com/testing-library/react-testing-library/issues/1016;>#1016) https://github.com/testing-library/react-testing-library/commit/149d9a9af3addeb6c49696867b05b87afe0d0b3c;>149d9a9 fix: Add @types/react-dom as a direct dependency (https://github-redirect.dependabot.com/testing-library/react-testing-library/issues/1001;>#1001) https://github.com/testing-library/react-testing-library/commit/8f17a2bc4fa9c2c17a623b38ded9ab18b086e457;>8f17a2b chore: set protocol for npm to https (https://github-redirect.dependabot.com/testing-library/react-testing-library/issues/975;>#975) https://github.com/testing-library/react-testing-library/commit/7f53b5673f64ff72a54c19b0685f901cfec96b03;>7f53b56 fix(render): Don't reject wrapper types based on statics (https://github-redirect.dependabot.com/testing-library/react-testing-library/issues/973;>#973) https://github.com/testing-library/react-testing-library/commit/cde904cd161782090d7ab7256bcb9b13e771d0ea;>cde904c fix(TS): make wrapper allow a simple function comp (https://github-redirect.dependabot.com/testing-library/react-testing-library/issues/966;>#966) https://github.com/testing-library/react-testing-library/commit/a218b63163e1cafffb7da08fa05f26b68a34f14d;>a218b63 docs: add akashshyamdev as a contributor for bug (https://github-redirect.dependabot.com/testing-library/react-testing-library/issues/967;>#967) https://github.com/testing-library/react-testing-library/commit/84851dc660d49543707ba9eead42395c45ec06e2;>84851dc test: Backport tests using the full timer matrix (https://github-redirect.dependabot.com/testing-library/react-testing-library/issues/962;>#962) https://github.com/testing-library/react-testing-library/commit/3325061cac7c6cfcefa7da7b80765c7d36a25b40;>3325061 docs: add ImADrafter as a contributor for doc (https://github-redirect.dependabot.com/testing-library/react-testing-library/issues/961;>#961) https://github.com/testing-library/react-testing-library/commit/fbacb0da993518c2975efee17604e99a3180664f;>fbacb0d feat: improve JSDocs for RenderOptions (https://github-redirect.dependabot.com/testing-library/react-testing-library/issues/909;>#909) https://github.com/testing-library/react-testing-library/commit/071a6fdc1d8378bad0ad2d9f8fa58ec846ed7e2d;>071a6fd test: Format codebase with prettier (https://github-redirect.dependabot.com/testing-library/react-testing-library/issues/959;>#959) Additional commits viewable in https://github.com/testing-library/react-testing-library/compare/v12.0.0...v12.1.3;>compare view [![Dependabot compatibility
[GitHub] [qpid-dispatch] dependabot[bot] closed pull request #1486: Bump @testing-library/react from 12.0.0 to 12.1.2 in /console/react
dependabot[bot] closed pull request #1486: URL: https://github.com/apache/qpid-dispatch/pull/1486 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] dependabot[bot] commented on pull request #1486: Bump @testing-library/react from 12.0.0 to 12.1.2 in /console/react
dependabot[bot] commented on pull request #1486: URL: https://github.com/apache/qpid-dispatch/pull/1486#issuecomment-1041885631 Superseded by #1519. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2314) TSAN data race when setting the presettled flag
[ https://issues.apache.org/jira/browse/DISPATCH-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493349#comment-17493349 ] ASF GitHub Bot commented on DISPATCH-2314: -- codecov-commenter commented on pull request #1518: URL: https://github.com/apache/qpid-dispatch/pull/1518#issuecomment-1041875374 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1518?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1518](https://codecov.io/gh/apache/qpid-dispatch/pull/1518?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (65ef983) into [main](https://codecov.io/gh/apache/qpid-dispatch/commit/b7918db600decd9b610f8401ff306261674cfdb8?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (b7918db) will **increase** coverage by `0.04%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/1518?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## main#1518 +/- ## == + Coverage 84.82% 84.86% +0.04% == Files 117 117 Lines 2864328642 -1 == + Hits2429524307 +12 + Misses 4348 4335 -13 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1518?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1518/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=) | `93.71% <0.00%> (-0.56%)` | :arrow_down: | | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1518/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL21lc3NhZ2UuYw==) | `88.69% <0.00%> (-0.01%)` | :arrow_down: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1518/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `94.00% <0.00%> (+0.09%)` | :arrow_up: | | [src/adaptors/http1/http1\_codec.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1518/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL2h0dHAxL2h0dHAxX2NvZGVjLmM=) | `85.75% <0.00%> (+0.12%)` | :arrow_up: | | [src/router\_core/modules/mobile\_sync/mobile.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1518/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvbW9iaWxlX3N5bmMvbW9iaWxlLmM=) | `92.60% <0.00%> (+0.23%)` | :arrow_up: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1518/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `89.18% <0.00%> (+0.28%)` | :arrow_up: | | [src/adaptors/tcp\_adaptor.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1518/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL3RjcF9hZGFwdG9yLmM=) | `77.42% <0.00%> (+0.31%)` | :arrow_up: | | [src/adaptors/http1/http1\_server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1518/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL2h0dHAxL2h0dHAxX3NlcnZlci5j) | `85.73% <0.00%> (+0.55%)` | :arrow_up: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1518/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `94.50% <0.00%> (+0.63%)` | :arrow_up: | -- [Continue to review full report at
[GitHub] [qpid-dispatch] codecov-commenter commented on pull request #1518: DISPATCH-2314: Added TSAN suppression entry to suppress errors when s…
codecov-commenter commented on pull request #1518: URL: https://github.com/apache/qpid-dispatch/pull/1518#issuecomment-1041875374 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1518?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1518](https://codecov.io/gh/apache/qpid-dispatch/pull/1518?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (65ef983) into [main](https://codecov.io/gh/apache/qpid-dispatch/commit/b7918db600decd9b610f8401ff306261674cfdb8?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (b7918db) will **increase** coverage by `0.04%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/1518?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## main#1518 +/- ## == + Coverage 84.82% 84.86% +0.04% == Files 117 117 Lines 2864328642 -1 == + Hits2429524307 +12 + Misses 4348 4335 -13 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1518?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1518/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=) | `93.71% <0.00%> (-0.56%)` | :arrow_down: | | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1518/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL21lc3NhZ2UuYw==) | `88.69% <0.00%> (-0.01%)` | :arrow_down: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1518/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `94.00% <0.00%> (+0.09%)` | :arrow_up: | | [src/adaptors/http1/http1\_codec.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1518/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL2h0dHAxL2h0dHAxX2NvZGVjLmM=) | `85.75% <0.00%> (+0.12%)` | :arrow_up: | | [src/router\_core/modules/mobile\_sync/mobile.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1518/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvbW9iaWxlX3N5bmMvbW9iaWxlLmM=) | `92.60% <0.00%> (+0.23%)` | :arrow_up: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1518/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `89.18% <0.00%> (+0.28%)` | :arrow_up: | | [src/adaptors/tcp\_adaptor.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1518/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL3RjcF9hZGFwdG9yLmM=) | `77.42% <0.00%> (+0.31%)` | :arrow_up: | | [src/adaptors/http1/http1\_server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1518/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL2h0dHAxL2h0dHAxX3NlcnZlci5j) | `85.73% <0.00%> (+0.55%)` | :arrow_up: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1518/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `94.50% <0.00%> (+0.63%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1518?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn
[jira] [Commented] (DISPATCH-2234) Update JavaScript console packages for the 1.19.0 release
[ https://issues.apache.org/jira/browse/DISPATCH-2234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493347#comment-17493347 ] ASF GitHub Bot commented on DISPATCH-2234: -- bartoval commented on pull request #1517: URL: https://github.com/apache/qpid-dispatch/pull/1517#issuecomment-1041872307 Great job +1 ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update JavaScript console packages for the 1.19.0 release > - > > Key: DISPATCH-2234 > URL: https://issues.apache.org/jira/browse/DISPATCH-2234 > Project: Qpid Dispatch > Issue Type: Task > Components: Console >Reporter: Jiri Daněk >Assignee: Jiri Daněk >Priority: Major > Fix For: 1.19.0 > > -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] bartoval commented on pull request #1517: DISPATCH-2234: Update JavaScript console packages for the 1.19.0 release
bartoval commented on pull request #1517: URL: https://github.com/apache/qpid-dispatch/pull/1517#issuecomment-1041872307 Great job +1 ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2234) Update JavaScript console packages for the 1.19.0 release
[
https://issues.apache.org/jira/browse/DISPATCH-2234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493346#comment-17493346
]
ASF GitHub Bot commented on DISPATCH-2234:
--
bartoval commented on a change in pull request #1517:
URL: https://github.com/apache/qpid-dispatch/pull/1517#discussion_r808227824
##
File path: console/react/src/App.js
##
@@ -28,26 +29,22 @@ import "@patternfly/patternfly/components/Nav/nav.css";
import { QDRService } from "./common/qdrService";
import "./App.css";
import PageLayout from "./overview/dashboard/layout";
-class App extends Component {
- state = {};
-
- render() {
-// service is passed in to make testing easier
-const service = new QDRService();
-// also, a router is used here to provide PageLayout with a history
property
-return (
-
-
- (
-
-)}
- />
-
-
-);
- }
+
+function App(props) {
+
+ // service is passed in to make testing easier
+ let service = new QDRService();
+
+ // also, a router is used here to provide PageLayout with a history property
+ let history = createHashHistory({ window });
+
+ return (
+
Review comment:
Good point +1.
Probably one of the things to do is refactor the PageLayout component as a
function (but this is out of the scope of this PR honestly) to use directly
hooks. So we can avoid passing history and use directly useNavigate and
useLocation. Then probably we can avoid passing {...props } because without
typescript we lose a bit the control of what we inject in the component.
Moreover the High order component 'WithRoute' will be deleted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Update JavaScript console packages for the 1.19.0 release
> -
>
> Key: DISPATCH-2234
> URL: https://issues.apache.org/jira/browse/DISPATCH-2234
> Project: Qpid Dispatch
> Issue Type: Task
> Components: Console
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
> Fix For: 1.19.0
>
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] bartoval commented on a change in pull request #1517: DISPATCH-2234: Update JavaScript console packages for the 1.19.0 release
bartoval commented on a change in pull request #1517:
URL: https://github.com/apache/qpid-dispatch/pull/1517#discussion_r808227824
##
File path: console/react/src/App.js
##
@@ -28,26 +29,22 @@ import "@patternfly/patternfly/components/Nav/nav.css";
import { QDRService } from "./common/qdrService";
import "./App.css";
import PageLayout from "./overview/dashboard/layout";
-class App extends Component {
- state = {};
-
- render() {
-// service is passed in to make testing easier
-const service = new QDRService();
-// also, a router is used here to provide PageLayout with a history
property
-return (
-
-
- (
-
-)}
- />
-
-
-);
- }
+
+function App(props) {
+
+ // service is passed in to make testing easier
+ let service = new QDRService();
+
+ // also, a router is used here to provide PageLayout with a history property
+ let history = createHashHistory({ window });
+
+ return (
+
Review comment:
Good point +1.
Probably one of the things to do is refactor the PageLayout component as a
function (but this is out of the scope of this PR honestly) to use directly
hooks. So we can avoid passing history and use directly useNavigate and
useLocation. Then probably we can avoid passing {...props } because without
typescript we lose a bit the control of what we inject in the component.
Moreover the High order component 'WithRoute' will be deleted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2234) Update JavaScript console packages for the 1.19.0 release
[
https://issues.apache.org/jira/browse/DISPATCH-2234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493340#comment-17493340
]
ASF GitHub Bot commented on DISPATCH-2234:
--
bartoval commented on a change in pull request #1517:
URL: https://github.com/apache/qpid-dispatch/pull/1517#discussion_r807832047
##
File path: console/react/src/App.js
##
@@ -28,26 +29,22 @@ import "@patternfly/patternfly/components/Nav/nav.css";
import { QDRService } from "./common/qdrService";
import "./App.css";
import PageLayout from "./overview/dashboard/layout";
-class App extends Component {
- state = {};
-
- render() {
-// service is passed in to make testing easier
-const service = new QDRService();
-// also, a router is used here to provide PageLayout with a history
property
-return (
-
-
- (
-
-)}
- />
-
-
-);
- }
+
+function App(props) {
+
+ // service is passed in to make testing easier
+ let service = new QDRService();
Review comment:
You can safetely use the _const_ keyword instead of _let_ here and in
line 39.
`const service = new QDRService();`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Update JavaScript console packages for the 1.19.0 release
> -
>
> Key: DISPATCH-2234
> URL: https://issues.apache.org/jira/browse/DISPATCH-2234
> Project: Qpid Dispatch
> Issue Type: Task
> Components: Console
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
> Fix For: 1.19.0
>
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] bartoval commented on a change in pull request #1517: DISPATCH-2234: Update JavaScript console packages for the 1.19.0 release
bartoval commented on a change in pull request #1517:
URL: https://github.com/apache/qpid-dispatch/pull/1517#discussion_r807832047
##
File path: console/react/src/App.js
##
@@ -28,26 +29,22 @@ import "@patternfly/patternfly/components/Nav/nav.css";
import { QDRService } from "./common/qdrService";
import "./App.css";
import PageLayout from "./overview/dashboard/layout";
-class App extends Component {
- state = {};
-
- render() {
-// service is passed in to make testing easier
-const service = new QDRService();
-// also, a router is used here to provide PageLayout with a history
property
-return (
-
-
- (
-
-)}
- />
-
-
-);
- }
+
+function App(props) {
+
+ // service is passed in to make testing easier
+ let service = new QDRService();
Review comment:
You can safetely use the _const_ keyword instead of _let_ here and in
line 39.
`const service = new QDRService();`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2066) [http1] In system_tests_http1_adaptor Http1AdaptorQ2Standalone backpressure tests, block_ct != unblock_ct
[
https://issues.apache.org/jira/browse/DISPATCH-2066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493278#comment-17493278
]
ASF GitHub Bot commented on DISPATCH-2066:
--
kgiusti commented on a change in pull request #1516:
URL: https://github.com/apache/qpid-dispatch/pull/1516#discussion_r808093159
##
File path: tests/system_tests_http1_adaptor.py
##
@@ -800,15 +799,37 @@ def _read_until_empty(self, sock, timeout):
break # timeout
return data
+def check_logs(self, prefix, log_file):
+# check router log for proper block/unblock activity
+block_ct = 0
+unblock_ct = 0
+block_line = 0
+unblock_line = 0
+line_no = 0
+with io.open(log_file) as f:
+for line in f:
Review comment:
good idea - done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [http1] In system_tests_http1_adaptor Http1AdaptorQ2Standalone backpressure
> tests, block_ct != unblock_ct
> -
>
> Key: DISPATCH-2066
> URL: https://issues.apache.org/jira/browse/DISPATCH-2066
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Protocol Adaptors
>Affects Versions: 1.16.0
>Reporter: Jiri Daněk
>Assignee: Ken Giusti
>Priority: Major
> Labels: HTTP/1.x
> Fix For: 1.19.0
>
>
> https://travis-ci.com/github/apache/qpid-dispatch/jobs/46271#L11501
> {noformat}
> test 70
> Start 70: system_tests_http1_adaptor
> 70: Test command: /usr/bin/python3.8
> "/home/travis/build/apache/qpid-dispatch/build/tests/run.py" "-m" "unittest"
> "-v" "system_tests_http1_adaptor"
> 70: Test timeout computed to be: 500
> 70: test_01_unsolicited_response
> (system_tests_http1_adaptor.Http1AdaptorBadEndpointsTest)
> 70: Create a server that sends an immediate Request Timeout response ... ok
> 70: test_02_bad_request_message
> (system_tests_http1_adaptor.Http1AdaptorBadEndpointsTest)
> 70: Test various improperly constructed request messages ... ok
> 70: test_03_bad_response_message
> (system_tests_http1_adaptor.Http1AdaptorBadEndpointsTest)
> 70: Test various improperly constructed response messages ... ok
> 70:
> 70: Router TestBadEndpoints output file:
> 70:
> 70: -
> 70: Suppressions used:
> 70: count bytes template
> 70: 1 24 ^pn_condition$
> 70: 1 1536 ^pn_raw_connection$
> 70: 1 56 qdr_core_subscribe
> 70: 2112 ^pn_string_grow$
> 70: 7328 ^pn_object_new$
> 70: 1128 ^pn_list$
> 70: 2 48 ^pni_record_create$
> 70: 597 926857 /libpython3.*.so
> 70: -
> 70:
> 70:
> 70:
> 70: test_01_concurrent_requests
> (system_tests_http1_adaptor.Http1AdaptorEdge2EdgeTest)
> 70: Test multiple concurrent clients sending streaming messages ... ok
> 70: test_02_credit_replenish
> (system_tests_http1_adaptor.Http1AdaptorEdge2EdgeTest)
> 70: Verify credit is replenished by sending > the default credit window ... ok
> 70: test_03_server_reconnect
> (system_tests_http1_adaptor.Http1AdaptorEdge2EdgeTest)
> 70: Verify server reconnect logic. ... ok
> 70: test_04_server_pining_for_the_fjords
> (system_tests_http1_adaptor.Http1AdaptorEdge2EdgeTest)
> 70: Test permanent loss of server ... ok
> 70: test_05_large_streaming_msg
> (system_tests_http1_adaptor.Http1AdaptorEdge2EdgeTest)
> 70: Verify large streaming message transfer ... ok
> 70:
> 70: Router EA2 output file:
> 70:
> 70: -
> 70: Suppressions used:
> 70: count bytes template
> 70: 7 59 ^load_server_config$
> 70: 6401 ^qd_dispatch_configure_connector$
> 70: 1 24 ^pn_condition$
> 70: 1 1536 ^pn_raw_connection$
> 70: 1 64 sys_mutex
> 70: 1 56 qdr_core_subscribe
> 70: 2112 ^pn_string_grow$
> 70: 7328 ^pn_object_new$
> 70: 1128 ^pn_list$
> 70: 2 48 ^pni_record_create$
> 70: 601 929697 /libpython3.*.so
> 70: -
> 70:
> 70:
> 70:
> 70:
> 70: Router EA2 debug dump file:
> 70:
> 70: alloc.c: Items of type 'qd_timer_t' remain allocated at shutdown: 1
> (SUPPRESSED)
> 70: alloc.c: Items of type 'qd_connector_t' remain allocated at shutdown: 1
>
[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #1516: DISPATCH-2066: fix flakey http1 Q2 test
kgiusti commented on a change in pull request #1516: URL: https://github.com/apache/qpid-dispatch/pull/1516#discussion_r808093159 ## File path: tests/system_tests_http1_adaptor.py ## @@ -800,15 +799,37 @@ def _read_until_empty(self, sock, timeout): break # timeout return data +def check_logs(self, prefix, log_file): +# check router log for proper block/unblock activity +block_ct = 0 +unblock_ct = 0 +block_line = 0 +unblock_line = 0 +line_no = 0 +with io.open(log_file) as f: +for line in f: Review comment: good idea - done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-2330) system_tests_one_router fails in test_30_presettled_overflow test
[
https://issues.apache.org/jira/browse/DISPATCH-2330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ganesh Murthy resolved DISPATCH-2330.
-
Fix Version/s: 1.19.0
Resolution: Fixed
> system_tests_one_router fails in test_30_presettled_overflow test
> -
>
> Key: DISPATCH-2330
> URL: https://issues.apache.org/jira/browse/DISPATCH-2330
> Project: Qpid Dispatch
> Issue Type: Test
> Components: Tests
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.19.0
>
>
> {noformat}
> self = testMethod=test_30_presettled_overflow>
> def test_30_presettled_overflow(self):
> test = PresettledOverflowTest(self.address)
> test.run()
> > self.assertIsNone(test.error)
>AssertionError: 'No deliveries were dropped' is not None {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2330) system_tests_one_router fails in test_30_presettled_overflow test
[
https://issues.apache.org/jira/browse/DISPATCH-2330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493272#comment-17493272
]
ASF subversion and git services commented on DISPATCH-2330:
---
Commit 75607d11fee7d76e681b040f805542074fc16006 in qpid-dispatch's branch
refs/heads/main from Ganesh Murthy
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=75607d1 ]
DISPATCH-2330: Removed test_30_presettled_overflow since that test case is
already covered in system_tests_delivery_counts.OneRouterLinkCountersTest
testMethod=test_06_large_message_released
> system_tests_one_router fails in test_30_presettled_overflow test
> -
>
> Key: DISPATCH-2330
> URL: https://issues.apache.org/jira/browse/DISPATCH-2330
> Project: Qpid Dispatch
> Issue Type: Test
> Components: Tests
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
>
> {noformat}
> self = testMethod=test_30_presettled_overflow>
> def test_30_presettled_overflow(self):
> test = PresettledOverflowTest(self.address)
> test.run()
> > self.assertIsNone(test.error)
>AssertionError: 'No deliveries were dropped' is not None {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-2330) system_tests_one_router fails in test_30_presettled_overflow test
Ganesh Murthy created DISPATCH-2330:
---
Summary: system_tests_one_router fails in
test_30_presettled_overflow test
Key: DISPATCH-2330
URL: https://issues.apache.org/jira/browse/DISPATCH-2330
Project: Qpid Dispatch
Issue Type: Test
Components: Tests
Reporter: Ganesh Murthy
Assignee: Ganesh Murthy
{noformat}
self =
def test_30_presettled_overflow(self):
test = PresettledOverflowTest(self.address)
test.run()
> self.assertIsNone(test.error)
AssertionError: 'No deliveries were dropped' is not None {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2314) TSAN data race when setting the presettled flag
[
https://issues.apache.org/jira/browse/DISPATCH-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493264#comment-17493264
]
ASF GitHub Bot commented on DISPATCH-2314:
--
ganeshmurthy opened a new pull request #1518:
URL: https://github.com/apache/qpid-dispatch/pull/1518
…etting the presettled flag in qdr_delivery_continue_CT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> TSAN data race when setting the presettled flag
> ---
>
> Key: DISPATCH-2314
> URL: https://issues.apache.org/jira/browse/DISPATCH-2314
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Container
>Reporter: Ganesh Murthy
>Priority: Major
> Labels: race-condition, tsan
>
> {noformat}
> 21: E Process 2380 error: exit code 66, expected 0
> 21: E qdrouterd -c test-router.conf -I
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/python
> 21: E
> /__w/qpid-dispatch/qpid-dispatch/qpid-dispatch/build/tests/system_test.dir/system_tests_one_router/OneRouterTest/setUpClass/test-router-9.cmd
> 21: E
> 21: E ==
> 21: E WARNING: ThreadSanitizer: data race (pid=2380)
> 21: E Write of size 1 at 0x7b440003d355 by thread T4:
> 21: E #0 qdr_delivery_set_presettled
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_core/delivery.c:136
> (qdrouterd+0x49d8c5)
> 21: E #1 AMQP_rx_handler
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_node.c:538
> (qdrouterd+0x4d2ff5)
> 21: E #2 deferred_AMQP_rx_handler
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_node.c:922
> (qdrouterd+0x4d37b2)
> 21: E #3 invoke_deferred_calls
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:801
> (qdrouterd+0x4d584b)
> 21: E #4 invoke_deferred_calls
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:790
> (qdrouterd+0x4d8b16)
> 21: E #5 handle
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1058
> (qdrouterd+0x4d8b16)
> 21: E #6 thread_run
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1133
> (qdrouterd+0x4dae84)
> 21: E #7 _thread_init
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/posix/threading.c:172
> (qdrouterd+0x48160d)
> 21: E
> 21: E Previous read of size 1 at 0x7b440003d355 by thread T1:
> 21: E #0 qdr_delivery_continue_CT
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_core/delivery.c:1108
> (qdrouterd+0x49f9e2)
> 21: E #1 router_core_thread
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_core/router_core_thread.c:236
> (qdrouterd+0x4b572a)
> 21: E #2 _thread_init
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/posix/threading.c:172
> (qdrouterd+0x48160d)
> 21: E
> 21: E Location is heap block of size 320 at 0x7b440003d2c0
> allocated by thread T3:
> 21: E #0 posix_memalign (libtsan.so.0+0x32a23)
> 21: E #1 qd_alloc
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/alloc_pool.c:391
> (qdrouterd+0x44ad29)
> 21: E #2 new_qdr_delivery_t
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_core/delivery.c:24
> (qdrouterd+0x49d33c)
> 21: E #3 qdr_link_deliver
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_core/transfer.c:64
> (qdrouterd+0x4bb125)
> 21: E #4 AMQP_rx_handler
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/router_node.c:877
> (qdrouterd+0x4d3106)
> 21: E #5 do_receive
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/container.c:219
> (qdrouterd+0x45f234)
> 21: E #6 qd_container_handle_event
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/container.c:734
> (qdrouterd+0x45f234)
> 21: E #7 handle
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1108
> (qdrouterd+0x4d8b41)
> 21: E #8 thread_run
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/src/server.c:1133
> (qdrouterd+0x4dae84)
> 21: E #9 _thread_init
>
[GitHub] [qpid-dispatch] ganeshmurthy opened a new pull request #1518: DISPATCH-2314: Added TSAN suppression entry to suppress errors when s…
ganeshmurthy opened a new pull request #1518: URL: https://github.com/apache/qpid-dispatch/pull/1518 …etting the presettled flag in qdr_delivery_continue_CT -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-cpp] grs closed pull request #30: Test: just change some text
grs closed pull request #30: URL: https://github.com/apache/qpid-cpp/pull/30 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2234) Update JavaScript console packages for the 1.19.0 release
[
https://issues.apache.org/jira/browse/DISPATCH-2234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493241#comment-17493241
]
ASF GitHub Bot commented on DISPATCH-2234:
--
jiridanek commented on a change in pull request #1517:
URL: https://github.com/apache/qpid-dispatch/pull/1517#discussion_r807979965
##
File path: console/react/src/App.js
##
@@ -28,26 +29,22 @@ import "@patternfly/patternfly/components/Nav/nav.css";
import { QDRService } from "./common/qdrService";
import "./App.css";
import PageLayout from "./overview/dashboard/layout";
-class App extends Component {
- state = {};
-
- render() {
-// service is passed in to make testing easier
-const service = new QDRService();
-// also, a router is used here to provide PageLayout with a history
property
-return (
-
-
- (
-
-)}
- />
-
-
-);
- }
+
+function App(props) {
+
+ // service is passed in to make testing easier
+ let service = new QDRService();
+
+ // also, a router is used here to provide PageLayout with a history property
+ let history = createHashHistory({ window });
+
+ return (
+
Review comment:
Yeah, that is how you are supposed to use HistoryRouter, according to
docs, https://reactrouter.com/docs/en/v6/api#unstable_historyrouter
Honestly, there are two things in the console, related to react-router-dom,
that I think can be now done better
- navigating between pages; which is now done inconsistently, either with
``, or `navigate()`, or through `history`.
- the page structure which is supposed to use the `` feature but it
does not
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Update JavaScript console packages for the 1.19.0 release
> -
>
> Key: DISPATCH-2234
> URL: https://issues.apache.org/jira/browse/DISPATCH-2234
> Project: Qpid Dispatch
> Issue Type: Task
> Components: Console
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
> Fix For: 1.19.0
>
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek commented on a change in pull request #1517: DISPATCH-2234: Update JavaScript console packages for the 1.19.0 release
jiridanek commented on a change in pull request #1517:
URL: https://github.com/apache/qpid-dispatch/pull/1517#discussion_r807979965
##
File path: console/react/src/App.js
##
@@ -28,26 +29,22 @@ import "@patternfly/patternfly/components/Nav/nav.css";
import { QDRService } from "./common/qdrService";
import "./App.css";
import PageLayout from "./overview/dashboard/layout";
-class App extends Component {
- state = {};
-
- render() {
-// service is passed in to make testing easier
-const service = new QDRService();
-// also, a router is used here to provide PageLayout with a history
property
-return (
-
-
- (
-
-)}
- />
-
-
-);
- }
+
+function App(props) {
+
+ // service is passed in to make testing easier
+ let service = new QDRService();
+
+ // also, a router is used here to provide PageLayout with a history property
+ let history = createHashHistory({ window });
+
+ return (
+
Review comment:
Yeah, that is how you are supposed to use HistoryRouter, according to
docs, https://reactrouter.com/docs/en/v6/api#unstable_historyrouter
Honestly, there are two things in the console, related to react-router-dom,
that I think can be now done better
- navigating between pages; which is now done inconsistently, either with
``, or `navigate()`, or through `history`.
- the page structure which is supposed to use the `` feature but it
does not
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2234) Update JavaScript console packages for the 1.19.0 release
[
https://issues.apache.org/jira/browse/DISPATCH-2234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493238#comment-17493238
]
ASF GitHub Bot commented on DISPATCH-2234:
--
bartoval commented on a change in pull request #1517:
URL: https://github.com/apache/qpid-dispatch/pull/1517#discussion_r807967089
##
File path: console/react/src/App.js
##
@@ -28,26 +29,22 @@ import "@patternfly/patternfly/components/Nav/nav.css";
import { QDRService } from "./common/qdrService";
import "./App.css";
import PageLayout from "./overview/dashboard/layout";
-class App extends Component {
- state = {};
-
- render() {
-// service is passed in to make testing easier
-const service = new QDRService();
-// also, a router is used here to provide PageLayout with a history
property
-return (
-
-
- (
-
-)}
- />
-
-
-);
- }
+
+function App(props) {
+
+ // service is passed in to make testing easier
+ let service = new QDRService();
+
+ // also, a router is used here to provide PageLayout with a history property
+ let history = createHashHistory({ window });
+
+ return (
+
Review comment:
Here I see that the child component PageLayout pass explicitly the pro
```history={history}``` and history coming from ``` createHashHistory({ window
});```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Update JavaScript console packages for the 1.19.0 release
> -
>
> Key: DISPATCH-2234
> URL: https://issues.apache.org/jira/browse/DISPATCH-2234
> Project: Qpid Dispatch
> Issue Type: Task
> Components: Console
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
> Fix For: 1.19.0
>
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] bartoval commented on a change in pull request #1517: DISPATCH-2234: Update JavaScript console packages for the 1.19.0 release
bartoval commented on a change in pull request #1517:
URL: https://github.com/apache/qpid-dispatch/pull/1517#discussion_r807967089
##
File path: console/react/src/App.js
##
@@ -28,26 +29,22 @@ import "@patternfly/patternfly/components/Nav/nav.css";
import { QDRService } from "./common/qdrService";
import "./App.css";
import PageLayout from "./overview/dashboard/layout";
-class App extends Component {
- state = {};
-
- render() {
-// service is passed in to make testing easier
-const service = new QDRService();
-// also, a router is used here to provide PageLayout with a history
property
-return (
-
-
- (
-
-)}
- />
-
-
-);
- }
+
+function App(props) {
+
+ // service is passed in to make testing easier
+ let service = new QDRService();
+
+ // also, a router is used here to provide PageLayout with a history property
+ let history = createHashHistory({ window });
+
+ return (
+
Review comment:
Here I see that the child component PageLayout pass explicitly the pro
```history={history}``` and history coming from ``` createHashHistory({ window
});```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2234) Update JavaScript console packages for the 1.19.0 release
[
https://issues.apache.org/jira/browse/DISPATCH-2234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493235#comment-17493235
]
ASF GitHub Bot commented on DISPATCH-2234:
--
jiridanek commented on a change in pull request #1517:
URL: https://github.com/apache/qpid-dispatch/pull/1517#discussion_r807960231
##
File path: console/react/src/App.js
##
@@ -28,26 +29,22 @@ import "@patternfly/patternfly/components/Nav/nav.css";
import { QDRService } from "./common/qdrService";
import "./App.css";
import PageLayout from "./overview/dashboard/layout";
-class App extends Component {
- state = {};
-
- render() {
-// service is passed in to make testing easier
-const service = new QDRService();
-// also, a router is used here to provide PageLayout with a history
property
-return (
-
-
- (
-
-)}
- />
-
-
-);
- }
+
+function App(props) {
+
+ // service is passed in to make testing easier
+ let service = new QDRService();
+
+ // also, a router is used here to provide PageLayout with a history property
+ let history = createHashHistory({ window });
+
+ return (
+
Review comment:
Because the code of some components nested further in needs to have
`history` instance in properties. That is not available in react-router-dom v6
unless I put it there. And `HistoryRouter` is the way to inject `history`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Update JavaScript console packages for the 1.19.0 release
> -
>
> Key: DISPATCH-2234
> URL: https://issues.apache.org/jira/browse/DISPATCH-2234
> Project: Qpid Dispatch
> Issue Type: Task
> Components: Console
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
> Fix For: 1.19.0
>
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2234) Update JavaScript console packages for the 1.19.0 release
[
https://issues.apache.org/jira/browse/DISPATCH-2234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493232#comment-17493232
]
ASF GitHub Bot commented on DISPATCH-2234:
--
jiridanek commented on a change in pull request #1517:
URL: https://github.com/apache/qpid-dispatch/pull/1517#discussion_r807959553
##
File path: console/react/package.json
##
@@ -1,25 +1,25 @@
{
"name": "dispatch-console",
- "version": "1.17.0",
+ "version": "1.19.0",
"private": true,
"dependencies": {
-"@patternfly/patternfly": "^4.125.3",
-"@patternfly/react-charts": "^6.15.14",
-"@patternfly/react-core": "^4.147.0",
-"@patternfly/react-icons": "^4.11.8",
-"@patternfly/react-styles": "^4.11.8",
-"@patternfly/react-table": "^4.29.37",
-"@patternfly/react-topology": "^4.9.42",
+"@patternfly/patternfly": "^4.171.1",
+"@patternfly/react-charts": "^6.45.15",
+"@patternfly/react-core": "^4.192.15",
+"@patternfly/react-icons": "^4.43.15",
+"@patternfly/react-styles": "^4.42.15",
+"@patternfly/react-table": "^4.61.15",
+"@patternfly/react-topology": "^4.39.15",
"d3": "^3.5.17",
"d3-queue": "^3.0.7",
-"express": "^4.17.1",
+"express": "^4.17.2",
"font-awesome": "^4.7.0",
-"prop-types": "^15.7.2",
+"prop-types": "^15.8.1",
"react": "^17.0.2",
"react-dom": "^17.0.2",
"react-fontawesome": "^1.7.1",
-"react-router-dom": "^5.2.0",
-"rhea": "^2.0.4",
+"react-router-dom": "^6.2.1",
Review comment:
I think so, but there is not a thoughtfully developed policy on this in
the dispatch-router project.
Normally, for the native code components (the qdrouterd itself), the
versions of dependencies are dictated by the minimum version present in Linux
distributions that needs to be supported; that is, centos/rhel/fedora and
ubuntu. This is how C projects usually work. There are some packaging systems
for C, similar to npm, but the traditional Linux practice is to rely on your
distro.
In Javascript, all dependencies come from npm, so there the only limitation
coming from distros is version of nodejs.
I believe that the most sensible policy is to keep up with the latest
upstream version and to upgrade often. Here are my reasons for that
- security: minimizes the amount of `npm audit` warnings
- ease of update: when required (due to npm audit warnings), it helps if we
are on still actively supported recent version
- small diffs on upgrade: when the upgrade is done soon, the amount of
changes will be smaller than when having to upgrade over multiple major versions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Update JavaScript console packages for the 1.19.0 release
> -
>
> Key: DISPATCH-2234
> URL: https://issues.apache.org/jira/browse/DISPATCH-2234
> Project: Qpid Dispatch
> Issue Type: Task
> Components: Console
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
> Fix For: 1.19.0
>
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2234) Update JavaScript console packages for the 1.19.0 release
[
https://issues.apache.org/jira/browse/DISPATCH-2234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493233#comment-17493233
]
ASF GitHub Bot commented on DISPATCH-2234:
--
jiridanek commented on a change in pull request #1517:
URL: https://github.com/apache/qpid-dispatch/pull/1517#discussion_r807959792
##
File path: console/react/src/App.js
##
@@ -28,26 +29,22 @@ import "@patternfly/patternfly/components/Nav/nav.css";
import { QDRService } from "./common/qdrService";
import "./App.css";
import PageLayout from "./overview/dashboard/layout";
-class App extends Component {
- state = {};
-
- render() {
-// service is passed in to make testing easier
-const service = new QDRService();
-// also, a router is used here to provide PageLayout with a history
property
-return (
-
-
- (
-
-)}
- />
-
-
-);
- }
+
+function App(props) {
+
+ // service is passed in to make testing easier
+ let service = new QDRService();
Review comment:
:+1:
##
File path: console/react/src/overview/dashboard/layout.test.js
##
@@ -21,6 +21,7 @@ import React from "react";
import { render } from "@testing-library/react";
import { service } from "../../serviceTest";
import PageLayout from "./layout";
+import {MemoryRouter} from "react-router-dom";
Review comment:
`MemoryRouter` is intended for testing in nodejs (outside of browser).
`HistoryRouter` is meant to allow injecting your own `history` instance.
(https://reactrouter.com/docs/en/v6/api#setup)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Update JavaScript console packages for the 1.19.0 release
> -
>
> Key: DISPATCH-2234
> URL: https://issues.apache.org/jira/browse/DISPATCH-2234
> Project: Qpid Dispatch
> Issue Type: Task
> Components: Console
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
> Fix For: 1.19.0
>
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek commented on a change in pull request #1517: DISPATCH-2234: Update JavaScript console packages for the 1.19.0 release
jiridanek commented on a change in pull request #1517:
URL: https://github.com/apache/qpid-dispatch/pull/1517#discussion_r807960231
##
File path: console/react/src/App.js
##
@@ -28,26 +29,22 @@ import "@patternfly/patternfly/components/Nav/nav.css";
import { QDRService } from "./common/qdrService";
import "./App.css";
import PageLayout from "./overview/dashboard/layout";
-class App extends Component {
- state = {};
-
- render() {
-// service is passed in to make testing easier
-const service = new QDRService();
-// also, a router is used here to provide PageLayout with a history
property
-return (
-
-
- (
-
-)}
- />
-
-
-);
- }
+
+function App(props) {
+
+ // service is passed in to make testing easier
+ let service = new QDRService();
+
+ // also, a router is used here to provide PageLayout with a history property
+ let history = createHashHistory({ window });
+
+ return (
+
Review comment:
Because the code of some components nested further in needs to have
`history` instance in properties. That is not available in react-router-dom v6
unless I put it there. And `HistoryRouter` is the way to inject `history`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek commented on a change in pull request #1517: DISPATCH-2234: Update JavaScript console packages for the 1.19.0 release
jiridanek commented on a change in pull request #1517:
URL: https://github.com/apache/qpid-dispatch/pull/1517#discussion_r807959792
##
File path: console/react/src/App.js
##
@@ -28,26 +29,22 @@ import "@patternfly/patternfly/components/Nav/nav.css";
import { QDRService } from "./common/qdrService";
import "./App.css";
import PageLayout from "./overview/dashboard/layout";
-class App extends Component {
- state = {};
-
- render() {
-// service is passed in to make testing easier
-const service = new QDRService();
-// also, a router is used here to provide PageLayout with a history
property
-return (
-
-
- (
-
-)}
- />
-
-
-);
- }
+
+function App(props) {
+
+ // service is passed in to make testing easier
+ let service = new QDRService();
Review comment:
:+1:
##
File path: console/react/src/overview/dashboard/layout.test.js
##
@@ -21,6 +21,7 @@ import React from "react";
import { render } from "@testing-library/react";
import { service } from "../../serviceTest";
import PageLayout from "./layout";
+import {MemoryRouter} from "react-router-dom";
Review comment:
`MemoryRouter` is intended for testing in nodejs (outside of browser).
`HistoryRouter` is meant to allow injecting your own `history` instance.
(https://reactrouter.com/docs/en/v6/api#setup)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek commented on a change in pull request #1517: DISPATCH-2234: Update JavaScript console packages for the 1.19.0 release
jiridanek commented on a change in pull request #1517:
URL: https://github.com/apache/qpid-dispatch/pull/1517#discussion_r807959553
##
File path: console/react/package.json
##
@@ -1,25 +1,25 @@
{
"name": "dispatch-console",
- "version": "1.17.0",
+ "version": "1.19.0",
"private": true,
"dependencies": {
-"@patternfly/patternfly": "^4.125.3",
-"@patternfly/react-charts": "^6.15.14",
-"@patternfly/react-core": "^4.147.0",
-"@patternfly/react-icons": "^4.11.8",
-"@patternfly/react-styles": "^4.11.8",
-"@patternfly/react-table": "^4.29.37",
-"@patternfly/react-topology": "^4.9.42",
+"@patternfly/patternfly": "^4.171.1",
+"@patternfly/react-charts": "^6.45.15",
+"@patternfly/react-core": "^4.192.15",
+"@patternfly/react-icons": "^4.43.15",
+"@patternfly/react-styles": "^4.42.15",
+"@patternfly/react-table": "^4.61.15",
+"@patternfly/react-topology": "^4.39.15",
"d3": "^3.5.17",
"d3-queue": "^3.0.7",
-"express": "^4.17.1",
+"express": "^4.17.2",
"font-awesome": "^4.7.0",
-"prop-types": "^15.7.2",
+"prop-types": "^15.8.1",
"react": "^17.0.2",
"react-dom": "^17.0.2",
"react-fontawesome": "^1.7.1",
-"react-router-dom": "^5.2.0",
-"rhea": "^2.0.4",
+"react-router-dom": "^6.2.1",
Review comment:
I think so, but there is not a thoughtfully developed policy on this in
the dispatch-router project.
Normally, for the native code components (the qdrouterd itself), the
versions of dependencies are dictated by the minimum version present in Linux
distributions that needs to be supported; that is, centos/rhel/fedora and
ubuntu. This is how C projects usually work. There are some packaging systems
for C, similar to npm, but the traditional Linux practice is to rely on your
distro.
In Javascript, all dependencies come from npm, so there the only limitation
coming from distros is version of nodejs.
I believe that the most sensible policy is to keep up with the latest
upstream version and to upgrade often. Here are my reasons for that
- security: minimizes the amount of `npm audit` warnings
- ease of update: when required (due to npm audit warnings), it helps if we
are on still actively supported recent version
- small diffs on upgrade: when the upgrade is done soon, the amount of
changes will be smaller than when having to upgrade over multiple major versions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2234) Update JavaScript console packages for the 1.19.0 release
[
https://issues.apache.org/jira/browse/DISPATCH-2234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493214#comment-17493214
]
ASF GitHub Bot commented on DISPATCH-2234:
--
bartoval commented on a change in pull request #1517:
URL: https://github.com/apache/qpid-dispatch/pull/1517#discussion_r807832047
##
File path: console/react/src/App.js
##
@@ -28,26 +29,22 @@ import "@patternfly/patternfly/components/Nav/nav.css";
import { QDRService } from "./common/qdrService";
import "./App.css";
import PageLayout from "./overview/dashboard/layout";
-class App extends Component {
- state = {};
-
- render() {
-// service is passed in to make testing easier
-const service = new QDRService();
-// also, a router is used here to provide PageLayout with a history
property
-return (
-
-
- (
-
-)}
- />
-
-
-);
- }
+
+function App(props) {
+
+ // service is passed in to make testing easier
+ let service = new QDRService();
Review comment:
You can safetely use the _const_ keyword instead of _let_ here and in
line 39.
`let service = new QDRService();`
##
File path: console/react/src/App.js
##
@@ -28,26 +29,22 @@ import "@patternfly/patternfly/components/Nav/nav.css";
import { QDRService } from "./common/qdrService";
import "./App.css";
import PageLayout from "./overview/dashboard/layout";
-class App extends Component {
- state = {};
-
- render() {
-// service is passed in to make testing easier
-const service = new QDRService();
-// also, a router is used here to provide PageLayout with a history
property
-return (
-
-
- (
-
-)}
- />
-
-
-);
- }
+
+function App(props) {
+
+ // service is passed in to make testing easier
+ let service = new QDRService();
+
+ // also, a router is used here to provide PageLayout with a history property
+ let history = createHashHistory({ window });
+
+ return (
+
Review comment:
Why we are using HistoryRouter here? Before this refactoring, we used
the HashRouter.
##
File path: console/react/package.json
##
@@ -1,25 +1,25 @@
{
"name": "dispatch-console",
- "version": "1.17.0",
+ "version": "1.19.0",
"private": true,
"dependencies": {
-"@patternfly/patternfly": "^4.125.3",
-"@patternfly/react-charts": "^6.15.14",
-"@patternfly/react-core": "^4.147.0",
-"@patternfly/react-icons": "^4.11.8",
-"@patternfly/react-styles": "^4.11.8",
-"@patternfly/react-table": "^4.29.37",
-"@patternfly/react-topology": "^4.9.42",
+"@patternfly/patternfly": "^4.171.1",
+"@patternfly/react-charts": "^6.45.15",
+"@patternfly/react-core": "^4.192.15",
+"@patternfly/react-icons": "^4.43.15",
+"@patternfly/react-styles": "^4.42.15",
+"@patternfly/react-table": "^4.61.15",
+"@patternfly/react-topology": "^4.39.15",
"d3": "^3.5.17",
"d3-queue": "^3.0.7",
-"express": "^4.17.1",
+"express": "^4.17.2",
"font-awesome": "^4.7.0",
-"prop-types": "^15.7.2",
+"prop-types": "^15.8.1",
"react": "^17.0.2",
"react-dom": "^17.0.2",
"react-fontawesome": "^1.7.1",
-"react-router-dom": "^5.2.0",
-"rhea": "^2.0.4",
+"react-router-dom": "^6.2.1",
Review comment:
That is a breaking change. is it worth changing the library?
##
File path: console/react/src/overview/dashboard/layout.test.js
##
@@ -21,6 +21,7 @@ import React from "react";
import { render } from "@testing-library/react";
import { service } from "../../serviceTest";
import PageLayout from "./layout";
+import {MemoryRouter} from "react-router-dom";
Review comment:
Why we are using MemoryRouter here?
I see in the code we use the History Router.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Update JavaScript console packages for the 1.19.0 release
> -
>
> Key: DISPATCH-2234
> URL: https://issues.apache.org/jira/browse/DISPATCH-2234
> Project: Qpid Dispatch
> Issue Type: Task
> Components: Console
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
> Fix For: 1.19.0
>
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] bartoval commented on a change in pull request #1517: DISPATCH-2234: Update JavaScript console packages for the 1.19.0 release
bartoval commented on a change in pull request #1517:
URL: https://github.com/apache/qpid-dispatch/pull/1517#discussion_r807832047
##
File path: console/react/src/App.js
##
@@ -28,26 +29,22 @@ import "@patternfly/patternfly/components/Nav/nav.css";
import { QDRService } from "./common/qdrService";
import "./App.css";
import PageLayout from "./overview/dashboard/layout";
-class App extends Component {
- state = {};
-
- render() {
-// service is passed in to make testing easier
-const service = new QDRService();
-// also, a router is used here to provide PageLayout with a history
property
-return (
-
-
- (
-
-)}
- />
-
-
-);
- }
+
+function App(props) {
+
+ // service is passed in to make testing easier
+ let service = new QDRService();
Review comment:
You can safetely use the _const_ keyword instead of _let_ here and in
line 39.
`let service = new QDRService();`
##
File path: console/react/src/App.js
##
@@ -28,26 +29,22 @@ import "@patternfly/patternfly/components/Nav/nav.css";
import { QDRService } from "./common/qdrService";
import "./App.css";
import PageLayout from "./overview/dashboard/layout";
-class App extends Component {
- state = {};
-
- render() {
-// service is passed in to make testing easier
-const service = new QDRService();
-// also, a router is used here to provide PageLayout with a history
property
-return (
-
-
- (
-
-)}
- />
-
-
-);
- }
+
+function App(props) {
+
+ // service is passed in to make testing easier
+ let service = new QDRService();
+
+ // also, a router is used here to provide PageLayout with a history property
+ let history = createHashHistory({ window });
+
+ return (
+
Review comment:
Why we are using HistoryRouter here? Before this refactoring, we used
the HashRouter.
##
File path: console/react/package.json
##
@@ -1,25 +1,25 @@
{
"name": "dispatch-console",
- "version": "1.17.0",
+ "version": "1.19.0",
"private": true,
"dependencies": {
-"@patternfly/patternfly": "^4.125.3",
-"@patternfly/react-charts": "^6.15.14",
-"@patternfly/react-core": "^4.147.0",
-"@patternfly/react-icons": "^4.11.8",
-"@patternfly/react-styles": "^4.11.8",
-"@patternfly/react-table": "^4.29.37",
-"@patternfly/react-topology": "^4.9.42",
+"@patternfly/patternfly": "^4.171.1",
+"@patternfly/react-charts": "^6.45.15",
+"@patternfly/react-core": "^4.192.15",
+"@patternfly/react-icons": "^4.43.15",
+"@patternfly/react-styles": "^4.42.15",
+"@patternfly/react-table": "^4.61.15",
+"@patternfly/react-topology": "^4.39.15",
"d3": "^3.5.17",
"d3-queue": "^3.0.7",
-"express": "^4.17.1",
+"express": "^4.17.2",
"font-awesome": "^4.7.0",
-"prop-types": "^15.7.2",
+"prop-types": "^15.8.1",
"react": "^17.0.2",
"react-dom": "^17.0.2",
"react-fontawesome": "^1.7.1",
-"react-router-dom": "^5.2.0",
-"rhea": "^2.0.4",
+"react-router-dom": "^6.2.1",
Review comment:
That is a breaking change. is it worth changing the library?
##
File path: console/react/src/overview/dashboard/layout.test.js
##
@@ -21,6 +21,7 @@ import React from "react";
import { render } from "@testing-library/react";
import { service } from "../../serviceTest";
import PageLayout from "./layout";
+import {MemoryRouter} from "react-router-dom";
Review comment:
Why we are using MemoryRouter here?
I see in the code we use the History Router.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-2066) [http1] In system_tests_http1_adaptor Http1AdaptorQ2Standalone backpressure tests, block_ct != unblock_ct
[
https://issues.apache.org/jira/browse/DISPATCH-2066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493055#comment-17493055
]
ASF GitHub Bot commented on DISPATCH-2066:
--
jiridanek commented on a change in pull request #1516:
URL: https://github.com/apache/qpid-dispatch/pull/1516#discussion_r807650507
##
File path: tests/system_tests_http1_adaptor.py
##
@@ -951,18 +964,8 @@ def test_02_backpressure_server(self):
server_listener.shutdown(socket.SHUT_RDWR)
server_listener.close()
-# search the router log file to verify Q2 was hit
-
-block_ct = 0
-unblock_ct = 0
-with io.open(self.INT_A.logfile_path) as f:
-for line in f:
-if 'server link blocked on Q2 limit' in line:
-block_ct += 1
-if 'server link unblocked from Q2 limit' in line:
-unblock_ct += 1
-self.assertTrue(block_ct > 0)
-self.assertEqual(block_ct, unblock_ct)
+router.teardown()
+self.check_logs("server", router.logfile_path)
Review comment:
@kgiusti correct, I haven't realized that this system_test.py#L814 is
operating there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [http1] In system_tests_http1_adaptor Http1AdaptorQ2Standalone backpressure
> tests, block_ct != unblock_ct
> -
>
> Key: DISPATCH-2066
> URL: https://issues.apache.org/jira/browse/DISPATCH-2066
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Protocol Adaptors
>Affects Versions: 1.16.0
>Reporter: Jiri Daněk
>Assignee: Ken Giusti
>Priority: Major
> Labels: HTTP/1.x
> Fix For: 1.19.0
>
>
> https://travis-ci.com/github/apache/qpid-dispatch/jobs/46271#L11501
> {noformat}
> test 70
> Start 70: system_tests_http1_adaptor
> 70: Test command: /usr/bin/python3.8
> "/home/travis/build/apache/qpid-dispatch/build/tests/run.py" "-m" "unittest"
> "-v" "system_tests_http1_adaptor"
> 70: Test timeout computed to be: 500
> 70: test_01_unsolicited_response
> (system_tests_http1_adaptor.Http1AdaptorBadEndpointsTest)
> 70: Create a server that sends an immediate Request Timeout response ... ok
> 70: test_02_bad_request_message
> (system_tests_http1_adaptor.Http1AdaptorBadEndpointsTest)
> 70: Test various improperly constructed request messages ... ok
> 70: test_03_bad_response_message
> (system_tests_http1_adaptor.Http1AdaptorBadEndpointsTest)
> 70: Test various improperly constructed response messages ... ok
> 70:
> 70: Router TestBadEndpoints output file:
> 70:
> 70: -
> 70: Suppressions used:
> 70: count bytes template
> 70: 1 24 ^pn_condition$
> 70: 1 1536 ^pn_raw_connection$
> 70: 1 56 qdr_core_subscribe
> 70: 2112 ^pn_string_grow$
> 70: 7328 ^pn_object_new$
> 70: 1128 ^pn_list$
> 70: 2 48 ^pni_record_create$
> 70: 597 926857 /libpython3.*.so
> 70: -
> 70:
> 70:
> 70:
> 70: test_01_concurrent_requests
> (system_tests_http1_adaptor.Http1AdaptorEdge2EdgeTest)
> 70: Test multiple concurrent clients sending streaming messages ... ok
> 70: test_02_credit_replenish
> (system_tests_http1_adaptor.Http1AdaptorEdge2EdgeTest)
> 70: Verify credit is replenished by sending > the default credit window ... ok
> 70: test_03_server_reconnect
> (system_tests_http1_adaptor.Http1AdaptorEdge2EdgeTest)
> 70: Verify server reconnect logic. ... ok
> 70: test_04_server_pining_for_the_fjords
> (system_tests_http1_adaptor.Http1AdaptorEdge2EdgeTest)
> 70: Test permanent loss of server ... ok
> 70: test_05_large_streaming_msg
> (system_tests_http1_adaptor.Http1AdaptorEdge2EdgeTest)
> 70: Verify large streaming message transfer ... ok
> 70:
> 70: Router EA2 output file:
> 70:
> 70: -
> 70: Suppressions used:
> 70: count bytes template
> 70: 7 59 ^load_server_config$
> 70: 6401 ^qd_dispatch_configure_connector$
> 70: 1 24 ^pn_condition$
> 70: 1 1536 ^pn_raw_connection$
> 70: 1 64 sys_mutex
> 70: 1 56 qdr_core_subscribe
> 70: 2112 ^pn_string_grow$
> 70: 7328 ^pn_object_new$
> 70: 1128 ^pn_list$
> 70: 2 48
[GitHub] [qpid-dispatch] jiridanek commented on a change in pull request #1516: DISPATCH-2066: fix flakey http1 Q2 test
jiridanek commented on a change in pull request #1516:
URL: https://github.com/apache/qpid-dispatch/pull/1516#discussion_r807650507
##
File path: tests/system_tests_http1_adaptor.py
##
@@ -951,18 +964,8 @@ def test_02_backpressure_server(self):
server_listener.shutdown(socket.SHUT_RDWR)
server_listener.close()
-# search the router log file to verify Q2 was hit
-
-block_ct = 0
-unblock_ct = 0
-with io.open(self.INT_A.logfile_path) as f:
-for line in f:
-if 'server link blocked on Q2 limit' in line:
-block_ct += 1
-if 'server link unblocked from Q2 limit' in line:
-unblock_ct += 1
-self.assertTrue(block_ct > 0)
-self.assertEqual(block_ct, unblock_ct)
+router.teardown()
+self.check_logs("server", router.logfile_path)
Review comment:
@kgiusti correct, I haven't realized that this system_test.py#L814 is
operating there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek commented on a change in pull request #1515: Dispatch 1487: message annotations re-write (full patch)
jiridanek commented on a change in pull request #1515: URL: https://github.com/apache/qpid-dispatch/pull/1515#discussion_r807646524 ## File path: include/qpid/dispatch/amqp.h ## @@ -19,6 +19,8 @@ * under the License. Review comment: Router seems to be exiting cleanly, the log says ``` 25: Router QDR.Policy output file: 25: 25: - 25: Suppressions used: 25: count bytes template 25: 1 56 ^IoAdapter_init$ 25: 2 46 ^load_server_config$ 25: 6192 ^qd_policy_c_counts_alloc$ 25: 591 901140 /libpython3.*.so 25: - ``` That to me suggest the exit code of the router was also checked. I think it could be a case of the stalls/freezes as in https://issues.apache.org/jira/browse/DISPATCH-2094, except there a timeout in the tests allows to fail a single test and carry on. So, quite possibly this is not new problem introduced by PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
