[jira] [Commented] (PROTON-1224) Proton-J SSL uses deprecated Bouncy Castle functionality

2016-08-31 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/PROTON-1224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15453173#comment-15453173
 ] 

ASF GitHub Bot commented on PROTON-1224:


Github user JemDay commented on the issue:

https://github.com/apache/qpid-proton/pull/79
  
Robbie..

As-per JIRA comment we were able to verify functionality with successful 
connections to a dispatch-router network.

Looks good, thanks for your patience.

J--


> Proton-J SSL uses deprecated Bouncy Castle functionality
> 
>
> Key: PROTON-1224
> URL: https://issues.apache.org/jira/browse/PROTON-1224
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: proton-j
>Affects Versions: 0.12.2
>Reporter: Jem Day
>
> The BouncyCastle project deprecated functionality used by the proton-j driver 
> in version 1.48. This causes run-time issues for us as our application 
> containers are using newer BC versions.
> Thanks for you patience with this, hopefully this is now cleaner PR, I have 
> closed the original PR #75
> Jem



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1224) Proton-J SSL uses deprecated Bouncy Castle functionality

2016-08-30 Thread Jem Day (JIRA) 

[ 
https://issues.apache.org/jira/browse/PROTON-1224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15450067#comment-15450067
 ] 

Jem Day commented on PROTON-1224:
-

Robbie - Have verified your changes and we were able to establish SSL 
connections to a dispatch router instance

Looks good.

> Proton-J SSL uses deprecated Bouncy Castle functionality
> 
>
> Key: PROTON-1224
> URL: https://issues.apache.org/jira/browse/PROTON-1224
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: proton-j
>Affects Versions: 0.12.2
>Reporter: Jem Day
>
> The BouncyCastle project deprecated functionality used by the proton-j driver 
> in version 1.48. This causes run-time issues for us as our application 
> containers are using newer BC versions.
> Thanks for you patience with this, hopefully this is now cleaner PR, I have 
> closed the original PR #75
> Jem



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1224) Proton-J SSL uses deprecated Bouncy Castle functionality

2016-08-29 Thread Jem Day (JIRA) 

[ 
https://issues.apache.org/jira/browse/PROTON-1224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15447151#comment-15447151
 ] 

Jem Day commented on PROTON-1224:
-

Robbie - Sorry for the delay, re-verifying internally is taking longer than 
expected ..

> Proton-J SSL uses deprecated Bouncy Castle functionality
> 
>
> Key: PROTON-1224
> URL: https://issues.apache.org/jira/browse/PROTON-1224
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: proton-j
>Affects Versions: 0.12.2
>Reporter: Jem Day
>
> The BouncyCastle project deprecated functionality used by the proton-j driver 
> in version 1.48. This causes run-time issues for us as our application 
> containers are using newer BC versions.
> Thanks for you patience with this, hopefully this is now cleaner PR, I have 
> closed the original PR #75
> Jem



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1224) Proton-J SSL uses deprecated Bouncy Castle functionality

2016-08-25 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/PROTON-1224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15437561#comment-15437561
 ] 

ASF GitHub Bot commented on PROTON-1224:


Github user JemDay commented on the issue:

https://github.com/apache/qpid-proton/pull/79
  
Robbie

Thanks, i've taken a quick look and nothing leaps out at me, i'll try 
pulling this down and checking locally. I will try and get to this today but it 
might stretch to tomorrow.

I'd also like to discuss off-line another enhancement we'd like to make 
whereby we can provide/inject an SSLContext directly - this is the way we can 
conform with our in-house security constraints and mechanisms.

Jem..


> Proton-J SSL uses deprecated Bouncy Castle functionality
> 
>
> Key: PROTON-1224
> URL: https://issues.apache.org/jira/browse/PROTON-1224
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: proton-j
>Affects Versions: 0.12.2
>Reporter: Jem Day
>
> The BouncyCastle project deprecated functionality used by the proton-j driver 
> in version 1.48. This causes run-time issues for us as our application 
> containers are using newer BC versions.
> Thanks for you patience with this, hopefully this is now cleaner PR, I have 
> closed the original PR #75
> Jem



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1224) Proton-J SSL uses deprecated Bouncy Castle functionality

2016-08-25 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/PROTON-1224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15437094#comment-15437094
 ] 

ASF GitHub Bot commented on PROTON-1224:


Github user gemmellr commented on the issue:

https://github.com/apache/qpid-proton/pull/79
  
@JemDay I've made some updates to your patch, if youd like to give things a 
look over and try out and let me know how you get on that would be good, then I 
can merge it (might squash things first, left them separate for now).


> Proton-J SSL uses deprecated Bouncy Castle functionality
> 
>
> Key: PROTON-1224
> URL: https://issues.apache.org/jira/browse/PROTON-1224
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: proton-j
>Affects Versions: 0.12.2
>Reporter: Jem Day
>
> The BouncyCastle project deprecated functionality used by the proton-j driver 
> in version 1.48. This causes run-time issues for us as our application 
> containers are using newer BC versions.
> Thanks for you patience with this, hopefully this is now cleaner PR, I have 
> closed the original PR #75
> Jem



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1224) Proton-J SSL uses deprecated Bouncy Castle functionality

2016-08-25 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/PROTON-1224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15437082#comment-15437082
 ] 

ASF GitHub Bot commented on PROTON-1224:


GitHub user gemmellr opened a pull request:

https://github.com/apache/qpid-proton/pull/79

PROTON-1224: support newer BouncyCastle versions

Update based on PR #78

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gemmellr/qpid-proton bouncycastle-update

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-proton/pull/79.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #79


commit 0642fa59caa0e62bb19485b83248ca65d91e213f
Author: Jem Day 
Date:   2016-08-22T20:37:39Z

PROTON-1224: Support newer BouncyCastle Implementations

Support new version of BouncyCastle library via existing reflection
mechanism.
Added Unit-tests

commit 24873ebd1191af7b03937fa93329458c69eb80b7
Author: Robert Gemmell 
Date:   2016-08-25T14:48:06Z

PROTON-1224: rework loading of bouncycastle to ensure failure is detected, 
but suppressed since its optional, and actually reported at the point usage 
would fail. Fix up various whitespace etc issues.




> Proton-J SSL uses deprecated Bouncy Castle functionality
> 
>
> Key: PROTON-1224
> URL: https://issues.apache.org/jira/browse/PROTON-1224
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: proton-j
>Affects Versions: 0.12.2
>Reporter: Jem Day
>
> The BouncyCastle project deprecated functionality used by the proton-j driver 
> in version 1.48. This causes run-time issues for us as our application 
> containers are using newer BC versions.
> Thanks for you patience with this, hopefully this is now cleaner PR, I have 
> closed the original PR #75
> Jem



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1224) Proton-J SSL uses deprecated Bouncy Castle functionality

2016-08-22 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/PROTON-1224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15431632#comment-15431632
 ] 

ASF GitHub Bot commented on PROTON-1224:


Github user JemDay closed the pull request at:

https://github.com/apache/qpid-proton/pull/75


> Proton-J SSL uses deprecated Bouncy Castle functionality
> 
>
> Key: PROTON-1224
> URL: https://issues.apache.org/jira/browse/PROTON-1224
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: proton-j
>Affects Versions: 0.12.2
>Reporter: Jem Day
>
> The BouncyCastle project deprecated functionality used by the proton-j driver 
> in version 1.48. This causes run-time issues for us as our application 
> containers are using newer BC versions.
> Thanks for you patience with this, hopefully this is now cleaner PR, I have 
> closed the original PR #75
> Jem



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1224) Proton-J SSL uses deprecated Bouncy Castle functionality

2016-08-22 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/PROTON-1224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15431631#comment-15431631
 ] 

ASF GitHub Bot commented on PROTON-1224:


Github user JemDay commented on the issue:

https://github.com/apache/qpid-proton/pull/75
  
Closing for re-creation


> Proton-J SSL uses deprecated Bouncy Castle functionality
> 
>
> Key: PROTON-1224
> URL: https://issues.apache.org/jira/browse/PROTON-1224
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: proton-j
>Affects Versions: 0.12.2
>Reporter: Jem Day
>
> The BouncyCastle project deprecated functionality used by the proton-j driver 
> in version 1.48. This causes run-time issues for us as our application 
> containers are using newer BC versions.
> Thanks for you patience with this, hopefully this is now cleaner PR, I have 
> closed the original PR #75
> Jem



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1224) Proton-J SSL uses deprecated Bouncy Castle functionality

2016-08-22 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/PROTON-1224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15431570#comment-15431570
 ] 

ASF GitHub Bot commented on PROTON-1224:


Github user JemDay commented on the issue:

https://github.com/apache/qpid-proton/pull/75
  
I would like to close this PR and open a new one with (hopefully) a much 
cleaner change delta ...


> Proton-J SSL uses deprecated Bouncy Castle functionality
> 
>
> Key: PROTON-1224
> URL: https://issues.apache.org/jira/browse/PROTON-1224
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: proton-j
>Affects Versions: 0.12.2
>Reporter: Jem Day
>
> The BouncyCastle project deprecated functionality used by the proton-j driver 
> in version 1.48. This causes run-time issues for us as our application 
> containers are using newer BC versions.
> I've submitted a PR for this change and verified that all tests run using 
> both BC 1.48 and 1.54.
> Note: The CI pipeline for the PR is flagging an error but i am able to 
> build/test locally with no reported errors - build log is attached to the PR 
> comments.
> https://github.com/apache/qpid-proton/pull/74



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1224) Proton-J SSL uses deprecated Bouncy Castle functionality

2016-06-24 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/PROTON-1224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348316#comment-15348316
 ] 

ASF GitHub Bot commented on PROTON-1224:


Github user gemmellr commented on the issue:

https://github.com/apache/qpid-proton/pull/75
  
you just need to ensure you have the upstream repo up to date, then rebase 
your fork against it, then [force] push to your fork, which should result in 
your commit(s) sitting at the head of the branch with the current upstream 
commits preceding them and no unnecessary merge commits. You can repeat that 
process as many times as you like.

You obviously want to avoid force pushes on branches you are using to 
directly collaborate with other people on, but typically you commit work on a 
specific branch for the PR and then since noone else is likely to be depending 
on it doing such a force push is of little consequence to anyone.


> Proton-J SSL uses deprecated Bouncy Castle functionality
> 
>
> Key: PROTON-1224
> URL: https://issues.apache.org/jira/browse/PROTON-1224
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: proton-j
>Affects Versions: 0.12.2
>Reporter: Jem Day
>
> The BouncyCastle project deprecated functionality used by the proton-j driver 
> in version 1.48. This causes run-time issues for us as our application 
> containers are using newer BC versions.
> I've submitted a PR for this change and verified that all tests run using 
> both BC 1.48 and 1.54.
> Note: The CI pipeline for the PR is flagging an error but i am able to 
> build/test locally with no reported errors - build log is attached to the PR 
> comments.
> https://github.com/apache/qpid-proton/pull/74



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1224) Proton-J SSL uses deprecated Bouncy Castle functionality

2016-06-17 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/PROTON-1224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15336943#comment-15336943
 ] 

ASF GitHub Bot commented on PROTON-1224:


Github user JemDay commented on the issue:

https://github.com/apache/qpid-proton/pull/75
  
i think this is royally screwed up now, the file-change list looks clean 
but using a rebase rather than a pull (to remove the merge commits) now appears 
to be having an even worse affect.

I'm open to suggestions - i can close this PR, trash my fork, and then 
re-create the change if that's going to be a simpler path forward but before 
that i would like to better understand the fork/pull/commit/push/PR cycle when 
there may be multiple commits to the fork before the PR is actually raised. 
Squashing after commits have been pushed seems to just open world of hurt



> Proton-J SSL uses deprecated Bouncy Castle functionality
> 
>
> Key: PROTON-1224
> URL: https://issues.apache.org/jira/browse/PROTON-1224
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: proton-j
>Affects Versions: 0.12.2
>Reporter: Jem Day
>
> The BouncyCastle project deprecated functionality used by the proton-j driver 
> in version 1.48. This causes run-time issues for us as our application 
> containers are using newer BC versions.
> I've submitted a PR for this change and verified that all tests run using 
> both BC 1.48 and 1.54.
> Note: The CI pipeline for the PR is flagging an error but i am able to 
> build/test locally with no reported errors - build log is attached to the PR 
> comments.
> https://github.com/apache/qpid-proton/pull/74



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1224) Proton-J SSL uses deprecated Bouncy Castle functionality

2016-06-17 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/PROTON-1224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15336739#comment-15336739
 ] 

ASF GitHub Bot commented on PROTON-1224:


Github user JemDay commented on the issue:

https://github.com/apache/qpid-proton/pull/75
  
OK ... my lack of high-wire skills with GITis really showing through now 
... i'm completely stumped as to how to 'not' include other commits when 
pushing back to my fork ..



> Proton-J SSL uses deprecated Bouncy Castle functionality
> 
>
> Key: PROTON-1224
> URL: https://issues.apache.org/jira/browse/PROTON-1224
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: proton-j
>Affects Versions: 0.12.2
>Reporter: Jem Day
>
> The BouncyCastle project deprecated functionality used by the proton-j driver 
> in version 1.48. This causes run-time issues for us as our application 
> containers are using newer BC versions.
> I've submitted a PR for this change and verified that all tests run using 
> both BC 1.48 and 1.54.
> Note: The CI pipeline for the PR is flagging an error but i am able to 
> build/test locally with no reported errors - build log is attached to the PR 
> comments.
> https://github.com/apache/qpid-proton/pull/74



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1224) Proton-J SSL uses deprecated Bouncy Castle functionality

2016-06-16 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/PROTON-1224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15334067#comment-15334067
 ] 

ASF GitHub Bot commented on PROTON-1224:


Github user JemDay commented on the issue:

https://github.com/apache/qpid-proton/pull/75
  
Robbie - thanks for reviewing and sorry for the slow response, i'll look to 
try and resolve these today.

As previously discussed i'm not an enormous fan of this reflective approach 
but the cmake build process for java floored me a bit w.r.t how to achieve the 
maven style dependency at compile time.


> Proton-J SSL uses deprecated Bouncy Castle functionality
> 
>
> Key: PROTON-1224
> URL: https://issues.apache.org/jira/browse/PROTON-1224
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: proton-j
>Affects Versions: 0.12.2
>Reporter: Jem Day
>
> The BouncyCastle project deprecated functionality used by the proton-j driver 
> in version 1.48. This causes run-time issues for us as our application 
> containers are using newer BC versions.
> I've submitted a PR for this change and verified that all tests run using 
> both BC 1.48 and 1.54.
> Note: The CI pipeline for the PR is flagging an error but i am able to 
> build/test locally with no reported errors - build log is attached to the PR 
> comments.
> https://github.com/apache/qpid-proton/pull/74



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1224) Proton-J SSL uses deprecated Bouncy Castle functionality

2016-06-16 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/PROTON-1224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15334054#comment-15334054
 ] 

ASF GitHub Bot commented on PROTON-1224:


Github user JemDay commented on a diff in the pull request:

https://github.com/apache/qpid-proton/pull/75#discussion_r67372467
  
--- Diff: 
proton-j/src/test/resources/org/apache/qpid/proton/engine/impl/ssl/cert.pem.txt 
---
@@ -0,0 +1,27 @@
+-BEGIN CERTIFICATE-
--- End diff --

will do


> Proton-J SSL uses deprecated Bouncy Castle functionality
> 
>
> Key: PROTON-1224
> URL: https://issues.apache.org/jira/browse/PROTON-1224
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: proton-j
>Affects Versions: 0.12.2
>Reporter: Jem Day
>
> The BouncyCastle project deprecated functionality used by the proton-j driver 
> in version 1.48. This causes run-time issues for us as our application 
> containers are using newer BC versions.
> I've submitted a PR for this change and verified that all tests run using 
> both BC 1.48 and 1.54.
> Note: The CI pipeline for the PR is flagging an error but i am able to 
> build/test locally with no reported errors - build log is attached to the PR 
> comments.
> https://github.com/apache/qpid-proton/pull/74



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1224) Proton-J SSL uses deprecated Bouncy Castle functionality

2016-06-16 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/PROTON-1224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15334053#comment-15334053
 ] 

ASF GitHub Bot commented on PROTON-1224:


Github user JemDay commented on a diff in the pull request:

https://github.com/apache/qpid-proton/pull/75#discussion_r67372424
  
--- Diff: tests/pom.xml ---
@@ -99,7 +99,7 @@ mvn test \
 
   org.bouncycastle
   bcpkix-jdk15on
-  1.47
+  1.48
--- End diff --

will do..


> Proton-J SSL uses deprecated Bouncy Castle functionality
> 
>
> Key: PROTON-1224
> URL: https://issues.apache.org/jira/browse/PROTON-1224
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: proton-j
>Affects Versions: 0.12.2
>Reporter: Jem Day
>
> The BouncyCastle project deprecated functionality used by the proton-j driver 
> in version 1.48. This causes run-time issues for us as our application 
> containers are using newer BC versions.
> I've submitted a PR for this change and verified that all tests run using 
> both BC 1.48 and 1.54.
> Note: The CI pipeline for the PR is flagging an error but i am able to 
> build/test locally with no reported errors - build log is attached to the PR 
> comments.
> https://github.com/apache/qpid-proton/pull/74



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1224) Proton-J SSL uses deprecated Bouncy Castle functionality

2016-06-14 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/PROTON-1224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15330050#comment-15330050
 ] 

ASF GitHub Bot commented on PROTON-1224:


Github user gemmellr commented on the issue:

https://github.com/apache/qpid-proton/pull/75
  
I still need to have a final look, but if you could address the couple 
niggles I commented on that would be good. As I mentioned before, if you could 
also please remove merge commits from PRs that would be good, you have added a 
second in this version. Feel free to rebase the PR and squash all the commits, 
you don't need to open a new PR.


> Proton-J SSL uses deprecated Bouncy Castle functionality
> 
>
> Key: PROTON-1224
> URL: https://issues.apache.org/jira/browse/PROTON-1224
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: proton-j
>Affects Versions: 0.12.2
>Reporter: Jem Day
>
> The BouncyCastle project deprecated functionality used by the proton-j driver 
> in version 1.48. This causes run-time issues for us as our application 
> containers are using newer BC versions.
> I've submitted a PR for this change and verified that all tests run using 
> both BC 1.48 and 1.54.
> Note: The CI pipeline for the PR is flagging an error but i am able to 
> build/test locally with no reported errors - build log is attached to the PR 
> comments.
> https://github.com/apache/qpid-proton/pull/74



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1224) Proton-J SSL uses deprecated Bouncy Castle functionality

2016-06-14 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/PROTON-1224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15330041#comment-15330041
 ] 

ASF GitHub Bot commented on PROTON-1224:


Github user gemmellr commented on a diff in the pull request:

https://github.com/apache/qpid-proton/pull/75#discussion_r67023365
  
--- Diff: 
proton-j/src/test/resources/org/apache/qpid/proton/engine/impl/ssl/cert.pem.txt 
---
@@ -0,0 +1,27 @@
+-BEGIN CERTIFICATE-
--- End diff --

Please provide instructions on exactly how to (re)create the SSL resources 
used for the tests, so they can be easily updated later as needed.

E.g like the existing proton SSL test resource details: 
https://github.com/apache/qpid-proton/blob/master/tests/python/proton_tests/ssl_db/README.txt
Or the qpid-jms SSL test resource details (which can be sourced and execute 
directly): 
https://github.com/apache/qpid-jms/blob/master/qpid-jms-client/src/test/resources/README.txt


> Proton-J SSL uses deprecated Bouncy Castle functionality
> 
>
> Key: PROTON-1224
> URL: https://issues.apache.org/jira/browse/PROTON-1224
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: proton-j
>Affects Versions: 0.12.2
>Reporter: Jem Day
>
> The BouncyCastle project deprecated functionality used by the proton-j driver 
> in version 1.48. This causes run-time issues for us as our application 
> containers are using newer BC versions.
> I've submitted a PR for this change and verified that all tests run using 
> both BC 1.48 and 1.54.
> Note: The CI pipeline for the PR is flagging an error but i am able to 
> build/test locally with no reported errors - build log is attached to the PR 
> comments.
> https://github.com/apache/qpid-proton/pull/74



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1224) Proton-J SSL uses deprecated Bouncy Castle functionality

2016-06-14 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/PROTON-1224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15330037#comment-15330037
 ] 

ASF GitHub Bot commented on PROTON-1224:


Github user gemmellr commented on a diff in the pull request:

https://github.com/apache/qpid-proton/pull/75#discussion_r67023070
  
--- Diff: tests/pom.xml ---
@@ -99,7 +99,7 @@ mvn test \
 
   org.bouncycastle
   bcpkix-jdk15on
-  1.47
+  1.48
--- End diff --

Given the idea is to update it probably makes sense to go for the latest 
version rather than this 3+ year old version (same goes for the other instance).


> Proton-J SSL uses deprecated Bouncy Castle functionality
> 
>
> Key: PROTON-1224
> URL: https://issues.apache.org/jira/browse/PROTON-1224
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: proton-j
>Affects Versions: 0.12.2
>Reporter: Jem Day
>
> The BouncyCastle project deprecated functionality used by the proton-j driver 
> in version 1.48. This causes run-time issues for us as our application 
> containers are using newer BC versions.
> I've submitted a PR for this change and verified that all tests run using 
> both BC 1.48 and 1.54.
> Note: The CI pipeline for the PR is flagging an error but i am able to 
> build/test locally with no reported errors - build log is attached to the PR 
> comments.
> https://github.com/apache/qpid-proton/pull/74



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1224) Proton-J SSL uses deprecated Bouncy Castle functionality

2016-06-13 Thread Jem Day (JIRA) 

[ 
https://issues.apache.org/jira/browse/PROTON-1224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15328068#comment-15328068
 ] 

Jem Day commented on PROTON-1224:
-

Robbie,

  I close out the original PR and created a new one, the CI jobs appear now to 
be failing during the Python tests. I am able to run the cmake build locally.

Jem..

> Proton-J SSL uses deprecated Bouncy Castle functionality
> 
>
> Key: PROTON-1224
> URL: https://issues.apache.org/jira/browse/PROTON-1224
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: proton-j
>Affects Versions: 0.12.2
>Reporter: Jem Day
>
> The BouncyCastle project deprecated functionality used by the proton-j driver 
> in version 1.48. This causes run-time issues for us as our application 
> containers are using newer BC versions.
> I've submitted a PR for this change and verified that all tests run using 
> both BC 1.48 and 1.54.
> Note: The CI pipeline for the PR is flagging an error but i am able to 
> build/test locally with no reported errors - build log is attached to the PR 
> comments.
> https://github.com/apache/qpid-proton/pull/74



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1224) Proton-J SSL uses deprecated Bouncy Castle functionality

2016-06-10 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/PROTON-1224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15324921#comment-15324921
 ] 

ASF GitHub Bot commented on PROTON-1224:


GitHub user JemDay opened a pull request:

https://github.com/apache/qpid-proton/pull/75

PROTON-1224: Upgrade BouncyCastle

Support 1.48+ of BouncyCastle
Added unit-test and associated certificate and key test resources.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/JemDay/qpid-proton master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-proton/pull/75.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #75


commit d97854bc37f6b71f0ba6944c39e59826c6651d12
Author: Jem Day 
Date:   2016-06-10T17:13:36Z

PROTON-1224: Upgrade BouncyCastle to 1.48+

commit f9efcf058cd056ac61ed174b6b31555454740610
Author: Jem Day 
Date:   2016-06-10T17:13:36Z

PROTON-1224: Upgrade BouncyCastle to 1.48+

commit daa2959004e2d090a5e5afcedd4dfc7e3e9a49a7
Author: Jem Day 
Date:   2016-06-10T17:30:38Z

Merge branch 'master' of https://github.com/JemDay/qpid-proton

commit 7aff6361d6942ea069727f118750bb27117aa8cf
Author: Jem Day 
Date:   2016-06-10T17:34:27Z

Merge branch 'master' of https://github.com/apache/qpid-proton




> Proton-J SSL uses deprecated Bouncy Castle functionality
> 
>
> Key: PROTON-1224
> URL: https://issues.apache.org/jira/browse/PROTON-1224
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: proton-j
>Affects Versions: 0.12.2
>Reporter: Jem Day
>
> The BouncyCastle project deprecated functionality used by the proton-j driver 
> in version 1.48. This causes run-time issues for us as our application 
> containers are using newer BC versions.
> I've submitted a PR for this change and verified that all tests run using 
> both BC 1.48 and 1.54.
> Note: The CI pipeline for the PR is flagging an error but i am able to 
> build/test locally with no reported errors - build log is attached to the PR 
> comments.
> https://github.com/apache/qpid-proton/pull/74



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1224) Proton-J SSL uses deprecated Bouncy Castle functionality

2016-06-06 Thread Robbie Gemmell (JIRA) 

[ 
https://issues.apache.org/jira/browse/PROTON-1224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15316741#comment-15316741
 ] 

Robbie Gemmell commented on PROTON-1224:


Copying comment from the PR since JIRA was actually down earlier when I 
commented on the PR.

{noformat}
The CI builds are failing while running the cmake build (using it is outlined 
in DEVELOPERS.md) rather than the maven build. The cmake
build creates a proton-j jar by itself for use in certain tests, a process 
which these changes break through introduction of a compile time
dependency on bouncycastle that it doesn't accommodate because it didn't 
previously need to. Either the update needs to be made
fully-reflective as before, or the cmake build updated to accommodate the new 
compilation dependency.

Some more general comments:
-  The main module and tests are specifying difference versions of bouncycastle 
to use.
-   If you include the JIRA title in the PR title, it will be updated by a bot 
upon PR open/comments/close.
-   Please reference the JIRA in commit msg, i.e "PROTON-XYZ: msg".
-   Please remove merge commits from PRs.

(Mentioning PROTON-1224 so it also gets updated)
{noformat}

> Proton-J SSL uses deprecated Bouncy Castle functionality
> 
>
> Key: PROTON-1224
> URL: https://issues.apache.org/jira/browse/PROTON-1224
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: proton-j
>Affects Versions: 0.12.2
>Reporter: Jem Day
>
> The BouncyCastle project deprecated functionality used by the proton-j driver 
> in version 1.48. This causes run-time issues for us as our application 
> containers are using newer BC versions.
> I've submitted a PR for this change and verified that all tests run using 
> both BC 1.48 and 1.54.
> Note: The CI pipeline for the PR is flagging an error but i am able to 
> build/test locally with no reported errors - build log is attached to the PR 
> comments.
> https://github.com/apache/qpid-proton/pull/74



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org