[jira] Commented: (QPID-2693) Broker instability with the topic exchange
[ https://issues.apache.org/jira/browse/QPID-2693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13004462#comment-13004462 ] Robbie Gemmell commented on QPID-2693: -- Hi Emmanuel. I took yet another shot at this, as whilst QPID-3010 was definitely causing one of the issues you noted above there was obviously another. Can you run your test again after adding this to your message(Session session, MessageTransfer xfr) listener method: session.processed(xfr); Broker instability with the topic exchange -- Key: QPID-2693 URL: https://issues.apache.org/jira/browse/QPID-2693 Project: Qpid Issue Type: Bug Components: Java Broker Affects Versions: 0.7, 0.8 Environment: java version 1.6.0_12 Java(TM) SE Runtime Environment (build 1.6.0_12-b04) Java HotSpot(TM) 64-Bit Server VM (build 11.2-b01, mixed mode) Linux 2.6.24-11-pve #1 SMP PREEMPT Fri May 14 09:28:08 CEST 2010 x86_64 GNU/Linux Reporter: Emmanuel Bourg Assignee: Robbie Gemmell Priority: Critical Fix For: 0.9 Attachments: qpid-dump.txt, qpid-log.txt I've noticed an instability of the Java broker when sending a high volume of messages to the topic exchange. The messages are non acked, non durable. After about 15 minutes the messages can no longer be dispatched and the client gets this exception: org.apache.qpid.transport.SessionException: timed out waiting for sync: complete = 77824, point = 77825 at org.apache.qpid.transport.Session.sync(Session.java:743) at org.apache.qpid.transport.Session.sync(Session.java:712) at org.apache.qpid.transport.Session.invoke(Session.java:672) at org.apache.qpid.transport.Session.invoke(Session.java:518) at org.apache.qpid.transport.SessionInvoker.messageTransfer(SessionInvoker.java:96) at org.apache.qpid.transport.Session.messageTransfer(Session.java:880) And in the server log I get these exceptions: 2010-06-25 02:48:48,005 [ERROR] Exception thrown and no ProtocolEngine to handle it org.apache.qpid.transport.SessionException: timed out waiting for completion at org.apache.qpid.transport.Session.invoke(Session.java:635) at org.apache.qpid.server.transport.ServerSession.sendMessage(ServerSession.java:180) at org.apache.qpid.server.subscription.Subscription_0_10.send(Subscription_0_10.java:573) at org.apache.qpid.server.queue.SimpleAMQQueue.deliverMessage(SimpleAMQQueue.java:715) at org.apache.qpid.server.queue.SimpleAMQQueue.deliverToSubscription(SimpleAMQQueue.java:658) at org.apache.qpid.server.queue.SimpleAMQQueue.enqueue(SimpleAMQQueue.java:611) at org.apache.qpid.server.queue.SimpleAMQQueue.enqueue(SimpleAMQQueue.java:536) at org.apache.qpid.server.transport.ServerSession$1.postCommit(ServerSession.java:157) at org.apache.qpid.server.txn.AutoCommitTransaction.enqueue(AutoCommitTransaction.java:151) at org.apache.qpid.server.transport.ServerSession.enqueue(ServerSession.java:146) at org.apache.qpid.server.transport.ServerSessionDelegate.messageTransfer(ServerSessionDelegate.java:287) at org.apache.qpid.server.transport.ServerSessionDelegate.messageTransfer(ServerSessionDelegate.java:96) at org.apache.qpid.transport.MessageTransfer.dispatch(MessageTransfer.java:103) at org.apache.qpid.transport.SessionDelegate.command(SessionDelegate.java:46) at org.apache.qpid.server.transport.ServerSessionDelegate.command(ServerSessionDelegate.java:110) at org.apache.qpid.server.transport.ServerSessionDelegate.command(ServerSessionDelegate.java:96) at org.apache.qpid.transport.Method.delegate(Method.java:159) at org.apache.qpid.transport.Session.received(Session.java:487) at org.apache.qpid.transport.Connection.dispatch(Connection.java:377) at org.apache.qpid.transport.ConnectionDelegate.handle(ConnectionDelegate.java:64) at org.apache.qpid.transport.ConnectionDelegate.handle(ConnectionDelegate.java:40) at org.apache.qpid.transport.MethodDelegate.messageTransfer(MethodDelegate.java:113) at org.apache.qpid.transport.MessageTransfer.dispatch(MessageTransfer.java:103) at org.apache.qpid.transport.ConnectionDelegate.command(ConnectionDelegate.java:54) at org.apache.qpid.transport.ConnectionDelegate.command(ConnectionDelegate.java:40) at org.apache.qpid.transport.Method.delegate(Method.java:159) at org.apache.qpid.transport.Connection.received(Connection.java:342) at org.apache.qpid.transport.Connection.received(Connection.java:55) at org.apache.qpid.transport.network.Assembler.emit(Assembler.java:98)
Code snippets in JIRA
Hi, I noticed that the code formatting is not enabled in JIRA (the {code:java} blocks for example). This seems to be specific to QPID since other Apache projects have it. I'm don't know how this is configured in JIRA but maybe someone with an admin role on the project could get a look at the settings and try to enable it ? Emmanuel Bourg smime.p7s Description: S/MIME Cryptographic Signature
Re: Code snippets in JIRA
I had a look and there doesn't appear to be any way for us to configure this ourselves, it must be something that infra would need to update. Do you have an example issue I could use to show the difference when raising a JIRA with infra to have it changed? Robbie On 9 March 2011 11:03, Emmanuel Bourg ebo...@apache.org wrote: Hi, I noticed that the code formatting is not enabled in JIRA (the {code:java} blocks for example). This seems to be specific to QPID since other Apache projects have it. I'm don't know how this is configured in JIRA but maybe someone with an admin role on the project could get a look at the settings and try to enable it ? Emmanuel Bourg
[jira] Created: (QPID-3132) Threshold alert on a queue used to receive alerts causes broker crash
Threshold alert on a queue used to receive alerts causes broker crash - Key: QPID-3132 URL: https://issues.apache.org/jira/browse/QPID-3132 Project: Qpid Issue Type: Bug Affects Versions: 0.10 Reporter: Gordon Sim Assignee: Gordon Sim Priority: Blocker Fix For: 0.10 If a queue bound to the QMF exchange for receiving events reaches a configured threhold and generates an alert, the alert will result in an infinite recursion where the message for the event is enqueued triggering a further event etc etc -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
Re: Code snippets in JIRA
Le 09/03/2011 12:17, Robbie Gemmell a écrit : I had a look and there doesn't appear to be any way for us to configure this ourselves, it must be something that infra would need to update. Do you have an example issue I could use to show the difference when raising a JIRA with infra to have it changed? Thank you Robbie, The comments in QPID-2693 have several code blocks that are formatted as plain text. Emmanuel Bourg smime.p7s Description: S/MIME Cryptographic Signature
Re: Code snippets in JIRA
Yes I noticed, I meant an example with it turned on hehe :) Robbie On 9 March 2011 11:32, Emmanuel Bourg ebo...@apache.org wrote: Le 09/03/2011 12:17, Robbie Gemmell a écrit : I had a look and there doesn't appear to be any way for us to configure this ourselves, it must be something that infra would need to update. Do you have an example issue I could use to show the difference when raising a JIRA with infra to have it changed? Thank you Robbie, The comments in QPID-2693 have several code blocks that are formatted as plain text. Emmanuel Bourg
[jira] Commented: (QPID-2693) Broker instability with the topic exchange
[ https://issues.apache.org/jira/browse/QPID-2693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13004483#comment-13004483 ] Emmanuel Bourg commented on QPID-2693: -- This is slightly more difficult to test since it implies updating all the consumers deployed and I can't do this quickly. Would that mean the Java broker expects the messages to be acked despite the fact the message transfer was configured to not use acknowledgment? Broker instability with the topic exchange -- Key: QPID-2693 URL: https://issues.apache.org/jira/browse/QPID-2693 Project: Qpid Issue Type: Bug Components: Java Broker Affects Versions: 0.7, 0.8 Environment: java version 1.6.0_12 Java(TM) SE Runtime Environment (build 1.6.0_12-b04) Java HotSpot(TM) 64-Bit Server VM (build 11.2-b01, mixed mode) Linux 2.6.24-11-pve #1 SMP PREEMPT Fri May 14 09:28:08 CEST 2010 x86_64 GNU/Linux Reporter: Emmanuel Bourg Assignee: Robbie Gemmell Priority: Critical Fix For: 0.9 Attachments: qpid-dump.txt, qpid-log.txt I've noticed an instability of the Java broker when sending a high volume of messages to the topic exchange. The messages are non acked, non durable. After about 15 minutes the messages can no longer be dispatched and the client gets this exception: org.apache.qpid.transport.SessionException: timed out waiting for sync: complete = 77824, point = 77825 at org.apache.qpid.transport.Session.sync(Session.java:743) at org.apache.qpid.transport.Session.sync(Session.java:712) at org.apache.qpid.transport.Session.invoke(Session.java:672) at org.apache.qpid.transport.Session.invoke(Session.java:518) at org.apache.qpid.transport.SessionInvoker.messageTransfer(SessionInvoker.java:96) at org.apache.qpid.transport.Session.messageTransfer(Session.java:880) And in the server log I get these exceptions: 2010-06-25 02:48:48,005 [ERROR] Exception thrown and no ProtocolEngine to handle it org.apache.qpid.transport.SessionException: timed out waiting for completion at org.apache.qpid.transport.Session.invoke(Session.java:635) at org.apache.qpid.server.transport.ServerSession.sendMessage(ServerSession.java:180) at org.apache.qpid.server.subscription.Subscription_0_10.send(Subscription_0_10.java:573) at org.apache.qpid.server.queue.SimpleAMQQueue.deliverMessage(SimpleAMQQueue.java:715) at org.apache.qpid.server.queue.SimpleAMQQueue.deliverToSubscription(SimpleAMQQueue.java:658) at org.apache.qpid.server.queue.SimpleAMQQueue.enqueue(SimpleAMQQueue.java:611) at org.apache.qpid.server.queue.SimpleAMQQueue.enqueue(SimpleAMQQueue.java:536) at org.apache.qpid.server.transport.ServerSession$1.postCommit(ServerSession.java:157) at org.apache.qpid.server.txn.AutoCommitTransaction.enqueue(AutoCommitTransaction.java:151) at org.apache.qpid.server.transport.ServerSession.enqueue(ServerSession.java:146) at org.apache.qpid.server.transport.ServerSessionDelegate.messageTransfer(ServerSessionDelegate.java:287) at org.apache.qpid.server.transport.ServerSessionDelegate.messageTransfer(ServerSessionDelegate.java:96) at org.apache.qpid.transport.MessageTransfer.dispatch(MessageTransfer.java:103) at org.apache.qpid.transport.SessionDelegate.command(SessionDelegate.java:46) at org.apache.qpid.server.transport.ServerSessionDelegate.command(ServerSessionDelegate.java:110) at org.apache.qpid.server.transport.ServerSessionDelegate.command(ServerSessionDelegate.java:96) at org.apache.qpid.transport.Method.delegate(Method.java:159) at org.apache.qpid.transport.Session.received(Session.java:487) at org.apache.qpid.transport.Connection.dispatch(Connection.java:377) at org.apache.qpid.transport.ConnectionDelegate.handle(ConnectionDelegate.java:64) at org.apache.qpid.transport.ConnectionDelegate.handle(ConnectionDelegate.java:40) at org.apache.qpid.transport.MethodDelegate.messageTransfer(MethodDelegate.java:113) at org.apache.qpid.transport.MessageTransfer.dispatch(MessageTransfer.java:103) at org.apache.qpid.transport.ConnectionDelegate.command(ConnectionDelegate.java:54) at org.apache.qpid.transport.ConnectionDelegate.command(ConnectionDelegate.java:40) at org.apache.qpid.transport.Method.delegate(Method.java:159) at org.apache.qpid.transport.Connection.received(Connection.java:342) at org.apache.qpid.transport.Connection.received(Connection.java:55) at org.apache.qpid.transport.network.Assembler.emit(Assembler.java:98) at
[jira] Commented: (QPID-2693) Broker instability with the topic exchange
[ https://issues.apache.org/jira/browse/QPID-2693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13004504#comment-13004504 ] Robbie Gemmell commented on QPID-2693: -- No. The messages are not being acknowledged (or Accepted, rather) by performing that call, the AMQP 0-10 commands used to transfer them are being marked as processed so that the protocol level command window can be updated. This is something that normally occurs further up the tree at the Consumer level in the JMS layer, however in not using the supported API you are intercepting the MessageTransfer commands as they arrive on the transport Session at a point where they are then never marked processed. This means the client just keeps periodically indicating to the broker that it hasn't processed anything, which will eventually be met with attempts to synchronize the completed commands failing in the manner observed. Broker instability with the topic exchange -- Key: QPID-2693 URL: https://issues.apache.org/jira/browse/QPID-2693 Project: Qpid Issue Type: Bug Components: Java Broker Affects Versions: 0.7, 0.8 Environment: java version 1.6.0_12 Java(TM) SE Runtime Environment (build 1.6.0_12-b04) Java HotSpot(TM) 64-Bit Server VM (build 11.2-b01, mixed mode) Linux 2.6.24-11-pve #1 SMP PREEMPT Fri May 14 09:28:08 CEST 2010 x86_64 GNU/Linux Reporter: Emmanuel Bourg Assignee: Robbie Gemmell Priority: Critical Fix For: 0.9 Attachments: qpid-dump.txt, qpid-log.txt I've noticed an instability of the Java broker when sending a high volume of messages to the topic exchange. The messages are non acked, non durable. After about 15 minutes the messages can no longer be dispatched and the client gets this exception: org.apache.qpid.transport.SessionException: timed out waiting for sync: complete = 77824, point = 77825 at org.apache.qpid.transport.Session.sync(Session.java:743) at org.apache.qpid.transport.Session.sync(Session.java:712) at org.apache.qpid.transport.Session.invoke(Session.java:672) at org.apache.qpid.transport.Session.invoke(Session.java:518) at org.apache.qpid.transport.SessionInvoker.messageTransfer(SessionInvoker.java:96) at org.apache.qpid.transport.Session.messageTransfer(Session.java:880) And in the server log I get these exceptions: 2010-06-25 02:48:48,005 [ERROR] Exception thrown and no ProtocolEngine to handle it org.apache.qpid.transport.SessionException: timed out waiting for completion at org.apache.qpid.transport.Session.invoke(Session.java:635) at org.apache.qpid.server.transport.ServerSession.sendMessage(ServerSession.java:180) at org.apache.qpid.server.subscription.Subscription_0_10.send(Subscription_0_10.java:573) at org.apache.qpid.server.queue.SimpleAMQQueue.deliverMessage(SimpleAMQQueue.java:715) at org.apache.qpid.server.queue.SimpleAMQQueue.deliverToSubscription(SimpleAMQQueue.java:658) at org.apache.qpid.server.queue.SimpleAMQQueue.enqueue(SimpleAMQQueue.java:611) at org.apache.qpid.server.queue.SimpleAMQQueue.enqueue(SimpleAMQQueue.java:536) at org.apache.qpid.server.transport.ServerSession$1.postCommit(ServerSession.java:157) at org.apache.qpid.server.txn.AutoCommitTransaction.enqueue(AutoCommitTransaction.java:151) at org.apache.qpid.server.transport.ServerSession.enqueue(ServerSession.java:146) at org.apache.qpid.server.transport.ServerSessionDelegate.messageTransfer(ServerSessionDelegate.java:287) at org.apache.qpid.server.transport.ServerSessionDelegate.messageTransfer(ServerSessionDelegate.java:96) at org.apache.qpid.transport.MessageTransfer.dispatch(MessageTransfer.java:103) at org.apache.qpid.transport.SessionDelegate.command(SessionDelegate.java:46) at org.apache.qpid.server.transport.ServerSessionDelegate.command(ServerSessionDelegate.java:110) at org.apache.qpid.server.transport.ServerSessionDelegate.command(ServerSessionDelegate.java:96) at org.apache.qpid.transport.Method.delegate(Method.java:159) at org.apache.qpid.transport.Session.received(Session.java:487) at org.apache.qpid.transport.Connection.dispatch(Connection.java:377) at org.apache.qpid.transport.ConnectionDelegate.handle(ConnectionDelegate.java:64) at org.apache.qpid.transport.ConnectionDelegate.handle(ConnectionDelegate.java:40) at org.apache.qpid.transport.MethodDelegate.messageTransfer(MethodDelegate.java:113) at org.apache.qpid.transport.MessageTransfer.dispatch(MessageTransfer.java:103) at
[jira] Commented: (QPID-3128) Update CPP broker documentation with producer flow control user api.
[ https://issues.apache.org/jira/browse/QPID-3128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13004554#comment-13004554 ] Ken Giusti commented on QPID-3128: -- Review board request: https://reviews.apache.org/r/480/ Update CPP broker documentation with producer flow control user api. Key: QPID-3128 URL: https://issues.apache.org/jira/browse/QPID-3128 Project: Qpid Issue Type: Improvement Components: C++ Broker, Documentation Affects Versions: 0.9 Reporter: Ken Giusti Assignee: Ken Giusti Priority: Minor Fix For: 0.9 Need to add the new producer flow control feature to the user documentation. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
Request for QPID-3073 to be included in 0.10
https://issues.apache.org/jira/browse/QPID-3073 Already on trunk. -K - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Commented: (QPID-3128) Update CPP broker documentation with producer flow control user api.
[ https://issues.apache.org/jira/browse/QPID-3128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13004577#comment-13004577 ] Justin Ross commented on QPID-3128: --- Approved for 0.10. Reviewed by Gordon. Update CPP broker documentation with producer flow control user api. Key: QPID-3128 URL: https://issues.apache.org/jira/browse/QPID-3128 Project: Qpid Issue Type: Improvement Components: C++ Broker, Documentation Affects Versions: 0.9 Reporter: Ken Giusti Assignee: Ken Giusti Priority: Minor Fix For: 0.9 Need to add the new producer flow control feature to the user documentation. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
QPID-3132: blocker for 0.10
I'm afraid my addition of the queue threshold events has a potentially serious issue needing fixing for 0.10. The events are sent out as normal messages through management exchanges - if the queues used to subscribe for these also reach their limits then there is an infinite recursion causing a broker crash. I have checked in a test and fix preventing this to trunk and would like to merge that onto the 0.10 branch also. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
QPID-3121: release branch broken on windows
The changes committed to the release branch for QPID-3121 (Cluster management inconsistency when using persistent store) broke the windows build. I committed the trivial fix to the trunk for this already, which only affects linking and has no logic changes in it at all and iths adds no risk to the already approved changes (http://svn.apache.org/viewvc?view=revisionrevision=1079313). I believe the same change needs to be applied to the release branch (or else the changes that broke the built would need to be backed out). - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Resolved: (QPID-3073) Producer flow control need performance tuning.
[ https://issues.apache.org/jira/browse/QPID-3073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ken Giusti resolved QPID-3073. -- Resolution: Fixed Fix Version/s: (was: 0.9) 0.10 Producer flow control need performance tuning. -- Key: QPID-3073 URL: https://issues.apache.org/jira/browse/QPID-3073 Project: Qpid Issue Type: Improvement Components: C++ Broker Affects Versions: 0.9 Reporter: Ken Giusti Assignee: Ken Giusti Fix For: 0.10 Attachments: qpid-2935-performance-impact.ods It looks like the presence of flow control (QPID-2935) has no impact when it is disabled (to be expected) but with flow control on I see about a 10% loss in thruput even though there's no actual flow control happening in this scenario. Needs investigation. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
Re: QPID-3121: release branch broken on windows
r1079313 is the correct patch to fix the 0.10 build issue which I just proved in a local build. I approve. -Chuck - Original Message - From: Gordon Sim g...@redhat.com To: dev@qpid.apache.org Sent: Wednesday, March 9, 2011 10:55:53 AM Subject: QPID-3121: release branch broken on windows The changes committed to the release branch for QPID-3121 (Cluster management inconsistency when using persistent store) broke the windows build. I committed the trivial fix to the trunk for this already, which only affects linking and has no logic changes in it at all and iths adds no risk to the already approved changes (http://svn.apache.org/viewvc?view=revisionrevision=1079313). I believe the same change needs to be applied to the release branch (or else the changes that broke the built would need to be backed out). - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
RE: QPID-3121: release branch broken on windows
FWIW, I'd like this change to be merged to the release branch. -Steve -Original Message- From: Gordon Sim [mailto:g...@redhat.com] Sent: Wednesday, March 09, 2011 10:56 AM To: dev@qpid.apache.org Subject: QPID-3121: release branch broken on windows The changes committed to the release branch for QPID-3121 (Cluster management inconsistency when using persistent store) broke the windows build. I committed the trivial fix to the trunk for this already, which only affects linking and has no logic changes in it at all and iths adds no risk to the already approved changes (http://svn.apache.org/viewvc?view=revisionrevision=1079313). I believe the same change needs to be applied to the release branch (or else the changes that broke the built would need to be backed out). - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
Re: QPID-3121: release branch broken on windows
On 03/09/2011 04:28 PM, Chuck Rolke wrote: r1079313 is the correct patch to fix the 0.10 build issue which I just proved in a local build. I approve. Justin, ok with you? - Original Message - From: Gordon Simg...@redhat.com To: dev@qpid.apache.org Sent: Wednesday, March 9, 2011 10:55:53 AM Subject: QPID-3121: release branch broken on windows The changes committed to the release branch for QPID-3121 (Cluster management inconsistency when using persistent store) broke the windows build. I committed the trivial fix to the trunk for this already, which only affects linking and has no logic changes in it at all and iths adds no risk to the already approved changes (http://svn.apache.org/viewvc?view=revisionrevision=1079313). I believe the same change needs to be applied to the release branch (or else the changes that broke the built would need to be backed out). - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
Re: QPID-3121: release branch broken on windows
Yes, approved. On Wed, 9 Mar 2011, Gordon Sim wrote: On 03/09/2011 04:28 PM, Chuck Rolke wrote: r1079313 is the correct patch to fix the 0.10 build issue which I just proved in a local build. I approve. Justin, ok with you? - Original Message - From: Gordon Simg...@redhat.com To: dev@qpid.apache.org Sent: Wednesday, March 9, 2011 10:55:53 AM Subject: QPID-3121: release branch broken on windows The changes committed to the release branch for QPID-3121 (Cluster management inconsistency when using persistent store) broke the windows build. I committed the trivial fix to the trunk for this already, which only affects linking and has no logic changes in it at all and iths adds no risk to the already approved changes (http://svn.apache.org/viewvc?view=revisionrevision=1079313). I believe the same change needs to be applied to the release branch (or else the changes that broke the built would need to be backed out). - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Created: (QPID-3133) Failover tests do not pass on 0-10 profiles
Failover tests do not pass on 0-10 profiles --- Key: QPID-3133 URL: https://issues.apache.org/jira/browse/QPID-3133 Project: Qpid Issue Type: Bug Components: Java Broker, Java Client Affects Versions: 0.11 Reporter: Andrew Kennedy Assignee: Andrew Kennedy Fix For: 0.11 The Failover test cases do not work correctly or pass on 0-10 test profiles -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
Re: JMS Queue Browser Implementation
On 03/08/2011 04:47 PM, Rajith Attapattu wrote: On Tue, Mar 8, 2011 at 5:27 AM, Gordon Sim g...@redhat.com mailto:g...@redhat.com wrote: On 03/08/2011 09:50 AM, Robert Godfrey wrote: On 8 March 2011 04:48, Rajith Attapatturajit...@gmail.com mailto:rajit...@gmail.com wrote: Each time the getEnumeration method is called we create a new consumer. I fully understand the reasons as to why each enumeration needs to have it's own consumer. Is creating a consumer really that expensive? Or is the issue that the whole queue is then (potentially) sent to the client? Or is it that the subscriptions are never cleaned up correctly? (The mail on the user list talked about increasing numbers of subscriptions). The subscriptions are only cleaned up if 'close()' is called. In this case the user is repeatedly calling 'getEnumeration()' without closing the browser. If each call to getEnumeration() creates a new subscription, then I'd think that the cancellation should occur when the Enumeration is exhausted or discarded. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Created: (QPID-3134) Exceptions thrown during synchronous operations should be caught and wrapped appropriately
Exceptions thrown during synchronous operations should be caught and wrapped appropriately -- Key: QPID-3134 URL: https://issues.apache.org/jira/browse/QPID-3134 Project: Qpid Issue Type: Bug Reporter: Andrew Kennedy The 0-10 txCommit is a synchronous operation, and may time out or throw other SessionExceptions. These should be caught -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Commented: (QPID-3132) Threshold alert on a queue used to receive alerts causes broker crash
[ https://issues.apache.org/jira/browse/QPID-3132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13004711#comment-13004711 ] Ken Giusti commented on QPID-3132: -- I reviewed and approve the above patched for inclusion in 0.10 branch. Threshold alert on a queue used to receive alerts causes broker crash - Key: QPID-3132 URL: https://issues.apache.org/jira/browse/QPID-3132 Project: Qpid Issue Type: Bug Affects Versions: 0.10 Reporter: Gordon Sim Assignee: Gordon Sim Priority: Blocker Fix For: 0.10 If a queue bound to the QMF exchange for receiving events reaches a configured threhold and generates an alert, the alert will result in an infinite recursion where the message for the event is enqueued triggering a further event etc etc -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Commented: (QPID-3132) Threshold alert on a queue used to receive alerts causes broker crash
[ https://issues.apache.org/jira/browse/QPID-3132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13004712#comment-13004712 ] Justin Ross commented on QPID-3132: --- Approved for 0.10. Reviewed by Ken. Threshold alert on a queue used to receive alerts causes broker crash - Key: QPID-3132 URL: https://issues.apache.org/jira/browse/QPID-3132 Project: Qpid Issue Type: Bug Affects Versions: 0.10 Reporter: Gordon Sim Assignee: Gordon Sim Priority: Blocker Fix For: 0.10 If a queue bound to the QMF exchange for receiving events reaches a configured threhold and generates an alert, the alert will result in an infinite recursion where the message for the event is enqueued triggering a further event etc etc -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Resolved: (QPID-3132) Threshold alert on a queue used to receive alerts causes broker crash
[ https://issues.apache.org/jira/browse/QPID-3132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gordon Sim resolved QPID-3132. -- Resolution: Fixed Threshold alert on a queue used to receive alerts causes broker crash - Key: QPID-3132 URL: https://issues.apache.org/jira/browse/QPID-3132 Project: Qpid Issue Type: Bug Affects Versions: 0.10 Reporter: Gordon Sim Assignee: Gordon Sim Priority: Blocker Fix For: 0.10 If a queue bound to the QMF exchange for receiving events reaches a configured threhold and generates an alert, the alert will result in an infinite recursion where the message for the event is enqueued triggering a further event etc etc -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Commented: (QPID-2985) Add producer configurable transaction timeouts
[ https://issues.apache.org/jira/browse/QPID-2985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13004813#comment-13004813 ] Andrew Kennedy commented on QPID-2985: -- Documented here: https://cwiki.apache.org/confluence/display/qpid/Qpid+Java+Broker+Transaction+Timeouts Add producer configurable transaction timeouts -- Key: QPID-2985 URL: https://issues.apache.org/jira/browse/QPID-2985 Project: Qpid Issue Type: Improvement Components: Java Broker Reporter: Andrew Kennedy Assignee: Robbie Gemmell Fix For: 0.11 Port changes from QPID-2864 to trunk -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Commented: (QPID-2984) Add statistics generation for broker message delivery
[ https://issues.apache.org/jira/browse/QPID-2984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13004814#comment-13004814 ] Andrew Kennedy commented on QPID-2984: -- Documented here: https://cwiki.apache.org/confluence/display/qpid/Qpid+Java+Broker+Statistics Add statistics generation for broker message delivery - Key: QPID-2984 URL: https://issues.apache.org/jira/browse/QPID-2984 Project: Qpid Issue Type: Improvement Components: Java Broker Reporter: Andrew Kennedy Assignee: Robbie Gemmell Fix For: 0.11 Port changes from QPID-2932 to trunk -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
Re: Request for the following commits to be included in 0.10
Yes, ./systests/src/main/java/org/apache/qpid/test/unit/ack/ Acknowledge2ConsumersTest.java ./systests/src/main/java/org/apache/qpid/test/unit/ack/ AcknowledgeOnMessageTest.java ./systests/src/main/java/org/apache/qpid/test/unit/ack/ AcknowledgeAfterFailoverOnMessageTest.java ./systests/src/main/java/org/apache/qpid/test/unit/ack/ AcknowledgeTest.java ./systests/src/main/java/org/apache/qpid/test/unit/ack/ AcknowledgeAfterFailoverTest.java The AcknowledgeTest class has a test called 'testNoAck' which exercises this mode, and all the other classes extend this. This is how I both discovered and confirmed the fix for the regression. Andrew. -- -- andrew d kennedy ? do not fold, bend, spindle, or mutilate ; -- http://grkvlt.blogspot.com/ ? edinburgh : +44 7582 293 255 ; On 9 Mar 2011, at 20:47, Rajith Attapattu wrote: In rev 1079986 I added test cases for the reliability options including testing if the correct accept modes are set. I am wondering if there are existing test cases for NO_ACKNOWLEDGE other than the QueueBrowser test cases ? Regards, Rajith On Tue, Mar 8, 2011 at 8:52 PM, Andrew Kennedy andrewinternatio...@gmail.com wrote: On 9 Mar 2011, at 00:40, Robbie Gemmell wrote: Sorry if I wasn't clear. I wasn't saying it shouldn't go in, quite the opposite; in general I wouldn't allow this kind of change at this point, but in this particular case it is actually putting something back roughly the way it was until changed a few days ago so I would actually say that it must be put in. +1 on including #4 in 0.10 When we discovered and fixed this, we weren't actually aware it was a regression introduced recently, hence the separate JIRA and careful testing. Andrew. -- -- andrew d kennedy ? do not fold, bend, spindle, or mutilate ; -- http://grkvlt.blogspot.com/ ? edinburgh : +44 7582 293 255 ; - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
Re: Request for the following commits to be included in 0.10
Andrew, I did do a grep on NO_ACKNOWLEDGE and saw those test cases. Thanks for confirming. Just wanted to make sure I verified the changes properly. Btw does the various QueueBrowser tests pass for you ? Rajith On Wed, Mar 9, 2011 at 4:55 PM, Andrew Kennedy andrewinternatio...@gmail.com wrote: Yes, ./systests/src/main/java/org/apache/qpid/test/unit/ack/Acknowledge2ConsumersTest.java ./systests/src/main/java/org/apache/qpid/test/unit/ack/AcknowledgeOnMessageTest.java ./systests/src/main/java/org/apache/qpid/test/unit/ack/AcknowledgeAfterFailoverOnMessageTest.java ./systests/src/main/java/org/apache/qpid/test/unit/ack/AcknowledgeTest.java ./systests/src/main/java/org/apache/qpid/test/unit/ack/AcknowledgeAfterFailoverTest.java The AcknowledgeTest class has a test called 'testNoAck' which exercises this mode, and all the other classes extend this. This is how I both discovered and confirmed the fix for the regression. Andrew. -- -- andrew d kennedy ? do not fold, bend, spindle, or mutilate ; -- http://grkvlt.blogspot.com/ ? edinburgh : +44 7582 293 255 ; On 9 Mar 2011, at 20:47, Rajith Attapattu wrote: In rev 1079986 I added test cases for the reliability options including testing if the correct accept modes are set. I am wondering if there are existing test cases for NO_ACKNOWLEDGE other than the QueueBrowser test cases ? Regards, Rajith On Tue, Mar 8, 2011 at 8:52 PM, Andrew Kennedy andrewinternatio...@gmail.com wrote: On 9 Mar 2011, at 00:40, Robbie Gemmell wrote: Sorry if I wasn't clear. I wasn't saying it shouldn't go in, quite the opposite; in general I wouldn't allow this kind of change at this point, but in this particular case it is actually putting something back roughly the way it was until changed a few days ago so I would actually say that it must be put in. +1 on including #4 in 0.10 When we discovered and fixed this, we weren't actually aware it was a regression introduced recently, hence the separate JIRA and careful testing. Andrew. -- -- andrew d kennedy ? do not fold, bend, spindle, or mutilate ; -- http://grkvlt.blogspot.com/ ? edinburgh : +44 7582 293 255 ; - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Created: (QPID-3135) cpp/bld-winsdk.ps1 tries to install non-existant files
cpp/bld-winsdk.ps1 tries to install non-existant files -- Key: QPID-3135 URL: https://issues.apache.org/jira/browse/QPID-3135 Project: Qpid Issue Type: Bug Components: Packaging Affects Versions: 0.9 Environment: bld-winsdk builds Reporter: Chuck Rolke Assignee: Chuck Rolke The examples revision in QPID-3067 moved some files and bld-winsdk.ps1 still refers to them in their old directories. This prevents bld-winsdk from building a package correctly. This same problem is in QPID-3118 as it applies to CMakeLists. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Updated: (QPID-3135) cpp/bld-winsdk.ps1 tries to install non-existant files
[ https://issues.apache.org/jira/browse/QPID-3135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chuck Rolke updated QPID-3135: -- Attachment: QPID-3118_AdjustWinSdkInstallation.patch cpp/bld-winsdk.ps1 tries to install non-existant files -- Key: QPID-3135 URL: https://issues.apache.org/jira/browse/QPID-3135 Project: Qpid Issue Type: Bug Components: Packaging Affects Versions: 0.9 Environment: bld-winsdk builds Reporter: Chuck Rolke Assignee: Chuck Rolke Attachments: QPID-3118_AdjustWinSdkInstallation.patch The examples revision in QPID-3067 moved some files and bld-winsdk.ps1 still refers to them in their old directories. This prevents bld-winsdk from building a package correctly. This same problem is in QPID-3118 as it applies to CMakeLists. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Commented: (QPID-3135) cpp/bld-winsdk.ps1 tries to install non-existant files
[ https://issues.apache.org/jira/browse/QPID-3135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13004959#comment-13004959 ] Chuck Rolke commented on QPID-3135: --- I've added a patch that adjusts bld-winsdk.ps1 to the new directory structure. This patch is unverified so don't yet apply it. Let me give it a go tomorrow. cpp/bld-winsdk.ps1 tries to install non-existant files -- Key: QPID-3135 URL: https://issues.apache.org/jira/browse/QPID-3135 Project: Qpid Issue Type: Bug Components: Packaging Affects Versions: 0.9 Environment: bld-winsdk builds Reporter: Chuck Rolke Assignee: Chuck Rolke Attachments: QPID-3118_AdjustWinSdkInstallation.patch The examples revision in QPID-3067 moved some files and bld-winsdk.ps1 still refers to them in their old directories. This prevents bld-winsdk from building a package correctly. This same problem is in QPID-3118 as it applies to CMakeLists. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org