Re: Error compiling SDK
Alright, it should be building correctly now. Sorry again! -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Mon, May 13, 2024 at 8:56 AM Josh Tynjala wrote: > Sorry about that! Working on a fix. > > -- > Josh Tynjala > Bowler Hat LLC <https://bowlerhat.dev> > > > On Sat, May 11, 2024 at 5:35 PM Maria Jose Esteve > wrote: > >> The compilation of the SDK, when downloading the latest changes from >> royale-compiler (commit 15c7703), fails. >> >> BUILD FAILED >> D:\Develop_Royale\Projects\Royale-SDK\royale-asjs\build.xml:696: The >> following error occurred while executing this line: >> D:\Develop_Royale\Projects\Royale-SDK\royale-asjs\frameworks\build.xml:128: >> The following error occurred while executing this line: >> D:\Develop_Royale\Projects\Royale-SDK\royale-asjs\frameworks\build.xml:486: >> The following error occurred while executing this line: >> D:\Develop_Royale\Projects\Royale-SDK\royale-asjs\frameworks\projects\RoyaleUnitUI\build.xml:51: >> The following error occurred while executing this line: >> D:\Develop_Royale\Projects\Royale-SDK\royale-asjs\frameworks\js\projects\RoyaleUnitUIJS\build.xml:95: >> Warning: Could not find file >> D:\Develop_Royale\Projects\Royale-SDK\royale-asjs\frameworks\js\projects\RoyaleUnitUIJS\target\RoyaleUnitUIJS.swc >> to copy. >> >> Hiedra >> >>
Re: Error compiling SDK
Sorry about that! Working on a fix. -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Sat, May 11, 2024 at 5:35 PM Maria Jose Esteve wrote: > The compilation of the SDK, when downloading the latest changes from > royale-compiler (commit 15c7703), fails. > > BUILD FAILED > D:\Develop_Royale\Projects\Royale-SDK\royale-asjs\build.xml:696: The > following error occurred while executing this line: > D:\Develop_Royale\Projects\Royale-SDK\royale-asjs\frameworks\build.xml:128: > The following error occurred while executing this line: > D:\Develop_Royale\Projects\Royale-SDK\royale-asjs\frameworks\build.xml:486: > The following error occurred while executing this line: > D:\Develop_Royale\Projects\Royale-SDK\royale-asjs\frameworks\projects\RoyaleUnitUI\build.xml:51: > The following error occurred while executing this line: > D:\Develop_Royale\Projects\Royale-SDK\royale-asjs\frameworks\js\projects\RoyaleUnitUIJS\build.xml:95: > Warning: Could not find file > D:\Develop_Royale\Projects\Royale-SDK\royale-asjs\frameworks\js\projects\RoyaleUnitUIJS\target\RoyaleUnitUIJS.swc > to copy. > > Hiedra > >
Re: Align the FontAwesome5Type class with the latest 5x version
I see in the documentation that the font name is called "Font Awesome 5 Pro". font-family: "Font Awesome 5 Pro"; So maybe I'd go with FontAwesome5ProType. -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Mon, Apr 22, 2024 at 4:45 PM Maria Jose Esteve wrote: > Thanks for responding Josh and for the link. > I also like to keep the history because, in case of problems, it always > helps me. From now on I will try not to make "silly commits" and I will > upload everything :) if no one tells me otherwise. > > Since I uploaded the entire repo I can't use squash, although if I'm > honest, it gives me too much respect: if I make a mistake, I think I will > cause more problems. > > Josh, FontAwesome5ProType or FontAwesomePro5Type? > > Hiedra > > -Mensaje original- > De: Josh Tynjala > Enviado el: martes, 23 de abril de 2024 0:55 > Para: dev@royale.apache.org > Asunto: Re: Align the FontAwesome5Type class with the latest 5x version > > Personally, I usually just push all of my commits to develop without any > cleanup. I don't like changing history in Git, even if it is messy. > However, I know many others like to clean up their changes to look nicer. > Everyone has their own preferences. > > It is possible to "squash" multiple commits together into one commit by > using Git's powerful "rebase" feature. Rebasing can be useful when you are > working on a separate branch, and want to simplify your changes before > merging that branch into develop. > > Here's an article that I found that seems like a pretty good introduction > to rebasing: > > > https://medium.com/@slamflipstrom/a-beginners-guide-to-squashing-commits-with-git-rebase-8185cf6e62ec > > Be careful when rebasing, though. You nevert want to change any Git > history that has already been pushed to develop because that could mess > with others who have pulled them already. Rebasing should be used only for > commits that don't yet exist on the branch that you intend to merge into. > > -- > Josh Tynjala > Bowler Hat LLC <https://bowlerhat.dev> > > > On Mon, Apr 22, 2024 at 3:36 PM Maria Jose Esteve > wrote: > > > Hi, I finished the work yesterday (included an update to the > > MaterialIconType class as well) and would like to include it in the > > repository to move on to something else. > > If it's okay, tomorrow morning (in 8 hours), if no one has any > > objection I will mix in develop. > > > > I need you to tell me how you usually make changes to the repo when > > they are not simple commits (which we do directly in develop). I > > created a branch and made all the changes there. If I merge this > > branch into develop all the commits I have made will be pushed. "How > > do you act in this situation? How do you usually work against the SDK?" > > > > Thx. > > Hiedra > > > > -Mensaje original- > > De: Maria Jose Esteve Enviado el: domingo, 21 de > > abril de 2024 22:40 > > Para: dev@royale.apache.org > > Asunto: RE: Align the FontAwesome5Type class with the latest 5x > > version > > > > ¿FontAwesome5ProIconType o FontAwesomePro5Type? > > > > Hiedra > > > > -Mensaje original- > > De: Maria Jose Esteve Enviado el: domingo, 21 de > > abril de 2024 20:23 > > Para: dev@royale.apache.org > > Asunto: RE: Align the FontAwesome5Type class with the latest 5x > > version > > > > I have completed the FontAwesome5Type class with all the icons from > > the latest version 5.x, 5.15.4, Free and I have created the new > > FontAwesome6Type class (I made this modification the other day) > > > > I have followed the following criteria: > > - The constants of the new icons for the "numeric digits: 0, 1, 2, ... 9" > > begin with "N" (N1, N2, N3...N9) and I have respected the name of the > > constants that began by a number, such as "500px", a value > > corresponding to the constant "F500PX". > > > > - The name of a constant matches its value but in capital letters and > > with the "hyphens" (-) replaced by "underscore" (_) public static > > const ALIGN_JUSTIFY:String = "align-justify"; > > > > - I have only left the icons from the Free version. > > - I have added the icons of the Professional version, which existed in > > the FontAwesome5Type class, to the end of the class "temporarily". > > > > I have obtained the list of icons from the github repositories: > > version > > 5.15.4 [1] and version 6.5.2 [2] I am implementing th
Re: Align the FontAwesome5Type class with the latest 5x version
Personally, I usually just push all of my commits to develop without any cleanup. I don't like changing history in Git, even if it is messy. However, I know many others like to clean up their changes to look nicer. Everyone has their own preferences. It is possible to "squash" multiple commits together into one commit by using Git's powerful "rebase" feature. Rebasing can be useful when you are working on a separate branch, and want to simplify your changes before merging that branch into develop. Here's an article that I found that seems like a pretty good introduction to rebasing: https://medium.com/@slamflipstrom/a-beginners-guide-to-squashing-commits-with-git-rebase-8185cf6e62ec Be careful when rebasing, though. You nevert want to change any Git history that has already been pushed to develop because that could mess with others who have pulled them already. Rebasing should be used only for commits that don't yet exist on the branch that you intend to merge into. -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Mon, Apr 22, 2024 at 3:36 PM Maria Jose Esteve wrote: > Hi, I finished the work yesterday (included an update to the > MaterialIconType class as well) and would like to include it in the > repository to move on to something else. > If it's okay, tomorrow morning (in 8 hours), if no one has any objection I > will mix in develop. > > I need you to tell me how you usually make changes to the repo when they > are not simple commits (which we do directly in develop). I created a > branch and made all the changes there. If I merge this branch into develop > all the commits I have made will be pushed. "How do you act in this > situation? How do you usually work against the SDK?" > > Thx. > Hiedra > > -Mensaje original- > De: Maria Jose Esteve > Enviado el: domingo, 21 de abril de 2024 22:40 > Para: dev@royale.apache.org > Asunto: RE: Align the FontAwesome5Type class with the latest 5x version > > ¿FontAwesome5ProIconType o FontAwesomePro5Type? > > Hiedra > > -Mensaje original- > De: Maria Jose Esteve Enviado el: domingo, 21 de > abril de 2024 20:23 > Para: dev@royale.apache.org > Asunto: RE: Align the FontAwesome5Type class with the latest 5x version > > I have completed the FontAwesome5Type class with all the icons from the > latest version 5.x, 5.15.4, Free and I have created the new > FontAwesome6Type class (I made this modification the other day) > > I have followed the following criteria: > - The constants of the new icons for the "numeric digits: 0, 1, 2, ... 9" > begin with "N" (N1, N2, N3...N9) and I have respected the name of the > constants that began by a number, such as "500px", a value corresponding to > the constant "F500PX". > > - The name of a constant matches its value but in capital letters and with > the "hyphens" (-) replaced by "underscore" (_) public static const > ALIGN_JUSTIFY:String = "align-justify"; > > - I have only left the icons from the Free version. > - I have added the icons of the Professional version, which existed in the > FontAwesome5Type class, to the end of the class "temporarily". > > I have obtained the list of icons from the github repositories: version > 5.15.4 [1] and version 6.5.2 [2] I am implementing these changes in an > independent branch [3] until you confirm that it is right or wrong for you. > Next, I'm going to create the FontAwesome5ProType class. > > [1] https://github.com/FortAwesome/Font-Awesome/tree/5.x > [2] https://github.com/FortAwesome/Font-Awesome/tree/6.x > [3] > https://github.com/apache/royale-asjs/tree/fontIcon/toplineup_fontawesome5 > > Hiedra > > -Mensaje original- > De: Maria Jose Esteve Enviado el: domingo, 21 de > abril de 2024 14:01 > Para: dev@royale.apache.org > Asunto: Align the FontAwesome5Type class with the latest 5x version > > I wanted to ask you a couple of questions... > > I want to align the FontAwesome5Type class with the latest 5x version, > 5.15.4 to complete it (I understand that there will be no more > modifications because version 6x came out) In this class, now, the icons of > the "Free" version are mixed with those of the "Pro" version. > Wouldn't it be better to divide this class into two? leave the Free icons > in the current class and create a new FontAwesome5ProType for the Pro icons? > > On the other hand, I have detected some errors (for now): > area-chart really is chart-area, and the same thing happens with bar-chart > and bar-pie, (chart-bar and chart-pie) My question is... would you modify > the name of the variable as well or leave it as is? > For example: > Now: public static const AREA_CHART:String = "area-chart"; > Opt. 1: public static const AREA_CHART:String = "chart-area"; > Opt. 2: public static const CHART_AREA:String = "chart-area"; > > Option 1 or Option 2? > > Let me know your opinion. > > Hiedra > >
Re: Abstract getters and setters
Yeah, I started on it yesterday, and I don't see why I can't finish it up in April. -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Fri, Mar 29, 2024 at 12:49 AM Harbs wrote: > Thanks Josh, > > Is that something you can see yourself working on? > > Thanks, > Harbs > > > On Mar 27, 2024, at 5:47 PM, Josh Tynjala > wrote: > > > > I don't think this has been discussed before. I don't believe that there > is > > any technical issue preventing it. I suspect that getters/setters just > > never crossed my mind when I implemented abstract methods. > > > > -- > > Josh Tynjala > > Bowler Hat LLC <https://bowlerhat.dev> > > > > > > On Wed, Mar 27, 2024 at 5:19 AM Gabe Harbs > wrote: > > > >> I just noticed that getters and setters cannot be abstract. > >> > >> I don’t remember if this was discussed before. Is there an issue with > >> adding that functionality? > >> > >> Thanks, > >> Harbs > >
Re: Abstract getters and setters
I don't think this has been discussed before. I don't believe that there is any technical issue preventing it. I suspect that getters/setters just never crossed my mind when I implemented abstract methods. -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Wed, Mar 27, 2024 at 5:19 AM Gabe Harbs wrote: > I just noticed that getters and setters cannot be abstract. > > I don’t remember if this was discussed before. Is there an issue with > adding that functionality? > > Thanks, > Harbs
Re: New Release?
Just a reminder: the npm version of Royale is currently one ahead of where it should be: 0.9.11 instead of 0.9.10. With that in mind, we probably need the new Royale release to be version 0.9.12. This has happened a couple of times now. We also had one npm release that was missing most of its files, so it didn't work at all. It's okay. Mistakes happen. If the release manager instructions don't warn about potential issues around the npm release, though, I think that we should update them to include some extra manual checks before publishing to npm. Here are some things that might be worth mentioning (perhaps with some editing): The `npm pack` command creates a .tgz bundle of the package. You can extract this with your favorite program to manually check what's inside. Side note: The .tgz file can also be passed to `npm install` to test installation. It works something like this: npm install -g royale-js.tgz npm install -g royale-js-swf.tgz --foreground-scripts While `npm publish` with no arguments can be run in the repo directory that contains package.json, you can also pass the .tgz bundle created by `npm pack` to `npm publish`. If you've already checked the contents of the .tgz bundle, then it makes sense to submit that directly. npm publish royale-js.tgz Finally, `npm publish` has an optional --dry-run command line option that will fake a submission locally. The output from this command will include the version and a list of all included files. It will stop before submitting to the registry, though. On Tue, Mar 12, 2024 at 9:30 AM Yishay Weiss wrote: > Hi Guys, > > It's been a while since we've done a release. There have been some recent > compiler changes and some minor asjs fixes, which together might warrant > one. Thougths on this? Is anybody planning any big changes soon? > > Thanks, > Yishay >
Re: New Release?
The royale-compiler release notes are ready to go. I updated the royale-asjs release notes with things that I personally worked on. I'll let others who work more deeply on the framework take care of the rest for royale-asjs. -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Tue, Mar 12, 2024 at 9:30 AM Yishay Weiss wrote: > Hi Guys, > > It's been a while since we've done a release. There have been some recent > compiler changes and some minor asjs fixes, which together might warrant > one. Thougths on this? Is anybody planning any big changes soon? > > Thanks, > Yishay >
Re: New Release?
Sounds good to me! I'll update the compiler release notes. -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Tue, Mar 12, 2024 at 9:30 AM Yishay Weiss wrote: > Hi Guys, > > It's been a while since we've done a release. There have been some recent > compiler changes and some minor asjs fixes, which together might warrant > one. Thougths on this? Is anybody planning any big changes soon? > > Thanks, > Yishay >
Re: NullPointerException - NullPointerException: Cannot invoke "org.antlr.runtime.TokenStream.getSourceName()" because "tokenStream"
My latest commit should fix it. Sorry about that! -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Thu, Feb 29, 2024 at 6:34 AM Piotr Zarzycki wrote: > Hi All, > > I'm getting following error while building by Maven our application in > GitHub Actions. Do you recognise anything here ? > > Internal error: java.lang.NullPointerException: Cannot invoke > "org.antlr.runtime.TokenStream.getSourceName()" because "tokenStream" is > null > > org.apache.royale.compiler.internal.css.CSSDocument.(CSSDocument.java:181)org.apache.royale.compiler.internal.css.codegen.CSSCompilationSession$SynthesizedCSSDocument.(CSSCompilationSession.java:376)org.apache.royale.compiler.internal.css.codegen.CSSCompilationSession.synthesisNormalizedCSS(CSSCompilationSession.java:217)org.apache.royale.compiler.internal.driver.js.royale.JSCSSCompilationSession.getEncodedCSS(JSCSSCompilationSession.java:68)org.apache.royale.compiler.internal.codegen.mxml.royale.MXMLRoyaleEmitter.postProcess(MXMLRoyaleEmitter.java:613)org.apache.royale.compiler.internal.codegen.mxml.MXMLWriter.writeTo(MXMLWriter.java:73)org.apache.royale.compiler.clients.MXMLJSCRoyale.writeCompilationUnit(MXMLJSCRoyale.java:536)org.apache.royale.compiler.clients.MXMLJSCRoyale.compile(MXMLJSCRoyale.java:450)org.apache.royale.compiler.clients.MXMLJSCRoyale._mainNoExit(MXMLJSCRoyale.java:271)org.apache.royale.compiler.clients.MXMLJSCRoyale.mainNoExit(MXMLJSCRoyale.java:228)org.apache.royale.compiler.clients.MXMLJSC._mainNoExit(MXMLJSC.java:308)org.apache.royale.compiler.clients.MXMLJSC.mainNoExit(MXMLJSC.java:243)org.apache.royale.compiler.clients.MXMLJSC.execute(MXMLJSC.java:172)org.apache.royale.maven.BaseMojo.execute(BaseMojo.java:398)org.apache.royale.maven.CompileAppMojo.execute(CompileAppMojo.java:112)org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:137)org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2(MojoExecutor.java:370)org.apache.maven.lifecycle.internal.MojoExecutor.doExecute(MojoExecutor.java:351)org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:215)org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:171)org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:163)org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:117)org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:81)org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:56)org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:299)org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)org.apache.maven.cli.MavenCli.execute(MavenCli.java:963)org.apache.maven.cli.MavenCli.doMain(MavenCli.java:296)org.apache.maven.cli.MavenCli.main(MavenCli.java:199)java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native > > Method)java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)java.base/java.lang.reflect.Method.invoke(Method.java:568)org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:282)org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:225)org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:406)org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:347) > > Thanks, > -- > > Piotr Zarzycki >
Minimum Java version 11 for Royale Compiler
Hey folks, A user recently reported an issue building royale-compiler with Maven and a newer version of Java (they were trying with Java 19). It resulted in the following error, which I was able to reproduce if I switched to the latest Java: [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-antlr-plugin:2.0-beta-1: > generate (generate-as-parser) on project compiler: > Execution generate-as-parser of goal > org.apache.maven.plugins:maven-antlr-plugin:2.0-beta-1:generate failed: > > The Security Manager is deprecated and will be removed in a future release > -> [Help 1] > The reporter determined that the issue was caused by the org.apache.maven.plugins.maven-antlr-plugin dependency used by the Maven build for royale-compiler. They suggested a different org.omnifaces.antlr-maven-plugin dependency that is compatible, but doesn't have the Security Manager issue. I confirmed that this fixed the issue, and things still seemed to be working correctly, so I merged the updated dependency. I didn't notice it at the time, but I just discovered that this new dependency requires Java 11 at minimum. Until now, we've supported Java 8 at minimum. Unfortunately, I could not find another alternative Antlr plugin for Maven that still supports Java 8, so it looks like we'll need to update our minimum requirements for Royale too. At least for the Maven build. However, for our sanity, we should probably just require Java 11 minimum across the board (in the Ant build too). For reference, Java 8 was released in 2014. Java 11 was released in 2018. Both are considered LTS (Long Term Support) versions and continue to receive updates from OpenJDK vendors. Java 17 and 21 are newer LTS versions that are also available. -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev>
Re: TrustedHTML
It could be as easy as updating the version number, and everything still works the same from our end. Or they could have breaking changes in the Closure Compiler APIs, or maybe they've started requiring JS to be written in a different way, and then things could be very complicated. -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Tue, Nov 28, 2023 at 9:07 AM Gabe Harbs wrote: > I guess I’ll try. > > And IIRC, updating Closure Compiler was very complicated. Right? > > > On Nov 28, 2023, at 6:46 PM, Josh Tynjala > wrote: > > > > You can set the GOOG_HOME environment variable (or env.GOOG_HOME in > > env.properties) to use a custom Closure Library when building > royale-asjs, > > instead of the version that we have pinned. > > > > I seem to remember Alex mentioning that updating either Closure Compiler > or > > Closure Library *sometimes* also requires updating the other. I don't see > > any mention of specific versions in either README file, though. So you > > might just need to try using an updated Closure Library and test if it > > works with the version of Closure Compiler that we're bundling. > > > > -- > > Josh Tynjala > > Bowler Hat LLC <https://bowlerhat.dev> > > > > > > On Tue, Nov 28, 2023 at 8:34 AM Gabe Harbs > wrote: > > > >> It seems like our dependency of Closure Compiler is too old. > >> > >> I have an app which runs inside Google Workspace and I’m having issues > >> running a debug version since Google enabled TrustedHTML restrictions. > >> https://developer.mozilla.org/en-US/docs/Web/API/TrustedHTML > >> > >> The newer versions appear to support TrustedHTML. > >> > >> > >> > https://github.com/google/closure-library/blob/7818ff7dc0b53555a7fb3c3427e6761e88bde3a2/closure/goog/base.js#L2996 > >> > >> Is there an issue with just swapping the closure-library version? > >> > >> Harbs > >
Re: TrustedHTML
You can set the GOOG_HOME environment variable (or env.GOOG_HOME in env.properties) to use a custom Closure Library when building royale-asjs, instead of the version that we have pinned. I seem to remember Alex mentioning that updating either Closure Compiler or Closure Library *sometimes* also requires updating the other. I don't see any mention of specific versions in either README file, though. So you might just need to try using an updated Closure Library and test if it works with the version of Closure Compiler that we're bundling. -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Tue, Nov 28, 2023 at 8:34 AM Gabe Harbs wrote: > It seems like our dependency of Closure Compiler is too old. > > I have an app which runs inside Google Workspace and I’m having issues > running a debug version since Google enabled TrustedHTML restrictions. > https://developer.mozilla.org/en-US/docs/Web/API/TrustedHTML > > The newer versions appear to support TrustedHTML. > > > https://github.com/google/closure-library/blob/7818ff7dc0b53555a7fb3c3427e6761e88bde3a2/closure/goog/base.js#L2996 > > Is there an issue with just swapping the closure-library version? > > Harbs
Re: Rich media in Royale
Looks like it worked! -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Wed, Sep 27, 2023 at 9:22 AM Maria Jose Esteve wrote: > I have already updated it. I don't see the changes yet but I imagine we > will have to wait some time. > Hiedra > > -Mensaje original- > De: Maria Jose Esteve > Enviado el: miércoles, 27 de septiembre de 2023 18:04 > Para: dev@royale.apache.org > Asunto: RE: Rich media in Royale > > Well, I don't understand it, because I don't see the Video and Audio > examples that Cristallium made. what could be happening? > I'm going to compile it and upload it again, just to make sure, okay? > > Hiedra > > -Mensaje original- > De: Josh Tynjala Enviado el: miércoles, 27 de > septiembre de 2023 17:47 > Para: dev@royale.apache.org > Asunto: Re: Rich media in Royale > > It appears to be correctly serving the version that Yishay uploaded. There > is no redirect to change. > > -- > Josh Tynjala > Bowler Hat LLC <https://bowlerhat.dev> > > > On Tue, Sep 26, 2023 at 4:45 PM Maria Jose Esteve > wrote: > > > Hi, I've checked the website repository [1] and in the "tourdejewel" > > folder there appears to be an updated build that Yishay uploaded in > > early June. It seems that https://royale.apache.org/tourdejewel is not > > pointing to the new address. > > I'm lost here... how can you change the redirect? > > > > Hiedra > > > > [1] https://github.com/apache/royale-website > > > > > > > > -Mensaje original- > > De: Maria Jose Esteve Enviado el: jueves, 21 de > > septiembre de 2023 17:05 > > Para: dev@royale.apache.org > > Asunto: RE: Rich media in Royale > > > > Over the weekend I will try to review the documentation on the TDJ > > publication. I remember that some time ago I compiled it and uploaded > > it but I couldn't get it to work. > > I will give you feedback. > > > > Hiedra > > > > De: cont...@cristallium.com Enviado el: > > jueves, > > 21 de septiembre de 2023 14:24 > > Para: dev@royale.apache.org > > Asunto: Re: Rich media in Royale > > > > > > Hi Virginia, > > > > As Maria said, Apache Royale has Audio and VideoPlayer with variable > > playrate in 0.9.10 version. > > > > Tour de jewel (https://royale.apache.org/tourdejewel/) is not now up > > to date to see it. > > > > You can find attached zip with tdj up to date and see by yourselft > > Audio and Video player usage. > > > > For recording side, you can use external js capabilities of Apache > > Royale ( > > https://royale.apache.org/blog/using-external-javascript-libraries-in- > > apache-royale/) to use javascript recording librarie from AS3. > > > > Hope that will help you > > > > Fred > > > > > > > > Le 2023-09-19 10:35, Virginia Westwood a écrit : > > Hi, > > > > About 10 years ago, after working with First Nations Communities, I > > completed a Flex application (Flash) for Computer Assisted Language > > Learning for their Language (NYIKINA) - the first of its kind in the > world. > > However, it was effectively killed by Adobe. I tried over several > > years to keep it going, trans-piling it, and using Flash players in > > browsers like BlueMoon. I also followed the Royale development closely > > and tried, before giving up as most of the development of classes and > > components seemed directed at business applications. > > > > I am now trying again, as GitHub and websites consistently say that > > Royale supports Rich Media. But I am blowed if I can find any classes > that do this. > > > > Can you possibly help? Guide me to the classes I can use for audio > > (play and record) and video, vital to language learning. > > Or confirm if it is not available? If it maybe, sometime? > > > > Thanks > > > > Virginia > > > > > > Dr Virginia Westwood > > Research Fellow (Intergenerational Cultural Transfer of Indigenous > > Knowledges) Project Coordinator (ARC Linkage Grant) > > > > I respectfully acknowledge the traditional custodians of the Country > > on which we live and work, and commit to building relationships, > > respect and opportunities together. > > > > Nulungu Research Institute > > The University of Notre Dame Australia > > 88 Guy St (PO Box 2287) Broome, Western Australia 6725 Phone (+61 8) > > 9192 > > 0614 > > Mobile: 0408 971 446 > > Email: virginia.westw...@nd.edu.au
Re: Rich media in Royale
Yeah, it takes some time to synchronize. -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Wed, Sep 27, 2023 at 9:22 AM Maria Jose Esteve wrote: > I have already updated it. I don't see the changes yet but I imagine we > will have to wait some time. > Hiedra > > -Mensaje original- > De: Maria Jose Esteve > Enviado el: miércoles, 27 de septiembre de 2023 18:04 > Para: dev@royale.apache.org > Asunto: RE: Rich media in Royale > > Well, I don't understand it, because I don't see the Video and Audio > examples that Cristallium made. what could be happening? > I'm going to compile it and upload it again, just to make sure, okay? > > Hiedra > > -Mensaje original- > De: Josh Tynjala Enviado el: miércoles, 27 de > septiembre de 2023 17:47 > Para: dev@royale.apache.org > Asunto: Re: Rich media in Royale > > It appears to be correctly serving the version that Yishay uploaded. There > is no redirect to change. > > -- > Josh Tynjala > Bowler Hat LLC <https://bowlerhat.dev> > > > On Tue, Sep 26, 2023 at 4:45 PM Maria Jose Esteve > wrote: > > > Hi, I've checked the website repository [1] and in the "tourdejewel" > > folder there appears to be an updated build that Yishay uploaded in > > early June. It seems that https://royale.apache.org/tourdejewel is not > > pointing to the new address. > > I'm lost here... how can you change the redirect? > > > > Hiedra > > > > [1] https://github.com/apache/royale-website > > > > > > > > -Mensaje original- > > De: Maria Jose Esteve Enviado el: jueves, 21 de > > septiembre de 2023 17:05 > > Para: dev@royale.apache.org > > Asunto: RE: Rich media in Royale > > > > Over the weekend I will try to review the documentation on the TDJ > > publication. I remember that some time ago I compiled it and uploaded > > it but I couldn't get it to work. > > I will give you feedback. > > > > Hiedra > > > > De: cont...@cristallium.com Enviado el: > > jueves, > > 21 de septiembre de 2023 14:24 > > Para: dev@royale.apache.org > > Asunto: Re: Rich media in Royale > > > > > > Hi Virginia, > > > > As Maria said, Apache Royale has Audio and VideoPlayer with variable > > playrate in 0.9.10 version. > > > > Tour de jewel (https://royale.apache.org/tourdejewel/) is not now up > > to date to see it. > > > > You can find attached zip with tdj up to date and see by yourselft > > Audio and Video player usage. > > > > For recording side, you can use external js capabilities of Apache > > Royale ( > > https://royale.apache.org/blog/using-external-javascript-libraries-in- > > apache-royale/) to use javascript recording librarie from AS3. > > > > Hope that will help you > > > > Fred > > > > > > > > Le 2023-09-19 10:35, Virginia Westwood a écrit : > > Hi, > > > > About 10 years ago, after working with First Nations Communities, I > > completed a Flex application (Flash) for Computer Assisted Language > > Learning for their Language (NYIKINA) - the first of its kind in the > world. > > However, it was effectively killed by Adobe. I tried over several > > years to keep it going, trans-piling it, and using Flash players in > > browsers like BlueMoon. I also followed the Royale development closely > > and tried, before giving up as most of the development of classes and > > components seemed directed at business applications. > > > > I am now trying again, as GitHub and websites consistently say that > > Royale supports Rich Media. But I am blowed if I can find any classes > that do this. > > > > Can you possibly help? Guide me to the classes I can use for audio > > (play and record) and video, vital to language learning. > > Or confirm if it is not available? If it maybe, sometime? > > > > Thanks > > > > Virginia > > > > > > Dr Virginia Westwood > > Research Fellow (Intergenerational Cultural Transfer of Indigenous > > Knowledges) Project Coordinator (ARC Linkage Grant) > > > > I respectfully acknowledge the traditional custodians of the Country > > on which we live and work, and commit to building relationships, > > respect and opportunities together. > > > > Nulungu Research Institute > > The University of Notre Dame Australia > > 88 Guy St (PO Box 2287) Broome, Western Australia 6725 Phone (+61 8) > > 9192 > > 0614 > > Mobile: 0408 971 446 > > Email: virginia.westw.
Re: Rich media in Royale
It appears to be correctly serving the version that Yishay uploaded. There is no redirect to change. -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Tue, Sep 26, 2023 at 4:45 PM Maria Jose Esteve wrote: > Hi, I've checked the website repository [1] and in the "tourdejewel" > folder there appears to be an updated build that Yishay uploaded in early > June. It seems that https://royale.apache.org/tourdejewel is not pointing > to the new address. > I'm lost here... how can you change the redirect? > > Hiedra > > [1] https://github.com/apache/royale-website > > > > -Mensaje original- > De: Maria Jose Esteve > Enviado el: jueves, 21 de septiembre de 2023 17:05 > Para: dev@royale.apache.org > Asunto: RE: Rich media in Royale > > Over the weekend I will try to review the documentation on the TDJ > publication. I remember that some time ago I compiled it and uploaded it > but I couldn't get it to work. > I will give you feedback. > > Hiedra > > De: cont...@cristallium.com Enviado el: jueves, > 21 de septiembre de 2023 14:24 > Para: dev@royale.apache.org > Asunto: Re: Rich media in Royale > > > Hi Virginia, > > As Maria said, Apache Royale has Audio and VideoPlayer with variable > playrate in 0.9.10 version. > > Tour de jewel (https://royale.apache.org/tourdejewel/) is not now up to > date to see it. > > You can find attached zip with tdj up to date and see by yourselft Audio > and Video player usage. > > For recording side, you can use external js capabilities of Apache Royale ( > https://royale.apache.org/blog/using-external-javascript-libraries-in-apache-royale/) > to use javascript recording librarie from AS3. > > Hope that will help you > > Fred > > > > Le 2023-09-19 10:35, Virginia Westwood a écrit : > Hi, > > About 10 years ago, after working with First Nations Communities, I > completed a Flex application (Flash) for Computer Assisted Language > Learning for their Language (NYIKINA) - the first of its kind in the world. > However, it was effectively killed by Adobe. I tried over several years to > keep it going, trans-piling it, and using Flash players in browsers like > BlueMoon. I also followed the Royale development closely and tried, before > giving up as most of the development of classes and components seemed > directed at business applications. > > I am now trying again, as GitHub and websites consistently say that Royale > supports Rich Media. But I am blowed if I can find any classes that do this. > > Can you possibly help? Guide me to the classes I can use for audio (play > and record) and video, vital to language learning. > Or confirm if it is not available? If it maybe, sometime? > > Thanks > > Virginia > > > Dr Virginia Westwood > Research Fellow (Intergenerational Cultural Transfer of Indigenous > Knowledges) Project Coordinator (ARC Linkage Grant) > > I respectfully acknowledge the traditional custodians of the Country on > which we live and work, and commit to building relationships, respect and > opportunities together. > > Nulungu Research Institute > The University of Notre Dame Australia > 88 Guy St (PO Box 2287) Broome, Western Australia 6725 Phone (+61 8) 9192 > 0614 > Mobile: 0408 971 446 > Email: virginia.westw...@nd.edu.au<mailto:virginia.westw...@nd.edu.au > ><mailto:virginia.westw...@nd.edu.au<mailto:virginia.westw...@nd.edu.au>> > > Disclaimer > > The information contained in this communication from the sender is > confidential. It is intended solely for use by the recipient and others > authorized to receive it. If you are not the recipient, you are hereby > notified that any disclosure, copying, distribution or taking action in > relation of the contents of this information is strictly prohibited and may > be unlawful. > > This email has been scanned for viruses and malware, and may have been > automatically archived by Mimecast Ltd, an innovator in Software as a > Service (SaaS) for business. Providing a safer and more useful place for > your human generated data. Specializing in; Security, archiving and > compliance. To find out more visit the Mimecast website. > > > > >
Royale AS3 with Starling Framework
Hi Royale community, As you may know, I'm a big fan of finding ways for Royale's AS3 to JS compiler to work with emulated Flash APIs. Today, I'm sharing a little project created by Fancy2209 that uses AS3/Royale to build an app running on the GPU-accelerated Starling Framework. Here's the "Flappy Starling" sample, compiled from AS3 to JS, running on top of OpenFL and Starling — in your web browser! https://fancy2209.github.io/FlappyStarlingRoyale/ Source code available here: https://github.com/Fancy2209/Flappy-Starling-Royale -- Josh Tynjala
UIBase has mouse events but not keyboard events?
I'm trying to convert some Flex code to Royale. In particular, I'd like to add a keyDown listener to a component in MXML so I can listen to special keys like Esc, but there doesn't seem to be any [Event] metadata for keyboard events on UIBase. I see that there is [Event] metadata for mouse events, though. Maybe I've missed it, but there also doesn't even seem to be a bead that can somehow allow me to add a keyDown listener in MXML either. I found DispatchKeyboardEventBead, but it seems to dispatch the event on the strand, which would require me to manually call addEventListener() in AS3 instead, which is pretty complicated because I would need to listen to some other event in MXML first, like initialize or whatever. Both mouse and keyboard feel to me like pretty fundamental forms of user input. With that in mind, if PAYG is the justification for not exposing keyboard events, I'm not sure how the same justification doesn't apply to mouse events. On the other hand, if it's something that actually should be exposed without beads, and it simply hasn't been a priority yet, then I hope someone can help me add it. I tried my best to figure out how Royale MouseEvents get converted from HTML/JS mouse events, to see if I could do something similar with keyboard events, but it wasn't clear to me where the lowest level listeners were being added for things like mousedown/mouseup/mousemove/etc. -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev>
Re: New (optional) AS3 compiler feature: Type inference
I think it would be feasible for vscode-as3mxml to provide a quick fix to convert the inferred type into an explicitly declared type, if that's what you mean. I don't think that there's any other tool where it makes sense. The formatter, for instance, can see the type declarations, but it doesn't understand the types. Yes, assigning the variable when it is declared is required (but it doesn't need to be a literal value... another variable, or even a more complex expression with operators, function calls, etc. can have their types detected by the compiler). With no declared type and no assignment, the variable's value defaults to undefined, which would be inferred as type * instead. -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Tue, Jun 20, 2023 at 2:23 PM Harbs wrote: > Nice. > > I personally like explicit types because it’s more human readable. > > How feasable would it be to automatically add types to the code based on > type inference. So var s = “hello” could be transformed to var s:String = > “hello”. > > Do you need to assign the variable when it’s declared for this to work? > > > On Jun 21, 2023, at 12:07 AM, Josh Tynjala > wrote: > > > > Hi all, > > > > One cool feature in other languages similar to AS3, such as TypeScript or > > Haxe, is type inference. It allows developers to optionally omit a type > > declaration from a variable, or a function signature, by having the > > compiler automatically detect an appropriate type from context. > > > > For example, you traditionally would declare a variable with a String > type > > like this: > > > > var s:String = "hello"; > > > > If you enable type inference, you can declare the same variable like this > > instead because the compiler knows that the initializer is a string. > > > > var s = "hello"; > > > > Type inference applies to local/member/static variables, getters/setters, > > function parameters, and function return values. If a function has > multiple > > return statements, the type inference will try to find a common base > type, > > if possible. If a type cannot be inferred for any reason, the compiler > will > > fall back to the * type, and you'll get a warning, the same as when type > > inference is disabled. > > > > If you build the compiler from source (or download the next nightly > build), > > you can enable this feature in your project using the new > -infer-types=true > > compiler option. It is opt-in for now, to avoid any potential backwards > > compatibility issues with existing code. > > > > I also wrote some documentation with examples and more detailed > > explanations: > > > > https://apache.github.io/royale-docs/features/as3/type-inference > > > > -- > > Josh Tynjala > > Bowler Hat LLC <https://bowlerhat.dev> > >
New (optional) AS3 compiler feature: Type inference
Hi all, One cool feature in other languages similar to AS3, such as TypeScript or Haxe, is type inference. It allows developers to optionally omit a type declaration from a variable, or a function signature, by having the compiler automatically detect an appropriate type from context. For example, you traditionally would declare a variable with a String type like this: var s:String = "hello"; If you enable type inference, you can declare the same variable like this instead because the compiler knows that the initializer is a string. var s = "hello"; Type inference applies to local/member/static variables, getters/setters, function parameters, and function return values. If a function has multiple return statements, the type inference will try to find a common base type, if possible. If a type cannot be inferred for any reason, the compiler will fall back to the * type, and you'll get a warning, the same as when type inference is disabled. If you build the compiler from source (or download the next nightly build), you can enable this feature in your project using the new -infer-types=true compiler option. It is opt-in for now, to avoid any potential backwards compatibility issues with existing code. I also wrote some documentation with examples and more detailed explanations: https://apache.github.io/royale-docs/features/as3/type-inference -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev>
Re: Adding Royale Compiler to reproducible-central
Yes, I assume that it's because they didn't use option-with-swf, but they're comparing to a version that did. I don't really know why sources JARs are uploaded, or whether they're supposed to be reproducible or not. -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Sun, Jun 18, 2023 at 1:25 AM Yishay Weiss wrote: > >1) It looks like they built without playerglobal.swc, but they are > comparing to a build that used playerglobal.swc > > Is that because they didn't use the option-with-swf option? > > >2) The emitHeader() method in JBurgGenerator adds the current date to a > comment: > > I looked at the validation script in compiler/releasesteps.xml and it > looks like there is no comparison of sources.jar, which is what they tested > for (namely compiler-0.9.10-sources.jar). Only binary jars get validated. > > Are *sources jars uploaded solely for debugging convenience? If so, can we > say that those should not be tested for reproducibility? > > > > From: Josh Tynjala > Sent: Thursday, June 15, 2023 7:13 PM > To: dev@royale.apache.org > Subject: Re: Adding Royale Compiler to reproducible-central > > A couple of obvious things that I see right away: > > 1) It looks like they built without playerglobal.swc, but they are > comparing to a build that used playerglobal.swc. > > 2) The emitHeader() method in JBurgGenerator adds the current date to a > comment: > > > https://github.com/apache/royale-compiler/blob/apache-royale-0.9.10/compiler-jburg-types/src/main/java/jburg/burg/JBurgGenerator.java#L1048-L1053 > > To make it reproducible, this should either use a fixed date passed in as > part of the build, or the generated comment shouldn't include the date at > all. > > -- > Josh Tynjala > Bowler Hat LLC <https://bowlerhat.dev> > > > On Thu, Jun 15, 2023 at 12:31 AM Yishay Weiss > wrote: > > > Hi, > > > > There's been a lot of talk recently on ASF's members channel regarding > > reproducible builds, which has brought me to this repo [1] which lists > > known reproducible artifacts. I've opened a ticket [2] requesting our > > compiler be added and have received a report of some differences in > > binaries. > > > > Does anyone want to take a look? > > > > Thanks, > > Yishay > > > > [1] jvm-repo-rebuild/reproducible-central: Reproducible Central: rebuild > > instructions for artifacts published to (Maven) Central Repository ( > > github.com)<https://github.com/jvm-repo-rebuild/reproducible-central> > > [2] Add org.apache.royale · Issue #117 · > > jvm-repo-rebuild/reproducible-central (github.com)< > > https://github.com/jvm-repo-rebuild/reproducible-central/issues/117> > > >
Re: Adding Royale Compiler to reproducible-central
A couple of obvious things that I see right away: 1) It looks like they built without playerglobal.swc, but they are comparing to a build that used playerglobal.swc. 2) The emitHeader() method in JBurgGenerator adds the current date to a comment: https://github.com/apache/royale-compiler/blob/apache-royale-0.9.10/compiler-jburg-types/src/main/java/jburg/burg/JBurgGenerator.java#L1048-L1053 To make it reproducible, this should either use a fixed date passed in as part of the build, or the generated comment shouldn't include the date at all. -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Thu, Jun 15, 2023 at 12:31 AM Yishay Weiss wrote: > Hi, > > There's been a lot of talk recently on ASF's members channel regarding > reproducible builds, which has brought me to this repo [1] which lists > known reproducible artifacts. I've opened a ticket [2] requesting our > compiler be added and have received a report of some differences in > binaries. > > Does anyone want to take a look? > > Thanks, > Yishay > > [1] jvm-repo-rebuild/reproducible-central: Reproducible Central: rebuild > instructions for artifacts published to (Maven) Central Repository ( > github.com)<https://github.com/jvm-repo-rebuild/reproducible-central> > [2] Add org.apache.royale · Issue #117 · > jvm-repo-rebuild/reproducible-central (github.com)< > https://github.com/jvm-repo-rebuild/reproducible-central/issues/117> >
Re: [DISCUSS] Release Apache Royale 0.9.10 RC4
I think you just replace the contents of the tourdejewel directory with a new build: https://github.com/apache/royale-website/tree/master/tourdejewel -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Wed, May 31, 2023 at 2:40 AM Yishay Weiss wrote: > I added a blog post to the docs repo, does it get published automatically? > > What needs to be done in TDJ? > ____ > From: Josh Tynjala > Sent: Tuesday, May 30, 2023 7:02 PM > To: dev@royale.apache.org > Subject: Re: [DISCUSS] Release Apache Royale 0.9.10 RC4 > > I just updated the source code and downloads pages on the website to link > to 0.9.10. > > In addition to Tour de Jewel, we'll need a 9.10.0 blog post. As with > previous releases, it can simply be based on the changelogs. > > -- > Josh Tynjala > Bowler Hat LLC <https://bowlerhat.dev> > > > On Sun, May 28, 2023 at 10:54 PM Piotr Zarzycki > > wrote: > > > I agree on a point where we need more people who can easily do a release. > > Let’s have 2 more releases with someone else than you and discuss 1.0 > than. > > > > In case of announcing I think it should happen once all release related > > stuff is fully done. We need to update website and Tour de Jewel build > > maybe. Do you know how to do that ? > > > > On Sun, 28 May 2023 at 14:31, Yishay Weiss > wrote: > > > > > I think it's a good idea to bump the next version, maybe to 0.9.12. > Going > > > to 1.0 now does not seem like a good idea to me, because it would > involve > > > some overhead and my aim now is to get somebody else in the team > involved > > > in the next release and I want to keep it simple for him or her. > > > > > > I just posted the standard draft announcement, if anybody has > suggestions > > > on how to handle the npm version confusion there, please respond to > that > > > thread. > > > > > > Thanks. > > > > > > From: Piotr Zarzycki > > > Sent: Sunday, May 28, 2023 2:20 PM > > > To: dev@royale.apache.org > > > Cc: OmPrakash Muppirala > > > Subject: Re: [DISCUSS] Release Apache Royale 0.9.10 RC4 > > > > > > My suggestion is next release 1.0.0 finally and forgot about that minor > > > stuff. > > > > > > The other thing let’s have clear explanation in announcement. > > > > > > On Sun, 28 May 2023 at 11:52, Yishay Weiss > > wrote: > > > > > > > OTOH the release number is incorrect. I published it to 0.9.11 > > > > accidentally. I'm afraid I cannot change that to 0.9.10 because I > > > > accidentally published to 0.9.10 a year ago. The good news is that I > > have > > > > fixed the npm release script so this issue should not happen again. > The > > > bad > > > > news is that when we release 0.9.11 we won't be able to overwrite the > > > > current 0.9.11 version. > > > > > > > > Unpublishing 0.9.10 and 0.9.11 is not an option so long as @OmPrakash > > > > Muppirala<mailto:bigosma...@gmail.com> is listed as a maintainer and > > > does > > > > not explicitly approve. > > > > > > > > Not sure what to do here, so any suggestions are welcome. > > > > > > > > > > > > > > > > > > > > > > > > From: Josh Tynjala > > > > Sent: Thursday, May 25, 2023 8:31 PM > > > > To: dev@royale.apache.org > > > > Subject: Re: [DISCUSS] Release Apache Royale 0.9.10 RC4 > > > > > > > > In reference to the npm issue with the 0.9.9 release [1], I just > wanted > > > to > > > > mention that I've confirmed that the published npm packages are > > > > working correctly for this release. Yay! > > > > > > > > [1] https://lists.apache.org/thread/zclk7q1lowsv464797xl5wmxr2skj2ww > > > > > > > > -- > > > > Josh Tynjala > > > > Bowler Hat LLC <https://bowlerhat.dev> > > > > > > > > > > > > On Sat, May 13, 2023 at 10:37 AM Yishay Weiss < > yishayj...@hotmail.com> > > > > wrote: > > > > > > > > > This is the discussion thread. > > > > > > > > > > > > -- > > > > > > Piotr Zarzycki > > > > > -- > > > > Piotr Zarzycki > > >
Re: [DISCUSS] Release Apache Royale 0.9.10 RC4
I just updated the source code and downloads pages on the website to link to 0.9.10. In addition to Tour de Jewel, we'll need a 9.10.0 blog post. As with previous releases, it can simply be based on the changelogs. -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Sun, May 28, 2023 at 10:54 PM Piotr Zarzycki wrote: > I agree on a point where we need more people who can easily do a release. > Let’s have 2 more releases with someone else than you and discuss 1.0 than. > > In case of announcing I think it should happen once all release related > stuff is fully done. We need to update website and Tour de Jewel build > maybe. Do you know how to do that ? > > On Sun, 28 May 2023 at 14:31, Yishay Weiss wrote: > > > I think it's a good idea to bump the next version, maybe to 0.9.12. Going > > to 1.0 now does not seem like a good idea to me, because it would involve > > some overhead and my aim now is to get somebody else in the team involved > > in the next release and I want to keep it simple for him or her. > > > > I just posted the standard draft announcement, if anybody has suggestions > > on how to handle the npm version confusion there, please respond to that > > thread. > > > > Thanks. > > > > From: Piotr Zarzycki > > Sent: Sunday, May 28, 2023 2:20 PM > > To: dev@royale.apache.org > > Cc: OmPrakash Muppirala > > Subject: Re: [DISCUSS] Release Apache Royale 0.9.10 RC4 > > > > My suggestion is next release 1.0.0 finally and forgot about that minor > > stuff. > > > > The other thing let’s have clear explanation in announcement. > > > > On Sun, 28 May 2023 at 11:52, Yishay Weiss > wrote: > > > > > OTOH the release number is incorrect. I published it to 0.9.11 > > > accidentally. I'm afraid I cannot change that to 0.9.10 because I > > > accidentally published to 0.9.10 a year ago. The good news is that I > have > > > fixed the npm release script so this issue should not happen again. The > > bad > > > news is that when we release 0.9.11 we won't be able to overwrite the > > > current 0.9.11 version. > > > > > > Unpublishing 0.9.10 and 0.9.11 is not an option so long as @OmPrakash > > > Muppirala<mailto:bigosma...@gmail.com> is listed as a maintainer and > > does > > > not explicitly approve. > > > > > > Not sure what to do here, so any suggestions are welcome. > > > > > > > > > > > > > > > > > > From: Josh Tynjala > > > Sent: Thursday, May 25, 2023 8:31 PM > > > To: dev@royale.apache.org > > > Subject: Re: [DISCUSS] Release Apache Royale 0.9.10 RC4 > > > > > > In reference to the npm issue with the 0.9.9 release [1], I just wanted > > to > > > mention that I've confirmed that the published npm packages are > > > working correctly for this release. Yay! > > > > > > [1] https://lists.apache.org/thread/zclk7q1lowsv464797xl5wmxr2skj2ww > > > > > > -- > > > Josh Tynjala > > > Bowler Hat LLC <https://bowlerhat.dev> > > > > > > > > > On Sat, May 13, 2023 at 10:37 AM Yishay Weiss > > > wrote: > > > > > > > This is the discussion thread. > > > > > > > > > -- > > > > Piotr Zarzycki > > > -- > > Piotr Zarzycki >
Re: [DISCUSS] Release Apache Royale 0.9.10 RC4
In reference to the npm issue with the 0.9.9 release [1], I just wanted to mention that I've confirmed that the published npm packages are working correctly for this release. Yay! [1] https://lists.apache.org/thread/zclk7q1lowsv464797xl5wmxr2skj2ww -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Sat, May 13, 2023 at 10:37 AM Yishay Weiss wrote: > This is the discussion thread. >
Re: [DISCUSS] Release Apache Royale 0.9.10 RC4
You could try adding -e or -X to the mvn command args. That should make Maven display more details about errors. -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Mon, May 15, 2023 at 7:16 PM Maria Jose Esteve wrote: > I don't have mvn.exe in the /bin directory of Maven... but I tried it and > it didn't work. > I have restored mvn.cmd (this file does exist) in ApproveRoyale.xml > I modified my build bat and manually set MAVEN_HOME, in case the system > variable was getting lost, but the result was the same. > The last test was to put MAVEN_HOME in first position in the path, also, > same error. > > I have run out of ideas ☹ > > Hiedra > > -Mensaje original- > De: Josh Tynjala > Enviado el: lunes, 15 de mayo de 2023 23:20 > Para: dev@royale.apache.org > Asunto: Re: [DISCUSS] Release Apache Royale 0.9.10 RC4 > > It seems to be failing when running Maven, but it's not giving you an > error message to explain what the issue is. > > I see that you're on Windows. I wonder if you're having a similar issue > that I had on a previous release of the Royale build tools (I was on > Windows at the time, but I'm on macOS these days): > > https://lists.apache.org/thread/4fw80rsr87h79tofzsfs908plvfghvd4 > > In this case, a similar workaround would be to change mvn.cmd to mvn.exe > on line 72 of ApproveRoyale.xml > > > > > > -- > Josh Tynjala > Bowler Hat LLC <https://bowlerhat.dev> > > > On Mon, May 15, 2023 at 2:08 PM Maria Jose Esteve > wrote: > > > It has no longer included it as unapproved, but I still can't finish > > the Maven compilation, same problem but I don't know why, it's in the > > path. (I can compile the SDK normally with ant and with mvn and it > > hasn't given me any problems). > > any idea? > > --- > > main: > > > > build_maven: > > Path is C:\Program Files (x86)\Common > > Files\Oracle\Java\javapath;D:\Apache;C:\Program > > Files\Java\jdk1.8.0_281\bin;D:\Apache\apache-ant-1.10.13\bin;D:\Apache > > \apache-maven-3.9.1\bin;D:\app\client\hiedra\product\19.0.0\client_1\b > > in;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\ > > System32\WindowsPowerShell\v1.0\;C:\Windows\System32\OpenSSH\;C:\Progr > > am Files (x86)\NVIDIA Corporation\PhysX\Common;C:\Program > > Files\dotnet\;C:\Program > > Files\Git\cmd;C:\Users\hiedra\AppData\Local\Programs\Microsoft VS > > Code;C:\Program Files\Microsoft SQL Server\Client > > SDK\ODBC\170\Tools\Binn\;C:\Program > > Files\PowerShell\7-preview\preview;C:\Program Files > > (x86)\Yarn\bin\;D:\Apache\HaxeToolkit\haxe;D:\Apache\HaxeToolkit\neko; > > C:\Program Files\nodejs\;C:\Program Files (x86)\Intel\Intel(R) > > Management Engine Components\DAL;C:\Program Files\Intel\Intel(R) > > Management Engine Components\DAL;C:\Program Files (x86)\Pulse > > Secure\VC142.CRT\X64\;C:\Program Files (x86)\Pulse > > Secure\VC142.CRT\X86\;C:\Program Files\Microsoft SQL > > Server\150\Tools\Binn\;C:\Program Files\Microsoft SQL > > Server\130\Tools\Binn\;C:\Program Files > > (x86)\GnuPG\bin;C:\Users\hiedra\AppData\Local\Microsoft\WindowsApps;C: > > \Users\hiedra\AppData\Local\GitHubDesktop\bin;C:\Users\hiedra\.dotnet\ > > tools;C:\Users\hiedra\AppData\Local\Programs\Microsoft > > VS > > Code\bin;C:\Users\hiedra\AppData\Local\Yarn\bin;C:\Users\hiedra\AppDat > > a\Roaming\npm;C:\Program > > Files\Microsoft Office\root\Client > > > > BUILD FAILED > > D:\Develop_Royale\Projects\Royale-SDK\0.9.10\ApproveRoyale.xml:798: > > The following error occurred while executing this line: > > D:\Develop_Royale\Projects\Royale-SDK\0.9.10\ApproveRoyale.xml:811: > > exec > > returned: 1 > > > > Total time: 37 minutes 10 seconds > > > > -- > > -- > > > > Hiedra > > > > -Mensaje original- > > De: Josh Tynjala Enviado el: lunes, 15 de > > mayo de 2023 22:16 > > Para: dev@royale.apache.org > > Asunto: Re: [DISCUSS] Release Apache Royale 0.9.10 RC4 > > > > Yes, as I said, "You should be able to use it with this existing RC, > > if you'd like." > > > > -- > > Josh Tynjala > > Bowler Hat LLC <https://bowlerhat.dev> > > > > > > On Mon, May 15, 2023 at 1:15 PM Maria Jose Esteve > > wrote: > > > > > can I test this "ApproveRoyale.xml" with RC4 Josh? > > > Hiedra > > > > > > -Mensaje original- > > &
Re: [DISCUSS] Release Apache Royale 0.9.10 RC4
It seems to be failing when running Maven, but it's not giving you an error message to explain what the issue is. I see that you're on Windows. I wonder if you're having a similar issue that I had on a previous release of the Royale build tools (I was on Windows at the time, but I'm on macOS these days): https://lists.apache.org/thread/4fw80rsr87h79tofzsfs908plvfghvd4 In this case, a similar workaround would be to change mvn.cmd to mvn.exe on line 72 of ApproveRoyale.xml -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Mon, May 15, 2023 at 2:08 PM Maria Jose Esteve wrote: > It has no longer included it as unapproved, but I still can't finish the > Maven compilation, same problem but I don't know why, it's in the path. (I > can compile the SDK normally with ant and with mvn and it hasn't given me > any problems). > any idea? > --- > main: > > build_maven: > Path is C:\Program Files (x86)\Common > Files\Oracle\Java\javapath;D:\Apache;C:\Program > Files\Java\jdk1.8.0_281\bin;D:\Apache\apache-ant-1.10.13\bin;D:\Apache\apache-maven-3.9.1\bin;D:\app\client\hiedra\product\19.0.0\client_1\bin;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0\;C:\Windows\System32\OpenSSH\;C:\Program > Files (x86)\NVIDIA Corporation\PhysX\Common;C:\Program > Files\dotnet\;C:\Program > Files\Git\cmd;C:\Users\hiedra\AppData\Local\Programs\Microsoft VS > Code;C:\Program Files\Microsoft SQL Server\Client > SDK\ODBC\170\Tools\Binn\;C:\Program > Files\PowerShell\7-preview\preview;C:\Program Files > (x86)\Yarn\bin\;D:\Apache\HaxeToolkit\haxe;D:\Apache\HaxeToolkit\neko;C:\Program > Files\nodejs\;C:\Program Files (x86)\Intel\Intel(R) Management Engine > Components\DAL;C:\Program Files\Intel\Intel(R) Management Engine > Components\DAL;C:\Program Files (x86)\Pulse > Secure\VC142.CRT\X64\;C:\Program Files (x86)\Pulse > Secure\VC142.CRT\X86\;C:\Program Files\Microsoft SQL > Server\150\Tools\Binn\;C:\Program Files\Microsoft SQL > Server\130\Tools\Binn\;C:\Program Files > (x86)\GnuPG\bin;C:\Users\hiedra\AppData\Local\Microsoft\WindowsApps;C:\Users\hiedra\AppData\Local\GitHubDesktop\bin;C:\Users\hiedra\.dotnet\tools;C:\Users\hiedra\AppData\Local\Programs\Microsoft > VS > Code\bin;C:\Users\hiedra\AppData\Local\Yarn\bin;C:\Users\hiedra\AppData\Roaming\npm;C:\Program > Files\Microsoft Office\root\Client > > BUILD FAILED > D:\Develop_Royale\Projects\Royale-SDK\0.9.10\ApproveRoyale.xml:798: The > following error occurred while executing this line: > D:\Develop_Royale\Projects\Royale-SDK\0.9.10\ApproveRoyale.xml:811: exec > returned: 1 > > Total time: 37 minutes 10 seconds > > -------- > > Hiedra > > -Mensaje original- > De: Josh Tynjala > Enviado el: lunes, 15 de mayo de 2023 22:16 > Para: dev@royale.apache.org > Asunto: Re: [DISCUSS] Release Apache Royale 0.9.10 RC4 > > Yes, as I said, "You should be able to use it with this existing RC, if > you'd like." > > -- > Josh Tynjala > Bowler Hat LLC <https://bowlerhat.dev> > > > On Mon, May 15, 2023 at 1:15 PM Maria Jose Esteve > wrote: > > > can I test this "ApproveRoyale.xml" with RC4 Josh? > > Hiedra > > > > -Mensaje original- > > De: Josh Tynjala Enviado el: lunes, 15 de > > mayo de 2023 20:04 > > Para: dev@royale.apache.org > > Asunto: Re: [DISCUSS] Release Apache Royale 0.9.10 RC4 > > > > That being said, I have updated the approval script in the royale-asjs > > Git repo. You should be able to use it with this existing RC, if you'd > like. > > > > https://github.com/apache/royale-asjs/blob/develop/ApproveRoyale.xml > > > > -- > > Josh Tynjala > > Bowler Hat LLC <https://bowlerhat.dev> > > > > > > On Mon, May 15, 2023 at 9:35 AM Josh Tynjala > > > > wrote: > > > > > Now that I've had my morning tea, I remember now that I put > > > RoyaleUnit's dependencies into a separate directory so that they > > > don't conflict with anything else (and so that they aren't loaded by > > > the compiler when they aren't needed). I didn't know that I needed > > > to update ApproveRoyale.xml. I will get that fixed for *future* > releases. > > > > > > For now, this is just a minor issue, and it should not prevent you > > > from voting in favor of this RC. The license is actually allowed, > > > but > > "Rat" > > > incorrectly flags it. The approval script will not fail when it > > > mentions this license, so we don't need
Re: [DISCUSS] Release Apache Royale 0.9.10 RC4
Based on some further investigation, it looks like the Royale compiler knows how to implement the JS IEventDispatcher API in generated .js files only. When those .js files are included in a SWC file, the binary part of the SWC file that is used for type checking and IDE support will always be generated with the SWF IEventDispatcher API. That's where the conflict comes from. This does not appear to me to be a regression, but how it has always worked. We may want to provide a way to generate both APIs in SWC binary code, but I would say that's for a future release. In Royale framework code, it looks like there are two ways to manually handle bindable beads. 1) Extend DispatcherBead. It looks like a lot of bead classes do this. 2) Manually implement IEventDispatcher, with the different signatures conditionally compiled with COMPILE::SWF and COMPILE::JS. This is much less common, but it is used in a couple of places. In both cases, the compiler won't generate any IEventDispatcher code for bindable properties because the beads will already be event dispatchers. The first option is most common, but not always possible when another is superclass already being used. The second option where the interface is manually implemented happens in these two bead: a) In Jewel, a manual IEventDispatcher implementation is used in ArrayListSelectionModel. b) In Spark, a manual implementation is used in LayoutBase. In the case of Jewel's TileHorizontalLayout, if you wanted to avoid manually implementing IEventDispatcher, the Core version of LayoutBase would need to extend DispatcherBead. However, I don't think this would be considered PAYG, which Core is expected to follow more strictly than Jewel, so there's no way to use DispatcherBead with Jewel's TileHorizontalLayout. TileHorizontalLayout probably needs a manual implementation of IEventDispatcher. Or possibly SimpleHorizontalLayout or StyledLayoutBase instead, depending on how strict you want to be with PAYG in Jewel. For the least impact and most PAYG, you should manually implement IEventDispatcher directly on TileHorizontalLayout. (In my opinion, this is not a release blocker. I'm just letting you know what I found in my investigation, and my advice for fixing it.) -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Mon, May 15, 2023 at 1:13 PM Josh Tynjala wrote: > > Does anyone have any idea what has happened here ? Why > TileHorizontalLayout > > after compilation to TileHorizontalLayout.js have all of these methods ? > > TileHorizontallayout has [Bindable] metadata on some properties. If > anything in a class is marked as [Bindable], and that class (or a > superclass) does not already extend EventDispatcher (or implement > IEventDispatcher), the compiler will automatically generate an > implementation of IEventDispatcher. This is true in Royale, and it was also > true in Flex. > > Here are the classes that TileHorizontalLayout is a subclass of: > TileHorizontalLayout extends SimpleHorizontalLayout extends > StyledLayoutBase extends LayoutBase extends Bead > > There are also the following interfaces in the type hierarchy: > ILayoutStyleProperties, IBeadLayout, IBead > > Nowhere in this chain of classes is there an EventDispatcher or > IEventDispatcher. So the compiler is generating its own implementation of > IEventDispatcher. > > Unfortunately, it seems to be generating an implementation of the methods > from the SWF version of IEventDispatcher instead of the methods from the JS > version of IEventDispatcher. I don't believe that I have worked with the > part of the Royale compiler that generates code for bindable > classes/properties before, so I don't know why it would be doing that. > However, that seems like a bug. Maybe not necessarily in the compiler. It > could be that the compiler options used by the JewelJS build are wrong. > > Note: I don't think that the compiler is incorrectly using the Spark > version of LayoutBase instead of the Core version of LayoutBase. This can > be explained without the Spark version of LayoutBase being involved in any > way. > > -- > Josh Tynjala > Bowler Hat LLC <https://bowlerhat.dev> > > > On Mon, May 15, 2023 at 5:14 AM Piotr Zarzycki > wrote: > >> Hi Guys, >> >> I have voted +1, but I have found one issue which concerns me a little >> bit. >> I have need of usage in my application >> -> org.apache.royale.jewel.beads.layouts.TileHorizontalLayout. I have made >> my own custom class which extends that one. To my big surprise I got >> following compilation error: >> >> Error: interface method addEventListener in interface IEventDispatcher is >> implemented with an incompatible signature in class >> ExtendedTileHorizontalLayout >> : Error: interface method removeEventListener in int
Re: [VOTE] Release Apache Royale 0.9.10 RC4
+1 Package https://dist.apache.org/repos/dist/dev/royale/0.9.10/rc4/apache-royale-0.9.10-src.tar.gz Java 17 OS: Mac OS X aarch64 13.3.1 Source kit signatures match: y Source kit builds: y README is ok: y RELEASE_NOTES is ok: y NOTICE is ok: y LICENSE is ok: y No unapproved licenses or archives: y No unapproved binaries: y Package https://dist.apache.org/repos/dist/dev/royale/0.9.10/rc4/binaries/apache-royale-0.9.10-bin-js-swf.tar.gz Binary kit signatures match: y NOTICE is ok: y LICENSE is ok: y No unapproved licenses or archives in binary package: y No unapproved binaries in binary package: y Additional notes: 1) ApproveRoyale.xml works with both JS/SWF and JS-only packages on my machine. 2) I confirmed that both of the binary packages may be installed successfully with npm. 3) I can successfully build the asconfigc tool with all RoyaleUnit tests passing, and I can use it to build projects that have asconfig.json files. 4) SWF tests were run with Flash Player 32 and AIR 32. -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Sat, May 13, 2023 at 10:35 AM Yishay Weiss wrote: > Hi, > This is the vote for the 0.9.10 release of Apache Royale. The release > candidate can be found here; > https://dist.apache.org/repos/dist/dev/royale/0.9.10/rc4/ > > Before voting please review the section,'What are the ASF requirements on > approving a release?', at: > http://www.apache.org/dev/release.html#approving-a-release > > At a minimum you would be expected to check that: > - SHA and signed packages are correct > - README, RELEASE_NOTES, NOTICE and LICENSE files are all fine > - That the build script completes successfully > - That you can compile and crosscompile a simple example using the SDK. > > The KEYS file is at https://dist.apache.org/repos/dist/release/royale/KEYS > > The source package is a combination of the 3 main Royale repos. > > To use the binary package, unzip it into a folder. The -js package is > ready-to-use in an IDE or command-line. If you need SWF output, use the > -js-swf package and use Apache Ant to run the InstallAdobeSDKs script via: > ant -f InstallAdobeSDKs.xml > > You may also get the binarypackages via NPM. The -js package can be > installed via: > npm install > https://dist.apache.org/repos/dist/dev/royale/0.9.10/rc4/binaries/apache-royale-0.9.10-bin-js.tar.gz > > The full package with SWF support can be installed via: > > npm install > https://dist.apache.org/repos/dist/dev/royale/0.9.10/rc4/binaries/apache-royale-0.9.10-bin-js-swf.tar.gz > > Maven artifacts are staged here: > https://repository.apache.org/content/repositories/orgapacheroyale-1096 > > Please vote to approve this release: > +1 Approve the release > -1 Disapprove the release (please provide specific comments to why) > > This vote will be open for 72 hours or until a result can be called. > > The vote passes if there is: > - At least 3 +1 votes from the PMC > - More positive votes than negative votes > > Remember that this is a 'beta-quality' release so expect there will be > many bugs found. IMO the goal is not to try to find and fix bugs in the RC, > but to make sure we have the packaging right, and enough functionality that > folks will have some success trying to use it. People who are not in PMC > are also encouraged to test out the release and vote, although their votes > will not be binding, they can influence how the PMC votes. > > When voting please indicate what OS, IDE, Flash Player version and AIR > version you tested with. > > For your convenience, there is an ant script that automates the common > steps to validate a release. Instead of individually downloading the > package and signature files, unzipping, etc, you can instead: > 1) create an empty folder, > 2) download into that folder this file: > https://dist.apache.org/repos/dist/dev/royale/0.9.10/rc4/ApproveRoyale.xml > 3) run the script: >ant -e -f ApproveRoyale.xml -Drelease.version=0.9.10 -Drc=4 >If you want to test SWF support during the approval, use: >ant -e -f ApproveRoyale.xml -Drelease.version=0.9.10 -Drc=4 > -Duse-flash=true > > You are not required to use this script, and more testing of the packages > and build results are always encouraged. > > Please put all discussion about this release in the DISCUSSION thread not > this VOTE thread. > > Thanks, > Yishay Weiss > >
Re: [DISCUSS] Release Apache Royale 0.9.10 RC4
Yes, as I said, "You should be able to use it with this existing RC, if you'd like." -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Mon, May 15, 2023 at 1:15 PM Maria Jose Esteve wrote: > can I test this "ApproveRoyale.xml" with RC4 Josh? > Hiedra > > -Mensaje original- > De: Josh Tynjala > Enviado el: lunes, 15 de mayo de 2023 20:04 > Para: dev@royale.apache.org > Asunto: Re: [DISCUSS] Release Apache Royale 0.9.10 RC4 > > That being said, I have updated the approval script in the royale-asjs Git > repo. You should be able to use it with this existing RC, if you'd like. > > https://github.com/apache/royale-asjs/blob/develop/ApproveRoyale.xml > > -- > Josh Tynjala > Bowler Hat LLC <https://bowlerhat.dev> > > > On Mon, May 15, 2023 at 9:35 AM Josh Tynjala > wrote: > > > Now that I've had my morning tea, I remember now that I put > > RoyaleUnit's dependencies into a separate directory so that they don't > > conflict with anything else (and so that they aren't loaded by the > > compiler when they aren't needed). I didn't know that I needed to > > update ApproveRoyale.xml. I will get that fixed for *future* releases. > > > > For now, this is just a minor issue, and it should not prevent you > > from voting in favor of this RC. The license is actually allowed, but > "Rat" > > incorrectly flags it. The approval script will not fail when it > > mentions this license, so we don't need to do anything to fix it > > immediately. > > > > -- > > Josh Tynjala > > Bowler Hat LLC <https://bowlerhat.dev> > > > > > > On Mon, May 15, 2023 at 8:55 AM Josh Tynjala > > > > wrote: > > > >> The approval script excludes dom4j-LICENSE.txt at the following > location: > >> > >> > >> > >> But your path is slightly different: > >> > >> royale-asjs/js/lib/royaleunit/dom4j-LICENSE.txt > >> > >> I think we can just make a minor tweak to the approval script to add > >> this path too: > >> > >> > >> > >> -- > >> Josh Tynjala > >> Bowler Hat LLC <https://bowlerhat.dev> > >> > >> > >> On Sat, May 13, 2023 at 6:29 PM Maria Jose Esteve > >> wrote: > >> > >>> Hi, > >>> I keep testing the automated compilation option [1] the compilation > >>> gave me error ☹. > >>> I have left the log of the compilation here [2] but I attach the error: > >>> > >>> <<<<<<< > >>> ... > >>> main: > >>> Copying 1 file to > >>> > D:\Develop_Royale\Projects\Royale-SDK\0.9.10\apache-royale-0.9.10-src\royale-asjs\examples\native\USStatesMap\bin\js-debug > >>> Copying 1 file to > >>> D:\Develop_Royale\Projects\Royale-SDK\0.9.10\apache-royale-0.9.10-sr > >>> c\royale-asjs\examples\native\USStatesMap\bin\js-release > >>> > >>> main: > >>> > >>> build_maven: > >>> Path is C:\Program Files (x86)\Common > >>> Files\Oracle\Java\javapath;D:\Apache;C:\Program > >>> Files\Java\jdk1.8.0_281\bin;D:\Apache\apache-ant-1.10.13\bin;D:\Apac > >>> he\apache-maven-3.9.1\bin;D:\app\client\hiedra\product\19.0.0\client > >>> _1\bin;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Wi > >>> ndows\System32\WindowsPowerShell\v1.0\;C:\Windows\System32\OpenSSH\; > >>> C:\Program Files (x86)\NVIDIA Corporation\PhysX\Common;C:\Program > >>> Files\dotnet\;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbe > >>> m;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\WINDOWS\System32\Op > >>> enSSH\;C:\Program > >>> Files\Git\cmd;C:\Users\hiedra\AppData\Local\Programs\Microsoft VS > >>> Code;C:\Program Files\Microsoft SQL Server\Client > >>> SDK\ODBC\170\Tools\Binn\;C:\Program > >>> Files\PowerShell\7-preview\preview;C:\Program Files > >>> (x86)\Yarn\bin\;D:\Apache\HaxeToolkit\haxe;D:\Apache\HaxeToolkit\nek > >>> o;C:\Program Files\nodejs\;C:\Program Files (x86)\Intel\Intel(R) > >>> Management Engine Components\DAL;C:\Program Files\Intel\Intel(R) > >>> Management Engine Components\DAL;C:\Program Files (x86)\Pulse > >>> Secure\VC142.CRT\X64\;C:\Program Files (x86)\Pulse > >>> Secure\VC142.CRT\X86\;C:\Program Files\Microsoft SQL > >>> Server\150\Tools\Binn\;C:\Program F
Re: [DISCUSS] Release Apache Royale 0.9.10 RC4
> Does anyone have any idea what has happened here ? Why TileHorizontalLayout > after compilation to TileHorizontalLayout.js have all of these methods ? TileHorizontallayout has [Bindable] metadata on some properties. If anything in a class is marked as [Bindable], and that class (or a superclass) does not already extend EventDispatcher (or implement IEventDispatcher), the compiler will automatically generate an implementation of IEventDispatcher. This is true in Royale, and it was also true in Flex. Here are the classes that TileHorizontalLayout is a subclass of: TileHorizontalLayout extends SimpleHorizontalLayout extends StyledLayoutBase extends LayoutBase extends Bead There are also the following interfaces in the type hierarchy: ILayoutStyleProperties, IBeadLayout, IBead Nowhere in this chain of classes is there an EventDispatcher or IEventDispatcher. So the compiler is generating its own implementation of IEventDispatcher. Unfortunately, it seems to be generating an implementation of the methods from the SWF version of IEventDispatcher instead of the methods from the JS version of IEventDispatcher. I don't believe that I have worked with the part of the Royale compiler that generates code for bindable classes/properties before, so I don't know why it would be doing that. However, that seems like a bug. Maybe not necessarily in the compiler. It could be that the compiler options used by the JewelJS build are wrong. Note: I don't think that the compiler is incorrectly using the Spark version of LayoutBase instead of the Core version of LayoutBase. This can be explained without the Spark version of LayoutBase being involved in any way. -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Mon, May 15, 2023 at 5:14 AM Piotr Zarzycki wrote: > Hi Guys, > > I have voted +1, but I have found one issue which concerns me a little bit. > I have need of usage in my application > -> org.apache.royale.jewel.beads.layouts.TileHorizontalLayout. I have made > my own custom class which extends that one. To my big surprise I got > following compilation error: > > Error: interface method addEventListener in interface IEventDispatcher is > implemented with an incompatible signature in class > ExtendedTileHorizontalLayout > : Error: interface method removeEventListener in interface IEventDispatcher > is implemented with an incompatible signature in class > ExtendedTileHorizontalLayout > : Error: interface method dispatchEvent in interface IEventDispatcher is > implemented with an incompatible signature in class > ExtendedTileHorizontalLayout > > I have looked into TileHorizontalLayout in Moonshine and I see there > signature methods -> https://prnt.sc/crcNcuFHgu-8 > > Look int signatures dispatchEvent, hasEventListener, removeEventListener > and addEventListener - they are all missing fields name. This is definitely > wrong, but I think all of these methods shouldn't even exists in > frameworks/js/libs/JewelJS.swc -> TileHorizontalLayout. > > TileHorizontalLayout extends several classes, one of them > is org.apache.royale.core.LayoutBase - non of these classes have anywhere > inside methods dispatchEvent, hasEventListener etc. However there is > another class in completely different > package spark.layouts.supportClasses.LayoutBase - that one have these > methods implemented exactly in the same way as my TileHorizontalLayout.js > have. > > Does anyone have any idea what has happened here ? Why TileHorizontalLayout > after compilation to TileHorizontalLayout.js have all of these methods ? > > Thanks, > Piotr > > > niedz., 14 maj 2023 o 03:29 Maria Jose Esteve > napisał(a): > > > Hi, > > I keep testing the automated compilation option [1] the compilation gave > > me error ☹. > > I have left the log of the compilation here [2] but I attach the error: > > > > <<<<<<< > > ... > > main: > > Copying 1 file to > > > D:\Develop_Royale\Projects\Royale-SDK\0.9.10\apache-royale-0.9.10-src\royale-asjs\examples\native\USStatesMap\bin\js-debug > > Copying 1 file to > > > D:\Develop_Royale\Projects\Royale-SDK\0.9.10\apache-royale-0.9.10-src\royale-asjs\examples\native\USStatesMap\bin\js-release > > > > main: > > > > build_maven: > > Path is C:\Program Files (x86)\Common > > Files\Oracle\Java\javapath;D:\Apache;C:\Program > > > Files\Java\jdk1.8.0_281\bin;D:\Apache\apache-ant-1.10.13\bin;D:\Apache\apache-maven-3.9.1\bin;D:\app\client\hiedra\product\19.0.0\client_1\bin;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0\;C:\Windows\System32\OpenSSH\;C:\Program > > Files (x86)\NVIDIA Corporation\PhysX\Common;C:\Program > > &
Re: [DISCUSS] Release Apache Royale 0.9.10 RC4
That being said, I have updated the approval script in the royale-asjs Git repo. You should be able to use it with this existing RC, if you'd like. https://github.com/apache/royale-asjs/blob/develop/ApproveRoyale.xml -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Mon, May 15, 2023 at 9:35 AM Josh Tynjala wrote: > Now that I've had my morning tea, I remember now that I put > RoyaleUnit's dependencies into a separate directory so that they don't > conflict with anything else (and so that they aren't loaded by the compiler > when they aren't needed). I didn't know that I needed to update > ApproveRoyale.xml. I will get that fixed for *future* releases. > > For now, this is just a minor issue, and it should not prevent you from > voting in favor of this RC. The license is actually allowed, but "Rat" > incorrectly flags it. The approval script will not fail when it > mentions this license, so we don't need to do anything to fix it > immediately. > > -- > Josh Tynjala > Bowler Hat LLC <https://bowlerhat.dev> > > > On Mon, May 15, 2023 at 8:55 AM Josh Tynjala > wrote: > >> The approval script excludes dom4j-LICENSE.txt at the following location: >> >> >> >> But your path is slightly different: >> >> royale-asjs/js/lib/royaleunit/dom4j-LICENSE.txt >> >> I think we can just make a minor tweak to the approval script to add this >> path too: >> >> >> >> -- >> Josh Tynjala >> Bowler Hat LLC <https://bowlerhat.dev> >> >> >> On Sat, May 13, 2023 at 6:29 PM Maria Jose Esteve >> wrote: >> >>> Hi, >>> I keep testing the automated compilation option [1] the compilation gave >>> me error ☹. >>> I have left the log of the compilation here [2] but I attach the error: >>> >>> <<<<<<< >>> ... >>> main: >>> Copying 1 file to >>> D:\Develop_Royale\Projects\Royale-SDK\0.9.10\apache-royale-0.9.10-src\royale-asjs\examples\native\USStatesMap\bin\js-debug >>> Copying 1 file to >>> D:\Develop_Royale\Projects\Royale-SDK\0.9.10\apache-royale-0.9.10-src\royale-asjs\examples\native\USStatesMap\bin\js-release >>> >>> main: >>> >>> build_maven: >>> Path is C:\Program Files (x86)\Common >>> Files\Oracle\Java\javapath;D:\Apache;C:\Program >>> Files\Java\jdk1.8.0_281\bin;D:\Apache\apache-ant-1.10.13\bin;D:\Apache\apache-maven-3.9.1\bin;D:\app\client\hiedra\product\19.0.0\client_1\bin;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0\;C:\Windows\System32\OpenSSH\;C:\Program >>> Files (x86)\NVIDIA Corporation\PhysX\Common;C:\Program >>> Files\dotnet\;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\WINDOWS\System32\OpenSSH\;C:\Program >>> Files\Git\cmd;C:\Users\hiedra\AppData\Local\Programs\Microsoft VS >>> Code;C:\Program Files\Microsoft SQL Server\Client >>> SDK\ODBC\170\Tools\Binn\;C:\Program >>> Files\PowerShell\7-preview\preview;C:\Program Files >>> (x86)\Yarn\bin\;D:\Apache\HaxeToolkit\haxe;D:\Apache\HaxeToolkit\neko;C:\Program >>> Files\nodejs\;C:\Program Files (x86)\Intel\Intel(R) Management Engine >>> Components\DAL;C:\Program Files\Intel\Intel(R) Management Engine >>> Components\DAL;C:\Program Files (x86)\Pulse >>> Secure\VC142.CRT\X64\;C:\Program Files (x86)\Pulse >>> Secure\VC142.CRT\X86\;C:\Program Files\Microsoft SQL >>> Server\150\Tools\Binn\;C:\Program Files\Microsoft SQL >>> Server\130\Tools\Binn\;C:\Program Files >>> (x86)\GnuPG\bin;C:\Users\hiedra\AppData\Local\Microsoft\WindowsApps;C:\Users\hiedra\AppData\Local\GitHubDesktop\bin;C:\Users\hiedra\.dotnet\tools;C:\Users\hiedra\AppData\Local\Microsoft\WindowsApps;C:\Users\hiedra\AppData\Local\Programs\Microsoft >>> VS >>> Code\bin;C:\Users\hiedra\AppData\Local\Yarn\bin;C:\Users\hiedra\AppData\Roaming\npm >>> >>> BUILD FAILED >>> >>> D:\Develop_Royale\Projects\Royale-SDK\0.9.10\ApproveRoyale.xml:796: The >>> following error occurred while executing this line: >>> >>> D:\Develop_Royale\Projects\Royale-SDK\0.9.10\ApproveRoyale.xml:809: exec >>> returned: 1 >>> >>> Total time: 39 minutes 52 seconds >>> >>>>>>> >>> >>> The error occurs in the Maven compilation task (it's in the path, could >>> it be because of the maven version?): >>> >>> >>>>>>> >>> ... >
Re: [DISCUSS] Release Apache Royale 0.9.10 RC4
Now that I've had my morning tea, I remember now that I put
RoyaleUnit's dependencies into a separate directory so that they don't
conflict with anything else (and so that they aren't loaded by the compiler
when they aren't needed). I didn't know that I needed to update
ApproveRoyale.xml. I will get that fixed for *future* releases.
For now, this is just a minor issue, and it should not prevent you from
voting in favor of this RC. The license is actually allowed, but "Rat"
incorrectly flags it. The approval script will not fail when it
mentions this license, so we don't need to do anything to fix it
immediately.
--
Josh Tynjala
Bowler Hat LLC <https://bowlerhat.dev>
On Mon, May 15, 2023 at 8:55 AM Josh Tynjala
wrote:
> The approval script excludes dom4j-LICENSE.txt at the following location:
>
>
>
> But your path is slightly different:
>
> royale-asjs/js/lib/royaleunit/dom4j-LICENSE.txt
>
> I think we can just make a minor tweak to the approval script to add this
> path too:
>
>
>
> --
> Josh Tynjala
> Bowler Hat LLC <https://bowlerhat.dev>
>
>
> On Sat, May 13, 2023 at 6:29 PM Maria Jose Esteve
> wrote:
>
>> Hi,
>> I keep testing the automated compilation option [1] the compilation gave
>> me error ☹.
>> I have left the log of the compilation here [2] but I attach the error:
>>
>> <<<<<<<
>> ...
>> main:
>> Copying 1 file to
>> D:\Develop_Royale\Projects\Royale-SDK\0.9.10\apache-royale-0.9.10-src\royale-asjs\examples\native\USStatesMap\bin\js-debug
>> Copying 1 file to
>> D:\Develop_Royale\Projects\Royale-SDK\0.9.10\apache-royale-0.9.10-src\royale-asjs\examples\native\USStatesMap\bin\js-release
>>
>> main:
>>
>> build_maven:
>> Path is C:\Program Files (x86)\Common
>> Files\Oracle\Java\javapath;D:\Apache;C:\Program
>> Files\Java\jdk1.8.0_281\bin;D:\Apache\apache-ant-1.10.13\bin;D:\Apache\apache-maven-3.9.1\bin;D:\app\client\hiedra\product\19.0.0\client_1\bin;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0\;C:\Windows\System32\OpenSSH\;C:\Program
>> Files (x86)\NVIDIA Corporation\PhysX\Common;C:\Program
>> Files\dotnet\;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\WINDOWS\System32\OpenSSH\;C:\Program
>> Files\Git\cmd;C:\Users\hiedra\AppData\Local\Programs\Microsoft VS
>> Code;C:\Program Files\Microsoft SQL Server\Client
>> SDK\ODBC\170\Tools\Binn\;C:\Program
>> Files\PowerShell\7-preview\preview;C:\Program Files
>> (x86)\Yarn\bin\;D:\Apache\HaxeToolkit\haxe;D:\Apache\HaxeToolkit\neko;C:\Program
>> Files\nodejs\;C:\Program Files (x86)\Intel\Intel(R) Management Engine
>> Components\DAL;C:\Program Files\Intel\Intel(R) Management Engine
>> Components\DAL;C:\Program Files (x86)\Pulse
>> Secure\VC142.CRT\X64\;C:\Program Files (x86)\Pulse
>> Secure\VC142.CRT\X86\;C:\Program Files\Microsoft SQL
>> Server\150\Tools\Binn\;C:\Program Files\Microsoft SQL
>> Server\130\Tools\Binn\;C:\Program Files
>> (x86)\GnuPG\bin;C:\Users\hiedra\AppData\Local\Microsoft\WindowsApps;C:\Users\hiedra\AppData\Local\GitHubDesktop\bin;C:\Users\hiedra\.dotnet\tools;C:\Users\hiedra\AppData\Local\Microsoft\WindowsApps;C:\Users\hiedra\AppData\Local\Programs\Microsoft
>> VS
>> Code\bin;C:\Users\hiedra\AppData\Local\Yarn\bin;C:\Users\hiedra\AppData\Roaming\npm
>>
>> BUILD FAILED
>>
>> D:\Develop_Royale\Projects\Royale-SDK\0.9.10\ApproveRoyale.xml:796: The
>> following error occurred while executing this line:
>>
>> D:\Develop_Royale\Projects\Royale-SDK\0.9.10\ApproveRoyale.xml:809: exec
>> returned: 1
>>
>> Total time: 39 minutes 52 seconds
>> >>>>>>>
>>
>> The error occurs in the Maven compilation task (it's in the path, could
>> it be because of the maven version?):
>>
>> >>>>>>>
>> ...
>>
>> > value="-Poption-with-swf"
>> else="-Ddummy=true">
>>
>>
>> > value="-Pwith-examples,with-distribution,option-with-swf"
>> else="-Pwith-examples,with-distribution">
>>
>>
>> Path is ${env.Path}
>>
>> -- >>>> inputstring="Yes">
>>
>>
>>
>>
>>
>>
>>
>>
>> > inputstring="Yes">
>>
>
Re: [DISCUSS] Release Apache Royale 0.9.10 RC4
The approval script excludes dom4j-LICENSE.txt at the following location:
But your path is slightly different:
royale-asjs/js/lib/royaleunit/dom4j-LICENSE.txt
I think we can just make a minor tweak to the approval script to add this
path too:
--
Josh Tynjala
Bowler Hat LLC <https://bowlerhat.dev>
On Sat, May 13, 2023 at 6:29 PM Maria Jose Esteve wrote:
> Hi,
> I keep testing the automated compilation option [1] the compilation gave
> me error ☹.
> I have left the log of the compilation here [2] but I attach the error:
>
> <<<<<<<
> ...
> main:
> Copying 1 file to
> D:\Develop_Royale\Projects\Royale-SDK\0.9.10\apache-royale-0.9.10-src\royale-asjs\examples\native\USStatesMap\bin\js-debug
> Copying 1 file to
> D:\Develop_Royale\Projects\Royale-SDK\0.9.10\apache-royale-0.9.10-src\royale-asjs\examples\native\USStatesMap\bin\js-release
>
> main:
>
> build_maven:
> Path is C:\Program Files (x86)\Common
> Files\Oracle\Java\javapath;D:\Apache;C:\Program
> Files\Java\jdk1.8.0_281\bin;D:\Apache\apache-ant-1.10.13\bin;D:\Apache\apache-maven-3.9.1\bin;D:\app\client\hiedra\product\19.0.0\client_1\bin;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0\;C:\Windows\System32\OpenSSH\;C:\Program
> Files (x86)\NVIDIA Corporation\PhysX\Common;C:\Program
> Files\dotnet\;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\WINDOWS\System32\OpenSSH\;C:\Program
> Files\Git\cmd;C:\Users\hiedra\AppData\Local\Programs\Microsoft VS
> Code;C:\Program Files\Microsoft SQL Server\Client
> SDK\ODBC\170\Tools\Binn\;C:\Program
> Files\PowerShell\7-preview\preview;C:\Program Files
> (x86)\Yarn\bin\;D:\Apache\HaxeToolkit\haxe;D:\Apache\HaxeToolkit\neko;C:\Program
> Files\nodejs\;C:\Program Files (x86)\Intel\Intel(R) Management Engine
> Components\DAL;C:\Program Files\Intel\Intel(R) Management Engine
> Components\DAL;C:\Program Files (x86)\Pulse
> Secure\VC142.CRT\X64\;C:\Program Files (x86)\Pulse
> Secure\VC142.CRT\X86\;C:\Program Files\Microsoft SQL
> Server\150\Tools\Binn\;C:\Program Files\Microsoft SQL
> Server\130\Tools\Binn\;C:\Program Files
> (x86)\GnuPG\bin;C:\Users\hiedra\AppData\Local\Microsoft\WindowsApps;C:\Users\hiedra\AppData\Local\GitHubDesktop\bin;C:\Users\hiedra\.dotnet\tools;C:\Users\hiedra\AppData\Local\Microsoft\WindowsApps;C:\Users\hiedra\AppData\Local\Programs\Microsoft
> VS
> Code\bin;C:\Users\hiedra\AppData\Local\Yarn\bin;C:\Users\hiedra\AppData\Roaming\npm
>
> BUILD FAILED
>
> D:\Develop_Royale\Projects\Royale-SDK\0.9.10\ApproveRoyale.xml:796: The
> following error occurred while executing this line:
>
> D:\Develop_Royale\Projects\Royale-SDK\0.9.10\ApproveRoyale.xml:809: exec
> returned: 1
>
> Total time: 39 minutes 52 seconds
> >>>>>>>
>
> The error occurs in the Maven compilation task (it's in the path, could it
> be because of the maven version?):
>
> >>>>>>>
> ...
>
> value="-Poption-with-swf"
> else="-Ddummy=true">
>
>
> value="-Pwith-examples,with-distribution,option-with-swf"
> else="-Pwith-examples,with-distribution">
>
>
> Path is ${env.Path}
>
> -- >>> inputstring="Yes">
>
>
>
>
> dir="${basedir}/${maven.package.url.name}/royale-typedefs"
> failonerror="true" >
>
>
>
> dir="${basedir}/${maven.package.url.name}/royale-asjs"
> failonerror="true" inputstring="Yes">
>
>
>
>
>
> ...
> <<<<<<<
>
> I have a question about licenses... Yishay has no anomalies in this regard
> but I have an unapproved license:
> Unapproved licenses:
>
>
> D:/Develop_Royale/Projects/Royale-SDK/0.9.10/apache-royale-0.9.10-bin-js-swf/royale-asjs/js/lib/royaleunit/dom4j-LICENSE.txt
> How can I fix it?
>
> [1]
> https://dist.apache.org/repos/dist/dev/royale/0.9.10/rc4/ApproveRoyale.xml
> y ejecutando el script:
>ant -e -f ApproveRoyale.xml -Drelease.version=0.9.10 -Drc=4
> [2]
> https://drive.google.com/file/d/1jCgS51cgtRSSuh11UJUxzdEaburpDdpF/view?usp=share_link
>
> Hiedra
>
> -Mensaje original-
> De: Yishay Weiss
> Enviado el: sábado, 13 de mayo de 2023 19:36
> Para: dev@royale.apache.org
> Asunto: [DISCUSS] Release Apache Royale 0.9.10 RC4
>
> This is the discussion thread.
>
Re: [DISCUSS] Release Apache Royale 0.9.10 RC3
On my machine, I can answer "n" to download the designmodo fonts, and the
build continues (failing at the same TourDeJewel example as when I answer
"y" instead).
--
Josh Tynjala
Bowler Hat LLC <https://bowlerhat.dev>
On Wed, May 10, 2023 at 11:48 AM Yishay Weiss
wrote:
> The reason I thought it was not a blocker was because I assumed the ant
> script for TDJ had never been functional. I can see now that there was
> likely regression due to e71b1485cce885f84cda7d7883750eebeec38b3d which was
> one day after our prior release. I am not sure why my TDJ test was
> successful before my latest commit. Maybe the themes had been built
> previously or I was running it from a different directory. Anyway, I'll try
> to fix that. Thanks for the input, Josh and Piotr.
>
> I do think we should consider whether this type of regression necessarily
> implies no release. What do other folks think?
>
> Has anybody confirmed Maria's issues with designmodo fonts being
> obligatory?
>
> From: Josh Tynjala
> Sent: Wednesday, May 10, 2023 7:17 PM
> To: dev@royale.apache.org
> Subject: Re: [DISCUSS] Release Apache Royale 0.9.10 RC3
>
> I'm getting the same failure when running the approval script. I won't be
> able to vote +1 for this RC.
>
> Since the themes are incorrectly building with TourDeJewel as the basedir,
> I'm guessing that the theme targets in TourDeJewel/build.xml need the dir
> attribute specified in the element:
>
> Before:
>
>
> antfile="${basedir}/../../../frameworks/themes/Jewel-Dark-NoFlat-Emphasized-Amethyst-Theme/build.xml"/>
>
> After:
>
> dir="${basedir}/../../../frameworks/themes/Jewel-Dark-NoFlat-Emphasized-Amethyst-Theme"
>
> antfile="${basedir}/../../../frameworks/themes/Jewel-Dark-NoFlat-Emphasized-Amethyst-Theme/build.xml"/>
>
> Be sure to test it, though. That's just a guess.
>
> --
> Josh Tynjala
> Bowler Hat LLC <https://bowlerhat.dev>
>
>
> On Wed, May 10, 2023 at 3:09 AM Yishay Weiss
> wrote:
>
> > Looks like TDJ ant build is still failing... I don't think it's a
> blocker.
> >
> > From: Piotr Zarzycki
> > Sent: Wednesday, May 10, 2023 12:21 PM
> > To: dev@royale.apache.org
> > Subject: Re: [DISCUSS] Release Apache Royale 0.9.10 RC3
> >
> > Hello,
> >
> > I was trying to vote. I got following error during build ant non-swf.
> > Anyone have same issue ? I'm on Mac OSX Ventura 13.3.1 (a)
> >
> > compile:
> >
> > Compiling libs/Jewel-Dark-NoFlat-Emphasized-Amethyst-Theme.swc
> >
> > ROYALE_HOME:
> >
> >
> /Users/piotrzarzycki/Downloads/MoonshineSDKs/Royale_SDK/royale_vote/apache-royale-0.9.10-src/royale-asjs
> >
> > ROYALE_SWF_COMPILER_HOME:
> >
> >
> /Users/piotrzarzycki/Downloads/MoonshineSDKs/Royale_SDK/royale_vote/apache-royale-0.9.10-src/royale-asjs
> >
> > ROYALE_COMPILER_HOME:
> >
> >
> /Users/piotrzarzycki/Downloads/MoonshineSDKs/Royale_SDK/royale_vote/apache-royale-0.9.10-src/royale-asjs/js
> >
> > args:
> >
> >
> >
> +royalelib=/Users/piotrzarzycki/Downloads/MoonshineSDKs/Royale_SDK/royale_vote/apache-royale-0.9.10-src/royale-asjs/frameworks
> >
> > +playerglobal.version=11.1
> >
> >
> >
> +env.AIR_HOME=/Users/piotrzarzycki/Downloads/MoonshineSDKs/Royale_SDK/royale_vote/apache-royale-0.9.10-src/royale-asjs
> >
> > -compiler.strict-xml=true
> >
> > -compiler.targets=SWF,JSRoyale
> >
> >
> >
> -output=/Users/piotrzarzycki/Downloads/MoonshineSDKs/Royale_SDK/royale_vote/apache-royale-0.9.10-src/royale-asjs/examples/jewel/TourDeJewel/target/Jewel-Dark-NoFlat-Emphasized-Amethyst-Theme.swc
> >
> >
> >
> -load-config=/Users/piotrzarzycki/Downloads/MoonshineSDKs/Royale_SDK/royale_vote/apache-royale-0.9.10-src/royale-asjs/examples/jewel/TourDeJewel/src/main/config/compile-swf-config.xml
> >
> >
> >
> -js-load-config=/Users/piotrzarzycki/Downloads/MoonshineSDKs/Royale_SDK/royale_vote/apache-royale-0.9.10-src/royale-asjs/frameworks/js-config.xml
> >
> >
> >
> -js-load-config+=/Users/piotrzarzycki/Downloads/MoonshineSDKs/Royale_SDK/royale_vote/apache-royale-0.9.10-src/royale-asjs/examples/jewel/TourDeJewel/../../js/themes/Jewel-Dark-NoFlat-Emphasized-Amethyst-ThemeJS/src/main/config/compile-js-config.xml
> >
> > 0.225995245 seconds
> >
> > command line unable to open
> >
> >
> '/Users/piotrzarzycki/Downloads/MoonshineSDKs/Royale_SDK/royale_vote/apache-royale-0.9.10-src/royale-asjs/examples/jewel/TourDeJewel/src/main/config/compile-swf-c
Re: [DISCUSS] Release Apache Royale 0.9.10 RC3
While I was having lunch, I thought of another reason why I'm not inclined
to vote for a build where the approval script doesn't pass.
In the past, sometimes, the Royale CI server went over a week at a time
with no successful builds. We're much better about fixing it quickly these
days. Back then, on multiple occasions, I took on the effort to fix it, and
after taking care of the original issue, I discovered that the build was
still broken. I turned out that later commits had issues too, and no one
noticed because the build was already failing.
With the approval script, I worry that an issue may not get fixed after we
release, and then, when the next release rolls around, we have to again
choose whether to fix it or not. So it might get delayed again. If that
happens, we won't know if additional issues are building up behind the
original one, which makes it even harder to fix the approval script, and we
may end up missing more serious issues that the approval script could have
caught for us.
--
Josh Tynjala
Bowler Hat LLC <https://bowlerhat.dev>
On Wed, May 10, 2023 at 12:22 PM Josh Tynjala
wrote:
> I'm inclined to vote -1 if the approval script ever fails on an RC. I
> could be convinced to vote 0 at best, if I'm feeling particularly confident
> about everything else. It just feels to me like the script should be able
> to pass as a bare minimum. Maybe if it were easy to skip the part that
> fails and continue to the end, but I hate to be left wondering if there
> were additional issues after the one that caused the failure.
>
> I'll check the designmodo requirement later today.
>
> --
> Josh Tynjala
> Bowler Hat LLC <https://bowlerhat.dev>
>
>
> On Wed, May 10, 2023 at 11:48 AM Yishay Weiss
> wrote:
>
>> The reason I thought it was not a blocker was because I assumed the ant
>> script for TDJ had never been functional. I can see now that there was
>> likely regression due to e71b1485cce885f84cda7d7883750eebeec38b3d which was
>> one day after our prior release. I am not sure why my TDJ test was
>> successful before my latest commit. Maybe the themes had been built
>> previously or I was running it from a different directory. Anyway, I'll try
>> to fix that. Thanks for the input, Josh and Piotr.
>>
>> I do think we should consider whether this type of regression necessarily
>> implies no release. What do other folks think?
>>
>> Has anybody confirmed Maria's issues with designmodo fonts being
>> obligatory?
>>
>> From: Josh Tynjala
>> Sent: Wednesday, May 10, 2023 7:17 PM
>> To: dev@royale.apache.org
>> Subject: Re: [DISCUSS] Release Apache Royale 0.9.10 RC3
>>
>> I'm getting the same failure when running the approval script. I won't be
>> able to vote +1 for this RC.
>>
>> Since the themes are incorrectly building with TourDeJewel as the basedir,
>> I'm guessing that the theme targets in TourDeJewel/build.xml need the dir
>> attribute specified in the element:
>>
>> Before:
>>
>> >
>> antfile="${basedir}/../../../frameworks/themes/Jewel-Dark-NoFlat-Emphasized-Amethyst-Theme/build.xml"/>
>>
>> After:
>>
>> > dir="${basedir}/../../../frameworks/themes/Jewel-Dark-NoFlat-Emphasized-Amethyst-Theme"
>>
>> antfile="${basedir}/../../../frameworks/themes/Jewel-Dark-NoFlat-Emphasized-Amethyst-Theme/build.xml"/>
>>
>> Be sure to test it, though. That's just a guess.
>>
>> --
>> Josh Tynjala
>> Bowler Hat LLC <https://bowlerhat.dev>
>>
>>
>> On Wed, May 10, 2023 at 3:09 AM Yishay Weiss
>> wrote:
>>
>> > Looks like TDJ ant build is still failing... I don't think it's a
>> blocker.
>> >
>> > From: Piotr Zarzycki
>> > Sent: Wednesday, May 10, 2023 12:21 PM
>> > To: dev@royale.apache.org
>> > Subject: Re: [DISCUSS] Release Apache Royale 0.9.10 RC3
>> >
>> > Hello,
>> >
>> > I was trying to vote. I got following error during build ant non-swf.
>> > Anyone have same issue ? I'm on Mac OSX Ventura 13.3.1 (a)
>> >
>> > compile:
>> >
>> > Compiling libs/Jewel-Dark-NoFlat-Emphasized-Amethyst-Theme.swc
>> >
>> > ROYALE_HOME:
>> >
>> >
>> /Users/piotrzarzycki/Downloads/MoonshineSDKs/Royale_SDK/royale_vote/apache-royale-0.9.10-src/royale-asjs
>> >
>> > ROYALE_SWF_COMPILER_HOME:
>> >
>> >
>> /Users/piotrzarzycki/Downloads/MoonshineSDKs/Royale_SDK/royale_vote/apache-royale-0.9.10-src/royale-asjs
>> >
>> > ROYALE_COMPILER_HOM
Re: [DISCUSS] Release Apache Royale 0.9.10 RC3
I'm inclined to vote -1 if the approval script ever fails on an RC. I could
be convinced to vote 0 at best, if I'm feeling particularly confident about
everything else. It just feels to me like the script should be able to pass
as a bare minimum. Maybe if it were easy to skip the part that fails and
continue to the end, but I hate to be left wondering if there were
additional issues after the one that caused the failure.
I'll check the designmodo requirement later today.
--
Josh Tynjala
Bowler Hat LLC <https://bowlerhat.dev>
On Wed, May 10, 2023 at 11:48 AM Yishay Weiss
wrote:
> The reason I thought it was not a blocker was because I assumed the ant
> script for TDJ had never been functional. I can see now that there was
> likely regression due to e71b1485cce885f84cda7d7883750eebeec38b3d which was
> one day after our prior release. I am not sure why my TDJ test was
> successful before my latest commit. Maybe the themes had been built
> previously or I was running it from a different directory. Anyway, I'll try
> to fix that. Thanks for the input, Josh and Piotr.
>
> I do think we should consider whether this type of regression necessarily
> implies no release. What do other folks think?
>
> Has anybody confirmed Maria's issues with designmodo fonts being
> obligatory?
> ____
> From: Josh Tynjala
> Sent: Wednesday, May 10, 2023 7:17 PM
> To: dev@royale.apache.org
> Subject: Re: [DISCUSS] Release Apache Royale 0.9.10 RC3
>
> I'm getting the same failure when running the approval script. I won't be
> able to vote +1 for this RC.
>
> Since the themes are incorrectly building with TourDeJewel as the basedir,
> I'm guessing that the theme targets in TourDeJewel/build.xml need the dir
> attribute specified in the element:
>
> Before:
>
>
> antfile="${basedir}/../../../frameworks/themes/Jewel-Dark-NoFlat-Emphasized-Amethyst-Theme/build.xml"/>
>
> After:
>
> dir="${basedir}/../../../frameworks/themes/Jewel-Dark-NoFlat-Emphasized-Amethyst-Theme"
>
> antfile="${basedir}/../../../frameworks/themes/Jewel-Dark-NoFlat-Emphasized-Amethyst-Theme/build.xml"/>
>
> Be sure to test it, though. That's just a guess.
>
> --
> Josh Tynjala
> Bowler Hat LLC <https://bowlerhat.dev>
>
>
> On Wed, May 10, 2023 at 3:09 AM Yishay Weiss
> wrote:
>
> > Looks like TDJ ant build is still failing... I don't think it's a
> blocker.
> >
> > From: Piotr Zarzycki
> > Sent: Wednesday, May 10, 2023 12:21 PM
> > To: dev@royale.apache.org
> > Subject: Re: [DISCUSS] Release Apache Royale 0.9.10 RC3
> >
> > Hello,
> >
> > I was trying to vote. I got following error during build ant non-swf.
> > Anyone have same issue ? I'm on Mac OSX Ventura 13.3.1 (a)
> >
> > compile:
> >
> > Compiling libs/Jewel-Dark-NoFlat-Emphasized-Amethyst-Theme.swc
> >
> > ROYALE_HOME:
> >
> >
> /Users/piotrzarzycki/Downloads/MoonshineSDKs/Royale_SDK/royale_vote/apache-royale-0.9.10-src/royale-asjs
> >
> > ROYALE_SWF_COMPILER_HOME:
> >
> >
> /Users/piotrzarzycki/Downloads/MoonshineSDKs/Royale_SDK/royale_vote/apache-royale-0.9.10-src/royale-asjs
> >
> > ROYALE_COMPILER_HOME:
> >
> >
> /Users/piotrzarzycki/Downloads/MoonshineSDKs/Royale_SDK/royale_vote/apache-royale-0.9.10-src/royale-asjs/js
> >
> > args:
> >
> >
> >
> +royalelib=/Users/piotrzarzycki/Downloads/MoonshineSDKs/Royale_SDK/royale_vote/apache-royale-0.9.10-src/royale-asjs/frameworks
> >
> > +playerglobal.version=11.1
> >
> >
> >
> +env.AIR_HOME=/Users/piotrzarzycki/Downloads/MoonshineSDKs/Royale_SDK/royale_vote/apache-royale-0.9.10-src/royale-asjs
> >
> > -compiler.strict-xml=true
> >
> > -compiler.targets=SWF,JSRoyale
> >
> >
> >
> -output=/Users/piotrzarzycki/Downloads/MoonshineSDKs/Royale_SDK/royale_vote/apache-royale-0.9.10-src/royale-asjs/examples/jewel/TourDeJewel/target/Jewel-Dark-NoFlat-Emphasized-Amethyst-Theme.swc
> >
> >
> >
> -load-config=/Users/piotrzarzycki/Downloads/MoonshineSDKs/Royale_SDK/royale_vote/apache-royale-0.9.10-src/royale-asjs/examples/jewel/TourDeJewel/src/main/config/compile-swf-config.xml
> >
> >
> >
> -js-load-config=/Users/piotrzarzycki/Downloads/MoonshineSDKs/Royale_SDK/royale_vote/apache-royale-0.9.10-src/royale-asjs/frameworks/js-config.xml
> >
> >
> >
> -js-load-config+=/Users/piotrzarzycki/Downloads/MoonshineSDKs/Royale_SDK/royale_vote/apache-royale-0.9.10-src/royale-asjs/examples/jewel/TourDeJewel/../../js/themes/Jewel-Dark-NoFlat-Emphasized-Amethyst-ThemeJS/src/main/c
Re: [DISCUSS] Release Apache Royale 0.9.10 RC3
I'm getting the same failure when running the approval script. I won't be able to vote +1 for this RC. Since the themes are incorrectly building with TourDeJewel as the basedir, I'm guessing that the theme targets in TourDeJewel/build.xml need the dir attribute specified in the element: Before: After: Be sure to test it, though. That's just a guess. -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Wed, May 10, 2023 at 3:09 AM Yishay Weiss wrote: > Looks like TDJ ant build is still failing... I don't think it's a blocker. > > From: Piotr Zarzycki > Sent: Wednesday, May 10, 2023 12:21 PM > To: dev@royale.apache.org > Subject: Re: [DISCUSS] Release Apache Royale 0.9.10 RC3 > > Hello, > > I was trying to vote. I got following error during build ant non-swf. > Anyone have same issue ? I'm on Mac OSX Ventura 13.3.1 (a) > > compile: > > Compiling libs/Jewel-Dark-NoFlat-Emphasized-Amethyst-Theme.swc > > ROYALE_HOME: > > /Users/piotrzarzycki/Downloads/MoonshineSDKs/Royale_SDK/royale_vote/apache-royale-0.9.10-src/royale-asjs > > ROYALE_SWF_COMPILER_HOME: > > /Users/piotrzarzycki/Downloads/MoonshineSDKs/Royale_SDK/royale_vote/apache-royale-0.9.10-src/royale-asjs > > ROYALE_COMPILER_HOME: > > /Users/piotrzarzycki/Downloads/MoonshineSDKs/Royale_SDK/royale_vote/apache-royale-0.9.10-src/royale-asjs/js > > args: > > > +royalelib=/Users/piotrzarzycki/Downloads/MoonshineSDKs/Royale_SDK/royale_vote/apache-royale-0.9.10-src/royale-asjs/frameworks > > +playerglobal.version=11.1 > > > +env.AIR_HOME=/Users/piotrzarzycki/Downloads/MoonshineSDKs/Royale_SDK/royale_vote/apache-royale-0.9.10-src/royale-asjs > > -compiler.strict-xml=true > > -compiler.targets=SWF,JSRoyale > > > -output=/Users/piotrzarzycki/Downloads/MoonshineSDKs/Royale_SDK/royale_vote/apache-royale-0.9.10-src/royale-asjs/examples/jewel/TourDeJewel/target/Jewel-Dark-NoFlat-Emphasized-Amethyst-Theme.swc > > > -load-config=/Users/piotrzarzycki/Downloads/MoonshineSDKs/Royale_SDK/royale_vote/apache-royale-0.9.10-src/royale-asjs/examples/jewel/TourDeJewel/src/main/config/compile-swf-config.xml > > > -js-load-config=/Users/piotrzarzycki/Downloads/MoonshineSDKs/Royale_SDK/royale_vote/apache-royale-0.9.10-src/royale-asjs/frameworks/js-config.xml > > > -js-load-config+=/Users/piotrzarzycki/Downloads/MoonshineSDKs/Royale_SDK/royale_vote/apache-royale-0.9.10-src/royale-asjs/examples/jewel/TourDeJewel/../../js/themes/Jewel-Dark-NoFlat-Emphasized-Amethyst-ThemeJS/src/main/config/compile-js-config.xml > > 0.225995245 seconds > > command line unable to open > > '/Users/piotrzarzycki/Downloads/MoonshineSDKs/Royale_SDK/royale_vote/apache-royale-0.9.10-src/royale-asjs/examples/jewel/TourDeJewel/src/main/config/compile-swf-config.xml'. > > > Java Result: 4 > > > compile-js: > > > copy-swc: > > > BUILD FAILED > > > /Users/piotrzarzycki/Downloads/MoonshineSDKs/Royale_SDK/royale_vote/ApproveRoyale.xml:795: > The following error occurred while executing this line: > > > /Users/piotrzarzycki/Downloads/MoonshineSDKs/Royale_SDK/royale_vote/apache-royale-0.9.10-src/royale-asjs/build.xml:688: > The following error occurred while executing this line: > > > /Users/piotrzarzycki/Downloads/MoonshineSDKs/Royale_SDK/royale_vote/apache-royale-0.9.10-src/royale-asjs/examples/build.xml:101: > The following error occurred while executing this line: > > > /Users/piotrzarzycki/Downloads/MoonshineSDKs/Royale_SDK/royale_vote/apache-royale-0.9.10-src/royale-asjs/examples/jewel/TourDeJewel/build.xml:45: > The following error occurred while executing this line: > > > /Users/piotrzarzycki/Downloads/MoonshineSDKs/Royale_SDK/royale_vote/apache-royale-0.9.10-src/royale-asjs/examples/jewel/TourDeJewel/build.xml:387: > The following error occurred while executing this line: > > > /Users/piotrzarzycki/Downloads/MoonshineSDKs/Royale_SDK/royale_vote/apache-royale-0.9.10-src/royale-asjs/frameworks/themes/Jewel-Dark-NoFlat-Emphasized-Amethyst-Theme/build.xml:56: > Warning: Could not find file > > /Users/piotrzarzycki/Downloads/MoonshineSDKs/Royale_SDK/royale_vote/apache-royale-0.9.10-src/royale-asjs/examples/jewel/TourDeJewel/target/Jewel-Dark-NoFlat-Emphasized-Amethyst-Theme.swc > to copy. > > > > > wt., 9 maj 2023 o 19:21 Yishay Weiss napisał(a): > > > This is the discussion thread. > > > > > -- > > Piotr Zarzycki >
Re: [DISCUSS] Release Apache Royale 0.9.10 RC2
Hi Hiedra, All releases from Apache include code signing. The program gpg is used to verify that the release manager's signature is valid (Yishay's signature, for this release). You'll need to install it on your computer, and you'll need to import the Royale KEYS file. Here are some links with more information: https://infra.apache.org/new-committers-guide.html#set-up-security-and-pgp-keys https://infra.apache.org/release-signing.html https://infra.apache.org/openpgp.html The Royale KEYS file: https://dist.apache.org/repos/dist/release/royale/KEYS -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> María José Esteve wrote: > I do not identify the cause of the error, gpg?: >
Re: [DISCUSS] Release Apache Royale 0.9.10 RC2
> Here I understand that the licenses are not compatible, do I have to say install anyway? Due to the license incompatibility, it's considered an optional component. It's your choice to install it or not. It might be worth running the build twice. Once where you install the fonts, and once where you do not. Then, you will have tested each of the possible paths that a user might take when building Royale. If both builds succeed, that's good. If one of the builds fail, that might be something that we need to fix before the release. -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Tue, May 9, 2023 at 10:39 AM Maria Jose Esteve wrote: > my first check of this kind... > The error was because I did not have gpg installed nor did I have the keys > imported. > Once this was done the compilation process " ant -e -f ApproveRoyale.xml > -Drelease.version=0.9.10 -Drc=2" has continued without problems. > > But I have a doubt... > > ask-font: > Apache Royale includes an optional component set that > uses fonts from designmodo.com. > The font files are subject to and governed by the > Creative Commons Attribution-NonCommercial-NoDerivs 3.0 Unported license: > http://creativecommons.org/licenses/by-nc-nd/3.0/ > This license is not compatible with the Apache v2 license. > Do you want to install the designmodo fonts? (y, [n]) > > Here I understand that the licenses are not compatible, do I have to say > install anyway? > > Hiedra > > -Mensaje original- > De: Maria Jose Esteve > Enviado el: domingo, 7 de mayo de 2023 20:12 > Para: dev@royale.apache.org > Asunto: RE: [DISCUSS] Release Apache Royale 0.9.10 RC2 > > Sorry, I got the wrong thread ... > > > For your convenience, there is an ant script that automates the common > steps to validate a release. Instead of individually downloading the > package and signature files, unzipping, etc, you can instead: > > 1) create an empty folder, > > 2) download into that folder this file: > > https://dist.apache.org/repos/dist/dev/royale/0.9.10/rc2/ApproveRoyale > > .xml > > 3) run the script: > >ant -e -f ApproveRoyale.xml -Drelease.version=0.9.10 -Drc=2 > > I do not identify the cause of the error, gpg?: > [Results] > > --- > Microsoft Windows [Versión 10.0.19045.2846] > (c) Microsoft Corporation. Todos los derechos reservados. > > D:\Develop_Royale\Projects\Royale-SDK\0.9.10>ant -e -f ApproveRoyale.xml > -Drelease.version=0.9.10 -Drc=2 Picked up JAVA_TOOL_OPTIONS: > -Dfile.encoding=UTF-8 -Xms2048m -Xmx4096m > Buildfile: D:\Develop_Royale\Projects\Royale-SDK\0.9.10\ApproveRoyale.xml > > check-flash: > > write-out-jars-list: > > install-rat.jar: > Getting: > https://search.maven.org/remotecontent?filepath=org/apache/rat/apache-rat/0.11/apache-rat-0.11.jar > To: D:\Apache\apache-ant-1.10.7\lib\apache-rat-0.11.jar > > https://search.maven.org/remotecontent?filepath=org/apache/rat/apache-rat/0.11/apache-rat-0.11.jar > moved to > https://repo1.maven.org/maven2/org/apache/rat/apache-rat/0.11/apache-rat-0.11.jar > > install-rat.tasks.jar: > Getting: > https://search.maven.org/remotecontent?filepath=org/apache/rat/apache-rat-tasks/0.11/apache-rat-tasks-0.11.jar > To: D:\Apache\apache-ant-1.10.7\lib\apache-rat-tasks-0.11.jar > > https://search.maven.org/remotecontent?filepath=org/apache/rat/apache-rat-tasks/0.11/apache-rat-tasks-0.11.jar > moved to > https://repo1.maven.org/maven2/org/apache/rat/apache-rat-tasks/0.11/apache-rat-tasks-0.11.jar > > install-rat: > > download: > Getting: > https://dist.apache.org/repos/dist/dev/royale/0.9.10/rc2/apache-royale-0.9.10-src.zip > To: > D:\Develop_Royale\Projects\Royale-SDK\0.9.10\apache-royale-0.9.10-src.zip > Getting: > https://dist.apache.org/repos/dist/dev/royale/0.9.10/rc2/apache-royale-0.9.10-src.zip.sha512 > To: > D:\Develop_Royale\Projects\Royale-SDK\0.9.10\apache-royale-0.9.10-src.zip.sha512 > Getting: > https://dist.apache.org/repos/dist/dev/royale/0.9.10/rc2/binaries/apache-royale-0.9.10-bin-js-swf.zip > To: > D:\Develop_Royale\Projects\Royale-SDK\0.9.10\apache-royale-0.9.10-bin-js-swf.zip > Getting: > https://dist.apache.org/repos/dist/dev/royale/0.9.10/rc2/binaries/apache-royale-0.9.10-bin-js-swf.zip.sha512 > To: > D:\Develop_Royale\Projects\Royale-SDK\0.9.10\apache-royale-0.9.10-bin-js-swf.zip.sha512 > > get_asc: > Getting: > https://dist.apache.org/repos/dist/dev/royale/0.9.10/rc2/apache-royale-0.9.10-src.zip.asc > To: > D:\Develop_Royale\Projects\Royale-SDK\0.9.10\apache-royale-0.9.10-src.zip.asc > Getting: > https://dist.apache.org/repos/dist/dev/royale/0.9.10/rc2/binaries/ap
Re: [DISCUSS] Release Apache Royale 0.9.10 RC2
This RC has a couple of issues when installing the js-swf version with npm. npm install -g apache-royale-0.9.10-bin-js-swf.tar.gz 1) The download URLs are no longer valid for playerglobal.swc and the Adobe AIR SDK. At some point, Adobe stopped providing anything before version 32.0, and we were trying to download 25.0. I fixed this issue today, in this commit: https://github.com/apache/royale-asjs/commit/36adf988efddbb0ad508798b0ec371e87eb7b8e9 2) Newer versions of npm (since v7, I think) no longer display any prompts to the user when a package has a "postinstall" script. We have a "postinstall" script that asks the user to accept Adobe's licenses and download the binaries. By default, npm now just skips this dependency installation entirely because it aborts the "postinstall" script when it tries to prompt. One available workaround is to tell users to add --foreground-scripts to the npm install command. This will show the prompts, though they are kind of mixed together with npm's progress bar, which isn't ideal. The user can optionally add --no-progress to hide the progress bar. Another workaround is to set the environment variable ACCEPT_ALL_ROYALE_LICENSES to true before installing. No prompts required, and the "postinstall" script completes successfully. The first issue is the bigger one, since it prevents the SWF/JS distribution from installing its dependencies under any circumstances. As I said, it's now fixed on royale-asjs develop. For the second issue, we can update our npm install instructions on the website to include --foreground-scripts. It's not ideal, but we can come up with a better solution later. -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Fri, May 5, 2023 at 1:58 AM Yishay Weiss wrote: > This is the discuss thread. >
Re: Player Global
When you build royale-asjs, make two changes. 1) Don't set PLAYERLGLOBAL_HOME or AIR_HOME in your environment variables (or in env.properties, if you use that instead). PLAYERGLOBAL_HOME would normally point to that "player" folder that you rsync, but we don't want that. 2) Add -Dswf.distribution=1 to your ant command. If I'm remembering correctly, those two changes should be enough to make it build a SWF distribution while pulling playerglobal.swc and airglobal.swc from royale-typedefs. -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Thu, May 4, 2023 at 11:09 AM Gabe Harbs wrote: > This went over my head a bit. > > Currently, when I build Royale (withs wf support), I rsync a “player” > folder which has playerglobal.swc into frameworks/libs to allow it to be > used for compiling applications. I’m looking to get rid of that step and > I’m not sure how we can facilitate that. > > Harbs > > > On May 4, 2023, at 8:53 PM, Josh Tynjala > wrote: > > > > There's a swf.distribution Ant property that normally gets managed > > automatically. It get set to true when AIR_HOME is available, and false > > when AIR_HOME is not available. The availability of AIR_HOME (and > > PLAYERGLOBAL_HOME) is normally how the Ant build determines that it needs > > to build a SWF/JS distribution instead of a JS-only distribution. > > > > As I recall, you can manually enable it with -Dswf.distribution=1 on the > > command line (or you can set it in env.properties, if you prefer), and > this > > will force a SWF/JS distribution even when PLAYERGLOBAL_HOME and AIR_HOME > > are not set. When swf.distribution is set, but PLAYERGLOBAL_HOME and > > AIR_HOME are not set, it should look for the royale-typedefs versions of > > playerglobal.swc and airglobal.swc instead of the Adobe versions. > > > > -- > > Josh Tynjala > > Bowler Hat LLC <https://bowlerhat.dev> > > > > > > On Thu, May 4, 2023 at 12:20 AM Gabe Harbs > wrote: > > > >> What’s the status to compiling player global? I remember Josh doing work > >> on creating our own version of player global so we wouldn’t have to > rely on > >> the downloads from Adobe. > >> > >> It does not seem to be added as part of the build process. Is there a > >> reason why not? > >> > >> Thanks, > >> Harbs > >
Re: Player Global
There's a swf.distribution Ant property that normally gets managed automatically. It get set to true when AIR_HOME is available, and false when AIR_HOME is not available. The availability of AIR_HOME (and PLAYERGLOBAL_HOME) is normally how the Ant build determines that it needs to build a SWF/JS distribution instead of a JS-only distribution. As I recall, you can manually enable it with -Dswf.distribution=1 on the command line (or you can set it in env.properties, if you prefer), and this will force a SWF/JS distribution even when PLAYERGLOBAL_HOME and AIR_HOME are not set. When swf.distribution is set, but PLAYERGLOBAL_HOME and AIR_HOME are not set, it should look for the royale-typedefs versions of playerglobal.swc and airglobal.swc instead of the Adobe versions. -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Thu, May 4, 2023 at 12:20 AM Gabe Harbs wrote: > What’s the status to compiling player global? I remember Josh doing work > on creating our own version of player global so we wouldn’t have to rely on > the downloads from Adobe. > > It does not seem to be added as part of the build process. Is there a > reason why not? > > Thanks, > Harbs
Re: 0.9.10 Release
It looks like the jquery-1.9.js externs download was being cached by download-maven-plugin, and one machine had an older version than the other. We were skipping the cache for other .js externs downloads already, so I updated them all to skip the cache. Hopefully, this will be the last difference. Give it another try! -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Thu, Apr 20, 2023 at 12:17 AM Yishay Weiss wrote: > I started another release candidate. Somehow, I'm getting a > reproducibility problem which did not exist before in type-defs. > > If somebody wants to confirm you can try to reproduce the problem with > the following step: > > > From the royale-typedefs repo: > 1. Run ant -f releasesteps.xml Release_Step_007 -Drelease.version=0.9.10 > -DskipTests=true > > I had to locally modify releasesteps.xml (line 122) to add CI > crendentials [1]. I still need to fix the permissions in CI. > > What I'm seeing is that locally built > royale-typedefs-jquery-0.9.10-typedefs.swc does not match archived one. > > [1] username="****" password="***" > > From: Josh Tynjala > Sent: Monday, April 17, 2023 11:52 PM > To: dev@royale.apache.org > Subject: Re: 0.9.10 Release > > Alright, my commit today seems to do the trick. All SWC files in the > js/libs, frameworks/libs, and frameworks/js/libs directories are a binary > match when I compare the Maven distribution as built on macOS vs built on > Windows. > > You need to make sure to pull the latest develop branch for both > royale-compiler and royale-asjs. > > -- > Josh Tynjala > Bowler Hat LLC <https://bowlerhat.dev> > > > On Sun, Apr 16, 2023 at 5:59 AM Yishay Weiss > wrote: > > > >I still need to figure out the duplicate hoisted variables in MXRoyale. > > > > I can confirm it's still happening. It does not happen on my machine with > > a simple "mvn clean install". > > > > From: Josh Tynjala > > Sent: Friday, April 7, 2023 2:01 AM > > To: dev@royale.apache.org > > Subject: Re: 0.9.10 Release > > > > My latest commits make the Jewel and JewelJS SWC files match between my > > macOS and Windows machines. I ended up having to switch to a different > > Maven Sass plugin because I realized the one we were using was no longer > > maintained, and it was misbehaving. This new plugin is based on the newer > > Sass that doesn't support CRLF output at all, so the changes I talked > about > > in my previous email ended up being a strict requirement. > > > > I still need to figure out the duplicate hoisted variables in MXRoyale. > > I'll need to dive into that on another day. > > > > -- > > Josh Tynjala > > Bowler Hat LLC <https://bowlerhat.dev> > > > > > > On Thu, Apr 6, 2023 at 9:57 AM Josh Tynjala > > wrote: > > > > > Some more findings: > > > > > > The difference in Jewel appears to be caused by defaults.css. The Maven > > > build at some point was updated to force Sass to output CRLF on > Windows, > > to > > > keep Git from saying that the file is modified after regenerating it. > > > Unfortunately, this breaks the ability to do a cross-platform > > reproducible > > > build because every other platform uses LF. I'm probably going to undo > > this > > > change (sorry, Greg!). However, it looks like adding a .gitattributes > > file > > > to the repo allows us to force line endings for specific files or > > > extensions, regardless of autocrlf behavior. It should provide the same > > > benefit as Greg's commit, while restoring reproducible builds. Side > > note: I > > > also found that modern Sass doesn't even provide the option to use > CRLF, > > so > > > this change is probably for the best because we may need to upgrade > Sass > > in > > > the future. > > > > > > The situation with duplicates of hoisted variables in > > > MXRoyaleBase/MXRoyale in JDK 17 might be a threading conflict (and > > probably > > > could happen with JDK 11 too, if conditions are correct). When the > issue > > > reproduces, I see that the function scope actually contains duplicate > > > definitions of every local variable, instead of just one of each. > > > Interestingly, if I add enough logging to help myself debug this issue, > > the > > > scope ends up containing one of each local variable, and it doesn't > > > duplicate the hoisted variables anymore. That makes me think multiple > > > threads
Re: 0.9.10 Release
Alright, my commit today seems to do the trick. All SWC files in the js/libs, frameworks/libs, and frameworks/js/libs directories are a binary match when I compare the Maven distribution as built on macOS vs built on Windows. You need to make sure to pull the latest develop branch for both royale-compiler and royale-asjs. -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Sun, Apr 16, 2023 at 5:59 AM Yishay Weiss wrote: > >I still need to figure out the duplicate hoisted variables in MXRoyale. > > I can confirm it's still happening. It does not happen on my machine with > a simple "mvn clean install". > ________ > From: Josh Tynjala > Sent: Friday, April 7, 2023 2:01 AM > To: dev@royale.apache.org > Subject: Re: 0.9.10 Release > > My latest commits make the Jewel and JewelJS SWC files match between my > macOS and Windows machines. I ended up having to switch to a different > Maven Sass plugin because I realized the one we were using was no longer > maintained, and it was misbehaving. This new plugin is based on the newer > Sass that doesn't support CRLF output at all, so the changes I talked about > in my previous email ended up being a strict requirement. > > I still need to figure out the duplicate hoisted variables in MXRoyale. > I'll need to dive into that on another day. > > -- > Josh Tynjala > Bowler Hat LLC <https://bowlerhat.dev> > > > On Thu, Apr 6, 2023 at 9:57 AM Josh Tynjala > wrote: > > > Some more findings: > > > > The difference in Jewel appears to be caused by defaults.css. The Maven > > build at some point was updated to force Sass to output CRLF on Windows, > to > > keep Git from saying that the file is modified after regenerating it. > > Unfortunately, this breaks the ability to do a cross-platform > reproducible > > build because every other platform uses LF. I'm probably going to undo > this > > change (sorry, Greg!). However, it looks like adding a .gitattributes > file > > to the repo allows us to force line endings for specific files or > > extensions, regardless of autocrlf behavior. It should provide the same > > benefit as Greg's commit, while restoring reproducible builds. Side > note: I > > also found that modern Sass doesn't even provide the option to use CRLF, > so > > this change is probably for the best because we may need to upgrade Sass > in > > the future. > > > > The situation with duplicates of hoisted variables in > > MXRoyaleBase/MXRoyale in JDK 17 might be a threading conflict (and > probably > > could happen with JDK 11 too, if conditions are correct). When the issue > > reproduces, I see that the function scope actually contains duplicate > > definitions of every local variable, instead of just one of each. > > Interestingly, if I add enough logging to help myself debug this issue, > the > > scope ends up containing one of each local variable, and it doesn't > > duplicate the hoisted variables anymore. That makes me think multiple > > threads may be manipulating the scope. > > > > -- > > Josh Tynjala > > Bowler Hat LLC <https://bowlerhat.dev> > > > > > > On Wed, Apr 5, 2023 at 2:42 PM Josh Tynjala > > wrote: > > > >> Some preliminary findings: > >> > >> Jewel: > >> - Some plaintext [Embed] content was not matching up between macOS and > >> Windows. It was clearly a text encoding issue. I fixed a compiler bug > >> where it was using the system default encoding instead of UTF-8. A > >> workaround would be to use JAVA_TOOL_OPTIONS=-Dfile.encoding=UTF8. > >> - The SWF files inside the Jewel SWCs still do not match between my > >> machines. I still need to figure out why. Probably a missing compiler > >> option in the Jewel pom.xml file. > >> > >> MXRoyale and MXRoyaleBase: > >> - On Windows, I was seeing hoisted variables appear in the JS output > >> twice. I noticed that I was using JDK 11 on macOS, and JDK 17 on > Windows. > >> When I switched to JDK 11 on Windows, the problem went away. It looks > like > >> there's a bug in the compiler that needs to be fixed to support JDK 17. > >> Until then, I recommend building with JDK 11 or older (8 should be fine > >> too). > >> > >> -- > >> Josh Tynjala > >> Bowler Hat LLC <https://bowlerhat.dev> > >> > >> > >> On Wed, Apr 5, 2023 at 10:11 AM Josh Tynjala > > >> wrote: > >> > >>> Alright, I built the distribution locally with Maven on two different > >>> machines, and
Re: 0.9.10 Release
This Set is a local variable in a method, so I don't think that it's possible for multiple threads to access it. -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Mon, Apr 17, 2023 at 10:58 AM Alex Harui wrote: > I was going to suggest using a Set like you just did in the commit, but in > looking at it, (and it has been a long time since I did Java work), I would > also see what it takes to lock out other threads during the Set test. > Otherwise, two threads can both do the set test, and then since both would > get "false", the two threads could still each add to the set. When the Set > is being checked and added, no other thread should be able to run that same > code. > > HTH, > -Alex > > > On 4/17/23, 8:07 AM, "Josh Tynjala" joshtynj...@bowlerhat.dev>> wrote: > > > EXTERNAL: Use caution when clicking on links or opening attachments. > > > > > I'll be working on this one out later today. I have a couple of ideas to > try. > > > -- > Josh Tynjala > Bowler Hat LLC <https://bowlerhat.dev/> <https://bowlerhat.dev/;> > > > > > On Sun, Apr 16, 2023 at 5:59 AM Yishay Weiss <mailto:yishayj...@hotmail.com>> wrote: > > > > >I still need to figure out the duplicate hoisted variables in MXRoyale. > > > > I can confirm it's still happening. It does not happen on my machine with > > a simple "mvn clean install". > > > > From: Josh Tynjala joshtynj...@bowlerhat.dev>> > > Sent: Friday, April 7, 2023 2:01 AM > > To: dev@royale.apache.org <mailto:dev@royale.apache.org> < > dev@royale.apache.org <mailto:dev@royale.apache.org>> > > Subject: Re: 0.9.10 Release > > > > My latest commits make the Jewel and JewelJS SWC files match between my > > macOS and Windows machines. I ended up having to switch to a different > > Maven Sass plugin because I realized the one we were using was no longer > > maintained, and it was misbehaving. This new plugin is based on the newer > > Sass that doesn't support CRLF output at all, so the changes I talked > about > > in my previous email ended up being a strict requirement. > > > > I still need to figure out the duplicate hoisted variables in MXRoyale. > > I'll need to dive into that on another day. > > > > -- > > Josh Tynjala > > Bowler Hat LLC <https://bowlerhat.dev/> <https://bowlerhat.dev/;> > > > > > > On Thu, Apr 6, 2023 at 9:57 AM Josh Tynjala <mailto:joshtynj...@bowlerhat.dev>> > > wrote: > > > > > Some more findings: > > > > > > The difference in Jewel appears to be caused by defaults.css. The Maven > > > build at some point was updated to force Sass to output CRLF on > Windows, > > to > > > keep Git from saying that the file is modified after regenerating it. > > > Unfortunately, this breaks the ability to do a cross-platform > > reproducible > > > build because every other platform uses LF. I'm probably going to undo > > this > > > change (sorry, Greg!). However, it looks like adding a .gitattributes > > file > > > to the repo allows us to force line endings for specific files or > > > extensions, regardless of autocrlf behavior. It should provide the same > > > benefit as Greg's commit, while restoring reproducible builds. Side > > note: I > > > also found that modern Sass doesn't even provide the option to use > CRLF, > > so > > > this change is probably for the best because we may need to upgrade > Sass > > in > > > the future. > > > > > > The situation with duplicates of hoisted variables in > > > MXRoyaleBase/MXRoyale in JDK 17 might be a threading conflict (and > > probably > > > could happen with JDK 11 too, if conditions are correct). When the > issue > > > reproduces, I see that the function scope actually contains duplicate > > > definitions of every local variable, instead of just one of each. > > > Interestingly, if I add enough logging to help myself debug this issue, > > the > > > scope ends up containing one of each local variable, and it doesn't > > > duplicate the hoisted variables anymore. That makes me think multiple > > > threads may be manipulating the scope. > > > > > > -- > > > Josh Tynjala > > > Bowler Hat LLC <https://bowlerhat.dev/> <https://bowlerhat.dev/;> > > > > > > > > > On Wed, Apr 5, 2023 at 2:42 PM Josh Tynjala <mailto:joshtynj...@bowlerhat.dev>> &g
Re: 0.9.10 Release
I'll be working on this one out later today. I have a couple of ideas to try. -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Sun, Apr 16, 2023 at 5:59 AM Yishay Weiss wrote: > >I still need to figure out the duplicate hoisted variables in MXRoyale. > > I can confirm it's still happening. It does not happen on my machine with > a simple "mvn clean install". > ________ > From: Josh Tynjala > Sent: Friday, April 7, 2023 2:01 AM > To: dev@royale.apache.org > Subject: Re: 0.9.10 Release > > My latest commits make the Jewel and JewelJS SWC files match between my > macOS and Windows machines. I ended up having to switch to a different > Maven Sass plugin because I realized the one we were using was no longer > maintained, and it was misbehaving. This new plugin is based on the newer > Sass that doesn't support CRLF output at all, so the changes I talked about > in my previous email ended up being a strict requirement. > > I still need to figure out the duplicate hoisted variables in MXRoyale. > I'll need to dive into that on another day. > > -- > Josh Tynjala > Bowler Hat LLC <https://bowlerhat.dev> > > > On Thu, Apr 6, 2023 at 9:57 AM Josh Tynjala > wrote: > > > Some more findings: > > > > The difference in Jewel appears to be caused by defaults.css. The Maven > > build at some point was updated to force Sass to output CRLF on Windows, > to > > keep Git from saying that the file is modified after regenerating it. > > Unfortunately, this breaks the ability to do a cross-platform > reproducible > > build because every other platform uses LF. I'm probably going to undo > this > > change (sorry, Greg!). However, it looks like adding a .gitattributes > file > > to the repo allows us to force line endings for specific files or > > extensions, regardless of autocrlf behavior. It should provide the same > > benefit as Greg's commit, while restoring reproducible builds. Side > note: I > > also found that modern Sass doesn't even provide the option to use CRLF, > so > > this change is probably for the best because we may need to upgrade Sass > in > > the future. > > > > The situation with duplicates of hoisted variables in > > MXRoyaleBase/MXRoyale in JDK 17 might be a threading conflict (and > probably > > could happen with JDK 11 too, if conditions are correct). When the issue > > reproduces, I see that the function scope actually contains duplicate > > definitions of every local variable, instead of just one of each. > > Interestingly, if I add enough logging to help myself debug this issue, > the > > scope ends up containing one of each local variable, and it doesn't > > duplicate the hoisted variables anymore. That makes me think multiple > > threads may be manipulating the scope. > > > > -- > > Josh Tynjala > > Bowler Hat LLC <https://bowlerhat.dev> > > > > > > On Wed, Apr 5, 2023 at 2:42 PM Josh Tynjala > > wrote: > > > >> Some preliminary findings: > >> > >> Jewel: > >> - Some plaintext [Embed] content was not matching up between macOS and > >> Windows. It was clearly a text encoding issue. I fixed a compiler bug > >> where it was using the system default encoding instead of UTF-8. A > >> workaround would be to use JAVA_TOOL_OPTIONS=-Dfile.encoding=UTF8. > >> - The SWF files inside the Jewel SWCs still do not match between my > >> machines. I still need to figure out why. Probably a missing compiler > >> option in the Jewel pom.xml file. > >> > >> MXRoyale and MXRoyaleBase: > >> - On Windows, I was seeing hoisted variables appear in the JS output > >> twice. I noticed that I was using JDK 11 on macOS, and JDK 17 on > Windows. > >> When I switched to JDK 11 on Windows, the problem went away. It looks > like > >> there's a bug in the compiler that needs to be fixed to support JDK 17. > >> Until then, I recommend building with JDK 11 or older (8 should be fine > >> too). > >> > >> -- > >> Josh Tynjala > >> Bowler Hat LLC <https://bowlerhat.dev> > >> > >> > >> On Wed, Apr 5, 2023 at 10:11 AM Josh Tynjala > > >> wrote: > >> > >>> Alright, I built the distribution locally with Maven on two different > >>> machines, and I can see that the following SWCs don't match: Jewel, > >>> MXRoyale, and MXRoyaleBase > >>> > >>> It affects both the JS and SWF versions of the SWCs. > >>> > >>> I'll see what I
Re: 0.9.10 Release
My latest commits make the Jewel and JewelJS SWC files match between my macOS and Windows machines. I ended up having to switch to a different Maven Sass plugin because I realized the one we were using was no longer maintained, and it was misbehaving. This new plugin is based on the newer Sass that doesn't support CRLF output at all, so the changes I talked about in my previous email ended up being a strict requirement. I still need to figure out the duplicate hoisted variables in MXRoyale. I'll need to dive into that on another day. -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Thu, Apr 6, 2023 at 9:57 AM Josh Tynjala wrote: > Some more findings: > > The difference in Jewel appears to be caused by defaults.css. The Maven > build at some point was updated to force Sass to output CRLF on Windows, to > keep Git from saying that the file is modified after regenerating it. > Unfortunately, this breaks the ability to do a cross-platform reproducible > build because every other platform uses LF. I'm probably going to undo this > change (sorry, Greg!). However, it looks like adding a .gitattributes file > to the repo allows us to force line endings for specific files or > extensions, regardless of autocrlf behavior. It should provide the same > benefit as Greg's commit, while restoring reproducible builds. Side note: I > also found that modern Sass doesn't even provide the option to use CRLF, so > this change is probably for the best because we may need to upgrade Sass in > the future. > > The situation with duplicates of hoisted variables in > MXRoyaleBase/MXRoyale in JDK 17 might be a threading conflict (and probably > could happen with JDK 11 too, if conditions are correct). When the issue > reproduces, I see that the function scope actually contains duplicate > definitions of every local variable, instead of just one of each. > Interestingly, if I add enough logging to help myself debug this issue, the > scope ends up containing one of each local variable, and it doesn't > duplicate the hoisted variables anymore. That makes me think multiple > threads may be manipulating the scope. > > -- > Josh Tynjala > Bowler Hat LLC <https://bowlerhat.dev> > > > On Wed, Apr 5, 2023 at 2:42 PM Josh Tynjala > wrote: > >> Some preliminary findings: >> >> Jewel: >> - Some plaintext [Embed] content was not matching up between macOS and >> Windows. It was clearly a text encoding issue. I fixed a compiler bug >> where it was using the system default encoding instead of UTF-8. A >> workaround would be to use JAVA_TOOL_OPTIONS=-Dfile.encoding=UTF8. >> - The SWF files inside the Jewel SWCs still do not match between my >> machines. I still need to figure out why. Probably a missing compiler >> option in the Jewel pom.xml file. >> >> MXRoyale and MXRoyaleBase: >> - On Windows, I was seeing hoisted variables appear in the JS output >> twice. I noticed that I was using JDK 11 on macOS, and JDK 17 on Windows. >> When I switched to JDK 11 on Windows, the problem went away. It looks like >> there's a bug in the compiler that needs to be fixed to support JDK 17. >> Until then, I recommend building with JDK 11 or older (8 should be fine >> too). >> >> -- >> Josh Tynjala >> Bowler Hat LLC <https://bowlerhat.dev> >> >> >> On Wed, Apr 5, 2023 at 10:11 AM Josh Tynjala >> wrote: >> >>> Alright, I built the distribution locally with Maven on two different >>> machines, and I can see that the following SWCs don't match: Jewel, >>> MXRoyale, and MXRoyaleBase >>> >>> It affects both the JS and SWF versions of the SWCs. >>> >>> I'll see what I can do. >>> >>> -- >>> Josh Tynjala >>> Bowler Hat LLC <https://bowlerhat.dev> >>> >>> >>> On Mon, Apr 3, 2023 at 8:04 AM Josh Tynjala >>> wrote: >>> >>>> Yes, it's on by default. >>>> >>>> I guess that there must be some other reason why the builds don't match >>>> up. I just happened to notice this, in particular, was different between >>>> the Ant build and the Maven build. >>>> >>>> You may need to extract the .swc files and manually compare the >>>> contents to see what is different. >>>> >>>> -- >>>> Josh Tynjala >>>> Bowler Hat LLC <https://bowlerhat.dev> >>>> >>>> >>>> On Sun, Apr 2, 2023 at 4:01 AM Yishay Weiss >>>> wrote: >>>> >>>>> Is that option on by default? I just tried building both on release >>>>> machine and l
Re: [royale-compiler] branch develop updated: JSRoyaleEmitter: when reading plain text files for [Embed] metadata, read as UTF-8 instead of system default
I ended up skipping the compiler option. Instead, [Embed] metadata with
mimeType="text/plain" can now optionally specify a charset attribute.
[Embed(source="file.txt",mimeType="text/plain",charset="CP1250")]
public var file:String;
To me, this makes more sense than a compiler option, since non-utf8
encoding should be rare. The vast majority of projects will be more likely
to have almost all embedded text files encoded as utf8, and only a small
number in a different encoding, for special circumstances.
--
Josh Tynjala
Bowler Hat LLC <https://bowlerhat.dev>
On Wed, Apr 5, 2023 at 4:06 PM Josh Tynjala
wrote:
> Maybe a new compiler option that will let folks choose an encoding would
> be best. Default to a sane UTF-8, and let people opt into playing with
> weird encodings, if they need it.
>
> --
> Josh Tynjala
> Bowler Hat LLC <https://bowlerhat.dev>
>
>
> On Wed, Apr 5, 2023 at 3:58 PM Alex Harui
> wrote:
>
>> There is a chance this will break someone on Windows where the file
>> system is not UTF8 and the data includes Windows-encoded characters that
>> reference a file or something like that.
>>
>> IIRC, that's why I decided to live with JAVA_TOOL_OPTIONS, so we don't
>> make a change that can't be overridden.
>>
>> -Alex
>>
>> On 4/5/23, 1:47 PM, "Greg Dove" > greg.d...@gmail.com>> wrote:
>>
>>
>> EXTERNAL: Use caution when clicking on links or opening attachments.
>>
>>
>>
>>
>> Nice find, Josh.
>>
>>
>> I was intending to look into some similar issue with resource*
>> .properties *files
>> as well.
>> We have definitely had the need to set utf8 file.encoding in
>> JAVA_TOOL_OPTIONS to get that to work the same as flex compiler did for
>> royale compiler (JS in particular, but I will try to check if royale swf
>> is
>> at odds also), in some work over the last 12-18 months.
>> This is just a mention, for your awareness, not a request for you to do
>> anything. I hope to find some time to spend on Royale work in the 2nd half
>> of April, so I will try to look into it then.
>>
>>
>> -- Forwarded message -
>> From: mailto:joshtynj...@apache.org>>
>> Date: Thu, Apr 6, 2023 at 8:31 AM
>> Subject: [royale-compiler] branch develop updated: JSRoyaleEmitter: when
>> reading plain text files for [Embed] metadata, read as UTF-8 instead of
>> system default
>> To: comm...@royale.apache.org <mailto:comm...@royale.apache.org> <
>> comm...@royale.apache.org <mailto:comm...@royale.apache.org>>
>>
>>
>>
>>
>> This is an automated email from the ASF dual-hosted git repository.
>>
>>
>> joshtynjala pushed a commit to branch develop
>> in repository https://gitbox.apache.org/repos/asf/royale-compiler.git <
>> https://gitbox.apache.org/repos/asf/royale-compiler.git>
>>
>>
>>
>>
>> The following commit(s) were added to refs/heads/develop by this push:
>> new 5669b4714 JSRoyaleEmitter: when reading plain text files for
>> [Embed] metadata, read as UTF-8 instead of system default
>> 5669b4714 is described below
>>
>>
>> commit 5669b4714118c1e2c2edf0e01360a39002e78033
>> Author: Josh Tynjala > joshtynj...@apache.org>>
>> AuthorDate: Wed Apr 5 13:31:34 2023 -0700
>>
>>
>> JSRoyaleEmitter: when reading plain text files for [Embed] metadata,
>> read as UTF-8 instead of system default
>>
>>
>> This matches the behavior of reading other text files, and avoids the
>> need for JAVA_TOOL_OPTIONS with file.encoding
>> ---
>> .../royale/compiler/internal/codegen/js/royale/JSRoyaleEmitter.java |
>> 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>>
>> diff --git
>>
>> a/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/royale/JSRoyaleEmitter.java
>>
>> b/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/royale/JSRoyaleEmitter.java
>> index 10bc04b4e..2f67e14f5 100644
>> ---
>>
>> a/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/royale/JSRoyaleEmitter.java
>> +++
>>
>> b/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/royale/JSRoyaleEmitter.java
>> @@ -1097,7 +1097,7 @@ public class JSRoyaleEmitter extends JSGoogEmitter
>> implements IJSRoyaleEmitter
>> File file = new File(FilenameNormalization.normalize(source));
>> try {
>> String newlineReplacement = "n";
>> - String s = FileUtils.readFileToString(file);
>> + String s = FileUtils.readFileToString(file,
>> "UTF-8");
>> s = s.replaceAll("\n", "__NEWLINE_PLACEHOLDER__");
>> s = s.replaceAll("\r", "__CR_PLACEHOLDER__");
>> s = s.replaceAll("\t", "__TAB_PLACEHOLDER__");
>>
>>
>>
>>
Re: [royale-compiler] branch develop updated: JSRoyaleEmitter: when reading plain text files for [Embed] metadata, read as UTF-8 instead of system default
According to the compiler docs, .properties files are assumed to be UTF-8. https://github.com/apache/royale-compiler/blob/apache-royale-0.9.9/compiler/src/main/java/org/apache/royale/compiler/internal/resourcebundles/PropertiesFileParser.java#L98-L100 -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Wed, Apr 5, 2023 at 7:21 PM Greg Dove wrote: > @Josh: > That sounds good to me, and makes things easier compared to what I was > considering. > > > @Alex: > I was going to compare the behavior of the most recent Flex compiler and > the Royale compiler to understand/avoid issues, but obviously only with swf > vs. swf. > Then check for any difference in royale compiler swf vs. js. > > For Resource properties files I had only found one very. old 'known issue' > mention from the Flex 2 compiler which said: > >- All strings in properties files must be Latin-1 or UTF-8 encoded. > > I don't have experience using anything other than utf-8 throughout the Flex > years in these cases. The Flex 2 issue comment above seems to be quite > restrictive for properties files. However that may have been 'fixed' in > Flex 3 or Flex 4 compilers to allow more. > I do suspect that even in more recent compilers it ought to have been utf-8 > by default though, I believe that is what we were seeing for the migration > project I was involved with, where the utf-8 encoding setting was needed on > the Royale compiler but not on the old Flex one.. My intention however was > to try to verify that before making any changes. If we do what Josh is > suggesting then I would skip that work and just go with the explicit (but > default Utf8) config setting. > > > > On Thu, Apr 6, 2023 at 11:07 AM Josh Tynjala > wrote: > > > Maybe a new compiler option that will let folks choose an encoding would > be > > best. Default to a sane UTF-8, and let people opt into playing with weird > > encodings, if they need it. > > > > -- > > Josh Tynjala > > Bowler Hat LLC <https://bowlerhat.dev> > > > > > > On Wed, Apr 5, 2023 at 3:58 PM Alex Harui > > wrote: > > > > > There is a chance this will break someone on Windows where the file > > system > > > is not UTF8 and the data includes Windows-encoded characters that > > reference > > > a file or something like that. > > > > > > IIRC, that's why I decided to live with JAVA_TOOL_OPTIONS, so we don't > > > make a change that can't be overridden. > > > > > > -Alex > > > > > > On 4/5/23, 1:47 PM, "Greg Dove" > > greg.d...@gmail.com>> wrote: > > > > > > > > > EXTERNAL: Use caution when clicking on links or opening attachments. > > > > > > > > > > > > > > > Nice find, Josh. > > > > > > > > > I was intending to look into some similar issue with resource* > > > .properties *files > > > as well. > > > We have definitely had the need to set utf8 file.encoding in > > > JAVA_TOOL_OPTIONS to get that to work the same as flex compiler did for > > > royale compiler (JS in particular, but I will try to check if royale > swf > > is > > > at odds also), in some work over the last 12-18 months. > > > This is just a mention, for your awareness, not a request for you to do > > > anything. I hope to find some time to spend on Royale work in the 2nd > > half > > > of April, so I will try to look into it then. > > > > > > > > > -- Forwarded message - > > > From: mailto:joshtynj...@apache.org>> > > > Date: Thu, Apr 6, 2023 at 8:31 AM > > > Subject: [royale-compiler] branch develop updated: JSRoyaleEmitter: > when > > > reading plain text files for [Embed] metadata, read as UTF-8 instead of > > > system default > > > To: comm...@royale.apache.org <mailto:comm...@royale.apache.org> < > > > comm...@royale.apache.org <mailto:comm...@royale.apache.org>> > > > > > > > > > > > > > > > This is an automated email from the ASF dual-hosted git repository. > > > > > > > > > joshtynjala pushed a commit to branch develop > > > in repository https://gitbox.apache.org/repos/asf/royale-compiler.git > < > > > https://gitbox.apache.org/repos/asf/royale-compiler.git> > > > > > > > > > > > > > > > The following commit(s) were added to refs/heads/develop by this push: > > > new 5669b4714 JSRoyaleEmitter: when reading plain text files for > > > [Em
Re: 0.9.10 Release
> The Maven build at some point was updated to force Sass to output CRLF on Windows > Unfortunately, this breaks the ability to do a cross-platform reproducible build because every other platform uses LF I should add an important detail to this. Technically, the SWC writer converts CRLF to LF for CSS files. You would think that would be enough. But, it turns out that Sass generates CSS files with slightly different formatting depending on if it is using LF or CRLF line endings. So even when line endings are normalized in a post-processing step, the files still won't match. Fun, right? -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Thu, Apr 6, 2023 at 9:57 AM Josh Tynjala wrote: > Some more findings: > > The difference in Jewel appears to be caused by defaults.css. The Maven > build at some point was updated to force Sass to output CRLF on Windows, to > keep Git from saying that the file is modified after regenerating it. > Unfortunately, this breaks the ability to do a cross-platform reproducible > build because every other platform uses LF. I'm probably going to undo this > change (sorry, Greg!). However, it looks like adding a .gitattributes file > to the repo allows us to force line endings for specific files or > extensions, regardless of autocrlf behavior. It should provide the same > benefit as Greg's commit, while restoring reproducible builds. Side note: I > also found that modern Sass doesn't even provide the option to use CRLF, so > this change is probably for the best because we may need to upgrade Sass in > the future. > > The situation with duplicates of hoisted variables in > MXRoyaleBase/MXRoyale in JDK 17 might be a threading conflict (and probably > could happen with JDK 11 too, if conditions are correct). When the issue > reproduces, I see that the function scope actually contains duplicate > definitions of every local variable, instead of just one of each. > Interestingly, if I add enough logging to help myself debug this issue, the > scope ends up containing one of each local variable, and it doesn't > duplicate the hoisted variables anymore. That makes me think multiple > threads may be manipulating the scope. > > -- > Josh Tynjala > Bowler Hat LLC <https://bowlerhat.dev> > > > On Wed, Apr 5, 2023 at 2:42 PM Josh Tynjala > wrote: > >> Some preliminary findings: >> >> Jewel: >> - Some plaintext [Embed] content was not matching up between macOS and >> Windows. It was clearly a text encoding issue. I fixed a compiler bug >> where it was using the system default encoding instead of UTF-8. A >> workaround would be to use JAVA_TOOL_OPTIONS=-Dfile.encoding=UTF8. >> - The SWF files inside the Jewel SWCs still do not match between my >> machines. I still need to figure out why. Probably a missing compiler >> option in the Jewel pom.xml file. >> >> MXRoyale and MXRoyaleBase: >> - On Windows, I was seeing hoisted variables appear in the JS output >> twice. I noticed that I was using JDK 11 on macOS, and JDK 17 on Windows. >> When I switched to JDK 11 on Windows, the problem went away. It looks like >> there's a bug in the compiler that needs to be fixed to support JDK 17. >> Until then, I recommend building with JDK 11 or older (8 should be fine >> too). >> >> -- >> Josh Tynjala >> Bowler Hat LLC <https://bowlerhat.dev> >> >> >> On Wed, Apr 5, 2023 at 10:11 AM Josh Tynjala >> wrote: >> >>> Alright, I built the distribution locally with Maven on two different >>> machines, and I can see that the following SWCs don't match: Jewel, >>> MXRoyale, and MXRoyaleBase >>> >>> It affects both the JS and SWF versions of the SWCs. >>> >>> I'll see what I can do. >>> >>> -- >>> Josh Tynjala >>> Bowler Hat LLC <https://bowlerhat.dev> >>> >>> >>> On Mon, Apr 3, 2023 at 8:04 AM Josh Tynjala >>> wrote: >>> >>>> Yes, it's on by default. >>>> >>>> I guess that there must be some other reason why the builds don't match >>>> up. I just happened to notice this, in particular, was different between >>>> the Ant build and the Maven build. >>>> >>>> You may need to extract the .swc files and manually compare the >>>> contents to see what is different. >>>> >>>> -- >>>> Josh Tynjala >>>> Bowler Hat LLC <https://bowlerhat.dev> >>>> >>>> >>>> On Sun, Apr 2, 2023 at 4:01 AM Yishay Weiss >>>> wrote: >>>> >>>>> Is that option on by default? I just t
Re: 0.9.10 Release
Some more findings: The difference in Jewel appears to be caused by defaults.css. The Maven build at some point was updated to force Sass to output CRLF on Windows, to keep Git from saying that the file is modified after regenerating it. Unfortunately, this breaks the ability to do a cross-platform reproducible build because every other platform uses LF. I'm probably going to undo this change (sorry, Greg!). However, it looks like adding a .gitattributes file to the repo allows us to force line endings for specific files or extensions, regardless of autocrlf behavior. It should provide the same benefit as Greg's commit, while restoring reproducible builds. Side note: I also found that modern Sass doesn't even provide the option to use CRLF, so this change is probably for the best because we may need to upgrade Sass in the future. The situation with duplicates of hoisted variables in MXRoyaleBase/MXRoyale in JDK 17 might be a threading conflict (and probably could happen with JDK 11 too, if conditions are correct). When the issue reproduces, I see that the function scope actually contains duplicate definitions of every local variable, instead of just one of each. Interestingly, if I add enough logging to help myself debug this issue, the scope ends up containing one of each local variable, and it doesn't duplicate the hoisted variables anymore. That makes me think multiple threads may be manipulating the scope. -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Wed, Apr 5, 2023 at 2:42 PM Josh Tynjala wrote: > Some preliminary findings: > > Jewel: > - Some plaintext [Embed] content was not matching up between macOS and > Windows. It was clearly a text encoding issue. I fixed a compiler bug > where it was using the system default encoding instead of UTF-8. A > workaround would be to use JAVA_TOOL_OPTIONS=-Dfile.encoding=UTF8. > - The SWF files inside the Jewel SWCs still do not match between my > machines. I still need to figure out why. Probably a missing compiler > option in the Jewel pom.xml file. > > MXRoyale and MXRoyaleBase: > - On Windows, I was seeing hoisted variables appear in the JS output > twice. I noticed that I was using JDK 11 on macOS, and JDK 17 on Windows. > When I switched to JDK 11 on Windows, the problem went away. It looks like > there's a bug in the compiler that needs to be fixed to support JDK 17. > Until then, I recommend building with JDK 11 or older (8 should be fine > too). > > -- > Josh Tynjala > Bowler Hat LLC <https://bowlerhat.dev> > > > On Wed, Apr 5, 2023 at 10:11 AM Josh Tynjala > wrote: > >> Alright, I built the distribution locally with Maven on two different >> machines, and I can see that the following SWCs don't match: Jewel, >> MXRoyale, and MXRoyaleBase >> >> It affects both the JS and SWF versions of the SWCs. >> >> I'll see what I can do. >> >> -- >> Josh Tynjala >> Bowler Hat LLC <https://bowlerhat.dev> >> >> >> On Mon, Apr 3, 2023 at 8:04 AM Josh Tynjala >> wrote: >> >>> Yes, it's on by default. >>> >>> I guess that there must be some other reason why the builds don't match >>> up. I just happened to notice this, in particular, was different between >>> the Ant build and the Maven build. >>> >>> You may need to extract the .swc files and manually compare the contents >>> to see what is different. >>> >>> -- >>> Josh Tynjala >>> Bowler Hat LLC <https://bowlerhat.dev> >>> >>> >>> On Sun, Apr 2, 2023 at 4:01 AM Yishay Weiss >>> wrote: >>> >>>> Is that option on by default? I just tried building both on release >>>> machine and locally and am still getting the mismatch. >>>> >>>> >>> failonerror="true" > >>>> >>>> >>>> >>> value="royale-release,apache-release,_reproducible-build,with-distribution,with-examples,with-manualtests,option-with-swf" >>>> /> >>>> >>>> >>>> >>>> >>>> Is how it gets built now locally. Intuitively debug info should not be >>>> part of the release but I need to look into it further. >>>> >>>> From: Josh Tynjala >>>> Sent: Tuesday, March 28, 2023 6:17 PM >>>> To: dev@royale.apache.org >>>> Subject: Re: 0.9.10 Release >>>> >>>> Hey Yishay, >>>> >>>> I recently made a commit that adds the swf-debugfile-alias compiler >>>> option >>>> f
Re: [royale-compiler] branch develop updated: JSRoyaleEmitter: when reading plain text files for [Embed] metadata, read as UTF-8 instead of system default
Maybe a new compiler option that will let folks choose an encoding would be
best. Default to a sane UTF-8, and let people opt into playing with weird
encodings, if they need it.
--
Josh Tynjala
Bowler Hat LLC <https://bowlerhat.dev>
On Wed, Apr 5, 2023 at 3:58 PM Alex Harui wrote:
> There is a chance this will break someone on Windows where the file system
> is not UTF8 and the data includes Windows-encoded characters that reference
> a file or something like that.
>
> IIRC, that's why I decided to live with JAVA_TOOL_OPTIONS, so we don't
> make a change that can't be overridden.
>
> -Alex
>
> On 4/5/23, 1:47 PM, "Greg Dove" greg.d...@gmail.com>> wrote:
>
>
> EXTERNAL: Use caution when clicking on links or opening attachments.
>
>
>
>
> Nice find, Josh.
>
>
> I was intending to look into some similar issue with resource*
> .properties *files
> as well.
> We have definitely had the need to set utf8 file.encoding in
> JAVA_TOOL_OPTIONS to get that to work the same as flex compiler did for
> royale compiler (JS in particular, but I will try to check if royale swf is
> at odds also), in some work over the last 12-18 months.
> This is just a mention, for your awareness, not a request for you to do
> anything. I hope to find some time to spend on Royale work in the 2nd half
> of April, so I will try to look into it then.
>
>
> -- Forwarded message -
> From: mailto:joshtynj...@apache.org>>
> Date: Thu, Apr 6, 2023 at 8:31 AM
> Subject: [royale-compiler] branch develop updated: JSRoyaleEmitter: when
> reading plain text files for [Embed] metadata, read as UTF-8 instead of
> system default
> To: comm...@royale.apache.org <mailto:comm...@royale.apache.org> <
> comm...@royale.apache.org <mailto:comm...@royale.apache.org>>
>
>
>
>
> This is an automated email from the ASF dual-hosted git repository.
>
>
> joshtynjala pushed a commit to branch develop
> in repository https://gitbox.apache.org/repos/asf/royale-compiler.git <
> https://gitbox.apache.org/repos/asf/royale-compiler.git>
>
>
>
>
> The following commit(s) were added to refs/heads/develop by this push:
> new 5669b4714 JSRoyaleEmitter: when reading plain text files for
> [Embed] metadata, read as UTF-8 instead of system default
> 5669b4714 is described below
>
>
> commit 5669b4714118c1e2c2edf0e01360a39002e78033
> Author: Josh Tynjala joshtynj...@apache.org>>
> AuthorDate: Wed Apr 5 13:31:34 2023 -0700
>
>
> JSRoyaleEmitter: when reading plain text files for [Embed] metadata,
> read as UTF-8 instead of system default
>
>
> This matches the behavior of reading other text files, and avoids the
> need for JAVA_TOOL_OPTIONS with file.encoding
> ---
> .../royale/compiler/internal/codegen/js/royale/JSRoyaleEmitter.java |
> 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
> diff --git
>
> a/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/royale/JSRoyaleEmitter.java
>
> b/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/royale/JSRoyaleEmitter.java
> index 10bc04b4e..2f67e14f5 100644
> ---
>
> a/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/royale/JSRoyaleEmitter.java
> +++
>
> b/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/royale/JSRoyaleEmitter.java
> @@ -1097,7 +1097,7 @@ public class JSRoyaleEmitter extends JSGoogEmitter
> implements IJSRoyaleEmitter
> File file = new File(FilenameNormalization.normalize(source));
> try {
> String newlineReplacement = "n";
> - String s = FileUtils.readFileToString(file);
> + String s = FileUtils.readFileToString(file,
> "UTF-8");
> s = s.replaceAll("\n", "__NEWLINE_PLACEHOLDER__");
> s = s.replaceAll("\r", "__CR_PLACEHOLDER__");
> s = s.replaceAll("\t", "__TAB_PLACEHOLDER__");
>
>
>
>
Re: 0.9.10 Release
I don't doubt that you included it in the instructions. I always avoid setting JAVA_TOOL_OPTIONS on my local machines because it gives me more opportunities to find and fix bugs in the compiler. -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Wed, Apr 5, 2023 at 3:52 PM Alex Harui wrote: > I thought the RM instructions dictated that you had to set > JAVA_TOOL_OPTIONS=-Dfile.encoding=UTF8 > > If that's not true, sorry for omitting that. But that would be the > recommended practice. > > -Alex > > On 4/5/23, 2:43 PM, "Josh Tynjala" joshtynj...@bowlerhat.dev>> wrote: > > > EXTERNAL: Use caution when clicking on links or opening attachments. > > > > > Some preliminary findings: > > > Jewel: > - Some plaintext [Embed] content was not matching up between macOS and > Windows. It was clearly a text encoding issue. I fixed a compiler bug where > it was using the system default encoding instead of UTF-8. A workaround > would be to use JAVA_TOOL_OPTIONS=-Dfile.encoding=UTF8. > - The SWF files inside the Jewel SWCs still do not match between my > machines. I still need to figure out why. Probably a missing compiler > option in the Jewel pom.xml file. > > > MXRoyale and MXRoyaleBase: > - On Windows, I was seeing hoisted variables appear in the JS output twice. > I noticed that I was using JDK 11 on macOS, and JDK 17 on Windows. When I > switched to JDK 11 on Windows, the problem went away. It looks like there's > a bug in the compiler that needs to be fixed to support JDK 17. Until then, > I recommend building with JDK 11 or older (8 should be fine too). > > > -- > Josh Tynjala > Bowler Hat LLC <https://bowlerhat.dev/> <https://bowlerhat.dev/;> > > > > > On Wed, Apr 5, 2023 at 10:11 AM Josh Tynjala <mailto:joshtynj...@bowlerhat.dev>> > wrote: > > > > Alright, I built the distribution locally with Maven on two different > > machines, and I can see that the following SWCs don't match: Jewel, > > MXRoyale, and MXRoyaleBase > > > > It affects both the JS and SWF versions of the SWCs. > > > > I'll see what I can do. > > > > -- > > Josh Tynjala > > Bowler Hat LLC <https://bowlerhat.dev/> <https://bowlerhat.dev/;> > > > > > > On Mon, Apr 3, 2023 at 8:04 AM Josh Tynjala <mailto:joshtynj...@bowlerhat.dev>> > > wrote: > > > >> Yes, it's on by default. > >> > >> I guess that there must be some other reason why the builds don't match > >> up. I just happened to notice this, in particular, was different between > >> the Ant build and the Maven build. > >> > >> You may need to extract the .swc files and manually compare the contents > >> to see what is different. > >> > >> -- > >> Josh Tynjala > >> Bowler Hat LLC <https://bowlerhat.dev/> <https://bowlerhat.dev/;> > >> > >> > >> On Sun, Apr 2, 2023 at 4:01 AM Yishay Weiss <mailto:yishayj...@hotmail.com>> > >> wrote: > >> > >>> Is that option on by default? I just tried building both on release > >>> machine and locally and am still getting the mismatch. > >>> > >>> >>> failonerror="true" > > >>> > >>> > >>> >>> > value="royale-release,apache-release,_reproducible-build,with-distribution,with-examples,with-manualtests,option-with-swf" > >>> /> > >>> > >>> > >>> > >>> > >>> Is how it gets built now locally. Intuitively debug info should not be > >>> part of the release but I need to look into it further. > >>> > >>> From: Josh Tynjala joshtynj...@bowlerhat.dev>> > >>> Sent: Tuesday, March 28, 2023 6:17 PM > >>> To: dev@royale.apache.org <mailto:dev@royale.apache.org> < > dev@royale.apache.org <mailto:dev@royale.apache.org>> > >>> Subject: Re: 0.9.10 Release > >>> > >>> Hey Yishay, > >>> > >>> I recently made a commit that adds the swf-debugfile-alias compiler > >>> option > >>> for SWC files built by Maven. This compiler option was being used by > Ant > >>> already, but it never got added to the Maven build. And I think that > >>> binaries would fail comparison without it. This may be why Release Step > >>> 11 > >>> was failing for you. > >>> > >>> Basically, swf-debugfile-alias ensures that the debugging informatio
Re: 0.9.10 Release
Some preliminary findings: Jewel: - Some plaintext [Embed] content was not matching up between macOS and Windows. It was clearly a text encoding issue. I fixed a compiler bug where it was using the system default encoding instead of UTF-8. A workaround would be to use JAVA_TOOL_OPTIONS=-Dfile.encoding=UTF8. - The SWF files inside the Jewel SWCs still do not match between my machines. I still need to figure out why. Probably a missing compiler option in the Jewel pom.xml file. MXRoyale and MXRoyaleBase: - On Windows, I was seeing hoisted variables appear in the JS output twice. I noticed that I was using JDK 11 on macOS, and JDK 17 on Windows. When I switched to JDK 11 on Windows, the problem went away. It looks like there's a bug in the compiler that needs to be fixed to support JDK 17. Until then, I recommend building with JDK 11 or older (8 should be fine too). -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Wed, Apr 5, 2023 at 10:11 AM Josh Tynjala wrote: > Alright, I built the distribution locally with Maven on two different > machines, and I can see that the following SWCs don't match: Jewel, > MXRoyale, and MXRoyaleBase > > It affects both the JS and SWF versions of the SWCs. > > I'll see what I can do. > > -- > Josh Tynjala > Bowler Hat LLC <https://bowlerhat.dev> > > > On Mon, Apr 3, 2023 at 8:04 AM Josh Tynjala > wrote: > >> Yes, it's on by default. >> >> I guess that there must be some other reason why the builds don't match >> up. I just happened to notice this, in particular, was different between >> the Ant build and the Maven build. >> >> You may need to extract the .swc files and manually compare the contents >> to see what is different. >> >> -- >> Josh Tynjala >> Bowler Hat LLC <https://bowlerhat.dev> >> >> >> On Sun, Apr 2, 2023 at 4:01 AM Yishay Weiss >> wrote: >> >>> Is that option on by default? I just tried building both on release >>> machine and locally and am still getting the mismatch. >>> >>> >> failonerror="true" > >>> >>> >>> >> value="royale-release,apache-release,_reproducible-build,with-distribution,with-examples,with-manualtests,option-with-swf" >>> /> >>> >>> >>> >>> >>> Is how it gets built now locally. Intuitively debug info should not be >>> part of the release but I need to look into it further. >>> >>> From: Josh Tynjala >>> Sent: Tuesday, March 28, 2023 6:17 PM >>> To: dev@royale.apache.org >>> Subject: Re: 0.9.10 Release >>> >>> Hey Yishay, >>> >>> I recently made a commit that adds the swf-debugfile-alias compiler >>> option >>> for SWC files built by Maven. This compiler option was being used by Ant >>> already, but it never got added to the Maven build. And I think that >>> binaries would fail comparison without it. This may be why Release Step >>> 11 >>> was failing for you. >>> >>> Basically, swf-debugfile-alias ensures that the debugging information in >>> the SWC doesn't include the local path to the .as/.mxml source files >>> (starting with something like C:\Users\joshtynjala\ or >>> /Users/CoolGuy19/). >>> Instead, it sets a generic path that will always match among builds from >>> different machines. Considering this was missing, it sure sounds like a >>> reason why binary comparison would fail. >>> >>> -- >>> Josh Tynjala >>> Bowler Hat LLC <https://bowlerhat.dev> >>> >>> >>> On Wed, Feb 22, 2023 at 10:38 AM Yishay Weiss >>> wrote: >>> >>> > FYI I am put this on hold about 2 weeks ago after failing to debug a >>> > binary reproducibility issue in as-js repo. >>> > >>> > @Harbs<mailto:harbs.li...@gmail.com>, can you see if the same issue >>> > exists for you? >>> > >>> > You can follow instructions [1] and tell me if step 2 succeeded or >>> failed >>> > for you. >>> > >>> > Thanks. >>> > >>> > [1] >>> > >>> apacheroyale.francecentral.cloudapp.azure.com:8080/job/Royale_Release_Step_011/ws/Success-5.txt >>> > < >>> > >>> http://apacheroyale.francecentral.cloudapp.azure.com:8080/job/Royale_Release_Step_011/ws/Success-5.txt >>> > > >>> > ___
Re: 0.9.10 Release
Alright, I built the distribution locally with Maven on two different machines, and I can see that the following SWCs don't match: Jewel, MXRoyale, and MXRoyaleBase It affects both the JS and SWF versions of the SWCs. I'll see what I can do. -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Mon, Apr 3, 2023 at 8:04 AM Josh Tynjala wrote: > Yes, it's on by default. > > I guess that there must be some other reason why the builds don't match > up. I just happened to notice this, in particular, was different between > the Ant build and the Maven build. > > You may need to extract the .swc files and manually compare the contents > to see what is different. > > -- > Josh Tynjala > Bowler Hat LLC <https://bowlerhat.dev> > > > On Sun, Apr 2, 2023 at 4:01 AM Yishay Weiss > wrote: > >> Is that option on by default? I just tried building both on release >> machine and locally and am still getting the mismatch. >> >> > failonerror="true" > >> >> >> > value="royale-release,apache-release,_reproducible-build,with-distribution,with-examples,with-manualtests,option-with-swf" >> /> >> >> >> >> >> Is how it gets built now locally. Intuitively debug info should not be >> part of the release but I need to look into it further. >> >> From: Josh Tynjala >> Sent: Tuesday, March 28, 2023 6:17 PM >> To: dev@royale.apache.org >> Subject: Re: 0.9.10 Release >> >> Hey Yishay, >> >> I recently made a commit that adds the swf-debugfile-alias compiler option >> for SWC files built by Maven. This compiler option was being used by Ant >> already, but it never got added to the Maven build. And I think that >> binaries would fail comparison without it. This may be why Release Step 11 >> was failing for you. >> >> Basically, swf-debugfile-alias ensures that the debugging information in >> the SWC doesn't include the local path to the .as/.mxml source files >> (starting with something like C:\Users\joshtynjala\ or /Users/CoolGuy19/). >> Instead, it sets a generic path that will always match among builds from >> different machines. Considering this was missing, it sure sounds like a >> reason why binary comparison would fail. >> >> -- >> Josh Tynjala >> Bowler Hat LLC <https://bowlerhat.dev> >> >> >> On Wed, Feb 22, 2023 at 10:38 AM Yishay Weiss >> wrote: >> >> > FYI I am put this on hold about 2 weeks ago after failing to debug a >> > binary reproducibility issue in as-js repo. >> > >> > @Harbs<mailto:harbs.li...@gmail.com>, can you see if the same issue >> > exists for you? >> > >> > You can follow instructions [1] and tell me if step 2 succeeded or >> failed >> > for you. >> > >> > Thanks. >> > >> > [1] >> > >> apacheroyale.francecentral.cloudapp.azure.com:8080/job/Royale_Release_Step_011/ws/Success-5.txt >> > < >> > >> http://apacheroyale.francecentral.cloudapp.azure.com:8080/job/Royale_Release_Step_011/ws/Success-5.txt >> > > >> > >> > From: Josh Tynjala >> > Sent: Tuesday, January 17, 2023 10:08 PM >> > To: dev@royale.apache.org >> > Subject: Re: 0.9.10 Release >> > >> > Oops! I meant NO further changes. Sorry about that. You're good to go >> on my >> > end. >> > >> > -- >> > Josh Tynjala >> > Bowler Hat LLC <https://bowlerhat.dev> >> > >> > >> > On Tue, Jan 17, 2023 at 11:32 AM Yishay Weiss >> > wrote: >> > >> > > Thanks for the update, let me know when to pull the trigger. >> > > >> > > Get Outlook for Android<https://aka.ms/AAb9ysg> >> > > >> > > From: Josh Tynjala >> > > Sent: Tuesday, January 17, 2023 7:05:29 PM >> > > To: dev@royale.apache.org >> > > Subject: Re: 0.9.10 Release >> > > >> > > I've updated the release notes with my changes. I have further changes >> > > planned before the release. >> > > >> > > -- >> > > Josh Tynjala >> > > Bowler Hat LLC <https://bowlerhat.dev> >> > > >> > > >> > > On Mon, Jan 16, 2023 at 12:40 AM Yishay Weiss > > >> > > wrote: >> > > >> > > > Hi Guys, >> > > > >> > > > We’re starting a new release soon. As it’s been a while and I expect >> > some >> > > > issues I have agreed with Harbs to do this release. 0.9.11 should be >> > > easier >> > > > if we don’t wait too long, so the goal is for a different volunteer >> to >> > do >> > > > the next one. >> > > > >> > > > If anybody wants to commit changes they are welcome to do so now, >> and >> > > > update the release notes. >> > > > >> > > > Please make sure the integration tests are working post commits. >> > > > >> > > > Thanks, >> > > > Yishay >> > > > >> > > >> > >> >
Re: 0.9.10 Release
Yes, it's on by default. I guess that there must be some other reason why the builds don't match up. I just happened to notice this, in particular, was different between the Ant build and the Maven build. You may need to extract the .swc files and manually compare the contents to see what is different. -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Sun, Apr 2, 2023 at 4:01 AM Yishay Weiss wrote: > Is that option on by default? I just tried building both on release > machine and locally and am still getting the mismatch. > > failonerror="true" > > > > value="royale-release,apache-release,_reproducible-build,with-distribution,with-examples,with-manualtests,option-with-swf" > /> > > > > > Is how it gets built now locally. Intuitively debug info should not be > part of the release but I need to look into it further. > > From: Josh Tynjala > Sent: Tuesday, March 28, 2023 6:17 PM > To: dev@royale.apache.org > Subject: Re: 0.9.10 Release > > Hey Yishay, > > I recently made a commit that adds the swf-debugfile-alias compiler option > for SWC files built by Maven. This compiler option was being used by Ant > already, but it never got added to the Maven build. And I think that > binaries would fail comparison without it. This may be why Release Step 11 > was failing for you. > > Basically, swf-debugfile-alias ensures that the debugging information in > the SWC doesn't include the local path to the .as/.mxml source files > (starting with something like C:\Users\joshtynjala\ or /Users/CoolGuy19/). > Instead, it sets a generic path that will always match among builds from > different machines. Considering this was missing, it sure sounds like a > reason why binary comparison would fail. > > -- > Josh Tynjala > Bowler Hat LLC <https://bowlerhat.dev> > > > On Wed, Feb 22, 2023 at 10:38 AM Yishay Weiss > wrote: > > > FYI I am put this on hold about 2 weeks ago after failing to debug a > > binary reproducibility issue in as-js repo. > > > > @Harbs<mailto:harbs.li...@gmail.com>, can you see if the same issue > > exists for you? > > > > You can follow instructions [1] and tell me if step 2 succeeded or failed > > for you. > > > > Thanks. > > > > [1] > > > apacheroyale.francecentral.cloudapp.azure.com:8080/job/Royale_Release_Step_011/ws/Success-5.txt > > < > > > http://apacheroyale.francecentral.cloudapp.azure.com:8080/job/Royale_Release_Step_011/ws/Success-5.txt > > > > > > > From: Josh Tynjala > > Sent: Tuesday, January 17, 2023 10:08 PM > > To: dev@royale.apache.org > > Subject: Re: 0.9.10 Release > > > > Oops! I meant NO further changes. Sorry about that. You're good to go on > my > > end. > > > > -- > > Josh Tynjala > > Bowler Hat LLC <https://bowlerhat.dev> > > > > > > On Tue, Jan 17, 2023 at 11:32 AM Yishay Weiss > > wrote: > > > > > Thanks for the update, let me know when to pull the trigger. > > > > > > Get Outlook for Android<https://aka.ms/AAb9ysg> > > > > > > From: Josh Tynjala > > > Sent: Tuesday, January 17, 2023 7:05:29 PM > > > To: dev@royale.apache.org > > > Subject: Re: 0.9.10 Release > > > > > > I've updated the release notes with my changes. I have further changes > > > planned before the release. > > > > > > -- > > > Josh Tynjala > > > Bowler Hat LLC <https://bowlerhat.dev> > > > > > > > > > On Mon, Jan 16, 2023 at 12:40 AM Yishay Weiss > > > wrote: > > > > > > > Hi Guys, > > > > > > > > We’re starting a new release soon. As it’s been a while and I expect > > some > > > > issues I have agreed with Harbs to do this release. 0.9.11 should be > > > easier > > > > if we don’t wait too long, so the goal is for a different volunteer > to > > do > > > > the next one. > > > > > > > > If anybody wants to commit changes they are welcome to do so now, and > > > > update the release notes. > > > > > > > > Please make sure the integration tests are working post commits. > > > > > > > > Thanks, > > > > Yishay > > > > > > > > > >
Re: 0.9.10 Release
Hey Yishay, I recently made a commit that adds the swf-debugfile-alias compiler option for SWC files built by Maven. This compiler option was being used by Ant already, but it never got added to the Maven build. And I think that binaries would fail comparison without it. This may be why Release Step 11 was failing for you. Basically, swf-debugfile-alias ensures that the debugging information in the SWC doesn't include the local path to the .as/.mxml source files (starting with something like C:\Users\joshtynjala\ or /Users/CoolGuy19/). Instead, it sets a generic path that will always match among builds from different machines. Considering this was missing, it sure sounds like a reason why binary comparison would fail. -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Wed, Feb 22, 2023 at 10:38 AM Yishay Weiss wrote: > FYI I am put this on hold about 2 weeks ago after failing to debug a > binary reproducibility issue in as-js repo. > > @Harbs<mailto:harbs.li...@gmail.com>, can you see if the same issue > exists for you? > > You can follow instructions [1] and tell me if step 2 succeeded or failed > for you. > > Thanks. > > [1] > apacheroyale.francecentral.cloudapp.azure.com:8080/job/Royale_Release_Step_011/ws/Success-5.txt > < > http://apacheroyale.francecentral.cloudapp.azure.com:8080/job/Royale_Release_Step_011/ws/Success-5.txt > > > > From: Josh Tynjala > Sent: Tuesday, January 17, 2023 10:08 PM > To: dev@royale.apache.org > Subject: Re: 0.9.10 Release > > Oops! I meant NO further changes. Sorry about that. You're good to go on my > end. > > -- > Josh Tynjala > Bowler Hat LLC <https://bowlerhat.dev> > > > On Tue, Jan 17, 2023 at 11:32 AM Yishay Weiss > wrote: > > > Thanks for the update, let me know when to pull the trigger. > > > > Get Outlook for Android<https://aka.ms/AAb9ysg> > > > > From: Josh Tynjala > > Sent: Tuesday, January 17, 2023 7:05:29 PM > > To: dev@royale.apache.org > > Subject: Re: 0.9.10 Release > > > > I've updated the release notes with my changes. I have further changes > > planned before the release. > > > > -- > > Josh Tynjala > > Bowler Hat LLC <https://bowlerhat.dev> > > > > > > On Mon, Jan 16, 2023 at 12:40 AM Yishay Weiss > > wrote: > > > > > Hi Guys, > > > > > > We’re starting a new release soon. As it’s been a while and I expect > some > > > issues I have agreed with Harbs to do this release. 0.9.11 should be > > easier > > > if we don’t wait too long, so the goal is for a different volunteer to > do > > > the next one. > > > > > > If anybody wants to commit changes they are welcome to do so now, and > > > update the release notes. > > > > > > Please make sure the integration tests are working post commits. > > > > > > Thanks, > > > Yishay > > > > > >
Re: Issue compiling Royale
I'm just shooting in the dark here about what might be different about our systems. One thing I noticed in your logs is that the royale-asjs repo seems to be checked out on an external drive. /System/Volumes/Data/Apache/royale-asjs vs /Users/harbs/ What if you checked it out somewhere inside /Users/harbs/ instead? I don't know why that would matter, but you never know. -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Thu, Mar 16, 2023 at 12:52 PM Harbs wrote: > It definitely seems like some kind of socket issue or an issue with the > debugger loading the swfs. > > I have the trust entries. > > I locally modified the RoyaleUnitSocketThread class to continue on a > request. > > That allowed it to run without an error, but the swf tests report no > results (they all look like this): > > [mkdir] Created dir: > /System/Volumes/Data/Apache/royale-asjs/frameworks/projects/Network/src/test/royale/out > [royaleunit] Validating task attributes ... > [royaleunit] Generating default values ... > [royaleunit] Using the following settings for the test run: > [royaleunit]ROYALE_HOME: [/System/Volumes/Data/Apache/royale-asjs] > [royaleunit]haltonfailure: [true] > [royaleunit]headless: [false] > [royaleunit]display: [99] > [royaleunit]localTrusted: [true] > [royaleunit]player: [flash] > [royaleunit]port: [1024] > [royaleunit]swf: > [/System/Volumes/Data/Apache/royale-asjs/frameworks/projects/Network/src/test/royale/FlexUnitRoyaleApplication.swf] > [royaleunit]timeout: [9ms] > [royaleunit]toDir: > [/System/Volumes/Data/Apache/royale-asjs/frameworks/projects/Network/src/test/royale/out] > [royaleunit] Entry > [/System/Volumes/Data/Apache/royale-asjs/frameworks/projects/Network/src/test/royale] > already available in local trust file at > [/Users/harbs/Library/Preferences/Macromedia/Flash > Player/#Security/FlashPlayerTrust/royaleUnit.cfg]. > [royaleunit] Setting up server process ... > [royaleunit] Starting server ... > [royaleunit] Executing 'open' with arguments: > [royaleunit] > '/System/Volumes/Data/Apache/royale-asjs/frameworks/projects/Network/src/test/royale/FlexUnitRoyaleApplication.swf' > [royaleunit] > [royaleunit] The ' characters around the executable and arguments are > [royaleunit] not part of the command. > [royaleunit] > [royaleunit] Opening server socket on port [1024]. > [royaleunit] Waiting for client connection ... > [royaleunit] Client connected. > [royaleunit] Setting inbound buffer size to [262144] bytes. > [royaleunit] Receiving data ... > [royaleunit] Sending acknowledgement to player to start sending test data > ... > [royaleunit] > [royaleunit] > [royaleunit] Stopping server ... > [royaleunit] End of test data reached, sending acknowledgement to player > ... > [royaleunit] Closing client connection ... > [royaleunit] Closing server on port [1024] ... > [royaleunit] Analyzing reports ... > [royaleunit] > [royaleunit] > [royaleunit] Results : > [royaleunit] > [royaleunit] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time > elapsed: 0.000 sec > [royaleunit] > > > > On Mar 16, 2023, at 9:28 PM, Josh Tynjala > wrote: > > > >> java -version > > openjdk version "11.0.17" 2022-10-18 > > OpenJDK Runtime Environment Temurin-11.0.17+8 (build 11.0.17+8) > > OpenJDK 64-Bit Server VM Temurin-11.0.17+8 (build 11.0.17+8, mixed mode) > > > >> ant -version > > Apache Ant(TM) version 1.10.12 compiled on October 13 2021 > > > > Flash Player.app (Flash Player Debugger) 32.0.0.465 > > > > macOS Ventura 13.2.1 (M1) > > > > -- > > Josh Tynjala > > Bowler Hat LLC <https://bowlerhat.dev> > > > > > > On Thu, Mar 16, 2023 at 12:06 PM Alex Harui > > wrote: > > > >> Josh, what version of Java and Ant and FlashPlayer are you using? > >> > >> -Alex > >> > >> On 3/16/23, 10:33 AM, "Josh Tynjala" >> joshtynj...@bowlerhat.dev>> wrote: > >> > >> > >> EXTERNAL: Use caution when clicking on links or opening attachments. > >> > >> > >> > >> > >> The RoyaleUnit Ant task runs a socket server in Java that Flash Player > >> connects to (for JS, it runs a web socket server instead). > >> > >> > >> -- > >> Josh Tynjala > >> Bowler Hat LLC < > >> > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbowlerhat.dev%2F=05%7C01%7Caharui%40adobe.com%7C7666c0f10dc14f6a3d7308db2644874f%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C638145847995199118%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2
Re: Issue compiling Royale
> java -version openjdk version "11.0.17" 2022-10-18 OpenJDK Runtime Environment Temurin-11.0.17+8 (build 11.0.17+8) OpenJDK 64-Bit Server VM Temurin-11.0.17+8 (build 11.0.17+8, mixed mode) > ant -version Apache Ant(TM) version 1.10.12 compiled on October 13 2021 Flash Player.app (Flash Player Debugger) 32.0.0.465 macOS Ventura 13.2.1 (M1) -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Thu, Mar 16, 2023 at 12:06 PM Alex Harui wrote: > Josh, what version of Java and Ant and FlashPlayer are you using? > > -Alex > > On 3/16/23, 10:33 AM, "Josh Tynjala" joshtynj...@bowlerhat.dev>> wrote: > > > EXTERNAL: Use caution when clicking on links or opening attachments. > > > > > The RoyaleUnit Ant task runs a socket server in Java that Flash Player > connects to (for JS, it runs a web socket server instead). > > > -- > Josh Tynjala > Bowler Hat LLC < > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbowlerhat.dev%2F=05%7C01%7Caharui%40adobe.com%7C7666c0f10dc14f6a3d7308db2644874f%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C638145847995199118%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C=B8%2F7B%2F8ejXv4OReitk%2BDM6QRAEG2azHXH4WfH7ah37w%3D=0> > < > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbowlerhat.dev%2Fdata=05%7C01%7Caharui%40adobe.com%7C7666c0f10dc14f6a3d7308db2644874f%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C638145847995199118%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7Csdata=B8%2F7B%2F8ejXv4OReitk%2BDM6QRAEG2azHXH4WfH7ah37w%3Dreserved=0 > ;> > > > > > On Thu, Mar 16, 2023 at 10:14 AM Alex Harui <mailto:aha...@adobe.com.inva>lid> > wrote: > > > > Does RoyaleUnit use a socket or access a server? What version of Java and > > Ant are you using? > > > > On 3/16/23, 9:58 AM, "Harbs" harbs.li...@gmail.com> > harbs.li...@gmail.com <mailto:harbs.li...@gmail.com>>> wrote: > > > > > > EXTERNAL: Use caution when clicking on links or opening attachments. > > > > > > > > > > That was actually a different computer and I don’t know if I ever got > that > > to work. > > > > > > > On Mar 16, 2023, at 6:10 PM, Josh Tynjala <mailto:joshtynj...@bowlerhat.dev> > > <mailto:joshtynj...@bowlerhat.dev <mailto:joshtynj...@bowlerhat.dev>>> > wrote: > > > > > > It looks like you had the same issue a year ago when you initially got > > your > > > new Mac: > > > > > > > > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.apache.org%2Fthread%2Fwxkvx2c00fjdktdd3ot55wfn04nfz463=05%7C01%7Caharui%40adobe.com%7C7666c0f10dc14f6a3d7308db2644874f%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C638145847995199118%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C=QRMMDv%2FvuogBtKKTWQc0HGER2bC803iMSeMiKyRhmpY%3D=0 > < > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.apache.org%2Fthread%2Fwxkvx2c00fjdktdd3ot55wfn04nfz463data=05%7C01%7Caharui%40adobe.com%7C7666c0f10dc14f6a3d7308db2644874f%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C638145847995199118%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7Csdata=QRMMDv%2FvuogBtKKTWQc0HGER2bC803iMSeMiKyRhmpY%3Dreserved=0 > > > > < > > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.apache.org%2Fthread%2Fwxkvx2c00fjdktdd3ot55wfn04nfz463=05%7C01%7Caharui%40adobe.com%7C7666c0f10dc14f6a3d7308db2644874f%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C638145847995199118%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C=QRMMDv%2FvuogBtKKTWQc0HGER2bC803iMSeMiKyRhmpY%3D=0 > < > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.apache.org%2Fthread%2Fwxkvx2c00fjdktdd3ot55wfn04nfz463data=05%7C01%7Caharui%40adobe.com%7C7666c0f10dc14f6a3d7308db2644874f%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C638145847995199118%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7Csdata=QRMMDv%2FvuogBtKKTWQc0HGER2bC803iMSeMiKyRhmpY%3Dreserved=0 > > > > > > > > > > > -- > > > Josh Tynjala > > > Bowler Hat LLC < > > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbowlerhat.dev%2F=05%7C01%7Caharui%40adobe.com%7C7666c0f10dc14f6a3d7308db2644874f%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C638145847995199118%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwM
Re: Issue compiling Royale
The RoyaleUnit Ant task runs a socket server in Java that Flash Player connects to (for JS, it runs a web socket server instead). -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Thu, Mar 16, 2023 at 10:14 AM Alex Harui wrote: > Does RoyaleUnit use a socket or access a server? What version of Java and > Ant are you using? > > On 3/16/23, 9:58 AM, "Harbs" harbs.li...@gmail.com>> wrote: > > > EXTERNAL: Use caution when clicking on links or opening attachments. > > > > > That was actually a different computer and I don’t know if I ever got that > to work. > > > > On Mar 16, 2023, at 6:10 PM, Josh Tynjala <mailto:joshtynj...@bowlerhat.dev>> wrote: > > > > It looks like you had the same issue a year ago when you initially got > your > > new Mac: > > > > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.apache.org%2Fthread%2Fwxkvx2c00fjdktdd3ot55wfn04nfz463=05%7C01%7Caharui%40adobe.com%7C58d0e111382348be6c3108db263fbaa2%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C638145827380784460%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C=k%2FYHBcQhqAfT3JsWDogQbUzniC%2BKglQpUSJ8I9DoSmg%3D=0 > < > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.apache.org%2Fthread%2Fwxkvx2c00fjdktdd3ot55wfn04nfz463data=05%7C01%7Caharui%40adobe.com%7C58d0e111382348be6c3108db263fbaa2%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C638145827380784460%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7Csdata=k%2FYHBcQhqAfT3JsWDogQbUzniC%2BKglQpUSJ8I9DoSmg%3Dreserved=0 > > > > > > -- > > Josh Tynjala > > Bowler Hat LLC < > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbowlerhat.dev%2F=05%7C01%7Caharui%40adobe.com%7C58d0e111382348be6c3108db263fbaa2%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C638145827380784460%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C=CdG8avLJsslVfcwqr62ac2Nv4IZGyq5JI8mZCh2901g%3D=0> > < > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbowlerhat.dev%2Fdata=05%7C01%7Caharui%40adobe.com%7C58d0e111382348be6c3108db263fbaa2%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C638145827380784460%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7Csdata=CdG8avLJsslVfcwqr62ac2Nv4IZGyq5JI8mZCh2901g%3Dreserved=0 > ;> > > > > > > On Thu, Mar 16, 2023 at 5:19 AM Harbs harbs.li...@gmail.com>> wrote: > > > >> I recently upgraded my MacBook Pro to Ventura. > >> > >> When trying to compile Royale, I’m getting the following error. Any > ideas > >> what to do? > >> > >> > /System/Volumes/Data/Apache/royale-asjs/frameworks/projects/Basic/src/test/royale/build.xml:102: > >> java.util.concurrent.ExecutionException: command > [] > >> not understood > >> at java.util.concurrent.FutureTask.report(FutureTask.java:122) > >> at java.util.concurrent.FutureTask.get(FutureTask.java:192) > >> at org.apache.royale.test.ant.tasks.TestRun.run(TestRun.java:93) > >> at > >> > org.apache.royale.test.ant.tasks.RoyaleUnitTask.execute(RoyaleUnitTask.java:201) > >> at > >> org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:299) > >> at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown Source) > >> at > >> > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > >> at java.lang.reflect.Method.invoke(Method.java:498) > >> at > >> > org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:99) > >> at org.apache.tools.ant.Task.perform(Task.java:350) > >> at org.apache.tools.ant.Target.execute(Target.java:449) > >> at org.apache.tools.ant.Target.performTasks(Target.java:470) > >> at > >> org.apache.tools.ant.Project.executeSortedTargets(Project.java:1401) > >> at > >> > org.apache.tools.ant.helper.SingleCheckExecutor.executeTargets(SingleCheckExecutor.java:36) > >> at org.apache.tools.ant.Project.executeTargets(Project.java:1264) > >> at org.apache.tools.ant.taskdefs.Ant.execute(Ant.java:437) > >> at > >> org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:299) > >> at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown Source) > >> at > >> > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > >> at java.lang.reflect.Method.invoke(Method.java:498) > >> at > >> > o
Re: Issue compiling Royale
It looks like you had the same issue a year ago when you initially got your new Mac: https://lists.apache.org/thread/wxkvx2c00fjdktdd3ot55wfn04nfz463 -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Thu, Mar 16, 2023 at 5:19 AM Harbs wrote: > I recently upgraded my MacBook Pro to Ventura. > > When trying to compile Royale, I’m getting the following error. Any ideas > what to do? > > /System/Volumes/Data/Apache/royale-asjs/frameworks/projects/Basic/src/test/royale/build.xml:102: > java.util.concurrent.ExecutionException: command [] > not understood > at java.util.concurrent.FutureTask.report(FutureTask.java:122) > at java.util.concurrent.FutureTask.get(FutureTask.java:192) > at org.apache.royale.test.ant.tasks.TestRun.run(TestRun.java:93) > at > org.apache.royale.test.ant.tasks.RoyaleUnitTask.execute(RoyaleUnitTask.java:201) > at > org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:299) > at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown Source) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:99) > at org.apache.tools.ant.Task.perform(Task.java:350) > at org.apache.tools.ant.Target.execute(Target.java:449) > at org.apache.tools.ant.Target.performTasks(Target.java:470) > at > org.apache.tools.ant.Project.executeSortedTargets(Project.java:1401) > at > org.apache.tools.ant.helper.SingleCheckExecutor.executeTargets(SingleCheckExecutor.java:36) > at org.apache.tools.ant.Project.executeTargets(Project.java:1264) > at org.apache.tools.ant.taskdefs.Ant.execute(Ant.java:437) > at > org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:299) > at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown Source) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:99) > at org.apache.tools.ant.Task.perform(Task.java:350) > at org.apache.tools.ant.Target.execute(Target.java:449) > at org.apache.tools.ant.Target.performTasks(Target.java:470) > at > org.apache.tools.ant.Project.executeSortedTargets(Project.java:1401) > at > org.apache.tools.ant.helper.SingleCheckExecutor.executeTargets(SingleCheckExecutor.java:36) > at org.apache.tools.ant.Project.executeTargets(Project.java:1264) > at org.apache.tools.ant.taskdefs.Ant.execute(Ant.java:437) > at > org.apache.tools.ant.taskdefs.CallTarget.execute(CallTarget.java:106) > at > org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:299) > at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown Source) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:99) > at org.apache.tools.ant.Task.perform(Task.java:350) > at org.apache.tools.ant.Target.execute(Target.java:449) > at org.apache.tools.ant.Target.performTasks(Target.java:470) > at > org.apache.tools.ant.Project.executeSortedTargets(Project.java:1401) > at > org.apache.tools.ant.helper.SingleCheckExecutor.executeTargets(SingleCheckExecutor.java:36) > at org.apache.tools.ant.Project.executeTargets(Project.java:1264) > at org.apache.tools.ant.taskdefs.Ant.execute(Ant.java:437) > at > org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:299) > at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown Source) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:99) > at org.apache.tools.ant.Task.perform(Task.java:350) > at org.apache.tools.ant.Target.execute(Target.java:449) > at org.apache.tools.ant.Target.performTasks(Target.java:470) > at > org.apache.tools.ant.Project.executeSortedTargets(Project.java:1401) > at > org.apache.tools.ant.helper.SingleCheckExecutor.executeTargets(SingleCheckExecutor.java:36) > at org.apache.tools.ant.Project.executeTargets(Project.java:1264) > at org.apache.tools.ant.taskdefs.Ant.execute
Re: Clear the cache strategy
I think some JS bundling tools generate a short hash (like SHA or MD5) based on the contents of the file. Just a possible alternative to using a version string. The Royale compiler doesn't support doing anything like that automatically, but I don't see why you couldn't write a shell script to run a post-processing step after compiling. If you want something supported by the Royale compiler, you'd probably need to create a custom index.html template for the release build. Instead of letting the compiler inject the tag, you could hard-code it manually. -- Josh Tynjala Bowler Hat LLC <<a rel="nofollow" href="https://bowlerhat.dev">https://bowlerhat.dev</a>> On Thu, Mar 9, 2023 at 12:43 PM Hugo Ferreira <hferreira...@gmail.com> wrote: > Hi, > > I'm releasing now updates more often and sometimes (many times), the > browser cache my App.js > In a quick google search I found a solution (more a workaround) => > <a rel="nofollow" href="https://stackoverflow.com/questions/1011605/clear-the-cache-in-javascript">https://stackoverflow.com/questions/1011605/clear-the-cache-in-javascript</a> > When I build - release with VS Code, it inject this line on my html > file:<script type="text/javascript" src="./App.js"> > So, I don't have control over it. > > What I would like to do is something like have a version flag of my App in > the asconfig.json and when I build - relase the compiler inject something > like: > > ... > > This is possible today ? > > Regards, > Hugo. >
Re: playerglobal in maven repo?
flex-sdk-converter-maven-extension 1.1.0 has been officially released. The develop branch of the royale-compiler, royale-typedefs, and royale-asjs repositories now use this new version. It resolves the issue where playerglobal.swc could not be downloaded by Maven. -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Thu, Feb 2, 2023 at 3:31 PM Josh Tynjala wrote: > In order to resolve this issue, I'm starting the release process for > flex-sdk-converter-maven-extension 1.1.0. As release manager, I just > submitted RC 1 to the Flex PMC. If you are a member of the Flex PMC, please > go try it out, and add your +1 vote, if things look okay. > > To build the flex-sdk-converter-maven-extension source release, extract > the .zip file and run `mvn clean install` in the root directory with > pom.xml. > > OPTIONAL: After installing RC1 locally, you can also test that it works > with royale-compiler. Here's what you need to do: > > (Prerequisite: Make sure that you have the FLASHPLAYER_DEBUGGER env var > pointing to a Flash Player projector executable. If you don't have this > executable already, the royale-compiler README explains how you can still > download it from Adobe.) > > 1. In royale-compiler, go into .mvn/extensions.xml and replace the version > number with 1.1.0 > 2. Go into ~/.m2/repository/com/adobe/flash/ and move the "framework" > directory somewhere else temporarily. This lets you put it back later, if > something goes wrong. > 3. In royale-compiler, run `mvn clean install -P option-with-swf`. > > -- > Josh Tynjala > Bowler Hat LLC <https://bowlerhat.dev> > > > On Thu, Feb 2, 2023 at 1:01 PM Josh Tynjala > wrote: > >> Just replying with the error message you get if you forget `-s >> settings-template.xml` so that it will show up in search. >> >> [ERROR] Extension >> org.apache.flex.utilities.converter:flex-sdk-converter-maven-extension:1.1.0-SNAPSHOT >> or one of its dependencies could not be resolved: Could not find artifact >> org.apache.flex.utilities.converter:flex-sdk-converter-maven-extension:jar:1.1.0-SNAPSHOT >> >> It means that you're missing `-s settings-template.xml`. So you need to >> run `mvn install -s settings-template.xml` instead of just `mvn install`. >> -- >> Josh Tynjala >> Bowler Hat LLC <https://bowlerhat.dev> >> >> >> On Wed, Feb 1, 2023 at 9:19 AM Josh Tynjala >> wrote: >> >>> I deployed flex-sdk-converter-extension 1.1.0-SNAPSHOT to Apache >>> snapshots to allow testing of my bugfix. I updated the royale-compiler >>> develop branch to use it, along with playerglobal 32.0 instead of 20.0 >>> because Adobe no longer makes 20.0 available for download. >>> >>> Similar to how it worked in the past, before >>> flex-sdk-converter-extension 1.0 was released, you are now required to tell >>> Maven to use settings-template.xml (but I think only the first time) to >>> find this snapshot when building royale-compiler. >>> >>> mvn clean install -P option-with-swf -s settings-template.xml >>> >>> Using settings-template.xml is temporary. I plan to start the full >>> release process for 1.1.0 as soon as others verify that it's working for >>> them too. So please pull from the develop branch of royale-compiler and try >>> to build using the command above. Thanks! >>> >>> I'll hold off on updating royale-asjs to use 1.1.0-SNAPSHOT and >>> playerglobal 32.0 until Yishay creates the release branch in that repo, so >>> that the release branches remain in sync. >>> >>> -- >>> Josh Tynjala >>> Bowler Hat LLC <https://bowlerhat.dev> >>> >>> >>> On Tue, Jan 31, 2023 at 12:24 PM Josh Tynjala >>> wrote: >>> >>>> I think I want to try publishing flex-sdk-converter-extension >>>> 1.1.0-SNAPSHOT to Apache's Maven snapshots repo. Then, we can use the "-s >>>> settings-template.xml" trick to get our build to use that snapshot version. >>>> This is how we did it with 1.0.0-SNAPSHOT before Chris released the proper >>>> 1.0.0. That'll at least get us unstuck. Later, I'll try to do a proper >>>> release of 1.1.0. >>>> >>>> -- >>>> Josh Tynjala >>>> Bowler Hat LLC <https://bowlerhat.dev> >>>> >>>> >>>> On Tue, Jan 31, 2023 at 10:23 AM Josh Tynjala < >>>> joshtynj...@bowlerhat.dev> wrote: >>>> >>>>> Okay, I rebuilt flex-sdk-converter-extension on my local machine (it's >>>>> in t
Re: [EXTERNAL] Binding inside the html property has stopped working
My change actually fixed a bug in the Royale compiler. Binding with {} is
not supposed to work inside CData. This change brings the Royale compiler
closer to the behavior of the Flex compiler.
So you'll need to change your code.
--
Josh Tynjala
Bowler Hat LLC <https://bowlerhat.dev>
On Mon, Feb 13, 2023 at 11:53 AM Maria Jose Esteve
wrote:
> Hi Brian, thanks for replying.
> Yes, they did work and I really liked it
> If Josh said he can't make it compatible, I would do it as you tell me
> with the html attribute directly.
>
> Thx.
> Hiedra
>
> -Mensaje original-
> De: Brian Raymes
> Enviado el: lunes, 13 de febrero de 2023 20:19
> Para: dev@royale.apache.org
> Asunto: RE: [EXTERNAL] Binding inside the html property has stopped working
>
> I don't believe bindings work within CDATA blocks?
>
> This should work:
>
> html="{reg.nombre}br{reg.apellido1}br{reg.apellido2}"/>
>
>
> Brian
>
> -Original Message-
> From: Maria Jose Esteve
> Sent: Monday, February 13, 2023 10:33 AM
> To: dev@royale.apache.org
> Subject: [EXTERNAL] Binding inside the html property has stopped working
>
> Greetings to all,
> After a couple of months of unemployment, I have been able to resume the
> Royale project and I have encountered a problem in my itemRenderers: The
> bindings included in the html property of a Label control are displayed as
> is, not replaced by the expected binded value. [1]
>
> The code:
>
>
>
>
>
> Or
>
>
>
>
>
> [1]
> https://drive.google.com/file/d/1WNm_hi2HtU71JaVWGNQgbtr4ukSsbulD/view?usp=share_link
>
> I have identified the source of the problem in Josh's December 7, 2022
> commits:
>
> MXMLTreeBuilder: fix CData handling with [CollapseWhiteSpace] metadata
> (closes #213) Josh Tynjala joshtynj...@apache.org joshtynj...@apache.org> d50913c14b5b998a82a14e6c14592ad24995e3e2
> 07/12/2022 23:18:34
> MXMLDataBindingParser: use constant instead of literal Josh Tynjala
> joshtynj...@apache.org<mailto:joshtynj...@apache.org>
> 1c3acfe9767359e35fd6fe0607d22be0946243db 07/12/2022 21:39:55
> MXMLDataBindingParser: fix data binding being incorrectly detected inside
> CData text (references #213) Josh Tynjala joshtynj...@apache.org joshtynj...@apache.org> e570d87f621837b2dc9e6eafa4de9a79f89600fb
> 07/12/2022 19:00:22
> MXMLRoyaleEmitter: remove dead code that was causing a null exception
> (closes #216) Josh Tynjala joshtynj...@apache.org joshtynj...@apache.org> 053ea997fcaa1d15b2b3efe77de7ffc10bdb13b5
> 07/12/2022 18:05:55
>
> @Josh, can this be fixed or do I have to implement it some other way?
> Thx.
> Hiedra
>
>
Re: playerglobal in maven repo?
In order to resolve this issue, I'm starting the release process for flex-sdk-converter-maven-extension 1.1.0. As release manager, I just submitted RC 1 to the Flex PMC. If you are a member of the Flex PMC, please go try it out, and add your +1 vote, if things look okay. To build the flex-sdk-converter-maven-extension source release, extract the .zip file and run `mvn clean install` in the root directory with pom.xml. OPTIONAL: After installing RC1 locally, you can also test that it works with royale-compiler. Here's what you need to do: (Prerequisite: Make sure that you have the FLASHPLAYER_DEBUGGER env var pointing to a Flash Player projector executable. If you don't have this executable already, the royale-compiler README explains how you can still download it from Adobe.) 1. In royale-compiler, go into .mvn/extensions.xml and replace the version number with 1.1.0 2. Go into ~/.m2/repository/com/adobe/flash/ and move the "framework" directory somewhere else temporarily. This lets you put it back later, if something goes wrong. 3. In royale-compiler, run `mvn clean install -P option-with-swf`. -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Thu, Feb 2, 2023 at 1:01 PM Josh Tynjala wrote: > Just replying with the error message you get if you forget `-s > settings-template.xml` so that it will show up in search. > > [ERROR] Extension > org.apache.flex.utilities.converter:flex-sdk-converter-maven-extension:1.1.0-SNAPSHOT > or one of its dependencies could not be resolved: Could not find artifact > org.apache.flex.utilities.converter:flex-sdk-converter-maven-extension:jar:1.1.0-SNAPSHOT > > It means that you're missing `-s settings-template.xml`. So you need to > run `mvn install -s settings-template.xml` instead of just `mvn install`. > -- > Josh Tynjala > Bowler Hat LLC <https://bowlerhat.dev> > > > On Wed, Feb 1, 2023 at 9:19 AM Josh Tynjala > wrote: > >> I deployed flex-sdk-converter-extension 1.1.0-SNAPSHOT to Apache >> snapshots to allow testing of my bugfix. I updated the royale-compiler >> develop branch to use it, along with playerglobal 32.0 instead of 20.0 >> because Adobe no longer makes 20.0 available for download. >> >> Similar to how it worked in the past, before flex-sdk-converter-extension >> 1.0 was released, you are now required to tell Maven to use >> settings-template.xml (but I think only the first time) to find this >> snapshot when building royale-compiler. >> >> mvn clean install -P option-with-swf -s settings-template.xml >> >> Using settings-template.xml is temporary. I plan to start the full >> release process for 1.1.0 as soon as others verify that it's working for >> them too. So please pull from the develop branch of royale-compiler and try >> to build using the command above. Thanks! >> >> I'll hold off on updating royale-asjs to use 1.1.0-SNAPSHOT and >> playerglobal 32.0 until Yishay creates the release branch in that repo, so >> that the release branches remain in sync. >> >> -- >> Josh Tynjala >> Bowler Hat LLC <https://bowlerhat.dev> >> >> >> On Tue, Jan 31, 2023 at 12:24 PM Josh Tynjala >> wrote: >> >>> I think I want to try publishing flex-sdk-converter-extension >>> 1.1.0-SNAPSHOT to Apache's Maven snapshots repo. Then, we can use the "-s >>> settings-template.xml" trick to get our build to use that snapshot version. >>> This is how we did it with 1.0.0-SNAPSHOT before Chris released the proper >>> 1.0.0. That'll at least get us unstuck. Later, I'll try to do a proper >>> release of 1.1.0. >>> >>> -- >>> Josh Tynjala >>> Bowler Hat LLC <https://bowlerhat.dev> >>> >>> >>> On Tue, Jan 31, 2023 at 10:23 AM Josh Tynjala >>> wrote: >>> >>>> Okay, I rebuilt flex-sdk-converter-extension on my local machine (it's >>>> in the flex-utilities repo, for anyone interested). If I change the URL for >>>> sdk-installer-config-4.0.xml from http to https, it successfully downloads. >>>> >>>> So, for some reason, the 301 redirect is not being handled correctly. >>>> Presumably, something changed on the server. Perhaps it was still serving >>>> http in the past, and it was forced to https more recently. >>>> >>>> I found this explanation about redirects in Java: >>>> >>>> > After discussion among Java Networking engineers, it is felt that we >>>> shouldn't automatically follow redirect from one protocol to another, for >>>> instance, from http to https and vise versa, doing so may have serious >>>>
Re: playerglobal in maven repo?
Just replying with the error message you get if you forget `-s settings-template.xml` so that it will show up in search. [ERROR] Extension org.apache.flex.utilities.converter:flex-sdk-converter-maven-extension:1.1.0-SNAPSHOT or one of its dependencies could not be resolved: Could not find artifact org.apache.flex.utilities.converter:flex-sdk-converter-maven-extension:jar:1.1.0-SNAPSHOT It means that you're missing `-s settings-template.xml`. So you need to run `mvn install -s settings-template.xml` instead of just `mvn install`. -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Wed, Feb 1, 2023 at 9:19 AM Josh Tynjala wrote: > I deployed flex-sdk-converter-extension 1.1.0-SNAPSHOT to Apache snapshots > to allow testing of my bugfix. I updated the royale-compiler develop branch > to use it, along with playerglobal 32.0 instead of 20.0 because Adobe no > longer makes 20.0 available for download. > > Similar to how it worked in the past, before flex-sdk-converter-extension > 1.0 was released, you are now required to tell Maven to use > settings-template.xml (but I think only the first time) to find this > snapshot when building royale-compiler. > > mvn clean install -P option-with-swf -s settings-template.xml > > Using settings-template.xml is temporary. I plan to start the full release > process for 1.1.0 as soon as others verify that it's working for them too. > So please pull from the develop branch of royale-compiler and try to build > using the command above. Thanks! > > I'll hold off on updating royale-asjs to use 1.1.0-SNAPSHOT and > playerglobal 32.0 until Yishay creates the release branch in that repo, so > that the release branches remain in sync. > > -- > Josh Tynjala > Bowler Hat LLC <https://bowlerhat.dev> > > > On Tue, Jan 31, 2023 at 12:24 PM Josh Tynjala > wrote: > >> I think I want to try publishing flex-sdk-converter-extension >> 1.1.0-SNAPSHOT to Apache's Maven snapshots repo. Then, we can use the "-s >> settings-template.xml" trick to get our build to use that snapshot version. >> This is how we did it with 1.0.0-SNAPSHOT before Chris released the proper >> 1.0.0. That'll at least get us unstuck. Later, I'll try to do a proper >> release of 1.1.0. >> >> -- >> Josh Tynjala >> Bowler Hat LLC <https://bowlerhat.dev> >> >> >> On Tue, Jan 31, 2023 at 10:23 AM Josh Tynjala >> wrote: >> >>> Okay, I rebuilt flex-sdk-converter-extension on my local machine (it's >>> in the flex-utilities repo, for anyone interested). If I change the URL for >>> sdk-installer-config-4.0.xml from http to https, it successfully downloads. >>> >>> So, for some reason, the 301 redirect is not being handled correctly. >>> Presumably, something changed on the server. Perhaps it was still serving >>> http in the past, and it was forced to https more recently. >>> >>> I found this explanation about redirects in Java: >>> >>> > After discussion among Java Networking engineers, it is felt that we >>> shouldn't automatically follow redirect from one protocol to another, for >>> instance, from http to https and vise versa, doing so may have serious >>> security consequences. Thus the fix is to return the server responses for >>> redirect. Check response code and Location header field value for redirect >>> information. It's the application's responsibility to follow the redirect. >>> >>> Looks like flex-sdk-converter-extension needs to update this URL and get >>> a new release, since the redirect from http to https won't work. >>> >>> -- >>> Josh Tynjala >>> Bowler Hat LLC <https://bowlerhat.dev> >>> >>> >>> On Tue, Jan 31, 2023 at 9:24 AM Josh Tynjala >>> wrote: >>> >>>> I tried changing to playerglobal 32.0, and it is still failing. >>>> Interestingly, I see these lower level exceptions in the log when I add the >>>> -X option to mvn: >>>> >>>> Caused by: >>>> org.apache.flex.utilities.converter.retrievers.exceptions.RetrieverException: >>>> Error parsing 'sdk-installer-config-4.0.xml' >>>> Caused by: org.xml.sax.SAXParseException: Premature end of file. >>>> >>>> So it's trying to download >>>> http://flex.apache.org/installer/sdk-installer-config-4.0.xml (where >>>> it will find the URL to playerglobal.swc), and something is going wrong >>>> parsing that file. >>>> >>>> It seems to be valid XML, so maybe it's getting some kind of error >>>> document from the
Re: playerglobal in maven repo?
I deployed flex-sdk-converter-extension 1.1.0-SNAPSHOT to Apache snapshots to allow testing of my bugfix. I updated the royale-compiler develop branch to use it, along with playerglobal 32.0 instead of 20.0 because Adobe no longer makes 20.0 available for download. Similar to how it worked in the past, before flex-sdk-converter-extension 1.0 was released, you are now required to tell Maven to use settings-template.xml (but I think only the first time) to find this snapshot when building royale-compiler. mvn clean install -P option-with-swf -s settings-template.xml Using settings-template.xml is temporary. I plan to start the full release process for 1.1.0 as soon as others verify that it's working for them too. So please pull from the develop branch of royale-compiler and try to build using the command above. Thanks! I'll hold off on updating royale-asjs to use 1.1.0-SNAPSHOT and playerglobal 32.0 until Yishay creates the release branch in that repo, so that the release branches remain in sync. -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Tue, Jan 31, 2023 at 12:24 PM Josh Tynjala wrote: > I think I want to try publishing flex-sdk-converter-extension > 1.1.0-SNAPSHOT to Apache's Maven snapshots repo. Then, we can use the "-s > settings-template.xml" trick to get our build to use that snapshot version. > This is how we did it with 1.0.0-SNAPSHOT before Chris released the proper > 1.0.0. That'll at least get us unstuck. Later, I'll try to do a proper > release of 1.1.0. > > -- > Josh Tynjala > Bowler Hat LLC <https://bowlerhat.dev> > > > On Tue, Jan 31, 2023 at 10:23 AM Josh Tynjala > wrote: > >> Okay, I rebuilt flex-sdk-converter-extension on my local machine (it's in >> the flex-utilities repo, for anyone interested). If I change the URL for >> sdk-installer-config-4.0.xml from http to https, it successfully downloads. >> >> So, for some reason, the 301 redirect is not being handled correctly. >> Presumably, something changed on the server. Perhaps it was still serving >> http in the past, and it was forced to https more recently. >> >> I found this explanation about redirects in Java: >> >> > After discussion among Java Networking engineers, it is felt that we >> shouldn't automatically follow redirect from one protocol to another, for >> instance, from http to https and vise versa, doing so may have serious >> security consequences. Thus the fix is to return the server responses for >> redirect. Check response code and Location header field value for redirect >> information. It's the application's responsibility to follow the redirect. >> >> Looks like flex-sdk-converter-extension needs to update this URL and get >> a new release, since the redirect from http to https won't work. >> >> -- >> Josh Tynjala >> Bowler Hat LLC <https://bowlerhat.dev> >> >> >> On Tue, Jan 31, 2023 at 9:24 AM Josh Tynjala >> wrote: >> >>> I tried changing to playerglobal 32.0, and it is still failing. >>> Interestingly, I see these lower level exceptions in the log when I add the >>> -X option to mvn: >>> >>> Caused by: >>> org.apache.flex.utilities.converter.retrievers.exceptions.RetrieverException: >>> Error parsing 'sdk-installer-config-4.0.xml' >>> Caused by: org.xml.sax.SAXParseException: Premature end of file. >>> >>> So it's trying to download >>> http://flex.apache.org/installer/sdk-installer-config-4.0.xml (where it >>> will find the URL to playerglobal.swc), and something is going wrong >>> parsing that file. >>> >>> It seems to be valid XML, so maybe it's getting some kind of error >>> document from the web server instead of the proper file. >>> >>> I'll keep digging... >>> >>> -- >>> Josh Tynjala >>> Bowler Hat LLC <https://bowlerhat.dev> >>> >>> >>> On Tue, Jan 31, 2023 at 8:47 AM Josh Tynjala >>> wrote: >>> >>>> I seem to recall that Adobe stopped making most older versions of >>>> playerglobal.swc available for download from their servers. I think it >>>> might be only version 32.0 that's still available. >>>> >>>> We have flash.version set to 20.0 in our pom.xml: >>>> >>>> 20.0 >>>> >>>> We might need to change that to 32.0. >>>> >>>> Most of us wouldn't notice that the download wasn't available because >>>> we installed playerglobal months/years ago, before Adobe removed their >>>> downloads, and the Maven extension probably doesn't try to download
Re: playerglobal in maven repo?
I think I want to try publishing flex-sdk-converter-extension 1.1.0-SNAPSHOT to Apache's Maven snapshots repo. Then, we can use the "-s settings-template.xml" trick to get our build to use that snapshot version. This is how we did it with 1.0.0-SNAPSHOT before Chris released the proper 1.0.0. That'll at least get us unstuck. Later, I'll try to do a proper release of 1.1.0. -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Tue, Jan 31, 2023 at 10:23 AM Josh Tynjala wrote: > Okay, I rebuilt flex-sdk-converter-extension on my local machine (it's in > the flex-utilities repo, for anyone interested). If I change the URL for > sdk-installer-config-4.0.xml from http to https, it successfully downloads. > > So, for some reason, the 301 redirect is not being handled correctly. > Presumably, something changed on the server. Perhaps it was still serving > http in the past, and it was forced to https more recently. > > I found this explanation about redirects in Java: > > > After discussion among Java Networking engineers, it is felt that we > shouldn't automatically follow redirect from one protocol to another, for > instance, from http to https and vise versa, doing so may have serious > security consequences. Thus the fix is to return the server responses for > redirect. Check response code and Location header field value for redirect > information. It's the application's responsibility to follow the redirect. > > Looks like flex-sdk-converter-extension needs to update this URL and get a > new release, since the redirect from http to https won't work. > > -- > Josh Tynjala > Bowler Hat LLC <https://bowlerhat.dev> > > > On Tue, Jan 31, 2023 at 9:24 AM Josh Tynjala > wrote: > >> I tried changing to playerglobal 32.0, and it is still failing. >> Interestingly, I see these lower level exceptions in the log when I add the >> -X option to mvn: >> >> Caused by: >> org.apache.flex.utilities.converter.retrievers.exceptions.RetrieverException: >> Error parsing 'sdk-installer-config-4.0.xml' >> Caused by: org.xml.sax.SAXParseException: Premature end of file. >> >> So it's trying to download >> http://flex.apache.org/installer/sdk-installer-config-4.0.xml (where it >> will find the URL to playerglobal.swc), and something is going wrong >> parsing that file. >> >> It seems to be valid XML, so maybe it's getting some kind of error >> document from the web server instead of the proper file. >> >> I'll keep digging... >> >> -- >> Josh Tynjala >> Bowler Hat LLC <https://bowlerhat.dev> >> >> >> On Tue, Jan 31, 2023 at 8:47 AM Josh Tynjala >> wrote: >> >>> I seem to recall that Adobe stopped making most older versions of >>> playerglobal.swc available for download from their servers. I think it >>> might be only version 32.0 that's still available. >>> >>> We have flash.version set to 20.0 in our pom.xml: >>> >>> 20.0 >>> >>> We might need to change that to 32.0. >>> >>> Most of us wouldn't notice that the download wasn't available because we >>> installed playerglobal months/years ago, before Adobe removed their >>> downloads, and the Maven extension probably doesn't try to download it >>> again, if it's already available locally. >>> >>> I'm going to try to see if I can mess with my local Maven cache to >>> trigger this error on my computer. >>> >>> -- >>> Josh Tynjala >>> Bowler Hat LLC <https://bowlerhat.dev> >>> >>> >>> On Tue, Jan 31, 2023 at 8:35 AM Josh Tynjala >>> wrote: >>> >>>> We use some kind of Maven plugin/extension that downloads >>>> playerglobal.swc from Adobe. >>>> >>>> I think it's the flex-sdk-converter-maven-extension referenced in >>>> .mvn/extensions.xml >>>> >>>> -- >>>> Josh Tynjala >>>> Bowler Hat LLC <https://bowlerhat.dev> >>>> >>>> >>>> On Tue, Jan 31, 2023 at 7:43 AM Yishay Weiss >>>> wrote: >>>> >>>>> Compiler release is failing [1] due to playerglobal not being found in >>>>> maven repo. I checked and I can’t find com.adobe.flash there [2] any >>>>> ideas? >>>>> >>>>> [1] Royale_Release_Step_002 #9 Console [Jenkins] (azure.com)< >>>>> http://apacheroyale.francecentral.cloudapp.azure.com:8080/job/Royale_Release_Step_002/lastBuild/console >>>>> > >>>>> [2] Central Repository: com/adobe (apache.org)< >>>>> https://repo.maven.apache.org/maven2/com/adobe/> >>>>> >>>>
Re: playerglobal in maven repo?
Okay, I rebuilt flex-sdk-converter-extension on my local machine (it's in the flex-utilities repo, for anyone interested). If I change the URL for sdk-installer-config-4.0.xml from http to https, it successfully downloads. So, for some reason, the 301 redirect is not being handled correctly. Presumably, something changed on the server. Perhaps it was still serving http in the past, and it was forced to https more recently. I found this explanation about redirects in Java: > After discussion among Java Networking engineers, it is felt that we shouldn't automatically follow redirect from one protocol to another, for instance, from http to https and vise versa, doing so may have serious security consequences. Thus the fix is to return the server responses for redirect. Check response code and Location header field value for redirect information. It's the application's responsibility to follow the redirect. Looks like flex-sdk-converter-extension needs to update this URL and get a new release, since the redirect from http to https won't work. -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Tue, Jan 31, 2023 at 9:24 AM Josh Tynjala wrote: > I tried changing to playerglobal 32.0, and it is still failing. > Interestingly, I see these lower level exceptions in the log when I add the > -X option to mvn: > > Caused by: > org.apache.flex.utilities.converter.retrievers.exceptions.RetrieverException: > Error parsing 'sdk-installer-config-4.0.xml' > Caused by: org.xml.sax.SAXParseException: Premature end of file. > > So it's trying to download > http://flex.apache.org/installer/sdk-installer-config-4.0.xml (where it > will find the URL to playerglobal.swc), and something is going wrong > parsing that file. > > It seems to be valid XML, so maybe it's getting some kind of error > document from the web server instead of the proper file. > > I'll keep digging... > > -- > Josh Tynjala > Bowler Hat LLC <https://bowlerhat.dev> > > > On Tue, Jan 31, 2023 at 8:47 AM Josh Tynjala > wrote: > >> I seem to recall that Adobe stopped making most older versions of >> playerglobal.swc available for download from their servers. I think it >> might be only version 32.0 that's still available. >> >> We have flash.version set to 20.0 in our pom.xml: >> >> 20.0 >> >> We might need to change that to 32.0. >> >> Most of us wouldn't notice that the download wasn't available because we >> installed playerglobal months/years ago, before Adobe removed their >> downloads, and the Maven extension probably doesn't try to download it >> again, if it's already available locally. >> >> I'm going to try to see if I can mess with my local Maven cache to >> trigger this error on my computer. >> >> -- >> Josh Tynjala >> Bowler Hat LLC <https://bowlerhat.dev> >> >> >> On Tue, Jan 31, 2023 at 8:35 AM Josh Tynjala >> wrote: >> >>> We use some kind of Maven plugin/extension that downloads >>> playerglobal.swc from Adobe. >>> >>> I think it's the flex-sdk-converter-maven-extension referenced in >>> .mvn/extensions.xml >>> >>> -- >>> Josh Tynjala >>> Bowler Hat LLC <https://bowlerhat.dev> >>> >>> >>> On Tue, Jan 31, 2023 at 7:43 AM Yishay Weiss >>> wrote: >>> >>>> Compiler release is failing [1] due to playerglobal not being found in >>>> maven repo. I checked and I can’t find com.adobe.flash there [2] any ideas? >>>> >>>> [1] Royale_Release_Step_002 #9 Console [Jenkins] (azure.com)< >>>> http://apacheroyale.francecentral.cloudapp.azure.com:8080/job/Royale_Release_Step_002/lastBuild/console >>>> > >>>> [2] Central Repository: com/adobe (apache.org)< >>>> https://repo.maven.apache.org/maven2/com/adobe/> >>>> >>>
Re: playerglobal in maven repo?
I tried changing to playerglobal 32.0, and it is still failing. Interestingly, I see these lower level exceptions in the log when I add the -X option to mvn: Caused by: org.apache.flex.utilities.converter.retrievers.exceptions.RetrieverException: Error parsing 'sdk-installer-config-4.0.xml' Caused by: org.xml.sax.SAXParseException: Premature end of file. So it's trying to download http://flex.apache.org/installer/sdk-installer-config-4.0.xml (where it will find the URL to playerglobal.swc), and something is going wrong parsing that file. It seems to be valid XML, so maybe it's getting some kind of error document from the web server instead of the proper file. I'll keep digging... -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Tue, Jan 31, 2023 at 8:47 AM Josh Tynjala wrote: > I seem to recall that Adobe stopped making most older versions of > playerglobal.swc available for download from their servers. I think it > might be only version 32.0 that's still available. > > We have flash.version set to 20.0 in our pom.xml: > > 20.0 > > We might need to change that to 32.0. > > Most of us wouldn't notice that the download wasn't available because we > installed playerglobal months/years ago, before Adobe removed their > downloads, and the Maven extension probably doesn't try to download it > again, if it's already available locally. > > I'm going to try to see if I can mess with my local Maven cache to trigger > this error on my computer. > > -- > Josh Tynjala > Bowler Hat LLC <https://bowlerhat.dev> > > > On Tue, Jan 31, 2023 at 8:35 AM Josh Tynjala > wrote: > >> We use some kind of Maven plugin/extension that downloads >> playerglobal.swc from Adobe. >> >> I think it's the flex-sdk-converter-maven-extension referenced in >> .mvn/extensions.xml >> >> -- >> Josh Tynjala >> Bowler Hat LLC <https://bowlerhat.dev> >> >> >> On Tue, Jan 31, 2023 at 7:43 AM Yishay Weiss >> wrote: >> >>> Compiler release is failing [1] due to playerglobal not being found in >>> maven repo. I checked and I can’t find com.adobe.flash there [2] any ideas? >>> >>> [1] Royale_Release_Step_002 #9 Console [Jenkins] (azure.com)< >>> http://apacheroyale.francecentral.cloudapp.azure.com:8080/job/Royale_Release_Step_002/lastBuild/console >>> > >>> [2] Central Repository: com/adobe (apache.org)< >>> https://repo.maven.apache.org/maven2/com/adobe/> >>> >>
Re: playerglobal in maven repo?
I seem to recall that Adobe stopped making most older versions of playerglobal.swc available for download from their servers. I think it might be only version 32.0 that's still available. We have flash.version set to 20.0 in our pom.xml: 20.0 We might need to change that to 32.0. Most of us wouldn't notice that the download wasn't available because we installed playerglobal months/years ago, before Adobe removed their downloads, and the Maven extension probably doesn't try to download it again, if it's already available locally. I'm going to try to see if I can mess with my local Maven cache to trigger this error on my computer. -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Tue, Jan 31, 2023 at 8:35 AM Josh Tynjala wrote: > We use some kind of Maven plugin/extension that downloads playerglobal.swc > from Adobe. > > I think it's the flex-sdk-converter-maven-extension referenced in > .mvn/extensions.xml > > -- > Josh Tynjala > Bowler Hat LLC <https://bowlerhat.dev> > > > On Tue, Jan 31, 2023 at 7:43 AM Yishay Weiss > wrote: > >> Compiler release is failing [1] due to playerglobal not being found in >> maven repo. I checked and I can’t find com.adobe.flash there [2] any ideas? >> >> [1] Royale_Release_Step_002 #9 Console [Jenkins] (azure.com)< >> http://apacheroyale.francecentral.cloudapp.azure.com:8080/job/Royale_Release_Step_002/lastBuild/console >> > >> [2] Central Repository: com/adobe (apache.org)< >> https://repo.maven.apache.org/maven2/com/adobe/> >> >
Re: playerglobal in maven repo?
We use some kind of Maven plugin/extension that downloads playerglobal.swc from Adobe. I think it's the flex-sdk-converter-maven-extension referenced in .mvn/extensions.xml -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Tue, Jan 31, 2023 at 7:43 AM Yishay Weiss wrote: > Compiler release is failing [1] due to playerglobal not being found in > maven repo. I checked and I can’t find com.adobe.flash there [2] any ideas? > > [1] Royale_Release_Step_002 #9 Console [Jenkins] (azure.com)< > http://apacheroyale.francecentral.cloudapp.azure.com:8080/job/Royale_Release_Step_002/lastBuild/console > > > [2] Central Repository: com/adobe (apache.org)< > https://repo.maven.apache.org/maven2/com/adobe/> >
Re: 0.9.10 Release
Oops! I meant NO further changes. Sorry about that. You're good to go on my end. -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Tue, Jan 17, 2023 at 11:32 AM Yishay Weiss wrote: > Thanks for the update, let me know when to pull the trigger. > > Get Outlook for Android<https://aka.ms/AAb9ysg> > ________ > From: Josh Tynjala > Sent: Tuesday, January 17, 2023 7:05:29 PM > To: dev@royale.apache.org > Subject: Re: 0.9.10 Release > > I've updated the release notes with my changes. I have further changes > planned before the release. > > -- > Josh Tynjala > Bowler Hat LLC <https://bowlerhat.dev> > > > On Mon, Jan 16, 2023 at 12:40 AM Yishay Weiss > wrote: > > > Hi Guys, > > > > We’re starting a new release soon. As it’s been a while and I expect some > > issues I have agreed with Harbs to do this release. 0.9.11 should be > easier > > if we don’t wait too long, so the goal is for a different volunteer to do > > the next one. > > > > If anybody wants to commit changes they are welcome to do so now, and > > update the release notes. > > > > Please make sure the integration tests are working post commits. > > > > Thanks, > > Yishay > > >
Re: 0.9.10 Release
I've updated the release notes with my changes. I have further changes planned before the release. -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Mon, Jan 16, 2023 at 12:40 AM Yishay Weiss wrote: > Hi Guys, > > We’re starting a new release soon. As it’s been a while and I expect some > issues I have agreed with Harbs to do this release. 0.9.11 should be easier > if we don’t wait too long, so the goal is for a different volunteer to do > the next one. > > If anybody wants to commit changes they are welcome to do so now, and > update the release notes. > > Please make sure the integration tests are working post commits. > > Thanks, > Yishay >
Re: Compiler not buiding in Ant, any ideas?
While I was working on the new AS3 language syntax from AIR 50, I noticed
that changes to the RawASTokenizer.lex file wouldn't be included in the
compiler .jar files unless I ran `ant clean` first. Perhaps our build
script has an assumption that the core AS3 token syntax doesn't change much.
With that in mind, cloning a fresh copy of the repo would require the .lex
files to be processed, similarly to a clean build.
--
Josh Tynjala
Bowler Hat LLC <https://bowlerhat.dev>
On Sun, Dec 4, 2022 at 3:21 AM Yishay Weiss wrote:
> Not sure what was happening there, but cloning from repo and running ant
> scripts does seem to work.
>
> From: Yishay Weiss<mailto:yishayj...@hotmail.com>
> Sent: Sunday, December 4, 2022 11:20 AM
> To: dev@royale.apache.org<mailto:dev@royale.apache.org>
> Subject: Compiler not buiding in Ant, any ideas?
>
>
> tests:
> [junit] Running as.ASAbstractClassTests
> [junit] looking for
> C:\dev\full_royale_sdk\royale-compiler\env.properties
> [junit] environment property - FLEX_HOME =
> C:\MoonshineSDKs\Flex_SDK\Flex_4.16.1_AIR_32.0
> [junit] environment property - PLAYERGLOBAL_HOME = C:\dev\player
> [junit] environment property - PLAYERGLOBAL_VERSION = 11.1
> [junit] environment property - TLF_HOME = null
> [junit] environment property - AIR_HOME =
> C:\MoonshineSDKs\Flex_SDK\Flex_4.16.1_AIR_32.0
> [junit] environment property - FLASHPLAYER_DEBUGGER =
> C:\dev\content_debugger\flashplayer_32_sa_debug.exe
> [junit] environment property - ASJS_HOME =
> C:\dev\full_royale_sdk\royale-asjs
> [junit] environment property - GOOG_HOME = c:\dev\goog_home
> [junit] Generating test:
> [junit] Compiling test:
> [junit] -external-library-path=C:\dev\player\11.1\playerglobal.swc
> -allow-abstract-classes=true
> C:\dev\full_royale_sdk\royale-compiler\compiler\target\junit-temp\ASAbstractClassTests2513614478
> 847439910.as
> [junit]
> [junit] 794 bytes written to
> C:\dev\full_royale_sdk\royale-compiler\compiler\target\junit-temp\ASAbstractClassTests2513614478847439910.swf
> in 0.842 seconds
> [junit] After compile:
> [junit]
> [junit] Generating test:
> [junit] Compiling test:
> [junit] -external-library-path=C:\dev\player\11.1\playerglobal.swc
> -allow-abstract-classes=true
> C:\dev\full_royale_sdk\royale-compiler\compiler\target\junit-temp\ASAbstractClassTests1794492585
> 075857429.as
> [junit]
> [junit] After compile:
> [junit]
> C:\dev\full_royale_sdk\royale-compiler\compiler\target\junit-temp\ASAbstractClassTests1794492585
> 075857429.as(15): col: 9 Internal error: Unable to generate code for 'var'
> [junit]
> [junit] var obj:A = new B();
> [junit] Unexpected compilation problems:
> [junit] Unable to generate code for 'var'
> [junit] ^
> [junit]
> [junit]
> [junit] Generating test:
> [junit] Compiling test:
> [junit] -external-library-path=C:\dev\player\11.1\playerglobal.swc
> -allow-abstract-classes=true
> C:\dev\full_royale_sdk\royale-compiler\compiler\target\junit-temp\ASAbstractClassTests7943759737
> 369516615.as
> [junit]
> [junit] 786 bytes written to
> C:\dev\full_royale_sdk\royale-compiler\compiler\target\junit-temp\ASAbstractClassTests7943759737369516615.swf
> in 0.198 seconds
> [junit] After compile:
> [junit]
> [junit] Generating test:
> [junit] Compiling test:
> [junit] -external-library-path=C:\dev\player\11.1\playerglobal.swc
> -allow-abstract-classes=true
> C:\dev\full_royale_sdk\royale-compiler\compiler\target\junit-temp\ASAbstractClassTests1620344814
> 896536570.as
> [junit]
>[junit] 791 bytes written to
> C:\dev\full_royale_sdk\royale-compiler\compiler\target\junit-temp\ASAbstractClassTests1620344814896536570.swf
> in 0.211 seconds
> [junit] After compile:
> [junit]
> [junit] Generating test:
> [junit] Compiling test:
>[junit] -external-library-path=C:\dev\player\11.1\playerglobal.swc
> -allow-abstract-classes=true
> C:\dev\full_royale_sdk\royale-compiler\compiler\target\junit-temp\ASAbstractClassTests9104213270
> 379958485.as
> [junit]
> [junit]
> C:\dev\full_royale_sdk\royale-compiler\compiler\target\junit-temp\ASAbstractClassTests9104213270
> 379958485.as(34): col: 7 Error: Method b in abstract class B not
> implemented by class C
> [junit]
> [junit] class C extends B {
> [junit] ^
> [junit]
> [junit]
> C:\dev\full_royale_sdk\royale-compiler\compiler\target\junit-temp\ASAbstractClassTests9104213270
> 379958485.as(34): col: 7 Error: Method a in abstract class A not
> implemented by class C
> [junit]
> [junit] class C exten
Using Java 11 for Royale jobs on ci-builds.apache.org
Hey team, I just wanted to mention that I did a little maintenance to our Royale jobs that run on ci-builds.apache.org today. In particular, I updated the jobs to run using Java 11 instead of Java 8. The reason I changed this is because Jenkins seems to require Java 11 as the minimum version now, as mentioned in this blog post from earlier this year: https://www.jenkins.io/blog/2022/06/28/require-java-11/ I discovered the new minimum requirement after I noticed that some of our builds were failing intermittently with the following message: java.lang.UnsupportedClassVersionError: hudson/remoting/Launcher has been compiled by a more recent version of the Java Runtime (class file version 55.0), this version of the Java Runtime only recognizes class file versions up to 52.0 Class file version 55.0 is used by Java 11 and class file version 52.0 is used by Java 8. To be clear, this change only affects ci-builds.apache.org, and Royale can still be built with Java 8 in other environments. -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev>
Re: Error compiling the SDK
My latest commits should fix the build issue. Please let me know if you run into any further problems. -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Tue, Nov 29, 2022 at 8:52 AM Maria Jose Esteve wrote: > Hello, > with the latest unit tests the compilation ends with error. > The error occurs when compiling royale-asjs with ant. > > In my case I compile first with maven and then with ant: > > call ant clean > call ant super-clean > call mvn clean install -DskipTests -P > option-with-sass-compile,option-with-swf -Drat.skip=true > call ant all -Dbuild.noprompt=true -Drelease.target=true -Dskip-tests=true > > Hiedra > >
Re: Error compiling the SDK
I am working on fixing the compiler tests. I'm not sure how to reproduce it on my machine yet. -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Tue, Nov 29, 2022 at 8:52 AM Maria Jose Esteve wrote: > Hello, > with the latest unit tests the compilation ends with error. > The error occurs when compiling royale-asjs with ant. > > In my case I compile first with maven and then with ant: > > call ant clean > call ant super-clean > call mvn clean install -DskipTests -P > option-with-sass-compile,option-with-swf -Drat.skip=true > call ant all -Dbuild.noprompt=true -Drelease.target=true -Dskip-tests=true > > Hiedra > >
Re: New CI Update
It looks like I created a property in the royale-asjs build named
royaleunit.browser to allow someone request a specific installed web
browser to run RoyaleUnit tests. If royaleunit.browser is not set,
RoyaleUnit will use Playwright. So -Dbrowser won't affect it (but maybe it
was used before I added Playwright support). You could add
-Droyaleunit.browser, but I recommend avoiding that on the CI server and
just let it use Playwright. I added royaleunit.browser mostly to give folks
the ability to customize their local build environment, if desired.
Looking over royale-asjs, it appears that ${browser} is still used for
examples and release candidate stuff, though.
--
Josh Tynjala
Bowler Hat LLC <https://bowlerhat.dev>
On Tue, Nov 15, 2022 at 5:50 AM Yishay Weiss wrote:
> Hi,
>
>
>
> I have imported most of the settings from Alex’s CI instance. People can
> look at current state in
>
>
>
> http://apacheroyale.francecentral.cloudapp.azure.com:8080
>
>
>
> Or play around with it using RDP. The credentials are same as Alex’s CI.
>
>
>
> Currently I’m trying to figure out a royale-asjs failure [1] which I
> suspect has to do with browser instances for unit tests.
>
>
>
> @Josh Tynjala , I found your post on the
> playwright [2] changes you made. Do these mean playwright is the default,
> and does this param [3] interfere with that?
>
>
>
> [1]
> http://apacheroyale.francecentral.cloudapp.azure.com:8080/job/royale-asjs/13/console
>
> [2] Using Playwright for RoyaleUnit JS testing-Apache Mail Archives
> <https://lists.apache.org/thread/l3rkhq8q9vrtocot907mrq4cbxj3z1bk>
>
> [3] '"-Dbrowser=C:\Program Files\Mozilla Firefox\firefox.exe"'
>
>
>
> Thanks
>
>
>
Re: Jenkins (was Re: Introducing asformat)
I can successfully load http://apacheroyaleci2.westus2.cloudapp.azure.com:8080 in my browser. It looks like the builds are running. It appears that build failure emails aren't getting sent, though. This is from the royale-asjs_jsonly console log: > Sending e-mails to: royale-bui...@royale.apache.org > ERROR: 535-5.7.8 Username and Password not accepted. Learn more at > 535 5.7.8 https://support.google.com/mail/?p=BadCredentials g4-20020a6544c400b00439f027789asm2672501pgs.59 - gsmtp -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Fri, Oct 28, 2022 at 8:39 AM Alex Harui wrote: > Looks like I was able to recover it and move it to my new subscription. > Can someone else verify? > > -Alex > > From: Yishay Weiss > Date: Saturday, October 22, 2022 at 3:54 AM > To: Alex Harui , "dev@royale.apache.org" < > dev@royale.apache.org>, Maria Jose Esteve > Subject: Re: Jenkins (was Re: Introducing asformat) > > > EXTERNAL: Use caution when clicking on links or opening attachments. > > > Thanks for the update. > > Get Outlook for Android< > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Faka.ms%2FAAb9ysg=05%7C01%7Caharui%40adobe.com%7Cb76c1bfcc9dc45f9f83f08dab41bb87e%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C638020328414901525%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C=WXHc8nAvise3FKzmn344k6s8yXWg8CZvFK6GpNEv51k%3D=0 > > > > From: Alex Harui > Sent: Saturday, October 22, 2022 5:05:53 AM > To: Yishay Weiss ; dev@royale.apache.org < > dev@royale.apache.org>; Maria Jose Esteve > Subject: Re: Jenkins (was Re: Introducing asformat) > > > I logged into the Azure portal. The Jenkins VM is listed but against a > disabled subscription. For some reason I was given a new subscription id > instead of renewing the old one. I created a support ticket to see if they > can let me run that VM again. We’ll see. > > > > -Alex > > > > From: Yishay Weiss > Date: Thursday, October 20, 2022 at 11:50 PM > To: Alex Harui , "dev@royale.apache.org" < > dev@royale.apache.org>, Maria Jose Esteve > Subject: RE: Jenkins (was Re: Introducing asformat) > > > > EXTERNAL: Use caution when clicking on links or opening attachments. > > > > >. Not sure if we’ve made changes since, > > > > I did make some changes in Jenkins job and in VM env (maybe Josh did as > well). > > > > Can you gather from the emails you got if files were permanently deleted > and if there are recovery paths? > > From: Alex Harui<mailto:aha...@adobe.com> > Sent: Friday, October 21, 2022 9:36 AM > To: Yishay Weiss<mailto:yishayj...@hotmail.com>; dev@royale.apache.org > <mailto:dev@royale.apache.org>; Maria Jose Esteve<mailto:mjest...@iest.com > > > Subject: Jenkins (was Re: Introducing asformat) > > > > I was wondering when someone would notice that Jenkins CI was down. > > > > My free subscription expired several weeks ago and due to the renewal > notices going to spam and renewal forms handled by volunteers, my new free > subscription didn’t get renewed until recently. I have not had time to > look, but some notices said that resources would be deleted, so I won’t be > surprised to find the VM’s disk is empty. I might have time to look this > weekend. > > > > I do have Jenkins screenshots saved from when I first set up the jobs. > Not sure if we’ve made changes since, and Jenkins UI might have changed. > But if the disk is empty and I can’t recover the disk data, probably the > next best option is to just try to recreate the jobs on Yishay’s VM. > > > > -Alex > > > > From: Yishay Weiss > Date: Wednesday, October 19, 2022 at 9:46 AM > To: "dev@royale.apache.org" , Alex Harui < > aha...@adobe.com>, Maria Jose Esteve > Subject: RE: Introducing asformat > > > > EXTERNAL: Use caution when clicking on links or opening attachments. > > > > * I don't feel able to help you with any of this but, Yishay, if you > teach me I can be your backup for the releases. > > @Maria Jose Esteve<mailto:mjest...@iest.com>, the first step in getting a > release done is making sure all builds on CI are running without issue. For > that we will need the CI to be up and running. > > > > @Alex Harui<mailto:aha...@adobe.com>, It looks like CI is down. Can you > take a look? I hope to work on creating my own CI next week. > > > > Thanks. > > > > From: Maria Jose Esteve<mailto:mjest...@iest.com> > Sent: Wednesday, September 28, 2022 11:00 PM > To: dev@ro
Re: HTML
To build a single project, you can run ant from the project directory: cd frameworks/projects/Jewel ant -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Tue, Oct 18, 2022 at 1:59 PM Hugo Ferreira wrote: > Fixed, tested and commit done :) > > Usually I fix using CodEditor (a kind of Notepad++ for macOS) and then "ant > clean" and then "ant all". > It takes more then 30 minutes on my machine ! > For things more complex I test integrated on my project using VS Code and > then I put the code in the SDK, compile and test. > > For this particular use case, how could I acelerate my workflow ? > > > > Harbs escreveu no dia terça, 18/10/2022 à(s) > 21:53: > > > FYI, it’s not necessary to compile the whole SDK unless your current > build > > is old. You can compile a single SWC at a time. > > > > > On Oct 18, 2022, at 11:51 PM, Hugo Ferreira > > wrote: > > > > > > Yes, it's exactly what I'm doing right now. > > > Compiling the SDK on my machine takes the time to dinner and even so, > > > probably it's not finished yet ! > > > I hope next year, I update my MacBook :) > > > > > > Harbs escreveu no dia terça, 18/10/2022 à(s) > > 21:38: > > > > > >> Let’s see what others think, but in the meantime there’s no reason to > > not > > >> fix the bug. There are other html setters which already set innerHTML. > > >> > > >> Harbs > > >> > > >>> On Oct 18, 2022, at 11:29 PM, Hugo Ferreira > > >> wrote: > > >>> > > >>> Yes, I saw that helper (I searched for it name) :) > > >>> Yes, it's exactly what I mean: put this in one of the limites of the > > >>> workflow and never in the middle. > > >>> That's my opinion. > > >>> > > >>> > > >>> > > >>> Harbs escreveu no dia terça, 18/10/2022 à(s) > > >> 08:06: > > >>> > > >>>> There’s a sanitizeHTML helper function that’s relatively new. > > >>>> > > >>>> I don’t have a strong opinion on whether it should be sanitized by > > >> default > > >>>> or that should be the application developer’s responsibility. > > >>>> > > >>>> As far as PAYG is concerned, it’s better to put the responsibility > on > > >> the > > >>>> app developer. > > >>>> > > >>>> As far as security is concerned, it would be better to sanitize in > the > > >>>> framework. > > >>>> > > >>>> I personally would give precedence to PAYG because the threat of a > XSS > > >>>> attack using innerHTML is a bit of a stretch in Royale. > > >>>> > > >>>> We should come up with a policy, document it, and stick to it across > > the > > >>>> framework. > > >>>> > > >>>> If we do sanitize in the components, it should probably happen in > the > > >>>> model setter. > > >>>> > > >>>> What do others think? > > >>>> > > >>>>> On Oct 18, 2022, at 2:32 AM, Hugo Ferreira > > > >>>> wrote: > > >>>>> > > >>>>> Thank you very much. > > >>>>> I see the bug. > > >>>>> I hope that the Label (html property) that FormHeading that depends > > on, > > >>>>> doesn't have the same issue :) > > >>>>> > > >>>>> About the sanitize: > > >>>>> Should this be really a reponsibility of FormHeadingView !? > > >>>>> Shouldn't the responsibility on one of the edges (the limit of html > > >>>>> property core or on the end application) ? > > >>>>> In the middle, we could ending "sanitizing" too much just to be > > ensure. > > >>>>> > > >>>>> > > >>>>> > > >>>>> Harbs escreveu no dia segunda, 17/10/2022 > > à(s) > > >>>>> 19:25: > > >>>>> > > >>>>>> I assume this is Jewel. I don’t use Jewel, but I just looked at > > >>>>>> FormHeadingView and textChangeHandler is used for both textChange > > and > > >>>>>> htmlChange. In both cases it sets the text rather than html in the > > >>>>>> htmlChange case. That seems to be broken. > > >>>>>> > > >>>>>> If you fix this, make sure the html is sanitized when applied. > > >>>>>> > > >>>>>> Harbs > > >>>>>> > > >>>>>>> On Oct 16, 2022, at 5:17 PM, Hugo Ferreira < > hferreira...@gmail.com > > > > > >>>>>> wrote: > > >>>>>>> > > >>>>>>> Hi, > > >>>>>>> > > >>>>>>> I'm using FormHeading when I have a lot of fields and want to > > create > > >> a > > >>>>>>> vertical separation (group of data). > > >>>>>>> It's OK, however I needed now to use in the FormHeading texto > some > > >> HTML > > >>>>>>> (basic stuff like strong and br), however the property "text" of > > >>>>>>> FormHeading it's for simple real strings and not HTML. > > >>>>>>> I saw the html property, however this property does nothing. > > >>>>>>> It's something that it's not already implemented in the core or > I'm > > >>>>>> missing > > >>>>>>> something ? > > >>>>>>> > > >>>>>>> I saw tht I can workaround, using a pure html:Div with innerHTML > > but > > >> I > > >>>>>> have > > >>>>>>> read in the past that I should avoid it. > > >>>>>> > > >>>>>> > > >>>> > > >>>> > > >> > > >> > > > > >
Re: Ignore warning: duplicate variable
I think that the compiler option to turn off this particular warning is: -warn-duplicate-variable-def You will likely need to add it in additionalOptions instead of compilerOptions in asconfig.json. -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Sun, Oct 9, 2022 at 1:54 PM Hugo Ferreira wrote: > Hi, > > With the latest SDK, I start getting false warnings about duplicate > variable. > BTW, I never like this warning when was true. > How can I ignore warnings about duplicate variables using VS Code ? >
Re: Compile error about linter
Interesting. I see that royale-asjs sets the javac.src property, which gets inherited by the royale-compiler build when running ant all. I just pushed a commit to royale-asjs to fix it. -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Wed, Oct 5, 2022 at 4:27 PM Hugo Ferreira wrote: > Hi, > > I'm getting now the following error (about linter) when I try to compile > with the following command: ant all > > [javac] (use -source 8 or higher to enable lambda expressions) > > > I already update JAVA to latest version (19) but the error persist. >
Re: Introducing asformat
Around 2015 or so, I had never worked on a compiler, formatter, or linter.
I started trying to use the Royale compiler (still called the FlexJS
compiler at the time) to create the AS3/MXML extension for VSCode. Soon, I
found a bug in the compiler that prevented my VSCode extension from working
properly. I tried my best to understand a small section of the compiler's
code, and I was able to fix the bug and submit a pull request. Eventually,
I fixed some more bugs, and I was asked to join the project as a
contributor. Since then, I've learned how larger and larger parts of the
compiler work. To be honest, it took probably 5-7 years before I really
felt that I understood most of what the compiler was doing. It just takes a
lot of time and persistence.
Recently, I was able to recognize that I could reuse large parts of the
compiler's code to create a formatter and a linter for ActionScript (the
ActionScript language name is where the "as" prefix of "asformat" and
"aslint" comes from, of course). I had never created a formatter or a
linter before, and it took some trial and error to figure out the best way
to do things. For the formatter, I tried to format one little thing first,
like `if (condition) {}` or something like that. Then, I slowly added more
and more (for, while, try/catch, class A extends B, etc.). It took months
of work, which was built on my previous years of work understanding and
maintaining the compiler.
Honestly, like most of everything I've ever tried to learn, I started with
one small thing. Don't try to understand everything all at once. At least
not in detail. It's often fine to have a general idea of how something
works at a high-level, even if you don't understand it completely. Then,
you can dive into the details later. Anyway, over the course of years
working on the same thing, you can really learn a lot.
--
Josh Tynjala
Bowler Hat LLC <https://bowlerhat.dev>
On Wed, Sep 28, 2022 at 1:00 PM Maria Jose Esteve wrote:
> How can you know about so many things? asformat, aslint, linter... omg,
> you guys never cease to amaze me... I had to look up the meaning of each of
> these words :(
>
> I don't feel able to help you with any of this but, Yishay, if you teach
> me I can be your backup for the releases.
>
> Hiedra
>
> -Mensaje original-
> De: Yishay Weiss
> Enviado el: miércoles, 28 de septiembre de 2022 20:16
> Para: dev@royale.apache.org
> Asunto: RE: Introducing asformat
>
> It's great to see this progress. I expect to see as-linter replacing
> SonarQube in our current project. Do you think it would be hard to
> integrate it with GitHub actions?
>
> The -watch option is already being used and is a big productivity boost.
>
> I expect I'll make use of asformat at some point as well. Thanks for all
> this Josh.
>
> I may get some time at the end of this month to work on a release, but I
> would prefer to do it with another volunteer, to share knowledge and add
> redundancy. Also, I want to use the new Azure VM I created (Apache funded)
> instead of Alex's so we have redundancy in that respect as well. The VM
> isn't all set up yet so I will need to work on that.
>
>
>
>
>
> From: Josh Tynjala<mailto:joshtynj...@bowlerhat.dev>
> Sent: Wednesday, September 28, 2022 6:35 PM
> To: dev@royale.apache.org<mailto:dev@royale.apache.org>
> Subject: Re: Introducing asformat
>
> A new release sounds good to me! I just updated the compiler release
> notes, and there's a decent amount of stuff to be included. Not just these
> formatter improvements, but also the new linter, headless JS RoyaleUnit
> tests with Playwright, and the --watch compiler option are all new since
> the last release.
>
> --
> Josh Tynjala
> Bowler Hat LLC <https://bowlerhat.dev>
>
>
> On Wed, Sep 28, 2022 at 6:45 AM Harbs wrote:
>
> > That's great!
> >
> > This is a good reason to get another release out. :-)
> >
> > Harbs
> >
> > > On Sep 28, 2022, at 12:24 AM, Josh Tynjala
> > >
> > wrote:
> > >
> > > I just wanted to follow up by mentioning that I recently added the
> > ability for the formatter load configuration files, in addition to the
> > existing command line options. It will automatically detect an
> > asformat-config.xml file in the current working directory, allowing
> > you to easily specify configuration options for a specific project.
> > You can also use a new -load-config option to load a configuration
> > file from any path, not just the current working directory. You can
> > use -skip-local-config-file to ignore the asformat-config.xml file.
> > >
> > > Once we release the next Royale update, I plan to make
> > > vscode-as3mxml
> >
Re: Introducing asformat
The formatter and linter are documented. I'll make sure that the other things are too. -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Wed, Sep 28, 2022 at 11:31 AM Andrew Wetmore wrote: > Have we got documentation for all these new features, and how-tos for > deploying them? > > On Wed, Sep 28, 2022 at 12:36 PM Josh Tynjala > wrote: > > > A new release sounds good to me! I just updated the compiler release > notes, > > and there's a decent amount of stuff to be included. Not just these > > formatter improvements, but also the new linter, headless JS RoyaleUnit > > tests with Playwright, and the --watch compiler option are all new since > > the last release. > > > > -- > > Josh Tynjala > > Bowler Hat LLC <https://bowlerhat.dev> > > > > > > On Wed, Sep 28, 2022 at 6:45 AM Harbs wrote: > > > > > That’s great! > > > > > > This is a good reason to get another release out… :-) > > > > > > Harbs > > > > > > > On Sep 28, 2022, at 12:24 AM, Josh Tynjala < > joshtynj...@bowlerhat.dev> > > > wrote: > > > > > > > > I just wanted to follow up by mentioning that I recently added the > > > ability for the formatter load configuration files, in addition to the > > > existing command line options. It will automatically detect an > > > asformat-config.xml file in the current working directory, allowing you > > to > > > easily specify configuration options for a specific project. You can > also > > > use a new -load-config option to load a configuration file from any > path, > > > not just the current working directory. You can use > > -skip-local-config-file > > > to ignore the asformat-config.xml file. > > > > > > > > Once we release the next Royale update, I plan to make vscode-as3mxml > > > automatically detect the asformat-config.xml file too, so you will be > > able > > > to configure formatting options for both the command line and VSCode at > > the > > > same time. > > > > > > > > I also updated the Royale documentation to add a section for the > > > formatter: > > > > > > > > https://apache.github.io/royale-docs/formatter < > > > https://apache.github.io/royale-docs/formatter> > > > > > > > > -- > > > > Josh Tynjala > > > > Bowler Hat LLC <https://bowlerhat.dev/> > > > > > > > > > > > > On Wed, Sep 22, 2021 at 10:42 AM Josh Tynjala < > > joshtynj...@bowlerhat.dev > > > <mailto:joshtynj...@bowlerhat.dev>> wrote: > > > > Hey everyone, > > > > > > > > I recently created asformat, which is a formatter for ActionScript > > code. > > > It is based on the Royale compiler's lexer that creates a stream of > > tokens. > > > One nice thing about working with the token stream versus a full AST > > > (Abstract Syntax Tree) is that it's easier to keep track of existing > > > whitespace to preserve it where appropriate. > > > > > > > > In addition to command line usage, this formatter is intended to > > > eventually be used by IDEs/editors, such as VSCode and Moonshine. > > > > > > > > You can find asformat in nightly builds for now. I'm still testing it > > > with existing codebases, but I wanted to share my progress so that > others > > > could check it out, if interested. > > > > > > > > Usage: > > > > > > > > Format a file, and write it back to the file system: > > > > > > > > asformat --write-files src/com/example/MyClass.as > > > > > > > > Alternatively, format all .as files in a directory: > > > > > > > > asformat --write-files src > > > > > > > > Options: > > > > > > > > --write-files: Writes the formatting changes back to the original > > files. > > > If a file has no formatting changes, it will not be modified. Alias: > -w. > > > Default: false. > > > > > > > > --list-files: Lists the files that have been changed by formatting. > If > > a > > > file has no formatting changes, it won't be listed. Alias: -l. Default: > > > false. > > > > > > > > --insert-spaces: Indents with spaces instead of tabs. (Default: > false) > > > > > > > > --tab-width: The width of tabs when insert-spaces is specified. > > >
Re: Introducing aslint, a linter for ActionScript and MXML
Almost all of the values are true or false. If it says , then you pass an integer value. If it says , the available values should be documented on the options page. https://apache.github.io/royale-docs/linter/linter-options The *-name rules (-class-name, -field-name, etc.) are strictly true/false for now, but I'd like to expose a way to provide a custom regex pattern in the future. The defaults for all of the *-name options, when set to true, are basically just to enforce camel case. I should add the default regex patterns to the docs. -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Wed, Sep 28, 2022 at 12:25 PM Harbs wrote: > Also, the values for some of the options are not very clear. How do we > discover possible values? > > > On Sep 28, 2022, at 10:18 PM, Harbs wrote: > > > > Do you have instructions on how to integrate the linter into VS Code? > > > >> On Sep 28, 2022, at 12:14 AM, Josh Tynjala > wrote: > >> > >> Hey folks, > >> > >> I recently committed a new tool to the royale-compiler repository. It's > >> called aslint, and it is a linter to find common issues in .as and .mxml > >> files. > >> > >> You can find more information about aslint in the documentation that I > >> created: > >> > >> https://apache.github.io/royale-docs/linter > >> > >> This new linter includes a number of rules. Some rules are enabled by > >> default. Other rules are more opinionated, and they may not be right for > >> everyone, so you need to opt into them. > >> > >> We can certainly add more rules in the future, but let's be mindful > about > >> which are enabled by default, and which are opt-in. The list of defaults > >> should be small — with a focus on code issues that are most likely to > cause > >> actual bugs. Let's strive to avoid enabling formatting rules by default > >> (where braces are placed, spacing around operators, tabs/indents, etc.). > >> Everyone has their own opinions on formatting, and people will avoid > using > >> a linter if they don't agree with the formatting it wants to enforce. We > >> can include formatting rules, of course, but we should always make them > >> opt-in. > >> > >> All available command line options, including options to enable or > disable > >> specific rules, are documented here: > >> > >> https://apache.github.io/royale-docs/linter/linter-options > >> > >> Additionally, you can create an aslint-config.xml file containing the > >> options you'd like configured for a specific project, and it will be > loaded > >> by the tool automatically. > >> > >> https://apache.github.io/royale-docs/linter/aslint-config-file > >> > >> The architecture of aslint is very similar to the asformat tool that I > >> added a while back. It loads one or more files, and it uses the > compiler to > >> generate data structures to represent the code in memory. In asformat, > it > >> generates a simple token stream with the compiler, which is enough to > >> recognize keywords, operators, and other basic parts of the code. In > >> aslint, it generates a token stream the same way, but it also generates > an > >> Abstract Syntax Tree (AST), which allows for a more detailed analysis of > >> the code. > >> > >> Let me know if you run into any issues. Thanks! > >> > >> -- > >> Josh Tynjala > >> Bowler Hat LLC <https://bowlerhat.dev> > > > >
Re: Introducing aslint, a linter for ActionScript and MXML
It's currently possible to run it on the command line only. You could
either open a terminal and run the aslint command manually, or you could
add a custom task in your workspace's tasks.json file. Something like this:
{
"label": "aslint",
"type": "shell",
"command": "/path/to/aslint",
"args": [
"src"
]
}
If you want to customize the rules, you can either add more args to the
task, or you can create an aslint-config.xml at the workspace root.
You'll need to add a problem matcher to the task to get issues to show up
in the Problems view. Otherwise, they'll appear in the terminal output
only. Check the docs for how to do that.
Ideally, I'd like to add deeper integration with vscode-as3mxml. Linter
issues should automatically show up in the Problems view as you type (or
maybe when you save a file). I haven't had time to dig into that yet.
--
Josh Tynjala
Bowler Hat LLC <https://bowlerhat.dev>
On Wed, Sep 28, 2022 at 12:18 PM Harbs wrote:
> Do you have instructions on how to integrate the linter into VS Code?
>
> > On Sep 28, 2022, at 12:14 AM, Josh Tynjala
> wrote:
> >
> > Hey folks,
> >
> > I recently committed a new tool to the royale-compiler repository. It's
> > called aslint, and it is a linter to find common issues in .as and .mxml
> > files.
> >
> > You can find more information about aslint in the documentation that I
> > created:
> >
> > https://apache.github.io/royale-docs/linter
> >
> > This new linter includes a number of rules. Some rules are enabled by
> > default. Other rules are more opinionated, and they may not be right for
> > everyone, so you need to opt into them.
> >
> > We can certainly add more rules in the future, but let's be mindful about
> > which are enabled by default, and which are opt-in. The list of defaults
> > should be small — with a focus on code issues that are most likely to
> cause
> > actual bugs. Let's strive to avoid enabling formatting rules by default
> > (where braces are placed, spacing around operators, tabs/indents, etc.).
> > Everyone has their own opinions on formatting, and people will avoid
> using
> > a linter if they don't agree with the formatting it wants to enforce. We
> > can include formatting rules, of course, but we should always make them
> > opt-in.
> >
> > All available command line options, including options to enable or
> disable
> > specific rules, are documented here:
> >
> > https://apache.github.io/royale-docs/linter/linter-options
> >
> > Additionally, you can create an aslint-config.xml file containing the
> > options you'd like configured for a specific project, and it will be
> loaded
> > by the tool automatically.
> >
> > https://apache.github.io/royale-docs/linter/aslint-config-file
> >
> > The architecture of aslint is very similar to the asformat tool that I
> > added a while back. It loads one or more files, and it uses the compiler
> to
> > generate data structures to represent the code in memory. In asformat, it
> > generates a simple token stream with the compiler, which is enough to
> > recognize keywords, operators, and other basic parts of the code. In
> > aslint, it generates a token stream the same way, but it also generates
> an
> > Abstract Syntax Tree (AST), which allows for a more detailed analysis of
> > the code.
> >
> > Let me know if you run into any issues. Thanks!
> >
> > --
> > Josh Tynjala
> > Bowler Hat LLC <https://bowlerhat.dev>
>
>
Re: Introducing asformat
If the aslint command line linter doesn't find issues, its exit code will be 0. If it finds issues, the exit code will be non-zero, and that should automatically cause the build to fail on Github Actions. Basically the same as running the compiler. -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Wed, Sep 28, 2022 at 11:16 AM Yishay Weiss wrote: > It’s great to see this progress. I expect to see as-linter replacing > SonarQube in our current project. Do you think it would be hard to > integrate it with GitHub actions? > > The –watch option is already being used and is a big productivity boost. > > I expect I’ll make use of asformat at some point as well. Thanks for all > this Josh. > > I may get some time at the end of this month to work on a release, but I > would prefer to do it with another volunteer, to share knowledge and add > redundancy. Also, I want to use the new Azure VM I created (Apache funded) > instead of Alex’s so we have redundancy in that respect as well. The VM > isn’t all set up yet so I will need to work on that. > > > > > > From: Josh Tynjala<mailto:joshtynj...@bowlerhat.dev> > Sent: Wednesday, September 28, 2022 6:35 PM > To: dev@royale.apache.org<mailto:dev@royale.apache.org> > Subject: Re: Introducing asformat > > A new release sounds good to me! I just updated the compiler release notes, > and there's a decent amount of stuff to be included. Not just these > formatter improvements, but also the new linter, headless JS RoyaleUnit > tests with Playwright, and the --watch compiler option are all new since > the last release. > > -- > Josh Tynjala > Bowler Hat LLC <https://bowlerhat.dev> > > > On Wed, Sep 28, 2022 at 6:45 AM Harbs wrote: > > > That’s great! > > > > This is a good reason to get another release out… :-) > > > > Harbs > > > > > On Sep 28, 2022, at 12:24 AM, Josh Tynjala > > wrote: > > > > > > I just wanted to follow up by mentioning that I recently added the > > ability for the formatter load configuration files, in addition to the > > existing command line options. It will automatically detect an > > asformat-config.xml file in the current working directory, allowing you > to > > easily specify configuration options for a specific project. You can also > > use a new -load-config option to load a configuration file from any path, > > not just the current working directory. You can use > -skip-local-config-file > > to ignore the asformat-config.xml file. > > > > > > Once we release the next Royale update, I plan to make vscode-as3mxml > > automatically detect the asformat-config.xml file too, so you will be > able > > to configure formatting options for both the command line and VSCode at > the > > same time. > > > > > > I also updated the Royale documentation to add a section for the > > formatter: > > > > > > https://apache.github.io/royale-docs/formatter < > > https://apache.github.io/royale-docs/formatter>< > https://apache.github.io/royale-docs/formatter%3e> > > > > > > -- > > > Josh Tynjala > > > Bowler Hat LLC <https://bowlerhat.dev/> > > > > > > > > > On Wed, Sep 22, 2021 at 10:42 AM Josh Tynjala < > joshtynj...@bowlerhat.dev > > <mailto:joshtynj...@bowlerhat.dev>> wrote: > > > Hey everyone, > > > > > > I recently created asformat, which is a formatter for ActionScript > code. > > It is based on the Royale compiler's lexer that creates a stream of > tokens. > > One nice thing about working with the token stream versus a full AST > > (Abstract Syntax Tree) is that it's easier to keep track of existing > > whitespace to preserve it where appropriate. > > > > > > In addition to command line usage, this formatter is intended to > > eventually be used by IDEs/editors, such as VSCode and Moonshine. > > > > > > You can find asformat in nightly builds for now. I'm still testing it > > with existing codebases, but I wanted to share my progress so that others > > could check it out, if interested. > > > > > > Usage: > > > > > > Format a file, and write it back to the file system: > > > > > > asformat --write-files src/com/example/MyClass.as > > > > > > Alternatively, format all .as files in a directory: > > > > > > asformat --write-files src > > > > > > Options: > > > > > > --write-files: Writes the formatting changes back to the original > files. > > If a file has no formatt
Re: Introducing asformat
A new release sounds good to me! I just updated the compiler release notes, and there's a decent amount of stuff to be included. Not just these formatter improvements, but also the new linter, headless JS RoyaleUnit tests with Playwright, and the --watch compiler option are all new since the last release. -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Wed, Sep 28, 2022 at 6:45 AM Harbs wrote: > That’s great! > > This is a good reason to get another release out… :-) > > Harbs > > > On Sep 28, 2022, at 12:24 AM, Josh Tynjala > wrote: > > > > I just wanted to follow up by mentioning that I recently added the > ability for the formatter load configuration files, in addition to the > existing command line options. It will automatically detect an > asformat-config.xml file in the current working directory, allowing you to > easily specify configuration options for a specific project. You can also > use a new -load-config option to load a configuration file from any path, > not just the current working directory. You can use -skip-local-config-file > to ignore the asformat-config.xml file. > > > > Once we release the next Royale update, I plan to make vscode-as3mxml > automatically detect the asformat-config.xml file too, so you will be able > to configure formatting options for both the command line and VSCode at the > same time. > > > > I also updated the Royale documentation to add a section for the > formatter: > > > > https://apache.github.io/royale-docs/formatter < > https://apache.github.io/royale-docs/formatter> > > > > -- > > Josh Tynjala > > Bowler Hat LLC <https://bowlerhat.dev/> > > > > > > On Wed, Sep 22, 2021 at 10:42 AM Josh Tynjala <mailto:joshtynj...@bowlerhat.dev>> wrote: > > Hey everyone, > > > > I recently created asformat, which is a formatter for ActionScript code. > It is based on the Royale compiler's lexer that creates a stream of tokens. > One nice thing about working with the token stream versus a full AST > (Abstract Syntax Tree) is that it's easier to keep track of existing > whitespace to preserve it where appropriate. > > > > In addition to command line usage, this formatter is intended to > eventually be used by IDEs/editors, such as VSCode and Moonshine. > > > > You can find asformat in nightly builds for now. I'm still testing it > with existing codebases, but I wanted to share my progress so that others > could check it out, if interested. > > > > Usage: > > > > Format a file, and write it back to the file system: > > > > asformat --write-files src/com/example/MyClass.as > > > > Alternatively, format all .as files in a directory: > > > > asformat --write-files src > > > > Options: > > > > --write-files: Writes the formatting changes back to the original files. > If a file has no formatting changes, it will not be modified. Alias: -w. > Default: false. > > > > --list-files: Lists the files that have been changed by formatting. If a > file has no formatting changes, it won't be listed. Alias: -l. Default: > false. > > > > --insert-spaces: Indents with spaces instead of tabs. (Default: false) > > > > --tab-width: The width of tabs when insert-spaces is specified. > (Default: 4) > > > > --insert-final-new-line: Adds a final empty line at the end of the file, > if one doesn't exist already. (Default: false) > > > > --open-brace-new-line: Controls whether an opening curly brace is placed > on a new line, or is "cuddled" on the current line. (Default: true) > > > > --insert-space-for-loop-semicolon: Controls whether a space is inserted > after the semicolons in a for() loop. (Default: true) > > > > --insert-space-control-flow-keywords: Controls whether a space is > inserted between control flow keywords (like if, for, while) and the > following ( open parenthesis. (Default: true) > > > > --insert-space-anonymous-function-keyword: Controls whether a space is > inserted between the function keyword and the following ( open parenthesis, > if the function is anonymous (if it doesn't have a name). (Default: false) > > > > --insert-space-binary-operators: Controls whether a space is inserted > before and after binary operators (like +, -, *, /, &&, ||, etc.) (Default: > true) > > > > --insert-space-comma-delimiter: Controls whether a space is inserted > after comma delimiters in Object and Array literals. (Default: true) > > > > --collapse-empty-blocks: Controls whether empty blocks are collapsed so > that the opening and closing curly brace are both on th
Re: Deploy new Royale static site as-is?
Yeah, same URL as before. Just new instructions to replace the old WordPress stuff. https://github.com/apache/royale-asjs/wiki/Release-Manager-(Web-Site) -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Tue, Sep 27, 2022 at 3:06 PM Andrew Wetmore wrote: > Ah, thank you. Is it in the page that had the information for the WordPress > site? > > a > > On Tue, Sep 27, 2022 at 7:02 PM Josh Tynjala > wrote: > > > FYI — I wrote the new documentation for updating the Royale website. > > -- > > Josh Tynjala > > Bowler Hat LLC <https://bowlerhat.dev> > > > > > > On Tue, Aug 30, 2022 at 3:24 PM Andrew Wetmore > > wrote: > > > > > If we now have a working process to maintain our website, can someone > > help > > > me update our documentation about it? This page [1] still gives > guidance > > > for the WordPress site. > > > > > > a > > > > > > 1. > https://github.com/apache/royale-asjs/wiki/Release-Manager-(Web-Site) > > > > > > On Mon, Aug 1, 2022 at 1:35 PM Andrew Wetmore > > wrote: > > > > > > > The help docs for working with the Pelican website template are now > up > > to > > > > date. The main page is here [1]. > > > > > > > > The main changes are on the getting-started page [2] and the page > about > > > > building and testing locally [3]. For the latter, there is now a > > > > downloadable tool that simplifies the local-build process. > > > > > > > > [1] https://infra.apache.org/asf-pelican.html > > > > [2] https://infra.apache.org/asf-pelican-gettingstarted.html > > > > [3] https://infra.apache.org/asf-pelican-local.html > > > > > > > > On Tue, Jul 19, 2022 at 4:42 AM Maria Jose Esteve > > > > > wrote: > > > > > > > >> +1 > > > >> > > > >> Hiedra > > > >> > > > >> -Mensaje original- > > > >> De: Josh Tynjala > > > >> Enviado el: lunes, 18 de julio de 2022 23:55 > > > >> Para: Apache Royale Development > > > >> Asunto: Deploy new Royale static site as-is? > > > >> > > > >> Hi all, > > > >> > > > >> I just created a new 11ty branch in the apache/royale-website repo, > > and > > > I > > > >> added the source files for the static site that I built with > Eleventy. > > > >> > > > >> https://github.com/apache/royale-website/tree/11ty > > > >> > > > >> I made it so that Github Actions builds the site from source and > > deploys > > > >> the output to the asf-staging branch. In the asf-staging branch, I > > > added an > > > >> .asf.yaml file, which currently deploys every new commit at the > > > following > > > >> staging URL: > > > >> > > > >> https://royale-11ty.staged.apache.org/ > > > >> > > > >> It would be a relatively easy change to configure this repo to > deploy > > to > > > >> the production royale.apache.org website instead. > > > >> > > > >> I feel that it's better for Royale's future to have an updated > website > > > >> working sooner rather than later. I propose that we move forward > with > > > what > > > >> we have now, instead of waiting any longer to migrate to Pelican. I > > have > > > >> nothing against Pelican, and I'm totally okay with using it in the > > > future. > > > >> I simply think that it's better to replace the old website with > > > >> **anything** that we can update properly, since the old website > > doesn't > > > >> even mention the newest two Royale SDK releases. > > > >> > > > >> Does anyone object to moving forward with the Elventy-based site for > > > now? > > > >> > > > >> -- > > > >> Josh Tynjala > > > >> Bowler Hat LLC <https://bowlerhat.dev> > > > >> > > > > > > > > > > > > -- > > > > Andrew Wetmore > > > > > > > > Editor, Moose House Publications <https://moosehousepress.com/> > > > > Editor-Writer, The Apache Software Foundation <https://apache.org/> > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > Andrew Wetmore > > > > > > Editor, Moose House Publications <https://moosehousepress.com/> > > > Editor-Writer, The Apache Software Foundation <https://apache.org/> > > > > > > > > -- > Andrew Wetmore > > Editor, Moose House Publications <https://moosehousepress.com/> > Editor-Writer, The Apache Software Foundation <https://apache.org/> >
Re: Deploy new Royale static site as-is?
FYI — I wrote the new documentation for updating the Royale website. -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Tue, Aug 30, 2022 at 3:24 PM Andrew Wetmore wrote: > If we now have a working process to maintain our website, can someone help > me update our documentation about it? This page [1] still gives guidance > for the WordPress site. > > a > > 1. https://github.com/apache/royale-asjs/wiki/Release-Manager-(Web-Site) > > On Mon, Aug 1, 2022 at 1:35 PM Andrew Wetmore wrote: > > > The help docs for working with the Pelican website template are now up to > > date. The main page is here [1]. > > > > The main changes are on the getting-started page [2] and the page about > > building and testing locally [3]. For the latter, there is now a > > downloadable tool that simplifies the local-build process. > > > > [1] https://infra.apache.org/asf-pelican.html > > [2] https://infra.apache.org/asf-pelican-gettingstarted.html > > [3] https://infra.apache.org/asf-pelican-local.html > > > > On Tue, Jul 19, 2022 at 4:42 AM Maria Jose Esteve > > wrote: > > > >> +1 > >> > >> Hiedra > >> > >> -Mensaje original- > >> De: Josh Tynjala > >> Enviado el: lunes, 18 de julio de 2022 23:55 > >> Para: Apache Royale Development > >> Asunto: Deploy new Royale static site as-is? > >> > >> Hi all, > >> > >> I just created a new 11ty branch in the apache/royale-website repo, and > I > >> added the source files for the static site that I built with Eleventy. > >> > >> https://github.com/apache/royale-website/tree/11ty > >> > >> I made it so that Github Actions builds the site from source and deploys > >> the output to the asf-staging branch. In the asf-staging branch, I > added an > >> .asf.yaml file, which currently deploys every new commit at the > following > >> staging URL: > >> > >> https://royale-11ty.staged.apache.org/ > >> > >> It would be a relatively easy change to configure this repo to deploy to > >> the production royale.apache.org website instead. > >> > >> I feel that it's better for Royale's future to have an updated website > >> working sooner rather than later. I propose that we move forward with > what > >> we have now, instead of waiting any longer to migrate to Pelican. I have > >> nothing against Pelican, and I'm totally okay with using it in the > future. > >> I simply think that it's better to replace the old website with > >> **anything** that we can update properly, since the old website doesn't > >> even mention the newest two Royale SDK releases. > >> > >> Does anyone object to moving forward with the Elventy-based site for > now? > >> > >> -- > >> Josh Tynjala > >> Bowler Hat LLC <https://bowlerhat.dev> > >> > > > > > > -- > > Andrew Wetmore > > > > Editor, Moose House Publications <https://moosehousepress.com/> > > Editor-Writer, The Apache Software Foundation <https://apache.org/> > > > > > > > > > > > > -- > Andrew Wetmore > > Editor, Moose House Publications <https://moosehousepress.com/> > Editor-Writer, The Apache Software Foundation <https://apache.org/> >
Re: Introducing asformat
I just wanted to follow up by mentioning that I recently added the ability for the formatter load configuration files, in addition to the existing command line options. It will automatically detect an asformat-config.xml file in the current working directory, allowing you to easily specify configuration options for a specific project. You can also use a new -load-config option to load a configuration file from any path, not just the current working directory. You can use -skip-local-config-file to ignore the asformat-config.xml file. Once we release the next Royale update, I plan to make vscode-as3mxml automatically detect the asformat-config.xml file too, so you will be able to configure formatting options for both the command line and VSCode at the same time. I also updated the Royale documentation to add a section for the formatter: https://apache.github.io/royale-docs/formatter -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Wed, Sep 22, 2021 at 10:42 AM Josh Tynjala wrote: > Hey everyone, > > I recently created asformat, which is a formatter for ActionScript code. > It is based on the Royale compiler's lexer that creates a stream of tokens. > One nice thing about working with the token stream versus a full AST > (Abstract Syntax Tree) is that it's easier to keep track of existing > whitespace to preserve it where appropriate. > > In addition to command line usage, this formatter is intended to > eventually be used by IDEs/editors, such as VSCode and Moonshine. > > You can find asformat in nightly builds for now. I'm still testing it with > existing codebases, but I wanted to share my progress so that others could > check it out, if interested. > > Usage: > > Format a file, and write it back to the file system: > > asformat --write-files src/com/example/MyClass.as > > Alternatively, format all .as files in a directory: > > asformat --write-files src > > Options: > > --write-files: Writes the formatting changes back to the original files. > If a file has no formatting changes, it will not be modified. Alias: -w. > Default: false. > > --list-files: Lists the files that have been changed by formatting. If a > file has no formatting changes, it won't be listed. Alias: -l. Default: > false. > > --insert-spaces: Indents with spaces instead of tabs. (Default: false) > > --tab-width: The width of tabs when insert-spaces is specified. (Default: > 4) > > --insert-final-new-line: Adds a final empty line at the end of the file, > if one doesn't exist already. (Default: false) > > --open-brace-new-line: Controls whether an opening curly brace is placed > on a new line, or is "cuddled" on the current line. (Default: true) > > --insert-space-for-loop-semicolon: Controls whether a space is inserted > after the semicolons in a for() loop. (Default: true) > > --insert-space-control-flow-keywords: Controls whether a space is inserted > between control flow keywords (like if, for, while) and the following ( > open parenthesis. (Default: true) > > --insert-space-anonymous-function-keyword: Controls whether a space is > inserted between the function keyword and the following ( open parenthesis, > if the function is anonymous (if it doesn't have a name). (Default: false) > > --insert-space-binary-operators: Controls whether a space is inserted > before and after binary operators (like +, -, *, /, &&, ||, etc.) (Default: > true) > > --insert-space-comma-delimiter: Controls whether a space is inserted after > comma delimiters in Object and Array literals. (Default: true) > > --collapse-empty-blocks: Controls whether empty blocks are collapsed so > that the opening and closing curly brace are both on the same line or not. > (Default: false) > > --max-preserve-new-lines: Specify the maximum number of new line > characters that are allowed to appear consecutively. (Default: 2) > > --semicolons: Controls how semicolons are handled. Valid values are > insert, remove, and ignore. Insert means that missing semicolons are > inserted. Remove means that all semicolons are removed, and ignore means > that there is no change to semicolons in the file. (Default: insert) > > Additional notes: > > If neither --write-files nor --list-files is specified, the formatted > source code is written to standard output instead. > > If no files are specified, asformat waits for standard input instead. > > -- > Josh Tynjala > Bowler Hat LLC <https://bowlerhat.dev> >
Introducing aslint, a linter for ActionScript and MXML
Hey folks, I recently committed a new tool to the royale-compiler repository. It's called aslint, and it is a linter to find common issues in .as and .mxml files. You can find more information about aslint in the documentation that I created: https://apache.github.io/royale-docs/linter This new linter includes a number of rules. Some rules are enabled by default. Other rules are more opinionated, and they may not be right for everyone, so you need to opt into them. We can certainly add more rules in the future, but let's be mindful about which are enabled by default, and which are opt-in. The list of defaults should be small — with a focus on code issues that are most likely to cause actual bugs. Let's strive to avoid enabling formatting rules by default (where braces are placed, spacing around operators, tabs/indents, etc.). Everyone has their own opinions on formatting, and people will avoid using a linter if they don't agree with the formatting it wants to enforce. We can include formatting rules, of course, but we should always make them opt-in. All available command line options, including options to enable or disable specific rules, are documented here: https://apache.github.io/royale-docs/linter/linter-options Additionally, you can create an aslint-config.xml file containing the options you'd like configured for a specific project, and it will be loaded by the tool automatically. https://apache.github.io/royale-docs/linter/aslint-config-file The architecture of aslint is very similar to the asformat tool that I added a while back. It loads one or more files, and it uses the compiler to generate data structures to represent the code in memory. In asformat, it generates a simple token stream with the compiler, which is enough to recognize keywords, operators, and other basic parts of the code. In aslint, it generates a token stream the same way, but it also generates an Abstract Syntax Tree (AST), which allows for a more detailed analysis of the code. Let me know if you run into any issues. Thanks! -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev>
Re: Deploy new Royale static site as-is?
The website is in this repo: https://github.com/apache/royale-website The readme gives the relevant npm commands to install required dependencies and test locally (requires Node.js). Just commit changes and push to the master branch, and it will deploy automatically. -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Tue, Aug 30, 2022 at 3:24 PM Andrew Wetmore wrote: > If we now have a working process to maintain our website, can someone help > me update our documentation about it? This page [1] still gives guidance > for the WordPress site. > > a > > 1. https://github.com/apache/royale-asjs/wiki/Release-Manager-(Web-Site) > > On Mon, Aug 1, 2022 at 1:35 PM Andrew Wetmore wrote: > > > The help docs for working with the Pelican website template are now up to > > date. The main page is here [1]. > > > > The main changes are on the getting-started page [2] and the page about > > building and testing locally [3]. For the latter, there is now a > > downloadable tool that simplifies the local-build process. > > > > [1] https://infra.apache.org/asf-pelican.html > > [2] https://infra.apache.org/asf-pelican-gettingstarted.html > > [3] https://infra.apache.org/asf-pelican-local.html > > > > On Tue, Jul 19, 2022 at 4:42 AM Maria Jose Esteve > > wrote: > > > >> +1 > >> > >> Hiedra > >> > >> -Mensaje original- > >> De: Josh Tynjala > >> Enviado el: lunes, 18 de julio de 2022 23:55 > >> Para: Apache Royale Development > >> Asunto: Deploy new Royale static site as-is? > >> > >> Hi all, > >> > >> I just created a new 11ty branch in the apache/royale-website repo, and > I > >> added the source files for the static site that I built with Eleventy. > >> > >> https://github.com/apache/royale-website/tree/11ty > >> > >> I made it so that Github Actions builds the site from source and deploys > >> the output to the asf-staging branch. In the asf-staging branch, I > added an > >> .asf.yaml file, which currently deploys every new commit at the > following > >> staging URL: > >> > >> https://royale-11ty.staged.apache.org/ > >> > >> It would be a relatively easy change to configure this repo to deploy to > >> the production royale.apache.org website instead. > >> > >> I feel that it's better for Royale's future to have an updated website > >> working sooner rather than later. I propose that we move forward with > what > >> we have now, instead of waiting any longer to migrate to Pelican. I have > >> nothing against Pelican, and I'm totally okay with using it in the > future. > >> I simply think that it's better to replace the old website with > >> **anything** that we can update properly, since the old website doesn't > >> even mention the newest two Royale SDK releases. > >> > >> Does anyone object to moving forward with the Elventy-based site for > now? > >> > >> -- > >> Josh Tynjala > >> Bowler Hat LLC <https://bowlerhat.dev> > >> > > > > > > -- > > Andrew Wetmore > > > > Editor, Moose House Publications <https://moosehousepress.com/> > > Editor-Writer, The Apache Software Foundation <https://apache.org/> > > > > > > > > > > > > -- > Andrew Wetmore > > Editor, Moose House Publications <https://moosehousepress.com/> > Editor-Writer, The Apache Software Foundation <https://apache.org/> >
Re: The build is failing (even without changes on my side)
You can add -Dskip-tests=1 to your ant command to skip all RoyaleUnit tests. -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Fri, Aug 19, 2022 at 7:57 AM Hugo Ferreira wrote: > It's something on my side that I need to fix or on this case is on a server > ? > There is a way to ignore this flexunitests ? > I'm using the command: ant all > > Harbs escreveu no dia sexta, 19/08/2022 à(s) > 15:50: > > > It looks like flexUnitTests.xml.XMLTesterGeneralTest is failing. > > > > What’s the error? > > > > > On Aug 19, 2022, at 4:58 PM, Hugo Ferreira > > wrote: > > > > > > Hi, > > > > > > > > > A simple build without change, fail: > > > > > > > > > check-royaleunit-browser: > > > > > > > > > test: > > > > > >[mkdir] Created dir: > > > > > > /Volumes/Data/SDK/apache-royale-src/apache-royale/frameworks/js/projects/XMLJS/src/test/royale/out > > > > > > [royaleunit] Validating task attributes ... > > > > > > [royaleunit] Generating default values ... > > > > > > [royaleunit] Using the following settings for the test run: > > > > > > [royaleunit] ROYALE_HOME: > > > [/Volumes/Data/SDK/apache-royale-src/apache-royale] > > > > > > [royaleunit] haltonfailure: [false] > > > > > > [royaleunit] headless: [false] > > > > > > [royaleunit] display: [99] > > > > > > [royaleunit] localTrusted: [true] > > > > > > [royaleunit] player: [html] > > > > > > [royaleunit] command: [/Applications/Google > > > Chrome.app/Contents/MacOS/Google Chrome] > > > > > > [royaleunit] port: [1024] > > > > > > [royaleunit] swf: > > > > > > [/Volumes/Data/SDK/apache-royale-src/apache-royale/frameworks/js/projects/XMLJS/src/test/royale/target/bin/js-release/index.html] > > > > > > [royaleunit] timeout: [9ms] > > > > > > [royaleunit] toDir: > > > > > > [/Volumes/Data/SDK/apache-royale-src/apache-royale/frameworks/js/projects/XMLJS/src/test/royale/out] > > > > > > [royaleunit] Entry > > > > > > [/Volumes/Data/SDK/apache-royale-src/apache-royale/frameworks/js/projects/XMLJS/src/test/royale/target/bin/js-release] > > > already available in local trust file at > > > [/Users/hugo/Library/Preferences/Macromedia/Flash > > > Player/#Security/FlashPlayerTrust/royaleUnit.cfg]. > > > > > > [royaleunit] Setting up server process ... > > > > > > [royaleunit] SLF4J: Failed to load class > > > "org.slf4j.impl.StaticLoggerBinder". > > > > > > [royaleunit] SLF4J: Defaulting to no-operation (NOP) logger > > implementation > > > > > > [royaleunit] SLF4J: See > > http://www.slf4j.org/codes.html#StaticLoggerBinder > > > for further details. > > > > > > [royaleunit] Executing '/Applications/Google > > > Chrome.app/Contents/MacOS/Google Chrome' with arguments: > > > > > > [royaleunit] > > > > > > '/Volumes/Data/SDK/apache-royale-src/apache-royale/frameworks/js/projects/XMLJS/src/test/royale/target/bin/js-release/index.html' > > > > > > [royaleunit] > > > > > > [royaleunit] The ' characters around the executable and arguments are > > > > > > [royaleunit] not part of the command. > > > > > > [royaleunit] > > > > > > [royaleunit] Starting server ... > > > > > > [royaleunit] Waiting for client connection ... > > > > > > [royaleunit] Client connected. > > > > > > [royaleunit] Receiving data ... > > > > > > [royaleunit] Sending acknowledgement to player to start sending test > data > > > ... > > > > > > [royaleunit] > > > > > > [royaleunit] RoyaleUnit test testMixedAddition in suite > > > flexUnitTests.xml.XMLTesterGeneralTest had errors. > > > > > > [royaleunit] > > > > > > [royaleunit] Stopping server ... > > > > > > [royaleunit] End of test data reached, sending acknowledgement to > player > > ... > > > > > > [royaleunit] Analyzing reports ... > > > > > > [royaleunit] > > > > > > [royaleunit] Suite: flexUnitTests.xml.XMLNotificationTest > > > > > > [royaleunit] Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time > > > elapsed: 1.353 sec > > > > &g
Re: Using Playwright for RoyaleUnit JS testing
I don't think that using Playwright gives us any improvement to build/test
performance. It's still ultimately launching a separate browser process and
communicating over a websocket. It's mainly stability improvements, for the
reasons mentioned.
Playwright is certainly be something that could be useful for UI testing.
Probably not as part of RoyaleUnit, but as a separate thing. As I
mentioned, it has a pretty extensive programmatic API. You can query the
DOM, watch for changes to global variables, evaluate arbitrary JS code,
perform user interactions (mouse clicks, keyboard input, etc.). I haven't
really dug into everything Playwright is capable of. So far, my only
experience with Playwright is specifically running unit tests for Royale
and Haxe.
--
Josh Tynjala
Bowler Hat LLC <https://bowlerhat.dev>
On Tue, Aug 2, 2022 at 1:02 PM Harbs wrote:
> Cool. I was wondering what those references to Playwright were.
>
> A couple of questions:
>
> Does this bring any performance improvements?
> Does this make UI testing easier?
>
> > On Aug 2, 2022, at 8:50 PM, Josh Tynjala
> wrote:
> >
> > Hey all,
> >
> > Recently, I committed some changes to the RoyaleUnit Ant task to make it
> > more robust and powerful. This is in response to my recent discovery that
> > the RoyaleUnit testing in our royale-asjs build seems to have become less
> > reliable over time since I originally set things up.
> >
> > In particular, I found that Chrome was failing on certain tests because
> of
> > security restrictions with file:/// URLs (I guess that Chrome was either
> > not as strict in the past, or we have added newer tests that are
> accessing
> > restricted APIs that we weren't using in the past). Additionally, I was
> > seeing the occasional intermittent communication failure in Firefox, for
> no
> > obvious reason.
> >
> > To remedy this situation, I've integrated Playwright into the RoyaleUnit
> > Ant task.
> >
> > https://playwright.dev
> >
> > If you're not aware, Playwright is a library that enables automated
> testing
> > in Chromium, Firefox, and Webkit. Playwright works on macOS, Linux, and
> > Windows, and it has a powerful programmatic API (available for a number
> of
> > languages... we're using the Java version).
> >
> > By using Playwright, we get some interesting enhancements to our JS
> testing:
> >
> > - Headless
> > - No browser windows popping up during long builds
> > - Doesn't use your installed browsers
> > - Won't litter your default browser with a bunch of tabs that don't
> > auto-close
> > - No risk of being affected by customized extensions/add-ons
> > - It automatically sets up the correct security sandbox
> > - No arcane combinations of command line arguments or about:config
> > tweaks to get file:/// URLs working as we need
> > - The browser debugging console (trace/console.log) messages appear in
> > the terminal output of the build
> > - Easier to see what went wrong if an exception is thrown during
> tests
> >
> > The "player" attribute of the task may now be set to
> > "chromium", "firefox", or "webkit" to use a specific browser. RoyaleUnit
> > will keep supporting the "html" value for backwards compatibility, and
> > it's now an alias for "chromium". You can also use "html" when you want
> to
> > use a custom browser executable instead of Playwright.
> >
> > Example of in an Ant script that runs JS tests in
> > WebKit/Safari:
> >
> > >player="webkit"
> >swf="${basedir}/target/bin/js-release/index.html"/>
> >
> >> Aside: Yes, the attribute name for the file/URL is still "swf". That's a
> > legacy from FlexUnit. We could add an alias, but it hasn't been a
> priority.
> >
> > I have updated the royale-asjs build to use Playwright, instead of trying
> > to detect which browsers are installed locally.
> >
> > That's not the only change to the RoyaleUnit Ant task that I've made
> > recently, though.
> >
> > First, I should specify it's still possible to specify a custom
> > royaleunit.browser property in your env.properties file for the
> royale-asjs
> > Ant build. If you have that set up already, you don't need to change
> > anything. It should keep working the same as before, and your build won't
> > use Playwright when royaleunit.browser is defined. However, if you would
> > like to switch to Playwright for local builds, you can just comment out
> or
> &g
Using Playwright for RoyaleUnit JS testing
Hey all, Recently, I committed some changes to the RoyaleUnit Ant task to make it more robust and powerful. This is in response to my recent discovery that the RoyaleUnit testing in our royale-asjs build seems to have become less reliable over time since I originally set things up. In particular, I found that Chrome was failing on certain tests because of security restrictions with file:/// URLs (I guess that Chrome was either not as strict in the past, or we have added newer tests that are accessing restricted APIs that we weren't using in the past). Additionally, I was seeing the occasional intermittent communication failure in Firefox, for no obvious reason. To remedy this situation, I've integrated Playwright into the RoyaleUnit Ant task. https://playwright.dev If you're not aware, Playwright is a library that enables automated testing in Chromium, Firefox, and Webkit. Playwright works on macOS, Linux, and Windows, and it has a powerful programmatic API (available for a number of languages... we're using the Java version). By using Playwright, we get some interesting enhancements to our JS testing: - Headless - No browser windows popping up during long builds - Doesn't use your installed browsers - Won't litter your default browser with a bunch of tabs that don't auto-close - No risk of being affected by customized extensions/add-ons - It automatically sets up the correct security sandbox - No arcane combinations of command line arguments or about:config tweaks to get file:/// URLs working as we need - The browser debugging console (trace/console.log) messages appear in the terminal output of the build - Easier to see what went wrong if an exception is thrown during tests The "player" attribute of the task may now be set to "chromium", "firefox", or "webkit" to use a specific browser. RoyaleUnit will keep supporting the "html" value for backwards compatibility, and it's now an alias for "chromium". You can also use "html" when you want to use a custom browser executable instead of Playwright. Example of in an Ant script that runs JS tests in WebKit/Safari: > Aside: Yes, the attribute name for the file/URL is still "swf". That's a legacy from FlexUnit. We could add an alias, but it hasn't been a priority. I have updated the royale-asjs build to use Playwright, instead of trying to detect which browsers are installed locally. That's not the only change to the RoyaleUnit Ant task that I've made recently, though. First, I should specify it's still possible to specify a custom royaleunit.browser property in your env.properties file for the royale-asjs Ant build. If you have that set up already, you don't need to change anything. It should keep working the same as before, and your build won't use Playwright when royaleunit.browser is defined. However, if you would like to switch to Playwright for local builds, you can just comment out or remove the royaleunit.browser property customization from your env.properties file (or from the -Droyaleunit.browser command line arguments, or any other place you might have set it). If you'd like to keep using a custom browser, you may be interested to know that the RoyaleUnit Ant task now supports custom arguments when you specify an executable command. Example below: > Aside: The commandArgs above should work well to get tests to pass in Chrome with file:/// URLs, even without Playwright. Other browsers may require different commandArgs. I updated the royale-asjs build to optionally support both the royaleunit.browser property along with a new royaleunit.browser.args property, which you can specify in env.properties, if you prefer not to rely on Playwright. Example below (on macOS): # in env.properties royaleunit.browser=/Applications/Google Chrome.app/Contents/MacOS/Google Chrome royaleunit.browser.args=--no-sandbox --user-data-dir=/Users/joshtynjala/Development/apache/royaleunit_chrome_profile --no-first-run Please let me know if anything seems broken. I've confirmed that Playwright tests are working on CI builds. It's also working on both my local macOS and Windows machines. -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev>
Deploy new Royale static site as-is?
Hi all, I just created a new 11ty branch in the apache/royale-website repo, and I added the source files for the static site that I built with Eleventy. https://github.com/apache/royale-website/tree/11ty I made it so that Github Actions builds the site from source and deploys the output to the asf-staging branch. In the asf-staging branch, I added an .asf.yaml file, which currently deploys every new commit at the following staging URL: https://royale-11ty.staged.apache.org/ It would be a relatively easy change to configure this repo to deploy to the production royale.apache.org website instead. I feel that it's better for Royale's future to have an updated website working sooner rather than later. I propose that we move forward with what we have now, instead of waiting any longer to migrate to Pelican. I have nothing against Pelican, and I'm totally okay with using it in the future. I simply think that it's better to replace the old website with **anything** that we can update properly, since the old website doesn't even mention the newest two Royale SDK releases. Does anyone object to moving forward with the Elventy-based site for now? -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev>
Re: Developing new Royale website with Pelican
Thanks, Andrew! I'll check it out once you have the docs updated. -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Tue, Jul 5, 2022 at 11:46 AM Andrew Wetmore wrote: > Hi, colleagues: > > I am happy to tell you that the Infra team has been able to repair and > strengthen the Pelican template, so that it now works for both live and > offline builds. I need to update the documentation a bit, especially the > instructions for building locally, and then I think we will be good to have > Josh add his content for the refreshed website to the template framework > and see what happens. > > I should have the documentation ready for that experiment tomorrow, or > Thursday at the latest. > > a > > On Sun, Jun 26, 2022 at 1:16 PM Harbs wrote: > > > Looks great! > > > > > On Jun 24, 2022, at 6:46 PM, Josh Tynjala > > wrote: > > > > > > By the way, if anyone is interested in seeing my progress on the > > website, I > > > just uploaded a build here: > > > > > > https://royale.bowlerhat.dev/ > > > > > > This is currently using the Eleventy static site generator. > > > > > > -- > > > Josh Tynjala > > > Bowler Hat LLC <https://bowlerhat.dev> > > > > > > > > > On Thu, Jun 23, 2022 at 9:10 AM Josh Tynjala < > joshtynj...@bowlerhat.dev> > > > wrote: > > > > > >> This is a thread to discuss the conversion of the current site away > from > > >> the WordPress setup we've been using to Pelican, a static site > generator > > >> recommended by Infra. > > >> > > >> -- > > >> Josh Tynjala > > >> Bowler Hat LLC <https://bowlerhat.dev> > > >> > > > > > > -- > Andrew Wetmore > > Editor, Moose House Publications <https://moosehousepress.com/> > Editor-Writer, The Apache Software Foundation <https://apache.org/> >
