[jira] [Commented] (SLING-6679) Replace usage of org.apache.sling.commons.json.*
[ https://issues.apache.org/jira/browse/SLING-6679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15941360#comment-15941360 ] Karl Pauls commented on SLING-6679: --- Ok, I'm done with a first path. There should be patches for all the bundles now. Please review > Replace usage of org.apache.sling.commons.json.* > > > Key: SLING-6679 > URL: https://issues.apache.org/jira/browse/SLING-6679 > Project: Sling > Issue Type: Improvement >Reporter: Karl Pauls >Assignee: Karl Pauls > > Following the deprecation of org.apache.sling.commons.json (SLING-6536) we > need to replace its usage everywhere else (at least if we want to be able to > release other modules that depend on it). > This is the umbrella issue for getting this done. The idea is to create > sub-issues with patches for individual components, review the patches, and > when all are done: close this issue. > General discussions and problems should go to this issue and specific ones on > the sub-issue in question. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (SLING-6693) Replace commons.json usage in org.apache.sling.hc.core
[ https://issues.apache.org/jira/browse/SLING-6693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls reassigned SLING-6693: - Assignee: Karl Pauls > Replace commons.json usage in org.apache.sling.hc.core > -- > > Key: SLING-6693 > URL: https://issues.apache.org/jira/browse/SLING-6693 > Project: Sling > Issue Type: Sub-task > Components: Health Check >Affects Versions: Health Check Core 1.2.6 >Reporter: Karl Pauls >Assignee: Karl Pauls > Labels: patch-available > Fix For: Health Check Core 1.2.8 > > Attachments: SLING-6693.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (SLING-6693) Replace commons.json usage in org.apache.sling.hc.core
[ https://issues.apache.org/jira/browse/SLING-6693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls updated SLING-6693: -- Attachment: SLING-6693.patch Please review. > Replace commons.json usage in org.apache.sling.hc.core > -- > > Key: SLING-6693 > URL: https://issues.apache.org/jira/browse/SLING-6693 > Project: Sling > Issue Type: Sub-task > Components: Health Check >Affects Versions: Health Check Core 1.2.6 >Reporter: Karl Pauls >Assignee: Karl Pauls > Labels: patch-available > Fix For: Health Check Core 1.2.8 > > Attachments: SLING-6693.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (SLING-6693) Replace commons.json usage in org.apache.sling.hc.core
[ https://issues.apache.org/jira/browse/SLING-6693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls updated SLING-6693: -- Labels: patch-available (was: ) > Replace commons.json usage in org.apache.sling.hc.core > -- > > Key: SLING-6693 > URL: https://issues.apache.org/jira/browse/SLING-6693 > Project: Sling > Issue Type: Sub-task > Components: Health Check >Affects Versions: Health Check Core 1.2.6 >Reporter: Karl Pauls >Assignee: Karl Pauls > Labels: patch-available > Fix For: Health Check Core 1.2.8 > > Attachments: SLING-6693.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (SLING-6692) Replace commons.json usage in org.apache.sling.discovery.oak
[ https://issues.apache.org/jira/browse/SLING-6692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls updated SLING-6692: -- Attachment: SLING-6692.patch This one again basically only required switching the dependencies for the test. However, the tests did uncover some bugs in the base and commons which are now fixed as well. > Replace commons.json usage in org.apache.sling.discovery.oak > > > Key: SLING-6692 > URL: https://issues.apache.org/jira/browse/SLING-6692 > Project: Sling > Issue Type: Sub-task > Components: Extensions >Affects Versions: Discovery Oak 1.2.10 >Reporter: Karl Pauls >Assignee: Karl Pauls > Labels: patch-available > Fix For: Discovery Oak 1.2.18 > > Attachments: SLING-6692.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (SLING-6692) Replace commons.json usage in org.apache.sling.discovery.oak
[ https://issues.apache.org/jira/browse/SLING-6692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls updated SLING-6692: -- Labels: patch-available (was: ) > Replace commons.json usage in org.apache.sling.discovery.oak > > > Key: SLING-6692 > URL: https://issues.apache.org/jira/browse/SLING-6692 > Project: Sling > Issue Type: Sub-task > Components: Extensions >Affects Versions: Discovery Oak 1.2.10 >Reporter: Karl Pauls >Assignee: Karl Pauls > Labels: patch-available > Fix For: Discovery Oak 1.2.18 > > Attachments: SLING-6692.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (SLING-6691) Replace commons.json usage in org.apache.sling.discovery.impl
[ https://issues.apache.org/jira/browse/SLING-6691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls updated SLING-6691: -- Attachment: (was: SLING-6691.patch) > Replace commons.json usage in org.apache.sling.discovery.impl > - > > Key: SLING-6691 > URL: https://issues.apache.org/jira/browse/SLING-6691 > Project: Sling > Issue Type: Sub-task > Components: Extensions >Affects Versions: Discovery Impl 1.2.8 >Reporter: Karl Pauls >Assignee: Karl Pauls > Labels: patch-available > Fix For: Discovery Impl 1.2.12 > > Attachments: SLING-6691.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (SLING-6691) Replace commons.json usage in org.apache.sling.discovery.impl
[ https://issues.apache.org/jira/browse/SLING-6691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls updated SLING-6691: -- Attachment: SLING-6691.patch > Replace commons.json usage in org.apache.sling.discovery.impl > - > > Key: SLING-6691 > URL: https://issues.apache.org/jira/browse/SLING-6691 > Project: Sling > Issue Type: Sub-task > Components: Extensions >Affects Versions: Discovery Impl 1.2.8 >Reporter: Karl Pauls >Assignee: Karl Pauls > Labels: patch-available > Fix For: Discovery Impl 1.2.12 > > Attachments: SLING-6691.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (SLING-6690) Replace commons.json usage in org.apache.sling.discovery.commons
[ https://issues.apache.org/jira/browse/SLING-6690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls updated SLING-6690: -- Attachment: (was: SLING-6690.patch) > Replace commons.json usage in org.apache.sling.discovery.commons > > > Key: SLING-6690 > URL: https://issues.apache.org/jira/browse/SLING-6690 > Project: Sling > Issue Type: Sub-task > Components: Extensions >Affects Versions: Discovery Commons 1.0.12 >Reporter: Karl Pauls >Assignee: Karl Pauls > Labels: patch-available > Fix For: Discovery Commons 1.0.20 > > Attachments: SLING-6690.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (SLING-6690) Replace commons.json usage in org.apache.sling.discovery.commons
[ https://issues.apache.org/jira/browse/SLING-6690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls updated SLING-6690: -- Attachment: SLING-6690.patch The discovery oak module tests uncovered some minor bugs - hence, updating the patch inplace. Should be good now. > Replace commons.json usage in org.apache.sling.discovery.commons > > > Key: SLING-6690 > URL: https://issues.apache.org/jira/browse/SLING-6690 > Project: Sling > Issue Type: Sub-task > Components: Extensions >Affects Versions: Discovery Commons 1.0.12 >Reporter: Karl Pauls >Assignee: Karl Pauls > Labels: patch-available > Fix For: Discovery Commons 1.0.20 > > Attachments: SLING-6690.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (SLING-6689) Replace commons.json usage in org.apache.sling.discovery.base
[ https://issues.apache.org/jira/browse/SLING-6689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls updated SLING-6689: -- Attachment: SLING-6689.patch The discovery oak module tests uncovered some minor bugs - hence, updating the patch in place. > Replace commons.json usage in org.apache.sling.discovery.base > - > > Key: SLING-6689 > URL: https://issues.apache.org/jira/browse/SLING-6689 > Project: Sling > Issue Type: Sub-task > Components: Extensions >Affects Versions: Discovery Base 1.1.2 >Reporter: Karl Pauls >Assignee: Karl Pauls > Labels: patch-available > Fix For: Discovery Base 1.1.4 > > Attachments: SLING-6689.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (SLING-6689) Replace commons.json usage in org.apache.sling.discovery.base
[ https://issues.apache.org/jira/browse/SLING-6689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls updated SLING-6689: -- Attachment: (was: SLING-6689.patch) > Replace commons.json usage in org.apache.sling.discovery.base > - > > Key: SLING-6689 > URL: https://issues.apache.org/jira/browse/SLING-6689 > Project: Sling > Issue Type: Sub-task > Components: Extensions >Affects Versions: Discovery Base 1.1.2 >Reporter: Karl Pauls >Assignee: Karl Pauls > Labels: patch-available > Fix For: Discovery Base 1.1.4 > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (SLING-6692) Replace commons.json usage in org.apache.sling.discovery.oak
[ https://issues.apache.org/jira/browse/SLING-6692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls reassigned SLING-6692: - Assignee: Karl Pauls > Replace commons.json usage in org.apache.sling.discovery.oak > > > Key: SLING-6692 > URL: https://issues.apache.org/jira/browse/SLING-6692 > Project: Sling > Issue Type: Sub-task > Components: Extensions >Affects Versions: Discovery Oak 1.2.10 >Reporter: Karl Pauls >Assignee: Karl Pauls > Fix For: Discovery Oak 1.2.18 > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (SLING-6691) Replace commons.json usage in org.apache.sling.discovery.impl
[ https://issues.apache.org/jira/browse/SLING-6691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls updated SLING-6691: -- Attachment: SLING-6691.patch This one is basically just switching the dependencies to johnzon for the tests. Good to see they pass so as they aggregate the other discovery bundles. Please review. > Replace commons.json usage in org.apache.sling.discovery.impl > - > > Key: SLING-6691 > URL: https://issues.apache.org/jira/browse/SLING-6691 > Project: Sling > Issue Type: Sub-task > Components: Extensions >Affects Versions: Discovery Impl 1.2.8 >Reporter: Karl Pauls >Assignee: Karl Pauls > Labels: patch-available > Fix For: Discovery Impl 1.2.12 > > Attachments: SLING-6691.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (SLING-6691) Replace commons.json usage in org.apache.sling.discovery.impl
[ https://issues.apache.org/jira/browse/SLING-6691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls updated SLING-6691: -- Labels: patch-available (was: ) > Replace commons.json usage in org.apache.sling.discovery.impl > - > > Key: SLING-6691 > URL: https://issues.apache.org/jira/browse/SLING-6691 > Project: Sling > Issue Type: Sub-task > Components: Extensions >Affects Versions: Discovery Impl 1.2.8 >Reporter: Karl Pauls >Assignee: Karl Pauls > Labels: patch-available > Fix For: Discovery Impl 1.2.12 > > Attachments: SLING-6691.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (SLING-6691) Replace commons.json usage in org.apache.sling.discovery.impl
[ https://issues.apache.org/jira/browse/SLING-6691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls reassigned SLING-6691: - Assignee: Karl Pauls > Replace commons.json usage in org.apache.sling.discovery.impl > - > > Key: SLING-6691 > URL: https://issues.apache.org/jira/browse/SLING-6691 > Project: Sling > Issue Type: Sub-task > Components: Extensions >Affects Versions: Discovery Impl 1.2.8 >Reporter: Karl Pauls >Assignee: Karl Pauls > Fix For: Discovery Impl 1.2.12 > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (SLING-6690) Replace commons.json usage in org.apache.sling.discovery.commons
[ https://issues.apache.org/jira/browse/SLING-6690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls updated SLING-6690: -- Labels: patch-available (was: ) > Replace commons.json usage in org.apache.sling.discovery.commons > > > Key: SLING-6690 > URL: https://issues.apache.org/jira/browse/SLING-6690 > Project: Sling > Issue Type: Sub-task > Components: Extensions >Affects Versions: Discovery Commons 1.0.12 >Reporter: Karl Pauls >Assignee: Karl Pauls > Labels: patch-available > Fix For: Discovery Commons 1.0.20 > > Attachments: SLING-6690.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (SLING-6690) Replace commons.json usage in org.apache.sling.discovery.commons
[ https://issues.apache.org/jira/browse/SLING-6690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls updated SLING-6690: -- Attachment: SLING-6690.patch Please review. > Replace commons.json usage in org.apache.sling.discovery.commons > > > Key: SLING-6690 > URL: https://issues.apache.org/jira/browse/SLING-6690 > Project: Sling > Issue Type: Sub-task > Components: Extensions >Affects Versions: Discovery Commons 1.0.12 >Reporter: Karl Pauls >Assignee: Karl Pauls > Labels: patch-available > Fix For: Discovery Commons 1.0.20 > > Attachments: SLING-6690.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (SLING-6690) Replace commons.json usage in org.apache.sling.discovery.commons
[ https://issues.apache.org/jira/browse/SLING-6690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls reassigned SLING-6690: - Assignee: Karl Pauls > Replace commons.json usage in org.apache.sling.discovery.commons > > > Key: SLING-6690 > URL: https://issues.apache.org/jira/browse/SLING-6690 > Project: Sling > Issue Type: Sub-task > Components: Extensions >Affects Versions: Discovery Commons 1.0.12 >Reporter: Karl Pauls >Assignee: Karl Pauls > Fix For: Discovery Commons 1.0.20 > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (SLING-6689) Replace commons.json usage in org.apache.sling.discovery.base
[ https://issues.apache.org/jira/browse/SLING-6689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls updated SLING-6689: -- Attachment: SLING-6689.patch This one wasn't that bad. Please review. > Replace commons.json usage in org.apache.sling.discovery.base > - > > Key: SLING-6689 > URL: https://issues.apache.org/jira/browse/SLING-6689 > Project: Sling > Issue Type: Sub-task > Components: Extensions >Affects Versions: Discovery Base 1.1.2 >Reporter: Karl Pauls >Assignee: Karl Pauls > Labels: patch-available > Fix For: Discovery Base 1.1.4 > > Attachments: SLING-6689.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (SLING-6689) Replace commons.json usage in org.apache.sling.discovery.base
[ https://issues.apache.org/jira/browse/SLING-6689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls reassigned SLING-6689: - Assignee: Karl Pauls > Replace commons.json usage in org.apache.sling.discovery.base > - > > Key: SLING-6689 > URL: https://issues.apache.org/jira/browse/SLING-6689 > Project: Sling > Issue Type: Sub-task > Components: Extensions >Affects Versions: Discovery Base 1.1.2 >Reporter: Karl Pauls >Assignee: Karl Pauls > Fix For: Discovery Base 1.1.4 > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (SLING-6687) Replace commons.json usage in org.apache.sling.adapter
[ https://issues.apache.org/jira/browse/SLING-6687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls updated SLING-6687: -- Labels: patch-available (was: ) > Replace commons.json usage in org.apache.sling.adapter > -- > > Key: SLING-6687 > URL: https://issues.apache.org/jira/browse/SLING-6687 > Project: Sling > Issue Type: Sub-task > Components: Extensions >Affects Versions: Adapter 2.1.8 >Reporter: Karl Pauls >Assignee: Karl Pauls > Labels: patch-available > Fix For: Adapter 2.1.10 > > Attachments: SLING-6687.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (SLING-6687) Replace commons.json usage in org.apache.sling.adapter
[ https://issues.apache.org/jira/browse/SLING-6687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls reassigned SLING-6687: - Assignee: Karl Pauls > Replace commons.json usage in org.apache.sling.adapter > -- > > Key: SLING-6687 > URL: https://issues.apache.org/jira/browse/SLING-6687 > Project: Sling > Issue Type: Sub-task > Components: Extensions >Affects Versions: Adapter 2.1.8 >Reporter: Karl Pauls >Assignee: Karl Pauls > Fix For: Adapter 2.1.10 > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (SLING-6687) Replace commons.json usage in org.apache.sling.adapter
[ https://issues.apache.org/jira/browse/SLING-6687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls updated SLING-6687: -- Attachment: SLING-6687.patch This one looks pretty straight forward. However, I don't think the tests touch the relevant parts at all - hence, the provided patch [^SLING-6687.patch] needs to be considered completely untested at this point (in other words, I probably will need help from somebody who knows how to test it). > Replace commons.json usage in org.apache.sling.adapter > -- > > Key: SLING-6687 > URL: https://issues.apache.org/jira/browse/SLING-6687 > Project: Sling > Issue Type: Sub-task > Components: Extensions >Affects Versions: Adapter 2.1.8 >Reporter: Karl Pauls >Assignee: Karl Pauls > Labels: patch-available > Fix For: Adapter 2.1.10 > > Attachments: SLING-6687.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (SLING-6679) Replace usage of org.apache.sling.commons.json.*
[ https://issues.apache.org/jira/browse/SLING-6679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940703#comment-15940703 ] Karl Pauls commented on SLING-6679: --- I did do that in one or two places where it seemed sensible. For the rest well, it is an option but at this point I would rather not do it. Basically, in the case of the commons.johnzon bundle there is virtual no overhead for the provider lookup and for other providers I would wait until this actually becomes a problem. > Replace usage of org.apache.sling.commons.json.* > > > Key: SLING-6679 > URL: https://issues.apache.org/jira/browse/SLING-6679 > Project: Sling > Issue Type: Improvement >Reporter: Karl Pauls >Assignee: Karl Pauls > > Following the deprecation of org.apache.sling.commons.json (SLING-6536) we > need to replace its usage everywhere else (at least if we want to be able to > release other modules that depend on it). > This is the umbrella issue for getting this done. The idea is to create > sub-issues with patches for individual components, review the patches, and > when all are done: close this issue. > General discussions and problems should go to this issue and specific ones on > the sub-issue in question. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (SLING-6679) Replace usage of org.apache.sling.commons.json.*
[ https://issues.apache.org/jira/browse/SLING-6679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940670#comment-15940670 ] Stefan Seifert commented on SLING-6679: --- i had a look as the patch from SLING-6694 - looks good to me. one general question left: should we create a static instance of the factories like JsonReaderFactory? this would avoid looking up the json provider and intializing it again on every invocation. according to http://docs.oracle.com/javaee/7/api/javax/json/JsonReaderFactory.html it's threadsafe. same applies to the other factories. on the other hand this may be a premature optimization, i've no metrics if it really helps. > Replace usage of org.apache.sling.commons.json.* > > > Key: SLING-6679 > URL: https://issues.apache.org/jira/browse/SLING-6679 > Project: Sling > Issue Type: Improvement >Reporter: Karl Pauls >Assignee: Karl Pauls > > Following the deprecation of org.apache.sling.commons.json (SLING-6536) we > need to replace its usage everywhere else (at least if we want to be able to > release other modules that depend on it). > This is the umbrella issue for getting this done. The idea is to create > sub-issues with patches for individual components, review the patches, and > when all are done: close this issue. > General discussions and problems should go to this issue and specific ones on > the sub-issue in question. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (SLING-6710) Vanity Path might get removed if a resource is updated
[ https://issues.apache.org/jira/browse/SLING-6710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940666#comment-15940666 ] Carsten Ziegeler commented on SLING-6710: - Added a test case in rev 1788498 which fails in 1.5.20 but passes with the above applied fix > Vanity Path might get removed if a resource is updated > -- > > Key: SLING-6710 > URL: https://issues.apache.org/jira/browse/SLING-6710 > Project: Sling > Issue Type: Bug > Components: ResourceResolver >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Blocker > Fix For: Resource Resolver 1.5.22 > > > Assume there is a resource at /libs/foo which has a child resource > /libs/foo/jcr:content with a vanity path. If now /libs/foo is updated, the > current implementation first removes the vanity path for /libs/foo (as > defined in the child resource jcr:content) but then fails to re-add it as it > does not take the jcr:content child resource into account. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Resolved] (SLING-6710) Vanity Path might get removed if a resource is updated
[ https://issues.apache.org/jira/browse/SLING-6710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-6710. - Resolution: Fixed > Vanity Path might get removed if a resource is updated > -- > > Key: SLING-6710 > URL: https://issues.apache.org/jira/browse/SLING-6710 > Project: Sling > Issue Type: Bug > Components: ResourceResolver >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Blocker > Fix For: Resource Resolver 1.5.22 > > > Assume there is a resource at /libs/foo which has a child resource > /libs/foo/jcr:content with a vanity path. If now /libs/foo is updated, the > current implementation first removes the vanity path for /libs/foo (as > defined in the child resource jcr:content) but then fails to re-add it as it > does not take the jcr:content child resource into account. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (SLING-6710) Vanity Path might get removed if a resource is updated
[ https://issues.apache.org/jira/browse/SLING-6710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940615#comment-15940615 ] Carsten Ziegeler commented on SLING-6710: - Updated the implementation in rev 1788490 to check the updated resource and also check for a potential child resource named jcr:content In addition improved the handling of update and discard invalid paths as quickly as possible > Vanity Path might get removed if a resource is updated > -- > > Key: SLING-6710 > URL: https://issues.apache.org/jira/browse/SLING-6710 > Project: Sling > Issue Type: Bug > Components: ResourceResolver >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Blocker > Fix For: Resource Resolver 1.5.22 > > > Assume there is a resource at /libs/foo which has a child resource > /libs/foo/jcr:content with a vanity path. If now /libs/foo is updated, the > current implementation first removes the vanity path for /libs/foo (as > defined in the child resource jcr:content) but then fails to re-add it as it > does not take the jcr:content child resource into account. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (SLING-6708) Sling Dynamic Include - Usage of nocache selector allows uncached access to everything
[
https://issues.apache.org/jira/browse/SLING-6708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940614#comment-15940614
]
Roy Teeuwen commented on SLING-6708:
Indeed, this is more of a problem related to the AEM dispatcher itself instead
of this module
> Sling Dynamic Include - Usage of nocache selector allows uncached access to
> everything
> --
>
> Key: SLING-6708
> URL: https://issues.apache.org/jira/browse/SLING-6708
> Project: Sling
> Issue Type: Bug
> Components: Extensions
>Affects Versions: Dynamic Include 3.0.0, Dynamic Include 3.0.2
>Reporter: Henry Kuijpers
>Priority: Blocker
>
> The SDI module works with a nocache-selector (or a selector that we
> arbitrarily choose).
> However, we cannot guarantee that only SDI's requests come in through the
> nocache-selector. It can be any request.
> This document says https://github.com/Cognifide/Sling-Dynamic-Include
> that we should configure the Dispatcher to not cache when
> {code}*.nocache.html*{code} can be applied to the request.
> This means that anyone can use the nocache-selector on any request to bypass
> Dispatcher caching for html files.
> It even means that ".nocache.html" can appear anywhere in the full request
> URL.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Closed] (SLING-6622) maven-sling-plugin: Add "fsmount" and "fsunmount" goals
[ https://issues.apache.org/jira/browse/SLING-6622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert closed SLING-6622. - > maven-sling-plugin: Add "fsmount" and "fsunmount" goals > --- > > Key: SLING-6622 > URL: https://issues.apache.org/jira/browse/SLING-6622 > Project: Sling > Issue Type: New Feature > Components: Tooling >Reporter: Stefan Seifert >Assignee: Stefan Seifert > Fix For: Maven Sling Plugin 2.2.0 > > > the feature to add osgi configurations for the file system resource provider > is quite hidden with the optional "mountByFs" property from the > install/uninstall goals. > we should additionally add two explicit goals "fsmount" and "fsunmount" > allowing to add or remove these configs without installing/uninstalling the > bundle at the same time. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Closed] (SLING-6619) maven-sling-plugin: Switch to javax.json + Johnzon
[ https://issues.apache.org/jira/browse/SLING-6619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert closed SLING-6619. - > maven-sling-plugin: Switch to javax.json + Johnzon > -- > > Key: SLING-6619 > URL: https://issues.apache.org/jira/browse/SLING-6619 > Project: Sling > Issue Type: Improvement > Components: Tooling >Affects Versions: Maven Sling Plugin 2.1.10 >Reporter: Stefan Seifert >Assignee: Stefan Seifert > Fix For: Maven Sling Plugin 2.2.0 > > > we should get rid of o.a.s.common.json and replace usage with javax.json + > johnzon. > maven-sling-plugin is a maven plugin, so it's easy to switch the dependencies. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Closed] (SLING-6630) maven-sling-plugin: Support Mount FileVault XML for File System Resource Provider
[ https://issues.apache.org/jira/browse/SLING-6630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert closed SLING-6630. - > maven-sling-plugin: Support Mount FileVault XML for File System Resource > Provider > - > > Key: SLING-6630 > URL: https://issues.apache.org/jira/browse/SLING-6630 > Project: Sling > Issue Type: New Feature > Components: Tooling >Reporter: Stefan Seifert >Assignee: Stefan Seifert > Fix For: Maven Sling Plugin 2.2.0 > > > with SLING-6537 the file system resource provider can also be used to mount > filevault xml file system layouts. > we should enhance the maven-sling-plugin to support this layout as well for > the fsmount and fsunmount goals (SLING-6622). -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[RESULT] [VOTE] Release Apache Sling Maven Sling Plugin 2.2.0
Hi, The vote has passed with the following result : +1 (binding): Stefan Seifert, Carsten Ziegeler, Justin Edelson I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. stefan
[jira] [Commented] (SLING-6708) Sling Dynamic Include - Usage of nocache selector allows uncached access to everything
[
https://issues.apache.org/jira/browse/SLING-6708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940587#comment-15940587
]
Stefan Seifert commented on SLING-6708:
---
not sure what should be fixed inside sling or SDI for this issue.
you can always make the pattern more explicit in your webserver configuration
and let only requests pass to URLs where you expect and allow it.
> Sling Dynamic Include - Usage of nocache selector allows uncached access to
> everything
> --
>
> Key: SLING-6708
> URL: https://issues.apache.org/jira/browse/SLING-6708
> Project: Sling
> Issue Type: Bug
> Components: Extensions
>Affects Versions: Dynamic Include 3.0.0, Dynamic Include 3.0.2
>Reporter: Henry Kuijpers
>Priority: Blocker
>
> The SDI module works with a nocache-selector (or a selector that we
> arbitrarily choose).
> However, we cannot guarantee that only SDI's requests come in through the
> nocache-selector. It can be any request.
> This document says https://github.com/Cognifide/Sling-Dynamic-Include
> that we should configure the Dispatcher to not cache when
> {code}*.nocache.html*{code} can be applied to the request.
> This means that anyone can use the nocache-selector on any request to bypass
> Dispatcher caching for html files.
> It even means that ".nocache.html" can appear anywhere in the full request
> URL.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (SLING-6684) Replace commons.json usage in org.apache.sling.jcr.jackrabbit.accessmanager
[ https://issues.apache.org/jira/browse/SLING-6684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls updated SLING-6684: -- Attachment: (was: SLING-6684-2.patch) > Replace commons.json usage in org.apache.sling.jcr.jackrabbit.accessmanager > --- > > Key: SLING-6684 > URL: https://issues.apache.org/jira/browse/SLING-6684 > Project: Sling > Issue Type: Sub-task > Components: JCR >Affects Versions: JCR Jackrabbit Access Manager 2.1.2 >Reporter: Karl Pauls >Assignee: Karl Pauls > Labels: patch-available > Fix For: JCR Jackrabbit Access Manager 2.1.4 > > Attachments: SLING-6684-2.patch, SLING-6684.patch > > > This bundle has no tests so it is hard to say if stuff works. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (SLING-6684) Replace commons.json usage in org.apache.sling.jcr.jackrabbit.accessmanager
[ https://issues.apache.org/jira/browse/SLING-6684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls updated SLING-6684: -- Attachment: SLING-6684-2.patch > Replace commons.json usage in org.apache.sling.jcr.jackrabbit.accessmanager > --- > > Key: SLING-6684 > URL: https://issues.apache.org/jira/browse/SLING-6684 > Project: Sling > Issue Type: Sub-task > Components: JCR >Affects Versions: JCR Jackrabbit Access Manager 2.1.2 >Reporter: Karl Pauls >Assignee: Karl Pauls > Labels: patch-available > Fix For: JCR Jackrabbit Access Manager 2.1.4 > > Attachments: SLING-6684-2.patch, SLING-6684.patch > > > This bundle has no tests so it is hard to say if stuff works. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (SLING-6679) Replace usage of org.apache.sling.commons.json.*
[ https://issues.apache.org/jira/browse/SLING-6679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940549#comment-15940549 ] Karl Pauls commented on SLING-6679: --- I updated the patches on SLING-6681, SLING-6683, SLING-6684, SLING-6685, SLING-6694 making them use the new commons.johnzon bundle and trying to incorporate the suggestions by [~sseif...@pro-vision.de] and [~cziegeler]. At this point, I would hope that they as well as SLING-6682 and SLING-6700 are acceptable like this - hence, please review. I'll continue with the other issues now. > Replace usage of org.apache.sling.commons.json.* > > > Key: SLING-6679 > URL: https://issues.apache.org/jira/browse/SLING-6679 > Project: Sling > Issue Type: Improvement >Reporter: Karl Pauls >Assignee: Karl Pauls > > Following the deprecation of org.apache.sling.commons.json (SLING-6536) we > need to replace its usage everywhere else (at least if we want to be able to > release other modules that depend on it). > This is the umbrella issue for getting this done. The idea is to create > sub-issues with patches for individual components, review the patches, and > when all are done: close this issue. > General discussions and problems should go to this issue and specific ones on > the sub-issue in question. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (SLING-6710) Vanity Path might get removed if a resource is updated
Carsten Ziegeler created SLING-6710: --- Summary: Vanity Path might get removed if a resource is updated Key: SLING-6710 URL: https://issues.apache.org/jira/browse/SLING-6710 Project: Sling Issue Type: Bug Components: ResourceResolver Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Priority: Blocker Fix For: Resource Resolver 1.5.22 Assume there is a resource at /libs/foo which has a child resource /libs/foo/jcr:content with a vanity path. If now /libs/foo is updated, the current implementation first removes the vanity path for /libs/foo (as defined in the child resource jcr:content) but then fails to re-add it as it does not take the jcr:content child resource into account. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (SLING-6684) Replace commons.json usage in org.apache.sling.jcr.jackrabbit.accessmanager
[ https://issues.apache.org/jira/browse/SLING-6684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls updated SLING-6684: -- Attachment: SLING-6684-2.patch Updated patch [^SLING-6684-2.patch] that uses commons.json. > Replace commons.json usage in org.apache.sling.jcr.jackrabbit.accessmanager > --- > > Key: SLING-6684 > URL: https://issues.apache.org/jira/browse/SLING-6684 > Project: Sling > Issue Type: Sub-task > Components: JCR >Affects Versions: JCR Jackrabbit Access Manager 2.1.2 >Reporter: Karl Pauls >Assignee: Karl Pauls > Labels: patch-available > Fix For: JCR Jackrabbit Access Manager 2.1.4 > > Attachments: SLING-6684-2.patch, SLING-6684.patch > > > This bundle has no tests so it is hard to say if stuff works. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Comment Edited] (SLING-6680) contributing esx scripting engine
[
https://issues.apache.org/jira/browse/SLING-6680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940530#comment-15940530
]
Bertrand Delacretaz edited comment on SLING-6680 at 3/24/17 3:25 PM:
-
Thanks for your contribution! I have committed it under contrib/scripting/esx
and made minor changes in http://svn.apache.org/r1788469 and
http://svn.apache.org/r1788470
It would be good to have integration tests, the Sling Pax Exam mechanism as
used in bundles/extensions/org.apache.sling.resource.presence can be good for
that. For now the manual tests described in the README worked for me, both the
minimal rendering example and the demo.html pages, provided one runs {{npm
install}} before building the module as described in the README.
I think we should consider this module experimental for now but it's good to
have it IMO, I especially like the ability to use existing NodeJS modules.
was (Author: bdelacretaz):
Thanks for your contribution! I have committed it under contrib/scripting/esx
and made minor changes in http://svn.apache.org/r1788469 and
http://svn.apache.org/r1788470
It would be good to have integration tests, the Sling Pax Exam mechanism as
used in bundles/extensions/org.apache.sling.resource.presence can be good for
that.
I think we should consider this module experimental for now but it's good to
have it IMO, I especially like the ability to use existing NodeJS modules.
> contributing esx scripting engine
> -
>
> Key: SLING-6680
> URL: https://issues.apache.org/jira/browse/SLING-6680
> Project: Sling
> Issue Type: New Feature
> Components: Scripting
>Reporter: Senol Tas
>Assignee: Bertrand Delacretaz
>Priority: Minor
> Fix For: Apache Sling Scripting ESX 0.2.0
>
> Attachments: esx.zip
>
>
> I'd like to contribute a small scripting engine which is using a nodejs like
> module loading.
> This module implements a Nashorn Apache Sling Script Engine for the "esx"
> extension.
> It requires a function named render in the esx script that processes the
> request.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Resolved] (SLING-6680) contributing esx scripting engine
[ https://issues.apache.org/jira/browse/SLING-6680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz resolved SLING-6680. Resolution: Fixed Thanks for your contribution! I have committed it under contrib/scripting/esx and made minor changes in http://svn.apache.org/r1788469 and http://svn.apache.org/r1788470 It would be good to have integration tests, the Sling Pax Exam mechanism as used in bundles/extensions/org.apache.sling.resource.presence can be good for that. I think we should consider this module experimental for now but it's good to have it IMO, I especially like the ability to use existing NodeJS modules. > contributing esx scripting engine > - > > Key: SLING-6680 > URL: https://issues.apache.org/jira/browse/SLING-6680 > Project: Sling > Issue Type: New Feature > Components: Scripting >Reporter: Senol Tas >Assignee: Bertrand Delacretaz >Priority: Minor > Fix For: Apache Sling Scripting ESX 0.2.0 > > Attachments: esx.zip > > > I'd like to contribute a small scripting engine which is using a nodejs like > module loading. > This module implements a Nashorn Apache Sling Script Engine for the "esx" > extension. > It requires a function named render in the esx script that processes the > request. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (SLING-6683) Replace commons.json usage in org.apache.sling.servlets.get
[ https://issues.apache.org/jira/browse/SLING-6683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls updated SLING-6683: -- Attachment: SLING-6683-2.patch Updated patch [^SLING-6683-2.patch] using commons.johnzon and does a better job in flushing writers. > Replace commons.json usage in org.apache.sling.servlets.get > --- > > Key: SLING-6683 > URL: https://issues.apache.org/jira/browse/SLING-6683 > Project: Sling > Issue Type: Sub-task > Components: Servlets >Affects Versions: Servlets Get 2.1.20 >Reporter: Karl Pauls >Assignee: Karl Pauls > Labels: patch-available > Fix For: Servlets Get 2.1.24 > > Attachments: SLING-6683-2.patch, SLING-6683.patch > > > We need to replace the usage of commons.json but this one does heavy rely on > some of the helper classes. Its going to be tricky to make sure it still > works as intended. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (SLING-6680) contributing esx scripting engine
[ https://issues.apache.org/jira/browse/SLING-6680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz updated SLING-6680: --- Fix Version/s: Apache Sling Scripting ESX 1.0.0 > contributing esx scripting engine > - > > Key: SLING-6680 > URL: https://issues.apache.org/jira/browse/SLING-6680 > Project: Sling > Issue Type: New Feature > Components: Scripting >Reporter: Senol Tas >Assignee: Bertrand Delacretaz >Priority: Minor > Fix For: Apache Sling Scripting ESX 1.0.0 > > Attachments: esx.zip > > > I'd like to contribute a small scripting engine which is using a nodejs like > module loading. > This module implements a Nashorn Apache Sling Script Engine for the "esx" > extension. > It requires a function named render in the esx script that processes the > request. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (SLING-6680) contributing esx scripting engine
[ https://issues.apache.org/jira/browse/SLING-6680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz reassigned SLING-6680: -- Assignee: Bertrand Delacretaz > contributing esx scripting engine > - > > Key: SLING-6680 > URL: https://issues.apache.org/jira/browse/SLING-6680 > Project: Sling > Issue Type: New Feature > Components: Scripting >Reporter: Senol Tas >Assignee: Bertrand Delacretaz >Priority: Minor > Attachments: esx.zip > > > I'd like to contribute a small scripting engine which is using a nodejs like > module loading. > This module implements a Nashorn Apache Sling Script Engine for the "esx" > extension. > It requires a function named render in the esx script that processes the > request. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Resolved] (SLING-6706) Migrate to R6 annotations, clean up dependencies
[ https://issues.apache.org/jira/browse/SLING-6706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-6706. - Resolution: Fixed Updated in rev 1788461 > Migrate to R6 annotations, clean up dependencies > > > Key: SLING-6706 > URL: https://issues.apache.org/jira/browse/SLING-6706 > Project: Sling > Issue Type: Improvement > Components: Engine >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler > Fix For: Engine 2.6.8 > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Comment Edited] (SLING-6090) Avoid using nt:resource while creating file nodes via SlingPostServlet
[
https://issues.apache.org/jira/browse/SLING-6090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940455#comment-15940455
]
Konrad Windszus edited comment on SLING-6090 at 3/24/17 2:44 PM:
-
Just for the reference: A nodetype definition for Sling could then look like
this
{code}
/**
* This node type may be used to represent the content of a file. This should be
* preferred over nt:resource if non referenceable nt:file nodes are required
*
*/
[sling:Resource] > mix:mimeType, mix:lastModified
primaryitem jcr:data
- jcr:data (BINARY) mandatory
{code}
but {{sling:Resource}} is already a mixin, being defined in
https://github.com/apache/sling/blob/d316f91f0305a27e0033e477199aac9d2197ef7f/bundles/jcr/resource/src/main/resources/SLING-INF/nodetypes/resource.cnd.
was (Author: kwin):
Just for the reference: A nodetype definition for Sling could then look like
this
{code}
/**
* This node type may be used to represent the content of a file. This should be
* preferred over nt:resource if non referenceable nt:file nodes are required
*
*/
[sling:Resource] > mix:mimeType, mix:lastModified
primaryitem jcr:data
- jcr:data (BINARY) mandatory
{code}
> Avoid using nt:resource while creating file nodes via SlingPostServlet
> --
>
> Key: SLING-6090
> URL: https://issues.apache.org/jira/browse/SLING-6090
> Project: Sling
> Issue Type: Improvement
> Components: Servlets
>Reporter: Chetan Mehrotra
>Assignee: Chetan Mehrotra
> Fix For: Servlets Post 2.3.16
>
>
> Currently Sling uses {{nt:resource}} nodetype while creating file nodes in
> {{SlingFileUploadHandler}} and {{StreamedChunk}}.
> As discussed in OAK-4567 and also in best practices at [1] it would be better
> to avoid using a referenceable nodetype and instead use another nodetype like
> {{oak:Resource}}
> Mail thread on DL
> [1]
> https://adapt.to/2016/en/schedule/let_s-run-the-whole-web-on-apache-sling-and-oak-.html
> [2] http://markmail.org/thread/77xvjxtx42euhss4
> [3] http://markmail.org/thread/tnqbcegadnyaflw4
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (SLING-6090) Avoid using nt:resource while creating file nodes via SlingPostServlet
[
https://issues.apache.org/jira/browse/SLING-6090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940455#comment-15940455
]
Konrad Windszus commented on SLING-6090:
Just for the reference: A nodetype definition for Sling could then look like
this
{code}
/**
* This node type may be used to represent the content of a file. This should be
* preferred over nt:resource if non referenceable nt:file nodes are required
*
*/
[sling:Resource] > mix:mimeType, mix:lastModified
primaryitem jcr:data
- jcr:data (BINARY) mandatory
{code}
> Avoid using nt:resource while creating file nodes via SlingPostServlet
> --
>
> Key: SLING-6090
> URL: https://issues.apache.org/jira/browse/SLING-6090
> Project: Sling
> Issue Type: Improvement
> Components: Servlets
>Reporter: Chetan Mehrotra
>Assignee: Chetan Mehrotra
> Fix For: Servlets Post 2.3.16
>
>
> Currently Sling uses {{nt:resource}} nodetype while creating file nodes in
> {{SlingFileUploadHandler}} and {{StreamedChunk}}.
> As discussed in OAK-4567 and also in best practices at [1] it would be better
> to avoid using a referenceable nodetype and instead use another nodetype like
> {{oak:Resource}}
> Mail thread on DL
> [1]
> https://adapt.to/2016/en/schedule/let_s-run-the-whole-web-on-apache-sling-and-oak-.html
> [2] http://markmail.org/thread/77xvjxtx42euhss4
> [3] http://markmail.org/thread/tnqbcegadnyaflw4
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Created] (SLING-6709) The HAPI implementation doesn't provide the correct attribute type for "itemscope"
Radu Cotescu created SLING-6709:
---
Summary: The HAPI implementation doesn't provide the correct
attribute type for "itemscope"
Key: SLING-6709
URL: https://issues.apache.org/jira/browse/SLING-6709
Project: Sling
Issue Type: Bug
Components: Extensions
Affects Versions: HApi 1.0.0
Reporter: Radu Cotescu
Assignee: Andrei Dulvac
The microdata specification defines the {{itemscope}} attribute as boolean [0].
However, the current Sling implementation returns a string, leading to invalid
HTML 5 markup.
[0] - https://www.w3.org/TR/microdata/#attr-itemscope
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Resolved] (SLING-6707) LoginAdminWhitelist.fragment metatype descriptor not as intended
[
https://issues.apache.org/jira/browse/SLING-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Sedding resolved SLING-6707.
---
Resolution: Fixed
Fix Version/s: JCR Base 3.0.2
Fixed in [r1788436|https://svn.apache.org/r1788436].
> LoginAdminWhitelist.fragment metatype descriptor not as intended
>
>
> Key: SLING-6707
> URL: https://issues.apache.org/jira/browse/SLING-6707
> Project: Sling
> Issue Type: Improvement
> Components: JCR
>Affects Versions: JCR Base 3.0.0
>Reporter: Julian Sedding
>Assignee: Julian Sedding
>Priority: Minor
> Fix For: JCR Base 3.0.2
>
>
> The metatype description for {{LoginAdminWhitelist.fragment}} factory
> configurations is not as intended:
> - {{whitelist.regexp}} has no description
> - {{whitelist.bundles.default}} is deprecated and should not be in the
> metatype (but still work if configured)
> - {{whitelist.bundles.additional}} is deprecated and should not be in the
> metatype (but still work if configured)
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (SLING-6681) Replace commons.json usage in org.apache.sling.servlets.post
[ https://issues.apache.org/jira/browse/SLING-6681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls updated SLING-6681: -- Attachment: SLING-6681-2.patch Updated patch [^SLING-6681-2.patch] using commons.johnzon. > Replace commons.json usage in org.apache.sling.servlets.post > > > Key: SLING-6681 > URL: https://issues.apache.org/jira/browse/SLING-6681 > Project: Sling > Issue Type: Sub-task > Components: Servlets >Affects Versions: Servlets Post 2.3.14 >Reporter: Karl Pauls >Assignee: Karl Pauls > Labels: patch-available > Fix For: Servlets Post 2.3.16 > > Attachments: SLING-6681-2.patch, SLING-6681.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (SLING-6708) Sling Dynamic Include - Usage of nocache selector allows uncached access to everything
Henry Kuijpers created SLING-6708: - Summary: Sling Dynamic Include - Usage of nocache selector allows uncached access to everything Key: SLING-6708 URL: https://issues.apache.org/jira/browse/SLING-6708 Project: Sling Issue Type: Bug Components: Extensions Affects Versions: Dynamic Include 3.0.0, Dynamic Include 3.0.2 Reporter: Henry Kuijpers Priority: Blocker The SDI module works with a nocache-selector (or a selector that we arbitrarily choose). However, we cannot guarantee that only SDI's requests come in through the nocache-selector. It can be any request. This document says https://github.com/Cognifide/Sling-Dynamic-Include that we should configure the Dispatcher to not cache when *.nocache.html* can be applied to the request. This means that anyone can use the nocache-selector on any request to bypass Dispatcher caching for html files. It even means that ".nocache.html" can appear anywhere in the full request URL. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (SLING-6708) Sling Dynamic Include - Usage of nocache selector allows uncached access to everything
[
https://issues.apache.org/jira/browse/SLING-6708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henry Kuijpers updated SLING-6708:
--
Description:
The SDI module works with a nocache-selector (or a selector that we arbitrarily
choose).
However, we cannot guarantee that only SDI's requests come in through the
nocache-selector. It can be any request.
This document says https://github.com/Cognifide/Sling-Dynamic-Include
that we should configure the Dispatcher to not cache when
{code}*.nocache.html*{code} can be applied to the request.
This means that anyone can use the nocache-selector on any request to bypass
Dispatcher caching for html files.
It even means that ".nocache.html" can appear anywhere in the full request URL.
was:
The SDI module works with a nocache-selector (or a selector that we arbitrarily
choose).
However, we cannot guarantee that only SDI's requests come in through the
nocache-selector. It can be any request.
This document says https://github.com/Cognifide/Sling-Dynamic-Include
that we should configure the Dispatcher to not cache when `*.nocache.html*` can
be applied to the request.
This means that anyone can use the nocache-selector on any request to bypass
Dispatcher caching for html files.
It even means that ".nocache.html" can appear anywhere in the full request URL.
> Sling Dynamic Include - Usage of nocache selector allows uncached access to
> everything
> --
>
> Key: SLING-6708
> URL: https://issues.apache.org/jira/browse/SLING-6708
> Project: Sling
> Issue Type: Bug
> Components: Extensions
>Affects Versions: Dynamic Include 3.0.0, Dynamic Include 3.0.2
>Reporter: Henry Kuijpers
>Priority: Blocker
>
> The SDI module works with a nocache-selector (or a selector that we
> arbitrarily choose).
> However, we cannot guarantee that only SDI's requests come in through the
> nocache-selector. It can be any request.
> This document says https://github.com/Cognifide/Sling-Dynamic-Include
> that we should configure the Dispatcher to not cache when
> {code}*.nocache.html*{code} can be applied to the request.
> This means that anyone can use the nocache-selector on any request to bypass
> Dispatcher caching for html files.
> It even means that ".nocache.html" can appear anywhere in the full request
> URL.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (SLING-6708) Sling Dynamic Include - Usage of nocache selector allows uncached access to everything
[ https://issues.apache.org/jira/browse/SLING-6708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henry Kuijpers updated SLING-6708: -- Description: The SDI module works with a nocache-selector (or a selector that we arbitrarily choose). However, we cannot guarantee that only SDI's requests come in through the nocache-selector. It can be any request. This document says https://github.com/Cognifide/Sling-Dynamic-Include that we should configure the Dispatcher to not cache when `*.nocache.html*` can be applied to the request. This means that anyone can use the nocache-selector on any request to bypass Dispatcher caching for html files. It even means that ".nocache.html" can appear anywhere in the full request URL. was: The SDI module works with a nocache-selector (or a selector that we arbitrarily choose). However, we cannot guarantee that only SDI's requests come in through the nocache-selector. It can be any request. This document says https://github.com/Cognifide/Sling-Dynamic-Include that we should configure the Dispatcher to not cache when *.nocache.html* can be applied to the request. This means that anyone can use the nocache-selector on any request to bypass Dispatcher caching for html files. It even means that ".nocache.html" can appear anywhere in the full request URL. > Sling Dynamic Include - Usage of nocache selector allows uncached access to > everything > -- > > Key: SLING-6708 > URL: https://issues.apache.org/jira/browse/SLING-6708 > Project: Sling > Issue Type: Bug > Components: Extensions >Affects Versions: Dynamic Include 3.0.0, Dynamic Include 3.0.2 >Reporter: Henry Kuijpers >Priority: Blocker > > The SDI module works with a nocache-selector (or a selector that we > arbitrarily choose). > However, we cannot guarantee that only SDI's requests come in through the > nocache-selector. It can be any request. > This document says https://github.com/Cognifide/Sling-Dynamic-Include > that we should configure the Dispatcher to not cache when `*.nocache.html*` > can be applied to the request. > This means that anyone can use the nocache-selector on any request to bypass > Dispatcher caching for html files. > It even means that ".nocache.html" can appear anywhere in the full request > URL. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (SLING-6707) LoginAdminWhitelist.fragment metatype descriptor not as intended
Julian Sedding created SLING-6707:
-
Summary: LoginAdminWhitelist.fragment metatype descriptor not as
intended
Key: SLING-6707
URL: https://issues.apache.org/jira/browse/SLING-6707
Project: Sling
Issue Type: Improvement
Components: JCR
Affects Versions: JCR Base 3.0.0
Reporter: Julian Sedding
Assignee: Julian Sedding
Priority: Minor
The metatype description for {{LoginAdminWhitelist.fragment}} factory
configurations is not as intended:
- {{whitelist.regexp}} has no description
- {{whitelist.bundles.default}} is deprecated and should not be in the metatype
(but still work if configured)
- {{whitelist.bundles.additional}} is deprecated and should not be in the
metatype (but still work if configured)
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Created] (SLING-6706) Migrate to R6 annotations, clean up dependencies
Carsten Ziegeler created SLING-6706: --- Summary: Migrate to R6 annotations, clean up dependencies Key: SLING-6706 URL: https://issues.apache.org/jira/browse/SLING-6706 Project: Sling Issue Type: Improvement Components: Engine Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: Engine 2.6.8 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (SLING-6685) Replace commons.json usage in org.apache.sling.xss
[ https://issues.apache.org/jira/browse/SLING-6685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls updated SLING-6685: -- Attachment: SLING-6685-2.patch After some more clean-up, I think the second patch is good to go so please review again. > Replace commons.json usage in org.apache.sling.xss > -- > > Key: SLING-6685 > URL: https://issues.apache.org/jira/browse/SLING-6685 > Project: Sling > Issue Type: Sub-task > Components: XSS Protection API >Affects Versions: XSS Protection API 1.0.18 >Reporter: Karl Pauls >Assignee: Karl Pauls > Labels: patch-available > Fix For: XSS Protection API 1.0.20 > > Attachments: SLING-6685-2.patch, SLING-6685.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (SLING-6685) Replace commons.json usage in org.apache.sling.xss
[ https://issues.apache.org/jira/browse/SLING-6685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls updated SLING-6685: -- Attachment: (was: SLING-6685-2.patch) > Replace commons.json usage in org.apache.sling.xss > -- > > Key: SLING-6685 > URL: https://issues.apache.org/jira/browse/SLING-6685 > Project: Sling > Issue Type: Sub-task > Components: XSS Protection API >Affects Versions: XSS Protection API 1.0.18 >Reporter: Karl Pauls >Assignee: Karl Pauls > Labels: patch-available > Fix For: XSS Protection API 1.0.20 > > Attachments: SLING-6685.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (SLING-6694) Replace commons.json usage in org.apache.sling.jcr.contentloader
[ https://issues.apache.org/jira/browse/SLING-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls updated SLING-6694: -- Attachment: SLING-6694-2.patch Slightly updated patch [^SLING-6694-2.patch] which allows json comments and contains some clean-ups. > Replace commons.json usage in org.apache.sling.jcr.contentloader > > > Key: SLING-6694 > URL: https://issues.apache.org/jira/browse/SLING-6694 > Project: Sling > Issue Type: Sub-task > Components: JCR >Affects Versions: JCR ContentLoader 2.1.10 >Reporter: Karl Pauls >Assignee: Karl Pauls > Labels: patch-available > Fix For: JCR ContentLoader 2.2.0 > > Attachments: SLING-6694-2.patch, SLING-6694.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Comment Edited] (SLING-6685) Replace commons.json usage in org.apache.sling.xss
[ https://issues.apache.org/jira/browse/SLING-6685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940231#comment-15940231 ] Karl Pauls edited comment on SLING-6685 at 3/24/17 12:25 PM: - Updated patch [^SLING-6685-2.patch] which uses the common.johnzon bundle, enables comments in json, and changes the tests to only use wellformed json. Additionally, I fixed some javadoc and changed the api version to 2.0.0 as this is a breaking change (unfortunately, the api is leaking the JSONObject). was (Author: karlpauls): Updated patch which uses the common.johnzon bundle, enables comments in json, and changes the tests to only use wellformed json. Additionally, I fixed some javadoc and changed the api version to 2.0.0 as this is a breaking change (unfortunately, the api is leaking the JSONObject). > Replace commons.json usage in org.apache.sling.xss > -- > > Key: SLING-6685 > URL: https://issues.apache.org/jira/browse/SLING-6685 > Project: Sling > Issue Type: Sub-task > Components: XSS Protection API >Affects Versions: XSS Protection API 1.0.18 >Reporter: Karl Pauls >Assignee: Karl Pauls > Labels: patch-available > Fix For: XSS Protection API 1.0.20 > > Attachments: SLING-6685-2.patch, SLING-6685.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (SLING-6685) Replace commons.json usage in org.apache.sling.xss
[ https://issues.apache.org/jira/browse/SLING-6685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls updated SLING-6685: -- Attachment: SLING-6685-2.patch Updated patch which uses the common.johnzon bundle, enables comments in json, and changes the tests to only use wellformed json. Additionally, I fixed some javadoc and changed the api version to 2.0.0 as this is a breaking change (unfortunately, the api is leaking the JSONObject). > Replace commons.json usage in org.apache.sling.xss > -- > > Key: SLING-6685 > URL: https://issues.apache.org/jira/browse/SLING-6685 > Project: Sling > Issue Type: Sub-task > Components: XSS Protection API >Affects Versions: XSS Protection API 1.0.18 >Reporter: Karl Pauls >Assignee: Karl Pauls > Labels: patch-available > Fix For: XSS Protection API 1.0.20 > > Attachments: SLING-6685-2.patch, SLING-6685.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (SLING-6658) Register models with their implType implicitly
[
https://issues.apache.org/jira/browse/SLING-6658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940214#comment-15940214
]
Konrad Windszus commented on SLING-6658:
Applied slightly modified documentation patch in
[r1788419|https://svn.apache.org/r1788419].
> Register models with their implType implicitly
> --
>
> Key: SLING-6658
> URL: https://issues.apache.org/jira/browse/SLING-6658
> Project: Sling
> Issue Type: Improvement
>Reporter: Dirk Rudolph
>Assignee: Justin Edelson
>Priority: Minor
> Fix For: Sling Models Impl 1.3.10
>
> Attachments: models.mdtext.patch
>
>
> As discussed in SLING-6652, the implementation of the {{@Exporter}} feature
> introduced a undocumented assumption of the order of the adapterTypes.
> This ticket is about always registering any {{@Model}} implicitly with its
> {{implType}}, if not specified explicitly. This will allow the ExportServlet
> to always use the {{implType}} while creating the {{@Model}} its going to
> export.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Resolved] (SLING-6064) Redirect servlet should encode url for redirecting
[ https://issues.apache.org/jira/browse/SLING-6064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-6064. - Resolution: Fixed Assignee: Carsten Ziegeler Fixed in rev 1788408 > Redirect servlet should encode url for redirecting > -- > > Key: SLING-6064 > URL: https://issues.apache.org/jira/browse/SLING-6064 > Project: Sling > Issue Type: Bug > Components: Servlets >Affects Versions: Servlets Get 2.1.18 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler > Fix For: Servlets Get 2.1.24 > > > The RedirectServlet is directly setting the location header (wondering why > sendRedirect is not used instead?) however it is not encoding the URL > (calling encodeRedirectURL). Therefore if query parameters are appended these > are not encoded. According to the servlet spec, the url should be encoded > before being passed to sendRedirect. I would assume the same applies to > setting the header as it goes in there unmodified -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Resolved] (SLING-6705) Make use of java.jcr api optional
[ https://issues.apache.org/jira/browse/SLING-6705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-6705. - Resolution: Fixed Changed in rev 1788407. The XML rendering is useless if no JCR api is available, but this has always been the case > Make use of java.jcr api optional > - > > Key: SLING-6705 > URL: https://issues.apache.org/jira/browse/SLING-6705 > Project: Sling > Issue Type: Improvement > Components: Servlets >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler > Fix For: Servlets Get 2.1.24 > > > In order to reduce the required dependencies to run a minimal Sling we should > make the dependency to JCR optional -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (SLING-6705) Make use of java.jcr api optional
Carsten Ziegeler created SLING-6705: --- Summary: Make use of java.jcr api optional Key: SLING-6705 URL: https://issues.apache.org/jira/browse/SLING-6705 Project: Sling Issue Type: Improvement Components: Servlets Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: Servlets Get 2.1.24 In order to reduce the required dependencies to run a minimal Sling we should make the dependency to JCR optional -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Resolved] (SLING-6704) Migrate to R6 annotations, clean up dependencies
[ https://issues.apache.org/jira/browse/SLING-6704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-6704. - Resolution: Fixed Updated in rev 1788403, cleaned up some dependencies and also removed unnecessary "immediate" flags from components > Migrate to R6 annotations, clean up dependencies > > > Key: SLING-6704 > URL: https://issues.apache.org/jira/browse/SLING-6704 > Project: Sling > Issue Type: Improvement > Components: Servlets >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler > Fix For: Servlets Get 2.1.24 > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Comment Edited] (SLING-6703) Sling Post Servlet: Do not hide original exception in AbstractPostResponse.setError
[
https://issues.apache.org/jira/browse/SLING-6703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940136#comment-15940136
]
Konrad Windszus edited comment on SLING-6703 at 3/24/17 10:40 AM:
--
I did not some more test and could not see any repository internals being
exposed through exceptions for user's without the appropriate privileges. If
that would be the case, it would need to be fixed in the underlying resource
resolver then, because the Sling POST Servlet takes the current request
resource resolver for all operations.
Therefore I reverted the fix from SLING-4415 in
[r1788402|https://svn.apache.org/r1788402].
was (Author: kwin):
I did not some more test and could not see any repository internals being
exposed through exceptions for user's without the appropriate privileges. If
that would be the case, it would need to be fixed in the underlying resource
resolver then, because the Sling POST Servlet takes the current request
resource resolver for all operation.
Therefore I reverted the fix from SLING-4415 in
[r1788402|https://svn.apache.org/r1788402].
> Sling Post Servlet: Do not hide original exception in
> AbstractPostResponse.setError
> ---
>
> Key: SLING-6703
> URL: https://issues.apache.org/jira/browse/SLING-6703
> Project: Sling
> Issue Type: Improvement
> Components: Servlets
>Affects Versions: Servlets Post 2.3.14
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
> Fix For: Servlets Post 2.3.16
>
>
> Currently {{AbstractPostResponse.setError}}
> (https://github.com/apache/sling/blob/4df9ab2d6592422889c71fa13afd453a10a5a626/bundles/servlets/post/src/main/java/org/apache/sling/servlets/post/AbstractPostResponse.java#L221)
> always ignores the given {{Throwable}} and just creates a new generic
> {{SlingException}}.
> To e.g. allow {{SlingPostProcessor}} to throw meaningful exceptions which
> occur in the response body, the given exception should not be wrapped but
> just the given throwable's message text should be given out in the document.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (SLING-6703) Sling Post Servlet: Do not hide original exception in AbstractPostResponse.setError
[
https://issues.apache.org/jira/browse/SLING-6703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940136#comment-15940136
]
Konrad Windszus commented on SLING-6703:
I did not some more test and could not see any repository internals being
exposed through exceptions for user's without the appropriate privileges. If
that would be the case, it would need to be fixed in the underlying resource
resolver then, because the Sling POST Servlet takes the current request
resource resolver for all operation.
Therefore I reverted the fix from SLING-4415 in
[r1788402|https://svn.apache.org/r1788402].
> Sling Post Servlet: Do not hide original exception in
> AbstractPostResponse.setError
> ---
>
> Key: SLING-6703
> URL: https://issues.apache.org/jira/browse/SLING-6703
> Project: Sling
> Issue Type: Improvement
> Components: Servlets
>Affects Versions: Servlets Post 2.3.14
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
> Fix For: Servlets Post 2.3.16
>
>
> Currently {{AbstractPostResponse.setError}}
> (https://github.com/apache/sling/blob/4df9ab2d6592422889c71fa13afd453a10a5a626/bundles/servlets/post/src/main/java/org/apache/sling/servlets/post/AbstractPostResponse.java#L221)
> always ignores the given {{Throwable}} and just creates a new generic
> {{SlingException}}.
> To e.g. allow {{SlingPostProcessor}} to throw meaningful exceptions which
> occur in the response body, the given exception should not be wrapped but
> just the given throwable's message text should be given out in the document.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Resolved] (SLING-6703) Sling Post Servlet: Do not hide original exception in AbstractPostResponse.setError
[
https://issues.apache.org/jira/browse/SLING-6703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus resolved SLING-6703.
Resolution: Fixed
> Sling Post Servlet: Do not hide original exception in
> AbstractPostResponse.setError
> ---
>
> Key: SLING-6703
> URL: https://issues.apache.org/jira/browse/SLING-6703
> Project: Sling
> Issue Type: Improvement
> Components: Servlets
>Affects Versions: Servlets Post 2.3.14
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
> Fix For: Servlets Post 2.3.16
>
>
> Currently {{AbstractPostResponse.setError}}
> (https://github.com/apache/sling/blob/4df9ab2d6592422889c71fa13afd453a10a5a626/bundles/servlets/post/src/main/java/org/apache/sling/servlets/post/AbstractPostResponse.java#L221)
> always ignores the given {{Throwable}} and just creates a new generic
> {{SlingException}}.
> To e.g. allow {{SlingPostProcessor}} to throw meaningful exceptions which
> occur in the response body, the given exception should not be wrapped but
> just the given throwable's message text should be given out in the document.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Assigned] (SLING-6703) Sling Post Servlet: Do not hide original exception in AbstractPostResponse.setError
[
https://issues.apache.org/jira/browse/SLING-6703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus reassigned SLING-6703:
--
Assignee: Konrad Windszus
> Sling Post Servlet: Do not hide original exception in
> AbstractPostResponse.setError
> ---
>
> Key: SLING-6703
> URL: https://issues.apache.org/jira/browse/SLING-6703
> Project: Sling
> Issue Type: Improvement
> Components: Servlets
>Affects Versions: Servlets Post 2.3.14
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
> Fix For: Servlets Post 2.3.16
>
>
> Currently {{AbstractPostResponse.setError}}
> (https://github.com/apache/sling/blob/4df9ab2d6592422889c71fa13afd453a10a5a626/bundles/servlets/post/src/main/java/org/apache/sling/servlets/post/AbstractPostResponse.java#L221)
> always ignores the given {{Throwable}} and just creates a new generic
> {{SlingException}}.
> To e.g. allow {{SlingPostProcessor}} to throw meaningful exceptions which
> occur in the response body, the given exception should not be wrapped but
> just the given throwable's message text should be given out in the document.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (SLING-6703) Sling Post Servlet: Do not hide original exception in AbstractPostResponse.setError
[
https://issues.apache.org/jira/browse/SLING-6703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-6703:
---
Summary: Sling Post Servlet: Do not hide original exception in
AbstractPostResponse.setError (was: Sling Post Servlet: Do not create hide
original exception in AbstractPostResponse.setError)
> Sling Post Servlet: Do not hide original exception in
> AbstractPostResponse.setError
> ---
>
> Key: SLING-6703
> URL: https://issues.apache.org/jira/browse/SLING-6703
> Project: Sling
> Issue Type: Improvement
> Components: Servlets
>Affects Versions: Servlets Post 2.3.14
>Reporter: Konrad Windszus
> Fix For: Servlets Post 2.3.16
>
>
> Currently {{AbstractPostResponse.setError}}
> (https://github.com/apache/sling/blob/4df9ab2d6592422889c71fa13afd453a10a5a626/bundles/servlets/post/src/main/java/org/apache/sling/servlets/post/AbstractPostResponse.java#L221)
> always ignores the given {{Throwable}} and just creates a new generic
> {{SlingException}}.
> To e.g. allow {{SlingPostProcessor}} to throw meaningful exceptions which
> occur in the response body, the given exception should not be wrapped but
> just the given throwable's message text should be given out in the document.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Resolved] (SLING-6701) Clarify documentation for JCR Content Loader (https://sling.apache.org/documentation/bundles/content-loading-jcr-contentloader.html)
[ https://issues.apache.org/jira/browse/SLING-6701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved SLING-6701. Resolution: Fixed > Clarify documentation for JCR Content Loader > (https://sling.apache.org/documentation/bundles/content-loading-jcr-contentloader.html) > > > Key: SLING-6701 > URL: https://issues.apache.org/jira/browse/SLING-6701 > Project: Sling > Issue Type: Improvement > Components: JCR, Site >Reporter: Konrad Windszus >Assignee: Konrad Windszus > Attachments: content-loading-jcr-contentloader-SLING-6701-v01.html, > SLING-6701-v01.patch > > > Compare with http://www.mail-archive.com/dev@sling.apache.org/msg66056.html. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (SLING-6701) Clarify documentation for JCR Content Loader (https://sling.apache.org/documentation/bundles/content-loading-jcr-contentloader.html)
[ https://issues.apache.org/jira/browse/SLING-6701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940088#comment-15940088 ] Konrad Windszus commented on SLING-6701: Fixed the doc in [r1788399|https://svn.apache.org/r1788399]. > Clarify documentation for JCR Content Loader > (https://sling.apache.org/documentation/bundles/content-loading-jcr-contentloader.html) > > > Key: SLING-6701 > URL: https://issues.apache.org/jira/browse/SLING-6701 > Project: Sling > Issue Type: Improvement > Components: JCR, Site >Reporter: Konrad Windszus >Assignee: Konrad Windszus > Attachments: content-loading-jcr-contentloader-SLING-6701-v01.html, > SLING-6701-v01.patch > > > Compare with http://www.mail-archive.com/dev@sling.apache.org/msg66056.html. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Closed] (SLING-6513) Set ACCEPT_RANGES_THRESHOLD in StreamRendererServlet to 100KB
[ https://issues.apache.org/jira/browse/SLING-6513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-6513. --- > Set ACCEPT_RANGES_THRESHOLD in StreamRendererServlet to 100KB > - > > Key: SLING-6513 > URL: https://issues.apache.org/jira/browse/SLING-6513 > Project: Sling > Issue Type: Bug > Components: Servlets >Affects Versions: Servlets Get 2.1.20 >Reporter: Karl Pauls >Assignee: Karl Pauls > Fix For: Servlets Get 2.1.22 > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (SLING-6683) Replace commons.json usage in org.apache.sling.servlets.get
[ https://issues.apache.org/jira/browse/SLING-6683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-6683: Fix Version/s: (was: Servlets Get 2.1.22) Servlets Get 2.1.24 > Replace commons.json usage in org.apache.sling.servlets.get > --- > > Key: SLING-6683 > URL: https://issues.apache.org/jira/browse/SLING-6683 > Project: Sling > Issue Type: Sub-task > Components: Servlets >Affects Versions: Servlets Get 2.1.20 >Reporter: Karl Pauls >Assignee: Karl Pauls > Labels: patch-available > Fix For: Servlets Get 2.1.24 > > Attachments: SLING-6683.patch > > > We need to replace the usage of commons.json but this one does heavy rely on > some of the helper classes. Its going to be tricky to make sure it still > works as intended. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (SLING-6704) Migrate to R6 annotations, clean up dependencies
Carsten Ziegeler created SLING-6704: --- Summary: Migrate to R6 annotations, clean up dependencies Key: SLING-6704 URL: https://issues.apache.org/jira/browse/SLING-6704 Project: Sling Issue Type: Improvement Components: Servlets Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: Servlets Get 2.1.24 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (SLING-6701) Clarify documentation for JCR Content Loader (https://sling.apache.org/documentation/bundles/content-loading-jcr-contentloader.html)
[
https://issues.apache.org/jira/browse/SLING-6701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940082#comment-15940082
]
Konrad Windszus commented on SLING-6701:
Thanks for the feedback, [~sseif...@pro-vision.de].
Regarding
bq. "Otherwise, it loads the content given in SLING-INF/content/home into root
node /."
This seems to be just plain wrong. The target path is either the default (i.e.
root) or the given {{path}} no matter whether it exists or not. The according
code can be found in
https://github.com/apache/sling/blob/4df9ab2d6592422889c71fa13afd453a10a5a626/bundles/jcr/contentloader/src/main/java/org/apache/sling/jcr/contentloader/internal/BundleContentLoader.java#L587.
Missing intermediate nodes are created with type {{sling:Folder}}. So I am
gonna remove that sentence as well.
> Clarify documentation for JCR Content Loader
> (https://sling.apache.org/documentation/bundles/content-loading-jcr-contentloader.html)
>
>
> Key: SLING-6701
> URL: https://issues.apache.org/jira/browse/SLING-6701
> Project: Sling
> Issue Type: Improvement
> Components: JCR, Site
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
> Attachments: content-loading-jcr-contentloader-SLING-6701-v01.html,
> SLING-6701-v01.patch
>
>
> Compare with http://www.mail-archive.com/dev@sling.apache.org/msg66056.html.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Closed] (SLING-6671) Context-Aware Config: Lower log level for unexpected config paths
[
https://issues.apache.org/jira/browse/SLING-6671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Seifert closed SLING-6671.
-
> Context-Aware Config: Lower log level for unexpected config paths
> -
>
> Key: SLING-6671
> URL: https://issues.apache.org/jira/browse/SLING-6671
> Project: Sling
> Issue Type: Improvement
> Components: Extensions
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
>Priority: Minor
> Labels: contextaware-config
> Fix For: Context-Aware Configuration Impl 1.3.0
>
>
> the {{DefaultConfigurationResourceResolvingStrategy}} logs warnings if it
> detects config paths outside it's expectations (e.g. /conf).
> this should be lowered to "debug" as other strategies may support it and both
> should co-exist without warnings.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Closed] (SLING-6674) Context-Aware Config: Separate exception when persist failes due to missing access rights
[ https://issues.apache.org/jira/browse/SLING-6674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert closed SLING-6674. - > Context-Aware Config: Separate exception when persist failes due to missing > access rights > - > > Key: SLING-6674 > URL: https://issues.apache.org/jira/browse/SLING-6674 > Project: Sling > Issue Type: Improvement > Components: Extensions >Reporter: Stefan Seifert >Assignee: Stefan Seifert > Labels: contextaware-config > Fix For: Context-Aware Configuration SPI 1.3.0, Context-Aware > Configuration Impl 1.3.0 > > > when persisting configuration failes due to missing access rights (e.g. > read-only access) the implementation should throw a dedicated exception to be > handled separately in upper layers (e.g. configuration editor GUI). -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Closed] (SLING-6669) Context-Aware Config: More control about resource paths in Configuration Persistence Strategy
[
https://issues.apache.org/jira/browse/SLING-6669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Seifert closed SLING-6669.
-
> Context-Aware Config: More control about resource paths in Configuration
> Persistence Strategy
> -
>
> Key: SLING-6669
> URL: https://issues.apache.org/jira/browse/SLING-6669
> Project: Sling
> Issue Type: New Feature
> Components: Extensions
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
> Labels: contextaware-config
> Fix For: Context-Aware Configuration SPI 1.3.0, Context-Aware
> Configuration Impl 1.3.0
>
>
> currently the SPI interface ConfigurationPersistenceStrategy offers two
> methods (getResource, getResourcePath) to rewrite resource paths when
> persisting resources - e.g. insert an additional {{jcr:content}} hierarchy.
> but this is a bit limited because it is not known if the resource paths
> belongs to a singleton resource or resource collection item, or just a config
> name. and it is not possible to change the parent resource of a configuration
> collection.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Closed] (SLING-6442) All context aware configuration multiplexers should be exposed outside of the bundle
[ https://issues.apache.org/jira/browse/SLING-6442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert closed SLING-6442. - > All context aware configuration multiplexers should be exposed outside of the > bundle > > > Key: SLING-6442 > URL: https://issues.apache.org/jira/browse/SLING-6442 > Project: Sling > Issue Type: Improvement > Components: Extensions >Affects Versions: Context-Aware Configuration Impl 1.2.0 >Reporter: Nicolas Peltier >Assignee: Stefan Seifert > Fix For: Context-Aware Configuration Impl 1.3.0 > > > While caconfig's "Service Provider Interfaces (SPI) [...] allows you to > overlay, enhance or replace the default implementation and adapt it to your > needs", custom implementations (outside of caconfig bundles) need to access > the multiplexers' API to reuse other pieces of the framework. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Closed] (SLING-6670) Support CAConfig Impl 1.3.0
[ https://issues.apache.org/jira/browse/SLING-6670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert closed SLING-6670. - > Support CAConfig Impl 1.3.0 > --- > > Key: SLING-6670 > URL: https://issues.apache.org/jira/browse/SLING-6670 > Project: Sling > Issue Type: Improvement >Affects Versions: Context-Aware Configuration Mock Plugin 1.0.0 >Reporter: Stefan Seifert >Assignee: Stefan Seifert > Fix For: Context-Aware Configuration Mock Plugin 1.1.0 > > > some classes in the CAConfig 1.3.0 implementation have moved - we need to > update the mock plugin to support this changes in unit tests. > as before the mock plugin should support all CAConfig Impl version since 1.0. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[RESULT] [VOTE] Release Apache Sling CAConfig SPI 1.3.0, CAConfig Impl 1.3.0, CAConfig Mock Plugin 1.1.0
Hi, The vote has passed with the following result : +1 (binding): Stefan Seifert, Carsten Ziegeler, Karl Pauls I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. stefan
[jira] [Commented] (SLING-6702) Make MetricsService accessible as easily as a Logger
[
https://issues.apache.org/jira/browse/SLING-6702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15939948#comment-15939948
]
Bertrand Delacretaz commented on SLING-6702:
bq. ...The Metrics instance created from MetricService are usable (in the sense
no exception would be thrown) even if backing Sling MetricService gets
recycled. ...
Is this degraded state logged? I haven't tried so far.
-Bertrand
> Make MetricsService accessible as easily as a Logger
>
>
> Key: SLING-6702
> URL: https://issues.apache.org/jira/browse/SLING-6702
> Project: Sling
> Issue Type: Improvement
> Components: Extensions
>Affects Versions: Commons Metrics 1.2.0
>Reporter: Bertrand Delacretaz
>Assignee: Bertrand Delacretaz
>Priority: Minor
> Fix For: Commons Metrics 1.2.2
>
>
> Metrics are useful in all classes, not only OSGi components, so getting the
> {{MetricsService}} should be as useful as getting a {{Logger}} for example.
> I'll add a public {{MetricsServiceFactory}} class to our metrics module,
> usable like
> {code}
> MetricsService ms =
> MetricsServiceFactory.getMetricsService(this.getClass());
> {code}
> There's already a private {{MetricsServiceFactory}} class in that module,
> I'll rename that to {{InternalMetricsServiceFactory}} to avoid confusion.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
