[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #152: SLING-11739 Index definition extraction from content packages is miss…
sonarcloud[bot] commented on PR #152: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/152#issuecomment-1360893691 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-feature-cpconverter=152) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=152=new_coverage=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=152=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=152=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=152=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-cpconverter] abhishekgarg18 commented on pull request #152: SLING-11739 Index definition extraction from content packages is miss…
abhishekgarg18 commented on PR #152: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/152#issuecomment-1360892769 @rombert Instead of changing repositoryPath in IndexDefinitionsEntryHandler, I have changed IndexDefinitionsJsonWriter, as That was not giving all the binaries files for the following structure. ``` /oak:index/lucene-custom/analyzers/default/filters/Stop/ stopwords.txt stopwords_2.txt ``` added the test case for the same also. Please review it again. cc : @kwin @niekraaijmakers @DominikSuess -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-ide-tooling] kwin merged pull request #20: releng: update to Tycho 3.0.1
kwin merged PR #20: URL: https://github.com/apache/sling-ide-tooling/pull/20 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: RepoInit: Intended behaviour in case of failures and backwards-compatibility
Fair enough, apologies for not expressing myself here clearly. I *suggested* something, this was neither a decision nor meant as a dismission of something. However, I've seen too many cases where all potential cases are considered first, leading then to a too complicated solution that in the end is no one using - and that confuses users. Regards Carsten Am 20.12.2022 um 20:31 schrieb Eric Norman: My reply was not intended as a personal accusation. I apologize if you took it that way. I was simply expecting a reasoned discussion based on facts rather than a dismissive reply that declared how it will be. Regards, Eric On Tue, Dec 20, 2022, 3:53 AM Konrad Windszus wrote: Hi Eric, Actually your concern/use case lead to a modified proposal (ensure nodes) to allow for future other instructions (like update nodes). But I agree with Carsten here (and I am not Adobe): personal accusations don’t belong here and your are offending others with comments like these. Konrad On 19. Dec 2022, at 20:02, Eric Norman wrote: It seems my opinions don't matter here as the Adobe voices have overwhelmed the discussion. -- Carsten Ziegeler Adobe cziege...@apache.org
Re: RepoInit: Intended behaviour in case of failures and backwards-compatibility
My reply was not intended as a personal accusation. I apologize if you took it that way. I was simply expecting a reasoned discussion based on facts rather than a dismissive reply that declared how it will be. Regards, Eric On Tue, Dec 20, 2022, 3:53 AM Konrad Windszus wrote: > Hi Eric, > Actually your concern/use case lead to a modified proposal (ensure nodes) > to allow for future other instructions (like update nodes). > But I agree with Carsten here (and I am not Adobe): personal accusations > don’t belong here and your are offending others with comments like these. > > Konrad > > > On 19. Dec 2022, at 20:02, Eric Norman wrote: > > > > It seems my opinions don't matter > > here as the Adobe voices have overwhelmed the discussion. > >
[GitHub] [sling-org-apache-sling-repoinit-parser] sonarcloud[bot] commented on pull request #28: SLING-10281 add "ensure principal ACL" with stricter semantics
sonarcloud[bot] commented on PR #28: URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/28#issuecomment-1359996837 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-repoinit-parser=28) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser=28=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser=28=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser=28=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser=28=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser=28=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser=28=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-repoinit-parser=28=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-repoinit-parser=28=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-repoinit-parser=28=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser=28=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser=28=false=CODE_SMELL) [3 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser=28=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-repoinit-parser=28=new_coverage=list) [81.2% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-repoinit-parser=28=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-repoinit-parser=28=new_duplicated_lines_density=list) [28.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-repoinit-parser=28=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-repoinit-parser] kwin commented on a diff in pull request #28: SLING-10281 add "ensure principal ACL" with stricter semantics
kwin commented on code in PR #28:
URL:
https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/28#discussion_r1053531692
##
src/main/java/org/apache/sling/repoinit/parser/operations/SetAclPrincipalBased.java:
##
@@ -27,7 +27,9 @@
/** Set ACL statement that groups a set of AclLines
* that all refer to the same set of principals.
+ * @deprecated Use {@link EnsureAclPrincipalBased} based with stricter
semantics
*/
+@Deprecated
@ProviderType
public class SetAclPrincipalBased extends AclGroupBase {
Review Comment:
Should we emit a WARN log message when the deprecated constructor is called
to encourage users to migrate to the new statement?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (SLING-11741) Provide alternative terminology for inequitable terms
[ https://issues.apache.org/jira/browse/SLING-11741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cioriia Cristian updated SLING-11741: - Description: The Apache Sling Login Admin Whitelist has occurrences of "whitelist" and "blacklist" e.g. "whitelist.bypass", "whitelist.bundles.regexp" which is considered inequitable terminology and some customers are prevented to use these terms by their git commit policies. Therefore, some more acceptable equivalents should be provided for these terms. The proposal is to provide the "allowedlist.bypass" and "allowedlist.bundles.regexp" alternatives for them was: The Apache Sling Login Admin Whitelist has occurrences of "whitelist" and "blacklist" e.g. "resource.resolver.vanitypath.blacklist", "resource.resolver.vanitypath.whitelist" which is considered inequitable terminology and some customers are prevented to use these terms by their git commit policies. Therefore, some more acceptable equivalents should be provided for these terms. The proposal is to provide the "resource.resolver.vanitypath.blockedlist" and "resource.resolver.vanitypath.allowedlist" alternatives for them > Provide alternative terminology for inequitable terms > - > > Key: SLING-11741 > URL: https://issues.apache.org/jira/browse/SLING-11741 > Project: Sling > Issue Type: Improvement >Reporter: Cioriia Cristian >Priority: Major > > The Apache Sling Login Admin Whitelist has occurrences of "whitelist" and > "blacklist" e.g. "whitelist.bypass", "whitelist.bundles.regexp" which is > considered inequitable terminology and some customers are prevented to use > these terms by their git commit policies. > Therefore, some more acceptable equivalents should be provided for these > terms. The proposal is to provide the "allowedlist.bypass" and > "allowedlist.bundles.regexp" alternatives for them -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-11741) Provide alternative terminology for inequitable terms
Cioriia Cristian created SLING-11741: Summary: Provide alternative terminology for inequitable terms Key: SLING-11741 URL: https://issues.apache.org/jira/browse/SLING-11741 Project: Sling Issue Type: Improvement Reporter: Cioriia Cristian The Apache Sling Login Admin Whitelist has occurrences of "whitelist" and "blacklist" e.g. "resource.resolver.vanitypath.blacklist", "resource.resolver.vanitypath.whitelist" which is considered inequitable terminology and some customers are prevented to use these terms by their git commit policies. Therefore, some more acceptable equivalents should be provided for these terms. The proposal is to provide the "resource.resolver.vanitypath.blockedlist" and "resource.resolver.vanitypath.allowedlist" alternatives for them -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #152: SLING-11739 Index definition extraction from content packages is miss…
sonarcloud[bot] commented on PR #152: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/152#issuecomment-1359382375 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-feature-cpconverter=152) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=152=new_coverage=list) [80.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=152=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=152=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=152=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-repoinit-parser] sonarcloud[bot] commented on pull request #27: SLING-11736 Add "ensure nodes" as replacement of "create path" with
sonarcloud[bot] commented on PR #27: URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/27#issuecomment-1359372716 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-repoinit-parser=27) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser=27=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser=27=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser=27=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser=27=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser=27=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser=27=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-repoinit-parser=27=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-repoinit-parser=27=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-repoinit-parser=27=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser=27=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser=27=false=CODE_SMELL) [6 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser=27=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-repoinit-parser=27=new_coverage=list) [90.6% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-repoinit-parser=27=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-repoinit-parser=27=new_duplicated_lines_density=list) [66.1% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-repoinit-parser=27=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-repoinit-parser] sonarcloud[bot] commented on pull request #27: SLING-11736 Add "ensure nodes" as replacement of "create path" with
sonarcloud[bot] commented on PR #27: URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/27#issuecomment-1359344995 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-repoinit-parser=27) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser=27=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser=27=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser=27=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser=27=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser=27=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser=27=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-repoinit-parser=27=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-repoinit-parser=27=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-repoinit-parser=27=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser=27=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser=27=false=CODE_SMELL) [6 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser=27=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-repoinit-parser=27=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-repoinit-parser=27=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-repoinit-parser=27=new_duplicated_lines_density=list) [66.1% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-repoinit-parser=27=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-cpconverter] kwin commented on a diff in pull request #152: SLING-11739 Index definition extraction from content packages is miss…
kwin commented on code in PR #152:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/152#discussion_r1053268611
##
src/main/java/org/apache/sling/feature/cpconverter/handlers/IndexDefinitionsEntryHandler.java:
##
@@ -126,8 +126,9 @@ public void handle(@NotNull String path, @NotNull Archive
archive, @NotNull Entr
} else {
// binary file, should we attach?
-if (
archive.getMetaInf().getFilter().contains(repositoryPath)) {
-
indexManager.getIndexes().registerBinary(repositoryPath, is);
+String binaryParentPath =
repositoryPath.substring(0,repositoryPath.lastIndexOf("/")) ;
+if (
archive.getMetaInf().getFilter().contains(binaryParentPath)) {
+
indexManager.getIndexes().registerBinary(binaryParentPath, is);
Review Comment:
The javadoc says explicitly:
> repositoryPath The JCR repository path where the binary was found
This is for me the path to the binary node (nt:file)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-cpconverter] kwin commented on a diff in pull request #152: SLING-11739 Index definition extraction from content packages is miss…
kwin commented on code in PR #152:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/152#discussion_r1053265209
##
src/main/java/org/apache/sling/feature/cpconverter/handlers/IndexDefinitionsEntryHandler.java:
##
@@ -126,8 +126,9 @@ public void handle(@NotNull String path, @NotNull Archive
archive, @NotNull Entr
} else {
// binary file, should we attach?
-if (
archive.getMetaInf().getFilter().contains(repositoryPath)) {
-
indexManager.getIndexes().registerBinary(repositoryPath, is);
+String binaryParentPath =
repositoryPath.substring(0,repositoryPath.lastIndexOf("/")) ;
Review Comment:
I don't think this is how FileVault works, you really need to check if the
node path given through `repositoryPath` is contained in the filter (otherwise
it won't be imported). Just think about more complicated use cases like
excludes below a specific filter root.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-cpconverter] kwin commented on a diff in pull request #152: SLING-11739 Index definition extraction from content packages is miss…
kwin commented on code in PR #152:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/152#discussion_r1053266464
##
src/main/java/org/apache/sling/feature/cpconverter/handlers/IndexDefinitionsEntryHandler.java:
##
@@ -126,8 +126,9 @@ public void handle(@NotNull String path, @NotNull Archive
archive, @NotNull Entr
} else {
// binary file, should we attach?
-if (
archive.getMetaInf().getFilter().contains(repositoryPath)) {
-
indexManager.getIndexes().registerBinary(repositoryPath, is);
+String binaryParentPath =
repositoryPath.substring(0,repositoryPath.lastIndexOf("/")) ;
+if (
archive.getMetaInf().getFilter().contains(binaryParentPath)) {
+
indexManager.getIndexes().registerBinary(binaryParentPath, is);
Review Comment:
for me it would make more sense to find the parent within the
`registerBinary` method.
##
src/main/java/org/apache/sling/feature/cpconverter/handlers/IndexDefinitionsEntryHandler.java:
##
@@ -126,8 +126,9 @@ public void handle(@NotNull String path, @NotNull Archive
archive, @NotNull Entr
} else {
// binary file, should we attach?
-if (
archive.getMetaInf().getFilter().contains(repositoryPath)) {
-
indexManager.getIndexes().registerBinary(repositoryPath, is);
+String binaryParentPath =
repositoryPath.substring(0,repositoryPath.lastIndexOf("/")) ;
Review Comment:
I don't think this is how FileVault works, you really need to check if the
node path given through repository path is contained in the filter (otherwise
it won't be imported). Just think about more complicated use cases like
excludes below a specific filter root.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: RepoInit: Intended behaviour in case of failures and backwards-compatibility
Hi Eric, Actually your concern/use case lead to a modified proposal (ensure nodes) to allow for future other instructions (like update nodes). But I agree with Carsten here (and I am not Adobe): personal accusations don’t belong here and your are offending others with comments like these. Konrad > On 19. Dec 2022, at 20:02, Eric Norman wrote: > > It seems my opinions don't matter > here as the Adobe voices have overwhelmed the discussion.
Re: RepoInit: Intended behaviour in case of failures and backwards-compatibility
Hi, Eric Norman wrote: > ...I apologise for trying to be proactive. It seems my opinions don't matter > here... They do matter, and I'm sorry if whatever I wrote made you feel otherwise. The use case that you mentioned does not fit the way I use Sling: > ...In other words, if someone else already created a path (with the > wrong types) that you are not expecting to be there, then failing right > away seems like a reasonable solution... So I considered that having a variant of "set node" that fails if paths already exist does not seem useful *at this point*. And it would actually get in the way for my use cases - but I could of course refrain from using it. Not implementing that variant now does not prevent someone from implementing it later. I don't think it's useful myself, and I might have more (unwanted) weight in these discussions as I worked a lot on repoinit in its beginnings. But don't let that stop you. -Bertrand
[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #152: SLING-11739 Index definition extraction from content packages is miss…
sonarcloud[bot] commented on PR #152: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/152#issuecomment-1359144041 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-feature-cpconverter=152) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=152=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=152=new_coverage=list) [80.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=152=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=152=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=152=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-cpconverter] rombert commented on pull request #152: SLING-11739 Index definition extraction from content packages is miss…
rombert commented on PR #152: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/152#issuecomment-1359125038 @abhishekgarg18 - can you please merge the laster master branch and push? CI should be ok now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
