[GitHub] [sling-org-apache-sling-dynamic-include] YegorKozlov opened a new pull request #15: use Set instead of a List to test ignoreUrlParams

2020-03-24 Thread GitBox
YegorKozlov opened a new pull request #15: use Set instead of a List to test  
ignoreUrlParams
URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/15
 
 
   In our setup we have a list of ignored GET parameters 
(_include-filter.config.ignoreUrlParams_) which grew with time to a hundred or 
so elements .
   
   _org.apache.sling.dynamicinclude.Configuration_ loads these into a 
_java.util.List_ which is further  checked from IncludeTagFilter via 
_List#contains_
   
   Calling _List#contains_ in a loop is kind of a smell.  I believe 
_java.util.Set_ will be a more appropriate containter with fixed O(1) cost of 
_contains()_. 
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Created] (SLING-9247) Improve Performance Of Testing Ignored GET Parameters

2020-03-24 Thread Yegor Kozlov (Jira)
Yegor Kozlov created SLING-9247:
---

 Summary: Improve Performance Of Testing Ignored GET Parameters
 Key: SLING-9247
 URL: https://issues.apache.org/jira/browse/SLING-9247
 Project: Sling
  Issue Type: Improvement
  Components: Extensions
Affects Versions: Dynamic Include 3.1.6
Reporter: Yegor Kozlov
 Fix For: Dynamic Include 3.2.0


This is a follow-up on SLING-9045

_org.apache.sling.dynamicinclude.Configuration_ loads the list of ignored GET 
parameters into a _java.util.List_ which is further checked from 
_IncludeTagFilter_ via _List#contains_

Calling _List#contains_ in a loop is kind of a smell. I believe _java.util.Set_ 
will be a more appropriate container with fixed O(1) cost of _contains()_.

 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (SLING-9247) Improve Performance Of Testing Ignored GET Parameters

2020-03-24 Thread Yegor Kozlov (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yegor Kozlov updated SLING-9247:

External issue URL: 
https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/15

> Improve Performance Of Testing Ignored GET Parameters
> -
>
> Key: SLING-9247
> URL: https://issues.apache.org/jira/browse/SLING-9247
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: Dynamic Include 3.1.6
>Reporter: Yegor Kozlov
>Priority: Minor
> Fix For: Dynamic Include 3.2.0
>
>
> This is a follow-up on SLING-9045
> _org.apache.sling.dynamicinclude.Configuration_ loads the list of ignored GET 
> parameters into a _java.util.List_ which is further checked from 
> _IncludeTagFilter_ via _List#contains_
> Calling _List#contains_ in a loop is kind of a smell. I believe 
> _java.util.Set_ will be a more appropriate container with fixed O(1) cost of 
> _contains()_.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (SLING-9247) Improve Performance Of Testing Ignored GET Parameters

2020-03-24 Thread Yegor Kozlov (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yegor Kozlov updated SLING-9247:

External issue URL:   (was: 
https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/15)

> Improve Performance Of Testing Ignored GET Parameters
> -
>
> Key: SLING-9247
> URL: https://issues.apache.org/jira/browse/SLING-9247
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: Dynamic Include 3.1.6
>Reporter: Yegor Kozlov
>Priority: Minor
> Fix For: Dynamic Include 3.2.0
>
>
> This is a follow-up on SLING-9045
> _org.apache.sling.dynamicinclude.Configuration_ loads the list of ignored GET 
> parameters into a _java.util.List_ which is further checked from 
> _IncludeTagFilter_ via _List#contains_
> Calling _List#contains_ in a loop is kind of a smell. I believe 
> _java.util.Set_ will be a more appropriate container with fixed O(1) cost of 
> _contains()_.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (SLING-9248) Feature model variables are not resolved for array elements

2020-03-24 Thread A. J. David Bosschaert (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

A. J. David Bosschaert updated SLING-9248:
--
Description: 
Feature model variables are not resolved for array elements.

Let's say the following variable is defined:
{code}
"variables" : {
  "foo": "b"
}
{code}
Then this variable should be substituted in configuration values that are an 
array:
{code}
 "configkey" : ["a": "${foo}"]
{code}

  was:
Feature model variables are not resolved for array elements.

Let's say the following variable is defined:
{code}
"variables" : {
  "foo": true
}
{code}
Then this variable should be substituted in configuration values that are an 
array:
{code}
 "configkey" : ["b": "${foo}"]
{code}


> Feature model variables are not resolved for array elements
> ---
>
> Key: SLING-9248
> URL: https://issues.apache.org/jira/browse/SLING-9248
> Project: Sling
>  Issue Type: Bug
>  Components: Feature Model
>Affects Versions: Feature Model 1.1.4
>Reporter: A. J. David Bosschaert
>Priority: Major
>
> Feature model variables are not resolved for array elements.
> Let's say the following variable is defined:
> {code}
> "variables" : {
>   "foo": "b"
> }
> {code}
> Then this variable should be substituted in configuration values that are an 
> array:
> {code}
>  "configkey" : ["a": "${foo}"]
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (SLING-9248) Feature model variables are not resolved for array elements

2020-03-24 Thread A. J. David Bosschaert (Jira)
A. J. David Bosschaert created SLING-9248:
-

 Summary: Feature model variables are not resolved for array 
elements
 Key: SLING-9248
 URL: https://issues.apache.org/jira/browse/SLING-9248
 Project: Sling
  Issue Type: Bug
  Components: Feature Model
Affects Versions: Feature Model 1.1.4
Reporter: A. J. David Bosschaert


Feature model variables are not resolved for array elements.

Let's say the following variable is defined:
{code}
"variables" : {
  "foo": true
}
{code}
Then this variable should be substituted in configuration values that are an 
array:
{code}
 "configkey" : ["b": "${foo}"]
{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [sling-org-apache-sling-dynamic-include] rombert commented on issue #15: use Set instead of a List to test ignoreUrlParams

2020-03-24 Thread GitBox
rombert commented on issue #15: use Set instead of a List to test  
ignoreUrlParams
URL: 
https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/15#issuecomment-603126532
 
 
   Thanks for the PR @YegorKozlov . Can you please amend the commit message to 
reference the Jira issue you created? Please force-push so we get only one 
commit.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [sling-org-apache-sling-dynamic-include] sonarcloud[bot] commented on issue #15: use Set instead of a List to test ignoreUrlParams

2020-03-24 Thread GitBox
sonarcloud[bot] commented on issue #15: use Set instead of a List to test  
ignoreUrlParams
URL: 
https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/15#issuecomment-603126478
 
 
   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=15&resolved=false&types=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=15&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=15&resolved=false&types=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=15&resolved=false&types=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=15&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=15&resolved=false&types=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=15&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=15&resolved=false&types=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=15&resolved=false&types=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=15&resolved=false&types=CODE_SMELL)
 [1 Code 
Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=15&resolved=false&types=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=15&metric=new_coverage&view=list)
 [100.0% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=15&metric=new_coverage&view=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=15&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=15&metric=new_duplicated_lines_density&view=list)
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[RESULT] [VOTE] Release Apache Sling Installer Core 3.11.0

2020-03-24 Thread Robert Munteanu
Hi,

The vote has passed with the following result:

+1 (binding): Dan Klco, Robert Munteanu, Carsten Ziegeler, Konrad
Windszus
+1 (non-binding): none

I will copy this release to the Sling dist directory and
promote the artifacts to the central Maven repository.

Regards,
Robert Munteanu



[jira] [Closed] (SLING-9184) BundleInstallUpgradeDowngradeTest fails

2020-03-24 Thread Robert Munteanu (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu closed SLING-9184.
--

> BundleInstallUpgradeDowngradeTest fails
> ---
>
> Key: SLING-9184
> URL: https://issues.apache.org/jira/browse/SLING-9184
> Project: Sling
>  Issue Type: Bug
>  Components: Installer
>Affects Versions: Installer Core 3.10.2
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Minor
> Fix For: Installer Core 3.11.0
>
>
> The BundleInstallUpgradeDowngradeTest  IT test is failing (see below). The 
> test is passing with 3.9.0 but fails with 3.10.2 (it also fails with 
> 3.10.3-SNAPSHOT):
> 15:04:34,966 [ERROR] Failures:
> 15:04:34,968 [ERROR]   
> BundleInstallUpgradeDowngradeTest.testReplaceBundleWithSameUrlButDifferentSymbolicName:232->OsgiInstallerTestBase.waitForBundleEvents:555
>  osgi-installer-testbundle must be installed : Expected events=[
> BundleEvent osgi-installer-testbundle, version=1.0.0, state=1
> BundleEvent osgi-installer-testbundle, version=1.0.0, state=2
> ]
> received events=[
> ]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (SLING-9167) Installer core embeds too many config admin classes

2020-03-24 Thread Robert Munteanu (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu closed SLING-9167.
--

> Installer core embeds too many config admin classes
> ---
>
> Key: SLING-9167
> URL: https://issues.apache.org/jira/browse/SLING-9167
> Project: Sling
>  Issue Type: Bug
>  Components: Installer
>Affects Versions: Installer Core 3.10.0, Installer Core 3.10.2
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Installer Core 3.11.0
>
>
> It seems complete packages from Apache Felix CM are now included, previously 
> these were only single classes:
>  
> org.apache.felix.configadmin;inline="org/apache/felix/cm/file/ConfigurationHandler.*",
> vs
> org/apache/felix/cm/NotCachablePersistenceManager.class
> org/apache/felix/cm/PersistenceManager.class
> org/apache/felix/cm/file/ConfigurationHandler.class
> org/apache/felix/cm/file/FilePersistenceManager$1.class
> org/apache/felix/cm/file/FilePersistenceManager$2.class
> org/apache/felix/cm/file/FilePersistenceManager$3.class
> org/apache/felix/cm/file/FilePersistenceManager$4.class
> org/apache/felix/cm/file/FilePersistenceManager$DictionaryEnumeration$1.class
> org/apache/felix/cm/file/FilePersistenceManager$DictionaryEnumeration.class
> org/apache/felix/cm/file/FilePersistenceManager.class
> org/apache/felix/cm/file/package-info.class
> org/apache/felix/cm/package-info.class



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (SLING-9166) Installer core must not depend on org.osgi.service.event

2020-03-24 Thread Robert Munteanu (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu closed SLING-9166.
--

> Installer core must not depend on  org.osgi.service.event
> -
>
> Key: SLING-9166
> URL: https://issues.apache.org/jira/browse/SLING-9166
> Project: Sling
>  Issue Type: Bug
>  Components: Installer
>Affects Versions: Installer Core 3.10.0, Installer Core 3.10.2
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Blocker
> Fix For: Installer Core 3.11.0
>
>
> The latest installer core release depends on   org.osgi.service.event 
> (without any version range). Eventing must not be required for the installer 
> to work
> This is introduced by the Conditional-Package statement for 
> org.apache.sling.commons.osgi
> Previously only the required classes where included:
> org.apache.sling.commons.osgi;inline="org/apache/sling/commons/osgi/ManifestHeader*.*|org/apache/sling/commons/osgi/PropertiesUtil.*|org/apache/sling/commons/osgi/SortingServiceTracker.*"
> Now the whole package org.apache.sling.commons.osgi ins included - which is 
> wrong



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (SLING-9172) Allow Sling Installer to install and handle multiple versions of bundles instead of updating

2020-03-24 Thread Robert Munteanu (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu closed SLING-9172.
--

> Allow Sling Installer to install and handle multiple versions of bundles 
> instead of updating
> 
>
> Key: SLING-9172
> URL: https://issues.apache.org/jira/browse/SLING-9172
> Project: Sling
>  Issue Type: Improvement
>  Components: Installer
>Affects Versions: Installer Core 3.10.2
>Reporter: Dominik Süß
>Assignee: Carsten Ziegeler
>Priority: Major
>  Labels: Sling-12-ReleaseNotes
> Fix For: Installer Core 3.11.0
>
>  Time Spent: 4.5h
>  Remaining Estimate: 0h
>
> Sling Installer currently always updates bundles when different versions of 
> bundles get installed. Since Apache Felix does support multiple versions of 
> bundles to exist in parallel it should be possible to change the behavior 
> with via property to install and uninstall multiple versions in parallel 
> instead of updating them.
> To achieve this two changes are required:
> a) DefaultTransformer should change the EntityID of bundles to include the 
> version to make sure the state handling of Installer handles each version as 
> own entity
> b) BundleTaskCreator must be adjusted to create install task over update task 
> as the detection currently checks for the existence of BSN



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (SLING-9169) Installer core should shade embedded classes

2020-03-24 Thread Robert Munteanu (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu closed SLING-9169.
--

> Installer core should shade embedded classes
> 
>
> Key: SLING-9169
> URL: https://issues.apache.org/jira/browse/SLING-9169
> Project: Sling
>  Issue Type: Improvement
>  Components: Installer
>Affects Versions: Installer Core 3.10.2
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Installer Core 3.11.0
>
>
> Installer core embeds several classes from other bundles without shading them 
> (moving to a different package). When the installer is run in a flat class 
> path this might cause collisions and unwanted effects.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (SLING-9168) Installer core should not imbed javax / johnzon

2020-03-24 Thread Robert Munteanu (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu closed SLING-9168.
--

> Installer core should not imbed javax / johnzon
> ---
>
> Key: SLING-9168
> URL: https://issues.apache.org/jira/browse/SLING-9168
> Project: Sling
>  Issue Type: Improvement
>  Components: Installer
>Affects Versions: Installer Core 3.10.0, Installer Core 3.10.2
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Installer Core 3.11.0
>
>
> While it is good that the installer has minimum dependencies, embedding 
> complete bundles like javax.json / johnzon will probably call for trouble 
> over time.
> Updating those libraries will then also requiring to update the installer.
> It is good to embed single classes to avoid copying code, but not complete 
> bundles.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Reopened] (SLING-9219) Invalid Comments in JSON Configuration

2020-03-24 Thread Carsten Ziegeler (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler reopened SLING-9219:
-

JCR Installer does not compile anymore : 
/src/main/java/org/apache/sling/installer/provider/jcr/impl/JcrInstaller.java:[71,8]
 org.apache.sling.installer.provider.jcr.impl.JcrInstaller is not abstract and 
does not override abstract method 
handleUpdate(java.lang.String,java.lang.String,java.lang.String,java.util.Dictionary,java.util.Map)
 in org.apache.sling.installer.api.UpdateHandler

> Invalid Comments in JSON Configuration
> --
>
> Key: SLING-9219
> URL: https://issues.apache.org/jira/browse/SLING-9219
> Project: Sling
>  Issue Type: Bug
>  Components: Installer
>Affects Versions: File Installer 1.2.0, JCR Installer 3.2.0
>Reporter: Dan Klco
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: JCR Installer 3.2.2, File Installer 1.2.2
>
>
> With the latest version of JCR Installer, I'm seeing an exception when saving 
> OSGi Configurations from the console:
>  
> {{18.03.2020 19:57:44.565 *WARN* [JcrInstaller.2] 
> org.apache.sling.installer.core.impl.OsgiInstallerImpl Cannot create 
> InternalResource (resource will be ignored):InstallableResource, 
> priority=200, 
> id=/apps/sling/install/org.apache.sling.cms.core.internal.repository.RevisionCleanupScheduler.cfg.json}}{{javax.json.stream.JsonParsingException:
>  Unexpected character '#' (Codepoint: 35) on [lineNumber=2, columnNumber=77, 
> streamOffset=76]. Reason is [[Expected structural character or digit or 't' 
> or 'n' or 'f' or '-']]}}{{at 
> org.apache.johnzon.core.JsonStreamParserImpl.uexc(JsonStreamParserImpl.java:966)}}{{at
>  
> org.apache.johnzon.core.JsonStreamParserImpl.uexc(JsonStreamParserImpl.java:972)}}{{at
>  
> org.apache.johnzon.core.JsonStreamParserImpl.defaultHandling(JsonStreamParserImpl.java:422)}}{{at
>  
> org.apache.johnzon.core.JsonStreamParserImpl.next(JsonStreamParserImpl.java:414)}}{{at
>  
> org.apache.johnzon.core.JsonStreamParserImpl.next(JsonStreamParserImpl.java:353)}}{{at
>  
> org.apache.johnzon.core.JsonReaderImpl.parseObject(JsonReaderImpl.java:131)}}{{at
>  
> org.apache.johnzon.core.JsonReaderImpl.readValue(JsonReaderImpl.java:56)}}{{at
>  org.apache.johnzon.core.JsonReaderImpl.read(JsonReaderImpl.java:42)}}{{at 
> org.apache.felix.configurator.impl.json.JSONUtil.parseJSON(JSONUtil.java:331) 
> [org.apache.sling.installer.core:3.10.2]}}{{at 
> org.apache.felix.configurator.impl.json.JSONUtil.readJSON(JSONUtil.java:161) 
> [org.apache.sling.installer.core:3.10.2]}}{{at 
> org.apache.sling.installer.core.impl.InternalResource.readDictionary(InternalResource.java:274)
>  [org.apache.sling.installer.core:3.10.2]}}{{at 
> org.apache.sling.installer.core.impl.InternalResource.create(InternalResource.java:106)
>  [org.apache.sling.installer.core:3.10.2]}}{{at 
> org.apache.sling.installer.core.impl.OsgiInstallerImpl.createResources(OsgiInstallerImpl.java:385)
>  [org.apache.sling.installer.core:3.10.2]}}{{at 
> org.apache.sling.installer.core.impl.OsgiInstallerImpl.updateResources(OsgiInstallerImpl.java:425)
>  [org.apache.sling.installer.core:3.10.2]}}{{at 
> org.apache.sling.installer.provider.jcr.impl.JcrInstaller.runOneCycle(JcrInstaller.java:465)
>  [org.apache.sling.installer.provider.jcr:3.2.0]}}{{at 
> org.apache.sling.installer.provider.jcr.impl.JcrInstaller$StoppableThread.run(JcrInstaller.java:287)
>  [org.apache.sling.installer.provider.jcr:3.2.0]}}
> The problem appears to be that the files are in JSON format, but contain a 
> prefix comment: " # Configuration created by Apache Sling JCR Installer"
> This is due to the JCR Installer changing to write the configuration files in 
> JSON format, but still including the comment from when the configurations 
> were persisted as text files:
> [https://github.com/apache/sling-org-apache-sling-installer-provider-jcr/blame/master/src/main/java/org/apache/sling/installer/provider/jcr/impl/JcrInstaller.java#L695]
> The question [~kwin] it looks like there was a revert commit, so should the 
> config files revert to TXT format or remove the comment and have the 
> configurations in JSON format?
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (SLING-9249) Exception thrown when running the Sling Starter -

2020-03-24 Thread Robert Munteanu (Jira)
Robert Munteanu created SLING-9249:
--

 Summary: Exception thrown when running the Sling Starter - 
 Key: SLING-9249
 URL: https://issues.apache.org/jira/browse/SLING-9249
 Project: Sling
  Issue Type: Bug
  Components: Scripting
Affects Versions: Scripting HTL Engine 1.3.2-1.4.0
Reporter: Robert Munteanu


To reproduce: run {{mvn clean verify}} on the current sling starter - 
org.apache.sling.starter-11-77-g85dfd1c.

I see the following error logged on the console:

{noformat}ERROR: bundle org.apache.sling.scripting.sightly:1.3.2.0 
(167)[org.apache.sling.scripting.sightly.impl.engine.extension.use.UseRuntimeExtension(311)]
 : The bindUseProvider method has thrown an exception
java.lang.NullPointerException
at 
java.base/java.util.concurrent.ConcurrentSkipListMap.put(ConcurrentSkipListMap.java:1345)
at 
org.apache.sling.scripting.sightly.impl.engine.extension.use.UseRuntimeExtension.bindUseProvider(UseRuntimeExtension.java:91)
at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
at 
org.apache.felix.scr.impl.inject.methods.BaseMethod.invokeMethod(BaseMethod.java:228)
at 
org.apache.felix.scr.impl.inject.methods.BaseMethod.access$500(BaseMethod.java:41)
at 
org.apache.felix.scr.impl.inject.methods.BaseMethod$Resolved.invoke(BaseMethod.java:664)
at 
org.apache.felix.scr.impl.inject.methods.BaseMethod.invoke(BaseMethod.java:510)
at 
org.apache.felix.scr.impl.inject.methods.BindMethod.invoke(BindMethod.java:42)
at 
org.apache.felix.scr.impl.manager.DependencyManager.doInvokeBindMethod(DependencyManager.java:1813)
at 
org.apache.felix.scr.impl.manager.DependencyManager.invokeBindMethod(DependencyManager.java:1788)
at 
org.apache.felix.scr.impl.manager.SingleComponentManager.invokeBindMethod(SingleComponentManager.java:435)
at 
org.apache.felix.scr.impl.manager.DependencyManager$MultipleDynamicCustomizer.addedService(DependencyManager.java:325)
at 
org.apache.felix.scr.impl.manager.DependencyManager$MultipleDynamicCustomizer.addedService(DependencyManager.java:294)
at 
org.apache.felix.scr.impl.manager.ServiceTracker$Tracked.customizerAdded(ServiceTracker.java:1216)
at 
org.apache.felix.scr.impl.manager.ServiceTracker$Tracked.customizerAdded(ServiceTracker.java:1137)
at 
org.apache.felix.scr.impl.manager.ServiceTracker$AbstractTracked.trackAdding(ServiceTracker.java:944)
at 
org.apache.felix.scr.impl.manager.ServiceTracker$AbstractTracked.track(ServiceTracker.java:880)
at 
org.apache.felix.scr.impl.manager.ServiceTracker$Tracked.serviceChanged(ServiceTracker.java:1168)
at 
org.apache.felix.scr.impl.BundleComponentActivator$ListenerInfo.serviceChanged(BundleComponentActivator.java:125)
at 
org.apache.felix.framework.EventDispatcher.invokeServiceListenerCallback(EventDispatcher.java:990)
at 
org.apache.felix.framework.EventDispatcher.fireEventImmediately(EventDispatcher.java:838)
at 
org.apache.felix.framework.EventDispatcher.fireServiceEvent(EventDispatcher.java:545)
at org.apache.felix.framework.Felix.fireServiceEvent(Felix.java:4833)
at org.apache.felix.framework.Felix.registerService(Felix.java:3804)
at 
org.apache.felix.framework.BundleContextImpl.registerService(BundleContextImpl.java:328)
at 
org.apache.felix.scr.impl.manager.AbstractComponentManager$3.register(AbstractComponentManager.java:906)
at 
org.apache.felix.scr.impl.manager.AbstractComponentManager$3.register(AbstractComponentManager.java:892)
at 
org.apache.felix.scr.impl.manager.RegistrationManager.changeRegistration(RegistrationManager.java:128)
at 
org.apache.felix.scr.impl.manager.AbstractComponentManager.registerService(AbstractComponentManager.java:959)
at 
org.apache.felix.scr.impl.manager.AbstractComponentManager.activateInternal(AbstractComponentManager.java:732)
at 
org.apache.felix.scr.impl.manager.DependencyManager$SingleStaticCustomizer.addedService(DependencyManager.java:1045)
at 
org.apache.felix.scr.impl.manager.DependencyManager$SingleStaticCustomizer.addedService(DependencyManager.java:999)
at 
org.apache.felix.scr.impl.manager.ServiceTracker$Tracked.customizerAdded(ServiceTracker.java:1216)
at 
org.apache.felix.scr.impl.manager.ServiceTracker$Tracked.customizerAdded(ServiceTracker.java:1137)
at 
org.apache.felix.scr.impl.manager.ServiceTracker$AbstractTracked.trackAdding(ServiceTracker.java:944)
at 
org

[jira] [Updated] (SLING-9249) Exception thrown when running the Sling Starter - UseRuntimeException: The bindUseProvider method has thrown an exception

2020-03-24 Thread Robert Munteanu (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-9249:
---
Summary: Exception thrown when running the Sling Starter - 
UseRuntimeException: The bindUseProvider method has thrown an exception  (was: 
Exception thrown when running the Sling Starter - )

> Exception thrown when running the Sling Starter - UseRuntimeException: The 
> bindUseProvider method has thrown an exception
> -
>
> Key: SLING-9249
> URL: https://issues.apache.org/jira/browse/SLING-9249
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Affects Versions: Scripting HTL Engine 1.3.2-1.4.0
>Reporter: Robert Munteanu
>Priority: Major
>
> To reproduce: run {{mvn clean verify}} on the current sling starter - 
> org.apache.sling.starter-11-77-g85dfd1c.
> I see the following error logged on the console:
> {noformat}ERROR: bundle org.apache.sling.scripting.sightly:1.3.2.0 
> (167)[org.apache.sling.scripting.sightly.impl.engine.extension.use.UseRuntimeExtension(311)]
>  : The bindUseProvider method has thrown an exception
> java.lang.NullPointerException
>   at 
> java.base/java.util.concurrent.ConcurrentSkipListMap.put(ConcurrentSkipListMap.java:1345)
>   at 
> org.apache.sling.scripting.sightly.impl.engine.extension.use.UseRuntimeExtension.bindUseProvider(UseRuntimeExtension.java:91)
>   at 
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.base/java.lang.reflect.Method.invoke(Method.java:566)
>   at 
> org.apache.felix.scr.impl.inject.methods.BaseMethod.invokeMethod(BaseMethod.java:228)
>   at 
> org.apache.felix.scr.impl.inject.methods.BaseMethod.access$500(BaseMethod.java:41)
>   at 
> org.apache.felix.scr.impl.inject.methods.BaseMethod$Resolved.invoke(BaseMethod.java:664)
>   at 
> org.apache.felix.scr.impl.inject.methods.BaseMethod.invoke(BaseMethod.java:510)
>   at 
> org.apache.felix.scr.impl.inject.methods.BindMethod.invoke(BindMethod.java:42)
>   at 
> org.apache.felix.scr.impl.manager.DependencyManager.doInvokeBindMethod(DependencyManager.java:1813)
>   at 
> org.apache.felix.scr.impl.manager.DependencyManager.invokeBindMethod(DependencyManager.java:1788)
>   at 
> org.apache.felix.scr.impl.manager.SingleComponentManager.invokeBindMethod(SingleComponentManager.java:435)
>   at 
> org.apache.felix.scr.impl.manager.DependencyManager$MultipleDynamicCustomizer.addedService(DependencyManager.java:325)
>   at 
> org.apache.felix.scr.impl.manager.DependencyManager$MultipleDynamicCustomizer.addedService(DependencyManager.java:294)
>   at 
> org.apache.felix.scr.impl.manager.ServiceTracker$Tracked.customizerAdded(ServiceTracker.java:1216)
>   at 
> org.apache.felix.scr.impl.manager.ServiceTracker$Tracked.customizerAdded(ServiceTracker.java:1137)
>   at 
> org.apache.felix.scr.impl.manager.ServiceTracker$AbstractTracked.trackAdding(ServiceTracker.java:944)
>   at 
> org.apache.felix.scr.impl.manager.ServiceTracker$AbstractTracked.track(ServiceTracker.java:880)
>   at 
> org.apache.felix.scr.impl.manager.ServiceTracker$Tracked.serviceChanged(ServiceTracker.java:1168)
>   at 
> org.apache.felix.scr.impl.BundleComponentActivator$ListenerInfo.serviceChanged(BundleComponentActivator.java:125)
>   at 
> org.apache.felix.framework.EventDispatcher.invokeServiceListenerCallback(EventDispatcher.java:990)
>   at 
> org.apache.felix.framework.EventDispatcher.fireEventImmediately(EventDispatcher.java:838)
>   at 
> org.apache.felix.framework.EventDispatcher.fireServiceEvent(EventDispatcher.java:545)
>   at org.apache.felix.framework.Felix.fireServiceEvent(Felix.java:4833)
>   at org.apache.felix.framework.Felix.registerService(Felix.java:3804)
>   at 
> org.apache.felix.framework.BundleContextImpl.registerService(BundleContextImpl.java:328)
>   at 
> org.apache.felix.scr.impl.manager.AbstractComponentManager$3.register(AbstractComponentManager.java:906)
>   at 
> org.apache.felix.scr.impl.manager.AbstractComponentManager$3.register(AbstractComponentManager.java:892)
>   at 
> org.apache.felix.scr.impl.manager.RegistrationManager.changeRegistration(RegistrationManager.java:128)
>   at 
> org.apache.felix.scr.impl.manager.AbstractComponentManager.registerService(AbstractComponentManager.java:959)
>   at 
> org.apache.felix.scr.impl.manager.AbstractComponentManager.activateInternal(AbstractComponentManager.java:732

[jira] [Commented] (SLING-9249) Exception thrown when running the Sling Starter - UseRuntimeException: The bindUseProvider method has thrown an exception

2020-03-24 Thread Robert Munteanu (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-9249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17065493#comment-17065493
 ] 

Robert Munteanu commented on SLING-9249:


[~radu] - not sure if this has other side effects, but at least it would be 
good to prevent it from happening and being printed on the console.

> Exception thrown when running the Sling Starter - UseRuntimeException: The 
> bindUseProvider method has thrown an exception
> -
>
> Key: SLING-9249
> URL: https://issues.apache.org/jira/browse/SLING-9249
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Affects Versions: Scripting HTL Engine 1.3.2-1.4.0
>Reporter: Robert Munteanu
>Priority: Major
>
> To reproduce: run {{mvn clean verify}} on the current sling starter - 
> org.apache.sling.starter-11-77-g85dfd1c.
> I see the following error logged on the console:
> {noformat}ERROR: bundle org.apache.sling.scripting.sightly:1.3.2.0 
> (167)[org.apache.sling.scripting.sightly.impl.engine.extension.use.UseRuntimeExtension(311)]
>  : The bindUseProvider method has thrown an exception
> java.lang.NullPointerException
>   at 
> java.base/java.util.concurrent.ConcurrentSkipListMap.put(ConcurrentSkipListMap.java:1345)
>   at 
> org.apache.sling.scripting.sightly.impl.engine.extension.use.UseRuntimeExtension.bindUseProvider(UseRuntimeExtension.java:91)
>   at 
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.base/java.lang.reflect.Method.invoke(Method.java:566)
>   at 
> org.apache.felix.scr.impl.inject.methods.BaseMethod.invokeMethod(BaseMethod.java:228)
>   at 
> org.apache.felix.scr.impl.inject.methods.BaseMethod.access$500(BaseMethod.java:41)
>   at 
> org.apache.felix.scr.impl.inject.methods.BaseMethod$Resolved.invoke(BaseMethod.java:664)
>   at 
> org.apache.felix.scr.impl.inject.methods.BaseMethod.invoke(BaseMethod.java:510)
>   at 
> org.apache.felix.scr.impl.inject.methods.BindMethod.invoke(BindMethod.java:42)
>   at 
> org.apache.felix.scr.impl.manager.DependencyManager.doInvokeBindMethod(DependencyManager.java:1813)
>   at 
> org.apache.felix.scr.impl.manager.DependencyManager.invokeBindMethod(DependencyManager.java:1788)
>   at 
> org.apache.felix.scr.impl.manager.SingleComponentManager.invokeBindMethod(SingleComponentManager.java:435)
>   at 
> org.apache.felix.scr.impl.manager.DependencyManager$MultipleDynamicCustomizer.addedService(DependencyManager.java:325)
>   at 
> org.apache.felix.scr.impl.manager.DependencyManager$MultipleDynamicCustomizer.addedService(DependencyManager.java:294)
>   at 
> org.apache.felix.scr.impl.manager.ServiceTracker$Tracked.customizerAdded(ServiceTracker.java:1216)
>   at 
> org.apache.felix.scr.impl.manager.ServiceTracker$Tracked.customizerAdded(ServiceTracker.java:1137)
>   at 
> org.apache.felix.scr.impl.manager.ServiceTracker$AbstractTracked.trackAdding(ServiceTracker.java:944)
>   at 
> org.apache.felix.scr.impl.manager.ServiceTracker$AbstractTracked.track(ServiceTracker.java:880)
>   at 
> org.apache.felix.scr.impl.manager.ServiceTracker$Tracked.serviceChanged(ServiceTracker.java:1168)
>   at 
> org.apache.felix.scr.impl.BundleComponentActivator$ListenerInfo.serviceChanged(BundleComponentActivator.java:125)
>   at 
> org.apache.felix.framework.EventDispatcher.invokeServiceListenerCallback(EventDispatcher.java:990)
>   at 
> org.apache.felix.framework.EventDispatcher.fireEventImmediately(EventDispatcher.java:838)
>   at 
> org.apache.felix.framework.EventDispatcher.fireServiceEvent(EventDispatcher.java:545)
>   at org.apache.felix.framework.Felix.fireServiceEvent(Felix.java:4833)
>   at org.apache.felix.framework.Felix.registerService(Felix.java:3804)
>   at 
> org.apache.felix.framework.BundleContextImpl.registerService(BundleContextImpl.java:328)
>   at 
> org.apache.felix.scr.impl.manager.AbstractComponentManager$3.register(AbstractComponentManager.java:906)
>   at 
> org.apache.felix.scr.impl.manager.AbstractComponentManager$3.register(AbstractComponentManager.java:892)
>   at 
> org.apache.felix.scr.impl.manager.RegistrationManager.changeRegistration(RegistrationManager.java:128)
>   at 
> org.apache.felix.scr.impl.manager.AbstractComponentManager.registerService(AbstractComponentManager.java:959)
>   at 
> org.apache.felix.scr.impl.manager.AbstractComponentManager.activateInternal(AbstractComponentManager.j

[jira] [Comment Edited] (SLING-9219) Invalid Comments in JSON Configuration

2020-03-24 Thread Carsten Ziegeler (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-9219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17065491#comment-17065491
 ] 

Carsten Ziegeler edited comment on SLING-9219 at 3/24/20, 10:28 AM:


JCR Installer does not compile anymore : 
/src/main/java/org/apache/sling/installer/provider/jcr/impl/JcrInstaller.java:[71,8]
 org.apache.sling.installer.provider.jcr.impl.JcrInstaller is not abstract and 
does not override abstract method 
handleUpdate(java.lang.String,java.lang.String,java.lang.String,java.util.Dictionary,java.util.Map)
 in org.apache.sling.installer.api.UpdateHandler

[~kwin] Please also note that the commits to both projects contain a wrong 
issue number (9218 and not 9219)


was (Author: cziegeler):
JCR Installer does not compile anymore : 
/src/main/java/org/apache/sling/installer/provider/jcr/impl/JcrInstaller.java:[71,8]
 org.apache.sling.installer.provider.jcr.impl.JcrInstaller is not abstract and 
does not override abstract method 
handleUpdate(java.lang.String,java.lang.String,java.lang.String,java.util.Dictionary,java.util.Map)
 in org.apache.sling.installer.api.UpdateHandler

> Invalid Comments in JSON Configuration
> --
>
> Key: SLING-9219
> URL: https://issues.apache.org/jira/browse/SLING-9219
> Project: Sling
>  Issue Type: Bug
>  Components: Installer
>Affects Versions: File Installer 1.2.0, JCR Installer 3.2.0
>Reporter: Dan Klco
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: JCR Installer 3.2.2, File Installer 1.2.2
>
>
> With the latest version of JCR Installer, I'm seeing an exception when saving 
> OSGi Configurations from the console:
>  
> {{18.03.2020 19:57:44.565 *WARN* [JcrInstaller.2] 
> org.apache.sling.installer.core.impl.OsgiInstallerImpl Cannot create 
> InternalResource (resource will be ignored):InstallableResource, 
> priority=200, 
> id=/apps/sling/install/org.apache.sling.cms.core.internal.repository.RevisionCleanupScheduler.cfg.json}}{{javax.json.stream.JsonParsingException:
>  Unexpected character '#' (Codepoint: 35) on [lineNumber=2, columnNumber=77, 
> streamOffset=76]. Reason is [[Expected structural character or digit or 't' 
> or 'n' or 'f' or '-']]}}{{at 
> org.apache.johnzon.core.JsonStreamParserImpl.uexc(JsonStreamParserImpl.java:966)}}{{at
>  
> org.apache.johnzon.core.JsonStreamParserImpl.uexc(JsonStreamParserImpl.java:972)}}{{at
>  
> org.apache.johnzon.core.JsonStreamParserImpl.defaultHandling(JsonStreamParserImpl.java:422)}}{{at
>  
> org.apache.johnzon.core.JsonStreamParserImpl.next(JsonStreamParserImpl.java:414)}}{{at
>  
> org.apache.johnzon.core.JsonStreamParserImpl.next(JsonStreamParserImpl.java:353)}}{{at
>  
> org.apache.johnzon.core.JsonReaderImpl.parseObject(JsonReaderImpl.java:131)}}{{at
>  
> org.apache.johnzon.core.JsonReaderImpl.readValue(JsonReaderImpl.java:56)}}{{at
>  org.apache.johnzon.core.JsonReaderImpl.read(JsonReaderImpl.java:42)}}{{at 
> org.apache.felix.configurator.impl.json.JSONUtil.parseJSON(JSONUtil.java:331) 
> [org.apache.sling.installer.core:3.10.2]}}{{at 
> org.apache.felix.configurator.impl.json.JSONUtil.readJSON(JSONUtil.java:161) 
> [org.apache.sling.installer.core:3.10.2]}}{{at 
> org.apache.sling.installer.core.impl.InternalResource.readDictionary(InternalResource.java:274)
>  [org.apache.sling.installer.core:3.10.2]}}{{at 
> org.apache.sling.installer.core.impl.InternalResource.create(InternalResource.java:106)
>  [org.apache.sling.installer.core:3.10.2]}}{{at 
> org.apache.sling.installer.core.impl.OsgiInstallerImpl.createResources(OsgiInstallerImpl.java:385)
>  [org.apache.sling.installer.core:3.10.2]}}{{at 
> org.apache.sling.installer.core.impl.OsgiInstallerImpl.updateResources(OsgiInstallerImpl.java:425)
>  [org.apache.sling.installer.core:3.10.2]}}{{at 
> org.apache.sling.installer.provider.jcr.impl.JcrInstaller.runOneCycle(JcrInstaller.java:465)
>  [org.apache.sling.installer.provider.jcr:3.2.0]}}{{at 
> org.apache.sling.installer.provider.jcr.impl.JcrInstaller$StoppableThread.run(JcrInstaller.java:287)
>  [org.apache.sling.installer.provider.jcr:3.2.0]}}
> The problem appears to be that the files are in JSON format, but contain a 
> prefix comment: " # Configuration created by Apache Sling JCR Installer"
> This is due to the JCR Installer changing to write the configuration files in 
> JSON format, but still including the comment from when the configurations 
> were persisted as text files:
> [https://github.com/apache/sling-org-apache-sling-installer-provider-jcr/blame/master/src/main/java/org/apache/sling/installer/provider/jcr/impl/JcrInstaller.java#L695]
> The question [~kwin] it looks like there was a revert commit, so should the 
> config files revert to TXT format or remove the comment and have the 
> configurations in JSON f

[jira] [Updated] (SLING-9249) Exception thrown when running the Sling Starter - UseRuntimeException: The bindUseProvider method has thrown an exception

2020-03-24 Thread Robert Munteanu (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-9249:
---
Description: 
To reproduce: run {{mvn clean verify}} on the current sling starter - 
org.apache.sling.starter-11-77-g85dfd1c.

I see the following error logged on the console:

{noformat}ERROR: bundle org.apache.sling.scripting.sightly:1.3.2.0 
(167)[org.apache.sling.scripting.sightly.impl.engine.extension.use.UseRuntimeExtension(311)]
 : The bindUseProvider method has thrown an exception
java.lang.NullPointerException
at 
java.base/java.util.concurrent.ConcurrentSkipListMap.put(ConcurrentSkipListMap.java:1345)
at 
org.apache.sling.scripting.sightly.impl.engine.extension.use.UseRuntimeExtension.bindUseProvider(UseRuntimeExtension.java:91)
at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
at 
org.apache.felix.scr.impl.inject.methods.BaseMethod.invokeMethod(BaseMethod.java:228)
at 
org.apache.felix.scr.impl.inject.methods.BaseMethod.access$500(BaseMethod.java:41)
at 
org.apache.felix.scr.impl.inject.methods.BaseMethod$Resolved.invoke(BaseMethod.java:664)
at 
org.apache.felix.scr.impl.inject.methods.BaseMethod.invoke(BaseMethod.java:510)
at 
org.apache.felix.scr.impl.inject.methods.BindMethod.invoke(BindMethod.java:42)
at 
org.apache.felix.scr.impl.manager.DependencyManager.doInvokeBindMethod(DependencyManager.java:1813)
at 
org.apache.felix.scr.impl.manager.DependencyManager.invokeBindMethod(DependencyManager.java:1788)
at 
org.apache.felix.scr.impl.manager.SingleComponentManager.invokeBindMethod(SingleComponentManager.java:435)
at 
org.apache.felix.scr.impl.manager.DependencyManager$MultipleDynamicCustomizer.addedService(DependencyManager.java:325)
at 
org.apache.felix.scr.impl.manager.DependencyManager$MultipleDynamicCustomizer.addedService(DependencyManager.java:294)
at 
org.apache.felix.scr.impl.manager.ServiceTracker$Tracked.customizerAdded(ServiceTracker.java:1216)
at 
org.apache.felix.scr.impl.manager.ServiceTracker$Tracked.customizerAdded(ServiceTracker.java:1137)
at 
org.apache.felix.scr.impl.manager.ServiceTracker$AbstractTracked.trackAdding(ServiceTracker.java:944)
at 
org.apache.felix.scr.impl.manager.ServiceTracker$AbstractTracked.track(ServiceTracker.java:880)
at 
org.apache.felix.scr.impl.manager.ServiceTracker$Tracked.serviceChanged(ServiceTracker.java:1168)
at 
org.apache.felix.scr.impl.BundleComponentActivator$ListenerInfo.serviceChanged(BundleComponentActivator.java:125)
at 
org.apache.felix.framework.EventDispatcher.invokeServiceListenerCallback(EventDispatcher.java:990)
at 
org.apache.felix.framework.EventDispatcher.fireEventImmediately(EventDispatcher.java:838)
at 
org.apache.felix.framework.EventDispatcher.fireServiceEvent(EventDispatcher.java:545)
at org.apache.felix.framework.Felix.fireServiceEvent(Felix.java:4833)
at org.apache.felix.framework.Felix.registerService(Felix.java:3804)
at 
org.apache.felix.framework.BundleContextImpl.registerService(BundleContextImpl.java:328)
at 
org.apache.felix.scr.impl.manager.AbstractComponentManager$3.register(AbstractComponentManager.java:906)
at 
org.apache.felix.scr.impl.manager.AbstractComponentManager$3.register(AbstractComponentManager.java:892)
at 
org.apache.felix.scr.impl.manager.RegistrationManager.changeRegistration(RegistrationManager.java:128)
at 
org.apache.felix.scr.impl.manager.AbstractComponentManager.registerService(AbstractComponentManager.java:959)
at 
org.apache.felix.scr.impl.manager.AbstractComponentManager.activateInternal(AbstractComponentManager.java:732)
at 
org.apache.felix.scr.impl.manager.DependencyManager$SingleStaticCustomizer.addedService(DependencyManager.java:1045)
at 
org.apache.felix.scr.impl.manager.DependencyManager$SingleStaticCustomizer.addedService(DependencyManager.java:999)
at 
org.apache.felix.scr.impl.manager.ServiceTracker$Tracked.customizerAdded(ServiceTracker.java:1216)
at 
org.apache.felix.scr.impl.manager.ServiceTracker$Tracked.customizerAdded(ServiceTracker.java:1137)
at 
org.apache.felix.scr.impl.manager.ServiceTracker$AbstractTracked.trackAdding(ServiceTracker.java:944)
at 
org.apache.felix.scr.impl.manager.ServiceTracker$AbstractTracked.track(ServiceTracker.java:880)
at 
org.apache.felix.scr.impl.manager.ServiceTracker$Tracked.serviceChanged(ServiceTracker.java:1168)
at 

[jira] [Updated] (SLING-9249) Exception thrown when running the Sling Starter - UseRuntimeException: The bindUseProvider method has thrown an exception

2020-03-24 Thread Robert Munteanu (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-9249:
---
Attachment: log.txt

> Exception thrown when running the Sling Starter - UseRuntimeException: The 
> bindUseProvider method has thrown an exception
> -
>
> Key: SLING-9249
> URL: https://issues.apache.org/jira/browse/SLING-9249
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Affects Versions: Scripting HTL Engine 1.3.2-1.4.0
>Reporter: Robert Munteanu
>Priority: Major
> Attachments: log.txt
>
>
> To reproduce: run {{mvn clean verify}} on the current sling starter - 
> org.apache.sling.starter-11-77-g85dfd1c.
> I see the following error logged on the console:
> {noformat}ERROR: bundle org.apache.sling.scripting.sightly:1.3.2.0 
> (167)[org.apache.sling.scripting.sightly.impl.engine.extension.use.UseRuntimeExtension(311)]
>  : The bindUseProvider method has thrown an exception
> java.lang.NullPointerException
>   at 
> java.base/java.util.concurrent.ConcurrentSkipListMap.put(ConcurrentSkipListMap.java:1345)
>   at 
> org.apache.sling.scripting.sightly.impl.engine.extension.use.UseRuntimeExtension.bindUseProvider(UseRuntimeExtension.java:91)
>   at 
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.base/java.lang.reflect.Method.invoke(Method.java:566)
>   at 
> org.apache.felix.scr.impl.inject.methods.BaseMethod.invokeMethod(BaseMethod.java:228)
>   at 
> org.apache.felix.scr.impl.inject.methods.BaseMethod.access$500(BaseMethod.java:41)
>   at 
> org.apache.felix.scr.impl.inject.methods.BaseMethod$Resolved.invoke(BaseMethod.java:664)
>   at 
> org.apache.felix.scr.impl.inject.methods.BaseMethod.invoke(BaseMethod.java:510)
>   at 
> org.apache.felix.scr.impl.inject.methods.BindMethod.invoke(BindMethod.java:42)
>   at 
> org.apache.felix.scr.impl.manager.DependencyManager.doInvokeBindMethod(DependencyManager.java:1813)
>   at 
> org.apache.felix.scr.impl.manager.DependencyManager.invokeBindMethod(DependencyManager.java:1788)
>   at 
> org.apache.felix.scr.impl.manager.SingleComponentManager.invokeBindMethod(SingleComponentManager.java:435)
>   at 
> org.apache.felix.scr.impl.manager.DependencyManager$MultipleDynamicCustomizer.addedService(DependencyManager.java:325)
>   at 
> org.apache.felix.scr.impl.manager.DependencyManager$MultipleDynamicCustomizer.addedService(DependencyManager.java:294)
>   at 
> org.apache.felix.scr.impl.manager.ServiceTracker$Tracked.customizerAdded(ServiceTracker.java:1216)
>   at 
> org.apache.felix.scr.impl.manager.ServiceTracker$Tracked.customizerAdded(ServiceTracker.java:1137)
>   at 
> org.apache.felix.scr.impl.manager.ServiceTracker$AbstractTracked.trackAdding(ServiceTracker.java:944)
>   at 
> org.apache.felix.scr.impl.manager.ServiceTracker$AbstractTracked.track(ServiceTracker.java:880)
>   at 
> org.apache.felix.scr.impl.manager.ServiceTracker$Tracked.serviceChanged(ServiceTracker.java:1168)
>   at 
> org.apache.felix.scr.impl.BundleComponentActivator$ListenerInfo.serviceChanged(BundleComponentActivator.java:125)
>   at 
> org.apache.felix.framework.EventDispatcher.invokeServiceListenerCallback(EventDispatcher.java:990)
>   at 
> org.apache.felix.framework.EventDispatcher.fireEventImmediately(EventDispatcher.java:838)
>   at 
> org.apache.felix.framework.EventDispatcher.fireServiceEvent(EventDispatcher.java:545)
>   at org.apache.felix.framework.Felix.fireServiceEvent(Felix.java:4833)
>   at org.apache.felix.framework.Felix.registerService(Felix.java:3804)
>   at 
> org.apache.felix.framework.BundleContextImpl.registerService(BundleContextImpl.java:328)
>   at 
> org.apache.felix.scr.impl.manager.AbstractComponentManager$3.register(AbstractComponentManager.java:906)
>   at 
> org.apache.felix.scr.impl.manager.AbstractComponentManager$3.register(AbstractComponentManager.java:892)
>   at 
> org.apache.felix.scr.impl.manager.RegistrationManager.changeRegistration(RegistrationManager.java:128)
>   at 
> org.apache.felix.scr.impl.manager.AbstractComponentManager.registerService(AbstractComponentManager.java:959)
>   at 
> org.apache.felix.scr.impl.manager.AbstractComponentManager.activateInternal(AbstractComponentManager.java:732)
>   at 
> org.apache.felix.scr.impl.manager.DependencyManager$SingleStaticCustomizer.addedService(DependencyManager.java:1045)
> 

[jira] [Commented] (SLING-9219) Invalid Comments in JSON Configuration

2020-03-24 Thread Konrad Windszus (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-9219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17065497#comment-17065497
 ] 

Konrad Windszus commented on SLING-9219:


Thanks for the heads up, the compilation issue should be fixed in 
https://github.com/apache/sling-org-apache-sling-installer-provider-jcr/commit/ed8ac0bfe6eb9ec359f2afa28e45c0829cd42d1f.
 I saw the wrong issue number too late though.

> Invalid Comments in JSON Configuration
> --
>
> Key: SLING-9219
> URL: https://issues.apache.org/jira/browse/SLING-9219
> Project: Sling
>  Issue Type: Bug
>  Components: Installer
>Affects Versions: File Installer 1.2.0, JCR Installer 3.2.0
>Reporter: Dan Klco
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: JCR Installer 3.2.2, File Installer 1.2.2
>
>
> With the latest version of JCR Installer, I'm seeing an exception when saving 
> OSGi Configurations from the console:
>  
> {{18.03.2020 19:57:44.565 *WARN* [JcrInstaller.2] 
> org.apache.sling.installer.core.impl.OsgiInstallerImpl Cannot create 
> InternalResource (resource will be ignored):InstallableResource, 
> priority=200, 
> id=/apps/sling/install/org.apache.sling.cms.core.internal.repository.RevisionCleanupScheduler.cfg.json}}{{javax.json.stream.JsonParsingException:
>  Unexpected character '#' (Codepoint: 35) on [lineNumber=2, columnNumber=77, 
> streamOffset=76]. Reason is [[Expected structural character or digit or 't' 
> or 'n' or 'f' or '-']]}}{{at 
> org.apache.johnzon.core.JsonStreamParserImpl.uexc(JsonStreamParserImpl.java:966)}}{{at
>  
> org.apache.johnzon.core.JsonStreamParserImpl.uexc(JsonStreamParserImpl.java:972)}}{{at
>  
> org.apache.johnzon.core.JsonStreamParserImpl.defaultHandling(JsonStreamParserImpl.java:422)}}{{at
>  
> org.apache.johnzon.core.JsonStreamParserImpl.next(JsonStreamParserImpl.java:414)}}{{at
>  
> org.apache.johnzon.core.JsonStreamParserImpl.next(JsonStreamParserImpl.java:353)}}{{at
>  
> org.apache.johnzon.core.JsonReaderImpl.parseObject(JsonReaderImpl.java:131)}}{{at
>  
> org.apache.johnzon.core.JsonReaderImpl.readValue(JsonReaderImpl.java:56)}}{{at
>  org.apache.johnzon.core.JsonReaderImpl.read(JsonReaderImpl.java:42)}}{{at 
> org.apache.felix.configurator.impl.json.JSONUtil.parseJSON(JSONUtil.java:331) 
> [org.apache.sling.installer.core:3.10.2]}}{{at 
> org.apache.felix.configurator.impl.json.JSONUtil.readJSON(JSONUtil.java:161) 
> [org.apache.sling.installer.core:3.10.2]}}{{at 
> org.apache.sling.installer.core.impl.InternalResource.readDictionary(InternalResource.java:274)
>  [org.apache.sling.installer.core:3.10.2]}}{{at 
> org.apache.sling.installer.core.impl.InternalResource.create(InternalResource.java:106)
>  [org.apache.sling.installer.core:3.10.2]}}{{at 
> org.apache.sling.installer.core.impl.OsgiInstallerImpl.createResources(OsgiInstallerImpl.java:385)
>  [org.apache.sling.installer.core:3.10.2]}}{{at 
> org.apache.sling.installer.core.impl.OsgiInstallerImpl.updateResources(OsgiInstallerImpl.java:425)
>  [org.apache.sling.installer.core:3.10.2]}}{{at 
> org.apache.sling.installer.provider.jcr.impl.JcrInstaller.runOneCycle(JcrInstaller.java:465)
>  [org.apache.sling.installer.provider.jcr:3.2.0]}}{{at 
> org.apache.sling.installer.provider.jcr.impl.JcrInstaller$StoppableThread.run(JcrInstaller.java:287)
>  [org.apache.sling.installer.provider.jcr:3.2.0]}}
> The problem appears to be that the files are in JSON format, but contain a 
> prefix comment: " # Configuration created by Apache Sling JCR Installer"
> This is due to the JCR Installer changing to write the configuration files in 
> JSON format, but still including the comment from when the configurations 
> were persisted as text files:
> [https://github.com/apache/sling-org-apache-sling-installer-provider-jcr/blame/master/src/main/java/org/apache/sling/installer/provider/jcr/impl/JcrInstaller.java#L695]
> The question [~kwin] it looks like there was a revert commit, so should the 
> config files revert to TXT format or remove the comment and have the 
> configurations in JSON format?
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: [VOTE] Release Apache Sling App CMS version 0.16.0

2020-03-24 Thread Daniel Klco
Any more PMC votes?

On Fri, Mar 20, 2020 at 12:41 PM Daniel Klco  wrote:

> +1
>
> On Fri, Mar 20, 2020 at 12:37 PM Robert Munteanu 
> wrote:
>
>> On Fri, 2020-03-20 at 12:12 -0400, Daniel Klco wrote:
>> > Please vote to approve this release:
>>
>> +1
>> Robert
>>
>


Re: [VOTE] Release Apache Sling App CMS version 0.16.0

2020-03-24 Thread Andrei Dulvac
+1

On Tue, 24 Mar 2020 at 12:37, Daniel Klco  wrote:

> Any more PMC votes?
>
> On Fri, Mar 20, 2020 at 12:41 PM Daniel Klco  wrote:
>
> > +1
> >
> > On Fri, Mar 20, 2020 at 12:37 PM Robert Munteanu 
> > wrote:
> >
> >> On Fri, 2020-03-20 at 12:12 -0400, Daniel Klco wrote:
> >> > Please vote to approve this release:
> >>
> >> +1
> >> Robert
> >>
> >
>


[jira] [Updated] (SLING-9251) Update Pax Exam to 4.13.3

2020-03-24 Thread Oliver Lietz (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz updated SLING-9251:

Summary: Update Pax Exam to 4.13.3  (was: Update Pax Exam to 4.13.2)

> Update Pax Exam to 4.13.3
> -
>
> Key: SLING-9251
> URL: https://issues.apache.org/jira/browse/SLING-9251
> Project: Sling
>  Issue Type: Task
>  Components: Commons
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Commons HTML 1.2.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (SLING-9251) Update Pax Exam to 4.13.2

2020-03-24 Thread Oliver Lietz (Jira)
Oliver Lietz created SLING-9251:
---

 Summary: Update Pax Exam to 4.13.2
 Key: SLING-9251
 URL: https://issues.apache.org/jira/browse/SLING-9251
 Project: Sling
  Issue Type: Task
  Components: Commons
Reporter: Oliver Lietz
Assignee: Oliver Lietz
 Fix For: Commons HTML 1.2.0






--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (SLING-9250) Selectors are used as extensions when servlets are registered for a capability

2020-03-24 Thread Radu Cotescu (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu resolved SLING-9250.
-
Resolution: Fixed

Fixed in [commit 
fd90c9c|https://github.com/apache/sling-org-apache-sling-scripting-bundle-tracker/commit/fd90c9c].

> Selectors are used as extensions when servlets are registered for a capability
> --
>
> Key: SLING-9250
> URL: https://issues.apache.org/jira/browse/SLING-9250
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Reporter: Radu Cotescu
>Assignee: Radu Cotescu
>Priority: Major
> Fix For: Scripting Bundle Tracker 0.2.0
>
>
> The fix for SLING-9216 slipped a bug where a capability's selectors are used 
> for generating the {{sling.servlets.extensions}} servlet registration 
> property.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (SLING-9252) Optimise request dispatching for inheriting resource types

2020-03-24 Thread Radu Cotescu (Jira)
Radu Cotescu created SLING-9252:
---

 Summary: Optimise request dispatching for inheriting resource types
 Key: SLING-9252
 URL: https://issues.apache.org/jira/browse/SLING-9252
 Project: Sling
  Issue Type: Improvement
  Components: Scripting
Reporter: Radu Cotescu
Assignee: Radu Cotescu
 Fix For: Scripting Bundle Tracker 0.2.0


The request dispatching for inheriting resource types can be optimised if the 
version is also appended to the type in the {{sling.servlet.resourceSuperType}} 
property when registering the child resource type. When adding the version 
information, the request will be handled directly by the most specific servlet, 
rather than by the {{DispatcherServlet}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (SLING-9252) Optimise request dispatching for inheriting resource types

2020-03-24 Thread Radu Cotescu (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu resolved SLING-9252.
-
Resolution: Fixed

Fixed in [commit 
1776151|https://github.com/apache/sling-org-apache-sling-scripting-bundle-tracker/commit/1776151].

> Optimise request dispatching for inheriting resource types
> --
>
> Key: SLING-9252
> URL: https://issues.apache.org/jira/browse/SLING-9252
> Project: Sling
>  Issue Type: Improvement
>  Components: Scripting
>Reporter: Radu Cotescu
>Assignee: Radu Cotescu
>Priority: Major
> Fix For: Scripting Bundle Tracker 0.2.0
>
>
> The request dispatching for inheriting resource types can be optimised if the 
> version is also appended to the type in the 
> {{sling.servlet.resourceSuperType}} property when registering the child 
> resource type. When adding the version information, the request will be 
> handled directly by the most specific servlet, rather than by the 
> {{DispatcherServlet}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (SLING-9251) Update Pax Exam to 4.13.3

2020-03-24 Thread Oliver Lietz (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz resolved SLING-9251.
-
Resolution: Done

* Pax Exam updated
* Testing PaxExam updated

> Update Pax Exam to 4.13.3
> -
>
> Key: SLING-9251
> URL: https://issues.apache.org/jira/browse/SLING-9251
> Project: Sling
>  Issue Type: Task
>  Components: Commons
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Commons HTML 1.2.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (SLING-9171) Support for settings properties on paths created via repoinit create path

2020-03-24 Thread Bertrand Delacretaz (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bertrand Delacretaz reassigned SLING-9171:
--

Assignee: Bertrand Delacretaz

> Support for settings properties on paths created via repoinit create path
> -
>
> Key: SLING-9171
> URL: https://issues.apache.org/jira/browse/SLING-9171
> Project: Sling
>  Issue Type: Improvement
>  Components: Repoinit
>Reporter: Nitin Gupta
>Assignee: Bertrand Delacretaz
>Priority: Major
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> Apart from jcr:primaryType and mixin, there is a requirement to add custom 
> properties to the nodes valuemap via repoinit. This is a gap currently.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[RESULT] [VOTE] Release Apache Sling App CMS version 0.16.0

2020-03-24 Thread Daniel Klco
Hi,

The vote has passed with the following result:

+1 (binding): Robert Munteanu, Dan Klco, Andrei Dulvac
+1 (non-binding): none

I will copy this release to the Sling dist directory and promote the
artifacts to the central Maven repository.

Regards,
Dan Klco

On Tue, Mar 24, 2020 at 7:41 AM Andrei Dulvac  wrote:

> +1
>
> On Tue, 24 Mar 2020 at 12:37, Daniel Klco  wrote:
>
>> Any more PMC votes?
>>
>> On Fri, Mar 20, 2020 at 12:41 PM Daniel Klco  wrote:
>>
>> > +1
>> >
>> > On Fri, Mar 20, 2020 at 12:37 PM Robert Munteanu 
>> > wrote:
>> >
>> >> On Fri, 2020-03-20 at 12:12 -0400, Daniel Klco wrote:
>> >> > Please vote to approve this release:
>> >>
>> >> +1
>> >> Robert
>> >>
>> >
>>
>


[jira] [Resolved] (SLING-9219) Invalid Comments in JSON Configuration

2020-03-24 Thread Carsten Ziegeler (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-9219.
-
Resolution: Fixed

Thanks [~kwin] for the quick fix.


> Invalid Comments in JSON Configuration
> --
>
> Key: SLING-9219
> URL: https://issues.apache.org/jira/browse/SLING-9219
> Project: Sling
>  Issue Type: Bug
>  Components: Installer
>Affects Versions: File Installer 1.2.0, JCR Installer 3.2.0
>Reporter: Dan Klco
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: JCR Installer 3.2.2, File Installer 1.2.2
>
>
> With the latest version of JCR Installer, I'm seeing an exception when saving 
> OSGi Configurations from the console:
>  
> {{18.03.2020 19:57:44.565 *WARN* [JcrInstaller.2] 
> org.apache.sling.installer.core.impl.OsgiInstallerImpl Cannot create 
> InternalResource (resource will be ignored):InstallableResource, 
> priority=200, 
> id=/apps/sling/install/org.apache.sling.cms.core.internal.repository.RevisionCleanupScheduler.cfg.json}}{{javax.json.stream.JsonParsingException:
>  Unexpected character '#' (Codepoint: 35) on [lineNumber=2, columnNumber=77, 
> streamOffset=76]. Reason is [[Expected structural character or digit or 't' 
> or 'n' or 'f' or '-']]}}{{at 
> org.apache.johnzon.core.JsonStreamParserImpl.uexc(JsonStreamParserImpl.java:966)}}{{at
>  
> org.apache.johnzon.core.JsonStreamParserImpl.uexc(JsonStreamParserImpl.java:972)}}{{at
>  
> org.apache.johnzon.core.JsonStreamParserImpl.defaultHandling(JsonStreamParserImpl.java:422)}}{{at
>  
> org.apache.johnzon.core.JsonStreamParserImpl.next(JsonStreamParserImpl.java:414)}}{{at
>  
> org.apache.johnzon.core.JsonStreamParserImpl.next(JsonStreamParserImpl.java:353)}}{{at
>  
> org.apache.johnzon.core.JsonReaderImpl.parseObject(JsonReaderImpl.java:131)}}{{at
>  
> org.apache.johnzon.core.JsonReaderImpl.readValue(JsonReaderImpl.java:56)}}{{at
>  org.apache.johnzon.core.JsonReaderImpl.read(JsonReaderImpl.java:42)}}{{at 
> org.apache.felix.configurator.impl.json.JSONUtil.parseJSON(JSONUtil.java:331) 
> [org.apache.sling.installer.core:3.10.2]}}{{at 
> org.apache.felix.configurator.impl.json.JSONUtil.readJSON(JSONUtil.java:161) 
> [org.apache.sling.installer.core:3.10.2]}}{{at 
> org.apache.sling.installer.core.impl.InternalResource.readDictionary(InternalResource.java:274)
>  [org.apache.sling.installer.core:3.10.2]}}{{at 
> org.apache.sling.installer.core.impl.InternalResource.create(InternalResource.java:106)
>  [org.apache.sling.installer.core:3.10.2]}}{{at 
> org.apache.sling.installer.core.impl.OsgiInstallerImpl.createResources(OsgiInstallerImpl.java:385)
>  [org.apache.sling.installer.core:3.10.2]}}{{at 
> org.apache.sling.installer.core.impl.OsgiInstallerImpl.updateResources(OsgiInstallerImpl.java:425)
>  [org.apache.sling.installer.core:3.10.2]}}{{at 
> org.apache.sling.installer.provider.jcr.impl.JcrInstaller.runOneCycle(JcrInstaller.java:465)
>  [org.apache.sling.installer.provider.jcr:3.2.0]}}{{at 
> org.apache.sling.installer.provider.jcr.impl.JcrInstaller$StoppableThread.run(JcrInstaller.java:287)
>  [org.apache.sling.installer.provider.jcr:3.2.0]}}
> The problem appears to be that the files are in JSON format, but contain a 
> prefix comment: " # Configuration created by Apache Sling JCR Installer"
> This is due to the JCR Installer changing to write the configuration files in 
> JSON format, but still including the comment from when the configurations 
> were persisted as text files:
> [https://github.com/apache/sling-org-apache-sling-installer-provider-jcr/blame/master/src/main/java/org/apache/sling/installer/provider/jcr/impl/JcrInstaller.java#L695]
> The question [~kwin] it looks like there was a revert commit, so should the 
> config files revert to TXT format or remove the comment and have the 
> configurations in JSON format?
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (SLING-9250) Selectors are used as extensions when servlets are registered for a capability

2020-03-24 Thread Radu Cotescu (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu updated SLING-9250:

Description: The fix for SLING-9216 slipped a bug where a capability's 
selectors are used for generating the {{sling.servlets.extensions}} servlet 
registration property.  (was: The fix for SLING-9216 slipped a bug where a 
capability's selectors are used for generating the `sling.servlets.extensions` 
servlet registration property.)

> Selectors are used as extensions when servlets are registered for a capability
> --
>
> Key: SLING-9250
> URL: https://issues.apache.org/jira/browse/SLING-9250
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Reporter: Radu Cotescu
>Assignee: Radu Cotescu
>Priority: Major
> Fix For: Scripting Bundle Tracker 0.2.0
>
>
> The fix for SLING-9216 slipped a bug where a capability's selectors are used 
> for generating the {{sling.servlets.extensions}} servlet registration 
> property.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (SLING-9250) Selectors are used as extensions when servlets are registered for a capability

2020-03-24 Thread Radu Cotescu (Jira)
Radu Cotescu created SLING-9250:
---

 Summary: Selectors are used as extensions when servlets are 
registered for a capability
 Key: SLING-9250
 URL: https://issues.apache.org/jira/browse/SLING-9250
 Project: Sling
  Issue Type: Bug
  Components: Scripting
Reporter: Radu Cotescu
Assignee: Radu Cotescu
 Fix For: Scripting Bundle Tracker 0.2.0


The fix for SLING-9216 slipped a bug where a capability's selectors are used 
for generating the `sling.servlets.extensions` servlet registration property.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (SLING-9253) Feature archive gives EOFException while reading

2020-03-24 Thread Nitin Gupta (Jira)
Nitin Gupta created SLING-9253:
--

 Summary: Feature archive gives EOFException while reading
 Key: SLING-9253
 URL: https://issues.apache.org/jira/browse/SLING-9253
 Project: Sling
  Issue Type: Bug
  Components: Maven Plugins and Archetypes
Reporter: Nitin Gupta


{{[java.io|http://java.io/]}}{{.EOFException: Unexpected end of ZLIB input 
stream}}
{{  at 
java.util.zip.InflaterInputStream.fill(InflaterInputStream.java:240)}}
{{  at 
java.util.zip.InflaterInputStream.read(InflaterInputStream.java:158)}}
{{  at java.util.zip.ZipInputStream.read(ZipInputStream.java:194)}}
{{  at java.util.jar.JarInputStream.read(JarInputStream.java:207)}}

{{}}

{{It is probably due to not closing of JarOutputStream in the 
AttachFeatureArchivesMojo}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (SLING-9253) Feature archive gives EOFException while reading

2020-03-24 Thread Carsten Ziegeler (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler reassigned SLING-9253:
---

Assignee: Carsten Ziegeler

> Feature archive gives EOFException while reading
> 
>
> Key: SLING-9253
> URL: https://issues.apache.org/jira/browse/SLING-9253
> Project: Sling
>  Issue Type: Bug
>  Components: Maven Plugins and Archetypes
>Reporter: Nitin Gupta
>Assignee: Carsten Ziegeler
>Priority: Major
>
> {{[java.io|http://java.io/]}}{{.EOFException: Unexpected end of ZLIB input 
> stream}}
> {{at 
> java.util.zip.InflaterInputStream.fill(InflaterInputStream.java:240)}}
> {{at 
> java.util.zip.InflaterInputStream.read(InflaterInputStream.java:158)}}
> {{at java.util.zip.ZipInputStream.read(ZipInputStream.java:194)}}
> {{at java.util.jar.JarInputStream.read(JarInputStream.java:207)}}
> {{}}
> {{It is probably due to not closing of JarOutputStream in the 
> AttachFeatureArchivesMojo}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (SLING-9253) Feature archive gives EOFException while reading

2020-03-24 Thread Carsten Ziegeler (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler updated SLING-9253:

Fix Version/s: slingfeature-maven-plugin 1.1.22

> Feature archive gives EOFException while reading
> 
>
> Key: SLING-9253
> URL: https://issues.apache.org/jira/browse/SLING-9253
> Project: Sling
>  Issue Type: Bug
>  Components: Maven Plugins and Archetypes
>Reporter: Nitin Gupta
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: slingfeature-maven-plugin 1.1.22
>
>
> {{[java.io|http://java.io/]}}{{.EOFException: Unexpected end of ZLIB input 
> stream}}
> {{at 
> java.util.zip.InflaterInputStream.fill(InflaterInputStream.java:240)}}
> {{at 
> java.util.zip.InflaterInputStream.read(InflaterInputStream.java:158)}}
> {{at java.util.zip.ZipInputStream.read(ZipInputStream.java:194)}}
> {{at java.util.jar.JarInputStream.read(JarInputStream.java:207)}}
> {{}}
> {{It is probably due to not closing of JarOutputStream in the 
> AttachFeatureArchivesMojo}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (SLING-9253) Feature archive gives EOFException while reading

2020-03-24 Thread Carsten Ziegeler (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler updated SLING-9253:

Component/s: Feature Model

> Feature archive gives EOFException while reading
> 
>
> Key: SLING-9253
> URL: https://issues.apache.org/jira/browse/SLING-9253
> Project: Sling
>  Issue Type: Bug
>  Components: Feature Model, Maven Plugins and Archetypes
>Affects Versions:  slingfeature-maven-plugin 1.1.20
>Reporter: Nitin Gupta
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: slingfeature-maven-plugin 1.1.22
>
>
> {{[java.io|http://java.io/]}}{{.EOFException: Unexpected end of ZLIB input 
> stream}}
> {{at 
> java.util.zip.InflaterInputStream.fill(InflaterInputStream.java:240)}}
> {{at 
> java.util.zip.InflaterInputStream.read(InflaterInputStream.java:158)}}
> {{at java.util.zip.ZipInputStream.read(ZipInputStream.java:194)}}
> {{at java.util.jar.JarInputStream.read(JarInputStream.java:207)}}
> {{}}
> {{It is probably due to not closing of JarOutputStream in the 
> AttachFeatureArchivesMojo}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (SLING-9253) Feature archive gives EOFException while reading

2020-03-24 Thread Carsten Ziegeler (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler updated SLING-9253:

Affects Version/s:  slingfeature-maven-plugin 1.1.20

> Feature archive gives EOFException while reading
> 
>
> Key: SLING-9253
> URL: https://issues.apache.org/jira/browse/SLING-9253
> Project: Sling
>  Issue Type: Bug
>  Components: Maven Plugins and Archetypes
>Affects Versions:  slingfeature-maven-plugin 1.1.20
>Reporter: Nitin Gupta
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: slingfeature-maven-plugin 1.1.22
>
>
> {{[java.io|http://java.io/]}}{{.EOFException: Unexpected end of ZLIB input 
> stream}}
> {{at 
> java.util.zip.InflaterInputStream.fill(InflaterInputStream.java:240)}}
> {{at 
> java.util.zip.InflaterInputStream.read(InflaterInputStream.java:158)}}
> {{at java.util.zip.ZipInputStream.read(ZipInputStream.java:194)}}
> {{at java.util.jar.JarInputStream.read(JarInputStream.java:207)}}
> {{}}
> {{It is probably due to not closing of JarOutputStream in the 
> AttachFeatureArchivesMojo}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (SLING-9171) Support for settings properties on paths created via repoinit create path

2020-03-24 Thread Bertrand Delacretaz (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-9171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17065932#comment-17065932
 ] 

Bertrand Delacretaz commented on SLING-9171:


Naming is hard...thank you [~jsedding], Nitin has made his contribution with 
set/default, I hope that works for you.

[~nitigupt] I have merged your parser PR, thank you very much! And made a few 
changes in the commits that follow it at 
https://github.com/apache/sling-org-apache-sling-repoinit-parser/ , in 
particular I moved the dates, types and values parsing logic to the 
{{PropertyLine}} class, I think it's easier to debug there than in the grammar 
itself. Sorry for hinting at the opposite structure earlier, but looking at it 
the grammar was becoming too complex for my taste.

I also fixed an inconsistency in the quoted strings, the start/end quotes were 
not removed for the general case.

Note that {{PropertyLine}} now returns a list of {{Object}} with specific types 
based on their set/default statements, you'll need to modify the JCR pull 
request for this but I think it's more consistent in this way.

Can you review my changes and see if they work for you? 

> Support for settings properties on paths created via repoinit create path
> -
>
> Key: SLING-9171
> URL: https://issues.apache.org/jira/browse/SLING-9171
> Project: Sling
>  Issue Type: Improvement
>  Components: Repoinit
>Reporter: Nitin Gupta
>Assignee: Bertrand Delacretaz
>Priority: Major
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> Apart from jcr:primaryType and mixin, there is a requirement to add custom 
> properties to the nodes valuemap via repoinit. This is a gap currently.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (SLING-9253) Feature archive gives EOFException while reading

2020-03-24 Thread Carsten Ziegeler (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-9253.
-
Resolution: Fixed

Fixed in 
https://github.com/apache/sling-slingfeature-maven-plugin/commit/dd75d365949713c92d68bb980bf62a2d3f26b571

> Feature archive gives EOFException while reading
> 
>
> Key: SLING-9253
> URL: https://issues.apache.org/jira/browse/SLING-9253
> Project: Sling
>  Issue Type: Bug
>  Components: Feature Model, Maven Plugins and Archetypes
>Affects Versions:  slingfeature-maven-plugin 1.1.20
>Reporter: Nitin Gupta
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: slingfeature-maven-plugin 1.1.22
>
>
> {{[java.io|http://java.io/]}}{{.EOFException: Unexpected end of ZLIB input 
> stream}}
> {{at 
> java.util.zip.InflaterInputStream.fill(InflaterInputStream.java:240)}}
> {{at 
> java.util.zip.InflaterInputStream.read(InflaterInputStream.java:158)}}
> {{at java.util.zip.ZipInputStream.read(ZipInputStream.java:194)}}
> {{at java.util.jar.JarInputStream.read(JarInputStream.java:207)}}
> {{}}
> {{It is probably due to not closing of JarOutputStream in the 
> AttachFeatureArchivesMojo}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (SLING-9171) Support for settings properties on paths created via repoinit create path

2020-03-24 Thread Nitin Gupta (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-9171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17066011#comment-17066011
 ] 

Nitin Gupta edited comment on SLING-9171 at 3/24/20, 5:31 PM:
--

Thanks [~bdelacretaz], agree that moving the parsing logic to PropertyLine 
helps in debugging and also simplifying the regex. Moreover, this has also 
enabled type validation for other types of values.

i was just wondering if we could use _javax.jcr.Value_ instead of _Object_ in 
_PropertyLine#getValues_ API to make the API more restrictive, but i guess, we 
would want to keep the APIs for repoinit parser independent of jcr in general, 
and that's why Object is more appropriate.

That being said, I'm all good with the changes. Thanks again for reviewing and 
improving this.


was (Author: nitigupt):
Thanks [~bdelacretaz], agree that moving the parsing logic to PropertyLine 
helps is debugging and also simplifying the regex. Moreover, this has also 
enabled type validation for other types of values.

i was just wondering if we could use _javax.jcr.Value_ instead of _Object_ in 
_PropertyLine#getValues_ API to make the API more restrictive, but i guess, we 
would want to keep the APIs for repoinit parser independent of jcr in general, 
and that's why Object is more appropriate.

That being said, I'm all good with the changes. Thanks again for reviewing and 
improving this.

> Support for settings properties on paths created via repoinit create path
> -
>
> Key: SLING-9171
> URL: https://issues.apache.org/jira/browse/SLING-9171
> Project: Sling
>  Issue Type: Improvement
>  Components: Repoinit
>Reporter: Nitin Gupta
>Assignee: Bertrand Delacretaz
>Priority: Major
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> Apart from jcr:primaryType and mixin, there is a requirement to add custom 
> properties to the nodes valuemap via repoinit. This is a gap currently.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (SLING-9171) Support for settings properties on paths created via repoinit create path

2020-03-24 Thread Nitin Gupta (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-9171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17066011#comment-17066011
 ] 

Nitin Gupta commented on SLING-9171:


Thanks [~bdelacretaz], agree that moving the parsing logic to PropertyLine 
helps is debugging and also simplifying the regex. Moreover, this has also 
enabled type validation for other types of values.

i was just wondering if we could use _javax.jcr.Value_ instead of _Object_ in 
_PropertyLine#getValues_ API to make the API more restrictive, but i guess, we 
would want to keep the APIs for repoinit parser independent of jcr in general, 
and that's why Object is more appropriate.

That being said, I'm all good with the changes. Thanks again for reviewing and 
improving this.

> Support for settings properties on paths created via repoinit create path
> -
>
> Key: SLING-9171
> URL: https://issues.apache.org/jira/browse/SLING-9171
> Project: Sling
>  Issue Type: Improvement
>  Components: Repoinit
>Reporter: Nitin Gupta
>Assignee: Bertrand Delacretaz
>Priority: Major
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> Apart from jcr:primaryType and mixin, there is a requirement to add custom 
> properties to the nodes valuemap via repoinit. This is a gap currently.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (SLING-9171) Support for settings properties on paths created via repoinit create path

2020-03-24 Thread Nitin Gupta (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-9171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17066082#comment-17066082
 ] 

Nitin Gupta commented on SLING-9171:


Incorporated the corresponding jcr-repoinit changes also at 
[https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/10]

Please review and merge, thanks !

> Support for settings properties on paths created via repoinit create path
> -
>
> Key: SLING-9171
> URL: https://issues.apache.org/jira/browse/SLING-9171
> Project: Sling
>  Issue Type: Improvement
>  Components: Repoinit
>Reporter: Nitin Gupta
>Assignee: Bertrand Delacretaz
>Priority: Major
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> Apart from jcr:primaryType and mixin, there is a requirement to add custom 
> properties to the nodes valuemap via repoinit. This is a gap currently.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (SLING-8953) CMS - Closing Search Issues

2020-03-24 Thread Dan Klco (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-8953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Klco closed SLING-8953.
---

> CMS - Closing Search Issues
> ---
>
> Key: SLING-8953
> URL: https://issues.apache.org/jira/browse/SLING-8953
> Project: Sling
>  Issue Type: Bug
>  Components: App CMS
>Affects Versions: App CMS 0.12.0, CMS 0.14.0
>Reporter: Dan Klco
>Assignee: Dan Klco
>Priority: Major
> Fix For: CMS 0.16.0
>
>
> There are two issues closing the search dialog:
>  * When closing from page properties, this also closes the page properties 
> dialog
>  * when closing without selecting a value from a component it just displays a 
> loader and does not reopen the editor



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (SLING-8871) CMS - Upload Click Handler Registered Multiple Times

2020-03-24 Thread Dan Klco (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-8871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Klco closed SLING-8871.
---

> CMS - Upload Click Handler Registered Multiple Times
> 
>
> Key: SLING-8871
> URL: https://issues.apache.org/jira/browse/SLING-8871
> Project: Sling
>  Issue Type: Bug
>Affects Versions: CMS 0.14.0
>Reporter: Dan Klco
>Assignee: Dan Klco
>Priority: Major
> Fix For: CMS 0.16.0
>
>
> When a user uploads a file and then closes the dialog and uploads another 
> file the click handler will register multiple times resulting in the UI 
> attempting to upload the same file multiple times. 
> This does not affect the drag and drop functionality.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (SLING-8947) CMS - Grid View Missing Fields

2020-03-24 Thread Dan Klco (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-8947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Klco closed SLING-8947.
---

> CMS - Grid View Missing Fields
> --
>
> Key: SLING-8947
> URL: https://issues.apache.org/jira/browse/SLING-8947
> Project: Sling
>  Issue Type: Bug
>Affects Versions: CMS 0.14.0
>Reporter: Dan Klco
>Assignee: Dan Klco
>Priority: Major
> Fix For: CMS 0.16.0
>
>
> Currently the table view shows data which is not visible on the grid view. We 
> should add the:
>  
>  * Title
>  * Modified date
>  * Publish status



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (SLING-8872) CMS - Fails to Extract JPEG Metadata

2020-03-24 Thread Dan Klco (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-8872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Klco closed SLING-8872.
---

> CMS - Fails to Extract JPEG Metadata
> 
>
> Key: SLING-8872
> URL: https://issues.apache.org/jira/browse/SLING-8872
> Project: Sling
>  Issue Type: Bug
>Affects Versions: CMS 0.14.0
>Reporter: Dan Klco
>Assignee: Dan Klco
>Priority: Major
> Fix For: CMS 0.16.0
>
>
> The File Metadata Extractor fails to extract the metadata of JPEG files due 
> to the errors described here:
> https://issues.apache.org/jira/browse/TIKA-2987
> The fix is to:
>  * Update to Tika 1.22
>  * Remove the Tika Parsers to avoid conflicting imports



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (SLING-8930) CMS - i18n Not Reloading

2020-03-24 Thread Dan Klco (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Klco closed SLING-8930.
---

> CMS - i18n Not Reloading
> 
>
> Key: SLING-8930
> URL: https://issues.apache.org/jira/browse/SLING-8930
> Project: Sling
>  Issue Type: Bug
>  Components: App CMS
>Affects Versions: CMS 0.14.0
>Reporter: Dan Klco
>Assignee: Dan Klco
>Priority: Major
> Fix For: CMS 0.16.0
>
>
> When adding a new entry to the i18n editor, the editor does not display a 
> value until the page is refreshed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (SLING-8956) Archetype Token Replacement Issues

2020-03-24 Thread Dan Klco (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-8956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Klco closed SLING-8956.
---

> Archetype Token Replacement Issues
> --
>
> Key: SLING-8956
> URL: https://issues.apache.org/jira/browse/SLING-8956
> Project: Sling
>  Issue Type: Bug
>  Components: App CMS
>Affects Versions: CMS 0.14.0
>Reporter: Dan Klco
>Assignee: Dan Klco
>Priority: Major
> Fix For: CMS 0.16.0
>
>
> The Sling CMS Archetype fails to replace tokens in the readme and page.json 
> and does not handle the path correctly in the java code.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (SLING-9156) CMS - Add Thumbnail to Search

2020-03-24 Thread Dan Klco (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Klco closed SLING-9156.
---

> CMS - Add Thumbnail to Search
> -
>
> Key: SLING-9156
> URL: https://issues.apache.org/jira/browse/SLING-9156
> Project: Sling
>  Issue Type: Improvement
>  Components: App CMS
>Affects Versions: CMS 0.14.0
>Reporter: Dan Klco
>Assignee: Dan Klco
>Priority: Minor
> Fix For: CMS 0.16.0
>
>
> The search feature should display thumbnails for files to give users a visual 
> indicator of what is being selected.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (SLING-9152) CMS Reference - Use Commons Messaging Mail

2020-03-24 Thread Dan Klco (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Klco closed SLING-9152.
---

> CMS Reference - Use Commons Messaging Mail
> --
>
> Key: SLING-9152
> URL: https://issues.apache.org/jira/browse/SLING-9152
> Project: Sling
>  Issue Type: Improvement
>  Components: App CMS Reference
>Affects Versions: CMS 0.14.0
>Reporter: Dan Klco
>Assignee: Dan Klco
>Priority: Minor
> Fix For: CMS 0.16.0
>
>
> Instead of rolling an email client, leverage the Commons Messaging Mail 1.0.0 
> client.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (SLING-9226) CMS - Move Fails with Same Name Resources

2020-03-24 Thread Dan Klco (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Klco closed SLING-9226.
---

> CMS - Move Fails with Same Name Resources
> -
>
> Key: SLING-9226
> URL: https://issues.apache.org/jira/browse/SLING-9226
> Project: Sling
>  Issue Type: Bug
>  Components: App CMS
>Affects Versions: CMS 0.14.0
>Reporter: Dan Klco
>Assignee: Dan Klco
>Priority: Minor
> Fix For: CMS 0.16.0
>
>
> When moving a resource to another container, if the container already 
> contains a resource with the same name, the move operation fails. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (SLING-9001) CMS - Cannot Create Page without Template Policy

2020-03-24 Thread Dan Klco (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Klco closed SLING-9001.
---

> CMS - Cannot Create Page without Template Policy
> 
>
> Key: SLING-9001
> URL: https://issues.apache.org/jira/browse/SLING-9001
> Project: Sling
>  Issue Type: Bug
>  Components: App CMS
>Affects Versions: CMS 0.14.0
>Reporter: Dan Klco
>Assignee: Dan Klco
>Priority: Minor
> Fix For: CMS 0.16.0
>
>
> Template policies are required in the page template model so pages cannot be 
> created from a template where the policy is not set, even if the template 
> does not truly need a policy.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (SLING-8957) Tika Fallback Provider Fails on Large Files

2020-03-24 Thread Dan Klco (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-8957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Klco closed SLING-8957.
---

> Tika Fallback Provider Fails on Large Files
> ---
>
> Key: SLING-8957
> URL: https://issues.apache.org/jira/browse/SLING-8957
> Project: Sling
>  Issue Type: Bug
>  Components: App CMS
>Affects Versions: CMS 0.14.0
>Reporter: Dan Klco
>Assignee: Dan Klco
>Priority: Major
> Fix For: CMS 0.16.0
>
>
> Tika Fallback Provider Fails on Large(ish) Files



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (SLING-9225) CMS - Add JCR Cleanup Schedulers

2020-03-24 Thread Dan Klco (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Klco closed SLING-9225.
---

> CMS - Add JCR Cleanup Schedulers
> 
>
> Key: SLING-9225
> URL: https://issues.apache.org/jira/browse/SLING-9225
> Project: Sling
>  Issue Type: Improvement
>  Components: App CMS
>Affects Versions: CMS 0.14.0
>Reporter: Dan Klco
>Assignee: Dan Klco
>Priority: Major
> Fix For: CMS 0.16.0
>
>
> Currently, the Sling CMS repository does not perform any automated cleanup 
> including the Segment or Data Store. 
> The application should include schedulers to perform Jackrabbit Oak 
> Repository cleanup activities as provided in the Repository Manager MBean. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (SLING-8952) CMS - Use Bulma Tags Instead of Buttons for Labelfield

2020-03-24 Thread Dan Klco (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-8952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Klco closed SLING-8952.
---

> CMS - Use Bulma Tags Instead of Buttons for Labelfield
> --
>
> Key: SLING-8952
> URL: https://issues.apache.org/jira/browse/SLING-8952
> Project: Sling
>  Issue Type: Improvement
>  Components: App CMS
>Reporter: Dan Klco
>Assignee: Dan Klco
>Priority: Minor
> Fix For: CMS 0.16.0
>
>
> Currently, the taxonomy, members and membership fields use bulma buttons 
> instead of tags, tags provide a clearer and better UX. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (SLING-8958) Return Default Thumbnail on Error

2020-03-24 Thread Dan Klco (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-8958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Klco closed SLING-8958.
---

> Return Default Thumbnail on Error
> -
>
> Key: SLING-8958
> URL: https://issues.apache.org/jira/browse/SLING-8958
> Project: Sling
>  Issue Type: Improvement
>  Components: App CMS
>Affects Versions: CMS 0.14.0
>Reporter: Dan Klco
>Assignee: Dan Klco
>Priority: Major
> Fix For: CMS 0.16.0
>
>
> When the transformer fails to transform a file it would be friendlier to 
> return a default thumbnail than an error



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (SLING-8917) CMS - Add Support for LDAP

2020-03-24 Thread Dan Klco (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-8917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Klco closed SLING-8917.
---

> CMS - Add Support for LDAP
> --
>
> Key: SLING-8917
> URL: https://issues.apache.org/jira/browse/SLING-8917
> Project: Sling
>  Issue Type: Improvement
>  Components: App CMS
>Reporter: Dan Klco
>Assignee: Dan Klco
>Priority: Minor
>  Labels: backlog
> Fix For: CMS 0.16.0
>
>
> Look into adding LDAP support via OAK LDAP: 
> [https://jackrabbit.apache.org/oak/docs/security/authentication/ldap.html]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (SLING-9000) CMS - Reload Fails When Editing Component

2020-03-24 Thread Dan Klco (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Klco closed SLING-9000.
---

> CMS - Reload Fails When Editing Component
> -
>
> Key: SLING-9000
> URL: https://issues.apache.org/jira/browse/SLING-9000
> Project: Sling
>  Issue Type: Bug
>  Components: App CMS
>Affects Versions: CMS 0.14.0
>Reporter: Dan Klco
>Assignee: Dan Klco
>Priority: Major
> Fix For: CMS 0.16.0
>
>
> Reload Fails When Component Embedded Directly in Page Component due to a 
> JavaScript error:
> editor.min.js:17 Uncaught TypeError: Cannot read property 'dataset' of null
>  at Object.reloadComponent (editor.min.js:17)
>  at scripts-all.min.js:72
>  at HTMLButtonElement. (scripts-all.min.js:72)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


CVE-2020-1949: Apache Sling CMS Reflected XSS Vulnerability

2020-03-24 Thread Daniel Klco
Severity: Medium

Vendor:
The Apache Software Foundation

Versions Affected:
Sling CMS 0.14.0 and previous releases

Description:
Scripts in Sling CMS do not property escape the Sling Selector from URLs
when generating navigational elements for the administrative consoles and
are vulnerable to reflected XSS attacks.

Mitigation:
All users should upgrade to 0.16.0

Credit:
This issue was discovered by Guillaume GRABÉ Pentester from Orange
Cyberdefense France

References:
https://sling.apache.org/project-information/security.html