[GitHub] thrift pull request: THRIFT-3408: correct emitted JSON types

[aughr]

GitHub user aughr opened a pull request:

https://github.com/apache/thrift/pull/679

THRIFT-3408: correct emitted JSON types

https://issues.apache.org/jira/browse/THRIFT-3408

Currently this has no tests associated with it because the JSON generator 
itself appears untested. No wonder there was this regression.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/aughr/thrift THRIFT-3408

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/679.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #679


commit 69cbfef16dc7e55d9086778779e4b591d019b2b2
Author: Andrew Bloomgarden 
Date:   2015-11-03T15:19:14Z

THRIFT-3408: correct emitted JSON types




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (THRIFT-3408) JSON generator emits incorrect types

[Andrew Bloomgarden (JIRA)]

Andrew Bloomgarden created THRIFT-3408:
--

 Summary: JSON generator emits incorrect types
 Key: THRIFT-3408
 URL: https://issues.apache.org/jira/browse/THRIFT-3408
 Project: Thrift
  Issue Type: Bug
  Components: JSON - Compiler
Affects Versions: 0.9.3
Reporter: Andrew Bloomgarden
Priority: Minor


This change makes all base types emit "binary" as their type in the JSON 
generator:

https://github.com/apache/thrift/commit/8dbe5f60a7c1401302e10aec41069f9c385d34a1#diff-e6c383fcc2ee5e64083db96846727639




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] thrift pull request: THRIFT-338 Compact Protocol in Erlang

[nsuke]

Github user nsuke commented on the pull request:

https://github.com/apache/thrift/pull/675#issuecomment-153348137
  
b31f0900b57b7473a8f84c7b74f73381dcff2818


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-338 Compact Protocol in Erlang

[nsuke]

Github user nsuke closed the pull request at:

https://github.com/apache/thrift/pull/675


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-3274 calling "make clean" twice in a r...

[nsuke]

GitHub user nsuke opened a pull request:

https://github.com/apache/thrift/pull/676

THRIFT-3274 calling "make clean" twice in a row yields make error

Removing `gen-cpp/.deps` hidden directory broke the source tree where any 
subsequent make command failed.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nsuke/thrift THRIFT-3274

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/676.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #676


commit 10b30a03a9011560c1617b44a9ebf4ba86f38e14
Author: Nobuaki Sukegawa 
Date:   2015-11-03T04:42:00Z

THRIFT-3274 calling "make clean" twice in a row yields make error




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (THRIFT-3274) calling "make clean" twice in a row yields make error

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-3274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14987252#comment-14987252
 ] 

ASF GitHub Bot commented on THRIFT-3274:


GitHub user nsuke opened a pull request:

https://github.com/apache/thrift/pull/676

THRIFT-3274 calling "make clean" twice in a row yields make error

Removing `gen-cpp/.deps` hidden directory broke the source tree where any 
subsequent make command failed.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nsuke/thrift THRIFT-3274

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/676.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #676


commit 10b30a03a9011560c1617b44a9ebf4ba86f38e14
Author: Nobuaki Sukegawa 
Date:   2015-11-03T04:42:00Z

THRIFT-3274 calling "make clean" twice in a row yields make error




> calling "make clean" twice in a row yields make error
> -
>
> Key: THRIFT-3274
> URL: https://issues.apache.org/jira/browse/THRIFT-3274
> Project: Thrift
>  Issue Type: Bug
>  Components: C++ - Library
>Reporter: Jens Geyer
>Priority: Minor
>
> After calling {{make clean}} by accident twice in a row I got this:
> {code}
> Making clean in test
> make[3]: Entering directory '/home/jens/Arbeitsfläche/Thrift/lib/cpp/test'
> Makefile:1173: gen-cpp/.deps/ChildService.Plo: File or directory not found
> Makefile:1174: gen-cpp/.deps/DebugProtoTest_types.Plo: File or directory not 
> found
> Makefile:1175: gen-cpp/.deps/EmptyService.Plo: File or directory not found
> Makefile:1176: gen-cpp/.deps/EnumTest_types.Plo: File or directory not found
> Makefile:1177: gen-cpp/.deps/OptionalRequiredTest_types.Plo: File or 
> directory not found
> Makefile:1178: gen-cpp/.deps/ParentService.Plo: File or directory not found
> Makefile:1179: gen-cpp/.deps/Recursive_types.Plo: File or directory not found
> Makefile:1180: gen-cpp/.deps/ThriftTest_constants.Plo: File or directory not 
> found
> Makefile:1181: gen-cpp/.deps/ThriftTest_types.Plo: File or directory not found
> Makefile:1182: gen-cpp/.deps/TypedefTest_types.Plo: File or directory not 
> found
> Makefile:1183: gen-cpp/.deps/proc_types.Plo: File or directory not found
> make[3]: *** No rule to make target 'gen-cpp/.deps/proc_types.Plo'.  Stop.
> make[3]: Leaving directory '/home/jens/Arbeitsfläche/Thrift/lib/cpp/test'
> Makefile:1578: recipe for target 'clean-recursive' failed
> make[2]: *** [clean-recursive] Error 1
> make[2]: Leaving directory '/home/jens/Arbeitsfläche/Thrift/lib/cpp'
> Makefile:536: recipe for target 'clean-recursive' failed
> make[1]: *** [clean-recursive] Error 1
> make[1]: Leaving directory '/home/jens/Arbeitsfläche/Thrift/lib'
> Makefile:601: recipe for target 'clean-recursive' failed
> make: *** [clean-recursive] Error 1
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] thrift pull request: THRIFT-2423: Facebook's THeader protocol and ...

[bufferoverflow]

Github user bufferoverflow commented on the pull request:

https://github.com/apache/thrift/pull/357#issuecomment-153325696
  
@nsuke Yes, please do so.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Resolved] (THRIFT-338) Compact Protocol in Erlang

[Aki Sukegawa (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aki Sukegawa resolved THRIFT-338.
-
Resolution: Fixed

committed

> Compact Protocol in Erlang
> --
>
> Key: THRIFT-338
> URL: https://issues.apache.org/jira/browse/THRIFT-338
> Project: Thrift
>  Issue Type: Sub-task
>Reporter: Todd Lipcon
>Assignee: Aki Sukegawa
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (THRIFT-338) Compact Protocol in Erlang

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14987241#comment-14987241
 ] 

ASF GitHub Bot commented on THRIFT-338:
---

Github user nsuke closed the pull request at:

https://github.com/apache/thrift/pull/675


> Compact Protocol in Erlang
> --
>
> Key: THRIFT-338
> URL: https://issues.apache.org/jira/browse/THRIFT-338
> Project: Thrift
>  Issue Type: Sub-task
>Reporter: Todd Lipcon
>Assignee: Aki Sukegawa
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (THRIFT-338) Compact Protocol in Erlang

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14987240#comment-14987240
 ] 

ASF GitHub Bot commented on THRIFT-338:
---

Github user nsuke commented on the pull request:

https://github.com/apache/thrift/pull/675#issuecomment-153348137
  
b31f0900b57b7473a8f84c7b74f73381dcff2818


> Compact Protocol in Erlang
> --
>
> Key: THRIFT-338
> URL: https://issues.apache.org/jira/browse/THRIFT-338
> Project: Thrift
>  Issue Type: Sub-task
>Reporter: Todd Lipcon
>Assignee: Aki Sukegawa
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (THRIFT-2423) THeader

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-2423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14987124#comment-14987124
 ] 

ASF GitHub Bot commented on THRIFT-2423:


Github user bufferoverflow commented on the pull request:

https://github.com/apache/thrift/pull/357#issuecomment-153325696
  
@nsuke Yes, please do so.


> THeader
> ---
>
> Key: THRIFT-2423
> URL: https://issues.apache.org/jira/browse/THRIFT-2423
> Project: Thrift
>  Issue Type: Sub-task
>  Components: Build Process, C++ - Compiler, C++ - Library, Test Suite
>Reporter: Roger Meier
> Fix For: 1.0
>
>
> THeader seems to be a nice feature.
> Is there some documentation available?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (THRIFT-3408) JSON generator emits incorrect types

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-3408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14987449#comment-14987449
 ] 

ASF GitHub Bot commented on THRIFT-3408:


GitHub user aughr opened a pull request:

https://github.com/apache/thrift/pull/679

THRIFT-3408: correct emitted JSON types

https://issues.apache.org/jira/browse/THRIFT-3408

Currently this has no tests associated with it because the JSON generator 
itself appears untested. No wonder there was this regression.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/aughr/thrift THRIFT-3408

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/679.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #679


commit 69cbfef16dc7e55d9086778779e4b591d019b2b2
Author: Andrew Bloomgarden 
Date:   2015-11-03T15:19:14Z

THRIFT-3408: correct emitted JSON types




> JSON generator emits incorrect types
> 
>
> Key: THRIFT-3408
> URL: https://issues.apache.org/jira/browse/THRIFT-3408
> Project: Thrift
>  Issue Type: Bug
>  Components: JSON - Compiler
>Affects Versions: 0.9.3
>Reporter: Andrew Bloomgarden
>Priority: Minor
>
> This change makes all base types emit "binary" as their type in the JSON 
> generator:
> https://github.com/apache/thrift/commit/8dbe5f60a7c1401302e10aec41069f9c385d34a1#diff-e6c383fcc2ee5e64083db96846727639



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] thrift pull request: Thrift 1857 redux 2

[nsuke]

GitHub user nsuke opened a pull request:

https://github.com/apache/thrift/pull/680

Thrift 1857 redux 2

Rational:
* No TType.UTF8 (don't break cross-lang compatibility)
* No six.BufferIO (don't break fastbinary)
* Don't make py2 read/writeString UTF8 (don't break backward API 
compatibility)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nsuke/thrift THRIFT-1857-redux-2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/680.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #680


commit d516da27b8f329e0827219bd47da02356b2eef92
Author: Thomas Bartelmess 
Date:   2014-04-30T20:21:05Z

Python 3 support

Added six to install_requires in setup.py

commit d3d1e4e2e43823c07c5000882a3e1d63935b124d
Author: Eevee (Alex Munroe) 
Date:   2014-08-19T23:07:36Z

Fix useless warnings about a broken C extension on 3.x, PyPy, etc.

Also remove use_2to3, since this is supposed to be single-codebase now.

commit 3d755dbabe880edca4b5e306f53d00fd03998406
Author: Eevee (Alex Munroe) 
Date:   2014-08-19T23:12:16Z

Fix a few minor nitpicks with the Python 3 fixes.

commit 6295a64a0fe9b489fa49e03068ffbb4b079e1872
Author: Eevee (Alex Munroe) 
Date:   2014-08-19T23:28:07Z

JSONProtocol's constants need to be bytestrings.

commit 4eee7c76a03d97c3e8f5b6355236b6131ad2182f
Author: Eevee (Alex Munroe) 
Date:   2014-08-19T23:28:55Z

Use print_function in the Python tests.

commit c646c9360995b659e913df94cc6d7a2a5db858e8
Author: Eevee (Alex Munroe) 
Date:   2014-08-19T23:29:09Z

Unbreak the Python tests when the C extension doesn't exist.

If there's no C part, everything gets built into `build/lib/`, but the
shell globs were looking for a dot.

commit ae60057e6adc233ffda2b515760ebea477947891
Author: Eevee (Alex Munroe) 
Date:   2014-08-19T23:30:06Z

Trailing whitespace my editor fixed for me.

commit 67aab994e7f41e23373c08e3853d790700010651
Author: Eevee (Alex Munroe) 
Date:   2014-08-20T02:53:07Z

Probably don't need this 2.4 compat any more.

commit a679eec6f4b11e3373e5b55e192fce36f613136b
Author: Eevee (Alex Munroe) 
Date:   2014-08-20T02:53:20Z

Stop generating code that contains xrange and iteritems.

commit 4a45fe5904be3e6d9df9c3be9c2d67421e2226ac
Author: Eevee (Alex Munroe) 
Date:   2014-08-20T02:53:50Z

Make JSON and compact protocols use bytes everywhere.

commit f692770e967debb149b0ae18e9fce72230e17272
Author: Eevee (Alex Munroe) 
Date:   2014-08-20T02:54:31Z

Python 3 support in test/py/.

commit 774fc7884d938c57887a5b1ea8839212c1c5ee94
Author: Eevee (Alex Munroe) 
Date:   2014-08-20T02:54:44Z

Miscellaneous module moves and text/bytes stuff that was missed.

commit d0a36c1c587c2ca7261dd51b8036d1bf516868b7
Author: Eevee (Alex Munroe) 
Date:   2014-08-20T03:14:21Z

Fix more sys.path.insert glob shenanigans.

commit 19bd44462ae29cc527c1e6e9fe9540e35bd22d9d
Author: Eevee (Alex Munroe) 
Date:   2014-08-20T03:43:51Z

Fix a bad relativized import.

commit 99cc4360fcdc8ee4ca81c4f62c9b972a2096778d
Author: Eevee (Alex Munroe) 
Date:   2014-08-20T03:46:13Z

Run 2to3 on the Python tutorial code.

commit b05fdd2d8b0350a3a1c65be96fff14123911eaa1
Author: Eevee (Alex Munroe) 
Date:   2014-08-20T04:08:50Z

Don't compile to itervalues, either.

commit 5aaa2bb707a1a8fee12ea8e74db9dcaaf0fc1ed7
Author: Eevee (Alex Munroe) 
Date:   2014-08-20T04:09:06Z

Fix passing a float to struct.pack() -- tolerated in 2, not 3.

commit 1bc93b53ec92d2f9e968a370581a411ddde9551a
Author: Eevee (Alex Munroe) 
Date:   2014-09-11T22:42:50Z

And one more round of fixing JSON decoding.

commit 8d54badced75eb1913820b296922f011d9753334
Author: helgridly 
Date:   2015-03-19T20:09:04Z

Restored some logging objects that got stomped on during the rebase

commit 586505ea40709cb32130d6313d1307162c3fcaeb
Author: helgridly 
Date:   2015-03-19T21:40:52Z

Replaced cStringIO with six.BytesIO

commit e6ecc28242166324694cd7526f40a46aa34769d5
Author: Nobuaki Sukegawa 
Date:   2015-11-03T12:32:41Z

Fix compilation

commit 29d8b73dd1009ec9e1b3c4afc69b4a2663f87efc
Author: Nobuaki Sukegawa 
Date:   2015-11-03T12:32:47Z

Fix fastbinary for py2, read/writeString for py2 and py3

commit 93bdbde1d15320773cd44b788046548f1cd1f3fc
Author: Nobuaki 

[jira] [Assigned] (THRIFT-3200) JS and nodejs do not encode JSON protocol binary fields as base64

[Aki Sukegawa (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-3200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aki Sukegawa reassigned THRIFT-3200:


Assignee: Aki Sukegawa

> JS and nodejs do not encode JSON protocol binary fields as base64
> -
>
> Key: THRIFT-3200
> URL: https://issues.apache.org/jira/browse/THRIFT-3200
> Project: Thrift
>  Issue Type: Bug
>  Components: JavaScript - Library, Node.js - Library
>Affects Versions: 0.9.2
>Reporter: Adam Beberg
>Assignee: Aki Sukegawa
> Fix For: 1.0
>
>
> Binary fields in the JSON protocol are base64 encoded in 
> cpp/go/java/rb/py/go/... All code with JSON implementations except javascript 
> and nodejs - which escape them as if they as strings (unfinished 
> implementation). This makes js/nodejs incompatable with any other languages 
> since JSON is their only supported protocol. To fix this js/nodejs need to be 
> corrected, but this will break backward compatibility.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] thrift pull request: Thrift-1857: Python 3 support, redux

[nsuke]

Github user nsuke commented on the pull request:

https://github.com/apache/thrift/pull/213#issuecomment-153393441
  
I did some research on this.
TType.UTF8 was added years ago but currently not used by any language.
So using this now will result in incompatibility against any other 
implementation.

I rebased @c4urself 's rebase and fixed both fastbinary (py2) and 
string/binary (py2 & py3) issues : #680


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Assigned] (THRIFT-3350) Python JSON protocol does not encode binary as Base64

[Aki Sukegawa (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-3350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aki Sukegawa reassigned THRIFT-3350:


Assignee: Aki Sukegawa

> Python JSON protocol does not encode binary as Base64
> -
>
> Key: THRIFT-3350
> URL: https://issues.apache.org/jira/browse/THRIFT-3350
> Project: Thrift
>  Issue Type: Bug
>  Components: Python - Compiler, Python - Library
>Reporter: Aki Sukegawa
>Assignee: Aki Sukegawa
>
> According to THRIFT-3200 discussion, python JSON protocol is supposed to be 
> using Base64 encoding but it doesn't.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (THRIFT-2423) THeader

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-2423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14987606#comment-14987606
 ] 

Hudson commented on THRIFT-2423:


SUCCESS: Integrated in Thrift #1708 (See 
[https://builds.apache.org/job/Thrift/1708/])
THRIFT-2423 Facebook's THeader protocol and transport for cpp Client: (nsuke: 
rev 792db4e92607a38a45eeb57f9561210cd4d4ef73)
* lib/cpp/src/thrift/transport/THeaderTransport.cpp
* lib/c_glib/test/CMakeLists.txt
* test/cpp/src/TestServer.cpp
* test/cpp/CMakeLists.txt
* lib/cpp/src/thrift/server/TNonblockingServer.cpp
* lib/cpp/src/thrift/transport/TBufferTransports.h
* lib/cpp/src/thrift/protocol/TProtocol.h
* lib/cpp/src/thrift/transport/THeaderTransport.h
* lib/cpp/src/thrift/protocol/THeaderProtocol.h
* lib/cpp/src/thrift/protocol/THeaderProtocol.cpp
* doc/specs/HeaderFormat.md
* lib/cpp/Makefile.am
* lib/cpp/test/CMakeLists.txt
* lib/cpp/src/thrift/server/TNonblockingServer.h
* test/cpp/src/TestClient.cpp
* test/cpp/Makefile.am
* test/tests.json
* test/known_failures_Linux.json
* lib/cpp/src/thrift/protocol/TProtocolTypes.h
* lib/cpp/src/thrift/protocol/TBinaryProtocol.h
* lib/cpp/CMakeLists.txt
* tutorial/cpp/CMakeLists.txt
* lib/cpp/src/thrift/server/TServerFramework.cpp


> THeader
> ---
>
> Key: THRIFT-2423
> URL: https://issues.apache.org/jira/browse/THRIFT-2423
> Project: Thrift
>  Issue Type: Sub-task
>  Components: Build Process, C++ - Compiler, C++ - Library, Test Suite
>Reporter: Roger Meier
>Assignee: Dave Watson
> Fix For: 1.0
>
>
> THeader seems to be a nice feature.
> Is there some documentation available?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] thrift pull request: THRIFT-3182: Close transport after reading an...

[marshalium]

Github user marshalium commented on the pull request:

https://github.com/apache/thrift/pull/512#issuecomment-153496623
  
Hey @jfarrell. Are things better with CI now? Should I rebase off of master 
and try again? Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (THRIFT-3182) TFramedTransport is in an invalid state after frame size exception

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-3182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14988175#comment-14988175
 ] 

ASF GitHub Bot commented on THRIFT-3182:


Github user marshalium commented on the pull request:

https://github.com/apache/thrift/pull/512#issuecomment-153496623
  
Hey @jfarrell. Are things better with CI now? Should I rebase off of master 
and try again? Thanks!


> TFramedTransport is in an invalid state after frame size exception
> --
>
> Key: THRIFT-3182
> URL: https://issues.apache.org/jira/browse/THRIFT-3182
> Project: Thrift
>  Issue Type: Bug
>  Components: Java - Library
>Affects Versions: 0.9.2
>Reporter: Marshall Scorcio
>
> https://github.com/apache/thrift/pull/512
> This is necessary because after reading the invalid
> frame size from the underlying transport the transport
> is left in a bad state. Any following reads will
> likely throw more invalid frame size exceptions and
> if they don’t they will be reading corrupted messages.
> Closing forces the caller to discard the connection and
> get a new one.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] thrift pull request: Allow context to be passed into NewTHttpPostC...

[i]

GitHub user i opened a pull request:

https://github.com/apache/thrift/pull/682

Allow context to be passed into NewTHttpPostClient

This provides a way to cancel outgoing requests which this library doesn't
currently support.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/uber/thrift ctxhttp

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/682.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #682


commit 305a37965ecffdc5d36ed135c0cd6bb63c00808c
Author: Ian Lozinski 
Date:   2015-11-03T23:11:07Z

Allow context to be passed into NewTHttpPostClient

This provides a way to cancel outgoing requests which this library doesn't
currently support.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Resolved] (THRIFT-3274) calling "make clean" twice in a row yields make error

[Roger Meier (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-3274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Roger Meier resolved THRIFT-3274.
-
Resolution: Fixed

tutorial fix is committed

> calling "make clean" twice in a row yields make error
> -
>
> Key: THRIFT-3274
> URL: https://issues.apache.org/jira/browse/THRIFT-3274
> Project: Thrift
>  Issue Type: Bug
>  Components: C++ - Library
>Reporter: Jens Geyer
>Assignee: Aki Sukegawa
>Priority: Minor
>
> After calling {{make clean}} by accident twice in a row I got this:
> {code}
> Making clean in test
> make[3]: Entering directory '/home/jens/Arbeitsfläche/Thrift/lib/cpp/test'
> Makefile:1173: gen-cpp/.deps/ChildService.Plo: File or directory not found
> Makefile:1174: gen-cpp/.deps/DebugProtoTest_types.Plo: File or directory not 
> found
> Makefile:1175: gen-cpp/.deps/EmptyService.Plo: File or directory not found
> Makefile:1176: gen-cpp/.deps/EnumTest_types.Plo: File or directory not found
> Makefile:1177: gen-cpp/.deps/OptionalRequiredTest_types.Plo: File or 
> directory not found
> Makefile:1178: gen-cpp/.deps/ParentService.Plo: File or directory not found
> Makefile:1179: gen-cpp/.deps/Recursive_types.Plo: File or directory not found
> Makefile:1180: gen-cpp/.deps/ThriftTest_constants.Plo: File or directory not 
> found
> Makefile:1181: gen-cpp/.deps/ThriftTest_types.Plo: File or directory not found
> Makefile:1182: gen-cpp/.deps/TypedefTest_types.Plo: File or directory not 
> found
> Makefile:1183: gen-cpp/.deps/proc_types.Plo: File or directory not found
> make[3]: *** No rule to make target 'gen-cpp/.deps/proc_types.Plo'.  Stop.
> make[3]: Leaving directory '/home/jens/Arbeitsfläche/Thrift/lib/cpp/test'
> Makefile:1578: recipe for target 'clean-recursive' failed
> make[2]: *** [clean-recursive] Error 1
> make[2]: Leaving directory '/home/jens/Arbeitsfläche/Thrift/lib/cpp'
> Makefile:536: recipe for target 'clean-recursive' failed
> make[1]: *** [clean-recursive] Error 1
> make[1]: Leaving directory '/home/jens/Arbeitsfläche/Thrift/lib'
> Makefile:601: recipe for target 'clean-recursive' failed
> make: *** [clean-recursive] Error 1
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (THRIFT-3274) calling "make clean" twice in a row yields make error

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-3274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14988407#comment-14988407
 ] 

Hudson commented on THRIFT-3274:


SUCCESS: Integrated in Thrift #1710 (See 
[https://builds.apache.org/job/Thrift/1710/])
THRIFT-3274 calling "make clean" twice in a row yields make error (roger: rev 
f57b57ac0b5e890d7d8ebb75610e7fe279833909)
* tutorial/cpp/Makefile.am


> calling "make clean" twice in a row yields make error
> -
>
> Key: THRIFT-3274
> URL: https://issues.apache.org/jira/browse/THRIFT-3274
> Project: Thrift
>  Issue Type: Bug
>  Components: C++ - Library
>Reporter: Jens Geyer
>Assignee: Aki Sukegawa
>Priority: Minor
>
> After calling {{make clean}} by accident twice in a row I got this:
> {code}
> Making clean in test
> make[3]: Entering directory '/home/jens/Arbeitsfläche/Thrift/lib/cpp/test'
> Makefile:1173: gen-cpp/.deps/ChildService.Plo: File or directory not found
> Makefile:1174: gen-cpp/.deps/DebugProtoTest_types.Plo: File or directory not 
> found
> Makefile:1175: gen-cpp/.deps/EmptyService.Plo: File or directory not found
> Makefile:1176: gen-cpp/.deps/EnumTest_types.Plo: File or directory not found
> Makefile:1177: gen-cpp/.deps/OptionalRequiredTest_types.Plo: File or 
> directory not found
> Makefile:1178: gen-cpp/.deps/ParentService.Plo: File or directory not found
> Makefile:1179: gen-cpp/.deps/Recursive_types.Plo: File or directory not found
> Makefile:1180: gen-cpp/.deps/ThriftTest_constants.Plo: File or directory not 
> found
> Makefile:1181: gen-cpp/.deps/ThriftTest_types.Plo: File or directory not found
> Makefile:1182: gen-cpp/.deps/TypedefTest_types.Plo: File or directory not 
> found
> Makefile:1183: gen-cpp/.deps/proc_types.Plo: File or directory not found
> make[3]: *** No rule to make target 'gen-cpp/.deps/proc_types.Plo'.  Stop.
> make[3]: Leaving directory '/home/jens/Arbeitsfläche/Thrift/lib/cpp/test'
> Makefile:1578: recipe for target 'clean-recursive' failed
> make[2]: *** [clean-recursive] Error 1
> make[2]: Leaving directory '/home/jens/Arbeitsfläche/Thrift/lib/cpp'
> Makefile:536: recipe for target 'clean-recursive' failed
> make[1]: *** [clean-recursive] Error 1
> make[1]: Leaving directory '/home/jens/Arbeitsfläche/Thrift/lib'
> Makefile:601: recipe for target 'clean-recursive' failed
> make: *** [clean-recursive] Error 1
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (THRIFT-3274) calling "make clean" twice in a row yields make error

[Jens Geyer (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-3274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14988017#comment-14988017
 ] 

Jens Geyer commented on THRIFT-3274:


Better, but not perfect. The tutorial seems to suffer from the same problems:

{code}
Making clean in cpp
make[2]: Entering directory '/home/jens/Arbeitsfläche/Thrift/tutorial/cpp'
Makefile:621: gen-cpp/.deps/Calculator.Plo: Datei oder Verzeichnis nicht 
gefunden
Makefile:622: gen-cpp/.deps/SharedService.Plo: Datei oder Verzeichnis nicht 
gefunden
Makefile:623: gen-cpp/.deps/shared_constants.Plo: Datei oder Verzeichnis nicht 
gefunden
Makefile:624: gen-cpp/.deps/shared_types.Plo: Datei oder Verzeichnis nicht 
gefunden
Makefile:625: gen-cpp/.deps/tutorial_constants.Plo: Datei oder Verzeichnis 
nicht gefunden
Makefile:626: gen-cpp/.deps/tutorial_types.Plo: Datei oder Verzeichnis nicht 
gefunden
make[2]: *** No rule to make target 'gen-cpp/.deps/tutorial_types.Plo'.  
Schluss.
make[2]: Leaving directory '/home/jens/Arbeitsfläche/Thrift/tutorial/cpp'
Makefile:535: recipe for target 'clean-recursive' failed
make[1]: *** [clean-recursive] Error 1
make[1]: Leaving directory '/home/jens/Arbeitsfläche/Thrift/tutorial'
Makefile:613: recipe for target 'clean-recursive' failed
make: *** [clean-recursive] Error 1
{code}


> calling "make clean" twice in a row yields make error
> -
>
> Key: THRIFT-3274
> URL: https://issues.apache.org/jira/browse/THRIFT-3274
> Project: Thrift
>  Issue Type: Bug
>  Components: C++ - Library
>Reporter: Jens Geyer
>Priority: Minor
>
> After calling {{make clean}} by accident twice in a row I got this:
> {code}
> Making clean in test
> make[3]: Entering directory '/home/jens/Arbeitsfläche/Thrift/lib/cpp/test'
> Makefile:1173: gen-cpp/.deps/ChildService.Plo: File or directory not found
> Makefile:1174: gen-cpp/.deps/DebugProtoTest_types.Plo: File or directory not 
> found
> Makefile:1175: gen-cpp/.deps/EmptyService.Plo: File or directory not found
> Makefile:1176: gen-cpp/.deps/EnumTest_types.Plo: File or directory not found
> Makefile:1177: gen-cpp/.deps/OptionalRequiredTest_types.Plo: File or 
> directory not found
> Makefile:1178: gen-cpp/.deps/ParentService.Plo: File or directory not found
> Makefile:1179: gen-cpp/.deps/Recursive_types.Plo: File or directory not found
> Makefile:1180: gen-cpp/.deps/ThriftTest_constants.Plo: File or directory not 
> found
> Makefile:1181: gen-cpp/.deps/ThriftTest_types.Plo: File or directory not found
> Makefile:1182: gen-cpp/.deps/TypedefTest_types.Plo: File or directory not 
> found
> Makefile:1183: gen-cpp/.deps/proc_types.Plo: File or directory not found
> make[3]: *** No rule to make target 'gen-cpp/.deps/proc_types.Plo'.  Stop.
> make[3]: Leaving directory '/home/jens/Arbeitsfläche/Thrift/lib/cpp/test'
> Makefile:1578: recipe for target 'clean-recursive' failed
> make[2]: *** [clean-recursive] Error 1
> make[2]: Leaving directory '/home/jens/Arbeitsfläche/Thrift/lib/cpp'
> Makefile:536: recipe for target 'clean-recursive' failed
> make[1]: *** [clean-recursive] Error 1
> make[1]: Leaving directory '/home/jens/Arbeitsfläche/Thrift/lib'
> Makefile:601: recipe for target 'clean-recursive' failed
> make: *** [clean-recursive] Error 1
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (THRIFT-3274) calling "make clean" twice in a row yields make error

[Jens Geyer (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-3274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14988017#comment-14988017
 ] 

Jens Geyer edited comment on THRIFT-3274 at 11/3/15 8:09 PM:
-

Better, but not perfect. The tutorial seems to suffer from the same problems:

{code}
Making clean in cpp
make[2]: Entering directory '/home/jens/Arbeitsfläche/Thrift/tutorial/cpp'
Makefile:621: gen-cpp/.deps/Calculator.Plo: File or directory not found
Makefile:622: gen-cpp/.deps/SharedService.Plo: File or directory not found
Makefile:623: gen-cpp/.deps/shared_constants.Plo: File or directory not found
Makefile:624: gen-cpp/.deps/shared_types.Plo: File or directory not found
Makefile:625: gen-cpp/.deps/tutorial_constants.Plo: File or directory not found
Makefile:626: gen-cpp/.deps/tutorial_types.Plo: File or directory not found
make[2]: *** No rule to make target 'gen-cpp/.deps/tutorial_types.Plo'.  
Schluss.
make[2]: Leaving directory '/home/jens/Arbeitsfläche/Thrift/tutorial/cpp'
Makefile:535: recipe for target 'clean-recursive' failed
make[1]: *** [clean-recursive] Error 1
make[1]: Leaving directory '/home/jens/Arbeitsfläche/Thrift/tutorial'
Makefile:613: recipe for target 'clean-recursive' failed
make: *** [clean-recursive] Error 1
{code}



was (Author: jensg):
Better, but not perfect. The tutorial seems to suffer from the same problems:

{code}
Making clean in cpp
make[2]: Entering directory '/home/jens/Arbeitsfläche/Thrift/tutorial/cpp'
Makefile:621: gen-cpp/.deps/Calculator.Plo: Datei oder Verzeichnis nicht 
gefunden
Makefile:622: gen-cpp/.deps/SharedService.Plo: Datei oder Verzeichnis nicht 
gefunden
Makefile:623: gen-cpp/.deps/shared_constants.Plo: Datei oder Verzeichnis nicht 
gefunden
Makefile:624: gen-cpp/.deps/shared_types.Plo: Datei oder Verzeichnis nicht 
gefunden
Makefile:625: gen-cpp/.deps/tutorial_constants.Plo: Datei oder Verzeichnis 
nicht gefunden
Makefile:626: gen-cpp/.deps/tutorial_types.Plo: Datei oder Verzeichnis nicht 
gefunden
make[2]: *** No rule to make target 'gen-cpp/.deps/tutorial_types.Plo'.  
Schluss.
make[2]: Leaving directory '/home/jens/Arbeitsfläche/Thrift/tutorial/cpp'
Makefile:535: recipe for target 'clean-recursive' failed
make[1]: *** [clean-recursive] Error 1
make[1]: Leaving directory '/home/jens/Arbeitsfläche/Thrift/tutorial'
Makefile:613: recipe for target 'clean-recursive' failed
make: *** [clean-recursive] Error 1
{code}


> calling "make clean" twice in a row yields make error
> -
>
> Key: THRIFT-3274
> URL: https://issues.apache.org/jira/browse/THRIFT-3274
> Project: Thrift
>  Issue Type: Bug
>  Components: C++ - Library
>Reporter: Jens Geyer
>Priority: Minor
>
> After calling {{make clean}} by accident twice in a row I got this:
> {code}
> Making clean in test
> make[3]: Entering directory '/home/jens/Arbeitsfläche/Thrift/lib/cpp/test'
> Makefile:1173: gen-cpp/.deps/ChildService.Plo: File or directory not found
> Makefile:1174: gen-cpp/.deps/DebugProtoTest_types.Plo: File or directory not 
> found
> Makefile:1175: gen-cpp/.deps/EmptyService.Plo: File or directory not found
> Makefile:1176: gen-cpp/.deps/EnumTest_types.Plo: File or directory not found
> Makefile:1177: gen-cpp/.deps/OptionalRequiredTest_types.Plo: File or 
> directory not found
> Makefile:1178: gen-cpp/.deps/ParentService.Plo: File or directory not found
> Makefile:1179: gen-cpp/.deps/Recursive_types.Plo: File or directory not found
> Makefile:1180: gen-cpp/.deps/ThriftTest_constants.Plo: File or directory not 
> found
> Makefile:1181: gen-cpp/.deps/ThriftTest_types.Plo: File or directory not found
> Makefile:1182: gen-cpp/.deps/TypedefTest_types.Plo: File or directory not 
> found
> Makefile:1183: gen-cpp/.deps/proc_types.Plo: File or directory not found
> make[3]: *** No rule to make target 'gen-cpp/.deps/proc_types.Plo'.  Stop.
> make[3]: Leaving directory '/home/jens/Arbeitsfläche/Thrift/lib/cpp/test'
> Makefile:1578: recipe for target 'clean-recursive' failed
> make[2]: *** [clean-recursive] Error 1
> make[2]: Leaving directory '/home/jens/Arbeitsfläche/Thrift/lib/cpp'
> Makefile:536: recipe for target 'clean-recursive' failed
> make[1]: *** [clean-recursive] Error 1
> make[1]: Leaving directory '/home/jens/Arbeitsfläche/Thrift/lib'
> Makefile:601: recipe for target 'clean-recursive' failed
> make: *** [clean-recursive] Error 1
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (THRIFT-3274) calling "make clean" twice in a row yields make error

[Roger Meier (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-3274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Roger Meier resolved THRIFT-3274.
-
Resolution: Fixed
  Assignee: Aki Sukegawa

Thanks Aki!

> calling "make clean" twice in a row yields make error
> -
>
> Key: THRIFT-3274
> URL: https://issues.apache.org/jira/browse/THRIFT-3274
> Project: Thrift
>  Issue Type: Bug
>  Components: C++ - Library
>Reporter: Jens Geyer
>Assignee: Aki Sukegawa
>Priority: Minor
>
> After calling {{make clean}} by accident twice in a row I got this:
> {code}
> Making clean in test
> make[3]: Entering directory '/home/jens/Arbeitsfläche/Thrift/lib/cpp/test'
> Makefile:1173: gen-cpp/.deps/ChildService.Plo: File or directory not found
> Makefile:1174: gen-cpp/.deps/DebugProtoTest_types.Plo: File or directory not 
> found
> Makefile:1175: gen-cpp/.deps/EmptyService.Plo: File or directory not found
> Makefile:1176: gen-cpp/.deps/EnumTest_types.Plo: File or directory not found
> Makefile:1177: gen-cpp/.deps/OptionalRequiredTest_types.Plo: File or 
> directory not found
> Makefile:1178: gen-cpp/.deps/ParentService.Plo: File or directory not found
> Makefile:1179: gen-cpp/.deps/Recursive_types.Plo: File or directory not found
> Makefile:1180: gen-cpp/.deps/ThriftTest_constants.Plo: File or directory not 
> found
> Makefile:1181: gen-cpp/.deps/ThriftTest_types.Plo: File or directory not found
> Makefile:1182: gen-cpp/.deps/TypedefTest_types.Plo: File or directory not 
> found
> Makefile:1183: gen-cpp/.deps/proc_types.Plo: File or directory not found
> make[3]: *** No rule to make target 'gen-cpp/.deps/proc_types.Plo'.  Stop.
> make[3]: Leaving directory '/home/jens/Arbeitsfläche/Thrift/lib/cpp/test'
> Makefile:1578: recipe for target 'clean-recursive' failed
> make[2]: *** [clean-recursive] Error 1
> make[2]: Leaving directory '/home/jens/Arbeitsfläche/Thrift/lib/cpp'
> Makefile:536: recipe for target 'clean-recursive' failed
> make[1]: *** [clean-recursive] Error 1
> make[1]: Leaving directory '/home/jens/Arbeitsfläche/Thrift/lib'
> Makefile:601: recipe for target 'clean-recursive' failed
> make: *** [clean-recursive] Error 1
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Reopened] (THRIFT-3274) calling "make clean" twice in a row yields make error

[Jens Geyer (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-3274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jens Geyer reopened THRIFT-3274:


> calling "make clean" twice in a row yields make error
> -
>
> Key: THRIFT-3274
> URL: https://issues.apache.org/jira/browse/THRIFT-3274
> Project: Thrift
>  Issue Type: Bug
>  Components: C++ - Library
>Reporter: Jens Geyer
>Assignee: Aki Sukegawa
>Priority: Minor
>
> After calling {{make clean}} by accident twice in a row I got this:
> {code}
> Making clean in test
> make[3]: Entering directory '/home/jens/Arbeitsfläche/Thrift/lib/cpp/test'
> Makefile:1173: gen-cpp/.deps/ChildService.Plo: File or directory not found
> Makefile:1174: gen-cpp/.deps/DebugProtoTest_types.Plo: File or directory not 
> found
> Makefile:1175: gen-cpp/.deps/EmptyService.Plo: File or directory not found
> Makefile:1176: gen-cpp/.deps/EnumTest_types.Plo: File or directory not found
> Makefile:1177: gen-cpp/.deps/OptionalRequiredTest_types.Plo: File or 
> directory not found
> Makefile:1178: gen-cpp/.deps/ParentService.Plo: File or directory not found
> Makefile:1179: gen-cpp/.deps/Recursive_types.Plo: File or directory not found
> Makefile:1180: gen-cpp/.deps/ThriftTest_constants.Plo: File or directory not 
> found
> Makefile:1181: gen-cpp/.deps/ThriftTest_types.Plo: File or directory not found
> Makefile:1182: gen-cpp/.deps/TypedefTest_types.Plo: File or directory not 
> found
> Makefile:1183: gen-cpp/.deps/proc_types.Plo: File or directory not found
> make[3]: *** No rule to make target 'gen-cpp/.deps/proc_types.Plo'.  Stop.
> make[3]: Leaving directory '/home/jens/Arbeitsfläche/Thrift/lib/cpp/test'
> Makefile:1578: recipe for target 'clean-recursive' failed
> make[2]: *** [clean-recursive] Error 1
> make[2]: Leaving directory '/home/jens/Arbeitsfläche/Thrift/lib/cpp'
> Makefile:536: recipe for target 'clean-recursive' failed
> make[1]: *** [clean-recursive] Error 1
> make[1]: Leaving directory '/home/jens/Arbeitsfläche/Thrift/lib'
> Makefile:601: recipe for target 'clean-recursive' failed
> make: *** [clean-recursive] Error 1
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (THRIFT-3274) calling "make clean" twice in a row yields make error

[Roger Meier (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-3274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14988135#comment-14988135
 ] 

Roger Meier commented on THRIFT-3274:
-

[~jensg] fix for tutorial is in verification...

> calling "make clean" twice in a row yields make error
> -
>
> Key: THRIFT-3274
> URL: https://issues.apache.org/jira/browse/THRIFT-3274
> Project: Thrift
>  Issue Type: Bug
>  Components: C++ - Library
>Reporter: Jens Geyer
>Assignee: Aki Sukegawa
>Priority: Minor
>
> After calling {{make clean}} by accident twice in a row I got this:
> {code}
> Making clean in test
> make[3]: Entering directory '/home/jens/Arbeitsfläche/Thrift/lib/cpp/test'
> Makefile:1173: gen-cpp/.deps/ChildService.Plo: File or directory not found
> Makefile:1174: gen-cpp/.deps/DebugProtoTest_types.Plo: File or directory not 
> found
> Makefile:1175: gen-cpp/.deps/EmptyService.Plo: File or directory not found
> Makefile:1176: gen-cpp/.deps/EnumTest_types.Plo: File or directory not found
> Makefile:1177: gen-cpp/.deps/OptionalRequiredTest_types.Plo: File or 
> directory not found
> Makefile:1178: gen-cpp/.deps/ParentService.Plo: File or directory not found
> Makefile:1179: gen-cpp/.deps/Recursive_types.Plo: File or directory not found
> Makefile:1180: gen-cpp/.deps/ThriftTest_constants.Plo: File or directory not 
> found
> Makefile:1181: gen-cpp/.deps/ThriftTest_types.Plo: File or directory not found
> Makefile:1182: gen-cpp/.deps/TypedefTest_types.Plo: File or directory not 
> found
> Makefile:1183: gen-cpp/.deps/proc_types.Plo: File or directory not found
> make[3]: *** No rule to make target 'gen-cpp/.deps/proc_types.Plo'.  Stop.
> make[3]: Leaving directory '/home/jens/Arbeitsfläche/Thrift/lib/cpp/test'
> Makefile:1578: recipe for target 'clean-recursive' failed
> make[2]: *** [clean-recursive] Error 1
> make[2]: Leaving directory '/home/jens/Arbeitsfläche/Thrift/lib/cpp'
> Makefile:536: recipe for target 'clean-recursive' failed
> make[1]: *** [clean-recursive] Error 1
> make[1]: Leaving directory '/home/jens/Arbeitsfläche/Thrift/lib'
> Makefile:601: recipe for target 'clean-recursive' failed
> make: *** [clean-recursive] Error 1
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] thrift pull request: THRIFT-3274 calling "make clean" twice in a r...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/thrift/pull/676


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (THRIFT-3274) calling "make clean" twice in a row yields make error

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-3274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14988024#comment-14988024
 ] 

ASF GitHub Bot commented on THRIFT-3274:


Github user asfgit closed the pull request at:

https://github.com/apache/thrift/pull/676


> calling "make clean" twice in a row yields make error
> -
>
> Key: THRIFT-3274
> URL: https://issues.apache.org/jira/browse/THRIFT-3274
> Project: Thrift
>  Issue Type: Bug
>  Components: C++ - Library
>Reporter: Jens Geyer
>Priority: Minor
>
> After calling {{make clean}} by accident twice in a row I got this:
> {code}
> Making clean in test
> make[3]: Entering directory '/home/jens/Arbeitsfläche/Thrift/lib/cpp/test'
> Makefile:1173: gen-cpp/.deps/ChildService.Plo: File or directory not found
> Makefile:1174: gen-cpp/.deps/DebugProtoTest_types.Plo: File or directory not 
> found
> Makefile:1175: gen-cpp/.deps/EmptyService.Plo: File or directory not found
> Makefile:1176: gen-cpp/.deps/EnumTest_types.Plo: File or directory not found
> Makefile:1177: gen-cpp/.deps/OptionalRequiredTest_types.Plo: File or 
> directory not found
> Makefile:1178: gen-cpp/.deps/ParentService.Plo: File or directory not found
> Makefile:1179: gen-cpp/.deps/Recursive_types.Plo: File or directory not found
> Makefile:1180: gen-cpp/.deps/ThriftTest_constants.Plo: File or directory not 
> found
> Makefile:1181: gen-cpp/.deps/ThriftTest_types.Plo: File or directory not found
> Makefile:1182: gen-cpp/.deps/TypedefTest_types.Plo: File or directory not 
> found
> Makefile:1183: gen-cpp/.deps/proc_types.Plo: File or directory not found
> make[3]: *** No rule to make target 'gen-cpp/.deps/proc_types.Plo'.  Stop.
> make[3]: Leaving directory '/home/jens/Arbeitsfläche/Thrift/lib/cpp/test'
> Makefile:1578: recipe for target 'clean-recursive' failed
> make[2]: *** [clean-recursive] Error 1
> make[2]: Leaving directory '/home/jens/Arbeitsfläche/Thrift/lib/cpp'
> Makefile:536: recipe for target 'clean-recursive' failed
> make[1]: *** [clean-recursive] Error 1
> make[1]: Leaving directory '/home/jens/Arbeitsfläche/Thrift/lib'
> Makefile:601: recipe for target 'clean-recursive' failed
> make: *** [clean-recursive] Error 1
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (THRIFT-3409) NodeJS binary field issues

[Roger Meier (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-3409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14988006#comment-14988006
 ] 

Roger Meier commented on THRIFT-3409:
-

great stuff!
+1

> NodeJS binary field issues
> --
>
> Key: THRIFT-3409
> URL: https://issues.apache.org/jira/browse/THRIFT-3409
> Project: Thrift
>  Issue Type: Sub-task
>  Components: Node.js - Library
>Reporter: Aki Sukegawa
>Assignee: Aki Sukegawa
>
> There's at least 3 problems in NodeJS binary field.
> # API are inconsistent across binary/comact/JSON protocols
> # compact/JSON wire format is imcompatible with other languages
>   (JSON : THRIFT-3200)
> # size of compact wire format is 2x of the original binary
> I propose following changes to fix this
> # Change JSON protocol return value from string to Buffer (same as 
> binary/compact)
> # Change JSON protocol wire format to Base64 (same as other languages)
> # Change compact protocol wire format to plain binary (same as other 
> languages)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (THRIFT-3407) Refill buffer when JSON closing bracket is missing

[Roger Meier (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-3407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14987994#comment-14987994
 ] 

Roger Meier commented on THRIFT-3407:
-

+1

> Refill buffer when JSON closing bracket is missing
> --
>
> Key: THRIFT-3407
> URL: https://issues.apache.org/jira/browse/THRIFT-3407
> Project: Thrift
>  Issue Type: Bug
>  Components: Node.js - Library
>Affects Versions: 0.9.3
>Reporter: Aki Sukegawa
>Assignee: Aki Sukegawa
>
> NodeJS TJSONProtocol aborts reading when number of closing brackets is 
> smaller than that of opening brackets.
> It is problematic because it is not guaranteed if the transport reads the 
> whole JSON message at once or not.
> Practically, sending big JSON message over buffered tranpsort is being 
> unstable because of this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Reopened] (THRIFT-3339) Support for database/sql

[Adam Beberg (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-3339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adam Beberg reopened THRIFT-3339:
-

Reopening to add support for optional enums.

> Support for database/sql
> 
>
> Key: THRIFT-3339
> URL: https://issues.apache.org/jira/browse/THRIFT-3339
> Project: Thrift
>  Issue Type: Improvement
>  Components: Go - Compiler
>Reporter: Adam Beberg
>Assignee: Adam Beberg
> Fix For: 0.9.4
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> For use by database/sql the generated code needs:
> 1. Generated enums need to implement sql.Scanner and driver.Valuer
> 2. Struct fields need db: annotations with the original field names.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] thrift pull request: Deprecate this Apache Thrift Fork

[Raynos]

Github user Raynos commented on the pull request:

https://github.com/apache/thrift/pull/683#issuecomment-153534427
  
#legit 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: Deprecate this Apache Thrift Fork

[breerly]

GitHub user breerly opened a pull request:

https://github.com/apache/thrift/pull/683

Deprecate this Apache Thrift Fork

We're finally to a place where we can deprecate this repo.

* Python & Node use 
[thriftrw](https://github.com/search?utf8=%E2%9C%93=thriftrw).
* Go uses packaged binaries that are separate from this fork.
* Java uses Apache Thrift directly.

This will not break existing functionality - instead, it will halt new 
development and reduce confusion.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/uber/thrift deprecate

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/683.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #683


commit 30d44ce4ae4baff4b300a69ceddee6817fc9fe82
Author: Grayson Koonce 
Date:   2015-11-04T00:34:16Z

RIP




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: Thrift 1857 redux 2

[bufferoverflow]

Github user bufferoverflow commented on the pull request:

https://github.com/apache/thrift/pull/680#issuecomment-153534017
  
:+1: 
tested with autoconf running **make cross** and cmake **make** on Debian 
Jessie amd64 with Python 2.7.9
-roger


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: Deprecate this Apache Thrift Fork

[breerly]

Github user breerly closed the pull request at:

https://github.com/apache/thrift/pull/683


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: Deprecate this Apache Thrift Fork

[kriskowal]

Github user kriskowal commented on the pull request:

https://github.com/apache/thrift/pull/683#issuecomment-153534454
  
:ok:


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: Deprecate this Apache Thrift Fork

[Raynos]

Github user Raynos commented on the pull request:

https://github.com/apache/thrift/pull/683#issuecomment-153534582
  
#oops 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: Fix package.json to include only the needed f...

[bufferoverflow]

Github user bufferoverflow commented on the pull request:

https://github.com/apache/thrift/pull/672#issuecomment-153511243
  
Thanks for the PR!

We need a strong YES to according to the contribution guidelines as 
mentioned here https://thrift.apache.org/docs/HowToContribute (generated from 
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md)

I guess CONTRIBUTING.md is displayed when creating a merge request? But 
there is no ack... or is pressing the create Merge Request an ACK on the 
contribution license?

We probably need to simplify this somehow especially for such small but 
essential contributions.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-3407 Refill buffer when JSON closing b...

[nsuke]

GitHub user nsuke opened a pull request:

https://github.com/apache/thrift/pull/678

THRIFT-3407 Refill buffer when JSON closing bracket is missing



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nsuke/thrift THRIFT-3407

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/678.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #678


commit 1db3e4af072f9db62ff640b9a4ff09cf189ef544
Author: Nobuaki Sukegawa 
Date:   2015-11-03T13:58:20Z

THRIFT-3407 Refill buffer when JSON closing bracket is missing




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (THRIFT-3407) Refill buffer when JSON closing bracket is missing

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-3407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14987399#comment-14987399
 ] 

ASF GitHub Bot commented on THRIFT-3407:


GitHub user nsuke opened a pull request:

https://github.com/apache/thrift/pull/678

THRIFT-3407 Refill buffer when JSON closing bracket is missing



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nsuke/thrift THRIFT-3407

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/678.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #678


commit 1db3e4af072f9db62ff640b9a4ff09cf189ef544
Author: Nobuaki Sukegawa 
Date:   2015-11-03T13:58:20Z

THRIFT-3407 Refill buffer when JSON closing bracket is missing




> Refill buffer when JSON closing bracket is missing
> --
>
> Key: THRIFT-3407
> URL: https://issues.apache.org/jira/browse/THRIFT-3407
> Project: Thrift
>  Issue Type: Bug
>  Components: Node.js - Library
>Affects Versions: 0.9.3
>Reporter: Aki Sukegawa
>Assignee: Aki Sukegawa
>
> NodeJS TJSONProtocol aborts reading when number of closing brackets is 
> smaller than that of opening brackets.
> It is problematic because it is not guaranteed if the transport reads the 
> whole JSON message at once or not.
> Practically, sending big JSON message over buffered tranpsort is being 
> unstable because of this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] thrift pull request: THRIFT-3409 NodeJS binary field issues

[nsuke]

GitHub user nsuke opened a pull request:

https://github.com/apache/thrift/pull/681

THRIFT-3409 NodeJS binary field issues



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nsuke/thrift THRIFT-3409

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/681.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #681


commit b427f7e6dbec073f71c6af2c16de6e29d047dbcf
Author: Nobuaki Sukegawa 
Date:   2015-11-03T15:07:43Z

THRIFT-3409 NodeJS binary field issues




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Closed] (THRIFT-338) Compact Protocol in Erlang

[Aki Sukegawa (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aki Sukegawa closed THRIFT-338.
---

> Compact Protocol in Erlang
> --
>
> Key: THRIFT-338
> URL: https://issues.apache.org/jira/browse/THRIFT-338
> Project: Thrift
>  Issue Type: Sub-task
>Reporter: Todd Lipcon
>Assignee: Aki Sukegawa
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (THRIFT-3409) NodeJS binary field issues

[Aki Sukegawa (JIRA)]

Aki Sukegawa created THRIFT-3409:


 Summary: NodeJS binary field issues
 Key: THRIFT-3409
 URL: https://issues.apache.org/jira/browse/THRIFT-3409
 Project: Thrift
  Issue Type: Sub-task
  Components: Node.js - Library
Reporter: Aki Sukegawa
Assignee: Aki Sukegawa


There's at least 3 problems in NodeJS binary field.

# API are inconsistent across binary/comact/JSON protocols
# compact/JSON wire format is imcompatible with other languages
  (JSON : THRIFT-3200)
# size of compact wire format is 2x of the original binary

I propose following changes to fix this

# Change JSON protocol return value from string to Buffer (same as 
binary/compact)
# Change JSON protocol wire format to Base64 (same as other languages)
# Change compact protocol wire format to plain binary (same as other languages)





--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (THRIFT-3409) NodeJS binary field issues

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-3409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14987525#comment-14987525
 ] 

ASF GitHub Bot commented on THRIFT-3409:


GitHub user nsuke opened a pull request:

https://github.com/apache/thrift/pull/681

THRIFT-3409 NodeJS binary field issues



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nsuke/thrift THRIFT-3409

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/681.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #681


commit b427f7e6dbec073f71c6af2c16de6e29d047dbcf
Author: Nobuaki Sukegawa 
Date:   2015-11-03T15:07:43Z

THRIFT-3409 NodeJS binary field issues




> NodeJS binary field issues
> --
>
> Key: THRIFT-3409
> URL: https://issues.apache.org/jira/browse/THRIFT-3409
> Project: Thrift
>  Issue Type: Sub-task
>  Components: Node.js - Library
>Reporter: Aki Sukegawa
>Assignee: Aki Sukegawa
>
> There's at least 3 problems in NodeJS binary field.
> # API are inconsistent across binary/comact/JSON protocols
> # compact/JSON wire format is imcompatible with other languages
>   (JSON : THRIFT-3200)
> # size of compact wire format is 2x of the original binary
> I propose following changes to fix this
> # Change JSON protocol return value from string to Buffer (same as 
> binary/compact)
> # Change JSON protocol wire format to Base64 (same as other languages)
> # Change compact protocol wire format to plain binary (same as other 
> languages)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (THRIFT-2423) THeader

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-2423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14987555#comment-14987555
 ] 

ASF GitHub Bot commented on THRIFT-2423:


Github user asfgit closed the pull request at:

https://github.com/apache/thrift/pull/357


> THeader
> ---
>
> Key: THRIFT-2423
> URL: https://issues.apache.org/jira/browse/THRIFT-2423
> Project: Thrift
>  Issue Type: Sub-task
>  Components: Build Process, C++ - Compiler, C++ - Library, Test Suite
>Reporter: Roger Meier
> Fix For: 1.0
>
>
> THeader seems to be a nice feature.
> Is there some documentation available?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (THRIFT-2423) THeader

[Aki Sukegawa (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-2423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aki Sukegawa resolved THRIFT-2423.
--
Resolution: Fixed
  Assignee: Dave Watson

Committed, sorry for the delay. Thanks !

> THeader
> ---
>
> Key: THRIFT-2423
> URL: https://issues.apache.org/jira/browse/THRIFT-2423
> Project: Thrift
>  Issue Type: Sub-task
>  Components: Build Process, C++ - Compiler, C++ - Library, Test Suite
>Reporter: Roger Meier
>Assignee: Dave Watson
> Fix For: 1.0
>
>
> THeader seems to be a nice feature.
> Is there some documentation available?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] thrift pull request: THRIFT-2423: Facebook's THeader protocol and ...

[nsuke]

Github user nsuke commented on the pull request:

https://github.com/apache/thrift/pull/357#issuecomment-153356845
  
There were several build issues.
I'll commit the fixed version shortly after #677.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (THRIFT-338) Compact Protocol in Erlang

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14987298#comment-14987298
 ] 

Hudson commented on THRIFT-338:
---

SUCCESS: Integrated in Thrift #1707 (See 
[https://builds.apache.org/job/Thrift/1707/])
THRIFT-338 Compact Protocol in Erlang Client: Erlang Patch: Nobuaki (nsuke: rev 
b31f0900b57b7473a8f84c7b74f73381dcff2818)
* lib/erl/src/thrift_compact_protocol.erl
* test/erl/src/test_client.erl
* lib/erl/src/thrift_protocol.erl
* test/erl/src/test_thrift_server.erl
* lib/erl/src/thrift_client_util.erl
* test/tests.json
* lib/erl/test/test_thrift_compact_protocol.erl
* test/known_failures_Linux.json
* lib/erl/src/thrift_socket_server.erl


> Compact Protocol in Erlang
> --
>
> Key: THRIFT-338
> URL: https://issues.apache.org/jira/browse/THRIFT-338
> Project: Thrift
>  Issue Type: Sub-task
>Reporter: Todd Lipcon
>Assignee: Aki Sukegawa
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (THRIFT-2423) THeader

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-2423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14987297#comment-14987297
 ] 

ASF GitHub Bot commented on THRIFT-2423:


Github user nsuke commented on the pull request:

https://github.com/apache/thrift/pull/357#issuecomment-153356845
  
There were several build issues.
I'll commit the fixed version shortly after #677.


> THeader
> ---
>
> Key: THRIFT-2423
> URL: https://issues.apache.org/jira/browse/THRIFT-2423
> Project: Thrift
>  Issue Type: Sub-task
>  Components: Build Process, C++ - Compiler, C++ - Library, Test Suite
>Reporter: Roger Meier
> Fix For: 1.0
>
>
> THeader seems to be a nice feature.
> Is there some documentation available?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (THRIFT-3407) Refill buffer when JSON closing bracket is missing

[Aki Sukegawa (JIRA)]

Aki Sukegawa created THRIFT-3407:


 Summary: Refill buffer when JSON closing bracket is missing
 Key: THRIFT-3407
 URL: https://issues.apache.org/jira/browse/THRIFT-3407
 Project: Thrift
  Issue Type: Bug
  Components: Node.js - Library
Affects Versions: 0.9.3
Reporter: Aki Sukegawa
Assignee: Aki Sukegawa


NodeJS TJSONProtocol aborts reading when number of closing brackets is smaller 
than that of opening brackets.
It is problematic because it is not guaranteed if the transport reads the whole 
JSON message at one or not.

Practically, sending big JSON message over buffered tranpsort is being unstable 
because of this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (THRIFT-3407) Refill buffer when JSON closing bracket is missing

[Aki Sukegawa (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-3407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aki Sukegawa updated THRIFT-3407:
-
Description: 
NodeJS TJSONProtocol aborts reading when number of closing brackets is smaller 
than that of opening brackets.
It is problematic because it is not guaranteed if the transport reads the whole 
JSON message at onece or not.

Practically, sending big JSON message over buffered tranpsort is being unstable 
because of this.

  was:
NodeJS TJSONProtocol aborts reading when number of closing brackets is smaller 
than that of opening brackets.
It is problematic because it is not guaranteed if the transport reads the whole 
JSON message at one or not.

Practically, sending big JSON message over buffered tranpsort is being unstable 
because of this.


> Refill buffer when JSON closing bracket is missing
> --
>
> Key: THRIFT-3407
> URL: https://issues.apache.org/jira/browse/THRIFT-3407
> Project: Thrift
>  Issue Type: Bug
>  Components: Node.js - Library
>Affects Versions: 0.9.3
>Reporter: Aki Sukegawa
>Assignee: Aki Sukegawa
>
> NodeJS TJSONProtocol aborts reading when number of closing brackets is 
> smaller than that of opening brackets.
> It is problematic because it is not guaranteed if the transport reads the 
> whole JSON message at onece or not.
> Practically, sending big JSON message over buffered tranpsort is being 
> unstable because of this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (THRIFT-3407) Refill buffer when JSON closing bracket is missing

[Aki Sukegawa (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-3407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aki Sukegawa updated THRIFT-3407:
-
Description: 
NodeJS TJSONProtocol aborts reading when number of closing brackets is smaller 
than that of opening brackets.
It is problematic because it is not guaranteed if the transport reads the whole 
JSON message at once or not.

Practically, sending big JSON message over buffered tranpsort is being unstable 
because of this.

  was:
NodeJS TJSONProtocol aborts reading when number of closing brackets is smaller 
than that of opening brackets.
It is problematic because it is not guaranteed if the transport reads the whole 
JSON message at onece or not.

Practically, sending big JSON message over buffered tranpsort is being unstable 
because of this.


> Refill buffer when JSON closing bracket is missing
> --
>
> Key: THRIFT-3407
> URL: https://issues.apache.org/jira/browse/THRIFT-3407
> Project: Thrift
>  Issue Type: Bug
>  Components: Node.js - Library
>Affects Versions: 0.9.3
>Reporter: Aki Sukegawa
>Assignee: Aki Sukegawa
>
> NodeJS TJSONProtocol aborts reading when number of closing brackets is 
> smaller than that of opening brackets.
> It is problematic because it is not guaranteed if the transport reads the 
> whole JSON message at once or not.
> Practically, sending big JSON message over buffered tranpsort is being 
> unstable because of this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] thrift pull request: Thrift 2423 redux

[nsuke]

GitHub user nsuke opened a pull request:

https://github.com/apache/thrift/pull/677

Thrift 2423 redux



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nsuke/thrift THRIFT-2423-redux

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/677.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #677


commit 4f9bb986d5f1438185af3a1e792ce1b5d65ab5d8
Author: Dave Watson 
Date:   2015-01-16T19:22:01Z

THRIFT-2423 Facebook's THeader protocol and transport for cpp
Client: C++ Library, Compiler
Author: Dave Watson 

commit f63f4e4914b2ba1ccdf529af4b0528703ba2bd14
Author: Nobuaki Sukegawa 
Date:   2015-11-02T16:39:37Z

Remove readStringBody that does not exist (build fix)

commit b53b406dcdf70851317a6e0f94e0ccb5997d6466
Author: Nobuaki Sukegawa 
Date:   2015-11-02T16:39:41Z

Enable header protocol cross test

commit a54adb359acea39e55ce57a55cdd976afad6345d
Author: Nobuaki Sukegawa 
Date:   2015-11-02T18:04:25Z

Fix C++98 build

commit 0679ad90c7c09d3eada70dda5899f5eb5a26f093
Author: Nobuaki Sukegawa 
Date:   2015-11-02T17:01:16Z

Fix cmake build

commit 26b5cb310fc2dce9654e3ab85fdf4fc9b94a083c
Author: Nobuaki Sukegawa 
Date:   2015-11-02T18:40:45Z

Add zlib link to cmake build

commit f4c63016c620578fe0b889d971cd95f6622808cd
Author: Nobuaki Sukegawa 
Date:   2015-11-03T04:12:47Z

clang-format




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-2423: Facebook's THeader protocol and ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/thrift/pull/357


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: Thrift 2423 redux

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/thrift/pull/677


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---