[jira] [Commented] (TINKERPOP-2852) Update Maven plugin for docker-images building for M1 compatibility
[ https://issues.apache.org/jira/browse/TINKERPOP-2852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17716486#comment-17716486 ] ASF GitHub Bot commented on TINKERPOP-2852: --- xiazcy merged PR #2043: URL: https://github.com/apache/tinkerpop/pull/2043 > Update Maven plugin for docker-images building for M1 compatibility > --- > > Key: TINKERPOP-2852 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2852 > Project: TinkerPop > Issue Type: Improvement > Components: build-release >Affects Versions: 3.5.4 >Reporter: Yang Xia >Priority: Critical > > The current Maven plug in we use for the `docker-image` building profile is > no longer maintained > ([https://github.com/spotify/dockerfile-maven)|https://github.com/spotify/dockerfile-maven).], > and it is also not compatible with M1 Macs. > We should consider swapping the plug in for an actively maintained one that > is M1 compatible, for example > [https://github.com/fabric8io/docker-maven-plugin/issues/1257.|https://github.com/fabric8io/docker-maven-plugin/issues/1257] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TINKERPOP-2852) Update Maven plugin for docker-images building for M1 compatibility
[ https://issues.apache.org/jira/browse/TINKERPOP-2852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17716485#comment-17716485 ] ASF GitHub Bot commented on TINKERPOP-2852: --- xiazcy merged PR #2007: URL: https://github.com/apache/tinkerpop/pull/2007 > Update Maven plugin for docker-images building for M1 compatibility > --- > > Key: TINKERPOP-2852 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2852 > Project: TinkerPop > Issue Type: Improvement > Components: build-release >Affects Versions: 3.5.4 >Reporter: Yang Xia >Priority: Critical > > The current Maven plug in we use for the `docker-image` building profile is > no longer maintained > ([https://github.com/spotify/dockerfile-maven)|https://github.com/spotify/dockerfile-maven).], > and it is also not compatible with M1 Macs. > We should consider swapping the plug in for an actively maintained one that > is M1 compatible, for example > [https://github.com/fabric8io/docker-maven-plugin/issues/1257.|https://github.com/fabric8io/docker-maven-plugin/issues/1257] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TINKERPOP-2852) Update Maven plugin for docker-images building for M1 compatibility
[ https://issues.apache.org/jira/browse/TINKERPOP-2852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17716484#comment-17716484 ] ASF GitHub Bot commented on TINKERPOP-2852: --- xiazcy commented on PR #2007: URL: https://github.com/apache/tinkerpop/pull/2007#issuecomment-1522633044 VOTE +1 > Update Maven plugin for docker-images building for M1 compatibility > --- > > Key: TINKERPOP-2852 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2852 > Project: TinkerPop > Issue Type: Improvement > Components: build-release >Affects Versions: 3.5.4 >Reporter: Yang Xia >Priority: Critical > > The current Maven plug in we use for the `docker-image` building profile is > no longer maintained > ([https://github.com/spotify/dockerfile-maven)|https://github.com/spotify/dockerfile-maven).], > and it is also not compatible with M1 Macs. > We should consider swapping the plug in for an actively maintained one that > is M1 compatible, for example > [https://github.com/fabric8io/docker-maven-plugin/issues/1257.|https://github.com/fabric8io/docker-maven-plugin/issues/1257] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TINKERPOP-2852) Update Maven plugin for docker-images building for M1 compatibility
[
https://issues.apache.org/jira/browse/TINKERPOP-2852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17716133#comment-17716133
]
ASF GitHub Bot commented on TINKERPOP-2852:
---
FlorianHockmann commented on code in PR #2007:
URL: https://github.com/apache/tinkerpop/pull/2007#discussion_r1176113134
##
docs/src/upgrade/release-3.5.x.asciidoc:
##
@@ -30,24 +30,8 @@ complete list of all the modifications that are part of this
release.
=== Upgrading for Users
-=== Upgrading for Providers
-
- Local steps should handle non-Iterables
-
-`index` steps and local steps `count`, `dedup`, `max`, `mean`, `min`, `order`,
`range`, `sample`, `sum`, `tail` should
-work correctly with not only `Iterable` input, but also with arrays and single
values.
-
-Examples of queries that should be supported:
-
-[source,groovy]
-
-g.inject(1).max(local)
-
-
-[source,java]
-
-g.inject(new Integer[] {1,2},3).max(Scope.local).toList()
-
+Gremlin server docker image now supports both AMD64 and ARM64.
Multi-architecture image can now be found at
Review Comment:
Could you please add a heading for this?
> Update Maven plugin for docker-images building for M1 compatibility
> ---
>
> Key: TINKERPOP-2852
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2852
> Project: TinkerPop
> Issue Type: Improvement
> Components: build-release
>Affects Versions: 3.5.4
>Reporter: Yang Xia
>Priority: Critical
>
> The current Maven plug in we use for the `docker-image` building profile is
> no longer maintained
> ([https://github.com/spotify/dockerfile-maven)|https://github.com/spotify/dockerfile-maven).],
> and it is also not compatible with M1 Macs.
> We should consider swapping the plug in for an actively maintained one that
> is M1 compatible, for example
> [https://github.com/fabric8io/docker-maven-plugin/issues/1257.|https://github.com/fabric8io/docker-maven-plugin/issues/1257]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TINKERPOP-2852) Update Maven plugin for docker-images building for M1 compatibility
[ https://issues.apache.org/jira/browse/TINKERPOP-2852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17716080#comment-17716080 ] ASF GitHub Bot commented on TINKERPOP-2852: --- codecov-commenter commented on PR #2043: URL: https://github.com/apache/tinkerpop/pull/2043#issuecomment-1521158668 ## [Codecov](https://codecov.io/gh/apache/tinkerpop/pull/2043?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#2043](https://codecov.io/gh/apache/tinkerpop/pull/2043?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (88006c5) into [3.6-dev](https://codecov.io/gh/apache/tinkerpop/commit/09997f937d1f83a35d8ef312927f8ecf7f352306?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (09997f9) will **increase** coverage by `0.49%`. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## 3.6-dev#2043 +/- ## = + Coverage 69.51% 70.00% +0.49% - Complexity 9359 9363 +4 = Files878 853 -25 Lines 4225938466-3793 Branches5653 5653 = - Hits 2937826930-2448 + Misses 10888 9719-1169 + Partials1993 1817 -176 ``` [see 31 files with indirect coverage changes](https://codecov.io/gh/apache/tinkerpop/pull/2043/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > Update Maven plugin for docker-images building for M1 compatibility > --- > > Key: TINKERPOP-2852 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2852 > Project: TinkerPop > Issue Type: Improvement > Components: build-release >Affects Versions: 3.5.4 >Reporter: Yang Xia >Priority: Critical > > The current Maven plug in we use for the `docker-image` building profile is > no longer maintained > ([https://github.com/spotify/dockerfile-maven)|https://github.com/spotify/dockerfile-maven).], > and it is also not compatible with M1 Macs. > We should consider swapping the plug in for an actively maintained one that > is M1 compatible, for example > [https://github.com/fabric8io/docker-maven-plugin/issues/1257.|https://github.com/fabric8io/docker-maven-plugin/issues/1257] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TINKERPOP-2852) Update Maven plugin for docker-images building for M1 compatibility
[ https://issues.apache.org/jira/browse/TINKERPOP-2852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17716025#comment-17716025 ] ASF GitHub Bot commented on TINKERPOP-2852: --- Cole-Greer opened a new pull request, #2043: URL: https://github.com/apache/tinkerpop/pull/2043 Cherry picking from https://github.com/apache/tinkerpop/pull/2007 for 3.6. Only notable difference is the latest tag is added back for this branch. > Update Maven plugin for docker-images building for M1 compatibility > --- > > Key: TINKERPOP-2852 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2852 > Project: TinkerPop > Issue Type: Improvement > Components: build-release >Affects Versions: 3.5.4 >Reporter: Yang Xia >Priority: Critical > > The current Maven plug in we use for the `docker-image` building profile is > no longer maintained > ([https://github.com/spotify/dockerfile-maven)|https://github.com/spotify/dockerfile-maven).], > and it is also not compatible with M1 Macs. > We should consider swapping the plug in for an actively maintained one that > is M1 compatible, for example > [https://github.com/fabric8io/docker-maven-plugin/issues/1257.|https://github.com/fabric8io/docker-maven-plugin/issues/1257] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TINKERPOP-2852) Update Maven plugin for docker-images building for M1 compatibility
[ https://issues.apache.org/jira/browse/TINKERPOP-2852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17715217#comment-17715217 ] ASF GitHub Bot commented on TINKERPOP-2852: --- lyndonbauto commented on PR #2007: URL: https://github.com/apache/tinkerpop/pull/2007#issuecomment-1518478482 @Cole-Greer Sweet, that's really cool mean. VOTE+1 > Update Maven plugin for docker-images building for M1 compatibility > --- > > Key: TINKERPOP-2852 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2852 > Project: TinkerPop > Issue Type: Improvement > Components: build-release >Affects Versions: 3.5.4 >Reporter: Yang Xia >Priority: Critical > > The current Maven plug in we use for the `docker-image` building profile is > no longer maintained > ([https://github.com/spotify/dockerfile-maven)|https://github.com/spotify/dockerfile-maven).], > and it is also not compatible with M1 Macs. > We should consider swapping the plug in for an actively maintained one that > is M1 compatible, for example > [https://github.com/fabric8io/docker-maven-plugin/issues/1257.|https://github.com/fabric8io/docker-maven-plugin/issues/1257] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TINKERPOP-2852) Update Maven plugin for docker-images building for M1 compatibility
[ https://issues.apache.org/jira/browse/TINKERPOP-2852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17715209#comment-17715209 ] ASF GitHub Bot commented on TINKERPOP-2852: --- Cole-Greer commented on PR #2007: URL: https://github.com/apache/tinkerpop/pull/2007#issuecomment-1518442805 @lyndonbauto > So does this now support building on x64 and aarch64? As of TinkerPop 3.5.5/3.6.3 both x64 and aarch64 were able to build and run TinkerPop out of the box. > Also does it support cross platform docker image building or just building for the given machines architecture? The new docker plugin introduced here uses docker buildx under the hood. In theory a user can run this from any platform with docker installed and build an image for any other platform they want. My expectation is that we could build images for all architectures supported by the [alpine base image](https://hub.docker.com/_/alpine/tags) simply by adding them to the `` list. The only reason the list is currently limited to x86 and arm is that is all I am able to test. Also in my testing the ARM console image was unstable on my ARM Mac so I opted not to include it in the deployment here. I'm currently unsure what's causing this instability as the console runs fine on ARM without docker. > Update Maven plugin for docker-images building for M1 compatibility > --- > > Key: TINKERPOP-2852 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2852 > Project: TinkerPop > Issue Type: Improvement > Components: build-release >Affects Versions: 3.5.4 >Reporter: Yang Xia >Priority: Critical > > The current Maven plug in we use for the `docker-image` building profile is > no longer maintained > ([https://github.com/spotify/dockerfile-maven)|https://github.com/spotify/dockerfile-maven).], > and it is also not compatible with M1 Macs. > We should consider swapping the plug in for an actively maintained one that > is M1 compatible, for example > [https://github.com/fabric8io/docker-maven-plugin/issues/1257.|https://github.com/fabric8io/docker-maven-plugin/issues/1257] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TINKERPOP-2852) Update Maven plugin for docker-images building for M1 compatibility
[ https://issues.apache.org/jira/browse/TINKERPOP-2852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17715202#comment-17715202 ] ASF GitHub Bot commented on TINKERPOP-2852: --- lyndonbauto commented on PR #2007: URL: https://github.com/apache/tinkerpop/pull/2007#issuecomment-1518426644 Made a couple nits, feel free to commit or ignore them. So does this now support building on x64 and aarch64? Also does it support cross platform docker image building or just building for the given machines architecture? > Update Maven plugin for docker-images building for M1 compatibility > --- > > Key: TINKERPOP-2852 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2852 > Project: TinkerPop > Issue Type: Improvement > Components: build-release >Affects Versions: 3.5.4 >Reporter: Yang Xia >Priority: Critical > > The current Maven plug in we use for the `docker-image` building profile is > no longer maintained > ([https://github.com/spotify/dockerfile-maven)|https://github.com/spotify/dockerfile-maven).], > and it is also not compatible with M1 Macs. > We should consider swapping the plug in for an actively maintained one that > is M1 compatible, for example > [https://github.com/fabric8io/docker-maven-plugin/issues/1257.|https://github.com/fabric8io/docker-maven-plugin/issues/1257] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TINKERPOP-2852) Update Maven plugin for docker-images building for M1 compatibility
[
https://issues.apache.org/jira/browse/TINKERPOP-2852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17715201#comment-17715201
]
ASF GitHub Bot commented on TINKERPOP-2852:
---
lyndonbauto commented on code in PR #2007:
URL: https://github.com/apache/tinkerpop/pull/2007#discussion_r1174226183
##
gremlin-server/pom.xml:
##
@@ -378,60 +412,28 @@ limitations under the License.
-com.spotify
-dockerfile-maven-plugin
+io.fabric8
+docker-maven-plugin
-docker-image-build
+docker:build
build
-
-${project.version}
-
-
target/apache-tinkerpop-${project.artifactId}-${project.version}-standalone
-
-
-
-
-docker-image-tag-minor-version
-
-tag
-
-
-
${parsedVersion.majorVersion}.${parsedVersion.minorVersion}
-
${only.when.is.prerelease.version}
-
+package
-docker-image-push
-deploy
+docker:push
push
-
-${project.version}
-${only.when.is.snapshot.used}
-
-
-
-docker-image-push-minor-version
deploy
-
-push
-
-
-
${parsedVersion.majorVersion}.${parsedVersion.minorVersion}
-
${only.when.is.prerelease.version}
-
-
-tinkerpop/gremlin-server
-
+
Review Comment:
```suggestion
```
> Update Maven plugin for docker-images building for M1 compatibility
> ---
>
> Key: TINKERPOP-2852
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2852
> Project: TinkerPop
> Issue Type: Improvement
> Components: build-release
>Affects Versions: 3.5.4
>Reporter: Yang Xia
>Priority: Critical
>
> The current Maven plug in we use for the `docker-image` building profile is
> no longer maintained
> ([https://github.com/spotify/dockerfile-maven)|https://github.com/spotify/dockerfile-maven).],
> and it is also not compatible with M1 Macs.
> We should consider swapping the plug in for an actively maintained one that
> is M1 compatible, for example
> [https://github.com/fabric8io/docker-maven-plugin/issues/1257.|https://github.com/fabric8io/docker-maven-plugin/issues/1257]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TINKERPOP-2852) Update Maven plugin for docker-images building for M1 compatibility
[ https://issues.apache.org/jira/browse/TINKERPOP-2852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17715200#comment-17715200 ] ASF GitHub Bot commented on TINKERPOP-2852: --- lyndonbauto commented on code in PR #2007: URL: https://github.com/apache/tinkerpop/pull/2007#discussion_r1174226024 ## gremlin-server/pom.xml: ## @@ -32,6 +32,8 @@ limitations under the License. --> false Update Maven plugin for docker-images building for M1 compatibility > --- > > Key: TINKERPOP-2852 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2852 > Project: TinkerPop > Issue Type: Improvement > Components: build-release >Affects Versions: 3.5.4 >Reporter: Yang Xia >Priority: Critical > > The current Maven plug in we use for the `docker-image` building profile is > no longer maintained > ([https://github.com/spotify/dockerfile-maven)|https://github.com/spotify/dockerfile-maven).], > and it is also not compatible with M1 Macs. > We should consider swapping the plug in for an actively maintained one that > is M1 compatible, for example > [https://github.com/fabric8io/docker-maven-plugin/issues/1257.|https://github.com/fabric8io/docker-maven-plugin/issues/1257] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TINKERPOP-2852) Update Maven plugin for docker-images building for M1 compatibility
[ https://issues.apache.org/jira/browse/TINKERPOP-2852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17714841#comment-17714841 ] ASF GitHub Bot commented on TINKERPOP-2852: --- FlorianHockmann commented on code in PR #2007: URL: https://github.com/apache/tinkerpop/pull/2007#discussion_r1173374302 ## pom.xml: ## @@ -345,11 +345,62 @@ limitations under the License. false + + Update Maven plugin for docker-images building for M1 compatibility > --- > > Key: TINKERPOP-2852 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2852 > Project: TinkerPop > Issue Type: Improvement > Components: build-release >Affects Versions: 3.5.4 >Reporter: Yang Xia >Priority: Critical > > The current Maven plug in we use for the `docker-image` building profile is > no longer maintained > ([https://github.com/spotify/dockerfile-maven)|https://github.com/spotify/dockerfile-maven).], > and it is also not compatible with M1 Macs. > We should consider swapping the plug in for an actively maintained one that > is M1 compatible, for example > [https://github.com/fabric8io/docker-maven-plugin/issues/1257.|https://github.com/fabric8io/docker-maven-plugin/issues/1257] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TINKERPOP-2852) Update Maven plugin for docker-images building for M1 compatibility
[ https://issues.apache.org/jira/browse/TINKERPOP-2852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17714753#comment-17714753 ] ASF GitHub Bot commented on TINKERPOP-2852: --- Cole-Greer commented on PR #2007: URL: https://github.com/apache/tinkerpop/pull/2007#issuecomment-1516940988 @FlorianHockmann Looks like I accidentally removed too much when I attempted to remove the `latest` tag from 3.5 which was the cause of that error you observed. I have fixed that and run several tests deploying images with different versions to a personal dockerhub repo. You can see all of the tags here (https://hub.docker.com/repository/docker/colegreer/gremlin-console/tags?page=1&ordering=last_updated, https://hub.docker.com/repository/docker/colegreer/gremlin-server/tags?page=1&ordering=last_updated). I tested deployments of `3.5.6-SNAPSHOT`, `3.5.7`, `3.6.3-SNAPSHOT`, and `3.6.4` to ensure we are getting the correct tags for all of them. When running these tests I temporarily moved the `docker:push` execution from the `deploy` phase to the `install` phase as I wanted to test docker deployment without triggering any of the other deploy phase goals. It's also noteworthy that the new plugin does not attempt to build the full multi-arch image during the build goal. The reasoning for this being that multi-arch images are much larger in size and slow to build. The full multi-arch image is not built until the `push` goal is executed. This isn't ideal for us but there doesn't appear to be a good workaround with this plugin. Ultimately I don't think it is a big issue though, as we only need the multi-arch images during deployment. > Update Maven plugin for docker-images building for M1 compatibility > --- > > Key: TINKERPOP-2852 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2852 > Project: TinkerPop > Issue Type: Improvement > Components: build-release >Affects Versions: 3.5.4 >Reporter: Yang Xia >Priority: Critical > > The current Maven plug in we use for the `docker-image` building profile is > no longer maintained > ([https://github.com/spotify/dockerfile-maven)|https://github.com/spotify/dockerfile-maven).], > and it is also not compatible with M1 Macs. > We should consider swapping the plug in for an actively maintained one that > is M1 compatible, for example > [https://github.com/fabric8io/docker-maven-plugin/issues/1257.|https://github.com/fabric8io/docker-maven-plugin/issues/1257] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TINKERPOP-2852) Update Maven plugin for docker-images building for M1 compatibility
[ https://issues.apache.org/jira/browse/TINKERPOP-2852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17714199#comment-17714199 ] ASF GitHub Bot commented on TINKERPOP-2852: --- Cole-Greer commented on PR #2007: URL: https://github.com/apache/tinkerpop/pull/2007#issuecomment-1515052170 > Is it working for you when you change the version to a non-prerelease one? @FlorianHockmann That is strange. The tags were working as expected in my testing before submitting the PR. More investigation and testing is needed, I have converted this back to a draft PR for the meantime. > Update Maven plugin for docker-images building for M1 compatibility > --- > > Key: TINKERPOP-2852 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2852 > Project: TinkerPop > Issue Type: Improvement > Components: build-release >Affects Versions: 3.5.4 >Reporter: Yang Xia >Priority: Critical > > The current Maven plug in we use for the `docker-image` building profile is > no longer maintained > ([https://github.com/spotify/dockerfile-maven)|https://github.com/spotify/dockerfile-maven).], > and it is also not compatible with M1 Macs. > We should consider swapping the plug in for an actively maintained one that > is M1 compatible, for example > [https://github.com/fabric8io/docker-maven-plugin/issues/1257.|https://github.com/fabric8io/docker-maven-plugin/issues/1257] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TINKERPOP-2852) Update Maven plugin for docker-images building for M1 compatibility
[ https://issues.apache.org/jira/browse/TINKERPOP-2852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17714016#comment-17714016 ] ASF GitHub Bot commented on TINKERPOP-2852: --- FlorianHockmann commented on code in PR #2007: URL: https://github.com/apache/tinkerpop/pull/2007#discussion_r1171052912 ## pom.xml: ## @@ -345,6 +345,55 @@ limitations under the License. false + + Update Maven plugin for docker-images building for M1 compatibility > --- > > Key: TINKERPOP-2852 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2852 > Project: TinkerPop > Issue Type: Improvement > Components: build-release >Affects Versions: 3.5.4 >Reporter: Yang Xia >Priority: Critical > > The current Maven plug in we use for the `docker-image` building profile is > no longer maintained > ([https://github.com/spotify/dockerfile-maven)|https://github.com/spotify/dockerfile-maven).], > and it is also not compatible with M1 Macs. > We should consider swapping the plug in for an actively maintained one that > is M1 compatible, for example > [https://github.com/fabric8io/docker-maven-plugin/issues/1257.|https://github.com/fabric8io/docker-maven-plugin/issues/1257] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TINKERPOP-2852) Update Maven plugin for docker-images building for M1 compatibility
[ https://issues.apache.org/jira/browse/TINKERPOP-2852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713719#comment-17713719 ] ASF GitHub Bot commented on TINKERPOP-2852: --- kenhuuu commented on PR #2007: URL: https://github.com/apache/tinkerpop/pull/2007#issuecomment-1513657376 VOTE +1 > Update Maven plugin for docker-images building for M1 compatibility > --- > > Key: TINKERPOP-2852 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2852 > Project: TinkerPop > Issue Type: Improvement > Components: build-release >Affects Versions: 3.5.4 >Reporter: Yang Xia >Priority: Critical > > The current Maven plug in we use for the `docker-image` building profile is > no longer maintained > ([https://github.com/spotify/dockerfile-maven)|https://github.com/spotify/dockerfile-maven).], > and it is also not compatible with M1 Macs. > We should consider swapping the plug in for an actively maintained one that > is M1 compatible, for example > [https://github.com/fabric8io/docker-maven-plugin/issues/1257.|https://github.com/fabric8io/docker-maven-plugin/issues/1257] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TINKERPOP-2852) Update Maven plugin for docker-images building for M1 compatibility
[ https://issues.apache.org/jira/browse/TINKERPOP-2852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17711230#comment-17711230 ] ASF GitHub Bot commented on TINKERPOP-2852: --- Cole-Greer commented on code in PR #2007: URL: https://github.com/apache/tinkerpop/pull/2007#discussion_r1163729269 ## pom.xml: ## @@ -345,6 +345,55 @@ limitations under the License. false + + Update Maven plugin for docker-images building for M1 compatibility > --- > > Key: TINKERPOP-2852 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2852 > Project: TinkerPop > Issue Type: Improvement > Components: build-release >Affects Versions: 3.5.4 >Reporter: Yang Xia >Priority: Critical > > The current Maven plug in we use for the `docker-image` building profile is > no longer maintained > ([https://github.com/spotify/dockerfile-maven)|https://github.com/spotify/dockerfile-maven).], > and it is also not compatible with M1 Macs. > We should consider swapping the plug in for an actively maintained one that > is M1 compatible, for example > [https://github.com/fabric8io/docker-maven-plugin/issues/1257.|https://github.com/fabric8io/docker-maven-plugin/issues/1257] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TINKERPOP-2852) Update Maven plugin for docker-images building for M1 compatibility
[ https://issues.apache.org/jira/browse/TINKERPOP-2852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17711212#comment-17711212 ] ASF GitHub Bot commented on TINKERPOP-2852: --- FlorianHockmann commented on code in PR #2007: URL: https://github.com/apache/tinkerpop/pull/2007#discussion_r1163682374 ## pom.xml: ## @@ -345,6 +345,55 @@ limitations under the License. false + + Update Maven plugin for docker-images building for M1 compatibility > --- > > Key: TINKERPOP-2852 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2852 > Project: TinkerPop > Issue Type: Improvement > Components: build-release >Affects Versions: 3.5.4 >Reporter: Yang Xia >Priority: Critical > > The current Maven plug in we use for the `docker-image` building profile is > no longer maintained > ([https://github.com/spotify/dockerfile-maven)|https://github.com/spotify/dockerfile-maven).], > and it is also not compatible with M1 Macs. > We should consider swapping the plug in for an actively maintained one that > is M1 compatible, for example > [https://github.com/fabric8io/docker-maven-plugin/issues/1257.|https://github.com/fabric8io/docker-maven-plugin/issues/1257] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TINKERPOP-2852) Update Maven plugin for docker-images building for M1 compatibility
[ https://issues.apache.org/jira/browse/TINKERPOP-2852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17711050#comment-17711050 ] ASF GitHub Bot commented on TINKERPOP-2852: --- Cole-Greer commented on code in PR #2007: URL: https://github.com/apache/tinkerpop/pull/2007#discussion_r1163069019 ## pom.xml: ## @@ -345,6 +345,55 @@ limitations under the License. false + + Update Maven plugin for docker-images building for M1 compatibility > --- > > Key: TINKERPOP-2852 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2852 > Project: TinkerPop > Issue Type: Improvement > Components: build-release >Affects Versions: 3.5.4 >Reporter: Yang Xia >Priority: Critical > > The current Maven plug in we use for the `docker-image` building profile is > no longer maintained > ([https://github.com/spotify/dockerfile-maven)|https://github.com/spotify/dockerfile-maven).], > and it is also not compatible with M1 Macs. > We should consider swapping the plug in for an actively maintained one that > is M1 compatible, for example > [https://github.com/fabric8io/docker-maven-plugin/issues/1257.|https://github.com/fabric8io/docker-maven-plugin/issues/1257] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TINKERPOP-2852) Update Maven plugin for docker-images building for M1 compatibility
[ https://issues.apache.org/jira/browse/TINKERPOP-2852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17711046#comment-17711046 ] ASF GitHub Bot commented on TINKERPOP-2852: --- Cole-Greer commented on code in PR #2007: URL: https://github.com/apache/tinkerpop/pull/2007#discussion_r1163057037 ## pom.xml: ## @@ -345,6 +345,55 @@ limitations under the License. false + + Update Maven plugin for docker-images building for M1 compatibility > --- > > Key: TINKERPOP-2852 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2852 > Project: TinkerPop > Issue Type: Improvement > Components: build-release >Affects Versions: 3.5.4 >Reporter: Yang Xia >Priority: Critical > > The current Maven plug in we use for the `docker-image` building profile is > no longer maintained > ([https://github.com/spotify/dockerfile-maven)|https://github.com/spotify/dockerfile-maven).], > and it is also not compatible with M1 Macs. > We should consider swapping the plug in for an actively maintained one that > is M1 compatible, for example > [https://github.com/fabric8io/docker-maven-plugin/issues/1257.|https://github.com/fabric8io/docker-maven-plugin/issues/1257] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TINKERPOP-2852) Update Maven plugin for docker-images building for M1 compatibility
[ https://issues.apache.org/jira/browse/TINKERPOP-2852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17710865#comment-17710865 ] ASF GitHub Bot commented on TINKERPOP-2852: --- FlorianHockmann commented on code in PR #2007: URL: https://github.com/apache/tinkerpop/pull/2007#discussion_r1162603370 ## pom.xml: ## @@ -345,6 +345,55 @@ limitations under the License. false + + Update Maven plugin for docker-images building for M1 compatibility > --- > > Key: TINKERPOP-2852 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2852 > Project: TinkerPop > Issue Type: Improvement > Components: build-release >Affects Versions: 3.5.4 >Reporter: Yang Xia >Priority: Critical > > The current Maven plug in we use for the `docker-image` building profile is > no longer maintained > ([https://github.com/spotify/dockerfile-maven)|https://github.com/spotify/dockerfile-maven).], > and it is also not compatible with M1 Macs. > We should consider swapping the plug in for an actively maintained one that > is M1 compatible, for example > [https://github.com/fabric8io/docker-maven-plugin/issues/1257.|https://github.com/fabric8io/docker-maven-plugin/issues/1257] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TINKERPOP-2852) Update Maven plugin for docker-images building for M1 compatibility
[ https://issues.apache.org/jira/browse/TINKERPOP-2852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17709492#comment-17709492 ] ASF GitHub Bot commented on TINKERPOP-2852: --- codecov-commenter commented on PR #2007: URL: https://github.com/apache/tinkerpop/pull/2007#issuecomment-1499528300 ## [Codecov](https://codecov.io/gh/apache/tinkerpop/pull/2007?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#2007](https://codecov.io/gh/apache/tinkerpop/pull/2007?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b937b3e) into [3.5-dev](https://codecov.io/gh/apache/tinkerpop/commit/8267422b1e583f26797425b22ace0789f3be1e6d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8267422) will **increase** coverage by `0.00%`. > The diff coverage is `n/a`. ```diff @@Coverage Diff @@ ## 3.5-dev#2007 +/- ## == Coverage 69.37% 69.37% - Complexity 8959 8966+7 == Files866 866 Lines 4118341219 +36 Branches5423 5432+9 == + Hits 2857028595 +25 - Misses 1070410712+8 - Partials1909 1912+3 ``` [see 13 files with indirect coverage changes](https://codecov.io/gh/apache/tinkerpop/pull/2007/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > Update Maven plugin for docker-images building for M1 compatibility > --- > > Key: TINKERPOP-2852 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2852 > Project: TinkerPop > Issue Type: Improvement > Components: build-release >Affects Versions: 3.5.4 >Reporter: Yang Xia >Priority: Critical > > The current Maven plug in we use for the `docker-image` building profile is > no longer maintained > ([https://github.com/spotify/dockerfile-maven)|https://github.com/spotify/dockerfile-maven).], > and it is also not compatible with M1 Macs. > We should consider swapping the plug in for an actively maintained one that > is M1 compatible, for example > [https://github.com/fabric8io/docker-maven-plugin/issues/1257.|https://github.com/fabric8io/docker-maven-plugin/issues/1257] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TINKERPOP-2852) Update Maven plugin for docker-images building for M1 compatibility
[ https://issues.apache.org/jira/browse/TINKERPOP-2852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706613#comment-17706613 ] ASF GitHub Bot commented on TINKERPOP-2852: --- Cole-Greer opened a new pull request, #2007: URL: https://github.com/apache/tinkerpop/pull/2007 Replaces spotify plugin with io.fabric8 docker-maven-plugin. The new plugin has the benefit of supporting multi-arch images through buildx for deployments and it is an actively maintained plugin as opposed to the spotify plugin. The new plugin continues to fetch auth credentials from the same location so no changes to the release environment will be necessary. I have tested the full set of .Net gherkin and integration tests against the new image with no issues. I have also used [container-diff](https://github.com/GoogleContainerTools/container-diff) to compare the new image to the one that we currently build using the mvn exec plugin and docker compose. These are the results: ``` -File- These entries have been added to colegreer/tinkerpop:server-3.5.6-SNAPSHOT: None These entries have been deleted from colegreer/tinkerpop:server-3.5.6-SNAPSHOT: None These entries have been changed between colegreer/tinkerpop:server-3.5.6-SNAPSHOT and tinkerpop/gremlin-server:3.5.6-SNAPSHOT: FILE SIZE1 SIZE2 /opt/gremlin-server/lib/gremlin-server-3.5.6-SNAPSHOT.jar243K 242.8K /etc/ssl/certs/java/cacerts 155.3K 155.3K -Apt- Packages found only in colegreer/tinkerpop:server-3.5.6-SNAPSHOT: None Packages found only in tinkerpop/gremlin-server:3.5.6-SNAPSHOT: None Version differences: None ``` I haven't yet identified the minute difference in the jar file between the two images. I can investigate this further if anyone views it as a potential concern. TODO: Switch gremlin-console to new plugin. Support manual image deployment as similar to what `mvn dockerfile:push` currently does. > Update Maven plugin for docker-images building for M1 compatibility > --- > > Key: TINKERPOP-2852 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2852 > Project: TinkerPop > Issue Type: Improvement > Components: build-release >Affects Versions: 3.5.4 >Reporter: Yang Xia >Priority: Critical > > The current Maven plug in we use for the `docker-image` building profile is > no longer maintained > ([https://github.com/spotify/dockerfile-maven)|https://github.com/spotify/dockerfile-maven).], > and it is also not compatible with M1 Macs. > We should consider swapping the plug in for an actively maintained one that > is M1 compatible, for example > [https://github.com/fabric8io/docker-maven-plugin/issues/1257.|https://github.com/fabric8io/docker-maven-plugin/issues/1257] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TINKERPOP-2852) Update Maven plugin for docker-images building for M1 compatibility
[ https://issues.apache.org/jira/browse/TINKERPOP-2852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654689#comment-17654689 ] Cole Greer commented on TINKERPOP-2852: --- If for some reason anyone finds it essential to run the `docker-images` profile as is on an apple silicon mac, a viable work around is to install and run maven from an x86 JDK build. I have had success doing so with Oracle OpenJDK 11.0.2 for intel macs. > Update Maven plugin for docker-images building for M1 compatibility > --- > > Key: TINKERPOP-2852 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2852 > Project: TinkerPop > Issue Type: Improvement >Reporter: Yang Xia >Priority: Major > > The current Maven plug in we use for the `docker-image` building profile is > no longer maintained > ([https://github.com/spotify/dockerfile-maven)|https://github.com/spotify/dockerfile-maven).], > and it is also not compatible with M1 Macs. > We should consider swapping the plug in for an actively maintained one that > is M1 compatible, for example > [https://github.com/fabric8io/docker-maven-plugin/issues/1257.|https://github.com/fabric8io/docker-maven-plugin/issues/1257] -- This message was sent by Atlassian Jira (v8.20.10#820010)
