svn commit: r380645 - /tomcat/connectors/trunk/util/java/org/apache/tomcat/util/digester/Digester.java

2006-02-24 Thread remm
Author: remm
Date: Fri Feb 24 03:37:46 2006
New Revision: 380645

URL: http://svn.apache.org/viewcvs?rev=380645view=rev
Log:
- Refresh loggers being used, to make sure the current webapp logger is used.

Modified:

tomcat/connectors/trunk/util/java/org/apache/tomcat/util/digester/Digester.java

Modified: 
tomcat/connectors/trunk/util/java/org/apache/tomcat/util/digester/Digester.java
URL: 
http://svn.apache.org/viewcvs/tomcat/connectors/trunk/util/java/org/apache/tomcat/util/digester/Digester.java?rev=380645r1=380644r2=380645view=diff
==
--- 
tomcat/connectors/trunk/util/java/org/apache/tomcat/util/digester/Digester.java 
(original)
+++ 
tomcat/connectors/trunk/util/java/org/apache/tomcat/util/digester/Digester.java 
Fri Feb 24 03:37:46 2006
@@ -2338,7 +2338,10 @@
 params.clear();
 publicId = null;
 stack.clear();
-
+log = null;
+saxLog = null;
+configured = false;
+
 }
 
 
@@ -2550,6 +2553,9 @@
 if (configured) {
 return;
 }
+
+log = LogFactory.getLog(org.apache.commons.digester.Digester);
+saxLog = LogFactory.getLog(org.apache.commons.digester.Digester.sax);
 
 // Perform lazy configuration as needed
 initialize(); // call hook method for subclasses that want to be 
initialized once only



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r380673 - /tomcat/build/tc5.5.x/build.properties.default

2006-02-24 Thread remm
Author: remm
Date: Fri Feb 24 06:11:27 2006
New Revision: 380673

URL: http://svn.apache.org/viewcvs?rev=380673view=rev
Log:
- Update to JDT 3.1.2.

Modified:
tomcat/build/tc5.5.x/build.properties.default

Modified: tomcat/build/tc5.5.x/build.properties.default
URL: 
http://svn.apache.org/viewcvs/tomcat/build/tc5.5.x/build.properties.default?rev=380673r1=380672r2=380673view=diff
==
--- tomcat/build/tc5.5.x/build.properties.default (original)
+++ tomcat/build/tc5.5.x/build.properties.default Fri Feb 24 06:11:27 2006
@@ -134,11 +134,11 @@
 xerces.loc=${base-xml.loc}/xerces-j/binaries/Xerces-J-bin.2.7.1.tar.gz
 
 
-# - Eclipse JDT, version 3.1.1 or later -
+# - Eclipse JDT, version 3.1.2 or later -
 jdt.home=${base.path}/eclipse/plugins
 jdt.lib=${jdt.home}
-jdt.jar=${jdt.lib}/org.eclipse.jdt.core_3.1.1.jar
-jdt.loc=http://sunsite.informatik.rwth-aachen.de/eclipse/downloads/drops/R-3.1.1-200509290840/eclipse-JDT-3.1.1.zip
+jdt.jar=${jdt.lib}/org.eclipse.jdt.core_3.1.2.jar
+jdt.loc=http://sunsite.informatik.rwth-aachen.de/eclipse/downloads/drops/R-3.1.2-200601181600/eclipse-JDT-3.1.2.zip
 
 
 # - Tomcat native library -



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 38740] - (5.5.15) session attributes set in sessionCreated not synched

2006-02-24 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=38740.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38740





--- Additional Comments From [EMAIL PROTECTED]  2006-02-24 15:45 ---
Attributes set by a session listener via setAttribute in sessionCreated are not
replicated via the cluster. Only the creation of the session (it's ID) is being
replicated and after the listener was called the DeltaRequest is being reset.

But: if notifySessionListenersOnReplication=true for the cluster manager - which
is the default - then the listener is called after replicating the session
creation on the remote side and will then set the Attribute there again. That's
why the attribute can be found on the remote side.

CAUTION: Replicating an attribute and setting it independently on the primary
and secondary nodes might not be the same. It depends on the type of the
attribute if that results in an application problem or not.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 38779] New: - Wrong class name in org/apache/catalina/cluster/tcp/mbeans-descriptors.xml

2006-02-24 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=38779.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38779

   Summary: Wrong class name in
org/apache/catalina/cluster/tcp/mbeans-descriptors.xml
   Product: Tomcat 5
   Version: 5.5.14
  Platform: All
OS/Version: All
Status: NEW
  Severity: trivial
  Priority: P3
 Component: Catalina:Cluster
AssignedTo: tomcat-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]


This bug is found in 5.5.15!!

In file org/apache/catalina/cluster/tcp/mbeans-descriptors.xml there is a class
section:
  parameter name=message
 description=replication message
 type=org.apache.catalina..cluster.ClusterMessage/

So, org.apache.catalina..cluster.ClusterMessage should be replaced
with org.apache.catalina.cluster.ClusterMessage 

Without this fix there is an exception like below:
11:33:06 main [org.apache.catalina.cluster.tcp.SimpleTcpCluster]: INFO  Cluster
is about to start
11:33:07 main [org.apache.catalina.cluster.tcp.SimpleTcpCluster]: ERROR Cannot
instantiate ModelMBean of class org.apache.commons.modeler.BaseModelMBean
javax.management.MBeanException: Cannot instantiate ModelMBean of class
org.apache.commons.modeler.BaseModelMBean
at 
org.apache.commons.modeler.ManagedBean.createMBean(ManagedBean.java:430)
at
org.apache.catalina.cluster.tcp.SimpleTcpCluster.getManagedBean(SimpleTcpCluster.java:1340)
at
org.apache.catalina.cluster.tcp.SimpleTcpCluster.registerMBeans(SimpleTcpCluster.java:1289)
at
org.apache.catalina.cluster.tcp.SimpleTcpCluster.start(SimpleTcpCluster.java:732)
at org.apache.catalina.core.ContainerBase.start(ContainerBase.java:1002)
at org.apache.catalina.core.StandardHost.start(StandardHost.java:718)
at org.apache.catalina.core.ContainerBase.start(ContainerBase.java:1012)
at 
org.apache.catalina.core.StandardEngine.start(StandardEngine.java:442)
at org.apache.catalina.startup.Embedded.start(Embedded.java:821)
at
fi.gtech.esi.player.channel.util.EmbeddedTomcat.start(EmbeddedTomcat.java:186)
at
fi.gtech.esi.player.channel.mgmt.Management.startComponent(Management.java:306)
at 
fi.gtech.esi.player.channel.mgmt.Management.start(Management.java:204)
at 
fi.gtech.esi.player.channel.mgmt.Management.start(Management.java:129)
at fi.gtech.esi.player.channel.mgmt.Management.main(Management.java:117)
Caused by: java.lang.IllegalArgumentException: Not a valid Java type name:
org.apache.catalina..cluster.ClusterMessage
at 
javax.management.MBeanInfo.mustBeValidJavaTypeName(MBeanInfo.java:470)
at 
javax.management.MBeanParameterInfo.init(MBeanParameterInfo.java:58)
at
org.apache.commons.modeler.ParameterInfo.createParameterInfo(ParameterInfo.java:175)
at
org.apache.commons.modeler.OperationInfo.createOperationInfo(OperationInfo.java:251)
at
org.apache.commons.modeler.ManagedBean.createMBeanInfo(ManagedBean.java:480)
at 
org.apache.commons.modeler.ManagedBean.createMBean(ManagedBean.java:424)

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 38740] - (5.5.15) session attributes set in sessionCreated not synched

2006-02-24 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=38740.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38740





--- Additional Comments From [EMAIL PROTECTED]  2006-02-24 16:38 ---
That's a good point Rainer -- in your test config Filip, did you enable
notifySessionListenersOnReplication?

I still think this is a valid bug, but I'll leave it to you to reopen.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 38776] - Jsp generated servlet classes have bad SourceFile attribute

2006-02-24 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=38776.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38776





--- Additional Comments From [EMAIL PROTECTED]  2006-02-24 17:28 ---
This is an Eclipse JDT compiler problem.  I searched Eclipse Bugzilla and didn't
see any bug resembling this so you could open a bug there.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Using APR with tomcat leaves port 8009 bound when tomcat is terminated?

2006-02-24 Thread Jim Jagielski


On Feb 24, 2006, at 11:15 AM, Jim Jagielski wrote:



On Feb 23, 2006, at 11:53 AM, Remy Maucherat wrote:


Jim Jagielski wrote:

I agree that the change is a big benefit, and for
most OSs we care about, SO_REUSEADDR is available.
The APR call should gracefully fail...
I'll plug this in later on today after some edge-case tests.


In AprEndpoint, there are a lot of Socket.optSet(serverSock,  
Socket.APR_SO_REUSEADDR, 1);




Yes, the only rub is that for reasons I'm trying to remind myself
why, we do the setting before the bind under non-Windows, and
afterwards on Windows...



Anyway, while I research this, I went the safe route
and adjusted the ordering to match httpd.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: never say never...

2006-02-24 Thread Glen Mazza

Haroon Rafique wrote:


On Tuesday at 12:54pm, JB=Jay Burgess [EMAIL PROTECTED] wrote:

JB The following comments are not intended to be a personal attack on 
JB anyone. However, I can't stand by and watch George speak my mind for 
JB me, word for word, and not chime in and say I agree!.  Plus, I think 
JB if you took a poll, you'd find he speaks for a large number of list 
JB subcribers.
JB 

Yes Jay, other members have that feeling too. If we take a look at the 
recent past, there are various examples of rudeness, impropriety and lack 
of respect.




Well, my sympathies are more with the Tomcat developer team, given the 
abuse they incur from certain unfortunate individuals in the user 
community.




There's the thread:
http://marc.theaimsgroup.com/?t=11310796102r=1w=2
Subject: Sloppy, Lazy Tomcat Developers (Was: Persistent) which speaks 
volumes about how the tomcat dev community is turning people away. 



I checked the thread and didn't see anything wrong with what was stated 
by the Tomcat developers.  They're only properly defending themselves 
against abuse from a disrespectful user.  How would you expect any team 
to respond to an email with a subject of Sloppy, Lazy Tomcat Developers?


Glen

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 37213] - problem when running tomcat with -security option

2006-02-24 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=37213.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37213





--- Additional Comments From [EMAIL PROTECTED]  2006-02-24 18:57 ---
I got the same problem.

The problem occurs if log4j is configured to write to a file where log4j th
webapp does not have permission to write to.

the original exception
java.security.AccessControlException: access denied (java.io.FilePermission
\_training\webapps\fear\WebRoot\l
og.html write)

gets some how converted (log4j??) to a 
Caused by: java.lang.NoClassDefFoundError

and than converted by commons-logging to a :
java.lang.reflect.InvocationTargetException

Each time the a static initialization of logger is done a
java.lang.ExceptionInInitializerError is thrown.

This makes tomcat loop trying to clean up the webapplication:
...
GRAVE: Context [/max64] startup failed due to previous errors
24-feb-2006 17.16.09 org.apache.catalina.core.StandardContext start
GRAVE: Exception during cleanup after start failed
...
24-feb-2006 17.16.31 org.apache.catalina.startup.ContextConfig 
applicationWebConfig
GRAVE: Context [/max64] startup failed due to previous errors
24-feb-2006 17.16.31 org.apache.catalina.core.StandardContext start
GRAVE: Exception during cleanup after start failed

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



TomCat monitoring

2006-02-24 Thread Michael Gesundheit
Hi,
   
  I'm looking for any information concerning TomCat runtime monitoring. 
Resources status, Memory consumption etc.
  I could not find any material about this issue on the official web site.
   
  Any clue?
   
  Thanks,
  -Michael


svn commit: r380776 - /tomcat/container/branches/tc4.1.x/catalina/src/share/org/apache/catalina/servlets/HTMLManagerServlet.java

2006-02-24 Thread markt
Author: markt
Date: Fri Feb 24 10:44:13 2006
New Revision: 380776

URL: http://svn.apache.org/viewcvs?rev=380776view=rev
Log:
More TLP related changes.

Modified:

tomcat/container/branches/tc4.1.x/catalina/src/share/org/apache/catalina/servlets/HTMLManagerServlet.java

Modified: 
tomcat/container/branches/tc4.1.x/catalina/src/share/org/apache/catalina/servlets/HTMLManagerServlet.java
URL: 
http://svn.apache.org/viewcvs/tomcat/container/branches/tc4.1.x/catalina/src/share/org/apache/catalina/servlets/HTMLManagerServlet.java?rev=380776r1=380775r2=380776view=diff
==
--- 
tomcat/container/branches/tc4.1.x/catalina/src/share/org/apache/catalina/servlets/HTMLManagerServlet.java
 (original)
+++ 
tomcat/container/branches/tc4.1.x/catalina/src/share/org/apache/catalina/servlets/HTMLManagerServlet.java
 Fri Feb 24 10:44:13 2006
@@ -626,11 +626,11 @@
 table cellspacing=\4\ width=\100%\ border=\0\\n +
  tr\n +
   td colspan=\2\\n +
-   a href=\http://jakarta.apache.org/\;\n +
-img border=\0\ alt=\The Jakarta Project\ align=\left\\n +
- src=\{0}/images/jakarta-logo.gif\\n +
+   a href=\http://www.apache.org/\;\n +
+img border=\0\ alt=\The Apache Software Foundation\+
+ align=\left\\n src=\{0}/images/asf-logo.gif\\n +
/a\n +
-   a href=\http://jakarta.apache.org/tomcat/\;\n +
+   a href=\http://tomcat.apache.org/\;\n +
 img border=\0\ alt=\The Tomcat Servlet/JSP Container\\n +
  align=\right\ src=\{0}/images/tomcat.gif\\n +
/a\n +



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: TomCat monitoring

2006-02-24 Thread Diego
Michael,
  here is an article about monitoring tomcat clusters (skip the cluster
section if you want)
 http://www.devx.com/Java/Article/21726/1954?pf=true

  and here is an open source application for monitoring j2ee servers using
JMX. I think tomcat is supported
 http://sourceforge.net/projects/mc4j


On 2/24/06, Michael Gesundheit [EMAIL PROTECTED] wrote:

 Hi,

 I'm looking for any information concerning TomCat runtime monitoring.
 Resources status, Memory consumption etc.
 I could not find any material about this issue on the official web site.

 Any clue?

 Thanks,
 -Michael




svn commit: r380807 - in /tomcat/container/branches/tc4.1.x: BUILDING.txt build.properties.default build.xml tomcat.nsi

2006-02-24 Thread markt
Author: markt
Date: Fri Feb 24 12:19:46 2006
New Revision: 380807

URL: http://svn.apache.org/viewcvs?rev=380807view=rev
Log:
Use procrun from commons-daemon rather than JavaService to enable Tomcat to run 
as a service on Windows.

Modified:
tomcat/container/branches/tc4.1.x/BUILDING.txt
tomcat/container/branches/tc4.1.x/build.properties.default
tomcat/container/branches/tc4.1.x/build.xml
tomcat/container/branches/tc4.1.x/tomcat.nsi

Modified: tomcat/container/branches/tc4.1.x/BUILDING.txt
URL: 
http://svn.apache.org/viewcvs/tomcat/container/branches/tc4.1.x/BUILDING.txt?rev=380807r1=380806r2=380807view=diff
==
--- tomcat/container/branches/tc4.1.x/BUILDING.txt (original)
+++ tomcat/container/branches/tc4.1.x/BUILDING.txt Fri Feb 24 12:19:46 2006
@@ -1,3 +1,4 @@
+
 $Id$
 
 
@@ -506,17 +507,7 @@
   own subdirectory.
 
 
-(31) JavaService
-
-* Download the JavaService package (version 1.2.0 or later) from:
-
-http://www.alexandriasc.com/software/JavaService/JavaService-bin-1.2.0.zip
-
-* Install the application into a convenient location so that it resides in its
-  own subdirectory.
-
-
-(32) Run Ant
+(31) Run Ant
 
 Open a command line shell, and issue the following commands:
 
@@ -525,10 +516,9 @@
 
 
 
-(33) Build the release distribution - OPTIONAL
+(32) Build the release distribution - OPTIONAL
 
 Open a command line shell, and issue the following commands:
 
   cd ${tomcat.source}/container
   ant release
-

Modified: tomcat/container/branches/tc4.1.x/build.properties.default
URL: 
http://svn.apache.org/viewcvs/tomcat/container/branches/tc4.1.x/build.properties.default?rev=380807r1=380806r2=380807view=diff
==
--- tomcat/container/branches/tc4.1.x/build.properties.default (original)
+++ tomcat/container/branches/tc4.1.x/build.properties.default Fri Feb 24 
12:19:46 2006
@@ -170,11 +170,6 @@
 
commons-pool.loc=${base-jakarta.loc}/commons/pool/binaries/commons-pool-1.2.tar.gz
 
 
-# - JavaService, version 1.2.0 or later -
-javaservice.home=${base.path}/javaservice
-javaservice.loc=http://www.alexandriasc.com/software/JavaService/JavaService-bin-1.2.0.zip
-
-
 # - Java Database Connectivity (JDBC) Optional Package, version 2.0 -
 jdbc20ext.home=${base.path}/jdbc2_0-stdext
 jdbc20ext.lib=${jdbc20ext.home}

Modified: tomcat/container/branches/tc4.1.x/build.xml
URL: 
http://svn.apache.org/viewcvs/tomcat/container/branches/tc4.1.x/build.xml?rev=380807r1=380806r2=380807view=diff
==
--- tomcat/container/branches/tc4.1.x/build.xml (original)
+++ tomcat/container/branches/tc4.1.x/build.xml Fri Feb 24 12:19:46 2006
@@ -35,7 +35,6 @@
   !-- Build Defaults --
   property name=catalina.build   value=${basedir}/catalina/build/
   property name=jasper.build value=${jasper.home}/build/
-  property name=javaservice.home value=../javaservice/
   property name=nsis.homevalue=c:\program files\nsis/
   property name=servlet.home value=${api.home}/dist/
   property name=tomcat.build value=${basedir}/build/
@@ -285,8 +284,11 @@
 /copy
 copy file=${nsis.home}/Plugins/InstallOptions.dll 
  todir=${tomcat.dist} /
-copy file=${javaservice.home}/bin/JavaService.exe 
- tofile=${tomcat.dist}/bin/tomcat.exe /
+copy file=${jtc.home}/procrun/bin/tomcat5.exe
+tofile=${tomcat.dist}/bin/tomcat4.exe /
+copy file=${jtc.home}/procrun/bin/tomcat5w.exe
+tofile=${tomcat.dist}/bin/tomcat4w.exe /
+
 filter token=VERSION value=${version}/
 copy file=tomcat.nsi tofile=${tomcat.dist}/tomcat.nsi 
  filtering=true/
@@ -339,7 +341,6 @@
 condition property=execute.installer
   and
 os family=windows /
-available file=${javaservice.home}/bin/JavaService.exe /
 available file=${nsis.home}/makensis.exe /
   /and
 /condition
@@ -505,11 +506,6 @@
 antcall target=downloadgz
   param name=sourcefile value=${commons-modeler.loc}/
   param name=destfile value=${commons-modeler.jar}/
-/antcall
-antcall target=downloadzip
-  param name=sourcefile value=${javaservice.loc}/
-  param name=destfile value=${javaservice.home}/bin/JavaService.exe/
-  param name=destdir value=${javaservice.home}/
 /antcall
 antcall target=downloadgz
   param name=sourcefile value=${jmx.loc}/

Modified: tomcat/container/branches/tc4.1.x/tomcat.nsi
URL: 
http://svn.apache.org/viewcvs/tomcat/container/branches/tc4.1.x/tomcat.nsi?rev=380807r1=380806r2=380807view=diff
==
--- tomcat/container/branches/tc4.1.x/tomcat.nsi (original)
+++ tomcat/container/branches/tc4.1.x/tomcat.nsi Fri Feb 24 12:19:46 2006
@@ -7,13 +7,15 @@
 OutFile tomcat4.exe
 CRCCheck on
 SetCompress force
-SetCompressor lzma

Re: Using APR with tomcat leaves port 8009 bound when tomcat is terminated?

2006-02-24 Thread William A. Rowe, Jr.

Jim Jagielski wrote:


On Feb 23, 2006, at 11:53 AM, Remy Maucherat wrote:


Jim Jagielski wrote:


I agree that the change is a big benefit, and for
most OSs we care about, SO_REUSEADDR is available.
The APR call should gracefully fail...
I'll plug this in later on today after some edge-case tests.



In AprEndpoint, there are a lot of Socket.optSet(serverSock,  
Socket.APR_SO_REUSEADDR, 1);




Yes, the only rub is that for reasons I'm trying to remind myself
why, we do the setting before the bind under non-Windows, and
afterwards on Windows...


If you SO_REUSEADDR before on win32, you will share any existing port
that's previously opened by any other application.  Not cool :)

Bill

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: never say never...

2006-02-24 Thread William A. Rowe, Jr.

Glen Mazza wrote:

Haroon Rafique wrote:


On Tuesday at 12:54pm, JB=Jay Burgess [EMAIL PROTECTED] wrote:

JB The following comments are not intended to be a personal attack on 
JB anyone. However, I can't stand by and watch George speak my mind 
for JB me, word for word, and not chime in and say I agree!.  Plus, 
I think JB if you took a poll, you'd find he speaks for a large 
number of list JB subcribers.


Yes Jay, other members have that feeling too. If we take a look at the 
recent past, there are various examples of rudeness, impropriety and 
lack of respect.


Well, my sympathies are more with the Tomcat developer team, given the 
abuse they incur from certain unfortunate individuals in the user 
community.


You mean by the same unfortunate individuals who like to abuse their
checkout clerk, bank teller and doctor's receptionist?  Odd, they tend
to excuse themselves that they are paying for that privilage; Funny
I don't recall seeing a donation check from them to the ASF.

Bill

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Using APR with tomcat leaves port 8009 bound when tomcat is terminated?

2006-02-24 Thread William A. Rowe, Jr.

D'OH!!!

Why doesn't this become an apr_sockattr element to the apr_socket_create
or apr_socket_bind call, so that APR determines the before/after thingy?

One side note, you setopt *after* the bind if you want to know you are
the absolute owner of the socket.  you setopt *before* the bind on win32
if you know your app owns the socket and now you want to add additional
listeners (processes) to pay attention to it.  Dunno how we could map this
all that cleanly.

Bill

William A. Rowe, Jr. wrote:

Jim Jagielski wrote:


On Feb 23, 2006, at 11:53 AM, Remy Maucherat wrote:


Jim Jagielski wrote:


I agree that the change is a big benefit, and for
most OSs we care about, SO_REUSEADDR is available.
The APR call should gracefully fail...
I'll plug this in later on today after some edge-case tests.




In AprEndpoint, there are a lot of Socket.optSet(serverSock,  
Socket.APR_SO_REUSEADDR, 1);




Yes, the only rub is that for reasons I'm trying to remind myself
why, we do the setting before the bind under non-Windows, and
afterwards on Windows...



If you SO_REUSEADDR before on win32, you will share any existing port
that's previously opened by any other application.  Not cool :)

Bill

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


.




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 38776] - Jsp generated servlet classes have bad SourceFile attribute

2006-02-24 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=38776.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38776


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2006-02-24 22:59 ---
Please check https://bugs.eclipse.org/bugs/show_bug.cgi?id=129383#c5.
This comment suggests a fix for the org.apache.jasper.compiler.JDTCompiler 
class.
Once I fixed it following comment 5, I got the expected result.
See https://bugs.eclipse.org/bugs/show_bug.cgi?id=129383#c9.

Let me know if there is anything I can do to help.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 38776] - Jsp generated servlet classes have bad SourceFile attribute

2006-02-24 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=38776.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38776





--- Additional Comments From [EMAIL PROTECTED]  2006-02-24 23:01 ---
Thank you Olivier!

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 38740] - (5.5.15) session attributes set in sessionCreated not synched

2006-02-24 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=38740.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38740


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|INVALID |




--- Additional Comments From [EMAIL PROTECTED]  2006-02-24 23:10 ---
actually, the session code looks broken. resetDeltaRequest shoult NOT be called
inside DeltaManager.createSession, and it should not be called inside
DeltaManager.sendCreateSession

resetDeltaRequest is called inside the DeltaSession constructor. That is good
enough.



-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r380835 - /tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/session/DeltaManager.java

2006-02-24 Thread fhanik
Author: fhanik
Date: Fri Feb 24 14:19:22 2006
New Revision: 380835

URL: http://svn.apache.org/viewcvs?rev=380835view=rev
Log:
Fix for bug 
http://issues.apache.org/bugzilla/show_bug.cgi?id=38740
looks like we got trigger happy with the resetDeltaRequest
Thanks to Nick Wesselman and Rainer Jung that pointed this out.


Modified:

tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/session/DeltaManager.java

Modified: 
tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/session/DeltaManager.java
URL: 
http://svn.apache.org/viewcvs/tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/session/DeltaManager.java?rev=380835r1=380834r2=380835view=diff
==
--- 
tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/session/DeltaManager.java
 (original)
+++ 
tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/session/DeltaManager.java
 Fri Feb 24 14:19:22 2006
@@ -605,7 +605,6 @@
 }
 
 DeltaSession session = (DeltaSession) super.createSession(sessionId) ;
-session.resetDeltaRequest();
 if (distribute) {
 sendCreateSession(session.getId(), session);
 }
@@ -633,7 +632,6 @@
 counterSend_EVT_SESSION_CREATED++;
 send(msg);
 }
-session.resetDeltaRequest();
 }
 
 /**



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 38233] - StringIndexOutOfBounds using request dispatcher

2006-02-24 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=38233.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38233


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2006-02-24 23:42 ---
Fixed in 5.5 tree

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r380870 - in /tomcat/container/tc5.5.x/modules: groupcom/src/share/org/apache/catalina/cluster/ groupcom/src/share/org/apache/catalina/cluster/demos/ groupcom/src/share/org/apache/catalina

2006-02-24 Thread fhanik
Author: fhanik
Date: Fri Feb 24 15:56:03 2006
New Revision: 380870

URL: http://svn.apache.org/viewcvs?rev=380870view=rev
Log:
Compiles correctly

Added:

tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/cluster/Channel.java
  - copied, changed from r380865, 
tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/cluster/ClusterChannel.java

tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/cluster/ChannelMessage.java
  - copied, changed from r380865, 
tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/cluster/ClusterMessage.java

tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/cluster/ChannelReceiver.java
  - copied, changed from r380865, 
tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/cluster/ClusterReceiver.java

tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/cluster/ChannelSender.java
  - copied, changed from r380865, 
tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/cluster/ClusterSender.java
Removed:

tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/cluster/ClusterChannel.java

tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/cluster/ClusterMessage.java

tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/cluster/ClusterReceiver.java

tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/cluster/ClusterSender.java
Modified:

tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/cluster/ChannelInterceptor.java

tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/cluster/MessageListener.java

tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/cluster/demos/Draw.java

tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/cluster/group/ChannelCoordinator.java

tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/cluster/group/ChannelInterceptorBase.java

tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/cluster/group/GroupChannel.java

tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/cluster/group/interceptors/GzipInterceptor.java

tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/cluster/io/XByteBuffer.java

tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/cluster/tcp/DataSender.java

tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/cluster/tcp/ReplicationListener.java

tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/cluster/tcp/ReplicationTransmitter.java

tomcat/container/tc5.5.x/modules/ha/src/share/org/apache/catalina/cluster/CatalinaCluster.java

tomcat/container/tc5.5.x/modules/ha/src/share/org/apache/catalina/cluster/ClusterListener.java

tomcat/container/tc5.5.x/modules/ha/src/share/org/apache/catalina/cluster/ClusterRuleSet.java

tomcat/container/tc5.5.x/modules/ha/src/share/org/apache/catalina/cluster/session/DeltaManager.java

tomcat/container/tc5.5.x/modules/ha/src/share/org/apache/catalina/cluster/tcp/SimpleTcpCluster.java

Copied: 
tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/cluster/Channel.java
 (from r380865, 
tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/cluster/ClusterChannel.java)
URL: 
http://svn.apache.org/viewcvs/tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/cluster/Channel.java?p2=tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/cluster/Channel.javap1=tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/cluster/ClusterChannel.javar1=380865r2=380870rev=380870view=diff
==
--- 
tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/cluster/ClusterChannel.java
 (original)
+++ 
tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/cluster/Channel.java
 Fri Feb 24 15:56:03 2006
@@ -22,7 +22,7 @@
  * @author Filip Hanik
  * @version $Revision: 304032 $, $Date: 2005-07-27 10:11:55 -0500 (Wed, 27 Jul 
2005) $
  */
-public interface ClusterChannel {
+public interface Channel {
 
 /**
  * Start and stop sequences can be controlled by these constants
@@ -72,11 +72,11 @@
  * @param options int - sender options, see class documentation
  * @return ClusterMessage[] - the replies from the members, if any. 
  */
-public ClusterMessage[] send(Member[] destination, ClusterMessage msg, int 
options) throws ChannelException;
+public ChannelMessage[] send(Member[] destination, ChannelMessage msg, int 
options) throws ChannelException;
 
 
-public void setClusterSender(ClusterSender sender);
-public void 

Re: svn commit: r380835 -/tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/session/DeltaManager.java

2006-02-24 Thread Rainer Jung

Hi Filip,

I did a little exercise with Java 6 and Solaris DTrace.

The change is in fact OK, although I first thought that the DeltaRequest 
will no longer be initialized:


DeltaManager.createSession() calls

   ManagerBase.createSession()

which in turns calls

  DeltaManager.createEmptySession()
 DeltaManager.getNewDeltaSession()
DeltaSession.init()
   DeltaSession.resetDeltaRequest()

So the DeltaRequest still gets initialized correctly :)

Thanks

Rainer

[EMAIL PROTECTED] wrote:

Author: fhanik
Date: Fri Feb 24 14:19:22 2006
New Revision: 380835

URL: http://svn.apache.org/viewcvs?rev=380835view=rev
Log:
Fix for bug 
http://issues.apache.org/bugzilla/show_bug.cgi?id=38740

looks like we got trigger happy with the resetDeltaRequest
Thanks to Nick Wesselman and Rainer Jung that pointed this out.


Modified:

tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/session/DeltaManager.java

Modified: 
tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/session/DeltaManager.java
URL: 
http://svn.apache.org/viewcvs/tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/session/DeltaManager.java?rev=380835r1=380834r2=380835view=diff
==
--- 
tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/session/DeltaManager.java
 (original)
+++ 
tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/session/DeltaManager.java
 Fri Feb 24 14:19:22 2006
@@ -605,7 +605,6 @@
 }
 
 DeltaSession session = (DeltaSession) super.createSession(sessionId) ;

-session.resetDeltaRequest();
 if (distribute) {
 sendCreateSession(session.getId(), session);
 }
@@ -633,7 +632,6 @@
 counterSend_EVT_SESSION_CREATED++;
 send(msg);
 }
-session.resetDeltaRequest();
 }
 
 /**




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 38740] - (5.5.15) session attributes set in sessionCreated not synched

2006-02-24 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=38740.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38740


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|NEEDINFO




--- Additional Comments From [EMAIL PROTECTED]  2006-02-25 01:37 ---
Nick,

Filip made a change. Are you able to check with the DeltaManager from trunk?

The new version should replicate your foo attribute as set by the listener on
the primary side. Your listener will also be called by default on the remote
side (and set the attribute), but it will afterwards be overwritten by the
replicated attribute. You could check by setting the attribute foo to a
timestamp instead of bar.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: never say never...

2006-02-24 Thread Wade Chandler
--- William A. Rowe, Jr. [EMAIL PROTECTED]
wrote:

 Glen Mazza wrote:
  Haroon Rafique wrote:
  
  On Tuesday at 12:54pm, JB=Jay Burgess
 [EMAIL PROTECTED] wrote:
 
  JB The following comments are not intended to be
 a personal attack on 
  JB anyone. However, I can't stand by and watch
 George speak my mind 
  for JB me, word for word, and not chime in and
 say I agree!.  Plus, 
  I think JB if you took a poll, you'd find he
 speaks for a large 
  number of list JB subcribers.
  
  Yes Jay, other members have that feeling too. If
 we take a look at the 
  recent past, there are various examples of
 rudeness, impropriety and 
  lack of respect.
  
  Well, my sympathies are more with the Tomcat
 developer team, given the 
  abuse they incur from certain unfortunate
 individuals in the user 
  community.
 
 You mean by the same unfortunate individuals who
 like to abuse their
 checkout clerk, bank teller and doctor's
 receptionist?  Odd, they tend
 to excuse themselves that they are paying for that
 privilage; Funny
 I don't recall seeing a donation check from them to
 the ASF.
 
 Bill
I thought about not even writing this.  Then I thought
about not even submitting it.  Don't take it
personally how ever it hits anyone.  I think it's
fair.

I think it runs both ways.  I think most of the Tomcat
developers are really great.  I think an unnamed
developer could learn how to be a little nicer.  I
think a good number of users could as well.  There is
no good excuse for simply being mean and nasty for
users nor developers.

Without mentioning any names: If one could see a list
of what contracts and monetary connections are made
through the Apache project for certain members they
would see some things a little differently, and I do
not mean that any of the developers deserve to be
yelled at or belittled.  For instance, I'm sure a few
JBoss customers might find a couple of bugs and
comments associated with them a little disturbing.  I
would imagine a few other commercial customers of
other companies using projects based on Tomcat would
as well.  This based on my own experiences with aiding
in explaining a couple of issues found in Tomcat. 
Some things do not require arguing about.  They simply
need to be looked at and egos need not get in the way.

So, not to kick up the flames, just being real;  I
don't think it is as black and white as some people
would like to believe in relation to volunteering
hours to the project vs being compensated.  The same
can be said about Eclipse, Netbeans, etc.  Many
projects today have incorporated corporate interests
into their ranks (whether it's admitted or not). 
Companies employ people to work on these projects, so
they aren't doing it for free.  Others are
contributing their time to also utilize others time
and selling products based on these open source
projects and making a good amount of money doing so. 
Then some 3rd party softwares based on these solutions
are bought by users.  The company they purchased their
software from spends money in donations or contributes
developers to the projects.  Money = Time and Time =
Money.  Lets face it, if these companies were not
making money from from these open source projects they
would not be contributing.  They like the collective
free time and work, which is also why many contribute
to projects.  Others contribute in their free time one
way or another mostly just for fun.

Anyways, many thanks to the Tomcat developers.  I
think almost every one of them are really great guys.

Wade

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]